Repository navigation
Conversation
Background from thiemowmde: "chemist" is heavily ambiguous. Could be a science lab on a campus. Could be an industrial site. Could be an alternative for a pharmacy. A quick image search leaves the impression that no country uses a test glass to represent a pharmacy. The Maki 2 announcement mentions Noun Project as inspiration. Searching that for "chemist" and "pharmacy" doesn't make the situation much clearer. The patch that added the icon associates it with many different things. dewikivoyage translates it as "Drogerie". A Maki 2 issue from 2016 associates it with "pharmacy". There are many possible replacements for "minefield", e.g. "barrier" or "caution". "danger" felt most appropriate. "london-underground", "rail-above" and "rail-underground" become "rail". I couldn't find a better alternative.
The old (maki 0.5.0) icons were rendered with a large margin which is wasted space in a bitmap. Instead, this patch renders the full 15x15 (units) new icons in smaller boxes with no margin. Exact sizes were chosen such that new icons are roughly congruent to the old ones. There is a slight savings in the number of bits for each image. Includes a few more symbols.
This still builds static PNGs to serve, but the source step is done by a script. No longer paints a stroke around glyphs, to match the new Maki style guidelines.
This was going to be used for "chemist", mapping it to the blank pin by giving it a target icon of "", but we might not do so. Now the code is at least organized to make such a thing possible in the future.
…a threshold This makes the symbol visible on light backgrounds.
Was missing a color space conversion. The resulting formula has been checked against other references.
Calculate the luminance threshold dynamically, improving code maintainability in case we need to change the color again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.