Thanks! Agreed, it looks like the design is no longer using tables.

Test wiki on Patch demo by BMartinezCalvo (WMF) using patch(es) linked to this task was deleted by Catalyst admin via Cron DeleteExpiredWikis:

"How this suggestion is configured" sounds good.

Indeed, that is much simpler! (and simpler for purely read-only cases like Attribution API where they want to show the number of references on the page the user is reading!)

Currently, when a user clicks Edit on a page with an unstable revision, they start editing the version of the page after that change, not the version they were reading. I think following that logic probably makes the most sense, in which case suggestions would be computed based on the latest revision ID rather than the latest stable revision ID. That also, helpfully, seems like the simple/consistent option, rather than requiring special logic for FlaggedRevs.

hey @ppelberg , thanks for providing the expected due date.

Could it be though? If you can move the .js config to MW config, and mv the on-wiki page config parsing to PHP, you could provide the parsed config to the page load and use it in VE?

Technically it could, but it runs up against...

Oh. gadgets can change config?

Yes, though it's more that gadgets can create checks. The primary route to a community implementing their own wiki-specific check would be to make them as default-gadgets, which would just register checks when the visualeditor starts up. Because editcheck-headless loads a page, it'll include counts for anything registered this way.

This isn't the code that's used client-side to decide whether to show a check. Behavioral drift is a risk.

Could it be though? If you can move the .js config to MW config, and mv the on-wiki page config parsing to PHP, you could provide the parsed config to the page load and use it in VE?

Q: is editcheck-headless lambda reachable over HTTP like this? Will you need extra service mesh routing to get to it?

I did a little bit of digging into this, and I'm pretty certain we'd need to set up new mesh routing for it. I don't think we can use the existing gRPC listener from PHP, so we'd need to create a new route to access the /config endpoint directly from a mediawiki server.

Oh interesting! So no LAC artifact caching! Just fetching from editcheck-headless directly and storing in MW caches. Fine with me, no new data storage to think about outside of MW.

FYI, patches are in for T443442: Edit Suggestion Counts - use LinkedArtifacts config. Once deployed, you will be able to fetch edit_suggestions_counts from LAC using the EventBus.LinkedArtifactsClient MW service.

Meta

• 1. @ppelberg to draft story for ticket
• 2. @DLynch to do code review on approach Ed implemented
• 3. In parallel to "2.", @Esanders to seek input from @Ottomata to ensure he is okay with the approach

Note that @Esanders has implemented fetching the config from editcheck-headless and filtering counts using it in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1308570

We talked about this: if we want the community to be able to set the default value for the preference, we think that setting up something via community config might work (not Editcheck-config.json, since that's very check-focused and applies to all checks). Note that if the community decide to switch the default value back and forth, this will eventually subsume people's preferences because of how the preferences system works (we only store non-default preferences).

@medelius Please review AC2, before I test the others. Thanks!

@medelius Before I test the others, can you please review AC1

If you click out of the paragraph, it will turn into the success state.