Re: Many of the example loadable builtins don't work anymore
From:
Emanuele Torre
Subject:
Re: Many of the example loadable builtins don't work anymore
Date:
Sat, 25 Nov 2023 19:32:44 +0100
User-agent:
Mutt/2.2.12 (2023-09-09)
On Sat, Nov 25, 2023 at 01:20:55PM -0500, Chet Ramey wrote:
> On 11/24/23 9:40 PM, Emanuele Torre wrote:
> > Many of the loadable builtins that set variables in the
> > examples/loadables directory don't work anymore because they still want
> > to call legal_identifier instead of valid_identifier.
>
> I haven't decided yet whether to use lib/sh/compat.c, in which case I'll
> add a call to init_compat() into main() so the linker links that file
> into libsh.a, or use some other mechanism like creating libloadables.a.
> The former is better for third-party loadable builtins in that it
> doesn't require rebuilding; the latter is a more general approach that
> requires more changes to the loadables build process. None of this stuff
> has been released yet anyway.
I see.
> In any event, thanks for pointing out where the examples still need to
> change.
No problem. :)
I also noticed that examples/loadables/strptime is not in .gitignore.
o/
emanuele6