bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] _rl_isearch_cleanup: avoid nested execution


From: penguin p
Subject: Re: [PATCH] _rl_isearch_cleanup: avoid nested execution
Date: Wed, 20 Aug 2025 17:45:42 +0000

>  https://cgit.git.savannah.gnu.org/cgit/bash.git/?h=devel

Sorry, I am not able to build using the Mac, so I go into arch linux then build 
and tested over there.

I pressed so hard I got this error
```
This is workbench@ArchLinux: ~/works/bash
$ ^C
This is workbench@ArchLinux: ~/works/bash
$ ^C
This is workbench@ArchLinux: ~/works/bash
=================================================================
==1078506==ERROR: AddressSanitizer: heap-use-after-free on address 
0x7c315f7e217c at pc 0x55bc1d03b545 bp 0x7ffdbdb3c920 sp 0x7ffdbdb3c910
WRITE of size 4 at 0x7c315f7e217c thread T0
    #0 0x55bc1d03b544 in _rl_search_getchar 
/home/arch/works/bash/lib/readline/isearch.c:322
    #1 0x55bc1d0412ed in rl_search_history 
/home/arch/works/bash/lib/readline/isearch.c:927
    #2 0x55bc1d03a526 in rl_reverse_search_history 
/home/arch/works/bash/lib/readline/isearch.c:135
    #3 0x55bc1d0098f4 in _rl_dispatch_subseq 
/home/arch/works/bash/lib/readline/readline.c:941
    #4 0x55bc1d00949c in _rl_dispatch 
/home/arch/works/bash/lib/readline/readline.c:876
    #5 0x55bc1d008946 in readline_internal_char 
/home/arch/works/bash/lib/readline/readline.c:690
    #6 0x55bc1d008d6a in readline_internal_charloop 
/home/arch/works/bash/lib/readline/readline.c:737
    #7 0x55bc1d008d8a in readline_internal 
/home/arch/works/bash/lib/readline/readline.c:749
    #8 0x55bc1d007ce3 in readline 
/home/arch/works/bash/lib/readline/readline.c:387
    #9 0x55bc1ce3773a in yy_readline_get parse.y:1679
    #10 0x55bc1ce37598 in yy_getc parse.y:1609
    #11 0x55bc1ce39e1a in shell_getc parse.y:2558
    #12 0x55bc1ce3d89e in read_token parse.y:3637
    #13 0x55bc1ce3c04c in yylex parse.y:3103
    #14 0x55bc1ce2bf7a in yyparse /home/arch/works/bash/y.tab.c:1912
    #15 0x55bc1ce2ad81 in parse_command /home/arch/works/bash/eval.c:369
    #16 0x55bc1ce2b01f in read_command /home/arch/works/bash/eval.c:414
    #17 0x55bc1ce29921 in reader_loop /home/arch/works/bash/eval.c:147
    #18 0x55bc1ce249a8 in main /home/arch/works/bash/shell.c:834
    #19 0x7f4160a27674  (/usr/lib/libc.so.6+0x27674) (BuildId: 
4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)
    #20 0x7f4160a27728 in __libc_start_main (/usr/lib/libc.so.6+0x27728) 
(BuildId: 4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)
    #21 0x55bc1ce230f4 in _start (/home/arch/works/bash/bash+0x9d0f4) (BuildId: 
2356e6193d630762321a443eb53c2878d4724eac)

0x7c315f7e217c is located 108 bytes inside of 168-byte region 
[0x7c315f7e2110,0x7c315f7e21b8)
freed by thread T0 here:
    #0 0x7f4160f1f79d in free 
/usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:51
    #1 0x55bc1cf79e73 in xfree /home/arch/works/bash/xmalloc.c:153
    #2 0x55bc1d03a502 in _rl_scxt_dispose 
/home/arch/works/bash/lib/readline/isearch.c:127
    #3 0x55bc1d0411c1 in _rl_isearch_cleanup 
/home/arch/works/bash/lib/readline/isearch.c:899
    #4 0x55bc1d0547af in _rl_state_sigcleanup 
/home/arch/works/bash/lib/readline/signals.c:599
    #5 0x55bc1d0548d6 in rl_free_line_state 
/home/arch/works/bash/lib/readline/signals.c:616
    #6 0x55bc1d0536f4 in _rl_handle_signal 
/home/arch/works/bash/lib/readline/signals.c:221
    #7 0x55bc1d05352e in _rl_signal_handler 
/home/arch/works/bash/lib/readline/signals.c:152
    #8 0x55bc1d05edab in rl_read_key 
/home/arch/works/bash/lib/readline/input.c:829
    #9 0x55bc1d03b506 in _rl_search_getchar 
/home/arch/works/bash/lib/readline/isearch.c:322
    #10 0x55bc1d0412ed in rl_search_history 
/home/arch/works/bash/lib/readline/isearch.c:927
    #11 0x55bc1d03a526 in rl_reverse_search_history 
/home/arch/works/bash/lib/readline/isearch.c:135
    #12 0x55bc1d0098f4 in _rl_dispatch_subseq 
/home/arch/works/bash/lib/readline/readline.c:941
    #13 0x55bc1d00949c in _rl_dispatch 
/home/arch/works/bash/lib/readline/readline.c:876
    #14 0x55bc1d008946 in readline_internal_char 
/home/arch/works/bash/lib/readline/readline.c:690
    #15 0x55bc1d008d6a in readline_internal_charloop 
/home/arch/works/bash/lib/readline/readline.c:737
    #16 0x55bc1d008d8a in readline_internal 
/home/arch/works/bash/lib/readline/readline.c:749
    #17 0x55bc1d007ce3 in readline 
/home/arch/works/bash/lib/readline/readline.c:387
    #18 0x55bc1ce3773a in yy_readline_get parse.y:1679
    #19 0x55bc1ce37598 in yy_getc parse.y:1609
    #20 0x55bc1ce39e1a in shell_getc parse.y:2558
    #21 0x55bc1ce3d89e in read_token parse.y:3637
    #22 0x55bc1ce3c04c in yylex parse.y:3103
    #23 0x55bc1ce2bf7a in yyparse /home/arch/works/bash/y.tab.c:1912
    #24 0x55bc1ce2ad81 in parse_command /home/arch/works/bash/eval.c:369
    #25 0x55bc1ce2b01f in read_command /home/arch/works/bash/eval.c:414
    #26 0x55bc1ce29921 in reader_loop /home/arch/works/bash/eval.c:147
    #27 0x55bc1ce249a8 in main /home/arch/works/bash/shell.c:834
    #28 0x7f4160a27674  (/usr/lib/libc.so.6+0x27674) (BuildId: 
4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)
    #29 0x7f4160a27728 in __libc_start_main (/usr/lib/libc.so.6+0x27728) 
(BuildId: 4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)

previously allocated by thread T0 here:
    #0 0x7f4160f20cb5 in malloc 
/usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:67
    #1 0x55bc1cf79c24 in xmalloc /home/arch/works/bash/xmalloc.c:104
    #2 0x55bc1d039d72 in _rl_scxt_alloc 
/home/arch/works/bash/lib/readline/isearch.c:84
    #3 0x55bc1d03a77f in _rl_isearch_init 
/home/arch/works/bash/lib/readline/isearch.c:212
    #4 0x55bc1d041219 in rl_search_history 
/home/arch/works/bash/lib/readline/isearch.c:915
    #5 0x55bc1d03a526 in rl_reverse_search_history 
/home/arch/works/bash/lib/readline/isearch.c:135
    #6 0x55bc1d0098f4 in _rl_dispatch_subseq 
/home/arch/works/bash/lib/readline/readline.c:941
    #7 0x55bc1d00949c in _rl_dispatch 
/home/arch/works/bash/lib/readline/readline.c:876
    #8 0x55bc1d008946 in readline_internal_char 
/home/arch/works/bash/lib/readline/readline.c:690
    #9 0x55bc1d008d6a in readline_internal_charloop 
/home/arch/works/bash/lib/readline/readline.c:737
    #10 0x55bc1d008d8a in readline_internal 
/home/arch/works/bash/lib/readline/readline.c:749
    #11 0x55bc1d007ce3 in readline 
/home/arch/works/bash/lib/readline/readline.c:387
    #12 0x55bc1ce3773a in yy_readline_get parse.y:1679
    #13 0x55bc1ce37598 in yy_getc parse.y:1609
    #14 0x55bc1ce39e1a in shell_getc parse.y:2558
    #15 0x55bc1ce3d89e in read_token parse.y:3637
    #16 0x55bc1ce3c04c in yylex parse.y:3103
    #17 0x55bc1ce2bf7a in yyparse /home/arch/works/bash/y.tab.c:1912
    #18 0x55bc1ce2ad81 in parse_command /home/arch/works/bash/eval.c:369
    #19 0x55bc1ce2b01f in read_command /home/arch/works/bash/eval.c:414
    #20 0x55bc1ce29921 in reader_loop /home/arch/works/bash/eval.c:147
    #21 0x55bc1ce249a8 in main /home/arch/works/bash/shell.c:834
    #22 0x7f4160a27674  (/usr/lib/libc.so.6+0x27674) (BuildId: 
4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)
    #23 0x7f4160a27728 in __libc_start_main (/usr/lib/libc.so.6+0x27728) 
(BuildId: 4fe011c94a88e8aeb6f2201b9eb369f42b4a1e9e)
    #24 0x55bc1ce230f4 in _start (/home/arch/works/bash/bash+0x9d0f4) (BuildId: 
2356e6193d630762321a443eb53c2878d4724eac)

SUMMARY: AddressSanitizer: heap-use-after-free 
/home/arch/works/bash/lib/readline/isearch.c:322 in _rl_search_getchar
Shadow bytes around the buggy address:
  0x7c315f7e1e80: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa
  0x7c315f7e1f00: fa fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd
  0x7c315f7e1f80: fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa fa
  0x7c315f7e2000: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c315f7e2080: fd fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa
=>0x7c315f7e2100: fa fa fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]
  0x7c315f7e2180: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
  0x7c315f7e2200: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7c315f7e2280: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7c315f7e2300: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7c315f7e2380: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==1078506==ABORTING
```

Command I used to build
```
$ git rev-parse HEAD
086456835944d1a3098a026646144573deafc917
$ ./configure -C --without-bash-malloc CFLAGS='-g -O0 -fsanitize=address 
-fno-omit-frame-pointer -fno-optimize-sibling-calls'
$ make -j
$ ./bash --norc
```

Also core.bash.1075255 is generated. Please refer to the attachment.

The error I got building from mac
```
penguin@macstudio bash % make -j
bison -y -d ./parse.y
rm -f lsignames.h
rm -f syntax.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"aarch64"' 
-DCONF_OSTYPE='"darwin24.6.0"' -DCONF_MACHTYPE='"aarch64-apple-darwin24.6.0"' 
-DCONF_VENDOR='"apple"' -DLOCALEDIR='"/usr/local/share/locale"' 
-DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H -DMACOSX -DDEBUG -DMALLOC_DEBUG -I.  
-I. -I./include -I./lib -I./lib/intl -I/Users/penguin/works/bash/lib/intl    -g 
-O0 -fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls -c 
syntax.c
./mksignames lsignames.h
rm -f copy_cmd.o
rm -f flags.o
rm -f hashcmd.o
./parse.y:501.23-27: symbol YYEOF is used, but is not defined as a token and 
has no rules
rm -f hashlib.o
make: *** [y.tab.c] Error 1
...
```

Regards.

Attachment: core.bash.1075255
Description: core.bash.1075255


reply via email to

[Prev in Thread] Current Thread [Next in Thread]