bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] command substitution with trailing newlines (was Re: [PATCH]


From: Koichi Murase
Subject: Re: [PATCH] command substitution with trailing newlines (was Re: [PATCH] Add shopts for ...)
Date: Thu, 18 Sep 2025 23:09:11 +0900

2025年8月29日(金) 20:16 Kevin Pulo <kevin.pulo@mongodb.com>:
> This patch adds the syntax ${;cmd;}, which is handled identically to ${ cmd;}
> except that trailing newlines are preserved.

I've checked the contents of the patch. Maybe it's already been
applied to the codebase with adjustments, but shouldn't the
keep-trailing-newlines flag be passed to read_comsub() through the
existing parameter "flags" (with a new macro such as #define
PF_COMSUB_KEEPNEWLINES 0x100) instead of a new parameter "keep_nls"?
Anyway, I'm not requesting to submit a new patch because I think Chet
will adjust this patch in a way he thinks is proper.

--
Koichi



reply via email to

[Prev in Thread] Current Thread [Next in Thread]