bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add missing #include <errno.h> to winsize.c


From: Chet Ramey
Subject: Re: [PATCH] Add missing #include <errno.h> to winsize.c
Date: Thu, 13 Nov 2025 09:14:15 -0500
User-agent: Mozilla Thunderbird

On 11/13/25 8:23 AM, andrew@andrewoates.com wrote:
From: Andrew Oates <andrew@andrewoates.com>

A better approach might be to put this in externs.h, guarded with
HAVE_ERRNO_H, and put the extern int errno declaration there as well.
However many other files do this pattern (unconditionally include
<errno.h> and declare extern int errno), so just using that pattern
here as well.

This is the only instance where we declare extern int errno but _don't_
include <errno.h> that I can find in the codebase.

Thanks for the report.

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]