Re: [PATCH] cp --reflink: preserve attributes on the cloned file if aske
From:
PƔdraig Brady
Subject:
Re: [PATCH] cp --reflink: preserve attributes on the cloned file if asked
Date:
Wed, 26 Aug 2009 11:04:30 +0100
User-agent:
Thunderbird 2.0.0.6 (X11/20071008)
Jim Meyering wrote:
> PƔdraig Brady wrote:
>> I think we need to preserve meta data also for cloned files,
>> as in the attached patch? The patch is mostly indentation changes
>> and I've copied the only interesting bit below.
>
> Good point!
> At first glance, the patch looks ok, but it'd be even better if
> it included a test to exercise the bug and demonstrate the fix.
I'll add tests for these.
It's not helped by my laptop going AWOL as soon as I touch BTRFS,
but I'll update my kernel first and have another go.
cheers,
PƔdraig.