bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#79095: [PATCH] test: removed dead code for unrecognised binary opera


From: Collin Funk
Subject: bug#79095: [PATCH] test: removed dead code for unrecognised binary operators
Date: Sat, 26 Jul 2025 00:26:21 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

Hi Paul,

Paul Eggert <eggert@cs.ucla.edu> writes:

> +    case NT_BINOP: case OT_BINOP:
> +      {
> +        if (l_is_l | r_is_l)
> +          test_syntax_error (_("%s does not accept -l"), argv[op]);

This causes 'make syntax-check' to fail with the following:

     error_quotes
     test.c:332:          test_syntax_error (_("%s does not accept -l"), 
argv[op]);
     maint.mk: Use quote() for error string arguments
     make: *** [cfg.mk:204: sc_error_quotes] Error 1

Using quote would be incorrect here, since we still have the following
message without quotes:

    test_syntax_error (_("-ef does not accept -l"));

I pushed the attached patch to fix it. We can just place the argument on
another line.

Collin

Attachment: 0001-maint-avoid-syntax-check-failure-from-previous-commi.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]