bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#79118: CI test failures


From: Collin Funk
Subject: bug#79118: CI test failures
Date: Thu, 31 Jul 2025 22:06:15 -0700
User-agent: Gnus/5.13 (Gnus v5.13)

tags 79118 fixed
close 79118
stop

Collin Funk <collin.funk1@gmail.com> writes:

> Bruno Haible <bruno@clisp.org> writes:
>
>> There are basically two ways to fix this:
>>   (a) set the appropriate environment variables (instead of setlocale calls),
>>   (b) add an nstrftime_l and fprintftime_l variant and pass a locale that
>>       has "C" for the LC_TIME category.
>>
>> (b) is more hairy, when it comes to the "underlying strftime" delegation in
>> gnulib/lib/strftime.c.
>>
>> Therefore here is a proposed fix according to (a). It fixes the test failures
>> on macOS and OpenBSD. It also passes "make syntax-check".
>
> Thanks for the patch. Interestingly, it passes macOS (cfarm104) but
> fails on my OpenBSD VM.
>
> Let me investigate some more...

False alarm. The Gnulib submodule did not have the nstrftime and
nstrftime-limited change you recently committed. This means that on
OpenBSD 'SUPPORT_NON_GREG_CALENDARS_IN_STRFTIME' was false.

I pushed a commit to update that and then pushed your patch, with very
minor adjustments to the commit message to make it consistent with
Coreutils.

Thanks again for the help with this.

Collin





reply via email to

[Prev in Thread] Current Thread [Next in Thread]