|
| From: | Paul Eggert |
| Subject: | bug#79267: cp --sparse=auto heuristic fails on a squashfs mounted drive. |
| Date: | Fri, 22 Aug 2025 18:48:31 -0600 |
| User-agent: | Mozilla Thunderbird |
On 8/22/25 07:04, Pádraig Brady wrote:
     /* Copy this extent, looking for further opportunities to not         bother to write zeros if --sparse=always, since SEEK_HOLE         is conservative and may miss some holes. */ So the comment needs to be tweaked, but a more general issue is that it disables copy offloading (copy_file_range) for sparse files.
Ouch, I didn't see that. That's a real loss. I installed the first attached patch to revert that part of my recent change.
I assume the part of the change that always punches holes is OK. I couldn't see why one would not want to punch a hole if one has already taken the trouble to find and create the hole.
BTW commit 26bf557 also changed this a couple of weeks agowithout updating the comment, so the comment relates to sparse_mode != SPARSE_ALWAYS.
Not quite following but I hope the comment is OK now with the first patch installed.
squashfs is giving the wrong info here after all, right?
Yes, that's the actual space-performance bug here. I installed the second attached patch to try to work around it.
Jeremy, can you please try these two further patches? Thanks.
0001-cp-go-back-to-copy_file_range-optimization.patch
Description: Text Data
0002-cp-improve-hole-handling-on-squashfs.patch
Description: Text Data
| [Prev in Thread] | Current Thread | [Next in Thread] |