|
| From: | Pádraig Brady |
| Subject: | bug#81413: [PATCH] install: skip chown/chmod when -C finds nothing to change |
| Date: | Wed, 15 Jul 2026 12:18:02 +0100 |
| User-agent: | Mozilla Thunderbird Beta |
On 14/07/2026 23:30, Mateusz Nosek wrote:
Hi, I attach a patch for the "install" utility: "install -C" was still calling chown/chmod on the destination even when need_copy() had already determined it matches (mode, owner, group, content), which could needlessly fail, e.g. on an immutable file. This is my first patch to coreutils, so apologies for any mistakes in the submission process -- happy to fix anything you point out.
This makes sense I think. You moved setdefaultfilecon() out of this consideration. I'd be inclined to leave it where it was and treat the same way, because the comparison also compares selinux context, and also if the file is already present it probably has an appropriate context anyway. thanks, Padraig
| [Prev in Thread] | Current Thread | [Next in Thread] |