|
| From: | Frank Hunleth |
| Subject: | [bug-gettext] [bug #55356] libcroco fails to build when gcc's format-security error is enabled |
| Date: | Tue, 1 Jan 2019 15:56:33 -0500 (EST) |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0 |
URL:
<https://savannah.gnu.org/bugs/?55356>
Summary: libcroco fails to build when gcc's format-security
error is enabled
Project: GNU gettext
Submitted by: fhunleth
Submitted on: Tue 01 Jan 2019 08:56:31 PM UTC
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
libcroco has several instances of using fprintf to print out arbitrary strings
using the second parameter. This causes the following compiler error when
-Werror=format-security is enabled:
libcroco/cr-statement.c:2610:17: error: format not a string literal and no
format arguments [-Werror=format-security]
fprintf (a_fp, str);
^~~~~~~
libcroco/cr-statement.c: In function 'cr_statement_dump_charset':
It looks like this was fixed upstream in the following commit:
https://github.com/GNOME/libcroco/commit/c7197cad42d6269739f379025c2bec9e474c8027.
Would it be possible to either pull this commit or resync to the latest
upstream libcroco?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55356>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |