Re: [coreutils] [PATCH 1/5] tests: factor out VERBOSE-only --version-pri
From:
Jim Meyering
Subject:
Re: [coreutils] [PATCH 1/5] tests: factor out VERBOSE-only --version-printing code
Date:
Thu, 18 Nov 2010 06:20:13 +0100
Pádraig Brady wrote:
> On 17/11/10 21:31, Jim Meyering wrote:
>> FYI, here are 5 change-sets to make a few hundred (mostly automated)
>> changes like these:
>>
>> -test "$VERBOSE" = yes && chown --version
>> +print_ver_ chown
>>
>> -test "$VERBOSE" = yes && { cp --version; mv --version; }
>> +print_ver_ cp mv
>>
>> -test "$VERBOSE" = yes && { env -- pwd --version; readlink --version; }
>> +print_ver_ pwd readlink
>
> A nice refactoring. Looks good.
Thanks. I pushed that.
BTW, I noticed (via a conflict) while looking at your split patch
that you corrected one of those (maybe involving "ln"?), so you too
will see the conflict when you rebase.
I realized only afterward that I still need to write
a syntax-check to prevent reintroduction of new uses like this:
test "$VERBOSE" = yes && ... --version