Re: [PATCH 6/6] tests: avoid spurious parallel failure due to temporary
From:
Pádraig Brady
Subject:
Re: [PATCH 6/6] tests: avoid spurious parallel failure due to temporary disk full
Date:
Mon, 04 Apr 2011 10:34:16 +0100
User-agent:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3
On 04/04/11 10:08, Jim Meyering wrote:
> Pádraig Brady wrote:
>> On 04/04/11 06:13, Jim Meyering wrote:
>>> From: Jim Meyering <address@hidden>
>>>
>>> Running the new fiemap-empty test uses 600MB of disk space via
>>> fallocate, and in so doing caused failure in unrelated tests that
>>> were running in parallel on a small file system. Rather than
>>> simply running fallocate (which allocates the space, inducing
>>> disk full when it fails), skip the test if there is less than
>>> 800MB of free space, as computed via stat and awk.
>
> Thanks for looking.
>
>> Oops sorry.
>> Maybe worth noting is that stat works at a lower level,
>
> Not sure what you mean? Both use statfs.
Oops right. df uses f_bavail, so perhaps it might
be better to use %a rather than %f with `stat`?
This fallocate() behavior is annoying anyway,
as I'm not sure when it's useful, except for
filling up a file system.
It seems like a this would be useful.
#define FALLOC_FL_FULL_SIZE 0x03 /* allocate all or nothing */
cheers,
Pádraig.