Re: [PATCH] tests: run expensive tests if RUN_VERY_EXPENSIVE_TESTS is 'y
From:
Bernhard Voelker
Subject:
Re: [PATCH] tests: run expensive tests if RUN_VERY_EXPENSIVE_TESTS is 'yes'
Date:
Thu, 08 Mar 2012 16:45:40 +0100
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2
On 03/08/2012 11:59 AM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> This patch helps in cases where a single, expensive test is run,
>> but only the RUN_VERY_EXPENSIVE_TESTS variable is there - the test
>> would be skipped. E.g.
>>
>>
>> ~/git/coreutils/tests> make check RUN_VERY_EXPENSIVE_TESTS=yes
>> TESTS=du/fd-leak
>> ...
>> fd-leak: skipped test: expensive: disabled by default
>> SKIP: du/fd-leak
>> ...
>
> Hi Berny,
>
> I deliberately chose to keep those categories separate.
> That is why README-release suggests to set both variables.
>
> If you want to run that test, you could just set RUN_EXPENSIVE_TESTS=yes.
> If you want to change the meaning of RUN_VERY_EXPENSIVE_TESTS=yes so
> that one does not also have to set RUN_EXPENSIVE_TESTS=yes to run all tests,
> then please change it everywhere.
Hi Jim,
thanks. The meaning has already diverged with my commit
57db1fc2a97add508d43cf163d2a5f4f381d2837
'make check-very-expensive' includes expensive checks:
+check-very-expensive:
+ $(MAKE) check-expensive RUN_VERY_EXPENSIVE_TESTS=yes
I'm okay if we leave it as it is.
Have a nice day,
Berny