Re: sc_tests_list_consistency failure when adding tests [was: df --outpu
From:
Bernhard Voelker
Subject:
Re: sc_tests_list_consistency failure when adding tests [was: df --output]
Date:
Fri, 21 Sep 2012 12:55:56 +0200
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0
On 09/21/2012 12:36 PM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> On 09/21/2012 12:15 PM, Jim Meyering wrote:
>>> Bernhard Voelker wrote:
>>> If you merely "git add" your new test script, that should be enough,
>>> since that test compares the list of VC'd files under tests/
>>> and the list of test file names.
>>>
>>> In other words, afaik, there is no problem.
>>
>> Right, but don't we need to add new tests to
>> tests/local.mk (all_tests) anymore?
>
> Not sure I understand the question, but I've just confirmed two things:
>
> if you git-add *and commit* (contrary to what I said above you do need
> to commit locally) a new tests/somewhere/*.sh (or .pl) file, but forget
> to list it in all_tests, then "make sc_tests_list_consistency" will
> point out the failure.
That was exactly my question:
there's currently no way of having a syntax-check passed _before_ you
do the actual commit. I don't feel much comfortable with that: I used
to use syntax-check to assure that all I'm planning to commit is okay,
but now, this can only be assured afterwards.