Re: [PATCH] tests: document CMP/PRE/POST in unit test module
From:
Assaf Gordon
Subject:
Re: [PATCH] tests: document CMP/PRE/POST in unit test module
Date:
Tue, 02 Apr 2013 12:11:43 -0400
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4
Thanks for the quick reply.
Here's a better patch.
Bernhard Voelker wrote, On 04/02/2013 04:03 AM:
> s/PRE,POST/PRE, POST
> due to the line length it may be worth adding a line break.
Done. Also added IN_PIPE .
> Close square brackets, and move blank character to after the comma:
Done.
> 2 notes:
> * According to the code, instead of a plain string, 'data' can also be a HASH.
> * If the file name is '@AUX@', then it is replaced.
I do not fully understand those uses, so I can't really explain them.
When are these useful?
> Furthermore, IN, AUX, and EXIT also do not seem to be documented yet.
> Do you like to document these, too?
>
I've added "IN" and "IN_PIPE".
"EXIT" was already mentioned.
"AUX" - I do not know what it does...
-gordon