Re: [platform-testers] new snapshot available: coreutils-8.22.151-37b36
From:
Pádraig Brady
Subject:
Re: [platform-testers] new snapshot available: coreutils-8.22.151-37b36
Date:
Wed, 16 Jul 2014 13:58:10 +0100
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
On 07/16/2014 01:29 PM, Eric Blake wrote:
> On 07/15/2014 11:41 PM, Bernhard Voelker wrote:
>
>>> That looks good to include in the release.
>>> No need to respin a snapshot for this though I think.
>>
>> I didn't follow closely - you know, the FIFA world cup ;-) -
>> ... but what about the other 17 uses of isblank() in src/*.c?
>
> Most of them are already 'isblank (to_uchar (expr))', which is safe even
> in the presence of a unibyte locale where byte 255 is considered space.
Right, but I guess Bernhard was wondering about the consistency aspect.
This would be significant in unibyte locales where isblank(\xA0)
would return non zero. For consistency with parsing in other utils,
I would use c_isdigit() and isblank(to_uchar (...)).
Assaf I'll adjust your patch accordingly and apply later.
thanks,
Pádraig.