Re: false-positive failure of the root-removal test
From:
Pádraig Brady
Subject:
Re: false-positive failure of the root-removal test
Date:
Thu, 15 Oct 2015 11:57:51 +0100
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
On 15/10/15 11:33, Bernhard Voelker wrote:
> On 10/15/2015 11:32 AM, Pádraig Brady wrote:
>> How about the attached on top?
>
> I'm now on a newer openSUSE host where GDB doesn't have this bug anymore,
> but from reading the patch looks good ... except this tiny typo:
>
>> * tests/rm/r-root.sh: SKip the test if there are gdb warnings
>
> s/SKip/Skip/
>
> Another issue: during the creation of the test, I forgot to initialize
> the variable CU_TEST_SKIP_EXIT at the very beginning. It's unlikely
> that someone has such a variable set, but would you mind to squash
> an 'unset CU_TEST_SKIP_EXIT' into the commit?
Pushed with those adjustments.
thanks again for the review,
Pádraig.