Re: dircolors man page should mention proper quoting
From:
Reuti
Subject:
Re: dircolors man page should mention proper quoting
Date:
Tue, 28 Jun 2016 18:00:11 +0200
Hi,
> Am 16.06.2016 um 00:13 schrieb Eric Blake <address@hidden>:
>
> 'info dircolors' properly mentions that you should use:
>
> eval "$(dircolors ...)"
>
> but there is no mention in 'dircolors --help' or 'man dircolors' about
> the proper way to use it with eval.
>
> I mention this because the 'ssh-agent' man page has a bug: it suggests:
>
> eval `ssh-agent -s`
>
> which BREAKS if any of the environment variables thus output contain
> whitespace. It should be:
>
> eval "`ssh-agent -s`"
I don't see this, You mean instead of "SSH_AUTH_SOC" it's named "SSH AUTH SOC"
which wouldn't be allowed? What would break exactly as there are already
multiple lines output?
-- Reuti
> (or modern $(), rather than ``).
>
> Since not everyone bothers to read 'info dircolors', and there are lots
> of sites out there with bad advice that lack quoting, we probably ought
> to make the --help/man page more explicit on safe usage patterns.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
signature.asc Description: Message signed with OpenPGP using GPGMail