Re: [PATCH] build: Properly expand cu_install_program viariable when cro
From:
Eric Blake
Subject:
Re: [PATCH] build: Properly expand cu_install_program viariable when cross-compiling
Date:
Wed, 25 Jan 2017 08:58:02 -0600
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
On 01/25/2017 08:51 AM, address@hidden wrote:
> From: Manolis Ragkousis <address@hidden>
>
> * src/local.mk (cu_install_program): Replace @INSTALL_PROGRAM@
> with @INSTALL@ and "=" with ":=" when cross-compiling.
> ---
> src/local.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/local.mk b/src/local.mk
> index 86d0d8e22..8091b9a81 100644
> --- a/src/local.mk
> +++ b/src/local.mk
> @@ -645,7 +645,7 @@ check-duplicate-no-install: src/tr
>
> # Use the just-built 'ginstall', when not cross-compiling.
> if CROSS_COMPILING
> -cu_install_program = @INSTALL_PROGRAM@
> +cu_install_program := @INSTALL@
Do we really need ':='?
I'm wondering if this is merely a sign that commit 477a1e8 was
incomplete, when we switched from overriding INSTALL_PROGRAM to instead
overriding INSTALL.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc Description: OpenPGP digital signature