Re: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was
From:
Bernhard Voelker
Subject:
Re: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was: [INSTALLED 2/2] ln: use linkat and symlinkat]
Date:
Sun, 28 Oct 2018 19:48:30 +0100
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
On 10/28/18 2:40 PM, Jim Meyering wrote:
> On Sun, Oct 28, 2018 at 12:59 PM Bernhard Voelker
> <address@hidden> wrote:
>> On 10/28/18 1:25 PM, Jim Meyering wrote:
>>> Thanks for fixing that, but...
>>>
>>>> - @h='same.h' re='\<same_name *\(' $(_sc_header_without_use)
>>> + @h='same.h' re='\<same_name(|at) *\(' $(_sc_header_without_use)
>>>
>>> please use the "?" operator instead of an empty alternation, i.e.,
>>>
>>> @h='same.h' re='\<same_name(at)? *\(' $(_sc_header_without_use)
>>
>> okay, thanks. Would you push for me with that little change, please?
>> I don't have push permissions on 'gnulib.git' anyway.
>
> Sure. Done.
Thanks!
BTW: there are 5 more such cases with an empty alternative in the RE:
$ GIT_PAGER= git grep -F '(|' -- top/maint.mk
top/maint.mk: @prohibit='! *strcmp *\(|\<$(sp_) *[!=]=|[!=]= *$(sp_)'
\
top/maint.mk: @h='quote.h' re='\<quote((_n)? *\(|_quoting_options\>)' \
top/maint.mk:
re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<(invalid_arg|argmatch(_exit_fn|_(in)?valid)?)
*\()' \
top/maint.mk: re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>'
\
top/maint.mk: /^\# *define ([^_ (][^ (]*)(\s*\(|\s+\w+)/\
Are you worried about them as well?
Have a nice day,
Berny