Re: baseN: new program suggestion (various 'base' encoding)
From:
Bernhard Voelker
Subject:
Re: baseN: new program suggestion (various 'base' encoding)
Date:
Fri, 4 Jan 2019 22:07:32 +0100
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3
On 1/4/19 6:38 PM, PƔdraig Brady wrote:
> I wonder should we avoid VLAs in coreutils altogether?
> I.E. add -Werror=vla. The kernel has done this for security reaons.
Well, why not? The only problem is still the one mentioned in 'configure.ac':
nw="$nw -Wvla" # warnings in gettext.h
With -Werror=vla, we get a lot of warnings, but all originate from
these 2 places in gettext.h:
./lib/gettext.h: In function 'dcpgettext_expr':
./lib/gettext.h:220:3: error: ISO C90 forbids variable length array
'msg_ctxt_id' [-Werror=vla]
char msg_ctxt_id[msgctxt_len + msgid_len];
^~~~
./lib/gettext.h: In function 'dcnpgettext_expr':
./lib/gettext.h:268:3: error: ISO C90 forbids variable length array
'msg_ctxt_id' [-Werror=vla]
char msg_ctxt_id[msgctxt_len + msgid_len];
^~~~
Have a nice day,
Berny