coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: build: add src/termios.c to the tarball


From: Jeffrey Walton
Subject: Re: build: add src/termios.c to the tarball
Date: Sun, 22 Jun 2025 19:41:01 -0400

On Sun, Jun 22, 2025 at 1:49 AM Collin Funk <collin.funk1@gmail.com> wrote:
>
> Hi Pádraig,
>
> I have 2 patches attached.
>
> First, I noticed many instances of three-valued comparisons written
> like:
>
>    return (a > b) - (a < b);

Isn't this the transitive comparison function fiasco all over again?
See <https://www.openwall.com/lists/oss-security/2024/01/30/7>.

> I think it will take a bit of thought for new contributors to understand
> this. Instead we can use _GL_CMP which does the same thing (and Gnulib
> will probably never remove).
>
> A new contributor can grep for the _GL_CMP definition and read the
> detailed comment in m4/gnulib-common.m4 or lib/config.h(in)? to
> understand it.

Jeff



reply via email to

[Prev in Thread] Current Thread [Next in Thread]