coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sort: prefer posix_spawnp to fork and execlp


From: Pádraig Brady
Subject: Re: sort: prefer posix_spawnp to fork and execlp
Date: Fri, 24 Oct 2025 13:33:02 +0100
User-agent: Mozilla Thunderbird Beta

On 24/10/2025 07:24, Collin Funk wrote:
Here is a patch to make 'sort' use posix_spawnp.

Very tiny performance improvement:

     $ export LC_ALL=C
     $ seq 100000 | shuf > input
     $ perf stat -i --repeat 10 ./src/sort-prev -S 1K \
         --compress-program=gzip input 2>&1 > /dev/null \
         | grep -F 'seconds time elapsed'
                 4.5896 +- 0.0109 seconds time elapsed  ( +-  0.24% )
     $ perf stat -i --repeat 10 ./src/sort -S 1K \
         --compress-program=gzip input 2>&1 > /dev/null \
         | grep -F 'seconds time elapsed'
                4.53118 +- 0.00142 seconds time elapsed  ( +-  0.03% )

But hopefully it avoids a fork failing with ENOMEM.

Also, I think the error reporting is a bit nicer with this change. Here
is how it behaved previously:

     $ /bin/sort -S 1K --compress-program=missing Makefile 2>&1
     couldn't execute compress program: errno 2
     [...]
     couldn't execute compress program: errno 2
     sort: 'missing' [-d] terminated abnormally
     couldn't execute compress program: errno 2
     couldn't execute compress program: errno 2
     $ /bin/sort -S 1K --compress-program=missing Makefile 2>&1
     couldn't execute compress program: errno 2
     [...]
     couldn't execute compress program: errno 2
     sort: 'missing' [-d] terminated abnormally
     couldn't execute compress program: errno 2

Here it is now:

     $ ./src/sort -S 1K --compress-program=missing Makefile 2>&1
     sort: couldn't create process for 'missing': No such file or directory

That's quite a bit better.

The logic in the patch looks sound.
I tried to make it more succinct but it looks optimal in that regard.

A few remarks on the commit message.

Generally the summary should describe the "why" not the "what".
So: "sort: prefer posix_spawnp to fork and execlp" would be better
as: "sort: use the more efficient posix_spawn to invoke helpers"

Also "* NEWS: Mention the change." would be better
as:  "* NEWS: Mention the improvement."

I've attached a few naming tweaks your patch
and adjusted an error message slightly,
which you can squash in if you agree.

thanks!
Padraig

Attachment: sort-posix-spawn-tweaks.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]