|
| From: | Pádraig Brady |
| Subject: | Re: RFC: adjust lseek_copy to handle non zero offsets |
| Date: | Tue, 4 Nov 2025 16:31:04 +0000 |
| User-agent: | Mozilla Thunderbird Beta |
On 04/11/2025 15:51, Paul Eggert wrote:
On 2025-11-03 15:42, Pádraig Brady wrote:Hi Paul, When looking at this I noticed confusing code in lseek_copy() which seems like it might not be accounting for non zero SRC_POS. I know we don't use non zero offsets yet, but does the attached make sense?Yes, I think so. This area needs more looking into. I did that a couple of months ago but don't have a cleanup patch yet (too many other things...).
Cool I'll apply it so. BTW I really like the copy_file_data() refactoring. It splits things out really nicely. cheers, Padraig
| [Prev in Thread] | Current Thread | [Next in Thread] |