[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: prefer ext4 casefold for case insensitive tests
|
From: |
Collin Funk |
|
Subject: |
Re: [PATCH] tests: prefer ext4 casefold for case insensitive tests |
|
Date: |
Thu, 27 Nov 2025 14:20:35 -0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Pádraig Brady <P@draigBrady.com> writes:
> * tests/mv/hardlink-case.sh: Try both ext4 casefold and hfsplus,
> as ext4 has better availability.
> Suggested at https://github.com/coreutils/coreutils/issues/133
> ---
> tests/mv/hardlink-case.sh | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/tests/mv/hardlink-case.sh b/tests/mv/hardlink-case.sh
> index 2884af6eb..da182b106 100755
> --- a/tests/mv/hardlink-case.sh
> +++ b/tests/mv/hardlink-case.sh
> @@ -23,10 +23,22 @@ require_root_
> cwd=$(pwd)
> cleanup_() { cd /; umount "$cwd/mnt"; }
>
> -truncate -s100M hfs.img || framework_failure_
> -mkfs -t hfsplus hfs.img || skip_ 'failed to create hfs file system'
> -mkdir mnt || framework_failure_
> -mount hfs.img mnt || skip_ 'failed to mount hfs file system'
> +for ocase in '-t ext4 -O casefold' '-t hfsplus'; do
> + rm -f case.img
> + truncate -s100M case.img || framework_failure_
> + mkfs $ocase case.img &&
> + mkdir mnt &&
> + mount case.img mnt &&
> + printf '%s\n' "$ocase" > mnt/type &&
> + break
> +done
> +
> +test -f mnt/type || skip_ 'failed to create case insensitive file system'
> +
> +if grep 'ext4' mnt/type; then
> + rm -d mnt/type mnt/lost+found || framework_failure_
> + chattr +F mnt || skip_ 'failed to create case insensitive file system'
> +fi
>
> cd mnt
> touch foo
Looks good to me. Thanks!
Collin