coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: mktemp: add tests for invalid Unicode options


From: Pádraig Brady
Subject: Re: [PATCH] tests: mktemp: add tests for invalid Unicode options
Date: Tue, 6 Jan 2026 13:40:48 +0000
User-agent: Mozilla Thunderbird Beta

On 06/01/2026 01:56, Collin Funk wrote:
Collin Funk <collin.funk1@gmail.com> writes:

+: > "$(bad_unicode)" || skip_ 'bad unicode not supported in file names'

Oops, I forgot we can't do this. I applied the additional patch locally:

diff --git a/tests/mktemp/bad-unicode.sh b/tests/mktemp/bad-unicode.sh
index 2583a251a..ea67b5253 100755
--- a/tests/mktemp/bad-unicode.sh
+++ b/tests/mktemp/bad-unicode.sh
@@ -19,7 +19,7 @@
  . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
  print_ver_ mktemp
-: > "$(bad_unicode)" || skip_ 'bad unicode not supported in file names'
+echo a > "$(bad_unicode)" || skip_ 'bad unicode not supported in file names'

Maybe s/file names/shell or file system/

You may prefer to use no `if` and reduce all the "fail=1" by doing:

  one &&
  two &&
  ... || fail=1

In any case, it fine to push.

thanks,
Padraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]