coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] selinux-h: only disable SELinux when a warning is provided


From: Bruno Haible
Subject: Re: [PATCH] selinux-h: only disable SELinux when a warning is provided
Date: Sat, 10 Jan 2026 05:00:40 +0100

Michael Daniels wrote:
> > 1) It very much looks like it has not been tested.
> 
> Dammit. I did test a very similar patch (differing only in the placement of 
> &&),
> then changed the placement of the && to conform to the GNU coding standards.
> And I didn't test because surely that tiny change can't matter.

Yeah, I can relate to that experience :) I've made the same mistake
(tweaking after testing) many times too. It isn't obvious that one needs
backslashes on the line before '&&'.

The better habit is "tweak then test", rather "test then tweak". But yes,
often it turns into "tweak then test then tweak then test again"...

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]