|
| From: | Pádraig Brady |
| Subject: | Re: [PATCH] ls: promptly diagnose write errors |
| Date: | Sun, 11 Jan 2026 12:38:36 +0000 |
| User-agent: | Mozilla Thunderbird Beta |
On 11/01/2026 07:17, Collin Funk wrote:
There are two things about this patch that I am unsure about. When we receive a write error, should we attempt to restore the default terminal colors? The write to standard output will almost certainly not work, but is it worth a shot anyways? Second, I am not really sure of a test case to add for this. Doing 'ls -R $HOME' or 'ls -R /' should take long enough, but I would rather not access anything outside of the checkout or $TMPDIR in the test suite. Any ideas?
I'm 50:50 on this one because: * The question about terminal reset * 3 call sites (albeit minimal overhead) * impractical usage (evidenced by awkward testing) cheers, Padraig
| [Prev in Thread] | Current Thread | [Next in Thread] |