coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: recent nullptr related changes


From: Jeffrey Walton
Subject: Re: recent nullptr related changes
Date: Fri, 16 Jan 2026 15:35:02 -0500

On Fri, Jan 16, 2026 at 2:37 PM Collin Funk <collin.funk1@gmail.com> wrote:
>
> PƔdraig Brady <P@draigBrady.com> writes:
>
> > Also I noticed the reintroduction of NULL in coreutils since:
> > https://github.com/coreutils/coreutils/commit/1202fac2
> > with the referenced (good) justification of https://bugs.gnu.org/66221#53
> > The implication of that is, the sc_prohibit_NULL syntax check will fail.
> > I'll probably remove the syntax check anyway,
> > and possibly s/nullptr/NULL/ everywhere for consistency.
>
> Removing bug-gnulib@gnu.org from CC since I'm mostly responding to the
> part that applies to coreutils.
>
> I don't have a strong preference for either NULL or nullptr. Using them
> inconsistently seems terrible for readability, though. So I would be for
> s/nullptr/NULL/ or s/NULL/nullptr/ everywhere.

I recommend changing it to GNULIB_NULL, and then defining the macro to
the value you want, like NULL or nullptr, in the nullptr module.

> Regarding that warning, it seems nice to use if the compatibility issues
> are fixed. It will help me update GNU time which uses 0 instead of NULL
> in many places.

Jeff



reply via email to

[Prev in Thread] Current Thread [Next in Thread]