Re: [PATCH] doc: post process html with non-GNU make programs
From:
Collin Funk
Subject:
Re: [PATCH] doc: post process html with non-GNU make programs
Date:
Sun, 18 Jan 2026 12:25:15 -0800
User-agent:
Gnus/5.13 (Gnus v5.13)
Pádraig Brady <P@draigBrady.com> writes:
>> diff --git a/doc/local.mk b/doc/local.mk
>> index 04ce909e9..6f80cb189 100644
>> --- a/doc/local.mk
>> +++ b/doc/local.mk
>> @@ -25,9 +25,11 @@ doc_coreutils_TEXINFOS = \
>> doc/fdl.texi \
>> doc/sort-version.texi
>> +MAKEINFO = $(abs_top_srcdir)/build-aux/makeinfo-wrapper.sh
>
> I think that should be ${abs_top_builddir} to support VPATH builds.
Nice catch. My patch didn't work after running ./configure in a
subdirectory, but using $(abs_top_builddir) fixes it.
>> +MAKEINFO = $(abs_top_srcdir)/build-aux/makeinfo-wrapper.sh
>> +
>> # The customization variable CHECK_NORMAL_MENU_STRUCTURE is necessary with
>> # makeinfo versions ≥ 6.8.
>> -MAKEINFO = @MAKEINFO@ -c CHECK_NORMAL_MENU_STRUCTURE=1
>> +MAKEINFOFLAGS = -c CHECK_NORMAL_MENU_STRUCTURE=1
>
>I notice there are also AM_MAKEINFOFLAGS passed.
>Should we be using that, rather than overriding
>variables the user may set at configure/build time?
Yes, that is correct. It seems I read the Automake manual very poorly
yesterday.
Pushed the patch after those two changes [1].
Thanks,
Collin
[1]
https://github.com/coreutils/coreutils/commit/740d33b8da14cf410057249f884cf7a612b28d6b