coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gnulib update for 'od -j' quoting


From: Pádraig Brady
Subject: Re: Gnulib update for 'od -j' quoting
Date: Sun, 14 Jun 2026 10:18:32 +0100
User-agent: Mozilla Thunderbird Beta

On 14/06/2026 04:09, Collin Funk wrote:
Hi Pádraig,

Regarding the 'od -j' quoting, I am leaning towards considering it as a
bug since coreutils-8.25 had the following news entry:

   All utilities now quote user supplied arguments in error strings,
   which avoids confusing error messages in the presence of '\r' chars etc.

What do you think? The other programs added listed in the proposed NEWS
entry in the attached patch are from this:

     $ git grep -l -E 'xstrtol_(error|fatal)' -- '*.[ch]' | \
         sed -E 's|^src/||; s|\.c$||' | sort -u
     df
     du
     ls
     od
     pr
     sort

I also only added a test for 'od -j', since it didn't seem very
beneficial to duplicate it for the other cases.
Since the original change in 8.25 was presented as an improvement,
I'd also class this change as an improvement rather than a bug fix.
Otherwise is reads as if there was an issue introduced in 8.25.

Otherwise this looks good.

thanks!
Padraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]