Re: [PATCH] cp: quote destination name when preserving ownership on syml
From:
Collin Funk
Subject:
Re: [PATCH] cp: quote destination name when preserving ownership on symlinks fails
Date:
Fri, 23 Oct 2026 19:48:41 -0700
User-agent:
Gnus/5.13 (Gnus v5.13)
Pádraig Brady <P@draigBrady.com> writes:
> We do have various sc_error_... syntax checks for these,
> but they're heuristics and don't handle multi-line error() calls robustly.
> I temp hacked the source to put error()s on a single line,
> before running `make syntax_check` and found these further quoting issues,
> which the attached should address. In the patch I've added a general item
> about improved quoting given all these similar improvements.
Nice, thanks.
Yeah, I knew about those sc_error_... checks, but as you mentioned, they
are heuristics. We also need a way to handle strings we don't want
quoted. I guess we could make a script to more robustly check this
stuff, e.g., by requiring a comment on arguments that shouldn't be
quoted, but it probably isn’t worth the time.
Collin