coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pr: fix a crash when reading more than INT_MAX bytes for a s


From: Pádraig Brady
Subject: Re: [PATCH] pr: fix a crash when reading more than INT_MAX bytes for a single page
Date: Thu, 29 Oct 2026 15:53:10 +0000
User-agent: Mozilla Thunderbird Beta

On 29/10/2026 07:12, Collin Funk wrote:
I suspect testing this takes too much time for even expensive tests:

     $ truncate -s 2G f; time pr -2 f > /dev/null
     Segmentation fault         (core dumped) pr -2 f > /dev/null
real 0m28.021s
     user       0m20.729s
     sys        0m4.321s

It is even slower with ASAN, of course. Also, some other things in
that file are probably worth changing to idx_t.

Code changes look good.

It probably isn't worth a very_expensive_ test for this,
given pr is a lower priority tool in general.

cheers,
Padraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]