coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: avoid false failures on dash 0.5.13


From: Pádraig Brady
Subject: Re: [PATCH] tests: avoid false failures on dash 0.5.13
Date: Sun, 8 Nov 2026 10:54:12 +0000
User-agent: Mozilla Thunderbird Beta

On 07/11/2026 22:21, Collin Funk wrote:
Pádraig Brady <P@draigBrady.com> writes:

dash 0.5.13 to 0.5.13.5 at least has a variable expansion bug:
https://bugzilla.redhat.com/2568651
This was seen on Fedora 44 and there is no upstream dash
release with a fix yet.

* init.cfg (bad_unicode): Avoid the dash issue, by comparing
the variable expansion and skipping upon mismatch.
* tests/du/block-size.sh: Add explicit checks for expansion
on values with high bit set.
* tests/paste/multi-byte.sh: Likewise.
---
  init.cfg                  | 11 ++++++++++-
  tests/du/block-size.sh    |  3 +++
  tests/paste/multi-byte.sh |  5 +++++
  3 files changed, 18 insertions(+), 1 deletion(-)

Nice find.

BTW, do you test any other shells other than bash and dash?

I'm not sure if any distributions use zsh or mksh by default, but they
are probably worth testing. I'm thinking of setting up a script to test
configurations that I don't use often, i.e., shells and single binary
mostly.
Before release (or when testing a lot of tests/ changes) I generally:

  for sh in sh bash dash ksh; do
    make -j $(nproc) SHELL=/bin/$sh \
                     PREFERABLY_POSIX_SHELL=/bin/$sh SUBDIRS=. check ||
      break
  done

$SHELL sets the shell used to run sh scripts
$PREFERABLY_POSIX_SHELL sets the $SHELL used within those scripts.

Note I've nightly CI that runs:
  latest coreutils
  latest gnulib
  --enable-single-binary
  SHELL=/bin/dash

You can see that at ~pixelbeat/coreutils.ci on cfarm13.cfarm.net

cheers,
Padraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]