coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mv: with -Z don't perform an extra fstatat for each director


From: Pádraig Brady
Subject: Re: [PATCH] mv: with -Z don't perform an extra fstatat for each directory entry
Date: Tue, 17 Nov 2026 18:45:10 +0000
User-agent: Mozilla Thunderbird Beta

On 17/11/2026 01:49, Collin Funk wrote:
As far as I can tell, only 'mv -Z' uses the recursive code in the
restorecon function. It calls restorecon_private, which opens a file
descriptor and performs an fstat/stat call. Therefore, the fts stat is
not necessary. I noticed this while looking to make some other changes
here.
+  'mv -Z' no longer performs an extra fstatat call for each directory entry
+  located under a moved directory.
+  [bug introduced with SELinux support in coreutils-8.22]

An improvement rather than a bug.
Otherwise LGTM.

cheers,
Padraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]