From MAILER-DAEMON Tue Jun 20 17:15:33 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dNQUn-0004Uk-DL
	for mharc-bug-ddd@gnu.org; Tue, 20 Jun 2017 17:15:33 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1dNQUk-0004Ud-P9
	for bug-ddd@gnu.org; Tue, 20 Jun 2017 17:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1dNQUh-0008Vq-I1
	for bug-ddd@gnu.org; Tue, 20 Jun 2017 17:15:30 -0400
Received: from frontend0.savannah.gnu.org ([208.118.235.79]:48405)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1dNQUh-0008Vj-Ev
	for bug-ddd@gnu.org; Tue, 20 Jun 2017 17:15:27 -0400
Received: by frontend0.savannah.gnu.org (Postfix, from userid 33)
	id 6022F21F9; Tue, 20 Jun 2017 17:15:27 -0400 (EDT)
To: Zdenek Sojka <zsojka@seznam.cz>, bug-ddd@gnu.org
Subject: [bug #51281] WhenReadyInfo::WhenReadyInfo() : wrong use of memcpy()
X-PHP-Originating-Script: 1001:sendmail.php
From: Zdenek Sojka <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.79]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: ddd
X-Savane-Tracker: bugs
X-Savane-Item-ID: 51281
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:45.9) Gecko/20100101 Goanna/3.2 Firefox/45.9 PaleMoon/27.3.0
X-Apparently-From: 109.183.32.44 (Savane authenticated user zsojka)
Message-Id: <20170620-211526.sv71178.27807@savannah.gnu.org>
References: 
In-Reply-To: 
Date: Tue, 20 Jun 2017 17:15:27 -0400 (EDT)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.79
X-BeenThere: bug-ddd@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for the GNU DDD graphical debugger frontend
	<bug-ddd.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-ddd>,
	<mailto:bug-ddd-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-ddd/>
List-Post: <mailto:bug-ddd@gnu.org>
List-Help: <mailto:bug-ddd-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-ddd>,
	<mailto:bug-ddd-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 21:15:31 -0000

URL:
  <http://savannah.gnu.org/bugs/?51281>

                 Summary: WhenReadyInfo::WhenReadyInfo() : wrong use of
memcpy()
                 Project: DDD
            Submitted by: zsojka
            Submitted on: Tue 20 Jun 2017 09:15:26 PM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 3.3.12-rc2

    _______________________________________________________

Details:

When compiling DDD with a recent gcc (5.4.0 in my case), the following warning
is given:


ddd.C: In constructor 'WhenReadyInfo::WhenReadyInfo(const MString&,
XtCallbackProc, XtPointer, const XmPushButtonCallbackStruct&)':
ddd.C:5825:39: warning: argument to 'sizeof' in 'void* memcpy(void*, const
void*, size_t)' call is the same expression as the destination; did you mean
to dereference it? [-Wsizeof-pointer-memaccess]
      memcpy(cbs.event, c.event, sizeof(cbs.event));


The warning seems to be valid, since the memcpy() parameters are most likely
the same (dst == src), and the size is size_of_pointer.

event is unitialized (its default constructor is used; if applicable)

This patch might trigger the originally intended behavior:

+++ ddd/ddd.C   2017-06-20 23:03:48.946830931 +0200
@@ -5822,7 +5822,7 @@
        }
        else
        {
-           memcpy(cbs.event, c.event, sizeof(cbs.event));
+           memcpy(&event, c.event, sizeof(event));
            cbs.event = &event;
        }
     }






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51281>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



