From MAILER-DAEMON Tue Oct 04 07:57:11 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RB3cV-0005gP-HI
	for mharc-bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:57:11 -0400
Received: from eggs.gnu.org ([140.186.70.92]:39464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3cP-0005fX-U2
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:57:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3cO-00077C-MM
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:57:05 -0400
Received: from mx.meyering.net ([88.168.87.75]:59677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3cO-000774-EQ
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:57:04 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id ABDB860042;
	Tue,  4 Oct 2011 13:57:02 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Tim Waugh <twaugh@redhat.com>
In-Reply-To: <1316710283.6304.2.camel@worm.elk> (Tim Waugh's message of "Thu, 
	22 Sep 2011 17:51:23 +0100")
References: <1316710283.6304.2.camel@worm.elk>
Date: Tue, 04 Oct 2011 13:57:02 +0200
Message-ID: <87ehytq8a9.fsf@rho.meyering.net>
Lines: 32
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] gnulib test-float failure on ppc
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2011 11:57:10 -0000

Tim Waugh wrote:
> I'm seeing the gnulib test-float test fail on PPC (with exit status 134,
> i.e. SIGFPE) with the gnulib shipped along with diffutils-3.2.
>
> This patch works around it:
>
> diff -up diffutils-3.2/gnulib-tests/test-float.c.mantdig
> diffutils-3.2/gnulib-tests/test-float.c
> --- diffutils-3.2/gnulib-tests/test-float.c.mantdig	2011-09-02 00:38:42.000000000 +0200
> +++ diffutils-3.2/gnulib-tests/test-float.c	2011-09-22 11:12:53.142761914 +0200
> @@ -325,7 +325,11 @@ test_long_double (void)
>      int n;
>
>      ASSERT (m + m > m);
> +#if (defined _ARCH_PPC || defined _POWER)
> +    for (n = 0; n <= 2 * DBL_MANT_DIG; n++)
> +#else
>      for (n = 0; n <= 2 * LDBL_MANT_DIG; n++)
> +#endif
>        {
>          volatile long double pow2_n = pow2l (n); /* 2^n */
>          volatile long double x = m + (m / pow2_n);
>
> Here's the original bug report:
>   https://bugzilla.redhat.com/show_bug.cgi?id=733536

Hi Tim,

Thanks for the report.

That was fixed by a recent change by Bruno Haible in gnulib, so I've
updated diffutils to use the latest from gnulib and will push that shortly.


From MAILER-DAEMON Tue Oct 04 07:58:50 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RB3e6-0005tY-QG
	for mharc-bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:58:50 -0400
Received: from eggs.gnu.org ([140.186.70.92]:39723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3e4-0005tJ-Mq
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:58:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3e0-0007UR-Fq
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:58:48 -0400
Received: from mx.meyering.net ([88.168.87.75]:59684)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RB3e0-0007UN-8S
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 07:58:44 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 79EDE602F7;
	Tue,  4 Oct 2011 13:58:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Claudio Bley <claudio.bley@gmail.com>
In-Reply-To: <m27h5nl5ss.fsf@home.int> (Claudio Bley's message of "Mon, 05 Sep
	2011 11:03:31 +0200")
References: <m27h5nl5ss.fsf@home.int>
Date: Tue, 04 Oct 2011 13:58:42 +0200
Message-ID: <878vp1q87h.fsf@rho.meyering.net>
Lines: 105
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] [PATCH] use binary-io gnulib module instead of
	xfreopen
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2011 11:58:49 -0000

Claudio Bley wrote:
> (I already posted a message yesterday, but apparently it didn't come
>  through. Sorry, if this is a duplicate.)
>
> Using NULL as filename in xfreopen is non-portable. It doesn't work on
> MinGW, it crashes using MSVC.
>
> Here is a patch using the binary-io gnulib module instead, as suggested
> by Bruno Haible on the gnulib bugs ML.
...
> Subject: [PATCH] Use gnulib's binary-io module instead of xfreopen to change
>  the translation mode.
>
> ---
>  bootstrap.conf |    1 +
>  src/cmp.c      |    4 ++--
>  src/diff.c     |    6 +++---
>  3 files changed, 6 insertions(+), 5 deletions(-)

Thank you for the patch.
I have adjusted your commit log to conform to our style
guidelines (see HACKING) and will push this shortly.

>From 7508234eabe646abcea074baea83612f8115d3b9 Mon Sep 17 00:00:00 2001
From: Claudio Bley <claudio.bley@gmail.com>
Date: Sun, 4 Sep 2011 18:01:57 +0200
Subject: [PATCH] portability: use SET_BINARY rather than xfreopen (NULL, ...

* src/diff.c: Include binary-io.h, not xfreopen.h.
(main): Use SET_BINARY (...) rather than xfreopen (NULL, X, ...),
because the latter doesn't work on MinGW and crashes using MSVC.
* src/cmp.c (main): Likewise.
---
 bootstrap.conf |    1 +
 src/cmp.c      |    4 ++--
 src/diff.c     |    6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index cc6d88c..c4e340e 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -19,6 +19,7 @@
 # gnulib modules used by this package.
 gnulib_modules='
 announce-gen
+binary-io
 c-stack
 config-h
 diffseq
diff --git a/src/cmp.c b/src/cmp.c
index adf1cf9..2620b0f 100644
--- a/src/cmp.c
+++ b/src/cmp.c
@@ -33,7 +33,7 @@
 #include <unlocked-io.h>
 #include <version-etc.h>
 #include <xalloc.h>
-#include <xfreopen.h>
+#include <binary-io.h>
 #include <xstrtol.h>

 /* The official name of this program (e.g., no `g' prefix).  */
@@ -293,7 +293,7 @@ main (int argc, char **argv)
 	{
 	  file_desc[f1] = STDIN_FILENO;
 	  if (O_BINARY && ! isatty (STDIN_FILENO))
-	    xfreopen (NULL, "rb", stdin);
+	    SET_BINARY (STDIN_FILENO);
 	}
       else
 	file_desc[f1] = open (file[f1], O_RDONLY | O_BINARY, 0);
diff --git a/src/diff.c b/src/diff.c
index c096406..170d42f 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -39,7 +39,7 @@
 #include <timespec.h>
 #include <version-etc.h>
 #include <xalloc.h>
-#include <xfreopen.h>
+#include <binary-io.h>

 /* The official name of this program (e.g., no `g' prefix).  */
 #define PROGRAM_NAME "diff"
@@ -525,7 +525,7 @@ main (int argc, char **argv)
 #if O_BINARY
 	  binary = true;
 	  if (! isatty (STDOUT_FILENO))
-	    xfreopen (NULL, "wb", stdout);
+	    SET_BINARY (STDOUT_FILENO);
 #endif
 	  break;

@@ -1108,7 +1108,7 @@ compare_files (struct comparison const *parent,
 	    {
 	      cmp.file[f].desc = STDIN_FILENO;
 	      if (O_BINARY && binary && ! isatty (STDIN_FILENO))
-		xfreopen (NULL, "rb", stdin);
+		SET_BINARY (STDIN_FILENO);
 	      if (fstat (STDIN_FILENO, &cmp.file[f].stat) != 0)
 		cmp.file[f].desc = ERRNO_ENCODE (errno);
 	      else
--
1.7.7.rc0.362.g5a14


From MAILER-DAEMON Tue Oct 04 22:15:57 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RBH1Z-0006hD-Dv
	for mharc-bug-diffutils@gnu.org; Tue, 04 Oct 2011 22:15:57 -0400
Received: from eggs.gnu.org ([140.186.70.92]:43414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gcgdb-bug-diffutils@m.gmane.org>) id 1RBB6R-0003A9-7a
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 15:56:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gcgdb-bug-diffutils@m.gmane.org>) id 1RBB6Q-0005wi-4C
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 15:56:35 -0400
Received: from lo.gmane.org ([80.91.229.12]:42339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gcgdb-bug-diffutils@m.gmane.org>) id 1RBB6P-0005wO-VS
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 15:56:34 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gcgdb-bug-diffutils@m.gmane.org>) id 1RBB6N-0002VE-UJ
	for bug-diffutils@gnu.org; Tue, 04 Oct 2011 21:56:31 +0200
Received: from dslb-188-102-221-185.pools.arcor-ip.net ([188.102.221.185])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <bug-diffutils@gnu.org>; Tue, 04 Oct 2011 21:56:31 +0200
Received: from claudio.bley by dslb-188-102-221-185.pools.arcor-ip.net with
	local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <bug-diffutils@gnu.org>; Tue, 04 Oct 2011 21:56:31 +0200
X-Injected-Via-Gmane: http://gmane.org/
To: bug-diffutils@gnu.org
From: Claudio Bley <claudio.bley@gmail.com>
Date: Tue, 04 Oct 2011 22:00:53 +0200
Lines: 10
Message-ID: <m2wrck34sq.fsf@home.int>
References: <m27h5nl5ss.fsf@home.int> <878vp1q87h.fsf@rho.meyering.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: dslb-188-102-221-185.pools.arcor-ip.net
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Cancel-Lock: sha1:WTTFuv237slkkBXjNMvqxfmkSDs=
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 80.91.229.12
X-Mailman-Approved-At: Tue, 04 Oct 2011 22:15:55 -0400
Subject: Re: [bug-diffutils] [PATCH] use binary-io gnulib module instead of
	xfreopen
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2011 19:56:36 -0000

Jim Meyering <jim@meyering.net> writes:

> I have adjusted your commit log to conform to our style
> guidelines (see HACKING) and will push this shortly.

Thank you very much. Again, sorry for the dupes -- I guess posting via
gmane is like /a box of chocolate/ sometimes... ;)

Cheers,
Claudio



From MAILER-DAEMON Tue Oct 11 10:17:33 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RDd9B-0007aS-4w
	for mharc-bug-diffutils@gnu.org; Tue, 11 Oct 2011 10:17:33 -0400
Received: from eggs.gnu.org ([140.186.70.92]:47598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDKxD-0005Kl-UJ
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 14:52:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDKxC-0005Bd-Gk
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 14:51:59 -0400
Received: from mail-ey0-f169.google.com ([209.85.215.169]:38486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDKxC-0005BX-Av
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 14:51:58 -0400
Received: by eye4 with SMTP id 4so1061941eye.0
	for <bug-diffutils@gnu.org>; Mon, 10 Oct 2011 11:51:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:cc:subject:date:message-id:x-mailer;
	bh=0tCYaZIc/9QByoeqQmk5xkiSrKgMOr3xN7sI4kNMnDM=;
	b=DG/tBXDLmP1fEpOcZhOE6q34VKUtykrr+iLwmjr7wOrth8MKEr5QXSAO8GzFy6MHVh
	dK5pswRCrxVOPHYhpAperRE2AFOx1cWg3MpVUEEFRqz6YScS+2nMkgJYhZgMQwrI4UVS
	mLr7kh+v4hHL5fRzoIP2gwpKJlbLAokFZwHlA=
Received: by 10.216.230.73 with SMTP id i51mr4872444weq.89.1318272717256;
	Mon, 10 Oct 2011 11:51:57 -0700 (PDT)
Received: from localhost.localdomain
	(host172-102-dynamic.2-87-r.retail.telecomitalia.it. [87.2.102.172])
	by mx.google.com with ESMTPS id n21sm34185456wbp.2.2011.10.10.11.51.54
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 10 Oct 2011 11:51:55 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: bug-diffutils@gnu.org
Date: Mon, 10 Oct 2011 20:51:46 +0200
Message-Id: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
X-Mailer: git-send-email 1.7.2.3
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 209.85.215.169
X-Mailman-Approved-At: Tue, 11 Oct 2011 10:17:31 -0400
Subject: [bug-diffutils] [PATCH] tests: make test runner a script,
	not a shell function
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2011 18:52:01 -0000

All the test scripts in the diffutils testsuite are shell scripts,
so the current definition of TESTS_ENVIRONMENT, which adaptively
run tests using either perl or the shell depending on their kind,
is an overkill.

Moreover, this change is required in order for the testsuite to
continue to work with the new testsuite harness that is planned
to be introduced in Automake 1.12 (which, as of the writing date,
is still under development and in late alpha state).

See also related discussion on bug-coreutils:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8887>

* tests/Makefile.am (TESTS_ENVIRONMENT): Remove definition of the
`shell_or_perl_' shell function, which is not really required.
* tests/binary: Make executable.
* tests/colliding-file-names: Likewise.
* tests/excess-slash: Likewise.
* tests/no-newline-at-eof: Likewise.
---
 tests/Makefile.am          |   17 +----------------
 1 files changed, 1 insertions(+), 16 deletions(-)
 mode change 100644 => 100755 tests/binary
 mode change 100644 => 100755 tests/colliding-file-names
 mode change 100644 => 100755 tests/excess-slash
 mode change 100644 => 100755 tests/no-newline-at-eof

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 582f976..5e2944d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -22,21 +22,6 @@ TESTS_ENVIRONMENT =				\
   tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.;	\
   TMPDIR=$$tmp__; export TMPDIR;		\
   exec 9>&2;					\
-  shell_or_perl_() {				\
-    if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then			\
-      if $(PERL) -e 'use warnings' > /dev/null 2>&1; then		\
-	grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=T || T_=;	\
-        $(PERL) -w$$T_ -I$(srcdir) -MCoreutils				\
-	      -M"CuTmpdir qw($$f)" -- "$$1";	\
-      else					\
-	echo 1>&2 "$$tst: configure did not find a usable version of Perl," \
-	  "so skipping this test";		\
-	(exit 77);				\
-      fi;					\
-    else					\
-      $(SHELL) "$$1";				\
-    fi;						\
-  };						\
   export					\
   VERSION='$(VERSION)'				\
   abs_top_builddir='$(abs_top_builddir)'	\
@@ -55,7 +40,7 @@ TESTS_ENVIRONMENT =				\
   PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \
   REPLACE_GETCWD=$(REPLACE_GETCWD)		\
   PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
-  ; shell_or_perl_
+  ;
 
 built_programs =							\
   echo 'spy:;@echo $$(PROGRAMS)'					\
diff --git a/tests/binary b/tests/binary
old mode 100644
new mode 100755
diff --git a/tests/colliding-file-names b/tests/colliding-file-names
old mode 100644
new mode 100755
diff --git a/tests/excess-slash b/tests/excess-slash
old mode 100644
new mode 100755
diff --git a/tests/no-newline-at-eof b/tests/no-newline-at-eof
old mode 100644
new mode 100755
-- 
1.7.2.3



From MAILER-DAEMON Tue Oct 11 10:17:33 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RDd9B-0007af-6i
	for mharc-bug-diffutils@gnu.org; Tue, 11 Oct 2011 10:17:33 -0400
Received: from eggs.gnu.org ([140.186.70.92]:35506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDNLj-0000yS-Rd
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 17:25:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDNLi-0007F2-GC
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 17:25:27 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:48062)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDNLi-0007Ed-0l
	for bug-diffutils@gnu.org; Mon, 10 Oct 2011 17:25:26 -0400
Received: by wyh15 with SMTP id 15so3572094wyh.0
	for <bug-diffutils@gnu.org>; Mon, 10 Oct 2011 14:25:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:references:in-reply-to:mime-version
	:content-type:message-id;
	bh=WJuE3MxIO1C+PUTmcMVAAhY4/VoaKMUSoRAoMaUAMDs=;
	b=MXqzjTKJQfMDNFoZiZsXGEF9GIsmlgTqfRuTpib3jEU5YMB5vNDq9OI83Yrs5Zpv2x
	qBXUFN0NT1kN7yhdjyW5hvlp66GDJUFLk9S9OMWrW4151S+1BY+c3hWFPf4kT0B6fSAz
	8HVs6WEzMUTIUuYHXFcBztOoBeparRSmxN61U=
Received: by 10.227.173.3 with SMTP id n3mr5802950wbz.1.1318281925246;
	Mon, 10 Oct 2011 14:25:25 -0700 (PDT)
Received: from bigio.localnet
	(host172-102-dynamic.2-87-r.retail.telecomitalia.it. [87.2.102.172])
	by mx.google.com with ESMTPS id j18sm34862050wbo.6.2011.10.10.14.25.23
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 10 Oct 2011 14:25:24 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: bug-diffutils@gnu.org
Date: Mon, 10 Oct 2011 23:25:07 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
In-Reply-To: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_0K2kO6zIwVHAlgl"
Message-Id: <201110102325.08432.stefano.lattarini@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.169
X-Mailman-Approved-At: Tue, 11 Oct 2011 10:17:31 -0400
Subject: Re: [bug-diffutils] [PATCH] tests: make test runner a script,
	not a shell function
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2011 21:25:29 -0000

--Boundary-00=_0K2kO6zIwVHAlgl
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit

On Monday 10 October 2011, Stefano Lattarini wrote:
> All the test scripts in the diffutils testsuite are shell scripts,
> so the current definition of TESTS_ENVIRONMENT, which adaptively
> run tests using either perl or the shell depending on their kind,
> is an overkill.
> 
> Moreover, this change is required in order for the testsuite to
> continue to work with the new testsuite harness that is planned
> to be introduced in Automake 1.12 (which, as of the writing date,
> is still under development and in late alpha state).
> 
> See also related discussion on bug-coreutils:
>  <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8887>
> 
> * tests/Makefile.am (TESTS_ENVIRONMENT): Remove definition of the
> `shell_or_perl_' shell function, which is not really required.
> * tests/binary: Make executable.
> * tests/colliding-file-names: Likewise.
> * tests/excess-slash: Likewise.
> * tests/no-newline-at-eof: Likewise.
> ---
>
Oops, the patch wasn't exactly right, as it introduced a slight semantic
change by making the test scripts being executed by the system default
shell `/bin/sh' rather than by the shell `$(SHELL)' detected at configure
time.  On some systems (e.g., Solaris 10), the difference is quite
relevant, since /bin/sh might not be a POSIX-conforming shell.  So the
following diff should be squashed in:

  diff --git a/tests/Makefile.am b/tests/Makefile.am
  index 5e2944d..9835ab6 100644
  --- a/tests/Makefile.am
  +++ b/tests/Makefile.am
  @@ -42,6 +42,8 @@ TESTS_ENVIRONMENT =                           \
     PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
     ;
 
  +LOG_COMPILER= $(SHELL)
  +
   built_programs =                                                       \
     echo 'spy:;@echo $$(PROGRAMS)'                                       \
       | MAKEFLAGS= $(MAKE) -s -C $(builddir)/../src -f Makefile -f - spy \


Attached is an updated patch that fixes the issue.

Sorry for the noise,
  Stefano

--Boundary-00=_0K2kO6zIwVHAlgl
Content-Type: text/x-patch;
  charset="utf-8";
  name="0001-tests-make-test-runner-a-script-not-a-shell-function.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
	filename="0001-tests-make-test-runner-a-script-not-a-shell-function.patch"

=46rom 5a45c31552df3b32810c92cf3502d8d1d6bfe9ce Mon Sep 17 00:00:00 2001
Message-Id: <5a45c31552df3b32810c92cf3502d8d1d6bfe9ce.1318281808.git.stefan=
o.lattarini@gmail.com>
=46rom: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Mon, 10 Oct 2011 20:30:21 +0200
Subject: [PATCH] tests: make test runner a script, not a shell function

All the test scripts in the diffutils testsuite are shell scripts,
so the current definition of TESTS_ENVIRONMENT, which adaptively
run tests using either perl or the shell depending on their kind,
is an overkill.

Moreover, this change is required in order for the testsuite to
continue to work with the new testsuite harness that is planned
to be introduced in Automake 1.12 (which, as of the writing date,
is still under development and in late alpha state).

See also related discussion on bug-coreutils:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8887>

* tests/Makefile.am (TESTS_ENVIRONMENT): Remove definition of the
`shell_or_perl_' shell function, which is not required anymore.
(LOG_COMPILER): New, define to `$(SHELL)'.
* tests/binary: Make executable.
* tests/colliding-file-names: Likewise.
* tests/excess-slash: Likewise.
* tests/no-newline-at-eof: Likewise.
=2D--
 tests/Makefile.am          |   19 +++----------------
 1 files changed, 3 insertions(+), 16 deletions(-)
 mode change 100644 =3D> 100755 tests/binary
 mode change 100644 =3D> 100755 tests/colliding-file-names
 mode change 100644 =3D> 100755 tests/excess-slash
 mode change 100644 =3D> 100755 tests/no-newline-at-eof

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 582f976..9835ab6 100644
=2D-- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -22,21 +22,6 @@ TESTS_ENVIRONMENT =3D				\
   tmp__=3D$$TMPDIR; test -d "$$tmp__" || tmp__=3D.;	\
   TMPDIR=3D$$tmp__; export TMPDIR;		\
   exec 9>&2;					\
=2D  shell_or_perl_() {				\
=2D    if grep '^\#!/usr/bin/perl' "$$1" > /dev/null; then			\
=2D      if $(PERL) -e 'use warnings' > /dev/null 2>&1; then		\
=2D	grep '^\#!/usr/bin/perl -T' "$$1" > /dev/null && T_=3DT || T_=3D;	\
=2D        $(PERL) -w$$T_ -I$(srcdir) -MCoreutils				\
=2D	      -M"CuTmpdir qw($$f)" -- "$$1";	\
=2D      else					\
=2D	echo 1>&2 "$$tst: configure did not find a usable version of Perl," \
=2D	  "so skipping this test";		\
=2D	(exit 77);				\
=2D      fi;					\
=2D    else					\
=2D      $(SHELL) "$$1";				\
=2D    fi;						\
=2D  };						\
   export					\
   VERSION=3D'$(VERSION)'				\
   abs_top_builddir=3D'$(abs_top_builddir)'	\
@@ -55,7 +40,9 @@ TESTS_ENVIRONMENT =3D				\
   PREFERABLY_POSIX_SHELL=3D'$(PREFERABLY_POSIX_SHELL)' \
   REPLACE_GETCWD=3D$(REPLACE_GETCWD)		\
   PATH=3D'$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
=2D  ; shell_or_perl_
+  ;
+
+LOG_COMPILER=3D $(SHELL)
=20
 built_programs =3D							\
   echo 'spy:;@echo $$(PROGRAMS)'					\
diff --git a/tests/binary b/tests/binary
old mode 100644
new mode 100755
diff --git a/tests/colliding-file-names b/tests/colliding-file-names
old mode 100644
new mode 100755
diff --git a/tests/excess-slash b/tests/excess-slash
old mode 100644
new mode 100755
diff --git a/tests/no-newline-at-eof b/tests/no-newline-at-eof
old mode 100644
new mode 100755
=2D-=20
1.7.2.3


--Boundary-00=_0K2kO6zIwVHAlgl--


From MAILER-DAEMON Wed Oct 12 05:27:24 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RDv5w-0001XQ-IC
	for mharc-bug-diffutils@gnu.org; Wed, 12 Oct 2011 05:27:24 -0400
Received: from eggs.gnu.org ([140.186.70.92]:44528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDv5q-0001PG-5l
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 05:27:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDv5a-0005qk-7g
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 05:27:18 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:55793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RDv5Z-0005qa-VH
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 05:27:02 -0400
Received: by wyi40 with SMTP id 40so543550wyi.0
	for <bug-diffutils@gnu.org>; Wed, 12 Oct 2011 02:27:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:references:in-reply-to:mime-version
	:content-type:message-id;
	bh=6VmtLZbhFCVWJ3FadMTh/lMeVq7r8iujaVkVKFSeHdM=;
	b=nY0Fsk8gseOp7+ynYB+z0wlJFXCSZgtxRTjZ00+LqENEntJzmdXOp2pqVeA093QmRA
	t1le20jR7mSLcMQjj312wuNjaTjljoR4as4sHVD3vbjuhSyjPyDRG4Z24hT4xZKgBGY3
	qDRsWofKVHpniAvyGTvfpp2AJyL06Pjgeu2FU=
Received: by 10.227.11.197 with SMTP id u5mr5343844wbu.99.1318411621333;
	Wed, 12 Oct 2011 02:27:01 -0700 (PDT)
Received: from bigio.localnet
	(host43-99-dynamic.20-79-r.retail.telecomitalia.it. [79.20.99.43])
	by mx.google.com with ESMTPS id es5sm2548674wbb.11.2011.10.12.02.26.58
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 12 Oct 2011 02:26:59 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: bug-diffutils@gnu.org
Date: Wed, 12 Oct 2011 11:26:49 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
	<201110102325.08432.stefano.lattarini@gmail.com>
In-Reply-To: <201110102325.08432.stefano.lattarini@gmail.com>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_a1VlOYKqfT1vgw5"
Message-Id: <201110121126.50087.stefano.lattarini@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.169
Subject: [bug-diffutils] [PATCH] tests: use more portable fd redirection in
	TESTS_ENVIRONMENT
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2011 09:27:22 -0000

--Boundary-00=_a1VlOYKqfT1vgw5
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit

You might also want to apply the attached follow-up, with prevents
an unportable usage of fd redirections in TESTS_ENVIRONMENT.

Regards,
  Stefano

--Boundary-00=_a1VlOYKqfT1vgw5
Content-Type: text/x-patch;
  charset="utf-8";
  name="0001-tests-use-more-portable-fd-redirection-in-TESTS_ENVI.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
	filename="0001-tests-use-more-portable-fd-redirection-in-TESTS_ENVI.patch"

=46rom a41fa9b670eab506f9b4daa95c8f96d813424ccc Mon Sep 17 00:00:00 2001
Message-Id: <a41fa9b670eab506f9b4daa95c8f96d813424ccc.1318411600.git.stefan=
o.lattarini@gmail.com>
=46rom: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Wed, 12 Oct 2011 11:11:23 +0200
Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONME=
NT

* tests/Makefile.am (TESTS_ENVIRONMENT): Redirection with `exec 9>&2'
is not portable to various Korn shells, and to (at least) HP-UX 11
/bin/sh.  Use a more portable idiom.
See http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488 for
lots of discussion.
=2D--
 tests/Makefile.am |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 9835ab6..9952d67 100644
=2D-- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -21,7 +21,6 @@ EXTRA_DIST =3D \
 TESTS_ENVIRONMENT =3D				\
   tmp__=3D$$TMPDIR; test -d "$$tmp__" || tmp__=3D.;	\
   TMPDIR=3D$$tmp__; export TMPDIR;		\
=2D  exec 9>&2;					\
   export					\
   VERSION=3D'$(VERSION)'				\
   abs_top_builddir=3D'$(abs_top_builddir)'	\
@@ -40,7 +39,7 @@ TESTS_ENVIRONMENT =3D				\
   PREFERABLY_POSIX_SHELL=3D'$(PREFERABLY_POSIX_SHELL)' \
   REPLACE_GETCWD=3D$(REPLACE_GETCWD)		\
   PATH=3D'$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
=2D  ;
+  ; 9>&2
=20
 LOG_COMPILER=3D $(SHELL)
=20
=2D-=20
1.7.2.3


--Boundary-00=_a1VlOYKqfT1vgw5--


From MAILER-DAEMON Wed Oct 12 13:25:58 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RE2Z4-00036Z-J2
	for mharc-bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:25:58 -0400
Received: from eggs.gnu.org ([140.186.70.92]:50532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2Z2-00036T-Ph
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:25:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2Z0-0006IX-Vp
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:25:56 -0400
Received: from mx.meyering.net ([88.168.87.75]:34608)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2Z0-0006IN-NZ
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:25:54 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id CA1E06006A;
	Wed, 12 Oct 2011 19:25:52 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Stefano Lattarini <stefano.lattarini@gmail.com>
In-Reply-To: <201110102325.08432.stefano.lattarini@gmail.com> (Stefano
	Lattarini's message of "Mon, 10 Oct 2011 23:25:07 +0200")
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
	<201110102325.08432.stefano.lattarini@gmail.com>
Date: Wed, 12 Oct 2011 19:25:52 +0200
Message-ID: <87vcru3yvz.fsf@rho.meyering.net>
Lines: 56
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] [PATCH] tests: make test runner a script,
	not a shell function
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2011 17:25:57 -0000

Stefano Lattarini wrote:
...
> Oops, the patch wasn't exactly right, as it introduced a slight semantic
> change by making the test scripts being executed by the system default
> shell `/bin/sh' rather than by the shell `$(SHELL)' detected at configure
> time.  On some systems (e.g., Solaris 10), the difference is quite
> relevant, since /bin/sh might not be a POSIX-conforming shell.  So the
> following diff should be squashed in:
>
>   diff --git a/tests/Makefile.am b/tests/Makefile.am
>   index 5e2944d..9835ab6 100644
>   --- a/tests/Makefile.am
>   +++ b/tests/Makefile.am
>   @@ -42,6 +42,8 @@ TESTS_ENVIRONMENT =                           \
>      PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
>      ;
>
>   +LOG_COMPILER= $(SHELL)
>   +
>    built_programs =                                                       \
>      echo 'spy:;@echo $$(PROGRAMS)'                                       \
>        | MAKEFLAGS= $(MAKE) -s -C $(builddir)/../src -f Makefile -f - spy \
>
>
> Attached is an updated patch that fixes the issue.
>
> Sorry for the noise,
>   Stefano
> From 5a45c31552df3b32810c92cf3502d8d1d6bfe9ce Mon Sep 17 00:00:00 2001
> Message-Id: <5a45c31552df3b32810c92cf3502d8d1d6bfe9ce.1318281808.git.stefano.lattarini@gmail.com>
> From: Stefano Lattarini <stefano.lattarini@gmail.com>
> Date: Mon, 10 Oct 2011 20:30:21 +0200
> Subject: [PATCH] tests: make test runner a script, not a shell function
>
> All the test scripts in the diffutils testsuite are shell scripts,
> so the current definition of TESTS_ENVIRONMENT, which adaptively
> run tests using either perl or the shell depending on their kind,
> is an overkill.
>
> Moreover, this change is required in order for the testsuite to
> continue to work with the new testsuite harness that is planned
> to be introduced in Automake 1.12 (which, as of the writing date,
> is still under development and in late alpha state).
>
> See also related discussion on bug-coreutils:
>  <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8887>
>
> * tests/Makefile.am (TESTS_ENVIRONMENT): Remove definition of the
> `shell_or_perl_' shell function, which is not required anymore.
> (LOG_COMPILER): New, define to `$(SHELL)'.
> * tests/binary: Make executable.
> * tests/colliding-file-names: Likewise.
> * tests/excess-slash: Likewise.
> * tests/no-newline-at-eof: Likewise.

Thanks.  I've applied it and expect to push soon.


From MAILER-DAEMON Wed Oct 12 13:43:03 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RE2pb-0001Gq-DQ
	for mharc-bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:43:03 -0400
Received: from eggs.gnu.org ([140.186.70.92]:46636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RE2pY-0001GU-Ty
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:43:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RE2pX-0001jb-JY
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:43:00 -0400
Received: from mail-ww0-f49.google.com ([74.125.82.49]:35863)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@gmail.com>) id 1RE2pX-0001iM-F6
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:42:59 -0400
Received: by wwp14 with SMTP id 14so336924wwp.30
	for <bug-diffutils@gnu.org>; Wed, 12 Oct 2011 10:42:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:content-type:content-transfer-encoding:message-id;
	bh=8rKd1HeAg+5CEnxilSXfty5x8FMHd/3sVvzdq28vdwM=;
	b=EDONsavpWfp62Q/ar3wqv3IICkGstyK3f9DRxWO674LbNJC5ILjOK0jE3N5yK4870E
	3aUTRuoGlNlC0L6Rg23HFohHfC+RCNeQ+zOUgn4lFEJZVWVtgnzPt1TiWj056r6cFkA4
	r/uHRTto0vlYONtgzo5ITkcb411OlBWz6YP14=
Received: by 10.216.209.198 with SMTP id s48mr2760073weo.103.1318441377865;
	Wed, 12 Oct 2011 10:42:57 -0700 (PDT)
Received: from bigio.localnet
	(host49-99-dynamic.20-79-r.retail.telecomitalia.it. [79.20.99.49])
	by mx.google.com with ESMTPS id h14sm1259741wbo.7.2011.10.12.10.42.55
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 12 Oct 2011 10:42:56 -0700 (PDT)
From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jim Meyering <jim@meyering.net>
Date: Wed, 12 Oct 2011 19:42:46 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
	<201110102325.08432.stefano.lattarini@gmail.com>
	<87vcru3yvz.fsf@rho.meyering.net>
In-Reply-To: <87vcru3yvz.fsf@rho.meyering.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201110121942.46806.stefano.lattarini@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.49
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] [PATCH] tests: make test runner a script,
	not a shell function
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2011 17:43:02 -0000

On Wednesday 12 October 2011, Jim Meyering wrote:
> Stefano Lattarini wrote:
> ...
> > Oops, the patch wasn't exactly right, as it introduced a slight semantic
> > change by making the test scripts being executed by the system default
> > shell `/bin/sh' rather than by the shell `$(SHELL)' detected at configure
> > time.  On some systems (e.g., Solaris 10), the difference is quite
> > relevant, since /bin/sh might not be a POSIX-conforming shell.  So the
> > following diff should be squashed in:
> >
> >   diff --git a/tests/Makefile.am b/tests/Makefile.am
> >   index 5e2944d..9835ab6 100644
> >   --- a/tests/Makefile.am
> >   +++ b/tests/Makefile.am
> >   @@ -42,6 +42,8 @@ TESTS_ENVIRONMENT =                           \
> >      PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
> >      ;
> >
> >   +LOG_COMPILER= $(SHELL)
> >   +
> >    built_programs =                                                       \
> >      echo 'spy:;@echo $$(PROGRAMS)'                                       \
> >        | MAKEFLAGS= $(MAKE) -s -C $(builddir)/../src -f Makefile -f - spy \
> >
> >
> > Attached is an updated patch that fixes the issue.
> >
> > Sorry for the noise,
> >   Stefano
> > From 5a45c31552df3b32810c92cf3502d8d1d6bfe9ce Mon Sep 17 00:00:00 2001
> > Message-Id: <5a45c31552df3b32810c92cf3502d8d1d6bfe9ce.1318281808.git.stefano.lattarini@gmail.com>
> > From: Stefano Lattarini <stefano.lattarini@gmail.com>
> > Date: Mon, 10 Oct 2011 20:30:21 +0200
> > Subject: [PATCH] tests: make test runner a script, not a shell function
> >
> > All the test scripts in the diffutils testsuite are shell scripts,
> > so the current definition of TESTS_ENVIRONMENT, which adaptively
> > run tests using either perl or the shell depending on their kind,
> > is an overkill.
> >
> > Moreover, this change is required in order for the testsuite to
> > continue to work with the new testsuite harness that is planned
> > to be introduced in Automake 1.12 (which, as of the writing date,
> > is still under development and in late alpha state).
> >
> > See also related discussion on bug-coreutils:
> >  <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8887>
> >
> > * tests/Makefile.am (TESTS_ENVIRONMENT): Remove definition of the
> > `shell_or_perl_' shell function, which is not required anymore.
> > (LOG_COMPILER): New, define to `$(SHELL)'.
> > * tests/binary: Make executable.
> > * tests/colliding-file-names: Likewise.
> > * tests/excess-slash: Likewise.
> > * tests/no-newline-at-eof: Likewise.
> 
> Thanks.  I've applied it and expect to push soon.
> 
Hello Jim .  Hoping it's not too late, I thin k it would be better to
amend the first line of the commit message to read someting like 
"tests: TEST_ENVIRONMENT simplified and made more robust", or similar;
the current wording ("tests: make test runner a script, not a shell
function") is a bit misleading IMHO.

Thanks, and sorry for the noise,
  Stefano



From MAILER-DAEMON Wed Oct 12 13:45:47 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RE2sF-0001QK-R3
	for mharc-bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:45:47 -0400
Received: from eggs.gnu.org ([140.186.70.92]:47136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2sC-0001PX-Vi
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:45:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2sC-00026V-2x
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:45:44 -0400
Received: from mx.meyering.net ([88.168.87.75]:40800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2sB-00026Q-Pr
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:45:44 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id A60556006A;
	Wed, 12 Oct 2011 19:45:41 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Stefano Lattarini <stefano.lattarini@gmail.com>
In-Reply-To: <201110121942.46806.stefano.lattarini@gmail.com> (Stefano
	Lattarini's message of "Wed, 12 Oct 2011 19:42:46 +0200")
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
	<201110102325.08432.stefano.lattarini@gmail.com>
	<87vcru3yvz.fsf@rho.meyering.net>
	<201110121942.46806.stefano.lattarini@gmail.com>
Date: Wed, 12 Oct 2011 19:45:41 +0200
Message-ID: <87k48a3xyy.fsf@rho.meyering.net>
Lines: 11
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] [PATCH] tests: make test runner a script,
	not a shell function
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2011 17:45:45 -0000

Stefano Lattarini wrote:
...
>> Thanks.  I've applied it and expect to push soon.
>>
> Hello Jim .  Hoping it's not too late, I thin k it would be better to
> amend the first line of the commit message to read someting like
> "tests: TEST_ENVIRONMENT simplified and made more robust", or similar;
> the current wording ("tests: make test runner a script, not a shell
> function") is a bit misleading IMHO.

Yes, that would have been better.  Oh well.


From MAILER-DAEMON Wed Oct 12 13:46:54 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RE2tK-0001Uq-V4
	for mharc-bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:46:54 -0400
Received: from eggs.gnu.org ([140.186.70.92]:36250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2tH-0001Tj-U7
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:46:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2tG-0002Fn-Lc
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:46:51 -0400
Received: from mx.meyering.net ([88.168.87.75]:40824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RE2tG-0002Fe-G3
	for bug-diffutils@gnu.org; Wed, 12 Oct 2011 13:46:50 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id E28ED60298;
	Wed, 12 Oct 2011 19:46:48 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Stefano Lattarini <stefano.lattarini@gmail.com>
In-Reply-To: <201110121126.50087.stefano.lattarini@gmail.com> (Stefano
	Lattarini's message of "Wed, 12 Oct 2011 11:26:49 +0200")
References: <9741de6b321f09705fbc3560afa2e0c89e4d63e4.1318271432.git.stefano.lattarini@gmail.com>
	<201110102325.08432.stefano.lattarini@gmail.com>
	<201110121126.50087.stefano.lattarini@gmail.com>
Date: Wed, 12 Oct 2011 19:46:48 +0200
Message-ID: <87ehyi3xx3.fsf@rho.meyering.net>
Lines: 39
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] [PATCH] tests: use more portable fd redirection
	in TESTS_ENVIRONMENT
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2011 17:46:53 -0000

Stefano Lattarini wrote:
> You might also want to apply the attached follow-up, with prevents
> an unportable usage of fd redirections in TESTS_ENVIRONMENT.
>
...
> Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT
>
> * tests/Makefile.am (TESTS_ENVIRONMENT): Redirection with `exec 9>&2'
> is not portable to various Korn shells, and to (at least) HP-UX 11
> /bin/sh.  Use a more portable idiom.
> See http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488 for
> lots of discussion.
> ---
>  tests/Makefile.am |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 9835ab6..9952d67 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -21,7 +21,6 @@ EXTRA_DIST = \
>  TESTS_ENVIRONMENT =				\
>    tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.;	\
>    TMPDIR=$$tmp__; export TMPDIR;		\
> -  exec 9>&2;					\
>    export					\
>    VERSION='$(VERSION)'				\
>    abs_top_builddir='$(abs_top_builddir)'	\
> @@ -40,7 +39,7 @@ TESTS_ENVIRONMENT =				\
>    PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \
>    REPLACE_GETCWD=$(REPLACE_GETCWD)		\
>    PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
> -  ;
> +  ; 9>&2
>
>  LOG_COMPILER= $(SHELL)

Thank you.
Applied.


From MAILER-DAEMON Sun Oct 16 11:56:57 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RFT57-0005Ok-CN
	for mharc-bug-diffutils@gnu.org; Sun, 16 Oct 2011 11:56:57 -0400
Received: from eggs.gnu.org ([140.186.70.92]:53426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1RFT54-0005No-Jn
	for bug-diffutils@gnu.org; Sun, 16 Oct 2011 11:56:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1RFT53-0002xS-CY
	for bug-diffutils@gnu.org; Sun, 16 Oct 2011 11:56:54 -0400
Received: from pizarro.unex.es ([158.49.8.2]:60179)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1RFT53-0002oq-7F
	for bug-diffutils@gnu.org; Sun, 16 Oct 2011 11:56:53 -0400
Received: from localhost (lavadora.siue [192.168.1.121])
	by pizarro.unex.es (Postfix) with ESMTP id D39291480B5;
	Sun, 16 Oct 2011 17:55:26 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at lavadora.unex.es
Received: from pizarro.unex.es ([192.168.1.103])
	by localhost (lavadora.unex.es [192.168.1.121]) (amavisd-new,
	port 10024)
	with ESMTP id uzqmB1sIv+pi; Sun, 16 Oct 2011 17:50:59 +0200 (CEST)
Received: from guadiana.unex.es (guadiana.unex.es [158.49.17.23])
	by pizarro.unex.es (Postfix) with ESMTP id 7444E14800A;
	Sun, 16 Oct 2011 17:55:26 +0200 (CEST)
Received: from cantor.unex.es (cantor.unex.es [158.49.50.20])
	by guadiana.unex.es (Postfix) with ESMTPS id 490544B99B;
	Sun, 16 Oct 2011 17:55:26 +0200 (CEST)
Date: Sun, 16 Oct 2011 17:55:26 +0200 (CEST)
From: Santiago Vila <sanvila@unex.es>
To: bug-diffutils@gnu.org
Message-ID: <alpine.DEB.2.00.1110161751360.3760@cantor.unex.es>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 158.49.8.2
Cc: 514893@bugs.debian.org, 514893-forwarded@bugs.debian.org,
	Michael Stransky <qmysjwxb8zhc25n@temporaryinbox.com>
Subject: [bug-diffutils] Bug#514893: cmp: please allow comparing multiple
	files (fwd)
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Oct 2011 15:56:55 -0000

Hello.

A long time ago, I received this from the Debian bug system.

[ I realize that this is unlikely to be implemented, but I am supposed
to forward upstream bugs upstream in either case ].

Thanks.

---------- Forwarded message ----------
From: Michael Stransky <qmysjwxb8zhc25n@temporaryinbox.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Date: Wed, 11 Feb 2009 19:26:52 +0100
Subject: cmp: please allow comparing multiple files

Package: diff
Version: 2.8.1-11
Severity: wishlist


It would be great if cmp could handle more then 2 files.
cmp -c file1 file2 file3 would output for example: 
(byte file1 file2 file3)
1 100 101 102
2 100 100 101 
7 100 101 102
cmp: EOF on file2.
9 100     102
cmp: EOF on file3.


From MAILER-DAEMON Sun Oct 23 19:39:44 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RI7do-0006dS-TJ
	for mharc-bug-diffutils@gnu.org; Sun, 23 Oct 2011 19:39:44 -0400
Received: from eggs.gnu.org ([140.186.70.92]:48578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RI3wl-0002Cq-UW
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 15:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RI3wk-0001mr-Pe
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 15:43:03 -0400
Received: from mail-qw0-f41.google.com ([209.85.216.41]:44037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RI3wk-0001mj-NH
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 15:43:02 -0400
Received: by qadc11 with SMTP id c11so2208423qad.0
	for <bug-diffutils@gnu.org>; Sun, 23 Oct 2011 12:43:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.185.145 with SMTP id co17mr17450367qab.1.1319398979479;
	Sun, 23 Oct 2011 12:42:59 -0700 (PDT)
Received: by 10.224.2.83 with HTTP; Sun, 23 Oct 2011 12:42:59 -0700 (PDT)
Date: Sun, 23 Oct 2011 21:42:59 +0200
Message-ID: <CABnVS=+oOrNko78DmrR0-Hw1JZZc3PntLh6OyXByeFfRFjERgg@mail.gmail.com>
From: Ben Baron <ben@logicalso.com>
To: bug-diffutils@gnu.org
Content-Type: multipart/mixed; boundary=20cf30334dc57d2a2b04affc832b
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 209.85.216.41
X-Mailman-Approved-At: Sun, 23 Oct 2011 19:39:43 -0400
Subject: [bug-diffutils] diff bug (with test files)
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Oct 2011 19:43:04 -0000

--20cf30334dc57d2a2b04affc832b
Content-Type: multipart/alternative; boundary=20cf30334dc57d2a2704affc8329

--20cf30334dc57d2a2704affc8329
Content-Type: text/plain; charset=ISO-8859-1

hi,
first of all, thank you all people at GNU for your hard work (appreciated!).
doing a diff between the two files (attached) will give incorrect results:
shows the last line as changed (while it's the same).

Kind regards,
Ben Baron
Logical Solutions
Hardware and Software Development
Mobile: +972-54-6501852
www.LogicalSo.com

--20cf30334dc57d2a2704affc8329
Content-Type: text/html; charset=ISO-8859-1

<div dir="ltr">hi,<br>first of all, thank you all people at GNU for your hard work (appreciated!).<br>doing a diff between the two files (attached) will give incorrect results: shows the last line as changed (while it&#39;s the same).<br>
<br clear="all"><div dir="ltr">Kind regards,<br>Ben Baron<br>Logical Solutions<br>Hardware and Software Development<br>Mobile: +972-54-6501852<br><a href="http://www.LogicalSo.com" target="_blank">www.LogicalSo.com</a><br>
</div><br>
</div>

--20cf30334dc57d2a2704affc8329--
--20cf30334dc57d2a2b04affc832b
Content-Type: application/zip; name="tests.zip"
Content-Disposition: attachment; filename="tests.zip"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gu4g8mj20

UEsDBBQAAgAIALis0jzU6iHjRAAAAFYAAAAFAAAAMS50eHRz9nAMCHENUjC04uXKSM3JyVfIKM1N
zCvW4eUqT81Jzs9NhYkn5mSmooqn5+enKCRVAlnFqakKlYkKOYklqUW8XLxcAFBLAwQUAAIACAC8
rNI8jAvO4UMAAABLAAAABQAAADIudHh0c/ZwDAhxDVIwtOLlykjNyclXyCjNTcwr1oFxE3MyU8Hc
8tSc5PzcVF6u9Pz8FIW8zPSMEl6u4tRUhcpEhZzEktQiAFBLAQIUABQAAgAIALis0jzU6iHjRAAA
AFYAAAAFAAAAAAAAAAEAIAAAAAAAAAAxLnR4dFBLAQIUABQAAgAIALys0jyMC87hQwAAAEsAAAAF
AAAAAAAAAAEAIAAAAGcAAAAyLnR4dFBLBQYAAAAAAgACAGYAAADNAAAAAAA=
--20cf30334dc57d2a2b04affc832b--


From MAILER-DAEMON Sun Oct 23 20:40:23 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RI8aV-00061n-VV
	for mharc-bug-diffutils@gnu.org; Sun, 23 Oct 2011 20:40:23 -0400
Received: from eggs.gnu.org ([140.186.70.92]:34529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1RI8aT-000617-OM
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 20:40:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1RI8aS-0004l9-T3
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 20:40:21 -0400
Received: from smtp.cs.ucla.edu ([131.179.128.62]:41604)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1RI8aS-0004kS-Nu
	for bug-diffutils@gnu.org; Sun, 23 Oct 2011 20:40:20 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp.cs.ucla.edu (Postfix) with ESMTP id 07E95A60005;
	Sun, 23 Oct 2011 17:40:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu
Received: from smtp.cs.ucla.edu ([127.0.0.1])
	by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id m766elLKw9E5; Sun, 23 Oct 2011 17:40:10 -0700 (PDT)
Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net
	[71.189.109.235])
	by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B1478A60002;
	Sun, 23 Oct 2011 17:40:10 -0700 (PDT)
Message-ID: <4EA4B3ED.4010507@cs.ucla.edu>
Date: Sun, 23 Oct 2011 17:40:13 -0700
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: Ben Baron <ben@logicalso.com>
References: <CABnVS=+oOrNko78DmrR0-Hw1JZZc3PntLh6OyXByeFfRFjERgg@mail.gmail.com>
In-Reply-To: <CABnVS=+oOrNko78DmrR0-Hw1JZZc3PntLh6OyXByeFfRFjERgg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 131.179.128.62
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] diff bug (with test files)
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 00:40:22 -0000

On 10/23/11 12:42, Ben Baron wrote:
> shows the last line as changed (while it's the same).

In one file, that line has a newline appended,
in the other, the newline is missing.  That is
why diff thinks the line has changed.  If you
prefer diff to ignore the missing newline,
you can use the -b option.


From MAILER-DAEMON Mon Oct 24 05:29:22 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RIGqQ-00026e-VE
	for mharc-bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:29:22 -0400
Received: from eggs.gnu.org ([140.186.70.92]:39408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RIGqM-00025l-Is
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:29:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RIGqK-0008VM-SA
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:29:18 -0400
Received: from mail-qw0-f41.google.com ([209.85.216.41]:40490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ben@logicalso.com>) id 1RIGqK-0008VE-MC
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:29:16 -0400
Received: by qadc11 with SMTP id c11so2403898qad.0
	for <bug-diffutils@gnu.org>; Mon, 24 Oct 2011 02:29:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.177.78 with SMTP id bh14mr13503369qab.14.1319448555416;
	Mon, 24 Oct 2011 02:29:15 -0700 (PDT)
Received: by 10.224.2.83 with HTTP; Mon, 24 Oct 2011 02:29:15 -0700 (PDT)
In-Reply-To: <4EA4B3ED.4010507@cs.ucla.edu>
References: <CABnVS=+oOrNko78DmrR0-Hw1JZZc3PntLh6OyXByeFfRFjERgg@mail.gmail.com>
	<4EA4B3ED.4010507@cs.ucla.edu>
Date: Mon, 24 Oct 2011 11:29:15 +0200
Message-ID: <CABnVS=+y+AqQ_+Os0MLtkE7rMv_F8phJqjA1kDBD-utVUeZr4A@mail.gmail.com>
From: Ben Baron <ben@logicalso.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Content-Type: multipart/alternative; boundary=20cf30334a0771ed9804b0080e95
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 209.85.216.41
Cc: bug-diffutils@gnu.org
Subject: Re: [bug-diffutils] diff bug (with test files)
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 09:29:19 -0000

--20cf30334a0771ed9804b0080e95
Content-Type: text/plain; charset=ISO-8859-1

Thank you, sorry. i didn't know the "blank lines" switch also affects
trailing EOL on non-empty lines.

Kind regards,
Ben Baron
Logical Solutions
Hardware and Software Development
Mobile: +972-54-6501852
www.LogicalSo.com



On Mon, Oct 24, 2011 at 2:40 AM, Paul Eggert <eggert@cs.ucla.edu> wrote:

> On 10/23/11 12:42, Ben Baron wrote:
> > shows the last line as changed (while it's the same).
>
> In one file, that line has a newline appended,
> in the other, the newline is missing.  That is
> why diff thinks the line has changed.  If you
> prefer diff to ignore the missing newline,
> you can use the -b option.
>

--20cf30334a0771ed9804b0080e95
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thank you, sorry. i didn&#39;t know the &quot;blank lines&=
quot; switch also affects trailing EOL on non-empty lines. <br><br clear=3D=
"all"><div dir=3D"ltr">Kind regards,<br>Ben Baron<br>Logical Solutions<br>H=
ardware and Software Development<br>
Mobile: +972-54-6501852<br><a href=3D"http://www.LogicalSo.com" target=3D"_=
blank">www.LogicalSo.com</a><br></div><br>
<br><br><div class=3D"gmail_quote">On Mon, Oct 24, 2011 at 2:40 AM, Paul Eg=
gert <span dir=3D"ltr">&lt;<a href=3D"mailto:eggert@cs.ucla.edu">eggert@cs.=
ucla.edu</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; p=
adding-left: 1ex;">
<div class=3D"im">On 10/23/11 12:42, Ben Baron wrote:<br>
&gt; shows the last line as changed (while it&#39;s the same).<br>
<br>
</div>In one file, that line has a newline appended,<br>
in the other, the newline is missing. =A0That is<br>
why diff thinks the line has changed. =A0If you<br>
prefer diff to ignore the missing newline,<br>
you can use the -b option.<br>
</blockquote></div><br></div>

--20cf30334a0771ed9804b0080e95--


From MAILER-DAEMON Mon Oct 24 05:58:44 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RIHIq-00022U-Ho
	for mharc-bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:58:44 -0400
Received: from eggs.gnu.org ([140.186.70.92]:33327)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RIHIl-0001yt-V5
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:58:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RIHIk-00056A-Dk
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:58:39 -0400
Received: from mx.meyering.net ([88.168.87.75]:60732)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RIHIk-00055t-8B
	for bug-diffutils@gnu.org; Mon, 24 Oct 2011 05:58:38 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id B783A6004E;
	Mon, 24 Oct 2011 11:58:35 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Santiago Vila <sanvila@unex.es>
In-Reply-To: <alpine.DEB.2.00.1110161751360.3760@cantor.unex.es> (Santiago
	Vila's message of "Sun, 16 Oct 2011 17:55:26 +0200 (CEST)")
References: <alpine.DEB.2.00.1110161751360.3760@cantor.unex.es>
Date: Mon, 24 Oct 2011 11:58:35 +0200
Message-ID: <87vcred838.fsf@rho.meyering.net>
Lines: 39
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org, 514893@bugs.debian.org,
	Michael Stransky <qmysjwxb8zhc25n@temporaryinbox.com>
Subject: Re: [bug-diffutils] Bug#514893: cmp: please allow comparing
	multiple files (fwd)
X-BeenThere: bug-diffutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 09:58:41 -0000

Santiago Vila wrote:
> A long time ago, I received this from the Debian bug system.
>
> [ I realize that this is unlikely to be implemented, but I am supposed
> to forward upstream bugs upstream in either case ].

Thanks for forwarding that.
However, I'll bet you can do something similar with od and a program
that can show differences in 3 files.  Here's how you can come close
using only two inputs with sdiff:

    $ f() { od -Anone -w1 -v -tc "$@"; }
    $ sdiff -w14 <(printf 'a\x06\xff\n'|f) <(printf 'a\x05\xff\n'|f)
       a       a
     006  |  005
     377     377
      \n      \n
    [Exit 1]

> ---------- Forwarded message ----------
> From: Michael Stransky <qmysjwxb8zhc25n@temporaryinbox.com>
> To: Debian Bug Tracking System <submit@bugs.debian.org>
> Date: Wed, 11 Feb 2009 19:26:52 +0100
> Subject: cmp: please allow comparing multiple files
>
> Package: diff
> Version: 2.8.1-11
> Severity: wishlist
>
>
> It would be great if cmp could handle more then 2 files.
> cmp -c file1 file2 file3 would output for example:
> (byte file1 file2 file3)
> 1 100 101 102
> 2 100 100 101
> 7 100 101 102
> cmp: EOF on file2.
> 9 100     102
> cmp: EOF on file3.


