From MAILER-DAEMON Tue Dec 09 01:09:15 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XyDz1-00056M-Qj
	for mharc-bug-diffutils@gnu.org; Tue, 09 Dec 2014 01:09:15 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyDyu-00056G-9B
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 01:09:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyDyo-0007L6-66
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 01:09:08 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:33039)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyDyo-0007Kw-2B
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 01:09:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyDyn-0004wA-L5
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 01:09:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: KO Myung-Hun <komh78@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 09 Dec 2014 06:09:01 +0000
Resent-Message-ID: <handler.19186.B19186.141810530818934@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 19186@debbugs.gnu.org
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141810530818934
	(code B ref 19186); Tue, 09 Dec 2014 06:09:01 +0000
Received: (at 19186) by debbugs.gnu.org; 9 Dec 2014 06:08:28 +0000
Received: from localhost ([127.0.0.1]:58485 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XyDyG-0004vJ-CX
	for submit@debbugs.gnu.org; Tue, 09 Dec 2014 01:08:28 -0500
Received: from mail-pa0-f42.google.com ([209.85.220.42]:44690)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <komh78@gmail.com>) id 1XyDyE-0004vC-N5
	for 19186@debbugs.gnu.org; Tue, 09 Dec 2014 01:08:27 -0500
Received: by mail-pa0-f42.google.com with SMTP id et14so6786876pad.1
	for <19186@debbugs.gnu.org>; Mon, 08 Dec 2014 22:08:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=from:message-id:date:user-agent:mime-version:newsgroups:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=Us8Oy3kgHZI5GQ+XOc883rmHanqunLGVdsJPmYvJYCA=;
	b=lVJS/WwEnFvwmC1v19v77I4BeWcQuI0zDk6VuKwEnyVt3s+bBfVY04fm2CtpcNeWdh
	Ngavbl2lEAzv0c3RapZmNYh3cMCw1D3qEPtZkrhdf4JFl9zEsXpwfDSXXQLyI0Fix9Jk
	lt6TXa3x8u815uqNFycPjCcswk80ejV+5PT2Wg38Kt16FPsqEkJEgyxkg8fabR1VotrF
	ArOgAIY2F2zm+erGCH0L4u7pwCRTk9wLVaK7hBzvHNTim9bCjEqChZVPHqXURcxvDosH
	b2rFYrTWeChWIgxElLMmkFQXDGt7OCcGMVvAkYSznizXhAHNF+/xD5egXYMFyEHrsnRs
	IaLA==
X-Received: by 10.70.13.1 with SMTP id d1mr27888653pdc.132.1418105305815;
	Mon, 08 Dec 2014 22:08:25 -0800 (PST)
Received: from [10.0.2.15] ([211.244.64.26])
	by mx.google.com with ESMTPSA id f12sm336978pat.43.2014.12.08.22.08.23
	for <19186@debbugs.gnu.org>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Mon, 08 Dec 2014 22:08:24 -0800 (PST)
From: KO Myung-Hun <komh78@gmail.com>
X-Google-Original-From: KO Myung-Hun <komh@chollian.net>
Message-ID: <548691D3.9060805@chollian.net>
Date: Tue, 09 Dec 2014 15:08:19 +0900
User-Agent: Mozilla/5.0 (OS/2; Warp 4.5;
	rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre
	SeaMonkey/2.7.2
MIME-Version: 1.0
Newsgroups: gmane.comp.gnu.diffutils.bugs
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=EUC-KR
Content-Transfer-Encoding: 7bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Subject: [bug-diffutils] bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Dec 2014 06:09:14 -0000

Ping ?

KO Myung-Hun wrote:
> Hi/2.
> 
> These are OS/2 patches.
> 
> Review, please...
> 
> [PATCH 1/2] build: use quotation mark(") for PATH
> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
> 
> 
> 
> 

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr





From MAILER-DAEMON Tue Dec 09 10:59:13 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XyNBx-00048F-CW
	for mharc-bug-diffutils@gnu.org; Tue, 09 Dec 2014 10:59:13 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyNBr-00047n-4M
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 10:59:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyNBm-0003P7-A5
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 10:59:07 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyNBm-0003P3-6I
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 10:59:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XyNBl-0005zQ-TX
	for bug-diffutils@gnu.org; Tue, 09 Dec 2014 10:59:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 09 Dec 2014 15:59:01 +0000
Resent-Message-ID: <handler.19186.B19186.141814071322986@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: KO Myung-Hun <komh78@gmail.com>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141814071322986
	(code B ref 19186); Tue, 09 Dec 2014 15:59:01 +0000
Received: (at 19186) by debbugs.gnu.org; 9 Dec 2014 15:58:33 +0000
Received: from localhost ([127.0.0.1]:59836 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XyNBI-0005yg-Rh
	for submit@debbugs.gnu.org; Tue, 09 Dec 2014 10:58:33 -0500
Received: from mail-yk0-f182.google.com ([209.85.160.182]:55664)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1XyNBF-0005yW-V9
	for 19186@debbugs.gnu.org; Tue, 09 Dec 2014 10:58:30 -0500
Received: by mail-yk0-f182.google.com with SMTP id 131so377709ykp.13
	for <19186@debbugs.gnu.org>; Tue, 09 Dec 2014 07:58:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=/RQq4HwvXWCg3rIfd4dnNvQYoM5HaPzmCEBeDbDxdE4=;
	b=nSwO4Q1ruMPbb2Mo5+FynM0iaRsMnSYa3pF9Oe+i43nndxTgOqCY19kkBJvMv7lnRU
	gIyMf4DwMynZd/AqcGh385akh4q6DljnY3mjQ+XesTjS/LPnAWXTPl3H8nqPnRD7DYHl
	vL0EXg6gOY5a9h76qXrFAXVoYrMTuOzPr7DW1751I5ePn55wykU6SFnyp03FPDJkc0dv
	EoVf10b3TRARPbgzn50vrc4Hrl3e7hoO3POItcJlQlE5R5vwtpCff3XTWAbYWe8eHlmN
	PosXrez06P00P2MYhSVp/xWpH4+HdZvj3knSNBJ5UvdY+2f0cOiDCfaXIK5AVz5/RZfE
	2QmA==
X-Received: by 10.170.160.137 with SMTP id b131mr4174263ykd.92.1418140709268; 
	Tue, 09 Dec 2014 07:58:29 -0800 (PST)
MIME-Version: 1.0
Received: by 10.170.139.67 with HTTP; Tue, 9 Dec 2014 07:58:09 -0800 (PST)
In-Reply-To: <1416968979-56894-1-git-send-email-komh@chollian.net>
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
From: Jim Meyering <jim@meyering.net>
Date: Tue, 9 Dec 2014 07:58:09 -0800
X-Google-Sender-Auth: YFBlibrY_mEHKnn20YY6nA0j0os
Message-ID: <CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Dec 2014 15:59:12 -0000

On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
> Hi/2.
>
> These are OS/2 patches.
>
> Review, please...
>
> [PATCH 1/2] build: use quotation mark(") for PATH
> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC

I saw no patches here, but was able to dig them out of the
bug-tracking system at http://debbugs.gnu.org/19186.
I have applied and pushed the first one.  Thank you.

However, for the second, my inclination is that if at all possible,
it should be fixed via an lseek replacement that does something
more sensible. Of course, that may not be possible, but from
what you've presented so far, I cannot tell. Please demonstrate
a use of diff that shows how OS/2+kLIBC's lseek fails.




From MAILER-DAEMON Thu Dec 11 00:38:16 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XywS8-0006Ty-Tp
	for mharc-bug-diffutils@gnu.org; Thu, 11 Dec 2014 00:38:16 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XywS1-0006Sv-Ia
	for bug-diffutils@gnu.org; Thu, 11 Dec 2014 00:38:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XywRw-0004L8-BS
	for bug-diffutils@gnu.org; Thu, 11 Dec 2014 00:38:09 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:32873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XywRw-0004L3-8W
	for bug-diffutils@gnu.org; Thu, 11 Dec 2014 00:38:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XywRv-0005fq-TQ
	for bug-diffutils@gnu.org; Thu, 11 Dec 2014 00:38:04 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: KO Myung-Hun <komh78@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 11 Dec 2014 05:38:03 +0000
Resent-Message-ID: <handler.19186.B19186.141827624021751@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141827624021751
	(code B ref 19186); Thu, 11 Dec 2014 05:38:03 +0000
Received: (at 19186) by debbugs.gnu.org; 11 Dec 2014 05:37:20 +0000
Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XywRE-0005el-6H
	for submit@debbugs.gnu.org; Thu, 11 Dec 2014 00:37:20 -0500
Received: from mail-pd0-f170.google.com ([209.85.192.170]:51517)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <komh78@gmail.com>) id 1XywRB-0005eS-H4
	for 19186@debbugs.gnu.org; Thu, 11 Dec 2014 00:37:18 -0500
Received: by mail-pd0-f170.google.com with SMTP id v10so4307727pde.1
	for <19186@debbugs.gnu.org>; Wed, 10 Dec 2014 21:37:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=7EZc1wQdPvtC1dLLnIXESkduIQCZZPDRiwFBjCZgBeA=;
	b=xIxiM4IvUzS8eK/GchesK+/nvANoLZVEo83QOnwaw3tfaZO8rGQ19Euofzt6PjlfFZ
	CKqjvG9hr/nKYftee07tOpnSqTdxDpXvQaiJEcHH6OZc+HDVkhgDbDkSoR8IPbK1XWQf
	wGKqDv9paO/yQhRLlzpsetEnvA3C1ukiVfZWFkngBjuCicpDZU0CrBgHisSDX1lRiTDG
	Ui/W3yvugrcEtqGn38lqBn4r0cNHRKMRxF1ueOGGKYsetoNJWIY7T/ltP5K/FhirI50o
	mybpNCp6rUhanlEcdbqE1r3sfwp8jn5msJbuJ/bJieSwV07w6rKDXkxGvEGNjPTI1lIa
	cKYA==
X-Received: by 10.68.65.2 with SMTP id t2mr13817176pbs.39.1418276231423;
	Wed, 10 Dec 2014 21:37:11 -0800 (PST)
Received: from [10.0.2.15] ([211.244.64.26])
	by mx.google.com with ESMTPSA id zn2sm159057pbb.41.2014.12.10.21.37.08
	for <multiple recipients>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Wed, 10 Dec 2014 21:37:10 -0800 (PST)
Message-ID: <54892D87.9000206@gmail.com>
Date: Thu, 11 Dec 2014 14:37:11 +0900
From: KO Myung-Hun <komh78@gmail.com>
User-Agent: Mozilla/5.0 (OS/2; Warp 4.5;
	rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre
	SeaMonkey/2.7.2
MIME-Version: 1.0
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
In-Reply-To: <CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Dec 2014 05:38:15 -0000



Jim Meyering wrote:
> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>> Hi/2.
>>
>> These are OS/2 patches.
>>
>> Review, please...
>>
>> [PATCH 1/2] build: use quotation mark(") for PATH
>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
> 
> I saw no patches here, but was able to dig them out of the
> bug-tracking system at http://debbugs.gnu.org/19186.
> I have applied and pushed the first one.  Thank you.
> 
> However, for the second, my inclination is that if at all possible,
> it should be fixed via an lseek replacement that does something
> more sensible. Of course, that may not be possible, but from
> what you've presented so far, I cannot tell. Please demonstrate
> a use of diff that shows how OS/2+kLIBC's lseek fails.

Do you want this ?

-----
$ cat file | diff - file
diff.exe: -: Invalid seek
-----


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr





From MAILER-DAEMON Fri Dec 12 10:57:14 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XzSag-0006kc-Q4
	for mharc-bug-diffutils@gnu.org; Fri, 12 Dec 2014 10:57:14 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzSaa-0006iu-Bd
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 10:57:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzSaV-0002WG-F1
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 10:57:08 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzSaV-0002W1-B3
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 10:57:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzSaU-0005Xd-1h
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 10:57:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Fri, 12 Dec 2014 15:57:01 +0000
Resent-Message-ID: <handler.19186.B19186.141839981921292@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: KO Myung-Hun <komh78@gmail.com>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141839981921292
	(code B ref 19186); Fri, 12 Dec 2014 15:57:01 +0000
Received: (at 19186) by debbugs.gnu.org; 12 Dec 2014 15:56:59 +0000
Received: from localhost ([127.0.0.1]:44096 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XzSaQ-0005XM-O9
	for submit@debbugs.gnu.org; Fri, 12 Dec 2014 10:56:58 -0500
Received: from mail-yk0-f177.google.com ([209.85.160.177]:45422)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1XzSaO-0005X6-Dt
	for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 10:56:56 -0500
Received: by mail-yk0-f177.google.com with SMTP id 9so3199287ykp.8
	for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 07:56:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=HjpVchDveqhqeTTEYNxia/v1ElJ80AXMIlcUkU5TY5Y=;
	b=k+FAynqK/0kkbTLy7MeTb2wtQC0Rkaz2zeeTaRDtBeMBa1xETaiCPtEvurLbtNfrnE
	xgbl0RQGyfjytn00QcVgYuM8kS0RycOOqoiAtI31SO8bbG2U/6uvevJRoVF7KKLY1Omm
	22YZShtrhpua6ij3lO9f8j1oIWPV0UW/pmnxcwCMktInYRzbjFruWp2AoAYtwd+20jmV
	XsFDL78uLoLzwXiGoYMj+mXbSMBai+h9Zu5LiSgH5O4inINQ7Xdvzh3382kGpTrBjxp3
	TpKQRYr0L8rZy8f3DWVFrDz3pH0jkLUZrflyTNDjJIzAscxyzn5rmnKIrTm7UPQwDG7n
	pGKg==
X-Received: by 10.170.174.213 with SMTP id q204mr13787469ykd.114.1418399810438;
	Fri, 12 Dec 2014 07:56:50 -0800 (PST)
MIME-Version: 1.0
Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 07:56:29 -0800 (PST)
In-Reply-To: <54892D87.9000206@gmail.com>
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
	<54892D87.9000206@gmail.com>
From: Jim Meyering <jim@meyering.net>
Date: Fri, 12 Dec 2014 07:56:29 -0800
X-Google-Sender-Auth: PH33bpJ1CoTKy2XSSlDKpCyM_bY
Message-ID: <CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2014 15:57:13 -0000

On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78@gmail.com> wrote:
> Jim Meyering wrote:
>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>> Hi/2.
>>>
>>> These are OS/2 patches.
>>>
>>> Review, please...
>>>
>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>
>> I saw no patches here, but was able to dig them out of the
>> bug-tracking system at http://debbugs.gnu.org/19186.
>> I have applied and pushed the first one.  Thank you.
>>
>> However, for the second, my inclination is that if at all possible,
>> it should be fixed via an lseek replacement that does something
>> more sensible. Of course, that may not be possible, but from
>> what you've presented so far, I cannot tell. Please demonstrate
>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>
> Do you want this ?
>
> -----
> $ cat file | diff - file
> diff.exe: -: Invalid seek
> -----

Yes.  Thanks. That shows how lseek-pipe fails on your system.
Please adjust your patch to make diff ignore failure only in that case,
i.e., when errno == EINVAL (assuming strerror(EINVAL)
produces that diagnostic).




From MAILER-DAEMON Fri Dec 12 22:25:15 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XzdKV-00005C-GI
	for mharc-bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:25:15 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdKO-0008Up-Dk
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:25:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdKJ-0003R8-3S
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:25:08 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdKI-0003Qd-Vt
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:25:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdKI-0007AQ-FD
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:25:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: KO Myung-Hun <komh78@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 13 Dec 2014 03:25:02 +0000
Resent-Message-ID: <handler.19186.B19186.141844108627523@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141844108627523
	(code B ref 19186); Sat, 13 Dec 2014 03:25:02 +0000
Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 03:24:46 +0000
Received: from localhost ([127.0.0.1]:44317 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XzdK2-00079r-5l
	for submit@debbugs.gnu.org; Fri, 12 Dec 2014 22:24:46 -0500
Received: from mail-pd0-f181.google.com ([209.85.192.181]:44631)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <komh78@gmail.com>) id 1XzdJz-00079Y-9j
	for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 22:24:44 -0500
Received: by mail-pd0-f181.google.com with SMTP id v10so8164431pde.26
	for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 19:24:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=I13+B18o1S/DhBZtdlCqo2pT1XD46Kn1Exvqel9at4w=;
	b=hj/elLqeLj0rVa4RIfteDvj8syGPTFFkAeqN47b2gneTkweFMSjFZi8aVXXSO+L0bx
	pYaB8/IzAy8q8XXUdTD9Hh16EZCdCf8uZNhkuFXdFvFLKnaeD3ZJF6VgvmmV7cpwkrzp
	Qzj8oNwu/1Cew5Tx2X/2UPuctIlNU9OWEOGTZggmjQgMpla1pRahYf7MYZPuruIi0CrP
	x1Ue2taHqH1P3EuMSEZTdnbSLRFQvF3apCmuDsjCXom1rquMAyTsEUWMybt/FRiVOBCe
	qUL0ItGIye8sG7ypZsVtlTZxEje+o57TogjZnrVqgCo4Juz4j0PaYyMeQruIYBqM608m
	54/A==
X-Received: by 10.70.88.47 with SMTP id bd15mr21962204pdb.54.1418441077286;
	Fri, 12 Dec 2014 19:24:37 -0800 (PST)
Received: from [10.0.2.15] ([211.244.64.26])
	by mx.google.com with ESMTPSA id vy1sm2807552pac.20.2014.12.12.19.24.34
	for <multiple recipients>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Fri, 12 Dec 2014 19:24:36 -0800 (PST)
Message-ID: <548BB17A.20602@gmail.com>
Date: Sat, 13 Dec 2014 12:24:42 +0900
From: KO Myung-Hun <komh78@gmail.com>
User-Agent: Mozilla/5.0 (OS/2; Warp 4.5;
	rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre
	SeaMonkey/2.7.2
MIME-Version: 1.0
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
	<54892D87.9000206@gmail.com>
	<CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
In-Reply-To: <CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Dec 2014 03:25:13 -0000



Jim Meyering wrote:
> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>> Jim Meyering wrote:
>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>> Hi/2.
>>>>
>>>> These are OS/2 patches.
>>>>
>>>> Review, please...
>>>>
>>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>>
>>> I saw no patches here, but was able to dig them out of the
>>> bug-tracking system at http://debbugs.gnu.org/19186.
>>> I have applied and pushed the first one.  Thank you.
>>>
>>> However, for the second, my inclination is that if at all possible,
>>> it should be fixed via an lseek replacement that does something
>>> more sensible. Of course, that may not be possible, but from
>>> what you've presented so far, I cannot tell. Please demonstrate
>>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>>
>> Do you want this ?
>>
>> -----
>> $ cat file | diff - file
>> diff.exe: -: Invalid seek
>> -----
> 
> Yes.  Thanks. That shows how lseek-pipe fails on your system.
> Please adjust your patch to make diff ignore failure only in that case,
> i.e., when errno == EINVAL (assuming strerror(EINVAL)
> produces that diagnostic).

Do you mean to add errno == EINVAL to if() for pfatal_with_name() ?

Then contents read from pipe are consumed and cannot be recovered. So
diff behaves in wrong way.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr





From MAILER-DAEMON Fri Dec 12 22:52:13 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Xzdkb-0002Dg-Lh
	for mharc-bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:52:13 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdkV-0002Cd-J6
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:52:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdkQ-0003UN-On
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:52:07 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdkQ-0003UI-KV
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzdkQ-0007sL-6Q
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 22:52:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 13 Dec 2014 03:52:02 +0000
Resent-Message-ID: <handler.19186.B19186.141844271130256@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: KO Myung-Hun <komh78@gmail.com>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141844271130256
	(code B ref 19186); Sat, 13 Dec 2014 03:52:02 +0000
Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 03:51:51 +0000
Received: from localhost ([127.0.0.1]:44321 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XzdkE-0007rw-MB
	for submit@debbugs.gnu.org; Fri, 12 Dec 2014 22:51:51 -0500
Received: from mail-yk0-f181.google.com ([209.85.160.181]:53750)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1XzdkB-0007ri-IG
	for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 22:51:48 -0500
Received: by mail-yk0-f181.google.com with SMTP id 142so3644593ykq.12
	for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 19:51:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=kOwKGxQF85aC+p68VGaQSrKj8Dzfhs5aos2B6bZ3sgg=;
	b=h1AJ35KTbFjyXFHO6rwdbQ543aot7dZT2NqiybuRuxOlENXHt5g5KV93JpbCsN72CB
	nzPyOeGi+oCgbRD6MC86ZWqyojB13M80/WCUBydJaarf94IUsnA5Gfi5uYgbxeLFcROb
	gTCQ1UcaFFRsduxAI76Ay/fzuaIfDQCvpPAVtJDjuHWQvkkjOCoeW26wqZcysoarmDp5
	pq1e5jb8rfg+a3l6vvOEgjMkYMZX0JqoYYk9+P5ritEPh6VWh3dLX5Av0HfYOP1WflHy
	oBigSpc8df3jNYjt76b7GKWdzwWCW6EDtF3Kow5+CqfJR5zYjoapOuSmufb80la1cGtb
	TdCA==
X-Received: by 10.236.220.194 with SMTP id o62mr14396493yhp.32.1418442702019; 
	Fri, 12 Dec 2014 19:51:42 -0800 (PST)
MIME-Version: 1.0
Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 19:51:21 -0800 (PST)
In-Reply-To: <548BB17A.20602@gmail.com>
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
	<54892D87.9000206@gmail.com>
	<CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
	<548BB17A.20602@gmail.com>
From: Jim Meyering <jim@meyering.net>
Date: Fri, 12 Dec 2014 19:51:21 -0800
X-Google-Sender-Auth: e9erxKr7vFQZkMonWotfpJU9I0A
Message-ID: <CA+8g5KHF2EPEgyGfvCC6q06oCzBc0swh1FAKoy5ve+yGA0dTgQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Dec 2014 03:52:12 -0000

On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>
>
> Jim Meyering wrote:
>> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>> Jim Meyering wrote:
>>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>>> Hi/2.
>>>>>
>>>>> These are OS/2 patches.
>>>>>
>>>>> Review, please...
>>>>>
>>>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>>>
>>>> I saw no patches here, but was able to dig them out of the
>>>> bug-tracking system at http://debbugs.gnu.org/19186.
>>>> I have applied and pushed the first one.  Thank you.
>>>>
>>>> However, for the second, my inclination is that if at all possible,
>>>> it should be fixed via an lseek replacement that does something
>>>> more sensible. Of course, that may not be possible, but from
>>>> what you've presented so far, I cannot tell. Please demonstrate
>>>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>>>
>>> Do you want this ?
>>>
>>> -----
>>> $ cat file | diff - file
>>> diff.exe: -: Invalid seek
>>> -----
>>
>> Yes.  Thanks. That shows how lseek-pipe fails on your system.
>> Please adjust your patch to make diff ignore failure only in that case,
>> i.e., when errno == EINVAL (assuming strerror(EINVAL)
>> produces that diagnostic).
>
> Do you mean to add errno == EINVAL to if() for pfatal_with_name() ?

No.
Skip the test only when this lseek fails with precisely that errno value:

+#ifdef __KLIBC__
+      /* Skip test if seek is not possible */
+      skip_test = skip_test || lseek (current->desc, 0, SEEK_CUR) < 0;
+#endif




From MAILER-DAEMON Fri Dec 12 23:19:14 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1XzeAk-0004ar-31
	for mharc-bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:19:14 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzeAd-0004aE-Rw
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:19:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzeAY-0001JO-U2
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:19:07 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzeAY-0001JF-Qv
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzeAY-00005E-IE
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:19:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: KO Myung-Hun <komh78@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 13 Dec 2014 04:19:02 +0000
Resent-Message-ID: <handler.19186.B19186.141844433332764@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 19186-submit@debbugs.gnu.org id=B19186.141844433332764
	(code B ref 19186); Sat, 13 Dec 2014 04:19:02 +0000
Received: (at 19186) by debbugs.gnu.org; 13 Dec 2014 04:18:53 +0000
Received: from localhost ([127.0.0.1]:44325 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XzeAO-0008WO-51
	for submit@debbugs.gnu.org; Fri, 12 Dec 2014 23:18:52 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:55021)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <komh78@gmail.com>) id 1XzeAL-0008W7-4X
	for 19186@debbugs.gnu.org; Fri, 12 Dec 2014 23:18:50 -0500
Received: by mail-pa0-f45.google.com with SMTP id lf10so7834476pab.4
	for <19186@debbugs.gnu.org>; Fri, 12 Dec 2014 20:18:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type;
	bh=cwkwrDyl6p3WBt7Y2yqw8nf6sfIb9MLoaCTdlY17dzo=;
	b=BUnx312RW1PfxUdDFddbqd2kD8ivJfIM2uy49hpAFUxeze6BT3JpSG0KrSxweS3P+s
	hxMQzFO6z7s7Cl9RtsNRaL/HfDIJi8tUFlSQK66PWYxa2rb4j0C/X3ciiMPsBLWxs9CV
	+XWo7EY8b5S0v3T4lGKzGzOvzFsyHNKYWm6JEvJHokTMxRvgiVzvPljsOPZtm8wVzczk
	ofjaRtbZfcy7gdSLj5ZCS49P8I6ly21uSUpxvou/P83zi8FZWfZBiAhJPgL8sxVjHlFb
	AOU/b5j6I2ycEA8XV8iS4Y3oNusiJneYm2IdkhdqUUXYV46oWRkyWj6ZxDW9WOWKBhYW
	ebvw==
X-Received: by 10.67.22.162 with SMTP id ht2mr32654682pad.49.1418444323260;
	Fri, 12 Dec 2014 20:18:43 -0800 (PST)
Received: from [10.0.2.15] ([211.244.64.26])
	by mx.google.com with ESMTPSA id fm4sm252753pdb.88.2014.12.12.20.18.40
	for <multiple recipients>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Fri, 12 Dec 2014 20:18:41 -0800 (PST)
Message-ID: <548BBE27.6070305@gmail.com>
Date: Sat, 13 Dec 2014 13:18:47 +0900
From: KO Myung-Hun <komh78@gmail.com>
User-Agent: Mozilla/5.0 (OS/2; Warp 4.5;
	rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre
	SeaMonkey/2.7.2
MIME-Version: 1.0
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
	<54892D87.9000206@gmail.com>
	<CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
	<548BB17A.20602@gmail.com>
	<CA+8g5KHF2EPEgyGfvCC6q06oCzBc0swh1FAKoy5ve+yGA0dTgQ@mail.gmail.com>
In-Reply-To: <CA+8g5KHF2EPEgyGfvCC6q06oCzBc0swh1FAKoy5ve+yGA0dTgQ@mail.gmail.com>
X-Enigmail-Version: 1.3.5
Content-Type: multipart/mixed; boundary="------------040106000506020404010807"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Dec 2014 04:19:13 -0000

This is a multi-part message in MIME format.
--------------040106000506020404010807
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit



Jim Meyering wrote:
> On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>
>>
>> Jim Meyering wrote:
>>> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>> Jim Meyering wrote:
>>>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>>>> Hi/2.
>>>>>>
>>>>>> These are OS/2 patches.
>>>>>>
>>>>>> Review, please...
>>>>>>
>>>>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>>>>
>>>>> I saw no patches here, but was able to dig them out of the
>>>>> bug-tracking system at http://debbugs.gnu.org/19186.
>>>>> I have applied and pushed the first one.  Thank you.
>>>>>
>>>>> However, for the second, my inclination is that if at all possible,
>>>>> it should be fixed via an lseek replacement that does something
>>>>> more sensible. Of course, that may not be possible, but from
>>>>> what you've presented so far, I cannot tell. Please demonstrate
>>>>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>>>>
>>>> Do you want this ?
>>>>
>>>> -----
>>>> $ cat file | diff - file
>>>> diff.exe: -: Invalid seek
>>>> -----
>>>
>>> Yes.  Thanks. That shows how lseek-pipe fails on your system.
>>> Please adjust your patch to make diff ignore failure only in that case,
>>> i.e., when errno == EINVAL (assuming strerror(EINVAL)
>>> produces that diagnostic).
>>
>> Do you mean to add errno == EINVAL to if() for pfatal_with_name() ?
> 
> No.
> Skip the test only when this lseek fails with precisely that errno value:
> 

Ok. Fixed.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


--------------040106000506020404010807
Content-Type: text/plain;
 name="0001-diff-skip-test-if-seek-is-not-possible-on-OS-2-kLIBC.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-diff-skip-test-if-seek-is-not-possible-on-OS-2-kLIBC.pa";
 filename*1="tch"

>From 7b7ebe9c5716a39cff4478e6e83720b9a9648c62 Mon Sep 17 00:00:00 2001
From: KO Myung-Hun <komh@chollian.net>
Date: Tue, 15 Jul 2014 11:50:53 +0900
Subject: [PATCH] diff: skip test if seek is not possible on OS/2 kLIBC

This fixes the problem that 'diff - file' and 'cat file | diff - file'
fail due to a seek failure with a message 'diff.exe: -: Invalid seek',
because seek does not work on stdin and a pipe on OS/2 kLIBC.

* src/io.c (sip): Set skip_test to true if seek is not possible on
OS/2 kLIBC.
---
 src/io.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/io.c b/src/io.c
index 1a8b936..e564f40 100644
--- a/src/io.c
+++ b/src/io.c
@@ -108,6 +108,13 @@ sip (struct file_data *current, bool skip_test)
 				     PTRDIFF_MAX - 2 * sizeof (word));
       current->buffer = xmalloc (current->bufsize);
 
+#ifdef __KLIBC__
+      /* Skip test if seek is not possible */
+      skip_test = skip_test
+		  || (lseek (current->desc, 0, SEEK_CUR) < 0
+		      && errno == ESPIPE);
+#endif
+
       if (! skip_test)
 	{
 	  /* Check first part of file to see if it's a binary file.  */
-- 
1.8.5.2


--------------040106000506020404010807--




From MAILER-DAEMON Fri Dec 12 23:55:14 2014
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Xzeja-0007UN-IT
	for mharc-bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:55:14 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59357)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzejU-0007S3-U3
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:55:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzejP-0002zD-8x
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:55:08 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34963)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzejP-0002yk-49
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:55:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1XzejO-0000y8-J8
	for bug-diffutils@gnu.org; Fri, 12 Dec 2014 23:55:02 -0500
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Sat, 13 Dec 2014 04:55:02 +0000
Resent-Message-ID: <handler.19186.D19186.14184464913701.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 19186
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: KO Myung-Hun <komh78@gmail.com>
Mail-Followup-To: 19186@debbugs.gnu.org, jim@meyering.net, komh78@gmail.com
Received: via spool by 19186-done@debbugs.gnu.org id=D19186.14184464913701
	(code D ref 19186); Sat, 13 Dec 2014 04:55:02 +0000
Received: (at 19186-done) by debbugs.gnu.org; 13 Dec 2014 04:54:51 +0000
Received: from localhost ([127.0.0.1]:44329 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1XzejC-0000xc-Ko
	for submit@debbugs.gnu.org; Fri, 12 Dec 2014 23:54:50 -0500
Received: from mail-yk0-f170.google.com ([209.85.160.170]:46163)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1XzejA-0000xP-4M
	for 19186-done@debbugs.gnu.org; Fri, 12 Dec 2014 23:54:48 -0500
Received: by mail-yk0-f170.google.com with SMTP id q200so3693276ykb.1
	for <19186-done@debbugs.gnu.org>; Fri, 12 Dec 2014 20:54:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=wLJRrk72GZo41qhKLXtb9p6+rbp9Uya/T7LY4kpJXMI=;
	b=QvWN9w1SeOOdW+zS63DJaAnm3LKRj1aC3BiAdJh0mJoHc+sbooGFGtL2oiLUJcccHW
	8+Cfp02iBaojip0QaZA9r3NTTvLJSuZOtZjf88w0Hgk51RFUfqKNNPYGk24gpk4IpBxm
	XEnn556JT+U8ncK2dVHLXzif+xAqDqQf7Mm2wys8J6h99I2aHZaPanLRLM2hTO0F/vI/
	+Sq68lVAtHpMupF5c9AF4Yq4F5jLg1UNbSWsRQJjDO+cKBS9DC7GHV6QERQJLvcCSCOV
	b8ebWPJxH9M0CfyhYdge5lABsUPyek7aHMau85eGiYbLMgXyLXNRcmGJxVhU9a5ippxs
	b3mQ==
X-Received: by 10.236.47.196 with SMTP id t44mr14442942yhb.59.1418446482542;
	Fri, 12 Dec 2014 20:54:42 -0800 (PST)
MIME-Version: 1.0
Received: by 10.170.139.67 with HTTP; Fri, 12 Dec 2014 20:54:22 -0800 (PST)
In-Reply-To: <548BBE27.6070305@gmail.com>
References: <1416968979-56894-1-git-send-email-komh@chollian.net>
	<CA+8g5KEJPonopjaaqjixks=tRhQa3vTdNFf=uhdRAeivKOuWjQ@mail.gmail.com>
	<54892D87.9000206@gmail.com>
	<CA+8g5KFJGd-DegdSnLqiY3Qoec6AA_4GbiEVaMtvRnay5ZVawA@mail.gmail.com>
	<548BB17A.20602@gmail.com>
	<CA+8g5KHF2EPEgyGfvCC6q06oCzBc0swh1FAKoy5ve+yGA0dTgQ@mail.gmail.com>
	<548BBE27.6070305@gmail.com>
From: Jim Meyering <jim@meyering.net>
Date: Fri, 12 Dec 2014 20:54:22 -0800
X-Google-Sender-Auth: NKcXEUiU_TjHlV781isi37w0cRA
Message-ID: <CA+8g5KGcm5mE1asnqTzYjjM139kKEZzpkkPa1Ao5Bbckv3T8Tg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
Cc: 19186-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#19186:  bug#19186: [PATCH] OS/2 patches
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Dec 2014 04:55:14 -0000

On Fri, Dec 12, 2014 at 8:18 PM, KO Myung-Hun <komh78@gmail.com> wrote:
> Jim Meyering wrote:
>> On Fri, Dec 12, 2014 at 7:24 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>
>>> Jim Meyering wrote:
>>>> On Wed, Dec 10, 2014 at 9:37 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>>> Jim Meyering wrote:
>>>>>> On Tue, Nov 25, 2014 at 6:29 PM, KO Myung-Hun <komh78@gmail.com> wrote:
>>>>>>> Hi/2.
>>>>>>>
>>>>>>> These are OS/2 patches.
>>>>>>>
>>>>>>> Review, please...
>>>>>>>
>>>>>>> [PATCH 1/2] build: use quotation mark(") for PATH
>>>>>>> [PATCH 2/2] diff: skip test if seek is not possible on OS/2 kLIBC
>>>>>>
>>>>>> I saw no patches here, but was able to dig them out of the
>>>>>> bug-tracking system at http://debbugs.gnu.org/19186.
>>>>>> I have applied and pushed the first one.  Thank you.
>>>>>>
>>>>>> However, for the second, my inclination is that if at all possible,
>>>>>> it should be fixed via an lseek replacement that does something
>>>>>> more sensible. Of course, that may not be possible, but from
>>>>>> what you've presented so far, I cannot tell. Please demonstrate
>>>>>> a use of diff that shows how OS/2+kLIBC's lseek fails.
>>>>>
>>>>> Do you want this ?
>>>>>
>>>>> -----
>>>>> $ cat file | diff - file
>>>>> diff.exe: -: Invalid seek
>>>>> -----
>>>>
>>>> Yes.  Thanks. That shows how lseek-pipe fails on your system.
>>>> Please adjust your patch to make diff ignore failure only in that case,
>>>> i.e., when errno == EINVAL (assuming strerror(EINVAL)
>>>> produces that diagnostic).
>>>
>>> Do you mean to add errno == EINVAL to if() for pfatal_with_name() ?
>>
>> No.
>> Skip the test only when this lseek fails with precisely that errno value:
>
> Ok. Fixed.

Applied and pushed.  Thanks.




