From MAILER-DAEMON Tue Dec 01 04:58:09 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a3hhJ-0008R3-1x
	for mharc-bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:58:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a3hhG-0008Qw-UZ
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:58:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a3hhD-0004VX-1c
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:58:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a3hhC-0004VE-Tz
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:58:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a3hhC-0008SZ-OU
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:58:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Gisle Vanem <gvanem@yahoo.no>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 01 Dec 2015 09:58:02 +0000
Resent-Message-ID: <handler.22067.B.144896382332449@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 22067@debbugs.gnu.org
X-Debbugs-Original-To: "bug-diffutils@gnu.org" <bug-diffutils@gnu.org>
Received: via spool by submit@debbugs.gnu.org id=B.144896382332449
	(code B ref -1); Tue, 01 Dec 2015 09:58:02 +0000
Received: (at submit) by debbugs.gnu.org; 1 Dec 2015 09:57:03 +0000
Received: from localhost ([127.0.0.1]:33641 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a3hgF-0008RJ-3t
	for submit@debbugs.gnu.org; Tue, 01 Dec 2015 04:57:03 -0500
Received: from eggs.gnu.org ([208.118.235.92]:36499)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <gvanem@yahoo.no>) id 1a3hgD-0008Qy-Cc
	for submit@debbugs.gnu.org; Tue, 01 Dec 2015 04:57:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gvanem@yahoo.no>) id 1a3hgC-00042S-5r
	for submit@debbugs.gnu.org; Tue, 01 Dec 2015 04:57:00 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:53365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gvanem@yahoo.no>) id 1a3hgC-00042O-3C
	for submit@debbugs.gnu.org; Tue, 01 Dec 2015 04:57:00 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gvanem@yahoo.no>) id 1a3hgB-0008KZ-7v
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:57:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gvanem@yahoo.no>) id 1a3hg7-00041V-Ak
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:56:59 -0500
Received: from nm36-vm5.bullet.mail.ir2.yahoo.com ([212.82.97.137]:55356)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gvanem@yahoo.no>) id 1a3hg7-00040I-13
	for bug-diffutils@gnu.org; Tue, 01 Dec 2015 04:56:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.no; s=s2048;
	t=1448963813; bh=FgMR3B3CPmZo22oc6iJoaZCyU2ef43CAwY9VV01oyjM=;
	h=From:Subject:To:Date:From:Subject;
	b=Jh1lGNaLjFDX0d6MG4nhh53Iqqs7gHnbxAhe4PBVXmzJnnbYm3xmxoidhiYT3Yi6iV1f1Jg/BK+artxQrwUs3U+S3S5VrMZdfR2G/VVWjDlY9zZ2SgPB57c8wW8QnMUdDMEulWHYAEJQjrbEdzrHjlA8IK6UhOHaxxXiqr4TZEALaHkCLk6Is3mvvyv5RqKvnfPSDXtktYzRN2QchUy7cbU6KEasgfTFTWniaMBmEnDVYNE4HcfugBXj5Ynr8vk3xIzdgPjOBLXx3aRyMNtiwUe6hVk6yR/v1ZP4AVEdRYIluQLgPzmeXUdiLpVFpU1QpH7Nbntb29lApn3nR/53jQ==
Received: from [212.82.98.62] by nm36.bullet.mail.ir2.yahoo.com with NNFMP;
	01 Dec 2015 09:56:53 -0000
Received: from [46.228.39.67] by tm15.bullet.mail.ir2.yahoo.com with NNFMP;
	01 Dec 2015 09:56:53 -0000
Received: from [127.0.0.1] by smtp104.mail.ir2.yahoo.com with NNFMP;
	01 Dec 2015 09:56:53 -0000
X-Yahoo-Newman-Id: 706454.71187.bm@smtp104.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: kkXJ6ZkVM1mtygrfiHa_w0zM9mjE6Ytj6m8Ze0oqdJ12NQX
	w4oYchEwrASOe3nLbVzwS0ceKWixrY9Gkcdq1ASo1hF4nuFHRBsGxqRSAFuu
	h_9il8xLvqhtHL4xUJl2cIaQvAxjAh3N5kIeDyLzTEu.MD4sSAOaOkUp69z0
	n0UzzX.7hv2wqTML.qOqvvx_.CJ3Gl1Cbf1cTIOGCfcAm1RaB4ye.ItbPdLh
	VuGQFHPSun8RT870D5LGH_EhmiDVD6T.yC_q7wAqLrsLP3NGbYe3vccLN9XF
	H_GVFlcu49R2Cwr65fLyIzlP5aPOVE9kQLEqBIQCm42k1G2x3prdZf.2Y8lD
	J1hXXQsbfygu12I9NLTPP.vlLEIKLbgkth76RMvGnGFYckQxww4GAV1LDXRm
	dyTHd0PUGy1EcVBMqUOjFY5CU5swrT974skKbbkuqBcxerp.qKLyyiwQb5wF
	vsV_tYwmBuhgeTXFQSntq0BKdzijtAkqUjFoPk_GkW7RYEUiRxhKFnege5K0
	8FrhYB4aIBcaIUOugSqYSr_E-
X-Yahoo-SMTP: 8zhYLGyswBB3AGU8c4pvFIFOfA--
From: Gisle Vanem <gvanem@yahoo.no>
Message-ID: <565D6EF4.20903@yahoo.no>
Date: Tue, 1 Dec 2015 10:57:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#22067: bug#20062: bug#20062: [PATCH] diff: add
	support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2015 09:58:07 -0000

Jim Meyering wrote:

> Good! Worthwhile after all. Thank you.
> I have just pushed those commits.

Trying this color-patch on Windows, there are a few issues:

1) ANSI-sequences are no good on Windows.
2) Some signals are not in MSVC, MinGW nor in Gnulib; i.e. SIGTSTP,
   SIGSTOP etc.
3) I'm getting a stack-overflow in handling a SIGINT.
   AFAICS there is a infinite recursion in process_signals().
   This function calls 'set_color_context (RESET_CONTEXT)'. But
   'set_color_context()' again calls 'process_signals()'. How can
   that *not* stack-fault on any platform?

1+2) I've patched here to get colors. Although hard-coded; ignoring
the '--palette' option etc.

-- 
--gv




From MAILER-DAEMON Sun Dec 06 14:27:05 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a5exd-0004Ey-Ed
	for mharc-bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:27:05 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5exb-0004EY-MU
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:27:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5exa-0005cP-Sw
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:27:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5exa-0005cG-Oi
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:27:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5exa-0007QX-Eo
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:27:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 06 Dec 2015 19:27:02 +0000
Resent-Message-ID: <handler.22102.B.144942996628477@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 22102
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 22102@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.144942996628477
	(code B ref -1); Sun, 06 Dec 2015 19:27:02 +0000
Received: (at submit) by debbugs.gnu.org; 6 Dec 2015 19:26:06 +0000
Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a5ewf-0007PE-QQ
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:26:06 -0500
Received: from eggs.gnu.org ([208.118.235.92]:51686)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1a5ewL-0007OU-Jy
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:26:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@gmail.com>) id 1a5ewK-00054u-Go
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:25:45 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:51996)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@gmail.com>) id 1a5ewK-00054q-DP
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:25:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@gmail.com>) id 1a5ewJ-0004Bb-Cl
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:25:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@gmail.com>) id 1a5ewI-00054g-Av
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:25:43 -0500
Received: from mail-vk0-x233.google.com ([2607:f8b0:400c:c05::233]:35482)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@gmail.com>) id 1a5ewI-00054c-5o
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:25:42 -0500
Received: by vkha189 with SMTP id a189so91321566vkh.2
	for <bug-diffutils@gnu.org>; Sun, 06 Dec 2015 11:25:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:from:date:message-id:subject:to:content-type;
	bh=+9N0LtkwlZaWjQPzpjMG1iqpLTuLC2dHMDEuA8iC3EE=;
	b=Tl5h/XA8aCIqmyjPBzOXxGC+RT5V8ekgwtte43nfm6j4bZUnTt+G1Hd/tsdJP5ANVC
	ogKTH2xAUvqzYbSW2urN8LUdwxtqKn+op2PPWz8wvO16DHWApGAw+QIfWH6UZw6DpuAy
	Ddaru8fKOi3c1WDX+muZwvg74Kb0DAos84/btAi1b5z7lCezNn+DfI6o8YSxTga53mlg
	znzuazjgfsmKRtnKuHT5bCYrU4pu96crCAdPlO3FAQsqsw4aMVrFmTeHNs4KYC+KXiBu
	BxdrS3e2+0ZhyJhdpaFwHna2BH+oGbglfAR//ofgMpwPahdrHSibJRvp6RnP25jMRewn
	FYTw==
X-Received: by 10.31.41.131 with SMTP id p125mr18472471vkp.133.1449429941388; 
	Sun, 06 Dec 2015 11:25:41 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.84.198 with HTTP; Sun, 6 Dec 2015 11:25:21 -0800 (PST)
From: Jim Meyering <jim@meyering.net>
Date: Sun, 6 Dec 2015 11:25:21 -0800
X-Google-Sender-Auth: sy0U7I238deStVkg-8pRUgcEdLY
Message-ID: <CA+8g5KEA+aCqxqT-=xXUJ0VbbCrXX0-uEX2q3ptYHNQvDuoVOw@mail.gmail.com>
Content-Type: multipart/mixed; boundary=001a113f0e46c8a61805263fb437
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#22102: tests: arrange to print any skipped-test
	explanation to tty, too
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 19:27:04 -0000

--001a113f0e46c8a61805263fb437
Content-Type: text/plain; charset=UTF-8

FYI, I've just pushed the attached:

--001a113f0e46c8a61805263fb437
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-tests-arrange-to-print-any-skipped-test-explanation-.patch"
Content-Disposition: attachment; 
	filename="0001-tests-arrange-to-print-any-skipped-test-explanation-.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ihux5c3s0

RnJvbSBhMTE0MGRkNDU4NDVkODM4NDAxNDI1ZjlhM2MwYWY5NDRhYmI1Nzk1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog
U3VuLCA2IERlYyAyMDE1IDEwOjM4OjE3IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHM6IGFy
cmFuZ2UgdG8gcHJpbnQgYW55IHNraXBwZWQtdGVzdCBleHBsYW5hdGlvbiB0byB0dHksCiB0b28K
Ckkgbm90aWNlZCB0aGF0IHdoZW4gYSB0ZXN0IHdhcyBza2lwcGVkLCB0aGUgcmVhc29uIHdhcyBu
b3QgcHJpbnRlZC4KVGhpcyBmaXhlcyBpdC4gIEluIGNvcmV1dGlscywgdGhpcyB2YXJpYWJsZSBp
cyBzZXQgaW4gaW5pdC5jZmcsCmJ1dCB0aGVyZSBpcyBubyBwb2ludCBpbiBwdXR0aW5nIHRoZSBk
ZWZpbml0aW9uIHNvIGZhciBmcm9tIHRoZQpjb2RlIHRoYXQgY2hvb3NlcyB0aGUgZmlsZSBkZXNj
cmlwdG9yIG51bWJlciBpbiB0ZXN0cy9NYWtlZmlsZS5hbS4KKiB0ZXN0cy9NYWtlZmlsZS5hbSAo
VEVTVFNfRU5WSVJPTk1FTlQpIFtzdGRlcnJfZmlsZW5vX106IERlZmluZQpoZXJlICh0byA5KSwg
cmlnaHQgbmV4dCB0byB0aGUgY29tcGFuaW9uICI5PiYyIi4KLS0tCiB0ZXN0cy9NYWtlZmlsZS5h
bSB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvdGVz
dHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5hbQppbmRleCA4MDVjY2MyLi4wODNhMDBh
IDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmlsZS5hbQpA
QCAtNDYsNiArNDYsNyBAQCBURVNUU19FTlZJUk9OTUVOVCA9CQkJCQkJCVwKICAgICBleHBvcnQg
UFJFRkVSQUJMWV9QT1NJWF9TSEVMTDsJCQkJCVwKICAgUkVQTEFDRV9HRVRDV0Q9JChSRVBMQUNF
X0dFVENXRCk7IGV4cG9ydCBSRVBMQUNFX0dFVENXRDsJCVwKICAgUEFUSD0nJChhYnNfdG9wX2J1
aWxkZGlyKS9zcmMkKFBBVEhfU0VQQVJBVE9SKSciJCRQQVRIIjsgZXhwb3J0IFBBVEgJXAorICBz
dGRlcnJfZmlsZW5vXz05OyBleHBvcnQgc3RkZXJyX2ZpbGVubwkJCQlcCiAgIDsgOT4mMgoKIExP
R19DT01QSUxFUj0gJChTSEVMTCkKLS0gCjIuNi4yCgo=
--001a113f0e46c8a61805263fb437--




From MAILER-DAEMON Sun Dec 06 14:28:10 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a5eyg-0004tJ-2V
	for mharc-bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:28:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33709)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5eyc-0004n7-91
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:28:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5eyY-0005tM-Oj
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:28:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51245)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5eyY-0005tG-LI
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:28:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5eyY-0007SW-EO
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:28:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 06 Dec 2015 19:28:02 +0000
Resent-Message-ID: <handler.21942.B21942.144943006528648@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 21942
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Stephan =?UTF-8?Q?M=C3=BCller?= <fruktopus@gmail.com>
Received: via spool by 21942-submit@debbugs.gnu.org id=B21942.144943006528648
	(code B ref 21942); Sun, 06 Dec 2015 19:28:02 +0000
Received: (at 21942) by debbugs.gnu.org; 6 Dec 2015 19:27:45 +0000
Received: from localhost ([127.0.0.1]:40953 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a5eyG-0007Rz-IG
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:27:45 -0500
Received: from mail-vk0-f41.google.com ([209.85.213.41]:36615)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1a5eyD-0007Rq-4I
	for 21942@debbugs.gnu.org; Sun, 06 Dec 2015 14:27:42 -0500
Received: by vkay187 with SMTP id y187so91385522vka.3
	for <21942@debbugs.gnu.org>; Sun, 06 Dec 2015 11:27:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=0ilBQn5yz5ibN70q8uS8/CftMBu1r/73mE2fmXkrH7M=;
	b=PLa7j06R26EXCjdoguK3VH22eR2J/gcddldqBRy7ey2cMHTXFipIUgUW7yA4zmA1CQ
	h2yii6zuoCV8XpzD+MuJxT+wZEKygtN3YlU4q/I/DYi2DI0FbBxr118+0nKISSI7GODL
	gv1EtDJcDLf50+S2FCPfM3ak3z51ZfYb6FfmvAk74KT+Vhy3VXQEtXkFCdrMHPqZcvVz
	RaSkgWggc4eJWomY77KMJ2Mdjr5c8s257lzv4lOehNDxRfqctVI084XUJisIsEo4nPHp
	3j9pzUnqOkMqV4K7TODoZvltffwQLWFTZgn6KjyyX2/Kk9Vg3NNuNY3CP7aXxlMt7BcD
	w3/A==
X-Received: by 10.31.170.199 with SMTP id t190mr18229023vke.66.1449430060564; 
	Sun, 06 Dec 2015 11:27:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.84.198 with HTTP; Sun, 6 Dec 2015 11:27:20 -0800 (PST)
In-Reply-To: <20151120233334.7e93f488@fuckup.fritz.box>
References: <20151117124408.27185c58@fuckup.fritz.box>
	<CA+8g5KF0+wT2bR6rBxSbvAxXrw2Ah8DT3_Gzx++LNnkepJX5Bw@mail.gmail.com>
	<20151120210654.779970ad@fuckup.fritz.box>
	<CA+8g5KH46mq54tgyzAATRh10vacNJKetCyWPq681ttmKuGxq_A@mail.gmail.com>
	<20151120233334.7e93f488@fuckup.fritz.box>
From: Jim Meyering <jim@meyering.net>
Date: Sun, 6 Dec 2015 11:27:20 -0800
X-Google-Sender-Auth: 2IGPrSbTf1kCyp7QOJyVXWTGZo0
Message-ID: <CA+8g5KGTTC2FRrpt0SYWmQebdCG89TjEf_46ozyegNadk_az1A@mail.gmail.com>
Content-Type: multipart/mixed; boundary=001a11431b0ce31a3105263fbbef
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
Cc: 21942@debbugs.gnu.org
Subject: [bug-diffutils] bug#21942: bug#21942: Files with incorrect file
	sizes
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 19:28:08 -0000

--001a11431b0ce31a3105263fbbef
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 20, 2015 at 2:33 PM, Stephan M=C3=BCller <fruktopus@gmail.com> =
wrote:
> Am Fri, 20 Nov 2015 23:12:40 +0100
> schrieb Jim Meyering <jim@meyering.net>:
>
>> On Fri, Nov 20, 2015 at 9:06 PM, Stephan M=C3=BCller <fruktopus@gmail.co=
m>
>> wrote:
>> > Am Fri, 20 Nov 2015 18:28:37 +0100
>> > schrieb Jim Meyering <jim@meyering.net>:
>> >
>> >> On Tue, Nov 17, 2015 at 12:44 PM, Stephan M=C3=BCller
>> >> <fruktopus@gmail.com> wrote:
>> >> > recently I had to debug weird problem. Finally I figured it out.
>> >> >
>> >> > Virtual file systems like /sys or /proc usually don't care about
>> >> > file sizes. All files have a size of 0. This leads to
>> >> > difficulties as diff sometimes looks for file sizes.
>> >> >
>> >> > Say you do:
>> >> >
>> >> >> $ cp /proc/cmdline my_cmdline
>> >> >> $ diff /proc/cmdline my_cmdline ; echo $?
>> >> >> 0      // ok, files don't differ
>> >> >> $ diff --brief /proc/cmdline my_cmdline
>> >> >> Files /proc/cmdline and mycmdline differ
>> >> >
>> >> > The --brief option triggers a binary compare, as we aren't
>> >> > interested in the actual differences this makes sense. As a first
>> >> > step, file sizes are compared (0 vs ~150) and the files are
>> >> > reported as different.
>> >>
>> >> thanks for the report.
>> >> What version of diffutils are you using?
>> >> I think this has been fixed for some time.
>> >> I was unable to reproduce with 2.8.1 nor with the latest built from
>> >> git. I.e., I created an empty file and used diff-2.8.1 to compare
>> >> it with the nominally-
>> >> zero-length /proc/cmdline file, and diff did the right thing.
>> >> Also, I ran stat to show st_size of each file is indeed 0:
>> >>
>> >>   $ :
>> >> > /tmp/k; /p/p/diffutils-2.8.1/bin/diff /proc/cmdline /tmp/k; \
>> >> > stat --format %s /proc/cmdline /tmp/k
>> >>   1d0
>> >>   < ro root=3DLABEL=3D...
>> >>   0
>> >>   0
>> >>
>> >> In fact, I went ahead and built all available versions and tested
>> >> them like this:
>> >>
>> >>   $ for i in /p/p/*/bin/diff; do p=3Ddiffutils-$i; echo $i; $i
>> >> /proc/cmdline /tmp/k > /dev/null && echo bad; done
>> >>   /p/p/diffutils-2.7/bin/diff
>> >>   /p/p/diffutils-2.8.1/bin/diff
>> >>   /p/p/diffutils-2.8/bin/diff
>> >>   /p/p/diffutils-2.9/bin/diff
>> >>   /p/p/diffutils-3.0/bin/diff
>> >>   /p/p/diffutils-3.1/bin/diff
>> >>   /p/p/diffutils-3.2/bin/diff
>> >>   /p/p/diffutils-3.3/bin/diff
>> >
>> > Hi,
>> >
>> > I am using v.3.3 of diffutils
>> >
>> > $ diff -v
>> > diff (GNU diffutils) 3.3
>> >
>> > but I think you misunderstood the problem. Sorry for being
>> > ambiguous. I am not diffing against an empty file. That works well.
>> > The point is procfs doesn't care about size, but 'normal' file
>> > systems do. So for example on my system I have (after
>> > cp /proc/cmdline mycmdline)
>> >
>> > $ stat --format %s /proc/cmdline mycmdline
>> > 0
>> > 140
>> >
>> > The result of diffing /proc/cmdline against mycmdline depends on the
>> > --brief flag.
>> >
>> > STEPS TO REPRODUCE:
>> >
>> > cp /proc/cmdline mycmdline
>> > diff --brief /proc/cmdline mycmdline > /dev/null ; echo ?$
>> > 1
>> > diff /proc/cmdline mycmdline ; echo $?
>> > 0
>> >
>> > EXPECTED RESULT:
>> >
>> > cp /proc/cmdline mycmdline
>> > diff --brief /proc/cmdline mycmdline > /dev/null ; echo ?$
>> > 0
>> > diff /proc/cmdline mycmdline ; echo $?
>> > 0
>>
>> Oh, indeed. Thank you for clarifying. That feels like a bug.
>> Here's a knee-jerk patch that refrains from using the
>> st_size-comparing heuristic when either of the sizes is zero. This
>> may well be wrong. I have only barely tested the diff.c code path.
>
> Thanks, that makes the problem at least (even) less unlikely. But if we
> cant trust file sizes we're doomed. What do you think about a flag
> controlling comparison by size and a notice if files differ by size.
>
> I can craft a patch for this.

Thank you, but I don't want to have to specify some new option to
avoid this misbehavior, so will push the attached patch shortly.
If someone finds a system for which a falsely reported stat.st_size
is nonzero, we can revisit this.

--001a11431b0ce31a3105263fbbef
Content-Type: text/x-patch; charset=UTF-8; 
	name="0001-diff-brief-no-longer-mistakenly-reports-diff.-with-0.patch"
Content-Disposition: attachment; 
	filename="0001-diff-brief-no-longer-mistakenly-reports-diff.-with-0.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ihux6nut0

RnJvbSAxMjA5ZDYxYWMwYzk0MGJkZDJkZDExNDQ4Y2M5ZTFiM2U5YjU5YTI5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog
U2F0LCAyOCBOb3YgMjAxNSAxODowMjowNSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGRpZmYgLS1i
cmllZiBubyBsb25nZXIgbWlzdGFrZW5seSByZXBvcnRzIGRpZmYuIHdpdGggMC1zaXplZAogL3By
b2MvIGZpbGVzCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hh
cnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIHNyYy9hbmFseXpl
LmMgKGRpZmZfMl9maWxlcyk6IERvbid0IGRlY2xhcmUgZGlmZmVyZW5jZSB3aGVuIGFueQpzdF9z
aXplIGlzIDAuCiogc3JjL2RpZmYuYyAoY29tcGFyZV9maWxlcyk6IExpa2V3aXNlLgoqIHRlc3Rz
L2JyaWVmLXZzLXByb2Mtc3RhdC16ZXJvOiBOZXcgdGVzdC4KKiB0ZXN0cy9NYWtlZmlsZS5hbTog
QWRkIGl0LgoqIE5FV1MgKEJ1ZyBmaXhlcyk6IERlc2NyaWJlIGl0LgpSZXBvcnRlZCBieSBTdGVw
aGFuIE3DvGxsZXIgaW4gaHR0cDovL2RlYmJ1Z3MuZ251Lm9yZy8yMTk0MgotLS0KIE5FV1MgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrCiBzcmMvYW5hbHl6ZS5j
ICAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArKwogc3JjL2RpZmYuYyAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgIDQgKysrLQogdGVzdHMvTWFrZWZpbGUuYW0gICAgICAgICAgICAgICAg
ICAgIHwgIDEgKwogdGVzdHMvYnJpZWYtdnMtc3RhdC16ZXJvLWtlcm5lbC1saWVzIHwgMzAgKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrCiA1IGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlv
bnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0cy9icmllZi12cy1z
dGF0LXplcm8ta2VybmVsLWxpZXMKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCAwODhm
MTNiLi4xNzI0Yzc0IDEwMDY0NAotLS0gYS9ORVdTCisrKyBiL05FV1MKQEAgLTIzLDYgKzIzLDE0
IEBAIEdOVSBkaWZmdXRpbHMgTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IC0qLSBvdXRsaW5lIC0qLQogICBkaWZmIC1CIG5vIGxvbmdlciBnZW5lcmF0ZXMgaW5jb3JyZWN0
IG91dHB1dCBpZiB0aGUgdHdvIGlucHV0cwogICBlYWNoIGVuZCB3aXRoIGEgb25lLWJ5dGUgaW5j
b21wbGV0ZSBsaW5lLgoKKyAgZGlmZiAtLWJyaWVmIG5vIGxvbmdlciByZXBvcnRzIGEgZGlmZmVy
ZW5jZSBmb3IgdW51c3VhbCBpZGVudGljYWwgZmlsZXMuCisgIEZvciBleGFtcGxlLCB3aGVuIGNv
bXBhcmluZyBhIGZpbGUgbGlrZSAvcHJvYy9jbWRsaW5lIChmb3Igd2hpY2ggdGhlIGxpbnV4Cisg
IGtlcm5lbCByZXBvcnRzIHN0X3NpemUgb2YgMCBldmVuIHRob3VnaCBpdCBpcyBub3QgYW4gZW1w
dHkgZmlsZSkgdG8gYQorICBjb3B5IG9mIHRoYXQgZmlsZSdzIGNvbnRlbnRzIHJlc2lkaW5nIG9u
IGEgIm5vcm1hbCIgZmlsZSBzeXN0ZW06CisgICAgJCBmPS9wcm9jL2NtZGxpbmU7IGNwICRmIGs7
IGRpZmYgLS1icmllZiAkZiBrCisgICAgRmlsZXMgL3Byb2MvY21kbGluZSBhbmQgayBkaWZmZXIK
KworCiAqKiBQZXJmb3JtYW5jZSBjaGFuZ2VzCgogICBkaWZmJ3MgZGVmYXVsdCBhbGdvcml0aG0g
aGFzIGJlZW4gYWRqdXN0ZWQgdG8gb3V0cHV0IGhpZ2hlci1xdWFsaXR5CmRpZmYgLS1naXQgYS9z
cmMvYW5hbHl6ZS5jIGIvc3JjL2FuYWx5emUuYwppbmRleCA4OTNkMDdjLi4yNjIyODEwIDEwMDY0
NAotLS0gYS9zcmMvYW5hbHl6ZS5jCisrKyBiL3NyYy9hbmFseXplLmMKQEAgLTQ3Nyw2ICs0Nzcs
OCBAQCBkaWZmXzJfZmlsZXMgKHN0cnVjdCBjb21wYXJpc29uICpjbXApCiAgICAgewogICAgICAg
LyogRmlsZXMgd2l0aCBkaWZmZXJlbnQgbGVuZ3RocyBtdXN0IGJlIGRpZmZlcmVudC4gICovCiAg
ICAgICBpZiAoY21wLT5maWxlWzBdLnN0YXQuc3Rfc2l6ZSAhPSBjbXAtPmZpbGVbMV0uc3RhdC5z
dF9zaXplCisJICAmJiAwIDwgY21wLT5maWxlWzBdLnN0YXQuc3Rfc2l6ZQorCSAgJiYgMCA8IGNt
cC0+ZmlsZVsxXS5zdGF0LnN0X3NpemUKIAkgICYmIChjbXAtPmZpbGVbMF0uZGVzYyA8IDAgfHwg
U19JU1JFRyAoY21wLT5maWxlWzBdLnN0YXQuc3RfbW9kZSkpCiAJICAmJiAoY21wLT5maWxlWzFd
LmRlc2MgPCAwIHx8IFNfSVNSRUcgKGNtcC0+ZmlsZVsxXS5zdGF0LnN0X21vZGUpKSkKIAljaGFu
Z2VzID0gMTsKZGlmZiAtLWdpdCBhL3NyYy9kaWZmLmMgYi9zcmMvZGlmZi5jCmluZGV4IDQ2YWM5
OWQuLmNmZjIzZjAgMTAwNjQ0Ci0tLSBhL3NyYy9kaWZmLmMKKysrIGIvc3JjL2RpZmYuYwpAQCAt
MTM3Nyw3ICsxMzc3LDkgQEAgY29tcGFyZV9maWxlcyAoc3RydWN0IGNvbXBhcmlzb24gY29uc3Qg
KnBhcmVudCwKICAgZWxzZSBpZiAoZmlsZXNfY2FuX2JlX3RyZWF0ZWRfYXNfYmluYXJ5CiAJICAg
JiYgU19JU1JFRyAoY21wLmZpbGVbMF0uc3RhdC5zdF9tb2RlKQogCSAgICYmIFNfSVNSRUcgKGNt
cC5maWxlWzFdLnN0YXQuc3RfbW9kZSkKLQkgICAmJiBjbXAuZmlsZVswXS5zdGF0LnN0X3NpemUg
IT0gY21wLmZpbGVbMV0uc3RhdC5zdF9zaXplKQorCSAgICYmIGNtcC5maWxlWzBdLnN0YXQuc3Rf
c2l6ZSAhPSBjbXAuZmlsZVsxXS5zdGF0LnN0X3NpemUKKwkgICAmJiAwIDwgY21wLmZpbGVbMF0u
c3RhdC5zdF9zaXplCisJICAgJiYgMCA8IGNtcC5maWxlWzFdLnN0YXQuc3Rfc2l6ZSkKICAgICB7
CiAgICAgICBtZXNzYWdlICgiRmlsZXMgJXMgYW5kICVzIGRpZmZlclxuIiwKIAkgICAgICAgZmls
ZV9sYWJlbFswXSA/IGZpbGVfbGFiZWxbMF0gOiBjbXAuZmlsZVswXS5uYW1lLApkaWZmIC0tZ2l0
IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5hbQppbmRleCA4MDVjY2MyLi5i
MDcwYTc2IDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmls
ZS5hbQpAQCAtNCw2ICs0LDcgQEAgVEVTVFMgPSBcCiAgIGJhc2ljIFwKICAgYmlnbnVtIFwKICAg
YmluYXJ5IFwKKyAgYnJpZWYtdnMtc3RhdC16ZXJvLWtlcm5lbC1saWVzIFwKICAgY29sbGlkaW5n
LWZpbGUtbmFtZXMgXAogICBleGNlc3Mtc2xhc2ggXAogICBoZWxwLXZlcnNpb24JXApkaWZmIC0t
Z2l0IGEvdGVzdHMvYnJpZWYtdnMtc3RhdC16ZXJvLWtlcm5lbC1saWVzIGIvdGVzdHMvYnJpZWYt
dnMtc3RhdC16ZXJvLWtlcm5lbC1saWVzCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAw
MDAuLjliMjcyYzYKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0cy9icmllZi12cy1zdGF0LXplcm8t
a2VybmVsLWxpZXMKQEAgLTAsMCArMSwzMCBAQAorIyEvYmluL3NoCisjIEJlZm9yZSBkaWZmLTMu
NCwgZGlmZiAtLWJyaWVmIGNvdWxkIG1pc3Rha2VubHkgZGVjbGFyZSBhIGRpZmZlcmVuY2UuCisj
IEZvciBleGFtcGxlLCB3aGVuIGNvbXBhcmluZyBhIGZpbGUgbGlrZSAvcHJvYy9jbWRsaW5lIChm
b3Igd2hpY2ggdGhlIGxpbnV4CisjIGtlcm5lbCByZXBvcnRzIGEgc3Rfc2l6ZSBvZiAwIGV2ZW4g
dGhvdWdoIGl0IGlzIG5vdCBhbiBlbXB0eSBmaWxlKSB0byBhCisjIGNvcHkgb2YgdGhhdCBmaWxl
J3MgY29udGVudHMgcmVzaWRpbmcgb24gYSAibm9ybWFsIiBmaWxlIHN5c3RlbS4KKworLiAiJHtz
cmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3JjCisKK2ZhaWw9MAorCisjIFNr
aXAgdGhlIHRlc3QgdW5sZXNzIHdlIGhhdmUgYW4gYXBwcm9wcmlhdGUgZmlsZS4KK2Jvb3Q9L3By
b2MvY21kbGluZQordGVzdCAtZiAkYm9vdCB8fCBza2lwXyBubyAkYm9vdCBmaWxlCitzej0kKHN0
YXQgLS1mb3JtYXQgJXMgJGJvb3QpIHx8IHNraXBfIHN0YXQgLS1mb3JtYXQgJXMgZG9lcyBub3Qg
d29yawordGVzdCAkc3ogPSAwIHx8IHNraXBfICRib290IGhhcyBub256ZXJvIHNpemUKKworIyBU
aGVyZSBhcmUgdHdvIGNvZGUgcGF0aHMgdG8gdGVzdDogb25lIGZvciBub24tYmluYXJ5IGFuZCBv
bmUgZm9yIGJpbmFyeSBmaWxlcy4KKyMgJGJvb3QgaXMgbm9uLWJpbmFyeS4KK2NhdCAkYm9vdCA+
IHJlZiB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KK2RpZmYgLS1icmllZiAkYm9vdCByZWYgPiBvdXQg
Mj4mMSB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIG91dCB8fCBmYWlsPTEKKworIyAvcHJv
Yy9zZWxmL2NtZGxpbmUgaXMgYSBOVUwtdGVybWluYXRlZCBsaXN0IG9mIGFyZ3YgdmFsdWVzLAor
IyBzbyBjb25zdHJ1Y3QgdGhlIGV4cGVjdGVkIG91dHB1dCBoZXJlOgorcHJpbnRmICdkaWZmXDAt
LWJyaWVmXDAvcHJvYy9zZWxmL2NtZGxpbmVcMGJpblwwJyA+IGJpbiB8fCBmcmFtZXdvcmtfZmFp
bHVyZV8KKyMgQW5kIHJ1biB0aGUgY29tbWFuZCB0aGF0IGlzIGVtYmVkZGVkIGluIHRoYXQgb3V0
cHV0OgorZGlmZiAtLWJyaWVmIC9wcm9jL3NlbGYvY21kbGluZSBiaW4gPiBvdXQgMj4mMSB8fCBm
YWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIG91dCB8fCBmYWlsPTEKKworRXhpdCAkZmFpbAotLSAK
Mi42LjIKCg==
--001a11431b0ce31a3105263fbbef--




From MAILER-DAEMON Sun Dec 06 14:41:09 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a5fBF-0008Cv-MV
	for mharc-bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:41:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fBD-0008CW-LK
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:41:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fB8-0008JJ-LX
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:41:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fB8-0008J3-II
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:41:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fB8-0007mS-Ch
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:41:02 -0500
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Sun, 06 Dec 2015 19:41:01 +0000
Resent-Message-ID: <handler.21942.D21942.144943082529851.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 21942
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Stephan =?UTF-8?Q?M=C3=BCller?= <fruktopus@gmail.com>
Mail-Followup-To: 21942@debbugs.gnu.org, jim@meyering.net, fruktopus@gmail.com
Received: via spool by 21942-done@debbugs.gnu.org id=D21942.144943082529851
	(code D ref 21942); Sun, 06 Dec 2015 19:41:01 +0000
Received: (at 21942-done) by debbugs.gnu.org; 6 Dec 2015 19:40:25 +0000
Received: from localhost ([127.0.0.1]:40957 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a5fAW-0007lM-JH
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:40:24 -0500
Received: from mail-vk0-f53.google.com ([209.85.213.53]:35063)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1a5fAC-0007kt-EB
	for 21942-done@debbugs.gnu.org; Sun, 06 Dec 2015 14:40:23 -0500
Received: by vkha189 with SMTP id a189so91412400vkh.2
	for <21942-done@debbugs.gnu.org>; Sun, 06 Dec 2015 11:40:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc:content-type;
	bh=lQtJkECtUzSl9APF25s5/z2pUv9ykNhOdmYf4uZ8qv4=;
	b=MxfXPkI1qFh6sJzs+7qGl+F+m7z/e8SBHeVjPjqR7sodahWRG0dJIzVFF/HoDetoPW
	Cpc3VZPM50QrbBdirUQlLn2163stJSCID1ecx3N8f3QgI1VCwvXEEoB3nwYSYhb2aHDa
	x7JhIuhvm9G6YqxXx5pXi9unIBSagzhbvE6f2weWyn+v3WHrXb2ZHZbqCB9xTh8+DDuE
	fAgLis0H+Wg2yKefKU+65gN0+gkUFa9juiQxVdCi1lPF3N8jqQG/nnYGVDelLOEX4HwY
	7WH6K9fSaL5B0lwxcFxHRftDy9lw1CQGKK+niDluwuaJsmJL66CvJutN5PKyKDNxy4Vh
	Hi8Q==
X-Received: by 10.31.48.11 with SMTP id w11mr16359056vkw.114.1449430803909;
	Sun, 06 Dec 2015 11:40:03 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.84.198 with HTTP; Sun, 6 Dec 2015 11:39:44 -0800 (PST)
In-Reply-To: <CA+8g5KGTTC2FRrpt0SYWmQebdCG89TjEf_46ozyegNadk_az1A@mail.gmail.com>
References: <20151117124408.27185c58@fuckup.fritz.box>
	<CA+8g5KF0+wT2bR6rBxSbvAxXrw2Ah8DT3_Gzx++LNnkepJX5Bw@mail.gmail.com>
	<20151120210654.779970ad@fuckup.fritz.box>
	<CA+8g5KH46mq54tgyzAATRh10vacNJKetCyWPq681ttmKuGxq_A@mail.gmail.com>
	<20151120233334.7e93f488@fuckup.fritz.box>
	<CA+8g5KGTTC2FRrpt0SYWmQebdCG89TjEf_46ozyegNadk_az1A@mail.gmail.com>
From: Jim Meyering <jim@meyering.net>
Date: Sun, 6 Dec 2015 11:39:44 -0800
X-Google-Sender-Auth: fMTBvY5CPK3p_lU7FDiABQWbrMs
Message-ID: <CA+8g5KFQ5U9LTQT6ynkPU92c3VX964sKK0==+uBqsKNNsFJLPg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
Cc: 21942-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#21942: bug#21942: Files with incorrect file
	sizes
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 19:41:08 -0000

On Sun, Dec 6, 2015 at 11:27 AM, Jim Meyering <jim@meyering.net> wrote:
...
> Thank you, but I don't want to have to specify some new option to
> avoid this misbehavior, so will push the attached patch shortly.
> If someone finds a system for which a falsely reported stat.st_size
> is nonzero, we can revisit this.

Pushed with commit log changes and one fewer blank line in NEWS.




From MAILER-DAEMON Sun Dec 06 14:43:10 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a5fDC-0000an-5f
	for mharc-bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:43:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fD9-0000Zq-2n
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:43:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fD4-0000fJ-4i
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:43:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:51258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fD4-0000fC-27
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:43:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5fD3-0007q1-Va
	for bug-diffutils@gnu.org; Sun, 06 Dec 2015 14:43:02 -0500
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Sun, 06 Dec 2015 19:43:01 +0000
Resent-Message-ID: <handler.22102.D22102.144943094430066.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 22102
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 22102-done@debbugs.gnu.org
Mail-Followup-To: 22102@debbugs.gnu.org, jim@meyering.net, jim@meyering.net
Received: via spool by 22102-done@debbugs.gnu.org id=D22102.144943094430066
	(code D ref 22102); Sun, 06 Dec 2015 19:43:01 +0000
Received: (at 22102-done) by debbugs.gnu.org; 6 Dec 2015 19:42:24 +0000
Received: from localhost ([127.0.0.1]:40964 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a5fCS-0007os-8g
	for submit@debbugs.gnu.org; Sun, 06 Dec 2015 14:42:24 -0500
Received: from mail-vk0-f45.google.com ([209.85.213.45]:35524)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <meyering@gmail.com>) id 1a5fCQ-0007ok-7J
	for 22102-done@debbugs.gnu.org; Sun, 06 Dec 2015 14:42:22 -0500
Received: by vkha189 with SMTP id a189so91427121vkh.2
	for <22102-done@debbugs.gnu.org>; Sun, 06 Dec 2015 11:42:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:content-type;
	bh=tKuE4akrBtmIOOT+DcCegnsP1kFTSQkt29AbDRNCplY=;
	b=WfeCyDEX9bqjS2ow8A5yXZw+H8t4gqzuWHO2Exp14DoggRCR/RSMumV+RPvXUCoPBv
	9EzJc76x3ko+Hnjki18Lm5BwnXjq+6bcu39N0F37JdJ/fTlkyZwSvcpquWN557eR4uyI
	/p/KtMX32hUSnqYbpVsrtacoYiXT/NR2FwpTUphYf8daMNFOmmy0WpUuGzMomNtkf4QJ
	MFM4Bouy7sjH8egv8aLdLOz17OlKAFpxN9Uw4yK4w0H4ZxSC/PZzYBf9zeZinOw0Sb1v
	u1gpMsjfImpbufrJ2jRMoyEylXLMlzmT/SsAnHYZqG6QmUM6KEYaMge8cYPwQEbJj+7p
	aSBw==
X-Received: by 10.31.183.200 with SMTP id h191mr18318749vkf.147.1449430941854; 
	Sun, 06 Dec 2015 11:42:21 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.84.198 with HTTP; Sun, 6 Dec 2015 11:42:02 -0800 (PST)
In-Reply-To: <CA+8g5KEA+aCqxqT-=xXUJ0VbbCrXX0-uEX2q3ptYHNQvDuoVOw@mail.gmail.com>
References: <CA+8g5KEA+aCqxqT-=xXUJ0VbbCrXX0-uEX2q3ptYHNQvDuoVOw@mail.gmail.com>
From: Jim Meyering <jim@meyering.net>
Date: Sun, 6 Dec 2015 11:42:02 -0800
X-Google-Sender-Auth: JfUxPzeQDWUJBKvBSdViOaM20zY
Message-ID: <CA+8g5KFB9ndhwi-mG83hYJLjAuXuiXu0dkKg1Xrt=5dfNG+eJQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#22102: bug#22102: tests: arrange to print any
	skipped-test explanation to tty, too
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2015 19:43:07 -0000

On Sun, Dec 6, 2015 at 11:25 AM, Jim Meyering <jim@meyering.net> wrote:
> FYI, I've just pushed the attached:

Marking as done.




From MAILER-DAEMON Mon Dec 07 16:15:24 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a6380-00037W-Fp
	for mharc-bug-diffutils@gnu.org; Mon, 07 Dec 2015 16:15:24 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5yTK-0004SW-6f
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 11:17:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5yTG-0006xE-Sw
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 11:17:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5yTG-0006xA-PV
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 11:17:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a5yTG-0006UH-Di
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 11:17:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Taco van Dijk <taco@waag.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Dec 2015 16:17:02 +0000
Resent-Message-ID: <handler.22108.B.144950499124887@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 22108
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 22108@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.144950499124887
	(code B ref -1); Mon, 07 Dec 2015 16:17:02 +0000
Received: (at submit) by debbugs.gnu.org; 7 Dec 2015 16:16:31 +0000
Received: from localhost ([127.0.0.1]:41868 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1a5ySj-0006TJ-RS
	for submit@debbugs.gnu.org; Mon, 07 Dec 2015 11:16:30 -0500
Received: from eggs.gnu.org ([208.118.235.92]:33389)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <taco@waag.org>) id 1a5uEt-00076l-8H
	for submit@debbugs.gnu.org; Mon, 07 Dec 2015 06:46:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <taco@waag.org>) id 1a5uEr-0007ir-UF
	for submit@debbugs.gnu.org; Mon, 07 Dec 2015 06:45:54 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:54345)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taco@waag.org>) id 1a5uEr-0007in-RA
	for submit@debbugs.gnu.org; Mon, 07 Dec 2015 06:45:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taco@waag.org>) id 1a5uEq-0007o2-Az
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 06:45:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <taco@waag.org>) id 1a5uEl-0007iW-5f
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 06:45:52 -0500
Received: from mx.waag.org ([195.169.149.61]:47158 helo=zimbra.waag.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taco@waag.org>) id 1a5uEk-0007fZ-Vh
	for bug-diffutils@gnu.org; Mon, 07 Dec 2015 06:45:47 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.waag.org (Postfix) with ESMTP id DBE212A60197
	for <bug-diffutils@gnu.org>; Mon,  7 Dec 2015 12:45:51 +0100 (CET)
Received: from zimbra.waag.org ([127.0.0.1])
	by localhost (zimbra.waag.org [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id VDypINDgLNGj for <bug-diffutils@gnu.org>;
	Mon,  7 Dec 2015 12:45:51 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.waag.org (Postfix) with ESMTP id 1B1012A60199
	for <bug-diffutils@gnu.org>; Mon,  7 Dec 2015 12:45:51 +0100 (CET)
X-Virus-Scanned: amavisd-new at zimbra.waag.org
Received: from zimbra.waag.org ([127.0.0.1])
	by localhost (zimbra.waag.org [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id ZhFojm8wnyY2 for <bug-diffutils@gnu.org>;
	Mon,  7 Dec 2015 12:45:50 +0100 (CET)
Received: from zimbra.waag.org (zimbra.waag.org [195.169.149.61])
	by zimbra.waag.org (Postfix) with ESMTP id 9612A2A60197
	for <bug-diffutils@gnu.org>; Mon,  7 Dec 2015 12:45:50 +0100 (CET)
Date: Mon, 7 Dec 2015 12:45:50 +0100 (CET)
From: Taco van Dijk <taco@waag.org>
Message-ID: <1787778417.63622490.1449488750054.JavaMail.zimbra@waag.org>
In-Reply-To: <1613289466.63616406.1449488225960.JavaMail.zimbra@waag.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [195.169.149.2]
X-Mailer: Zimbra 8.0.9_GA_6191 (ZimbraWebClient - FF42 (Mac)/8.0.9_GA_6191)
Thread-Topic: diff wrapper script for very large files, low memory
Thread-Index: MJqCFyiIElu9Esv/E1GQK7OUVzf34w==
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Mailman-Approved-At: Mon, 07 Dec 2015 11:16:28 -0500
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 208.118.235.43
X-Mailman-Approved-At: Mon, 07 Dec 2015 16:15:23 -0500
Subject: [bug-diffutils] bug#22108: diff wrapper script for very large files,
	low memory
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 16:17:11 -0000

Hi,

For our current project we faced the following problem;
When trying to compare two large files (2* 4+ Gb) exceeding the RAM of the machine, 
the machine would become unresponsive.

To solve this problem we have found a solution that might be worthwhile sharing, based around xxhash.

For anyone interested, you can find it here.

https://github.com/waagsociety/hashed-diff

Kind regards,

Taco van Dijk & Lodewijk Loos
Waag Society

-- 
PGP: 82EDF574 




From MAILER-DAEMON Sat Dec 26 13:09:08 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aCtHA-0003Pz-MK
	for mharc-bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:09:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34387)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCtH7-0003PJ-CL
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:09:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCtH4-00088z-04
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:09:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:34388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCtH3-00088v-T0
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:09:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCtH3-0005u4-N9
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:09:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Santiago Vila <sanvila@unex.es>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 26 Dec 2015 18:09:01 +0000
Resent-Message-ID: <handler.22245.B.145115332622658@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 22245
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 22245@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.145115332622658
	(code B ref -1); Sat, 26 Dec 2015 18:09:01 +0000
Received: (at submit) by debbugs.gnu.org; 26 Dec 2015 18:08:46 +0000
Received: from localhost ([127.0.0.1]:41990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aCtGb-0005t8-NX
	for submit@debbugs.gnu.org; Sat, 26 Dec 2015 13:08:45 -0500
Received: from eggs.gnu.org ([208.118.235.92]:43334)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <sanvila@unex.es>) id 1aCtGR-0005sk-TW
	for submit@debbugs.gnu.org; Sat, 26 Dec 2015 13:08:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1aCtGL-00085n-2t
	for submit@debbugs.gnu.org; Sat, 26 Dec 2015 13:08:18 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:48670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1aCtGK-00085j-Vw
	for submit@debbugs.gnu.org; Sat, 26 Dec 2015 13:08:17 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1aCtGJ-0003M4-Bp
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:08:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1aCtGG-00085O-1y
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:08:15 -0500
Received: from zmta01.unex.es ([158.49.17.55]:47770)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanvila@unex.es>) id 1aCtGF-00085K-NC
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 13:08:11 -0500
Received: from localhost (localhost [127.0.0.1])
	by zmta01.unex.es (Postfix) with ESMTP id 98D82610E7;
	Sat, 26 Dec 2015 19:08:07 +0100 (CET)
Received: from zmta01.unex.es ([127.0.0.1])
	by localhost (zmta01.servicios.unex.es [127.0.0.1]) (amavisd-new,
	port 10032)
	with ESMTP id eEqHo9bXoXyV; Sat, 26 Dec 2015 19:07:56 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by zmta01.unex.es (Postfix) with ESMTP id 72EE5610EA;
	Sat, 26 Dec 2015 19:07:56 +0100 (CET)
X-Virus-Scanned: amavisd-new at zmta01.siue
Received: from zmta01.unex.es ([127.0.0.1])
	by localhost (zmta01.servicios.unex.es [127.0.0.1]) (amavisd-new,
	port 10026)
	with ESMTP id JbqHWNroVezO; Sat, 26 Dec 2015 19:07:56 +0100 (CET)
Received: from zproxy01.unex.es (zproxy01.servicios.unex.es [10.254.208.61])
	by zmta01.unex.es (Postfix) with ESMTP id 24B6B610E7;
	Sat, 26 Dec 2015 19:07:56 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by zproxy01.unex.es (Postfix) with ESMTP id 0D99380198;
	Sat, 26 Dec 2015 19:07:56 +0100 (CET)
Received: from zproxy01.unex.es ([127.0.0.1])
	by localhost (zproxy01.servicios.unex.es [127.0.0.1]) (amavisd-new,
	port 10032)
	with ESMTP id 61ySyW_-slFH; Sat, 26 Dec 2015 19:07:49 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by zproxy01.unex.es (Postfix) with ESMTP id 934688017A;
	Sat, 26 Dec 2015 19:07:49 +0100 (CET)
X-Virus-Scanned: amavisd-new at zproxy01.siue
Received: from zproxy01.unex.es ([127.0.0.1])
	by localhost (zproxy01.servicios.unex.es [127.0.0.1]) (amavisd-new,
	port 10026)
	with ESMTP id 69DBcRUbcJIp; Sat, 26 Dec 2015 19:07:49 +0100 (CET)
Received: from cantor.unex.es (cantor.unex.es [158.49.50.20])
	by zproxy01.unex.es (Postfix) with ESMTPSA id 4C52B8002E;
	Sat, 26 Dec 2015 19:07:49 +0100 (CET)
Received: by cantor.unex.es (Postfix, from userid 1000)
	id 0DE69812B5; Sat, 26 Dec 2015 19:07:49 +0100 (CET)
Date: Sat, 26 Dec 2015 19:07:49 +0100
From: Santiago Vila <sanvila@unex.es>
Message-ID: <20151226180748.GA29426@cantor.unex.es>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ReaqsoxgOBHFXBhH"
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: lamby@debian.org, 809007@bugs.debian.org, 809007-forwarded@bugs.debian.org
Subject: [bug-diffutils] bug#22245: [lamby@debian.org: Bug#809007:
	diffutils: FTBFS: FAIL: test-update-copyright.sh]
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Dec 2015 18:09:07 -0000


--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

Greetings.

I've received this report from the Debian bug system.

In bug-m4 I was told that this is already fixed in gnulib by this commit:

http://git.savannah.gnu.org/cgit/gnulib.git/commit/?h=841d0dcfa8103235836a1aeb0c1ad657f43ade85

so fixing this would be just a matter of making a new release with updated files.

BTW: I find a little bit odd that only the left brace is escaped in
the git commit above. Sure, it will remove the warning about the
left brace, but it looks a little bit inconsistent.

I will apply the attached patch to the Debian diffutils package.

Thanks.

----- Forwarded message from Chris Lamb <lamby@debian.org> -----

Date: Sat, 26 Dec 2015 03:26:13 +0000
From: Chris Lamb <lamby@debian.org>
To: submit@bugs.debian.org
Subject: Bug#809007: diffutils: FTBFS:  FAIL: test-update-copyright.sh

Source: diffutils
Version: 1:3.3-2
Severity: serious
Justification: fails to build from source
User: reproducible-builds@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

diffutils fails to build from source in unstable/amd64. Looks similar to https://bugs.debian.org/808917 ?

  [..]

  ====================================================
     GNU diffutils 3.3: gnulib-tests/test-suite.log
  ====================================================
  
  # TOTAL: 140
  # PASS:  112
  # SKIP:  27
  # XFAIL: 0
  # FAIL:  1
  # XPASS: 0
  # ERROR: 0
  
  .. contents:: :depth: 2
  
  SKIP: test-btowc1.sh
  ====================
  
  Skipping test: no traditional french locale is installed
  
  SKIP: test-btowc2.sh
  ====================
  
  Skipping test: no french Unicode locale is installed
  
  SKIP: test-c-stack2.sh
  ======================
  
  cannot tell stack overflow from crash; consider installing libsigsegv
  
  SKIP: test-mbrtowc1.sh
  ======================
  
  Skipping test: no traditional french locale is installed
  
  SKIP: test-mbrtowc2.sh
  ======================
  
  Skipping test: no french Unicode locale is installed
  
  SKIP: test-mbrtowc3.sh
  ======================
  
  Skipping test: no traditional japanese locale is installed
  
  SKIP: test-mbrtowc4.sh
  ======================
  
  Skipping test: no transitional chinese locale is installed
  
  SKIP: test-mbrtowc-w32-1.sh
  ===========================
  
  Skipping test: not a native Windows system
  
  SKIP: test-mbrtowc-w32-2.sh
  ===========================
  
  Skipping test: not a native Windows system
  
  SKIP: test-mbrtowc-w32-3.sh
  ===========================
  
  Skipping test: not a native Windows system
  
  SKIP: test-mbrtowc-w32-4.sh
  ===========================
  
  Skipping test: not a native Windows system
  
  SKIP: test-mbrtowc-w32-5.sh
  ===========================
  
  Skipping test: not a native Windows system
  
  SKIP: test-mbscasecmp.sh
  ========================
  
  Skipping test: no turkish Unicode locale is installed
  
  SKIP: test-mbsinit.sh
  =====================
  
  Skipping test: no french Unicode locale is installed
  
  SKIP: test-mbsrtowcs1.sh
  ========================
  
  Skipping test: no traditional french locale is installed
  
  SKIP: test-mbsrtowcs2.sh
  ========================
  
  Skipping test: no french Unicode locale is installed
  
  SKIP: test-mbsrtowcs3.sh
  ========================
  
  Skipping test: no traditional japanese locale is installed
  
  SKIP: test-mbsrtowcs4.sh
  ========================
  
  Skipping test: no transitional chinese locale is installed
  
  SKIP: test-mbsstr2.sh
  =====================
  
  Skipping test: no french Unicode locale is installed
  
  SKIP: test-mbsstr3.sh
  =====================
  
  Skipping test: no chinese GB18030 locale is installed
  
  SKIP: test-setlocale1.sh
  ========================
  
  Skipping test: no locale for testing is installed
  
  FAIL: test-update-copyright.sh
  ==============================
  
  --- -	2015-12-26 03:23:35.680766889 +0000
  +++ update-copyright.test-ex-stderr	2015-12-26 03:23:35.675558045 +0000
  @@ -1,2 +1,18 @@
  +Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\G(?:(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)(?:\([cC]\)|@copyright{ <-- HERE }|&copy;))?(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)(?:(?:\d\d)?\d\d(?:,(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)?|-))*((?:\d\d)?\d\d)(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)Free(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)Software(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)Foundation,(?:[ \t\r\f]*(?:[ \t\r\f]|\n)[ \t\r\f]*)Inc./ at /home/lamby/temp/cdt.20151226032241.UmKbS7wF5C/diffutils-3.3/build-aux/update-copyright line 174, <> chunk 1.

[...]

--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename="diffutils.add-escapes-for-braces-in-perl-regex.txt"

--- a/build-aux/update-copyright
+++ b/build-aux/update-copyright
@@ -124,7 +124,7 @@
 use warnings;
 
 my $copyright_re = 'Copyright';
-my $circle_c_re = '(?:\([cC]\)|@copyright{}|&copy;)';
+my $circle_c_re = '(?:\([cC]\)|@copyright\{\}|&copy;)';
 my $holder = $ENV{UPDATE_COPYRIGHT_HOLDER};
 $holder ||= 'Free Software Foundation, Inc.';
 my $prefix_max = 5;

--ReaqsoxgOBHFXBhH--




From MAILER-DAEMON Sat Dec 26 14:16:09 2015
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aCuK1-0001RO-DW
	for mharc-bug-diffutils@gnu.org; Sat, 26 Dec 2015 14:16:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCuJz-0001QV-Em
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 14:16:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCuJu-0007in-FX
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 14:16:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:34523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCuJu-0007ij-9L
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 14:16:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aCuJu-0003cR-68
	for bug-diffutils@gnu.org; Sat, 26 Dec 2015 14:16:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 26 Dec 2015 19:16:02 +0000
Resent-Message-ID: <handler.22245.B22245.145115735313339@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22245
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Santiago Vila <sanvila@unex.es>, 22245@debbugs.gnu.org
Received: via spool by 22245-submit@debbugs.gnu.org id=B22245.145115735313339
	(code B ref 22245); Sat, 26 Dec 2015 19:16:02 +0000
Received: (at 22245) by debbugs.gnu.org; 26 Dec 2015 19:15:53 +0000
Received: from localhost ([127.0.0.1]:42125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aCuJk-0003Sl-LK
	for submit@debbugs.gnu.org; Sat, 26 Dec 2015 14:15:52 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60512)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <eggert@cs.ucla.edu>) id 1aCuJi-0003KU-PU
	for 22245@debbugs.gnu.org; Sat, 26 Dec 2015 14:15:51 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1301C1607C4;
	Sat, 26 Dec 2015 11:15:45 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id tQzslbspHYvu; Sat, 26 Dec 2015 11:15:44 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 38E9B160817;
	Sat, 26 Dec 2015 11:15:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id QAKd43KlFu03; Sat, 26 Dec 2015 11:15:44 -0800 (PST)
Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net
	[100.32.155.148])
	by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 05DA71607C4;
	Sat, 26 Dec 2015 11:15:44 -0800 (PST)
References: <20151226180748.GA29426@cantor.unex.es>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <567EE75F.7020102@cs.ucla.edu>
Date: Sat, 26 Dec 2015 11:15:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151226180748.GA29426@cantor.unex.es>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: lamby@debian.org, 809007@bugs.debian.org, 809007-forwarded@bugs.debian.org
Subject: [bug-diffutils] bug#22245: bug#22245: [lamby@debian.org:
	Bug#809007: diffutils: FTBFS: FAIL: test-update-copyright.sh]
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Dec 2015 19:16:08 -0000

Santiago Vila wrote:
> I find a little bit odd that only the left brace is escaped in
> the git commit above. Sure, it will remove the warning about the
> left brace, but it looks a little bit inconsistent.

It depends on which sort of consistency one wants. I mildly prefer omitting 
backslashes when not needed, as this helps avoid usages like:

grep '\[.*\]' *.c

which has undefined behavior due to the '\]'. Admittedly that's a POSIX regular 
expression, not Perl.




