From MAILER-DAEMON Tue Mar 01 03:26:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aafdC-00051I-C4
	for mharc-bug-diffutils@gnu.org; Tue, 01 Mar 2016 03:26:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aafd9-0004uA-5W
	for bug-diffutils@gnu.org; Tue, 01 Mar 2016 03:26:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aafd4-00030H-Uk
	for bug-diffutils@gnu.org; Tue, 01 Mar 2016 03:26:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:57584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aafd4-00030D-Rf
	for bug-diffutils@gnu.org; Tue, 01 Mar 2016 03:26:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aafd4-0006zr-4x
	for bug-diffutils@gnu.org; Tue, 01 Mar 2016 03:26:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Giuseppe Scrivano <gscrivano@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 01 Mar 2016 08:26:02 +0000
Resent-Message-ID: <handler.22067.B22067.145682071326840@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 22067-submit@debbugs.gnu.org id=B22067.145682071326840
	(code B ref 22067); Tue, 01 Mar 2016 08:26:02 +0000
Received: (at 22067) by debbugs.gnu.org; 1 Mar 2016 08:25:13 +0000
Received: from localhost ([127.0.0.1]:54711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aafcG-0006yp-UW
	for submit@debbugs.gnu.org; Tue, 01 Mar 2016 03:25:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58277)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <gscrivano@gnu.org>) id 1aafcF-0006yb-CP
	for 22067@debbugs.gnu.org; Tue, 01 Mar 2016 03:25:11 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 76A4064D33;
	Tue,  1 Mar 2016 08:25:05 +0000 (UTC)
Received: from foo.bar.baz (vpn1-4-41.ams2.redhat.com [10.36.4.41])
	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id u218P1kX028214
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO); Tue, 1 Mar 2016 03:25:03 -0500
From: Giuseppe Scrivano <gscrivano@gnu.org>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz>
Date: Tue, 01 Mar 2016 09:25:01 +0100
In-Reply-To: <87lh6q55c3.fsf@foo.bar.baz> (Giuseppe Scrivano's message of
	"Fri, 12 Feb 2016 16:14:04 +0100")
Message-ID: <87h9gq38rm.fsf@foo.bar.baz>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
	(mx1.redhat.com [10.5.110.39]); Tue, 01 Mar 2016 08:25:05 +0000 (UTC)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 08:26:08 -0000

Giuseppe Scrivano <gscrivano@gnu.org> writes:

> Jim Meyering <jim@meyering.net> writes:
>
>> Great! Thank you.
>>
>>> but it will need a change in the code as well, since
>>> the signals are installed only when outputting to a tty:
>> ...
>>> -  if (output_is_tty)
>>> +  if (output_is_tty || getenv ("DIFF_INSTALL_SIGNALS"))
>>>      install_signal_handlers ();
>>
>> However, we try very hard to avoid making tools depend on
>> environment variable settings more than they already do,
>> so how about a hidden, three-hyphen option, say,
>> ---presume-output-tty, analogous to rm's ---presume-input-tty?
>
> I have added a test that uses the new option ---presume-output-tty.
>
> From 4aea918d31454fdeaada5e2453bea3dfc2e25f8b Mon Sep 17 00:00:00 2001
> From: Giuseppe Scrivano <gscrivano@gnu.org>
> Date: Mon, 1 Feb 2016 09:58:52 +0100
> Subject: [PATCH] Fix an infinite recursion with --color
>
> * src/diff.h: New extern variable `presume_output_tty'.
> * src/diff.c: New enum PRESUME_OUTPUT_TTY_OPTION.
> (group_format_option): Add '-presume-output-tty'.
> (main): Handle PRESUME_OUTPUT_TTY_OPTION.
> * src/util.c: New variable `presume_output_tty'.
> (check_color_output): Handle presume_output_tty.
> (set_color_context): Call process_signals only when color_context is
> not RESET_CONTEXT.
> * tests/colors: Check that diff doesn't crash when interrupted
> in the middle of a color sequence.
>
> Reported by Gisle Vanem in http://debbugs.gnu.org/22067
> ---

ping.

Regards,
Giuseppe




From MAILER-DAEMON Mon Mar 07 10:20:14 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acwxC-0005pC-LS
	for mharc-bug-diffutils@gnu.org; Mon, 07 Mar 2016 10:20:14 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acwx5-0005bj-0K
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 10:20:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acwx0-0005pq-1g
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 10:20:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acwwz-0005pk-VX
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 10:20:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acwwz-0003yk-Rf
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 10:20:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Mar 2016 15:20:01 +0000
Resent-Message-ID: <handler.22067.B22067.145736397415255@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Giuseppe Scrivano <gscrivano@gnu.org>
Received: via spool by 22067-submit@debbugs.gnu.org id=B22067.145736397415255
	(code B ref 22067); Mon, 07 Mar 2016 15:20:01 +0000
Received: (at 22067) by debbugs.gnu.org; 7 Mar 2016 15:19:34 +0000
Received: from localhost ([127.0.0.1]:38208 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1acwwX-0003xz-R2
	for submit@debbugs.gnu.org; Mon, 07 Mar 2016 10:19:34 -0500
Received: from mail-oi0-f54.google.com ([209.85.218.54]:33027)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <meyering@gmail.com>) id 1acwwV-0003xm-O0
	for 22067@debbugs.gnu.org; Mon, 07 Mar 2016 10:19:32 -0500
Received: by mail-oi0-f54.google.com with SMTP id d205so81380264oia.0
	for <22067@debbugs.gnu.org>; Mon, 07 Mar 2016 07:19:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc;
	bh=PS5+2a+pWFVsqSpzwvSz6ns+EOZIJ70+dUznhj7tuZw=;
	b=wttiIGFfFk2hT0xTg3Jqn5GOIXw5AXVOq4DPe5B7876yHwMVVNO5gHm95xDHdeSqdL
	RopgtYNBuvOgRULnKYOYg5ESEQWLBtbRTvt6fR8WrWAISUAdXs91t6rDItLperZQj7bM
	71pe6qZ6S1SZuos9ww1FNIXbXYo6FTtagce1zFT7udQOYtjmcO3/qVyu5Vh2RHekDeu4
	k8K7NCKi2lLCXcJbH1t+XqxXJpmqF1i5pd9cknMg0a+dXMaIrtpmF/7o85IFR6KGw+Fs
	kTxTeZoSzUUbXxvWbPM4XX5AndMYA1VpzTA1vRb91t6Y4PkutvNEqkZwPTIwzHI8m6SG
	LYvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
	:date:message-id:subject:to:cc;
	bh=PS5+2a+pWFVsqSpzwvSz6ns+EOZIJ70+dUznhj7tuZw=;
	b=P1X1bzyvsGiTAr+DWCmx+nHMR4BVYEh0224UIwHcrfBns/5hgr2N2NbN0arvRSuhZ8
	VfIJhhXFpPl4T8FWKRSYX5tKTI0lVbFJqa0dttK53RnAO7Is78Brtp4e40pARdBHYZz7
	Jdq/FGhmMN1ixxNPhlH1i5xAC+REB0t5OivYp/kNu8lw3laq8UJ+E+pEHoXesT7skAjZ
	jHVLji6cJN9yOOQdiCnrRcp/Ie+lG+5mEbAxDZ45k8b2Uw0WDY1K3+3PjX2Tl1bbGNUo
	hlzgqtBBeWYbOdprWV+emA4n4C62cGi8DWJ9X/ZHU+rd5aXfXXZNp/zV8CDi5vF3fKZu
	SQ8g==
X-Gm-Message-State: AD7BkJJ04yKPQ16Rx4Lltm+LsxR529M1gMQQ9TO3WBrLwb3pykid9Ftp/8uDOpP3cM/luMCWLKo6od6S5wJ2ow==
X-Received: by 10.202.56.86 with SMTP id f83mr14385984oia.64.1457363966187;
	Mon, 07 Mar 2016 07:19:26 -0800 (PST)
MIME-Version: 1.0
Received: by 10.202.82.194 with HTTP; Mon, 7 Mar 2016 07:19:06 -0800 (PST)
In-Reply-To: <87h9gq38rm.fsf@foo.bar.baz>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
From: Jim Meyering <jim@meyering.net>
Date: Mon, 7 Mar 2016 07:19:06 -0800
X-Google-Sender-Auth: klOaXciP5SlPpoWdr0yKcvohqRk
Message-ID: <CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
Content-Type: multipart/mixed; boundary=001a113cc114837531052d76fdfa
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 15:20:13 -0000

--001a113cc114837531052d76fdfa
Content-Type: text/plain; charset=UTF-8

On Tue, Mar 1, 2016 at 12:25 AM, Giuseppe Scrivano <gscrivano@gnu.org> wrote:
> Giuseppe Scrivano <gscrivano@gnu.org> writes:
>
>> Jim Meyering <jim@meyering.net> writes:
>>
>>> Great! Thank you.
>>>
>>>> but it will need a change in the code as well, since
>>>> the signals are installed only when outputting to a tty:
>>> ...
>>>> -  if (output_is_tty)
>>>> +  if (output_is_tty || getenv ("DIFF_INSTALL_SIGNALS"))
>>>>      install_signal_handlers ();
>>>
>>> However, we try very hard to avoid making tools depend on
>>> environment variable settings more than they already do,
>>> so how about a hidden, three-hyphen option, say,
>>> ---presume-output-tty, analogous to rm's ---presume-input-tty?
>>
>> I have added a test that uses the new option ---presume-output-tty.
>>
>> From 4aea918d31454fdeaada5e2453bea3dfc2e25f8b Mon Sep 17 00:00:00 2001
>> From: Giuseppe Scrivano <gscrivano@gnu.org>
>> Date: Mon, 1 Feb 2016 09:58:52 +0100
>> Subject: [PATCH] Fix an infinite recursion with --color
>>
>> * src/diff.h: New extern variable `presume_output_tty'.
>> * src/diff.c: New enum PRESUME_OUTPUT_TTY_OPTION.
>> (group_format_option): Add '-presume-output-tty'.
>> (main): Handle PRESUME_OUTPUT_TTY_OPTION.
>> * src/util.c: New variable `presume_output_tty'.
>> (check_color_output): Handle presume_output_tty.
>> (set_color_context): Call process_signals only when color_context is
>> not RESET_CONTEXT.
>> * tests/colors: Check that diff doesn't crash when interrupted
>> in the middle of a color sequence.
>>
>> Reported by Gisle Vanem in http://debbugs.gnu.org/22067

Thank you, and sorry about the delay.
I noticed that on OS X, the new test passed even without
the fix, but didn't want to let that hold up the fix any longer.
I've adjusted the test slightly, to eliminate the tr pipes.
Will wait for your "ack", before pushing.

--001a113cc114837531052d76fdfa
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-diff-color-fix-an-infinite-recursion-bug.patch"
Content-Disposition: attachment; 
	filename="0001-diff-color-fix-an-infinite-recursion-bug.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ili4tztg0

RnJvbSAxN2UyNjk4YmNiZWUzMGE2Y2MyODJkNjFhZDYyNDJhNjRiYTljN2NmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHaXVzZXBwZSBTY3JpdmFubyA8Z3Njcml2YW5vQGdudS5vcmc+
CkRhdGU6IE1vbiwgMSBGZWIgMjAxNiAwOTo1ODo1MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGRp
ZmY6IC0tY29sb3I6IGZpeCBhbiBpbmZpbml0ZSByZWN1cnNpb24gYnVnCgoqIHNyYy9kaWZmLmgg
KHByZXN1bWVfb3V0cHV0X3R0eSk6IE5ldyBleHRlcm4gdmFyaWFibGUuCiogc3JjL2RpZmYuYyAo
UFJFU1VNRV9PVVRQVVRfVFRZX09QVElPTik6IE5ldyBlbnVtLgooZ3JvdXBfZm9ybWF0X29wdGlv
bik6IEFkZCAnLXByZXN1bWUtb3V0cHV0LXR0eScuCihtYWluKTogSGFuZGxlIFBSRVNVTUVfT1VU
UFVUX1RUWV9PUFRJT04uCiogc3JjL3V0aWwuYzogTmV3IHZhcmlhYmxlIGBwcmVzdW1lX291dHB1
dF90dHknLgooY2hlY2tfY29sb3Jfb3V0cHV0KTogSGFuZGxlIHByZXN1bWVfb3V0cHV0X3R0eS4K
KHNldF9jb2xvcl9jb250ZXh0KTogQ2FsbCBwcm9jZXNzX3NpZ25hbHMgb25seSB3aGVuIGNvbG9y
X2NvbnRleHQgaXMKbm90IFJFU0VUX0NPTlRFWFQuCiogdGVzdHMvY29sb3JzOiBDaGVjayB0aGF0
IGRpZmYgZG9lc24ndCBjcmFzaCB3aGVuIGludGVycnVwdGVkCmluIHRoZSBtaWRkbGUgb2YgYSBj
b2xvciBzZXF1ZW5jZS4KClJlcG9ydGVkIGJ5IEdpc2xlIFZhbmVtIGluIGh0dHA6Ly9kZWJidWdz
LmdudS5vcmcvMjIwNjcKLS0tCiBzcmMvZGlmZi5jICAgfCA5ICsrKysrKysrKwogc3JjL2RpZmYu
aCAgIHwgMiArKwogc3JjL3V0aWwuYyAgIHwgNyArKysrKy0tCiB0ZXN0cy9jb2xvcnMgfCA5ICsr
KysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL3NyYy9kaWZmLmMgYi9zcmMvZGlmZi5jCmluZGV4IDNhNTY2YjguLjli
YzFkOTYgMTAwNjQ0Ci0tLSBhL3NyYy9kaWZmLmMKKysrIGIvc3JjL2RpZmYuYwpAQCAtMTQxLDYg
KzE0MSw4IEBAIGVudW0KCiAgIENPTE9SX09QVElPTiwKICAgQ09MT1JfUEFMRVRURV9PUFRJT04s
CisKKyAgUFJFU1VNRV9PVVRQVVRfVFRZX09QVElPTiwKIH07Cgogc3RhdGljIGNoYXIgY29uc3Qg
Z3JvdXBfZm9ybWF0X29wdGlvbltdW3NpemVvZiAiLS11bmNoYW5nZWQtZ3JvdXAtZm9ybWF0Il0g
PQpAQCAtMjE5LDYgKzIyMSw5IEBAIHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIGNvbnN0IGxvbmdvcHRz
W10gPQogICB7InVuaWZpZWQiLCAyLCAwLCAnVSd9LAogICB7InZlcnNpb24iLCAwLCAwLCAndid9
LAogICB7IndpZHRoIiwgMSwgMCwgJ1cnfSwKKworICAvKiBUaGlzIGlzIHNvbGVseSBmb3IgdGVz
dGluZy4gIERvIG5vdCBkb2N1bWVudC4gICovCisgIHsiLXByZXN1bWUtb3V0cHV0LXR0eSIsIG5v
X2FyZ3VtZW50LCBOVUxMLCBQUkVTVU1FX09VVFBVVF9UVFlfT1BUSU9OfSwKICAgezAsIDAsIDAs
IDB9CiB9OwoKQEAgLTY0MSw2ICs2NDYsMTAgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2
KQogCSAgc2V0X2NvbG9yX3BhbGV0dGUgKG9wdGFyZyk7CiAJICBicmVhazsKCisgICAgICAgIGNh
c2UgUFJFU1VNRV9PVVRQVVRfVFRZX09QVElPTjoKKyAgICAgICAgICBwcmVzdW1lX291dHB1dF90
dHkgPSB0cnVlOworICAgICAgICAgIGJyZWFrOworCiAJZGVmYXVsdDoKIAkgIHRyeV9oZWxwIChO
VUxMLCBOVUxMKTsKIAl9CmRpZmYgLS1naXQgYS9zcmMvZGlmZi5oIGIvc3JjL2RpZmYuaAppbmRl
eCBlNGMxMzhjLi4wOTgzZTdjIDEwMDY0NAotLS0gYS9zcmMvZGlmZi5oCisrKyBiL3NyYy9kaWZm
LmgKQEAgLTQxNyw1ICs0MTcsNyBAQCBlbnVtIGNvbG9yX2NvbnRleHQKICAgTElORV9OVU1CRVJf
Q09OVEVYVCwKIH07CgorWFRFUk4gYm9vbCBwcmVzdW1lX291dHB1dF90dHk7CisKIGV4dGVybiB2
b2lkIHNldF9jb2xvcl9jb250ZXh0IChlbnVtIGNvbG9yX2NvbnRleHQgY29sb3JfY29udGV4dCk7
CiBleHRlcm4gdm9pZCBzZXRfY29sb3JfcGFsZXR0ZSAoY2hhciBjb25zdCAqcGFsZXR0ZSk7CmRp
ZmYgLS1naXQgYS9zcmMvdXRpbC5jIGIvc3JjL3V0aWwuYwppbmRleCBiZjllZDk3Li5kN2I4OTI1
IDEwMDY0NAotLS0gYS9zcmMvdXRpbC5jCisrKyBiL3NyYy91dGlsLmMKQEAgLTQ0LDYgKzQ0LDgg
QEAKCiBjaGFyIGNvbnN0IHByX3Byb2dyYW1bXSA9IFBSX1BST0dSQU07CgorYm9vbCBwcmVzdW1l
X291dHB1dF90dHk7CisKIC8qIFF1ZXVlIHVwIG9uZS1saW5lIG1lc3NhZ2VzIHRvIGJlIHByaW50
ZWQgYXQgdGhlIGVuZCwKICAgIHdoZW4gLWwgaXMgc3BlY2lmaWVkLiAgRWFjaCBtZXNzYWdlIGlz
IHJlY29yZGVkIHdpdGggYSAnc3RydWN0IG1zZycuICAqLwoKQEAgLTcxMCw3ICs3MTIsNyBAQCBj
aGVja19jb2xvcl9vdXRwdXQgKGJvb2wgaXNfcGlwZSkKICAgaWYgKCEgb3V0ZmlsZSB8fCBjb2xv
cnNfc3R5bGUgPT0gTkVWRVIpCiAgICAgcmV0dXJuOwoKLSAgb3V0cHV0X2lzX3R0eSA9ICFpc19w
aXBlICYmIGlzYXR0eSAoZmlsZW5vIChvdXRmaWxlKSk7CisgIG91dHB1dF9pc190dHkgPSBwcmVz
dW1lX291dHB1dF90dHkgfHwgKCFpc19waXBlICYmIGlzYXR0eSAoZmlsZW5vIChvdXRmaWxlKSkp
OwoKICAgY29sb3JzX2VuYWJsZWQgPSAoY29sb3JzX3N0eWxlID09IEFMV0FZUwogICAgICAgICAg
ICAgICAgICAgICB8fCAoY29sb3JzX3N0eWxlID09IEFVVE8gJiYgb3V0cHV0X2lzX3R0eSkpOwpA
QCAtMTM0OSw3ICsxMzUxLDggQEAgc3RhdGljIGVudW0gY29sb3JfY29udGV4dCBsYXN0X2NvbnRl
eHQgPSBSRVNFVF9DT05URVhUOwogdm9pZAogc2V0X2NvbG9yX2NvbnRleHQgKGVudW0gY29sb3Jf
Y29udGV4dCBjb2xvcl9jb250ZXh0KQogewotICBwcm9jZXNzX3NpZ25hbHMgKCk7CisgIGlmIChj
b2xvcl9jb250ZXh0ICE9IFJFU0VUX0NPTlRFWFQpCisgICAgcHJvY2Vzc19zaWduYWxzICgpOwog
ICBpZiAoY29sb3JzX2VuYWJsZWQgJiYgbGFzdF9jb250ZXh0ICE9IGNvbG9yX2NvbnRleHQpCiAg
ICAgewogICAgICAgcHV0X2luZGljYXRvciAoJmNvbG9yX2luZGljYXRvcltDX0xFRlRdKTsKZGlm
ZiAtLWdpdCBhL3Rlc3RzL2NvbG9ycyBiL3Rlc3RzL2NvbG9ycwppbmRleCBmYWNmZDhkLi44ODFj
MWI4IDEwMDc1NQotLS0gYS90ZXN0cy9jb2xvcnMKKysrIGIvdGVzdHMvY29sb3JzCkBAIC0xMTYs
NCArMTE2LDEzIEBAIHRlc3QgJD8gPSAxIHx8IGZhaWw9MQogZ2VuX2V4cF91ID4gZXhwIHx8IGZy
YW1ld29ya19mYWlsdXJlXwogY29tcGFyZSBleHAgb3V0IHx8IGZhaWw9MQoKKyMgQmVmb3JlIHRo
ZSBmaXggaW4gaHR0cDovL2RlYmJ1Z3MuZ251Lm9yZy8yMjA2NywKKyMgdGhpcyB0ZXN0IHdvdWxk
IHRyaWdnZXIgYW4gaW5maW5pdGUgbG9vcCBidWcuCitta2ZpZm8gZmlmbworcHJpbnRmICclKnMt
YScgMTAwMDAwMCA+IGEKK3ByaW50ZiAnJSpzLWInIDEwMDAwMDAgPiBiCitoZWFkIC1jIDEwIDwg
ZmlmbyA+IC9kZXYvbnVsbCAmCitkaWZmIC0tY29sb3I9YWx3YXlzIC0tLXByZXN1bWUtb3V0cHV0
LXR0eSBhIGIgPiBmaWZvCit0ZXN0ICQ/ID0gMTQxIHx8IGZhaWw9MQorCiBFeGl0ICRmYWlsCi0t
IAoyLjcuMgoK
--001a113cc114837531052d76fdfa--




From MAILER-DAEMON Mon Mar 07 11:18:13 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acxrJ-0000yA-Ke
	for mharc-bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:18:13 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acxrE-0000rL-0z
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:18:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acxr8-0006H3-4C
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:18:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acxr8-0006Gy-1X
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:18:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acxr7-0005LQ-RD
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:18:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Giuseppe Scrivano <gscrivano@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Mar 2016 16:18:01 +0000
Resent-Message-ID: <handler.22067.B22067.145736747920536@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 22067-submit@debbugs.gnu.org id=B22067.145736747920536
	(code B ref 22067); Mon, 07 Mar 2016 16:18:01 +0000
Received: (at 22067) by debbugs.gnu.org; 7 Mar 2016 16:17:59 +0000
Received: from localhost ([127.0.0.1]:38245 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1acxr5-0005LA-7r
	for submit@debbugs.gnu.org; Mon, 07 Mar 2016 11:17:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42548)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <gscrivano@gnu.org>) id 1acxr3-0005Kw-PS
	for 22067@debbugs.gnu.org; Mon, 07 Mar 2016 11:17:58 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id BDA972548;
	Mon,  7 Mar 2016 16:17:51 +0000 (UTC)
Received: from foo.bar.baz (vpn1-4-43.ams2.redhat.com [10.36.4.43])
	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id u27GHmaB029744
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO); Mon, 7 Mar 2016 11:17:50 -0500
From: Giuseppe Scrivano <gscrivano@gnu.org>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
Date: Mon, 07 Mar 2016 17:17:48 +0100
In-Reply-To: <CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	(Jim Meyering's message of "Mon, 7 Mar 2016 07:19:06 -0800")
Message-ID: <87y49ui7o3.fsf@foo.bar.baz>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 16:18:11 -0000

Jim Meyering <jim@meyering.net> writes:

> Thank you, and sorry about the delay.
> I noticed that on OS X, the new test passed even without
> the fix, but didn't want to let that hold up the fix any longer.
> I've adjusted the test slightly, to eliminate the tr pipes.
> Will wait for your "ack", before pushing.

Unfortunately I have no access to OS X to test it out by myself.

It is fine by me without the 'tr' so ACK from me.

Thanks for the review,
Giuseppe






From MAILER-DAEMON Mon Mar 07 11:33:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acy5m-0001IL-0U
	for mharc-bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:33:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acy5k-0001GV-2W
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:33:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acy5f-0003H2-4G
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:33:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41141)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acy5f-0003Gw-1E
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:33:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acy5e-0005iR-TJ
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 11:33:02 -0500
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Mar 2016 16:33:02 +0000
Resent-Message-ID: <handler.22067.D22067.145736833021885.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Giuseppe Scrivano <gscrivano@gnu.org>
Mail-Followup-To: 22067@debbugs.gnu.org, jim@meyering.net, gvanem@yahoo.no
Received: via spool by 22067-done@debbugs.gnu.org id=D22067.145736833021885
	(code D ref 22067); Mon, 07 Mar 2016 16:33:02 +0000
Received: (at 22067-done) by debbugs.gnu.org; 7 Mar 2016 16:32:10 +0000
Received: from localhost ([127.0.0.1]:38264 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1acy4o-0005gv-7m
	for submit@debbugs.gnu.org; Mon, 07 Mar 2016 11:32:10 -0500
Received: from mail-oi0-f42.google.com ([209.85.218.42]:36185)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <meyering@gmail.com>) id 1acy4m-0005gj-AU
	for 22067-done@debbugs.gnu.org; Mon, 07 Mar 2016 11:32:08 -0500
Received: by mail-oi0-f42.google.com with SMTP id r187so82899554oih.3
	for <22067-done@debbugs.gnu.org>; Mon, 07 Mar 2016 08:32:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc;
	bh=p4rdKoZkalTkZIjJOdUmzj/l4ZFLtRWt5eQMBMUwDH8=;
	b=gUQle3UvdWCK3MCIq8Pgo6Z6U3xLYNdiAFIlYailL0bZyoC+K1s/QAOjFWpwEtZCGW
	e1G0w8AOOpTHtBSlbLpnFiXU6kSiy8N8Iw2obtLlGgJbbRFs0xsILGonLloedu3AEmeL
	RDFaIbYZ43NjENjm0Q1H93IcWsgm31GYywiUMaXVW+NRGg5HYr/1a/MnMOxVxaleFx0J
	Dc27vQKkIxSx25G8Wu8PyAvJSjswsRkav5oe5HpyxntbKHWbBZ071BPKJ8vBd0MGpUb5
	Tu4uZeDleFii9PT5pWReXI4zgXdVn0XoLwt1GJCM1EQG93/3ZM9jYmE0Rf3Kb+AWI0PC
	XLKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
	:date:message-id:subject:to:cc;
	bh=p4rdKoZkalTkZIjJOdUmzj/l4ZFLtRWt5eQMBMUwDH8=;
	b=JUWUbELtugMgxjEvSPwpJOIVg1Br8qatZ0UAhdTk3ClRrTKEy5AXYOmeZtHiUgDbu9
	Ig4Df9TQNDU0nSR+YMXcT4UG7ENrRZ1RLlid2edWYFUHucmzMg6M1xHdk/9KG/yL1td5
	BBMmfrbYUEIU3reiVlj5/vygON0Jp9ujoDE387JgUQah2v9ov9Otu9qmF7ihk3dWAf+5
	otk259rIpsrAT0jrjaktxrKBXPAEe237Y7jqzIV5PqzEXBG+IWK98ihwjAwmhHjRIhFG
	7RellLLwZWR7meZUh4tkdU+F0Y6agB3j7Qxfi18IDG+Bf0KwJtMCnR/4bABjswVBSqig
	vkDQ==
X-Gm-Message-State: AD7BkJKhp4xUh5mMCcG5elbXYmJp9SC/aUO30C62P/FfCpUC2PrzPljA+cdPfW4+8REotGx/hrB44oDrl4FZzw==
X-Received: by 10.202.79.83 with SMTP id d80mr8879826oib.69.1457368322665;
	Mon, 07 Mar 2016 08:32:02 -0800 (PST)
MIME-Version: 1.0
Received: by 10.202.82.194 with HTTP; Mon, 7 Mar 2016 08:31:42 -0800 (PST)
In-Reply-To: <87y49ui7o3.fsf@foo.bar.baz>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
From: Jim Meyering <jim@meyering.net>
Date: Mon, 7 Mar 2016 08:31:42 -0800
X-Google-Sender-Auth: L5PbhKS21Nbc-FjyCsybO4IXpjk
Message-ID: <CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 16:33:08 -0000

pushed.




From MAILER-DAEMON Mon Mar 07 12:21:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acyqE-0006xp-Hg
	for mharc-bug-diffutils@gnu.org; Mon, 07 Mar 2016 12:21:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acyqC-0006xL-C6
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 12:21:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acyq7-0007X4-9q
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 12:21:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acyq7-0007W1-1z
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 12:21:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1acyq5-0006wx-Po
	for bug-diffutils@gnu.org; Mon, 07 Mar 2016 12:21:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Gisle Vanem <gvanem@yahoo.no>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Mar 2016 17:21:01 +0000
Resent-Message-ID: <handler.22067.B22067.145737123026669@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 22067@debbugs.gnu.org
Received: via spool by 22067-submit@debbugs.gnu.org id=B22067.145737123026669
	(code B ref 22067); Mon, 07 Mar 2016 17:21:01 +0000
Received: (at 22067) by debbugs.gnu.org; 7 Mar 2016 17:20:30 +0000
Received: from localhost ([127.0.0.1]:38315 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1acypa-0006w5-A7
	for submit@debbugs.gnu.org; Mon, 07 Mar 2016 12:20:30 -0500
Received: from nm35-vm6.bullet.mail.ir2.yahoo.com ([212.82.97.129]:43683)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <gvanem@yahoo.no>) id 1acypY-0006vr-Ay
	for 22067@debbugs.gnu.org; Mon, 07 Mar 2016 12:20:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.no; s=s2048;
	t=1457371222; bh=h1UYGUle1NMk4+yOAqApI9o/4sFsyN/s0mKwiC0JcGQ=;
	h=Subject:To:References:From:Date:In-Reply-To:From:Subject;
	b=LMr1D+moTnIIsszJVSSUwZh38I6MOTFUiSzUr6TcdTRwmU3hvVTmr2+iHd0YSUWttjbKZCEgIS6Toz1EzTJJXCJRyjkaJH+k+Tg+Ml+ockgXz37eUR//fQJnUPfl+5fkNqutYDWF1RZvKQ1TdIJY7XzotHZ5v7OJBGix3hSOfAyUsGk4RCmeIwFTk3+2+hAQqvCd/mpZ4ao+bRCBLoEICI/SKknvnB1fmBqBBAtup5V7+h6grQFo8iFgTvWyzfs0MspyDSnvf5rSb2f5rzp9/ITPrHposmE+NXb9S1zRepXDHQ2T3p0b71umrrq2//Plg//keBz0WAxKEjG8KAlBtg==
Received: from [212.82.98.61] by nm35.bullet.mail.ir2.yahoo.com with NNFMP;
	07 Mar 2016 17:20:22 -0000
Received: from [46.228.39.78] by tm14.bullet.mail.ir2.yahoo.com with NNFMP;
	07 Mar 2016 17:20:22 -0000
Received: from [127.0.0.1] by smtp115.mail.ir2.yahoo.com with NNFMP;
	07 Mar 2016 17:20:22 -0000
X-Yahoo-Newman-Id: 418952.62788.bm@smtp115.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: VjFwAcoVM1le1z88CHDtEh1rh1Nq_HgLnDtfovdko4m1NSK
	4kno5FocVoE2_u0ElBqBR2lZxvA.fQzFHOSQ9fCn2DXBflAwxT1J_qbDDn5t
	mkjfdreuktb3.DzZ0AkDOVYSq0bxKNfdNWV9e3M3JxIASZCe7q28s0IOLRsZ
	80P.st1oGbfaBRYu5fUNW8SJIwBuVn6v7KQAzU4PrXyQSppo2pdul6tWX67w
	QHovCfKIlfVNjUnHG2rm5UmUyJWL.UZoJLDjS3tnbbBUBbWYR4oz1HiRZ9re
	0_jO55OUfMNHHGKQt8wsqjYSdWZ3grM8iSl2seeZHPi.xQEqtul.gGv5JvaY
	IBvsKpMtytInmeKk7Z9BJD_WbwMybN8neOFhQdCSZWmuJ.L07ahZHvLGrCxH
	L.YrtDXhOeeaKYjQd94ROyQOOOamQt.IX3G_L7yRxg4DxIqChJ4ZZJrk.Rnb
	MdJzY4niFALpLdW8VOR36sBZXQDZFm7LeXw2zQRiNScjD8H.HU4QmplxYe7_
	GFsfU_5rHwHjxLgJM761i38M-
X-Yahoo-SMTP: 8zhYLGyswBB3AGU8c4pvFIFOfA--
References: <CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	<565D6EF4.20903@yahoo.no>
	<handler.22067.D22067.145736833021885.notifdone@debbugs.gnu.org>
From: Gisle Vanem <gvanem@yahoo.no>
Message-ID: <56DDB85B.2040904@yahoo.no>
Date: Mon, 7 Mar 2016 18:20:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <handler.22067.D22067.145736833021885.notifdone@debbugs.gnu.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#22067: closed (Re: bug#22067: bug#22067:
	bug#20062: bug#20062: [PATCH] diff: add support for --color)
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 17:21:09 -0000

> #22067: [bug-diffutils] bug#20062: bug#20062: [PATCH] diff: add support for --color
> 
> which was filed against the diffutils package, has been closed.

But still no support for colours on a plain Windows console
(except for Cygwin which has ANSI-colour support).

-- 
--gv




From MAILER-DAEMON Tue Mar 08 17:02:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adPhg-0001Pl-7e
	for mharc-bug-diffutils@gnu.org; Tue, 08 Mar 2016 17:02:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53009)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adPhe-0001PG-2L
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 17:02:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adPha-0008Ut-RF
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 17:02:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43066)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adPha-0008UI-Oa
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 17:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adPha-0004Cc-F6
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 17:02:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Giuseppe Scrivano <gscrivano@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 08 Mar 2016 22:02:02 +0000
Resent-Message-ID: <handler.22067.D22067.145747446916077@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 22067-done@debbugs.gnu.org id=D22067.145747446916077
	(code D ref 22067); Tue, 08 Mar 2016 22:02:02 +0000
Received: (at 22067-done) by debbugs.gnu.org; 8 Mar 2016 22:01:09 +0000
Received: from localhost ([127.0.0.1]:40193 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1adPgi-0004BF-Ta
	for submit@debbugs.gnu.org; Tue, 08 Mar 2016 17:01:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55617)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <gscrivano@gnu.org>) id 1adPgh-0004An-FL
	for 22067-done@debbugs.gnu.org; Tue, 08 Mar 2016 17:01:07 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id AA84E9134F;
	Tue,  8 Mar 2016 22:01:01 +0000 (UTC)
Received: from foo.bar.baz (vpn1-5-103.ams2.redhat.com [10.36.5.103])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id u28M0wZh026993
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO); Tue, 8 Mar 2016 17:01:00 -0500
From: Giuseppe Scrivano <gscrivano@gnu.org>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
	<CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
Date: Tue, 08 Mar 2016 23:00:57 +0100
In-Reply-To: <CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	(Jim Meyering's message of "Mon, 7 Mar 2016 08:31:42 -0800")
Message-ID: <87ziu8iq92.fsf@foo.bar.baz>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 22:02:06 -0000

Jim Meyering <jim@meyering.net> writes:

> pushed.

thanks!

Is there going to be any release of diffutils with the new changes?

Regards,
Giuseppe




From MAILER-DAEMON Tue Mar 08 21:34:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adTwu-0005iM-P3
	for mharc-bug-diffutils@gnu.org; Tue, 08 Mar 2016 21:34:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adTws-0005iB-K9
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 21:34:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adTwo-0003OO-6e
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 21:34:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adTwo-0003OK-3O
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 21:34:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1adTwn-0002hB-Ur
	for bug-diffutils@gnu.org; Tue, 08 Mar 2016 21:34:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Wed, 09 Mar 2016 02:34:01 +0000
Resent-Message-ID: <handler.22067.D22067.145749080010304@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Giuseppe Scrivano <gscrivano@gnu.org>
Received: via spool by 22067-done@debbugs.gnu.org id=D22067.145749080010304
	(code D ref 22067); Wed, 09 Mar 2016 02:34:01 +0000
Received: (at 22067-done) by debbugs.gnu.org; 9 Mar 2016 02:33:20 +0000
Received: from localhost ([127.0.0.1]:40309 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1adTw7-0002g7-Re
	for submit@debbugs.gnu.org; Tue, 08 Mar 2016 21:33:20 -0500
Received: from mail-ob0-f181.google.com ([209.85.214.181]:36653)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <meyering@gmail.com>) id 1adTw6-0002fv-15
	for 22067-done@debbugs.gnu.org; Tue, 08 Mar 2016 21:33:18 -0500
Received: by mail-ob0-f181.google.com with SMTP id m7so33493511obh.3
	for <22067-done@debbugs.gnu.org>; Tue, 08 Mar 2016 18:33:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc;
	bh=EdS8zc8hLRv/00toePxIXmedhxpApvSFlCEpgHtmLs8=;
	b=sBZ68bDZPAA8Frt2iA9dp9zXMzOYCx/AhCBTl1/j5+6Q+So6MBGPkxFTjwVrd+tAgm
	/7B1SQpD5Uzekw/Xx6KNl6imD81CNZWpCuGMRQ0sSiOffUJSw38Ji76G++sP9HqVJZYU
	ZfiVCu35yQHPZQYI4B/VgZD9DX3kjR87xLZtVGESXCH01I9mSaVqiXm4uqQtP1m4g6du
	8SWmmXOcBg1BAIY0S0BK15qN/wTTzPEWR3gSZANgKyXP4gHZrsPcD8OOSBHTbVPGOcHS
	2R6l9+6s0a8FRFMTnH58ln9X8kyMPkz6MQYc2r4Dv+Un20aVid9eDb2Zpgp9bKivMvZp
	Hiww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
	:date:message-id:subject:to:cc;
	bh=EdS8zc8hLRv/00toePxIXmedhxpApvSFlCEpgHtmLs8=;
	b=NLYuZOlkLyS8hYS45U0iXr9uf3a6QINiBlH5wIWG2X8AjBuZOqTWVlkH0Bv6/Du4ko
	l+aQamw4CsW6B2dtUZWnVh0HSKy4ILi0CziaAHoYXPnORjD501JaP1EvvkmCYXZpqjRV
	+FTgfRuPUhR2xAw/ginubzvzGdugkbW5q1cm8Kl3AccsnhjPTkSQ8TnzYofaTS/lrNUi
	gDpg4O+FFXzpXNXsJZOtz4ub0O2YC7LmI9GpKNYwZnKX2DvI4PPk4Vx2ojHA30dMaqGT
	6E2A6A0YVdyesLwvkrvwTkpmjhS0LQsi61G7gCEdPU6MqMMC1gGzaQr2ysP3REpYgB6L
	zIrg==
X-Gm-Message-State: AD7BkJIH02x/ekXArsYBCi2CaB4ePYT4UWJXNRHtNbnFqXuKR79PbXAE3qGqNQI/y9VPXef/VNKFdW05addBMw==
X-Received: by 10.60.227.105 with SMTP id rz9mr12107138oec.72.1457490792418;
	Tue, 08 Mar 2016 18:33:12 -0800 (PST)
MIME-Version: 1.0
Received: by 10.202.82.194 with HTTP; Tue, 8 Mar 2016 18:32:52 -0800 (PST)
In-Reply-To: <87ziu8iq92.fsf@foo.bar.baz>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
	<CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	<87ziu8iq92.fsf@foo.bar.baz>
From: Jim Meyering <jim@meyering.net>
Date: Tue, 8 Mar 2016 18:32:52 -0800
X-Google-Sender-Auth: Pk-N5PieJF8bdqj9yX3ZEwz5fNw
Message-ID: <CA+8g5KEK76YsKaL8Y3mNbupvKpcKDLiWnyKdLyEPW4t-GCa7hw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 02:34:07 -0000

On Tue, Mar 8, 2016 at 2:00 PM, Giuseppe Scrivano <gscrivano@gnu.org> wrote:
> Jim Meyering <jim@meyering.net> writes:
>
>> pushed.
>
> thanks!
>
> Is there going to be any release of diffutils with the new changes?

Yes. It's in the queue, but first I'll make releases for grep and gzip.
sed is also overdue. Any help with triaging things in the bug
lists would be most welcome:

  http://debbugs.gnu.org/cgi/pkgreport.cgi?package=diffutils




From MAILER-DAEMON Thu Mar 10 16:03:07 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ae7jf-00024N-Pg
	for mharc-bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:03:07 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae7jd-00020u-AM
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:03:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae7ja-0001SF-3V
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:03:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:46986)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae7ja-0001S3-0l
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:03:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae7jZ-0004EJ-MA
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:03:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Giuseppe Scrivano <gscrivano@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 10 Mar 2016 21:03:01 +0000
Resent-Message-ID: <handler.22067.D22067.145764376916238@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Jim Meyering <jim@meyering.net>
Received: via spool by 22067-done@debbugs.gnu.org id=D22067.145764376916238
	(code D ref 22067); Thu, 10 Mar 2016 21:03:01 +0000
Received: (at 22067-done) by debbugs.gnu.org; 10 Mar 2016 21:02:49 +0000
Received: from localhost ([127.0.0.1]:44113 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1ae7jI-0004Dl-Ss
	for submit@debbugs.gnu.org; Thu, 10 Mar 2016 16:02:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35706)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <gscrivano@gnu.org>) id 1ae7jG-0004Dc-8V
	for 22067-done@debbugs.gnu.org; Thu, 10 Mar 2016 16:02:42 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 50854C03C4;
	Thu, 10 Mar 2016 21:02:41 +0000 (UTC)
Received: from foo.bar.baz (vpn1-4-234.ams2.redhat.com [10.36.4.234])
	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id u2AL2cTt032286
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO); Thu, 10 Mar 2016 16:02:40 -0500
From: Giuseppe Scrivano <gscrivano@gnu.org>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
	<CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	<87ziu8iq92.fsf@foo.bar.baz>
	<CA+8g5KEK76YsKaL8Y3mNbupvKpcKDLiWnyKdLyEPW4t-GCa7hw@mail.gmail.com>
Date: Thu, 10 Mar 2016 22:02:38 +0100
In-Reply-To: <CA+8g5KEK76YsKaL8Y3mNbupvKpcKDLiWnyKdLyEPW4t-GCa7hw@mail.gmail.com>
	(Jim Meyering's message of "Tue, 8 Mar 2016 18:32:52 -0800")
Message-ID: <87pov2f3m9.fsf@foo.bar.baz>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 21:03:06 -0000

Hi Jim,

Jim Meyering <jim@meyering.net> writes:

> Yes. It's in the queue, but first I'll make releases for grep and gzip.
> sed is also overdue. Any help with triaging things in the bug
> lists would be most welcome:
>
>   http://debbugs.gnu.org/cgi/pkgreport.cgi?package=diffutils

I went through the open bugs (I skipped the ones already on wishlist)
and this is what I've found:

* 18641 [diffutils] [PATCH] diff: Add --only=REGEX option to parse only files that match REGEX
RFC

* 19508 [diffutils] [PATCH] diff: compare major, minor numbers of block/character special files
* 19509 [diffutils] [PATCH] diff: treat fifos as identical
not blocking issue, patch needs review

* 17185  diff --help doesn't mention short forms of some options
minor issue, not blocking

* 18655 Regression in 3.3 documentation versus 3.2
answered, bug must be closed

* 18973 diffutils-3.3 test-mbrtowc3.sh fails on Solaris without European localization
not triaged, no access to solaris to try it

* 19489 FYI: I've updated copyright dates -- and gnulib
not a bug, must be closed

* 19825 unified output format, number of consecutive unaffected lines, and POSIX
answered, can be closed

* 19835 RFC: diff: skip initial columns before comparing
RFC with patch not reviewed

* 19984 [diffutils] Diff and symlinks
commented, can be closed

* 20250 [diffutils] diff by size
RFC for size only comparison (I would close as NOTFIX)

* 20279 [diffutils] With -r, option to avoid duplicate differences due to relative symbolic links
RFC

* 20794 [diffutils] ignore subdirectory with diff
Went unanswered, looks like a RFC for a weird use case

* 20929 [diffutils] problem with diff -B and incomplete lines
Fixed by:

commit d2fd9d4683ef60c259a3b426f71cef1b89ff383d
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Wed Sep 3 15:58:03 2014 -0700

    diff: fix bug with diff -B and incomplete lines


* 21034 [diffutils] [bug-diffutils] bug#21023: bug#21023: REQUEST: --no-dereference missing from manpage + please make a short option for it
RFC, should probably be closed and pointed out that --no-d will work as well

* 21579 [diffutils] diffutils 3.3 man page may need update

Fixed by:

commit 2cd4ff3a5ff52d89b6b992d158f389b757f4faf4
Author: Jim Meyering <meyering@fb.com>
Date:   Mon Aug 31 23:12:43 2015 -0700

    build: correct man-page generation rule


* 21665  [diffutils] Use of mmap for large files
already answered as WONTFIX, must be closed

* 21674 [diffutils] Fix for context-header
plain diff patch proposed, changes the format of the header

* 21715 [diffutils] feat req: an option to skip directory inode comparison
RFC

* 22108 [diffutils] diff wrapper script for very large files, low memory
duplicate of 21665

* 22245 [diffutils] [lamby@debian.org: Bug* 809007: diffutils: FTBFS: FAIL: test-update-copyright.sh]
I had that issue some time ago but it was fixed upstream.  I have not bisected

* 22507 [diffutils] diffutils releases
not a bug, working for the release :)

* 22529 [diffutils] cmp man page too sophisticated
not a bug

* 22535 [diffutils] REQ: regex dialect switching (for -F and -I)
RFC, I would close it as a WONTFIX

* 22816 [diffutils] cmp --verbose EOF message could be more verbose
RFC

* 16467 [diffutils] Diffutils 3.3 v. VMS (et al.)
could be fixed in gnulib, not a regression anyway

Regards,
Giuseppe




From MAILER-DAEMON Thu Mar 10 16:24:09 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ae841-00034m-5O
	for mharc-bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:24:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae83y-0002zQ-HC
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:24:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae83u-0007bx-U1
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:24:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:47004)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae83u-0007bg-Qp
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:24:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ae83u-0004hy-OP
	for bug-diffutils@gnu.org; Thu, 10 Mar 2016 16:24:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 10 Mar 2016 21:24:02 +0000
Resent-Message-ID: <handler.22067.D22067.145764500218023@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: Giuseppe Scrivano <gscrivano@gnu.org>
Received: via spool by 22067-done@debbugs.gnu.org id=D22067.145764500218023
	(code D ref 22067); Thu, 10 Mar 2016 21:24:02 +0000
Received: (at 22067-done) by debbugs.gnu.org; 10 Mar 2016 21:23:22 +0000
Received: from localhost ([127.0.0.1]:44127 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1ae83F-0004gd-IA
	for submit@debbugs.gnu.org; Thu, 10 Mar 2016 16:23:21 -0500
Received: from mail-ob0-f170.google.com ([209.85.214.170]:34736)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <meyering@gmail.com>) id 1ae83D-0004gP-My
	for 22067-done@debbugs.gnu.org; Thu, 10 Mar 2016 16:23:20 -0500
Received: by mail-ob0-f170.google.com with SMTP id ts10so94207768obc.1
	for <22067-done@debbugs.gnu.org>; Thu, 10 Mar 2016 13:23:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc;
	bh=i3jUCPjOiDYahIQYEwrRUTIFGsg/2V8CvKfFh8LnLBI=;
	b=b2KtQD6l5HsCcne8tU8JWGKjXZcw+YH/HiR9jZuA1GNnUnPx/vLBNlDERlLdO/nrfw
	Na9SvYPSyMaD0eYN4S8kElW10ezaLTXC9pyk2vw9SgZvSt5UTWkpVrTOZLF25gfqdY7N
	LQAUC5d72VSnbC5RdA1l3OqFHCSiDFU9VaJOXFmZiIWKErBXYmRBDrQKBBndNT7AdYv2
	WL77zU7i1euYGRW8gVRmgwQZD+96O1DcYrkmTz7cJ7FI2f5LVf+6OITA2PmEVI4nN1rH
	XnbpnpBIp5L6UR5wEsRdd5T1bEuXd9hxnBdOyq5wzC/A84cDUFDRG829zKHcdyG4qWhO
	A0Pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
	:date:message-id:subject:to:cc;
	bh=i3jUCPjOiDYahIQYEwrRUTIFGsg/2V8CvKfFh8LnLBI=;
	b=E6uqW8h2Ex2PEcJ8oUm1qIVSwvhUJaABIOj6WZGMbaoKDlN9qezsIyEc4nYrkJ5RCd
	VwvRVOQknMKpdTGVPzI8+sETn8ux7pRo8176k2doztQQiI0J43Cb7uJn5rJ3a6UQRje8
	LDieI+JFLBvB7HC/S5Qx5LWz6ddY3HXLH8u3gV3WKbPByX84R2F/EzYKr8/hBr7Tn4+s
	qAIBXyPynccThflt1Dg4+jxhxUz7e45y1c8AokjFMC3kMBnWwKeIZ9x8pwftgTFpjN7R
	22aQcTZ9pluOK6GMsj/+RjsI3+Wmq1QNlOd8URm7wEwuvh+YgHnTCeq8HQYGQY2S6j04
	aBLw==
X-Gm-Message-State: AD7BkJIcyX4HWDVVNt+yKqdN0hgZKGFTlh12/T0kpK0IdN2pcsneHNoBFhSGc5hDfPjCdiPb5ReXgScORfZbZQ==
X-Received: by 10.182.142.69 with SMTP id ru5mr3459297obb.82.1457644994157;
	Thu, 10 Mar 2016 13:23:14 -0800 (PST)
MIME-Version: 1.0
Received: by 10.202.44.5 with HTTP; Thu, 10 Mar 2016 13:22:54 -0800 (PST)
In-Reply-To: <87pov2f3m9.fsf@foo.bar.baz>
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
	<CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	<87ziu8iq92.fsf@foo.bar.baz>
	<CA+8g5KEK76YsKaL8Y3mNbupvKpcKDLiWnyKdLyEPW4t-GCa7hw@mail.gmail.com>
	<87pov2f3m9.fsf@foo.bar.baz>
From: Jim Meyering <jim@meyering.net>
Date: Thu, 10 Mar 2016 13:22:54 -0800
X-Google-Sender-Auth: tW_1TWMrofIJWgWFPbbEjE261Fs
Message-ID: <CA+8g5KECgaRxeLRxXGhCh9TKSbHdcbBcgudc3iWw2kSiddKHVg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Cc: 22067-done@debbugs.gnu.org
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#20062:
	bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 21:24:07 -0000

On Thu, Mar 10, 2016 at 1:02 PM, Giuseppe Scrivano <gscrivano@gnu.org> wrote:
> Hi Jim,
>
> Jim Meyering <jim@meyering.net> writes:
>
>> Yes. It's in the queue, but first I'll make releases for grep and gzip.
>> sed is also overdue. Any help with triaging things in the bug
>> lists would be most welcome:
>>
>>   http://debbugs.gnu.org/cgi/pkgreport.cgi?package=diffutils
>
> I went through the open bugs (I skipped the ones already on wishlist)
> and this is what I've found:

[... lots of triage! ...]

Wow!!!
Thank you for all that work. I have no excuse to delay, now :-)

For anything that is obviously not a bug, you are welcome (encouraged,
even) to mark them as such and to close them in the bug db.

I suppose you know how to do that? One way is to reply to the affected
message and to include something like this at the top of it:

Here's an example that merges two bugs, tags as NOTABUG, and closes.
    forcemerge 7354 7353
    tags 7353 notabug
    close 7353
    thanks

Or just send that text to control@debbugs.gnu.org. Anyone can do that.

If you just want to close a bug, it's easy to do that with a reply to
the original where you change the auto-provided DDDDD@debbugs.gnu.org
recipient address to be DDDDD-done@debbugs.gnu.org

Thanks again.
I will take time to go through any you do not close/resolve within the
next few days.

Thanks again,
Jim




From MAILER-DAEMON Sat Mar 12 06:59:09 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aeiCL-0005O9-A3
	for mharc-bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:59:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aeiCI-0005O1-Mr
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:59:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aeiCE-00023c-25
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:59:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aeiCD-00023Y-V7
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:59:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aeiCD-0003qc-Q1
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:59:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 12 Mar 2016 11:59:01 +0000
Resent-Message-ID: <handler.22067.B.145778389814740@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 22067
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 22067@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.145778389814740
	(code B ref -1); Sat, 12 Mar 2016 11:59:01 +0000
Received: (at submit) by debbugs.gnu.org; 12 Mar 2016 11:58:18 +0000
Received: from localhost ([127.0.0.1]:45755 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aeiBP-0003pZ-Ps
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 06:58:17 -0500
Received: from eggs.gnu.org ([208.118.235.92]:41727)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBN-0003pN-8E
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 06:58:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBG-0001rK-FQ
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 06:58:04 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:44558)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBG-0001rG-Bs
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 06:58:02 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBE-0005IO-TW
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:58:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBA-0001qL-E3
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:58:00 -0500
Received: from kolbaba.stable.cz ([88.86.120.223]:54902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aeiBA-0001qH-4P
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 06:57:56 -0500
Received: from localhost (kolbaba.miton.cz [127.0.0.1])
	by kolbaba.stable.cz (Postfix) with ESMTP id 57A842248A
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 12:57:53 +0100 (CET)
X-Virus-Scanned: amavisd-new at kolbaba.stable.cz
Received: from kolbaba.stable.cz ([127.0.0.1])
	by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id i4u52WyUixRW for <bug-diffutils@gnu.org>;
	Sat, 12 Mar 2016 12:57:51 +0100 (CET)
Received: from [192.168.168.25] (154.198.broadband11.iol.cz [90.178.198.154])
	by kolbaba.stable.cz (Postfix) with ESMTPSA id 795EA2389D
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 12:57:51 +0100 (CET)
References: <565D6EF4.20903@yahoo.no> <87oac3peqc.fsf@foo.bar.baz>
	<56B86F8C.2010102@yahoo.no> <87zivb74c6.fsf@foo.bar.baz>
	<56B89827.5090909@yahoo.no> <8737t0ike3.fsf@foo.bar.baz>
	<CA+8g5KETyRKno98H18d_nLeO3SdywDGgXdfUBm5VF96hSxoxCw@mail.gmail.com>
	<871t8jbeol.fsf@foo.bar.baz>
	<CA+8g5KESKFNbniaRE6RnjkXzJQ7SAVMnrgURKLy1jOoO74ug2A@mail.gmail.com>
	<87lh6q55c3.fsf@foo.bar.baz> <87h9gq38rm.fsf@foo.bar.baz>
	<CA+8g5KFOAxZ1_3+y1bg5=dEoh7==sUn6swsZ+3pHBNcCj0GVZg@mail.gmail.com>
	<87y49ui7o3.fsf@foo.bar.baz>
	<CA+8g5KEn39MD7RxgwdwKCt21vFnoennq9gLXLurKaML5pjuOLA@mail.gmail.com>
	<87ziu8iq92.fsf@foo.bar.baz>
	<CA+8g5KEK76YsKaL8Y3mNbupvKpcKDLiWnyKdLyEPW4t-GCa7hw@mail.gmail.com>
	<87pov2f3m9.fsf@foo.bar.baz>
From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Message-ID: <56E4043F.3090501@svobodasoft.cz>
Date: Sat, 12 Mar 2016 12:57:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <87pov2f3m9.fsf@foo.bar.baz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#22067: bug#22067: bug#22067: bug#22067:
	bug#20062: bug#20062: [PATCH] diff: add support for --color
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Mar 2016 11:59:08 -0000

Giuseppe, Jim, guys,

I am the author of "compare major, minor numbers of block/character 
special files" (19508) and "treat fifos as identical" (19509). I needed 
them to compare backups of my Maemo 5 system (Nokia N900) -- there are 
static device files in /dev and some fifos too.

The first patch hasn't received a code review yet -- may I ask you or 
the list to give it a look? I think the patch is in a better shape than 
"treat fifos as identical" which isn't finished although it received a 
suggestion by Eric Blake (on 12 Feb last year) that fstat could be used 
to compare the fifos.

I rebased the patches in my working copy and I will at least send new 
versions to the list.

I am finishing my studies now so I can dedicate only limited time to 
finishing the patches. Let me know if you would like the functionality 
in the next release and I'll see what I can do.

Cheers,
Ondra

On 10.3.2016 22:02, Giuseppe Scrivano wrote:
> Hi Jim,
>
> Jim Meyering <jim@meyering.net> writes:
>
>> Yes. It's in the queue, but first I'll make releases for grep and gzip.
>> sed is also overdue. Any help with triaging things in the bug
>> lists would be most welcome:
>>
>>    http://debbugs.gnu.org/cgi/pkgreport.cgi?package=diffutils
> I went through the open bugs (I skipped the ones already on wishlist)
> and this is what I've found:
>
> * 18641 [diffutils] [PATCH] diff: Add --only=REGEX option to parse only files that match REGEX
> RFC
>
> * 19508 [diffutils] [PATCH] diff: compare major, minor numbers of block/character special files
> * 19509 [diffutils] [PATCH] diff: treat fifos as identical
> not blocking issue, patch needs review
>
> * 17185  diff --help doesn't mention short forms of some options
> minor issue, not blocking
>
> * 18655 Regression in 3.3 documentation versus 3.2
> answered, bug must be closed
>
> * 18973 diffutils-3.3 test-mbrtowc3.sh fails on Solaris without European localization
> not triaged, no access to solaris to try it
>
> * 19489 FYI: I've updated copyright dates -- and gnulib
> not a bug, must be closed
>
> * 19825 unified output format, number of consecutive unaffected lines, and POSIX
> answered, can be closed
>
> * 19835 RFC: diff: skip initial columns before comparing
> RFC with patch not reviewed
>
> * 19984 [diffutils] Diff and symlinks
> commented, can be closed
>
> * 20250 [diffutils] diff by size
> RFC for size only comparison (I would close as NOTFIX)
>
> * 20279 [diffutils] With -r, option to avoid duplicate differences due to relative symbolic links
> RFC
>
> * 20794 [diffutils] ignore subdirectory with diff
> Went unanswered, looks like a RFC for a weird use case
>
> * 20929 [diffutils] problem with diff -B and incomplete lines
> Fixed by:
>
> commit d2fd9d4683ef60c259a3b426f71cef1b89ff383d
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Date:   Wed Sep 3 15:58:03 2014 -0700
>
>      diff: fix bug with diff -B and incomplete lines
>
>
> * 21034 [diffutils] [bug-diffutils] bug#21023: bug#21023: REQUEST: --no-dereference missing from manpage + please make a short option for it
> RFC, should probably be closed and pointed out that --no-d will work as well
>
> * 21579 [diffutils] diffutils 3.3 man page may need update
>
> Fixed by:
>
> commit 2cd4ff3a5ff52d89b6b992d158f389b757f4faf4
> Author: Jim Meyering <meyering@fb.com>
> Date:   Mon Aug 31 23:12:43 2015 -0700
>
>      build: correct man-page generation rule
>
>
> * 21665  [diffutils] Use of mmap for large files
> already answered as WONTFIX, must be closed
>
> * 21674 [diffutils] Fix for context-header
> plain diff patch proposed, changes the format of the header
>
> * 21715 [diffutils] feat req: an option to skip directory inode comparison
> RFC
>
> * 22108 [diffutils] diff wrapper script for very large files, low memory
> duplicate of 21665
>
> * 22245 [diffutils] [lamby@debian.org: Bug* 809007: diffutils: FTBFS: FAIL: test-update-copyright.sh]
> I had that issue some time ago but it was fixed upstream.  I have not bisected
>
> * 22507 [diffutils] diffutils releases
> not a bug, working for the release :)
>
> * 22529 [diffutils] cmp man page too sophisticated
> not a bug
>
> * 22535 [diffutils] REQ: regex dialect switching (for -F and -I)
> RFC, I would close it as a WONTFIX
>
> * 22816 [diffutils] cmp --verbose EOF message could be more verbose
> RFC
>
> * 16467 [diffutils] Diffutils 3.3 v. VMS (et al.)
> could be fixed in gnulib, not a regression anyway
>
> Regards,
> Giuseppe
>




From MAILER-DAEMON Sat Mar 12 08:57:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aek2W-0000zL-LC
	for mharc-bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:57:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aek2T-0000zC-RX
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:57:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aek2Q-0007Th-Jh
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:57:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aek2Q-0007Td-GV
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:57:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aek2Q-0008Kb-8S
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:57:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 12 Mar 2016 13:57:02 +0000
Resent-Message-ID: <handler.19508.B.145779097431970@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19508
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 19508@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.145779097431970
	(code B ref -1); Sat, 12 Mar 2016 13:57:02 +0000
Received: (at submit) by debbugs.gnu.org; 12 Mar 2016 13:56:14 +0000
Received: from localhost ([127.0.0.1]:45854 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aek1d-0008Ja-L1
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 08:56:13 -0500
Received: from eggs.gnu.org ([208.118.235.92]:34549)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1b-0008JM-9f
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 08:56:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1U-0007Ej-Sf
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 08:56:06 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:34382)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1U-0007Ef-PY
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 08:56:04 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1T-0000vP-Bc
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:56:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1Q-0007DL-4Z
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:56:03 -0500
Received: from kolbaba.stable.cz ([88.86.120.223]:55589)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aek1P-0007D6-RK
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 08:56:00 -0500
Received: from localhost (kolbaba.miton.cz [127.0.0.1])
	by kolbaba.stable.cz (Postfix) with ESMTP id 661D4226C0
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 14:55:58 +0100 (CET)
X-Virus-Scanned: amavisd-new at kolbaba.stable.cz
Received: from kolbaba.stable.cz ([127.0.0.1])
	by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mcDDeqhB6Glh for <bug-diffutils@gnu.org>;
	Sat, 12 Mar 2016 14:55:57 +0100 (CET)
Received: from [192.168.0.15] (155.198.broadband11.iol.cz [90.178.198.155])
	by kolbaba.stable.cz (Postfix) with ESMTPSA id D84CD209D0
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 14:55:56 +0100 (CET)
References: <54A9A7E6.8020305@svobodasoft.cz>
From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Message-ID: <56E41FEC.6050300@svobodasoft.cz>
Date: Sat, 12 Mar 2016 14:55:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <54A9A7E6.8020305@svobodasoft.cz>
Content-Type: multipart/mixed; boundary="------------060105090405050203080107"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#19508:  bug#19508: [PATCH] diff: compare major,
	minor numbers of block/character special files
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Mar 2016 13:57:07 -0000

This is a multi-part message in MIME format.
--------------060105090405050203080107
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi everybody,

I rebased the patch on current master and tested it (as root) like this:

# mkdir /tmp/a /tmp/b
# mknod /tmp/a/block1 b 1 2; mknod /tmp/b/block1 b 1 2
# mknod /tmp/a/block2 b 2 3; mknod /tmp/b/block2 b 2 4
# mknod /tmp/a/block3 b 3 4; mknod /tmp/b/block3 b 5 4
# mknod /tmp/a/char1 c 1 2; mknod /tmp/b/char1 c 1 2
# mknod /tmp/a/char2 c 2 3; mknod /tmp/b/char2 c 2 4
# mknod /tmp/a/char3 c 3 4; mknod /tmp/b/char3 c 5 4

# LC_ALL=C ls -l /tmp/a
total 0
brw-r--r-- 1 root root 1, 2 Mar 12 14:51 block1
brw-r--r-- 1 root root 2, 3 Mar 12 14:51 block2
brw-r--r-- 1 root root 3, 4 Mar 12 14:51 block3
crw-r--r-- 1 root root 1, 2 Mar 12 14:51 char1
crw-r--r-- 1 root root 2, 3 Mar 12 14:51 char2
crw-r--r-- 1 root root 3, 4 Mar 12 14:51 char3

# LC_ALL=C ls -l /tmp/b
total 0
brw-r--r-- 1 root root 1, 2 Mar 12 14:51 block1
brw-r--r-- 1 root root 2, 4 Mar 12 14:51 block2
brw-r--r-- 1 root root 5, 4 Mar 12 14:51 block3
crw-r--r-- 1 root root 1, 2 Mar 12 14:51 char1
crw-r--r-- 1 root root 2, 4 Mar 12 14:51 char2
crw-r--r-- 1 root root 5, 4 Mar 12 14:51 char3

# LC_ALL=C diff -s -r /tmp/a /tmp/b
Files /tmp/a/block1 and /tmp/b/block1 are identical
File /tmp/a/block2 is a block special file while file /tmp/b/block2 is a 
block special file
File /tmp/a/block3 is a block special file while file /tmp/b/block3 is a 
block special file
Files /tmp/a/char1 and /tmp/b/char1 are identical
File /tmp/a/char2 is a character special file while file /tmp/b/char2 is 
a character special file
File /tmp/a/char3 is a character special file while file /tmp/b/char3 is 
a character special file

# LC_ALL=C /usr/local/bin/diff -s -r /tmp/a /tmp/b
Files /tmp/a/block1 and /tmp/b/block1 are identical
Block special files /tmp/a/block2 and /tmp/b/block2 differ: 2,3 (2,4)
Block special files /tmp/a/block3 and /tmp/b/block3 differ: 3,4 (5,4)
Files /tmp/a/char1 and /tmp/b/char1 are identical
Character special files /tmp/a/char2 and /tmp/b/char2 differ: 2,3 (2,4)
Character special files /tmp/a/char3 and /tmp/b/char3 differ: 3,4 (5,4)

The reason why diff compared block1 as identical perhaps because it 
descended to diff_2_files, I would know if I stepped through the code 
which I currently don't have much time to do.

Please share your comments!

Cheers,
Ondra

--------------060105090405050203080107
Content-Type: text/x-patch;
 name="0001-diff-compare-major-minor-numbers-of-block-character-.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-diff-compare-major-minor-numbers-of-block-character-.pa";
 filename*1="tch"

>From 36f26c15551d5c32d3197b3f0008a96fe3440240 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ond=C5=99ej=20Svoboda?= <ondrej@svobodasoft.cz>
Date: Sun, 21 Sep 2014 18:06:38 +0200
Subject: [PATCH] diff: compare major, minor numbers of block/character special
 files

This deals with situation such as

  File dev1/block1 is a block special file while file dev2/block1 is
  a block special file

in case the major and minor numbers are identical.
If stat.st_rdev does not match, a message is given:

  Block special files dev1/block1 and dev2/block1 differ: 1,2 (3,2)
---
 src/diff.c | 23 +++++++++++++++++++++++
 src/diff.h |  1 +
 src/util.c |  9 +++++++++
 3 files changed, 33 insertions(+)

diff --git a/src/diff.c b/src/diff.c
index 9bc1d96..110b8e1 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -1318,6 +1318,29 @@ compare_files (struct comparison const *parent,
 	      status = EXIT_FAILURE;
 	    }
 	}
+      else if ((S_ISBLK (cmp.file[0].stat.st_mode)
+	        && S_ISBLK (cmp.file[1].stat.st_mode))
+	       || (S_ISCHR (cmp.file[0].stat.st_mode)
+	           && S_ISCHR (cmp.file[1].stat.st_mode)))
+	{
+	  if (cmp.file[0].stat.st_rdev != cmp.file[1].stat.st_rdev)
+	    {
+	      char major_minor0[20], major_minor1[20];
+	      format_major_minor (major_minor0, cmp.file[0].stat.st_rdev);
+	      format_major_minor (major_minor1, cmp.file[1].stat.st_rdev);
+
+	      const char *message = S_ISBLK (cmp.file[0].stat.st_mode) ?
+			"Block special files %s and %s differ: %s (%s)\n" :
+			"Character special files %s and %s differ: %s (%s)\n";
+	      message5 (message,
+			file_label[0] ? file_label[0] : cmp.file[0].name,
+			file_label[1] ? file_label[1] : cmp.file[1].name,
+			major_minor0, major_minor1);
+
+	      /* This is a difference.  */
+	      status = EXIT_FAILURE;
+	    }
+	}
       else
 	{
 	  /* We have two files that are not to be compared.  */
diff --git a/src/diff.h b/src/diff.h
index 0983e7c..12ed085 100644
--- a/src/diff.h
+++ b/src/diff.h
@@ -391,6 +391,7 @@ extern void begin_output (void);
 extern void debug_script (struct change *);
 extern void fatal (char const *) __attribute__((noreturn));
 extern void finish_output (void);
+extern void format_major_minor (char *buffer, const dev_t st_rdev);
 extern void message (char const *, char const *, char const *);
 extern void message5 (char const *, char const *, char const *,
                       char const *, char const *);
diff --git a/src/util.c b/src/util.c
index d7b8925..85a47d3 100644
--- a/src/util.c
+++ b/src/util.c
@@ -26,6 +26,7 @@
 #include <xalloc.h>
 #include "xvasprintf.h"
 #include <signal.h>
+#include <sys/types.h>
 
 /* Use SA_NOCLDSTOP as a proxy for whether the sigaction machinery is
    present.  */
@@ -1577,3 +1578,11 @@ debug_script (struct change *sp)
 
   fflush (stderr);
 }
+
+/* Format a device number as major,minor. */
+
+void
+format_major_minor (char *buffer, const dev_t st_rdev)
+{
+  sprintf (buffer, "%u,%u", (major (st_rdev)), (minor (st_rdev)));
+}
-- 
2.7.2


--------------060105090405050203080107--




From MAILER-DAEMON Sat Mar 12 09:18:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aekMp-0003Oy-WE
	for mharc-bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:18:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aekMn-0003O1-7T
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:18:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aekMk-0004ba-0T
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:18:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48731)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aekMj-0004bW-Tn
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:18:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1aekMj-0000Ml-O0
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:18:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 12 Mar 2016 14:18:01 +0000
Resent-Message-ID: <handler.19508.B.14577922291346@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 19508
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: patch
To: 19508@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.14577922291346
	(code B ref -1); Sat, 12 Mar 2016 14:18:01 +0000
Received: (at submit) by debbugs.gnu.org; 12 Mar 2016 14:17:09 +0000
Received: from localhost ([127.0.0.1]:45858 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1aekLt-0000Le-If
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 09:17:09 -0500
Received: from eggs.gnu.org ([208.118.235.92]:37913)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLr-0000LQ-Bv
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 09:17:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLl-0004Uz-0e
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 09:17:02 -0500
Received: from lists.gnu.org ([2001:4830:134:3::11]:35379)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLk-0004Uv-TX
	for submit@debbugs.gnu.org; Sat, 12 Mar 2016 09:17:00 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLj-0003FF-Lz
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:17:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLg-0004RS-Ee
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:16:59 -0500
Received: from kolbaba.stable.cz ([88.86.120.223]:50906)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <SRS0-6hPm=PI=svobodasoft.cz=ondrej@stable.cz>)
	id 1aekLg-0004Pa-5F
	for bug-diffutils@gnu.org; Sat, 12 Mar 2016 09:16:56 -0500
Received: from localhost (kolbaba.miton.cz [127.0.0.1])
	by kolbaba.stable.cz (Postfix) with ESMTP id E543623FC3
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 15:16:54 +0100 (CET)
X-Virus-Scanned: amavisd-new at kolbaba.stable.cz
Received: from kolbaba.stable.cz ([127.0.0.1])
	by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4xjk0+DuOMYv for <bug-diffutils@gnu.org>;
	Sat, 12 Mar 2016 15:16:53 +0100 (CET)
Received: from [192.168.0.15] (155.198.broadband11.iol.cz [90.178.198.155])
	by kolbaba.stable.cz (Postfix) with ESMTPSA id 6255B22F14
	for <bug-diffutils@gnu.org>; Sat, 12 Mar 2016 15:16:53 +0100 (CET)
References: <54A9A7E6.8020305@svobodasoft.cz> <56E41FEC.6050300@svobodasoft.cz>
From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda <ondrej@svobodasoft.cz>
Message-ID: <56E424D1.3040904@svobodasoft.cz>
Date: Sat, 12 Mar 2016 15:16:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56E41FEC.6050300@svobodasoft.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#19508: bug#19508: bug#19508: [PATCH] diff:
	compare major, minor numbers of block/character special files
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Mar 2016 14:18:06 -0000

Please see the follow-up on testing below.

On 12.3.2016 14:55, Ond=C5=99ej Svoboda wrote:
> Hi everybody,
>
> I rebased the patch on current master and tested it (as root) like this=
:
>
> # mkdir /tmp/a /tmp/b
> # mknod /tmp/a/block1 b 1 2; mknod /tmp/b/block1 b 1 2
> # mknod /tmp/a/block2 b 2 3; mknod /tmp/b/block2 b 2 4
> # mknod /tmp/a/block3 b 3 4; mknod /tmp/b/block3 b 5 4
> # mknod /tmp/a/char1 c 1 2; mknod /tmp/b/char1 c 1 2
> # mknod /tmp/a/char2 c 2 3; mknod /tmp/b/char2 c 2 4
> # mknod /tmp/a/char3 c 3 4; mknod /tmp/b/char3 c 5 4
>
> # LC_ALL=3DC ls -l /tmp/a
> total 0
> brw-r--r-- 1 root root 1, 2 Mar 12 14:51 block1
> brw-r--r-- 1 root root 2, 3 Mar 12 14:51 block2
> brw-r--r-- 1 root root 3, 4 Mar 12 14:51 block3
> crw-r--r-- 1 root root 1, 2 Mar 12 14:51 char1
> crw-r--r-- 1 root root 2, 3 Mar 12 14:51 char2
> crw-r--r-- 1 root root 3, 4 Mar 12 14:51 char3
>
> # LC_ALL=3DC ls -l /tmp/b
> total 0
> brw-r--r-- 1 root root 1, 2 Mar 12 14:51 block1
> brw-r--r-- 1 root root 2, 4 Mar 12 14:51 block2
> brw-r--r-- 1 root root 5, 4 Mar 12 14:51 block3
> crw-r--r-- 1 root root 1, 2 Mar 12 14:51 char1
> crw-r--r-- 1 root root 2, 4 Mar 12 14:51 char2
> crw-r--r-- 1 root root 5, 4 Mar 12 14:51 char3
>
> # LC_ALL=3DC diff -s -r /tmp/a /tmp/b
> Files /tmp/a/block1 and /tmp/b/block1 are identical
> File /tmp/a/block2 is a block special file while file /tmp/b/block2 is=20
> a block special file
> File /tmp/a/block3 is a block special file while file /tmp/b/block3 is=20
> a block special file
> Files /tmp/a/char1 and /tmp/b/char1 are identical
> File /tmp/a/char2 is a character special file while file /tmp/b/char2=20
> is a character special file
> File /tmp/a/char3 is a character special file while file /tmp/b/char3=20
> is a character special file
>
> # LC_ALL=3DC /usr/local/bin/diff -s -r /tmp/a /tmp/b
> Files /tmp/a/block1 and /tmp/b/block1 are identical
> Block special files /tmp/a/block2 and /tmp/b/block2 differ: 2,3 (2,4)
> Block special files /tmp/a/block3 and /tmp/b/block3 differ: 3,4 (5,4)
> Files /tmp/a/char1 and /tmp/b/char1 are identical
> Character special files /tmp/a/char2 and /tmp/b/char2 differ: 2,3 (2,4)
> Character special files /tmp/a/char3 and /tmp/b/char3 differ: 3,4 (5,4)
>
> The reason why diff compared block1 as identical perhaps because it=20
> descended to diff_2_files, I would know if I stepped through the code=20
> which I currently don't have much time to do.

# touch /tmp/b/*

# LC_ALL=3DC ls -l /tmp/b
total 0
brw-r--r-- 1 root root 1, 2 Mar 12 15:09 block1
brw-r--r-- 1 root root 2, 4 Mar 12 15:09 block2
brw-r--r-- 1 root root 5, 4 Mar 12 15:09 block3
crw-r--r-- 1 root root 1, 2 Mar 12 15:09 char1
crw-r--r-- 1 root root 2, 4 Mar 12 15:09 char2
crw-r--r-- 1 root root 5, 4 Mar 12 15:09 char3

# LC_ALL=3DC diff -s -r /tmp/a /tmp/b
File /tmp/a/block1 is a block special file while file /tmp/b/block1 is a=20
block special file
File /tmp/a/block2 is a block special file while file /tmp/b/block2 is a=20
block special file
File /tmp/a/block3 is a block special file while file /tmp/b/block3 is a=20
block special file
File /tmp/a/char1 is a character special file while file /tmp/b/char1 is=20
a character special file
File /tmp/a/char2 is a character special file while file /tmp/b/char2 is=20
a character special file
File /tmp/a/char3 is a character special file while file /tmp/b/char3 is=20
a character special file

# LC_ALL=3DC /usr/local/bin/diff -s -r /tmp/a /tmp/b :(
Files /tmp/a/block1 and /tmp/b/block1 are identical
Block special files /tmp/a/block2 and /tmp/b/block2 differ: 2,3 (2,4)
Block special files /tmp/a/block3 and /tmp/b/block3 differ: 3,4 (5,4)
Files /tmp/a/char1 and /tmp/b/char1 are identical
Character special files /tmp/a/char2 and /tmp/b/char2 differ: 2,3 (2,4)
Character special files /tmp/a/char3 and /tmp/b/char3 differ: 3,4 (5,4)

After changing the modification datetime, both block1 and char1 compared=20
differently with diffutils 3.3-2 (on Arch Linux) while they were found=20
to be the same with the patched diff from master.

> Please share your comments!
>
> Cheers,
> Ondra





