From MAILER-DAEMON Tue Jan 01 12:06:15 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1geNUc-0007pn-V7
	for mharc-bug-diffutils@gnu.org; Tue, 01 Jan 2019 12:06:14 -0500
Received: from eggs.gnu.org ([208.118.235.92]:57928)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geNUX-0007lS-2K
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 12:06:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geNUS-0005RU-2z
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 12:06:09 -0500
Received: from debbugsout.gnu.org ([209.51.188.43]:36016)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1geNUR-0005RG-Vx
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 12:06:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geNUR-0008M3-Hu
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 12:06:03 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Sean Lewis <sean@suspend.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Tue, 01 Jan 2019 17:06:03 +0000
Resent-Message-ID: <handler.33947.B.154636234232068@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 33947
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 33947@debbugs.gnu.org
X-Debbugs-Original-To: "bug-diffutils@gnu.org" <bug-diffutils@gnu.org>
Received: via spool by submit@debbugs.gnu.org id=B.154636234232068
	(code B ref -1); Tue, 01 Jan 2019 17:06:03 +0000
Received: (at submit) by debbugs.gnu.org; 1 Jan 2019 17:05:42 +0000
Received: from localhost ([127.0.0.1]:44116 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1geNU5-0008L9-73
	for submit@debbugs.gnu.org; Tue, 01 Jan 2019 12:05:42 -0500
Received: from eggs.gnu.org ([208.118.235.92]:60902)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <sean@suspend.net>) id 1geNBz-0007rU-Hr
	for submit@debbugs.gnu.org; Tue, 01 Jan 2019 11:47:00 -0500
Received: from lists.gnu.org ([208.118.235.17]:52040)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <sean@suspend.net>) id 1geNBz-00005I-CA
	for submit@debbugs.gnu.org; Tue, 01 Jan 2019 11:46:59 -0500
Received: from eggs.gnu.org ([208.118.235.92]:54000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sean@suspend.net>) id 1geNBx-0005iH-A7
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 11:46:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sean@suspend.net>) id 1geNBu-0008VC-4i
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 11:46:57 -0500
Received: from mail-oln040092003060.outbound.protection.outlook.com
	([40.92.3.60]:36736 helo=NAM02-BL2-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <sean@suspend.net>) id 1geNBt-0008Us-W4
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 11:46:54 -0500
Received: from SN1NAM02FT063.eop-nam02.prod.protection.outlook.com
	(10.152.72.51) by SN1NAM02HT158.eop-nam02.prod.protection.outlook.com
	(10.152.72.170) with Microsoft SMTP Server (version=TLS1_2,
	cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13;
	Tue, 1 Jan 2019 16:46:52 +0000
Received: from MWHPR1601MB1296.namprd16.prod.outlook.com (10.152.72.56) by
	SN1NAM02FT063.mail.protection.outlook.com (10.152.72.213) with
	Microsoft SMTP
	Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
	15.20.1471.13 via Frontend Transport; Tue, 1 Jan 2019 16:46:52 +0000
Received: from MWHPR1601MB1296.namprd16.prod.outlook.com
	([fe80::b560:52e4:e17a:1c3f]) by
	MWHPR1601MB1296.namprd16.prod.outlook.com
	([fe80::b560:52e4:e17a:1c3f%9]) with mapi id 15.20.1471.019;
	Tue, 1 Jan 2019 16:46:52 +0000
From: Sean Lewis <sean@suspend.net>
Thread-Topic: Failure building diffutils-3.7 (openSUSE:Factory)
Thread-Index: AQHUofGYrXehzCULwku39FelV/hKKw==
Date: Tue, 1 Jan 2019 16:46:51 +0000
Message-ID: <MWHPR1601MB1296C95DDF7A22AAA86AAC77D8B30@MWHPR1601MB1296.namprd16.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-clientproxiedby: BYAPR02CA0018.namprd02.prod.outlook.com
	(2603:10b6:a02:ee::31) To MWHPR1601MB1296.namprd16.prod.outlook.com
	(2603:10b6:300:e5::18)
x-incomingtopheadermarker: OriginalChecksum:66DA6A8F376E668218CFBAD9C14B39567B0686B52FC25FF9D1656AE033053724;
	UpperCasedChecksum:D82445DC41BB843A4934994589C727693266E6EEFD754338AA54D6C66AD4BC7A;
	SizeAsReceived:7275; Count:47
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [axtkSzO4yO58JJXnrwTvs7hWGYpT604T]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; SN1NAM02HT158;
	6:IDMwVQwQ8DhXBGL27ZLe6k9Urs3HsclTHIz0nDob5yjvISVJ686lR7KsSrqrmYYXPoeu+AR0DrQJRZK653hKTqYfc3K77xSPI5IHkdtajtB+p7aCYAydFfDdDJP+RmmfVXoljg6U00YHK2jTPIXKDPYZOMTzFwqp3C0OnMcBju/BLZsf29Sp/HPZfw2KZP3P5/PTp/FQ5ANcocJIyqcHAxXmmhmRGmQcJNUkdpw+zakaqSFDFtKmrFF6PXoBoHmTGc4YVmNEaDw95Td9hooy06bl7iwPGjOLtaMh4YSlG6j7M9PwHokG/10pw/kDE55soepqUILNDU6rbl1M0jLr8IWfZdhM67laLHZq0hQpQAO4JGSXWXTPrGI6erawqELSHjVEG6Nw+dMXsyhkmcq0qxx8uxxuMmpEnXBI6HTqoTeNYKnR2yOJE02u1uKAKHTgQr5oy+KX/26HVtqlUw2vVw==;
	5:z3NORq3nW8+8+m32b3fW+cllmi0BcDRcUlR4KGXimYSqGk0caRIlMNZ5yR9Ljmu2KXyH2Bck13QiXL6lMG0Oz7i8COS5L7mfqtNJhFb1cAf8ppbd3gHOi5jw4oLNW53KUyVcoz3RspBh5GXRxYpjjUaqarWB9rOXdX4QPNhb20c=;
	7:2eBilA02N8OkX/bRqO3KUz9jdP07Z/poA/xQ/MC9yhtvAgo2my829YbhjbbqLmcz8ESP8LroD2JHhVbXp7mPRg7vE17qKF+f7TwpWVK8hz77MqTlty51p2xNFlbtBqEqphejLQX2+gSIclHgTLe3Mw==
x-incomingheadercount: 47
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0; PCL:0;
	RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);
	SRVR:SN1NAM02HT158; 
x-ms-traffictypediagnostic: SN1NAM02HT158:
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); 
	SRVR:SN1NAM02HT158; BCL:0; PCL:0; RULEID:;
	SRVR:SN1NAM02HT158; 
x-microsoft-antispam-message-info: HD1uPWc4VNph7B4yEr3YbifzpERoH+Mv2/ide1k3+MD17INlEJtJngOkJ+whf/Ei
Content-Type: text/plain; charset="utf-8"
Content-ID: <C019569A6A661944A1B3117CDF0FC14B@namprd16.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 9bd8b953-1c55-4da7-b616-8bcad099ae8b
X-MS-Exchange-CrossTenant-Network-Message-Id: 465a8fd5-299e-40da-dc32-08d67008b9f5
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 9bd8b953-1c55-4da7-b616-8bcad099ae8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jan 2019 16:46:51.9395 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT158
X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Mailman-Approved-At: Tue, 01 Jan 2019 12:05:39 -0500
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#33947: Failure building diffutils-3.7
 (openSUSE:Factory)
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jan 2019 17:06:13 -0000

R29vZCBtb3JuaW5nLA0KDQpUb2RheSBJIGF0dGVtcHRlZCB0byBwYWNrYWdlIHRoZSBuZXcgZGlm
ZnV0aWxzIDMuNyBhbmQgcmVjZWl2ZWQgYnVpbGQgDQpmYWlsdXJlcyAodGVzdC5sb2cgb3V0cHV0
IGlzIGJlbG93IGZvciB5b3VyIHJlZmVyZW5jZSkuIFRoaXMgaXMgZm9yIA0Kb3BlblNVU0UgYW5k
IEknbSBidWlsZGluZyB1c2luZyBvdXIgVHVtYmxld2VlZCByb2xsaW5nIHJlbGVhc2UgbW9kZWwg
DQp3aGljaCBoYXMgKG5lYXJseSkgY3VycmVudCBjb21wb25lbnRzIGZvciBhbGwgcGllY2VzIG9m
IHRoZSBlbnZpcm9ubWVudC4gDQpBbnkgZ3VpZGFuY2UgeW91IGNhbiBwcm92aWRlIGlzIGFwcHJl
Y2lhdGVkLCB0aGFuayB5b3UgYW5kIGhhcHB5IG5ldyB5ZWFyLg0KDQoNClNlYW4NCg0KDQpbwqAg
MTMyc10gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpbwqAg
MTMyc13CoMKgwqAgR05VIGRpZmZ1dGlscyAzLjc6IHRlc3RzL3Rlc3Qtc3VpdGUubG9nDQpbwqAg
MTMyc10gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpbwqAg
MTMyc10NClvCoCAxMzJzXSAjIFRPVEFMOiAyMg0KW8KgIDEzMnNdICMgUEFTUzrCoCAxOQ0KW8Kg
IDEzMnNdICMgU0tJUDrCoCAxDQpbwqAgMTMyc10gIyBYRkFJTDogMQ0KW8KgIDEzMnNdICMgRkFJ
TDrCoCAxDQpbwqAgMTMyc10gIyBYUEFTUzogMA0KW8KgIDEzMnNdICMgRVJST1I6IDANClvCoCAx
MzJzXQ0KW8KgIDEzMnNdIC4uIGNvbnRlbnRzOjogOmRlcHRoOiAyDQpbwqAgMTMyc10NClvCoCAx
MzJzXSBYRkFJTDogbGFyZ2Utc3Vib3B0DQpbwqAgMTMyc10gPT09PT09PT09PT09PT09PT09PQ0K
W8KgIDEzMnNdDQpbwqAgMTMyc10gKysgaW5pdGlhbF9jd2RfPS9ob21lL2FidWlsZC9ycG1idWls
ZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzDQpbwqAgMTMyc10gKysrIHRlc3RkaXJfcHJlZml4
Xw0KW8KgIDEzMnNdICsrKyBwcmludGYgZ3QNClvCoCAxMzJzXSArKyBwZnhfPWd0DQpbwqAgMTMy
c10gKysrIG1rdGVtcGRfIC9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43
L3Rlc3RzIA0KZ3QtbGFyZ2Utc3Vib3B0LlhYWFgNClvCoCAxMzJzXSArKysgY2FzZSAkIyBpbg0K
W8KgIDEzMnNdICsrKyBkZXN0ZGlyXz0vaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0
aWxzLTMuNy90ZXN0cw0KW8KgIDEzMnNdICsrKyB0ZW1wbGF0ZV89Z3QtbGFyZ2Utc3Vib3B0LlhY
WFgNClvCoCAxMzJzXSArKysgTUFYX1RSSUVTXz00DQpbwqAgMTMyc10gKysrIGNhc2UgJGRlc3Rk
aXJfIGluDQpbwqAgMTMyc10gKysrIGRlc3RkaXJfc2xhc2hfPS9ob21lL2FidWlsZC9ycG1idWls
ZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzLw0KW8KgIDEzMnNdICsrKyBjYXNlICR0ZW1wbGF0
ZV8gaW4NClvCoCAxMzJzXSArKysrIHVuc2V0IFRNUERJUg0KW8KgIDEzMnNdICsrKyANCmQ9L2hv
bWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3QtbGFyZ2Utc3Vi
b3B0LjlNMFYNClvCoCAxMzJzXSArKysgY2FzZSAkZCBpbg0KW8KgIDEzMnNdICsrKyA6DQpbwqAg
MTMyc10gKysrIHRlc3QgLWQgDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxz
LTMuNy90ZXN0cy9ndC1sYXJnZS1zdWJvcHQuOU0wVg0KW8KgIDEzMnNdICsrKysgbHMgLWRnbyAN
Ci9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzL2d0LWxhcmdl
LXN1Ym9wdC45TTBWDQpbwqAgMTMyc10gKysrIHBlcm1zPSdkcnd4LS0tLS0tIDEgMCBKYW7CoCAx
IDE2OjE3IA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMv
Z3QtbGFyZ2Utc3Vib3B0LjlNMFYnDQpbwqAgMTMyc10gKysrIGNhc2UgJHBlcm1zIGluDQpbwqAg
MTMyc10gKysrIDoNClvCoCAxMzJzXSArKysgZWNobyANCi9ob21lL2FidWlsZC9ycG1idWlsZC9C
VUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzL2d0LWxhcmdlLXN1Ym9wdC45TTBWDQpbwqAgMTMyc10g
KysrIHJldHVybg0KW8KgIDEzMnNdICsrIA0KdGVzdF9kaXJfPS9ob21lL2FidWlsZC9ycG1idWls
ZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzL2d0LWxhcmdlLXN1Ym9wdC45TTBWDQpbwqAgMTMy
c10gKysgY2QgDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0
cy9ndC1sYXJnZS1zdWJvcHQuOU0wVg0KW8KgIDEzMnNdICsrIGdsX2luaXRfc2hfbmxfPScNClvC
oCAxMzJzXSAnDQpbwqAgMTMyc10gKysgSUZTPScNClvCoCAxMzJzXSAnDQpbwqAgMTMyc10gKysg
Zm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAxMzJzXSArKysgZXhwciAxICsgMTI4DQpbwqAg
MTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxMjknXCcnIDEnDQpbwqAgMTMyc10gKysrIHRy
YXAgJ0V4aXQgMTI5JyAxDQpbwqAgMTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvC
oCAxMzJzXSArKysgZXhwciAyICsgMTI4DQpbwqAgMTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhp
dCAxMzAnXCcnIDInDQpbwqAgMTMyc10gKysrIHRyYXAgJ0V4aXQgMTMwJyAyDQpbwqAgMTMyc10g
KysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAxMzJzXSArKysgZXhwciAzICsgMTI4DQpb
wqAgMTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxMzEnXCcnIDMnDQpbwqAgMTMyc10gKysr
IHRyYXAgJ0V4aXQgMTMxJyAzDQpbwqAgMTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUN
ClvCoCAxMzJzXSArKysgZXhwciAxMyArIDEyOA0KW8KgIDEzMnNdICsrIGV2YWwgJ3RyYXAgJ1wn
J0V4aXQgMTQxJ1wnJyAxMycNClvCoCAxMzJzXSArKysgdHJhcCAnRXhpdCAxNDEnIDEzDQpbwqAg
MTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAxMzJzXSArKysgZXhwciAxNSAr
IDEyOA0KW8KgIDEzMnNdICsrIGV2YWwgJ3RyYXAgJ1wnJ0V4aXQgMTQzJ1wnJyAxNScNClvCoCAx
MzJzXSArKysgdHJhcCAnRXhpdCAxNDMnIDE1DQpbwqAgMTMyc10gKysgdHJhcCByZW1vdmVfdG1w
XyAwDQpbwqAgMTMyc10gKyBwYXRoX3ByZXBlbmRfIC4uL3NyYw0KW8KgIDEzMnNdICsgdGVzdCAx
ICchPScgMA0KW8KgIDEzMnNdICsgcGF0aF9kaXJfPS4uL3NyYw0KW8KgIDEzMnNdICsgY2FzZSAk
cGF0aF9kaXJfIGluDQpbwqAgMTMyc10gKyANCmFic19wYXRoX2Rpcl89L2hvbWUvYWJ1aWxkL3Jw
bWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvLi4vc3JjDQpbwqAgMTMyc10gKyBjYXNl
ICRhYnNfcGF0aF9kaXJfIGluDQpbwqAgMTMyc10gKyANClBBVEg9L2hvbWUvYWJ1aWxkL3JwbWJ1
aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvLi4vc3JjOi9ob21lL2FidWlsZC9ycG1idWls
ZC9CVUlMRC9kaWZmdXRpbHMtMy43L3NyYzovdXNyL2xvY2FsL2JpbjovdXNyL2JpbjovYmluOi91
c3IvbGliL21pdC9iaW46L3Vzci9saWIvbWl0L3NiaW46L3NiaW46L3Vzci9zYmluDQpbwqAgMTMy
c10gKyBjcmVhdGVfZXhlX3NoaW1zXyANCi9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZm
dXRpbHMtMy43L3Rlc3RzLy4uL3NyYw0KW8KgIDEzMnNdICsgY2FzZSAkRVhFRVhUIGluDQpbwqAg
MTMyc10gKyByZXR1cm4gMA0KW8KgIDEzMnNdICsgc2hpZnQNClvCoCAxMzJzXSArIHRlc3QgMCAn
IT0nIDANClvCoCAxMzJzXSArIGV4cG9ydCBQQVRIDQpbwqAgMTMyc10gKyBmYWlsPTANClvCoCAx
MzJzXSArIGRpZmYgLXUgDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMu
Ny90ZXN0cy9sYXJnZS1zdWJvcHQuaW4xIA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2Rp
ZmZ1dGlscy0zLjcvdGVzdHMvbGFyZ2Utc3Vib3B0LmluMg0KW8KgIDEzMnNdICsgcGVybCAtbjAg
LWUgJy9cbi0yXG4oXCtMOiAzNjFcbil7Mn1cKzJcbi8gYW5kIGRvIHskZT0xOyANCmxhc3R9OyBF
TkR7ZXhpdCAhJGV9Jw0KW8KgIDEzMnNdICsgZmFpbD0xDQpbwqAgMTMyc10gKyBFeGl0IDENClvC
oCAxMzJzXSArIHNldCArZQ0KW8KgIDEzMnNdICsgZXhpdCAxDQpbwqAgMTMyc10gKyBleGl0IDEN
ClvCoCAxMzJzXSArIHJlbW92ZV90bXBfDQpbwqAgMTMyc10gKyBfX3N0PTENClvCoCAxMzJzXSAr
IGNsZWFudXBfDQpbwqAgMTMyc10gKyA6DQpbwqAgMTMyc10gKyB0ZXN0ICcnID0geWVzDQpbwqAg
MTMyc10gKyBjZCAvaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0
cw0KW8KgIDEzMnNdICsgY2htb2QgLVIgdStyd3ggDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJ
TEQvZGlmZnV0aWxzLTMuNy90ZXN0cy9ndC1sYXJnZS1zdWJvcHQuOU0wVg0KW8KgIDEzMnNdICsg
cm0gLXJmIA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMv
Z3QtbGFyZ2Utc3Vib3B0LjlNMFYNClvCoCAxMzJzXSArIGV4aXQgMQ0KW8KgIDEzMnNdIFhGQUlM
IGxhcmdlLXN1Ym9wdCAoZXhpdCBzdGF0dXM6IDEpDQpbwqAgMTMyc10NClvCoCAxMzJzXSBTS0lQ
OiBzdHJpcC10cmFpbGluZy1jcg0KW8KgIDEzMnNdID09PT09PT09PT09PT09PT09PT09PT09DQpb
wqAgMTMyc10NClvCoCAxMzJzXSArKyBpbml0aWFsX2N3ZF89L2hvbWUvYWJ1aWxkL3JwbWJ1aWxk
L0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMNClvCoCAxMzJzXSArKysgdGVzdGRpcl9wcmVmaXhf
DQpbwqAgMTMyc10gKysrIHByaW50ZiBndA0KW8KgIDEzMnNdICsrIHBmeF89Z3QNClvCoCAxMzJz
XSArKysgbWt0ZW1wZF8gL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcv
dGVzdHMgDQpndC1zdHJpcC10cmFpbGluZy1jci5YWFhYDQpbwqAgMTMyc10gKysrIGNhc2UgJCMg
aW4NClvCoCAxMzJzXSArKysgZGVzdGRpcl89L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2Rp
ZmZ1dGlscy0zLjcvdGVzdHMNClvCoCAxMzJzXSArKysgdGVtcGxhdGVfPWd0LXN0cmlwLXRyYWls
aW5nLWNyLlhYWFgNClvCoCAxMzJzXSArKysgTUFYX1RSSUVTXz00DQpbwqAgMTMyc10gKysrIGNh
c2UgJGRlc3RkaXJfIGluDQpbwqAgMTMyc10gKysrIGRlc3RkaXJfc2xhc2hfPS9ob21lL2FidWls
ZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzLw0KW8KgIDEzMnNdICsrKyBjYXNl
ICR0ZW1wbGF0ZV8gaW4NClvCoCAxMzJzXSArKysrIHVuc2V0IFRNUERJUg0KW8KgIDEzMnNdICsr
KyANCmQ9L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3Qt
c3RyaXAtdHJhaWxpbmctY3IucFg4cw0KW8KgIDEzMnNdICsrKyBjYXNlICRkIGluDQpbwqAgMTMy
c10gKysrIDoNClvCoCAxMzJzXSArKysgdGVzdCAtZCANCi9ob21lL2FidWlsZC9ycG1idWlsZC9C
VUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzL2d0LXN0cmlwLXRyYWlsaW5nLWNyLnBYOHMNClvCoCAx
MzJzXSArKysrIGxzIC1kZ28gDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxz
LTMuNy90ZXN0cy9ndC1zdHJpcC10cmFpbGluZy1jci5wWDhzDQpbwqAgMTMyc10gKysrIHBlcm1z
PSdkcnd4LS0tLS0tIDEgMCBKYW7CoCAxIDE2OjE3IA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JV
SUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3Qtc3RyaXAtdHJhaWxpbmctY3IucFg4cycNClvCoCAx
MzJzXSArKysgY2FzZSAkcGVybXMgaW4NClvCoCAxMzJzXSArKysgOg0KW8KgIDEzMnNdICsrKyBl
Y2hvIA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3Qt
c3RyaXAtdHJhaWxpbmctY3IucFg4cw0KW8KgIDEzMnNdICsrKyByZXR1cm4NClvCoCAxMzJzXSAr
KyANCnRlc3RfZGlyXz0vaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90
ZXN0cy9ndC1zdHJpcC10cmFpbGluZy1jci5wWDhzDQpbwqAgMTMyc10gKysgY2QgDQovaG9tZS9h
YnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cy9ndC1zdHJpcC10cmFpbGlu
Zy1jci5wWDhzDQpbwqAgMTMyc10gKysgZ2xfaW5pdF9zaF9ubF89Jw0KW8KgIDEzMnNdICcNClvC
oCAxMzJzXSArKyBJRlM9Jw0KW8KgIDEzMnNdICcNClvCoCAxMzJzXSArKyBmb3Igc2lnXyBpbiAx
IDIgMyAxMyAxNQ0KW8KgIDEzMnNdICsrKyBleHByIDEgKyAxMjgNClvCoCAxMzJzXSArKyBldmFs
ICd0cmFwICdcJydFeGl0IDEyOSdcJycgMScNClvCoCAxMzJzXSArKysgdHJhcCAnRXhpdCAxMjkn
IDENClvCoCAxMzJzXSArKyBmb3Igc2lnXyBpbiAxIDIgMyAxMyAxNQ0KW8KgIDEzMnNdICsrKyBl
eHByIDIgKyAxMjgNClvCoCAxMzJzXSArKyBldmFsICd0cmFwICdcJydFeGl0IDEzMCdcJycgMicN
ClvCoCAxMzJzXSArKysgdHJhcCAnRXhpdCAxMzAnIDINClvCoCAxMzJzXSArKyBmb3Igc2lnXyBp
biAxIDIgMyAxMyAxNQ0KW8KgIDEzMnNdICsrKyBleHByIDMgKyAxMjgNClvCoCAxMzJzXSArKyBl
dmFsICd0cmFwICdcJydFeGl0IDEzMSdcJycgMycNClvCoCAxMzJzXSArKysgdHJhcCAnRXhpdCAx
MzEnIDMNClvCoCAxMzJzXSArKyBmb3Igc2lnXyBpbiAxIDIgMyAxMyAxNQ0KW8KgIDEzMnNdICsr
KyBleHByIDEzICsgMTI4DQpbwqAgMTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxNDEnXCcn
IDEzJw0KW8KgIDEzMnNdICsrKyB0cmFwICdFeGl0IDE0MScgMTMNClvCoCAxMzJzXSArKyBmb3Ig
c2lnXyBpbiAxIDIgMyAxMyAxNQ0KW8KgIDEzMnNdICsrKyBleHByIDE1ICsgMTI4DQpbwqAgMTMy
c10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxNDMnXCcnIDE1Jw0KW8KgIDEzMnNdICsrKyB0cmFw
ICdFeGl0IDE0MycgMTUNClvCoCAxMzJzXSArKyB0cmFwIHJlbW92ZV90bXBfIDANClvCoCAxMzJz
XSArIHBhdGhfcHJlcGVuZF8gLi4vc3JjDQpbwqAgMTMyc10gKyB0ZXN0IDEgJyE9JyAwDQpbwqAg
MTMyc10gKyBwYXRoX2Rpcl89Li4vc3JjDQpbwqAgMTMyc10gKyBjYXNlICRwYXRoX2Rpcl8gaW4N
ClvCoCAxMzJzXSArIA0KYWJzX3BhdGhfZGlyXz0vaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQv
ZGlmZnV0aWxzLTMuNy90ZXN0cy8uLi9zcmMNClvCoCAxMzJzXSArIGNhc2UgJGFic19wYXRoX2Rp
cl8gaW4NClvCoCAxMzJzXSArIA0KUEFUSD0vaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlm
ZnV0aWxzLTMuNy90ZXN0cy8uLi9zcmM6L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1
dGlscy0zLjcvc3JjOi91c3IvbG9jYWwvYmluOi91c3IvYmluOi9iaW46L3Vzci9saWIvbWl0L2Jp
bjovdXNyL2xpYi9taXQvc2Jpbjovc2JpbjovdXNyL3NiaW4NClvCoCAxMzJzXSArIGNyZWF0ZV9l
eGVfc2hpbXNfIA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVz
dHMvLi4vc3JjDQpbwqAgMTMyc10gKyBjYXNlICRFWEVFWFQgaW4NClvCoCAxMzJzXSArIHJldHVy
biAwDQpbwqAgMTMyc10gKyBzaGlmdA0KW8KgIDEzMnNdICsgdGVzdCAwICchPScgMA0KW8KgIDEz
MnNdICsgZXhwb3J0IFBBVEgNClvCoCAxMzJzXSArIGZhaWw9MA0KW8KgIDEzMnNdICsgcmVxdWly
ZV92YWxncmluZF8NClvCoCAxMzJzXSArIHZhbGdyaW5kIC0tZXJyb3ItZXhpdGNvZGU9MSB0cnVl
DQpbwqAgMTMyc10gKyBza2lwXyAncmVxdWlyZXMgYSB3b3JraW5nIHZhbGdyaW5kJw0KW8KgIDEz
MnNdICsgd2Fybl8gJ3N0cmlwLXRyYWlsaW5nLWNyOiBza2lwcGVkIHRlc3Q6IHJlcXVpcmVzIGEg
d29ya2luZyANCnZhbGdyaW5kJw0KW8KgIDEzMnNdICsgY2FzZSAkSUZTIGluDQpbwqAgMTMyc10g
KyBwcmludGYgJyVzXG4nICdzdHJpcC10cmFpbGluZy1jcjogc2tpcHBlZCB0ZXN0OiByZXF1aXJl
cyBhIA0Kd29ya2luZyB2YWxncmluZCcNClvCoCAxMzJzXSBzdHJpcC10cmFpbGluZy1jcjogc2tp
cHBlZCB0ZXN0OiByZXF1aXJlcyBhIHdvcmtpbmcgdmFsZ3JpbmQNClvCoCAxMzJzXSArIHRlc3Qg
OSA9IDINClvCoCAxMzJzXSArIHNlZCAxcQ0KW8KgIDEzMnNdICsgcHJpbnRmICclc1xuJyAnc3Ry
aXAtdHJhaWxpbmctY3I6IHNraXBwZWQgdGVzdDogcmVxdWlyZXMgYSANCndvcmtpbmcgdmFsZ3Jp
bmQnDQpbwqAgMTMyc10gKyBFeGl0IDc3DQpbwqAgMTMyc10gKyBzZXQgK2UNClvCoCAxMzJzXSAr
IGV4aXQgNzcNClvCoCAxMzJzXSArIGV4aXQgNzcNClvCoCAxMzJzXSArIHJlbW92ZV90bXBfDQpb
wqAgMTMyc10gKyBfX3N0PTc3DQpbwqAgMTMyc10gKyBjbGVhbnVwXw0KW8KgIDEzMnNdICsgOg0K
W8KgIDEzMnNdICsgdGVzdCAnJyA9IHllcw0KW8KgIDEzMnNdICsgY2QgL2hvbWUvYWJ1aWxkL3Jw
bWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMNClvCoCAxMzJzXSArIGNobW9kIC1SIHUr
cnd4IA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3Qt
c3RyaXAtdHJhaWxpbmctY3IucFg4cw0KW8KgIDEzMnNdICsgcm0gLXJmIA0KL2hvbWUvYWJ1aWxk
L3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3Qtc3RyaXAtdHJhaWxpbmctY3Iu
cFg4cw0KW8KgIDEzMnNdICsgZXhpdCA3Nw0KW8KgIDEzMnNdIFNLSVAgc3RyaXAtdHJhaWxpbmct
Y3IgKGV4aXQgc3RhdHVzOiA3NykNClvCoCAxMzJzXQ0KW8KgIDEzMnNdIEZBSUw6IGNvbG9ycw0K
W8KgIDEzMnNdID09PT09PT09PT09PQ0KW8KgIDEzMnNdDQpbwqAgMTMyc10gKysgaW5pdGlhbF9j
d2RfPS9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzDQpbwqAg
MTMyc10gKysrIHRlc3RkaXJfcHJlZml4Xw0KW8KgIDEzMnNdICsrKyBwcmludGYgZ3QNClvCoCAx
MzJzXSArKyBwZnhfPWd0DQpbwqAgMTMyc10gKysrIG1rdGVtcGRfIC9ob21lL2FidWlsZC9ycG1i
dWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzIA0KZ3QtY29sb3JzLlhYWFgNClvCoCAxMzJz
XSArKysgY2FzZSAkIyBpbg0KW8KgIDEzMnNdICsrKyBkZXN0ZGlyXz0vaG9tZS9hYnVpbGQvcnBt
YnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cw0KW8KgIDEzMnNdICsrKyB0ZW1wbGF0ZV89
Z3QtY29sb3JzLlhYWFgNClvCoCAxMzJzXSArKysgTUFYX1RSSUVTXz00DQpbwqAgMTMyc10gKysr
IGNhc2UgJGRlc3RkaXJfIGluDQpbwqAgMTMyc10gKysrIGRlc3RkaXJfc2xhc2hfPS9ob21lL2Fi
dWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzLw0KW8KgIDEzMnNdICsrKyBj
YXNlICR0ZW1wbGF0ZV8gaW4NClvCoCAxMzJzXSArKysrIHVuc2V0IFRNUERJUg0KW8KgIDEzMnNd
ICsrKyANCmQ9L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMv
Z3QtY29sb3JzLnVoTmsNClvCoCAxMzJzXSArKysgY2FzZSAkZCBpbg0KW8KgIDEzMnNdICsrKyA6
DQpbwqAgMTMyc10gKysrIHRlc3QgLWQgDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlm
ZnV0aWxzLTMuNy90ZXN0cy9ndC1jb2xvcnMudWhOaw0KW8KgIDEzMnNdICsrKysgbHMgLWRnbyAN
Ci9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzL2d0LWNvbG9y
cy51aE5rDQpbwqAgMTMyc10gKysrIHBlcm1zPSdkcnd4LS0tLS0tIDEgMCBKYW7CoCAxIDE2OjE3
IA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3QtY29s
b3JzLnVoTmsnDQpbwqAgMTMyc10gKysrIGNhc2UgJHBlcm1zIGluDQpbwqAgMTMyc10gKysrIDoN
ClvCoCAxMzJzXSArKysgZWNobyANCi9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRp
bHMtMy43L3Rlc3RzL2d0LWNvbG9ycy51aE5rDQpbwqAgMTMyc10gKysrIHJldHVybg0KW8KgIDEz
MnNdICsrIA0KdGVzdF9kaXJfPS9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMt
My43L3Rlc3RzL2d0LWNvbG9ycy51aE5rDQpbwqAgMTMyc10gKysgY2QgDQovaG9tZS9hYnVpbGQv
cnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cy9ndC1jb2xvcnMudWhOaw0KW8KgIDEz
MnNdICsrIGdsX2luaXRfc2hfbmxfPScNClvCoCAxMzJzXSAnDQpbwqAgMTMyc10gKysgSUZTPScN
ClvCoCAxMzJzXSAnDQpbwqAgMTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAx
MzJzXSArKysgZXhwciAxICsgMTI4DQpbwqAgMTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAx
MjknXCcnIDEnDQpbwqAgMTMyc10gKysrIHRyYXAgJ0V4aXQgMTI5JyAxDQpbwqAgMTMyc10gKysg
Zm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAxMzJzXSArKysgZXhwciAyICsgMTI4DQpbwqAg
MTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxMzAnXCcnIDInDQpbwqAgMTMyc10gKysrIHRy
YXAgJ0V4aXQgMTMwJyAyDQpbwqAgMTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvC
oCAxMzJzXSArKysgZXhwciAzICsgMTI4DQpbwqAgMTMyc10gKysgZXZhbCAndHJhcCAnXCcnRXhp
dCAxMzEnXCcnIDMnDQpbwqAgMTMyc10gKysrIHRyYXAgJ0V4aXQgMTMxJyAzDQpbwqAgMTMyc10g
KysgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUNClvCoCAxMzJzXSArKysgZXhwciAxMyArIDEyOA0K
W8KgIDEzMnNdICsrIGV2YWwgJ3RyYXAgJ1wnJ0V4aXQgMTQxJ1wnJyAxMycNClvCoCAxMzJzXSAr
KysgdHJhcCAnRXhpdCAxNDEnIDEzDQpbwqAgMTMyc10gKysgZm9yIHNpZ18gaW4gMSAyIDMgMTMg
MTUNClvCoCAxMzJzXSArKysgZXhwciAxNSArIDEyOA0KW8KgIDEzMnNdICsrIGV2YWwgJ3RyYXAg
J1wnJ0V4aXQgMTQzJ1wnJyAxNScNClvCoCAxMzJzXSArKysgdHJhcCAnRXhpdCAxNDMnIDE1DQpb
wqAgMTMyc10gKysgdHJhcCByZW1vdmVfdG1wXyAwDQpbwqAgMTMyc10gKyBwYXRoX3ByZXBlbmRf
IC4uL3NyYw0KW8KgIDEzMnNdICsgdGVzdCAxICchPScgMA0KW8KgIDEzMnNdICsgcGF0aF9kaXJf
PS4uL3NyYw0KW8KgIDEzMnNdICsgY2FzZSAkcGF0aF9kaXJfIGluDQpbwqAgMTMyc10gKyANCmFi
c19wYXRoX2Rpcl89L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVz
dHMvLi4vc3JjDQpbwqAgMTMyc10gKyBjYXNlICRhYnNfcGF0aF9kaXJfIGluDQpbwqAgMTMyc10g
KyANClBBVEg9L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMv
Li4vc3JjOi9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3NyYzovdXNy
L2xvY2FsL2JpbjovdXNyL2JpbjovYmluOi91c3IvbGliL21pdC9iaW46L3Vzci9saWIvbWl0L3Ni
aW46L3NiaW46L3Vzci9zYmluDQpbwqAgMTMyc10gKyBjcmVhdGVfZXhlX3NoaW1zXyANCi9ob21l
L2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMtMy43L3Rlc3RzLy4uL3NyYw0KW8KgIDEz
MnNdICsgY2FzZSAkRVhFRVhUIGluDQpbwqAgMTMyc10gKyByZXR1cm4gMA0KW8KgIDEzMnNdICsg
c2hpZnQNClvCoCAxMzJzXSArIHRlc3QgMCAnIT0nIDANClvCoCAxMzJzXSArIGV4cG9ydCBQQVRI
DQpbwqAgMTMyc10gKyBUWj1VVEMwDQpbwqAgMTMyc10gKyBleHBvcnQgVFoNClvCoCAxMzJzXSAr
IGZhaWw9MA0KW8KgIDEzMnNdICsgZWNobyBhDQpbwqAgMTMyc10gKyBlY2hvIGINClvCoCAxMzJz
XSArKyBkaWZmIC11IGEgYg0KW8KgIDEzMnNdICsrIGdyZXAgLUYgLg0KW8KgIDEzMnNdICsrIGVj
aG8gLjAwMDAwMDAwMA0KW8KgIDEzMnNdICsgbmFub3NlY29uZF96ZXJvcz0uMDAwMDAwMDAwDQpb
wqAgMTMyc10gKyBlcG9jaD0nMTk3MC0wMS0wMSAwMDowMDowMCcNClvCoCAxMzJzXSArIHRvdWNo
IC10IDE5NzAwMTAxMDAwMC4wMCBhIGINClvCoCAxMzJzXSArKyBwcmludGYgJ1wwMzMnDQpbwqAg
MTMyc10gKyBlPSQnXEUnDQpbwqAgMTMyc10gKysgcHJpbnRmICdcdCcNClvCoCAxMzJzXSArIHRh
Yj0nwqDCoMKgwqDCoMKgwqAgJw0KW8KgIDEzMnNdICsgcnM9MA0KW8KgIDEzMnNdICsgaGQ9MQ0K
W8KgIDEzMnNdICsgYWQ9MzINClvCoCAxMzJzXSArIGRlPTMxDQpbwqAgMTMyc10gKyBsbj0zNg0K
W8KgIDEzMnNdICsgcmV0dXJuc18gMSBkaWZmIC0tY29sb3I9YXV0byBhIGINClvCoCAxMzJzXSAr
IGdlbl9leHBfZGVmYXVsdA0KW8KgIDEzMnNdICsgcHJpbnRmICVzICcxYzENClvCoCAxMzJzXSA8
IGENClvCoCAxMzJzXSAtLS0NClvCoCAxMzJzXSA+IGINClvCoCAxMzJzXSAnDQpbwqAgMTMyc10g
KyBjb21wYXJlIGV4cCBvdXQNClvCoCAxMzJzXSArIGNvbXBhcmVfZGV2X251bGxfIGV4cCBvdXQN
ClvCoCAxMzJzXSArIHRlc3QgMiA9IDINClvCoCAxMzJzXSArIHRlc3QgeGV4cCA9IHgvZGV2L251
bGwNClvCoCAxMzJzXSArIHRlc3QgeG91dCA9IHgvZGV2L251bGwNClvCoCAxMzJzXSArIHJldHVy
biAyDQpbwqAgMTMyc10gKyBjYXNlICQ/IGluDQpbwqAgMTMyc10gKyBjb21wYXJlXyBleHAgb3V0
DQpbwqAgMTMyc10gKyBkaWZmIC11IGV4cCBvdXQNClvCoCAxMzJzXSArIHJldHVybnNfIDEgZW52
IA0KUEFUSD0vaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cy8u
Li9zcmM6L2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JVSUxEL2RpZmZ1dGlscy0zLjcvc3JjOi91c3Iv
bG9jYWwvYmluOi91c3IvYmluOi9iaW46L3Vzci9saWIvbWl0L2JpbjovdXNyL2xpYi9taXQvc2Jp
bjovc2JpbjovdXNyL3NiaW4gDQpURVJNPWR1bWIgZGlmZiAtLS1wcmVzdW1lLW91dHB1dC10dHkg
LS1jb2xvcj1hdXRvIGEgYg0KW8KgIDEzMnNdICsgZ2VuX2V4cF9kZWZhdWx0DQpbwqAgMTMyc10g
KyBwcmludGYgJXMgJzFjMQ0KW8KgIDEzMnNdIDwgYQ0KW8KgIDEzMnNdIC0tLQ0KW8KgIDEzMnNd
ID4gYg0KW8KgIDEzMnNdICcNClvCoCAxMzJzXSArIGNvbXBhcmUgZXhwIG91dA0KW8KgIDEzMnNd
ICsgY29tcGFyZV9kZXZfbnVsbF8gZXhwIG91dA0KW8KgIDEzMnNdICsgdGVzdCAyID0gMg0KW8Kg
IDEzMnNdICsgdGVzdCB4ZXhwID0geC9kZXYvbnVsbA0KW8KgIDEzMnNdICsgdGVzdCB4b3V0ID0g
eC9kZXYvbnVsbA0KW8KgIDEzMnNdICsgcmV0dXJuIDINClvCoCAxMzJzXSArIGNhc2UgJD8gaW4N
ClvCoCAxMzJzXSArIGNvbXBhcmVfIGV4cCBvdXQNClvCoCAxMzJzXSArIGRpZmYgLXUgZXhwIG91
dA0KW8KgIDEzMnNdICsgcmV0dXJuc18gMSBkaWZmIC0tY29sb3I9bmV2ZXIgYSBiDQpbwqAgMTMy
c10gKyBnZW5fZXhwX2RlZmF1bHQNClvCoCAxMzJzXSArIHByaW50ZiAlcyAnMWMxDQpbwqAgMTMy
c10gPCBhDQpbwqAgMTMyc10gLS0tDQpbwqAgMTMyc10gPiBiDQpbwqAgMTMyc10gJw0KW8KgIDEz
MnNdICsgY29tcGFyZSBleHAgb3V0DQpbwqAgMTMyc10gKyBjb21wYXJlX2Rldl9udWxsXyBleHAg
b3V0DQpbwqAgMTMyc10gKyB0ZXN0IDIgPSAyDQpbwqAgMTMyc10gKyB0ZXN0IHhleHAgPSB4L2Rl
di9udWxsDQpbwqAgMTMyc10gKyB0ZXN0IHhvdXQgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyBy
ZXR1cm4gMg0KW8KgIDEzMnNdICsgY2FzZSAkPyBpbg0KW8KgIDEzMnNdICsgY29tcGFyZV8gZXhw
IG91dA0KW8KgIDEzMnNdICsgZGlmZiAtdSBleHAgb3V0DQpbwqAgMTMyc10gKyByZXR1cm5zXyAx
IGRpZmYgYSBiDQpbwqAgMTMyc10gKyBnZW5fZXhwX2RlZmF1bHQNClvCoCAxMzJzXSArIHByaW50
ZiAlcyAnMWMxDQpbwqAgMTMyc10gPCBhDQpbwqAgMTMyc10gLS0tDQpbwqAgMTMyc10gPiBiDQpb
wqAgMTMyc10gJw0KW8KgIDEzMnNdICsgY29tcGFyZSBleHAgb3V0DQpbwqAgMTMyc10gKyBjb21w
YXJlX2Rldl9udWxsXyBleHAgb3V0DQpbwqAgMTMyc10gKyB0ZXN0IDIgPSAyDQpbwqAgMTMyc10g
KyB0ZXN0IHhleHAgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyB0ZXN0IHhvdXQgPSB4L2Rldi9u
dWxsDQpbwqAgMTMyc10gKyByZXR1cm4gMg0KW8KgIDEzMnNdICsgY2FzZSAkPyBpbg0KW8KgIDEz
MnNdICsgY29tcGFyZV8gZXhwIG91dA0KW8KgIDEzMnNdICsgZGlmZiAtdSBleHAgb3V0DQpbwqAg
MTMyc10gKyByZXR1cm5zXyAxIGRpZmYgLS1jb2xvcj1hbHdheXMgYSBiDQpbwqAgMTMyc10gKyBn
ZW5fZXhwX2RlZmF1bHRfY29sb3JzDQpbwqAgMTMyc10gKysgcHJpbnRmICcnDQpbwqAgMTMyc10g
KyBsb2NhbCAncnM9Jw0KW8KgIDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwg
J2hkPScNClvCoCAxMzJzXSArKyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2FsICdhZD0nDQpb
wqAgMTMyc10gKysgcHJpbnRmICcnDQpbwqAgMTMyc10gKyBsb2NhbCAnZGU9Jw0KW8KgIDEzMnNd
ICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwgJ2xuPScNClvCoCAxMzJzXSArIHByaW50
ZiAlcyAnMWMxDQpbwqAgMTMyc10gPCBhDQpbwqAgMTMyc10gLS0tDQpbwqAgMTMyc10gPiBiDQpb
wqAgMTMyc10gJw0KW8KgIDEzMnNdICsgY29tcGFyZSBleHAgb3V0DQpbwqAgMTMyc10gKyBjb21w
YXJlX2Rldl9udWxsXyBleHAgb3V0DQpbwqAgMTMyc10gKyB0ZXN0IDIgPSAyDQpbwqAgMTMyc10g
KyB0ZXN0IHhleHAgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyB0ZXN0IHhvdXQgPSB4L2Rldi9u
dWxsDQpbwqAgMTMyc10gKyByZXR1cm4gMg0KW8KgIDEzMnNdICsgY2FzZSAkPyBpbg0KW8KgIDEz
MnNdICsgY29tcGFyZV8gZXhwIG91dA0KW8KgIDEzMnNdICsgZGlmZiAtdSBleHAgb3V0DQpbwqAg
MTMyc10gKyByZXR1cm5zXyAxIGRpZmYgLXUgLS1jb2xvcj1hbHdheXMgYSBiDQpbwqAgMTMyc10g
KyBnZW5fZXhwX3UNClvCoCAxMzJzXSArIGxvY2FsICdlcG9jaF9wbHVzPTE5NzAtMDEtMDEgMDA6
MDA6MDAuMDAwMDAwMDAwICswMDAwJw0KW8KgIDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNd
ICsgbG9jYWwgJ3JzPScNClvCoCAxMzJzXSArKyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2Fs
ICdoZD0nDQpbwqAgMTMyc10gKysgcHJpbnRmICcnDQpbwqAgMTMyc10gKyBsb2NhbCAnYWQ9Jw0K
W8KgIDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwgJ2RlPScNClvCoCAxMzJz
XSArKyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2FsICdsbj0nDQpbwqAgMTMyc10gKyBwcmlu
dGYgJXMgJy0tLSBhwqDCoMKgwqAgMTk3MC0wMS0wMSAwMDowMDowMC4wMDAwMDAwMDAgKzAwMDAN
ClvCoCAxMzJzXSArKysgYsKgIDE5NzAtMDEtMDEgMDA6MDA6MDAuMDAwMDAwMDAwICswMDAwDQpb
wqAgMTMyc10gQEAgLTEgKzEgQEANClvCoCAxMzJzXSAtYQ0KW8KgIDEzMnNdICtiDQpbwqAgMTMy
c10gJw0KW8KgIDEzMnNdICsgY29tcGFyZSBleHAgb3V0DQpbwqAgMTMyc10gKyBjb21wYXJlX2Rl
dl9udWxsXyBleHAgb3V0DQpbwqAgMTMyc10gKyB0ZXN0IDIgPSAyDQpbwqAgMTMyc10gKyB0ZXN0
IHhleHAgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyB0ZXN0IHhvdXQgPSB4L2Rldi9udWxsDQpb
wqAgMTMyc10gKyByZXR1cm4gMg0KW8KgIDEzMnNdICsgY2FzZSAkPyBpbg0KW8KgIDEzMnNdICsg
Y29tcGFyZV8gZXhwIG91dA0KW8KgIDEzMnNdICsgZGlmZiAtdSBleHAgb3V0DQpbwqAgMTMyc10g
KyByZXR1cm5zXyAxIGRpZmYgLWMgLS1jb2xvcj1hbHdheXMgYSBiDQpbwqAgMTMyc10gKyBnZW5f
ZXhwX2MNClvCoCAxMzJzXSArIGxvY2FsICdlcG9jaF9wb3NpeF8xMDAzXzFfMjAwMT1UaHUgSmFu
wqAgMSAwMDowMDowMCAxOTcwJw0KW8KgIDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsg
bG9jYWwgJ3JzPScNClvCoCAxMzJzXSArKyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2FsICdo
ZD0nDQpbwqAgMTMyc10gKysgcHJpbnRmICcnDQpbwqAgMTMyc10gKyBsb2NhbCAnYWQ9Jw0KW8Kg
IDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwgJ2RlPScNClvCoCAxMzJzXSAr
KyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2FsICdsbj0nDQpbwqAgMTMyc10gKyBwcmludGYg
JXMgJyoqKiBhwqDCoMKgwqAgVGh1IEphbsKgIDEgMDA6MDA6MDAgMTk3MA0KW8KgIDEzMnNdIC0t
LSBiwqAgVGh1IEphbsKgIDEgMDA6MDA6MDAgMTk3MA0KW8KgIDEzMnNdICoqKioqKioqKioqKioq
Kg0KW8KgIDEzMnNdICoqKiAxICoqKioNClvCoCAxMzJzXSAhIGENClvCoCAxMzJzXSAtLS0gMSAt
LS0tDQpbwqAgMTMyc10gISBiDQpbwqAgMTMyc10gJw0KW8KgIDEzMnNdICsgY29tcGFyZSBleHAg
b3V0DQpbwqAgMTMyc10gKyBjb21wYXJlX2Rldl9udWxsXyBleHAgb3V0DQpbwqAgMTMyc10gKyB0
ZXN0IDIgPSAyDQpbwqAgMTMyc10gKyB0ZXN0IHhleHAgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10g
KyB0ZXN0IHhvdXQgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyByZXR1cm4gMg0KW8KgIDEzMnNd
ICsgY2FzZSAkPyBpbg0KW8KgIDEzMnNdICsgY29tcGFyZV8gZXhwIG91dA0KW8KgIDEzMnNdICsg
ZGlmZiAtdSBleHAgb3V0DQpbwqAgMTMyc10gKyBycz0wDQpbwqAgMTMyc10gKyBoZD0zMw0KW8Kg
IDEzMnNdICsgYWQ9MzQNClvCoCAxMzJzXSArIGRlPTM1DQpbwqAgMTMyc10gKyBsbj0zNg0KW8Kg
IDEzMnNdICsgcmV0dXJuc18gMSBkaWZmIC11IC0tY29sb3I9YWx3YXlzIA0KLS1wYWxldHRlPXJz
PTA6aGQ9MzM6YWQ9MzQ6ZGU9MzU6bG49MzYgYSBiDQpbwqAgMTMyc10gKyBnZW5fZXhwX3UNClvC
oCAxMzJzXSArIGxvY2FsICdlcG9jaF9wbHVzPTE5NzAtMDEtMDEgMDA6MDA6MDAuMDAwMDAwMDAw
ICswMDAwJw0KW8KgIDEzMnNdICsrIHByaW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwgJ3JzPScN
ClvCoCAxMzJzXSArKyBwcmludGYgJycNClvCoCAxMzJzXSArIGxvY2FsICdoZD0nDQpbwqAgMTMy
c10gKysgcHJpbnRmICcnDQpbwqAgMTMyc10gKyBsb2NhbCAnYWQ9Jw0KW8KgIDEzMnNdICsrIHBy
aW50ZiAnJw0KW8KgIDEzMnNdICsgbG9jYWwgJ2RlPScNClvCoCAxMzJzXSArKyBwcmludGYgJycN
ClvCoCAxMzJzXSArIGxvY2FsICdsbj0nDQpbwqAgMTMyc10gKyBwcmludGYgJXMgJy0tLSBhwqDC
oMKgwqAgMTk3MC0wMS0wMSAwMDowMDowMC4wMDAwMDAwMDAgKzAwMDANClvCoCAxMzJzXSArKysg
YsKgIDE5NzAtMDEtMDEgMDA6MDA6MDAuMDAwMDAwMDAwICswMDAwDQpbwqAgMTMyc10gQEAgLTEg
KzEgQEANClvCoCAxMzJzXSAtYQ0KW8KgIDEzMnNdICtiDQpbwqAgMTMyc10gJw0KW8KgIDEzMnNd
ICsgY29tcGFyZSBleHAgb3V0DQpbwqAgMTMyc10gKyBjb21wYXJlX2Rldl9udWxsXyBleHAgb3V0
DQpbwqAgMTMyc10gKyB0ZXN0IDIgPSAyDQpbwqAgMTMyc10gKyB0ZXN0IHhleHAgPSB4L2Rldi9u
dWxsDQpbwqAgMTMyc10gKyB0ZXN0IHhvdXQgPSB4L2Rldi9udWxsDQpbwqAgMTMyc10gKyByZXR1
cm4gMg0KW8KgIDEzMnNdICsgY2FzZSAkPyBpbg0KW8KgIDEzMnNdICsgY29tcGFyZV8gZXhwIG91
dA0KW8KgIDEzMnNdICsgZGlmZiAtdSBleHAgb3V0DQpbwqAgMTMyc10gKyBta2ZpZm8gZmlmbw0K
W8KgIDEzMnNdICsgcHJpbnRmICUxMDAwMDAwcy1hDQpbwqAgMTMyc10gKyBwcmludGYgJTEwMDAw
MDBzLWINClvCoCAxMzJzXSArIGRpZmYgLS1jb2xvcj1hbHdheXMgLS0tcHJlc3VtZS1vdXRwdXQt
dHR5IGEgYg0KW8KgIDEzMnNdICsgaGVhZCAtYyAxMA0KW8KgIDEzMnNdIGRpZmY6IHN0YW5kYXJk
IG91dHB1dDogQnJva2VuIHBpcGUNClvCoCAxMzJzXSArIHRlc3QgMiA9IDE0MQ0KW8KgIDEzMnNd
ICsgZmFpbD0xDQpbwqAgMTMyc10gKyBFeGl0IDENClvCoCAxMzJzXSArIHNldCArZQ0KW8KgIDEz
MnNdICsgZXhpdCAxDQpbwqAgMTMyc10gKyBleGl0IDENClvCoCAxMzJzXSArIHJlbW92ZV90bXBf
DQpbwqAgMTMyc10gKyBfX3N0PTENClvCoCAxMzJzXSArIGNsZWFudXBfDQpbwqAgMTMyc10gKyA6
DQpbwqAgMTMyc10gKyB0ZXN0ICcnID0geWVzDQpbwqAgMTMyc10gKyBjZCAvaG9tZS9hYnVpbGQv
cnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cw0KW8KgIDEzMnNdICsgY2htb2QgLVIg
dStyd3ggDQovaG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cy9n
dC1jb2xvcnMudWhOaw0KW8KgIDEzMnNdICsgcm0gLXJmIA0KL2hvbWUvYWJ1aWxkL3JwbWJ1aWxk
L0JVSUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMvZ3QtY29sb3JzLnVoTmsNClvCoCAxMzJzXSArIGV4
aXQgMQ0KW8KgIDEzMnNdIEZBSUwgY29sb3JzIChleGl0IHN0YXR1czogMSkNClvCoCAxMzJzXQ0K
W8KgIDEzMnNdIA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KW8KgIDEzMnNdIFRlc3RzdWl0ZSBzdW1t
YXJ5IGZvciBHTlUgZGlmZnV0aWxzIDMuNw0KW8KgIDEzMnNdIA0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQ0KW8KgIDEzMnNdICMgVE9UQUw6IDIyDQpbwqAgMTMyc10gIyBQQVNTOsKgIDE5DQpbwqAgMTMy
c10gIyBTS0lQOsKgIDENClvCoCAxMzJzXSAjIFhGQUlMOiAxDQpbwqAgMTMyc10gIyBGQUlMOsKg
IDENClvCoCAxMzJzXSAjIFhQQVNTOiAwDQpbwqAgMTMyc10gIyBFUlJPUjogMA0KW8KgIDEzMnNd
IA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQ0KW8KgIDEzMnNdIFNlZSB0ZXN0cy90ZXN0LXN1aXRlLmxv
Zw0KW8KgIDEzMnNdIFBsZWFzZSByZXBvcnQgdG8gYnVnLWRpZmZ1dGlsc0BnbnUub3JnDQpbwqAg
MTMyc10gDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpbwqAgMTMyc10gbWFrZVszXTogKioqIFtNYWtl
ZmlsZToxNTU5OiB0ZXN0LXN1aXRlLmxvZ10gRXJyb3IgMQ0KW8KgIDEzMnNdIG1ha2VbM106IExl
YXZpbmcgZGlyZWN0b3J5IA0KJy9ob21lL2FidWlsZC9ycG1idWlsZC9CVUlMRC9kaWZmdXRpbHMt
My43L3Rlc3RzJw0KW8KgIDEzMnNdIG1ha2VbMl06ICoqKiBbTWFrZWZpbGU6MTY2NzogY2hlY2st
VEVTVFNdIEVycm9yIDINClvCoCAxMzJzXSBtYWtlWzJdOiBMZWF2aW5nIGRpcmVjdG9yeSANCicv
aG9tZS9hYnVpbGQvcnBtYnVpbGQvQlVJTEQvZGlmZnV0aWxzLTMuNy90ZXN0cycNClvCoCAxMzJz
XSBtYWtlWzFdOiAqKiogW01ha2VmaWxlOjE4ODc6IGNoZWNrLWFtXSBFcnJvciAyDQpbwqAgMTMy
c10gbWFrZVsxXTogTGVhdmluZyBkaXJlY3RvcnkgDQonL2hvbWUvYWJ1aWxkL3JwbWJ1aWxkL0JV
SUxEL2RpZmZ1dGlscy0zLjcvdGVzdHMnDQpbwqAgMTMyc10gbWFrZTogKioqIFtNYWtlZmlsZTox
MzYxOiBjaGVjay1yZWN1cnNpdmVdIEVycm9yIDENClvCoCAxMzJzXSBlcnJvcjogQmFkIGV4aXQg
c3RhdHVzIGZyb20gL3Zhci90bXAvcnBtLXRtcC5BREV1Q3cgKCVjaGVjaykNClvCoCAxMzJzXQ0K
W8KgIDEzMnNdDQpbwqAgMTMyc10gUlBNIGJ1aWxkIGVycm9yczoNClvCoCAxMzJzXcKgwqDCoMKg
IEJhZCBleGl0IHN0YXR1cyBmcm9tIC92YXIvdG1wL3JwbS10bXAuQURFdUN3ICglY2hlY2spDQpb
wqAgMTMyc10NClvCoCAxMzJzXSBkZXZlc3RhdG9yIGZhaWxlZCAiYnVpbGQgZGlmZnV0aWxzLnNw
ZWMiIGF0IFR1ZSBKYW7CoCAxIDE2OjE3OjMzIA0KVVRDIDIwMTkuDQpbwqAgMTMyc10NCg0K




From MAILER-DAEMON Tue Jan 01 23:42:09 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1geYM4-0004AU-U8
	for mharc-bug-diffutils@gnu.org; Tue, 01 Jan 2019 23:42:08 -0500
Received: from eggs.gnu.org ([208.118.235.92]:58349)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYM2-00047Z-IE
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 23:42:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYLy-0001zK-Il
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 23:42:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41830)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1geYLy-0001yy-Do
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 23:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYLy-0001zH-Aq
	for bug-diffutils@gnu.org; Tue, 01 Jan 2019 23:42:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Wed, 02 Jan 2019 04:42:02 +0000
Resent-Message-ID: <handler.33947.B33947.15464040647554@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33947
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Sean Lewis <sean@suspend.net>
Cc: 33947@debbugs.gnu.org
Received: via spool by 33947-submit@debbugs.gnu.org id=B33947.15464040647554
	(code B ref 33947); Wed, 02 Jan 2019 04:42:02 +0000
Received: (at 33947) by debbugs.gnu.org; 2 Jan 2019 04:41:04 +0000
Received: from localhost ([127.0.0.1]:44235 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1geYL1-0001xk-LY
	for submit@debbugs.gnu.org; Tue, 01 Jan 2019 23:41:03 -0500
Received: from mail-wm1-f53.google.com ([209.85.128.53]:33641)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <meyering@gmail.com>) id 1geYKz-0001x8-Fv
	for 33947@debbugs.gnu.org; Tue, 01 Jan 2019 23:41:02 -0500
Received: by mail-wm1-f53.google.com with SMTP id r24so32021132wmh.0
	for <33947@debbugs.gnu.org>; Tue, 01 Jan 2019 20:41:01 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc;
	bh=EKtS1jfcCUg884wGegOz5jv6pyAtSZHBOTO0vdvLkm4=;
	b=PyWl2bizUS5gt9kDvO8cTWVm4UEZiWt9tPqHGjQ+AHikkVKsY8Bu8qiHEoEkEYgKO2
	ga3b9Dr6ZIy2n6sxhGQEjc+/cJbG24yMXd3BoC9zhY4MY+q/La5tk3Zq4DzhXNAUNBH1
	3s3Vnht7Ynv1emr/N/bHBE8YVogRFv/15nMoGWS5rYwEGqRa2NHhXlX/SYrhC1AH12OH
	MAkL/99pksGS8hpFyERMP7wP2CVtsiP7yH2D3384SMXE9cDLkEUQm+nfxR4xBQvyOca3
	kx/rRCG0rbQTgwPGH++pe3Ac/OoDJldxTOl098pubSMH8pnsHZgVuaGbXX7JwM6mqH18
	n+DA==
X-Gm-Message-State: AJcUukfhAIOeVJiJglHkE7eZXqw4T5BL6ne2as6Foa4Lnd3HaD37l8WW
	9sllhZRqG4yr4o+5P65WwC+Mke0rQhMogVOMWVnkMfBw
X-Google-Smtp-Source: AFSGD/XEnDqAsxGjkLLn9ixoJmBjFPZO8PFMLlvecF0n2IwuIBXgliFwlWYGW6LVrguHRFRimW+M61N3+H9tS4LdLUQ=
X-Received: by 2002:a7b:c218:: with SMTP id x24mr34454026wmi.58.1546404055594; 
	Tue, 01 Jan 2019 20:40:55 -0800 (PST)
MIME-Version: 1.0
References: <MWHPR1601MB1296C95DDF7A22AAA86AAC77D8B30@MWHPR1601MB1296.namprd16.prod.outlook.com>
In-Reply-To: <MWHPR1601MB1296C95DDF7A22AAA86AAC77D8B30@MWHPR1601MB1296.namprd16.prod.outlook.com>
From: Jim Meyering <jim@meyering.net>
Date: Tue, 1 Jan 2019 20:40:43 -0800
Message-ID: <CA+8g5KERX2qocLvMp23W+OcV_3zKQUfsBLAzDg+Q-zV1-6_aSA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33947: bug#33947: Failure building
 diffutils-3.7 (openSUSE:Factory)
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jan 2019 04:42:07 -0000

On Tue, Jan 1, 2019 at 9:06 AM Sean Lewis <sean@suspend.net> wrote:
> Today I attempted to package the new diffutils 3.7 and received build
> failures (test.log output is below for your reference).

Correction: the build succeeded, but you encountered a test failure.

> This is for
> openSUSE and I'm building using our Tumbleweed rolling release model
> which has (nearly) current components for all pieces of the environment.
> Any guidance you can provide is appreciated, thank you and happy new year.
...

A happy new year to you, too.
Thank you for the testing and the report.
Your system failed the final sub-test of the "colors" test because it
fails to propagate an PIPE signal "out" to the expected exit status of
141. Instead, diff on your system exits with status of 2:
...
> [  132s] + mkfifo fifo
> [  132s] + printf %1000000s-a
> [  132s] + printf %1000000s-b
> [  132s] + diff --color=always ---presume-output-tty a b
> [  132s] + head -c 10
> [  132s] diff: standard output: Broken pipe
> [  132s] + test 2 = 141
> [  132s] + fail=1

>From the above diagnostic, it is clear there was a broken pipe error.
...
> [  132s] FAIL colors (exit status: 1)

To reproduce it manually, run these commands:

mkfifo fifo
printf '%1000000s-a' > a
printf '%1000000s-b' > b
head -c 10 < fifo > /dev/null &
diff --color=always ---presume-output-tty a b > fifo
echo $?

The final echo should print 141.
Did you configure your shell to ignore SIGPIPE?




From MAILER-DAEMON Wed Jan 02 00:05:07 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1geYiJ-0005fg-MK
	for mharc-bug-diffutils@gnu.org; Wed, 02 Jan 2019 00:05:07 -0500
Received: from eggs.gnu.org ([208.118.235.92]:35372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYiH-0005fW-NG
	for bug-diffutils@gnu.org; Wed, 02 Jan 2019 00:05:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYiF-0006EK-15
	for bug-diffutils@gnu.org; Wed, 02 Jan 2019 00:05:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48164)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1geYiE-0006EF-TK
	for bug-diffutils@gnu.org; Wed, 02 Jan 2019 00:05:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1geYiE-0002Yx-Fd
	for bug-diffutils@gnu.org; Wed, 02 Jan 2019 00:05:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Sean Lewis <sean@suspend.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Wed, 02 Jan 2019 05:05:02 +0000
Resent-Message-ID: <handler.33947.B33947.15464054789816@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33947
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Jim Meyering <jim@meyering.net>
Cc: "33947@debbugs.gnu.org" <33947@debbugs.gnu.org>
Received: via spool by 33947-submit@debbugs.gnu.org id=B33947.15464054789816
	(code B ref 33947); Wed, 02 Jan 2019 05:05:02 +0000
Received: (at 33947) by debbugs.gnu.org; 2 Jan 2019 05:04:38 +0000
Received: from localhost ([127.0.0.1]:44241 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1geYhq-0002YG-0v
	for submit@debbugs.gnu.org; Wed, 02 Jan 2019 00:04:38 -0500
Received: from mail-oln040092012031.outbound.protection.outlook.com
	([40.92.12.31]:25128
	helo=NAM05-BY2-obe.outbound.protection.outlook.com)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <sean@suspend.net>) id 1geYhn-0002Y3-N9
	for 33947@debbugs.gnu.org; Wed, 02 Jan 2019 00:04:36 -0500
Received: from DM3NAM05FT051.eop-nam05.prod.protection.outlook.com
	(10.152.98.53) by DM3NAM05HT200.eop-nam05.prod.protection.outlook.com
	(10.152.99.130) with Microsoft SMTP Server (version=TLS1_2,
	cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.7;
	Wed, 2 Jan 2019 05:04:29 +0000
Received: from MWHPR1601MB1296.namprd16.prod.outlook.com (10.152.98.52) by
	DM3NAM05FT051.mail.protection.outlook.com (10.152.98.165) with
	Microsoft SMTP
	Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
	15.20.1471.7 via Frontend Transport; Wed, 2 Jan 2019 05:04:29 +0000
Received: from MWHPR1601MB1296.namprd16.prod.outlook.com
	([fe80::b560:52e4:e17a:1c3f]) by
	MWHPR1601MB1296.namprd16.prod.outlook.com
	([fe80::b560:52e4:e17a:1c3f%9]) with mapi id 15.20.1471.019;
	Wed, 2 Jan 2019 05:04:29 +0000
From: Sean Lewis <sean@suspend.net>
Thread-Topic: [bug-diffutils] bug#33947: Failure building diffutils-3.7
	(openSUSE:Factory)
Thread-Index: AQHUofGYrXehzCULwku39FelV/hKK6WbZsCAgAAFalA=
Date: Wed, 2 Jan 2019 05:04:29 +0000
Message-ID: <MWHPR1601MB1296A094AC608D5ACB4D0AB6D88C0@MWHPR1601MB1296.namprd16.prod.outlook.com>
References: <MWHPR1601MB1296C95DDF7A22AAA86AAC77D8B30@MWHPR1601MB1296.namprd16.prod.outlook.com>,
	<CA+8g5KERX2qocLvMp23W+OcV_3zKQUfsBLAzDg+Q-zV1-6_aSA@mail.gmail.com>
In-Reply-To: <CA+8g5KERX2qocLvMp23W+OcV_3zKQUfsBLAzDg+Q-zV1-6_aSA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-incomingtopheadermarker: OriginalChecksum:310C4B9111A3DB55FD8F4989F60A96D27951A9C3B5322FE073E50F5A43D5274C;
	UpperCasedChecksum:FDAD0E2A4DBE3D1145BE1A0B5B8C9E481F205C9DF6EB86EA19441BD9560A1125;
	SizeAsReceived:7265; Count:47
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [Zh/W8BireFlJAuDLXl/Y5SnzQO7HA8DE]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DM3NAM05HT200;
	6:MFDX3pq9JXeZy03NXSE2NRV7kwiCezKi+z6pMCtQUttA8Hkt3bqWyZeO6fCtuVKpLAbr99EQVz6W4Fq9s1muyDJDvyvJdw1WRaHrzwV2bPO/m0pmB0Y8Ka5aNtv8VxyUQhS0yP4RkdIcZepyq+c7CuZWUYCO/6CP/1g+utFAUcWab9+YLNXBYd2KJGe4YfQSmyQ1RCNaWh8M6GdSvRUZgFUY4UbEU3nZYmML3slPwaoIW4RWgXVRcUhCTM2pQ3F7Gg+BTYgETC1AU6jOSFuQ35EzmRNtZiLkgWoLqDVs4BUt5AouNpisW1zgBMA5ogj+Ad9wiQXeYnC78m14zJgl7SksjyvhiDBrLvoB3McRSiEacgAErH0WaQvZ4UPJRn+BgcSAJsY3g84RrXLH7bXEoLsYh2IhOp1cCK7foWAprFc6SUI7o26/p06TWZtDbwXU1/sk17bTveXfLkiGfRLLIw==;
	5:Jv5g31F7SD5r/axbmT13SA14QPm+9gq/G8Q5OIi3at/U0YSYaVmUI9Kr1Ikf66WpVpLH4pmqITGzqyj+naKJOAgBDoUJmVkF/qQX7D2DQW0OLvJxqHCrCYB+OEYQ/kZSBeSyVK4khoKAhRKDVX/TZEplxr0I6VoO5zitwLTNq/8=;
	7:WbmXg+BfhPwvislFxXhnMTvwZ9y/SHm77mDSRu7Yilt3uFkn5/cy3ADhtD+AZgEY8GeOSV4/FUai2/dZCgiNP7YRZ8YshwHe2C090ttDtJV8hwdY9Akx7WE2NlpI7PAvjRcRzecB9aVWJraL0VVS8Q==
x-incomingheadercount: 47
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0; PCL:0;
	RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);
	SRVR:DM3NAM05HT200; 
x-ms-traffictypediagnostic: DM3NAM05HT200:
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); 
	SRVR:DM3NAM05HT200; BCL:0; PCL:0; RULEID:;
	SRVR:DM3NAM05HT200; 
x-microsoft-antispam-message-info: 7rNPPM1DEbNzdPuWd4hRGkydJe2tDXiuWAjfRYMgKQJVptqrXHkL2mXpwFKulr7f
Content-Type: multipart/alternative;
	boundary="_000_MWHPR1601MB1296A094AC608D5ACB4D0AB6D88C0MWHPR1601MB1296_"
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 9bd8b953-1c55-4da7-b616-8bcad099ae8b
X-MS-Exchange-CrossTenant-Network-Message-Id: ada49dcd-65a0-4ee0-16ba-08d6706fc66f
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 9bd8b953-1c55-4da7-b616-8bcad099ae8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2019 05:04:29.1653 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3NAM05HT200
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33947: bug#33947: Failure building
 diffutils-3.7 (openSUSE:Factory)
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jan 2019 05:05:06 -0000

--_000_MWHPR1601MB1296A094AC608D5ACB4D0AB6D88C0MWHPR1601MB1296_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

Hi Jim,

Thanks for the response, comments in-line.


From: Jim Meyering<mailto:jim@meyering.net>
Sent: Tuesday, January 1, 2019 20:40
To: Sean Lewis<mailto:sean@suspend.net>
Cc: 33947@debbugs.gnu.org<mailto:33947@debbugs.gnu.org>
Subject: Re: [bug-diffutils] bug#33947: Failure building diffutils-3.7 (ope=
nSUSE:Factory)

On Tue, Jan 1, 2019 at 9:06 AM Sean Lewis <sean@suspend.net> wrote:
> Today I attempted to package the new diffutils 3.7 and received build
> failures (test.log output is below for your reference).

Correction: the build succeeded, but you encountered a test failure.
>> Fair enough :)

> This is for
> openSUSE and I'm building using our Tumbleweed rolling release model
> which has (nearly) current components for all pieces of the environment.
> Any guidance you can provide is appreciated, thank you and happy new year=
.
...

A happy new year to you, too.
Thank you for the testing and the report.
Your system failed the final sub-test of the "colors" test because it
fails to propagate an PIPE signal "out" to the expected exit status of
141. Instead, diff on your system exits with status of 2:
...
> [  132s] + mkfifo fifo
> [  132s] + printf %1000000s-a
> [  132s] + printf %1000000s-b
> [  132s] + diff --color=3Dalways ---presume-output-tty a b
> [  132s] + head -c 10
> [  132s] diff: standard output: Broken pipe
> [  132s] + test 2 =3D 141
> [  132s] + fail=3D1

>From the above diagnostic, it is clear there was a broken pipe error.
...
> [  132s] FAIL colors (exit status: 1)
>> Agreed.

To reproduce it manually, run these commands:

mkfifo fifo
printf '%1000000s-a' > a
printf '%1000000s-b' > b
head -c 10 < fifo > /dev/null &
diff --color=3Dalways ---presume-output-tty a b > fifo
echo $?

The final echo should print 141.
Did you configure your shell to ignore SIGPIPE?
>> I get 141 as a result there as well in userland. I=92m wondering if this=
 has to do with how we configure shell variables in our osc build environme=
nt. I=92ll investigate and get back to you, thanks for taking a look.

Sean

--_000_MWHPR1601MB1296A094AC608D5ACB4D0AB6D88C0MWHPR1601MB1296_
Content-Type: text/html; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of=
fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1=
252">
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style>
</head>
<body lang=3D"EN-US" link=3D"blue" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal">Hi Jim, </p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Thanks for the response, comments in-line.</p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<div style=3D"mso-element:para-border-div;border:none;border-top:solid #E1E=
1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class=3D"MsoNormal" style=3D"border:none;padding:0in"><b>From: </b><a hr=
ef=3D"mailto:jim@meyering.net">Jim Meyering</a><br>
<b>Sent: </b>Tuesday, January 1, 2019 20:40<br>
<b>To: </b><a href=3D"mailto:sean@suspend.net">Sean Lewis</a><br>
<b>Cc: </b><a href=3D"mailto:33947@debbugs.gnu.org">33947@debbugs.gnu.org</=
a><br>
<b>Subject: </b>Re: [bug-diffutils] bug#33947: Failure building diffutils-3=
.7 (openSUSE:Factory)</p>
</div>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">On Tue, Jan 1, 2019 at 9:06 AM Sean Lewis &lt;sean@s=
uspend.net&gt; wrote:<br>
&gt; Today I attempted to package the new diffutils 3.7 and received build<=
br>
&gt; failures (test.log output is below for your reference).<br>
<br>
Correction: the build succeeded, but you encountered a test failure.<br>
&gt;&gt; Fair enough :) <o:p></o:p></p>
<p class=3D"MsoNormal"><br>
&gt; This is for<br>
&gt; openSUSE and I'm building using our Tumbleweed rolling release model<b=
r>
&gt; which has (nearly) current components for all pieces of the environmen=
t.<br>
&gt; Any guidance you can provide is appreciated, thank you and happy new y=
ear.<br>
...<br>
<br>
A happy new year to you, too.<br>
Thank you for the testing and the report.<br>
Your system failed the final sub-test of the &quot;colors&quot; test becaus=
e it<br>
fails to propagate an PIPE signal &quot;out&quot; to the expected exit stat=
us of<br>
141. Instead, diff on your system exits with status of 2:<br>
...<br>
&gt; [&nbsp; 132s] &#43; mkfifo fifo<br>
&gt; [&nbsp; 132s] &#43; printf %1000000s-a<br>
&gt; [&nbsp; 132s] &#43; printf %1000000s-b<br>
&gt; [&nbsp; 132s] &#43; diff --color=3Dalways ---presume-output-tty a b<br=
>
&gt; [&nbsp; 132s] &#43; head -c 10<br>
&gt; [&nbsp; 132s] diff: standard output: Broken pipe<br>
&gt; [&nbsp; 132s] &#43; test 2 =3D 141<br>
&gt; [&nbsp; 132s] &#43; fail=3D1<br>
<br>
>From the above diagnostic, it is clear there was a broken pipe error.<br>
...<br>
&gt; [&nbsp; 132s] FAIL colors (exit status: 1)<br>
&gt;&gt; Agreed.<o:p></o:p></p>
<p class=3D"MsoNormal"><br>
To reproduce it manually, run these commands:<br>
<br>
mkfifo fifo<br>
printf '%1000000s-a' &gt; a<br>
printf '%1000000s-b' &gt; b<br>
head -c 10 &lt; fifo &gt; /dev/null &amp;<br>
diff --color=3Dalways ---presume-output-tty a b &gt; fifo<br>
echo $?<br>
<br>
The final echo should print 141.<br>
Did you configure your shell to ignore SIGPIPE?<o:p></o:p></p>
<p class=3D"MsoNormal">&gt;&gt; I get 141 as a result there as well in user=
land. I=92m wondering if this has to do with how we configure shell variabl=
es in our osc build environment. I=92ll investigate and get back to you, th=
anks for taking a look.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Sean<o:p></o:p></p>
</div>
</body>
</html>

--_000_MWHPR1601MB1296A094AC608D5ACB4D0AB6D88C0MWHPR1601MB1296_--




From MAILER-DAEMON Thu Jan 03 14:43:11 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gf8tb-0005pz-GZ
	for mharc-bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:43:11 -0500
Received: from eggs.gnu.org ([208.118.235.92]:54339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf8tZ-0005pp-GM
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:43:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf8tU-0002lz-Fk
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:43:09 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33823)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gf8tU-0002lt-C5
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:43:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf8tR-0006hg-S5
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:43:04 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Bruno Haible <bruno@clisp.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 03 Jan 2019 19:43:01 +0000
Resent-Message-ID: <handler.33965.B.154654456025733@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 33965@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.154654456025733
	(code B ref -1); Thu, 03 Jan 2019 19:43:01 +0000
Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 19:42:40 +0000
Received: from localhost ([127.0.0.1]:45978 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gf8t6-0006gz-8f
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 14:42:40 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:54525)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <bruno@clisp.org>) id 1gf8t3-0006gr-PG
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 14:42:38 -0500
Received: from lists.gnu.org ([208.118.235.17]:39561)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bruno@clisp.org>) id 1gf8t3-0002Ue-CC
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 14:42:37 -0500
Received: from eggs.gnu.org ([208.118.235.92]:54177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruno@clisp.org>) id 1gf8t2-0005nI-8s
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:42:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruno@clisp.org>) id 1gf8t1-0002TS-7F
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:42:36 -0500
Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:27735)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bruno@clisp.org>) id 1gf8t0-0002QG-Mf
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 14:42:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546544549;
	s=strato-dkim-0002; d=clisp.org;
	h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From:
	Subject:Sender;
	bh=bbtcrI9mcFw+VGLtihe2kprsV78PlZcIxbhyEi0xrk8=;
	b=dvC87gTWLRV5DM3s3hnmaaj85eZUkbRsefLnZKY6nGarjgMaivaE4aNOhZjvyISUMz
	Xu5m2CrfQM0x73vp8Q6DdStWyJqu3ZF/r5/mkHjIPrcwKhxLbZuXHd0TFltC2Lt6PQTp
	aK2dKIjNGMtBQ9Gf9PNviCBRRxy4ctRzK4hrv7O8YKBWZIOs5k5ozNwZx1UGF+1mcIXd
	PTOGaOVL1WvnfYfJNtiGy5MjDj9+lr7ZKmFSUaAWYHpw4gtmb/JfNiPAoeh2McM1oR82
	ve3FZOjc5G163K6M8bOjBF/bPNNdtTy7BA/qkfTgXFmG1xB3c4SgGTBVn/FRLnJX/3q4
	DuVQ==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s="
X-RZG-CLASS-ID: mo00
Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH)
	with ESMTPSA id k06e80v03JgTLIm
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521
	ECDH
	bits, eq. 15360 bits RSA)) (Client did not present a certificate);
	Thu, 3 Jan 2019 20:42:29 +0100 (CET)
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 03 Jan 2019 20:42:28 +0100
Message-ID: <6639990.yRvKeTYcJc@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart8317215.dh2gXTNRMh"
Content-Transfer-Encoding: 7Bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: handling of closed file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 19:43:10 -0000

This is a multi-part message in MIME format.

--nextPart8317215.dh2gXTNRMh
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

There is a problem with the handling of closed file descriptors
in diff-3.7: As mentioned in [1], the 'new-file' test fails on HP-UX.
An investigation [2] shows that different coding techniques are needed,
depending on the desired outcome for closed file descriptors.

This patch uses a variant of (A) from [2]. Namely, the result of fcntl
can apparently be used to distinguish the substitute file descriptor
stuffed in by exec() from a regular open("/dev/null",O_RDONLY).

[1] https://lists.gnu.org/archive/html/diffutils-devel/2018-12/msg00019.html
[2] https://lists.gnu.org/archive/html/bug-gnulib/2019-01/msg00012.html

--nextPart8317215.dh2gXTNRMh
Content-Disposition: attachment; filename="0001-Recognize-file-descriptors-closed-by-the-parent-proc.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0001-Recognize-file-descriptors-closed-by-the-parent-proc.patch"

>From 288ddc7c18c022f39233ca78e78e49e02833966c Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 3 Jan 2019 20:36:35 +0100
Subject: [PATCH] Recognize file descriptors closed by the parent process on
 HP-UX.

* src/diff.c (compare_files): Use fcntl to distinguish a file descriptor closed
by the parent parent process from a file descriptor that references /dev/null.
---
 src/diff.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/diff.c b/src/diff.c
index 6e8c6be..2ed3ae5 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -1172,6 +1172,13 @@ compare_files (struct comparison const *parent,
 	      cmp.file[f].desc = STDIN_FILENO;
 	      if (binary && ! isatty (STDIN_FILENO))
 		set_binary_mode (STDIN_FILENO, O_BINARY);
+#ifdef __hpux
+	      /* Recognize file descriptors closed by the parent on HP-UX.  */
+	      int flags = fcntl (STDIN_FILENO, F_GETFL, NULL);
+	      if (flags >= 0 && (flags & FD_CLOEXEC) != 0)
+		cmp.file[f].desc = ERRNO_ENCODE (EBADF);
+	      else
+#endif
 	      if (fstat (STDIN_FILENO, &cmp.file[f].stat) != 0)
 		cmp.file[f].desc = ERRNO_ENCODE (errno);
 	      else
-- 
2.7.4


--nextPart8317215.dh2gXTNRMh--





From MAILER-DAEMON Thu Jan 03 15:03:15 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gf9D1-0001vA-K4
	for mharc-bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:03:15 -0500
Received: from eggs.gnu.org ([208.118.235.92]:59229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf9Cz-0001ur-6J
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:03:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf9Cv-0006Bw-D6
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:03:11 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41643)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gf9Cp-00067z-3p
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:03:05 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gf9Co-0007D9-DK
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:03:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Bruno Haible <bruno@clisp.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 03 Jan 2019 20:03:02 +0000
Resent-Message-ID: <handler.33965.B.154654574327649@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 33965@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.154654574327649
	(code B ref -1); Thu, 03 Jan 2019 20:03:02 +0000
Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 20:02:23 +0000
Received: from localhost ([127.0.0.1]:45983 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gf9CB-0007Bs-0C
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 15:02:23 -0500
Received: from eggs.gnu.org ([208.118.235.92]:60193)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <bruno@clisp.org>) id 1gf9C8-0007Bk-AY
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 15:02:21 -0500
Received: from lists.gnu.org ([208.118.235.17]:56379)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bruno@clisp.org>) id 1gf9C8-0005eT-5L
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 15:02:20 -0500
Received: from eggs.gnu.org ([208.118.235.92]:59000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruno@clisp.org>) id 1gf9C7-0001rP-E5
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:02:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruno@clisp.org>) id 1gf9C6-0005da-N6
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:02:19 -0500
Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::6]:29686)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bruno@clisp.org>) id 1gf9C6-0005cd-6K
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 15:02:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546545736;
	s=strato-dkim-0002; d=clisp.org;
	h=References:In-Reply-To:Message-ID:Date:Subject:To:From:
	X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
	bh=79sr3y1MmGIeyUSoORFJ9lk3S+H8Fvt2HPsNavAq95Q=;
	b=N1EVZUB2ksQt7EGQPtdH0J4YqBf6OBioxAMAtQ4RC46UnVyjTttQE5bd0AfCrsxsbp
	8g9/WAvqIo3m9/REGJu4ur+DU55lK9CK8ddAIX1Dbfw5s57UyEUB43bmqURJUSX7xftg
	xc1vGJ9VHeFTnTKN1fwCjdySWixbE34UaMviRsJRHIgsFeIwfcxOBrl/qUFm0glE5/Ya
	Nf/PAOHzNVmmYYGFt5y1G8zbON5ds6yhFFIMFS377NbVnunFZOmtBY8IooAZeZMYbjPl
	4viNRO1VJURJNt+drG67FDGz6KaaLkhIlCWPL8J8Hbb+NCWToaDzw+ij7Y28tviCWPc2
	KGag==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s="
X-RZG-CLASS-ID: mo00
Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH)
	with ESMTPSA id k06e80v03K2GLKy
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521
	ECDH
	bits, eq. 15360 bits RSA)) (Client did not present a certificate);
	Thu, 3 Jan 2019 21:02:16 +0100 (CET)
From: Bruno Haible <bruno@clisp.org>
Date: Thu, 03 Jan 2019 21:02:16 +0100
Message-ID: <64441865.ngSBGZCanV@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <6639990.yRvKeTYcJc@omega>
References: <6639990.yRvKeTYcJc@omega>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: handling of closed file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 20:03:14 -0000

I wrote:
> the result of fcntl
> can apparently be used to distinguish the substitute file descriptor
> stuffed in by exec() from a regular open("/dev/null",O_RDONLY).

Note that the code works for STDIN_FILENO, where fcntl(...) is 5 in one case
and 0 in the other case, and we use FD_CLOEXEC = 1 to distinguish the two.
For STDOUT_FILENO, fcntl(...) would be 5 in one case and 1 in the other case,
and the flag which allows to distinguish the two cases (4) is not listed in
<sys/fcntl.h>, therefore likely is a kernel-private flag.

Bruno





From MAILER-DAEMON Thu Jan 03 18:29:09 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfCQH-00071u-Sx
	for mharc-bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:29:09 -0500
Received: from eggs.gnu.org ([208.118.235.92]:36461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfCQF-00071e-Op
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:29:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfCQC-0004MA-LN
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:29:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:37455)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfCQC-0004Ly-AT
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:29:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfCQB-0005pp-Tl
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:29:03 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Sergio =?UTF-8?Q?S=C3=A1mano?= <sergio_samano_salazar@hotmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Thu, 03 Jan 2019 23:29:02 +0000
Resent-Message-ID: <handler.33970.B.154655812822404@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 33970
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 33970@debbugs.gnu.org
X-Debbugs-Original-To: "bug-diffutils@gnu.org" <bug-diffutils@gnu.org>
Received: via spool by submit@debbugs.gnu.org id=B.154655812822404
	(code B ref -1); Thu, 03 Jan 2019 23:29:02 +0000
Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 23:28:48 +0000
Received: from localhost ([127.0.0.1]:46076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfCPv-0005pI-GG
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 18:28:48 -0500
Received: from eggs.gnu.org ([208.118.235.92]:46624)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <sergio_samano_salazar@hotmail.com>)
	id 1gfC1i-0005DC-MD
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 18:03:47 -0500
Received: from lists.gnu.org ([208.118.235.17]:40188)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <sergio_samano_salazar@hotmail.com>)
	id 1gfC1i-00053d-A2
	for submit@debbugs.gnu.org; Thu, 03 Jan 2019 18:03:46 -0500
Received: from eggs.gnu.org ([208.118.235.92]:56225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sergio_samano_salazar@hotmail.com>)
	id 1gfC1h-0006qY-CC
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:03:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sergio_samano_salazar@hotmail.com>)
	id 1gfC1e-00051i-7B
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:03:45 -0500
Received: from mail-oln040092011054.outbound.protection.outlook.com
	([40.92.11.54]:1055 helo=NAM04-SN1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <sergio_samano_salazar@hotmail.com>)
	id 1gfC1d-00050n-UT
	for bug-diffutils@gnu.org; Thu, 03 Jan 2019 18:03:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
	s=selector1;
	h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
	bh=1FVwzljBpzS8nP5roW/Fxw6pJsKa2TfK5y0imNCx7Ok=;
	b=sOvE0o3BdnILLD2KY/909M8zAjxP/8YHNujNDKZieOaZrOHaKiXn+BHraDxQ4HEQJriYIRkETVX7U3OzerLjYeOYGFWzV5b+4+s6c4EsZ1OaCc8hH9F9smqrVleSJ/1VCn3kbUJeWZJr5lxqm8e76m9dMM2n8NqvVBuZeuXigf9J5qH1vj/6aMM3/X34ZY449pmn2lN5+4GffqCkQDwtws64KD80KwRJFe6Y7DYzHRK1eQ5VDPjcYCFCTG1vpUv3Zv1TX5BTapq3W64lR1WZzfTwQd+gc80Q76AtXsx5uy9Cm1w6qYtJE8kH281jFN4VG74e9Kt1qgqccxmRMdy2fg==
Received: from SN1NAM04FT024.eop-NAM04.prod.protection.outlook.com
	(10.152.88.55) by SN1NAM04HT003.eop-NAM04.prod.protection.outlook.com
	(10.152.88.172) with Microsoft SMTP Server (version=TLS1_2,
	cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13;
	Thu, 3 Jan 2019 23:03:40 +0000
Received: from DM5PR0701MB3704.namprd07.prod.outlook.com (10.152.88.56) by
	SN1NAM04FT024.mail.protection.outlook.com (10.152.88.106) with
	Microsoft SMTP
	Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
	15.20.1471.13 via Frontend Transport; Thu, 3 Jan 2019 23:03:40 +0000
Received: from DM5PR0701MB3704.namprd07.prod.outlook.com
	([fe80::4c97:736b:4532:180f]) by
	DM5PR0701MB3704.namprd07.prod.outlook.com
	([fe80::4c97:736b:4532:180f%6]) with mapi id 15.20.1495.005;
	Thu, 3 Jan 2019 23:03:40 +0000
From: Sergio =?UTF-8?Q?S=C3=A1mano?= <sergio_samano_salazar@hotmail.com>
Thread-Topic: Issue dpkg with diff
Thread-Index: AQHUo6ClCJrW07eMVU+z7ym7CRqN4w==
Date: Thu, 3 Jan 2019 23:03:40 +0000
Message-ID: <DM5PR0701MB3704149CFDA076E14AD67482A38D0@DM5PR0701MB3704.namprd07.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-incomingtopheadermarker: OriginalChecksum:860E8D73B9B15FF2716853CF91FBE642F7BEFCC3145B342A426581F0DDBD59B8;
	UpperCasedChecksum:1954680FA36417795C3A98374CD74184938097611E5FB835354C90E1C9AFEA29;
	SizeAsReceived:6832; Count:43
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [wnzgQrEMYQ9b8A9WKJbSjflEOSMLc3NV]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; SN1NAM04HT003;
	6:zjlFQtUAcUNCYm4adNgf/aFltZojtQ4Gl3bt942oCp0/Rm7Gk2imtZC8/Ben/I6GZHBcw102Lj0RXvXq03gHRJ5QG5zqO2KBISAp7R7fKBX0c8kLkCA611fNK0MQAAWy4P2KmCxTLkpbiWZGX7vFPGh0oaSnPho2nUziA6w8xIq3FT6/TORXR5jTCM+lrfAPTJ/1f00NkTmsnRgjUytsqWWffe6SmmKp/A8Jx5WBVjIj3nh8JaH/Whcp/bkB4CmKKY49jdJ9HxvKD8QLKgnnR78osjdzHLzDfXAm4Gq2huserpXMZ8J7oUp31zb6pcw3FIh3mnnAflud5oAKOS8rw9PngX4pfHYAJbvnd7Leof0+3yHN5zoNj0KQNKugdVUrnN8sf7RH/x45s2RrrJ+ZuHk4qqhMwYIjTt11Mx0JjVbWC8Wy6lofnVwL315MRgYagFq17gFYxd8RkvO0PZC2Qg==;
	5:6ajygItttdY/JaAB696ioBJQ5mp3r4w1cVo0ymIRQZ3xvTf+ZsFzQLdfQy56bystZQlD00R5GWmnBihWNpIVA/DimFRqPrsxfapj2Aoly5ThSfqaxkoreFXAcZyS+ftZZCHELpSFVAJysAhHR32YA899dS461tH5I4axzfqcXnY=;
	7:GH/p4S5jamchp4bZpajchL3Ap3wjwgCMMJqaUb25LRDP/uRLk0tcz8MRys2utCbc/7xU+6Xl19cKauHIADwjorqU7w0g8uXOr+g9ZLQzhjW7VzOQz4dLsQE5E6x2o0Wsh99+PlcJv5NVx85T3zC+hQ==
x-incomingheadercount: 43
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0; PCL:0;
	RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);
	SRVR:SN1NAM04HT003; 
x-ms-traffictypediagnostic: SN1NAM04HT003:
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058); 
	SRVR:SN1NAM04HT003; BCL:0; PCL:0; RULEID:;
	SRVR:SN1NAM04HT003; 
x-microsoft-antispam-message-info: MXfwxSm7YQoncrKdkDqKnZt0KzurH4m3RgHQw345zWI+/RKfN/P46zi06pwjoU3b
Content-Type: multipart/alternative;
	boundary="_000_DM5PR0701MB3704149CFDA076E14AD67482A38D0DM5PR0701MB3704_"
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: f12efbb0-867f-4c93-8261-502eceebfafa
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c407bce-fba2-4395-439b-08d671cfb359
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: f12efbb0-867f-4c93-8261-502eceebfafa
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2019 23:03:40.0324 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT003
X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Mailman-Approved-At: Thu, 03 Jan 2019 18:28:45 -0500
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33970: Issue dpkg with diff
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 23:29:08 -0000

--_000_DM5PR0701MB3704149CFDA076E14AD67482A38D0DM5PR0701MB3704_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi

I have some issue related with apt-get update, upgrade, dpkg, are.,  runnin=
g all of them as root(recovery mode)finished with:

dpkg: warning: 'diff' not found in PATH or no executable
dpkg: error: 1 expected program not found or not executable
Note: root's PATH should usually contain /usr/sbin/ and /sbin

I've checked
#uname -a
Linux debian 4.18.0.3-amd64 #1 SMP Debian 4.18.20-2 (2018-11-23) x86_64 GNU=
/Linux
#echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin

I've modified

/etc/sudoers
Adding the line

Defaults secure_path:"/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin"

And in /root/.bashrc
Adding  the line

export PATH:/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin


Also in the file
/etc/profile  (doing match in both lines of PATH)
...
if [ "`id-u`" -eq 0 then]
PATH=3D"/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin"
else
PATH=3D"/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin:/usr/local/games=
:/usr/games"
...

And even after that I get the same

I've tried PATH before the instructions and is the same

Do you know why it is happening?
Do you have any guidance to resolve this?

Thanks in advance

Regards


Sergio S=E1mano


--_000_DM5PR0701MB3704149CFDA076E14AD67482A38D0DM5PR0701MB3704_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
</head>
<body>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Hi <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
I have some issue related with apt-get update, upgrade, dpkg, are.,&nbsp; r=
unning all of them as root(recovery mode)finished with:
<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
dpkg: warning: 'diff' not found in PATH or no executable <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
dpkg: error: 1 expected program not found or not executable <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Note: root's PATH should usually contain /usr/sbin/ and /sbin <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
I've checked <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
#uname -a <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Linux debian 4.18.0.3-amd64 #1 SMP Debian 4.18.20-2 (2018-11-23) x86_64 GNU=
/Linux
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
#echo $PATH <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
I've modified <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
/etc/sudoers <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Adding the line <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Defaults secure_path:&quot;/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/b=
in&quot; <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
And in /root/.bashrc <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Adding&nbsp; the line <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
export PATH:/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin <br>
<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Also in the file <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
/etc/profile&nbsp; (doing match in both lines of PATH)<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
...<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
if [ &quot;`id-u`&quot; -eq 0 then]<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
PATH=3D&quot;/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin&quot; <br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
else<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
PATH=3D&quot;/usr/local/sbin:/usr/local/bin:/usr/bin:/sbin:/bin:/usr/local/=
games:/usr/games&quot;
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
...<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
And even after that I get the same <br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
I've tried PATH before the instructions and is the same<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Do you know why it is happening?<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Do you have any guidance to resolve this?<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Thanks in advance<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Regards
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
<br>
<br>
</div>
<div dir=3D"auto" style=3D"direction: ltr; margin: 0; padding: 0; font-fami=
ly: sans-serif; font-size: 11pt; color: black; ">
Sergio S=E1mano</div>
<br>
</div>
</body>
</html>

--_000_DM5PR0701MB3704149CFDA076E14AD67482A38D0DM5PR0701MB3704_--




From MAILER-DAEMON Fri Jan 04 01:16:08 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfIm8-00066S-Mi
	for mharc-bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:16:08 -0500
Received: from eggs.gnu.org ([208.118.235.92]:59268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIm6-00063x-3k
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:16:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIm2-0000wR-Uh
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:16:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:47878)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfIm2-0000wJ-R8
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:16:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIm2-0008B9-Gx
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:16:02 -0500
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Fri, 04 Jan 2019 06:16:02 +0000
Resent-Message-ID: <handler.33965.D33965.154658253930289.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Bruno Haible <bruno@clisp.org>
Cc: 33965-done@debbugs.gnu.org
Mail-Followup-To: 33965@debbugs.gnu.org, jim@meyering.net, bruno@clisp.org
Received: via spool by 33965-done@debbugs.gnu.org id=D33965.154658253930289
	(code D ref 33965); Fri, 04 Jan 2019 06:16:02 +0000
Received: (at 33965-done) by debbugs.gnu.org; 4 Jan 2019 06:15:39 +0000
Received: from localhost ([127.0.0.1]:46164 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfIlf-0007sB-14
	for submit@debbugs.gnu.org; Fri, 04 Jan 2019 01:15:39 -0500
Received: from mail-wm1-f42.google.com ([209.85.128.42]:40473)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <meyering@gmail.com>) id 1gfIld-0007lo-3k
	for 33965-done@debbugs.gnu.org; Fri, 04 Jan 2019 01:15:37 -0500
Received: by mail-wm1-f42.google.com with SMTP id f188so225531wmf.5
	for <33965-done@debbugs.gnu.org>; Thu, 03 Jan 2019 22:15:37 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc;
	bh=a4MlZlzjJ5MGW9dldKf2Oc79zPcg/IGWqtyl84K3mjI=;
	b=Vgz2z0zEkQSuXqcudLs5E/BRqBNHQgejih9Ffa24lwXtNFKiZ8fb1sMVAVg6zoKMl7
	eeONfe8SRUZJctNL4VLzI31q7MmiiFUWkCC8oeKuTuO4A330jrZrOvFpbu5MT2VRGhR0
	w9VetFbBlFa+jpjy15Jlr+G9GiQMnlPb/q1kjfLUftU83QBAOMSXXzz0w5BwtBv2qK1F
	2fx8gh/7qC3o7qR9lUEcR+bHAhgU7QjCUJ3lW11nI2G2vtf84xoEwAWJTltr+fCjjlu3
	OnlzsPpmQb9CL9lJyj4UL6qIPvlUXvXfvSxNkTsAMxo3idO139qB2cpFWGxkb0lFGJMV
	9LMw==
X-Gm-Message-State: AJcUukfW+sfD0+C8J5uUvE2Ws53iEqzEwVvph/iuptlW5sZC71yoICzS
	68oPptSPtroguXjwGNVj3My8VleY22peHYE+zPA=
X-Google-Smtp-Source: ALg8bN4nBAcsKqeVr8UOl8K8nFBi4mgl9sUySVCy3Al7Z9ZpfNFZ6cxYxfnLxp8hnGfzRD/mqQN4hNlTLGBodTMJ4hM=
X-Received: by 2002:a1c:4346:: with SMTP id q67mr347065wma.114.1546582531343; 
	Thu, 03 Jan 2019 22:15:31 -0800 (PST)
MIME-Version: 1.0
References: <6639990.yRvKeTYcJc@omega>
In-Reply-To: <6639990.yRvKeTYcJc@omega>
From: Jim Meyering <jim@meyering.net>
Date: Thu, 3 Jan 2019 22:15:19 -0800
Message-ID: <CA+8g5KEe5CDHBKFqUgEUTV6saK2XDSn2_SVPQp_U53SRMABDWA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: bug#33965: handling of closed file
 descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 06:16:07 -0000

On Thu, Jan 3, 2019 at 11:43 AM Bruno Haible <bruno@clisp.org> wrote:
>
> There is a problem with the handling of closed file descriptors
> in diff-3.7: As mentioned in [1], the 'new-file' test fails on HP-UX.
> An investigation [2] shows that different coding techniques are needed,
> depending on the desired outcome for closed file descriptors.
>
> This patch uses a variant of (A) from [2]. Namely, the result of fcntl
> can apparently be used to distinguish the substitute file descriptor
> stuffed in by exec() from a regular open("/dev/null",O_RDONLY).
>
> [1] https://lists.gnu.org/archive/html/diffutils-devel/2018-12/msg00019.html
> [2] https://lists.gnu.org/archive/html/bug-gnulib/2019-01/msg00012.html

Thank you. I have just pushed that with one tweak to the log message:
s/parent parent/parent/.




From MAILER-DAEMON Fri Jan 04 01:26:10 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfIvq-0000r1-OH
	for mharc-bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:26:10 -0500
Received: from eggs.gnu.org ([208.118.235.92]:32943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIvo-0000qv-RV
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:26:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIvj-0006qb-7R
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:26:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58284)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfIvi-0006qS-8P
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:26:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfIvi-0001Bq-0c
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 01:26:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Jim Meyering <jim@meyering.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Fri, 04 Jan 2019 06:26:01 +0000
Resent-Message-ID: <handler.33970.B33970.15465831254534@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33970
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Sergio =?UTF-8?Q?S=C3=A1mano?= <sergio_samano_salazar@hotmail.com>
Cc: 33970@debbugs.gnu.org
Received: via spool by 33970-submit@debbugs.gnu.org id=B33970.15465831254534
	(code B ref 33970); Fri, 04 Jan 2019 06:26:01 +0000
Received: (at 33970) by debbugs.gnu.org; 4 Jan 2019 06:25:25 +0000
Received: from localhost ([127.0.0.1]:46168 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfIv7-0001B4-0W
	for submit@debbugs.gnu.org; Fri, 04 Jan 2019 01:25:25 -0500
Received: from mail-wr1-f49.google.com ([209.85.221.49]:43209)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <meyering@gmail.com>) id 1gfIv5-0001As-CS
	for 33970@debbugs.gnu.org; Fri, 04 Jan 2019 01:25:23 -0500
Received: by mail-wr1-f49.google.com with SMTP id r10so35605715wrs.10
	for <33970@debbugs.gnu.org>; Thu, 03 Jan 2019 22:25:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:cc:content-transfer-encoding;
	bh=V6cQ4d/JTOhsnhP7zT8qd5eXZPRSxbzs7TH+1imN+mw=;
	b=RBaK0IDXnZEt3miCD3ry53nenU3DpPLyv2324OnXZWi2/WehOCJSuPIGlULmCeTnyz
	J2Q20BdZHzg1XaZtLRYlYEsrMpBcFKaipXD23U1xDyFXTLSWzJHsKmXFdLjbDa3DUDQe
	yOrww4YU+BCDpvhp6sFoB9YGD2x/osS/GFeqTylXZ0Il9P6yXCYWv4S6g/owe2i72MWC
	8uGIKg7NQUIhClTT5oSh04Z04YqZgZrC6Lo05/0HQY+5YH6+hzZMsy9EVE8aBeIaz/mw
	iL4u5j+CcMs5QW8N4eYP03/zvjRZZRqPKVc8JUGWjtEqeQMVat8zchpoB53Rxt9dNuAl
	ga2A==
X-Gm-Message-State: AJcUukfjWHdbnAdba0kfCOMQqRJsEawICusCX9ej9n+OI/X7CvY3Zkh7
	k86erPXoe0j3cWGkkbuzpaYghHZO5CpPNJ6C2KI=
X-Google-Smtp-Source: ALg8bN41Z8hdweSMaNf4wX+RD7wRu36uOtKQP1hbDXGV7OvluU+GRnFUxTNdC3rU3ZZuzSmHwJ44QMKe5cCtuXA8lRs=
X-Received: by 2002:adf:c846:: with SMTP id e6mr41443135wrh.243.1546583117613; 
	Thu, 03 Jan 2019 22:25:17 -0800 (PST)
MIME-Version: 1.0
References: <DM5PR0701MB3704149CFDA076E14AD67482A38D0@DM5PR0701MB3704.namprd07.prod.outlook.com>
In-Reply-To: <DM5PR0701MB3704149CFDA076E14AD67482A38D0@DM5PR0701MB3704.namprd07.prod.outlook.com>
From: Jim Meyering <jim@meyering.net>
Date: Thu, 3 Jan 2019 22:25:06 -0800
Message-ID: <CA+8g5KFjUzTLxeLm5uKcz8catWDGuQFH9vF6UtOf==sROeuB4g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33970:  bug#33970: Issue dpkg with diff
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 06:26:09 -0000

tags 33970 + notabug
close 33970
stop

On Thu, Jan 3, 2019 at 3:29 PM Sergio S=C3=A1mano
<sergio_samano_salazar@hotmail.com> wrote:
> I have some issue related with apt-get update, upgrade, dpkg, are.,  runn=
ing all of them as root(recovery mode)finished with:
>
> dpkg: warning: 'diff' not found in PATH or no executable
> dpkg: error: 1 expected program not found or not executable
> Note: root's PATH should usually contain /usr/sbin/ and /sbin

Thanks for the report, but it appears to be due to a problem in your
environment and not a problem with GNU diff, so I'm closing this as
notabug.
I suggest you look for help on debian-related lists or forums.




From MAILER-DAEMON Fri Jan 04 17:43:07 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfYBH-0000xX-Jy
	for mharc-bug-diffutils@gnu.org; Fri, 04 Jan 2019 17:43:07 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:57872 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYBF-0000ut-Si
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 17:43:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYBC-0005zO-Lr
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 17:43:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:34419)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfYBC-0005yJ-HM
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 17:43:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYBC-0005FA-7j
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 17:43:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Fri, 04 Jan 2019 22:43:02 +0000
Resent-Message-ID: <handler.33965.B33965.154664175220116@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 33965@debbugs.gnu.org, jim@meyering.net, bruno@clisp.org
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.154664175220116
	(code B ref 33965); Fri, 04 Jan 2019 22:43:02 +0000
Received: (at 33965) by debbugs.gnu.org; 4 Jan 2019 22:42:32 +0000
Received: from localhost ([127.0.0.1]:47102 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfYAi-0005EO-2d
	for submit@debbugs.gnu.org; Fri, 04 Jan 2019 17:42:32 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39778)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eggert@cs.ucla.edu>) id 1gfYAf-0005E8-2k
	for 33965@debbugs.gnu.org; Fri, 04 Jan 2019 17:42:30 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id E7BAD160F5B;
	Fri,  4 Jan 2019 14:42:22 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id 4lGmXO5PkIEK; Fri,  4 Jan 2019 14:42:22 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBBAC160F5C;
	Fri,  4 Jan 2019 14:42:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id lhaMMLX6czO2; Fri,  4 Jan 2019 14:42:21 -0800 (PST)
Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200])
	by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CB8C1160F57;
	Fri,  4 Jan 2019 14:42:21 -0800 (PST)
From: Paul Eggert <eggert@cs.ucla.edu>
References: <6639990.yRvKeTYcJc@omega>
	<CA+8g5KEe5CDHBKFqUgEUTV6saK2XDSn2_SVPQp_U53SRMABDWA@mail.gmail.com>
Openpgp: preference=signencrypt
Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata=
	xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9
	Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS
	96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl
	KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss
	mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK
	QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2
	Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC
	OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+
	KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB
	n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy
	dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG
	FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t
	nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr
	6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD
	0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH
	s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY
	0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu
	oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt
	N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl
	+G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu
	ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc
	1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6
	70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/
	IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r
	Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r
	FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO
	gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6
	6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA
	nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA
	77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G
	IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC
	AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs
	T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF
	/VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO
	FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD
	LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx
	c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc
	XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu
	5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB
	1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0
	q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b
	uNcby4U=
Organization: UCLA Computer Science Department
Message-ID: <5640e0dc-e97f-fc77-0087-9dbc8c506dc5@cs.ucla.edu>
Date: Fri, 4 Jan 2019 14:42:21 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
	Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <CA+8g5KEe5CDHBKFqUgEUTV6saK2XDSn2_SVPQp_U53SRMABDWA@mail.gmail.com>
Content-Type: multipart/mixed; boundary="------------4C5C8295E10957DE69AEE802"
Content-Language: en-US
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: bug#33965: bug#33965: handling of closed
 file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 22:43:07 -0000

This is a multi-part message in MIME format.
--------------4C5C8295E10957DE69AEE802
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

I'd rather think of this as a bug in the test case, not a bug in 'diff'. 
This is because the test case assumes more about the shell's "<&-" 
construct than what POSIX requires.

The bigger picture here is that invoking programs with stdin closed is 
trouble, and although Gnulib provides several modules to work around the 
trouble these modules are a hassle and many applications don't use them. 
We should encourage platforms like HP-UX that try to work around the 
trouble, instead of having diffutils attempt to simulate the traditional 
but inferior exec semantics. Although the Linux kernel currently 
implements the traditional semantics, in this particular case I think 
I'd rather have diffutils adjust to what the platform provides, rather 
than attempt to simulate Linux behavior even on non-Linux kernels.

So I propose the attached further patch.

--------------4C5C8295E10957DE69AEE802
Content-Type: text/plain; charset=UTF-8;
 name="0001-diff-move-HP-UX-workaround-into-test-case.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-diff-move-HP-UX-workaround-into-test-case.txt"

RnJvbSBmZDNjOTc4ZGQ5Mjk0NTNkZmJlMGJmOGVhYTkyOTUzMjEyNzRiYTMzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1
PgpEYXRlOiBGcmksIDQgSmFuIDIwMTkgMTM6NDM6NTUgLTA4MDAKU3ViamVjdDogW1BBVENI
XSBkaWZmOiBtb3ZlIEhQLVVYIHdvcmthcm91bmQgaW50byB0ZXN0IGNhc2UKTUlNRS1WZXJz
aW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl
bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCiogc3JjL2RpZmYuYyAoY29tcGFyZV9maWxl
cykgW19faHB1eF06IFJlbW92ZSByZWNlbnRseS1pbnRyb2R1Y2VkCnNwZWNpYWwgY2FzZSBm
b3IgSFAtVVggZXhlYyB3aXRoIHN0ZGluIGNsb3NlZC4KKiB0ZXN0cy9uZXctZmlsZTogRG9u
4oCZdCBhc3N1bWUgc3RkaW4gc3RheXMgY2xvc2VkIGFmdGVyIGEKc3VjY2Vzc2Z1bCBleGVj
LCBhcyBQT1NJWCBkb2VzbuKAmXQgZ3VhcmFudGVlIHRoaXMgYW5kIGl0IGlzCm5vdCB0cnVl
IG9uIEhQLVVYLgotLS0KIHNyYy9kaWZmLmMgICAgIHwgIDcgLS0tLS0tLQogdGVzdHMvbmV3
LWZpbGUgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiAyIGZpbGVz
IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp
dCBhL3NyYy9kaWZmLmMgYi9zcmMvZGlmZi5jCmluZGV4IDJlZDNhZTUuLjZlOGM2YmUgMTAw
NjQ0Ci0tLSBhL3NyYy9kaWZmLmMKKysrIGIvc3JjL2RpZmYuYwpAQCAtMTE3MiwxMyArMTE3
Miw2IEBAIGNvbXBhcmVfZmlsZXMgKHN0cnVjdCBjb21wYXJpc29uIGNvbnN0ICpwYXJlbnQs
CiAJICAgICAgY21wLmZpbGVbZl0uZGVzYyA9IFNURElOX0ZJTEVOTzsKIAkgICAgICBpZiAo
YmluYXJ5ICYmICEgaXNhdHR5IChTVERJTl9GSUxFTk8pKQogCQlzZXRfYmluYXJ5X21vZGUg
KFNURElOX0ZJTEVOTywgT19CSU5BUlkpOwotI2lmZGVmIF9faHB1eAotCSAgICAgIC8qIFJl
Y29nbml6ZSBmaWxlIGRlc2NyaXB0b3JzIGNsb3NlZCBieSB0aGUgcGFyZW50IG9uIEhQLVVY
LiAgKi8KLQkgICAgICBpbnQgZmxhZ3MgPSBmY250bCAoU1RESU5fRklMRU5PLCBGX0dFVEZM
LCBOVUxMKTsKLQkgICAgICBpZiAoZmxhZ3MgPj0gMCAmJiAoZmxhZ3MgJiBGRF9DTE9FWEVD
KSAhPSAwKQotCQljbXAuZmlsZVtmXS5kZXNjID0gRVJSTk9fRU5DT0RFIChFQkFERik7Ci0J
ICAgICAgZWxzZQotI2VuZGlmCiAJICAgICAgaWYgKGZzdGF0IChTVERJTl9GSUxFTk8sICZj
bXAuZmlsZVtmXS5zdGF0KSAhPSAwKQogCQljbXAuZmlsZVtmXS5kZXNjID0gRVJSTk9fRU5D
T0RFIChlcnJubyk7CiAJICAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvdGVzdHMvbmV3LWZpbGUg
Yi90ZXN0cy9uZXctZmlsZQppbmRleCA0NDAwMDUxLi45YjJhZGE0IDEwMDc1NQotLS0gYS90
ZXN0cy9uZXctZmlsZQorKysgYi90ZXN0cy9uZXctZmlsZQpAQCAtMTAsMTEgKzEwLDIxIEBA
IGVjaG8gYSA+IGEgfHwgZmFpbD0xCiBlY2hvICcwYTEKID4gYScgPiBleHAgfHwgZmFpbD0x
CiAKLXJldHVybnNfIDEgZGlmZiAtTiAtIGEgPCYtID4gb3V0IHx8IGZhaWw9MQotY29tcGFy
ZSBleHAgb3V0IHx8IGZhaWw9MQotCi1yZXR1cm5zXyAxIGRpZmYgLS11bmlkaXJlY3Rpb25h
bC1uZXctZmlsZSAtIGEgPCYtID4gb3V0IHx8IGZhaWw9MQotY29tcGFyZSBleHAgb3V0IHx8
IGZhaWw9MQorIyBQT1NJWCBhbGxvd3MgYSBjbG9zZWQgc3RkaW4gdG8gYmUgb3BlbmVkIGJ5
IHRoZSBrZXJuZWwgYWZ0ZXIgYW4gZXhlYywKKyMgc28gZG8gc29tZSB0ZXN0cyBvbmx5IG9u
IHBsYXRmb3JtcyB3aGVyZSBzdGRpbiBzdGF5cyBjbG9zZWQgdGhlbi4KK2lmIHJldHVybnNf
IDIgY21wIC0gLSA8Ji0gPi9kZXYvbnVsbCAyPiYxOyB0aGVuCisgIHN0ZGluX3N0YXlzX2Ns
b3NlZD10cnVlCitlbHNlCisgIHN0ZGluX3N0YXlzX2Nsb3NlZD1mYWxzZQorZmkKKworaWYg
JHN0ZGluX3N0YXlzX2Nsb3NlZDsgdGhlbgorICByZXR1cm5zXyAxIGRpZmYgLU4gLSBhIDwm
LSA+IG91dCB8fCBmYWlsPTEKKyAgY29tcGFyZSBleHAgb3V0IHx8IGZhaWw9MQorCisgIHJl
dHVybnNfIDEgZGlmZiAtLXVuaWRpcmVjdGlvbmFsLW5ldy1maWxlIC0gYSA8Ji0gPiBvdXQg
fHwgZmFpbD0xCisgIGNvbXBhcmUgZXhwIG91dCB8fCBmYWlsPTEKK2ZpCiAKIHJldHVybnNf
IDEgZGlmZiAtTiBiIC0gPCBhID4gb3V0IHx8IGZhaWw9MQogY29tcGFyZSBleHAgb3V0IHx8
IGZhaWw9MQpAQCAtMjUsMTMgKzM1LDE1IEBAIGNvbXBhcmUgZXhwIG91dCB8fCBmYWlsPTEK
IGVjaG8gJzFkMAogPCBhJyA+IGV4cCB8fCBmYWlsPTEKIAotcmV0dXJuc18gMSBkaWZmIC1O
IGEgLSA8Ji0gPiBvdXQgfHwgZmFpbD0xCi1jb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0xCitp
ZiAkc3RkaW5fc3RheXNfY2xvc2VkOyB0aGVuCisgIHJldHVybnNfIDEgZGlmZiAtTiBhIC0g
PCYtID4gb3V0IHx8IGZhaWw9MQorICBjb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0xCiAKLSMg
V2l0aCBjbG9zZWQgc3RhbmRhcmQgaW5wdXQsIHJlcXVpcmUgYW4gZXhpdCBzdGF0dXMgb2Yg
MgotIyBhbmQgZW1wdHkgc3Rkb3V0LgotcmV0dXJuc18gMiBkaWZmIC0tdW5pZGlyZWN0aW9u
YWwtbmV3LWZpbGUgYSAtIDwmLSA+IG91dCB8fCBmYWlsPTEKLWNvbXBhcmUgL2Rldi9udWxs
IG91dCB8fCBmYWlsPTEKKyAgIyBXaXRoIGNsb3NlZCBzdGFuZGFyZCBpbnB1dCwgcmVxdWly
ZSBhbiBleGl0IHN0YXR1cyBvZiAyCisgICMgYW5kIGVtcHR5IHN0ZG91dC4KKyAgcmV0dXJu
c18gMiBkaWZmIC0tdW5pZGlyZWN0aW9uYWwtbmV3LWZpbGUgYSAtIDwmLSA+IG91dCB8fCBm
YWlsPTEKKyAgY29tcGFyZSAvZGV2L251bGwgb3V0IHx8IGZhaWw9MQorZmkKIAogcmV0dXJu
c18gMSBkaWZmIC1OIC0gYiA8IGEgPiBvdXQgfHwgZmFpbD0xCiBjb21wYXJlIGV4cCBvdXQg
fHwgZmFpbD0xCi0tIAoyLjIwLjEKCg==
--------------4C5C8295E10957DE69AEE802--




From MAILER-DAEMON Fri Jan 04 18:31:08 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfYvk-0006SR-Hd
	for mharc-bug-diffutils@gnu.org; Fri, 04 Jan 2019 18:31:08 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:40848 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYvi-0006SH-FS
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 18:31:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYvf-0007YG-Bp
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 18:31:06 -0500
Received: from debbugsout.gnu.org ([209.51.188.43]:57747)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfYve-0007Y2-Of
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 18:31:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfYve-0008VL-Am
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 18:31:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Bruno Haible <bruno@clisp.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Fri, 04 Jan 2019 23:31:02 +0000
Resent-Message-ID: <handler.33965.B33965.154664465032659@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 33965@debbugs.gnu.org, jim@meyering.net
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.154664465032659
	(code B ref 33965); Fri, 04 Jan 2019 23:31:02 +0000
Received: (at 33965) by debbugs.gnu.org; 4 Jan 2019 23:30:50 +0000
Received: from localhost ([127.0.0.1]:47116 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfYvR-0008Uf-JJ
	for submit@debbugs.gnu.org; Fri, 04 Jan 2019 18:30:49 -0500
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.218]:33126)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <bruno@clisp.org>) id 1gfYvN-0008UQ-Mu
	for 33965@debbugs.gnu.org; Fri, 04 Jan 2019 18:30:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546644644;
	s=strato-dkim-0002; d=clisp.org;
	h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:
	X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
	bh=YKY71bg2K+aRo73JF+nqXalqTdfCWKnzxQR2orgt7zw=;
	b=LQvys7U8FFO6Z46IU7+bgokP4hDrXUiFHBq57kkQ/aPMiZuts+tnyYnSpVFw0lzFLn
	lkYTEQHUG0RTjWPHiqR48AMJUrC6f3eq1cNlC//GR1KefkTnuP0g0oSQfBZhV9i1gTUl
	gzN0zsesusSRb6sb17J161G6WPGjVG9DbLw/HPS8K0tfdOnXSmRulLl///C15BH+Jm4j
	pMZ0I1J+HYAWuwT5W+AbCJHjZYP71Pm6rGKNWXkxuBdHXFoFGINlPEhuOcXyun07QIxL
	Kg7hRnkvB5UGP60wNFQdddxsWKCVIhqO5++HAZMujEj+HIq4EfSPLDD2etCG17auTTqo
	HoBw==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s="
X-RZG-CLASS-ID: mo00
Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH)
	with ESMTPSA id v0a34ev04NUe45p
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521
	ECDH
	bits, eq. 15360 bits RSA)) (Client did not present a certificate);
	Sat, 5 Jan 2019 00:30:40 +0100 (CET)
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 05 Jan 2019 00:30:39 +0100
Message-ID: <1742217.p5sQxCVaLy@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <5640e0dc-e97f-fc77-0087-9dbc8c506dc5@cs.ucla.edu>
References: <6639990.yRvKeTYcJc@omega>
	<CA+8g5KEe5CDHBKFqUgEUTV6saK2XDSn2_SVPQp_U53SRMABDWA@mail.gmail.com>
	<5640e0dc-e97f-fc77-0087-9dbc8c506dc5@cs.ucla.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#33965: bug#33965: handling of closed file
 descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 23:31:07 -0000

Sorry, Paul, but I have to vehemently disagree here. You are mixing
two different questions:
  (A) What is the best behaviour for a kernel?
  (B) What is the best behaviour for a program?

About (A):
> We should encourage platforms like HP-UX that try to work around the 
> trouble

The question is: Is it better for a kernel to be minimalist, hence
exec() does nothing special with the file descriptors? Or is it better
for a kernel to avoid pitfalls for programs, by protecting the first
3 file descriptors?

It is similar to the question: In the case of a signal delivery, should
a read() or write() system call return with a partial result or EINTR, or
should the kernel protect the programs from this knowledge and programming
overhead? This question was extensively discussed under the title
"worse is better", see
https://www.jwz.org/doc/worse-is-better.html
https://en.wikipedia.org/wiki/Worse_is_better

I have no personal opinion on this question.

About (B):
> I'd rather think of this as a bug in the test case, not a bug in 'diff'. 
Here I disagree.

* The majority of the uses of 'diff' and coreutils is through shell scripts.

* <&- and >&- are POSIX-standardized syntaxes in shell scripts for a long
  time.

* It is a goal to make the same shell script work the same way on different
  platforms. The user gains nothing if you tell them "your shell script
  works differently on Linux than on HP-UX because the kernel behaves
  slightly differently".

* Therefore the gnulib modules
    dirent-safer
    fcntl-safer
    fopen-safer
    freopen-safer
    openat-safer
    pipe2-safer
    popen-safer
    stdlib-safer
    tmpfile-safer
    unistd-safer
  serve a good purpose. They make programs running on Linux and
  programs running on HP-UX behave more similarly, which is a good thing.

> This is because the test case assumes more about the shell's "<&-" 
> construct than what POSIX requires.

It is like saying that it would be OK for a program, when interrupted
through Ctrl-Z and restarted through 'fg', to stop processing and exit
with a message "read: Interrupted system call". That's indeed how some
programs behaved around 1992: POSIX allowed the kernel to return from a
read() system call with errno = EINTR. But users don't want this. So it
was seen as a bug in the program, and fixed.

Same here.

Bruno





From MAILER-DAEMON Fri Jan 04 19:33:08 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfZtk-0007cN-R0
	for mharc-bug-diffutils@gnu.org; Fri, 04 Jan 2019 19:33:08 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:56732 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfZtj-0007cH-1i
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 19:33:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfZte-0001YV-3w
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 19:33:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42857)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfZtd-0001Y6-W7
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 19:33:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfZtd-0001ep-K0
	for bug-diffutils@gnu.org; Fri, 04 Jan 2019 19:33:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 05 Jan 2019 00:33:01 +0000
Resent-Message-ID: <handler.33965.B33965.15466483806362@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Bruno Haible <bruno@clisp.org>
Cc: 33965@debbugs.gnu.org, jim@meyering.net
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.15466483806362
	(code B ref 33965); Sat, 05 Jan 2019 00:33:01 +0000
Received: (at 33965) by debbugs.gnu.org; 5 Jan 2019 00:33:00 +0000
Received: from localhost ([127.0.0.1]:47131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfZtc-0001eY-5j
	for submit@debbugs.gnu.org; Fri, 04 Jan 2019 19:33:00 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57324)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eggert@cs.ucla.edu>) id 1gfZta-0001eI-Ak
	for 33965@debbugs.gnu.org; Fri, 04 Jan 2019 19:32:59 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1DF0B160F47;
	Fri,  4 Jan 2019 16:32:52 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id izH4715T2GGL; Fri,  4 Jan 2019 16:32:51 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 41AD5160F48;
	Fri,  4 Jan 2019 16:32:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id dUPc5aBw-bq7; Fri,  4 Jan 2019 16:32:51 -0800 (PST)
Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200])
	by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 252C9160F46;
	Fri,  4 Jan 2019 16:32:51 -0800 (PST)
References: <6639990.yRvKeTYcJc@omega>
	<CA+8g5KEe5CDHBKFqUgEUTV6saK2XDSn2_SVPQp_U53SRMABDWA@mail.gmail.com>
	<5640e0dc-e97f-fc77-0087-9dbc8c506dc5@cs.ucla.edu>
	<1742217.p5sQxCVaLy@omega>
From: Paul Eggert <eggert@cs.ucla.edu>
Openpgp: preference=signencrypt
Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata=
	xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9
	Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS
	96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl
	KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss
	mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK
	QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2
	Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC
	OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+
	KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB
	n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy
	dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG
	FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t
	nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr
	6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD
	0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH
	s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY
	0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu
	oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt
	N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl
	+G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu
	ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc
	1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6
	70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/
	IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r
	Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r
	FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO
	gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6
	6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA
	nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA
	77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G
	IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC
	AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs
	T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF
	/VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO
	FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD
	LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx
	c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc
	XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu
	5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB
	1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0
	q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b
	uNcby4U=
Organization: UCLA Computer Science Department
Message-ID: <d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
Date: Fri, 4 Jan 2019 16:32:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
	Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <1742217.p5sQxCVaLy@omega>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: bug#33965: handling of closed file
 descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2019 00:33:07 -0000

On 1/4/19 3:30 PM, Bruno Haible wrote:
>
>> the test case assumes more about the shell's "<&-"
>> construct than what POSIX requires.
> It is like saying that it would be OK for a program, when interrupted
> through Ctrl-Z and restarted through 'fg', to stop processing and exit
> with a message "read: Interrupted system call".

I don't see the analogy at all. Currently diffutils has a test shell 
script that is not portable POSIX code. Although we've worked around the 
problem with HP-UX by hacking on 'diff' itself, there are plausible 
POSIX platforms where our current hack will not work. It's not 
unreasonable to expect that test scripts should limit themselves to 
POSIX features so that they are as portable as reasonably possible.

> POSIX allowed the kernel to return from a
> read() system call with errno = EINTR. But users don't want this. So it
> was seen as a bug in the program, and fixed.

If by "users" you mean "programs that make system calls", then many 
users *do* want that. Certainly Emacs does, and I imagine many other 
programs do too. If you meant something else by "users" then I'm not 
sure I'm following the analogy.

For the stdin-is-closed situation, the users and developers of many (I 
would say most) applications do not want 'open' to hijack stdin. 
Although the HP-UX solution to this problem may not be best, it's better 
than the traditional behavior as it is a simple change to the kernel 
that fixes the issue for all applications, as opposed to the 
more-complicated dances we do in openat-safer and friends.

After thinking about this a bit more, the message that I'm getting from 
all this is that we should change diffutils to no longer rely on the 
"feature" that stdin is closed, and remove the test cases that attempt 
to test for this "feature". The feature is not portable to POSIX 
platforms. Besides, I doubt whether anybody is using the feature anyway. 
I put the feature in many years ago, so I can take the blame for 
introducing the misguided feature and the responsibility for taking it out.





From MAILER-DAEMON Sat Jan 05 04:42:10 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfiT4-0005uQ-5E
	for mharc-bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:42:10 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:51579 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiT1-0005st-P1
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:42:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiSw-0001zK-Qq
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:42:07 -0500
Received: from debbugsout.gnu.org ([209.51.188.43]:50456)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfiSw-0001y0-72
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiSw-0000Yz-0A
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:42:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Bruno Haible <bruno@clisp.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 05 Jan 2019 09:42:01 +0000
Resent-Message-ID: <handler.33965.B33965.15466812902122@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 33965@debbugs.gnu.org, jim@meyering.net
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.15466812902122
	(code B ref 33965); Sat, 05 Jan 2019 09:42:01 +0000
Received: (at 33965) by debbugs.gnu.org; 5 Jan 2019 09:41:30 +0000
Received: from localhost ([127.0.0.1]:47241 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfiSQ-0000YA-0U
	for submit@debbugs.gnu.org; Sat, 05 Jan 2019 04:41:30 -0500
Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.22]:18895)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <bruno@clisp.org>) id 1gfiSN-0000Xz-6r
	for 33965@debbugs.gnu.org; Sat, 05 Jan 2019 04:41:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546681285;
	s=strato-dkim-0002; d=clisp.org;
	h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:
	X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
	bh=yRwiNJEBgxBTEMLPMs3FMTpZgs78C0PCFq/AdqOFj+g=;
	b=UJRp/M1nR5Rkjn5nHM+Dv0B4mbYfZyw932kGM0aRGkNHUYTY2djIFb8wzRq2N/cH+c
	Ey6LffW3AMMBV4m25SKZVQ4NWkQgO+I34hklE/15FtNmTMFlAW7nZFWkjbJ2ZYP/TYhe
	NDjrZQpJ1K6Jov9NBbpmUaZXNW45tK+02PBhzNm5f6NohsUYZwZtu2BKMbu/5tgKjp7T
	DBR5z9NPta0JBKCNR9ysYYx5Egvm8Khhrt+YD/4bKflP55qkOvDmj2HL7rt/P4Gl+iRD
	dEk/ZpHwtb0gTrXDlWIdZMG8TKlt8zWNXFdcTuPvLQgwYP2iFsKmN/hSYblFBzhX6meK
	hkiA==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s="
X-RZG-CLASS-ID: mo00
Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH)
	with ESMTPSA id v0a34ev059fK5mW
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521
	ECDH
	bits, eq. 15360 bits RSA)) (Client did not present a certificate);
	Sat, 5 Jan 2019 10:41:20 +0100 (CET)
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 05 Jan 2019 10:41:20 +0100
Message-ID: <1637429.tjGFVHuugb@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
References: <6639990.yRvKeTYcJc@omega> <1742217.p5sQxCVaLy@omega>
	<d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#33965: bug#33965: handling of closed file
 descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2019 09:42:08 -0000

> > It is like saying that it would be OK for a program, when interrupted
> > through Ctrl-Z and restarted through 'fg', to stop processing and exit
> > with a message "read: Interrupted system call". ...
> > POSIX allowed the kernel to return from a
> > read() system call with errno = EINTR. But users don't want this. So it
> > was seen as a bug in the program, and fixed.
> 
> If by "users" you mean "programs that make system calls"

By "users don't want this" I meant: Users don't want programs to terminate
with an error message "read: Interrupted system call", just because they
used the job control features of the shell.

Bruno





From MAILER-DAEMON Sat Jan 05 04:45:08 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfiVw-0006eA-RW
	for mharc-bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:45:08 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:52365 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiVu-0006e4-Un
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:45:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiVq-0003im-11
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:45:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:38637)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfiVp-0003id-UI
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:45:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfiVp-0000di-Na
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 04:45:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Bruno Haible <bruno@clisp.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 05 Jan 2019 09:45:01 +0000
Resent-Message-ID: <handler.33965.B33965.15466814752405@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 33965@debbugs.gnu.org, bug-gnulib@gnu.org, jim@meyering.net
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.15466814752405
	(code B ref 33965); Sat, 05 Jan 2019 09:45:01 +0000
Received: (at 33965) by debbugs.gnu.org; 5 Jan 2019 09:44:35 +0000
Received: from localhost ([127.0.0.1]:47245 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfiVP-0000ci-EV
	for submit@debbugs.gnu.org; Sat, 05 Jan 2019 04:44:35 -0500
Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:35525)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <bruno@clisp.org>) id 1gfiVM-0000cW-Qo
	for 33965@debbugs.gnu.org; Sat, 05 Jan 2019 04:44:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546681471;
	s=strato-dkim-0002; d=clisp.org;
	h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:
	X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
	bh=BliwxpfNtROna93LCjH0ZPiEMNfrDkGbPhJVfB2NHhI=;
	b=i3PvrxvOlCw/1rX9sEDhFLT/sqfHKoe7wRQq0IY7rVvGLU87YRc+a2gdSSJ7kYIEwg
	zsHDojYaMuNQvzvaECSYF1F8lYdmTguNEb5uUUSV+1nmRDar0YgT5j6zE1o0/uIJjNMA
	/AXCC808N65qDVl399RTyV0Y4R5XtTWw43DbpDXGeyvlpcJ1MdzvvcjfBK+jYllvCU50
	yvI6rwDxfTmJsW4aZB3D/E1fPjqb0OSWRsRul0Km1JQs3aBW3eNnFy65+eIm0gltyL9b
	kjBbntDV4qY0L9FPahqz2LLp7Lxt3eJnV2HZk8dHO5OYWb5sQjEB2cd+q0JzE+mTTAjg
	xWRQ==
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s="
X-RZG-CLASS-ID: mo00
Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH)
	with ESMTPSA id v0a34ev059iI5mv
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521
	ECDH
	bits, eq. 15360 bits RSA)) (Client did not present a certificate);
	Sat, 5 Jan 2019 10:44:18 +0100 (CET)
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 05 Jan 2019 10:44:17 +0100
Message-ID: <2095398.ToFATaR5yE@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
References: <6639990.yRvKeTYcJc@omega> <1742217.p5sQxCVaLy@omega>
	<d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
Subject: [bug-diffutils] bug#33965: handling of closed file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2019 09:45:08 -0000

[CCing bug-gnulib. This is a followup to
 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33965 ]

Hi Paul,

> The feature is not portable to POSIX 
> platforms. Besides, I doubt whether anybody is using the feature anyway. 

OK, if you question the "feature" as a whole, then I'd say:

* Users don't *need* the "feature", in the sense that:
  - The normal way of invoking a program is by providing arguments
    and standard input/output streams. Users who want to invoke a program
    are not actively looking for this contorted way to invoke a program.
  - For most programs, equivalent functionality to the "feature" is available
    by passing an empty string, a reference to an empty file, or /dev/null
    as argument. If a program exists for which the equivalent functionality
    is not available through the normal way of invocation, the developers
    should better add it.

* But it's a security risk that a program can be invoked in ways in which it
  was surely never tested. Anything can happen then - from overwriting precious
  files of the user to endless loops.

* Therefore if you want to take out the "feature", you still have to think
  about how to mitigate the security risks.

  > Although the HP-UX solution to this problem may not be best, it's better 
  > than the traditional behavior as it is a simple change to the kernel 
  > that fixes the issue for all applications, as opposed to the 
  > more-complicated dances we do in openat-safer and friends.

  Given
    - the prevalent "worse is better" attitude,
    - the "never break userland behaviour that programs may rely upon"
      principle of the Linux kernel community,
    - the fact that the glibc people looked at the problem and used the
      HP-UX solution only for setuid programs,
  I predict that this "simple change to the kernel" will not make it into
  the majority of the operating systems in the next 10 years. (But you
  could start lobbying for it among the OpenBSD people. They would be the
  most likely to adopt it, I guess.)

  In the mean time, the remaining options I can see are:

    (a) Keep using the *-safer Gnulib modules.

    (b) Introduce a sanity_check_file_descriptors() function that all programs
        can invoke right at the beginning of main(), and that exits with an
        exit code if it detects a closed fd.

        void
        sanity_check_file_descriptors (void)
        {
          int fd;
          for (fd = 0; fd <= 2; fd++)
            if (fcntl (fd, F_GETFD, NULL) < 0 && errno == EBADF)
              exit (125);
        }

        On platforms like HP-UX, this code would not cause an exit, but
        the exec() call has already provided substitutes for the closed fds;
        this mitigates the security risks.
        I would propose exit code 125, since 127 and 126 are already taken [1].

  (b) surely is simpler than (a).

Bruno

[1] http://tldp.org/LDP/abs/html/exitcodes.html





From MAILER-DAEMON Sat Jan 05 23:08:13 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gfzjR-0007a1-7v
	for mharc-bug-diffutils@gnu.org; Sat, 05 Jan 2019 23:08:13 -0500
Received: from eggsout.gnu.org ([209.51.188.92]:60427 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfzjM-0007ZT-Lg
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 23:08:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfzjH-0001Cn-LO
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 23:08:08 -0500
Received: from debbugsout.gnu.org ([209.51.188.43]:55482)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfzjH-0001CZ-Ei
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 23:08:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfzjH-0004Gw-1F
	for bug-diffutils@gnu.org; Sat, 05 Jan 2019 23:08:03 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 06 Jan 2019 04:08:02 +0000
Resent-Message-ID: <handler.33965.B33965.154674762416355@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Bruno Haible <bruno@clisp.org>
Cc: 33965@debbugs.gnu.org, bug-gnulib@gnu.org, jim@meyering.net
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.154674762416355
	(code B ref 33965); Sun, 06 Jan 2019 04:08:02 +0000
Received: (at 33965) by debbugs.gnu.org; 6 Jan 2019 04:07:04 +0000
Received: from localhost ([127.0.0.1]:48195 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gfziJ-0004Fi-Cq
	for submit@debbugs.gnu.org; Sat, 05 Jan 2019 23:07:04 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60164)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eggert@cs.ucla.edu>) id 1gfziG-0004FB-Jg
	for 33965@debbugs.gnu.org; Sat, 05 Jan 2019 23:07:02 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id BFDDF160F7A;
	Sat,  5 Jan 2019 20:06:54 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id 3Y5CuZ_xeWQk; Sat,  5 Jan 2019 20:06:52 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 01BB4160F7D;
	Sat,  5 Jan 2019 20:06:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id xihQTv3G0ggy; Sat,  5 Jan 2019 20:06:51 -0800 (PST)
Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com
	[23.242.74.103])
	by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A3D2E160F46;
	Sat,  5 Jan 2019 20:06:51 -0800 (PST)
References: <6639990.yRvKeTYcJc@omega> <1742217.p5sQxCVaLy@omega>
	<d4d28d01-5433-4d39-a723-c41ae9edb1cb@cs.ucla.edu>
	<2095398.ToFATaR5yE@omega>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <e44b73f3-60dc-11cb-1187-5a5b76816881@cs.ucla.edu>
Date: Sat, 5 Jan 2019 20:06:51 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
	Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <2095398.ToFATaR5yE@omega>
Content-Type: multipart/mixed; boundary="------------34E9D1D1F5454BCC79E8AA56"
Content-Language: en-US
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#33965: handling of closed file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2019 04:08:11 -0000

This is a multi-part message in MIME format.
--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Bruno Haible wrote:

>> The feature is not portable to POSIX
>> platforms. Besides, I doubt whether anybody is using the feature anyway.
> 
> OK, if you question the "feature" as a whole,

Sorry, I was referring only to the never-used feature of diffutils, where "-" in 
a command-line argument stands for a missing file if stdin is closed (only in 
some cases, e.g., -N). I think nobody uses this feature or will miss it if it's 
removed, and anyway it can't work on some POSIX-conforming platforms. I put the 
feature into diffutils in many years ago, but it's now clear that the test case 
that is exercising it is a mistake and that the feature itself was mistaken.

But to broaden this to the more-general issue of whether kernels should force 
stdin/stdout/stderr to be open after an exec:

>    I predict that this "simple change to the kernel" will not make it into
>    the majority of the operating systems in the next 10 years. (But you
>    could start lobbying for it among the OpenBSD people. They would be the
>    most likely to adopt it, I guess.)

OpenBSD has already adopted it for setuid and setgid executables, as has 
FreeBSD, NetBSD, and SELinux. I imagine this feature is reasonably common 
elsewhere, at least for setuid (I haven't checked carefully). As far as I know 
only HP-UX does it for non-setuid/gid executables.

>    In the mean time, the remaining options I can see are:
> 
>      (a) Keep using the *-safer Gnulib modules.
> 
>      (b) Introduce a sanity_check_file_descriptors() function
 > ...
>          void
>          sanity_check_file_descriptors (void)
>          {
>            int fd;
>            for (fd = 0; fd <= 2; fd++)
>              if (fcntl (fd, F_GETFD, NULL) < 0 && errno == EBADF)
>                exit (125);
>          }
> ... 
>    (b) surely is simpler than (a).

I suggest instead a third option (c) that was formerly used in Coreutils, which 
is that the program makes sure that stdin/stdout/stderr are open before doing 
anything that creates a file descriptor. As I understand it Coreutils moved away 
from that approach primarily because it was redundant if the (earlier) *-safer 
modules are also used. However, in hindsight perhaps Coreutils should have 
stopped using the *-safer modules and just used method (c); it's a lot simpler 
and less intrusive.

I resurrected and refreshed that old Coreutils code and put it into a new Gnulib 
module stdopen, adjusted Gnulib's xfreopen module in a couple of minor ways 
(only diffutils uses xfreopen as far as I know) so that it no longer requires 
freopen-safer, and installed the first four attached patches into Gnulib. I then 
propagated this into diffutils and removed the unportable feature by installing 
the last three attached patches into diffutils.

As a result of these changes, diffutils no longer uses the *-safer modules (it 
uses the new stdopen module instead), it no longer supports the unportable 
feature in question, and it no longer mishandles some obscure situations where 
stdin, stdout, or stderr are closed.

--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0001-stdopen-copy-from-last-use-in-coreutils.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-stdopen-copy-from-last-use-in-coreutils.patch"

>From 14e1f1c39766bcb3fe4d6ec975ecac4058d11d98 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 11:02:51 -0800
Subject: [PATCH 1/4] stdopen: copy from last use in coreutils

* lib/stdopen.c, lib/stdopen.h, m4/stdopen.m4:
New files, taken from their last commit in coreutils
2007-07-23T12:35:58Z!jim@meyering.net
71aa3ea88084d17bcb4fc1031ad7b66f8647115e.
---
 ChangeLog     |  8 ++++++
 lib/stdopen.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/stdopen.h | 16 +++++++++++
 m4/stdopen.m4 | 13 +++++++++
 4 files changed, 111 insertions(+)
 create mode 100644 lib/stdopen.c
 create mode 100644 lib/stdopen.h
 create mode 100644 m4/stdopen.m4

diff --git a/ChangeLog b/ChangeLog
index d05cd8453..72d75ef26 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2019-01-05  Paul Eggert  <eggert@cs.ucla.edu>
+
+	stdopen: copy from last use in coreutils
+	* lib/stdopen.c, lib/stdopen.h, m4/stdopen.m4:
+	New files, taken from their last commit in coreutils
+	2007-07-23T12:35:58Z!jim@meyering.net
+	71aa3ea88084d17bcb4fc1031ad7b66f8647115e.
+
 2019-01-05  Bruno Haible  <bruno@clisp.org>
 
 	argp: Don't pass an invalid argument to dgettext().
diff --git a/lib/stdopen.c b/lib/stdopen.c
new file mode 100644
index 000000000..e9b554485
--- /dev/null
+++ b/lib/stdopen.c
@@ -0,0 +1,74 @@
+/* stdopen.c - ensure that the three standard file descriptors are in use
+
+   Copyright (C) 2005, 2006 Free Software Foundation, Inc.
+
+   This program is free software: you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation, either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+/* Written by Paul Eggert and Jim Meyering.  */
+
+#include <config.h>
+
+#include "stdopen.h"
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <errno.h>
+
+/* Try to ensure that all of the standard file numbers (0, 1, 2)
+   are in use.  Without this, each application would have to guard
+   every call to open, dup, fopen, etc. with tests to ensure they
+   don't use one of the special file numbers when opening a file.
+   Return false if at least one of the file descriptors is initially
+   closed and an attempt to reopen it fails.  Otherwise, return true.  */
+bool
+stdopen (void)
+{
+  int fd;
+  bool ok = true;
+
+  for (fd = 0; fd <= 2; fd++)
+    {
+      if (fcntl (fd, F_GETFD) < 0)
+	{
+	  if (errno != EBADF)
+	    ok = false;
+	  else
+	    {
+	      static const int contrary_mode[]
+		= { O_WRONLY, O_RDONLY, O_RDONLY };
+	      int mode = contrary_mode[fd];
+	      int new_fd;
+	      /* Open /dev/null with the contrary mode so that the typical
+		 read (stdin) or write (stdout, stderr) operation will fail.
+		 With descriptor 0, we can do even better on systems that
+		 have /dev/full, by opening that write-only instead of
+		 /dev/null.  The only drawback is that a write-provoked
+		 failure comes with a misleading errno value, ENOSPC.  */
+	      if (mode == O_RDONLY
+		  || (new_fd = open ("/dev/full", mode) != fd))
+		new_fd = open ("/dev/null", mode);
+	      if (new_fd != fd)
+		{
+		  if (0 <= new_fd)
+		    close (new_fd);
+		  ok = false;
+		}
+	    }
+	}
+    }
+
+  return ok;
+}
diff --git a/lib/stdopen.h b/lib/stdopen.h
new file mode 100644
index 000000000..d54e5f135
--- /dev/null
+++ b/lib/stdopen.h
@@ -0,0 +1,16 @@
+#ifndef STDOPEN_H
+# define STDOPEN_H 1
+
+# include <stdbool.h>
+
+# ifdef __cplusplus
+extern "C" {
+# endif
+
+bool stdopen (void);
+
+# ifdef __cplusplus
+}
+# endif
+
+#endif
diff --git a/m4/stdopen.m4 b/m4/stdopen.m4
new file mode 100644
index 000000000..b18c22ddf
--- /dev/null
+++ b/m4/stdopen.m4
@@ -0,0 +1,13 @@
+#serial 1
+dnl Copyright (C) 2005 Free Software Foundation, Inc.
+dnl This file is free software; the Free Software Foundation
+dnl gives unlimited permission to copy and/or distribute it,
+dnl with or without modifications, as long as this notice is preserved.
+
+AC_DEFUN([gl_STDOPEN],
+[
+  AC_LIBSOURCES([stdopen.c, stdopen.h])
+  AC_LIBOBJ([stdopen])
+
+  dnl Prerequisites.
+])
-- 
2.20.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0002-stdopen-modernize-and-simplify.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0002-stdopen-modernize-and-simplify.patch"

>From a4015f0453aeb60cfa70dcdfbd78db62b3a79b62 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 18:02:32 -0800
Subject: [PATCH 2/4] stdopen: modernize and simplify

* lib/stdopen.c: Update copyright date
Do not include sys/types.h; no longer needed these days.
(stdopen): Use C99-style decl in loop.  Return int errno
value, rather than just a bool.  Do not worry about fd mismatches,
since the caller cares only if 0, 1, 2 are occupied.
* lib/stdopen.h: No need to include <stdbool.h>.
* m4/stdopen.m4: Remove.
* modules/stdopen: New file.
---
 ChangeLog       | 10 ++++++++
 lib/stdopen.c   | 63 +++++++++++++++++++++----------------------------
 lib/stdopen.h   |  4 +---
 m4/stdopen.m4   | 13 ----------
 modules/stdopen | 24 +++++++++++++++++++
 5 files changed, 62 insertions(+), 52 deletions(-)
 delete mode 100644 m4/stdopen.m4
 create mode 100644 modules/stdopen

diff --git a/ChangeLog b/ChangeLog
index 72d75ef26..16ad6f169 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2019-01-05  Paul Eggert  <eggert@cs.ucla.edu>
 
+	stdopen: modernize and simplify
+	* lib/stdopen.c: Update copyright date
+	Do not include sys/types.h; no longer needed these days.
+	(stdopen): Use C99-style decl in loop.  Return int errno
+	value, rather than just a bool.  Do not worry about fd mismatches,
+	since the caller cares only if 0, 1, 2 are occupied.
+	* lib/stdopen.h: No need to include <stdbool.h>.
+	* m4/stdopen.m4: Remove.
+	* modules/stdopen: New file.
+
 	stdopen: copy from last use in coreutils
 	* lib/stdopen.c, lib/stdopen.h, m4/stdopen.m4:
 	New files, taken from their last commit in coreutils
diff --git a/lib/stdopen.c b/lib/stdopen.c
index e9b554485..3903224e6 100644
--- a/lib/stdopen.c
+++ b/lib/stdopen.c
@@ -1,6 +1,6 @@
 /* stdopen.c - ensure that the three standard file descriptors are in use
 
-   Copyright (C) 2005, 2006 Free Software Foundation, Inc.
+   Copyright (C) 2005-2006, 2019 Free Software Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -21,7 +21,6 @@
 
 #include "stdopen.h"
 
-#include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <unistd.h>
@@ -31,44 +30,36 @@
    are in use.  Without this, each application would have to guard
    every call to open, dup, fopen, etc. with tests to ensure they
    don't use one of the special file numbers when opening a file.
-   Return false if at least one of the file descriptors is initially
-   closed and an attempt to reopen it fails.  Otherwise, return true.  */
-bool
+   Return zero if successful, an errno value if at least one of
+   the file descriptors is initially closed and could not be opened.  */
+
+int
 stdopen (void)
 {
-  int fd;
-  bool ok = true;
-
-  for (fd = 0; fd <= 2; fd++)
+  for (int fd = STDIN_FILENO; fd <= STDERR_FILENO; fd++)
     {
       if (fcntl (fd, F_GETFD) < 0)
-	{
-	  if (errno != EBADF)
-	    ok = false;
-	  else
-	    {
-	      static const int contrary_mode[]
-		= { O_WRONLY, O_RDONLY, O_RDONLY };
-	      int mode = contrary_mode[fd];
-	      int new_fd;
-	      /* Open /dev/null with the contrary mode so that the typical
-		 read (stdin) or write (stdout, stderr) operation will fail.
-		 With descriptor 0, we can do even better on systems that
-		 have /dev/full, by opening that write-only instead of
-		 /dev/null.  The only drawback is that a write-provoked
-		 failure comes with a misleading errno value, ENOSPC.  */
-	      if (mode == O_RDONLY
-		  || (new_fd = open ("/dev/full", mode) != fd))
-		new_fd = open ("/dev/null", mode);
-	      if (new_fd != fd)
-		{
-		  if (0 <= new_fd)
-		    close (new_fd);
-		  ok = false;
-		}
-	    }
-	}
+        {
+          /* Open /dev/null with the contrary mode so that the typical
+             read (stdin) or write (stdout, stderr) operation will fail.
+             With descriptor 0, we can do even better on systems that
+             have /dev/full, by opening that write-only instead of
+             /dev/null.  The only drawback is that a write-provoked
+             failure comes with a misleading errno value, ENOSPC.  */
+          int mode = fd == STDIN_FILENO ? O_WRONLY : O_RDONLY;
+          int full_fd = fd == STDIN_FILENO ? open ("/dev/full", mode) : -1;
+          int new_fd = full_fd < 0 ? open ("/dev/null", mode) : full_fd;
+          if (new_fd < 0)
+            return errno;
+          if (STDERR_FILENO < new_fd)
+            {
+              /* 0, 1, and 2 are already open somehow.
+                 Our is not to reason why.  */
+              close (new_fd);
+              return 0;
+            }
+        }
     }
 
-  return ok;
+  return 0;
 }
diff --git a/lib/stdopen.h b/lib/stdopen.h
index d54e5f135..27901d397 100644
--- a/lib/stdopen.h
+++ b/lib/stdopen.h
@@ -1,13 +1,11 @@
 #ifndef STDOPEN_H
 # define STDOPEN_H 1
 
-# include <stdbool.h>
-
 # ifdef __cplusplus
 extern "C" {
 # endif
 
-bool stdopen (void);
+int stdopen (void);
 
 # ifdef __cplusplus
 }
diff --git a/m4/stdopen.m4 b/m4/stdopen.m4
deleted file mode 100644
index b18c22ddf..000000000
--- a/m4/stdopen.m4
+++ /dev/null
@@ -1,13 +0,0 @@
-#serial 1
-dnl Copyright (C) 2005 Free Software Foundation, Inc.
-dnl This file is free software; the Free Software Foundation
-dnl gives unlimited permission to copy and/or distribute it,
-dnl with or without modifications, as long as this notice is preserved.
-
-AC_DEFUN([gl_STDOPEN],
-[
-  AC_LIBSOURCES([stdopen.c, stdopen.h])
-  AC_LIBOBJ([stdopen])
-
-  dnl Prerequisites.
-])
diff --git a/modules/stdopen b/modules/stdopen
new file mode 100644
index 000000000..81de5765b
--- /dev/null
+++ b/modules/stdopen
@@ -0,0 +1,24 @@
+Description:
+Arrange for stdin/stdout/stderr to be open.
+
+Files:
+lib/stdopen.c
+lib/stdopen.h
+
+Depends-on:
+fcntl
+unistd
+
+configure.ac:
+
+Makefile.am:
+lib_SOURCES += stdopen.c
+
+Include:
+"stdopen.h"
+
+License:
+GPL
+
+Maintainer:
+all
-- 
2.20.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0003-xfreopen-need-not-depend-on-freopen-safer.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-xfreopen-need-not-depend-on-freopen-safer.patch"

>From f9d6fc71e4ebc142410352253fb1db337f530bdf Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 18:03:10 -0800
Subject: [PATCH 3/4] xfreopen need not depend on freopen-safer

* modules/xfreopen (Depends-on):
Depend on freopen, not freopen-safer.
---
 ChangeLog        | 4 ++++
 modules/xfreopen | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 16ad6f169..a88a52083 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2019-01-05  Paul Eggert  <eggert@cs.ucla.edu>
 
+	xfreopen need not depend on freopen-safer
+	* modules/xfreopen (Depends-on):
+	Depend on freopen, not freopen-safer.
+
 	stdopen: modernize and simplify
 	* lib/stdopen.c: Update copyright date
 	Do not include sys/types.h; no longer needed these days.
diff --git a/modules/xfreopen b/modules/xfreopen
index dcc48e0ac..850446d7a 100644
--- a/modules/xfreopen
+++ b/modules/xfreopen
@@ -8,7 +8,7 @@ lib/xfreopen.h
 Depends-on:
 error
 exitfail
-freopen-safer
+freopen
 quote
 
 configure.ac:
-- 
2.20.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0004-xfreopen-need-not-include-stdio-.h.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-xfreopen-need-not-include-stdio-.h.patch"

>From 10652b56fe5b76370187a06296168cff9cffb730 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 18:55:19 -0800
Subject: [PATCH 4/4] xfreopen need not include stdio--.h

* lib/xfreopen.c: Do not include stdio--.h.
---
 ChangeLog      | 3 +++
 lib/xfreopen.c | 1 -
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index a88a52083..73a86f29a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2019-01-05  Paul Eggert  <eggert@cs.ucla.edu>
 
+	xfreopen need not include stdio--.h
+	* lib/xfreopen.c: Do not include stdio--.h.
+
 	xfreopen need not depend on freopen-safer
 	* modules/xfreopen (Depends-on):
 	Depend on freopen, not freopen-safer.
diff --git a/lib/xfreopen.c b/lib/xfreopen.c
index 32a38d444..46a7c92a5 100644
--- a/lib/xfreopen.c
+++ b/lib/xfreopen.c
@@ -21,7 +21,6 @@
 #include "error.h"
 #include "exitfail.h"
 #include "quote.h"
-#include "stdio--.h"
 
 #include "gettext.h"
 #define _(msgid) gettext (msgid)
-- 
2.20.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0001-build-update-gnulib-submodule-to-latest.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-build-update-gnulib-submodule-to-latest.patch"

>From 1104d026514014808629f28f2e6c787bf3c520c4 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 18:05:33 -0800
Subject: [PATCH 1/3] build: update gnulib submodule to latest

---
 gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnulib b/gnulib
index 4652c7b..10652b5 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 4652c7bafa60332145f1e05a7de5f48e1bc56226
+Subproject commit 10652b56fe5b76370187a06296168cff9cffb730
-- 
2.17.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0002-diff-remove-unportable-diff-N-f-feature.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0002-diff-remove-unportable-diff-N-f-feature.patch"

>From 2c9d956aacdfddbb87334c985cd995d75102f789 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 19:20:11 -0800
Subject: [PATCH 2/3] =?UTF-8?q?diff:=20remove=20unportable=20=E2=80=98diff?=
 =?UTF-8?q?=20-N=20-=20f=20<&-=E2=80=99=20feature?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* NEWS: Mention this.
* bootstrap.conf (gnulib_modules): Add stdopen.
* doc/diffutils.texi (Comparing Directories):
Do not document behavior if stdin is closed.
* src/diff.c: Include stdopen.h.
(main): Call stdopen early.
(compare_files) [__hpux]: Remove recently-introduced
special case for HP-UX exec with stdin closed.
* tests/new-file: Remove tests of the removed feature.
---
 NEWS               |  9 +++++++++
 bootstrap.conf     |  1 +
 doc/diffutils.texi |  3 +--
 src/diff.c         | 11 ++++-------
 tests/new-file     | 14 --------------
 5 files changed, 15 insertions(+), 23 deletions(-)

diff --git a/NEWS b/NEWS
index d45d0fc..af675da 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,15 @@ GNU diffutils NEWS                                    -*- outline -*-
 
 * Noteworthy changes in release ?.? (????-??-??) [?]
 
+** Incompatible changes
+
+  diff no longer treats a closed stdin as representing an absent file
+  in usage like 'diff --new-file - foo <&-'.  This feature was rarely
+  if ever used and was not portable to POSIX platforms that reopen
+  stdin on exec, such as SELinux if the process underwent an AT_SECURE
+  transition, or HP-UX even if not setuid.
+  [bug#33965 introduced in 2.8]
+
 
 * Noteworthy changes in release 3.7 (2018-12-31) [stable]
 
diff --git a/bootstrap.conf b/bootstrap.conf
index 48cadd4..0c9fbfe 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -67,6 +67,7 @@ stat
 stat-macros
 stat-time
 stdint
+stdopen
 strcase
 strftime
 strptime
diff --git a/doc/diffutils.texi b/doc/diffutils.texi
index 42d3abd..3a780db 100644
--- a/doc/diffutils.texi
+++ b/doc/diffutils.texi
@@ -1796,8 +1796,7 @@ second position.)  To do this, use the @option{--new-file}
 (@option{-N}) option.  This option affects command-line arguments as
 well as files found via directory traversal; for example, @samp{diff
 -N a b} treats @file{a} as empty if @file{a} does not exist but
-@file{b} does, and similarly @samp{diff -N - b} treats standard input
-as empty if it is closed but @file{b} exists.
+@file{b} does.
 
 If the older directory contains large files that are not in
 the newer directory, you can make the patch smaller by using the
diff --git a/src/diff.c b/src/diff.c
index 2ed3ae5..a5ec7f4 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -37,6 +37,7 @@
 #include <progname.h>
 #include <sh-quote.h>
 #include <stat-time.h>
+#include <stdopen.h>
 #include <timespec.h>
 #include <version-etc.h>
 #include <xalloc.h>
@@ -297,6 +298,9 @@ main (int argc, char **argv)
   re_set_syntax (RE_SYNTAX_GREP | RE_NO_POSIX_BACKTRACKING);
   excluded = new_exclude ();
   presume_output_tty = false;
+  int stdopen_errno = stdopen ();
+  if (stdopen_errno != 0)
+    error (EXIT_TROUBLE, stdopen_errno, "standard file descriptors");
 
   /* Decode the options.  */
 
@@ -1172,13 +1176,6 @@ compare_files (struct comparison const *parent,
 	      cmp.file[f].desc = STDIN_FILENO;
 	      if (binary && ! isatty (STDIN_FILENO))
 		set_binary_mode (STDIN_FILENO, O_BINARY);
-#ifdef __hpux
-	      /* Recognize file descriptors closed by the parent on HP-UX.  */
-	      int flags = fcntl (STDIN_FILENO, F_GETFL, NULL);
-	      if (flags >= 0 && (flags & FD_CLOEXEC) != 0)
-		cmp.file[f].desc = ERRNO_ENCODE (EBADF);
-	      else
-#endif
 	      if (fstat (STDIN_FILENO, &cmp.file[f].stat) != 0)
 		cmp.file[f].desc = ERRNO_ENCODE (errno);
 	      else
diff --git a/tests/new-file b/tests/new-file
index 4400051..e3a61da 100755
--- a/tests/new-file
+++ b/tests/new-file
@@ -10,12 +10,6 @@ echo a > a || fail=1
 echo '0a1
 > a' > exp || fail=1
 
-returns_ 1 diff -N - a <&- > out || fail=1
-compare exp out || fail=1
-
-returns_ 1 diff --unidirectional-new-file - a <&- > out || fail=1
-compare exp out || fail=1
-
 returns_ 1 diff -N b - < a > out || fail=1
 compare exp out || fail=1
 
@@ -25,14 +19,6 @@ compare exp out || fail=1
 echo '1d0
 < a' > exp || fail=1
 
-returns_ 1 diff -N a - <&- > out || fail=1
-compare exp out || fail=1
-
-# With closed standard input, require an exit status of 2
-# and empty stdout.
-returns_ 2 diff --unidirectional-new-file a - <&- > out || fail=1
-compare /dev/null out || fail=1
-
 returns_ 1 diff -N - b < a > out || fail=1
 compare exp out || fail=1
 
-- 
2.17.1


--------------34E9D1D1F5454BCC79E8AA56
Content-Type: text/x-patch;
 name="0003-diff-fix-cmp-diff3-sdiff-with-stdin-closed.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-diff-fix-cmp-diff3-sdiff-with-stdin-closed.patch"

>From 601eceb57cfb87ded594701acc401277c53ff837 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 5 Jan 2019 19:55:08 -0800
Subject: [PATCH 3/3] diff: fix cmp, diff3, sdiff with stdin closed

* NEWS: Mention this.
* src/cmp.c, src/diff3.c, src/sdiff.c: Include stdopen.h.
(main): Call stdopen early.
* src/cmp.c (main): Simplify now that we need not worry about
stdin being closed.
* src/diff.c (main): Translate stdopen diagnostic.
---
 NEWS        |  8 ++++++++
 src/cmp.c   | 28 ++++++++++++++--------------
 src/diff.c  |  2 +-
 src/diff3.c |  4 ++++
 src/sdiff.c |  4 ++++
 5 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/NEWS b/NEWS
index af675da..9ab0748 100644
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,14 @@ GNU diffutils NEWS                                    -*- outline -*-
   transition, or HP-UX even if not setuid.
   [bug#33965 introduced in 2.8]
 
+** Bug fixes
+
+  diff and related programs no longer get confused if stdin, stdout,
+  or stderr are closed.  Previously, they sometimes opened files into
+  file descriptors 0, 1, or 2 and then mistakenly did I/O with them
+  that was intended for stdin, stdout, or stderr.
+  [bug#33965 present since "the beginning"]
+
 
 * Noteworthy changes in release 3.7 (2018-12-31) [stable]
 
diff --git a/src/cmp.c b/src/cmp.c
index 53ff210..7bad6dd 100644
--- a/src/cmp.c
+++ b/src/cmp.c
@@ -31,6 +31,7 @@
 #include <hard-locale.h>
 #include <inttostr.h>
 #include <progname.h>
+#include <stdopen.h>
 #include <unlocked-io.h>
 #include <version-etc.h>
 #include <xalloc.h>
@@ -199,7 +200,7 @@ GB 1,000,000,000, G 1,073,741,824, and so on for T, P, E, Z, Y."),
 int
 main (int argc, char **argv)
 {
-  int c, f, exit_status;
+  int c, exit_status;
   size_t words_per_buffer;
 
   exit_failure = EXIT_TROUBLE;
@@ -209,6 +210,9 @@ main (int argc, char **argv)
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (0);
+  int stdopen_errno = stdopen ();
+  if (stdopen_errno != 0)
+    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
 
   /* Parse command line options.  */
 
@@ -268,7 +272,7 @@ main (int argc, char **argv)
   file[0] = argv[optind++];
   file[1] = optind < argc ? argv[optind++] : "-";
 
-  for (f = 0; f < 2 && optind < argc; f++)
+  for (int f = 0; f < 2 && optind < argc; f++)
     {
       char *arg = argv[optind++];
       specify_ignore_initial (f, &arg, 0);
@@ -277,33 +281,29 @@ main (int argc, char **argv)
   if (optind < argc)
     try_help ("extra operand '%s'", argv[optind]);
 
-  for (f = 0; f < 2; f++)
+  for (int f = 0; f < 2; f++)
     {
-      /* If file[1] is "-", treat it first; this avoids a misdiagnostic if
-	 stdin is closed and opening file[0] yields file descriptor 0.  */
-      int f1 = f ^ (STREQ (file[1], "-"));
-
       /* Two files with the same name and offset are identical.
 	 But wait until we open the file once, for proper diagnostics.  */
       if (f && ignore_initial[0] == ignore_initial[1]
 	  && file_name_cmp (file[0], file[1]) == 0)
 	return EXIT_SUCCESS;
 
-      if (STREQ (file[f1], "-"))
+      if (STREQ (file[f], "-"))
 	{
-	  file_desc[f1] = STDIN_FILENO;
+	  file_desc[f] = STDIN_FILENO;
 	  if (O_BINARY && ! isatty (STDIN_FILENO))
 	    set_binary_mode (STDIN_FILENO, O_BINARY);
 	}
       else
-	file_desc[f1] = open (file[f1], O_RDONLY | O_BINARY, 0);
+	file_desc[f] = open (file[f], O_RDONLY | O_BINARY, 0);
 
-      if (file_desc[f1] < 0 || fstat (file_desc[f1], stat_buf + f1) != 0)
+      if (file_desc[f] < 0 || fstat (file_desc[f], stat_buf + f) != 0)
 	{
-	  if (file_desc[f1] < 0 && comparison_type == type_status)
+	  if (file_desc[f] < 0 && comparison_type == type_status)
 	    exit (EXIT_TROUBLE);
 	  else
-	    die (EXIT_TROUBLE, errno, "%s", file[f1]);
+	    die (EXIT_TROUBLE, errno, "%s", file[f]);
 	}
     }
 
@@ -361,7 +361,7 @@ main (int argc, char **argv)
 
   exit_status = cmp ();
 
-  for (f = 0; f < 2; f++)
+  for (int f = 0; f < 2; f++)
     if (close (file_desc[f]) != 0)
       die (EXIT_TROUBLE, errno, "%s", file[f]);
   if (exit_status != EXIT_SUCCESS && comparison_type < type_no_stdout)
diff --git a/src/diff.c b/src/diff.c
index a5ec7f4..d54782c 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -300,7 +300,7 @@ main (int argc, char **argv)
   presume_output_tty = false;
   int stdopen_errno = stdopen ();
   if (stdopen_errno != 0)
-    error (EXIT_TROUBLE, stdopen_errno, "standard file descriptors");
+    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
 
   /* Decode the options.  */
 
diff --git a/src/diff3.c b/src/diff3.c
index c7b2840..36bf4a6 100644
--- a/src/diff3.c
+++ b/src/diff3.c
@@ -30,6 +30,7 @@
 #include <file-type.h>
 #include <getopt.h>
 #include <progname.h>
+#include <stdopen.h>
 #include <system-quote.h>
 #include <version-etc.h>
 #include <xalloc.h>
@@ -272,6 +273,9 @@ main (int argc, char **argv)
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (0);
+  int stdopen_errno = stdopen ();
+  if (stdopen_errno != 0)
+    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
 
   while ((c = getopt_long (argc, argv, "aeimvx3AEL:TX", longopts, 0)) != -1)
     {
diff --git a/src/sdiff.c b/src/sdiff.c
index 25ce3fe..bbbe16c 100644
--- a/src/sdiff.c
+++ b/src/sdiff.c
@@ -32,6 +32,7 @@
 #include <file-type.h>
 #include <getopt.h>
 #include <progname.h>
+#include <stdopen.h>
 #include <system-quote.h>
 #include <version-etc.h>
 #include <xalloc.h>
@@ -455,6 +456,9 @@ main (int argc, char *argv[])
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (cleanup);
+  int stdopen_errno = stdopen ();
+  if (stdopen_errno != 0)
+    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
 
   prog = getenv ("EDITOR");
   if (prog)
-- 
2.17.1


--------------34E9D1D1F5454BCC79E8AA56--




From MAILER-DAEMON Sun Jan 06 20:48:06 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ggK1O-0006wM-3j
	for mharc-bug-diffutils@gnu.org; Sun, 06 Jan 2019 20:48:06 -0500
Received: from eggs.gnu.org ([209.51.188.92]:33530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggK1L-0006vr-PC
	for bug-diffutils@gnu.org; Sun, 06 Jan 2019 20:48:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggK1K-0003a5-Pp
	for bug-diffutils@gnu.org; Sun, 06 Jan 2019 20:48:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:48207)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ggK1K-0003Zj-M1
	for bug-diffutils@gnu.org; Sun, 06 Jan 2019 20:48:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggK1K-0008HX-8X
	for bug-diffutils@gnu.org; Sun, 06 Jan 2019 20:48:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 07 Jan 2019 01:48:02 +0000
Resent-Message-ID: <handler.33965.B33965.154682566431811@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 33965
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Bruno Haible <bruno@clisp.org>
Cc: 33965@debbugs.gnu.org, bug-gnulib@gnu.org
Received: via spool by 33965-submit@debbugs.gnu.org id=B33965.154682566431811
	(code B ref 33965); Mon, 07 Jan 2019 01:48:02 +0000
Received: (at 33965) by debbugs.gnu.org; 7 Jan 2019 01:47:44 +0000
Received: from localhost ([127.0.0.1]:47488 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1ggK12-0008Gz-C8
	for submit@debbugs.gnu.org; Sun, 06 Jan 2019 20:47:44 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36386)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eggert@cs.ucla.edu>) id 1ggK0z-0008Gm-Nx
	for 33965@debbugs.gnu.org; Sun, 06 Jan 2019 20:47:43 -0500
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 20C59160F77;
	Sun,  6 Jan 2019 17:47:36 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id rHeX63v--FhB; Sun,  6 Jan 2019 17:47:35 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by zimbra.cs.ucla.edu (Postfix) with ESMTP id 21980160F84;
	Sun,  6 Jan 2019 17:47:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
	by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id cofySn1O7GBc; Sun,  6 Jan 2019 17:47:35 -0800 (PST)
Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com
	[23.242.74.103])
	by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E7BFA160747;
	Sun,  6 Jan 2019 17:47:34 -0800 (PST)
References: <6639990.yRvKeTYcJc@omega> <2095398.ToFATaR5yE@omega>
	<e44b73f3-60dc-11cb-1187-5a5b76816881@cs.ucla.edu>
	<2029673.eREQEScGAn@omega>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <568450be-5ebc-b52b-f824-696aa9dc782d@cs.ucla.edu>
Date: Sun, 6 Jan 2019 17:47:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
	Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <2029673.eREQEScGAn@omega>
Content-Type: multipart/mixed; boundary="------------B073A92927AA86D4E38598FF"
Content-Language: en-US
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#33965: handling of closed file descriptors
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 01:48:04 -0000

This is a multi-part message in MIME format.
--------------B073A92927AA86D4E38598FF
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Thanks for the xstdopen module; it simplifies diffutils and I installed the 
attached patches there for it.

--------------B073A92927AA86D4E38598FF
Content-Type: text/x-patch;
 name="0001-build-update-gnulib-submodule-to-latest.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-build-update-gnulib-submodule-to-latest.patch"

>From 86ece0ee216910bce0dbceb60b98190bf8f93702 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 6 Jan 2019 17:15:06 -0800
Subject: [PATCH 1/2] build: update gnulib submodule to latest

---
 gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnulib b/gnulib
index 10652b5..8089c00 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 10652b56fe5b76370187a06296168cff9cffb730
+Subproject commit 8089c00979a5b089cff592c6b91420e595657167
-- 
2.17.1


--------------B073A92927AA86D4E38598FF
Content-Type: text/x-patch;
 name="0002-diff-use-xstdopen-not-stdopen.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0002-diff-use-xstdopen-not-stdopen.patch"

>From db6d5f7240c8a743aebb3def80b3e3fabf05f0c1 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 6 Jan 2019 17:22:37 -0800
Subject: [PATCH 2/2] diff: use xstdopen, not stdopen

* bootstrap.conf (gnulib_modules):
* src/cmp.c, src/diff.c, src/diff3.c, src/sdiff.c (main):
Use xstdopen, not stdopen.
---
 bootstrap.conf | 2 +-
 src/cmp.c      | 6 ++----
 src/diff.c     | 6 ++----
 src/diff3.c    | 6 ++----
 src/sdiff.c    | 6 ++----
 5 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 0c9fbfe..4671349 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -67,7 +67,6 @@ stat
 stat-macros
 stat-time
 stdint
-stdopen
 strcase
 strftime
 strptime
@@ -85,6 +84,7 @@ wcwidth
 xalloc
 xfreopen
 xreadlink
+xstdopen
 xstrtoumax
 xvasprintf
 '
diff --git a/src/cmp.c b/src/cmp.c
index 811d039..ce2bdb5 100644
--- a/src/cmp.c
+++ b/src/cmp.c
@@ -31,11 +31,11 @@
 #include <hard-locale.h>
 #include <inttostr.h>
 #include <progname.h>
-#include <stdopen.h>
 #include <unlocked-io.h>
 #include <version-etc.h>
 #include <xalloc.h>
 #include <binary-io.h>
+#include <xstdopen.h>
 #include <xstrtol.h>
 
 /* The official name of this program (e.g., no 'g' prefix).  */
@@ -210,9 +210,7 @@ main (int argc, char **argv)
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (0);
-  int stdopen_errno = stdopen ();
-  if (stdopen_errno != 0)
-    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
+  xstdopen ();
 
   /* Parse command line options.  */
 
diff --git a/src/diff.c b/src/diff.c
index 541d912..e9c2b11 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -37,11 +37,11 @@
 #include <progname.h>
 #include <sh-quote.h>
 #include <stat-time.h>
-#include <stdopen.h>
 #include <timespec.h>
 #include <version-etc.h>
 #include <xalloc.h>
 #include <xreadlink.h>
+#include <xstdopen.h>
 #include <binary-io.h>
 
 /* The official name of this program (e.g., no 'g' prefix).  */
@@ -298,9 +298,7 @@ main (int argc, char **argv)
   re_set_syntax (RE_SYNTAX_GREP | RE_NO_POSIX_BACKTRACKING);
   excluded = new_exclude ();
   presume_output_tty = false;
-  int stdopen_errno = stdopen ();
-  if (stdopen_errno != 0)
-    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
+  xstdopen ();
 
   /* Decode the options.  */
 
diff --git a/src/diff3.c b/src/diff3.c
index 8ce1a3d..037df25 100644
--- a/src/diff3.c
+++ b/src/diff3.c
@@ -30,11 +30,11 @@
 #include <file-type.h>
 #include <getopt.h>
 #include <progname.h>
-#include <stdopen.h>
 #include <system-quote.h>
 #include <version-etc.h>
 #include <xalloc.h>
 #include <xfreopen.h>
+#include <xstdopen.h>
 
 /* The official name of this program (e.g., no 'g' prefix).  */
 #define PROGRAM_NAME "diff3"
@@ -273,9 +273,7 @@ main (int argc, char **argv)
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (0);
-  int stdopen_errno = stdopen ();
-  if (stdopen_errno != 0)
-    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
+  xstdopen ();
 
   while ((c = getopt_long (argc, argv, "aeimvx3AEL:TX", longopts, 0)) != -1)
     {
diff --git a/src/sdiff.c b/src/sdiff.c
index 605fd33..2ef83da 100644
--- a/src/sdiff.c
+++ b/src/sdiff.c
@@ -32,10 +32,10 @@
 #include <file-type.h>
 #include <getopt.h>
 #include <progname.h>
-#include <stdopen.h>
 #include <system-quote.h>
 #include <version-etc.h>
 #include <xalloc.h>
+#include <xstdopen.h>
 
 /* The official name of this program (e.g., no 'g' prefix).  */
 #define PROGRAM_NAME "sdiff"
@@ -456,9 +456,7 @@ main (int argc, char *argv[])
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);
   c_stack_action (cleanup);
-  int stdopen_errno = stdopen ();
-  if (stdopen_errno != 0)
-    error (EXIT_TROUBLE, stdopen_errno, _("standard file descriptors"));
+  xstdopen ();
 
   prog = getenv ("EDITOR");
   if (prog)
-- 
2.17.1


--------------B073A92927AA86D4E38598FF--




From MAILER-DAEMON Wed Jan 30 12:39:05 2019
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1gotpJ-0006Lt-Mn
	for mharc-bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:39:05 -0500
Received: from eggs.gnu.org ([209.51.188.92]:39325)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gotpH-0006JV-4M
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:39:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gotpG-00010V-FK
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:39:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:52611)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gotpG-00010O-By
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:39:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gotpG-0001By-2r
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:39:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Peng Yu <pengyu.ut@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Wed, 30 Jan 2019 17:39:01 +0000
Resent-Message-ID: <handler.34259.B.15488699094534@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 34259
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 34259@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.15488699094534
	(code B ref -1); Wed, 30 Jan 2019 17:39:01 +0000
Received: (at submit) by debbugs.gnu.org; 30 Jan 2019 17:38:29 +0000
Received: from localhost ([127.0.0.1]:51892 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1gotoi-0001B3-U7
	for submit@debbugs.gnu.org; Wed, 30 Jan 2019 12:38:29 -0500
Received: from eggs.gnu.org ([209.51.188.92]:52911)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <pengyu.ut@gmail.com>) id 1gotog-0001Ao-QZ
	for submit@debbugs.gnu.org; Wed, 30 Jan 2019 12:38:27 -0500
Received: from lists.gnu.org ([209.51.188.17]:36281)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <pengyu.ut@gmail.com>) id 1gotob-0000iv-BR
	for submit@debbugs.gnu.org; Wed, 30 Jan 2019 12:38:21 -0500
Received: from eggs.gnu.org ([209.51.188.92]:39036)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1gotoa-0005oW-Bu
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:38:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1gotoV-0000hN-He
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:38:19 -0500
Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]:44567)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <pengyu.ut@gmail.com>) id 1gotoS-0000gI-38
	for bug-diffutils@gnu.org; Wed, 30 Jan 2019 12:38:13 -0500
Received: by mail-io1-xd2c.google.com with SMTP id r200so246471iod.11
	for <bug-diffutils@gnu.org>; Wed, 30 Jan 2019 09:38:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; 
	h=mime-version:from:date:message-id:subject:to;
	bh=dxHr/V5mDFN+BXRrgnvmisVZxtUscAbgHqhRfZurXL8=;
	b=Ri3mMU2z9y+b+cEShh1Qwh/+kk6MtOko/w3CvKwnMLWW1nmniLjyqQkhrWhDEghgwD
	Q0Wdf8BQszlnfGLl8ePRFw+tavo7XdlCuS0fo5zO1bsiZA3/t2P/aCp1FDQwJL1SppA3
	o2ky7UZlFPd+3qgZZquTxYczRljaZXvHut8kez2JUadkbuLh+JSZFEWcEPXwGLKZa3kt
	J2JgDzWuw/vyNBN7AKhd0CISU9raHVVzxCfQ+BYif0vvqFqUv0DmOeRwM0R6cnd194Bz
	fot2WNEBJbTPotqBgZGwDFIwgxL5x8DQzHhw4Qkp31pn//FXzAcIrUcdPr9grgbDnUAT
	JdUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
	bh=dxHr/V5mDFN+BXRrgnvmisVZxtUscAbgHqhRfZurXL8=;
	b=Gd115kHSFQXWwdjVYV5JzYHBJVghOfs77OaCYILYOCijWPZ+0ESemslDio3O4J7vaR
	qeuiA+EHgHizPtG7ZU0AN6dSZU2sp+9PM+ak74UbMGDFaaf6jM8IAWsa8AuocVyo/C3U
	Wpm7anU641A0ZkPLPpeHqCP5UGyTq35OUySf+RrIXd1tavA48OCJd3vCGVxka1W0V3xC
	ppQU0pY3z4wFECX+fQPyKgv6Z2VY3PbVaN4/42/P5BkbMe/fzS1O0Rq3BLDlSJtj8Ktj
	AJk/AxX2EquM1a5epYS4pQdYnpRS91hcgoA+oR6AFnNXKI4GoyTSchknS+vNzhfKI1wu
	NqKg==
X-Gm-Message-State: AHQUAua8goHHmxT3TY6+I2YjFKRdzV00htQuyTFdFmiN1+EO8i9FVcnp
	mrDOPw42k60unL0O+hEu2BybpNDlDVf2auPUpc6gX7RG
X-Google-Smtp-Source: ALg8bN6vi4NdHXQ/ZoEnXMv9cBwZ7x7vEqyATEMQYRtcazYnCqYJREh+crbqyoFWu+jO5n3qTVpp2q6+bcJpGDc2uQ8=
X-Received: by 2002:a6b:6a0a:: with SMTP id x10mr17935237iog.87.1548869888689; 
	Wed, 30 Jan 2019 09:38:08 -0800 (PST)
MIME-Version: 1.0
From: Peng Yu <pengyu.ut@gmail.com>
Date: Wed, 30 Jan 2019 11:37:57 -0600
Message-ID: <CABrM6wnThq+R8k9ZgJ07QbUHsC7_z=yF5WzzTUO=uxLSSavZJg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
Subject: [bug-diffutils] bug#34259: --*-line-format results are different
 from the default.
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-diffutils/>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
	<mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 17:39:04 -0000

Hi,

I'd expect only the new lines from the script2.txt should be printed
in the 2nd command. But somehow what it actually prints is not. The
test files are on the following URL. Could please let me know what is
wrong here? Thanks.

https://filebin.net/4hmuixxixarhfl1b

$  diff script[12].txt |head
186512a186513,186514
> internal_malloc    bb212    329    B>
> internal_malloc    bb212    333    B<
188481,188482d188482
< make_buffered_stream    bb38    60    B>
< make_buffered_stream    bb38    65    B<
189130a189131,189534
> set_line_mbstate    bb37    62    B>
> set_line_mbstate    bb37    66    B<
> set_line_mbstate    bb39    68    B>
$ diff --old-line-format=''  --new-line-format='>%L'
--unchanged-line-format=''  script[12].txt| head
>internal_malloc    bb212    329    B>
>internal_malloc    bb212    333    B<
>buffered_getchar    bb34    47    B>
>buffered_getchar    bb34    55    B<
>buffered_getchar    bb50    65    B>
>buffered_getchar    bb50    85    B<
>buffered_getchar    bb70    87    B>
>buffered_getchar    bb70    89    B<
>buffered_getchar    bb72    91    B>
>buffered_getchar    bb72    92    B<

-- 
Regards,
Peng




