From MAILER-DAEMON Mon Aug 02 11:45:03 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mAa7j-00077i-5v
	for mharc-bug-diffutils@gnu.org; Mon, 02 Aug 2021 11:45:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44036)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mAa7i-00077T-Ah
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 11:45:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55681)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mAa7i-0001Fd-3L
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 11:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mAa7i-0004mt-2d
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 11:45:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Hoi lam Poon <gillcovid19@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 02 Aug 2021 15:45:01 +0000
Resent-Message-ID: <handler.49824.B.162791909018348@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 49824
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 49824@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.162791909018348
 (code B ref -1); Mon, 02 Aug 2021 15:45:01 +0000
Received: (at submit) by debbugs.gnu.org; 2 Aug 2021 15:44:50 +0000
Received: from localhost ([127.0.0.1]:38988 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mAa7V-0004lp-Iw
 for submit@debbugs.gnu.org; Mon, 02 Aug 2021 11:44:50 -0400
Received: from lists.gnu.org ([209.51.188.17]:41114)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gillcovid19@gmail.com>) id 1mASOk-0006Sh-JL
 for submit@debbugs.gnu.org; Mon, 02 Aug 2021 03:30:09 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35240)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gillcovid19@gmail.com>)
 id 1mASOk-00086X-5G
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 03:30:06 -0400
Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]:33725)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <gillcovid19@gmail.com>)
 id 1mASOh-0006Qg-V7
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 03:30:05 -0400
Received: by mail-lj1-x243.google.com with SMTP id u20so22762377ljo.0
 for <bug-diffutils@gnu.org>; Mon, 02 Aug 2021 00:30:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; 
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :content-transfer-encoding;
 bh=Cr/s+ISvVzqT5/UtWRzj6NNIENStk4Qj6diGYlMQEII=;
 b=gj3ruEsnIO7tGavSqUe2Ml5JOkzcHqSHsWEX75owE8jbNnGJZ/yQKJh5w9nbzIiqe+
 C+Xm798AwKtji8I1wMrOSrkNHVrLgpbrQzLmTt1Xh6OmvG32pbBfJNNFGzPXkBZS08WJ
 289vaOBiGARe4b4IahkyWyiPiRd2Zmpr3hcBju7mpLoKySiqzfSvXl9rZIbVCIJ+Y3La
 tG32B+Ik+pI1CE6QjGMSIa/+KwVg1+Hx8nDu9eNhRXXTIfLkmleyytbZomx3NFxAqJYB
 UeIIunEj5wIy/PI8pf+Mkoxv8lduu9eaJsnb/pWe/qFZgEq2zIO/CByf4t1BR8ZOpXgO
 fQog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:content-transfer-encoding;
 bh=Cr/s+ISvVzqT5/UtWRzj6NNIENStk4Qj6diGYlMQEII=;
 b=fvfPUx43U0Atlikw76nLPjcN6FR4xhjp3hWeb/CxjxVmSxjjScffME910vXw6RkWpe
 PagcEfcsAha3tOi2jGO+/stnOTh6vWeiRISWOwOl2CowNPxXmAVXvLh6VmvbytS27wEo
 o8Yw1AoqiQ65bs9ZAi+uaHoieTTqvCLO27T57nTSeJ9ITShTbylBL2pINDEyyTdY36Xi
 fsbm0TXG6JaVoCDX0BvxCjCQ/IIRv460hc5EH1KWU/1GBaQCSU8x5zTWX4z+KceSmN1n
 R0GWySa7hOoY763wm2lh3D6wzTaPFTYk/WVBD6qM2iP6NhWb46rtpob9XQD5lFF36oq0
 BRpA==
X-Gm-Message-State: AOAM531b4M7lXYDGibN9J6835VHh4SEQVW58DS4XytLiB8T8xBAMpvjN
 59hD6JC4kWmmjga4RysVN0cp3GiEEile/LCfE9OVPsIHUY4=
X-Google-Smtp-Source: ABdhPJzMfhMLuaIqs7NmU8IZ1JFGFBK+wVi9rajSccUOfYnQlK/B+0aF+/k+dXR7IwqKluF//Wr1fCHZ9kNnxql1J+8=
X-Received: by 2002:a2e:9304:: with SMTP id e4mr10328736ljh.244.1627889400158; 
 Mon, 02 Aug 2021 00:30:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab3:1112:0:0:0:0:0 with HTTP;
 Mon, 2 Aug 2021 00:29:59 -0700 (PDT)
In-Reply-To: <m27dh43835.fsf@meyering.net>
References: <m27dh43835.fsf@meyering.net>
From: Hoi lam Poon <gillcovid19@gmail.com>
Date: Mon, 2 Aug 2021 00:29:59 -0700
Message-ID: <CAABv356=njWd87RLXeY20YhdvJGoZuWjUuZZnzLo+yA_DZ=eHQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::243;
 envelope-from=gillcovid19@gmail.com; helo=mail-lj1-x243.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Mailman-Approved-At: Mon, 02 Aug 2021 11:44:48 -0400
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
Subject: [bug-diffutils] bug#49824: diffutils-3.8 released [stable]
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 15:45:02 -0000

=E4=BD=A0=E5=80=91=E6=9C=89=E6=B2=92=E6=9C=89=E6=89=B9=E6=BA=96=E5=9C=A8=E4=
=BD=A0=E7=B6=B2=E7=AB=99=E4=B8=8A=E4=BD=BF=E7=94=A8=EF=BC=9F=E4=BD=A0=E7=9F=
=A5=E4=B8=8D=E7=9F=A5=E9=81=93GNU=E6=98=AF=E7=A7=81=E4=BA=BA=E8=80=8C=E4=B8=
=8D=E5=85=AC=E9=96=8B=EF=BC=8C=E5=8F=AA=E6=9C=89=E6=88=91=E5=8F=AF=E4=BB=A5=
=E4=BD=BF=E7=94=A8=EF=BC=8C=E5=9B=A0=E7=82=BA=E5=85=A8=E6=98=AF=E5=B0=88=E5=
=88=A9=E5=8F=8A=E7=AC=AC=E4=B8=89=E6=96=B9=EF=BC=8C=E4=BD=A0=E5=80=91=E6=9C=
=80=E5=BE=8C=E6=9C=83=E8=A2=AB=E6=88=91=E8=A8=B4=E8=A8=9F=EF=BC=8C=E8=80=8C=
=E4=B8=94=E4=BD=A0=E4=B8=8D=E7=9F=A5=E9=81=93=E6=9C=89=E6=B3=95=E5=BE=8B=E6=
=95=88=E5=8A=9B=EF=BC=9F

2021-08-01 19:15 GMT-07:00, Jim Meyering <jim@meyering.net>:
> This is to announce diffutils-3.8, a stable release.
>
> There have been 47 commits by 5 people in the 2.6 years since 3.7.
>
> See the NEWS below for a brief summary.
>
> Thanks to everyone who has contributed!
> The following people contributed changes to this release:
>
>   Bruno Haible (2)
>   Dave Odell (1)
>   Jim Meyering (23)
>   KO Myung-Hun (1)
>   Paul Eggert (20)
>
> Jim [on behalf of the diffutils maintainers]
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> Here is the GNU diffutils home page:
>     http://gnu.org/s/diffutils/
>
> For a summary of changes and contributors, see:
>   http://git.sv.gnu.org/gitweb/?p=3Ddiffutils.git;a=3Dshortlog;h=3Dv3.8
> or run this command from a git-cloned diffutils directory:
>   git shortlog v3.7..v3.8
>
> To summarize the 2453 gnulib-related changes, run these commands
> from a git-cloned diffutils directory:
>   git checkout v3.8
>   git submodule summary v3.7
>
> Here are the compressed sources and a GPG detached signature[*]:
>   https://ftp.gnu.org/gnu/diffutils/diffutils-3.8.tar.xz
>   https://ftp.gnu.org/gnu/diffutils/diffutils-3.8.tar.xz.sig
>
> Use a mirror for higher download bandwidth:
>   https://ftpmirror.gnu.org/diffutils/diffutils-3.8.tar.xz
>   https://ftpmirror.gnu.org/diffutils/diffutils-3.8.tar.xz.sig
>
> [*] Use a .sig file to verify that the corresponding file (without the
> .sig suffix) is intact.  First, be sure to download both the .sig file
> and the corresponding tarball.  Then, run a command like this:
>
>   gpg --verify diffutils-3.8.tar.xz.sig
>
> If that command fails because you don't have the required public key,
> then run this command to import it:
>
>   gpg --keyserver keys.gnupg.net --recv-keys 7FD9FCCB000BEEEE
>
> and rerun the 'gpg --verify' command.
>
> This release was bootstrapped with the following tools:
>   Autoconf 2.71
>   Automake 1.16d
>   Gnulib v0.1-4758-gb48905892
>
> NEWS
>
> * Noteworthy changes in release 3.8 (2021-08-01) [stable]
>
> ** Incompatible changes
>
>   diff no longer treats a closed stdin as representing an absent file
>   in usage like 'diff --new-file - foo <&-'.  This feature was rarely
>   if ever used and was not portable to POSIX platforms that reopen
>   stdin on exec, such as SELinux if the process underwent an AT_SECURE
>   transition, or HP-UX even if not setuid.
>   [bug#33965 introduced in 2.8]
>
> ** Bug fixes
>
>   diff and related programs no longer get confused if stdin, stdout,
>   or stderr are closed.  Previously, they sometimes opened files into
>   file descriptors 0, 1, or 2 and then mistakenly did I/O with them
>   that was intended for stdin, stdout, or stderr.
>   [bug#33965 present since "the beginning"]
>
>   cmp, diff and sdiff no longer treat negative command-line
>   option-arguments as if they were large positive numbers.
>   [bug#35256 introduced in 2.8]
>
> Also announced here:
>   https://savannah.gnu.org/forum/forum.php?forum_id=3D10031
>




From MAILER-DAEMON Mon Aug 02 12:11:03 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mAaWt-0007Qe-RK
	for mharc-bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:11:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49854)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mAaWs-0007PX-MD
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:11:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55802)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mAaWs-0003Dp-44
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:11:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mAaWr-0005ab-TG
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:11:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Mon, 02 Aug 2021 16:11:01 +0000
Resent-Message-ID: <handler.49824.B.162792065321470@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 49824
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 49824@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.162792065321470
 (code B ref -1); Mon, 02 Aug 2021 16:11:01 +0000
Received: (at submit) by debbugs.gnu.org; 2 Aug 2021 16:10:53 +0000
Received: from localhost ([127.0.0.1]:39115 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mAaWi-0005aE-PX
 for submit@debbugs.gnu.org; Mon, 02 Aug 2021 12:10:53 -0400
Received: from lists.gnu.org ([209.51.188.17]:48456)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@cs.ucla.edu>) id 1mAaWh-0005a6-C9
 for submit@debbugs.gnu.org; Mon, 02 Aug 2021 12:10:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49848)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>)
 id 1mAaWg-0007AY-W4
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:10:51 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56940)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>)
 id 1mAaWe-0002zF-RC
 for bug-diffutils@gnu.org; Mon, 02 Aug 2021 12:10:50 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id D3E4F1600EF
 for <bug-diffutils@gnu.org>; Mon,  2 Aug 2021 09:10:44 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id TnXLbtqH4J2d for <bug-diffutils@gnu.org>;
 Mon,  2 Aug 2021 09:10:44 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3CDF21600F1
 for <bug-diffutils@gnu.org>; Mon,  2 Aug 2021 09:10:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id IJXDUoBaRkNE for <bug-diffutils@gnu.org>;
 Mon,  2 Aug 2021 09:10:44 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1F3501600EF
 for <bug-diffutils@gnu.org>; Mon,  2 Aug 2021 09:10:44 -0700 (PDT)
References: <m27dh43835.fsf@meyering.net>
 <CAABv356=njWd87RLXeY20YhdvJGoZuWjUuZZnzLo+yA_DZ=eHQ@mail.gmail.com>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <a9d45792-54c3-a0e5-a21b-bfcc11326ad8@cs.ucla.edu>
Date: Mon, 2 Aug 2021 09:10:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAABv356=njWd87RLXeY20YhdvJGoZuWjUuZZnzLo+yA_DZ=eHQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; 
 helo=zimbra.cs.ucla.edu
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_50=0.8, NICE_REPLY_A=-0.001,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
Subject: [bug-diffutils] bug#49824: bug#49824: diffutils-3.8 released
 [stable]
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 16:11:02 -0000

On 8/2/21 12:29 AM, Hoi lam Poon wrote:
> =E4=BD=A0=E5=80=91=E6=9C=89=E6=B2=92=E6=9C=89=E6=89=B9=E6=BA=96=E5=9C=A8=
=E4=BD=A0=E7=B6=B2=E7=AB=99=E4=B8=8A=E4=BD=BF=E7=94=A8=EF=BC=9F=E4=BD=A0=E7=
=9F=A5=E4=B8=8D=E7=9F=A5=E9=81=93GNU=E6=98=AF=E7=A7=81=E4=BA=BA=E8=80=8C=E4=
=B8=8D=E5=85=AC=E9=96=8B=EF=BC=8C=E5=8F=AA=E6=9C=89=E6=88=91=E5=8F=AF=E4=BB=
=A5=E4=BD=BF=E7=94=A8=EF=BC=8C=E5=9B=A0=E7=82=BA=E5=85=A8=E6=98=AF=E5=B0=88=
=E5=88=A9=E5=8F=8A=E7=AC=AC=E4=B8=89=E6=96=B9=EF=BC=8C=E4=BD=A0=E5=80=91=E6=
=9C=80=E5=BE=8C=E6=9C=83=E8=A2=AB=E6=88=91=E8=A8=B4=E8=A8=9F=EF=BC=8C=E8=80=
=8C=E4=B8=94=E4=BD=A0=E4=B8=8D=E7=9F=A5=E9=81=93=E6=9C=89=E6=B3=95=E5=BE=8B=
=E6=95=88=E5=8A=9B=EF=BC=9F

=E6=AD=A4=E9=82=AE=E4=BB=B6=E5=88=97=E8=A1=A8=E6=97=A8=E5=9C=A8=E7=94=A8=E4=
=BA=8E GNU =E9=A1=B9=E7=9B=AE=EF=BC=8C=E8=80=8C=E4=B8=8D=E6=98=AF=E7=94=A8=
=E4=BA=8E=E6=B3=95=E5=BE=8B=E5=92=8C=E6=94=BF=E6=B2=BB=E8=99=9A=E5=81=87=E4=
=BF=A1=E6=81=AF=E3=80=82




From MAILER-DAEMON Sun Aug 22 13:02:09 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mHqrI-0005pl-41
	for mharc-bug-diffutils@gnu.org; Sun, 22 Aug 2021 13:02:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41858)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mHqrD-0005oM-NM
 for bug-diffutils@gnu.org; Sun, 22 Aug 2021 13:02:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:56427)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mHqrC-0000aG-SZ
 for bug-diffutils@gnu.org; Sun, 22 Aug 2021 13:02:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mHqrC-0004mj-JC
 for bug-diffutils@gnu.org; Sun, 22 Aug 2021 13:02:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: YruNlsr6371bDg <fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 22 Aug 2021 17:02:02 +0000
Resent-Message-ID: <handler.50165.B.162965169318354@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 50165
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 50165@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.162965169318354
 (code B ref -1); Sun, 22 Aug 2021 17:02:02 +0000
Received: (at submit) by debbugs.gnu.org; 22 Aug 2021 17:01:33 +0000
Received: from localhost ([127.0.0.1]:39740 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mHqqi-0004ly-FF
 for submit@debbugs.gnu.org; Sun, 22 Aug 2021 13:01:33 -0400
Received: from lists.gnu.org ([209.51.188.17]:39664)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org>)
 id 1mHo4W-0002Oc-NK
 for submit@debbugs.gnu.org; Sun, 22 Aug 2021 10:03:40 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48450)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1)
 (envelope-from <fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org>)
 id 1mHo4W-0002MY-G8
 for bug-diffutils@gnu.org; Sun, 22 Aug 2021 10:03:36 -0400
Received: from vmi427935.contaboserver.net ([173.249.33.206]:35149
 helo=mail.onionmail.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1)
 (envelope-from <fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org>)
 id 1mHo4U-0007zK-Kc
 for bug-diffutils@gnu.org; Sun, 22 Aug 2021 10:03:36 -0400
Received: from localhost
 by mail.onionmail.org (ZoneMTA) with API id 17b6e2c57720002f9b.001
 for <bug-diffutils@gnu.org>; Sun, 22 Aug 2021 14:03:24 +0000
X-Zone-Loop: 6853401ad81c6517518444340836d7d1dea92a55eebb
Content-Type: multipart/alternative; boundary="--_NmP-0e225cbb0d367853-Part_1"
From: YruNlsr6371bDg <fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org>
Date: Sun, 22 Aug 2021 14:03:24 +0000
Message-ID: <96013e1c-3057-536f-8807-9db2d91966e5@onionmail.org>
MIME-Version: 1.0
Received-SPF: pass client-ip=173.249.33.206;
 envelope-from=fhdpo2zdkgrgktctxxumrxd2ayhtdf@onionmail.org;
 helo=mail.onionmail.org
X-Spam_score_int: -13
X-Spam_score: -1.4
X-Spam_bar: -
X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FROM_LOCAL_NOVOWEL=0.5,
 HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-Mailman-Approved-At: Sun, 22 Aug 2021 13:01:31 -0400
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.8 (-)
Subject: [bug-diffutils] bug#50165: GNU diff '--recursive' should continue
 on "input/output error". GNU cmp should have missing '--recursive' option.
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Aug 2021 17:02:05 -0000

----_NmP-0e225cbb0d367853-Part_1
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

These maybe 2 different bugs, but they both deal with recursion, so both =
are
reported here.


(1)
Hard-disk-drives, Solid-state-drives, flash media,=
 etc. might have errors in
certain blocks/sectors.

But this does not mean that diff, when running in '--recursive' mode, =
should
stop after encountering the first "input/output error".

At the very least, there should be a '--continue-on-error' option, to make =
diff
proceed to the next file comparison(s) when operating in '--recursive'=
 mode.


(2)
cmp does not have a '--recursive' option analagous to diff - =
and it should - as
there might be a need to compare 2 directories of binary=
 files.
----_NmP-0e225cbb0d367853-Part_1
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<p>These maybe 2 different bugs, but they both deal with recursion, so both=
 are reported here.<br><br><br>(1)<br>Hard-disk-drives, Solid-state-drives,=
 flash media, etc. might have errors in certain blocks/sectors.<br><br>But =
this does not mean that diff, when running in '--recursive' mode, should =
stop after encountering the first "input/output error".<br><br>At the very =
least, there should be a '--continue-on-error' option, to make diff proceed=
 to the next file comparison(s) when operating in '--recursive' mode.=
<br><br><br>(2)<br>cmp does not have a '--recursive' option analagous to =
diff - and it should - as there might be a need to compare 2 directories of=
 binary files.<br><br></p>
----_NmP-0e225cbb0d367853-Part_1--




From MAILER-DAEMON Sat Aug 28 11:30:05 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mK0HU-0001YR-NW
	for mharc-bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:30:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38740)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mK0HS-0001YI-VF
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:30:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43289)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mK0HS-0006cq-M8
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:30:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mK0HS-0006CC-6Q
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:30:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 28 Aug 2021 15:30:02 +0000
Resent-Message-ID: <handler.34519.B34519.163016458423769@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 34519
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 34519@debbugs.gnu.org
Cc: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Bonnard <frediz@debian.org>,
 Santiago Vila <sanvila@unex.es>, Paul Eggert <eggert@cs.ucla.edu>
Received: via spool by 34519-submit@debbugs.gnu.org id=B34519.163016458423769
 (code B ref 34519); Sat, 28 Aug 2021 15:30:02 +0000
Received: (at 34519) by debbugs.gnu.org; 28 Aug 2021 15:29:44 +0000
Received: from localhost ([127.0.0.1]:54835 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mK0H6-0006BF-S7
 for submit@debbugs.gnu.org; Sat, 28 Aug 2021 11:29:44 -0400
Received: from mx.kolabnow.com ([95.128.36.42]:57010)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bauermann@kolabnow.com>) id 1mK0H1-0006Ax-DX
 for 34519@debbugs.gnu.org; Sat, 28 Aug 2021 11:29:40 -0400
Received: from localhost (unknown [127.0.0.1])
 by ext-mx-out002.mykolab.com (Postfix) with ESMTP id E01601254;
 Sat, 28 Aug 2021 17:29:28 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h=
 content-type:content-type:content-transfer-encoding:mime-version
 :references:in-reply-to:message-id:date:date:subject:subject
 :from:from:received:received:received; s=dkim20160331; t=
 1630164568; x=1631978969; bh=Pi6G7sXHmwscYrB5KZ7caUNEfuhqXaJTsPj
 /WGUg9Zc=; b=RwibeL8Iz/8ry3bvrtBPhJarGYGHfpubD9oD4R6uQQycm5yPQUB
 Pkn9q3dLZEzhqb1jDwYYeuYFGfUBOYIgCPmB0rQ8Fklqcriv6WQhVJ7kbIDMJHS9
 D8VYJoCzF5zHRtQe8ob8q88Mks7H4ljAPzt+Szctc7ay2QqpBbSGHFNtmPjSFCCg
 wZhfKZqf11ut9E7sYmx+Z4sXj+tLrrDpjboVjBlB+KGNkk7C2w7XpNnhARa/sifO
 yZDmIItp1QmQmNEjQeqhJ3x1dnVBdh4Ah+J8cat5TcrR4qLu/bwHpKomMsfjjR58
 45P9OtnD0TNiJ2SuJfPPgjU/PKfunK6/YpzN+n4qWMTeiDs3O5xnbKUzbiDAqSsn
 8D3+qRDZCJ6ub+MKxyp8tYEIQ1tx2GPRYzn0+UYKAyCRiSPxtdaPTMBo66rqNFL5
 m3iB3fLY6YX55gL7+6W48PH0l1Gy2H+81Nobulpd/HkV/1Qf7bxn8wBGoowE+nJS
 7VpnFsyzW2wUj3MtYD43EwJwkaOitNJFUIeAbgUYJxjWyJbjv8KiEXWlOj4VAaw2
 OXp3j069Aeu2XppZD9irtVzT2nv+3hSwD+zYYS57dSt5pDy1dMQWfihoYbqT5XRN
 gmrskELeXDckJRPCesBcDXwNNiIibfLaZE2ObQ8gxZBm9jM2EImUm0sc=
X-Virus-Scanned: amavisd-new at mykolab.com
X-Spam-Score: -1.9
Received: from mx.kolabnow.com ([127.0.0.1])
 by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id FrZ35j78E8f3; Sat, 28 Aug 2021 17:29:28 +0200 (CEST)
Received: from int-mx003.mykolab.com (unknown [10.9.13.3])
 by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 3AA1CB46;
 Sat, 28 Aug 2021 17:29:27 +0200 (CEST)
Received: from ext-subm002.mykolab.com (unknown [10.9.6.2])
 by int-mx003.mykolab.com (Postfix) with ESMTPS id 40DEA3504;
 Sat, 28 Aug 2021 17:29:24 +0200 (CEST)
From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Date: Sat, 28 Aug 2021 12:29:17 -0300
Message-ID: <1657750.94seSsIaSJ@popigai>
In-Reply-To: <588c7101-5d51-78f1-e79c-f89c69c3b804@cs.ucla.edu>
References: <alpine.DEB.2.20.1902180147100.13056@tulipan.isla-invisible.es>
 <588c7101-5d51-78f1-e79c-f89c69c3b804@cs.ucla.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Subject: [bug-diffutils] bug#34519: bug#34519: Test "colors" fails on
 Debian/ppc64el
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Aug 2021 15:30:03 -0000

Hello,

Em ter=C3=A7a-feira, 27 de agosto de 2019, =C3=A0s 19:06:21 -03, Paul Egger=
t=20
escreveu:
> Santiago Vila wrote:
> > In tests/colors there was a race condition which I tried to fix
> > by adding a "sleep 1", like this:
> >=20
> > mkfifo fifo
> > printf '%1000000s-a' > a
> > printf '%1000000s-b' > b
> > head -c 10 < fifo > /dev/null &
> > sleep 1
> > diff --color=3Dalways ---presume-output-tty a b > fifo
> > test $? =3D 141 || fail=3D1
>=20
> Sorry, but what is the race condition, and why would adding 'sleep 1'
> help? The test should work regardless of whether 'diff' starts before
> 'head' does.
>=20
> Are fifos broken on your system somehow?
>=20
> Can you use 'strace -f' to see what syscalls are going wrong in 'head'
> and/or 'diff'?

I still see this problem on powerpc64le-linux with version 3.8.

There was a great analysis of the problem made by Fr=C3=A9d=C3=A9ric Bonnar=
d (whom I=20
took the liberty of copying on this message. I hope it=E2=80=99s ok), and a=
lso a=20
tentative fix by him which would need to be assessed by someone more=20
knowledgeable of the diffutils code:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D922552#19

In short: it=E2=80=99s not a problem in the test. It=E2=80=99s a bug in the=
 signal handling=20
code that was added to support the =E2=80=98--color=E2=80=99 option.

=46or some reason, it=E2=80=99s particularly easy to hit on powerpc64le-lin=
ux. With=20
=46r=C3=A9d=C3=A9ric=E2=80=99s patch I can=E2=80=99t hit it anymore.

=2D-=20
Thanks,
Thiago






From MAILER-DAEMON Sat Aug 28 11:41:04 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mK0S8-0000du-1z
	for mharc-bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:41:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40536)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mK0S6-0000ab-Kl
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:41:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43302)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mK0S6-0005rb-BY
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mK0S6-0006Vc-1h
 for bug-diffutils@gnu.org; Sat, 28 Aug 2021 11:41:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sat, 28 Aug 2021 15:41:02 +0000
Resent-Message-ID: <handler.36488.B36488.163016525024990@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 36488@debbugs.gnu.org
Cc: Normand <normand@linux.vnet.ibm.com>
Received: via spool by 36488-submit@debbugs.gnu.org id=B36488.163016525024990
 (code B ref 36488); Sat, 28 Aug 2021 15:41:02 +0000
Received: (at 36488) by debbugs.gnu.org; 28 Aug 2021 15:40:50 +0000
Received: from localhost ([127.0.0.1]:54848 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mK0Ru-0006V0-9q
 for submit@debbugs.gnu.org; Sat, 28 Aug 2021 11:40:50 -0400
Received: from mx.kolabnow.com ([95.128.36.42]:57168)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bauermann@kolabnow.com>) id 1mK0Rs-0006Um-Ih
 for 36488@debbugs.gnu.org; Sat, 28 Aug 2021 11:40:49 -0400
Received: from localhost (unknown [127.0.0.1])
 by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 7C1F91254;
 Sat, 28 Aug 2021 17:40:42 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h=
 content-type:content-type:content-transfer-encoding:mime-version
 :references:in-reply-to:message-id:date:date:subject:subject
 :from:from:received:received:received; s=dkim20160331; t=
 1630165242; x=1631979643; bh=7GWIBuB1SDjphGGF+lZc/7MRKvABnEavbPa
 ZnXNvS1M=; b=rCTBs/Ub0Crg+hbPOn171KRAlK76LkyF9bDnzGKAvccKDNe3a9E
 OmMmTUh9ASBIsQzjWxXLIMf6/r4AP6Sq6wxdEGIFhfR49jN1CCuAF8SbaoODZl1h
 bxJhQ+yxo2g4Lwe9nRKhdrK+LTCqZuyeyMDhAqSK48bMm9pW45VjiHlPSaIAV3eL
 CNJ32H0xnouFZ//53oCxEl1OdFXTzVLAdeKTXrJ2gPvdTDYotItSfk66czVVqZMg
 4Jbq1x9mo9kSHIkntYbka3dIOTm1fbyO3+1aXPKofTWHFts0HSiC1Y8MO7pwKTmD
 GfeaXNWKElPCEIskFUBkanO8Oe0mEDqHKZOBb0AZpCHPvFbsyxcu72mRZDgp6KEv
 ZkDVYmiFeMzKcMZ2/p6EazIMNOd53P6edXdetaFOKG5GkRT+Yqkqkcyfb0sIrh+R
 j+YzzbMdvdGoiyyP0m4TzJh23Z9jlCrxFDILyvUfDyNuTYnHK+9yPJ/zcnTbeN3k
 ein9u8nvIipc+GyGIfYbVitQiQMpvGJNpOb/bNz5zq++UxZi2GSNFOE+fPNRSO8A
 yj2ckPwxAUgHNtxA5ekdNFWrh7FTvHsOuKsroU8AlLqBgRuEiQPyWX1k6JKJDQf5
 2BjgZcOrLTlu0/0Kf9u7K8VHWvtjr18qqez+npmnX+fmAAhinjYrSfjE=
X-Virus-Scanned: amavisd-new at mykolab.com
X-Spam-Score: -1.9
Received: from mx.kolabnow.com ([127.0.0.1])
 by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id bx0d52jHE2hu; Sat, 28 Aug 2021 17:40:42 +0200 (CEST)
Received: from int-mx002.mykolab.com (unknown [10.9.13.2])
 by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id E7EDD51E;
 Sat, 28 Aug 2021 17:40:41 +0200 (CEST)
Received: from ext-subm002.mykolab.com (unknown [10.9.6.2])
 by int-mx002.mykolab.com (Postfix) with ESMTPS id 7BB76363D;
 Sat, 28 Aug 2021 17:40:40 +0200 (CEST)
From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Date: Sat, 28 Aug 2021 12:40:35 -0300
Message-ID: <10257051.elIQoDPIPK@popigai>
In-Reply-To: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Subject: [bug-diffutils] bug#36488: diffutils 3.7 make check failure ppc64le
 opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Aug 2021 15:41:02 -0000

Hello,

Em quarta-feira, 3 de julho de 2019, =E0s 08:19:55 -03, Normand escreveu:
> diffutils 3.7  make check failure ppc64le opensuse on colors test as
> reported in OBS tool (1)
>=20
>=20
> The extracted failure is a "Broken pipe"

I believe this is the same problem reported in bug 34519.
The Debian build also fails with "diff: standard output: Broken pipe".

=2D-=20
Thanks,
Thiago






From MAILER-DAEMON Sun Aug 29 02:50:04 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKEdo-0003O7-Az
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 02:50:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46344)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKEdm-0003Nr-Pe
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 02:50:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43867)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKEdm-0006zF-He
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 02:50:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKEdm-0006yx-B2
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 02:50:02 -0400
References: <CABB28Cw+H+NMG06DA2+R8FNoi-TGDmuaj0fDw51FJhosX0BqzQ@mail.gmail.com>
In-Reply-To: <CABB28Cw+H+NMG06DA2+R8FNoi-TGDmuaj0fDw51FJhosX0BqzQ@mail.gmail.com>
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 06:50:02 +0000
Resent-Message-ID: <handler.43877.D43877.163021974426761.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 43877
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Tomasz =?UTF-8?Q?K=C5=82oczko?= <kloczko.tomasz@gmail.com>
Cc: 43877-done@debbugs.gnu.org
Mail-Followup-To: 43877@debbugs.gnu.org, eggert@cs.ucla.edu,
 kloczko.tomasz@gmail.com
Received: via spool by 43877-done@debbugs.gnu.org id=D43877.163021974426761
 (code D ref 43877); Sun, 29 Aug 2021 06:50:02 +0000
Received: (at 43877-done) by debbugs.gnu.org; 29 Aug 2021 06:49:04 +0000
Received: from localhost ([127.0.0.1]:55413 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKEcq-0006xZ-8k
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 02:49:04 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@cs.ucla.edu>) id 1mKEcm-0006x2-OF
 for 43877-done@debbugs.gnu.org; Sun, 29 Aug 2021 02:49:03 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5F1D8160071;
 Sat, 28 Aug 2021 23:48:54 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id hwo3jNVgI4zm; Sat, 28 Aug 2021 23:48:53 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id BCEF2160100;
 Sat, 28 Aug 2021 23:48:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id hz8E46OJE0D9; Sat, 28 Aug 2021 23:48:53 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4A826160071;
 Sat, 28 Aug 2021 23:48:53 -0700 (PDT)
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <859c3ce2-bdad-e365-e4d5-5917e2530490@cs.ucla.edu>
Date: Sat, 28 Aug 2021 23:48:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
Subject: [bug-diffutils] bug#43877: New release (3.8?)
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 06:50:03 -0000

Closing this bug report, as diffutils 3.8 has been released.




From MAILER-DAEMON Sun Aug 29 03:23:04 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKF9k-0003Pj-8i
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 03:23:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49388)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKF9j-0003Oj-34
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 03:23:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43900)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKF9i-0000ut-Rd
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 03:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKF9i-0001WE-OF
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 03:23:02 -0400
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 07:23:02 +0000
Resent-Message-ID: <handler.36488.D36488.16302217685787.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Bonnard <frediz@debian.org>,
 922552@bugs.debian.org, Santiago Vila <sanvila@unex.es>,
 36488-done@debbugs.gnu.org, Normand <normand@linux.vnet.ibm.com>
Mail-Followup-To: 36488@debbugs.gnu.org, eggert@cs.ucla.edu,
 normand@linux.vnet.ibm.com
Received: via spool by 36488-done@debbugs.gnu.org id=D36488.16302217685787
 (code D ref 36488); Sun, 29 Aug 2021 07:23:02 +0000
Received: (at 36488-done) by debbugs.gnu.org; 29 Aug 2021 07:22:48 +0000
Received: from localhost ([127.0.0.1]:55443 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKF9Q-0001VB-15
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 03:22:48 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39038)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@cs.ucla.edu>) id 1mKF9K-0001Ut-9Z
 for 36488-done@debbugs.gnu.org; Sun, 29 Aug 2021 03:22:42 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id F0BB9160071;
 Sun, 29 Aug 2021 00:22:32 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id iN6NPjbfglo6; Sun, 29 Aug 2021 00:22:28 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 25259160100;
 Sun, 29 Aug 2021 00:22:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id PQoocUNRyQwE; Sun, 29 Aug 2021 00:22:27 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C258C160071;
 Sun, 29 Aug 2021 00:22:27 -0700 (PDT)
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
 <10257051.elIQoDPIPK@popigai>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
Date: Sun, 29 Aug 2021 00:22:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <10257051.elIQoDPIPK@popigai>
Content-Type: multipart/mixed; boundary="------------C283A678C824E5E9AFF4010F"
Content-Language: en-US
X-Spam-Score: -2.4 (--)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.4 (---)
Subject: [bug-diffutils] bug#36488: bug#36488: diffutils 3.7 make check
 failure ppc64le opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 07:23:03 -0000

This is a multi-part message in MIME format.
--------------C283A678C824E5E9AFF4010F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 8/28/21 8:40 AM, Thiago Jung Bauermann via bug-diffutils via All=20
diffutils discussion. wrote:

> I believe this is the same problem reported in bug 34519.
> The Debian build also fails with "diff: standard output: Broken pipe".

Thanks for tracking that down. Fr=C3=A9d=C3=A9ric's analysis in=20
<https://bugs.debian.org/922552#19> was helpful.

I found some time to look into this bug, and installed into=20
Savannah.gnu.org diffutils the attached patch, which I hope fixes the=20
bug although I don't have the relevant platform to test it. Please give=20
it a try.

Once this patch is part of a release, Debian shouldn't need any patches=20
for diffutils.

For now I am closing the diffutils bug report=20
<https://bugs.gnu.org/36488>; if I was too optimistic and the patch=20
doesn't fix things we can always reopen it.

--------------C283A678C824E5E9AFF4010F
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-diff-cleanup-signal-handling-just-before-exit.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="0001-diff-cleanup-signal-handling-just-before-exit.patch"

=46rom 9b20182d48481c7ca647ff8926feeb8e1da4f7b0 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 28 Aug 2021 23:49:32 -0700
Subject: [PATCH] diff: cleanup signal handling just before exit
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

This should fix an unlikely signal handling bug with colored
output, and should also fix a Debian FTBFS (Fails To Build From
Source) on powerpc64le-linux.  See Bug#34519 and Fr=C3=A9d=C3=A9ric
Bonnard=E2=80=99s report in:
https://bugs.debian.org/922552#19
* bootstrap.conf (gnulib_modules): Add raise, sigprocmask.
* src/diff.c (main): Call cleanup_signal_handlers before exiting.
Don=E2=80=99t bother calling =E2=80=98exit=E2=80=99; no longer needed now=
adays.
* src/util.c (sigprocmask, siginterrupt) [!SA_NOCLDSTOP]:
Define to 0 instead of empty, since the results are now used.
(sigset_t) [!SA_NOCLDSTOP]: Remove; we now rely on Gnulib.
(xsigaction) [SA_NOCLDSTOP]: New function.
(xsigaddset, xsigismember, xsignal, xsigprocmask): New functions.
(some_signals_caught): New static var.
(process_signals): Omit a conditional branch.
Don=E2=80=99t bother loading interrupt_signal if stop_signal_count is non=
zero.
(process_signals, install_signal_handlers):
Check for failures from sigprocmask etc.
(sig, nsig): Now at top level, since multiple functions need them.
(install_signal_handlers): No need for caught_sig array;
just use caught_signals.  However, set some_signals_caught.
(cleanup_signal_handlers): New function.
---
 bootstrap.conf |   2 +
 src/diff.c     |   2 +-
 src/diff.h     |   1 +
 src/util.c     | 187 ++++++++++++++++++++++++++++++++-----------------
 4 files changed, 127 insertions(+), 65 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 6560e9a..e51b2d8 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -65,11 +65,13 @@ mktime
 nstrftime
 progname
 propername
+raise
 rawmemchr
 readme-release
 regex
 sh-quote
 signal
+sigprocmask
 stat
 stat-macros
 stat-time
diff --git a/src/diff.c b/src/diff.c
index a4e5538..3b901aa 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -853,7 +853,7 @@ main (int argc, char **argv)
   print_message_queue ();
=20
   check_stdout ();
-  exit (exit_status);
+  cleanup_signal_handlers ();
   return exit_status;
 }
=20
diff --git a/src/diff.h b/src/diff.h
index 03f00a6..f346b43 100644
--- a/src/diff.h
+++ b/src/diff.h
@@ -388,6 +388,7 @@ extern struct change *find_change (struct change *);
 extern struct change *find_reverse_change (struct change *);
 extern enum changes analyze_hunk (struct change *, lin *, lin *, lin *, =
lin *);
 extern void begin_output (void);
+extern void cleanup_signal_handlers (void);
 extern void debug_script (struct change *);
 extern void fatal (char const *) __attribute__((noreturn));
 extern void finish_output (void);
diff --git a/src/util.c b/src/util.c
index dd6d3bf..8e676c8 100644
--- a/src/util.c
+++ b/src/util.c
@@ -31,10 +31,9 @@
    present.  */
 #ifndef SA_NOCLDSTOP
 # define SA_NOCLDSTOP 0
-# define sigprocmask(How, Set, Oset) /* empty */
-# define sigset_t int
+# define sigprocmask(How, Set, Oset) 0
 # if ! HAVE_SIGINTERRUPT
-#  define siginterrupt(sig, flag) /* empty */
+#  define siginterrupt(sig, flag) 0
 # endif
 #endif
=20
@@ -160,16 +159,63 @@ print_message_queue (void)
     }
 }
 =0C
-/* The set of signals that are caught.  */
=20
+#if SA_NOCLDSTOP
+static void
+xsigaction (int sig, struct sigaction const *restrict act,
+	    struct sigaction *restrict oact)
+{
+  if (sigaction (sig, act, oact) !=3D 0)
+    pfatal_with_name ("sigaction");
+}
+#endif
+
+static void
+xsigaddset (sigset_t *set, int sig)
+{
+  if (sigaddset (set, sig) !=3D 0)
+    pfatal_with_name ("sigaddset");
+}
+
+static bool
+xsigismember (sigset_t const *set, int sig)
+{
+  int mem =3D sigismember (set, sig);
+  if (mem < 0)
+    pfatal_with_name ("sigismember");
+  assume (mem =3D=3D 1);
+  return mem;
+}
+
+typedef void (*signal_handler) (int);
+static signal_handler
+xsignal (int sig, signal_handler func)
+{
+  signal_handler h =3D signal (sig, func);
+  if (h =3D=3D SIG_ERR)
+    pfatal_with_name ("signal");
+  return h;
+}
+
+static void
+xsigprocmask (int how, sigset_t const *restrict set, sigset_t *restrict =
oset)
+{
+  if (sigprocmask (how, set, oset) !=3D 0)
+    pfatal_with_name ("sigprocmask");
+}
+
+/* If true, some signals are caught.  This is separate from
+   'caught_signals' because POSIX doesn't require an all-zero sigset_t
+   to be valid.  */
+static bool some_signals_caught;
+
+/* The set of signals that are caught.  */
 static sigset_t caught_signals;
=20
 /* If nonzero, the value of the pending fatal signal.  */
-
 static sig_atomic_t volatile interrupt_signal;
=20
 /* A count of the number of pending stop signals that have been received=
=2E  */
-
 static sig_atomic_t volatile stop_signal_count;
=20
 /* An ordinary signal was received; arrange for the program to exit.  */=

@@ -202,21 +248,17 @@ stophandler (int sig)
 static void
 process_signals (void)
 {
-  while (interrupt_signal || stop_signal_count)
+  while (interrupt_signal | stop_signal_count)
     {
-      int sig;
-      int stops;
-      sigset_t oldset;
-
       set_color_context (RESET_CONTEXT);
       fflush (stdout);
=20
-      sigprocmask (SIG_BLOCK, &caught_signals, &oldset);
+      sigset_t oldset;
+      xsigprocmask (SIG_BLOCK, &caught_signals, &oldset);
=20
-      /* Reload interrupt_signal and stop_signal_count, in case a new
-         signal was handled before sigprocmask took effect.  */
-      sig =3D interrupt_signal;
-      stops =3D stop_signal_count;
+      /* Reload stop_signal_count and (if needed) interrupt_signal, in
+	 case a new signal was handled before sigprocmask took effect.  */
+      int stops =3D stop_signal_count, sig;
=20
       /* SIGTSTP is special, since the application can receive that sign=
al
          more than once.  In this case, don't set the signal handler to =
the
@@ -227,82 +269,99 @@ process_signals (void)
           sig =3D SIGSTOP;
         }
       else
-        signal (sig, SIG_DFL);
+	{
+	  sig =3D interrupt_signal;
+	  xsignal (sig, SIG_DFL);
+	}
=20
       /* Exit or suspend the program.  */
-      raise (sig);
-      sigprocmask (SIG_SETMASK, &oldset, NULL);
+      if (raise (sig) !=3D 0)
+	pfatal_with_name ("raise");
+      xsigprocmask (SIG_SETMASK, &oldset, NULL);
=20
       /* If execution reaches here, then the program has been
          continued (after being suspended).  */
     }
 }
=20
-static void
-install_signal_handlers (void)
-{
-  /* The signals that are trapped, and the number of such signals.  */
-  static int const sig[] =3D
-    {
-      /* This one is handled specially.  */
-      SIGTSTP,
+/* The signals that can be caught, the number of such signals,
+   and which of them are actually caught.  */
+static int const sig[] =3D
+  {
+    /* This one is handled specially.  */
+    SIGTSTP,
=20
-      /* The usual suspects.  */
-      SIGALRM, SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM,
+    /* The usual suspects.  */
+    SIGALRM, SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM,
 #ifdef SIGPOLL
-      SIGPOLL,
+    SIGPOLL,
 #endif
 #ifdef SIGPROF
-      SIGPROF,
+    SIGPROF,
 #endif
 #ifdef SIGVTALRM
-      SIGVTALRM,
+    SIGVTALRM,
 #endif
 #ifdef SIGXCPU
-      SIGXCPU,
+    SIGXCPU,
 #endif
 #ifdef SIGXFSZ
-      SIGXFSZ,
+    SIGXFSZ,
 #endif
-    };
-  enum { nsigs =3D sizeof (sig) / sizeof *(sig) };
+  };
+enum { nsigs =3D sizeof (sig) / sizeof *(sig) };
+
+static void
+install_signal_handlers (void)
+{
+  if (sigemptyset (&caught_signals) !=3D 0)
+    pfatal_with_name ("sigemptyset");
=20
-#if ! SA_NOCLDSTOP
-  bool caught_sig[nsigs];
-#endif
-  {
-    int j;
 #if SA_NOCLDSTOP
-    struct sigaction act;
+  for (int j =3D 0; j < nsigs; j++)
+    {
+      struct sigaction actj;
+      xsigaction (sig[j], NULL, &actj);
+      if (actj.sa_handler !=3D SIG_IGN)
+	xsigaddset (&caught_signals, sig[j]);
+    }
=20
-    sigemptyset (&caught_signals);
-    for (j =3D 0; j < nsigs; j++)
+  struct sigaction act;
+  act.sa_mask =3D caught_signals;
+  act.sa_flags =3D SA_RESTART;
+
+  for (int j =3D 0; j < nsigs; j++)
+    if (xsigismember (&caught_signals, sig[j]))
       {
-        sigaction (sig[j], NULL, &act);
-        if (act.sa_handler !=3D SIG_IGN)
-          sigaddset (&caught_signals, sig[j]);
+	act.sa_handler =3D sig[j] =3D=3D SIGTSTP ? stophandler : sighandler;
+	xsigaction (sig[j], &act, NULL);
+	some_signals_caught =3D true;
       }
-
-    act.sa_mask =3D caught_signals;
-    act.sa_flags =3D SA_RESTART;
-
-    for (j =3D 0; j < nsigs; j++)
-      if (sigismember (&caught_signals, sig[j]))
-        {
-          act.sa_handler =3D sig[j] =3D=3D SIGTSTP ? stophandler : sigha=
ndler;
-          sigaction (sig[j], &act, NULL);
-        }
 #else
-    for (j =3D 0; j < nsigs; j++)
+  for (int j =3D 0; j < nsigs; j++)
+    if (xsignal (sig[j], SIG_IGN) !=3D SIG_IGN)
       {
-        caught_sig[j] =3D (signal (sig[j], SIG_IGN) !=3D SIG_IGN);
-        if (caught_sig[j])
-          {
-            signal (sig[j], sig[j] =3D=3D SIGTSTP ? stophandler : sighan=
dler);
-            siginterrupt (sig[j], 0);
-          }
+	xsigaddset (&caught_signals, sig[j]);
+	xsignal (sig[j], sig[j] =3D=3D SIGTSTP ? stophandler : sighandler);
+	some_signals_caught =3D true;
+	if (siginterrupt (sig[j], 0) !=3D 0)
+	  pfatal_with_name ("siginterrupt");
       }
 #endif
+}
+
+/* Clean up signal handlers just before exiting the program.  Do this
+   by resetting signal actions back to default, and then processing
+   any signals that arrived before resetting.  */
+void
+cleanup_signal_handlers (void)
+{
+  if (some_signals_caught)
+    {
+      for (int j =3D 0; j < nsigs; j++)
+	if (xsigismember (&caught_signals, sig[j]))
+	  xsignal (sig[j], SIG_DFL);
+      process_signals ();
     }
 }
=20
--=20
2.30.2


--------------C283A678C824E5E9AFF4010F--




From MAILER-DAEMON Sun Aug 29 07:15:04 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKImG-0005yr-Qc
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:15:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:43948)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKImF-0005yd-4b
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:15:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:44141)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKImE-0005n8-Rp
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:15:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKImE-00013b-Nc
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:15:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Gisle Vanem <gisle.vanem@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 11:15:02 +0000
Resent-Message-ID: <handler.36488.B.16302356443889@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 36488@debbugs.gnu.org
X-Debbugs-Original-To: bug-diffutils@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.16302356443889
 (code B ref -1); Sun, 29 Aug 2021 11:15:02 +0000
Received: (at submit) by debbugs.gnu.org; 29 Aug 2021 11:14:04 +0000
Received: from localhost ([127.0.0.1]:55683 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKIlI-00010f-K1
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 07:14:04 -0400
Received: from lists.gnu.org ([209.51.188.17]:34102)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gisle.vanem@gmail.com>) id 1mKIlH-00010Y-4B
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 07:14:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:43858)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gisle.vanem@gmail.com>)
 id 1mKIlG-0005AK-Rl
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:14:02 -0400
Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:36561)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <gisle.vanem@gmail.com>)
 id 1mKIlE-0005VO-Li
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 07:14:02 -0400
Received: by mail-lj1-x22a.google.com with SMTP id p15so20321370ljn.3
 for <bug-diffutils@gnu.org>; Sun, 29 Aug 2021 04:13:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; 
 h=from:subject:to:references:message-id:date:user-agent:mime-version
 :in-reply-to:content-language:content-transfer-encoding;
 bh=Y+kfBwyEirmyXKBYUpJeqoADRfn1to7C/XExghFuFGA=;
 b=nXtmzp/x0Leykd80CRb+J89PM9jplZ/vqDdJVXAlZXtOKB2NVpotemdRWk9xUw0KyE
 7nzJTVYqLTqT0fHHu+cYSANuXKQqISfHiJLi/9dUBblBjRS5QUqs0GVLK/qqrnYzIVPw
 V1KDio7uu6jQ+haE3yp4n5JRH8lVWv+6VGylRIbpxIVeb5uozRIDmhTCTpCV+ovFZrxy
 L1Ja0ZVeqN5sKop4CbeDlaqhbZRSaaApO5r90Ay/5usgChoQZpGyvW75ktIzQ8mzdqGB
 TjQbJ5EALPm/W+XBlXE4Nd5fBJa17iLatEbJ7awBUX0ck9CUBU2GO84UM65uI1nAPKDA
 BlWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:subject:to:references:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=Y+kfBwyEirmyXKBYUpJeqoADRfn1to7C/XExghFuFGA=;
 b=HuN+HDLQJEaGunTS0K5lnmMt8RjsxdfmMzMk+U1g+dRrH8bKu9gbNKv8ejfaVAwBT6
 qcc7kpRJb7HRnwFZLSMbh0XuEpq5O8wG5uryQ8clUE3pJToMUJoomiLAALGJSCN0CDdH
 pTeg+b4Y773P2gfGcjW4j1E164+OJCt5+g2lKFyYTD3RC26iZtwUK/fndvAHOCEhXosz
 6gsKoL+eIwcwedDPgsWhkaRu92Nao8YOepSd86wSxUWXMnEoe1FQEIMqo93Edir8y+D6
 ZzBGF42Ed9lWibVB7lZorH9SvvvYpbOqBECjx/gQYQNox4qpQExdTa0hdZRoK94+JDD4
 hwUw==
X-Gm-Message-State: AOAM531ejpKdA+0dwfeLh+IQpZ8adBsSi4rta1gshW0GhMe+x/+k0CLA
 8MGVKnCUAe6rUFZ48JcHmWNUzYlI0m4=
X-Google-Smtp-Source: ABdhPJxWnnLRYYSqwQ3FOx0B4HOQE3gP7KOvsaaJddXzdF6NQICmITp4s1L4ee+hV/wBR2DurUBR6Q==
X-Received: by 2002:a2e:58c:: with SMTP id 134mr16128977ljf.269.1630235638053; 
 Sun, 29 Aug 2021 04:13:58 -0700 (PDT)
Received: from [10.0.0.10] (ti0040q160-0004.bb.online.no. [88.95.101.5])
 by smtp.gmail.com with ESMTPSA id o18sm582593lfg.109.2021.08.29.04.13.57
 for <bug-diffutils@gnu.org>
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 29 Aug 2021 04:13:57 -0700 (PDT)
From: Gisle Vanem <gisle.vanem@gmail.com>
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
 <10257051.elIQoDPIPK@popigai>
 <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
Message-ID: <0b916f46-2495-3f86-b27d-5b151b8bc7f0@gmail.com>
Date: Sun, 29 Aug 2021 13:13:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2a00:1450:4864:20::22a;
 envelope-from=gisle.vanem@gmail.com; helo=mail-lj1-x22a.google.com
X-Spam_score_int: -24
X-Spam_score: -2.5
X-Spam_bar: --
X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, 
 NICE_REPLY_A=-0.437, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
Subject: [bug-diffutils] bug#36488: bug#36488: bug#36488: diffutils 3.7 make
 check failure ppc64le opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 11:15:03 -0000

Paul Eggert wrote:

> +static signal_handler
> +xsignal (int sig, signal_handler func)
> +{
> +  signal_handler h = signal (sig, func);
> +  if (h == SIG_ERR)
> +    pfatal_with_name ("signal");
> +  return h;
> +}
> +

On Windows, this causes a "diff --color file1 file2"
to exit with "diff.exe signal". How useful.

With some added trace-code I found this was for
SIGHUP (=1) which is not supported. So I just dropped
SIGHUP from the list.

-- 
--gv




From MAILER-DAEMON Sun Aug 29 14:21:06 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKPQY-0000cq-IN
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 14:21:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51152)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKPQV-0000c2-0C
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 14:21:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45799)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKPQT-0005e4-Qu
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 14:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKPQT-0005Za-NL
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 14:21:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 18:21:01 +0000
Resent-Message-ID: <handler.36488.B36488.163026121721314@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Gisle Vanem <gisle.vanem@gmail.com>
Cc: 36488@debbugs.gnu.org
Received: via spool by 36488-submit@debbugs.gnu.org id=B36488.163026121721314
 (code B ref 36488); Sun, 29 Aug 2021 18:21:01 +0000
Received: (at 36488) by debbugs.gnu.org; 29 Aug 2021 18:20:17 +0000
Received: from localhost ([127.0.0.1]:57340 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKPPk-0005Xi-Tv
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 14:20:17 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56292)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@cs.ucla.edu>) id 1mKPPi-0005XK-WB
 for 36488@debbugs.gnu.org; Sun, 29 Aug 2021 14:20:16 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id A9292160083;
 Sun, 29 Aug 2021 11:20:08 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id q-oqT8UPz_z4; Sun, 29 Aug 2021 11:20:04 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id E80EC1600A7;
 Sun, 29 Aug 2021 11:20:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id 7I3NGHUlA0KF; Sun, 29 Aug 2021 11:20:03 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BD238160083;
 Sun, 29 Aug 2021 11:20:03 -0700 (PDT)
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
 <10257051.elIQoDPIPK@popigai>
 <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
 <0b916f46-2495-3f86-b27d-5b151b8bc7f0@gmail.com>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <3986b30e-cc23-5cb2-9ddb-d2f56e280d9a@cs.ucla.edu>
Date: Sun, 29 Aug 2021 11:20:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <0b916f46-2495-3f86-b27d-5b151b8bc7f0@gmail.com>
Content-Type: multipart/mixed; boundary="------------49226973C0F681E13A18E7A2"
Content-Language: en-US
X-Spam-Score: -2.4 (--)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.4 (---)
Subject: [bug-diffutils] bug#36488: diffutils 3.7 make check failure ppc64le
 opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 18:21:04 -0000

This is a multi-part message in MIME format.
--------------49226973C0F681E13A18E7A2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8/29/21 4:13 AM, Gisle Vanem wrote:

> With some added trace-code I found this was for
> SIGHUP (=1) which is not supported. So I just dropped
> SIGHUP from the list. 

Thanks for reporting that. I installed the attached, which I hope fixes 
the problem in a more-portable way. Please give it a try.

In hindsight perhaps 'diff' should never have added signal handling, as 
it's a bug magnet. If your display's colors get messed up due to ^C the 
shell should fix the colors, not 'diff'.

--------------49226973C0F681E13A18E7A2
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-diff-port-better-to-MS-Windows.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-diff-port-better-to-MS-Windows.patch"

>From 078321ebeb4d9e83e900278154dbf47ec2758295 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 29 Aug 2021 11:14:14 -0700
Subject: [PATCH] diff: port better to MS-Windows

Problem reported by Gisle Vanem (Bug#36488#30).
* src/util.c (xsigaction) [SA_NOCLDSTOP]: Remove; no longer needed.
(install_signal_handlers): If the first call to sigaction or
signal fails, do not exit; just skip the signal and continue,
in case the runtime does not support the signal even though the
corresponding SIG* macro is defined.
---
 src/util.c | 36 +++++++++++++++---------------------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/src/util.c b/src/util.c
index 8e676c8..f8b911a 100644
--- a/src/util.c
+++ b/src/util.c
@@ -159,16 +159,7 @@ print_message_queue (void)
     }
 }
 
-
-#if SA_NOCLDSTOP
-static void
-xsigaction (int sig, struct sigaction const *restrict act,
-	    struct sigaction *restrict oact)
-{
-  if (sigaction (sig, act, oact) != 0)
-    pfatal_with_name ("sigaction");
-}
-#endif
+/* Signal handling, needed for restoring default colors.  */
 
 static void
 xsigaddset (sigset_t *set, int sig)
@@ -321,8 +312,7 @@ install_signal_handlers (void)
   for (int j = 0; j < nsigs; j++)
     {
       struct sigaction actj;
-      xsigaction (sig[j], NULL, &actj);
-      if (actj.sa_handler != SIG_IGN)
+      if (sigaction (sig[j], NULL, &actj) == 0 && actj.sa_handler != SIG_IGN)
 	xsigaddset (&caught_signals, sig[j]);
     }
 
@@ -334,19 +324,23 @@ install_signal_handlers (void)
     if (xsigismember (&caught_signals, sig[j]))
       {
 	act.sa_handler = sig[j] == SIGTSTP ? stophandler : sighandler;
-	xsigaction (sig[j], &act, NULL);
+	if (sigaction (sig[j], &act, NULL) != 0)
+	  pfatal_with_name ("sigaction");
 	some_signals_caught = true;
       }
 #else
   for (int j = 0; j < nsigs; j++)
-    if (xsignal (sig[j], SIG_IGN) != SIG_IGN)
-      {
-	xsigaddset (&caught_signals, sig[j]);
-	xsignal (sig[j], sig[j] == SIGTSTP ? stophandler : sighandler);
-	some_signals_caught = true;
-	if (siginterrupt (sig[j], 0) != 0)
-	  pfatal_with_name ("siginterrupt");
-      }
+    {
+      signal_handler h = signal (sig[j], SIG_IGN);
+      if (h != SIG_IGN && h != SIG_ERR)
+	{
+	  xsigaddset (&caught_signals, sig[j]);
+	  xsignal (sig[j], sig[j] == SIGTSTP ? stophandler : sighandler);
+	  some_signals_caught = true;
+	  if (siginterrupt (sig[j], 0) != 0)
+	    pfatal_with_name ("siginterrupt");
+	}
+    }
 #endif
 }
 
-- 
2.30.2


--------------49226973C0F681E13A18E7A2--




From MAILER-DAEMON Sun Aug 29 17:27:06 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKSKW-0006wv-HM
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 17:27:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44970)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKSKU-0006wZ-7k
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 17:27:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46044)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKSKT-0003GG-TQ
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 17:27:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKSKT-00069e-P0
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 17:27:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 21:27:01 +0000
Resent-Message-ID: <handler.36488.B36488.163027239323616@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Bonnard <frediz@debian.org>,
 Santiago Vila <sanvila@unex.es>, 36488@debbugs.gnu.org,
 Normand <normand@linux.vnet.ibm.com>
Received: via spool by 36488-submit@debbugs.gnu.org id=B36488.163027239323616
 (code B ref 36488); Sun, 29 Aug 2021 21:27:01 +0000
Received: (at 36488) by debbugs.gnu.org; 29 Aug 2021 21:26:33 +0000
Received: from localhost ([127.0.0.1]:57590 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKSK1-00068p-BM
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 17:26:33 -0400
Received: from mx.kolabnow.com ([95.128.36.41]:6722)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <bauermann@kolabnow.com>) id 1mKSJx-00068M-0B
 for 36488@debbugs.gnu.org; Sun, 29 Aug 2021 17:26:29 -0400
Received: from localhost (unknown [127.0.0.1])
 by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 5FA8CB4A;
 Sun, 29 Aug 2021 23:26:22 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h=
 content-type:content-type:content-transfer-encoding:mime-version
 :references:in-reply-to:message-id:date:date:subject:subject
 :from:from:received:received:received; s=dkim20160331; t=
 1630272378; x=1632086779; bh=XhcFuaASC6CVEfm3XPVL1bvlmplUVxARvtg
 HXnZGCfE=; b=4lfGlvbzXxH1XTlY7O2e94ZHEoJByYhRl7ci0qvT1/GktR/iTds
 cc+3kjnIBSQR0/f8UgJCnatWr+Gd/15bsd/1GhXHrMgfZ6+GkW+etAfYEGeMfekD
 U9OKKCr7Tat56NLIUqECAuWmr7HvnzuTCKhOPpvePLonCrKw4irpgQuiTnbo6WKa
 tSwXAMF0gwZPKLZOrB3GjNHoPXZec127pTu/UTW1KoKC0pbppZwRDd/dTPxk255T
 VqplqhEcuCvVJTxCDj6W3+fobnxxjOk1U3I6xF+IWaTYVJzhcp8YITFzO27u9lwt
 s8HSjhQRoRy2l7Zi3+WzleS4XvpyQuys5kfapVYEhXEsMIrbfokpI/E13yfFtkUm
 ScWGZ3sJ3hKprI/x6KkgsBm3mRIE6I0IDHDtLx7eOJDkfihQjC4Z4KEeiDauDiHJ
 Y8sKDYRinoI8PQEwbGO4/cJNC+tv9BT90WtuKsIlnKkGuqLIn9R71Zblvhs7mkU5
 9+oKykdjSP47BR2Guz0HR80QX8tNSnK1QDXnJ9FTN2m/jYei43eHJ/0hd1RsjVeu
 98TrqbvnwE8kX+xOBarDBBM1oR1BB21xGoA2qLuZvlIQ6wW9MiQTInOHf3q5qoIG
 aLCB9pW51C0OYMx5IBH0sBKDYOejy2rheFN/diqlBg55ARhWx80dif7Y=
X-Virus-Scanned: amavisd-new at mykolab.com
X-Spam-Score: -1.9
Received: from mx.kolabnow.com ([127.0.0.1])
 by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Mx5xt2djpUCY; Sun, 29 Aug 2021 23:26:18 +0200 (CEST)
Received: from int-mx003.mykolab.com (unknown [10.9.13.3])
 by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 9020FAAD;
 Sun, 29 Aug 2021 23:26:16 +0200 (CEST)
Received: from ext-subm002.mykolab.com (unknown [10.9.6.2])
 by int-mx003.mykolab.com (Postfix) with ESMTPS id 4214F3571;
 Sun, 29 Aug 2021 23:26:12 +0200 (CEST)
From: Thiago Jung Bauermann <bauermann@kolabnow.com>
Date: Sun, 29 Aug 2021 18:26:01 -0300
Message-ID: <12562597.lilg3O6Q0V@popigai>
In-Reply-To: <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
 <10257051.elIQoDPIPK@popigai>
 <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Subject: [bug-diffutils] bug#36488: bug#36488: diffutils 3.7 make check
 failure ppc64le opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 21:27:02 -0000

Hello Paul,

Em domingo, 29 de agosto de 2021, =C3=A0s 04:22:27 -03, Paul Eggert escreve=
u:
> On 8/28/21 8:40 AM, Thiago Jung Bauermann via bug-diffutils via All
>=20
> diffutils discussion. wrote:
> > I believe this is the same problem reported in bug 34519.
> > The Debian build also fails with "diff: standard output: Broken pipe".
>=20
> Thanks for tracking that down. Fr=C3=A9d=C3=A9ric's analysis in
> <https://bugs.debian.org/922552#19> was helpful.
>=20
> I found some time to look into this bug, and installed into
> Savannah.gnu.org diffutils the attached patch, which I hope fixes the
> bug although I don't have the relevant platform to test it. Please give
> it a try.

Awesome! That was very fast. Thank you very much.

> Once this patch is part of a release, Debian shouldn't need any patches
> for diffutils.
>=20
> For now I am closing the diffutils bug report
> <https://bugs.gnu.org/36488>; if I was too optimistic and the patch
> doesn't fix things we can always reopen it.

Unfortunately the colors test still hits the same problem in some runs even=
=20
with this patch applied.

Do you have access to a powerpc64le-linux machine? If you want, I can give=
=20
you an account on the VM I=E2=80=99m using.

=2D-=20
Thanks,
Thiago







From MAILER-DAEMON Sun Aug 29 18:01:04 2021
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1mKSrQ-0001wd-EP
	for mharc-bug-diffutils@gnu.org; Sun, 29 Aug 2021 18:01:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47352)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKSrO-0001wU-FW
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 18:01:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46073)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1mKSrO-0000Ke-5F
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 18:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1mKSrN-0001az-W4
 for bug-diffutils@gnu.org; Sun, 29 Aug 2021 18:01:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Paul Eggert <eggert@cs.ucla.edu>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-diffutils@gnu.org
Resent-Date: Sun, 29 Aug 2021 22:01:01 +0000
Resent-Message-ID: <handler.36488.B36488.16302744274141@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36488
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Bonnard <frediz@debian.org>,
 Santiago Vila <sanvila@unex.es>, 36488@debbugs.gnu.org,
 Normand <normand@linux.vnet.ibm.com>
Received: via spool by 36488-submit@debbugs.gnu.org id=B36488.16302744274141
 (code B ref 36488); Sun, 29 Aug 2021 22:01:01 +0000
Received: (at 36488) by debbugs.gnu.org; 29 Aug 2021 22:00:27 +0000
Received: from localhost ([127.0.0.1]:57619 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1mKSqp-00014V-2o
 for submit@debbugs.gnu.org; Sun, 29 Aug 2021 18:00:27 -0400
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@cs.ucla.edu>) id 1mKSqm-0000wQ-MK
 for 36488@debbugs.gnu.org; Sun, 29 Aug 2021 18:00:25 -0400
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id A8E3916005A;
 Sun, 29 Aug 2021 15:00:18 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id tbXeKeh9G-bj; Sun, 29 Aug 2021 15:00:18 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id D4AC81600FC;
 Sun, 29 Aug 2021 15:00:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id 3cp_Vz04q7BF; Sun, 29 Aug 2021 15:00:17 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 61F4616005A;
 Sun, 29 Aug 2021 15:00:17 -0700 (PDT)
References: <bf6471bb-38a2-d0a9-aee4-e20edb86fc97@linux.vnet.ibm.com>
 <10257051.elIQoDPIPK@popigai>
 <3a207779-c39f-55c0-2f27-d675da6df96f@cs.ucla.edu>
 <12562597.lilg3O6Q0V@popigai>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <6a34af3f-9f6c-ccb6-f68c-99fb54220e57@cs.ucla.edu>
Date: Sun, 29 Aug 2021 15:00:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <12562597.lilg3O6Q0V@popigai>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.4 (--)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.4 (---)
Subject: [bug-diffutils] bug#36488: bug#36488: diffutils 3.7 make check
 failure ppc64le opensuse on colors test
X-BeenThere: bug-diffutils@gnu.org
List-Id: "All diffutils discussion." <bug-diffutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-diffutils>
List-Post: <mailto:bug-diffutils@gnu.org>
List-Help: <mailto:bug-diffutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-diffutils>,
 <mailto:bug-diffutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Aug 2021 22:01:02 -0000

On 8/29/21 2:26 PM, Thiago Jung Bauermann wrote:

> Unfortunately the colors test still hits the same problem in some runs =
even
> with this patch applied.

Too bad. I reopened the bug report.

> Do you have access to a powerpc64le-linux machine? If you want, I can g=
ive
> you an account on the VM I=E2=80=99m using.

An account would be helpful, thanks.




