From MAILER-DAEMON Tue Jan 04 22:35:09 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PaK9U-00066W-Tu
	for mharc-bug-global@gnu.org; Tue, 04 Jan 2011 22:35:08 -0500
Received: from [140.186.70.92] (port=35738 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pa8xf-0004ix-2Q
	for bug-global@gnu.org; Tue, 04 Jan 2011 10:38:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wojtas.wes@gmail.com>) id 1Pa8xd-0003Dw-R7
	for bug-global@gnu.org; Tue, 04 Jan 2011 10:38:10 -0500
Received: from mail-bw0-f41.google.com ([209.85.214.41]:52583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wojtas.wes@gmail.com>) id 1Pa8xd-0003De-Lt
	for bug-global@gnu.org; Tue, 04 Jan 2011 10:38:09 -0500
Received: by bwz16 with SMTP id 16so17290365bwz.0
	for <bug-global@gnu.org>; Tue, 04 Jan 2011 07:38:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:date:message-id
	:subject:from:to:content-type;
	bh=L1wmKTCtcJbkRSTccvZ2HJB6368IWXkMdqeXJVtxf1Q=;
	b=VdNnOhE7sPBWFdoueWnQCCY33zShFj9jYO/1I4WfKw6Bz7qLnOLB7lBZWdzyKGbh1c
	R8ppSUHJ3DVvNdO/kEJwUzIEsv6mNzF8rF/w5lSRy8rc54Y8Vuu/4Ia0vLHoQyjlrDdn
	CCc+OUZmTDz6eLgX0t3wtvBs1ofbOx2kmgHkc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	b=lAPZCkYaT01tYQD/tiQCOAAdpB1gjap4PX09rggFJovhFGB98DfPm/WUAvwarmfJTw
	ZYDsf0pulPQxjWfFwS/3i4c5Z05ucMKPRPoXSaOOUQyKiBo4h6UW9V/rR1YKc0VtWrNY
	kA0NUnu29h/Vfw+z9QjaFcCCDDZBYmZOxouIA=
MIME-Version: 1.0
Received: by 10.204.45.223 with SMTP id g31mr16259760bkf.107.1294155486209;
	Tue, 04 Jan 2011 07:38:06 -0800 (PST)
Received: by 10.204.63.75 with HTTP; Tue, 4 Jan 2011 07:38:06 -0800 (PST)
Date: Tue, 4 Jan 2011 10:38:06 -0500
Message-ID: <AANLkTin8URSL+_YedtbY9uxrG9r6bRuFPZqU_TwaJGC1@mail.gmail.com>
From: Wes Wojtas <wojtas.wes@gmail.com>
To: bug-global@gnu.org
Content-Type: multipart/alternative; boundary=0016e6da7d9a0a29980499070e34
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Mailman-Approved-At: Tue, 04 Jan 2011 22:35:07 -0500
Subject: Erronous references when searching with cgi
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2011 15:38:12 -0000

--0016e6da7d9a0a29980499070e34
Content-Type: text/plain; charset=ISO-8859-1

   - *What did you do? (command line) *
   -   --> run 'htags' on latest phpfreechat php files
   -     htags -avgfF
   -
   - *What did you expect from it? *
   -  --> using -f option to be able to search globally for symbols/words
   (using cgi)
   -
   - *What was occured? (as is) *
   -  --> search results do not link to proper files - eg. if i search for
   word 'password' and one of results is:
   -                 ' .password             32
   src/commands/identify.class.php ...'
   - where word password is expected to be link to 'identify.class.php' file
   - actual file opened is 'rehash.class.php'

        To confirm you can point your browser at: "
http://wesnlois.sytes.net/wechat/HTML/" and do search.  I select '*grep*'
option in search box.

        Otherwise references from within  'global' - without cgi are
correct.

        Thanks,

        Wes

PS. Happy New Year 2011!   Cheers for excellent program.

--0016e6da7d9a0a29980499070e34
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><ul><li><u>What did you do? (command line)
</u></li><li>=A0 --&gt; run &#39;htags&#39; on latest phpfreechat php files=
=A0 <br></li><li>=A0=A0=A0 htags -avgfF</li><li><br></li><li><u>What did yo=
u expect from it?
</u></li><li>=A0--&gt; using -f option to be able to search globally for sy=
mbols/words (using cgi)<br></li><li><br></li><li><u>What was occured? (as i=
s)
</u></li><li>=A0--&gt; search results do not link to proper files - eg. if =
i search for word &#39;password&#39; and one of results is:</li><li>=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &#39; .password=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0 32 src/commands/identify.class.php ...&#39; <br>

</li><li>where word password is expected to be link to &#39;identify.class.=
php&#39; file - actual file opened is &#39;rehash.class.php&#39;</li></ul>=
=A0=A0=A0=A0=A0=A0=A0 To confirm you can point your browser at: &quot;<a hr=
ef=3D"http://wesnlois.sytes.net/wechat/HTML/">http://wesnlois.sytes.net/wec=
hat/HTML/</a>&quot; and do search.=A0 I select &#39;<u>grep</u>&#39; option=
 in search box.<br>

=A0=A0=A0=A0=A0=A0=A0 <br>
=A0=A0=A0=A0=A0=A0=A0 Otherwise references from within=A0 &#39;global&#39; =
- without cgi are correct.<br>
<br>
=A0=A0=A0=A0=A0=A0=A0 Thanks,<br>
<br>
=A0=A0=A0=A0=A0=A0=A0 Wes<br>
<br>
PS. Happy New Year 2011!=A0=A0 Cheers for excellent program.

--0016e6da7d9a0a29980499070e34--


From MAILER-DAEMON Tue Jan 04 22:35:09 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PaK9V-00066k-1J
	for mharc-bug-global@gnu.org; Tue, 04 Jan 2011 22:35:09 -0500
Received: from [140.186.70.92] (port=50448 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PaDug-0001IX-14
	for bug-global@gnu.org; Tue, 04 Jan 2011 15:55:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wojtas.wes@gmail.com>) id 1PaDue-0008Ai-IH
	for bug-global@gnu.org; Tue, 04 Jan 2011 15:55:25 -0500
Received: from mail-wy0-f169.google.com ([74.125.82.169]:35666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wojtas.wes@gmail.com>) id 1PaDue-0008AA-Bl
	for bug-global@gnu.org; Tue, 04 Jan 2011 15:55:24 -0500
Received: by wyj26 with SMTP id 26so15367771wyj.0
	for <bug-global@gnu.org>; Tue, 04 Jan 2011 12:55:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:content-type;
	bh=FlPLoa6j6qQ+gRWhRYD2o5bkKY/ZAbVAndDiT/+sGNA=;
	b=t9s8WXKUoXl3Dz6bHL4hBHjkIMLS/9lP2Vo4REZdxtuk4284qtVOP92cIEG4DuH8Bs
	P+Apto9r6Nb7WdFGzMPqp0d3u0ETciEn+FQXiTEBbAX50fcDQaXf9p/r6yq7/2kDrYEt
	lniGjeGKY06pGdj580l9ya3HtubnGSbKMy2lU=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	b=hG7x7XZ4pOZGKrfZub55Qpeks2aANfDOt/sDpYcIWx9FXneZvaODoSwc+7raEG3uZt
	WzTGVk0QeUs24iiZrnYFpSGcGc6yeRJrCTb52IlgkhFYvbmF6Mn9WhUK9J6dh8ISkW+o
	cbqSLvT4A4MbbMzl6AxtpozU9hfayyY5QJV1c=
MIME-Version: 1.0
Received: by 10.227.145.193 with SMTP id e1mr12759114wbv.110.1294174522720;
	Tue, 04 Jan 2011 12:55:22 -0800 (PST)
Received: by 10.227.69.133 with HTTP; Tue, 4 Jan 2011 12:55:22 -0800 (PST)
In-Reply-To: <AANLkTin8URSL+_YedtbY9uxrG9r6bRuFPZqU_TwaJGC1@mail.gmail.com>
References: <AANLkTin8URSL+_YedtbY9uxrG9r6bRuFPZqU_TwaJGC1@mail.gmail.com>
Date: Tue, 4 Jan 2011 15:55:22 -0500
Message-ID: <AANLkTinaAgsijGyqYo=X_6t3R7qtte5hjY4E9Yu1_Mjr@mail.gmail.com>
From: Wes Wojtas <wojtas.wes@gmail.com>
To: bug-global@gnu.org
Content-Type: multipart/alternative; boundary=001636833518b449dd04990b7cdc
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Mailman-Approved-At: Tue, 04 Jan 2011 22:35:07 -0500
Subject: Re: Erronous references when searching with cgi
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2011 20:55:27 -0000

--001636833518b449dd04990b7cdc
Content-Type: text/plain; charset=ISO-8859-1

Shigio,

I had sent this bug some hours ago. I repeated the steps below using another
project (http://wesnlois.sytes.net/joomla-proj/HTML/)   and find no problem
at all. Search is always correct.

I will remake project which showed problems and if I find it still
problematic I will contact you again.

Thanks,

Wes

On Tue, Jan 4, 2011 at 10:38 AM, Wes Wojtas <wojtas.wes@gmail.com> wrote:

>
>
>    - *What did you do? (command line) *
>    -   --> run 'htags' on latest phpfreechat php files
>    -     htags -avgfF
>    -
>    - *What did you expect from it? *
>    -  --> using -f option to be able to search globally for symbols/words
>    (using cgi)
>    -
>    - *What was occured? (as is) *
>    -  --> search results do not link to proper files - eg. if i search for
>    word 'password' and one of results is:
>    -                 ' .password             32
>    src/commands/identify.class.php ...'
>    - where word password is expected to be link to 'identify.class.php'
>    file - actual file opened is 'rehash.class.php'
>
>         To confirm you can point your browser at: "
> http://wesnlois.sytes.net/wechat/HTML/" and do search.  I select '*grep*'
> option in search box.
>
>         Otherwise references from within  'global' - without cgi are
> correct.
>
>         Thanks,
>
>         Wes
>
> PS. Happy New Year 2011!   Cheers for excellent program.

--001636833518b449dd04990b7cdc
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Shigio,<br><br>I had sent this bug some hours ago. I repeated the steps bel=
ow using another project (<a href=3D"http://wesnlois.sytes.net/joomla-proj/=
HTML" target=3D"_blank">http://wesnlois.sytes.net/joomla-proj/HTML</a>/) =
=A0 and find no problem at all. Search is always correct.=A0 <br>

<br>I will remake project which showed problems and if I find it still prob=
lematic I will contact you again. <br><br>Thanks,<br><br>Wes<br><br><div cl=
ass=3D"gmail_quote">On Tue, Jan 4, 2011 at 10:38 AM, Wes Wojtas <span dir=
=3D"ltr">&lt;<a href=3D"mailto:wojtas.wes@gmail.com" target=3D"_blank">wojt=
as.wes@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; borde=
r-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><br><ul><li><u>Wh=
at did you do? (command line)
</u></li><li>=A0 --&gt; run &#39;htags&#39; on latest phpfreechat php files=
=A0 <br></li><li>=A0=A0=A0 htags -avgfF</li><li><br></li><li><u>What did yo=
u expect from it?
</u></li><li>=A0--&gt; using -f option to be able to search globally for sy=
mbols/words (using cgi)<br></li><li><br></li><li><u>What was occured? (as i=
s)
</u></li><li>=A0--&gt; search results do not link to proper files - eg. if =
i search for word &#39;password&#39; and one of results is:</li><li>=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &#39; .password=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0 32 src/commands/identify.class.php ...&#39; <br>



</li><li>where word password is expected to be link to &#39;identify.class.=
php&#39; file - actual file opened is &#39;rehash.class.php&#39;</li></ul>=
=A0=A0=A0=A0=A0=A0=A0 To confirm you can point your browser at: &quot;<a hr=
ef=3D"http://wesnlois.sytes.net/wechat/HTML/" target=3D"_blank">http://wesn=
lois.sytes.net/wechat/HTML/</a>&quot; and do search.=A0 I select &#39;<u>gr=
ep</u>&#39; option in search box.<br>



=A0=A0=A0=A0=A0=A0=A0 <br>
=A0=A0=A0=A0=A0=A0=A0 Otherwise references from within=A0 &#39;global&#39; =
- without cgi are correct.<br>
<br>
=A0=A0=A0=A0=A0=A0=A0 Thanks,<br><font color=3D"#888888">
<br>
=A0=A0=A0=A0=A0=A0=A0 Wes<br>
</font><br>
PS. Happy New Year 2011!=A0=A0 Cheers for excellent program.
</blockquote></div><br>

--001636833518b449dd04990b7cdc--


From MAILER-DAEMON Fri Jan 14 09:06:07 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PdkI2-0005oi-UE
	for mharc-bug-global@gnu.org; Fri, 14 Jan 2011 09:06:06 -0500
Received: from [140.186.70.92] (port=41825 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdSQ5-0005DP-2R
	for bug-global@gnu.org; Thu, 13 Jan 2011 14:01:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdSQ3-0000PM-G0
	for bug-global@gnu.org; Thu, 13 Jan 2011 14:01:12 -0500
Received: from lo.gmane.org ([80.91.229.12]:39621)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdSQ3-0000PF-9f
	for bug-global@gnu.org; Thu, 13 Jan 2011 14:01:11 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdSP0-00031u-Ke
	for bug-global@gnu.org; Thu, 13 Jan 2011 20:00:06 +0100
Received: from gateway.shenick.com ([62.77.176.130])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Thu, 13 Jan 2011 20:00:06 +0100
Received: from Marc.Herbert by gateway.shenick.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Thu, 13 Jan 2011 20:00:06 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-global@gnu.org
From: Marc Herbert <Marc.Herbert@gmail.com>
Date: Thu, 13 Jan 2011 18:56:10 +0000
Lines: 61
Message-ID: <ignhs2$k8d$1@dough.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: gateway.shenick.com
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Mailman-Approved-At: Fri, 14 Jan 2011 09:06:04 -0500
Subject: Fixed 64bits bug where large long sysconf() values where cast into
 negative ints.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jan 2011 19:01:14 -0000

Hi,

I found this bug while running "global -u -v" on a 64 bits system.

Without the bug:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h
 [1/2] adding tags of mlips/include/foo.h
 [2/2] adding tags of mlips/include/bar.h

When a very large 64 bits value is returned by sysconf, it is cast to
a negative int and the bug is triggered. Then global is just deleting
symbols instead:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h


 This cause of this bug was very well hidden because negative values
were changed to zero. I cannot understand why: a limit of zero still
does not work, it just hides this bug.

Regards,

Marc


diff --git a/libutil/xargs.c b/libutil/xargs.c
index 94627dd..a1dba63 100644
--- a/libutil/xargs.c
+++ b/libutil/xargs.c
@@ -38,6 +38,7 @@
 #include "xargs.h"
 
 #if !defined(ARG_MAX) && defined(_SC_ARG_MAX)
+/* FIXME: in theory sysconf() can return -1L for unlimited */
 #define ARG_MAX         sysconf(_SC_ARG_MAX)
 #endif
 
@@ -70,7 +71,7 @@ static XARGS *xargs_open_generic(const char *, int);
 static int
 exec_line_limit(int length)
 {
-	int limit = 0;
+	long limit = 0;
 
 #ifdef ARG_MAX
 	/*
@@ -105,7 +106,8 @@ exec_line_limit(int length)
 	limit = 2047 - length - 80;
 #endif
 	if (limit < 0)
-		limit = 0;
+               die("Negative exec line limit = %ld", limit);
+
 	return limit;
 }
 /*





From MAILER-DAEMON Fri Jan 14 09:06:07 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PdkI3-0005ot-2A
	for mharc-bug-global@gnu.org; Fri, 14 Jan 2011 09:06:07 -0500
Received: from [140.186.70.92] (port=44005 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdV8E-0004Qq-DW
	for bug-global@gnu.org; Thu, 13 Jan 2011 16:55:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marc.herbert@gmail.com>) id 1PdV7y-0007X6-SB
	for bug-global@gnu.org; Thu, 13 Jan 2011 16:54:43 -0500
Received: from mail-wy0-f169.google.com ([74.125.82.169]:60910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc.herbert@gmail.com>) id 1PdV7y-0007Wv-Ki
	for bug-global@gnu.org; Thu, 13 Jan 2011 16:54:42 -0500
Received: by wyj26 with SMTP id 26so2191652wyj.0
	for <bug-global@gnu.org>; Thu, 13 Jan 2011 13:54:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:message-id:x-mozilla-status:x-mozilla-status2
	:x-mozilla-keys:date:from:user-agent:mime-version:newsgroups:subject
	:content-type:content-transfer-encoding:resent-date:resent-from
	:resent-to:resent-subject:resent-message-id:resent-user-agent;
	bh=iMrLCLtKqEFhxwaez494tS0qDGYsKVBCuRWsLdr/9+A=;
	b=vmL7kFyLCG7UDI55Ulh1GqHpbwZLk9yku2fSbNHJYmAOrQVn8mM2cMqv8FTQbAoVmq
	a+CyBcCoPbw/wCNnZAaiZ0ozGFHJhVsBa8ElPrkcaIoczRTBjpmWmRNb0e3ilPrOTX9j
	OpryLKLY5QX5HcA/4IojC7RiW3VZAzJ62Xwkw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:x-mozilla-status:x-mozilla-status2:x-mozilla-keys:date
	:from:user-agent:mime-version:newsgroups:subject:content-type
	:content-transfer-encoding:resent-date:resent-from:resent-to
	:resent-subject:resent-message-id:resent-user-agent;
	b=Hv4/J0IREnYzIM+UW7kTj7sYOCnjanXJQ39DmjEqvNd2z6qz0IBYOLZcUddUAtRUJ8
	TI1m+oGjFC7UuDbnzR9uu99+XPpbxjGFkCFq419gBCx8P0fbvhAkTDNj8Tp0Opjr9km0
	pWkNtehXSj3C5prrBdoKH+rwdLHbmFOalJcNI=
Received: by 10.216.48.70 with SMTP id u48mr2457443web.25.1294955680971;
	Thu, 13 Jan 2011 13:54:40 -0800 (PST)
Received: from [192.168.21.120] (gateway.shenick.com [62.77.176.130])
	by mx.google.com with ESMTPS id e12sm305103wer.36.2011.01.13.13.54.39
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Thu, 13 Jan 2011 13:54:40 -0800 (PST)
Message-ID: <4d2f74a0.8cf0d80a.3b7f.2166@mx.google.com>
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00800000
X-Mozilla-Keys: 
Date: Thu, 13 Jan 2011 18:56:10 +0000
From: Marc Herbert <Marc.Herbert@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
MIME-Version: 1.0
Newsgroups: gmane.comp.gnu.global.bugs
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
ReSent-Date: Thu, 13 Jan 2011 21:54:14 +0000 (GMT)
ReSent-From: Marc Herbert <marc.herbert@gmail.com>
ReSent-To: bug-global@gnu.org
ReSent-Subject: Fixed 64bits bug where large long sysconf() values where cast
	into negative ints.
ReSent-Message-ID: <alpine.LFD.2.02.1101132154140.11555@vercors>
ReSent-User-Agent: Alpine 2.02 (LFD 1266 2009-07-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Mailman-Approved-At: Fri, 14 Jan 2011 09:06:04 -0500
Subject: Fixed 64bits bug where large long sysconf() values where cast into
 negative ints.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jan 2011 21:55:05 -0000

Hi,

I found this bug while running "global -u -v" on a 64 bits system.

Without the bug:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h
 [1/2] adding tags of mlips/include/foo.h
 [2/2] adding tags of mlips/include/bar.h

When a very large 64 bits value is returned by sysconf, it is cast to
a negative int and the bug is triggered. Then global is just deleting
symbols instead:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h


 This cause of this bug was very well hidden because negative values
were changed to zero. I cannot understand why: a limit of zero still
does not work, it just hides this bug.

Regards,

Marc


diff --git a/libutil/xargs.c b/libutil/xargs.c
index 94627dd..a1dba63 100644
--- a/libutil/xargs.c
+++ b/libutil/xargs.c
@@ -38,6 +38,7 @@
 #include "xargs.h"
 
 #if !defined(ARG_MAX) && defined(_SC_ARG_MAX)
+/* FIXME: in theory sysconf() can return -1L for unlimited */
 #define ARG_MAX         sysconf(_SC_ARG_MAX)
 #endif
 
@@ -70,7 +71,7 @@ static XARGS *xargs_open_generic(const char *, int);
 static int
 exec_line_limit(int length)
 {
-	int limit = 0;
+	long limit = 0;
 
 #ifdef ARG_MAX
 	/*
@@ -105,7 +106,8 @@ exec_line_limit(int length)
 	limit = 2047 - length - 80;
 #endif
 	if (limit < 0)
-		limit = 0;
+               die("Negative exec line limit = %ld", limit);
+
 	return limit;
 }
 /*




From MAILER-DAEMON Fri Jan 14 09:06:07 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PdkI3-0005pD-8a
	for mharc-bug-global@gnu.org; Fri, 14 Jan 2011 09:06:07 -0500
Received: from [140.186.70.92] (port=42836 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdfWh-0006RW-EP
	for bug-global@gnu.org; Fri, 14 Jan 2011 04:00:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdfWg-0007yG-7m
	for bug-global@gnu.org; Fri, 14 Jan 2011 04:00:55 -0500
Received: from lo.gmane.org ([80.91.229.12]:53353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdfWg-0007y1-28
	for bug-global@gnu.org; Fri, 14 Jan 2011 04:00:54 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdfWd-0000ru-TD
	for bug-global@gnu.org; Fri, 14 Jan 2011 10:00:51 +0100
Received: from mail.gateway.shenick.com ([62.77.176.130])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Fri, 14 Jan 2011 10:00:51 +0100
Received: from Marc.Herbert by mail.gateway.shenick.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Fri, 14 Jan 2011 10:00:51 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-global@gnu.org
From: Marc Herbert <Marc.Herbert@gmail.com>
Date: Fri, 14 Jan 2011 09:00:52 +0000
Lines: 59
Message-ID: <igp3bo$8ka$1@dough.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: mail.gateway.shenick.com
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Mailman-Approved-At: Fri, 14 Jan 2011 09:06:04 -0500
Subject: [PATCH] Fixed 64bits bug where large long sysconf(ARG_MAX) values
 are cast into negative ints
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jan 2011 09:00:56 -0000

Hi,

I found this bug while running "global -u -v" on a 64 bits system.

Without the bug:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h
 [1/2] adding tags of mlips/include/foo.h
 [2/2] adding tags of mlips/include/bar.h

When a very large 64 bits value is returned by sysconf, it is cast to
a negative int and the bug is triggered. Then global is just deleting
symbols instead:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h


 This cause of this bug was very well hidden because negative values
were changed to zero. I cannot understand why: a limit of zero still
does not work, it just hides this bug.

Regards,

Marc

diff --git a/libutil/xargs.c b/libutil/xargs.c
index 94627dd..a1dba63 100644
--- a/libutil/xargs.c
+++ b/libutil/xargs.c
@@ -38,6 +38,7 @@
 #include "xargs.h"
 
 #if !defined(ARG_MAX) && defined(_SC_ARG_MAX)
+/* FIXME: in theory sysconf() can return -1L for unlimited */
 #define ARG_MAX         sysconf(_SC_ARG_MAX)
 #endif
 
@@ -70,7 +71,7 @@ static XARGS *xargs_open_generic(const char *, int);
 static int
 exec_line_limit(int length)
 {
-	int limit = 0;
+	long limit = 0;
 
 #ifdef ARG_MAX
 	/*
@@ -105,7 +106,8 @@ exec_line_limit(int length)
 	limit = 2047 - length - 80;
 #endif
 	if (limit < 0)
-		limit = 0;
+               die("Negative exec line limit = %ld", limit);
+
 	return limit;
 }
 /*




From MAILER-DAEMON Fri Jan 14 09:06:08 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PdkI3-0005pK-Ej
	for mharc-bug-global@gnu.org; Fri, 14 Jan 2011 09:06:07 -0500
Received: from [140.186.70.92] (port=55231 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pdhal-0004LI-Aw
	for bug-global@gnu.org; Fri, 14 Jan 2011 06:13:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Marc.Herbert@gmail.com>) id 1Pdhak-0006Lx-9k
	for bug-global@gnu.org; Fri, 14 Jan 2011 06:13:15 -0500
Received: from gateway.shenick.com ([62.77.176.130]:42623
	helo=aisling.irl.shenick.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Marc.Herbert@gmail.com>) id 1Pdhaj-0006Lg-Ua
	for bug-global@gnu.org; Fri, 14 Jan 2011 06:13:14 -0500
Received: from [192.168.21.120] ([192.168.21.120])
	by aisling.irl.shenick.com (8.13.1/8.13.1) with ESMTP id p0EBD91S031579;
	Fri, 14 Jan 2011 11:13:10 GMT
Message-ID: <4D302FD2.8000403@gmail.com>
Date: Fri, 14 Jan 2011 11:13:22 +0000
From: Marc Herbert <Marc.Herbert@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
MIME-Version: 1.0
To: bug-global@gnu.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Mailman-Approved-At: Fri, 14 Jan 2011 09:06:05 -0500
Subject: [PATCH] Fixed 64bits bug where large long sysconf(ARG_MAX) values
 are cast into a negative int
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jan 2011 11:13:16 -0000

Hi,

I found this bug while running "global -u -v" on a 64 bits system.

Without the bug:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h
 [1/2] adding tags of mlips/include/foo.h
 [2/2] adding tags of mlips/include/bar.h

When a very large 64 bits value is returned by sysconf, it is cast to
a negative int and the bug is triggered. Then global is just deleting
symbols instead:

 [1/2] deleting tags of mlips/include/foo.h
 [2/2] deleting tags of mlips/include/bar.h


 This cause of this bug was very well hidden because negative values
were changed to zero. I cannot understand why: a limit of zero still
does not work, it just hides this bug.

Regards,

Marc

diff --git a/libutil/xargs.c b/libutil/xargs.c
index 94627dd..a1dba63 100644
--- a/libutil/xargs.c
+++ b/libutil/xargs.c
@@ -38,6 +38,7 @@
 #include "xargs.h"
 
 #if !defined(ARG_MAX) && defined(_SC_ARG_MAX)
+/* FIXME: in theory sysconf() can return -1L for unlimited */
 #define ARG_MAX         sysconf(_SC_ARG_MAX)
 #endif
 
@@ -70,7 +71,7 @@ static XARGS *xargs_open_generic(const char *, int);
 static int
 exec_line_limit(int length)
 {
-	int limit = 0;
+	long limit = 0;
 
 #ifdef ARG_MAX
 	/*
@@ -105,7 +106,8 @@ exec_line_limit(int length)
 	limit = 2047 - length - 80;
 #endif
 	if (limit < 0)
-		limit = 0;
+               die("Negative exec line limit = %ld", limit);
+
 	return limit;
 }
 /*



From MAILER-DAEMON Fri Jan 14 09:22:11 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PdkXb-0003qG-Ax
	for mharc-bug-global@gnu.org; Fri, 14 Jan 2011 09:22:11 -0500
Received: from [140.186.70.92] (port=42018 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdkXY-0003lc-DS
	for bug-global@gnu.org; Fri, 14 Jan 2011 09:22:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdkXQ-0007O7-AI
	for bug-global@gnu.org; Fri, 14 Jan 2011 09:22:01 -0500
Received: from lo.gmane.org ([80.91.229.12]:40577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdkXQ-0007O3-1W
	for bug-global@gnu.org; Fri, 14 Jan 2011 09:22:00 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PdkXN-00031G-A4
	for bug-global@gnu.org; Fri, 14 Jan 2011 15:21:57 +0100
Received: from gateway.shenick.com ([62.77.176.130])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Fri, 14 Jan 2011 15:21:57 +0100
Received: from Marc.Herbert by gateway.shenick.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Fri, 14 Jan 2011 15:21:57 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-global@gnu.org
From: Marc Herbert <Marc.Herbert@gmail.com>
Date: Fri, 14 Jan 2011 14:21:56 +0000
Lines: 8
Message-ID: <igpm5n$97g$1@dough.gmane.org>
References: <4D302FD2.8000403@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: gateway.shenick.com
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
In-Reply-To: <4D302FD2.8000403@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Fixed 64bits bug where large long sysconf(ARG_MAX)
 values are cast into a negative int
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jan 2011 14:22:09 -0000

Deeply sorry for the duplicated posts. I thought the list was
*rejecting* my first attempts for various reasons (one reason per
attempt...), so I kept trying to post in different ways. I carefully
waited several hours after each attempt but this was apparently not
enough.

PS: I (try to) use gmane.




From MAILER-DAEMON Sat Jan 15 07:12:35 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Pe4zj-0005Du-DE
	for mharc-bug-global@gnu.org; Sat, 15 Jan 2011 07:12:35 -0500
Received: from [140.186.70.92] (port=57449 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pe4zh-0005Dc-IQ
	for bug-global@gnu.org; Sat, 15 Jan 2011 07:12:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1Pe4zg-0000T1-Dq
	for bug-global@gnu.org; Sat, 15 Jan 2011 07:12:33 -0500
Received: from msa104lp.auone-net.jp ([222.3.140.167]:38249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1Pe4zf-0000Sq-TX
	for bug-global@gnu.org; Sat, 15 Jan 2011 07:12:32 -0500
Received: from choota.tamacom.com (KHP059138043202.ppp-bb.dion.ne.jp
	[59.138.43.202])
	by msa104lp.auone-net.jp (au one net msa) with ESMTP id 0C635650036;
	Sat, 15 Jan 2011 21:12:27 +0900 (JST)
Received: from choota.tamacom.com (localhost [127.0.0.1]) by
	choota.tamacom.com (8.13.6/) with ESMTP id p0FCLOOe011111;
	Sat, 15 Jan 2011 21:21:24 +0900 (JST)
Message-Id: <201101151221.p0FCLOOe011111@tamacom.com>
To: Marc Herbert <Marc.Herbert@gmail.com>
From: "Shigio YAMAGUCHI" <shigio@gnu.org>
References: <igpm5n$97g$1@dough.gmane.org>
In-reply-to: Message from Marc Herbert <Marc.Herbert@gmail.com>
	of "Fri, 14 Jan 2011 14:21:56 GMT." <igpm5n$97g$1@dough.gmane.org>
Date: Sat, 15 Jan 2011 21:21:24 +0900
Sender: shigio@tamacom.com
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
Cc: bug-global@gnu.org
Subject: Re: [PATCH] Fixed 64bits bug where large long sysconf(ARG_MAX)
	values are cast into a negative int
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Jan 2011 12:12:34 -0000

Hi,
> I found this bug while running "global -u -v" on a 64 bits system.
...
>  This cause of this bug was very well hidden because negative values
> were changed to zero. I cannot understand why: a limit of zero still
> does not work, it just hides this bug.
...
> diff --git a/libutil/xargs.c b/libutil/xargs.c
> index 94627dd..a1dba63 100644
> --- a/libutil/xargs.c
> +++ b/libutil/xargs.c
> @@ -38,6 +38,7 @@
>  #include "xargs.h"
>  
>  #if !defined(ARG_MAX) && defined(_SC_ARG_MAX)
> +/* FIXME: in theory sysconf() can return -1L for unlimited */
>  #define ARG_MAX         sysconf(_SC_ARG_MAX)
>  #endif
>  
> @@ -70,7 +71,7 @@ static XARGS *xargs_open_generic(const char *, int);
>  static int
>  exec_line_limit(int length)
>  {
> -	int limit = 0;
> +	long limit = 0;
>  
>  #ifdef ARG_MAX
>  	/*
> @@ -105,7 +106,8 @@ exec_line_limit(int length)
>  	limit = 2047 - length - 80;
>  #endif
>  	if (limit < 0)
> -		limit = 0;
> +               die("Negative exec line limit = %ld", limit);
> +
>  	return limit;
>  }
>  /*

I have committed your patch.
Thank you.

> Deeply sorry for the duplicated posts. I thought the list was
> *rejecting* my first attempts for various reasons (one reason per
> attempt...), so I kept trying to post in different ways. I carefully
> waited several hours after each attempt but this was apparently not
> enough.

Please don't worry. Your behavior is natural.
The reaction of this mailing list might sometimes be late.

Basically, since this mailing list is moderated, most mails are not
accepted without my management procedure. However, it seems that you
are escaping from the moderation.:-O  (I will leave it as it is.)
In fact, because I had been being hospitalized for about one week,
I was not able to check this mailing list until today.

Anyway, thank you for your contribution!
--
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


From MAILER-DAEMON Sun Jan 16 06:25:08 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PeQjM-00024j-D4
	for mharc-bug-global@gnu.org; Sun, 16 Jan 2011 06:25:08 -0500
Received: from [140.186.70.92] (port=38120 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PeQjK-00022h-5d
	for bug-global@gnu.org; Sun, 16 Jan 2011 06:25:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1PeQjI-0003Zh-Tk
	for bug-global@gnu.org; Sun, 16 Jan 2011 06:25:06 -0500
Received: from msa104lp.auone-net.jp ([222.3.140.167]:37668)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shigio@tamacom.com>)
	id 1PeQjI-0003Z4-KR; Sun, 16 Jan 2011 06:25:04 -0500
Received: from choota.tamacom.com (KHP059138043202.ppp-bb.dion.ne.jp
	[59.138.43.202])
	by msa104lp.auone-net.jp (au one net msa) with ESMTP id DF46E65003C;
	Sun, 16 Jan 2011 20:25:01 +0900 (JST)
Received: from choota.tamacom.com (localhost [127.0.0.1]) by
	choota.tamacom.com (8.13.6/) with ESMTP id p0GBY1Km001893;
	Sun, 16 Jan 2011 20:34:01 +0900 (JST)
Message-Id: <201101161134.p0GBY1Km001893@tamacom.com>
To: bug-global@gnu.org
From: "Shigio YAMAGUCHI" <shigio@gnu.org>
Date: Sun, 16 Jan 2011 20:34:01 +0900
Sender: shigio@tamacom.com
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
Cc: 
Subject: [RFC] Two trivial modifications about htags(1).
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Jan 2011 11:25:07 -0000

Hi all,
I would like to change some options of htags(1).

1. Removing the --no-map-file option and adding new --map-file option.

	Currently, htags generates MAP and MAPFILE files by default.
	However, because they are not so used, I would like to stop always
	making them. Instead, I would like to add new --map-file option,
	which makes them if specified.

2. Removing the -c (--compact) option from the --suggestion2's list.

	Currently, the --suggestion2 option includes the -c (--compress)
	option. However, because the setup for it is difficult, and the
	importance of it is lower than before, I would like to remove it
	from the --suggestion2 option.

What do you think?
If there is no problem, I will change GLOBAL as mentioned above.
--
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


From MAILER-DAEMON Mon Jan 17 22:35:21 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Pf2Lp-0005yJ-IF
	for mharc-bug-global@gnu.org; Mon, 17 Jan 2011 22:35:21 -0500
Received: from [140.186.70.92] (port=44251 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf2Lm-0005xq-M5
	for bug-global@gnu.org; Mon, 17 Jan 2011 22:35:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1Pf2Ll-00061U-Hg
	for bug-global@gnu.org; Mon, 17 Jan 2011 22:35:18 -0500
Received: from msa105lp.auone-net.jp ([222.3.140.168]:49254)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shigio@tamacom.com>)
	id 1Pf2Ll-00061K-2U; Mon, 17 Jan 2011 22:35:17 -0500
Received: from choota.tamacom.com (KHP059138043202.ppp-bb.dion.ne.jp
	[59.138.43.202])
	by msa105lp.auone-net.jp (au one net msa) with ESMTP id DB0407F0037;
	Tue, 18 Jan 2011 12:35:12 +0900 (JST)
Received: from choota.tamacom.com (localhost [127.0.0.1]) by
	choota.tamacom.com (8.13.6/) with ESMTP id p0I3iEtW002481;
	Tue, 18 Jan 2011 12:44:14 +0900 (JST)
Message-Id: <201101180344.p0I3iEtW002481@tamacom.com>
To: bug-global@gnu.org
From: "Shigio YAMAGUCHI" <shigio@gnu.org>
Date: Tue, 18 Jan 2011 12:44:14 +0900
Sender: shigio@tamacom.com
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
Cc: 
Subject: [RFC] Removing pushy mouse key assignment from gtags.el.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2011 03:35:19 -0000

Hi all,

It seems that a lot of people who are using gtags.el say,
"Return the default mouse mapping of emacs!"
I should answer this.

How about changing gtags.el like follows?

o All the assignment of mouse key is abolished.
o Instead, new custom variable 'gtags-suggested-keymap' is added.

  If you hope old key mapping then you should write your .emacs file
  like this:
  [$HOME/.emacs]
  +------------------------------------------------
  |(setq gtags-mode-hook
  |  '(lambda ()
  |        (setq gtags-suggested-keymap t)
  |))

  This is equivalent to the following settings:
  [$HOME/.emacs]
  +------------------------------------------------
  |(setq gtags-mode-hook
  |   '(lambda ()
  |         (define-key gtags-mode-map "\eh" 'gtags-display-browser)
  |         (define-key gtags-mode-map "\C-]" 'gtags-find-tag-from-here)
  |         (define-key gtags-mode-map "\C-t" 'gtags-pop-stack)
  |         (define-key gtags-mode-map "\el" 'gtags-find-file)
  |         (define-key gtags-mode-map "\eg" 'gtags-find-with-grep)
  |         (define-key gtags-mode-map "\eI" 'gtags-find-with-idutils)
  |         (define-key gtags-mode-map "\es" 'gtags-find-symbol)
  |         (define-key gtags-mode-map "\er" 'gtags-find-rtag)
  |         (define-key gtags-mode-map "\et" 'gtags-find-tag)
  |         (define-key gtags-mode-map "\ev" 'gtags-visit-rootdir)
  |         (if (not gtags-running-xemacs) nil
  |             (define-key gtags-mode-map 'button3 'gtags-pop-stack)
  |             (define-key gtags-mode-map 'button2 'gtags-find-tag-by-event))
  |         (if gtags-running-xemacs nil
  |             (define-key gtags-mode-map [mouse-3] 'gtags-pop-stack)
  |             (define-key gtags-mode-map [mouse-2] 'gtags-find-tag-by-event))
  |))
  | 
  |(setq gtags-select-mode-hook
  |   '(lambda ()
  |         (if (not gtags-running-xemacs) nil
  |             (define-key gtags-select-mode-map 'button3 'gtags-pop-stack)
  |             (define-key gtags-select-mode-map 'button2 'gtags-select-tag-by-event))
  |         (if gtags-running-xemacs nil
  |             (define-key gtags-select-mode-map [mouse-3] 'gtags-pop-stack)
  |             (define-key gtags-select-mode-map [mouse-2] 'gtags-select-tag-by-event))
  |))

As a result, the following mappings remain assuming that is compulsory.

(define-key gtags-mode-map "\e*" 'gtags-pop-stack)
(define-key gtags-mode-map "\e." 'gtags-find-tag)
(define-key gtags-mode-map "\C-x4." 'gtags-find-tag-other-window)

(define-key gtags-select-mode-map "\e*" 'gtags-pop-stack)
(define-key gtags-select-mode-map "\^?" 'scroll-down)
(define-key gtags-select-mode-map " " 'scroll-up)
(define-key gtags-select-mode-map "\C-b" 'scroll-down)
(define-key gtags-select-mode-map "\C-f" 'scroll-up)
(define-key gtags-select-mode-map "k" 'previous-line)
(define-key gtags-select-mode-map "j" 'next-line)
(define-key gtags-select-mode-map "p" 'previous-line)
(define-key gtags-select-mode-map "n" 'next-line)
(define-key gtags-select-mode-map "q" 'gtags-pop-stack)
(define-key gtags-select-mode-map "u" 'gtags-pop-stack)
(define-key gtags-select-mode-map "\C-t" 'gtags-pop-stack)
(define-key gtags-select-mode-map "\C-m" 'gtags-select-tag)
(define-key gtags-select-mode-map "\C-o" 'gtags-select-tag-other-window)
(define-key gtags-select-mode-map "\e." 'gtags-select-tag)

What do you think?
--
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


From MAILER-DAEMON Tue Jan 18 00:46:25 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Pf4Of-0004D9-AD
	for mharc-bug-global@gnu.org; Tue, 18 Jan 2011 00:46:25 -0500
Received: from [140.186.70.92] (port=53248 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf43M-0000VG-Az
	for bug-global@gnu.org; Tue, 18 Jan 2011 00:24:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1Pf43K-0007K1-8Q
	for bug-global@gnu.org; Tue, 18 Jan 2011 00:24:24 -0500
Received: from e28smtp07.in.ibm.com ([122.248.162.7]:57598)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>)
	id 1Pf43J-0007Iv-K1; Tue, 18 Jan 2011 00:24:22 -0500
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp07.in.ibm.com (8.14.4/8.13.1) with ESMTP id p0I5OFS4016643;
	Tue, 18 Jan 2011 10:54:15 +0530
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p0I5OETw1822844; Tue, 18 Jan 2011 10:54:14 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p0I5OEac002551; Tue, 18 Jan 2011 16:24:14 +1100
Received: from skywalker.linux.vnet.ibm.com ([9.124.35.42])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id
	p0I5OEYV002538; Tue, 18 Jan 2011 16:24:14 +1100
From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Shigio YAMAGUCHI <shigio@gnu.org>, bug-global@gnu.org
In-Reply-To: <201101180344.p0I3iEtW002481@tamacom.com>
References: <201101180344.p0I3iEtW002481@tamacom.com>
User-Agent: Notmuch/0.5-32-gf6c60cc (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Tue, 18 Jan 2011 10:54:14 +0530
Message-ID: <87hbd6hji9.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Mailman-Approved-At: Tue, 18 Jan 2011 00:46:23 -0500
Cc: 
Subject: Re: [RFC] Removing pushy mouse key assignment from gtags.el.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2011 05:24:29 -0000

On Tue, 18 Jan 2011 12:44:14 +0900, "Shigio YAMAGUCHI" <shigio@gnu.org> wrote:
> Hi all,
> 
> It seems that a lot of people who are using gtags.el say,
> "Return the default mouse mapping of emacs!"
> I should answer this.
> 
> How about changing gtags.el like follows?
> 
> o All the assignment of mouse key is abolished.
> o Instead, new custom variable 'gtags-suggested-keymap' is added.
> 
>   If you hope old key mapping then you should write your .emacs file
>   like this:
>   [$HOME/.emacs]
>   +------------------------------------------------
>   |(setq gtags-mode-hook
>   |  '(lambda ()
>   |        (setq gtags-suggested-keymap t)
>   |))
> 
>   This is equivalent to the following settings:
>   [$HOME/.emacs]
>   +------------------------------------------------
>   |(setq gtags-mode-hook
>   |   '(lambda ()
>   |         (define-key gtags-mode-map "\eh" 'gtags-display-browser)
>   |         (define-key gtags-mode-map "\C-]" 'gtags-find-tag-from-here)
>   |         (define-key gtags-mode-map "\C-t" 'gtags-pop-stack)
>   |         (define-key gtags-mode-map "\el" 'gtags-find-file)
>   |         (define-key gtags-mode-map "\eg" 'gtags-find-with-grep)
>   |         (define-key gtags-mode-map "\eI" 'gtags-find-with-idutils)
>   |         (define-key gtags-mode-map "\es" 'gtags-find-symbol)
>   |         (define-key gtags-mode-map "\er" 'gtags-find-rtag)
>   |         (define-key gtags-mode-map "\et" 'gtags-find-tag)
>   |         (define-key gtags-mode-map "\ev" 'gtags-visit-rootdir)
>   |         (if (not gtags-running-xemacs) nil
>   |             (define-key gtags-mode-map 'button3 'gtags-pop-stack)
>   |             (define-key gtags-mode-map 'button2 'gtags-find-tag-by-event))
>   |         (if gtags-running-xemacs nil
>   |             (define-key gtags-mode-map [mouse-3] 'gtags-pop-stack)
>   |             (define-key gtags-mode-map [mouse-2] 'gtags-find-tag-by-event))
>   |))
>   | 
>   |(setq gtags-select-mode-hook
>   |   '(lambda ()
>   |         (if (not gtags-running-xemacs) nil
>   |             (define-key gtags-select-mode-map 'button3 'gtags-pop-stack)
>   |             (define-key gtags-select-mode-map 'button2 'gtags-select-tag-by-event))
>   |         (if gtags-running-xemacs nil
>   |             (define-key gtags-select-mode-map [mouse-3] 'gtags-pop-stack)
>   |             (define-key gtags-select-mode-map [mouse-2] 'gtags-select-tag-by-event))
>   |))
> 
> As a result, the following mappings remain assuming that is compulsory.
> 
> (define-key gtags-mode-map "\e*" 'gtags-pop-stack)
> (define-key gtags-mode-map "\e." 'gtags-find-tag)
> (define-key gtags-mode-map "\C-x4." 'gtags-find-tag-other-window)
> 
> (define-key gtags-select-mode-map "\e*" 'gtags-pop-stack)
> (define-key gtags-select-mode-map "\^?" 'scroll-down)
> (define-key gtags-select-mode-map " " 'scroll-up)
> (define-key gtags-select-mode-map "\C-b" 'scroll-down)
> (define-key gtags-select-mode-map "\C-f" 'scroll-up)
> (define-key gtags-select-mode-map "k" 'previous-line)
> (define-key gtags-select-mode-map "j" 'next-line)
> (define-key gtags-select-mode-map "p" 'previous-line)
> (define-key gtags-select-mode-map "n" 'next-line)
> (define-key gtags-select-mode-map "q" 'gtags-pop-stack)
> (define-key gtags-select-mode-map "u" 'gtags-pop-stack)
> (define-key gtags-select-mode-map "\C-t" 'gtags-pop-stack)
> (define-key gtags-select-mode-map "\C-m" 'gtags-select-tag)
> (define-key gtags-select-mode-map "\C-o" 'gtags-select-tag-other-window)
> (define-key gtags-select-mode-map "\e." 'gtags-select-tag)
> 
> What do you think?

Any chance of getting the per-frame tag stack. 

http://lists.gnu.org/archive/html/bug-global/2009-03/msg00002.html

-aneesh


From MAILER-DAEMON Tue Jan 18 02:27:30 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Pf5yU-0003Bm-PQ
	for mharc-bug-global@gnu.org; Tue, 18 Jan 2011 02:27:30 -0500
Received: from [140.186.70.92] (port=44483 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf5yT-0003Bh-0J
	for bug-global@gnu.org; Tue, 18 Jan 2011 02:27:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1Pf5yR-0007vO-Ox
	for bug-global@gnu.org; Tue, 18 Jan 2011 02:27:28 -0500
Received: from msa105lp.auone-net.jp ([222.3.140.168]:44097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shigio@tamacom.com>)
	id 1Pf5yR-0007vF-Fx; Tue, 18 Jan 2011 02:27:27 -0500
Received: from choota.tamacom.com (KHP059138043202.ppp-bb.dion.ne.jp
	[59.138.43.202])
	by msa105lp.auone-net.jp (au one net msa) with ESMTP id 7B7747F003A;
	Tue, 18 Jan 2011 16:27:24 +0900 (JST)
Received: from choota.tamacom.com (localhost [127.0.0.1]) by
	choota.tamacom.com (8.13.6/) with ESMTP id p0I7aPAv003514;
	Tue, 18 Jan 2011 16:36:25 +0900 (JST)
Message-Id: <201101180736.p0I7aPAv003514@tamacom.com>
To: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
From: "Shigio YAMAGUCHI" <shigio@gnu.org>
References: <87hbd6hji9.fsf@linux.vnet.ibm.com>
In-reply-to: Message from "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
	of "Tue,
	18 Jan 2011 10:54:14 +0530." <87hbd6hji9.fsf@linux.vnet.ibm.com>
Date: Tue, 18 Jan 2011 16:36:25 +0900
Sender: shigio@tamacom.com
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
Cc: bug-global@gnu.org
Subject: Re: gtags.el and gtags-pop-stack
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2011 07:27:30 -0000

Hi,
> Any chance of getting the per-frame tag stack. 
> 
> http://lists.gnu.org/archive/html/bug-global/2009-03/msg00002.html

I hasitate to adopt this patch as it is, because though the tag stack
is certainly managed per frame, the operation of the stack is not
completely separate.

I can adopt this if it meets the following requirements:

o Any pop-stack doesn't cause 'Selecting deleted buffer' error.
  (Pop-stack should leave the buffers which exist in other stacks.)
o Any Pop-stack in a frame doesn't influence other frames which treat
  the same file.

It apologizes for my neglecting this matter.
Shigio
--
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


From MAILER-DAEMON Wed Jan 19 04:22:04 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PfUEu-0008UJ-Nu
	for mharc-bug-global@gnu.org; Wed, 19 Jan 2011 04:22:04 -0500
Received: from [140.186.70.92] (port=54534 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfUEs-0008Td-Ko
	for bug-global@gnu.org; Wed, 19 Jan 2011 04:22:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PfUEr-0005WD-G0
	for bug-global@gnu.org; Wed, 19 Jan 2011 04:22:02 -0500
Received: from lo.gmane.org ([80.91.229.12]:59845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PfUEr-0005Vz-AP
	for bug-global@gnu.org; Wed, 19 Jan 2011 04:22:01 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gnu-bug-global@m.gmane.org>) id 1PfUEn-0000r6-M9
	for bug-global@gnu.org; Wed, 19 Jan 2011 10:21:57 +0100
Received: from gateway.shenick.com ([62.77.176.130])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Wed, 19 Jan 2011 10:21:57 +0100
Received: from Marc.Herbert by gateway.shenick.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <bug-global@gnu.org>; Wed, 19 Jan 2011 10:21:57 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-global@gnu.org
From: Marc Herbert <Marc.Herbert@gmail.com>
Date: Wed, 19 Jan 2011 09:22:29 +0000
Lines: 30
Message-ID: <ih6afa$7gc$1@dough.gmane.org>
References: <201101180344.p0I3iEtW002481@tamacom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: gateway.shenick.com
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14
	Thunderbird/3.1.7
In-Reply-To: <201101180344.p0I3iEtW002481@tamacom.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [RFC] Removing pushy mouse key assignment from gtags.el.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jan 2011 09:22:03 -0000

Le 18/01/2011 03:44, Shigio YAMAGUCHI a =C3=A9crit :
> Hi all,
>=20
> It seems that a lot of people who are using gtags.el say,
> "Return the default mouse mapping of emacs!"
> I should answer this.
>=20
> How about changing gtags.el like follows?
>=20
> o Instead, new custom variable 'gtags-suggested-keymap' is added.

Hi,

 If users have complained about the mouse only, then it might be best not=

to link mouse and keyboard shortcuts in the same variable but have
instead a simple way to disable mouse bindings only.

> o All the assignment of mouse key is abolished.

Assuming there is a custom toggle for mouse bindings, then I wish they
are still enabled by default. Otherwise all new users will miss and
never know about this great feature. Those who do not like them
will for sure instinctively think about customization when looking for
a simple way to disable them.

Cheers,

Marc




From MAILER-DAEMON Wed Jan 19 08:36:20 2011
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1PfYCy-0008PY-2y
	for mharc-bug-global@gnu.org; Wed, 19 Jan 2011 08:36:20 -0500
Received: from [140.186.70.92] (port=49669 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfYCv-0008OF-MQ
	for bug-global@gnu.org; Wed, 19 Jan 2011 08:36:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1PfYCu-0008Ad-Gy
	for bug-global@gnu.org; Wed, 19 Jan 2011 08:36:17 -0500
Received: from msa106lp.auone-net.jp ([222.3.140.169]:54499)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shigio@tamacom.com>) id 1PfYCu-00089g-6J
	for bug-global@gnu.org; Wed, 19 Jan 2011 08:36:16 -0500
Received: from choota.tamacom.com (KHP059138043202.ppp-bb.dion.ne.jp
	[59.138.43.202])
	by msa106lp.auone-net.jp (au one net msa) with ESMTP id 1739194036;
	Wed, 19 Jan 2011 22:36:09 +0900 (JST)
Received: from choota.tamacom.com (localhost [127.0.0.1]) by
	choota.tamacom.com (8.13.6/) with ESMTP id p0JDjCbf011204;
	Wed, 19 Jan 2011 22:45:12 +0900 (JST)
Message-Id: <201101191345.p0JDjCbf011204@tamacom.com>
To: Marc Herbert <Marc.Herbert@gmail.com>
From: "Shigio YAMAGUCHI" <shigio@gnu.org>
References: <ih6afa$7gc$1@dough.gmane.org>
In-reply-to: Message from Marc Herbert <Marc.Herbert@gmail.com>
	of "Wed, 19 Jan 2011 09:22:29 GMT." <ih6afa$7gc$1@dough.gmane.org>
Date: Wed, 19 Jan 2011 22:45:12 +0900
Sender: shigio@tamacom.com
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
Cc: bug-global@gnu.org
Subject: Re: [RFC] Removing pushy mouse key assignment from gtags.el.
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jan 2011 13:36:18 -0000

>  If users have complained about the mouse only, then it might be best not=
> 
> to link mouse and keyboard shortcuts in the same variable but have
> instead a simple way to disable mouse bindings only.
> 
> > o All the assignment of mouse key is abolished.
> 
> Assuming there is a custom toggle for mouse bindings, then I wish they
> are still enabled by default. Otherwise all new users will miss and
> never know about this great feature. Those who do not like them
> will for sure instinctively think about customization when looking for
> a simple way to disable them.

What you say is justifiable. I seem to have forgotten beginner's standpoint.
Additionally, your method is simple and will cause less confusion.

I changed the plan as follows. 

o New custom variable 'gtags-disable-pushy-mouse-mapping' is added.

  If this variable is set, then all mouse key mappings are not done.
  The other key mapping remains before.

  [$HOME/.emacs]
  +------------------------------------------------
  |(setq gtags-mode-hook
  |  '(lambda ()
  |        (setq gtags-disable-pushy-mouse-mapping t)
  |))

What do you think?
--
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


