From MAILER-DAEMON Fri Jan 13 01:58:12 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cRvoS-0006DO-RJ
	for mharc-bug-global@gnu.org; Fri, 13 Jan 2017 01:58:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cRvoQ-0006Bs-6W
	for bug-global@gnu.org; Fri, 13 Jan 2017 01:58:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cRvoN-0006pj-1t
	for bug-global@gnu.org; Fri, 13 Jan 2017 01:58:10 -0500
Received: from nm12-vm4.bullet.mail.ne1.yahoo.com ([98.138.91.172]:36429)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cRvoM-0006pU-KY
	for bug-global@gnu.org; Fri, 13 Jan 2017 01:58:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048;
	t=1484290684; bh=YOSQbYIOEMsnVZ8GNLxhp+8SaWZLpDuCx/RyO+0ZNlg=;
	h=To:From:Subject:Date:From:Subject;
	b=CRv5EMF2oA3OYtKJcTVNdC03KAfho3k8PcRnUPXliF9e/kbZFIZuiFrS3lv/OE6FAQPCYH1TjMmaNSNMjcy/P27PFpp+PpFwKlg9EX3G2kb9HmrNHkuCA16p25VWHs25mm9NW6DO4XPLWzcemIREyLgtXiyvXKkK/1zjSiAeRZqwRYBxOO+kW5w/t8Yd2ZdWnZ4Gx5j3V7SS4xLFdZZb5/XGP/rdRusdRqXzMVcbt6/kRbdxtE+OU06nl7XbbersCwPdDHQ71fwckdVJYRGilhI0Nv7dlfBeILreZ5N/1VFl5L51VQQI+vuhhX6Eg6xtgDBsnSdT3RmxjgIcLVJi9w==
Received: from [98.138.101.132] by nm12.bullet.mail.ne1.yahoo.com with NNFMP;
	13 Jan 2017 06:58:04 -0000
Received: from [98.138.226.130] by tm20.bullet.mail.ne1.yahoo.com with NNFMP;
	13 Jan 2017 06:58:04 -0000
Received: from [127.0.0.1] by smtp217.mail.ne1.yahoo.com with NNFMP;
	13 Jan 2017 06:58:04 -0000
X-Yahoo-Newman-Id: 734683.18713.bm@smtp217.mail.ne1.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: 2uG.OUsVM1l9jHGc0qUFLPR1gVBs9J17v5p7yR3AVEKSGzH
	Jw7I3xx04jn50grlNy2Pc8KO1rjElisi8UTZg4qBxOlHwZub8T93yUigIsjN
	L1HETNiIicZSlEfOzR8RN.c4edhMl9pg0LoeCzetrRsMdBuDSm0CvKrhCpJZ
	DPNtDHApQpQSmDDWHvuxWWvxy2KRCnA9jK81R7VSU9iBaUQCvLJNqgLaYXoz
	e936URs.6DBOZuTCwzTXpAd7vFx.UdCM_JAv2Cr.KRhn6.6sgnas1PPC2b0.
	Y4wl0T862wFIDhEHfvvkzTKq6KWk2GBnyS0zu6y7_Jjlr19pIumxsBnORElj
	UdrGeHXzNRFtVWZEbbGiiQHvsZQmoCqrqziHQcleLiIxfc2eNjvsE86pZZXt
	LDuDhAOZV_1eK9rECc.ujH6mgA1neknH1jb8Ggq1WLEoaXXFRJmYfSSu9Mfh
	wNp4EbfHrVCC.y9i.LzWQrODiojVRHdIhQpiqpGR22oqiiruKUeL5pUVKL_z
	IPb3ANME.4RIC62z1.yFpU5CJXuBhAiaoheUqENA-
X-Yahoo-SMTP: merhD1KswBCOGgml8bVfL5NEUQ--
To: "bug-global@gnu.org" <bug-global@gnu.org>
From: Jason Hood <jadoxa@yahoo.com.au>
Subject: GLOBAL 6.5.6 minor patches
Message-ID: <b4379b37-21bb-afff-3325-6dc4309ab4c4@yahoo.com.au>
Date: Fri, 13 Jan 2017 16:57:48 +1000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
	Thunderbird/45.1.1
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------92D60C3FA3EF7BF84D5D93DC"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 98.138.91.172
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 06:58:11 -0000

This is a multi-part message in MIME format.
--------------92D60C3FA3EF7BF84D5D93DC
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Just a minor patch to remove some warnings in Windows and tweak
the docs/comments/messages.  Another couple of things I noticed,
but didn't patch:

README - still has "tag system", not "tagging system".

gtags-cscope/manual.in - the backslash in "\'Find functions..."
finds its way into info; perhaps that should be done in convert.pl?

libutil/manual.in - similarly, "quote it by '\\'" keeps the double
backslash in info.

They should probably not even be using quotes (there's also a few
more cases), but @samp or @file or something.

-- 
Jason.

--------------92D60C3FA3EF7BF84D5D93DC
Content-Type: text/plain; charset=UTF-8;
 name="global-6.5.6.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="global-6.5.6.txt"

ZGlmZiAtdXJwIGdsb2JhbC02LjUtNi9nZWNvLnJjIGdsb2JhbC02LjUuNi9nZWNvLnJjCi0t
LSBnbG9iYWwtNi41LTYvZ2Vjby5yYwkyMDE2LTEyLTE5IDEwOjU3OjE4ICsxMDAwCisrKyBn
bG9iYWwtNi41LjYvZ2Vjby5yYwkyMDE3LTAxLTEyIDExOjQ4OjUzICsxMDAwCkBAIC0yMiw3
ICsyMiw3IEBACiAjIEF1dGhvcjogVGFtYSBDb21tdW5pY2F0aW9ucyBDb3Jwb3JhdGlvbgog
IyAKICMgR2VjbyBpcyBhIHF1aWNrIHZpZXcgdG9vbCBmb3IgR0xPQkFMIHVzaW5nIHBlcmNv
bCBhbmQgbGVzcy4KLSMgSXQgaXMgdXNlZnVsIGFzIGEgbGFuY2ggcGFkIGZvciB2aSBlZGl0
b3IuCisjIEl0IGlzIHVzZWZ1bCBhcyBhIGxhdW5jaCBwYWQgZm9yIHZpIGVkaXRvci4KICMK
ICMgRmVhdHVyZXM6CiAjIG8gQ29tbWFuZCBsaW5lIGlucHV0IGNvbXBsZXRpb24gdXNpbmcg
X19nZWNvX2NvbXBsZXRpb24oKQpAQCAtOTMsNyArOTMsNyBAQCBnZWNvbGVzcygpCiB7CiAJ
bG9jYWwgbGluZSBJRlM9CiAJY2FzZSAkX19ndGFnc19nZWNvX3NlbGVjdG9yIGluCi0JJycp
CWVjaG8gImdlY286IHBlcmNvbCBvciBwZWNvIGlzIHJlcXVpcmVkLiIKKwknJykJZWNobyAi
Z2VjbzogcGVyY29sLCBwZWNvIG9yIGZ6ZiBpcyByZXF1aXJlZC4iCiAJCXJldHVybiAxOzsK
IAllc2FjCiAJbGluZT0kKGNhdCkKZGlmZiAtdXJwIGdsb2JhbC02LjUtNi9ndGFncy9ndGFn
cy5jIGdsb2JhbC02LjUuNi9ndGFncy9ndGFncy5jCi0tLSBnbG9iYWwtNi41LTYvZ3RhZ3Mv
Z3RhZ3MuYwkyMDE2LTEyLTE5IDEwOjU3OjE4ICsxMDAwCisrKyBnbG9iYWwtNi41LjYvZ3Rh
Z3MvZ3RhZ3MuYwkyMDE3LTAxLTEzIDExOjQ3OjE4ICsxMDAwCkBAIC0yMjIsNyArMjIyLDcg
QEAgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAJCQlhcmd2ID0gcHJlcGVuZF9vcHRp
b25zKCZhcmdjLCBhcmd2LCBlbnYpOwogCX0KIAkvKgotCSAqIEV4ZWN1dGUgZ3RhZ3NfaG9v
ayBiZWZvcmUgdGhlIGpvZ3MuCisJICogRXhlY3V0ZSBndGFnc19ob29rIGJlZm9yZSB0aGUg
am9icy4KIAkgKi8KIAlpZiAoZ2V0Y29uZnMoImd0YWdzX2hvb2siLCBzYikpIHsKIAkJY2hh
ciAqcCA9IHNlcmlhbGl6ZV9vcHRpb25zKGFyZ2MsIGFyZ3YpOwpAQCAtMzU3LDcgKzM1Nyw3
IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogCQkJZGllKCJpbnZhbGlkIHZlcnNp
b24gc3RyaW5nIG9mIG1raWQ6ICVzIiwgc3RyYnVmX3ZhbHVlKHNiKSk7CiAJCXN3aXRjaCAo
Y2hlY2tfdmVyc2lvbihwICsgMSwgUkVRVUlSRURfTUtJRF9WRVJTSU9OKQogI2lmZGVmIF9X
SU4zMgotCQkJfHwgc3RyY21wKHAgKyAxLCAiMy4yLjk5IikgPT0gMAorCQkJfCBzdHJjbXAo
cCArIDEsICIzLjIuOTkiKSA9PSAwCiAjZW5kaWYKIAkJCSkgIHsKIAkJY2FzZSAxOgkJYnJl
YWs7CS8qIE9LICovCmRpZmYgLXVycCBnbG9iYWwtNi41LTYvZ3RhZ3MvbWFudWFsLmluIGds
b2JhbC02LjUuNi9ndGFncy9tYW51YWwuaW4KLS0tIGdsb2JhbC02LjUtNi9ndGFncy9tYW51
YWwuaW4JMjAxNi0xMi0xOSAxMDo1NzoxOCArMTAwMAorKysgZ2xvYmFsLTYuNS42L2d0YWdz
L21hbnVhbC5pbgkyMDE3LTAxLTEzIDEwOjI0OjA1ICsxMDAwCkBAIC02OCw3ICs2OCw3IEBA
CiAJCVRoZSBhcmd1bWVudCBAYXJne2ZpbGV9IGNhbiBiZSBzZXQgdG8gQHZhbHstfSB0byBh
Y2NlcHQgYSBsaXN0IG9mCiAJCWZpbGVzIGZyb20gdGhlIHN0YW5kYXJkIGlucHV0LgogCQlG
aWxlIG5hbWVzIG11c3QgYmUgc2VwYXJhdGVkIGJ5IG5ld2xpbmUuCi0JCVRvIG1ha2UgdGhl
IGxpc3QsIHlvdSBtYXkgdXNlIEB4cmVme2ZpbmQsMX0gd2hpY2ggaGFzIHJpY2ggb3B0aW9u
cworCQlUbyBtYWtlIHRoZSBsaXN0IHlvdSBtYXkgdXNlIEB4cmVme2ZpbmQsMX0sIHdoaWNo
IGhhcyByaWNoIG9wdGlvbnMKIAkJZm9yIHNlbGVjdGluZyBmaWxlcy4KIAlAaXRlbXtAb3B0
aW9uey0tZ3RhZ3Njb25mfSBAYXJne2ZpbGV9fQogCQlTZXQgZW52aXJvbm1lbnQgdmFyaWFi
bGUgQHZhcntHVEFHU0NPTkZ9IHRvIEBhcmd7ZmlsZX0uCkBAIC0xNDksOSArMTQ5LDkgQEAK
IAkJSWYgdGhpcyB2YXJpYWJsZSBpcyBzZXQsIEBmaWxleyRHVEFHU0xPR0dJTkd9IGlzIHVz
ZWQgYXMgdGhlIHBhdGggbmFtZQogCQlvZiBhIGxvZyBmaWxlLiBUaGVyZSBpcyBubyBkZWZh
dWx0IHZhbHVlLgogCUBpdGVte0B2YXJ7R1RBR1NfQ09NTUFORExJTkV9fQotCQlUaGlzIHZh
cmlhYmxlIGNhbiBvbmx5IGJlIHJlZmVyZW5jZWQgZnJvbSB0aGUgaG9vayAoU2VlIGd0YWdz
X2hvb2spLgotCQlAbmFtZXtHdGFnc30gc2V0IGl0cyBvd24gZWZmZWN0aXZlIGNvbW1hbmQg
bGluZSB0byB0aGlzIHZhcmlhYmxlIGJlZm9yZQotCQljYWxsaW5nIHRoZSBob29rLiBFYWNo
IGFyZ3VtZW50IGlzIHNlcGFsYXRlZCBieSB3aGl0ZXNwYWNlLCBhbmQKKwkJVGhpcyB2YXJp
YWJsZSBjYW4gb25seSBiZSByZWZlcmVuY2VkIGZyb20gdGhlIGhvb2sgKHNlZSBndGFnc19o
b29rKS4KKwkJQG5hbWV7R3RhZ3N9IHNldHMgaXRzIG93biBlZmZlY3RpdmUgY29tbWFuZCBs
aW5lIHRvIHRoaXMgdmFyaWFibGUgYmVmb3JlCisJCWNhbGxpbmcgdGhlIGhvb2suIEVhY2gg
YXJndW1lbnQgaXMgc2VwYXJhdGVkIGJ5IHdoaXRlc3BhY2UsIGFuZAogCQlyZWFsIHdoaXRl
c3BhY2UgaXMgcmVwcmVzZW50ZWQgYXMgJyUyMCcuIFRoaXMgaXMgcmVhZCBvbmx5LgogCUBp
dGVte0B2YXJ7R1RBR1NfT1BUSU9OU319CiAJCVRoZSB2YWx1ZSBvZiB0aGlzIHZhcmlhYmxl
IGlzIGluc2VydGVkIGluIHRoZSBoZWFkIG9mIGFyZ3VtZW50cy4KQEAgLTE3OSw3ICsxNzks
NyBAQAogCUBpdGVte0Bjb2Rle2d0YWdzX2hvb2t9IChjb21tYW5kIGxpbmUpfQogCQlTcGVj
aWZ5IGEgY29tbWFuZCBsaW5lIHdoaWNoIHNob3VsZCBiZSBleGVjdXRlZCBhdCB0aGUgYmVn
aW5uaW5nIG9mIEBuYW1le2d0YWdzfQogCQlhZnRlciBsb2FkaW5nIGNvbmZpZ3VyYXRpb24g
ZmlsZS4gWW91IGNhbiB1c2UgdGhpcyBob29rIHRvIHVwZGF0ZQotCQlAZmlsZXtndGFncy5m
aWxlc30gZHluYW1pY2FsbHkuLgorCQlAZmlsZXtndGFncy5maWxlc30gZHluYW1pY2FsbHku
CiAJCSIuLyIgaW4gaXQgYWx3YXlzIG1lYW5zIHRoZSBwcm9qZWN0IHJvb3QgZGlyZWN0b3J5
LCBzaW5jZSBAbmFtZXtndGFnc30gaXMKIAkJYWx3YXlzIGludm9rZWQgdGhlcmUuCiAJQGl0
ZW17QGNvZGV7aWNhc2VfcGF0aH0gKGJvb2xlYW4pfQpAQCAtMjAyLDcgKzIwMiw3IEBACiAJ
CUBicgogCQlJZiB0aGUgdmFsdWUgc3RhcnRzIHdpdGggQHNhbXB7L30sIGl0IGlzIGFzc3Vt
ZWQgYSByZWxhdGl2ZSBwYXRoIG5hbWUKIAkJZnJvbSB0aGUgcm9vdCBkaXJlY3Rvcnkgb2Yg
dGhlIHByb2plY3QuIFlvdSBjYW5ub3QgdXNlIGdsb2IgcGF0dGVybnMKLQkJZm9yIGEgcGF0
aCBuYW1lLiBIb3dldmVyLCB0aGlzIGRpcmVjdGlvbnMgaXMgb3V0LW9mLWRhdGUsIGFuZCBp
cyBub3QKKwkJZm9yIGEgcGF0aCBuYW1lLiBIb3dldmVyLCB0aGlzIGRpcmVjdGlvbiBpcyBv
dXQtb2YtZGF0ZSwgYW5kIGlzIG5vdAogCQlyZWNvbW1lbmRlZC4gSW5zdGVhZCwgeW91IGNh
biB1c2UgQG9wdGlvbnstZn0gb3B0aW9uIHdoaWNoIGNhbiBiZSBjb21iaW5lZCB3aXRoCiAJ
CUB4cmVme2ZpbmQsMX0uIFNpbmNlIEB4cmVme2ZpbmQsMX0gaGFzIHJpY2ggb3B0aW9ucyB0
byBzZWxlY3QgZmlsZXMsCiAJCXlvdSBjYW4gZG8gZXZlcnl0aGluZy4gQWRkaXRpb25hbGx5
LCB0aGlzIHRlY2huaXF1ZSBjYW4gYWxzbyBiZSBhcHBsaWVkCmRpZmYgLXVycCBnbG9iYWwt
Ni41LTYvZ3RhZ3MuY29uZi5pbiBnbG9iYWwtNi41LjYvZ3RhZ3MuY29uZi5pbgotLS0gZ2xv
YmFsLTYuNS02L2d0YWdzLmNvbmYuaW4JMjAxNi0xMi0xOSAxMDo1NzoxOCArMTAwMAorKysg
Z2xvYmFsLTYuNS42L2d0YWdzLmNvbmYuaW4JMjAxNy0wMS0xMyAxMDozNTozNiArMTAwMApA
QCAtMTcsNyArMTcsNyBAQAogIyBDb25maWd1cmF0aW9uIGZpbGUgZm9yIEdOVSBHTE9CQUwg
c291cmNlIGNvZGUgdGFnIHN5c3RlbS4KICMKICMgQmFzaWNhbGx5LCBHTE9CQUwgZG9lc24n
dCBuZWVkIHRoaXMgY29uZmlndXJhdGlvbiBmaWxlICgnZ3RhZ3MuY29uZicpLAotIyBiZWNh
dXNlIGl0IGhhcyBkZWZhdWx0IHZhbHVlcyBpbiBpdHNzZWxmLiBJZiB5b3UgaGF2ZSB0aGlz
IGZpbGUgYXMKKyMgYmVjYXVzZSBpdCBoYXMgZGVmYXVsdCB2YWx1ZXMgaW4gaXRzZWxmLiBJ
ZiB5b3UgaGF2ZSB0aGlzIGZpbGUgYXMKICMgJy9ldGMvZ3RhZ3MuY29uZicgb3IgIiRIT01F
Ly5nbG9iYWxyYyIgdGhlbiBHTE9CQUwgb3ZlcndyaXRlIHRoZSBkZWZhdWx0CiAjIHZhbHVl
cyB3aXRoIHZhbHVlcyBpbiB0aGUgZmlsZS4KICMgQ29uZmlndXJhdGlvbiBmaWxlIGlzIGFs
c28gbmVjZXNzYXJ5IHRvIHVzZSBwbHVnLWluIHBhcnNlcnMuCmRpZmYgLXVycCBnbG9iYWwt
Ni41LTYvbGlidXRpbC9hcmdzLmMgZ2xvYmFsLTYuNS42L2xpYnV0aWwvYXJncy5jCi0tLSBn
bG9iYWwtNi41LTYvbGlidXRpbC9hcmdzLmMJMjAxNi0xMi0xOSAxMDo1NzoxOCArMTAwMAor
KysgZ2xvYmFsLTYuNS42L2xpYnV0aWwvYXJncy5jCTIwMTctMDEtMTMgMTE6Mzk6NDggKzEw
MDAKQEAgLTI5LDYgKzI5LDkgQEAKICNpbmNsdWRlICJzdHJidWYuaCIKICNpbmNsdWRlICJ0
ZXN0LmgiCiAjaW5jbHVkZSAiZ3BhdGhvcC5oIgorI2lmIChkZWZpbmVkKF9XSU4zMikgJiYg
IWRlZmluZWQoX19DWUdXSU5fXykpIHx8IGRlZmluZWQoX19ESkdQUF9fKQorI2luY2x1ZGUg
InBhdGguaCIKKyNlbmRpZgogCiAjZGVmaW5lIEFSR1NfTk9QCTAKICNkZWZpbmUgQVJHU19B
UkdTCTEKZGlmZiAtdXJwIGdsb2JhbC02LjUtNi9saWJ1dGlsL21ha2VwYXRoLmMgZ2xvYmFs
LTYuNS42L2xpYnV0aWwvbWFrZXBhdGguYwotLS0gZ2xvYmFsLTYuNS02L2xpYnV0aWwvbWFr
ZXBhdGguYwkyMDE2LTEyLTE5IDEwOjU3OjE4ICsxMDAwCisrKyBnbG9iYWwtNi41LjYvbGli
dXRpbC9tYWtlcGF0aC5jCTIwMTctMDEtMTMgMTE6Mzg6MTUgKzEwMDAKQEAgLTMzLDYgKzMz
LDkgQEAKICNpbmNsdWRlICJtYWtlcGF0aC5oIgogI2luY2x1ZGUgInN0cmJ1Zi5oIgogI2lu
Y2x1ZGUgInN0cm1ha2UuaCIKKyNpZiBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChfX0RK
R1BQX18pCisjaW5jbHVkZSAicGF0aC5oIgorI2VuZGlmCiAKIC8qKgogICogbWFrZXBhdGg6
IG1ha2UgcGF0aCBmcm9tIGRpcmVjdG9yeSBhbmQgZmlsZS4K
--------------92D60C3FA3EF7BF84D5D93DC--


From MAILER-DAEMON Fri Jan 13 20:39:43 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cSDJn-0006HH-HM
	for mharc-bug-global@gnu.org; Fri, 13 Jan 2017 20:39:43 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cSDJl-0006H2-4U
	for bug-global@gnu.org; Fri, 13 Jan 2017 20:39:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cSDJi-000359-5W
	for bug-global@gnu.org; Fri, 13 Jan 2017 20:39:41 -0500
Received: from nm12-vm6.bullet.mail.ne1.yahoo.com ([98.138.91.105]:39231)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <jadoxa@yahoo.com.au>) id 1cSDJh-00034v-U2
	for bug-global@gnu.org; Fri, 13 Jan 2017 20:39:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048;
	t=1484357976; bh=HgDGEW5zjs8UeYnQhBLmxzFS+z4f9mO0N3ULyfRtOyM=;
	h=Subject:To:References:From:Date:In-Reply-To:From:Subject;
	b=OqUNCJbP2YeZRawKRJwlKWsFVRHliSd66s3ELorMduthSMs64tmB+Wu/fMloaOR+NBUkEf6Cu53NoWsp3oC9qcAoDwb2JxzGkP6GxJIDH6r/8899ovBCjtlg4+9Si1d5lZaopnTaAXmKFihiueMUjS3r8xHWfooIeuaU0dPmzDfsI7u0GsEfb1Xj8IwMKlt2zt4pz0pZmXX842ugF9SymgVNhAWetPRF9LW+FVWk9IwEMQ6LuH9HAssNAnwC67ZzPMB3EpMhxGuMlHSoXGf8MrBSQw6UlGrdENWzz/3y7XQ6uoz2djpONb0h65wtGiGDx5yFdZWO8UAgff4Q9UjKaw==
Received: from [98.138.100.118] by nm12.bullet.mail.ne1.yahoo.com with NNFMP;
	14 Jan 2017 01:39:36 -0000
Received: from [98.138.84.47] by tm109.bullet.mail.ne1.yahoo.com with NNFMP;
	14 Jan 2017 01:39:36 -0000
Received: from [127.0.0.1] by smtp115.mail.ne1.yahoo.com with NNFMP;
	14 Jan 2017 01:39:36 -0000
X-Yahoo-Newman-Id: 279987.96240.bm@smtp115.mail.ne1.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: IusP4esVM1lnbGlqyGKOhHWfTNBXhRwheMeFUhijc71MO5U
	1_fSPHdmdkKvPG9MeInNjhVpFWcuDu5NmXROUBx9r8btO5K4ymgNWPAQUb4M
	V.dVOGYM4zMYZNgrpOUULpSIdgy1jBtdevfiP65KxLPGiUrpjco3IVRboIbm
	uCb3.s1TPEXOnvjqOf3AlrOQTEuMJUmkYnmzrm7bJHIYiE9dC9OjNdfKlZJU
	TRJavi_gIKMfX5wsS4xRbI39iaLc93ppgJA9pYt1un39ZXTP22lJ2NkqlQA7
	9fRJjeYWUahtRDKDKQgri7OeeNe.MsAYYXSDIs8kLeQsyqxh8LLF1UlL52SQ
	2pzOQo06pmaQKYnzbxR3TVJP7DqEAfVatl4XSWZSR4BGsOX9j4XYsmxaNRib
	vbJMaKmFslkp8453XX3HCK00CmkjN2p5LV0.8laSAjMRiP.gYiSxkV5A3KKV
	Yr7ypJBY8bdYd.coEtqIKSFzPgrcXBgvOhwDMU.eiRDz8K00k4xxlUdS5pGq
	9c_j8Eq37ju708l.1QrROfrcAXKIlYLFu0gglOf8-
X-Yahoo-SMTP: merhD1KswBCOGgml8bVfL5NEUQ--
Subject: Re: GLOBAL 6.5.6 minor patches
To: "bug-global@gnu.org" <bug-global@gnu.org>
References: <b4379b37-21bb-afff-3325-6dc4309ab4c4@yahoo.com.au>
From: Jason Hood <jadoxa@yahoo.com.au>
Message-ID: <12c861fe-210d-13a8-2e96-91edfbc98b7d@yahoo.com.au>
Date: Sat, 14 Jan 2017 11:39:16 +1000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
	Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <b4379b37-21bb-afff-3325-6dc4309ab4c4@yahoo.com.au>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 98.138.91.105
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2017 01:39:42 -0000

Oh, another thing I noticed and meant to patch, but somehow missed:

gtags/manual.in - "and etc" should just be "etc" ("et" itself
means "and", hence the alternative abbreviation "&c").

-- 
Jason.


From MAILER-DAEMON Tue Jan 17 21:08:07 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cTffT-0006sD-Ss
	for mharc-bug-global@gnu.org; Tue, 17 Jan 2017 21:08:07 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.tamacom@gmail.com>) id 1cTffR-0006s7-8G
	for bug-global@gnu.org; Tue, 17 Jan 2017 21:08:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <i.tamacom@gmail.com>) id 1cTffP-0007M5-R4
	for bug-global@gnu.org; Tue, 17 Jan 2017 21:08:05 -0500
Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:33749)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <i.tamacom@gmail.com>) id 1cTffP-0007K5-K0
	for bug-global@gnu.org; Tue, 17 Jan 2017 21:08:03 -0500
Received: by mail-lf0-x236.google.com with SMTP id k86so122114829lfi.0
	for <bug-global@gnu.org>; Tue, 17 Jan 2017 18:08:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=mime-version:sender:from:date:message-id:subject:to;
	bh=s/bNFYpX3j6spawLYemBHr9F861VibjOnOtMve9TNLM=;
	b=DUs3nQOF5qFQ9HacRwMCYv+02QEH8rYNIX25g32K7lfkoJ9fxk8WGCAAmXlQaaTKJE
	butay38RkpykORTE03SUAvzcqfLu3uVpFVH3iS8du8wT/lroD9PfjL/5WTURa2TDDB3h
	kSYseiKGylY3tkEZrjD5c8gor1mIrdeLmcmPIZWk49sZGnOHWOfzjwoTcaHfRnwfKML9
	SpGxmWVj2M2+0WBmmUupxh5+0ZtuxlrC/3GKFGt1e4Q9U2hmyHZ8Fl298FySakuQkgwS
	+35T8cT6QvKnDqs4FI9hCTvt8rXKGEfw5/cHQEg94UNn8IxCdRTO+/Nj/2xxBtL8ofNm
	Cl4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:sender:from:date:message-id:subject
	:to; bh=s/bNFYpX3j6spawLYemBHr9F861VibjOnOtMve9TNLM=;
	b=gBTfJvn8M3T1yPsd9UlSDCJstV/Y0L9jUSkd5sK5qTZdhZNzHYm1fMTk7Ddtg/Aoja
	NsuZZSJnbEgf3yOTfsqmqoV4+QfmhS9cAd8kxTI0rhMIaV5QLBpCuc3DxyF46LJB4vzY
	FjK3WqwnptVCbkvyx0sTNIogi8fbB4xuWal3bkVoeh6ln++lcFv+w3QZXTfn/3MjTpjd
	+k+HbIqfd7Y5ii4WxGSQuWvg12ASjFSBR0Twg0jyecQ6XN7N2fObhPzQUcT+/lOMRnkp
	1uRt/a4x0iFe2VdDF80OzCCf2cBsBRZYqUs3rQ+6t/Z/tGITbTFOx/C/B226X658ZgM8
	whmg==
X-Gm-Message-State: AIkVDXIbvfd5QOsVjiPKfUd5NA/hsCppDy444UCOiEb0J+pYo99nklcxeTTsNm70zNgRsX/A26aV2eFI+Ihy1A==
X-Received: by 10.25.67.19 with SMTP id q19mr220458lfa.9.1484705280650; Tue,
	17 Jan 2017 18:08:00 -0800 (PST)
MIME-Version: 1.0
Sender: i.tamacom@gmail.com
Received: by 10.25.157.133 with HTTP; Tue, 17 Jan 2017 18:08:00 -0800 (PST)
From: Shigio YAMAGUCHI <shigio@gnu.org>
Date: Wed, 18 Jan 2017 11:08:00 +0900
X-Google-Sender-Auth: Ww81uBX0HyU9fxZbqK0-h2EISjA
Message-ID: <CADJmJYokm=yntmSQriu8kxsn81jyNz8aORyMrTsRRJJ64O7=oA@mail.gmail.com>
Subject: Re: GLOBAL 6.5.6 minor patches
To: Jason Hood <jadoxa@yahoo.com.au>, "bug-global@gnu.org" <bug-global@gnu.org>
Content-Type: multipart/alternative; boundary=f403045ea4ead97118054654e232
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:4010:c07::236
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jan 2017 02:08:06 -0000

--f403045ea4ead97118054654e232
Content-Type: text/plain; charset=UTF-8

Hi,
> Just a minor patch to remove some warnings in Windows and tweak
> the docs/comments/messages.  Another couple of things I noticed,
> but didn't patch:

I have committed it.

> README - still has "tag system", not "tagging system".

I fixed it all into 'tagging system'.

> gtags-cscope/manual.in - the backslash in "\'Find functions..."
> finds its way into info; perhaps that should be done in convert.pl?
>
> libutil/manual.in - similarly, "quote it by '\\'" keeps the double
> backslash in info.
>
> They should probably not even be using quotes (there's also a few
> more cases), but @samp or @file or something.

I used @samp for them.

> gtags/manual.in - "and etc" should just be "etc" ("et" itself
> means "and", hence the alternative abbreviation "&c").

I fixed it.

Thank you always.

Regards,
-- 
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3

--f403045ea4ead97118054654e232
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,<br></div><div>&gt; Just a minor patch to remove s=
ome warnings in Windows and tweak</div><div>&gt; the docs/comments/messages=
.=C2=A0 Another couple of things I noticed,</div><div>&gt; but didn&#39;t p=
atch:</div><div><br></div><div>I have committed it.</div><div><br></div><di=
v>&gt; README - still has &quot;tag system&quot;, not &quot;tagging system&=
quot;.</div><div><br></div><div>I fixed it all into &#39;tagging system&#39=
;.</div><div><br></div><div>&gt; gtags-cscope/<a href=3D"http://manual.in">=
manual.in</a> - the backslash in &quot;\&#39;Find functions...&quot;</div><=
div>&gt; finds its way into info; perhaps that should be done in <a href=3D=
"http://convert.pl">convert.pl</a>?</div><div>&gt;</div><div>&gt; libutil/<=
a href=3D"http://manual.in">manual.in</a> - similarly, &quot;quote it by &#=
39;\\&#39;&quot; keeps the double</div><div>&gt; backslash in info.</div><d=
iv>&gt;</div><div>&gt; They should probably not even be using quotes (there=
&#39;s also a few</div><div>&gt; more cases), but @samp or @file or somethi=
ng.</div><div><br></div><div>I used @samp for them.</div><div><br></div><di=
v>&gt; gtags/<a href=3D"http://manual.in">manual.in</a> - &quot;and etc&quo=
t; should just be &quot;etc&quot; (&quot;et&quot; itself</div><div>&gt; mea=
ns &quot;and&quot;, hence the alternative abbreviation &quot;&amp;c&quot;).=
</div><div><br></div><div>I fixed it.</div><div><br></div><div>Thank you al=
ways.</div><div><br></div><div>Regards,</div><div><span style=3D"background=
-color:rgb(255,255,255)">--=C2=A0</span><br></div><div class=3D"gmail_signa=
ture"><div dir=3D"ltr">Shigio YAMAGUCHI &lt;<a href=3D"mailto:shigio@gnu.or=
g" target=3D"_blank">shigio@gnu.org</a>&gt;<div>PGP fingerprint: D1CB 0B89 =
B346 4AB6 5663 =C2=A0C4B6 3CA5 BBB3 57BE DDA3<br></div></div></div>
</div>

--f403045ea4ead97118054654e232--


From MAILER-DAEMON Tue Jan 24 09:04:51 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iN-0003Wf-5y
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:51 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLR-0008Tg-QX
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLR-0007Qk-3j
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:13 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34043)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLQ-0007PV-UA
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:13 -0500
Received: by mail-wm0-x244.google.com with SMTP id c85so29890808wmi.1
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=Q+1nsXhSUpa6/Zaak9nPTPyUl+qUj5xJZ0Q4OowjSv4=;
	b=n6yOxw9MvGYaIy/Y6vQuk23eeFNLR8Oc8OTPQqeePetvVr264ErFXKQr4PvQagsCSy
	0B9a8bejkUxfWu4yWmVjvQDaXx8BMeMjvYO3Uqu1DieyZloYVhT7Sa/sk63pDjjURpxR
	HyYB0u3PsmKG9wXqyQkH7bt69eUzpBZZf4ro6SfwnwlNdX4zKhywBgkZigcJdBu5neLi
	yIDV07R+RQJIkKewxipIO0myztfAVE3fDO+XhZiSRt1fjSP/2b/bX9kUup8LZc19bI0T
	LDNePW/eJIxLmyQ+Nb6MNd9hjKexTHTHYtiO7N099xfPcumyAWAFbtlL2egjhBZ7GzB8
	xGqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=Q+1nsXhSUpa6/Zaak9nPTPyUl+qUj5xJZ0Q4OowjSv4=;
	b=rQv5CAzB5oX0ThCR+62aewcyaVgOCH/LCIFVbKnvbTppasyAM7+yYL1v46ZYsgKCqN
	Ev0A49raOkFdP00tm38vw+ABVDebundLnipnE32MAz/Mg+rWKHQpBq2GOJWjPNTmyt9G
	0468KkdprUwCZAdzRnGRS8mGx56aYth+o6njNgohU95CJRFzRCCaZcsdUAHdJ2VEl/Wr
	VE+xSbR7TBYEq+cQMaHH/UXIA90QdnUVzrL9fuDZ1jre9iLpFgEIsGjkXCu2cyRClRTD
	pHuGjGt3MdaY25ndShXMP2lT9PTp2w0+K+iZ2jiuGLPb3rKXiLupiU55EV6YfppI/Pn+
	Sy2Q==
X-Gm-Message-State: AIkVDXLpAmA55XUqvWpUAvW8mif51xR7pEW2Mu+pFckQVZcYGBJ8ZmmKglqemQHAEk0MrA==
X-Received: by 10.223.135.163 with SMTP id b32mr25664526wrb.184.1485211451884; 
	Mon, 23 Jan 2017 14:44:11 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	o132sm23227967wmo.17.2017.01.23.14.44.11
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:11 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 3/6] libutil: Remove usage of PATH_MAX from getrealpath
Date: Mon, 23 Jan 2017 22:43:36 +0000
Message-Id: <20170123224339.9013-4-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::244
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:17 -0000

When realpath is given a NULL argument, it returns a buffer allocated
with malloc containing the path. Update getrealpath function to rely
on this behaviour instead of using PATH_MAX.

While making this change, verify that callers of getrealpath
responsibly free the returned buffer once they no longer have use for
it.
---
 libutil/find.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index f366004..a009538 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -490,11 +490,11 @@ static int current_entry;			/**< current entry of the stack */
 static char *
 getrealpath(const char *dir)
 {
-	char real[PATH_MAX];
+	char *real;
 
-	if (realpath(dir, real) == NULL)
+	if ((real = realpath(dir, NULL)) == NULL)
 		die("cannot get real path of '%s'.", trimpath(dir));
-	return check_strdup(real);
+	return real;
 }
 /**
  * has_symlinkloop: whether or not dir has a symbolic link loops.
-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:52 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iN-0003X7-Q2
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:51 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLA-0008Ss-Ks
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:43:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnL7-0007CC-Hr
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:43:56 -0500
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34005)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnL7-0007BQ-C8
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:43:53 -0500
Received: by mail-wm0-x241.google.com with SMTP id c85so29888734wmi.1
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:43:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id;
	bh=Fyu9yWGzYrS+A4JOV7Vh6fxJhir/IhswQc6lrsgg8Yc=;
	b=dCKskJa2yml1NTFoaB3Jb8MJA4R8EAu4Vb8ed8at20A8W2LXeJ8c0nPede6Ys1/Bdn
	GZ2jiCeSWMfxw1AASW7sED5vo5+xM9UlTECzvK7dbmXEDOFhdRBhMRn7wRGQEaoomCAN
	T8//sdE2rp1vvBhzKpSQCNA9xjo8BfU3BHeGuUo0q0VdNZAPy9JKdiIHFb8LP3yYjgyS
	fmc85relMQCHK4Bt7tbhJewH/vIdI1+F2PrSfnFk41B8kc+TXQGwAFzJnocLmzMEQpcV
	Y+7Lusp+Kgb7Kqel8P6GYm8UD62fHFC8ac/4gQFNCPhfnEhm4zMTKhKnKzDiW+jqOSwu
	pjjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id;
	bh=Fyu9yWGzYrS+A4JOV7Vh6fxJhir/IhswQc6lrsgg8Yc=;
	b=fcNe7amjB6AqQRjxi/tkXYTUDUu/5TctFfKdlwbqkbf3TRzp26oh6KYPJ1ggKmetCO
	l45NxAJZhOvUGk8qT00eRNx2UhDQTh1iQNt+LAcM8ClEwNjXBdipvvzOAI3/ih4r2Kuh
	QcwpKmZg8vrPjsL/oaCtX1hChrRfoAwNMIZ1qhM/cONv0JzYO/pjJ7wEY6qN6BfvalaX
	92Ne+lujHNI28Y74K+T88xZ3gUPe18TVfz0J/EiE6bNcsmceZQUy1I93P0kgL1MwuPqm
	I804nRPiCVy2F5a0NFxP/R82VJWvZ7/I8CqofmdmDcA0zq86VmL0oL6RF8to6/vFgpJ2
	mPZg==
X-Gm-Message-State: AIkVDXL8BI5/ICl3gIyBXE855MfjMga4+ltUGe9z5IvDVfWxg4CGsOgiVcN0clNILKh0/Q==
X-Received: by 10.223.139.142 with SMTP id o14mr26216931wra.6.1485211430498;
	Mon, 23 Jan 2017 14:43:50 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	y65sm23331398wmb.5.2017.01.23.14.43.49
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:43:49 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 0/6] Enable building Gnu Global package on Hurd
Date: Mon, 23 Jan 2017 22:43:33 +0000
Message-Id: <20170123224339.9013-1-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::241
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:43:58 -0000

Hi,

Gnu Global package in Debian fails to build from source on Hurd[0] as
the build errors out when PATH_MAX is not defined. Here's the snippet
from libutil/find.c that triggers the failure -

#ifndef PATH_MAX
#error Since this platform does not have PATH_MAX, you should define it using an appropriate value for the platform.
/* #define PATH_MAX     1024 */
#endif

On digging futher[2][3], I came to the conclusion that instead of
defining PATH_MAX to a value, the way to fix it would be to change how
paths are handled. Although the changes are not difficult, one needs
to be careful to free the buffers when they are no longer
needed. Thought a bit tedious, the arguments against using PATH_MAX
(but also other similar macros) make sense.

In this series the dependency on PATH_MAX is dropped so that the build
succeeds on Hurd.

Patches 1 & 2 are a couple of minor cleanups. Patch 3-5 update
instances where the macro is used. Patch 6 drops the offending snippet
above.

Before applying the patch to the global package, I was hoping to get
some feedback and a view on whether they could be merged
upstream. There is nothing debian specific in the patches.

I'd also like to take this opportunity to raise the larger question of
how to address similar issues elsewhere in the codebase. A quick grep
shows ~150+ locations where MAXPATHLEN is used. Is there interest to
address this? Would more such patches updating the code be useful?  Or
is there a better way to go about this?

Feedback and opinions welcome.

Thanks,
Punit

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848302
[1] http://cvs.savannah.gnu.org/viewvc/global/global/libutil/find.c?view=markup#l82
[2] https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html
[3] https://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL

Punit Agrawal (6):
  libutil: Drop extraneous function declarations
  libutil: Staticize locally used functions
  libutil: Remove usage of PATH_MAX from getrealpath
  libutil: Remove usage of PATH_MAX from has_symlinkloop
  libutil: Convert rootdir to a dynamically allocated array
  libutil: Drop the requirement for PATH_MAX macro

 libutil/find.c | 219 ++++++++++++++++++++++++++++++---------------------------
 1 file changed, 114 insertions(+), 105 deletions(-)

-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:52 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iO-0003XK-2l
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:52 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLM-0008TI-U6
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLJ-0007Kh-RM
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:08 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34926)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLJ-0007JN-IO
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:05 -0500
Received: by mail-wm0-x244.google.com with SMTP id d140so30055136wmd.2
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=iWqC7DEYcmr8uOTLEd15iB7cXEoErDPBIQmLUUyfmR4=;
	b=JAfgM4ht8VFpSdAevyC6m+Q1D62Gg6+5fnC5wS5wekMvtSgBQ01wBjUz5gP2YVBrXM
	O79xtcO1u2l1dqZua2KjDSqTff1v0AM1loiMnzHb9AdbsTARGBboJxcAdnuy/ZOyoA6y
	RwJwFoqG3xbJuILXhSZSy95enxUtEJC2gdUlfWZaVjlRRIy86ZrYlD9YQyU5DRxjHTUI
	ELW2bu+YTE4Siz0rYV9tXkiNuDkZrvWVi7W+WCgHN27WxHToS7hawUuRpZ+c0TvW5MOG
	mPBggzbPMkmUaN7S9d2SYmvUgYI0zqWtu9Mq50NUL5Dit8DB9Mil9rR4Bzi9KKKRS3+s
	RtdQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=iWqC7DEYcmr8uOTLEd15iB7cXEoErDPBIQmLUUyfmR4=;
	b=GrZqa/yIVuBuqZ34sAawijf70F5ZoDPyptFvtSSHtB/Fya1BGFAOJXmEphOs423QaF
	v0Cv1ha+kSgQGTtnJeZxbnu7bpNiw/WnrPKf13IjOR+7dACJ68JLdR8XwB5E/Mb5dgS9
	O3KyhxUrzgn9Ai0/oLxnc1qODRan7KWPDyXYPoshKRNdLBnAasBnR7h4pWMj4+ekXX4G
	KMwBGwM9ZOZCSe8amn0zG+wYL7pPeGXzTbhFhSBVP83CqjSw48FuMIm3+3f9IUsEZAUi
	8cwNSk7rKep8NGaEq4cb4q3hRBDiPs6CiSPWAO1ny/B3bhKd1DQyysyzNq62kc0vLTIR
	savw==
X-Gm-Message-State: AIkVDXLgnA4dgdhnC3Ow7oU9P1+pcUKSry71rhpyeYH3lU+fk9mLNKbawF/PislLND6tDg==
X-Received: by 10.223.167.66 with SMTP id e2mr2648126wrd.48.1485211444183;
	Mon, 23 Jan 2017 14:44:04 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	c81sm23177848wmf.22.2017.01.23.14.44.03
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:03 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 1/6] libutil: Drop extraneous function declarations
Date: Mon, 23 Jan 2017 22:43:34 +0000
Message-Id: <20170123224339.9013-2-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::244
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:10 -0000

Get rid of unnecessary function declarations by rearranging the
definition of certain functions in the file.
---
 libutil/find.c | 160 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 78 insertions(+), 82 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index e53e8ce..d3c921a 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -104,10 +104,6 @@ static int find_eof;
 #define FIND_OPEN	1
 #define FILELIST_OPEN	2
 
-static void trim(char *);
-static char *find_read_traverse(void);
-static char *find_read_filelist(void);
-
 extern int qflag;
 extern int debug;
 static const int allow_blank = 1;
@@ -695,32 +691,83 @@ find_open_filelist(const char *filename, const char *root, int explain)
 	strlimcpy(cwddir, root, sizeof(cwddir));
 }
 /**
- * find_read: read path without GPATH.
+ * find_read_filelist: read path from file
  *
  *	@return		path
  */
-char *
-find_read(void)
+static char *
+find_read_filelist(void)
 {
+	STATIC_STRBUF(ib);
+	static char buf[MAXPATHLEN + 1];
 	static char *path;
 
-	assert(find_mode != 0);
-	if (find_eof)
-		path = NULL;
-	else if (find_mode == FILELIST_OPEN)
-		path = find_read_filelist();
-	else if (find_mode == FIND_OPEN)
-		path = find_read_traverse();
-	else
-		die("find_read: internal error.");
-	return path;
+	strbuf_clear(ib);
+	for (;;) {
+		path = strbuf_fgets(ib, ip, STRBUF_NOCRLF);
+		if (path == NULL) {
+			/* EOF */
+			find_eof = 1;
+			return NULL;
+		}
+		if (*path == '\0') {
+			/* skip empty line.  */
+			continue;
+		}
+		/*
+		 * Lines which start with ". " are considered to be comments.
+		 */
+		if (*path == '.' && *(path + 1) == ' ')
+			continue;
+		/*
+		 * Skip the following:
+		 * o directory
+		 * o file which does not exist
+		 * o dead symbolic link
+		 */
+		if (!test("f", path)) {
+			if (test("d", path))
+				warning("'%s' is a directory. ignored.", trimpath(path));
+			else
+				warning("'%s' not found. ignored.", trimpath(path));
+			continue;
+		}
+		/*
+		 * normalize path name.
+		 *
+		 *	rootdir  /a/b/
+		 *	buf      /a/b/c/d.c -> c/d.c -> ./c/d.c
+		 */
+		if (normalize(path, rootdir, cwddir, buf, sizeof(buf)) == NULL) {
+			warning("'%s' is out of source tree. ignored.", trimpath(path));
+			continue;
+		}
+		path = buf;
+		/*
+		 * Now GLOBAL can treat the path which includes blanks.
+		 * This message is obsoleted.
+		 */
+		if (!allow_blank && locatestring(path, " ", MATCH_LAST)) {
+			warning("'%s' ignored, because it includes blank.", trimpath(path));
+			continue;
+		}
+		if (skipthisfile(path))
+			continue;
+		/*
+		 * A blank at the head of path means
+		 * other than source file.
+		 */
+		if (!issourcefile(path))
+			*--path = ' ';
+		return path;
+	}
 }
 /**
  * find_read_traverse: read path without GPATH.
  *
  *	@return		path
  */
-char *
+static char *
 find_read_traverse(void)
 {
 	static char val[MAXPATHLEN];
@@ -816,76 +863,25 @@ find_read_traverse(void)
 	return NULL;
 }
 /**
- * find_read_filelist: read path from file
+ * find_read: read path without GPATH.
  *
  *	@return		path
  */
-static char *
-find_read_filelist(void)
+char *
+find_read(void)
 {
-	STATIC_STRBUF(ib);
-	static char buf[MAXPATHLEN + 1];
 	static char *path;
 
-	strbuf_clear(ib);
-	for (;;) {
-		path = strbuf_fgets(ib, ip, STRBUF_NOCRLF);
-		if (path == NULL) {
-			/* EOF */
-			find_eof = 1;
-			return NULL;
-		}
-		if (*path == '\0') {
-			/* skip empty line.  */
-			continue;
-		}
-		/*
-		 * Lines which start with ". " are considered to be comments.
-		 */
-		if (*path == '.' && *(path + 1) == ' ')
-			continue;
-		/*
-		 * Skip the following:
-		 * o directory
-		 * o file which does not exist
-		 * o dead symbolic link
-		 */
-		if (!test("f", path)) {
-			if (test("d", path))
-				warning("'%s' is a directory. ignored.", trimpath(path));
-			else
-				warning("'%s' not found. ignored.", trimpath(path));
-			continue;
-		}
-		/*
-		 * normalize path name.
-		 *
-		 *	rootdir  /a/b/
-		 *	buf      /a/b/c/d.c -> c/d.c -> ./c/d.c
-		 */
-		if (normalize(path, rootdir, cwddir, buf, sizeof(buf)) == NULL) {
-			warning("'%s' is out of source tree. ignored.", trimpath(path));
-			continue;
-		}
-		path = buf;
-		/*
-		 * Now GLOBAL can treat the path which includes blanks.
-		 * This message is obsoleted.
-		 */
-		if (!allow_blank && locatestring(path, " ", MATCH_LAST)) {
-			warning("'%s' ignored, because it includes blank.", trimpath(path));
-			continue;
-		}
-		if (skipthisfile(path))
-			continue;
-		/*
-		 * A blank at the head of path means
-		 * other than source file.
-		 */
-		if (!issourcefile(path))
-			*--path = ' ';
-		return path;
-	}
+	assert(find_mode != 0);
+	if (find_eof)
+		path = NULL;
+	else if (find_mode == FILELIST_OPEN)
+		path = find_read_filelist();
+	else if (find_mode == FIND_OPEN)
+		path = find_read_traverse();
+	else
+		die("find_read: internal error.");
+	return path;
 }
 /**
  * find_close: close iterator.
-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:52 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iO-0003Xi-Be
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:52 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLO-0008TO-R2
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLO-0007OG-0U
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:10 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:36254)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLN-0007Ns-QY
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:09 -0500
Received: by mail-wm0-x244.google.com with SMTP id r126so29982146wmr.3
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=BG8UpKg1L8IlZpNv70NNMD2MDuewAQto2WTajzSoFhA=;
	b=fTTEJPyTmdbTFhfNl9rk4+j4Uwha0oHfHm24jTtbcRVn7IL4bkfR/JyXiSRQH1hhIg
	mki7i66XzsJ16TlYB4oGiH15iLwg9P4g+gM0YhldKaAu45WrS5C45uMVcyErAU8Md6VP
	1Nr7dnuJs6xLDF46TY/lYnjZcCKEUtt338WKWAvixZ8f3xvW81VPwTzDpQq3zoj9NQxg
	zZmEMSzSvuTQnJH/1r35DhOAKK6ucPmmphkYEULQzRHBeepPirTGDP+MFv/3iEsieIs0
	zsXpuRREBCh93PW0WQtYKF+MA8Yd5w7VxsLzDNs/+t7w9rdwp0WaIWxIyZMhipA43Mpb
	QedQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=BG8UpKg1L8IlZpNv70NNMD2MDuewAQto2WTajzSoFhA=;
	b=dd44vFsWW6GTygeXzBlup03bgrCUNeiGA4IqwdGF0KcBVtKggJ8MNc0UppQRFW5nG+
	zt7bwn6rDxjlsGwxbCBL02TcaVkIE62Ai3ppfiLY3saC9Uz3i9GEaBK3JCC31ad7Vpnc
	ezpuVZkO/RUXIsyn5TGdElJkdmjkEC+ia7/4xHlbbHH4D7hfL6rgkW4rHuAEHeXRMMAw
	F/RTyRqu1rCgqLUK+9ngEDgrI5if3lbSY8GhqzNeLoUJq5iFrYmzU6mxRKyLqNYAXsW0
	qa3v/4/cDPMW9MQxyt2A4jMQywXkR7gPODHs0/UMaZTez4vmqY1AtaqkEAG9zUUIULPC
	eU8w==
X-Gm-Message-State: AIkVDXLePHi7TZOWB7Dxvp6ZgakiLq4UiUOOwVH4libGtTyX2VzApqF+GXtKT655alvqQg==
X-Received: by 10.28.127.13 with SMTP id a13mr14524976wmd.96.1485211448617;
	Mon, 23 Jan 2017 14:44:08 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150])
	by smtp.gmail.com with ESMTPSA id e74sm2322214wmd.2.2017.01.23.14.44.07
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:08 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 2/6] libutil: Staticize locally used functions
Date: Mon, 23 Jan 2017 22:43:35 +0000
Message-Id: <20170123224339.9013-3-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::244
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:11 -0000

getrealpath and has_symlinkloop are only used locally in this
compilation unit. Make their definitions static to higlight this fact.
---
 libutil/find.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index d3c921a..f366004 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -487,7 +487,7 @@ static int current_entry;			/**< current entry of the stack */
 /**
  * getrealpath: return a real path of dir using allocated area.
  */
-char *
+static char *
 getrealpath(const char *dir)
 {
 	char real[PATH_MAX];
@@ -502,7 +502,7 @@ getrealpath(const char *dir)
  *	@param[in]	dir	directory (should end by "/")
  *	@return		1: has a loop, 0: don't have a loop
  */
-int
+static int
 has_symlinkloop(const char *dir)
 {
 	struct stack_entry *sp;
-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:52 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iO-0003Y1-J9
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:52 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLW-0008U7-NM
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLV-0007Vt-Ol
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:18 -0500
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34053)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLV-0007VS-IE
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:17 -0500
Received: by mail-wm0-x241.google.com with SMTP id c85so29891223wmi.1
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=0y5+Y95p59w26bnVyTygQgE3yATs6KE0IGtpNk8L6y0=;
	b=iNumQ4xguZPbHGWEwVke1biC3k+LcnP+CYaWf1/O/+Np+/XnfY7xG+yh2ZoXbh+6u0
	WS6GZ24cjZfpgyBsYrC/2L8nTXWhngK96Ob8KnPm2L7Ye8F9goXVkpNIEQiKuoRaxtkK
	qG6RsvScwwwoJcvPuXwgpnpXgP/rY4Ew0IE1NYxLe1uO05GiwEpCFeOzBuJauz417mtu
	S0mMys9TvcUah35doS9uJjq8lNOe/fs72p1Qyl2gUw7Luvc5Mpm94IGH7bNsmq7d1dpG
	7Q2sCXDf6Vp54PMj8tDuAnw7pg41ugJvVFKdAe8A3w4k7tH4cjt8Q31fUITs5R0gHqxq
	Eo3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=0y5+Y95p59w26bnVyTygQgE3yATs6KE0IGtpNk8L6y0=;
	b=KGdyDwGvAqCjUwOYlz+i/+JrbbArOR/CeysozMvD7NdqCgz30clDHD218ZAW2NwAKE
	zqSOnhCn7CcuOagORpHCjHcN1/L3lQ2RVuUcTwevWNvVJHwlm1n1Uyfi3kxNPdtHKdLx
	i760mSqRgbTUhlGj5K+mmmYSjxa3S6JJCGvHlLgDB53SOk55NDGmcynYMJ9IgLAbiZtz
	kNw+qjvHzrkN8ZBDkki3qWkFTD10OK/JS3LFZpYZNCJl9yyySclUrJsnGJe/wqoeT+Dx
	jmUUdMyoQ0kNTba0jSmyzqiDs55FL+rn2fncES3/Y2V6Ru99RzdXM32hzuhR50IWGCMi
	N2aA==
X-Gm-Message-State: AIkVDXJtJ29WD/aJI1eUN9Ptymszade/1hni1pXG/ovIi6v8Ya+dzFfaS/ca/RUj850X2Q==
X-Received: by 10.223.153.15 with SMTP id x15mr25602534wrb.179.1485211456490; 
	Mon, 23 Jan 2017 14:44:16 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	e16sm16968339wra.36.2017.01.23.14.44.15
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:15 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 5/6] libutil: Convert rootdir to a dynamically allocated
	array
Date: Mon, 23 Jan 2017 22:43:38 +0000
Message-Id: <20170123224339.9013-6-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::241
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:19 -0000

In preparation for dropping the use of PATH_MAX, convert rootdir to a
dynamically allocated array. As rootdir is used to cache state across
function calls (iterating over files), free the buffer when it is no
longer being used (find_close).
---
 libutil/find.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index 1863df4..14d59d5 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -97,7 +97,7 @@ static regex_t *skip;			/**< regex for skipping units */
 static regex_t *suff;			/**< regex for suffixes */
 static FILE *ip;
 static FILE *temp;
-static char rootdir[PATH_MAX];
+static char *rootdir;
 static char cwddir[MAXPATHLEN];
 static int find_mode;
 static int find_eof;
@@ -635,7 +635,7 @@ find_open(const char *start, int explain)
 
 	if (!start)
 		start = "./";
-        if (realpath(start, rootdir) == NULL)
+        if ((rootdir = realpath(start, NULL)) == NULL)
                 die("cannot get real path of '%s'.", trimpath(dir));
 	/*
 	 * setup stack.
@@ -664,6 +664,7 @@ find_open(const char *start, int explain)
 void
 find_open_filelist(const char *filename, const char *root, int explain)
 {
+	size_t rootdir_len;
 	assert(find_mode == 0);
 	find_mode = FILELIST_OPEN;
 	find_explain = explain;
@@ -689,11 +690,19 @@ find_open_filelist(const char *filename, const char *root, int explain)
 	}
 	/*
 	 * rootdir always ends with '/'.
+	 *
+	 * rootdir_len is two characters longer than root to be able
+	 * to append a "/" if needed and the string terminator
+	 * ofcourse.
 	 */
-	if (!strcmp(root+ROOT, "/"))
-		strlimcpy(rootdir, root, sizeof(rootdir));
-	else
-		snprintf(rootdir, sizeof(rootdir), "%s/", root);
+	rootdir_len = strlen(root) + 2;
+	rootdir = malloc(rootdir_len);
+	if (!rootdir)
+		die("short of memory.");
+
+	snprintf(rootdir, rootdir_len, "%s%s", root,
+		 strcmp(root+ROOT, "/") ? "/" : "");
+
 	strlimcpy(cwddir, root, sizeof(cwddir));
 }
 /**
@@ -909,6 +918,8 @@ find_close(void)
 	} else {
 		die("find_close: internal error.");
 	}
+	if (rootdir)
+		free(rootdir);
 	if (suff)
 		regfree(suff);
 	if (skip)
-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:53 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iP-0003Yx-Eg
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLW-0008U5-L2
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLT-0007Sb-K2
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:18 -0500
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34939)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLT-0007Rz-Dw
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:15 -0500
Received: by mail-wm0-x242.google.com with SMTP id d140so30056194wmd.2
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=ZNoZUAFza4K2ChgY6Y2lxM3ukIlLDU2fi5GHTQwq85U=;
	b=jd7/f+nyzzc/SOUPjxjm5TTM/xrDWrNDkfcH//eJK09lzMtReD6rBJY9Az3EmPfQy/
	DtUcFBlUqFs3xJwyDTDukhe5AUFksIf8uex16ZL0qV/i8FK3M6QKFH1JYkMVXIZVi1RA
	rwycdF43YD18RKcdyGNzR/Lr/uQdtAQpi7v84RvnebzMwEOvFBLu/sYmVCO+QE+qIO6r
	yUmlsE3Y/N/KdP0gd/sHZNpUTpOcJ8NJlRIbPDStXyiBqPLQEB+jO3Bm0D5mE7ZyBOzE
	jf7tOAHV8P4Gos4kOeVms7LF1spuyRJ8YynZMY2j9ikRV5R39nF7OShf5USYBkTEl6IK
	uuPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=ZNoZUAFza4K2ChgY6Y2lxM3ukIlLDU2fi5GHTQwq85U=;
	b=OevMvdOb9FSdUrLhx32YfKLRIVSpfeBUIJLCWAkuKacH9uIpY3BOXgXdb4JEf/Zy++
	uLfhfAAW2PSWMoEFDK/CIzi7oQW9b4RgZwCTFz+ZQuu4LNdLa1AUCyJtdOAI6uv+unvy
	Dnwex0DekhzFqrYo4af6V+kukqcBzNSroWER2XjRG6LkBSX3oc+7WxTS2NtruXLFyPQR
	GJZCW0/VgJMWHKhmlZ6ZCy2H4HUQVxAY/EPDwCVLfBG3XZLbhRtKiAqDjMNFi7x3lBGB
	5khjX2ejpcRA8TcGluMuuMDarIqOoi6Nj+LAnf7c1LBvV2OCNKVc3tFsikiaKEa98opR
	srbg==
X-Gm-Message-State: AIkVDXIIKmYIN7wjLPVB4KHXH7PBwYfZeM7HTSIZrETK+G5hyWmk2KCjTuCyqAuSzoqV+w==
X-Received: by 10.28.165.130 with SMTP id o124mr14524269wme.129.1485211454249; 
	Mon, 23 Jan 2017 14:44:14 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	y30sm16895480wrc.23.2017.01.23.14.44.13
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:13 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 4/6] libutil: Remove usage of PATH_MAX from has_symlinkloop
Date: Mon, 23 Jan 2017 22:43:37 +0000
Message-Id: <20170123224339.9013-5-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::242
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:19 -0000

Update has_symlinkloop to no longer use PATH_MAX. The change relies on
the behaviour of realpath to return an allocated buffer when passed a
NULL second argument.

Ensure that the buffer is freed(not leaked) before returning from the
function.
---
 libutil/find.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index a009538..1863df4 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -506,12 +506,12 @@ static int
 has_symlinkloop(const char *dir)
 {
 	struct stack_entry *sp;
-	char real[PATH_MAX], *p;
-	int i;
+	char *real, *p;
+	int i, ret = 0;
 
 	if (!strcmp(dir, "./"))
 		return 0;
-	if (realpath(dir, real) == NULL)
+	if ((real = realpath(dir, NULL)) == NULL)
 		die("cannot get real path of '%s'.", trimpath(dir));
 #ifdef SLOOPDEBUG
 	fprintf(stderr, "======== has_symlinkloop ======\n");
@@ -520,8 +520,10 @@ has_symlinkloop(const char *dir)
 	fprintf(stderr, "\tcheck '%s' < '%s'\n", real, rootdir);
 #endif
 	p = locatestring(rootdir, real, MATCH_AT_FIRST);
-	if (p && (*p == '/' || *p == '\0' || !strcmp(real, "/")))
-		return 1;
+	if (p && (*p == '/' || *p == '\0' || !strcmp(real, "/"))) {
+		ret = 1;
+		goto out;
+	}
 	sp = varray_assign(stack, 0, 0);
 #ifdef SLOOPDEBUG
 	fprintf(stderr, "TEST-2\n");
@@ -530,13 +532,17 @@ has_symlinkloop(const char *dir)
 #ifdef SLOOPDEBUG
 		fprintf(stderr, "%d:\tcheck '%s' == '%s'\n", i, real, sp[i].real);
 #endif
-		if (!strcmp(sp[i].real, real))
-			return 1;
+		if (!strcmp(sp[i].real, real)) {
+			ret = 1;
+			goto out;
+		}
 	}
 #ifdef SLOOPDEBUG
 	fprintf(stderr, "===============================\n");
 #endif
-	return 0;
+out:
+	free(real);
+	return ret;
 }
 
 /**
-- 
2.11.0



From MAILER-DAEMON Tue Jan 24 09:04:54 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cW1iP-0003ZC-PR
	for mharc-bug-global@gnu.org; Tue, 24 Jan 2017 09:04:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLZ-0008UN-JV
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cVnLY-0007Xw-Su
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:21 -0500
Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33004)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cVnLY-0007XW-Ml
	for bug-global@gnu.org; Mon, 23 Jan 2017 17:44:20 -0500
Received: by mail-wm0-x243.google.com with SMTP id r144so29992303wme.0
	for <bug-global@gnu.org>; Mon, 23 Jan 2017 14:44:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:date:message-id:in-reply-to:references;
	bh=rNlRFB2Yju/vAlYXGxv1etWij4h3IuJ/CZjmAi3DUNk=;
	b=db8HawW6DpEKvAcvDiWLi+/e0/W/3iqQHPLQJc4C3L0w+ymQg9x6mFvp44NHMRLqqX
	F1pr2hpmJJ8kbxh02hyPYpPHvWtb0kZoJrY7WuxOLj1Zyvup3AkUA6ZGGopMCRomc0kc
	UDyoQECkBlLezQNDAW9dk5vfweqbBty9sv4WMmr14g9wxjY5ChN4pZN4QXwYErFUosf7
	h+XvqfhlltQK4/9IMCZ1lPQumozcqVYDxkuEZvkIhvwUP7WUwU3MKmJQTkqv4XRuyoD/
	dZnKlotNMOul6+nUGbYaB19mVrusAGdGVkt5b1Uny43mowfwzlD2qtGr03u0hNdI3/8a
	4arA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
	:references;
	bh=rNlRFB2Yju/vAlYXGxv1etWij4h3IuJ/CZjmAi3DUNk=;
	b=A9Ch0eyJH9VSn3xv5hhGy9lDVcQhyf2KbRqVJs05ff/1x3ThV+tIa/7TYOIJCPaWbe
	JpDUArttpQrL6YxFhQsD8mTnAfF0sMXYd4frRCzExX9S4VbOv218pfpJRBVvi9GCOafC
	vi0o2K7t7a/M+3bIIokrbFhJS6zn5kVZfJyo2/2uVIBGjaV3WLXjZjwGtnw5k2GnaaX1
	dvNKtcrUXw6wv4YnKC2ty2sQssvwhZjcj6eUuwR19fJak8QC1DSUFlgwAm1SsIxny1jX
	E4UA61W4zLBStKnKxDc99GGgfAgdMHEL6pwYKdjRjWB+p+5p9nyfxNPh/EP+ABocDtTK
	AJdQ==
X-Gm-Message-State: AIkVDXI5+2iRixpgtuyhkF+wCsGgHOngqmrbXTST0gURu4TJcXxTUt+W20y76cwYaBLm3g==
X-Received: by 10.223.168.87 with SMTP id l81mr31368562wrc.194.1485211459379; 
	Mon, 23 Jan 2017 14:44:19 -0800 (PST)
Received: from localhost (cpc111843-pete12-2-0-cust1173.4-4.cable.virginm.net.
	[81.97.76.150]) by smtp.gmail.com with ESMTPSA id
	c133sm4938440wmd.13.2017.01.23.14.44.18
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Mon, 23 Jan 2017 14:44:18 -0800 (PST)
From: Punit Agrawal <punitagrawal@gmail.com>
To: bug-global@gnu.org
Subject: [RFC PATCH 6/6] libutil: Drop the requirement for PATH_MAX macro
Date: Mon, 23 Jan 2017 22:43:39 +0000
Message-Id: <20170123224339.9013-7-punitagrawal@gmail.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::243
X-Mailman-Approved-At: Tue, 24 Jan 2017 09:04:49 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 22:44:22 -0000

PATH_MAX is no longer used in this file. Drop the requirement for it
to be defined.
---
 libutil/find.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libutil/find.c b/libutil/find.c
index 14d59d5..a515898 100644
--- a/libutil/find.c
+++ b/libutil/find.c
@@ -79,10 +79,6 @@
 #define STRNCMP strncmp
 #define ROOT 0
 #endif
-#ifndef PATH_MAX
-#error Since this platform does not have PATH_MAX, you should define it using an appropriate value for the platform.
-/* #define PATH_MAX     1024 */
-#endif
 /*
  * usage of find_xxx()
  *
-- 
2.11.0



From MAILER-DAEMON Wed Jan 25 01:30:11 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cWH5v-0006rA-LI
	for mharc-bug-global@gnu.org; Wed, 25 Jan 2017 01:30:11 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.tamacom@gmail.com>) id 1cWH5s-0006nZ-Au
	for bug-global@gnu.org; Wed, 25 Jan 2017 01:30:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <i.tamacom@gmail.com>) id 1cWH5q-0006p2-Ow
	for bug-global@gnu.org; Wed, 25 Jan 2017 01:30:08 -0500
Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34237)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <i.tamacom@gmail.com>) id 1cWH5q-0006mS-DW
	for bug-global@gnu.org; Wed, 25 Jan 2017 01:30:06 -0500
Received: by mail-lf0-x242.google.com with SMTP id q89so19444054lfi.1
	for <bug-global@gnu.org>; Tue, 24 Jan 2017 22:30:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=mime-version:sender:in-reply-to:references:from:date:message-id
	:subject:to:cc;
	bh=VfIexbZHkGT2IfNwrUwuoNZNs78lFXjE5alfl7kOjQA=;
	b=OXjetMmRejhoxTD/VEva4fQNQeD4A/p04hD8CdR5aYRwrd9NqNVX6pxRUFzSL1OFlE
	Aibo+UXu+KmnZ6Z+p7ImKxeDvjD5OYsUZKPAwZ6T6rIaxvv7ZlF7hmsAr/z+Exvy8SY3
	d8JEkO0cBh+12e+lGz54xQUrYpIJUCLeE6aUn+FIvvsyE+GSp4Nid25jKhIP7UE80isM
	L/wPcfth11P7cRY8wl4i35rRba9D97AKI/Ech4hdMJ4XcOLQ9YXK+4ojv1HTa3ZE5mp6
	L4YpTnh+Yy3S1dPaHV5LKLGOJpnNw4ja7TOHWT6KH51l5cp9X2f4RUHs0oj8bagZU0s+
	lPZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
	:date:message-id:subject:to:cc;
	bh=VfIexbZHkGT2IfNwrUwuoNZNs78lFXjE5alfl7kOjQA=;
	b=LCmCwOK/Nkk1gWvK4kweD+yCW55QGgBeICKems13q8l37xl2T4Iql3FcIHELLxWicK
	1BAOXFAih5IyB/iomKiyEvGk8t/RtJYpTaJCpzu9ajzswcGTlmoSLB+Mw/0S3EtgS/fP
	PkiReK9tSW8fc9lzCebZHA82SnBJplwikNY+PW4JV2MJg6VkNgealkBXQNJ5n9GiB4z9
	uqLz2wwsyrG35Cx7ilDbekKF+yFdHtwLgelKPwoLaPRQBdljBH7ORPLJADl3FONQqpjF
	HOp5Dv27YWu+TcIXf9pOZ8I2o2BLtWpuSW6evQkjHWZtLmAxP5L2k/gMFo5FpAqH1Gjz
	wA0w==
X-Gm-Message-State: AIkVDXKRLfGwXVZn3rkioups5wLcVn+iI3vC+MnVwheW1s3RC1dP52CFvu7Cih/3dS083/CXEp7khEIbRaL6Uw==
X-Received: by 10.25.25.133 with SMTP id 127mr7421684lfz.153.1485325803368;
	Tue, 24 Jan 2017 22:30:03 -0800 (PST)
MIME-Version: 1.0
Sender: i.tamacom@gmail.com
Received: by 10.25.41.67 with HTTP; Tue, 24 Jan 2017 22:30:02 -0800 (PST)
In-Reply-To: <20170123224339.9013-1-punitagrawal@gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
From: Shigio YAMAGUCHI <shigio@gnu.org>
Date: Wed, 25 Jan 2017 15:30:02 +0900
X-Google-Sender-Auth: MTA0xmCSxHACuPuGf30kmrgoi-4
Message-ID: <CADJmJYr1oAYm_-xY7n4_a-EZMKcPMdLK73sq3jetS1-cJgRc6Q@mail.gmail.com>
Subject: Re: [RFC PATCH 0/6] Enable building Gnu Global package on Hurd
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: "bug-global@gnu.org" <bug-global@gnu.org>
Content-Type: multipart/alternative; boundary=001a11401d9ce2b6a00546e55cff
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:4010:c07::242
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jan 2017 06:30:10 -0000

--001a11401d9ce2b6a00546e55cff
Content-Type: text/plain; charset=UTF-8

Hi,
> On digging futher[2][3], I came to the conclusion that instead of
> defining PATH_MAX to a value, the way to fix it would be to change how
> paths are handled. Although the changes are not difficult, one needs
> to be careful to free the buffers when they are no longer
> needed. Thought a bit tedious, the arguments against using PATH_MAX
> (but also other similar macros) make sense.

I agree with you.

> Before applying the patch to the global package, I was hoping to get
> some feedback and a view on whether they could be merged
> upstream. There is nothing debian specific in the patches.

I have committed the patches to the repository.
Thank you for the better code.

> shows ~150+ locations where MAXPATHLEN is used. Is there interest to
> address this? Would more such patches updating the code be useful?  Or
> is there a better way to go about this?

Such patches and guidelines are welcome.
Thank you very much.

Regards,
Shigio


2017-01-24 7:43 GMT+09:00 Punit Agrawal <punitagrawal@gmail.com>:

> Hi,
>
> Gnu Global package in Debian fails to build from source on Hurd[0] as
> the build errors out when PATH_MAX is not defined. Here's the snippet
> from libutil/find.c that triggers the failure -
>
> #ifndef PATH_MAX
> #error Since this platform does not have PATH_MAX, you should define it
> using an appropriate value for the platform.
> /* #define PATH_MAX     1024 */
> #endif
>
> On digging futher[2][3], I came to the conclusion that instead of
> defining PATH_MAX to a value, the way to fix it would be to change how
> paths are handled. Although the changes are not difficult, one needs
> to be careful to free the buffers when they are no longer
> needed. Thought a bit tedious, the arguments against using PATH_MAX
> (but also other similar macros) make sense.
>
> In this series the dependency on PATH_MAX is dropped so that the build
> succeeds on Hurd.
>
> Patches 1 & 2 are a couple of minor cleanups. Patch 3-5 update
> instances where the macro is used. Patch 6 drops the offending snippet
> above.
>
> Before applying the patch to the global package, I was hoping to get
> some feedback and a view on whether they could be merged
> upstream. There is nothing debian specific in the patches.
>
> I'd also like to take this opportunity to raise the larger question of
> how to address similar issues elsewhere in the codebase. A quick grep
> shows ~150+ locations where MAXPATHLEN is used. Is there interest to
> address this? Would more such patches updating the code be useful?  Or
> is there a better way to go about this?
>
> Feedback and opinions welcome.
>
> Thanks,
> Punit
>
> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848302
> [1] http://cvs.savannah.gnu.org/viewvc/global/global/libutil/
> find.c?view=markup#l82
> [2] https://www.gnu.org/software/hurd/community/gsoc/project_
> ideas/maxpath.html
> [3] https://www.gnu.org/software/hurd/hurd/porting/guidelines.
> html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL
>
> Punit Agrawal (6):
>   libutil: Drop extraneous function declarations
>   libutil: Staticize locally used functions
>   libutil: Remove usage of PATH_MAX from getrealpath
>   libutil: Remove usage of PATH_MAX from has_symlinkloop
>   libutil: Convert rootdir to a dynamically allocated array
>   libutil: Drop the requirement for PATH_MAX macro
>
>  libutil/find.c | 219 ++++++++++++++++++++++++++++++
> ---------------------------
>  1 file changed, 114 insertions(+), 105 deletions(-)
>
> --
> 2.11.0
>
>
> _______________________________________________
> Bug-global mailing list
> Bug-global@gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-global
>



-- 
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3

--001a11401d9ce2b6a00546e55cff
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div>&gt; On digging futher[2][3], I came to=
 the conclusion that instead of</div><div>&gt; defining PATH_MAX to a value=
, the way to fix it would be to change how</div><div>&gt; paths are handled=
. Although the changes are not difficult, one needs</div><div>&gt; to be ca=
reful to free the buffers when they are no longer</div><div>&gt; needed. Th=
ought a bit tedious, the arguments against using PATH_MAX</div><div>&gt; (b=
ut also other similar macros) make sense.</div><div><br></div><div>I agree =
with you.</div><div><br></div><div>&gt; Before applying the patch to the gl=
obal package, I was hoping to get</div><div>&gt; some feedback and a view o=
n whether they could be merged</div><div>&gt; upstream. There is nothing de=
bian specific in the patches.</div><div><br></div><div>I have committed the=
 patches to the repository.</div><div>Thank you for the better code.</div><=
div><br></div><div>&gt; shows ~150+ locations where MAXPATHLEN is used. Is =
there interest to</div><div>&gt; address this? Would more such patches upda=
ting the code be useful?=C2=A0 Or</div><div>&gt; is there a better way to g=
o about this?</div><div><br></div><div>Such patches and guidelines are welc=
ome.</div><div>Thank you very much.</div><div><br></div><div>Regards,</div>=
<div>Shigio</div><div><br></div></div><div class=3D"gmail_extra"><br><div c=
lass=3D"gmail_quote">2017-01-24 7:43 GMT+09:00 Punit Agrawal <span dir=3D"l=
tr">&lt;<a href=3D"mailto:punitagrawal@gmail.com" target=3D"_blank">punitag=
rawal@gmail.com</a>&gt;</span>:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Gnu Global package in Debian fails to build from source on Hurd[0] as<br>
the build errors out when PATH_MAX is not defined. Here&#39;s the snippet<b=
r>
from libutil/find.c that triggers the failure -<br>
<br>
#ifndef PATH_MAX<br>
#error Since this platform does not have PATH_MAX, you should define it usi=
ng an appropriate value for the platform.<br>
/* #define PATH_MAX=C2=A0 =C2=A0 =C2=A01024 */<br>
#endif<br>
<br>
On digging futher[2][3], I came to the conclusion that instead of<br>
defining PATH_MAX to a value, the way to fix it would be to change how<br>
paths are handled. Although the changes are not difficult, one needs<br>
to be careful to free the buffers when they are no longer<br>
needed. Thought a bit tedious, the arguments against using PATH_MAX<br>
(but also other similar macros) make sense.<br>
<br>
In this series the dependency on PATH_MAX is dropped so that the build<br>
succeeds on Hurd.<br>
<br>
Patches 1 &amp; 2 are a couple of minor cleanups. Patch 3-5 update<br>
instances where the macro is used. Patch 6 drops the offending snippet<br>
above.<br>
<br>
Before applying the patch to the global package, I was hoping to get<br>
some feedback and a view on whether they could be merged<br>
upstream. There is nothing debian specific in the patches.<br>
<br>
I&#39;d also like to take this opportunity to raise the larger question of<=
br>
how to address similar issues elsewhere in the codebase. A quick grep<br>
shows ~150+ locations where MAXPATHLEN is used. Is there interest to<br>
address this? Would more such patches updating the code be useful?=C2=A0 Or=
<br>
is there a better way to go about this?<br>
<br>
Feedback and opinions welcome.<br>
<br>
Thanks,<br>
Punit<br>
<br>
[0] <a href=3D"https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D848302" =
rel=3D"noreferrer" target=3D"_blank">https://bugs.debian.org/cgi-<wbr>bin/b=
ugreport.cgi?bug=3D848302</a><br>
[1] <a href=3D"http://cvs.savannah.gnu.org/viewvc/global/global/libutil/fin=
d.c?view=3Dmarkup#l82" rel=3D"noreferrer" target=3D"_blank">http://cvs.sava=
nnah.gnu.org/<wbr>viewvc/global/global/libutil/<wbr>find.c?view=3Dmarkup#l8=
2</a><br>
[2] <a href=3D"https://www.gnu.org/software/hurd/community/gsoc/project_ide=
as/maxpath.html" rel=3D"noreferrer" target=3D"_blank">https://www.gnu.org/s=
oftware/<wbr>hurd/community/gsoc/project_<wbr>ideas/maxpath.html</a><br>
[3] <a href=3D"https://www.gnu.org/software/hurd/hurd/porting/guidelines.ht=
ml#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL" rel=3D"noreferrer" target=3D"_blank">h=
ttps://www.gnu.org/software/<wbr>hurd/hurd/porting/guidelines.<wbr>html#PAT=
H_MAX_tt_MAX_PATH_tt_<wbr>MAXPATHL</a><br>
<br>
Punit Agrawal (6):<br>
=C2=A0 libutil: Drop extraneous function declarations<br>
=C2=A0 libutil: Staticize locally used functions<br>
=C2=A0 libutil: Remove usage of PATH_MAX from getrealpath<br>
=C2=A0 libutil: Remove usage of PATH_MAX from has_symlinkloop<br>
=C2=A0 libutil: Convert rootdir to a dynamically allocated array<br>
=C2=A0 libutil: Drop the requirement for PATH_MAX macro<br>
<br>
=C2=A0libutil/find.c | 219 ++++++++++++++++++++++++++++++<wbr>-------------=
--------------<br>
=C2=A01 file changed, 114 insertions(+), 105 deletions(-)<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
2.11.0<br>
<br>
<br>
______________________________<wbr>_________________<br>
Bug-global mailing list<br>
<a href=3D"mailto:Bug-global@gnu.org">Bug-global@gnu.org</a><br>
<a href=3D"https://lists.gnu.org/mailman/listinfo/bug-global" rel=3D"norefe=
rrer" target=3D"_blank">https://lists.gnu.org/mailman/<wbr>listinfo/bug-glo=
bal</a><br>
</font></span></blockquote></div><br><br clear=3D"all"><div><br></div>-- <b=
r><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div di=
r=3D"ltr">Shigio YAMAGUCHI &lt;<a href=3D"mailto:shigio@gnu.org" target=3D"=
_blank">shigio@gnu.org</a>&gt;<div>PGP fingerprint: D1CB 0B89 B346 4AB6 566=
3 =C2=A0C4B6 3CA5 BBB3 57BE DDA3<br></div></div></div>
</div>

--001a11401d9ce2b6a00546e55cff--


From MAILER-DAEMON Wed Jan 25 22:36:37 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1cWarV-0008Iz-7c
	for mharc-bug-global@gnu.org; Wed, 25 Jan 2017 22:36:37 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cWVOQ-0003wX-Bd
	for bug-global@gnu.org; Wed, 25 Jan 2017 16:46:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punitagrawal@gmail.com>) id 1cWVOL-0006Pa-VF
	for bug-global@gnu.org; Wed, 25 Jan 2017 16:46:14 -0500
Received: from mail-yb0-x243.google.com ([2607:f8b0:4002:c09::243]:36746)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <punitagrawal@gmail.com>)
	id 1cWVOG-0006Md-Nm; Wed, 25 Jan 2017 16:46:04 -0500
Received: by mail-yb0-x243.google.com with SMTP id f67so2808880ybc.3;
	Wed, 25 Jan 2017 13:46:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc; bh=uGEggJ3j/sVvVRmkc9BV3i19ECX6LjByRIotz/+KXls=;
	b=a0mD1doG3TCddT2LYgpg+14wIfzgItI6I1sFxmoEJd6Tad+0fFeURTQA9ebnLoBwnZ
	N+CCSjk1gT7heAkft6EShz7HHahcq2yx744mzty9kcnNYrwWpMnmW+qPDPwqUGSl4Wd7
	2+aIodaBm+hebzhCgFWo/18EftGgrkdT4RnEQ28d+Vn4AqsOYAu5qm2r9PnxXofK1Bac
	rDNkoF7q7cbq9GFs3DeJKD/xvT4NXzcfPVWvb8AwzRGJzR4uO12pS70H5HgkmH+I5XFD
	VbB3rs46GEF2Uw0+Dh6qWuTqAW8iVBzU5TDkVVcQ83RJ7WPYop1TacMc/5ychZUj9rpc
	5VYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc;
	bh=uGEggJ3j/sVvVRmkc9BV3i19ECX6LjByRIotz/+KXls=;
	b=h3treHkCdwEvGsNkRjI1xFMpOCUfVbQX2pV6MAd7i4i5BvHoE27cuNDB2iJRc/Vy4q
	ICncdsNt4MKRBOZ698AQ0FxaCUUN4jQTEFQBkwE+LeIAc3x3NM7tR/eTCmGByClOh4Pn
	lDg9duS46a9zjoVrAQ+q+lL23yQpM1TGMRO0KM1o/3hRUnm+pBg4D1JvpxAsgZfOk8Lg
	0AoFyPqy4rBx+6+eb/vSYSf6EHbZwL/w63yZGq4RkXdmGhuaVlnBtPSUEfMkKC2DjMyL
	NBK6VSed/UbrOo4y3d08/IvemlRJ1tJ1wRI15gphcwGiLJNv63txT7IqFFjmcD7oelja
	3SfA==
X-Gm-Message-State: AIkVDXJmIwTXwY0upCM7fODFExtOReShchyy87T6mOGZxe8bV5cJEtHKfWceI5ERdp2lxpXTnjfr+D/TVbW+bg==
X-Received: by 10.37.174.99 with SMTP id g35mr32601350ybe.170.1485380762286;
	Wed, 25 Jan 2017 13:46:02 -0800 (PST)
MIME-Version: 1.0
Received: by 10.129.94.65 with HTTP; Wed, 25 Jan 2017 13:45:42 -0800 (PST)
In-Reply-To: <CADJmJYr1oAYm_-xY7n4_a-EZMKcPMdLK73sq3jetS1-cJgRc6Q@mail.gmail.com>
References: <20170123224339.9013-1-punitagrawal@gmail.com>
	<CADJmJYr1oAYm_-xY7n4_a-EZMKcPMdLK73sq3jetS1-cJgRc6Q@mail.gmail.com>
From: Punit Agrawal <punitagrawal@gmail.com>
Date: Wed, 25 Jan 2017 21:45:42 +0000
Message-ID: <CAD4BONfzYCZmei2r1QVX4UKm_9zWNm5-3-bFpj5z=+Dih6QkLg@mail.gmail.com>
Subject: Re: [RFC PATCH 0/6] Enable building Gnu Global package on Hurd
To: Shigio YAMAGUCHI <shigio@gnu.org>
Cc: "bug-global@gnu.org" <bug-global@gnu.org>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 2607:f8b0:4002:c09::243
X-Mailman-Approved-At: Wed, 25 Jan 2017 22:36:36 -0500
X-BeenThere: bug-global@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports for GNU GLOBAL <bug-global.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-global/>
List-Post: <mailto:bug-global@gnu.org>
List-Help: <mailto:bug-global-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-global>,
	<mailto:bug-global-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jan 2017 21:46:18 -0000

On Wed, Jan 25, 2017 at 6:30 AM, Shigio YAMAGUCHI <shigio@gnu.org> wrote:
> Hi,
>> On digging futher[2][3], I came to the conclusion that instead of
>> defining PATH_MAX to a value, the way to fix it would be to change how
>> paths are handled. Although the changes are not difficult, one needs
>> to be careful to free the buffers when they are no longer
>> needed. Thought a bit tedious, the arguments against using PATH_MAX
>> (but also other similar macros) make sense.
>
> I agree with you.
>
>> Before applying the patch to the global package, I was hoping to get
>> some feedback and a view on whether they could be merged
>> upstream. There is nothing debian specific in the patches.
>
> I have committed the patches to the repository.
> Thank you for the better code.

Thanks for merging the patches. I'll upload a new package with them
until the next upstream release.

>
>> shows ~150+ locations where MAXPATHLEN is used. Is there interest to
>> address this? Would more such patches updating the code be useful?  Or
>> is there a better way to go about this?
>
> Such patches and guidelines are welcome.

That's good to know. Next time I'll pick such a task in global I'll
feel less hesitant. :)

Thanks,
Punit

> Thank you very much.
>
> Regards,
> Shigio
>
>
> 2017-01-24 7:43 GMT+09:00 Punit Agrawal <punitagrawal@gmail.com>:
>>
>> Hi,
>>
>> Gnu Global package in Debian fails to build from source on Hurd[0] as
>> the build errors out when PATH_MAX is not defined. Here's the snippet
>> from libutil/find.c that triggers the failure -
>>
>> #ifndef PATH_MAX
>> #error Since this platform does not have PATH_MAX, you should define it
>> using an appropriate value for the platform.
>> /* #define PATH_MAX     1024 */
>> #endif
>>
>> On digging futher[2][3], I came to the conclusion that instead of
>> defining PATH_MAX to a value, the way to fix it would be to change how
>> paths are handled. Although the changes are not difficult, one needs
>> to be careful to free the buffers when they are no longer
>> needed. Thought a bit tedious, the arguments against using PATH_MAX
>> (but also other similar macros) make sense.
>>
>> In this series the dependency on PATH_MAX is dropped so that the build
>> succeeds on Hurd.
>>
>> Patches 1 & 2 are a couple of minor cleanups. Patch 3-5 update
>> instances where the macro is used. Patch 6 drops the offending snippet
>> above.
>>
>> Before applying the patch to the global package, I was hoping to get
>> some feedback and a view on whether they could be merged
>> upstream. There is nothing debian specific in the patches.
>>
>> I'd also like to take this opportunity to raise the larger question of
>> how to address similar issues elsewhere in the codebase. A quick grep
>> shows ~150+ locations where MAXPATHLEN is used. Is there interest to
>> address this? Would more such patches updating the code be useful?  Or
>> is there a better way to go about this?
>>
>> Feedback and opinions welcome.
>>
>> Thanks,
>> Punit
>>
>> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848302
>> [1]
>> http://cvs.savannah.gnu.org/viewvc/global/global/libutil/find.c?view=markup#l82
>> [2]
>> https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html
>> [3]
>> https://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL
>>
>> Punit Agrawal (6):
>>   libutil: Drop extraneous function declarations
>>   libutil: Staticize locally used functions
>>   libutil: Remove usage of PATH_MAX from getrealpath
>>   libutil: Remove usage of PATH_MAX from has_symlinkloop
>>   libutil: Convert rootdir to a dynamically allocated array
>>   libutil: Drop the requirement for PATH_MAX macro
>>
>>  libutil/find.c | 219
>> ++++++++++++++++++++++++++++++---------------------------
>>  1 file changed, 114 insertions(+), 105 deletions(-)
>>
>> --
>> 2.11.0
>>
>>
>> _______________________________________________
>> Bug-global mailing list
>> Bug-global@gnu.org
>> https://lists.gnu.org/mailman/listinfo/bug-global
>
>
>
>
> --
> Shigio YAMAGUCHI <shigio@gnu.org>
> PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


