From MAILER-DAEMON Fri Aug 03 03:05:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SxBwg-0007uL-Eb
	for mharc-bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 03:05:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppisar@redhat.com>) id 1SwwsA-0001r7-Qd
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 10:59:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ppisar@redhat.com>) id 1Swws6-0005TG-Oe
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 10:59:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2216)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppisar@redhat.com>) id 1Swws6-0005T6-Gs
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 10:59:30 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72ExT57005441
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-utils@gnu.org>; Thu, 2 Aug 2012 10:59:29 -0400
Received: from dhcp-0-146.brq.redhat.com (dhcp-25-104.brq.redhat.com
	[10.34.25.104])
	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id q72ExR4Z005575
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 2 Aug 2012 10:59:28 -0400
Received: from dhcp-0-146.brq.redhat.com (localhost.localdomain [127.0.0.1])
	by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5) with ESMTP id
	q72ExQ3i017766; Thu, 2 Aug 2012 16:59:26 +0200
Received: (from petr@localhost)
	by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5/Submit) id q72ExQhI017758; 
	Thu, 2 Aug 2012 16:59:26 +0200
X-Authentication-Warning: dhcp-0-146.brq.redhat.com: petr set sender to
	ppisar@redhat.com using -f
Date: Thu, 2 Aug 2012 16:59:26 +0200
From: Petr Pisar <ppisar@redhat.com>
To: bug-gnu-utils@gnu.org
Subject: [sharutils-4.11.1] Compilation against glibc-2.16.6 fails due to
	incompatible gnulib
Message-ID: <20120802145925.GC2038@dhcp-0-146.brq.redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV"
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
X-Mailman-Approved-At: Fri, 03 Aug 2012 03:05:13 -0400
Cc: Petr Pisar <ppisar@redhat.com>
X-BeenThere: bug-gnu-utils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports for the GNU utilities <bug-gnu-utils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-utils>
List-Post: <mailto:bug-gnu-utils@gnu.org>
List-Help: <mailto:bug-gnu-utils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 14:59:40 -0000


--6zdv2QT/q3FMhpsV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

it's not possible to build sharutils 4.11.1 with glibc-2.16.6:

make[4]: Entering directory `/home/test/fedora/sharutils/sharutils-4.11.1/l=
ib'
gcc -DHAVE_CONFIG_H -I. -I..  -I../intl   -O2 -g -pipe -Wall -Wp,-D_FORTIFY=
_SOURCE=3D2 -fexceptions -fstack-protector --param=3Dssp-buffer-size=3D4  -=
m64 -mtune=3Dgeneric -c localcharset.c
In file included from localcharset.c:28:0:
=2E/stdio.h:494:1: error: =E2=80=98gets=E2=80=99 undeclared here (not in a =
function)

The reason is glibc-2.16 stopped declaring gets(3) in modern build environm=
ents
and this makes bundled gnulib unhappy, where the error is from. gnulib
developers has fix
<http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/30298>.

Please update the gnulib or apply the fix to sharutil copy.

-- Petr

--6zdv2QT/q3FMhpsV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iF4EABEIAAYFAlAalc0ACgkQEsnFx2fG+qJPXAD/RZcRsu37bQny+Bu3cBYirFcy
O1mLTvubkI2gWZtww6gA/RJ836R0KEHiAmuXwtDNzOccTMCZ96MsAxPaLL3GExvU
=+civ
-----END PGP SIGNATURE-----

--6zdv2QT/q3FMhpsV--


From MAILER-DAEMON Fri Aug 03 03:05:17 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SxBwj-0007zI-JJ
	for mharc-bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 03:05:17 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <petr@redhat.com>) id 1Swxry-0003f5-1L
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 12:03:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <petr@redhat.com>) id 1Swxrw-0001ju-PS
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 12:03:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60331)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <petr@redhat.com>) id 1Swxrw-0001jS-B5
	for bug-gnu-utils@gnu.org; Thu, 02 Aug 2012 12:03:24 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72G3N6a004217
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-utils@gnu.org>; Thu, 2 Aug 2012 12:03:23 -0400
Received: from dhcp-0-146.brq.redhat.com (dhcp-25-104.brq.redhat.com
	[10.34.25.104])
	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q72G3LVw031034
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 2 Aug 2012 12:03:22 -0400
Received: from dhcp-0-146.brq.redhat.com (localhost.localdomain [127.0.0.1])
	by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5) with ESMTP id
	q72G3K4U009021; Thu, 2 Aug 2012 18:03:20 +0200
Received: (from petr@localhost)
	by dhcp-0-146.brq.redhat.com (8.14.5/8.14.5/Submit) id q72G3KpT009020; 
	Thu, 2 Aug 2012 18:03:20 +0200
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
To: bug-gnu-utils@gnu.org
Subject: [PATCH] Fix building with glibc-2.16.6
Date: Thu,  2 Aug 2012 18:03:07 +0200
Message-Id: <1343923387-8975-1-git-send-email-ppisar@redhat.com>
In-Reply-To: <20120802145925.GC2038@dhcp-0-146.brq.redhat.com>
References: <20120802145925.GC2038@dhcp-0-146.brq.redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
X-Mailman-Approved-At: Fri, 03 Aug 2012 03:05:16 -0400
Cc: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
X-BeenThere: bug-gnu-utils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports for the GNU utilities <bug-gnu-utils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-utils>
List-Post: <mailto:bug-gnu-utils@gnu.org>
List-Help: <mailto:bug-gnu-utils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 16:03:32 -0000

Ported to sharutils-4.11.1 from gnulib commit:

>From 66712c23388e93e5c518ebc8515140fa0c807348 Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake@redhat.com>
Date: Thu, 29 Mar 2012 13:30:41 -0600
Subject: [PATCH] stdio: don't assume gets any more

Gnulib intentionally does not have a gets module, and now that C11
and glibc have dropped it, we should be more proactive about warning
any user on a platform that still has a declaration of this dangerous
interface.
---
 lib/stdio.in.h    | 12 +++++++-----
 m4/stdio_h.m4     |  4 ++--
 m4/warn-on-use.m4 |  4 ++--
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/lib/stdio.in.h b/lib/stdio.in.h
index 57e93ba..6ab9c8b 100644
--- a/lib/stdio.in.h
+++ b/lib/stdio.in.h
@@ -176,10 +176,12 @@ _GL_WARN_ON_USE (fflush, "fflush is not always POSIX compliant - "
 #endif
 
 /* It is very rare that the developer ever has full control of stdin,
-   so any use of gets warrants an unconditional warning.  Assume it is
-   always declared, since it is required by C89.  */
+   so any use of gets warrants an unconditional warning; besides, C11
+   removed it.  */
 #undef gets
+#if HAVE_RAW_DECL_GETS
 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+#endif
 
 #if @GNULIB_FOPEN@
 # if @REPLACE_FOPEN@
@@ -902,9 +904,9 @@ _GL_WARN_ON_USE (snprintf, "snprintf is unportable - "
 # endif
 #endif
 
-/* Some people would argue that sprintf should be handled like gets
-   (for example, OpenBSD issues a link warning for both functions),
-   since both can cause security holes due to buffer overruns.
+/* Some people would argue that all sprintf uses should be warned about
+   (for example, OpenBSD issues a link warning for it),
+   since it can cause security holes due to buffer overruns.
    However, we believe that sprintf can be used safely, and is more
    efficient than snprintf in those safe cases; and as proof of our
    belief, we use sprintf in several gnulib modules.  So this header
diff --git a/m4/stdio_h.m4 b/m4/stdio_h.m4
index 7f3ae56..990c616 100644
--- a/m4/stdio_h.m4
+++ b/m4/stdio_h.m4
@@ -34,9 +34,9 @@ AC_DEFUN([gl_STDIO_H],
 
   dnl Check for declarations of anything we want to poison if the
   dnl corresponding gnulib module is not in use, and which is not
-  dnl guaranteed by C89.
+  dnl guaranteed by both C89 and C11.
   gl_WARN_ON_USE_PREPARE([[#include <stdio.h>
-    ]], [dprintf fpurge fseeko ftello getdelim getline popen renameat
+    ]], [dprintf fpurge fseeko ftello getdelim getline gets popen renameat
     snprintf tmpfile vdprintf vsnprintf])
 ])
 
diff --git a/m4/warn-on-use.m4 b/m4/warn-on-use.m4
index e0d0f27..4b07efb 100644
--- a/m4/warn-on-use.m4
+++ b/m4/warn-on-use.m4
@@ -18,8 +18,8 @@ dnl with or without modifications, as long as this notice is preserved.
 # some systems declare functions in the wrong header, then INCLUDES
 # should do likewise.
 #
-# If you assume C89, then it is generally safe to assume declarations
-# for functions declared in that standard (such as gets) without
+# It is generally safe to assume declarations for functions declared
+# in the intersection of C89 and C11 (such as printf) without
 # needing gl_WARN_ON_USE_PREPARE.
 AC_DEFUN([gl_WARN_ON_USE_PREPARE],
 [
-- 
1.7.11.2



From MAILER-DAEMON Fri Aug 03 10:22:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SxIla-0001h2-E6
	for mharc-bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 10:22:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SxIlY-0001fr-8H
	for bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 10:22:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SxIlS-0004Ai-9n
	for bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 10:22:12 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:52349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SxIlS-0004Ad-6N
	for bug-gnu-utils@gnu.org; Fri, 03 Aug 2012 10:22:06 -0400
Received: from adsl-76-254-26-157.dsl.pltn13.sbcglobal.net
	([76.254.26.157]:55411 helo=[192.168.10.2])
	by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bkorb@gnu.org>)
	id 1SxIlR-0001OV-PM; Fri, 03 Aug 2012 10:22:06 -0400
Message-ID: <501BDE88.5060600@gnu.org>
Date: Fri, 03 Aug 2012 07:22:00 -0700
From: Bruce Korb <bkorb@gnu.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Petr Pisar <ppisar@redhat.com>
Subject: Re: [sharutils-4.11.1] Compilation against glibc-2.16.6 fails due
	to incompatible gnulib
References: <20120802145925.GC2038@dhcp-0-146.brq.redhat.com>
In-Reply-To: <20120802145925.GC2038@dhcp-0-146.brq.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.10
Cc: bug-gnu-utils@gnu.org
X-BeenThere: bug-gnu-utils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports for the GNU utilities <bug-gnu-utils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-utils>
List-Post: <mailto:bug-gnu-utils@gnu.org>
List-Help: <mailto:bug-gnu-utils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-utils>,
	<mailto:bug-gnu-utils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2012 14:22:13 -0000

On 08/02/12 07:59, Petr Pisar wrote:
> Please update the gnulib or apply the fix to sharutil copy.

The stuff from gnulib is automatically updated on every release.
The "every release" part doesn't mean it happens very often. :)
I'll bump out another release this weekend or next.  Thanks!


