From MAILER-DAEMON Sun Jan 01 04:50:07 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RhI3L-0001l4-7f
	for mharc-bug-patch@gnu.org; Sun, 01 Jan 2012 04:50:07 -0500
Received: from eggs.gnu.org ([140.186.70.92]:56360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhI3J-0001kC-Cu
	for bug-patch@gnu.org; Sun, 01 Jan 2012 04:50:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhI3I-0006co-Ew
	for bug-patch@gnu.org; Sun, 01 Jan 2012 04:50:05 -0500
Received: from mx.meyering.net ([88.168.87.75]:41050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhI3I-0006cS-8h
	for bug-patch@gnu.org; Sun, 01 Jan 2012 04:50:04 -0500
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 613EE600D0
	for <bug-patch@gnu.org>; Sun,  1 Jan 2012 10:50:03 +0100 (CET)
From: Jim Meyering <jim@meyering.net>
To: bug-patch@gnu.org
Date: Sun, 01 Jan 2012 10:50:03 +0100
Message-ID: <87lipr21mc.fsf@rho.meyering.net>
Lines: 5
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Subject: [bug-patch] FYI copyright updates for 2012
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jan 2012 09:50:06 -0000

I've done this:

    maint: update all copyright year number ranges

    Run "make update-copyright".


From MAILER-DAEMON Sun Jan 01 07:49:30 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RhKqw-0007xI-En
	for mharc-bug-patch@gnu.org; Sun, 01 Jan 2012 07:49:30 -0500
Received: from eggs.gnu.org ([140.186.70.92]:59498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhKqt-0007wT-T8
	for bug-patch@gnu.org; Sun, 01 Jan 2012 07:49:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhKqo-0004om-Vm
	for bug-patch@gnu.org; Sun, 01 Jan 2012 07:49:27 -0500
Received: from mail-ee0-f41.google.com ([74.125.83.41]:49997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhKqo-0004of-PC
	for bug-patch@gnu.org; Sun, 01 Jan 2012 07:49:22 -0500
Received: by eekc41 with SMTP id c41so15993144eek.0
	for <bug-patch@gnu.org>; Sun, 01 Jan 2012 04:49:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=subject:from:to:cc:date:in-reply-to:references:content-type
	:x-mailer:content-transfer-encoding:message-id:mime-version;
	bh=dovYT3jva7VobaaTG4C8t1/SCQmBkBqeue6dol4TGqA=;
	b=LS5/XIlsaQe60QnR2iH8ITy0R+irqzEL1Q21xlQ/gnC4WZl73Qn7B9sAES32rs/KrF
	3Z8Z6D4L1ub22tmVe0HpRs1yeYnmUZp6ZBygl2mWdINcHJXWMkgQ1yIP/B1YasUgOkYg
	DtET+oFT9h0wSsdmQUQsnYLp493wHGFE0BM0U=
Received: by 10.14.39.72 with SMTP id c48mr18870914eeb.25.1325422161377;
	Sun, 01 Jan 2012 04:49:21 -0800 (PST)
Received: from [192.168.91.169] (chello084114015216.14.vie.surfer.at.
	[84.114.15.216]) by mx.google.com with ESMTPS id
	y12sm175424039eeb.11.2012.01.01.04.49.19
	(version=SSLv3 cipher=OTHER); Sun, 01 Jan 2012 04:49:19 -0800 (PST)
From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
To: Steven Drake <sbd@NetBSD.org>
Date: Sun, 01 Jan 2012 13:49:18 +0100
In-Reply-To: <alpine.LNX.2.00.1112301522580.13359@nygne>
References: <alpine.LNX.2.00.1112301522580.13359@nygne>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) 
Content-Transfer-Encoding: 7bit
Message-ID: <1325422159.3350.49.camel@schurl.linbit>
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.83.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH 0/3] Asymmetric hunks fix
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jan 2012 12:49:28 -0000

Steve,

On Fri, 2011-12-30 at 15:36 +1300, Steven Drake wrote:
> GNU patches inability to handle asymmetric hunks as noted in
> "bug #25833: Patch fails to correctly apply hunks with asymmetric context"
> has become a major problem for pkgsrc users

we were using a version of GNU patch with the equivalent of your
proposed change on thousands of packages with many thousand patches,
over several months.  The results were problematic: hunks did
occasionally apply in the wrong places and we did not notice, leading to
wrong package builds.  This was way worse than the perceived original
problem (patches seemingly not applying as often as they should).

How are the patches with asymmetric hunks created in your case?  Why
can't they be refreshed when they break?  Any other ideas?

Thanks,
Andreas



From MAILER-DAEMON Sun Jan 01 16:40:55 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RhT9D-0005Eb-Om
	for mharc-bug-patch@gnu.org; Sun, 01 Jan 2012 16:40:55 -0500
Received: from eggs.gnu.org ([140.186.70.92]:46244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhT9A-0005Dj-On
	for bug-patch@gnu.org; Sun, 01 Jan 2012 16:40:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhT99-0005ec-Ib
	for bug-patch@gnu.org; Sun, 01 Jan 2012 16:40:52 -0500
Received: from mx.meyering.net ([88.168.87.75]:42673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RhT99-0005eO-Cc
	for bug-patch@gnu.org; Sun, 01 Jan 2012 16:40:51 -0500
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 8565C6015E
	for <bug-patch@gnu.org>; Sun,  1 Jan 2012 22:40:50 +0100 (CET)
From: Jim Meyering <jim@meyering.net>
To: bug-patch@gnu.org
Date: Sun, 01 Jan 2012 22:40:50 +0100
Message-ID: <87fwfzw17h.fsf@rho.meyering.net>
Lines: 103
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Subject: [bug-patch] [PATCH 1/2] maint: enable the useless_cpp_parens
	syntax-check rule
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jan 2012 21:40:53 -0000

Hi Andreas,

I noticed that two of the currently-disabled syntax checks
could be easily enabled.  One by removing useless parentheses,
and the other by reversing a few sp-TAB sequences in a single test.
These seem uncontroversial, but I'll wait a little, just in case.


>From d504183866dccdf8e7c09522b601236d91591141 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sun, 1 Jan 2012 10:54:51 +0100
Subject: [PATCH 1/2] maint: enable the useless_cpp_parens syntax-check rule

* cfg.mk (local-checks-to-skip): Remove sc_useless_cpp_parens,
thus enabling this syntax-check rule.
* src/patch.c: Remove unneeded parentheses.
---
 cfg.mk      |    3 +--
 src/patch.c |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 2730d3e..63dda64 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -31,8 +31,7 @@ local-checks-to-skip = \
   sc_prohibit_strcmp \
   sc_prohibit_test_minus_ao \
   sc_require_test_exit_idiom \
-  sc_space_tab \
-  sc_useless_cpp_parens
+  sc_space_tab

 exclude_file_name_regexp--sc_prohibit_doubled_word = ^src/util\.c$$
 exclude_file_name_regexp--sc_unmarked_diagnostics = ^src/util\.c$$
diff --git a/src/patch.c b/src/patch.c
index 652db31..9e94823 100644
--- a/src/patch.c
+++ b/src/patch.c
@@ -622,7 +622,7 @@ reinitialize_almost_everything (void)
 }

 static char const shortopts[] = "bB:cd:D:eEfF:g:i:l"
-#if 0 && defined(ENABLE_MERGE)
+#if 0 && defined ENABLE_MERGE
 				"m"
 #endif
 				"nNo:p:r:RstTuvV:x:Y:z:Z";
--
1.7.8.1.391.g2c2ad


>From d0745f417ce32d647ab5a949b6027404da5e98c3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sun, 1 Jan 2012 10:57:59 +0100
Subject: [PATCH 2/2] maint: enable the sc_space_tab syntax-check rule

* cfg.mk (local-checks-to-skip): Remove sc_space_tab,
thus enabling this syntax-check rule.
* tests/quoted-filenames: Use TAB-space, not space-TAB.
---
 cfg.mk                 |    3 +--
 tests/quoted-filenames |    8 ++++----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 63dda64..7fef9d0 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -30,8 +30,7 @@ local-checks-to-skip = \
   sc_prohibit_magic_number_exit \
   sc_prohibit_strcmp \
   sc_prohibit_test_minus_ao \
-  sc_require_test_exit_idiom \
-  sc_space_tab
+  sc_require_test_exit_idiom

 exclude_file_name_regexp--sc_prohibit_doubled_word = ^src/util\.c$$
 exclude_file_name_regexp--sc_unmarked_diagnostics = ^src/util\.c$$
diff --git a/tests/quoted-filenames b/tests/quoted-filenames
index ffbac09..d1fbe88 100644
--- a/tests/quoted-filenames
+++ b/tests/quoted-filenames
@@ -18,13 +18,13 @@ use_tmpdir
 #   \ / : * ? " < > |

 cat > d.diff <<EOF
-diff --git " \\t\\040" " \\t\\040"
---- " \\t\\040"
-+++ " \\t\\040"
+diff --git "\\t \\040" "\\t \\040"
+--- "\\t \\040"
++++ "\\t \\040"
 @@ -1 +1 @@
 -one
 +two
 EOF

-ncheck 'echo one > " 	 "'
+ncheck 'echo one > "	  "'
 ncheck 'patch -s -p0 < d.diff'
--
1.7.8.1.391.g2c2ad


From MAILER-DAEMON Sun Jan 01 18:15:28 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RhUci-0008JY-TR
	for mharc-bug-patch@gnu.org; Sun, 01 Jan 2012 18:15:28 -0500
Received: from eggs.gnu.org ([140.186.70.92]:51453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhUcg-0008JF-C4
	for bug-patch@gnu.org; Sun, 01 Jan 2012 18:15:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhUcf-0007sm-JL
	for bug-patch@gnu.org; Sun, 01 Jan 2012 18:15:26 -0500
Received: from mail-ee0-f41.google.com ([74.125.83.41]:54269)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1RhUcf-0007sc-CV
	for bug-patch@gnu.org; Sun, 01 Jan 2012 18:15:25 -0500
Received: by eekc41 with SMTP id c41so16210851eek.0
	for <bug-patch@gnu.org>; Sun, 01 Jan 2012 15:15:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=subject:from:to:cc:date:in-reply-to:references:content-type
	:x-mailer:content-transfer-encoding:message-id:mime-version;
	bh=HBOnvYsdmBrjyGQN7ipt90zOZjvb8xB3QAoUHbkG+uk=;
	b=jri6bX+yOzhYgH0JyMC0VitX0MBiFHuJp88Xg970ovS8MxPUn91BFk8ydsKlrhVVN1
	7fvuum1rSDDJa2Td6sknG5tt9vXw9vfadiUVtVt3+lUxqcR5jp1A+phgz+PA0Y21nWCx
	GpY5JBix7fl4iDGZ6OANBeSF7chCHbF6Jig+0=
Received: by 10.213.13.16 with SMTP id z16mr5787286ebz.52.1325459724370;
	Sun, 01 Jan 2012 15:15:24 -0800 (PST)
Received: from [192.168.91.169] (chello084114015216.14.vie.surfer.at.
	[84.114.15.216]) by mx.google.com with ESMTPS id
	y12sm182253252eeb.11.2012.01.01.15.15.22
	(version=SSLv3 cipher=OTHER); Sun, 01 Jan 2012 15:15:23 -0800 (PST)
From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
To: Jim Meyering <jim@meyering.net>
Date: Mon, 02 Jan 2012 00:15:21 +0100
In-Reply-To: <87fwfzw17h.fsf@rho.meyering.net>
References: <87fwfzw17h.fsf@rho.meyering.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) 
Content-Transfer-Encoding: 7bit
Message-ID: <1325459723.2433.3.camel@schurl.linbit>
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.83.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH 1/2] maint: enable the useless_cpp_parens
 syntax-check rule
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jan 2012 23:15:27 -0000

Hi Jim,

On Sun, 2012-01-01 at 22:40 +0100, Jim Meyering wrote:
> These seem uncontroversial

yes, the changes look fine.

Thanks,
Andreas



From MAILER-DAEMON Fri Jan 13 00:54:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Rla5V-00080V-Bz
	for mharc-bug-patch@gnu.org; Fri, 13 Jan 2012 00:54:05 -0500
Received: from eggs.gnu.org ([140.186.70.92]:37651)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mystica@gmail.com>) id 1RlY8u-00022z-W5
	for bug-patch@gnu.org; Thu, 12 Jan 2012 22:49:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mystica@gmail.com>) id 1RlY8t-0003H0-Tg
	for bug-patch@gnu.org; Thu, 12 Jan 2012 22:49:28 -0500
Received: from mail-ey0-f169.google.com ([209.85.215.169]:38821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mystica@gmail.com>) id 1RlY8t-0003Gw-MN
	for bug-patch@gnu.org; Thu, 12 Jan 2012 22:49:27 -0500
Received: by eaan1 with SMTP id n1so23751eaa.0
	for <bug-patch@gnu.org>; Thu, 12 Jan 2012 19:49:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	bh=sBubQYvvcIyviWcr59gNPDem1KezsbYAcau8y+qAE4I=;
	b=WENFBE7Ecv6lI7m3rNeSloDpT7Yb4CMq4QH6KEgQgQtflILUY86yxSyMtkhUoIfc8l
	rPF5k+WQvCz9H4uX0joh4bSjG3nRul3d9nt5cGAGfNk9Ka0AkyGMVWPFa//yscklF+Hd
	IbsoFuS3kM38iZTnt9L8E18cWGdKftn8cL5Bs=
MIME-Version: 1.0
Received: by 10.213.32.143 with SMTP id c15mr434378ebd.79.1326426565884; Thu,
	12 Jan 2012 19:49:25 -0800 (PST)
Received: by 10.213.13.145 with HTTP; Thu, 12 Jan 2012 19:49:25 -0800 (PST)
Date: Thu, 12 Jan 2012 20:49:25 -0700
Message-ID: <CAN++4hEp+L1cs4Py7KMW4fJiUaJiCwO=VWertwE-9MsvTngf8g@mail.gmail.com>
From: Mike Hodson <mystica@gmail.com>
To: bug-patch@gnu.org
Content-Type: multipart/alternative; boundary=0015174c399847bd5804b660c05c
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 209.85.215.169
X-Mailman-Approved-At: Fri, 13 Jan 2012 00:54:03 -0500
Subject: [bug-patch] patch fails to give notice that it is being ran in
 'dry-run' mode at any level of verbosity.
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2012 03:49:30 -0000

--0015174c399847bd5804b660c05c
Content-Type: text/plain; charset=ISO-8859-1

Good day,

I belive that the console output of 'patch' when in 'dry-run' mode should
actually notify of this and explicitly mention that no files will be
written or modified.

I have been trying to debug why something was not patching, when being used
as part of Gentoo's portage emerge process.   Portage never specified that
--dry-run was being used in any normal output (only if I dug through the
source or an environment log, or straced and looked at the execve() call)
so I was under the impression patch was actually being ran normally, and
that the .rej file was present in the directory as the output of patch
stated.

This obviously was not the case, as portage tries a --dry-run pass before
the real pass to simply find errors.  Portage in its patch process
redirects all of patch's output to a log file. Due to the bug in portage,
the command it logs is not actually the one that is executed. As such, this
log file never once mentioned a dry run.

Due to this, I believe patch needs some mention that a dry run pass is
being called.

A bug is also being filed with Gentoo's Portage project to not obfuscate
the dry-run from the logged commandline output.

A simple addition of a notice that patch is being run in 'dry-run' mode
would be greatly appreciated.

Thanks,

Mike

--0015174c399847bd5804b660c05c
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Good day,<br><br>I belive that the console output of &#39;patch&#39; when i=
n &#39;dry-run&#39; mode should actually notify of this and explicitly ment=
ion that no files will be written or modified.<br><br>I have been trying to=
 debug why something was not patching, when being used as part of Gentoo&#3=
9;s portage emerge process.=A0=A0 Portage never specified that --dry-run wa=
s being used in any normal output (only if I dug through the source or an e=
nvironment log, or straced and looked at the execve() call) so I was under =
the impression patch was actually being ran normally, and that the .rej fil=
e was present in the directory as the output of patch stated. <br>
<br>This obviously was not the case, as portage tries a --dry-run pass befo=
re the real pass to simply find errors.=A0 Portage in its patch process red=
irects all of patch&#39;s output to a log file. Due to the bug in portage, =
the command it logs is not actually the one that is executed. As such, this=
 log file never once mentioned a dry run.=A0 <br>
<br>Due to this, I believe patch needs some mention that a dry run pass is =
being called. <br><br>A bug is also being filed with Gentoo&#39;s Portage p=
roject to not obfuscate the dry-run from the logged commandline output.<br>
<br>A simple addition of a notice that patch is being run in &#39;dry-run&#=
39; mode would be greatly appreciated. <br><br>Thanks,<br><br>Mike<br><br>

--0015174c399847bd5804b660c05c--


From MAILER-DAEMON Fri Jan 13 17:12:49 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RlpMf-0006ML-6Z
	for mharc-bug-patch@gnu.org; Fri, 13 Jan 2012 17:12:49 -0500
Received: from eggs.gnu.org ([140.186.70.92]:45744)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RlpMc-0006Lh-Jj
	for bug-patch@gnu.org; Fri, 13 Jan 2012 17:12:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RlpMb-0000AT-Ql
	for bug-patch@gnu.org; Fri, 13 Jan 2012 17:12:46 -0500
Received: from mx.meyering.net ([88.168.87.75]:60420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1RlpMb-0000AN-Jm
	for bug-patch@gnu.org; Fri, 13 Jan 2012 17:12:45 -0500
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id ECE6160111;
	Fri, 13 Jan 2012 23:12:44 +0100 (CET)
From: Jim Meyering <jim@meyering.net>
To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
In-Reply-To: <1325459723.2433.3.camel@schurl.linbit> (Andreas Gruenbacher's
	message of "Mon, 02 Jan 2012 00:15:21 +0100")
References: <87fwfzw17h.fsf@rho.meyering.net>
	<1325459723.2433.3.camel@schurl.linbit>
Date: Fri, 13 Jan 2012 23:12:44 +0100
Message-ID: <87r4z3p7z7.fsf@rho.meyering.net>
Lines: 7
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH 1/2] maint: enable the useless_cpp_parens
	syntax-check rule
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2012 22:12:47 -0000

Andreas Gruenbacher wrote:
> On Sun, 2012-01-01 at 22:40 +0100, Jim Meyering wrote:
>> These seem uncontroversial
>
> yes, the changes look fine.

Thanks for the review.  Pushed.


