From MAILER-DAEMON Wed Aug 01 07:50:27 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwXRb-0003Fe-Al
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 07:50:27 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwXRU-0003Ak-RB
	for bug-patch@gnu.org; Wed, 01 Aug 2012 07:50:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwXRQ-0003Pf-Jl
	for bug-patch@gnu.org; Wed, 01 Aug 2012 07:50:20 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:40648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwXRQ-0003PX-Bg
	for bug-patch@gnu.org; Wed, 01 Aug 2012 07:50:16 -0400
Received: by lahi5 with SMTP id i5so5050191lah.0
	for <bug-patch@gnu.org>; Wed, 01 Aug 2012 04:50:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type;
	bh=RfjFrKQBlxu/lu8FCtbjUVjaV1SenilFcNntAp5t6pU=;
	b=SYqYxLj4R1B4xnXMAPOjMXryfii/qUxZ67PcHLIVnQO+VAb9kui9Y1CQmbG1/TRV1a
	wu+trbv0jQZ8HYGcny2TCXWOHOB620PxCmjjrAjvdya3PRO5T+R9Lqqv7fXZu/viivFf
	lzbFJrEg117TRr/Q1kEaTrxLLVYna+d7knmGp3020jUrZgB1yBUbttMgSpxOlBMG/A0K
	8B73CB1W3/9SDaiwymUX8ngPNkedzIoPvedRHuCnq2xirfNrjtC9Li0qoIt6UBgTLWR4
	VH2w5ZcTXA7qIE8OyL4kjSxw2A2VhlRZGnaHqbWN7MuSC/tr0Ahp1/nHNUPyDHOSlcnw
	7Dag==
MIME-Version: 1.0
Received: by 10.112.47.231 with SMTP id g7mr8264158lbn.29.1343821814426; Wed,
	01 Aug 2012 04:50:14 -0700 (PDT)
Sender: andreas.gruenbacher@gmail.com
Received: by 10.112.149.38 with HTTP; Wed, 1 Aug 2012 04:50:14 -0700 (PDT)
Date: Wed, 1 Aug 2012 13:50:14 +0200
X-Google-Sender-Auth: 9NLbZwM5NLtj8JwZsDKYBlqO48s
Message-ID: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <agruen@gnu.org>
To: bug-patch@gnu.org
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: git@vger.kernel.org
Subject: [bug-patch] GNU patch close to next stable release (2)
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 11:50:26 -0000

After another improvement in git-style diff support to better handle
concatenated
diffs, here is a last call for testing to ensure that the code works
well enough to
become the next stable release. Please find the latest development snapshots
here:

  ftp://alpha.gnu.org/gnu/patch/

The following significant changes have happened since the last stable release
in December 2009:

* Support for most features of the "diff --git" format, including renames and
  copies, permission changes, and symlink diffs.  Binary diffs are not
  supported yet; patch will complain and skip them.

* Support for double-quoted filenames in the "diff --git" format: when a
  filename starts with a double quote, it is interpreted as a C string
  literal.  The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, and \ooo
  (a three-digit octal number between 0 and 255) are recognized.

* Patch now ignores destination file names that are absolute or that contain
  a component of "..".  This addresses CVE-2010-4651.

* Refuse to apply a normal patch to a symlink.  (Previous versions of patch
  were replacing the symlink with a regular file.)

* When trying to modify a read-only file, warn about the potential problem
  by default.  The --read-only command line option allows to change this
  behavior.

* Files that should be deleted are now deleted once the entire patch file has
  been read.  This fixes a bug with numbered backup files.

* When a timestamp specifies a time zone, honor that instead of assuming the
  local time zone (--set-date) or Universal Coordinated Time (--set-utc).

* Support for nanosecond precision timestamps.

* Many portability and bug fixes.

Please report bugs or suggestions on the <bug-patch@gnu.org> mailing list, or
in the project's bug tracker on Savannah:

  http://savannah.gnu.org/projects/patch

Thanks,
Andreas


From MAILER-DAEMON Wed Aug 01 08:26:22 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwY0M-0005j2-GY
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 08:26:22 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SwY0E-0005NW-NH
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:26:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SwY09-0006rN-AH
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:26:14 -0400
Received: from vint.altlinux.org ([194.107.17.35]:38657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SwY09-0006qz-2I
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:26:09 -0400
Received: from wo.int.altlinux.org (wo.int.altlinux.org [192.168.1.4])
	by vint.altlinux.org (Postfix) with ESMTP id A5509226C0A6
	for <bug-patch@gnu.org>; Wed,  1 Aug 2012 12:26:06 +0000 (UTC)
Received: by wo.int.altlinux.org (Postfix, from userid 508)
	id 3B88B3F48AB0; Wed,  1 Aug 2012 16:26:06 +0400 (MSK)
Date: Wed, 1 Aug 2012 16:26:06 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: bug-patch@gnu.org
Message-ID: <20120801122606.GA7983@altlinux.org>
References: <20120523151254.GA5758@altlinux.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
In-Reply-To: <20120523151254.GA5758@altlinux.org>
X-fingerprint: FE4C 93AB E19A 2E4C CB5D  3E4E 7CAB E6AC 9E35 361E
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 194.107.17.35
Subject: [bug-patch] [RESEND] another v2.6.1-165-gc43eeb2 regression
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 12:26:20 -0000


--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

Starting with commit v2.6.1-165-gc43eeb2 and up to current HEAD
(v2.6.1-176-g386ae15), a certain kind of patch files is no longer
processed properly.  Here is a sample.

$ patch -p1 << '__EOF__'
From: Your Name <you@example.com>
Date: Wed, 24 Apr 2012 12:34:56 +0000
Subject: [PATCH 1/2] 1

---
 target |    1 +
 1 file changed, 1 insertion(+)
 create mode 100644 target

diff --git a/target b/target
new file mode 100644
index 0000000..d00491f
--- /dev/null
+++ b/target
@@ -0,0 +1 @@
+1

From: Your Name <you@example.com>
Date: Wed, 24 Apr 2012 12:34:56 +0000
Subject: [PATCH 2/2] 2

---
 target |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target b/target
index d00491f..0cfbf08 100644
--- a/target
+++ b/target
@@ -1 +1 @@
-1
+2
__EOF__
patching file target
can't find file to patch at input line 30
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|
|From: Your Name <you@example.com>
|Date: Wed, 24 Apr 2012 12:34:56 +0000
|Subject: [PATCH 2/2] 2
|
|---
| target |    2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
|diff --git a/target b/target
|index d00491f..0cfbf08 100644
|--- a/target
|+++ b/target
--------------------------
File to patch:=20
Skip this patch? [y]=20
Skipping patch.
1 out of 1 hunk ignored
$ cat target=20
1

The bug was originally reported via https://bugzilla.altlinux.org/27359
by Konstantin Pavlov.


--=20
ldv

--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlAZIF4ACgkQfKvmrJ41Nh61qQCgmWpAYF7UnG/9kuedKmgDtTMx
MJYAn3fzlk2M/fznzPyLWJfHi1OcIg5D
=5rVl
-----END PGP SIGNATURE-----

--bp/iNruPH9dso1Pn--


From MAILER-DAEMON Wed Aug 01 08:35:45 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwY9R-0008Jq-RA
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 08:35:45 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34242)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwY9K-0008Jb-Ht
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:35:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwY9A-0001Pc-SA
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:35:38 -0400
Received: from mx.meyering.net ([88.168.87.75]:42461)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwY9A-0001PV-Le
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:35:28 -0400
Received: from rho.meyering.net (rho.meyering.net [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 0B8EC60069
	for <bug-patch@gnu.org>; Wed,  1 Aug 2012 14:35:28 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: bug-patch@gnu.org
Date: Wed, 01 Aug 2012 14:35:28 +0200
Message-ID: <87k3xissbz.fsf@rho.meyering.net>
Lines: 30
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Subject: [bug-patch] [PATCH] build: remove unnecessary if-before-free
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 12:35:44 -0000

This probably counts as trivial, but with an impending release
I'll wait for an ACK before pushing it.

>From 7ce9bbfdb5d671702e3eabc921fb99b195367e91 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 1 Aug 2012 14:33:39 +0200
Subject: [PATCH] build: remove unnecessary if-before-free

* src/util.c (update_sha1): Remove unnecessary if-before-free,
to avoid "make syntax-check" failure.
---
 src/util.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util.c b/src/util.c
index d392ffe..9177fda 100644
--- a/src/util.c
+++ b/src/util.c
@@ -152,8 +152,7 @@ update_sha1 (struct stat const *st, char const *sha1)
   if (! p)
     p = __insert_file_id (st, UNKNOWN);
   else
-    if (p->sha1)
-      free (p->sha1);
+    free (p->sha1);
   p->sha1 = sha1 ? xstrdup (sha1) : 0;
 }

--
1.7.12.rc1.10.g97c7934


From MAILER-DAEMON Wed Aug 01 08:38:26 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwYC2-00008Q-Ok
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 08:38:26 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYC0-0008Ui-KK
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:38:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYBz-0002XV-Gl
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:38:24 -0400
Received: from mx.meyering.net ([88.168.87.75]:42468)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYBz-0002XG-9i
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:38:23 -0400
Received: from rho.meyering.net (rho.meyering.net [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id ACC6C60121
	for <bug-patch@gnu.org>; Wed,  1 Aug 2012 14:38:22 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: bug-patch@gnu.org
Date: Wed, 01 Aug 2012 14:38:22 +0200
Message-ID: <87ehnqss75.fsf@rho.meyering.net>
Lines: 34
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Subject: [bug-patch] [PATCH] build: mark an internal function as "pure"
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 12:38:26 -0000

Without this patch and configured with --enable-gcc-warnings,
building with recent gcc would fail:

  pch.c: In function 'sha1_says_nonexistent':
  pch.c:363:1: error: function might be candidate for attribute 'pure'\
    if it is known to return normally [-Werror=suggest-attribute=pure]


>From 4b53f76083b1557b529968159fe88581d89058a4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 1 Aug 2012 14:32:33 +0200
Subject: [PATCH] build: mark an internal function as "pure"

* src/pch.c (sha1_says_nonexistent): Apply _GL_ATTRIBUTE_PURE,
to avoid failure with -Werror=suggest-attribute=pure.
---
 src/pch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pch.c b/src/pch.c
index c4205f2..05874e0 100644
--- a/src/pch.c
+++ b/src/pch.c
@@ -359,7 +359,7 @@ get_sha1(char **sha1, char const *start, char const *end)
   (*sha1)[len] = 0;
 }

-static int
+static int _GL_ATTRIBUTE_PURE
 sha1_says_nonexistent(char const *sha1)
 {
   char const *empty_sha1 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391";
--
1.7.12.rc1.10.g97c7934


From MAILER-DAEMON Wed Aug 01 08:40:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwYE5-0001Kg-Fs
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 08:40:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56047)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYDy-0001Jn-PH
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:40:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYDt-00032V-33
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:40:26 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:35310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYDs-00032H-S3
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:40:21 -0400
Received: by lahi5 with SMTP id i5so5079298lah.0
	for <bug-patch@gnu.org>; Wed, 01 Aug 2012 05:40:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=b3jhcF/uH1LdpkPYjbVQLxDoG1+0DRFE5rvJIIMUaws=;
	b=aIuuclNDcroIoUF6MhUc385OyBrg2eO73RVMTO6xVQ6IvYvmPEXlSaaHq3KR/g1WBz
	AnJdQVPszWtrh583q0CF+e3RCbwW97jAfkGMX4vy5VeUIo5o63aVQdUSjQn17MUcEcfb
	U2eVNuAv80NznW4XaQDF0W+S0JOTI6JYn+7jH6eLj86kBReGnD1PcYINRcPAVtalMScE
	s/D7SxKFDcZJ03G/7zklsdpDq8nNq+NIwkjA9kEr/myUw4Li9qzCnvsxO7rESV76SI6V
	wfPi0Yi0WKlrfIx/rrXP55XgCu0saO6fMQGoPRm8PjStgFXCtf1bJaawn0FKc+GtkDGq
	KNSQ==
MIME-Version: 1.0
Received: by 10.152.46.6 with SMTP id r6mr18132145lam.7.1343824819787; Wed, 01
	Aug 2012 05:40:19 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Wed, 1 Aug 2012 05:40:19 -0700 (PDT)
In-Reply-To: <87k3xissbz.fsf@rho.meyering.net>
References: <87k3xissbz.fsf@rho.meyering.net>
Date: Wed, 1 Aug 2012 14:40:19 +0200
Message-ID: <CAHpGcMK9znFBf6YqRDurp=mSW75mCE51h8a4udn1r0Oi03Ubkw@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: Jim Meyering <jim@meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] build: remove unnecessary if-before-free
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 12:40:32 -0000

Jim,

2012/8/1 Jim Meyering <jim@meyering.net>:
> This probably counts as trivial, but with an impending release
> I'll wait for an ACK before pushing it.

this looks okay.

Thanks,
Andreas


From MAILER-DAEMON Wed Aug 01 08:50:08 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwYNM-0004DD-Mk
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 08:50:08 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45445)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYNJ-00044d-DU
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:50:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYNH-000642-Om
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:50:05 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:43579)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYNH-00061R-DM
	for bug-patch@gnu.org; Wed, 01 Aug 2012 08:50:03 -0400
Received: by lahi5 with SMTP id i5so5085654lah.0
	for <bug-patch@gnu.org>; Wed, 01 Aug 2012 05:50:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=BCLt1YpC+LoRPBuC4gA1SbBadeuYZNulwRu4eIZh8N8=;
	b=NEZ5ujh4TnzkGK6xyVOcrNtCOuuPEMAY2InDXFpZxzcs1LwBhJtPfeV1iRwmRNTaK5
	v2GfF57DOu4udXse+h+qOXdi7J7foMtz2aZukegGU3qaG5CSu0py50BdEWJleRiB9u8T
	d/aElkoctefJzkk8syTqop9Q2zIsM47SDjFiZq3kGulOMfv3i1bHmRA66odaj9m6Fej6
	V3p8twlqt4fJNRT6loKuo00+Xufkjs31i8lt/rYWSz2E5FjOFmjMpTB6S9gaUsjSId8Q
	4sAGn35yfUZOiYjJJm76DCyh3lCimnTk4s7YwDApPw5ZCemDil1qvVdyDBKnk1nSOQML
	Qt4A==
MIME-Version: 1.0
Received: by 10.112.30.41 with SMTP id p9mr8324521lbh.26.1343825401449; Wed,
	01 Aug 2012 05:50:01 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Wed, 1 Aug 2012 05:50:01 -0700 (PDT)
In-Reply-To: <87ehnqss75.fsf@rho.meyering.net>
References: <87ehnqss75.fsf@rho.meyering.net>
Date: Wed, 1 Aug 2012 14:50:01 +0200
Message-ID: <CAHpGcMLqZtHQQ7ER31xLAHL9imZZ0g8u6WOoqBTdeyU-CKTqqQ@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: Jim Meyering <jim@meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] build: mark an internal function as "pure"
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 12:50:06 -0000

Jim,

2012/8/1 Jim Meyering <jim@meyering.net>:
> -static int
> +static int _GL_ATTRIBUTE_PURE

thanks.


From MAILER-DAEMON Wed Aug 01 09:09:02 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwYfe-00027f-Le
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 09:09:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYfU-00026g-4W
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:09:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYfQ-0003uM-4r
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:08:52 -0400
Received: from mx.meyering.net ([88.168.87.75]:42553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwYfP-0003uG-UB
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:08:48 -0400
Received: from rho.meyering.net (rho.meyering.net [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 2E1F1600B2;
	Wed,  1 Aug 2012 15:08:47 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
In-Reply-To: <CAHpGcMK9znFBf6YqRDurp=mSW75mCE51h8a4udn1r0Oi03Ubkw@mail.gmail.com>
	("Andreas \=\?iso-8859-1\?Q\?Gr\=FCnbacher\=22's\?\= message of "Wed,
	1 Aug 2012 14:40:19 +0200")
References: <87k3xissbz.fsf@rho.meyering.net>
	<CAHpGcMK9znFBf6YqRDurp=mSW75mCE51h8a4udn1r0Oi03Ubkw@mail.gmail.com>
Date: Wed, 01 Aug 2012 15:08:47 +0200
Message-ID: <878vdysqsg.fsf@rho.meyering.net>
Lines: 7
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] build: remove unnecessary if-before-free
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 13:09:01 -0000

> 2012/8/1 Jim Meyering <jim@meyering.net>:
>> This probably counts as trivial, but with an impending release
>> I'll wait for an ACK before pushing it.
>
> this looks okay.

Thanks.  I've pushed both.


From MAILER-DAEMON Wed Aug 01 09:14:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwYkg-0003ZT-Hg
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 09:14:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:53575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYke-0003ZN-MY
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:14:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYka-0005Y7-Ip
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:14:12 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:53177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SwYka-0005Xu-B6
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:14:08 -0400
Received: by lahi5 with SMTP id i5so5101287lah.0
	for <bug-patch@gnu.org>; Wed, 01 Aug 2012 06:14:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=NZo1nGagLjLHlIKRneMAlSNDA0bn7JNRkhkC5DDJGQs=;
	b=XVcSWS6aBPRGgmBf+4CwjOAhU4/jHjtRBDejtgwVjZEHU/lPv+JRCp6/ZjH5jvj9s5
	aPBmPlf8y1y8pe/PSGEc19oEmhdGcRB9YDjzt54R+Kn8PNMfRdeen1cYxUIfnr+6em/Z
	QISI30+IKPqyE3j05jOtoUEGNwujH2WJ5j+VAN3nxIVei39+Un5YP1xyaRlzr9UzG//1
	fSJ5B7B1h0vNfldAw54R1RdhJYqTOV8ZWOJJ4RqiJrErGPN2pqcNfExqmPlM2u/FjjPn
	ts9tGfAqxzVOSO9EDBBOJVVol0OfnsFwypegvul3Mp3evri/prEfRRtVzNt3J9n5yQrh
	yojw==
MIME-Version: 1.0
Received: by 10.112.100.7 with SMTP id eu7mr8095169lbb.105.1343826847222; Wed,
	01 Aug 2012 06:14:07 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Wed, 1 Aug 2012 06:14:07 -0700 (PDT)
In-Reply-To: <20120801122606.GA7983@altlinux.org>
References: <20120523151254.GA5758@altlinux.org>
	<20120801122606.GA7983@altlinux.org>
Date: Wed, 1 Aug 2012 15:14:07 +0200
Message-ID: <CAHpGcMKXZi=KuQq4zSMXs3v=DD08xsnEW7gxPXVPbJAs8paZFA@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [RESEND] another v2.6.1-165-gc43eeb2 regression
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 13:14:13 -0000

Dmitry,

2012/8/1 Dmitry V. Levin <ldv@altlinux.org>:
> Hi,
>
> Starting with commit v2.6.1-165-gc43eeb2 and up to current HEAD
> (v2.6.1-176-g386ae15), a certain kind of patch files is no longer
> processed properly.  Here is a sample.

thanks, I see what's still going wrong; I've added a test case that
covers this particular
problem now.

Andreas


From MAILER-DAEMON Wed Aug 01 09:33:13 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SwZ33-00057F-Ot
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 09:33:13 -0400
Received: from eggs.gnu.org ([208.118.235.92]:54767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwZ2s-00054u-DM
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:33:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwZ2o-0003sY-6d
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:33:02 -0400
Received: from mx.meyering.net ([88.168.87.75]:42613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SwZ2n-0003sD-VW
	for bug-patch@gnu.org; Wed, 01 Aug 2012 09:32:58 -0400
Received: from rho.meyering.net (rho.meyering.net [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 960A060121
	for <bug-patch@gnu.org>; Wed,  1 Aug 2012 15:32:56 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: bug-patch@gnu.org
Date: Wed, 01 Aug 2012 15:32:56 +0200
Message-ID: <871ujqspo7.fsf@rho.meyering.net>
Lines: 57
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Subject: [bug-patch] [PATCH] patch: don't close a negative file descriptor
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 13:33:11 -0000

I ran a valgrind-wrapped patch through the test suite,
and saw many of these warnings:

    ==10347== Warning: invalid file descriptor -1 in syscall close()
    ==10347==    at 0x31686E4B80: __close_nocancel (in /usr/lib64/libc-2.15.so)
    ==10347==    by 0x4054BA: re_input (inp.c:64)
    ==10347==    by 0x404353: main (patch.c:639)

This suggests that the above is triggered by many of the test cases:

    $ grep -h Command..patch $(grep -l Warn *)
    ==10347== Command: patch -f -p1
    ==10472== Command: patch -p1
    ==10561== Command: patch -f -n
    ==10578== Command: patch -f -p0 --dry-run
    ==10739== Command: patch -p0 --read-only=fail
    ==10905== Command: patch
    ==10947== Command: patch -f -p0 --dry-run
    ==11018== Command: patch
    ==11054== Command: patch -p0
    ==11199== Command: patch -f -p1 --dry-run
    ==11229== Command: patch
    ==11332== Command: patch -f -p0 --dry-run
    ==11391== Command: patch -f -e
    ==11460== Command: patch -f -p0 --dry-run
    ==11491== Command: patch f
    ==11721== Command: patch -f -p0
    ==11729== Command: patch c

This patch fixes it:

>From 94aaeff8afa7e1cf1c5107470644f8b374d9cc00 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 1 Aug 2012 15:32:27 +0200
Subject: [PATCH] patch: don't close a negative file descriptor

* src/inp.c (re_input): Don't close FD if it's negative.
---
 src/inp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/inp.c b/src/inp.c
index 9cc140f..6387587 100644
--- a/src/inp.c
+++ b/src/inp.c
@@ -61,7 +61,8 @@ re_input (void)
 	}
     }
     else {
-	close (tifd);
+	if (tifd >= 0)
+	  close (tifd);
 	tifd = -1;
 	if (tibuf[0])
 	  {
--
1.7.12.rc1.10.g97c7934


From MAILER-DAEMON Wed Aug 01 14:37:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Swdn7-0005vp-L2
	for mharc-bug-patch@gnu.org; Wed, 01 Aug 2012 14:37:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junio@b-sasl-quonix.pobox.com>) id 1Swdn2-0005tx-LI
	for bug-patch@gnu.org; Wed, 01 Aug 2012 14:37:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <junio@b-sasl-quonix.pobox.com>) id 1Swdn1-0007iV-Kw
	for bug-patch@gnu.org; Wed, 01 Aug 2012 14:37:00 -0400
Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:35516
	helo=smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junio@b-sasl-quonix.pobox.com>)
	id 1Swdn0-0007dm-2A; Wed, 01 Aug 2012 14:36:58 -0400
Received: from smtp.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id D1D5191EC;
	Wed,  1 Aug 2012 13:58:08 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type:content-transfer-encoding; s=sasl; bh=1fn5jNxpv+oS
	kLss54IrFb5CDfk=; b=QpA5c+f2KzY3kJhVbm0BN3t5940pk9gnXsrEDuq4AZa3
	zkBWwsFjDtO/G/tuA+h7TkZbBkA0WaP9CaH4Ns/DNWMn16mprRODIur5wrZpuAIH
	ohdD4uQi3OpqI5iMfYhTM2YYigty/eYbI6b06SRXGQDAqGTNwkPKJocFeniRAb8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type:content-transfer-encoding; q=dns; s=sasl; b=EEx5rl
	/MbqDDyoPByYQapI1xkzWwkmWoJlh7JNWby97UmqGKBvD3pSzdotmGhoMjR7+xS1
	RPHSO2vK7Wxta9PENibO25UFAocxT+QOvSJLEOI+qbm3VYumFsgP3opGBdASqdux
	ZhlyoEk6YRMVuTiWzC1HQxEsa8PQc84MMWPfo=
Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1])
	by b-sasl-quonix.pobox.com (Postfix) with ESMTP id BEA4791EA;
	Wed,  1 Aug 2012 13:58:08 -0400 (EDT)
Received: from pobox.com (unknown [98.234.214.94]) (using TLSv1 with cipher
	DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by
	b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 3108291E9;
	Wed,  1 Aug 2012 13:58:08 -0400 (EDT)
From: Junio C Hamano <gitster@pobox.com>
To: Andreas =?utf-8?Q?Gr=C3=BCnbacher?= <agruen@gnu.org>
References: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
Date: Wed, 01 Aug 2012 10:58:06 -0700
In-Reply-To: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
	("Andreas =?utf-8?Q?Gr=C3=BCnbacher=22's?= message of "Wed, 1 Aug 2012
	13:50:14 +0200")
Message-ID: <7v8vdyfqa9.fsf@alter.siamese.dyndns.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
X-Pobox-Relay-ID: 7368583C-DC02-11E1-B430-01B42E706CDE-77302942!b-pb-sasl-quonix.pobox.com
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta)
X-Received-From: 208.72.237.35
Cc: bug-patch@gnu.org, git@vger.kernel.org
Subject: Re: [bug-patch] GNU patch close to next stable release (2)
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 18:37:01 -0000

Andreas Gr=C3=BCnbacher <agruen@gnu.org> writes:

> * Support for double-quoted filenames in the "diff --git" format: when =
a
>   filename starts with a double quote, it is interpreted as a C string
>   literal.  The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, an=
d \ooo
>   (a three-digit octal number between 0 and 255) are recognized.

Is this also available in non-git diffs?  IIRC, this extension to
allow funny characters in pathnames was proposed by and discussed
with Paul Eggert (listed as one of GNU diffutils maintainers at
www.gnu.org/software/diffutils/) and git happened to adopt it
earlier than "GNU diff" itself did.

I found it a bit odd to see this listed as one of the items needed
to support "diff --git" oddity.


From MAILER-DAEMON Thu Aug 02 14:43:42 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sx0N4-0004RH-Ae
	for mharc-bug-patch@gnu.org; Thu, 02 Aug 2012 14:43:42 -0400
Received: from eggs.gnu.org ([208.118.235.92]:59556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sx0N2-0004R3-BW
	for bug-patch@gnu.org; Thu, 02 Aug 2012 14:43:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sx0N1-0001pZ-JX
	for bug-patch@gnu.org; Thu, 02 Aug 2012 14:43:40 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:64871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sx0N1-0001pN-CM
	for bug-patch@gnu.org; Thu, 02 Aug 2012 14:43:39 -0400
Received: by lbon3 with SMTP id n3so417968lbo.0
	for <bug-patch@gnu.org>; Thu, 02 Aug 2012 11:43:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=dpW3RLUQdJVyc4Iw5BdYTTCv8sv7d0Kqh93KzEhh92c=;
	b=bB6e/T3E0gQjVhB7ry9sEUU9pEjelucLicNrWTFroB2KpvVEJVZXsuweFbHO8KK6Gi
	d0Vz4XmuCpt0gHtRMLpc7NXv4IpA5eVb9TM/oo6i4TsgOyYE7vOI4k1n4hR99M6+/65v
	T1rtZUYL12vaZzJIriDBziK3uCtjlVsyaX6ZPGep0Dvu19AOko0YndKBEvcy0sFkzPCj
	7tkF1eD2TQhvAjTdHYfg2wcCWD/Powpqi2fTmtcotf/OxuxfnyH0thAhwRhBrmbOCATA
	jO4EYVD5Gobp8ARBdW47qLk3o+JJ08bxLeY8++E/Y2gjgu56vyZwuNMOyB3/W1ZVeu6d
	ZRBg==
MIME-Version: 1.0
Received: by 10.152.110.70 with SMTP id hy6mr22381214lab.44.1343933017439;
	Thu, 02 Aug 2012 11:43:37 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Thu, 2 Aug 2012 11:43:37 -0700 (PDT)
In-Reply-To: <CAHpGcMKXZi=KuQq4zSMXs3v=DD08xsnEW7gxPXVPbJAs8paZFA@mail.gmail.com>
References: <20120523151254.GA5758@altlinux.org>
	<20120801122606.GA7983@altlinux.org>
	<CAHpGcMKXZi=KuQq4zSMXs3v=DD08xsnEW7gxPXVPbJAs8paZFA@mail.gmail.com>
Date: Thu, 2 Aug 2012 20:43:37 +0200
Message-ID: <CAHpGcMLcAsZzi4ynHMf3pDZjmQ=1y6WWszCYqGC_LVkOk1j6DQ@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.217.169
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [RESEND] another v2.6.1-165-gc43eeb2 regression
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 18:43:41 -0000

Dimitry,

I have pushed a fix for this and uploaded a new snapshot. (The actual fix is a
one-line change, but documenting it took another ~20 lines.)

Thanks for your help!

Andreas


From MAILER-DAEMON Thu Aug 02 16:02:20 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sx1bA-0006uL-Ac
	for mharc-bug-patch@gnu.org; Thu, 02 Aug 2012 16:02:20 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sx1b4-0006to-Uy
	for bug-patch@gnu.org; Thu, 02 Aug 2012 16:02:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sx1b3-0001yJ-P9
	for bug-patch@gnu.org; Thu, 02 Aug 2012 16:02:14 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:60958)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>)
	id 1Sx1b3-0001yE-Hc; Thu, 02 Aug 2012 16:02:13 -0400
Received: by lahi5 with SMTP id i5so6041288lah.0
	for <multiple recipients>; Thu, 02 Aug 2012 13:02:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=1iT2MFEKzsNzumstfjewjepzsT6uXXSp8tovTl41nII=;
	b=EDvGb/a5fLRMf0xuAyIDBsrXh75hafkS28qQT8sLBNGX16T8W8oDamX0lqHLClANrr
	U4GytiucOHTV2eo7JeYzDxNtnVQKXU/JmkDknOns/iAWLvzbJ42V/tqMCTugjJEN/ZV0
	Zjih+A7geuU9L3Bu2ReTPQPPxsurNM7TOVNmryX92ZLUcqQsCcl2YdMuNJj3PgGoXY1Y
	q9g8F8E+5q6k0LCT66/ZDgsxo34td6t5X6jZt7MaG6g6ZHUDFb1B1ISojnazhnwqdybN
	+iiNb9wdkpm4AiLNbgwOt+BKYetmv8YEJD4tmsbfxeraCY7Xamc+G89+QLGInORq2gDU
	ti8A==
MIME-Version: 1.0
Received: by 10.112.43.67 with SMTP id u3mr10107642lbl.16.1343937732181; Thu,
	02 Aug 2012 13:02:12 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Thu, 2 Aug 2012 13:02:12 -0700 (PDT)
In-Reply-To: <7v8vdyfqa9.fsf@alter.siamese.dyndns.org>
References: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
	<7v8vdyfqa9.fsf@alter.siamese.dyndns.org>
Date: Thu, 2 Aug 2012 22:02:12 +0200
Message-ID: <CAHpGcML5PVAgd9x75=5k1-ev+Px4V+26KJhhyZk-O54p0WxfxQ@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: bug-diffutils@gnu.org, Jim Meyering <meyering@redhat.com>,
	bug-patch@gnu.org, Paul Eggert <eggert@cs.ucla.edu>, git@vger.kernel.org
Subject: Re: [bug-patch] GNU patch close to next stable release (2)
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 20:02:19 -0000

Junio,

2012/8/1 Junio C Hamano <gitster@pobox.com>:
> Andreas Gr=FCnbacher <agruen@gnu.org> writes:
>
>> * Support for double-quoted filenames in the "diff --git" format: when a
>>   filename starts with a double quote, it is interpreted as a C string
>>   literal.  The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, and=
 \ooo
>>   (a three-digit octal number between 0 and 255) are recognized.
>
> Is this also available in non-git diffs?

I have only enabled this for git-style diffs for now. GNU diff doesn't do
filename quoting so far and if it eventually implements a slightly differen=
t
form of quoting (which I wouldn't recommend), we might be in trouble.

> IIRC, this extension to allow funny characters in pathnames was
> proposed by and discussed with Paul Eggert (listed as one of GNU
> diffutils maintainers at www.gnu.org/software/diffutils/) and git happene=
d
> to adopt it earlier than "GNU diff" itself did.

Paul and Jim, any thoughts about adding filename quoting to GNU diff anytim=
e
soon, or about the format?

Thanks,
Andreas


From MAILER-DAEMON Thu Aug 02 17:08:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sx2dS-00087M-La
	for mharc-bug-patch@gnu.org; Thu, 02 Aug 2012 17:08:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1Sx2dR-000867-3B
	for bug-patch@gnu.org; Thu, 02 Aug 2012 17:08:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>) id 1Sx2dQ-00057m-9a
	for bug-patch@gnu.org; Thu, 02 Aug 2012 17:08:45 -0400
Received: from smtp.cs.ucla.edu ([131.179.128.62]:53828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eggert@cs.ucla.edu>)
	id 1Sx2dO-00056j-Dq; Thu, 02 Aug 2012 17:08:42 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp.cs.ucla.edu (Postfix) with ESMTP id B2287A60009;
	Thu,  2 Aug 2012 14:08:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu
Received: from smtp.cs.ucla.edu ([127.0.0.1])
	by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JnzNeATYyr9X; Thu,  2 Aug 2012 14:08:40 -0700 (PDT)
Received: from [192.168.1.4] (pool-108-23-119-2.lsanca.fios.verizon.net
	[108.23.119.2])
	by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 54EEBA60007;
	Thu,  2 Aug 2012 14:08:40 -0700 (PDT)
Message-ID: <501AEC59.7010907@cs.ucla.edu>
Date: Thu, 02 Aug 2012 14:08:41 -0700
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: =?UTF-8?B?QW5kcmVhcyBHcsO8bmJhY2hlcg==?=
 <andreas.gruenbacher@gmail.com>
References: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
	<7v8vdyfqa9.fsf@alter.siamese.dyndns.org>
	<CAHpGcML5PVAgd9x75=5k1-ev+Px4V+26KJhhyZk-O54p0WxfxQ@mail.gmail.com>
In-Reply-To: <CAHpGcML5PVAgd9x75=5k1-ev+Px4V+26KJhhyZk-O54p0WxfxQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 131.179.128.62
Cc: bug-diffutils@gnu.org, Jim Meyering <meyering@redhat.com>,
	bug-patch@gnu.org, git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [bug-patch] GNU patch close to next stable release (2)
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 21:08:46 -0000

On 08/02/2012 01:02 PM, Andreas Gr=C3=BCnbacher wrote:
> Paul and Jim, any thoughts about adding filename quoting to GNU diff an=
ytime
> soon, or about the format?

The git format looks OK.  I don't have time right now to add it to GNU di=
ff, tho.


From MAILER-DAEMON Thu Aug 02 17:13:55 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sx2iR-0001De-Mt
	for mharc-bug-patch@gnu.org; Thu, 02 Aug 2012 17:13:55 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1Sx2iP-0001Cl-OI
	for bug-patch@gnu.org; Thu, 02 Aug 2012 17:13:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1Sx2iO-0007yF-OT
	for bug-patch@gnu.org; Thu, 02 Aug 2012 17:13:53 -0400
Received: from mx.meyering.net ([88.168.87.75]:47617)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>)
	id 1Sx2iM-0007xN-Pa; Thu, 02 Aug 2012 17:13:50 -0400
Received: from rho.meyering.net (rho.meyering.net [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 439A5600AE;
	Thu,  2 Aug 2012 23:13:49 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@cs.ucla.edu>
In-Reply-To: <501AEC59.7010907@cs.ucla.edu> (Paul Eggert's message of "Thu, 02
	Aug 2012 14:08:41 -0700")
References: <CAHpGcM+DkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw@mail.gmail.com>
	<7v8vdyfqa9.fsf@alter.siamese.dyndns.org>
	<CAHpGcML5PVAgd9x75=5k1-ev+Px4V+26KJhhyZk-O54p0WxfxQ@mail.gmail.com>
	<501AEC59.7010907@cs.ucla.edu>
Date: Thu, 02 Aug 2012 23:13:49 +0200
Message-ID: <877gtht2sy.fsf@rho.meyering.net>
Lines: 9
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: bug-diffutils@gnu.org,
	Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>,
	Junio C Hamano <gitster@pobox.com>, bug-patch@gnu.org, git@vger.kernel.org
Subject: Re: [bug-patch] GNU patch close to next stable release (2)
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2012 21:13:54 -0000

Paul Eggert wrote:
> On 08/02/2012 01:02 PM, Andreas Gr=FCnbacher wrote:
>> Paul and Jim, any thoughts about adding filename quoting to GNU diff any=
time
>> soon, or about the format?
>
> The git format looks OK.  I don't have time right now to add it to GNU di=
ff, tho.

I agree, and have no more free time for the task than Paul does.
Would someone care to contribute a complete patch?


From MAILER-DAEMON Tue Aug 07 06:45:56 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SyhIS-0004E0-NL
	for mharc-bug-patch@gnu.org; Tue, 07 Aug 2012 06:45:56 -0400
Received: from eggs.gnu.org ([208.118.235.92]:58532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SyhIQ-0004DA-SZ
	for bug-patch@gnu.org; Tue, 07 Aug 2012 06:45:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SyhIP-0004VM-OR
	for bug-patch@gnu.org; Tue, 07 Aug 2012 06:45:54 -0400
Received: from vint.altlinux.org ([194.107.17.35]:45428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SyhIP-0004V1-Gn
	for bug-patch@gnu.org; Tue, 07 Aug 2012 06:45:53 -0400
Received: from wo.int.altlinux.org (wo.int.altlinux.org [192.168.1.4])
	by vint.altlinux.org (Postfix) with ESMTP id 4E7DF3F80019;
	Tue,  7 Aug 2012 10:45:51 +0000 (UTC)
Received: by wo.int.altlinux.org (Postfix, from userid 508)
	id 41C96519000D; Tue,  7 Aug 2012 14:45:51 +0400 (MSK)
Date: Tue, 7 Aug 2012 14:45:51 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
Message-ID: <20120807104551.GB13375@altlinux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 194.107.17.35
Cc: bug-patch@gnu.org
Subject: [bug-patch] [PATCH] Add another git-style diff concatenation
	regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2012 10:45:55 -0000

* tests/concat-git-diff: Add a test case for erroneous file truncation.
---
 tests/concat-git-diff |   38 ++++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)

diff --git a/tests/concat-git-diff b/tests/concat-git-diff
index 445fd97..158625a 100644
--- a/tests/concat-git-diff
+++ b/tests/concat-git-diff
@@ -45,3 +45,41 @@ EOF
 check 'cat f' <<EOF
 three
 EOF
+
+cat > f <<EOF
+1
+2
+3
+EOF
+
+cat > concat2.diff <<EOF
+diff --git a/f b/f
+--- a/f
++++ b/f
+@@ -1,3 +1,4 @@
+ 1
+ 2
+ 3
++b
+diff --git a/f b/f
+--- a/f
++++ b/f
+@@ -1,3 +1,4 @@
++a
+ 1
+ 2
+ 3
+EOF
+
+check 'patch -p1 < concat2.diff || echo "Status: $?"' <<EOF
+patching file f
+patching file f
+EOF
+
+check 'cat f' <<EOF
+a
+1
+2
+3
+b
+EOF


-- 
ldv


From MAILER-DAEMON Tue Aug 07 07:24:22 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Syhte-0004tx-S1
	for mharc-bug-patch@gnu.org; Tue, 07 Aug 2012 07:24:22 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51368)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Syhta-0004sy-Mx
	for bug-patch@gnu.org; Tue, 07 Aug 2012 07:24:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SyhtW-0008Ug-HE
	for bug-patch@gnu.org; Tue, 07 Aug 2012 07:24:18 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:39729)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SyhtW-0008UR-9a
	for bug-patch@gnu.org; Tue, 07 Aug 2012 07:24:14 -0400
Received: by lahd3 with SMTP id d3so1139877lah.0
	for <bug-patch@gnu.org>; Tue, 07 Aug 2012 04:24:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=9PZwi3VCQy7K8iGl9i8sqNfT7z9dWB4zZN02jPXnYak=;
	b=A0HhQFEn4EYTsX7gp0ctq8FPNLfa97qPUPtxluG6yxWTuWoEeFe+OAjDlcQALZs59a
	WTRTrdbUT735qpcCkr9tOIRbCq7IWzBp68ROUQ/lCWUuPZY86VUiafNp65HLviFe3znS
	QTcJLX161wJ0vCl5A5rWdc2GStLmwSACbLEaPF5suHfaxE3nJWS5/O00AnoXqWmaNK0K
	/M3zRxDiW093hzfek3KcwPoglUvxOC4KTEXqb0xyFVSS3P9t425rAVN9QYgtfNjVSk/v
	9xn+OdXIrkBs4GAuOnX8r9UNKYD+HBYIsx0Yn0d4PEIqlfAT44rethB/5kAtI6+V4hp6
	BWKQ==
MIME-Version: 1.0
Received: by 10.112.26.197 with SMTP id n5mr395148lbg.18.1344338653218; Tue,
	07 Aug 2012 04:24:13 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Tue, 7 Aug 2012 04:24:13 -0700 (PDT)
In-Reply-To: <20120807104551.GB13375@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
Date: Tue, 7 Aug 2012 13:24:13 +0200
Message-ID: <CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
 regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2012 11:24:20 -0000

Dmitry,

2012/8/7 Dmitry V. Levin <ldv@altlinux.org>:
> * tests/concat-git-diff: Add a test case for erroneous file truncation.

there are no index lines in this test case, which would tell patch
that this is not a single git diff but two concatenated git diffs. You
can only end up with such diffs by hand editing.

Is this test case based on an actual problem with a patch, or is it made up?

Thanks,
Andreas


From MAILER-DAEMON Tue Aug 07 09:23:18 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Syjkk-0001Jk-PW
	for mharc-bug-patch@gnu.org; Tue, 07 Aug 2012 09:23:18 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Syjke-0001JP-LA
	for bug-patch@gnu.org; Tue, 07 Aug 2012 09:23:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Syjkb-0000sz-6x
	for bug-patch@gnu.org; Tue, 07 Aug 2012 09:23:12 -0400
Received: from vint.altlinux.org ([194.107.17.35]:56157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Syjka-0000sj-Re
	for bug-patch@gnu.org; Tue, 07 Aug 2012 09:23:09 -0400
Received: from wo.int.altlinux.org (wo.int.altlinux.org [192.168.1.4])
	by vint.altlinux.org (Postfix) with ESMTP id E52F83F80019;
	Tue,  7 Aug 2012 13:23:07 +0000 (UTC)
Received: by wo.int.altlinux.org (Postfix, from userid 508)
	id CBDD7519000D; Tue,  7 Aug 2012 17:23:07 +0400 (MSK)
Date: Tue, 7 Aug 2012 17:23:07 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
Message-ID: <20120807132307.GA14247@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
	<CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO"
Content-Disposition: inline
In-Reply-To: <CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
X-fingerprint: FE4C 93AB E19A 2E4C CB5D  3E4E 7CAB E6AC 9E35 361E
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 194.107.17.35
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
	regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2012 13:23:17 -0000


--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 07, 2012 at 01:24:13PM +0200, Andreas Gr=FCnbacher wrote:
> Dmitry,
>=20
> 2012/8/7 Dmitry V. Levin <ldv@altlinux.org>:
> > * tests/concat-git-diff: Add a test case for erroneous file truncation.
>=20
> there are no index lines in this test case, which would tell patch
> that this is not a single git diff but two concatenated git diffs. You
> can only end up with such diffs by hand editing.

Of course re-adding index lines produces the same result.
Here is the 2nd edition where these index lines are not omitted:

diff --git a/tests/concat-git-diff b/tests/concat-git-diff
index 445fd97..52d3004 100644
--- a/tests/concat-git-diff
+++ b/tests/concat-git-diff
@@ -45,3 +45,43 @@ EOF
 check 'cat f' <<EOF
 three
 EOF
+
+cat > f <<EOF
+1
+2
+3
+EOF
+
+cat > concat2.diff <<EOF
+diff --git a/f b/f
+index 01e79c3..0d0b976 100644
+--- a/f
++++ b/f
+@@ -1,3 +1,4 @@
+ 1
+ 2
+ 3
++b
+diff --git a/f b/f
+index 0d0b976..6b2348d 100644
+--- a/f
++++ b/f
+@@ -1,3 +1,4 @@
++a
+ 1
+ 2
+ 3
+EOF
+
+check 'patch -p1 < concat2.diff || echo "Status: $?"' <<EOF
+patching file f
+patching file f
+EOF
+
+check 'cat f' <<EOF
+a
+1
+2
+3
+b
+EOF

> Is this test case based on an actual problem with a patch, or is it made =
up?

This test case is a heavily reduced real case scenario where the target file
was erroneously truncated:
http://git.altlinux.org/people/vitty/packages/?p=3Dkrb5.git;a=3Dblob;f=3Dkr=
b5-1.10.2-fedora-keytab-etype.patch


--=20
ldv

--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlAhFrsACgkQfKvmrJ41Nh6mWQCfWyz/XH7b3bk20EeQQWHKPdqv
lscAnjOMuCWTyi4LF0LBAtL/WcTkCYrV
=u3XE
-----END PGP SIGNATURE-----

--M9NhX3UHpAaciwkO--


From MAILER-DAEMON Wed Aug 08 07:52:39 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sz4oZ-0007u2-GI
	for mharc-bug-patch@gnu.org; Wed, 08 Aug 2012 07:52:39 -0400
Received: from eggs.gnu.org ([208.118.235.92]:42808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sz4oT-0007sq-Is
	for bug-patch@gnu.org; Wed, 08 Aug 2012 07:52:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sz4oS-0007cN-MY
	for bug-patch@gnu.org; Wed, 08 Aug 2012 07:52:33 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:48742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1Sz4oS-0007bz-En
	for bug-patch@gnu.org; Wed, 08 Aug 2012 07:52:32 -0400
Received: by lbon3 with SMTP id n3so440168lbo.0
	for <bug-patch@gnu.org>; Wed, 08 Aug 2012 04:52:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=zN07fqM6v+CePdKxU6hi0LulrLXKH7syE0fqtyzxMbk=;
	b=V043FcAVPrR75X9VZKoc7lW1oRGyTFlfpjGsL5jaApY+7ypZvNOg6ZxQMK8eFmrsU4
	plou/s1g7B32O6ds+ssBOnfpe3GZSj4fO4I9HW7xYTswnTdJWgmomuFcsaj2THZqFuhM
	ySFKCTeIcL4juDlyh3Y08hZ82wjMiLfZGL4G1ro6+1mFcKE53KnADY3IUlH8DKDNZQjc
	rsnzfcrPgh2Sy8LEiZ49/RBkMiP7HY9PssC1p0NeCQmFf7osVUf4nLvySKkiiJY9Rc3I
	ohMqXIPtfE6dwr3VKTbJL4l8KddB5QgU1zAkUAnjsnfYdjRyXqyrwEcl1VvyQxmOKW65
	ZlKQ==
MIME-Version: 1.0
Received: by 10.112.26.197 with SMTP id n5mr2080070lbg.18.1344426750607; Wed,
	08 Aug 2012 04:52:30 -0700 (PDT)
Received: by 10.112.149.38 with HTTP; Wed, 8 Aug 2012 04:52:30 -0700 (PDT)
In-Reply-To: <20120807132307.GA14247@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
	<CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
	<20120807132307.GA14247@altlinux.org>
Date: Wed, 8 Aug 2012 13:52:30 +0200
Message-ID: <CAHpGcMLeEmdB3QbRB=wx=zK+G+yk_3qyopKhhsfi+99paO48Yw@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.217.169
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
 regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Aug 2012 11:52:37 -0000

2012/8/7 Dmitry V. Levin <ldv@altlinux.org>:
> Of course re-adding index lines produces the same result.

Hmm, I see now that relying on the index lines isn't going to work in
all cases. Instead, I've made the code check which files are bein
written to to detect concatenated git diffs. Can you please retry with
the current snapshot?

Thanks,
Andreas


From MAILER-DAEMON Wed Aug 08 10:31:16 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Sz7I4-0002Ao-Kk
	for mharc-bug-patch@gnu.org; Wed, 08 Aug 2012 10:31:16 -0400
Received: from eggs.gnu.org ([208.118.235.92]:53713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Sz7I1-00029y-Vt
	for bug-patch@gnu.org; Wed, 08 Aug 2012 10:31:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Sz7Hw-0004O7-8a
	for bug-patch@gnu.org; Wed, 08 Aug 2012 10:31:13 -0400
Received: from vint.altlinux.org ([194.107.17.35]:47646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1Sz7Hw-0004L1-18
	for bug-patch@gnu.org; Wed, 08 Aug 2012 10:31:08 -0400
Received: from wo.int.altlinux.org (wo.int.altlinux.org [192.168.1.4])
	by vint.altlinux.org (Postfix) with ESMTP id 17ADE3F80019;
	Wed,  8 Aug 2012 14:31:05 +0000 (UTC)
Received: by wo.int.altlinux.org (Postfix, from userid 508)
	id EC2443F487AA; Wed,  8 Aug 2012 18:31:04 +0400 (MSK)
Date: Wed, 8 Aug 2012 18:31:04 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
Message-ID: <20120808143103.GC29967@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
	<CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
	<20120807132307.GA14247@altlinux.org>
	<CAHpGcMLeEmdB3QbRB=wx=zK+G+yk_3qyopKhhsfi+99paO48Yw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD"
Content-Disposition: inline
In-Reply-To: <CAHpGcMLeEmdB3QbRB=wx=zK+G+yk_3qyopKhhsfi+99paO48Yw@mail.gmail.com>
X-fingerprint: FE4C 93AB E19A 2E4C CB5D  3E4E 7CAB E6AC 9E35 361E
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 194.107.17.35
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
	regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Aug 2012 14:31:15 -0000


--69pVuxX8awAiJ7fD
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 08, 2012 at 01:52:30PM +0200, Andreas Gr=FCnbacher wrote:
> 2012/8/7 Dmitry V. Levin <ldv@altlinux.org>:
> > Of course re-adding index lines produces the same result.
>=20
> Hmm, I see now that relying on the index lines isn't going to work in
> all cases. Instead, I've made the code check which files are bein
> written to to detect concatenated git diffs. Can you please retry with
> the current snapshot?

Thanks, it definitely works in the case where previous snapshot failed.
There is also a daily long package rebuild test, its results are expected
tomorrow.


--=20
ldv

--69pVuxX8awAiJ7fD
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlAieCcACgkQfKvmrJ41Nh6kIACfatUQONg8S9AWcKdrzx8Tvsvq
ZFUAn2h/L81IJQzZf0zlNmsFPFtF0l59
=TYWR
-----END PGP SIGNATURE-----

--69pVuxX8awAiJ7fD--


From MAILER-DAEMON Thu Aug 09 08:44:23 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SzS6B-0006dR-FZ
	for mharc-bug-patch@gnu.org; Thu, 09 Aug 2012 08:44:23 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SzS68-0006cK-VY
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:44:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SzS67-0001GW-Pd
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:44:20 -0400
Received: from vint.altlinux.org ([194.107.17.35]:48901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ldv@altlinux.org>) id 1SzS67-0001GN-IC
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:44:19 -0400
Received: from wo.int.altlinux.org (wo.int.altlinux.org [192.168.1.4])
	by vint.altlinux.org (Postfix) with ESMTP id 56265226C0A6;
	Thu,  9 Aug 2012 12:44:18 +0000 (UTC)
Received: by wo.int.altlinux.org (Postfix, from userid 508)
	id 0A0A0519000D; Thu,  9 Aug 2012 16:44:18 +0400 (MSK)
Date: Thu, 9 Aug 2012 16:44:17 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Andreas =?iso-8859-1?Q?Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
Message-ID: <20120809124417.GA7976@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
	<CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
	<20120807132307.GA14247@altlinux.org>
	<CAHpGcMLeEmdB3QbRB=wx=zK+G+yk_3qyopKhhsfi+99paO48Yw@mail.gmail.com>
	<20120808143103.GC29967@altlinux.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA"
Content-Disposition: inline
In-Reply-To: <20120808143103.GC29967@altlinux.org>
X-fingerprint: FE4C 93AB E19A 2E4C CB5D  3E4E 7CAB E6AC 9E35 361E
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 194.107.17.35
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
	regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2012 12:44:21 -0000


--W/nzBZO5zC0uMSeA
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 08, 2012 at 06:31:03PM +0400, Dmitry V. Levin wrote:
> On Wed, Aug 08, 2012 at 01:52:30PM +0200, Andreas Gr=FCnbacher wrote:
> > 2012/8/7 Dmitry V. Levin <ldv@altlinux.org>:
> > > Of course re-adding index lines produces the same result.
> >=20
> > Hmm, I see now that relying on the index lines isn't going to work in
> > all cases. Instead, I've made the code check which files are bein
> > written to to detect concatenated git diffs. Can you please retry with
> > the current snapshot?
>=20
> Thanks, it definitely works in the case where previous snapshot failed.
> There is also a daily long package rebuild test, its results are expected
> tomorrow.

The long test has shown no visible regressions.


--=20
ldv

--W/nzBZO5zC0uMSeA
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlAjsKEACgkQfKvmrJ41Nh6qmACfct9m+Mx21PyByiKg4TmaUQNu
VzkAn24+YZOxrgT3I28nUqp5SHsI25jr
=Ztiu
-----END PGP SIGNATURE-----

--W/nzBZO5zC0uMSeA--


From MAILER-DAEMON Thu Aug 09 08:50:47 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SzSCN-0008GW-Ag
	for mharc-bug-patch@gnu.org; Thu, 09 Aug 2012 08:50:47 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SzSCH-0008ER-D1
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:50:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SzSCC-0003e6-Sy
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:50:41 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:38713)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.gruenbacher@gmail.com>) id 1SzSCC-0003d6-Kg
	for bug-patch@gnu.org; Thu, 09 Aug 2012 08:50:36 -0400
Received: by lbon3 with SMTP id n3so277845lbo.0
	for <bug-patch@gnu.org>; Thu, 09 Aug 2012 05:50:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=B21F5e9ZvP/T5EAFGDsUgYwD7uG15HEcnUbYupdYtRo=;
	b=k2+dDa364yRGtN38961ZzqqM5VGV++/piYQ8fl9e1IhhWbLtOekrYl2iYIGMD/ofjp
	CXCBw5FRvzgUpKiM7qjVofjScTX6I1P8QzvcAVFa1hF7V6A6gLJZsG2Tmu9dGVObHVBA
	ziLkR+8mOzQmsiKY/twocSLFsCS3CaFu4UotbLaaHaxXavpBXIFLFymsS31l/XMZ/4CM
	8Kxd4uv1xrRnpysxA477fqKF3S5IwedHBkCEF+q4dxrRtFokOBugYlCrwr7O6dhF9nYN
	lcHPke6+6g6AwTAAHruyN90wQjqvfQ2sG8qFkmJpZyQAiKSXLZ98NYly49nd5zomnZGp
	3JTg==
MIME-Version: 1.0
Received: by 10.152.105.132 with SMTP id gm4mr13125657lab.8.1344516634886;
	Thu, 09 Aug 2012 05:50:34 -0700 (PDT)
Received: by 10.112.85.9 with HTTP; Thu, 9 Aug 2012 05:50:34 -0700 (PDT)
In-Reply-To: <20120809124417.GA7976@altlinux.org>
References: <20120807104551.GB13375@altlinux.org>
	<CAHpGcM+psMUfn+sZKdVLa_R6qWDFzYb6+FYf9yatPW5fFSW2Yw@mail.gmail.com>
	<20120807132307.GA14247@altlinux.org>
	<CAHpGcMLeEmdB3QbRB=wx=zK+G+yk_3qyopKhhsfi+99paO48Yw@mail.gmail.com>
	<20120808143103.GC29967@altlinux.org>
	<20120809124417.GA7976@altlinux.org>
Date: Thu, 9 Aug 2012 14:50:34 +0200
Message-ID: <CAHpGcMJiSXQnDZ4L0b142Ax8pGM=WDHKv0UfhqmBRDQvYXeeEQ@mail.gmail.com>
From: =?ISO-8859-1?Q?Andreas_Gr=FCnbacher?= <andreas.gruenbacher@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.217.169
Cc: bug-patch@gnu.org
Subject: Re: [bug-patch] [PATCH] Add another git-style diff concatenation
 regression test
X-BeenThere: bug-patch@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Bug reports, suggestions,
	general discussion for GNU patch." <bug-patch.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-patch>
List-Post: <mailto:bug-patch@gnu.org>
List-Help: <mailto:bug-patch-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-patch>,
	<mailto:bug-patch-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2012 12:50:45 -0000

Dmitry,

2012/8/9 Dmitry V. Levin <ldv@altlinux.org>
> The long test has shown no visible regressions.

thanks!

Andreas


