From MAILER-DAEMON Sun Nov 02 10:48:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGKS6-0001jo-K0
	for mharc-classpath@gnu.org; Sun, 02 Nov 2003 10:47:42 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGKR9-0000xx-Id
	for classpath@gnu.org; Sun, 02 Nov 2003 10:46:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGKPc-00008h-Vx
	for classpath@gnu.org; Sun, 02 Nov 2003 10:45:41 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGKJM-0007Fm-LH
	for classpath@gnu.org; Sun, 02 Nov 2003 10:38:46 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AGJK8-0007u7-00
	for <classpath@gnu.org>; Sun, 02 Nov 2003 15:35:24 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <3FA2A610.8010002@kaffe.org>
References: <3FA2A610.8010002@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-rchvg1s7gLAAprgiI30G"
Message-Id: <1067783743.794.44.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 02 Nov 2003 15:35:44 +0100
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Nov 2003 15:47:41 -0000


--=-rchvg1s7gLAAprgiI30G
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-10-31 at 19:12, Guilhem Lavaux wrote:
> Continuing the Classpath-Kaffe merge, I noticed that=20
> DataInputStream is failing one of kaffe's regression test=20
> (InputStreamTest). It seems the failure comes from=20
> readLine(): readLine() is a little too conservative compared=20
> to JDK's implementation. The real behaviour seems to be the=20
> following:
>=20
> readLine() is invoked =3D> it reads bytes until it finds a=20
> '\r' =3D> it reads the next byte
> * if it is  a '\n' it eats it
> * if it isn't it keeps it in an internal buffer until=20
> someone calls another read methods.
>
> But in any case the byte isn't put back in the input buffer.=20

The Classpath implementation clearly took the lowest overhead for the
non-readLine case. For the benefit of the other mailinglist readers,
here is the actual comment from Classpaths (same for libgcj)
DataInputStream.readLine():

    // FIXME: The following code tries to adjust the stream back one
    // character if the next char read is '\n'.  As a last resort,
    // it tries to mark the position before reading but the bottom
    // line is that it is possible that this method will not properly
    // deal with a '\r' '\n' combination thus not fulfilling the
    // DataInput contract for readLine.  It's not a particularly
    // safe approach threadwise since it is unsynchronized and
    // since it might mark an input stream behind the users back.
    // Along the same vein it could try the same thing for
    // ByteArrayInputStream and PushbackInputStream, but that is
    // probably overkill since this is deprecated & BufferedInputStream
    // is the most likely type of input stream.
    //
    // The alternative is to somehow push back the next byte if it
    // isn't a '\n' or to have the reading methods of this class
    // keep track of whether the last byte read was '\r' by readLine
    // and then skip the very next byte if it is '\n'.  Either way,
    // this would increase the complexity of the non-deprecated methods
    // and since it is undesirable to make non-deprecated methods
    // less efficient, the following seems like the most reasonable
    // approach.

BTW I don't think we have to worry about the unsynchronized thing since
streams are already not thread safe.

>   The real problem is what happens when someone calls one of=20
> the inherited method from FilterInputStream which are not=20
> overloaded (e.g. available).
>
> Kaffe's answer was to create a mini-buffer with default=20
> access in FilterInputStream. It is obvious it is clumsy=20
> because it slightly changes the API, but the only other=20
> option would be to overload all read functions.

That is overhead for every FilterInputStream, that should be avoided.
But I agree that the Classpath way is not very clean.

Would a solution be to do the following in the constructor?

  public DataInputStream (InputStream in)
  {
    super (in.markSupported() ? in : new BufferedInputStream(in, 1));
  }

And then use the fact that in will always be a BufferedInputStream in
the readLine method? This does create a small overhead for
DataInputStream in case it isn't already wrapped around something that
buffers already, but it would be easy to make it always work correctly.

Another question is how often (ever?) does this (mixing readLine() with
other DataInputStream and/or FilterInputStream calls happen in real
programs. The regression test of kaffe looks contrived, it even uses
StringInputStream which is an ugly (and thankfully deprecated) class.

Cheers,

Mark

--=-rchvg1s7gLAAprgiI30G
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/pRY/xVhZCJWr9QwRAmNrAKCBLMoybJvw7V7AZQa2NxPfgJ411gCdF+jQ
ZXzebKooT3PBEJD6sscDNrM=
=r8QN
-----END PGP SIGNATURE-----

--=-rchvg1s7gLAAprgiI30G--




From MAILER-DAEMON Sun Nov 02 11:39:58 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGLFk-0000AQ-K9
	for mharc-classpath@gnu.org; Sun, 02 Nov 2003 11:39:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGLFf-0008Vt-O0
	for classpath@gnu.org; Sun, 02 Nov 2003 11:38:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGLF7-00086v-RA
	for classpath@gnu.org; Sun, 02 Nov 2003 11:38:52 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AGLEv-0007j6-Jw
	for classpath@gnu.org; Sun, 02 Nov 2003 11:38:09 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AGLAz-0001bN-W3
	for classpath@gnu.org; Sun, 02 Nov 2003 11:34:06 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AGLAT-0006bo-00
	for <classpath@gnu.org>; Sun, 02 Nov 2003 17:33:33 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AGLAQ-0006bR-00; Sun, 02 Nov 2003 17:33:30 +0100
Message-ID: <3FA531DA.6010501@kaffe.org>
Date: Sun, 02 Nov 2003 17:33:30 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FA2A610.8010002@kaffe.org>
	<1067783743.794.44.camel@elsschot.wildebeest.org>
In-Reply-To: <1067783743.794.44.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Nov 2003 16:38:58 -0000

Mark Wielaard wrote:
> Hi,
> 
> On Fri, 2003-10-31 at 19:12, Guilhem Lavaux wrote:
> 
>>Continuing the Classpath-Kaffe merge, I noticed that 
>>DataInputStream is failing one of kaffe's regression test 
>>(InputStreamTest). It seems the failure comes from 
>>readLine(): readLine() is a little too conservative compared 
>>to JDK's implementation. The real behaviour seems to be the 
>>following:
>>
>>readLine() is invoked => it reads bytes until it finds a 
>>'\r' => it reads the next byte
>>* if it is  a '\n' it eats it
>>* if it isn't it keeps it in an internal buffer until 
>>someone calls another read methods.
>>
>>But in any case the byte isn't put back in the input buffer. 
 >
> 
> The Classpath implementation clearly took the lowest overhead for the
> non-readLine case. For the benefit of the other mailinglist readers,
> here is the actual comment from Classpaths (same for libgcj)
> DataInputStream.readLine():
> 
>     // FIXME: The following code tries to adjust the stream back one
>     // character if the next char read is '\n'.  As a last resort,
>     // it tries to mark the position before reading but the bottom
>     // line is that it is possible that this method will not properly
>     // deal with a '\r' '\n' combination thus not fulfilling the
>     // DataInput contract for readLine.  It's not a particularly
>     // safe approach threadwise since it is unsynchronized and
>     // since it might mark an input stream behind the users back.
>     // Along the same vein it could try the same thing for
>     // ByteArrayInputStream and PushbackInputStream, but that is
>     // probably overkill since this is deprecated & BufferedInputStream
>     // is the most likely type of input stream.
>     //
>     // The alternative is to somehow push back the next byte if it
>     // isn't a '\n' or to have the reading methods of this class
>     // keep track of whether the last byte read was '\r' by readLine
>     // and then skip the very next byte if it is '\n'.  Either way,
>     // this would increase the complexity of the non-deprecated methods
>     // and since it is undesirable to make non-deprecated methods
>     // less efficient, the following seems like the most reasonable
>     // approach.

That's a bug in Classpath then. Trying to 'read ahead' after \r fails on 
for those systems whose 'end of line' is a plain \r. See this note from 
Apple: http://developer.apple.com/technotes/tn/tn1157.html . Short 
story: you're reading lines over network from a machine on mac os x: you 
  read \r, try to read ahead but the next character never comes since 
the darwin machine already sent you its end of line, so you hang 
forever, i.e. util the connection is terminated.

In fact, while you're at it, check out the rationale behind kaffe's 
implementation as described in this thread:
http://www.kaffe.org/pipermail/kaffe/2002-October/040501.html
, where i go into some detail how to deal with the \r vs \r\n issue. ;) 
The FilterInputStream kludge was the only way to prevent fixing one bug 
on the cost of introducing the other I could come up with, and I think 
it's the only possible way to do it.

> BTW I don't think we have to worry about the unsynchronized thing since
> streams are already not thread safe.

They should be. My experience from working on kaffe's readers and 
writers and testing against JDK was that the JDK implementation was very 
thread safe, whereas kaffe's IO had thread safety kludged in afterwards 
by me for some classes. From what I remember, Classpath code wasn't 
thread safe at all, either.

For what it's worth, yes, there is code out there that expects threads 
to be able to read from readers/writers and not trip over their feet ;) 
AFAIK, the Java APIs explicitely mention when a method/class is not 
thread safe, so by default we should assume that APIs are to be thread 
safe. I mean, it's built in the laguage, why would you want to limit 
yourself to single threads when you're doing something as important as IO?

>>  The real problem is what happens when someone calls one of 
>>the inherited method from FilterInputStream which are not 
>>overloaded (e.g. available).
>>
>>Kaffe's answer was to create a mini-buffer with default 
>>access in FilterInputStream. It is obvious it is clumsy 
>>because it slightly changes the API, but the only other 
>>option would be to overload all read functions.
> 
> 
> That is overhead for every FilterInputStream, that should be avoided.
> But I agree that the Classpath way is not very clean.
> 
> Would a solution be to do the following in the constructor?
> 
>   public DataInputStream (InputStream in)
>   {
>     super (in.markSupported() ? in : new BufferedInputStream(in, 1));
>   }

No. Even if the superstream supports marking, then a mark/rewind based 
solution would delete a previous mark set by user of DataInputStream 
class each time a \r occurs. That would be a quite ugly bug to find.

> And then use the fact that in will always be a BufferedInputStream in
> the readLine method? This does create a small overhead for
> DataInputStream in case it isn't already wrapped around something that
> buffers already, but it would be easy to make it always work correctly.

It doesn't necessarily mean it will always be a buffered input stream. 
There are input streams that support marking that are not 
BufferedInputStreams.

> Another question is how often (ever?) does this (mixing readLine() with
> other DataInputStream and/or FilterInputStream calls happen in real
> programs. The regression test of kaffe looks contrived, it even uses
> StringInputStream which is an ugly (and thankfully deprecated) class.

Happened in real life with very popular libraries like xerces. See the 
kaffe mailing list thread. User was not pleased at all, and wanted to 
revert back to broken 'read ahead, and unread' method. I had to figure 
out a way to fix both issues, that's the whole story. If someone can 
find a more elegant way to do it, that doesn't create any new bugs, I'm 
all ears. I've been there before and spent some time researching this, 
though. You may have more luck. ;)

cheers,
dalibor topic




From MAILER-DAEMON Sun Nov 02 12:59:23 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGMUt-000133-5T
	for mharc-classpath@gnu.org; Sun, 02 Nov 2003 12:58:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGMUl-00010U-JT
	for classpath@gnu.org; Sun, 02 Nov 2003 12:58:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGMUD-0000n0-Hs
	for classpath@gnu.org; Sun, 02 Nov 2003 12:58:32 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGMSA-00006m-Ti
	for classpath@gnu.org; Sun, 02 Nov 2003 12:55:55 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AGMRg-000114-00
	for <classpath@gnu.org>; Sun, 02 Nov 2003 18:55:24 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <3FA531DA.6010501@kaffe.org>
References: <3FA2A610.8010002@kaffe.org>
	<1067783743.794.44.camel@elsschot.wildebeest.org>
	<3FA531DA.6010501@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-GcR4bGhxn9/RBZ+Lf0Dx"
Message-Id: <1067795743.11103.44.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 02 Nov 2003 18:55:44 +0100
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Nov 2003 17:58:38 -0000


--=-GcR4bGhxn9/RBZ+Lf0Dx
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2003-11-02 at 17:33, Dalibor Topic wrote:
>
> That's a bug in Classpath then. Trying to 'read ahead' after \r fails on=20
> for those systems whose 'end of line' is a plain \r.=20
> [...]
> In fact, while you're at it, check out the rationale behind kaffe's=20
> implementation as described in this thread:
> http://www.kaffe.org/pipermail/kaffe/2002-October/040501.html

Thanks for that pointer. You already put a lot of thought into this.

> > BTW I don't think we have to worry about the unsynchronized thing since
> > streams are already not thread safe.
>=20
> They should be. My experience from working on kaffe's readers and=20
> writers and testing against JDK was that the JDK implementation was very=20
> thread safe, whereas kaffe's IO had thread safety kludged in afterwards=20
> by me for some classes. From what I remember, Classpath code wasn't=20
> thread safe at all, either.

They have to be? O, bummer. That would be so brain-dead and makes
creating an efficient implementation impossible since you will then have
to do lots of synchronization :{

> For what it's worth, yes, there is code out there that expects threads=20
> to be able to read from readers/writers and not trip over their feet ;)

But what is the expected behavior? What does "not trip over their feet"
mean in this context? Does it mean that if they synchronize on the
stream and read/write one after another that they will get "real" return
values? Or does it mean that if some threads read/write at random
to/from without any synchronization that they still expect some coherent
return values? And you talk about readers/writers, does that mean that
this behavior is only guaranteed for character streams or for all
possible streams?

> AFAIK, the Java APIs explicitely mention when a method/class is not=20
> thread safe, so by default we should assume that APIs are to be thread=20
> safe.

I couldn't find this in my Java Class Library book (and don't have any
meaningful internet connection to check other sources). At least the
descriptions of InputStream, FilterInputStream and DataInputStream don't
seem to make any claims about thread safety.

> I mean, it's built in the laguage, why would you want to limit=20
> yourself to single threads when you're doing something as important as IO=
?

I agree that you should use multiple threads whenever that is beneficial
to your programming design? But I don't think that it is unreasonable to
ask the programmer to specify the synchronization behavior of the
program since that are often high-level aspects if the design and
low-level fine-grained locking will often not be beneficial to the users
(IMHO).

> > That is overhead for every FilterInputStream, that should be avoided.
> > But I agree that the Classpath way is not very clean.
> >=20
> > Would a solution be to do the following in the constructor?
> >=20
> >   public DataInputStream (InputStream in)
> >   {
> >     super (in.markSupported() ? in : new BufferedInputStream(in, 1));
> >   }
>=20
> No. Even if the superstream supports marking, then a mark/rewind based=20
> solution would delete a previous mark set by user of DataInputStream=20
> class each time a \r occurs. That would be a quite ugly bug to find.

Cannot be that hard to find such a bug, you found it before it was even
implemented :)

> > Another question is how often (ever?) does this (mixing readLine() with
> > other DataInputStream and/or FilterInputStream calls happen in real
> > programs. The regression test of kaffe looks contrived, it even uses
> > StringInputStream which is an ugly (and thankfully deprecated) class.
>=20
> Happened in real life with very popular libraries like xerces. See the=20
> kaffe mailing list thread. User was not pleased at all, and wanted to=20
> revert back to broken 'read ahead, and unread' method. I had to figure=20
> out a way to fix both issues, that's the whole story. If someone can=20
> find a more elegant way to do it, that doesn't create any new bugs, I'm=20
> all ears. I've been there before and spent some time researching this,=20
> though. You may have more luck. ;)

OK. Let me try to summarize the behavior we want so we can at least
create some good tests:

DataInputStream.readLine():
- Should not block when it has seen at least a \r but return as soon as
  possible even when it cannot be sure that the next character is or
  isn't a \n to prevent programs from blocking/deadlocking.
- If there is a unconsumed \n in the stream right after a readLine()
  then that \n should be transparently consumed for all these cases:
  - readLine() is called again.
  - another DataInputStream read method is called.
  - a non-overridden (Filter)InputStream is called.
  - a method in the originally wrapped InputStream is called.

That will be an ugly nut to crack. Especially how to guarantee that last
requirement is nasty. And the method is (rightly) deprectated since
programmers should BufferedReader.readLine() anyway (specified since
1.1). Sigh.

But having a good test case will be very valuable start.
Any volunteers :)

Cheers,

Mark

--=-GcR4bGhxn9/RBZ+Lf0Dx
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/pUUfxVhZCJWr9QwRAl9BAKCwEqCfUr0foV9q0f4yTBvpB3bP8wCeL7ej
aqgLudaGq+itwO+2RGo8U7g=
=YtOJ
-----END PGP SIGNATURE-----

--=-GcR4bGhxn9/RBZ+Lf0Dx--




From MAILER-DAEMON Sun Nov 02 16:29:05 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGPkc-0001fG-4V
	for mharc-classpath@gnu.org; Sun, 02 Nov 2003 16:27:10 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGPj2-0000np-D8
	for classpath@gnu.org; Sun, 02 Nov 2003 16:25:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGPiI-0000DE-BG
	for classpath@gnu.org; Sun, 02 Nov 2003 16:25:17 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGPiB-0008Tw-4p
	for classpath@gnu.org; Sun, 02 Nov 2003 16:24:39 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix4-1.free.fr (Postfix) with ESMTP
	id 85BD879A8A; Sun,  2 Nov 2003 21:12:03 +0100 (CET)
Message-ID: <3FA56509.4080005@kaffe.org>
Date: Sun, 02 Nov 2003 21:11:53 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030428
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FA2A610.8010002@kaffe.org>	<1067783743.794.44.camel@elsschot.wildebeest.org>	<3FA531DA.6010501@kaffe.org>
	<1067795743.11103.44.camel@elsschot.wildebeest.org>
In-Reply-To: <1067795743.11103.44.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.73.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Nov 2003 21:27:07 -0000

Mark Wielaard wrote:

>OK. Let me try to summarize the behavior we want so we can at least
>create some good tests:
>
>DataInputStream.readLine():
>- Should not block when it has seen at least a \r but return as soon as
>  possible even when it cannot be sure that the next character is or
>  isn't a \n to prevent programs from blocking/deadlocking.
>- If there is a unconsumed \n in the stream right after a readLine()
>  then that \n should be transparently consumed for all these cases:
>  - readLine() is called again.
>  - another DataInputStream read method is called.
>  - a non-overridden (Filter)InputStream is called.
>  - a method in the originally wrapped InputStream is called.
>
>That will be an ugly nut to crack. Especially how to guarantee that last
>requirement is nasty. And the method is (rightly) deprectated since
>programmers should BufferedReader.readLine() anyway (specified since
>1.1). Sigh.
>
>But having a good test case will be very valuable start.
>Any volunteers :)
>  
>
Well ! You described entirely the behaviour of the test. So it should be 
considered as done. ;-) But JDK won't pass this test (I've just tested 
one or two pieces of the ideas). Actually if DataInputStream can detect 
the '\n' it eats it directly in the call to readLine().
I'll be quite busy for the next few days. But if nobody takes the job, 
I'll do it asap.

Cheers,
Guilhem.




From MAILER-DAEMON Tue Nov 04 02:30:13 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGvdl-0003lj-D1
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 02:30:13 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGpOm-00088j-Fa
	for classpath@gnu.org; Mon, 03 Nov 2003 19:50:20 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGpNj-0006AQ-MJ
	for classpath@gnu.org; Mon, 03 Nov 2003 19:49:46 -0500
Received: from [146.103.254.12] (helo=dmz2.imec.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGpNf-000608-MK
	for classpath@gnu.org; Mon, 03 Nov 2003 19:49:11 -0500
Received: from e2k01.imec.be (e2k01.imec.be [146.103.0.4])
	by dmz2.imec.be (8.9.3/8.9.3) with ESMTP id BAA02350
	for <classpath@gnu.org>; Tue, 4 Nov 2003 01:49:09 +0100
Received: from imec.be ([146.103.22.167]) by e2k01.imec.be with Microsoft
	SMTPSVC(5.0.2195.2966); Tue, 4 Nov 2003 01:49:09 +0100
Message-ID: <3FA6F6C2.8070905@imec.be>
Date: Tue, 04 Nov 2003 01:45:54 +0100
From: Richard Stahl <richard.stahl@imec.be>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031008
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 04 Nov 2003 00:49:09.0190 (UTC)
	FILETIME=[74D72E60:01C3A26D]
X-Mailman-Approved-At: Tue, 04 Nov 2003 02:30:11 -0500
Subject: gnu.java.awt.image.GdkPixbufDecoder
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 00:50:27 -0000

hello,

i have just started using the classpath so maybe a stupid problem:

i would like to run some code on JikesRVM (which uses classpath). the 
code requires gnu.java.awt.peer.gtk.GtkToolkit. if invoking method 
getImage() of this class i get an error:


java.lang.UnsatisfiedLinkError: Cannot find library cpgdkpixbuf
         at 
com.ibm.JikesRVM.classloader.VM_ClassLoader.loadLibrary(VM_ClassLoader.java:113)
         at java.lang.Runtime.loadLibrary(Runtime.java:191)
         at java.lang.System.loadLibrary(System.java:665)
         at 
gnu.java.awt.image.GdkPixbufDecoder.<clinit>(GdkPixbufDecoder.java:59)
         at 
com.ibm.JikesRVM.classloader.VM_Class.initialize(VM_Class.java:1374)
         at 
com.ibm.JikesRVM.VM_Runtime.initializeClassForDynamicLink(VM_Runtime.java:514)
         at 
com.ibm.JikesRVM.VM_Runtime.unresolvedNewScalar(VM_Runtime.java:276)
         at gnu.java.awt.peer.gtk.GtkToolkit.getImage(GtkToolkit.java:140)


so, there is no library "cpgdkpixbuf" required by classloader loading 
gnu.java.awt.image.GdkPixbufDecoder while the code really includes 
static code for loading native library "cpgdkpixbuf".

can you, please, let me know how to solve this problem?

thank you very much in advance.

best regards,

richard




From MAILER-DAEMON Tue Nov 04 04:23:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGxPQ-0005Gx-9z
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 04:23:32 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGxPN-0005Ft-DT
	for classpath@gnu.org; Tue, 04 Nov 2003 04:23:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGxOr-00050D-Nf
	for classpath@gnu.org; Tue, 04 Nov 2003 04:23:28 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGxOc-0004vE-MB
	for classpath@gnu.org; Tue, 04 Nov 2003 04:22:42 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-80-210.ewetel.net
	[80.228.80.210])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id hA49MZ6J018901;
	Tue, 4 Nov 2003 10:22:38 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AGxOd-0006xk-00; Tue, 04 Nov 2003 10:22:43 +0100
Date: Tue, 4 Nov 2003 10:22:43 +0100
From: Michael Koch <konqueror@gmx.de>
To: Richard Stahl <richard.stahl@imec.be>
Message-ID: <20031104092243.GA24681@mail.konqueror.de>
References: <3FA6F6C2.8070905@imec.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FA6F6C2.8070905@imec.be>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: gnu.java.awt.image.GdkPixbufDecoder
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 09:23:30 -0000

On Tue, Nov 04, 2003 at 01:45:54AM +0100, Richard Stahl wrote:
> hello,
> 
> i have just started using the classpath so maybe a stupid problem:
> 
> i would like to run some code on JikesRVM (which uses classpath). the 
> code requires gnu.java.awt.peer.gtk.GtkToolkit. if invoking method 
> getImage() of this class i get an error:
> 
> 
> java.lang.UnsatisfiedLinkError: Cannot find library cpgdkpixbuf
>         at 
> com.ibm.JikesRVM.classloader.VM_ClassLoader.loadLibrary(VM_ClassLoader.java:113)
>         at java.lang.Runtime.loadLibrary(Runtime.java:191)
>         at java.lang.System.loadLibrary(System.java:665)
>         at 
> gnu.java.awt.image.GdkPixbufDecoder.<clinit>(GdkPixbufDecoder.java:59)
>         at 
> com.ibm.JikesRVM.classloader.VM_Class.initialize(VM_Class.java:1374)
>         at 
> com.ibm.JikesRVM.VM_Runtime.initializeClassForDynamicLink(VM_Runtime.java:514)
>         at 
> com.ibm.JikesRVM.VM_Runtime.unresolvedNewScalar(VM_Runtime.java:276)
>         at gnu.java.awt.peer.gtk.GtkToolkit.getImage(GtkToolkit.java:140)
> 
> 
> so, there is no library "cpgdkpixbuf" required by classloader loading 
> gnu.java.awt.image.GdkPixbufDecoder while the code really includes 
> static code for loading native library "cpgdkpixbuf".
> 
> can you, please, let me know how to solve this problem?

The problem is simply to tell: the native library is not build during
building classpath. Thats a bug in classpath. I made it compile and
install this helper library. Can you send me a little testcase for
testing before I commit this thingie ? I want to test if
GdkPixbufDecoder really works. The version in libgcj has a comment about
problems but doesnt tell which problems.


Michael



From MAILER-DAEMON Tue Nov 04 05:57:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AGysH-00057s-AG
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 05:57:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AGysE-000567-Rl
	for classpath@gnu.org; Tue, 04 Nov 2003 05:57:22 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AGyri-0004rp-UQ
	for classpath@gnu.org; Tue, 04 Nov 2003 05:57:21 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AGyri-0004rY-IK
	for classpath@gnu.org; Tue, 04 Nov 2003 05:56:50 -0500
Received: from [192.168.1.33] (215.248.static-adsl.customer.ch.easynet.net
	[217.8.215.248]) by smtp1.mail.ch.easynet.net (Postfix) with ESMTP
	id BA7B64A0DF; Tue,  4 Nov 2003 11:56:46 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Tue, 4 Nov 2003 11:55:48 +0100
Message-Id: <20031104105548.25206@smtp.mail.ch.easynet.net>
In-Reply-To: <20031030075517.75989.qmail@web25005.mail.ukl.yahoo.com>
References: <20031030075517.75989.qmail@web25005.mail.ukl.yahoo.com>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: jsona laio <freeonfair@yahoo.co.uk>
Subject: Re: characters set's problem
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 10:57:23 -0000

jsona laio <freeonfair@yahoo.co.uk> wrote on Thu, 30 Oct 2003 07:55:17 +0000:

>however, lately i want to participate a porject, in
>which involves developing encoding like CCCII (CJK
>based characters set for asian characters, which
>defines more characters than unicode supports in the
>parts of CJK). however, as i know, java vm is based
>upon unicode.

What exactly do you mean when you say "Unicode"? It seems that you think
that Java uses only U+0000 .. U+FFFF (the "basic multilingual plane",
also known as UCS-2). As far as I know, this was true in the past, but
this restriction has changed in the meantime. Nowadays, Java uses the
full Unicode character set.

The following is quoted from [1]:

>The native coded character set of the Java programming language is that
>of the first seventeen planes of the Unicode version 3.0 character set;
>that is, it consists in the basic multilingual plane (BMP) of Unicode
>version 1 plus the next sixteen planes of Unicode version 3. This is
>because the language's internal representation of characters uses the
>UTF-16 encoding, which encodes the BMP directly and uses surrogate pairs,
>a simple escape mechanism, to encode the other planes. Hence a charset in
>the Java platform defines a mapping between sequences of sixteen-bit
>values in UTF-16 and sequences of bytes.

Basically, you are free to use any Unicode code point that can be mapped
to and from UTF-16. You also might want to have a look at Unicode 4.0,
which has added many additional code points for CJK ideographs. (By the
way, CCCII is listed among the "Source Standards and Specifications" of
Unicode 4.0, chapter R.1, page 1385; also available online from the
Unicode site). But if you really need ideographs that are not covered in
Unicode, there are the "private usage areas". These are large ranges of
Unicode code points that are reserved for private purposes.

If you want to write a converter between some character encoding and
Unicode (possibly using code points from a private usage area, if Unicode
does not provide a code point for a specific ideograph), please have a
look that the java.nio.charset package. I think that GNU Classpath would
be glad to accept converters.

The distinction between character sets and character encodings can cause
a lot of confusion. A helpful introduction is [2].

[1] http://java.sun.com/j2se/1.4.2/docs/api/java/nio/charset/Charset.html
[2] http://www.unicode.org/standard/principles.html


Best regards,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Tue Nov 04 11:33:15 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AH47D-0001Xf-J3
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 11:33:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AH478-0001VY-Sl
	for classpath@gnu.org; Tue, 04 Nov 2003 11:33:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AH46b-00019d-Ns
	for classpath@gnu.org; Tue, 04 Nov 2003 11:33:04 -0500
Received: from [151.164.30.28] (helo=mta4.rcsntx.swbell.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AH46a-00018P-Ps
	for classpath@gnu.org; Tue, 04 Nov 2003 11:32:32 -0500
Received: from bothner.com (adsl-216-102-199-253.dsl.snfc21.pacbell.net
	[216.102.199.253])
	by mta4.rcsntx.swbell.net (8.12.10/8.12.10) with ESMTP id
	hA4GWNTX003439; Tue, 4 Nov 2003 10:32:24 -0600 (CST)
Message-ID: <3FA7D497.3040007@bothner.com>
Date: Tue, 04 Nov 2003 08:32:23 -0800
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.5b) Gecko/20030827
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Sascha Brawer <brawer@dandelis.ch>
References: <20031030075517.75989.qmail@web25005.mail.ukl.yahoo.com>
	<20031104105548.25206@smtp.mail.ch.easynet.net>
In-Reply-To: <20031104105548.25206@smtp.mail.ch.easynet.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, jsona laio <freeonfair@yahoo.co.uk>
Subject: Re: characters set's problem
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 16:33:09 -0000

Sascha Brawer wrote:

> What exactly do you mean when you say "Unicode"? It seems that you think
> that Java uses only U+0000 .. U+FFFF (the "basic multilingual plane",
> also known as UCS-2). As far as I know, this was true in the past, but
> this restriction has changed in the meantime. Nowadays, Java uses the
> full Unicode character set.

But rather awkwardly and incompletely.  Is there a replacement for 
java.lang.Character, which only handles 16-bit 'char' values?
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/





From MAILER-DAEMON Tue Nov 04 11:59:26 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AH4Wc-0001LZ-LT
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 11:59:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AH4WZ-0001KR-Mv
	for classpath@gnu.org; Tue, 04 Nov 2003 11:59:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AH4W1-0001At-Se
	for classpath@gnu.org; Tue, 04 Nov 2003 11:59:21 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AH4TM-0000Py-Ko
	for classpath@gnu.org; Tue, 04 Nov 2003 11:56:04 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 4 Nov 2003 17:56:01 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: VMInterface addition: Make native library names part
	ofVMInterface
Thread-Index: AcOcLfnM32qO7eKgRdmnlRQvzABwhgGxPcxA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Bryce McKinlay" <bryce@mckinlay.net.nz>, "Mark Wielaard" <mark@klomp.org>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 16:59:24 -0000

Bryce McKinlay wrote:
> Sorry, I think I misunderstood your message. I thought you were=20
> suggesting moving all the native methods (eg for IO classes) to=20
> separate VM* classes.

I think that is in fact what Mark was suggesting and I think this is
definitely a good idea. There are a lot of VMs that don't (want to) use
JNI for their "native" methods. Having all native methods in the VM*
classes makes this much easier.

> Right. I think there is a distinction, however, between what the VM=20
> must implement to operate with classpath - ie core VM classes like=20
> Class, Object, Throwable, Thread; and portable classes which=20
> happen to have native methods, such as java.io.File and=20
> java.net.PlainSocketImpl.=20
> The later are just normal classes with native methods, the=20
> implementations of which are typically be portable across different=20
> VMs.

This assumption is not true for some VMs. My VM (IKVM) has no native
methods and I'm pretty sure this is also true for JAOS and maybe others.

> So, they a system/platform interface rather than the VM=20
> interface.=20
> To put it another way, just because a method is native=20
> doesn't mean it interfaces with the VM.

The VM* classes don't mean "interfaces with the VM", but are a way for
VM implementers to easily replace their implementation. (The idea being
that the interface between the non-VM and VM classes is fairly stable).

Regards,
Jeroen



From MAILER-DAEMON Tue Nov 04 15:25:57 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AH7eW-0005ia-1s
	for mharc-classpath@gnu.org; Tue, 04 Nov 2003 15:19:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AH7eI-0005hK-SP
	for classpath@gnu.org; Tue, 04 Nov 2003 15:19:34 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AH7dl-0005bK-F9
	for classpath@gnu.org; Tue, 04 Nov 2003 15:19:32 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AH7ZW-00040Y-Ul
	for classpath@gnu.org; Tue, 04 Nov 2003 15:14:39 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id B4B43620C8; Tue,  4 Nov 2003 20:14:36 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 90664-02; Tue,  4 Nov 2003 20:14:34 +0000 (GMT)
Received: from reali.dnsalias.net (adsl-212-41-77-140.solnet.ch
	[212.41.77.140]) by mail01.solnet.ch (Postfix) with ESMTP
	id 32DAB60E0C; Tue,  4 Nov 2003 20:14:32 +0000 (GMT)
Received: from pcprr
	(192-168-001-003-at-home-your-network.privateiprange.solnet.ch
	[192.168.1.3]) by reali.dnsalias.net (Postfix) with SMTP
	id B4B073BDD2; Tue,  4 Nov 2003 21:05:00 +0100 (CET)
Message-ID: <001d01c3a310$57042700$0301a8c0@pcprr>
From: "Patrik Reali" <reali@acm.org>
To: "Jeroen Frijters" <jeroen@sumatra.nl>,
	"Bryce McKinlay" <bryce@mckinlay.net.nz>, "Mark Wielaard" <mark@klomp.org>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
Date: Tue, 4 Nov 2003 21:15:06 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Virus-Scanned: by SolNet
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 20:19:46 -0000

Jeroen wrote:
> Bryce McKinlay wrote:
> > Sorry, I think I misunderstood your message. I thought you were
> > suggesting moving all the native methods (eg for IO classes) to
> > separate VM* classes.
>
> I think that is in fact what Mark was suggesting and I think this is
> definitely a good idea. There are a lot of VMs that don't (want to) use
> JNI for their "native" methods. Having all native methods in the VM*
> classes makes this much easier.
>

I agree with this. Moving all the native methods in the VM* classes would be
easier for the VM implementors, because it is easier to document or find out
which methods must be provided (a grep native *.java doesn't help much!).

> > Right. I think there is a distinction, however, between what the VM
> > must implement to operate with classpath - ie core VM classes like
> > Class, Object, Throwable, Thread; and portable classes which
> > happen to have native methods, such as java.io.File and
> > java.net.PlainSocketImpl.
> > The later are just normal classes with native methods, the
> > implementations of which are typically be portable across different
> > VMs.
>
> This assumption is not true for some VMs. My VM (IKVM) has no native
> methods and I'm pretty sure this is also true for JAOS and maybe others.
>

How I'm going to explain this...? Well Jaos uses the Oberon language to
provide the native methods (native == written in a language other than
java), but  doesn't go through JNI: both languages have the same object
model with garbage collection, so no object pinning and similar stuff is
needed, and the jitter compiles the byte-code using the same data layout and
calling convention, such that the generated code is identical for both
languages. It is the task of the linker to patch the native implementation
entry points into the method tables, and from that point java can call
oberon and oberon can call java.

Moving all the native methods to a separate class would make my job simpler:
I would replace the complete class with an oberon class instead of having to
merge them. And because the interface is stable, I would be able to get rid
of a lot of bootstrap code, which checks every time whether the methods and
fields have changed.

> > So, they a system/platform interface rather than the VM
> > interface.
> > To put it another way, just because a method is native
> > doesn't mean it interfaces with the VM.
>
> The VM* classes don't mean "interfaces with the VM", but are a way for
> VM implementers to easily replace their implementation. (The idea being
> that the interface between the non-VM and VM classes is fairly stable).
>

Well, the VM classes are part of the VM interface, which is much broader. I
agree that they will be fairly stable, thus making the port simpler to
maintain.

-Patrik

--------
Patrik Reali
http://www.reali.ch/~patrik/
http://www.oberon.ethz.ch/jaos/




From MAILER-DAEMON Wed Nov 05 07:45:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHN1w-0002tq-1H
	for mharc-classpath@gnu.org; Wed, 05 Nov 2003 07:45:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHN1s-0002pH-CY
	for classpath@gnu.org; Wed, 05 Nov 2003 07:44:56 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHN1L-0002R5-0P
	for classpath@gnu.org; Wed, 05 Nov 2003 07:44:54 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHMt1-0000RO-DK
	for classpath@gnu.org; Wed, 05 Nov 2003 07:35:47 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA5CZWM06762
	for <classpath@gnu.org>; Wed, 5 Nov 2003 07:35:32 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA5CZV626891
	for <classpath@gnu.org>; Wed, 5 Nov 2003 07:35:32 -0500
Received: from cuddles.cambridge.redhat.com
	(IDENT:21UfYTubpFlucjcZcP3ev7p9JxGNTy76@vpn50-18.rdu.redhat.com
	[172.16.50.18])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA5CZUJm006084; 
	Wed, 5 Nov 2003 07:35:31 -0500
Received: from cuddles.cambridge.redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	hA5CY3Lc003113; Wed, 5 Nov 2003 12:34:28 GMT
Received: (from aph@localhost)
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8/Submit) id
	hA5CXwP5003109; Wed, 5 Nov 2003 12:33:58 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16296.60982.421684.459543@cuddles.cambridge.redhat.com>
Date: Wed, 5 Nov 2003 12:33:58 +0000
To: "Patrik Reali" <reali@acm.org>
In-Reply-To: <001d01c3a310$57042700$0301a8c0@pcprr>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
	<001d01c3a310$57042700$0301a8c0@pcprr>
X-Mailer: VM 7.14 under Emacs 21.2.1
Cc: Mark Wielaard <mark@klomp.org>, Bryce McKinlay <bryce@mckinlay.net.nz>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2003 12:44:58 -0000

Patrik Reali writes:
 > Jeroen wrote:
 > > Bryce McKinlay wrote:

 > > > Sorry, I think I misunderstood your message. I thought you were
 > > > suggesting moving all the native methods (eg for IO classes) to
 > > > separate VM* classes.
 > >
 > > I think that is in fact what Mark was suggesting and I think this
 > > is definitely a good idea. There are a lot of VMs that don't
 > > (want to) use JNI for their "native" methods. Having all native
 > > methods in the VM* classes makes this much easier.
 > 
 > I agree with this. Moving all the native methods in the VM* classes
 > would be easier for the VM implementors, because it is easier to
 > document or find out which methods must be provided (a grep native
 > *.java doesn't help much!).

Well, it depends.  A downside is that this will cause divergewnce
between libgcj and classpath, because of course we won't add another
indirection where it isn't necessary.  We don't have global inlining
in gcj at the moment, and two trips through the PLT for simple native
method invocations would be intolerable.  I suppose we could put some
sort of evil hack into the compiler to redirect such calls to the real
implementation, but I don't like that idea much.

Yea, we will eventually have global inlining so we can redirect
trivial calls.  However, in the presence of inheritance it's not
always easy to do this: binary compatibility says that even a call to
a final method can't necessarily be inlined because the target method
might be made non-final.

Andrew.



From MAILER-DAEMON Wed Nov 05 09:25:44 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHObP-0003tb-KK
	for mharc-classpath@gnu.org; Wed, 05 Nov 2003 09:25:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHObK-0003rW-68
	for classpath@gnu.org; Wed, 05 Nov 2003 09:25:38 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHOai-0003Yo-Q8
	for classpath@gnu.org; Wed, 05 Nov 2003 09:25:31 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHOad-0003Uh-9U
	for classpath@gnu.org; Wed, 05 Nov 2003 09:24:55 -0500
Received: from [192.168.1.33] (unknown [217.8.219.217])
	by smtp1.mail.ch.easynet.net (Postfix) with ESMTP
	id 453684A01E; Wed,  5 Nov 2003 15:24:46 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: Per Bothner <per@bothner.com>
Date: Wed, 5 Nov 2003 15:23:44 +0100
Message-Id: <20031105142344.29610@smtp.mail.ch.easynet.net>
In-Reply-To: <3FA7D497.3040007@bothner.com>
References: <3FA7D497.3040007@bothner.com>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, jsona laio <freeonfair@yahoo.co.uk>
Subject: Re: characters set's problem
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2003 14:25:39 -0000

Per Bothner <per@bothner.com> wrote on Tue, 4 Nov 2003 08:32:23 -0800:

>> Nowadays, Java uses the full Unicode character set.
>
>But rather awkwardly and incompletely.  Is there a replacement for 
>java.lang.Character, which only handles 16-bit 'char' values?

It certainly would make sense to enhance java.lang.Character accordingly.
J2SE1.5 might provide this, but I did not want to look at the pre-release
code for checking. Here's an announcement, though:

>Unicode 3.1 Support
>
>32-bit surrogate character support will be carefully added to the
>platform so the Java "char" will still remain at 16 bits.

Quoted from: http://developer.java.sun.com/developer/technicalArticles/
RoadMaps/J2SE_1.5/j2se_1_5.html

Best regards,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Nov 05 15:37:20 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHUP1-00025I-Pw
	for mharc-classpath@gnu.org; Wed, 05 Nov 2003 15:37:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHUOz-00023L-G3
	for classpath@gnu.org; Wed, 05 Nov 2003 15:37:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHUOT-0001o1-9n
	for classpath@gnu.org; Wed, 05 Nov 2003 15:37:16 -0500
Received: from [210.55.57.198] (helo=server.flinders.co.nz)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AHUJq-0008V9-Kf
	for classpath@gnu.org; Wed, 05 Nov 2003 15:31:58 -0500
Received: from [192.168.0.191] by server.flinders.co.nz (AppleMailServer
	10.2.3.0) id 98804 via TCP with SMTP; Thu, 06 Nov 2003 09:42:46 +1300
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
Mime-Version: 1.0 (Apple Message framework v606)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <13160FCD-0FCF-11D8-8B8E-003065F97F7C@mckinlay.net.nz>
Content-Transfer-Encoding: 7bit
From: Bryce McKinlay <bryce@mckinlay.net.nz>
Date: Thu, 6 Nov 2003 09:31:46 +1300
To: "Jeroen Frijters" <jeroen@sumatra.nl>
X-Mailer: Apple Mail (2.606)
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2003 20:37:18 -0000

On Nov 5, 2003, at 5:56 AM, Jeroen Frijters wrote:

> Bryce McKinlay wrote:
>> Sorry, I think I misunderstood your message. I thought you were
>> suggesting moving all the native methods (eg for IO classes) to
>> separate VM* classes.
>
> I think that is in fact what Mark was suggesting and I think this is
> definitely a good idea. There are a lot of VMs that don't (want to) use
> JNI for their "native" methods. Having all native methods in the VM*
> classes makes this much easier.

On the other hand, too much abstraction increases the complexity of the 
classes, making maintenance more difficult. Even putting efficiency 
issues aside, I agree with Andrew - we would not want to do this in 
libgcj.

> This assumption is not true for some VMs. My VM (IKVM) has no native
> methods and I'm pretty sure this is also true for JAOS and maybe 
> others.

I think its a mistake for classpath to try to be everything for 
everyone, even at the expense of elegance and efficiency. At some 
point, most implementations are going to have to modify it in some way 
in order to suit their special/custom needs.

Regards

Bryce.





From MAILER-DAEMON Thu Nov 06 04:58:40 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHguV-000885-Rz
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 04:58:39 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHguS-00086P-HM
	for classpath@gnu.org; Thu, 06 Nov 2003 04:58:36 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHgtw-0007s7-8Y
	for classpath@gnu.org; Thu, 06 Nov 2003 04:58:35 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHgtv-0007s4-OG
	for classpath@gnu.org; Thu, 06 Nov 2003 04:58:03 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AHgtX-0001c4-00
	for <classpath@gnu.org>; Thu, 06 Nov 2003 10:57:39 +0100
From: Mark Wielaard <mark@klomp.org>
To: GNU Classpath <classpath@gnu.org>
In-Reply-To: <13160FCD-0FCF-11D8-8B8E-003065F97F7C@mckinlay.net.nz>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
	<13160FCD-0FCF-11D8-8B8E-003065F97F7C@mckinlay.net.nz>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-6ToJPPkD8XG3yvzDeBAv"
Message-Id: <1068112680.960.56.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 06 Nov 2003 10:58:00 +0100
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 09:58:37 -0000


--=-6ToJPPkD8XG3yvzDeBAv
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2003-11-05 at 21:31, Bryce McKinlay wrote:
> On Nov 5, 2003, at 5:56 AM, Jeroen Frijters wrote:
>=20
> > I think that is in fact what Mark was suggesting and I think this is
> > definitely a good idea. There are a lot of VMs that don't (want to) use
> > JNI for their "native" methods. Having all native methods in the VM*
> > classes makes this much easier.

I was suggesting that. Sorry for not responding earlier. But having you
and Patrik affirm that it is a good thing is more valuable then when
'the guy without his own VM' says it :)

> I think its a mistake for classpath to try to be everything for=20
> everyone, even at the expense of elegance and efficiency. At some=20
> point, most implementations are going to have to modify it in some way=20
> in order to suit their special/custom needs.

Hopefully we won't do it at the expense of elegance 'and' efficiency,
but I agree that sometimes it won't be possible to achieve both. As our
Hacker Guide puts it (even though it leaves out elegance):

        When you write code for Classpath, write with three things in
        mind, and in the following order: portability, robustness, and
        efficiency.
       =20
        If efficiency breaks portability or robustness, then don't do it
        the efficient way. If robustness breaks portability, then
        bye-bye robust code. Of course, as a programmer you would
        probably like to find sneaky ways to get around the issue so
        that your code can be all three ...

And I am also sure that there might be better designs then the grouping
of platform dependent methods into their own VMInterface classes for
some VMs. But just marking some methods 'native' to indicate that they
are platform dependent is not it. A more efficient (and probably more
flexible) approach might be to introduce some preprocessor that munges
the java source files. But doing that in a clean way will be tricky.

One of the big plus points of defining all platform dependent methods in
VMInterface classes is that it makes clear when you are about to break
Classpath any VM, so you must explicitly document your change. And such
documenting and clear marking of 'special' VM classes makes it a lot
easier for VMs that don't follow classpath CVS all the time, but just
import a new version when we create a new snapshot release.

What I hoped was that by having the VMInterfaces classes clearly marked
as 'special', by being package local, final, having (mostly) static
methods, and starting the name with VM (*), would make it easy for VMs
and compilers to just inline all call to them. Especially if you treat
the Classpath core classes as 'sealed' and compile them as complete
packages. Maybe this is much harder then I imagined.

What would be very beneficial would be if we took the script that gcj
uses to display the changes between current Classpath CVS and gcc CVS
and apply it to all current VMs that use a modified Classpath.
http://gcc.gnu.org/java/libgcj-classpath-compare.html
It has a way to mark changes as 'local' to the VM implementation which
would be very helpful for all Classpath/VM integrators. And if more VMs
used it then it gives the Classpath developers a better clue about what
kind of things have to be adapted for every VM anyway.

I was pleased to hear at the GNU Classpath workshop that at least
Kissme, IKVM and Jaos use an unmodified GNU Classpath as core library
implementation (and I believe JikesRVM also uses a unmodified
Classpath). So we are not doing that bad. But maybe those VM/Compilers
are not as aggressive about efficiency and elegance as gcj is (which
does produce some very fast code!).

But I still like to hear how we can improve the VM/Compiler/Platform
specific parts of GNU Classpath without making life much harder for the
gcj hackers.

Cheers,

Mark

(*) Maybe VMInterface was wrong and we should actually call these
classes Platform_Interface classes.

--=-6ToJPPkD8XG3yvzDeBAv
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/qhsoxVhZCJWr9QwRApaNAKCYfy0WYiVyS32gpvuDYLl3xurn/QCfU++m
AQ9JXXqjAAwdGIrplqCQLJU=
=85v4
-----END PGP SIGNATURE-----

--=-6ToJPPkD8XG3yvzDeBAv--




From MAILER-DAEMON Thu Nov 06 05:29:58 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHhOn-0001Mm-6s
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 05:29:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHhOk-0001Ik-Nv
	for classpath@gnu.org; Thu, 06 Nov 2003 05:29:54 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHhOE-0000Na-Dw
	for classpath@gnu.org; Thu, 06 Nov 2003 05:29:53 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHhOD-0000La-R0
	for classpath@gnu.org; Thu, 06 Nov 2003 05:29:21 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA6ATKM27862
	for <classpath@gnu.org>; Thu, 6 Nov 2003 05:29:20 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA6ATK613745
	for <classpath@gnu.org>; Thu, 6 Nov 2003 05:29:20 -0500
Received: from cuddles.cambridge.redhat.com
	(IDENT:OlLcktMfneJxLY+kaHcmO+duxtKMecLQ@vpn50-18.rdu.redhat.com
	[172.16.50.18])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA6ATJH8014931; 
	Thu, 6 Nov 2003 05:29:19 -0500
Received: from cuddles.cambridge.redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	hA6ASSLc010000; Thu, 6 Nov 2003 10:28:53 GMT
Received: (from aph@localhost)
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8/Submit) id
	hA6ASO0Q009994; Thu, 6 Nov 2003 10:28:24 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16298.8776.457802.77025@cuddles.cambridge.redhat.com>
Date: Thu, 6 Nov 2003 10:28:24 +0000
To: Mark Wielaard <mark@klomp.org>
In-Reply-To: <1068112680.960.56.camel@elsschot.wildebeest.org>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>
	<13160FCD-0FCF-11D8-8B8E-003065F97F7C@mckinlay.net.nz>
	<1068112680.960.56.camel@elsschot.wildebeest.org>
X-Mailer: VM 7.14 under Emacs 21.2.1
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 10:29:55 -0000

Mark Wielaard writes:
 > 
 > Hopefully we won't do it at the expense of elegance 'and' efficiency,
 > but I agree that sometimes it won't be possible to achieve both. As our
 > Hacker Guide puts it (even though it leaves out elegance):
 > 
 >         When you write code for Classpath, write with three things in
 >         mind, and in the following order: portability, robustness, and
 >         efficiency.
 >         
 >         If efficiency breaks portability or robustness, then don't do it
 >         the efficient way. If robustness breaks portability, then
 >         bye-bye robust code. Of course, as a programmer you would
 >         probably like to find sneaky ways to get around the issue so
 >         that your code can be all three ...

And clearly these guidelines are at odds with those of libgcj, where
(and this is just my opinion) we favour robustness, maintainability,
efficiency, portability.

My goal is to improve gcj's speed to the point where it matches all of
its competitors.  I will be very cross indeed if while I am improving
the compiler someone is concurrently pessimizing the library,

 > What I hoped was that by having the VMInterfaces classes clearly
 > marked as 'special', by being package local, final, having (mostly)
 > static methods, and starting the name with VM (*), would make it
 > easy for VMs and compilers to just inline all call to
 > them. Especially if you treat the Classpath core classes as
 > 'sealed' and compile them as complete packages. Maybe this is much
 > harder then I imagined.

It's not particularly difficult to do, but at the moment we don't do
it.  gcj is perfectly capable of whole-program Java optimization but
we have to follow Java rules, and one of those rules is that you
cannot inline final methods because it breaks binary compatibility.
We could teach gcj that VM<foo> classes are an exception to that rule,
but I think you would agree that's not a pretty solution.
Alternatively, we could perhaps have a compiler switch that allows
final methods to be inlined, so

   gcj -finline-final foo.class VMfoo.class

inlines all calls to final methods between foo and VMfoo.  However,
this would force us to rewrite the libgcj build scripts to handle
VMfoo classes in a special way.

However, none of this addresses Bryce's valid point that "too much
abstraction increases the complexity of the classes, making
maintenance more difficult."  I've worked on systems with too much
abstraction.  They are very hard to understand and debug.

Andrew.



From MAILER-DAEMON Thu Nov 06 06:06:03 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHhxi-0003JF-TO
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 06:06:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHhxf-0003Gf-NE
	for classpath@gnu.org; Thu, 06 Nov 2003 06:05:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHhx3-0002Zn-UL
	for classpath@gnu.org; Thu, 06 Nov 2003 06:05:52 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHhx3-0002Xw-53
	for classpath@gnu.org; Thu, 06 Nov 2003 06:05:21 -0500
Received: from [192.168.1.33] (unknown [217.8.220.98])
	by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id 473DE6468C; Thu,  6 Nov 2003 12:05:17 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: Mark Wielaard <mark@klomp.org>, Andrew Haley <aph@redhat.com>
Date: Thu, 6 Nov 2003 12:04:20 +0100
Message-Id: <20031106110420.7453@smtp.mail.ch.easynet.net>
In-Reply-To: <16298.8776.457802.77025@cuddles.cambridge.redhat.com>
References: <16298.8776.457802.77025@cuddles.cambridge.redhat.com>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
 ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 11:06:00 -0000

Andrew Haley <aph@redhat.com> wrote on Thu, 6 Nov 2003 10:28:24 +0000:

>> [having the VMInterfaces classes clearly marked as 'special'
>> would make it easy for VMs and compilers to just inline all calls
>> to them]

>It's not particularly difficult to do, but at the moment we don't do
>it.  gcj is perfectly capable of whole-program Java optimization but
>we have to follow Java rules, and one of those rules is that you
>cannot inline final methods because it breaks binary compatibility.
>We could teach gcj that VM<foo> classes are an exception to that rule,
>but I think you would agree that's not a pretty solution.

Apparently, Java 1.5 will have "meta-data" (arbitrary, uninterpreted
declarations for language constructs that are represented in bytecode and
accessible via reflection), similar to CLI/.NET. This might be a much
cleaner approach for declaring such exceptions. Of course, the free
compilers would need to support it first.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Thu Nov 06 06:30:43 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHiKu-0005QX-JM
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 06:30:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHiKe-00050J-LC
	for classpath@gnu.org; Thu, 06 Nov 2003 06:29:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHiJn-0004PG-OF
	for classpath@gnu.org; Thu, 06 Nov 2003 06:29:22 -0500
Received: from [193.74.71.23] (helo=oola.is.kpn.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHiJi-0004LA-M0
	for classpath@gnu.org; Thu, 06 Nov 2003 06:28:46 -0500
Received: from (eudslpro-213-49-17-120.antwerp.kpn.be [213.49.17.120]) 
	by oola.is.kpn.be  with SMTP id hA6BSZS29708; 
	Thu, 6 Nov 2003 12:28:35 +0100
Message-Id: <200311061128.hA6BSZS29708@oola.is.kpn.be>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Sascha Brawer <brawer@dandelis.ch>, Mark Wielaard <mark@klomp.org>,
	Andrew Haley <aph@redhat.com>
Date: Thu, 6 Nov 2003 12:29:28 +0100
X-Mailer: KMail [version 1.3]
References: <16298.8776.457802.77025@cuddles.cambridge.redhat.com>
	<20031106110420.7453@smtp.mail.ch.easynet.net>
In-Reply-To: <20031106110420.7453@smtp.mail.ch.easynet.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 11:29:59 -0000

On Thursday 06 November 2003 12:04, Sascha Brawer wrote:
> Andrew Haley <aph@redhat.com> wrote on Thu, 6 Nov 2003 10:28:24 +0000:
> >> [having the VMInterfaces classes clearly marked as 'special'
> >> would make it easy for VMs and compilers to just inline all calls
> >> to them]
> >
> >It's not particularly difficult to do, but at the moment we don't do
> >it.  gcj is perfectly capable of whole-program Java optimization but
> >we have to follow Java rules, and one of those rules is that you
> >cannot inline final methods because it breaks binary compatibility.
> >We could teach gcj that VM<foo> classes are an exception to that rule,
> >but I think you would agree that's not a pretty solution.
>
> Apparently, Java 1.5 will have "meta-data" (arbitrary, uninterpreted
> declarations for language constructs that are represented in bytecode and
> accessible via reflection), similar to CLI/.NET. This might be a much
> cleaner approach for declaring such exceptions. Of course, the free
> compilers would need to support it first.

You could do it already using the "Attributes" mechanism - Java 
implementations are supposed to silently ignore attributes they don't 
understand. The attributes could be inserted by a tool using BCEL, so you 
wouldn't actually need to modify the compiler ...

-- 
Chris Gray                                /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                      +32 477 599 703



From MAILER-DAEMON Thu Nov 06 06:38:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHiTM-0004d5-AH
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 06:38:44 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHiEX-0002Xq-8G
	for classpath@gnu.org; Thu, 06 Nov 2003 06:23:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHiE0-0002Tq-0T
	for classpath@gnu.org; Thu, 06 Nov 2003 06:23:24 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHi98-0001QV-Kp
	for classpath@gnu.org; Thu, 06 Nov 2003 06:17:50 -0500
Received: (qmail 12499 invoked by uid 504); 6 Nov 2003 12:17:48 +0100
Received: from avdyk@debian.org by serv09.segi.ulg.ac.be by uid 501 with
	qmail-scanner-1.16 (clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.621953 secs); 06 Nov 2003 11:17:48 -0000
Received: from unknown (HELO localhost) ([139.165.77.48])
	(envelope-sender <avdyk@debian.org>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 6 Nov 2003 12:17:47 +0100
Date: Thu, 06 Nov 2003 12:17:46 +0100 (CET)
Message-Id: <20031106.121746.22961089.avdyk@debian.org>
To: classpath@gnu.org
From: Arnaud Vandyck <avdyk@debian.org>
In-Reply-To: <16285.43063.411880.776782@creche.redhat.com>
References: <1067034738.1260.312.camel@elsschot>
	<20031025083813.GA27689@mail.konqueror.de>
	<16285.43063.411880.776782@creche.redhat.com>
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://people.debian.org/~avdyk/
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
X-Mailer: Mew version 4.0.59 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Thu, 06 Nov 2003 06:38:42 -0500
Subject: Re: Code formatting
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 11:23:26 -0000

On Mon, 27 Oct 2003 16:20:23 -0700
Tom Tromey <tromey@redhat.com> wrote:

> >>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
> 
> Michael> From what I understood what Tom said to me our style would be to write:
> Michael> 		getToolkit().create (this);
> Michael> Empty brackets have no space before it, non-empty brackets have a
> Michael> space before it.
> 
> Oops, I didn't mean to give that impression.
> My understanding was that, in theory, for method calls we never had a
> space before the parens.  (In practice we often do, we're kind of
> random about it.)

So... what's up with this? ;) Do I have to re-write my patch? Was it
already committed?

Cheers,

-- 
  .''`.       ** Debian GNU/Linux **
 : :' :          Arnaud   Vandyck
 `. `'   http://people.debian.org/~avdyk/
   `-    



From MAILER-DAEMON Thu Nov 06 07:12:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHiwz-0001V5-N9
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 07:09:21 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHiwT-0001NR-Lx
	for classpath@gnu.org; Thu, 06 Nov 2003 07:08:49 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHiuS-0000e9-Br
	for classpath@gnu.org; Thu, 06 Nov 2003 07:07:15 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHiog-0008Ew-W3
	for classpath@gnu.org; Thu, 06 Nov 2003 07:00:47 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AHioI-0001ra-00
	for <classpath@gnu.org>; Thu, 06 Nov 2003 13:00:22 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <3FA56509.4080005@kaffe.org>
References: <3FA2A610.8010002@kaffe.org>
	<1067783743.794.44.camel@elsschot.wildebeest.org>
	<3FA531DA.6010501@kaffe.org>
	<1067795743.11103.44.camel@elsschot.wildebeest.org>
	<3FA56509.4080005@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-J3Rgxdk8WEtSGO8b7c/o"
Message-Id: <1068120043.973.119.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 06 Nov 2003 13:00:43 +0100
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 12:09:19 -0000


--=-J3Rgxdk8WEtSGO8b7c/o
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2003-11-02 at 21:11, Guilhem Lavaux wrote:
> Mark Wielaard wrote:
>=20
> >OK. Let me try to summarize the behavior we want so we can at least
> >create some good tests:
> >
> >DataInputStream.readLine():
> >- Should not block when it has seen at least a \r but return as soon as
> >  possible even when it cannot be sure that the next character is or
> >  isn't a \n to prevent programs from blocking/deadlocking.
> >- If there is a unconsumed \n in the stream right after a readLine()
> >  then that \n should be transparently consumed for all these cases:
> >  - readLine() is called again.
> >  - another DataInputStream read method is called.
> >  - a non-overridden (Filter)InputStream is called.
> >  - a method in the originally wrapped InputStream is called.
> >
> >That will be an ugly nut to crack. Especially how to guarantee that last
> >requirement is nasty. And the method is (rightly) deprectated since
> >programmers should BufferedReader.readLine() anyway (specified since
> >1.1). Sigh.
> >
> >But having a good test case will be very valuable start.
> >Any volunteers :)
> > =20
> Well ! You described entirely the behaviour of the test. So it should be=20
> considered as done. ;-)

I assume you are talking about test/regression/InputStreamTest.java from
kaffe. I only briefly looked at it when the thread started and assumed
it was only some strange corner case since it was also using the
deprecated StringBufferInputStream (which has its own share of
problems). Does that test really show all the (corner) cases that were
discussed? (Especially when to wrapped InputStream is blocking just in
the middle of a \r\n pair. Which seems to be the tricky case.)

> But JDK won't pass this test (I've just tested=20
> one or two pieces of the ideas). Actually if DataInputStream can detect=20
> the '\n' it eats it directly in the call to readLine().

That is interesting. So that implementation probably just does some
heuristics on the end of line if it can do it by looking ahead in the
stream, but not otherwise. That is a very sneaky thing todo, but
probably works in most cases that people care about. Sigh. What a bunch
of yuck needed for such an ugly and deprecated method.

Cheers,

Mark

--=-J3Rgxdk8WEtSGO8b7c/o
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/qjfrxVhZCJWr9QwRAgDMAJ9qkQcM5GlS9sbHciQB2+YJUtjgUwCgp8Vw
tKhdX1BjhBTk4glJTM1pLLQ=
=L5kP
-----END PGP SIGNATURE-----

--=-J3Rgxdk8WEtSGO8b7c/o--




From MAILER-DAEMON Thu Nov 06 07:16:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHj1J-0002yE-53
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 07:13:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHixW-0001cE-RB
	for classpath@gnu.org; Thu, 06 Nov 2003 07:09:54 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHikQ-0007bk-Ou
	for classpath@gnu.org; Thu, 06 Nov 2003 06:56:53 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHijt-0007N9-EK
	for classpath@gnu.org; Thu, 06 Nov 2003 06:55:49 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA6BtXM13715
	for <classpath@gnu.org>; Thu, 6 Nov 2003 06:55:33 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA6BtX602772
	for <classpath@gnu.org>; Thu, 6 Nov 2003 06:55:33 -0500
Received: from cuddles.cambridge.redhat.com
	(IDENT:qg0b62c3TU46X1a+JvaT1X5gAlZRPPoh@vpn50-18.rdu.redhat.com
	[172.16.50.18])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA6BtWH8021140; 
	Thu, 6 Nov 2003 06:55:32 -0500
Received: from cuddles.cambridge.redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	hA6BsVLc011833; Thu, 6 Nov 2003 11:54:56 GMT
Received: (from aph@localhost)
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8/Submit) id
	hA6BsTdq011829; Thu, 6 Nov 2003 11:54:29 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16298.13941.838766.667652@cuddles.cambridge.redhat.com>
Date: Thu, 6 Nov 2003 11:54:29 +0000
To: Sascha Brawer <brawer@dandelis.ch>
In-Reply-To: <20031106110420.7453@smtp.mail.ch.easynet.net>
References: <16298.8776.457802.77025@cuddles.cambridge.redhat.com>
	<20031106110420.7453@smtp.mail.ch.easynet.net>
X-Mailer: VM 7.14 under Emacs 21.2.1
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names part
 ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 12:13:47 -0000

Sascha Brawer writes:
 > Andrew Haley <aph@redhat.com> wrote on Thu, 6 Nov 2003 10:28:24 +0000:
 > 
 > >> [having the VMInterfaces classes clearly marked as 'special'
 > >> would make it easy for VMs and compilers to just inline all calls
 > >> to them]
 > 
 > >It's not particularly difficult to do, but at the moment we don't do
 > >it.  gcj is perfectly capable of whole-program Java optimization but
 > >we have to follow Java rules, and one of those rules is that you
 > >cannot inline final methods because it breaks binary compatibility.
 > >We could teach gcj that VM<foo> classes are an exception to that rule,
 > >but I think you would agree that's not a pretty solution.
 > 
 > Apparently, Java 1.5 will have "meta-data" (arbitrary, uninterpreted
 > declarations for language constructs that are represented in bytecode and
 > accessible via reflection), similar to CLI/.NET.

So we'd have something like

   public final class VMfoo
   {
      @Inline void native bar (int i);
   
      @Inline void baz (int i) {
   
I could make that work.

Andrew.



From MAILER-DAEMON Thu Nov 06 08:38:40 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHkLO-0005hX-8M
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 08:38:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHkJE-00047W-Nc
	for classpath@gnu.org; Thu, 06 Nov 2003 08:36:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHkIM-0002yB-Br
	for classpath@gnu.org; Thu, 06 Nov 2003 08:36:01 -0500
Received: from [32.97.182.101] (helo=e1.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AHkH8-0002Ab-IB
	for classpath@gnu.org; Thu, 06 Nov 2003 08:34:14 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e1.ny.us.ibm.com (8.12.10/NS PXFA) with ESMTP id hA6DY9f8357110
	for <classpath@gnu.org>; Thu, 6 Nov 2003 08:34:09 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hA6DY7ij066364
	for <classpath@gnu.org>; Thu, 6 Nov 2003 08:34:07 -0500
In-Reply-To: <1068112680.960.56.camel@elsschot.wildebeest.org>
To: GNU Classpath <classpath@gnu.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OF856B18AB.AD06757D-ON85256DD6.00490A42-85256DD6.004A8837@us.ibm.com>
Date: Thu, 6 Nov 2003 08:34:06 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/06/2003 08:34:08,
	Serialize complete at 11/06/2003 08:34:08
Content-Type: multipart/alternative;
	boundary="=_alternative 004A732485256DD6_="
Subject: Re: VMInterface addition: Make native library names
	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 13:38:36 -0000

This is a multipart message in MIME format.
--=_alternative 004A732485256DD6_=
Content-Type: text/plain; charset="US-ASCII"

Jikes RVM uses a mostly unmodifed classpath.  We don't require users to 
patch any classpath sources, but there are currently 12 non-VM classes for 
which we provide our own implementation.
        java.lang.ref: PhantomReference, Reference, SoftReference, 
WeakReference
        java.lang: Class, Object, Runtime, Thread, Throwable
        java.lang.reflect: Constructor, Field, Method

Some of this is historical (we had the classes already and haven't had the 
bandwidth to try to integrate our versions with classpath).  In the case 
of java.lang.ref.* we really needed to do something different than what 
classpath provided, and I don't see that changing (and the classes are 
tiny anyways).  There may be hope for merging some of the java.lang and 
java.lang.reflect classes eventually.

Jikes RVM cares a lot about efficiency, but we have different constraints 
than gcj.  It's very easy for us to inline across classes without breaking 
any semantics.  The VM itself is also written in Java (with some 
extensions to allow the VM to do type unsafe things like implement a GC), 
so for us efficiency usually means avoiding native methods and staying in 
Java+VM_Magic (this is what motivated the VMFloat/VMDouble changes I 
contributed to classpath a while back...Jikes RVM can do these operations 
much more efficiently by staying in Java instead of calling a native 
method).  But, an extra level of final methods is harmless for us, we 
inline it all away.

--dave
--=_alternative 004A732485256DD6_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Jikes RVM uses a mostly unmodifed classpath.
&nbsp;We don't require users to patch any classpath sources, but there
are currently 12 non-VM classes for which we provide our own implementation.</font>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; java.lang.ref:
PhantomReference, Reference, SoftReference, WeakReference</font>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; java.lang:
Class, Object, Runtime, Thread, Throwable</font>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; java.lang.reflect:
Constructor, Field, Method</font>
<br>
<br><font size=2 face="sans-serif">Some of this is historical (we had the
classes already and haven't had the bandwidth to try to integrate our versions
with classpath). &nbsp;In the case of java.lang.ref.* we really needed
to do something different than what classpath provided, and I don't see
that changing (and the classes are tiny anyways). &nbsp;There may be hope
for merging some of the java.lang and java.lang.reflect classes eventually.</font>
<br>
<br><font size=2 face="sans-serif">Jikes RVM cares a lot about efficiency,
but we have different constraints than gcj. &nbsp;It's very easy for us
to inline across classes without breaking any semantics. &nbsp;The VM itself
is also written in Java (with some extensions to allow the VM to do type
unsafe things like implement a GC), so for us efficiency usually means
avoiding native methods and staying in Java+VM_Magic (this is what motivated
the VMFloat/VMDouble changes I contributed to classpath a while back...Jikes
RVM can do these operations much more efficiently by staying in Java instead
of calling a native method). &nbsp;But, an extra level of final methods
is harmless for us, we inline it all away.</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 004A732485256DD6_=--



From MAILER-DAEMON Thu Nov 06 09:40:41 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHlJR-0005Pp-IL
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 09:40:41 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHlJJ-0005Mt-94
	for classpath@gnu.org; Thu, 06 Nov 2003 09:40:33 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHlIl-00055a-EX
	for classpath@gnu.org; Thu, 06 Nov 2003 09:40:30 -0500
Received: from [209.222.224.106] (helo=griffin.griffaction.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHlIl-00053k-3I
	for classpath@gnu.org; Thu, 06 Nov 2003 09:39:59 -0500
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by griffin.griffaction.ca with esmtp (Exim 3.36 #1 (Debian))
	id 1AHlId-0003Cp-00; Thu, 06 Nov 2003 09:39:51 -0500
Message-ID: <3FAA5D36.20405@uqam.ca>
Date: Thu, 06 Nov 2003 09:39:50 -0500
From: Etienne Gagnon <etienne.gagnon@uqam.ca>
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.5) Gecko/20031024 Debian/1.5-2
X-Accept-Language: en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <788B535AB1F9CB49BB9C229372B50ACC46D5@LEMBU.sumatrasoftware.com>	<13160FCD-0FCF-11D8-8B8E-003065F97F7C@mckinlay.net.nz>
	<1068112680.960.56.camel@elsschot.wildebeest.org>
In-Reply-To: <1068112680.960.56.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library names
	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 14:40:34 -0000

Mark Wielaard wrote:
>>>I think that is in fact what Mark was suggesting and I think this is
>>>definitely a good idea. There are a lot of VMs that don't (want to) use
>>>JNI for their "native" methods. Having all native methods in the VM*
>>>classes makes this much easier.
> 
> 
> I was suggesting that. Sorry for not responding earlier. But having you
> and Patrik affirm that it is a good thing is more valuable then when
> 'the guy without his own VM' says it :)

I am also strongly in favor of putting all VM-specific native methods in
VM* classes, and all library-specific native methods outside of VM* classes.

It even helps for code maintenance, and you can then use automated tools
to look for missing native implementations in the VM very easily.  Same
applies to class library.

> 
> Hopefully we won't do it at the expense of elegance 'and' efficiency,
> but I agree that sometimes it won't be possible to achieve both. As our
> Hacker Guide puts it (even though it leaves out elegance):
> 
>         When you write code for Classpath, write with three things in
>         mind, and in the following order: portability, robustness, and
>         efficiency.
>         
>         If efficiency breaks portability or robustness, then don't do it
>         the efficient way. If robustness breaks portability, then
>         bye-bye robust code. Of course, as a programmer you would
>         probably like to find sneaky ways to get around the issue so
>         that your code can be all three ...
> 
> And I am also sure that there might be better designs then the grouping
> of platform dependent methods into their own VMInterface classes for
> some VMs. 

I habve yet to find time for it, but I should within the upcoming months.
I see the possibility to use m4-like macros so that most VMs would share
VM*.java implementations, but be able to apply changes to them without
disrupting other VMs.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/




From MAILER-DAEMON Thu Nov 06 10:34:44 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHm9j-0003VX-SL
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 10:34:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHm8x-0002WG-G1
	for classpath@gnu.org; Thu, 06 Nov 2003 10:33:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHm84-0000rW-HZ
	for classpath@gnu.org; Thu, 06 Nov 2003 10:33:31 -0500
Received: from [32.97.182.103] (helo=e3.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AHm7o-0000dy-P5
	for classpath@gnu.org; Thu, 06 Nov 2003 10:32:44 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e3.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id hA6FWgYJ157806
	for <classpath@gnu.org>; Thu, 6 Nov 2003 10:32:42 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hA6FWeij064600
	for <classpath@gnu.org>; Thu, 6 Nov 2003 10:32:41 -0500
In-Reply-To: <3FAA5D36.20405@uqam.ca>
To: GNU Classpath <classpath@gnu.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OF2F442ECD.F17919B9-ON85256DD6.00526C32-85256DD6.005561B7@us.ibm.com>
Date: Thu, 6 Nov 2003 10:32:36 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/06/2003 10:32:41,
	Serialize complete at 11/06/2003 10:32:41
Content-Type: multipart/alternative;
	boundary="=_alternative 00551C4185256DD6_="
Subject: Re: VMInterface addition: Make native library
	names	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 15:34:41 -0000

This is a multipart message in MIME format.
--=_alternative 00551C4185256DD6_=
Content-Type: text/plain; charset="US-ASCII"

> I am also strongly in favor of putting all VM-specific native methods in
> VM* classes, and all library-specific native methods outside of VM* 
classes.

I suspect the notion of a VM-specific native method vs. a library-specific 
native method is pretty fuzzy.  One example is VMFloat, most VM's would 
probably view those as library specific, but Jikes RVM wants to think of 
them as VM-specific because we can do a better job of implementing them in 
a VM-specific way than the native method does (and we don't want to have 
to provide our own complete implementation of Float.java just to change a 
couple methods).  But, the native method is VM neutral and works just fine 
on Jikes RVM, it is just much less efficient for us.

There are also obviously Java methods that are (or can be) VM specific. 
Some of these have been moved to VM* classes, others have not. I don't 
think there is an easy solution to this as it is unlikely that a single 
VMInterface will fit the needs of all VMs perfectly.  In some cases 
(java.lang.ref.* for example), I don't think that it is reasonable for 
classpath to try to provide an implementation that will actually work 
unchanged on all VMs.  The details of this class are pretty closely tied 
into the details of the GC system and there is very little code that isn't 
VM specific.

--dave
--=_alternative 00551C4185256DD6_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2><tt>&gt; I am also strongly in favor of putting all VM-specific
native methods in<br>
&gt; VM* classes, and all library-specific native methods outside of VM*
classes.<br>
</tt></font>
<br><font size=2><tt>I suspect the notion of a VM-specific native method
vs. a library-specific native method is pretty fuzzy. &nbsp;One example
is VMFloat, most VM's would probably view those as library specific, but
Jikes RVM wants to think of them as VM-specific because we can do a better
job of implementing them in a VM-specific way than the native method does
(and we don't want to have to provide our own complete implementation of
Float.java just to change a couple methods). &nbsp;But, the native method
is VM neutral and works just fine on Jikes RVM, it is just much less efficient
for us.</tt></font>
<br>
<br><font size=2><tt>There are also obviously Java methods that are (or
can be) VM specific. Some of these have been moved to VM* classes, others
have not. I don't think there is an easy solution to this as it is unlikely
that a single VMInterface will fit the needs of all VMs perfectly. &nbsp;In
some cases (java.lang.ref.* for example), I don't think that it is reasonable
for classpath to try to provide an implementation that will actually work
unchanged on all VMs. &nbsp;The details of this class are pretty closely
tied into the details of the GC system and there is very little code that
isn't VM specific.</tt></font>
<br>
<br><font size=2><tt>--dave</tt></font>
--=_alternative 00551C4185256DD6_=--



From MAILER-DAEMON Thu Nov 06 10:45:28 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHmK3-0004GL-Kr
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 10:45:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHmIt-0003JR-Ha
	for classpath@gnu.org; Thu, 06 Nov 2003 10:44:11 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHmI1-0002aP-Eg
	for classpath@gnu.org; Thu, 06 Nov 2003 10:43:48 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHmHc-0001lY-Ly
	for classpath@gnu.org; Thu, 06 Nov 2003 10:42:52 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA6FgkM25811
	for <classpath@gnu.org>; Thu, 6 Nov 2003 10:42:46 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA6Fgk620543
	for <classpath@gnu.org>; Thu, 6 Nov 2003 10:42:46 -0500
Received: from cuddles.cambridge.redhat.com
	(IDENT:yOTUHmgWim+9CJ8TG6t4fe1qGXNjl7/y@vpn50-11.rdu.redhat.com
	[172.16.50.11])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA6FgiH8012680; 
	Thu, 6 Nov 2003 10:42:45 -0500
Received: from cuddles.cambridge.redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	hA6FfmLc023513; Thu, 6 Nov 2003 15:42:13 GMT
Received: (from aph@localhost)
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8/Submit) id
	hA6FflRX023509; Thu, 6 Nov 2003 15:41:47 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16298.27579.353696.801616@cuddles.cambridge.redhat.com>
Date: Thu, 6 Nov 2003 15:41:47 +0000
To: David P Grove <groved@us.ibm.com>
In-Reply-To: <OF2F442ECD.F17919B9-ON85256DD6.00526C32-85256DD6.005561B7@us.ibm.com>
References: <3FAA5D36.20405@uqam.ca>
	<OF2F442ECD.F17919B9-ON85256DD6.00526C32-85256DD6.005561B7@us.ibm.com>
X-Mailer: VM 7.14 under Emacs 21.2.1
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library
	names	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 15:45:21 -0000

David P Grove writes:

 > I don't think there is an easy solution to this as it is unlikely
 > that a single VMInterface will fit the needs of all VMs perfectly.
 > In some cases (java.lang.ref.* for example), I don't think that it
 > is reasonable for classpath to try to provide an implementation
 > that will actually work unchanged on all VMs.

Exactly.  Classpath should provide a reference implementation, we but
shouldn't expect every core class to be used unchanged.

Andrew.



From MAILER-DAEMON Thu Nov 06 11:39:39 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHnAX-0000fz-QY
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 11:39:37 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHnAS-0000c1-Nf
	for classpath@gnu.org; Thu, 06 Nov 2003 11:39:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHn9s-0000HV-Pp
	for classpath@gnu.org; Thu, 06 Nov 2003 11:39:27 -0500
Received: from [209.92.1.32] (helo=newmx2.fast.net)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AHn9r-0000G8-8v
	for classpath@gnu.org; Thu, 06 Nov 2003 11:38:55 -0500
Received: (qmail 14693 invoked from network); 6 Nov 2003 16:38:50 -0000
Received: from unknown (HELO corp.fast.net) ([209.152.221.64])
	(envelope-sender <stuart.ballard@corp.fast.net>)
	by newmx2.fast.net (qmail-ldap-1.03) with SMTP
	for <stuart.ballard@corp.fast.net>; 6 Nov 2003 16:38:50 -0000
Message-ID: <3FAA7918.2080609@corp.fast.net>
Date: Thu, 06 Nov 2003 11:38:48 -0500
From: Stuart Ballard <stuart.ballard@corp.fast.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031024 Debian/1.5-2
X-Accept-Language: en
MIME-Version: 1.0
To: Stuart Ballard <stuart.ballard@corp.fast.net>
References: <NFBBKALFDCPFIDBNKAPCEEENDIAA.dholmes@dltech.com.au>
	<3F8E9012.9060706@byu.net> <3F969B4A.3030701@corp.fast.net>
	<3F9D4969.7050106@corp.fast.net>
In-Reply-To: <3F9D4969.7050106@corp.fast.net>
Content-Type: multipart/mixed; boundary="------------040202050501000506090103"
Cc: classpath <classpath@gnu.org>
Subject: Re: [really patch] Re: HashMap putAll/putAllInternal bug
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 16:39:35 -0000

This is a multi-part message in MIME format.
--------------040202050501000506090103
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Stuart Ballard wrote:
> Nobody spoke up, so could someone apply the patch (attached)?

Anybody? :)

Stuart.

-- 
Stuart Ballard, Senior Web Developer
FASTNET - Web Solutions
(215) 283-2300, ext. 126
www.fast.net

--------------040202050501000506090103
Content-Type: text/plain;
 name="classpath.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="classpath.patch"

Index: HashMap.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/util/HashMap.java,v
retrieving revision 1.24
diff -u -r1.24 HashMap.java
--- HashMap.java	1 Aug 2003 03:31:32 -0000	1.24
+++ HashMap.java	25 Sep 2003 18:16:52 -0000
@@ -381,8 +381,7 @@
   public void putAll(Map m)
   {
     Iterator itr = m.entrySet().iterator();
-    int msize = m.size();
-    while (msize-- > 0)
+    while (itr.hasNext())
       {
         Map.Entry e = (Map.Entry) itr.next();
         // Optimize in case the Entry is one of our own.
@@ -709,10 +708,10 @@
   void putAllInternal(Map m)
   {
     Iterator itr = m.entrySet().iterator();
-    int msize = m.size();
-    size = msize;
-    while (msize-- > 0)
+    size = 0;
+    while (itr.hasNext())
       {
+        size++;
 	Map.Entry e = (Map.Entry) itr.next();
 	Object key = e.getKey();
 	int idx = hash(key);
Index: Hashtable.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/util/Hashtable.java,v
retrieving revision 1.28
diff -u -r1.28 Hashtable.java
--- Hashtable.java	7 May 2002 05:13:05 -0000	1.28
+++ Hashtable.java	25 Sep 2003 18:16:52 -0000
@@ -510,7 +510,7 @@
   {
     Iterator itr = m.entrySet().iterator();
 
-    for (int msize = m.size(); msize > 0; msize--)
+    while (itr.hasNext())
       {
         Map.Entry e = (Map.Entry) itr.next();
         // Optimize in case the Entry is one of our own.
@@ -859,11 +859,11 @@
   void putAllInternal(Map m)
   {
     Iterator itr = m.entrySet().iterator();
-    int msize = m.size();
-    this.size = msize;
+    size = 0;
 
-    for (; msize > 0; msize--)
+    while (itr.hasNext())
       {
+        size++;
 	Map.Entry e = (Map.Entry) itr.next();
 	Object key = e.getKey();
 	int idx = hash(key);

--------------040202050501000506090103--




From MAILER-DAEMON Thu Nov 06 15:09:00 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHqR9-0004V8-UW
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 15:08:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHqQr-00043p-F3
	for classpath@gnu.org; Thu, 06 Nov 2003 15:08:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHqPu-00034B-Mi
	for classpath@gnu.org; Thu, 06 Nov 2003 15:08:13 -0500
Received: from [207.219.125.105] (helo=touchme.toronto.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHqNC-0001gA-Qm
	for classpath@gnu.org; Thu, 06 Nov 2003 15:04:55 -0500
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92]) by touchme.toronto.redhat.com (Postfix) with ESMTP
	id 24C89800046; Thu,  6 Nov 2003 15:04:53 -0500 (EST)
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: GCJ Patches <java-patches@gcc.gnu.org>
Content-Type: multipart/mixed; boundary="=-Qk46w5VDh0DvSVkDFY/8"
Message-Id: <1068149092.32011.18.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Thu, 06 Nov 2003 15:04:53 -0500
Cc: classpath@gnu.org
Subject: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 20:08:55 -0000


--=-Qk46w5VDh0DvSVkDFY/8
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

This patch fixes various problems related to image loading.  It also
implements Component.imageUpdate, GtkToolkit.prepareImage and the
byte-array GtkToolkit.createImage method.

Comments?

Tom

2003-11-06  Thomas Fitzsimmons  <fitzsim@redhat.com>

	* Makefile.am: Add GdkPixbufDecoder.java and
	gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
	* Makefile.in: Regenerate.
	* gnu/java/awt/image/ImageDecoder.java (ImageDecoder(byte[],int,int)):
	New constructor.
	(startProduction): Create ByteArrayInputStream when url and filename
are
	null.
	(produce): Declare stream parameter as InputStream.
	* gnu/java/awt/image/XBMDecoder.java (produce): Declare stream
parameter
	as InputStream.
	* gnu/java/awt/peer/gtk/GdkPixbufDecoder.java
	(GdkPixbufDecoder(byte[],int,int)): New constructor.
	(produce): Declare stream parameter as InputStream.
	* gnu/java/awt/peer/gtk/GtkComponentPeer.java (prepareImage): Throw NPE
	if image is null.  Set image's observer before running PrepareImage
	thread.  Pass image to startProduction.
	* gnu/java/awt/peer/gtk/GtkImage.java: Add null checks before calls to
	source's member functions.
	(observer): New field.
	(setObserver): New method.
	(setDimensions, setPixels, imageComplete): Call observer's imageUpdate.
	* gnu/java/awt/peer/gtk/GtkToolkit.java (checkImage, getImage): Return
	new GtkImage.
	(prepareImage): Implement.
	* java/awt/Component.java (imageUpdate): Implement.
	(createImage): Call Toolkit's createImage if peer is null.
	(prepareImage): Throw NPE if image is null.
	* java/awt/MediaTracker.java: Fix return value.


--=-Qk46w5VDh0DvSVkDFY/8
Content-Disposition: attachment; filename=imageobserver2.patch
Content-Type: text/x-patch; name=imageobserver2.patch; charset=
Content-Transfer-Encoding: 7bit

Index: Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libjava/Makefile.am,v
retrieving revision 1.334
diff -u -r1.334 Makefile.am
--- Makefile.am	29 Oct 2003 16:07:58 -0000	1.334
+++ Makefile.am	6 Nov 2003 19:46:29 -0000
@@ -170,6 +170,7 @@
 gtk_c_source_files = \
 jni/gtk-peer/gnu_java_awt_peer_gtk_GdkFontMetrics.c \
 jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c \
+jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c \
 jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c \
 jni/gtk-peer/gnu_java_awt_peer_gtk_GtkCanvasPeer.c \
 jni/gtk-peer/gnu_java_awt_peer_gtk_GtkCheckboxMenuItemPeer.c \
@@ -206,6 +207,7 @@
 gtk_awt_peer_sources = \
 gnu/java/awt/peer/gtk/GdkFontMetrics.java \
 gnu/java/awt/peer/gtk/GdkGraphics.java \
+gnu/java/awt/peer/gtk/GdkPixbufDecoder.java \
 gnu/java/awt/peer/gtk/GtkArg.java \
 gnu/java/awt/peer/gtk/GtkArgList.java \
 gnu/java/awt/peer/gtk/GtkButtonPeer.java \
Index: gnu/java/awt/image/ImageDecoder.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/image/ImageDecoder.java,v
retrieving revision 1.1
diff -u -r1.1 ImageDecoder.java
--- gnu/java/awt/image/ImageDecoder.java	9 Aug 2002 04:32:43 -0000	1.1
+++ gnu/java/awt/image/ImageDecoder.java	6 Nov 2003 19:46:31 -0000
@@ -48,6 +48,10 @@
   Vector consumers = new Vector ();
   String filename;
   URL url;
+  byte[] data;
+  int offset;
+  int length;
+  InputStream input;
 
   public static ColorModel cm;
 
@@ -69,6 +73,13 @@
     this.url = url;
   }
 
+  public ImageDecoder (byte[] imagedata, int imageoffset, int imagelength)
+  {
+    data = imagedata;
+    offset = imageoffset;
+    length = imagelength;
+  }
+
   public void addConsumer (ImageConsumer ic) 
   {
     consumers.addElement (ic);
@@ -90,11 +101,22 @@
     Vector list = (Vector) consumers.clone ();
     try 
       {
-	FileInputStream is = (url == null) ? new FileInputStream (filename) :
-	                                  (FileInputStream) url.openStream();
-						  
-	produce (list, is);
-      } 
+	// Create the input stream here rather than in the
+	// ImageDecoder constructors so that exceptions cause
+	// imageComplete to be called with an appropriate error
+	// status.
+	if (url != null)
+	  input = url.openStream();
+	else
+	  {
+	    if (filename != null)
+	      input = new FileInputStream (filename);
+	    else
+	      input = new ByteArrayInputStream (data, offset, length);
+	  }
+
+	produce (list, input);
+      }
     catch (Exception e)
       {
 	for (int i = 0; i < list.size (); i++)
@@ -109,5 +131,5 @@
   { 
   }
 
-  abstract void produce (Vector v, FileInputStream is) throws IOException;
+  abstract void produce (Vector v, InputStream is) throws IOException;
 }
Index: gnu/java/awt/image/XBMDecoder.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/image/XBMDecoder.java,v
retrieving revision 1.1
diff -u -r1.1 XBMDecoder.java
--- gnu/java/awt/image/XBMDecoder.java	9 Aug 2002 04:32:43 -0000	1.1
+++ gnu/java/awt/image/XBMDecoder.java	6 Nov 2003 19:46:31 -0000
@@ -62,7 +62,7 @@
     super (url);
   }
 
-  public void produce (Vector v, FileInputStream is) throws IOException
+  public void produce (Vector v, InputStream is) throws IOException
   {
     reader = new BufferedReader (new InputStreamReader (is));
     int width = -1, height = -1;
Index: gnu/java/awt/peer/gtk/GdkPixbufDecoder.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GdkPixbufDecoder.java,v
retrieving revision 1.1
diff -u -r1.1 GdkPixbufDecoder.java
--- gnu/java/awt/peer/gtk/GdkPixbufDecoder.java	17 Sep 2003 20:03:02 -0000	1.1
+++ gnu/java/awt/peer/gtk/GdkPixbufDecoder.java	6 Nov 2003 19:46:31 -0000
@@ -39,8 +39,7 @@
 package gnu.java.awt.peer.gtk;
 
 import java.awt.image.*;
-import java.io.FileDescriptor;
-import java.io.FileInputStream;
+import java.io.InputStream;
 import java.io.IOException;
 import java.net.URL;
 import java.util.Vector;
@@ -85,6 +84,12 @@
     initState ();
   }
 
+  public GdkPixbufDecoder (byte[] imagedata, int imageoffset, int imagelength)
+  {
+    super (imagedata, imageoffset, imagelength);
+    initState ();
+  }
+
   // called back by native side
   void areaPrepared (int width, int height)
   {
@@ -122,7 +127,7 @@
   // this object, feeding back decoded pixel blocks, which we pass to each
   // of the ImageConsumers in the provided Vector.
 
-  void produce (Vector v, FileInputStream is) throws IOException
+  void produce (Vector v, InputStream is) throws IOException
   {
     curr = v;
 
Index: gnu/java/awt/peer/gtk/GtkComponentPeer.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkComponentPeer.java,v
retrieving revision 1.7
diff -u -r1.7 GtkComponentPeer.java
--- gnu/java/awt/peer/gtk/GtkComponentPeer.java	8 Oct 2003 23:38:44 -0000	1.7
+++ gnu/java/awt/peer/gtk/GtkComponentPeer.java	6 Nov 2003 19:46:31 -0000
@@ -230,6 +230,9 @@
   public boolean prepareImage (Image image, int width, int height,
 			       ImageObserver observer) 
   {
+    if (image == null)
+      throw new NullPointerException ();
+
     GtkImage i = (GtkImage) image;
 
     if (i.isLoaded ()) return true;
@@ -242,13 +245,12 @@
       PrepareImage (GtkImage image, ImageObserver observer)
       {
 	this.image = image;
-	this.observer = observer;
+	image.setObserver (observer);
       }
       
       public void run ()
       {
-	// XXX: need to return data to image observer
-	image.source.startProduction (null);
+	image.source.startProduction (image);
       }
     }
 
Index: gnu/java/awt/peer/gtk/GtkImage.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkImage.java,v
retrieving revision 1.2
diff -u -r1.2 GtkImage.java
--- gnu/java/awt/peer/gtk/GtkImage.java	13 Jul 2003 15:09:20 -0000	1.2
+++ gnu/java/awt/peer/gtk/GtkImage.java	6 Nov 2003 19:46:31 -0000
@@ -60,6 +60,7 @@
   Vector propertyObservers = new Vector ();
 
   ImageProducer source;
+  ImageObserver observer;
   Graphics g;
 
   /* Variables in which we stored cached data, if possible.
@@ -79,9 +80,15 @@
     source = producer;
     this.g = g;
 
-    source.addConsumer (this);
+    if (source != null)
+      source.addConsumer (this);
   }
-  
+
+  public void setObserver (ImageObserver observer)
+  {
+    this.observer = observer;
+  }
+
   public synchronized int 
   getWidth (ImageObserver observer)
   {
@@ -135,8 +142,11 @@
     pixelCache = null;
     model = null;
 
-    source.removeConsumer (this);
-    source.addConsumer (this);
+    if (source != null)
+      {
+	source.removeConsumer (this);
+	source.addConsumer (this);
+      }
   }
 
   public boolean
@@ -166,6 +176,12 @@
 	ImageObserver io = (ImageObserver) heightObservers.elementAt (i);
 	io.imageUpdate (this, ImageObserver.HEIGHT, -1, -1, width, height);
       }
+
+    if (observer != null)
+      observer.imageUpdate (this,
+			    (ImageObserver.WIDTH
+			     | ImageObserver.HEIGHT),
+			    -1, -1, width, height);
   }
 
   public synchronized void 
@@ -200,6 +216,11 @@
   {
     setPixels (x, y, width, height, cm, convertPixels (pixels), offset,
 	       scansize);
+
+    if (observer != null)
+      observer.imageUpdate (this,
+			    ImageObserver.SOMEBITS,
+			    x, y, width, height);
   }
 
   public synchronized void 
@@ -241,7 +262,20 @@
     if (status == ImageConsumer.SINGLEFRAMEDONE)
       isCacheable = false;
 
-    source.removeConsumer (this);
+    if (observer != null)
+      {
+	if (status == ImageConsumer.IMAGEERROR)
+	  observer.imageUpdate (null,
+				ImageObserver.ERROR,
+				-1, -1, -1, -1);
+	else
+	  observer.imageUpdate (null,
+				ImageObserver.ALLBITS,
+				-1, -1, -1, -1);
+      }
+
+    if (source != null)
+      source.removeConsumer (this);
   }
 
   public synchronized void
@@ -254,8 +288,11 @@
       }
     else
       {
-	source.startProduction (painter);
-	source.removeConsumer (painter);
+	if (source != null)
+	  {
+	    source.startProduction (painter);
+	    source.removeConsumer (painter);
+	  }
       }
   }
 
Index: gnu/java/awt/peer/gtk/GtkToolkit.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkToolkit.java,v
retrieving revision 1.3
diff -u -r1.3 GtkToolkit.java
--- gnu/java/awt/peer/gtk/GtkToolkit.java	27 Jul 2003 19:04:42 -0000	1.3
+++ gnu/java/awt/peer/gtk/GtkToolkit.java	6 Nov 2003 19:46:31 -0000
@@ -56,6 +56,7 @@
 import gnu.java.awt.EmbeddedWindowSupport;
 import gnu.java.awt.peer.EmbeddedWindowPeer;
 import gnu.classpath.Configuration;
+import gnu.java.awt.peer.gtk.GdkPixbufDecoder;
 
 /* This class uses a deprecated method java.awt.peer.ComponentPeer.getPeer().
    This merits comment.  We are basically calling Sun's bluff on this one.
@@ -91,24 +92,17 @@
   public int checkImage (Image image, int width, int height, 
 			 ImageObserver observer) 
   {
-    return ImageObserver.ALLBITS;
-
-//      GtkImage i = (GtkImage) image;
-//      return i.checkImage ();
+    return ((GtkImage) image).checkImage ();
   }
 
   public Image createImage (String filename)
   {
-    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
-    // return new GtkImage (new GdkPixbufDecoder (filename), null);
-    return null;
+    return new GtkImage (new GdkPixbufDecoder (filename), null);
   }
 
   public Image createImage (URL url)
   {
-    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
-    // return new GtkImage (new GdkPixbufDecoder (url), null);
-    return null;
+    return new GtkImage (new GdkPixbufDecoder (url), null);
   }
 
   public Image createImage (ImageProducer producer) 
@@ -117,10 +111,12 @@
   }
 
   public Image createImage (byte[] imagedata, int imageoffset,
-			    int imagelength) 
+			    int imagelength)
   {
-    // System.out.println ("createImage byte[] NOT SUPPORTED");
-    return null;
+    return new GtkImage (new GdkPixbufDecoder (imagedata,
+					       imageoffset,
+					       imagelength),
+			 null);
   }
 
   public ColorModel getColorModel () 
@@ -144,16 +140,12 @@
 
   public Image getImage (String filename) 
   {
-    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
-    // return new GtkImage (new GdkPixbufDecoder (filename), null);
-    return null;
+    return new GtkImage (new GdkPixbufDecoder (filename), null);
   }
 
   public Image getImage (URL url) 
   {
-    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
-    // return new GtkImage (new GdkPixbufDecoder (url), null);
-    return null;
+    return new GtkImage (new GdkPixbufDecoder (url), null);
   }
 
   public PrintJob getPrintJob (Frame frame, String jobtitle, Properties props) 
@@ -177,6 +169,31 @@
   public boolean prepareImage (Image image, int width, int height, 
 			       ImageObserver observer) 
   {
+    if (image == null)
+      throw new NullPointerException ();
+
+    GtkImage i = (GtkImage) image;
+
+    if (i.isLoaded ()) return true;
+
+    class PrepareImage extends Thread
+    {
+      GtkImage image;
+      ImageObserver observer;
+
+      PrepareImage (GtkImage image, ImageObserver observer)
+      {
+	this.image = image;
+	image.setObserver (observer);
+      }
+      
+      public void run ()
+      {
+	image.source.startProduction (image);
+      }
+    }
+
+    new PrepareImage (i, observer).start ();
     return false;
   }
 
Index: java/awt/Component.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Component.java,v
retrieving revision 1.29
diff -u -r1.29 Component.java
--- java/awt/Component.java	20 Sep 2003 21:30:39 -0000	1.29
+++ java/awt/Component.java	6 Nov 2003 19:46:31 -0000
@@ -1842,8 +1842,27 @@
    */
   public boolean imageUpdate(Image img, int flags, int x, int y, int w, int h)
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    boolean incrementalDraw = Boolean.getBoolean ("awt.image.incrementalDraw");
+    Long redrawRate = Long.getLong ("awt.image.redrawrate");
+
+    if ((flags & (FRAMEBITS|ALLBITS)) != 0)
+      repaint ();
+    else if ((flags & SOMEBITS) != 0)
+      {
+	if (incrementalDraw)
+	  {
+	    if (redrawRate != null)
+	      {
+		long tm = redrawRate.longValue();
+		if (tm < 0)
+		  tm = 0;
+		repaint (tm);
+	      }
+	    else
+	      repaint (100);
+	  }
+      }
+    return (flags & (ALLBITS|ABORT|ERROR)) == 0;
   }
 
   /**
@@ -1854,8 +1873,11 @@
    */
   public Image createImage(ImageProducer producer)
   {
-    // XXX What if peer or producer is null?
-    return peer.createImage(producer);
+    // Sun allows producer to be null.
+    if (peer != null)
+      return peer.createImage(producer);
+    else
+      return getToolkit().createImage(producer);
   }
 
   /**
@@ -1930,6 +1952,9 @@
    */
   public boolean prepareImage(Image image, ImageObserver observer)
   {
+    if (image == null)
+      throw new NullPointerException ();
+
     return prepareImage(image, image.getWidth(observer),
                         image.getHeight(observer), observer);
   }
Index: java/awt/MediaTracker.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/MediaTracker.java,v
retrieving revision 1.4
diff -u -r1.4 MediaTracker.java
--- java/awt/MediaTracker.java	25 Jul 2003 12:50:44 -0000	1.4
+++ java/awt/MediaTracker.java	6 Nov 2003 19:46:31 -0000
@@ -88,8 +88,8 @@
       {
 	MediaTracker.this.notifyAll();
       }
-      
-      return ((status & COMPLETE) != 0);
+      // If status is not COMPLETE then we need more updates.
+      return (status & COMPLETE) == 0;
     }
   }
 

--=-Qk46w5VDh0DvSVkDFY/8--




From MAILER-DAEMON Thu Nov 06 18:21:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHtRV-0007uv-Ez
	for mharc-classpath@gnu.org; Thu, 06 Nov 2003 18:21:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHtRK-0007X4-JH
	for classpath@gnu.org; Thu, 06 Nov 2003 18:21:22 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHtQY-0005fq-Qc
	for classpath@gnu.org; Thu, 06 Nov 2003 18:21:06 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHtQS-0005fF-M1
	for classpath@gnu.org; Thu, 06 Nov 2003 18:20:28 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP id 0076260C51
	for <classpath@gnu.org>; Thu,  6 Nov 2003 23:20:27 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 97674-05 for <classpath@gnu.org>;
	Thu,  6 Nov 2003 23:20:26 +0000 (GMT)
Received: from reali.dnsalias.net (adsl-212-41-77-140.solnet.ch
	[212.41.77.140])
	by mail01.solnet.ch (Postfix) with ESMTP id D568B60C46
	for <classpath@gnu.org>; Thu,  6 Nov 2003 23:20:25 +0000 (GMT)
Received: from pcprr
	(192-168-001-003-at-home-your-network.privateiprange.solnet.ch
	[192.168.1.3])
	by reali.dnsalias.net (Postfix) with SMTP id 5832F3BD8C
	for <classpath@gnu.org>; Fri,  7 Nov 2003 00:11:05 +0100 (CET)
Message-ID: <002201c3a4bc$ac774390$0301a8c0@pcprr>
From: "Patrik Reali" <reali@acm.org>
To: <classpath@gnu.org>
Date: Fri, 7 Nov 2003 00:21:14 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Virus-Scanned: by SolNet
Subject: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 23:21:29 -0000

Hi!

Has anybody already tried to import classpath under Eclipse? I tried to
create a project and import the files, but then Eclipse is far too
intelligent:
* gnu/java/lang classes are imported into package java.lang
* vm/reference/java/lang classes are imported into package vm.java.lang

Probably I'm just doing something wrong.... (I'm using Eclipse 3.0M4)

Thanks,
  Patrik
-----------
Patrik Reali
http://www.reali.ch/




From MAILER-DAEMON Fri Nov 07 00:02:50 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AHyla-000375-AC
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 00:02:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AHylI-0002aG-Ar
	for classpath@gnu.org; Fri, 07 Nov 2003 00:02:20 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AHykF-0000VA-2f
	for classpath@gnu.org; Fri, 07 Nov 2003 00:01:47 -0500
Received: from [24.25.9.102] (helo=ms-smtp-03-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AHykA-0000Lz-Jr
	for classpath@gnu.org; Fri, 07 Nov 2003 00:01:10 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-03-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hA750uZO021169; Fri, 7 Nov 2003 00:00:56 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id 77098BE641; Thu,  6 Nov 2003 23:49:11 -0500 (EST)
Sender: cbj@haphazard.org
To: Patrik Reali <reali@acm.org>
References: <002201c3a4bc$ac774390$0301a8c0@pcprr>
From: Brian Jones <cbj@gnu.org>
Date: 06 Nov 2003 23:49:11 -0500
In-Reply-To: <002201c3a4bc$ac774390$0301a8c0@pcprr>
Message-ID: <m31xskn5q0.fsf@lyta.haphazard.org>
Lines: 18
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 05:02:36 -0000

Patrik Reali <reali@acm.org> writes:

> Hi!
> 
> Has anybody already tried to import classpath under Eclipse? I tried to
> create a project and import the files, but then Eclipse is far too
> intelligent:
> * gnu/java/lang classes are imported into package java.lang
> * vm/reference/java/lang classes are imported into package vm.java.lang
> 
> Probably I'm just doing something wrong.... (I'm using Eclipse 3.0M4)

Never tried it.  Most IDEs do not expect people to try to work on core
java, especially not a "different" core java.

Brian
-- 
Brian Jones <cbj@gnu.org>



From MAILER-DAEMON Fri Nov 07 05:09:07 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AI3YA-0008LR-BW
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 05:09:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AI3Y7-0008Hv-LI
	for classpath@gnu.org; Fri, 07 Nov 2003 05:09:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AI3XA-0007lt-7L
	for classpath@gnu.org; Fri, 07 Nov 2003 05:08:35 -0500
Received: from [212.227.126.183] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AI3W7-0007M7-Vn
	for classpath@gnu.org; Fri, 07 Nov 2003 05:07:00 -0500
Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1AI3W5-0001uI-00; Fri, 07 Nov 2003 11:06:57 +0100
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1AI3W5-000869-00; Fri, 07 Nov 2003 11:06:57 +0100
Message-ID: <3FAB6EC0.2010908@aicas.com>
Date: Fri, 07 Nov 2003 11:06:56 +0100
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stuart Ballard <stuart.ballard@corp.fast.net>
References: <NFBBKALFDCPFIDBNKAPCEEENDIAA.dholmes@dltech.com.au>	<3F8E9012.9060706@byu.net>
	<3F969B4A.3030701@corp.fast.net>	<3F9D4969.7050106@corp.fast.net>
	<3FAA7918.2080609@corp.fast.net>
In-Reply-To: <3FAA7918.2080609@corp.fast.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath <classpath@gnu.org>
Subject: Re: [really patch] Re: HashMap putAll/putAllInternal bug
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 10:09:04 -0000

Hi Stuart,

I have commited your patch:

2003-11-07  Stuart Ballard <stuart.ballard@corp.fast.net>

	* java/util/HashMap.java (putAll): Use Iterator hasNext() method.
	(putAllInternal): Likewise.
	* java/util/Hashtable.java (putAll): Use Iterator hasNext() method.
	(putAllInternal): Likewise.

Ingo



Stuart Ballard wrote:
> Stuart Ballard wrote:
> 
>> Nobody spoke up, so could someone apply the patch (attached)?
> 
> 
> Anybody? :)
> 
> Stuart.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: HashMap.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/java/util/HashMap.java,v
> retrieving revision 1.24
> diff -u -r1.24 HashMap.java
> --- HashMap.java	1 Aug 2003 03:31:32 -0000	1.24
> +++ HashMap.java	25 Sep 2003 18:16:52 -0000
> @@ -381,8 +381,7 @@
>    public void putAll(Map m)
>    {
>      Iterator itr = m.entrySet().iterator();
> -    int msize = m.size();
> -    while (msize-- > 0)
> +    while (itr.hasNext())
>        {
>          Map.Entry e = (Map.Entry) itr.next();
>          // Optimize in case the Entry is one of our own.
> @@ -709,10 +708,10 @@
>    void putAllInternal(Map m)
>    {
>      Iterator itr = m.entrySet().iterator();
> -    int msize = m.size();
> -    size = msize;
> -    while (msize-- > 0)
> +    size = 0;
> +    while (itr.hasNext())
>        {
> +        size++;
>  	Map.Entry e = (Map.Entry) itr.next();
>  	Object key = e.getKey();
>  	int idx = hash(key);
> Index: Hashtable.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/java/util/Hashtable.java,v
> retrieving revision 1.28
> diff -u -r1.28 Hashtable.java
> --- Hashtable.java	7 May 2002 05:13:05 -0000	1.28
> +++ Hashtable.java	25 Sep 2003 18:16:52 -0000
> @@ -510,7 +510,7 @@
>    {
>      Iterator itr = m.entrySet().iterator();
>  
> -    for (int msize = m.size(); msize > 0; msize--)
> +    while (itr.hasNext())
>        {
>          Map.Entry e = (Map.Entry) itr.next();
>          // Optimize in case the Entry is one of our own.
> @@ -859,11 +859,11 @@
>    void putAllInternal(Map m)
>    {
>      Iterator itr = m.entrySet().iterator();
> -    int msize = m.size();
> -    this.size = msize;
> +    size = 0;
>  
> -    for (; msize > 0; msize--)
> +    while (itr.hasNext())
>        {
> +        size++;
>  	Map.Entry e = (Map.Entry) itr.next();
>  	Object key = e.getKey();
>  	int idx = hash(key);
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath




From MAILER-DAEMON Fri Nov 07 06:36:33 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AI4ul-0000B0-DS
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 06:36:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AI4ug-000098-Mh
	for classpath@gnu.org; Fri, 07 Nov 2003 06:36:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AI4u6-0008Ri-GO
	for classpath@gnu.org; Fri, 07 Nov 2003 06:36:21 -0500
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AI4u2-0008QC-55
	for classpath@gnu.org; Fri, 07 Nov 2003 06:35:46 -0500
Received: from tangency.co.uk (localhost [127.0.0.1])
	by outgoing.tangency.co.uk (Postfix) with ESMTP id B2F69606AD
	for <classpath@gnu.org>; Fri,  7 Nov 2003 11:34:49 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by tangency.co.uk (MailMonitor for SMTP v1.2.2 ) ;
	Fri, 7 Nov 2003 11:34:49 +0000 (GMT)
Received: from wraith (wraith.tangency.co.uk [192.168.1.4])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by tangency.co.uk (Postfix) with ESMTP id 37C0D606AD
	for <classpath@gnu.org>; Fri,  7 Nov 2003 11:34:49 +0000 (GMT)
To: classpath@gnu.org
References: <002201c3a4bc$ac774390$0301a8c0@pcprr>
	<m31xskn5q0.fsf@lyta.haphazard.org>
Message-ID: <oprx9mhxnjreuyrv@tangency.co.uk>
From: "S. Meslin-Weber" <twiun@adorphuye.com>
Content-Type: text/plain; format=flowed; charset=iso-8859-15
MIME-Version: 1.0
Date: Fri, 07 Nov 2003 11:35:47 -0000
In-Reply-To: <m31xskn5q0.fsf@lyta.haphazard.org>
User-Agent: Opera7.21/Win32 M2 build 3218
Content-Transfer-Encoding: quoted-printable
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 11:36:29 -0000

>> Has anybody already tried to import classpath under Eclipse? I tried t=
o
>> create a project and import the files, but then Eclipse is far too
>> intelligent:
>> * gnu/java/lang classes are imported into package java.lang
>> * vm/reference/java/lang classes are imported into package vm.java.lan=
g
>>
>> Probably I'm just doing something wrong.... (I'm using Eclipse 3.0M4)
>
> Never tried it.  Most IDEs do not expect people to try to work on core
> java, especially not a "different" core java.

Even so, there's nothing stopping you from configuring Eclipse to do so.
The main areas you will need to configure are:

- project properties -> Java Build Class Path -> Source
Remove the autodetected source paths and add the project root as one.

- Run -> Run As -> New Application (make sure you have your test app's=20
main class open in the editor)
gives you options to override the bootclasspath and other sundry items.

I develop fbAWT under Eclipse 3.0M4 without problem. I use classpath's
java.awt.Font* classes as they don't initialise native libs ;)

Cheers,

Stephane




From MAILER-DAEMON Fri Nov 07 07:19:39 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AI5aU-00083b-Q9
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 07:19:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AI5aP-00082Y-Uc
	for classpath@gnu.org; Fri, 07 Nov 2003 07:19:33 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AI5Zt-0007yN-7L
	for classpath@gnu.org; Fri, 07 Nov 2003 07:19:32 -0500
Received: from [32.97.182.104] (helo=e4.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AI5S5-0006na-BZ
	for classpath@gnu.org; Fri, 07 Nov 2003 07:10:57 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e4.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id hA7CAthn224732
	for <classpath@gnu.org>; Fri, 7 Nov 2003 07:10:55 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hA7CAsxS075318
	for <classpath@gnu.org>; Fri, 7 Nov 2003 07:10:54 -0500
In-Reply-To: <oprx9mhxnjreuyrv@tangency.co.uk>
To: classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OF7EEB4C1E.36B4DB56-ON85256DD7.0041A4BC-85256DD7.0042E682@us.ibm.com>
Date: Fri, 7 Nov 2003 07:10:51 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/07/2003 07:10:54,
	Serialize complete at 11/07/2003 07:10:54
Content-Type: multipart/alternative;
	boundary="=_alternative 004264E685256DD7_="
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 12:19:34 -0000

This is a multipart message in MIME format.
--=_alternative 004264E685256DD7_=
Content-Type: text/plain; charset="US-ASCII"

Julian Dolby knows more about this (maybe he will jump in), but when you 
run eclipse on Jikes RVM we've written a plugin such that the classpath 
libraries are not only used by eclipse, but are also used by the 
applications you develop in eclipse (and Jikes RVM is used to execute 
them).

So, you can edit, build, compile, and run your Java code in Eclipse 
without needing any other JVM at all.

One downside is that we haven't implemented JDWP in Jikes RVM yet, so you 
can't use the Eclipse debugger  in this mode, but we all write bug free 
programs the first time, right ;-)

We also have mainly been testing this on the 2.x versions of eclipse.  I'm 
pretty sure we have a little work to do to get the current Eclipse 
milestone builds to work on Jikes RVM. 

--dave
--=_alternative 004264E685256DD7_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Julian Dolby knows more about this (maybe
he will jump in), but when you run eclipse on Jikes RVM we've written a
plugin such that the classpath libraries are not only used by eclipse,
but are also used by the applications you develop in eclipse (and Jikes
RVM is used to execute them).</font>
<br>
<br><font size=2 face="sans-serif">So, you can edit, build, compile, and
run your Java code in Eclipse without needing any other JVM at all.</font>
<br>
<br><font size=2 face="sans-serif">One downside is that we haven't implemented
JDWP in Jikes RVM yet, so you can't use the Eclipse debugger &nbsp;in this
mode, but we all write bug free programs the first time, right ;-)</font>
<br>
<br><font size=2 face="sans-serif">We also have mainly been testing this
on the 2.x versions of eclipse. &nbsp;I'm pretty sure we have a little
work to do to get the current Eclipse milestone builds to work on Jikes
RVM. </font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 004264E685256DD7_=--



From MAILER-DAEMON Fri Nov 07 10:14:00 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AI89n-0004bL-Jl
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 10:04:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AI89Y-00045d-HS
	for classpath@gnu.org; Fri, 07 Nov 2003 10:04:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AI87N-0001jk-84
	for classpath@gnu.org; Fri, 07 Nov 2003 10:02:18 -0500
Received: from [209.92.1.32] (helo=newmx2.fast.net)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AI86c-0001G9-VE
	for classpath@gnu.org; Fri, 07 Nov 2003 10:00:59 -0500
Received: (qmail 1070 invoked from network); 7 Nov 2003 15:00:55 -0000
Received: from unknown (HELO corp.fast.net) ([209.152.221.64])
	(envelope-sender <stuart.ballard@corp.fast.net>)
	by newmx2.fast.net (qmail-ldap-1.03) with SMTP
	for <proetel@aicas.com>; 7 Nov 2003 15:00:55 -0000
Message-ID: <3FABB3A6.9090409@corp.fast.net>
Date: Fri, 07 Nov 2003 10:00:54 -0500
From: Stuart Ballard <stuart.ballard@corp.fast.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031024 Debian/1.5-2
X-Accept-Language: en
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
References: <NFBBKALFDCPFIDBNKAPCEEENDIAA.dholmes@dltech.com.au>	<3F8E9012.9060706@byu.net>
	<3F969B4A.3030701@corp.fast.net>	<3F9D4969.7050106@corp.fast.net>
	<3FAA7918.2080609@corp.fast.net> <3FAB6EC0.2010908@aicas.com>
In-Reply-To: <3FAB6EC0.2010908@aicas.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Cc: classpath <classpath@gnu.org>
Subject: Re: [really patch] Re: HashMap putAll/putAllInternal bug
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 15:04:05 -0000

Ingo Pr=F6tel wrote:
> Hi Stuart,
>=20
> I have commited your patch:
>=20
> 2003-11-07  Stuart Ballard <stuart.ballard@corp.fast.net>
>=20
>     * java/util/HashMap.java (putAll): Use Iterator hasNext() method.
>     (putAllInternal): Likewise.
>     * java/util/Hashtable.java (putAll): Use Iterator hasNext() method.=

>     (putAllInternal): Likewise.

Thanks!

Stuart.

--=20
Stuart Ballard, Senior Web Developer
FASTNET - Web Solutions
(215) 283-2300, ext. 126
www.fast.net




From MAILER-DAEMON Fri Nov 07 15:53:31 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIDbn-0005y1-Fw
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 15:53:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIDbl-0005xg-0h
	for classpath@gnu.org; Fri, 07 Nov 2003 15:53:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIDbE-0005qZ-Pz
	for classpath@gnu.org; Fri, 07 Nov 2003 15:53:27 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIDbD-0005pL-65
	for classpath@gnu.org; Fri, 07 Nov 2003 15:52:55 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA02802;
	Fri, 7 Nov 2003 12:51:10 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id D113F4F82B7; Fri,  7 Nov 2003 12:42:40 -0700 (MST)
To: David P Grove <groved@us.ibm.com>
References: <OF7EEB4C1E.36B4DB56-ON85256DD7.0041A4BC-85256DD7.0042E682@us.ibm.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: What I want to find out is -- do parrots know much about Astro-Turf?
Date: 07 Nov 2003 12:42:40 -0700
In-Reply-To: <OF7EEB4C1E.36B4DB56-ON85256DD7.0041A4BC-85256DD7.0042E682@us.ibm.com>
Message-ID: <874qxgvubz.fsf@fleche.redhat.com>
Lines: 10
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 20:53:29 -0000

>>>>> "David" == David P Grove <groved@us.ibm.com> writes:

David> One downside is that we haven't implemented JDWP in Jikes RVM
David> yet, so you can't use the Eclipse debugger in this mode, but we
David> all write bug free programs the first time, right ;-)

This is a problem for gcj-eclipse, too.  Does any free VM implement
JDWP?

Tom



From MAILER-DAEMON Fri Nov 07 15:58:13 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIDgL-0006fj-5E
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 15:58:13 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIDgH-0006ek-69
	for classpath@gnu.org; Fri, 07 Nov 2003 15:58:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIDfk-0006YL-8f
	for classpath@gnu.org; Fri, 07 Nov 2003 15:58:08 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIDfj-0006Xw-Lz
	for classpath@gnu.org; Fri, 07 Nov 2003 15:57:35 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA04350;
	Fri, 7 Nov 2003 12:56:10 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 1E0B34F82B7; Fri,  7 Nov 2003 12:47:40 -0700 (MST)
To: Andrew Haley <aph@redhat.com>
References: <3FAA5D36.20405@uqam.ca>
	<OF2F442ECD.F17919B9-ON85256DD6.00526C32-85256DD6.005561B7@us.ibm.com>
	<16298.27579.353696.801616@cuddles.cambridge.redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: It's hard being an ARTIST!!
Date: 07 Nov 2003 12:47:40 -0700
In-Reply-To: <16298.27579.353696.801616@cuddles.cambridge.redhat.com>
Message-ID: <87vfpwufj7.fsf@fleche.redhat.com>
Lines: 19
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library
	names	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 20:58:11 -0000

David> I don't think there is an easy solution to this as it is unlikely
David> that a single VMInterface will fit the needs of all VMs perfectly.
David> In some cases (java.lang.ref.* for example), I don't think that it
David> is reasonable for classpath to try to provide an implementation
David> that will actually work unchanged on all VMs.

Andrew> Exactly.  Classpath should provide a reference implementation,
Andrew> we but shouldn't expect every core class to be used unchanged.

I agree.  I think it is reasonable to expect libgcj to diverge from
classpath in some places -- there are areas where libgcj's needs
aren't the same as the needs of other VMs.  But at the same time, I'd
expect VMs that are unusual in other ways (e.g., IKVM or JikesRVM,
both "different" in one way or another) to also occasionally have
their own divergence.  Or, to put it another way, let's distribute
some of the divergence; it can't all rest on libgcj.  (Which I doubt
anyone is proposing anyway.)

Tom



From MAILER-DAEMON Fri Nov 07 16:03:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIDlk-0007vE-Tp
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 16:03:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIDcj-0006CM-Lm
	for classpath@gnu.org; Fri, 07 Nov 2003 15:54:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIDcD-00063x-Ip
	for classpath@gnu.org; Fri, 07 Nov 2003 15:54:27 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIDcC-00063Z-TI
	for classpath@gnu.org; Fri, 07 Nov 2003 15:53:57 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA03248;
	Fri, 7 Nov 2003 12:52:30 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 1D4984F82B7; Fri,  7 Nov 2003 12:44:01 -0700 (MST)
To: "Patrik Reali" <reali@acm.org>
References: <002201c3a4bc$ac774390$0301a8c0@pcprr>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I don't believe there really IS a GAS SHORTAGE..  I think it's all
	just a BIG HOAX on the part of the plastic sign salesmen--
	..  to sell more numbers!!
Date: 07 Nov 2003 12:44:01 -0700
In-Reply-To: <002201c3a4bc$ac774390$0301a8c0@pcprr>
Message-ID: <87znf8ufpa.fsf@fleche.redhat.com>
Lines: 9
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 21:03:47 -0000

>>>>> "Patrik" == Patrik Reali <reali@acm.org> writes:

Patrik> Has anybody already tried to import classpath under Eclipse?

FWIW, I wouldn't object to someone checking in an eclipse .project
file (and other stuff) into classpath, provided it didn't rely on
anything site-specific.

Tom



From MAILER-DAEMON Fri Nov 07 16:11:11 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIDss-0001Pt-13
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 16:11:10 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIDso-0001OW-Ap
	for classpath@gnu.org; Fri, 07 Nov 2003 16:11:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIDsH-0001DG-KN
	for classpath@gnu.org; Fri, 07 Nov 2003 16:11:04 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIDsG-0001CW-OQ
	for classpath@gnu.org; Fri, 07 Nov 2003 16:10:32 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id NAA08490;
	Fri, 7 Nov 2003 13:09:03 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id EC3C34F82B7; Fri,  7 Nov 2003 13:00:33 -0700 (MST)
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <1068149092.32011.18.camel@tortoise.toronto.redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Everybody is going somewhere!!  It's probably a garage sale
	or a disaster Movie!!
Date: 07 Nov 2003 13:00:33 -0700
In-Reply-To: <1068149092.32011.18.camel@tortoise.toronto.redhat.com>
Message-ID: <87r80kuexq.fsf@fleche.redhat.com>
Lines: 27
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 21:11:07 -0000

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch fixes various problems related to image loading.  It also
Tom> implements Component.imageUpdate, GtkToolkit.prepareImage and the
Tom> byte-array GtkToolkit.createImage method.

Looks good.

Tom> -    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
Tom> -    // return new GtkImage (new GdkPixbufDecoder (filename), null);
Tom> -    return null;
Tom> +    return new GtkImage (new GdkPixbufDecoder (filename), null);

I don't remember why I commented out this code in libgcj, other than
what the comment says.  I assume it is ok to enable now?

Tom> +    boolean incrementalDraw = Boolean.getBoolean ("awt.image.incrementalDraw");
Tom> +    Long redrawRate = Long.getLong ("awt.image.redrawrate");

Should these be computed once, at class init time?
Or do we want to recompute them each time this method is called?

Also, I forget where and how we're documenting properties we
recognize.  I know this has come up before though.  These two should
at least be mentioned in the javadoc for the method.

Tom



From MAILER-DAEMON Fri Nov 07 16:20:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIE1f-0003yS-M1
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 16:20:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIE1Z-0003ve-6c
	for classpath@gnu.org; Fri, 07 Nov 2003 16:20:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIE0w-0003kQ-3Y
	for classpath@gnu.org; Fri, 07 Nov 2003 16:20:02 -0500
Received: from [210.86.15.147] (helo=mta204-rme.xtra.co.nz)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIDvd-0002Qr-U3
	for classpath@gnu.org; Fri, 07 Nov 2003 16:14:02 -0500
Received: from mta2-rme.xtra.co.nz ([210.86.15.143])
	by mta204-rme.xtra.co.nz with ESMTP
	id <20031107201234.ZZZA18096.mta204-rme.xtra.co.nz@mta2-rme.xtra.co.nz>;
	Sat, 8 Nov 2003 09:12:34 +1300
Received: from [192.168.1.202] ([210.86.61.75]) by mta2-rme.xtra.co.nz
	with ESMTP
	id <20031107201234.EWTT20103.mta2-rme.xtra.co.nz@[192.168.1.202]>;
	Sat, 8 Nov 2003 09:12:34 +1300
In-Reply-To: <3FA531DA.6010501@kaffe.org>
References: <3FA2A610.8010002@kaffe.org>
	<1067783743.794.44.camel@elsschot.wildebeest.org>
	<3FA531DA.6010501@kaffe.org>
Mime-Version: 1.0 (Apple Message framework v606)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <B9A6E2E3-115E-11D8-88E8-003065F97F7C@mckinlay.net.nz>
Content-Transfer-Encoding: 7bit
From: Bryce McKinlay <bryce@mckinlay.net.nz>
Date: Sat, 8 Nov 2003 09:12:34 +1300
To: Dalibor Topic <robilad@kaffe.org>
X-Mailer: Apple Mail (2.606)
Cc: Mark Wielaard <mark@klomp.org>, classpath@gnu.org
Subject: Re: java.io.DataInputStream.readLine misbehaviour
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 21:20:10 -0000

On Nov 3, 2003, at 5:33 AM, Dalibor Topic wrote:

> For what it's worth, yes, there is code out there that expects threads 
> to be able to read from readers/writers and not trip over their feet 
> ;) AFAIK, the Java APIs explicitely mention when a method/class is not 
> thread safe, so by default we should assume that APIs are to be thread 
> safe.

> I mean, it's built in the laguage, why would you want to limit 
> yourself to single threads when you're doing something as important as 
> IO?

Because, in general, IO from multiple threads makes no sense. If 
multiple threads are reading/writing the stream, the behavior is 
non-deterministic. Even if you synchronize correctly, the IO operations 
can occur in any order - there is no way to determine what data each 
thread will receive from the stream, or what the contents of the 
written stream will be.

In order to do meaningful IO from multiple threads, synchronization 
needs to be done at the application level.

We should assume that, unless otherwise stated by the spec, object 
instances do not have to be internally synchronized. Having said that, 
its clear that many of the streams classes must be synchronized by 
design (PrintStream for example), so I agree that in general 
synchronization is required for the streams classes. However this is 
not true for the Java APIs in general.  Sun long ago realised their 
mistake in using synchronization too liberally throughout the older 
class libraries, and thats why mentions of synchronization have been 
removed from the spec for many classes - a hint that developers should 
not assume they are synchronized.

Regards

Bryce.




From MAILER-DAEMON Fri Nov 07 17:21:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIEyq-0005Dd-6M
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 17:21:24 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIEyl-0005Ba-QP
	for classpath@gnu.org; Fri, 07 Nov 2003 17:21:19 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIEyE-0004vP-Ec
	for classpath@gnu.org; Fri, 07 Nov 2003 17:21:17 -0500
Received: from [32.97.182.101] (helo=e1.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AIEyD-0004uE-Tv
	for classpath@gnu.org; Fri, 07 Nov 2003 17:20:45 -0500
Received: from northrelay02.pok.ibm.com (northrelay02.pok.ibm.com
	[9.56.224.150])
	by e1.ny.us.ibm.com (8.12.10/NS PXFA) with ESMTP id hA7LJJf8483644
	for <classpath@gnu.org>; Fri, 7 Nov 2003 16:19:19 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay02.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hA7LJIh9230154
	for <classpath@gnu.org>; Fri, 7 Nov 2003 16:19:18 -0500
In-Reply-To: <87vfpwufj7.fsf@fleche.redhat.com>
To: GNU Classpath <classpath@gnu.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OF3A2B26B8.F53FBE31-ON85256DD7.006DDDE3-85256DD7.00751ABE@us.ibm.com>
Date: Fri, 7 Nov 2003 16:19:15 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/07/2003 16:19:18,
	Serialize complete at 11/07/2003 16:19:18
Content-Type: multipart/alternative;
	boundary="=_alternative 0075083185256DD7_="
Subject: Re: VMInterface addition: Make native library
	names	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 22:21:22 -0000

This is a multipart message in MIME format.
--=_alternative 0075083185256DD7_=
Content-Type: text/plain; charset="US-ASCII"

I agree.

<disclaimer: I am not a lawyer....so my grasp on the fine details of 
licensing is not to be trusted>

One issue that comes up for Jikes RVM is that because we are licensed 
under the CPL we believe it is hard for us to provide modified versions of 
classpath in a way that is easy for our users to deal with.  Because of 
this we have taken a tact of either (1) using a classpath class unchanged 
or (2) providing a complete replacement for the class.  In most cases this 
is ok, but there are some cases where we want/need to make a very small 
change to a classpath class and things get awkward for us.  In many cases, 
this can be done by adding a VMFoo class and a level of method calls.

For us, this introduces no overhead because we inline them all away.  It 
seems to me that the key question is can we construct this stuff in such a 
way that it causes no overhead for gcj as well (is there some stylized 
cross class inlining that you can do easily).  If so, then there is a 
chance to really reduce the divergences by writing much of the sensitive 
code in this fashion,  If not, then it is harder to balance the needs of 
the various VMs vs the obvious goodness of having as close to a single 
unified code base as possible.

I personally really don't like having our own copies of entire classes 
because it is harder to track changes in classpath and benefit from bug 
fixes.  So, there are places where Jikes RVM is living with very 
inefficient implementations of library functionality (almost everything 
having to do with stack inspection except java.lang.Throwable which we did 
reimplement) because in most cases the pain of diverging has been more 
important than the performance cost.

--dave






Tom Tromey <tromey@redhat.com>
11/07/2003 02:47 PM
Please respond to tromey
 
        To:     Andrew Haley <aph@redhat.com>
        cc:     David P Grove/Watson/IBM@IBMUS, GNU Classpath 
<classpath@gnu.org>
        Subject:        Re: VMInterface addition: Make native library 
names   part    ofVMInterface


David> I don't think there is an easy solution to this as it is unlikely
David> that a single VMInterface will fit the needs of all VMs perfectly.
David> In some cases (java.lang.ref.* for example), I don't think that it
David> is reasonable for classpath to try to provide an implementation
David> that will actually work unchanged on all VMs.

Andrew> Exactly.  Classpath should provide a reference implementation,
Andrew> we but shouldn't expect every core class to be used unchanged.

I agree.  I think it is reasonable to expect libgcj to diverge from
classpath in some places -- there are areas where libgcj's needs
aren't the same as the needs of other VMs.  But at the same time, I'd
expect VMs that are unusual in other ways (e.g., IKVM or JikesRVM,
both "different" in one way or another) to also occasionally have
their own divergence.  Or, to put it another way, let's distribute
some of the divergence; it can't all rest on libgcj.  (Which I doubt
anyone is proposing anyway.)

Tom


--=_alternative 0075083185256DD7_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">I agree.</font>
<br>
<br><font size=2 face="sans-serif">&lt;disclaimer: I am not a lawyer....so
my grasp on the fine details of licensing is not to be trusted&gt;</font>
<br>
<br><font size=2 face="sans-serif">One issue that comes up for Jikes RVM
is that because we are licensed under the CPL we believe it is hard for
us to provide modified versions of classpath in a way that is easy for
our users to deal with. &nbsp;Because of this we have taken a tact of either
(1) using a classpath class unchanged or (2) providing a complete replacement
for the class. &nbsp;In most cases this is ok, but there are some cases
where we want/need to make a very small change to a classpath class and
things get awkward for us. &nbsp;In many cases, this can be done by adding
a VMFoo class and a level of method calls.</font>
<br>
<br><font size=2 face="sans-serif">For us, this introduces no overhead
because we inline them all away. &nbsp;It seems to me that the key question
is can we construct this stuff in such a way that it causes no overhead
for gcj as well (is there some stylized cross class inlining that you can
do easily). &nbsp;If so, then there is a chance to really reduce the divergences
by writing much of the sensitive code in this fashion, &nbsp;If not, then
it is harder to balance the needs of the various VMs vs the obvious goodness
of having as close to a single unified code base as possible.</font>
<br>
<br><font size=2 face="sans-serif">I personally really don't like having
our own copies of entire classes because it is harder to track changes
in classpath and benefit from bug fixes. &nbsp;So, there are places where
Jikes RVM is living with very inefficient implementations of library functionality
(almost everything having to do with stack inspection except java.lang.Throwable
which we did reimplement) because in most cases the pain of diverging has
been more important than the performance cost.</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
<br>
<br>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td>
<td><font size=1 face="sans-serif"><b>Tom Tromey &lt;tromey@redhat.com&gt;</b></font>
<p><font size=1 face="sans-serif">11/07/2003 02:47 PM</font>
<br><font size=1 face="sans-serif">Please respond to tromey</font>
<td><font size=1 face="Arial">&nbsp; &nbsp; &nbsp; &nbsp; </font>
<br><font size=1 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; To:
&nbsp; &nbsp; &nbsp; &nbsp;Andrew Haley &lt;aph@redhat.com&gt;</font>
<br><font size=1 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; cc:
&nbsp; &nbsp; &nbsp; &nbsp;David P Grove/Watson/IBM@IBMUS, GNU
Classpath &lt;classpath@gnu.org&gt;</font>
<br><font size=1 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; Subject:
&nbsp; &nbsp; &nbsp; &nbsp;Re: VMInterface addition: Make native
library names &nbsp; &nbsp; &nbsp; &nbsp;part &nbsp; &nbsp; &nbsp;
&nbsp;ofVMInterface</font></table>
<br>
<br>
<br><font size=2><tt>David&gt; I don't think there is an easy solution
to this as it is unlikely<br>
David&gt; that a single VMInterface will fit the needs of all VMs perfectly.<br>
David&gt; In some cases (java.lang.ref.* for example), I don't think that
it<br>
David&gt; is reasonable for classpath to try to provide an implementation<br>
David&gt; that will actually work unchanged on all VMs.<br>
<br>
Andrew&gt; Exactly. &nbsp;Classpath should provide a reference implementation,<br>
Andrew&gt; we but shouldn't expect every core class to be used unchanged.<br>
<br>
I agree. &nbsp;I think it is reasonable to expect libgcj to diverge from<br>
classpath in some places -- there are areas where libgcj's needs<br>
aren't the same as the needs of other VMs. &nbsp;But at the same time,
I'd<br>
expect VMs that are unusual in other ways (e.g., IKVM or JikesRVM,<br>
both &quot;different&quot; in one way or another) to also occasionally
have<br>
their own divergence. &nbsp;Or, to put it another way, let's distribute<br>
some of the divergence; it can't all rest on libgcj. &nbsp;(Which I doubt<br>
anyone is proposing anyway.)<br>
<br>
Tom<br>
</tt></font>
<br>
--=_alternative 0075083185256DD7_=--



From MAILER-DAEMON Fri Nov 07 17:51:11 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIFRd-0003Rr-Sq
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 17:51:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIFRa-0003Pg-CR
	for classpath@gnu.org; Fri, 07 Nov 2003 17:51:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIFR3-00030Q-3s
	for classpath@gnu.org; Fri, 07 Nov 2003 17:51:04 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIFR2-0002zG-JS
	for classpath@gnu.org; Fri, 07 Nov 2003 17:50:32 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id C60CC60E03; Fri,  7 Nov 2003 21:49:07 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 72351-05; Fri,  7 Nov 2003 21:49:07 +0000 (GMT)
Received: from reali.dnsalias.net (adsl-212-41-77-140.solnet.ch
	[212.41.77.140]) by mail01.solnet.ch (Postfix) with ESMTP
	id 8DDF460E3D; Fri,  7 Nov 2003 21:49:05 +0000 (GMT)
Received: from pcprr
	(192-168-001-003-at-home-your-network.privateiprange.solnet.ch
	[192.168.1.3]) by reali.dnsalias.net (Postfix) with SMTP
	id 04FC632C1D; Fri,  7 Nov 2003 22:39:43 +0100 (CET)
Message-ID: <007a01c3a579$145904f0$0301a8c0@pcprr>
From: "Patrik Reali" <reali@acm.org>
To: <tromey@redhat.com>, "Andrew Haley" <aph@redhat.com>
References: <3FAA5D36.20405@uqam.ca><OF2F442ECD.F17919B9-ON85256DD6.00526C32-85256DD6.005561B7@us.ibm.com><16298.27579.353696.801616@cuddles.cambridge.redhat.com>
	<87vfpwufj7.fsf@fleche.redhat.com>
Date: Fri, 7 Nov 2003 22:49:54 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Virus-Scanned: by SolNet
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: VMInterface addition: Make native library
	names	part	ofVMInterface
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2003 22:51:07 -0000


----- Original Message -----
Tom Tromey writes:
> David> I don't think there is an easy solution to this as it is unlikely
> David> that a single VMInterface will fit the needs of all VMs perfectly.
> David> In some cases (java.lang.ref.* for example), I don't think that it
> David> is reasonable for classpath to try to provide an implementation
> David> that will actually work unchanged on all VMs.
>
> Andrew> Exactly.  Classpath should provide a reference implementation,
> Andrew> we but shouldn't expect every core class to be used unchanged.
>
> I agree.  I think it is reasonable to expect libgcj to diverge from
> classpath in some places -- there are areas where libgcj's needs
> aren't the same as the needs of other VMs.  But at the same time, I'd
> expect VMs that are unusual in other ways (e.g., IKVM or JikesRVM,
> both "different" in one way or another) to also occasionally have
> their own divergence.  Or, to put it another way, let's distribute
> some of the divergence; it can't all rest on libgcj.  (Which I doubt
> anyone is proposing anyway.)
>

I agree with you.

My approach is rather pragmatic: first, classpath should allow to quickly
develop a VM, by providing a clean design and as many features as possible
in Java.

Then, once the VM is running, everybody can choose the optimizations that
match the problem that the VM is trying to address. In practice, as soon as
one VM leaves the state of "pet project" or "proof of concept",
optimizations are unavoidable.

I'm not sure that compiler optimizations (in particular inlining and pointer
escape analysis) can handle every problem (and as I remember, they ofter
require static compilation and limit dynamic loading, a core java feature),
thus some code modification may be required to optimize the API for the VM.

Anyway, coming myself from the compiler world, you can imagine how painful
it is for me to say that native methods should forward the call to the VM*
classes (thus adding an indirection). This has for me the following
advantages:
* clear separation between the API and the VM
* regrouping the native methods into a few classes (it is simpler to find
out which methods must be implemented, and the number of stubs to create is
much smaller, which is less code to manage)

On the other hand, the VM* approach causes additional costs:
* often requires to duplicate structures to keep track of one information.
* additional indirection in each invocation

As often the case, good design and optimizations don't mix well! In case of
doubt, I always choose the good design (it fits every case) over the
optimization (it usually fits only a specific use-case).

But this is just my own opinion.

-Patrik
--------
Patrik Reali
http://www.reali.ch/~patrik/
http://www.oberon.ethz.ch/jaos






From MAILER-DAEMON Fri Nov 07 22:46:58 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIK3t-0006U6-Uj
	for mharc-classpath@gnu.org; Fri, 07 Nov 2003 22:46:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIK3r-0006Qs-0u
	for classpath@gnu.org; Fri, 07 Nov 2003 22:46:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIK3J-0006Id-B3
	for classpath@gnu.org; Fri, 07 Nov 2003 22:46:52 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIK3I-0006Gs-UO
	for classpath@gnu.org; Fri, 07 Nov 2003 22:46:21 -0500
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AIJ5r-0008Hg-00
	for <classpath@gnu.org>; Sat, 08 Nov 2003 03:44:55 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AIJ5q-0008HY-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Sat, 08 Nov 2003 03:44:54 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AIJ5q-00035u-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Sat, 08 Nov 2003 03:44:54 +0100
From: graydon hoare <graydon@redhat.com>
Date: 07 Nov 2003 21:43:38 -0500
Lines: 16
Message-ID: <87n0b74m1x.fsf@dub.venge.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Sender: news <news@sea.gmane.org>
Subject: tiny bug gnu/classpath/Configuration.java.in
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2003 03:46:55 -0000

ok to commit this?

(gtk peers don't appear at all under classpath/kissme without setting
this right)

-graydon

--- Configuration.java.in	2 Oct 2003 11:05:15 -0000	1.11
+++ Configuration.java.in	8 Nov 2003 02:37:06 -0000
@@ -109,5 +109,5 @@
   /**
    * Name of default AWT peer library.
    */
-  String default_awt_peer_toolkit = "gnu.java.awt.peer.gtk.GTKToolkit";
+  String default_awt_peer_toolkit = "gnu.java.awt.peer.gtk.GtkToolkit";
 }




From MAILER-DAEMON Sat Nov 08 00:20:53 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AILWm-0001DE-G3
	for mharc-classpath@gnu.org; Sat, 08 Nov 2003 00:20:52 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AILWX-0000eV-Ax
	for classpath@gnu.org; Sat, 08 Nov 2003 00:20:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AILVk-00089d-K2
	for classpath@gnu.org; Sat, 08 Nov 2003 00:20:19 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AILVk-00088R-1u
	for classpath@gnu.org; Sat, 08 Nov 2003 00:19:48 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id VAA05207;
	Fri, 7 Nov 2003 21:18:22 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id ED7734F83DB; Fri,  7 Nov 2003 21:09:50 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <87n0b74m1x.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Are BOTH T.V.S on??
Date: 07 Nov 2003 21:09:50 -0700
In-Reply-To: <87n0b74m1x.fsf@dub.venge.net>
Message-ID: <87he1fh569.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: tiny bug gnu/classpath/Configuration.java.in
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2003 05:20:49 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> ok to commit this?
graydon> (gtk peers don't appear at all under classpath/kissme without setting
graydon> this right)

This is an obvious fix, so it can go in under that rule.
Not that Classpath has patch review :-)

I'm surprised to see this code in Classpath though.  Last time it was
in, Mark didn't like it, and I took it out, keeping it as a gcj-local
change.

Tom



From MAILER-DAEMON Sat Nov 08 14:29:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIYle-0004WI-HF
	for mharc-classpath@gnu.org; Sat, 08 Nov 2003 14:29:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIYlb-0004Vh-Hc
	for classpath@gnu.org; Sat, 08 Nov 2003 14:29:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIYky-0004Nc-DJ
	for classpath@gnu.org; Sat, 08 Nov 2003 14:28:55 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIYiQ-0003zb-E4
	for classpath@gnu.org; Sat, 08 Nov 2003 14:25:46 -0500
Received: from mark by nescio.wildebeest.org with local (Exim 3.35 #1 (Debian))
	id 1AIXkR-0007mX-00; Sat, 08 Nov 2003 19:23:47 +0100
Date: Sat, 8 Nov 2003 19:23:47 +0100
To: Patrik Reali <reali@acm.org>
Message-ID: <20031108182346.GA29523@couperus.wildebeest.org>
References: <002201c3a4bc$ac774390$0301a8c0@pcprr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <002201c3a4bc$ac774390$0301a8c0@pcprr>
User-Agent: Mutt/1.3.28i
From: Mark Wielaard <mark@klomp.org>
Cc: classpath@gnu.org
Subject: Re: Q: Classpath and Eclipse
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2003 19:29:04 -0000

Hi,

On Fri, Nov 07, 2003 at 12:21:14AM +0100, Patrik Reali wrote:
> Has anybody already tried to import classpath under Eclipse? I tried to
> create a project and import the files, but then Eclipse is far too
> intelligent:
> * gnu/java/lang classes are imported into package java.lang
> * vm/reference/java/lang classes are imported into package vm.java.lang
> 
> Probably I'm just doing something wrong.... (I'm using Eclipse 3.0M4)

Eclipse is trying to be much to smart and it doesn't seem as flexible as
we want it to be.
Some of this might be my inexprience with using the Eclipse JDT though.

It seems to want to insist on using a multiple project layout if your
filesystem has multiple source directories that contain classes that
belong in the same package (combining java and vm/reference/java).
It has its own exclusion mechanism (you want to use the lib/standard.omit
file).
You have to remove the standard JRE libraries (since the kaffe or gcj
standard libraries are slightly different, which you will notice when
trying to compile the VMinterface classes).
We have things like gnu.classpat.Configure which is generated in the obejct
tree and doesn't live in the source tree.

It does support some Ant trickery, but I haven't gotten that to work
yet (mostly Ant being to smart and trying to call all kinds of com.sun
classes. Sigh...). Since the CDT seems to have some Makefile support we
might be able to hack on that to get the Classpath build structure working.
That has the advantage of integrating the build with our JNI C stuff.
I don't know how easy it for Eclipse to parse the error output of external
tools (like emacs can). If that is possible then we could still use our
own Makefile structure and use the standalone eclipse java compiler that
Anthony Green created for the RHUG project (he calls it ecj and it is
faster then jikes! - compiled with gcj to a native binary of course).

What I ended up doing was making an empty java project and then creating
a directory structure in it with symlinks to the java files in my classpath
source and object directory. It works and the eclipse java compiler points
out some errors/warnings that weren't showing with jikes or gcj. It is
also nice for "cleaning up" import statements. But far to slow under gij
for such a big project (but the positive news is that it does work).
We really have to get a native gcj compiled 3.0 working (just haven't tried
since I still have some troubles with the interpreted one, see the gcj
mailinglist).

More positive news: gij + Eclipse 3.0 M4 + java-gnome bindings + gnome plugin
wizard seem to work quite nicely. More info (and screenshots!) when I have
better internet access.

Cheers,

Mark



From MAILER-DAEMON Sun Nov 09 13:51:46 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIuf2-0003ON-Q9
	for mharc-classpath@gnu.org; Sun, 09 Nov 2003 13:51:44 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIuex-0003O2-VB
	for classpath@gnu.org; Sun, 09 Nov 2003 13:51:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIueR-0003Ds-5J
	for classpath@gnu.org; Sun, 09 Nov 2003 13:51:38 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIueQ-0003Do-Ou
	for classpath@gnu.org; Sun, 09 Nov 2003 13:51:06 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AItgW-0001s9-00; Sun, 09 Nov 2003 18:49:13 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AItgu-0001WJ-00; Sun, 09 Nov 2003 18:49:36 +0100
From: Mark Wielaard <mark@klomp.org>
To: java@gcc.gnu.org, classpath@gnu.org,
	java-gnome-developer@lists.sourceforge.net
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1068400172.1430.129.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 09 Nov 2003 18:49:34 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: 
Subject: I love it when a plan comes together (GCJ, Eclipse and Gnome!)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Nov 2003 18:51:40 -0000

Hi all,

After finally getting the latest Eclipse 3.0 M4 working with gij
<http://gcc.gnu.org/ml/java/2003-11/msg00024.html>
I tried to get the java-gnome bindings
<http://java-gnome.sourceforge.net/>
and the eclipse java-gnome plugin wizard
<http://zeta.zizworks.com/public/projects/java-gnome.do>
all working together.

I was pleasantly surprized that the latest 0.8 java-gnome bindings are
already packeged for Debian:

libglade0-java - Java support for libglade gnome interface
libgnome0-java - Java framework for creating GNOME applications
libgnome0-jni - Java framework for creating GNOME applications
libgtk0-java - Gtk framework for Java
libgtk0-jni - GTK framework for Java

After installing these, and unzipping the plugin in my fresh eclipse
install directory everything worked out of the box!
<http://www.klomp.org:klomp.org/mark/classpath/eclipse-gnome-gij.png>
(Almost, you do have to get gij with eclipse working as described in the
email referenced above, which is a bit of a pain currently. And the
libraries that the java-gnome plugin wizard wants are in /usr/lib/jni
and /usr/share/java on a Debian system.)

Now that we have a completely free java-like toolchain and IDE for
creating Gnome applications, nothing stands in the way of world
domination! Muhawaha!

When we have accomplished world domination I will retire and finally
resume work on the Hunting of the Snark project ;-)
<http://klomp.org/snark/snark-gnome.html>
(Note, that is an experimental frontend using the old java-gnome
bindings, will try the new version soon.)

Thanks Gnome hackers, Thanks Eclipse hackers, Thanks Classpath hackers,
Thanks Debian hackers, Thanks Java-Gnome hackers, Thanks GCJ hackers,
Thank GNU!

Mark



From MAILER-DAEMON Sun Nov 09 13:58:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIulg-0006UR-Et
	for mharc-classpath@gnu.org; Sun, 09 Nov 2003 13:58:36 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIuld-0006UB-P2
	for classpath@gnu.org; Sun, 09 Nov 2003 13:58:33 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIul7-0006Hb-4Z
	for classpath@gnu.org; Sun, 09 Nov 2003 13:58:32 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIul6-0006HY-Kl
	for classpath@gnu.org; Sun, 09 Nov 2003 13:58:00 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AItnI-0001t8-00; Sun, 09 Nov 2003 18:56:12 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AItnf-0001Wy-00; Sun, 09 Nov 2003 18:56:35 +0100
From: Mark Wielaard <mark@klomp.org>
To: java@gcc.gnu.org, classpath@gnu.org,
	java-gnome-developer@lists.sourceforge.net
In-Reply-To: <1068400172.1430.129.camel@localhost>
References: <1068400172.1430.129.camel@localhost>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1068400594.1446.134.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 09 Nov 2003 18:56:34 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: 
Subject: Re: I love it when a plan comes together (GCJ, Eclipse and Gnome!)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Nov 2003 18:58:34 -0000

On Sun, 2003-11-09 at 18:49, Mark Wielaard wrote:
> After installing these, and unzipping the plugin in my fresh eclipse
> install directory everything worked out of the box!
> <http://www.klomp.org:klomp.org/mark/classpath/eclipse-gnome-gij.png>

Sorry, copy-paste error. Should be:
http://www.klomp.org/mark/classpath/eclipse-gnome-gij.png

> Thanks Gnome hackers, Thanks Eclipse hackers, Thanks Classpath hackers,
> Thanks Debian hackers, Thanks Java-Gnome hackers, Thanks GCJ hackers,
> Thank GNU!
> 
> Mark



From MAILER-DAEMON Sun Nov 09 17:01:07 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AIxcF-0000ku-Bq
	for mharc-classpath@gnu.org; Sun, 09 Nov 2003 17:01:03 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AIvFk-00034f-Dl
	for classpath@gnu.org; Sun, 09 Nov 2003 14:29:40 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AIvFD-0002rQ-4d
	for classpath@gnu.org; Sun, 09 Nov 2003 14:29:39 -0500
Received: from [131.111.8.70] (helo=red.csi.cam.ac.uk)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AIvFC-0002pK-Qk
	for classpath@gnu.org; Sun, 09 Nov 2003 14:29:06 -0500
Received: from pathfinderii.chu.cam.ac.uk ([131.111.203.177] helo=localhost)
	by red.csi.cam.ac.uk with smtp (Exim 4.12)
	id 1AIuHg-0004N1-00; Sun, 09 Nov 2003 18:27:40 +0000
Received: by localhost (sSMTP sendmail emulation);
	Sun,  9 Nov 2003 18:27:17 +0000
Date: Sun, 9 Nov 2003 18:27:17 +0000
From: Mark Howard <mh344@cam.ac.uk>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20031109182717.GA22839@(none)>
Mail-Followup-To: Mark Howard <mh344@cam.ac.uk>,
	Mark Wielaard <mark@klomp.org>, java@gcc.gnu.org, classpath@gnu.org,
	java-gnome-developer@lists.sourceforge.net
References: <1068400172.1430.129.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1068400172.1430.129.camel@localhost>
User-Agent: Mutt/1.5.4i
X-Mailman-Approved-At: Sun, 09 Nov 2003 17:00:59 -0500
Cc: java-gnome-developer@lists.sourceforge.net, classpath@gnu.org,
	java@gcc.gnu.org
Subject: Re: [Java-gnome-developer] I love it when a plan comes together
	(GCJ, Eclipse and Gnome!)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Nov 2003 19:29:41 -0000

On Sun, Nov 09, 2003 at 06:49:34PM +0100, Mark Wielaard wrote:
> I was pleasantly surprized that the latest 0.8 java-gnome bindings are
> already packeged for Debian:

you forgot to mention the most important package:
libjava-gnome-doc

-- 
  .''`. Mark Howard
 : :' :
 `. `'  http://www.tildemh.com 
   `-   mh@debian.org | mh@tildemh.com | mh344@cam.ac.uk 



From MAILER-DAEMON Tue Nov 11 17:35:51 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AJh70-0006rF-OE
	for mharc-classpath@gnu.org; Tue, 11 Nov 2003 17:35:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AJh6u-0006pI-S7
	for classpath@gnu.org; Tue, 11 Nov 2003 17:35:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AJh6O-0006i4-5L
	for classpath@gnu.org; Tue, 11 Nov 2003 17:35:43 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AJh6G-0006gu-Mm
	for classpath@gnu.org; Tue, 11 Nov 2003 17:35:04 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hABLXZM01986;
	Tue, 11 Nov 2003 16:33:35 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hABLXW625302; 
	Tue, 11 Nov 2003 16:33:33 -0500
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	hABLXUkr013350; Tue, 11 Nov 2003 16:33:30 -0500
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Tom Tromey <tromey@redhat.com>
In-Reply-To: <87r80kuexq.fsf@fleche.redhat.com>
References: <1068149092.32011.18.camel@tortoise.toronto.redhat.com>
	<87r80kuexq.fsf@fleche.redhat.com>
Content-Type: multipart/mixed; boundary="=-TeIjeg9we0s6eOUm2oTK"
Message-Id: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 11 Nov 2003 16:33:30 -0500
Cc: classpath@gnu.org, GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2003 22:35:48 -0000


--=-TeIjeg9we0s6eOUm2oTK
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Fri, 2003-11-07 at 15:00, Tom Tromey wrote:
> >>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:
> 
> Tom> This patch fixes various problems related to image loading.  It also
> Tom> implements Component.imageUpdate, GtkToolkit.prepareImage and the
> Tom> byte-array GtkToolkit.createImage method.
> 
> Looks good.
> 
> Tom> -    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
> Tom> -    // return new GtkImage (new GdkPixbufDecoder (filename), null);
> Tom> -    return null;
> Tom> +    return new GtkImage (new GdkPixbufDecoder (filename), null);
> 
> I don't remember why I commented out this code in libgcj, other than
> what the comment says.  I assume it is ok to enable now?
> 

Yes, we can remove these FIXMEs since Graydon fixed GdkPixbufDecoder.

> Tom> +    boolean incrementalDraw = Boolean.getBoolean ("awt.image.incrementalDraw");
> Tom> +    Long redrawRate = Long.getLong ("awt.image.redrawrate");
> 
> Should these be computed once, at class init time?

Yes, looking again, I think they should.

> Or do we want to recompute them each time this method is called?
> 
> Also, I forget where and how we're documenting properties we
> recognize.  I know this has come up before though.  These two should
> at least be mentioned in the javadoc for the method.
> 

Yup, they're already mentioned in the existing javadoc.

Are the attached changes to Component.java ok?  If so, I'll check them
in along with the rest of the patch.

Tom


--=-TeIjeg9we0s6eOUm2oTK
Content-Disposition: attachment; filename=imageobserver3.patch
Content-Type: text/x-patch; name=imageobserver3.patch; charset=
Content-Transfer-Encoding: 7bit

Index: java/awt/Component.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Component.java,v
retrieving revision 1.29
diff -u -r1.29 Component.java
--- java/awt/Component.java	20 Sep 2003 21:30:39 -0000	1.29
+++ java/awt/Component.java	11 Nov 2003 21:22:58 -0000
@@ -555,6 +555,17 @@
    */
   transient BufferStrategy bufferStrategy;
 
+  /**
+   * The system properties that affect image updating.
+   */
+  transient private static boolean incrementalDraw;
+  transient private static Long redrawRate;
+
+  static
+  {
+    incrementalDraw = Boolean.getBoolean ("awt.image.incrementalDraw");
+    redrawRate = Long.getLong ("awt.image.redrawrate");
+  }
 
   // Public and protected API.
 
@@ -1832,7 +1843,9 @@
    * @param y the Y coordinate
    * @param w the width
    * @param h the height
-   * @return true if the image has been fully loaded
+   * @return false if the image is completely loaded, loading has been
+   * aborted, or an error has occurred.  true if more updates are
+   * required.
    * @see ImageObserver
    * @see Graphics#drawImage(Image, int, int, Color, ImageObserver)
    * @see Graphics#drawImage(Image, int, int, ImageObserver)
@@ -1842,8 +1855,24 @@
    */
   public boolean imageUpdate(Image img, int flags, int x, int y, int w, int h)
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    if ((flags & (FRAMEBITS|ALLBITS)) != 0)
+      repaint ();
+    else if ((flags & SOMEBITS) != 0)
+      {
+	if (incrementalDraw)
+	  {
+	    if (redrawRate != null)
+	      {
+		long tm = redrawRate.longValue();
+		if (tm < 0)
+		  tm = 0;
+		repaint (tm);
+	      }
+	    else
+	      repaint (100);
+	  }
+      }
+    return (flags & (ALLBITS|ABORT|ERROR)) == 0;
   }
 
   /**
@@ -1854,8 +1883,11 @@
    */
   public Image createImage(ImageProducer producer)
   {
-    // XXX What if peer or producer is null?
-    return peer.createImage(producer);
+    // Sun allows producer to be null.
+    if (peer != null)
+      return peer.createImage(producer);
+    else
+      return getToolkit().createImage(producer);
   }
 
   /**
@@ -1930,6 +1962,9 @@
    */
   public boolean prepareImage(Image image, ImageObserver observer)
   {
+    if (image == null)
+      throw new NullPointerException ();
+
     return prepareImage(image, image.getWidth(observer),
                         image.getHeight(observer), observer);
   }

--=-TeIjeg9we0s6eOUm2oTK--




From MAILER-DAEMON Tue Nov 11 18:03:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AJhXR-0003Bw-BY
	for mharc-classpath@gnu.org; Tue, 11 Nov 2003 18:03:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AJhXP-0003Bf-Jj
	for classpath@gnu.org; Tue, 11 Nov 2003 18:03:07 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AJhWt-00035z-RS
	for classpath@gnu.org; Tue, 11 Nov 2003 18:03:06 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AJhWt-00035t-5H
	for classpath@gnu.org; Tue, 11 Nov 2003 18:02:35 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA15650;
	Tue, 11 Nov 2003 15:01:08 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id D1DD84F85E8; Tue, 11 Nov 2003 14:52:21 -0700 (MST)
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <1068149092.32011.18.camel@tortoise.toronto.redhat.com>
	<87r80kuexq.fsf@fleche.redhat.com>
	<1068586410.3911.312.camel@tortoise.toronto.redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Concentrate on th'cute, li'l CARTOON GUYS!
	Remember the SERIAL NUMBERS!!  Follow the WHIPPLE AVE EXIT!!
	Have a FREE PEPSI!!  Turn LEFT at th'HOLIDAY INN!!
	JOIN the CREDIT WORLD!!  MAKE me an OFFER!!!
Date: 11 Nov 2003 14:52:21 -0700
In-Reply-To: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
Message-ID: <87ekwe4lpm.fsf@fleche.redhat.com>
Lines: 17
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2003 23:03:08 -0000

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> Are the attached changes to Component.java ok?  If so, I'll check them
Tom> in along with the rest of the patch.

Looks great, just a couple little nit...

Tom> +  transient private static boolean incrementalDraw;

Should be "private static transient", I think.  The canonical
ordering is defined by Modifier.toString().

Tom> +    if ((flags & (FRAMEBITS|ALLBITS)) != 0)

You need spaces around the "|".  There are a few instances of this.

Tom



From MAILER-DAEMON Wed Nov 12 04:15:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AJr5o-0004yd-Q7
	for mharc-classpath@gnu.org; Wed, 12 Nov 2003 04:15:16 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AJr5l-0004xd-D6
	for classpath@gnu.org; Wed, 12 Nov 2003 04:15:13 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AJr58-0004od-EP
	for classpath@gnu.org; Wed, 12 Nov 2003 04:15:05 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AJr58-0004oN-0a
	for classpath@gnu.org; Wed, 12 Nov 2003 04:14:34 -0500
Received: from [192.168.1.33] (215.176.static-adsl.customer.ch.easynet.net
	[217.8.215.176]) by smtp1.mail.ch.easynet.net (Postfix) with ESMTP
	id ECA394A12B; Wed, 12 Nov 2003 09:13:07 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: Thomas Fitzsimmons <fitzsim@redhat.com>
Date: Wed, 12 Nov 2003 09:12:05 +0100
Message-Id: <20031112081205.20631@smtp.mail.ch.easynet.net>
In-Reply-To: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
References: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Nov 2003 09:15:14 -0000

Hi Tom,

Thomas Fitzsimmons <fitzsim@redhat.com> wrote on Tue, 11 Nov
2003 16:33:30 -0500:

>[patch to java/awt/Component.java]

    public boolean prepareImage(Image image, ImageObserver observer)
    {
+    if (image == null)
+      throw new NullPointerException ();
+
     return prepareImage(image, image.getWidth(observer),
                         image.getHeight(observer), observer);
    }

Actually, the test for image == null is not needed.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Nov 12 13:02:47 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AJzJJ-0007wt-BQ
	for mharc-classpath@gnu.org; Wed, 12 Nov 2003 13:01:45 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AJzIv-0007uF-Gb
	for classpath@gnu.org; Wed, 12 Nov 2003 13:01:21 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AJzAm-0006Gn-W3
	for classpath@gnu.org; Wed, 12 Nov 2003 12:53:29 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AJz44-0005A0-32
	for classpath@gnu.org; Wed, 12 Nov 2003 12:46:00 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hACGiRM18391;
	Wed, 12 Nov 2003 11:44:27 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hACGiR620233; 
	Wed, 12 Nov 2003 11:44:27 -0500
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	hACGiQQ1005428; Wed, 12 Nov 2003 11:44:26 -0500
From: Tom Fitzsimmons <fitzsim@redhat.com>
To: Sascha Brawer <brawer@dandelis.ch>
In-Reply-To: <20031112081205.20631@smtp.mail.ch.easynet.net>
References: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
	<20031112081205.20631@smtp.mail.ch.easynet.net>
Content-Type: text/plain
Message-Id: <1068655465.15917.38.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Wed, 12 Nov 2003 11:44:26 -0500
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Nov 2003 18:01:41 -0000

On Wed, 2003-11-12 at 03:12, Sascha Brawer wrote:
> Hi Tom,
> 
> Thomas Fitzsimmons <fitzsim@redhat.com> wrote on Tue, 11 Nov
> 2003 16:33:30 -0500:
> 
> >[patch to java/awt/Component.java]
> 
>     public boolean prepareImage(Image image, ImageObserver observer)
>     {
> +    if (image == null)
> +      throw new NullPointerException ();
> +
>      return prepareImage(image, image.getWidth(observer),
>                          image.getHeight(observer), observer);
>     }
> 
> Actually, the test for image == null is not needed.
> 

Yes, I know an NPE will be thrown either way.  I just thought it better
to be explicit.  But the other methods in Component don't follow this
policy so I'll remove the check.

Thanks,
Tom





From MAILER-DAEMON Wed Nov 12 14:42:37 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AK0sv-00073Y-AV
	for mharc-classpath@gnu.org; Wed, 12 Nov 2003 14:42:37 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AK0ss-00072v-O1
	for classpath@gnu.org; Wed, 12 Nov 2003 14:42:34 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AK0pw-0006My-D5
	for classpath@gnu.org; Wed, 12 Nov 2003 14:40:03 -0500
Received: from [146.87.255.99] (helo=rhea.salford.ac.uk)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AK0on-0005mC-Q6
	for classpath@gnu.org; Wed, 12 Nov 2003 14:38:22 -0500
Received: (qmail 46143 invoked by uid 1236); 12 Nov 2003 18:36:55 -0000
Received: from ricky_clarkson@yahoo.com by pan.salford.ac.uk by uid 401 with
	qmail-scanner-1.20rc4 
	(clamuko: 0.60. uvscan: v4.2.40/v4302. spamassassin: 2.60. Clear:RC:1:.
	Processed in 0.020475 secs); 12 Nov 2003 18:36:55 -0000
Received: from [146.87.133.141] (HELO debian) (146.87.133.141)
	by rhea.salford.ac.uk (qpsmtpd/0.27-dev) with ESMTP;
	Wed, 12 Nov 2003 18:36:55 +0000
Received: from ricky by debian with local (Exim 4.24) id 1AJzov-0001yu-ER
	for classpath@gnu.org; Wed, 12 Nov 2003 18:34:25 +0000
Date: Wed, 12 Nov 2003 18:34:25 +0000
To: classpath@gnu.org
Message-ID: <20031112183425.GA7608@yahoo.com>
References: <1068586410.3911.312.camel@tortoise.toronto.redhat.com>
	<20031112081205.20631@smtp.mail.ch.easynet.net>
	<1068655465.15917.38.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1068655465.15917.38.camel@tortoise.toronto.redhat.com>
User-Agent: Mutt/1.5.4i
From: Ricky Clarkson <ricky_clarkson@yahoo.com>
Subject: Re: Patch: image loading fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Nov 2003 19:42:35 -0000

Surely the exception to throw here would be IllegalArgumentException
anyway, as null would be an illegal input to the method.

Ricky.

> > >[patch to java/awt/Component.java]
> > 
> >     public boolean prepareImage(Image image, ImageObserver observer)
> >     {
> > +    if (image == null)
> > +      throw new NullPointerException ();
> > +
> >      return prepareImage(image, image.getWidth(observer),
> >                          image.getHeight(observer), observer);
> >     }
> > 
> > Actually, the test for image == null is not needed.
> > 
> 
> Yes, I know an NPE will be thrown either way.  I just thought it better
> to be explicit.  But the other methods in Component don't follow this
> policy so I'll remove the check.

-- 
Phasers locked on target, Captain.



From MAILER-DAEMON Wed Nov 12 20:31:24 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AK6KR-0004U3-P1
	for mharc-classpath@gnu.org; Wed, 12 Nov 2003 20:31:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AK6KF-0004Sy-8R
	for classpath@gnu.org; Wed, 12 Nov 2003 20:31:11 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AK6Ji-0004Nq-RR
	for classpath@gnu.org; Wed, 12 Nov 2003 20:31:10 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AK6Je-0004Lf-TJ
	for classpath@gnu.org; Wed, 12 Nov 2003 20:30:35 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AK5MB-00045o-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 01:29:07 +0100
Received: from mpiat2305.ag2.mpi-sb.mpg.de
	([139.19.20.94] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AK5MA-00045U-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 01:29:06 +0100
Message-ID: <3FB2D051.5010208@kaffe.org>
Date: Thu, 13 Nov 2003 01:29:05 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------070008040904060700050002"
X-Virus-Scanned: by AMaViS perl-11
Subject: [PATCH] Small fix for Jetty 4.2.14
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 01:31:11 -0000

This is a multi-part message in MIME format.
--------------070008040904060700050002
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

attached is a small fix for Jetty 4.2.14 that is needed to get Jetty to 
work with Classpath's file URL Connection. Jetty otherwise breaks on 
startup and complains that webapps/templates can not be found, despite 
that it exists. Jetty wants to access the path of the file permission on 
a file URL connection to determine the existence of a file, apparently.

The fix overwrites getPermission the file URL connection to return a 
FilePermission with the file path and a read permission.

cheers,
dalibor topic

2003-11-13  Dalibor Topic <robilad@kaffe.org>

        * libraries/javalib/gnu/java/net/protocol/file/Connection.java:
        Added imports for java.io.FilePermission and
        java.security.Permission.
        (permission) New field.
        (DEFAULT_PERMISSION) New constant.
        (Connection) Create a FilePermission with permission to read
        from file.
        (getPermission) Overwrite getPermission to return a
        FilePermission.


--------------070008040904060700050002
Content-Type: text/plain;
 name="file-connection.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="file-connection.diff"

Index: libraries/javalib/gnu/java/net/protocol/file/Connection.java
===================================================================
RCS file: /cvs/kaffe/kaffe/libraries/javalib/gnu/java/net/protocol/file/Connection.java,v
retrieving revision 1.1
diff -u -r1.1 Connection.java
--- libraries/javalib/gnu/java/net/protocol/file/Connection.java	29 Oct 2003 18:30:49 -0000	1.1
+++ libraries/javalib/gnu/java/net/protocol/file/Connection.java	13 Nov 2003 00:20:38 -0000
@@ -44,12 +44,14 @@
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
+import java.io.FilePermission;
 import java.io.InputStream;
 import java.io.IOException;
 import java.io.OutputStream;
 import java.net.ProtocolException;
 import java.net.URL;
 import java.net.URLConnection;
+import java.security.Permission;
 import java.util.AbstractSet;
 import java.util.Iterator;
 import java.util.Set;
@@ -79,7 +81,17 @@
    * OutputStream if we are writing to the file
    */
   private BufferedOutputStream outputStream;
-  
+
+  /**
+   * FilePermission to read the file
+   */
+  private FilePermission permission;
+
+  /**
+   * Default permission for a file
+   */
+  private static final String DEFAULT_PERMISSION = "read";
+
   /**
    * Calls superclass constructor to initialize.
    */
@@ -89,6 +101,8 @@
     
     /* Set up some variables */
     doOutput = false;
+
+    permission = new FilePermission(getURL().getFile(), DEFAULT_PERMISSION);
   }
   
   /**
@@ -193,6 +207,19 @@
       }
   }
 
+
+  /**
+   * This method returns a <code>Permission</code> object representing the
+   * permissions required to access this URL.  This method returns a
+   * <code>java.io.FilePermission</code> for the file's path with a read
+   * permission.
+   *
+   * @return A Permission object
+   */
+  public Permission getPermission() throws IOException
+  {
+    return permission;
+  }
 
   /**
    * Does the resource pointed to actually exist?

--------------070008040904060700050002--




From MAILER-DAEMON Thu Nov 13 10:48:14 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKJYh-00062U-Ly
	for mharc-classpath@gnu.org; Thu, 13 Nov 2003 10:38:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKJXc-0005sg-Do
	for classpath@gnu.org; Thu, 13 Nov 2003 10:37:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKJX2-0005jW-7J
	for classpath@gnu.org; Thu, 13 Nov 2003 10:37:47 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKJX0-0005iN-5f
	for classpath@gnu.org; Thu, 13 Nov 2003 10:37:14 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AKIZZ-0006Gp-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 15:35:49 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AKIZX-0006GV-00; Thu, 13 Nov 2003 15:35:47 +0100
Message-ID: <3FB396C3.8060705@kaffe.org>
Date: Thu, 13 Nov 2003 15:35:47 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>
Content-Type: multipart/mixed; boundary="------------030307090706060700060504"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 15:38:57 -0000

This is a multi-part message in MIME format.
--------------030307090706060700060504
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

attached is a small fix for ServerSocket's close method. It fixes a 
NullPointerException when attempting to close a ServerSocket twice.

2003-11-13  Guilhem Lavaux <guilhem@kaffe.org>
	* java/net/ServerSocket.java:
	(close) Check if server socket has already been released,
	before attepting to close it.


--------------030307090706060700060504
Content-Type: text/plain;
 name="cpath-server-socket-close.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-server-socket-close.diff"

--- /var/tmp/PROJECTS/classpath//./java/net/ServerSocket.java	Fri Oct 17 19:05:29 2003
+++ java/net/ServerSocket.java	Wed Oct 22 21:32:21 2003
@@ -339,7 +339,8 @@
    */
   public void close () throws IOException
   {
-    impl.close ();
+    if (impl != null)
+      impl.close ();
 
     if (getChannel() != null)
       getChannel().close ();

--------------030307090706060700060504--




From MAILER-DAEMON Thu Nov 13 13:19:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKM46-0006kE-HF
	for mharc-classpath@gnu.org; Thu, 13 Nov 2003 13:19:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKM3x-0006gc-2G
	for classpath@gnu.org; Thu, 13 Nov 2003 13:19:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKLzi-0005h6-P3
	for classpath@gnu.org; Thu, 13 Nov 2003 13:15:33 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKLzg-0005go-CA
	for classpath@gnu.org; Thu, 13 Nov 2003 13:15:00 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AKL1p-0004nz-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 18:13:09 +0100
From: Mark Wielaard <mark@klomp.org>
To: GNU Classpath <classpath@gnu.org>
In-Reply-To: <3FB2D051.5010208@kaffe.org>
References: <3FB2D051.5010208@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-4vlsWegeq3uvpDCtcQ+c"
Message-Id: <1068743613.934.58.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 13 Nov 2003 18:13:33 +0100
Subject: Re: [PATCH] Small fix for Jetty 4.2.14
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 18:19:27 -0000


--=-4vlsWegeq3uvpDCtcQ+c
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-13 at 01:29, Dalibor Topic wrote:
> Hi,
>=20
> attached is a small fix for Jetty 4.2.14 that is needed to get Jetty to=20
> work with Classpath's file URL Connection. Jetty otherwise breaks on=20
> startup and complains that webapps/templates can not be found, despite=20
> that it exists. Jetty wants to access the path of the file permission on=20
> a file URL connection to determine the existence of a file, apparently.
>=20
> The fix overwrites getPermission the file URL connection to return a=20
> FilePermission with the file path and a read permission.

Thanks. I also wrote a Mauve test for this.
(The test still fails because our file Handler.parseURL() seem broken.
But if that is fixed, your patch makes the new Mauve test succeed.)

2003-11-13  Dalibor Topic <robilad@kaffe.org>
>=20
>         * libraries/javalib/gnu/java/net/protocol/file/Connection.java:
>         Added imports for java.io.FilePermission and
>         java.security.Permission.
>         (permission) New field.
>         (DEFAULT_PERMISSION) New constant.
>         (Connection) Create a FilePermission with permission to read
>         from file.
>         (getPermission) Overwrite getPermission to return a
>         FilePermission.
>=20

Applied as follows:

2003-11-13  Dalibor Topic <robilad@kaffe.org>

       * gnu/java/net/protocol/file/Connection.java (permission): New field=
.
       (DEFAULT_PERMISSION): New constant.
       (Connection): Create a FilePermission with permission to read file.
       (getPermission): Overwrite getPermission to return a FilePermission.

You don't need to mention really trivial changes such as new imports.
Note the placement of the ':' between what was changed and the
description of the change.

Maybe kaffe could in the long run switch to a separate ChangeLog file in
the libraries/javalib directory so that we can even share the complete
ChangeLog messages between the projects as we already do with gcj
libjava.

Cheers,

Mark

--=-4vlsWegeq3uvpDCtcQ+c
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/s7u9xVhZCJWr9QwRAkE3AJwIwo9VPYv50I7V6Z4AM3LxkQDW5wCdHmxk
dmu3qaXBXKQDBYtng3+rdzI=
=7+VT
-----END PGP SIGNATURE-----

--=-4vlsWegeq3uvpDCtcQ+c--




From MAILER-DAEMON Thu Nov 13 13:49:38 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKMXC-0003Yx-0P
	for mharc-classpath@gnu.org; Thu, 13 Nov 2003 13:49:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKMX6-0003Y9-3a
	for classpath@gnu.org; Thu, 13 Nov 2003 13:49:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKMWX-00034y-Pz
	for classpath@gnu.org; Thu, 13 Nov 2003 13:49:28 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKMWW-00032P-8C
	for classpath@gnu.org; Thu, 13 Nov 2003 13:48:56 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AKLYf-0005p1-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 18:47:05 +0100
From: Mark Wielaard <mark@klomp.org>
To: GNU Classpath <classpath@gnu.org>
In-Reply-To: <3FB396C3.8060705@kaffe.org>
References: <3FB396C3.8060705@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-lHrlsJ0q3T/BD1TjYBsX"
Message-Id: <1068745650.926.61.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 13 Nov 2003 18:47:30 +0100
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 18:49:34 -0000


--=-lHrlsJ0q3T/BD1TjYBsX
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-13 at 15:35, Dalibor Topic wrote:
> attached is a small fix for ServerSocket's close method. It fixes a=20
> NullPointerException when attempting to close a ServerSocket twice.

Thanks. Checked in as obvious. Only slightly reformatted the ChangeLog
entry.

2003-11-13  Guilhem Lavaux <guilhem@kaffe.org>

       * java/net/ServerSocket.java (close): Check if server socket has
       already been released, before attepting to close it.

Cheers,

Mark

--=-lHrlsJ0q3T/BD1TjYBsX
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/s8OyxVhZCJWr9QwRApbBAKCFJmoexmxLnnuO0nAJcaqqYlvFPwCdGKXV
xpVsfr6ojflOsZibedLOXxQ=
=NqvR
-----END PGP SIGNATURE-----

--=-lHrlsJ0q3T/BD1TjYBsX--




From MAILER-DAEMON Thu Nov 13 18:55:32 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKRJE-0002iO-Ba
	for mharc-classpath@gnu.org; Thu, 13 Nov 2003 18:55:32 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKRJ7-0002hT-G7
	for classpath@gnu.org; Thu, 13 Nov 2003 18:55:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKRIb-0002Xp-HG
	for classpath@gnu.org; Thu, 13 Nov 2003 18:55:24 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKRI6-0002Ft-9r
	for classpath@gnu.org; Thu, 13 Nov 2003 18:54:22 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-74-048.ewetel.net
	[80.228.74.48])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id hADMqqTR018150;
	Thu, 13 Nov 2003 23:52:54 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AKQKa-0006My-00; Thu, 13 Nov 2003 23:52:52 +0100
Date: Thu, 13 Nov 2003 23:52:52 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20031113225252.GA24484@mail.konqueror.de>
References: <3FB396C3.8060705@kaffe.org>
	<1068745650.926.61.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1068745650.926.61.camel@elsschot.wildebeest.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 23:55:26 -0000

On Thu, Nov 13, 2003 at 06:47:30PM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Thu, 2003-11-13 at 15:35, Dalibor Topic wrote:
> > attached is a small fix for ServerSocket's close method. It fixes a 
> > NullPointerException when attempting to close a ServerSocket twice.
> 
> Thanks. Checked in as obvious. Only slightly reformatted the ChangeLog
> entry.
> 
> 2003-11-13  Guilhem Lavaux <guilhem@kaffe.org>
> 
>        * java/net/ServerSocket.java (close): Check if server socket has
>        already been released, before attepting to close it.

I think it would be really nice i you could commit this to libgcj too.
This class is totally merged.


Michael



From MAILER-DAEMON Thu Nov 13 18:57:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKRLR-0003qy-9a
	for mharc-classpath@gnu.org; Thu, 13 Nov 2003 18:57:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKRLM-0003lF-EX
	for classpath@gnu.org; Thu, 13 Nov 2003 18:57:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKRKa-0003NU-Ux
	for classpath@gnu.org; Thu, 13 Nov 2003 18:57:28 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKRKa-0003N7-9m
	for classpath@gnu.org; Thu, 13 Nov 2003 18:56:56 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AKQMj-0008KK-00
	for <classpath@gnu.org>; Thu, 13 Nov 2003 23:55:05 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <3FA0071C.10502@kaffe.org>
References: <3FA0071C.10502@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-iZ3gL3NxV8sDNzyS3dtE"
Message-Id: <1068764130.922.134.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 13 Nov 2003 23:55:30 +0100
Subject: Re: URL's fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 23:57:47 -0000


--=-iZ3gL3NxV8sDNzyS3dtE
Content-Type: multipart/mixed; boundary="=-h80E+8iP48oRw/7O1D8O"


--=-h80E+8iP48oRw/7O1D8O
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2003-10-29 at 19:29, Guilhem Lavaux wrote:

> I noticed some misbehaviour of classpath's URL compared to=20
> Sun's JDK while merging these classes in kaffe's library.=20
> Kaffe's regression test "URLTest" was failing nearly=20
> completely.

I turned that kaffe test into a new Mauve test.

> BTW, there was an error when url of the type=20
> "http://anonymous:anonymous@host/" was entered: URL reports=20
> to detect "anonymous" as the host.

I also added that to the new Mauve test and saw that your patch indeed
fixes the parsing, but that we also had a bug in the toExternalForm() of
such URLs. Fix as follows:

2003-11-13  Guilhem Lavaux  <guilhem@kaffe.org>
	    Mark Wielaard  <mark@klomp.org>

	* java/net/URLStreamHandler (parseUrl): Fixed URL parsing
	('@' should be checked to distinguish port from userinfo).
	(toExternalForm): Add @ userInfo if necessary.

> This patch fixes all these things.

It is easier when patches are split up into small parts.
That makes reviewing them much easier. Will review the rest of you patch
later.

Cheers,

Mark


--=-h80E+8iP48oRw/7O1D8O
Content-Disposition: inline; filename=URLStreamHandler.patch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name=URLStreamHandler.patch; charset=ISO-8859-1

SW5kZXg6IGphdmEvbmV0L1VSTFN0cmVhbUhhbmRsZXIuamF2YQ0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp
bGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvamF2YS9uZXQvVVJMU3RyZWFtSGFuZGxl
ci5qYXZhLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOQ0KZGlmZiAtdSAtcjEuMTkgVVJMU3Ry
ZWFtSGFuZGxlci5qYXZhDQotLS0gamF2YS9uZXQvVVJMU3RyZWFtSGFuZGxlci5qYXZhCTE5IFNl
cCAyMDAzIDA2OjE5OjQyIC0wMDAwCTEuMTkNCisrKyBqYXZhL25ldC9VUkxTdHJlYW1IYW5kbGVy
LmphdmEJMTMgTm92IDIwMDMgMjI6NTE6NTQgLTAwMDANCkBAIC0xMjksMTEgKzEyOSwxMiBAQA0K
ICAgICANCiAgICAgaWYgKHNwZWMucmVnaW9uTWF0Y2hlcyAoc3RhcnQsICIvLyIsIDAsIDIpKQ0K
ICAgICAgIHsNCisJU3RyaW5nIGdlbnVpbmVIb3N0Ow0KIAlpbnQgaG9zdEVuZDsNCi0JaW50IGNv
bG9uOw0KKwlpbnQgY29sb24sIGF0X2hvc3Q7DQogDQogCXN0YXJ0ICs9IDI7DQotCWludCBzbGFz
aCA9IHNwZWMuaW5kZXhPZignLycsIHN0YXJ0KTsNCisJaW50IHNsYXNoID0gc3BlYy5pbmRleE9m
ICgnLycsIHN0YXJ0KTsNCiAJaWYgKHNsYXNoID49IDApIA0KIAkgIGhvc3RFbmQgPSBzbGFzaDsN
CiAgICAgICAgIGVsc2UNCkBAIC0xNDEsMjQgKzE0MiwzNyBAQA0KIA0KIAlob3N0ID0gc3BlYy5z
dWJzdHJpbmcgKHN0YXJ0LCBob3N0RW5kKTsNCiAJDQorCS8vIFdlIGZpcnN0IG5lZWQgYSBnZW51
aW5lIGhvc3QgbmFtZSAod2l0aCB1c2VyaW5mbykuDQorCS8vIFNvIHdlIGNoZWNrIGZvciAnQCc6
IGlmIGl0J3MgcHJlc2VudCBjaGVjayB0aGUgcG9ydCBpbiB0aGUNCisJLy8gc2VjdGlvbiBhZnRl
ciAnQCcgaW4gdGhlIG90aGVyIGNhc2UgY2hlY2sgaXQgaW4gdGhlIGZ1bGwgc3RyaW5nLg0KKwkv
LyBQLlMuOiBXZSBkb24ndCBjYXJlIGhhdmluZyAnQCcgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUg
c3RyaW5nLg0KKwlpZiAoKGF0X2hvc3QgPSBob3N0LmluZGV4T2YgKCdAJykpID49IDApDQorCSAg
Z2VudWluZUhvc3QgPSBob3N0LnN1YnN0cmluZyAoYXRfaG9zdCk7DQorCWVsc2UNCisJICBnZW51
aW5lSG9zdCA9IGhvc3Q7DQorDQogCS8vIExvb2sgZm9yIG9wdGlvbmFsIHBvcnQgbnVtYmVyLiAg
SXQgaXMgdmFsaWQgZm9yIHRoZSBub24tcG9ydA0KIAkvLyBwYXJ0IG9mIHRoZSBob3N0IG5hbWUg
dG8gYmUgbnVsbCAoZS5nLiBhIFVSTCAiaHR0cDovLzo4MCIpLg0KIAkvLyBUQkQ6IEpESyAxLjIg
aW4gdGhpcyBjYXNlIHNldHMgaG9zdCB0byBudWxsIHJhdGhlciB0aGFuICIiOw0KIAkvLyB0aGlz
IGlzIHVuZG9jdW1lbnRlZCBhbmQgbGlrZWx5IGFuIHVuaW50ZW5kZWQgc2lkZSBlZmZlY3QgaW4g
MS4yDQogCS8vIHNvIHdlJ2xsIGJlIHNpbXBsZSBoZXJlIGFuZCBzdGljayB3aXRoICIiLiBOb3Rl
IHRoYXQNCiAJLy8gImh0dHA6Ly8iIG9yICJodHRwOi8vLyIgcHJvZHVjZSBhICIiIGhvc3QgaW4g
SkRLIDEuMi4NCi0JaWYgKChjb2xvbiA9IGhvc3QuaW5kZXhPZignOicpKSA+PSAwKQ0KKwlpZiAo
KGNvbG9uID0gZ2VudWluZUhvc3QuaW5kZXhPZiAoJzonKSkgPj0gMCkNCiAJICB7DQogCSAgICB0
cnkNCiAJICAgICAgew0KLQkJcG9ydCA9IEludGVnZXIucGFyc2VJbnQoaG9zdC5zdWJzdHJpbmco
Y29sb24gKyAxKSk7DQorCQlwb3J0ID0gSW50ZWdlci5wYXJzZUludCAoZ2VudWluZUhvc3Quc3Vi
c3RyaW5nIChjb2xvbiArIDEpKTsNCiAJICAgICAgfQ0KIAkgICAgY2F0Y2ggKE51bWJlckZvcm1h
dEV4Y2VwdGlvbiBlKQ0KIAkgICAgICB7DQogCQk7IC8vIElnbm9yZSBpbnZhbGlkIHBvcnQgdmFs
dWVzOyBwb3J0IGlzIGFscmVhZHkgc2V0IHRvIHUncw0KIAkJICAvLyBwb3J0Lg0KIAkgICAgICB9
DQotCSAgICBob3N0ID0gaG9zdC5zdWJzdHJpbmcoMCwgY29sb24pOw0KKwkgICAgLy8gTm93IHdl
IG11c3QgY3V0IHRoZSBwb3J0IG51bWJlciBpbiB0aGUgb3JpZ2luYWwgc3RyaW5nLg0KKwkgICAg
aWYgKGF0X2hvc3QgPj0gMCkNCisJICAgICAgaG9zdCA9IGhvc3Quc3Vic3RyaW5nICgwLCBhdF9o
b3N0ICsgY29sb24pOw0KKwkgICAgZWxzZQ0KKwkgICAgICBob3N0ID0gaG9zdC5zdWJzdHJpbmcg
KDAsIGNvbG9uKTsNCiAJICB9DQogCWZpbGUgPSBudWxsOw0KIAlzdGFydCA9IGhvc3RFbmQ7DQpA
QCAtNDUxLDcgKzQ2NSw3IEBADQogICAgKi8NCiAgIHByb3RlY3RlZCBTdHJpbmcgdG9FeHRlcm5h
bEZvcm0oVVJMIHUpDQogICB7DQotICAgIFN0cmluZyBwcm90b2NvbCwgaG9zdCwgZmlsZSwgcmVm
Ow0KKyAgICBTdHJpbmcgcHJvdG9jb2wsIGhvc3QsIGZpbGUsIHJlZiwgdXNlcjsNCiAgICAgaW50
IHBvcnQ7DQogDQogICAgIHByb3RvY29sID0gdS5nZXRQcm90b2NvbCgpOw0KQEAgLTQ2NSw2ICs0
NzksNyBAQA0KICAgICBwb3J0ID0gdS5nZXRQb3J0KCk7DQogICAgIGZpbGUgPSB1LmdldEZpbGUo
KTsNCiAgICAgcmVmID0gdS5nZXRSZWYoKTsNCisgICAgdXNlciA9IHUuZ2V0VXNlckluZm8oKTsN
CiANCiAgICAgLy8gR3Vlc3MgYSByZWFzb25hYmxlIHNpemUgZm9yIHRoZSBzdHJpbmcgYnVmZmVy
IHNvIHdlIGhhdmUgdG8gcmVzaXplDQogICAgIC8vIGF0IG1vc3Qgb25jZS4NCkBAIC00NzgsNyAr
NDkzLDEyIEBADQogICAgICAgfQ0KIA0KICAgICBpZiAoaG9zdC5sZW5ndGgoKSAhPSAwKQ0KLSAg
ICAgIHNiLmFwcGVuZCgiLy8iKS5hcHBlbmQoaG9zdCk7DQorICAgICAgew0KKwlzYi5hcHBlbmQo
Ii8vIik7DQorCWlmICh1c2VyICE9IG51bGwgJiYgISIiLmVxdWFscyh1c2VyKSkNCisJICBzYi5h
cHBlbmQodXNlcikuYXBwZW5kKCdAJyk7DQorCXNiLmFwcGVuZChob3N0KTsNCisgICAgICB9DQog
DQogICAgIC8vIE5vdGUgdGhhdCB0aGlzIHByb2R1Y2VzIGRpZmZlcmVudCByZXN1bHRzIGZyb20g
SkRLIDEuMiBhcyBKREsgMS4yDQogICAgIC8vIGlnbm9yZXMgYSBub24tZGVmYXVsdCBwb3J0IGlm
IGhvc3QgaXMgbnVsbCBvciAiIi4gIFRoYXQgaXMgaW5jb25zaXN0ZW50DQo=

--=-h80E+8iP48oRw/7O1D8O--

--=-iZ3gL3NxV8sDNzyS3dtE
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tAvixVhZCJWr9QwRApyqAJ9Fg0Pe0K8Tqgz5ot25+trwzAo0NgCfaLYJ
Ladfn7MiJX4iTKdSQh5hn8E=
=OQNZ
-----END PGP SIGNATURE-----

--=-iZ3gL3NxV8sDNzyS3dtE--




From MAILER-DAEMON Fri Nov 14 00:18:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKWLs-0005f3-LU
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 00:18:36 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKWLr-0005ev-3Q
	for classpath@gnu.org; Fri, 14 Nov 2003 00:18:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKWLL-0005an-7e
	for classpath@gnu.org; Fri, 14 Nov 2003 00:18:34 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKWLK-0005aE-NT
	for classpath@gnu.org; Fri, 14 Nov 2003 00:18:02 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id VAA05981;
	Thu, 13 Nov 2003 21:16:31 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 8C6E64F80B9; Thu, 13 Nov 2003 21:07:34 -0700 (MST)
To: Classpath Discussion Mailing List <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: ..  So, if we convert SUPPLY-SIDE SOYBEAN FUTURES into
	HIGH-YIELD T-BILL INDICATORS, the PRE-INFLATIONARY risks
	will DWINDLE to a rate of 2 SHOPPING SPREES per EGGPLANT!!
Date: 13 Nov 2003 21:07:34 -0700
Message-ID: <87wua3oant.fsf@fleche.redhat.com>
Lines: 114
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: reformatting: hacked jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 05:18:35 -0000

I've hacked jalopy a bit to generate output that conforms more
closely to what we'd like.

You can get it here:

    ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz

Also in that directory is "GNU.xml", my attempt at a GNU-like style
file.

I don't have anywhere to check in my changes; in the meantime they're
living here in an eclipse workspace.  I can generate a patch for
anybody who wants it.

A few caveats:

* I didn't add a GUI for the new options I added; I just set up their
  defaults to be what we'd like.  This is easy enough to change later
  if needed.

* jalopy always uses spaces for everything; the "tab" options don't do
  what we'd like.  Do we want tabs in the source?  If so, we can run
  the output through unexpand easily enough (or write a simple output
  filter that tabifies).  If not, we can all adjust our .emacs files
  to cope.

* Sometimes jalopy adds blank lines where we probably wouldn't.  See
  the attached Point.java patch.  I requested the deletion before
  "package" and the addition after the imports, but the other changes
  are jalopy's idea.  I'll try to look at this soon-ish.  It also
  adds blank lines around abstract methods, see the second patch.

* I disabled interpretation of javadoc (via a setting, not in the
  source), since our javadoc confuses jalopy.  So javadoc is never
  reformatted.

* I'd like to have it be able to delete "closing comments" after the
  final brace of a method or class (I usually remove these when I see
  them), but I haven't added this feature yet... not sure if we
  really wanted it.

* Bonus points for anybody who changes jalopy to remove redundant
  modifiers, like "public" in an interface.


Please try it out and let me know what you think.  I've only
spot-checked a few files in java.awt and javax.swing, we need more
eyes on this before we can use it in earnest.

I think we're pretty close to being able to use this.

Tom

Index: Point.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/Point.java,v
retrieving revision 1.7
diff -u -r1.7 Point.java
--- Point.java	21 Mar 2002 07:58:00 -0000	1.7
+++ Point.java	14 Nov 2003 03:56:44 -0000
@@ -35,12 +35,12 @@
 obligated to do so.  If you do not wish to do so, delete this
 exception statement from your version. */
 
-
 package java.awt;
 
 import java.awt.geom.Point2D;
 import java.io.Serializable;
 
+
 /**
  * This class represents a point on the screen using cartesian coordinates.
  * Remember that in screen coordinates, increasing x values go from left to
@@ -228,7 +228,9 @@
   {
     if (! (obj instanceof Point2D))
       return false;
+
     Point2D p = (Point2D) obj;
+
     return x == p.getX() && y == p.getY();
   }
 

Index: MenuPeer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/peer/MenuPeer.java,v
retrieving revision 1.10
diff -u -r1.10 MenuPeer.java
--- MenuPeer.java	12 Oct 2003 13:53:40 -0000	1.10
+++ MenuPeer.java	14 Nov 2003 04:13:42 -0000
@@ -35,15 +35,16 @@
 obligated to do so.  If you do not wish to do so, delete this
 exception statement from your version. */
 
-
 package java.awt.peer;
 
 import java.awt.MenuItem;
 
+
 public interface MenuPeer extends MenuItemPeer
 {
-  void addItem (MenuItem item);
-  void addSeparator ();
-  void delItem (int index);
-}
+  void addItem(MenuItem item);
 
+  void addSeparator();
+
+  void delItem(int index);
+}



From MAILER-DAEMON Fri Nov 14 00:32:26 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKWZG-0005uF-JW
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 00:32:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKWZE-0005tC-6v
	for classpath@gnu.org; Fri, 14 Nov 2003 00:32:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKWYh-0005XT-3H
	for classpath@gnu.org; Fri, 14 Nov 2003 00:32:23 -0500
Received: from [24.25.9.101] (helo=ms-smtp-02-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKWYg-0005Wo-Nf
	for classpath@gnu.org; Fri, 14 Nov 2003 00:31:50 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-02-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hAE4ULBC026638; Thu, 13 Nov 2003 23:30:22 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id AC861BE641; Thu, 13 Nov 2003 23:16:57 -0500 (EST)
Sender: cbj@haphazard.org
To: Michael Koch <konqueror@gmx.de>
References: <3FB396C3.8060705@kaffe.org>
	<1068745650.926.61.camel@elsschot.wildebeest.org>
	<20031113225252.GA24484@mail.konqueror.de>
From: Brian Jones <cbj@gnu.org>
Date: 13 Nov 2003 23:16:57 -0500
In-Reply-To: <20031113225252.GA24484@mail.konqueror.de>
Message-ID: <m3llqjlh3a.fsf@lyta.haphazard.org>
Lines: 10
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 05:32:24 -0000

Michael Koch <konqueror@gmx.de> writes:

> I think it would be really nice i you could commit this to libgcj too.
> This class is totally merged.

Just out of my curiosity, how does that whole process work?  

Brian
-- 
Brian Jones <cbj@gnu.org>



From MAILER-DAEMON Fri Nov 14 00:34:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKWbC-0006RX-BD
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 00:34:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKWb9-0006Or-55
	for classpath@gnu.org; Fri, 14 Nov 2003 00:34:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKWab-0006Gp-KU
	for classpath@gnu.org; Fri, 14 Nov 2003 00:34:20 -0500
Received: from [24.25.9.101] (helo=ms-smtp-02-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKWab-0006GT-8R
	for classpath@gnu.org; Fri, 14 Nov 2003 00:33:49 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-02-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hAE4WMBC027816; Thu, 13 Nov 2003 23:32:22 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id DF1EBBE641; Thu, 13 Nov 2003 23:18:57 -0500 (EST)
Sender: cbj@haphazard.org
To: tromey@redhat.com
References: <87wua3oant.fsf@fleche.redhat.com>
From: Brian Jones <cbj@gnu.org>
Date: 13 Nov 2003 23:18:57 -0500
In-Reply-To: <87wua3oant.fsf@fleche.redhat.com>
Message-ID: <m3he17lgzy.fsf@lyta.haphazard.org>
Lines: 11
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: reformatting: hacked jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 05:34:23 -0000

Tom Tromey <tromey@redhat.com> writes:

> * I didn't add a GUI for the new options I added; I just set up their
>   defaults to be what we'd like.  This is easy enough to change later
>   if needed.

Ok, I think we should make the "GNU" option do what we like if someone
does hack on the config piece.

-- 
Brian Jones <cbj@gnu.org>



From MAILER-DAEMON Fri Nov 14 06:03:18 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKbjR-0001kg-Ei
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 06:03:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKbjN-0001k0-K5
	for classpath@gnu.org; Fri, 14 Nov 2003 06:03:13 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKbhw-0001Kt-7j
	for classpath@gnu.org; Fri, 14 Nov 2003 06:02:15 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKbhf-0000zy-Bh
	for classpath@gnu.org; Fri, 14 Nov 2003 06:01:27 -0500
Received: (qmail 29989 invoked by uid 504); 14 Nov 2003 11:00:00 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 1.840773 secs); 14 Nov 2003 10:00:00 -0000
Received: from unknown (HELO localhost) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 14 Nov 2003 10:59:58 +0100
Date: Fri, 14 Nov 2003 11:02:58 +0100 (CET)
Message-Id: <20031114.110258.69381278.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Fri_Nov_14_11_02_58_2003_232)--"
Content-Transfer-Encoding: 7bit
Subject: CheckStyle and JDEE
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 11:03:14 -0000

----Security_Multipart(Fri_Nov_14_11_02_58_2003_232)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi everybody,

I think I'm not the only one here to work with emacs ;) I'm not also the
only one whwo use jdee to write java into emacs:
http://jdee.sunsite.dk/
(or if you use w3m in emacs: http://jdee.sunsite.dk/rootpage.html ;-) )

As you can see in the archive of the mailing list:

,----[ http://www.mail-archive.com/jde@sunsite.dk/msg06877.html ]
|   * From: Paul Kinnucan
|   * Subject: Planned Changes to CheckStyle Interface
|   * Date: Mon, 27 Oct 2003 10:04:32 -0800
| 
| Hi JDEE Users,
| 
| This is to alert you to the fact that I am planning to make a major
| change to the JDEE's interface to CheckStyle in the upcoming JDEE 2.3.3
| release and to give you the opportunity to give me some feedback before
| the plans are finalized.
| 
| [...]
| 
| Release 3.0 of CheckStyle replaces the properties method of
| customization with the use of XML configuration files. A user specifies
| a style by specifying a configuration file on the command line. The next
| release will support this new method by providing a customization
| variable named jde-checkstyle-style that allows you to specify either
| Sun's coding style or a custom style. If you specify Sun's style, the
| JDEE will point CheckStyle (via a command-line argument) to a
| configuration file that comes with the JDEE and defines the Sun
| standard. If you specify a custom style, you must enter the path of the
| configuration file that defines the custom standard. The JDEE will point
| CheckStyle to the custom configuration file that you specify.
| 
| [...]
`----

For reference, checkstyle is here:
http://checkstyle.sourceforge.net/

Best regards,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Fri_Nov_14_11_02_58_2003_232)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tKhV4vzFZu62tMIRAhG9AJ0WfcyNEnRmlk3DNkZT24/lMt0LMwCfUzCy
g7ELZluPjNVEhK+pKIGMnRs=
=pq/c
-----END PGP SIGNATURE-----

----Security_Multipart(Fri_Nov_14_11_02_58_2003_232)----



From MAILER-DAEMON Fri Nov 14 07:13:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKcpS-0005kh-Q4
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 07:13:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKcof-0005WB-0g
	for classpath@gnu.org; Fri, 14 Nov 2003 07:12:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKco2-0005Ju-Mc
	for classpath@gnu.org; Fri, 14 Nov 2003 07:12:37 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AKcmw-000544-4h; Fri, 14 Nov 2003 07:10:58 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AKboq-0003Ia-00; Fri, 14 Nov 2003 12:08:52 +0100
From: Mark Wielaard <mark@klomp.org>
To: Brian Jones <cbj@gnu.org>
In-Reply-To: <m3llqjlh3a.fsf@lyta.haphazard.org>
References: <3FB396C3.8060705@kaffe.org>
	<1068745650.926.61.camel@elsschot.wildebeest.org>
	<20031113225252.GA24484@mail.konqueror.de>
	<m3llqjlh3a.fsf@lyta.haphazard.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-yaTzLkrNm0hjjyHdeTMO"
Message-Id: <1068808157.922.198.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 14 Nov 2003 12:09:17 +0100
Cc: GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 12:13:32 -0000


--=-yaTzLkrNm0hjjyHdeTMO
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-14 at 05:16, Brian Jones wrote:
> Michael Koch <konqueror@gmx.de> writes:
>=20
> > I think it would be really nice i you could commit this to libgcj too.
> > This class is totally merged.
>=20
> Just out of my curiosity, how does that whole process work? =20

libgcj and GNU Classpath are mostly completely merged.
Basically people monitor both the classpath-commit and the gcj
java-patches mailinglist and pick up patches that have not been
approved/committed to both trees. Most libgcj committers also have
Classpath commit access and commit their changes to Classpath as soon as
they are accepted for libgcj. (libgcj has a good review process that I
hope we can adopt in the future for Classpath.)

Normally I test almost every change I make against both Classpath
(+Kissme) and gcj so that I can commit to both trees at once (after
approval on java-patches). At the moment I have a slightly hacked up gcj
here so I cannot easily test my patches on gcj so I don't submit patches
to them at the moment.

And from time to time people go through the following page
http://gcc.gnu.org/java/libgcj-classpath-compare.html
to see what has not gone into both trees and suggest to merge those
things. (Hopefully when kaffe is more merged with Classpath we can have
a similar page to compare kaffe-classpath). Michael has been a big help
here keeeping Classpath/libgcj in sync. Thanks Michael.

Cheers,

Mark

--=-yaTzLkrNm0hjjyHdeTMO
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tLfdxVhZCJWr9QwRAnM/AJ9V9sSlzvG2Vpko1hE6eXia/zBhQACgpNnq
9bwYmG2lR7qDmQbf/WnnMTU=
=rAhM
-----END PGP SIGNATURE-----

--=-yaTzLkrNm0hjjyHdeTMO--




From MAILER-DAEMON Fri Nov 14 13:03:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKiIU-00032w-DX
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 13:03:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKiIQ-00032C-AF
	for classpath@gnu.org; Fri, 14 Nov 2003 13:03:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKiHs-0002vM-SO
	for classpath@gnu.org; Fri, 14 Nov 2003 13:03:47 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKiHs-0002uw-Dy
	for classpath@gnu.org; Fri, 14 Nov 2003 13:03:16 -0500
Received: from [192.168.1.33] (196.46.dyn-adsl.customer.ch.easynet.net
	[217.8.196.46]) by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id BAC4B64662; Fri, 14 Nov 2003 18:01:47 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: Mark Wielaard <mark@klomp.org>
Date: Fri, 14 Nov 2003 18:00:39 +0100
Message-Id: <20031114170039.3555@smtp.mail.ch.easynet.net>
In-Reply-To: <1068828413.920.211.camel@elsschot.wildebeest.org>
References: <1068828413.920.211.camel@elsschot.wildebeest.org>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, graydon hoare <graydon@redhat.com>
Subject: Re: Mauve undo #1
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 18:03:51 -0000

Hi Mark and Graydon,

>With you recent patches to Classpath, Graydon his pending patch for
>libgcj and by adding the following line to
>javax/swing/plaf/basic/BasicDefaults.java:
>	put("AbstractUndoableEdit.undoText", "Undo");
>
>I got 25 passes with Classpath+Kissme.

25? It should be 35 :-(

Please add also the following:

>	put("AbstractUndoableEdit.redoText", "Redo");

Do we have a resource bundle that could get shared among all javax.swing
packages? If not, we probably should create one, since this text really
should be localized.

I'm cc'ing the list, if you don't mind.

Best,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Fri Nov 14 13:11:20 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AKiPd-0007iX-UZ
	for mharc-classpath@gnu.org; Fri, 14 Nov 2003 13:11:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AKiPY-0007bz-3u
	for classpath@gnu.org; Fri, 14 Nov 2003 13:11:12 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AKiOz-0006jA-D9
	for classpath@gnu.org; Fri, 14 Nov 2003 13:11:08 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AKiOf-0006Am-FX
	for classpath@gnu.org; Fri, 14 Nov 2003 13:10:17 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AKhQi-00048A-00; Fri, 14 Nov 2003 18:08:20 +0100
From: Mark Wielaard <mark@klomp.org>
To: Sascha Brawer <brawer@dandelis.ch>
In-Reply-To: <20031114170039.3555@smtp.mail.ch.easynet.net>
References: <1068828413.920.211.camel@elsschot.wildebeest.org>
	<20031114170039.3555@smtp.mail.ch.easynet.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-aPSAE9rq1fqvvxUZnlYW"
Message-Id: <1068829725.922.222.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 14 Nov 2003 18:08:45 +0100
Cc: GNU Classpath <classpath@gnu.org>, graydon hoare <graydon@redhat.com>
Subject: Re: Mauve undo #1
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 18:11:16 -0000


--=-aPSAE9rq1fqvvxUZnlYW
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-14 at 18:00, Sascha Brawer wrote:
> >With you recent patches to Classpath, Graydon his pending patch for
> >libgcj and by adding the following line to
> >javax/swing/plaf/basic/BasicDefaults.java:
> >	put("AbstractUndoableEdit.undoText", "Undo");
> >
> >I got 25 passes with Classpath+Kissme.
>=20
> 25? It should be 35 :-(

Sorry. I cannot count:
$ grep swing classes | kissme gnu.testlet.SimpleTestHarness -debug
0 of 35 tests failed

Cheers,

Mark

--=-aPSAE9rq1fqvvxUZnlYW
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tQwdxVhZCJWr9QwRAoj0AKCQtPJ7qVPPnPkqj0cOZEE6Nbn1gQCeKiuj
HfyEJMgvh/Tvo2XrgM2Fw4s=
=k4xN
-----END PGP SIGNATURE-----

--=-aPSAE9rq1fqvvxUZnlYW--




From MAILER-DAEMON Sat Nov 15 14:14:12 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AL5s3-0002t2-NT
	for mharc-classpath@gnu.org; Sat, 15 Nov 2003 14:14:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AL5s0-0002o0-HM
	for classpath@gnu.org; Sat, 15 Nov 2003 14:14:08 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AL5rO-0001oF-1D
	for classpath@gnu.org; Sat, 15 Nov 2003 14:14:02 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AL5rN-0001nR-HE
	for classpath@gnu.org; Sat, 15 Nov 2003 14:13:29 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AL4tv-0003gv-00
	for <classpath@gnu.org>; Sat, 15 Nov 2003 19:12:03 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AL4tu-0003gZ-00; Sat, 15 Nov 2003 19:12:02 +0100
Message-ID: <3FB66C72.6010408@kaffe.org>
Date: Sat, 15 Nov 2003 19:12:02 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>, 
	Jim Pick <jim@kaffe.org>
Content-Type: multipart/mixed; boundary="------------040601040004050205090406"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: [PATCH] Currency setter/getter methods for DateFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 19:14:10 -0000

This is a multi-part message in MIME format.
--------------040601040004050205090406
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

attached you'll find another trivial patch from Guilhem & Jim that I 
picked up during my re-syncing effort. Please review and check in. 
Guilhem wrote the methods, Jim added the import statement to make things 
compile in java/text/DecimalFormat.java, whike Guilhem wrote all of the 
patch to java/text/DecimalFormatSymbols.java alone.

cheers,
dalibor topic

ChangeLog:

2003-11-15  Guilhem Lavaux <guilhem@kaffe.org>,
	Jim Pick <jim@kaffe.org>

	* java/text/DecimalFormat.java (getCurrency, setCurrency): New 	
	methods.


2003-11-15 Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/DecimalFormatSymbols.java (getCurrency, 	
	setCurrency): New methods.

--------------040601040004050205090406
Content-Type: text/plain;
 name="cpath-decimal-format-currency.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-decimal-format-currency.diff"

Index: java/text/DecimalFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/DecimalFormat.java,v
retrieving revision 1.10
diff -u -r1.10 DecimalFormat.java
--- java/text/DecimalFormat.java	25 Oct 2003 00:16:24 -0000	1.10
+++ java/text/DecimalFormat.java	15 Nov 2003 17:38:15 -0000
@@ -37,6 +37,7 @@
 
 package java.text;
 
+import java.util.Currency;
 import java.util.Locale;
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
@@ -637,6 +638,11 @@
     return dest;
   }
 
+  public Currency getCurrency()
+  {
+    return symbols.getCurrency();
+  }
+
   public DecimalFormatSymbols getDecimalFormatSymbols ()
   {
     return symbols;
@@ -854,6 +860,11 @@
     pos.setIndex(index + suffix.length());
 
     return result;
+  }
+
+  public void setCurrency(Currency currency)
+  {
+    symbols.setCurrency(currency);
   }
 
   public void setDecimalFormatSymbols (DecimalFormatSymbols newSymbols)

--------------040601040004050205090406
Content-Type: text/plain;
 name="cpath-decimal-format-symbol-currency.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="cpath-decimal-format-symbol-currency.diff"

--- /var/tmp/PROJECTS/classpath//./java/text/DecimalFormatSymbols.java	Tue Jan 22 23:27:01 2002
+++ java/text/DecimalFormatSymbols.java	Mon Sep  1 17:46:50 2003
@@ -39,6 +39,7 @@
 package java.text;
 
 import java.io.Serializable;
+import java.util.Currency;
 import java.util.Locale;
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
@@ -195,6 +197,18 @@
   }
 
   /**
+   * Returns the currency corresponding to the currency symbol stored
+   * in the instance of <code>DecimalFormatSymbols</code>.
+   *
+   * @return A new instance of <code>Currency</code> if
+   * the currency code matches a known one.
+   */
+  public Currency getCurrency ()
+  {
+    return Currency.getInstance (currencySymbol);
+  }
+
+  /**
    * This method returns the currency symbol in local format.  For example,
    * "$" for Canadian dollars.
    *
@@ -354,6 +368,16 @@
   }
 
   /**
+   * This method sets the currency to the specified value.
+   *
+   * @param currency The new currency
+   */
+  public void setCurrency (Currency currency)
+  {
+    setCurrencySymbol (currency.getSymbol());
+  }
+
+  /**
    * This method sets the currency symbol to the specified value.
    *
    * @param currencySymbol The new currency symbol

--------------040601040004050205090406--




From MAILER-DAEMON Sat Nov 15 15:01:29 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AL6bo-0002dh-LT
	for mharc-classpath@gnu.org; Sat, 15 Nov 2003 15:01:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AL6bm-0002c0-79
	for classpath@gnu.org; Sat, 15 Nov 2003 15:01:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AL6bF-0002Ej-8N
	for classpath@gnu.org; Sat, 15 Nov 2003 15:01:24 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AL6bE-0001yd-Nd
	for classpath@gnu.org; Sat, 15 Nov 2003 15:00:52 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AL5Oe-00022o-Iq
	for classpath@gnu.org; Sat, 15 Nov 2003 13:43:48 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AL5O7-0001BR-00
	for <classpath@gnu.org>; Sat, 15 Nov 2003 19:43:15 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AL5O6-0001B9-00; Sat, 15 Nov 2003 19:43:14 +0100
Message-ID: <3FB673C1.6010206@kaffe.org>
Date: Sat, 15 Nov 2003 19:43:13 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>
Content-Type: multipart/mixed; boundary="------------090608070701000301000801"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 20:01:27 -0000

This is a multi-part message in MIME format.
--------------090608070701000301000801
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

attached is another small patch from Guilhem adding missing methods in 
FieldPosition. Please review & check in.

cheers,
dalibor topic

2003-11-15 Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/FieldPosition.java (field_attribute): New field.
	(FieldPosition (Format.Field), FieldPosition(Format.Field, int),
	getFieldAttribute) New methods.


--------------090608070701000301000801
Content-Type: text/plain;
 name="cpath-field-pos.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-field-pos.diff"

--- /var/tmp/PROJECTS/classpath//./java/text/FieldPosition.java	Tue Jan 22 23:27:01 2002
+++ java/text/FieldPosition.java	Tue Aug 26 11:29:53 2003
@@ -65,6 +65,38 @@
   private int end;
 
   /**
+   * This is the field attribute value.
+   */
+  private Format.Field field_attribute;
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id.
+   *
+   * @param field The field format attribute.
+   */
+  public FieldPosition (Format.Field field)
+  {
+    this.field_attribute = field;
+  }
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id is non null. The integer field id is only used if the Format.Field
+   * attribute is not used by the formatter.
+   *
+   * @param field The field format attribute.
+   * @param field_id The field identifier value.
+   */
+  public FieldPosition (Format.Field field, int field_id)
+  {
+    this.field_attribute = field;
+    this.field_id = field_id;
+  }
+
+  /**
    * This method initializes a new instance of <code>FieldPosition</code> to
    * have the specified field id.
    *
@@ -83,6 +115,11 @@
   public int getField ()
   {
     return field_id;
+  }
+
+  public Format.Field getFieldAttribute ()
+  {
+    return field_attribute;
   }
 
   /**

--------------090608070701000301000801--




From MAILER-DAEMON Sat Nov 15 17:58:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AL9Mb-00063R-Ib
	for mharc-classpath@gnu.org; Sat, 15 Nov 2003 17:57:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AL9MH-0005bL-K8
	for classpath@gnu.org; Sat, 15 Nov 2003 17:57:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AL9L4-0003kE-Vi
	for classpath@gnu.org; Sat, 15 Nov 2003 17:56:54 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AL9JX-0001Nn-Tu
	for classpath@gnu.org; Sat, 15 Nov 2003 17:54:47 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AL8E6-0006Ea-Sd
	for classpath@gnu.org; Sat, 15 Nov 2003 16:45:07 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AL8DU-00072m-00; Sat, 15 Nov 2003 22:44:28 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FB66C72.6010408@kaffe.org>
References: <3FB66C72.6010408@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-/2s6NTui/CRwh+YvpEf+"
Message-Id: <1068932694.946.527.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 15 Nov 2003 22:44:54 +0100
Cc: Jim Pick <jim@kaffe.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Currency setter/getter methods for DateFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 22:57:55 -0000


--=-/2s6NTui/CRwh+YvpEf+
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-15 at 19:12, Dalibor Topic wrote:
> 2003-11-15  Guilhem Lavaux <guilhem@kaffe.org>,
> 	Jim Pick <jim@kaffe.org>
>=20
> 	* java/text/DecimalFormat.java (getCurrency, setCurrency): New =09
> 	methods.
>=20
>=20
> 2003-11-15 Guilhem Lavaux <guilhem@kaffe.org>
>=20
> 	* java/text/DecimalFormatSymbols.java (getCurrency, =09
> 	setCurrency): New methods.

Thanks. Committed after adding some documentation about the new methods
to DecimalFormat.java.

Cheers,

Mark

--=-/2s6NTui/CRwh+YvpEf+
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tp5VxVhZCJWr9QwRAgdDAKCFOk9S2s3zvcoFC/xYJuuEyYSp9gCeMwQY
aiHx/jvmTheT67yahindxr0=
=uhOF
-----END PGP SIGNATURE-----

--=-/2s6NTui/CRwh+YvpEf+--




From MAILER-DAEMON Sat Nov 15 18:03:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AL9RU-0001qJ-3P
	for mharc-classpath@gnu.org; Sat, 15 Nov 2003 18:03:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AL9QY-0000aO-Mt
	for classpath@gnu.org; Sat, 15 Nov 2003 18:02:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AL9Pg-0008D1-7x
	for classpath@gnu.org; Sat, 15 Nov 2003 18:01:40 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AL9Pa-0007xy-H0
	for classpath@gnu.org; Sat, 15 Nov 2003 18:01:02 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AL8Q8-00075V-3n
	for classpath@gnu.org; Sat, 15 Nov 2003 16:57:32 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AL8Pf-00073B-00; Sat, 15 Nov 2003 22:57:03 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FB673C1.6010206@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-9ipNEfRb/TeV2JPwOvCE"
Message-Id: <1068933449.925.530.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 15 Nov 2003 22:57:29 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2003 23:02:56 -0000


--=-9ipNEfRb/TeV2JPwOvCE
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-15 at 19:43, Dalibor Topic wrote:
> 2003-11-15 Guilhem Lavaux <guilhem@kaffe.org>
>=20
> 	* java/text/FieldPosition.java (field_attribute): New field.
> 	(FieldPosition (Format.Field), FieldPosition(Format.Field, int),
> 	getFieldAttribute) New methods.
>=20

Shouldn't the hashCode(), equals() and possibly toString() methods be
updated to take the new field into account?

Cheers,

Mark

--=-9ipNEfRb/TeV2JPwOvCE
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/tqFIxVhZCJWr9QwRAtb4AJ4+dDmkAmcXgWwnhUcDpKLmSE5XagCeK9aU
hG/Vy5Q5i0KNzjU6oZ0bRms=
=B6GJ
-----END PGP SIGNATURE-----

--=-9ipNEfRb/TeV2JPwOvCE--




From MAILER-DAEMON Sun Nov 16 13:34:56 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALRjc-0003kM-2U
	for mharc-classpath@gnu.org; Sun, 16 Nov 2003 13:34:56 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALRjZ-0003jt-NL
	for classpath@gnu.org; Sun, 16 Nov 2003 13:34:53 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALRj3-0003ba-N7
	for classpath@gnu.org; Sun, 16 Nov 2003 13:34:52 -0500
Received: from [213.46.255.17] (helo=viefep16-int.chello.at)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALRj3-0003aV-5j
	for classpath@gnu.org; Sun, 16 Nov 2003 13:34:21 -0500
Received: from 6-allhosts ([80.109.234.144]) by viefep16-int.chello.at
	(InterMail vM.5.01.05.17 201-253-122-126-117-20021021) with ESMTP
	id <20031116172955.LEEE20342.viefep16-int.chello.at@6-allhosts>
	for <classpath@gnu.org>; Sun, 16 Nov 2003 18:29:55 +0100
From: Joseph Wenninger <jowenn@kde.org>
To: classpath@gnu.org
Content-Type: text/plain
Message-Id: <1069005110.2894.7.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 16 Nov 2003 17:51:51 +0000
Content-Transfer-Encoding: 7bit
Subject: awt - gtkpeers - threading
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2003 18:34:54 -0000

Hi

First a general question, are the gtk peers in the 0.06 tarball or in
cvs supposed to work ?

If yes:
1) Why is there a field native_state in the GtkMainThread accessed from
native functions, but nowhere defined in the class ?

2) Any ideas, opinions, suggestions how to use the gtk peer in a (I
think it is called) green thread environment ?
Right now for being able to show something I use  
gtk_events_pending(), gtk_main_iteration () on the native side and
Thread.sleep on the bytecode side instead of gtk_main. It is nice for
displaying a window, but not suited for real usage. Any ideas ?

Kind regards
Joseph Wenninger






From MAILER-DAEMON Sun Nov 16 14:55:37 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALSze-0003uA-MG
	for mharc-classpath@gnu.org; Sun, 16 Nov 2003 14:55:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALSzY-0003n8-Cq
	for classpath@gnu.org; Sun, 16 Nov 2003 14:55:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALSys-0003Qk-ET
	for classpath@gnu.org; Sun, 16 Nov 2003 14:55:17 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1ALSys-00038u-4D
	for classpath@gnu.org; Sun, 16 Nov 2003 14:54:46 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1ALRtY-0005pq-2Z
	for classpath@gnu.org; Sun, 16 Nov 2003 13:45:12 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id LAA09168;
	Sun, 16 Nov 2003 11:45:03 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 36F734F8243; Sun, 16 Nov 2003 11:35:56 -0700 (MST)
To: Joseph Wenninger <jowenn@kde.org>
References: <1069005110.2894.7.camel@localhost>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Is it NOUVELLE CUISINE when 3 olives are struggling with a scallop
	in a plate of SAUCE MORNAY?
Date: 16 Nov 2003 11:35:56 -0700
In-Reply-To: <1069005110.2894.7.camel@localhost>
Message-ID: <87ptfs5fg3.fsf@fleche.redhat.com>
Lines: 32
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: awt - gtkpeers - threading
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2003 19:55:32 -0000

>>>>> "Joseph" == Joseph Wenninger <jowenn@kde.org> writes:

Joseph> First a general question, are the gtk peers in the 0.06 tarball or in
Joseph> cvs supposed to work ?

No, not completely.  There are still plenty of bugs.  AWT is in active
development.

Joseph> 1) Why is there a field native_state in the GtkMainThread
Joseph> accessed from native functions, but nowhere defined in the
Joseph> class ?

Where do you see this?  I don't see a field named native_state
anywhere.  There is "native_state_table", but it is just an ordinary C
global, not a field.

Maybe this code has changed since 0.06; I didn't look.

Joseph> 2) Any ideas, opinions, suggestions how to use the gtk peer in a (I
Joseph> think it is called) green thread environment ?

The new standard Gtk thread code uses portable locking -- it uses JNI
calls to do its work.  This should work for any threading system.
Offhand I don't know whether this has been made the default yet; you'd
have to read the source to see.

>From your reference to green threads, I assume you want to use these
AWT peers with the Sun JDK.  Note that the peer interface is not
documented.  There's no guarantee our peers will work with Sun's
implementation.

Tom



From MAILER-DAEMON Sun Nov 16 16:30:02 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALUT4-0007Gr-1C
	for mharc-classpath@gnu.org; Sun, 16 Nov 2003 16:30:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALUT1-0007EP-BZ
	for classpath@gnu.org; Sun, 16 Nov 2003 16:29:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALUSV-0006jj-Mq
	for classpath@gnu.org; Sun, 16 Nov 2003 16:29:58 -0500
Received: from [213.46.255.27] (helo=viefep11-int.chello.at)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALUSU-0006j0-Sl
	for classpath@gnu.org; Sun, 16 Nov 2003 16:29:27 -0500
Received: from 6-allhosts ([80.109.234.144]) by viefep11-int.chello.at
	(InterMail vM.5.01.05.17 201-253-122-126-117-20021021) with ESMTP
	id <20031116202801.VHPC14424.viefep11-int.chello.at@6-allhosts>;
	Sun, 16 Nov 2003 21:28:01 +0100
From: Joseph Wenninger <jowenn@kde.org>
To: tromey@redhat.com
In-Reply-To: <87ptfs5fg3.fsf@fleche.redhat.com>
References: <1069005110.2894.7.camel@localhost>
	<87ptfs5fg3.fsf@fleche.redhat.com>
Content-Type: text/plain
Message-Id: <1069015793.26972.16.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 16 Nov 2003 20:49:56 +0000
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: awt - gtkpeers - threading
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2003 21:30:00 -0000

Hi

Am Son, den 16.11.2003 schrieb Tom Tromey um 18:35:
....
> Joseph> 1) Why is there a field native_state in the GtkMainThread
> Joseph> accessed from native functions, but nowhere defined in the
> Joseph> class ?
> 
> Where do you see this?  I don't see a field named native_state
> anywhere.  There is "native_state_table", but it is just an ordinary C
> global, not a field.
> 

In the 0.06 classpath  I see
Java_gnu_java_awt_peer_gtk_GtkMainThread_gtkInit (JNIEnv *env, jclass
clazz) -> 
MACRO:#define NSA_INIT(env, clazz) \
  native_state_table = init_state_table (env, clazz)
--->init_state_table_with_size (JNIEnv *env, jclass clazz, jint size)
{
...
  hash = (*env)->GetFieldID (env, clazz, "native_state", "I");

Could be that the problem is that we throw an exception, if a field
can't be found. Will look again in the jni documentation


....
> From your reference to green threads, I assume you want to use these
> AWT peers with the Sun JDK.  Note that the peer interface is not
> documented.  There's no guarantee our peers will work with Sun's
> implementation.

No. I have to do some developing practice during my studying and the
department at university I'm doing that, had developed an experimental
java jit/vm a long time ago. My job now is to port it to gnuclasspath.
it had it's own small class set before.
That thing doesn't use pthreads yet. It has it's own internal scheduler
and so on. My main problem is that once the gtk/g main loop has been
entered it doesn't return to the scheduler as long as the gtk main event
loop has been left, so it doesn't even finish the first show of a frame.

Kind regards
Joseph Wenninger




From MAILER-DAEMON Sun Nov 16 16:37:38 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALUaP-00058G-W6
	for mharc-classpath@gnu.org; Sun, 16 Nov 2003 16:37:37 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALUaK-00056d-Ap
	for classpath@gnu.org; Sun, 16 Nov 2003 16:37:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALUZm-0004t8-Lw
	for classpath@gnu.org; Sun, 16 Nov 2003 16:37:29 -0500
Received: from [32.97.182.105] (helo=e5.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1ALUZl-0004rX-KU
	for classpath@gnu.org; Sun, 16 Nov 2003 16:36:57 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e5.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id hAGKZSn9648440
	for <classpath@gnu.org>; Sun, 16 Nov 2003 15:35:29 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hAGKZRcC118016
	for <classpath@gnu.org>; Sun, 16 Nov 2003 15:35:27 -0500
In-Reply-To: <87ptfs5fg3.fsf@fleche.redhat.com>
Cc: classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OF6EB99036.5A5433F4-ON85256DE0.006E5A34-85256DE0.0071080A@us.ibm.com>
Date: Sun, 16 Nov 2003 15:35:26 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/16/2003 15:35:27,
	Serialize complete at 11/16/2003 15:35:27
Content-Type: multipart/alternative;
	boundary="=_alternative 0070FDC385256DE0_="
Subject: Re: awt - gtkpeers - threading
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2003 21:37:33 -0000

This is a multipart message in MIME format.
--=_alternative 0070FDC385256DE0_=
Content-Type: text/plain; charset="US-ASCII"

Jikes RVM uses a level of m-to-n threading and thus relies on the portable 
locking implementation that Tom mentioned.

In classpath 0.06 this was not the default and the function vector hadn't 
been updated to GTK 2.0 (so it didn't work at all).  I just tried with the 
cvs head of classpath, and it appears that the function vector has been 
updated (although my simple awt test program didn't work, but that might 
be a Jikes RVM problem, not a classpath defect).  I didn't look to see if 
the portable locking had become the default (we explicitly choose it by 
passing an arg to configure when building classpath for Jikes RVM).

--dave
--=_alternative 0070FDC385256DE0_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Jikes RVM uses a level of m-to-n threading
and thus relies on the portable locking implementation that Tom mentioned.</font>
<br>
<br><font size=2 face="sans-serif">In classpath 0.06 this was not the default
and the function vector hadn't been updated to GTK 2.0 (so it didn't work
at all). &nbsp;I just tried with the cvs head of classpath, and it appears
that the function vector has been updated (although my simple awt test
program didn't work, but that might be a Jikes RVM problem, not a classpath
defect). &nbsp;I didn't look to see if the portable locking had become
the default (we explicitly choose it by passing an arg to configure when
building classpath for Jikes RVM).</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 0070FDC385256DE0_=--



From MAILER-DAEMON Sun Nov 16 17:27:24 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALVMZ-0001Nk-OP
	for mharc-classpath@gnu.org; Sun, 16 Nov 2003 17:27:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALVGW-0003gD-EO
	for classpath@gnu.org; Sun, 16 Nov 2003 17:21:08 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALVG0-0003Zm-FT
	for classpath@gnu.org; Sun, 16 Nov 2003 17:21:07 -0500
Received: from [217.185.152.107] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1ALVDh-0008IW-Sq; Sun, 16 Nov 2003 17:18:14 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hAGMdIU01787; Sun, 16 Nov 2003 23:39:18 +0100
Message-ID: <3FB7FC87.6090205@kaffe.org>
Date: Sun, 16 Nov 2003 23:39:03 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: mailing list kaffe <kaffe@kaffe.org>, joeq-devel@lists.sourceforge.net,
	wonka-developers@acunia.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Sun, 16 Nov 2003 17:27:22 -0500
Cc: sablevm-developer@lists.sourceforge.net, debian-java@lists.debian.org,
	aegisvm-devel@lists.sourceforge.net, classpathx-discuss@gnu.org,
	classpathx-xml@gnu.org, jikesrvm-core@oss.software.ibm.com,
	java@gcc.gnu.org, GNU Classpath <classpath@gnu.org>,
	gnu-crypto-discuss@nongnu.org
Subject: [RFC] Upcoming Apache Software Foundation License changes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2003 22:21:09 -0000

Hi all,

excuse me for cross-posting the following e-mail to so many diverse 
projects. As I'm subscribed to all those projects mailing lists, I was 
surprised to notice a lack of discussion on the effect of the upcoming 
Apache Software Foundation (ASF) license changes [1] on them.

Most of you know ASF for their great work on free java software. ASF is 
increasingly becoming the testbed, and reference implementation provider 
for Java APIs, which end up in the implementations provided by Sun. The 
ASF is trying to modify its licenses to ensure GPL compatibility on one 
hand, and satisfy JSPA (Java Specification Participation Agreement) [2] 
requirements on the other hand, among other goals.

A new set of licenses replaces the single Apache license by 3 separate 
licenses, that inted to cover general Apache projects [3], reference 
implementation of a JSR (Java Specification Request) [4], and testing 
compatibility kits (TCKs) of a JSR [5].

As many of you are involved in projects that provide free 
implementations of parts of the runtime environment for Java programs, 
it would be nice if you could take some time to comment on the proposed 
licenses to the Apache license discussion mailing list. Instructions how 
to join that mailing list are povided on [1], the archives are on [6].

The effect of the upcoming ASF license change *could* be beneficial to 
the free software java world and the ASF wants to achieve that. The 
availability of RIs and TCKs under a liberal license seems particularly 
attractive to free software Java projects.

You can help fixing problems with the next apache licenses if you take 
some time to comment on them. If you intend to so so, make sure to 
submit your comment today. Yes, today is the last day, therefore you get 
this cross-posted e-mail, and so on. Anyway, comment on what you 
percieve as problematic, and your grandgrandchildren may thank you ;)

For another take on this issue, please take a look at Mark Wielaard's 
(GNU Classpath maintainer) reply [7] to an earlier version of this RFC 
sent to the debian-java mailing list, who asks developers to take a look 
at the RI and TCK licenses, as the ASF hasn't received many comments on 
those.

thanks,
dalibor topic

[1] http://www.apache.org/licenses/proposed/
[2] http://www.jcp.org/aboutJava/communityprocess/JSPA.pdf
[3] http://www.apache.org/licenses/proposed/LICENSE-2.0.txt
[4] http://www.apache.org/licenses/proposed/ri-license.txt
[5] http://www.apache.org/licenses/proposed/tck-license.txt
[6] 
http://nagoya.apache.org/eyebrowse/SummarizeList?listName=license@apache.org&by=thread
[7] 
http://lists.debian.org/debian-java/2003/debian-java-200311/msg00102.html




From MAILER-DAEMON Mon Nov 17 15:19:26 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALpqI-0004Ry-FW
	for mharc-classpath@gnu.org; Mon, 17 Nov 2003 15:19:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALpqF-0004R0-JW
	for classpath@gnu.org; Mon, 17 Nov 2003 15:19:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALppj-0004EJ-BN
	for classpath@gnu.org; Mon, 17 Nov 2003 15:19:22 -0500
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALppi-0004DM-PZ
	for classpath@gnu.org; Mon, 17 Nov 2003 15:18:50 -0500
Received: from tangency.co.uk (localhost [127.0.0.1])
	by outgoing.tangency.co.uk (Postfix) with ESMTP id E62E360882
	for <classpath@gnu.org>; Mon, 17 Nov 2003 19:16:07 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by tangency.co.uk (MailMonitor for SMTP v1.2.2 ) ;
	Mon, 17 Nov 2003 19:16:07 +0000 (GMT)
Received: from wraith (wraith.tangency.co.uk [192.168.1.4])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by tangency.co.uk (Postfix) with ESMTP id B8A6360882
	for <classpath@gnu.org>; Mon, 17 Nov 2003 19:16:07 +0000 (GMT)
Date: Mon, 17 Nov 2003 19:16:24 -0000
To: Kaffe Mailing List <kaffe@kaffe.org>
References: <oprysks71yreuyrv@tangency.co.uk>
	<00ae01c3ad32$74373110$0300a8c0@allanon>
From: "S. Meslin-Weber" <twiun@adorphuye.com>
Message-ID: <oprysqhmiwreuyrv@tangency.co.uk>
In-Reply-To: <00ae01c3ad32$74373110$0300a8c0@allanon>
User-Agent: Opera7.21/Win32 M2 build 3218
Resent-To: GNU Classpath Mailing List <classpath@gnu.org>
Resent-From: "S. Meslin-Weber" <twiun@adorphuye.com>
Content-Type: text/plain; format=flowed; charset=iso-8859-15
MIME-Version: 1.0
Resent-Date: Mon, 17 Nov 2003 19:17:23 -0000
Resent-Message-ID: <oprysqi9woreuyrv@tangency.co.uk>
Content-Transfer-Encoding: quoted-printable
Cc: 
Subject: Graphical Algorithm documents
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2003 20:19:24 -0000

Hi Everyone,

I stumbled on some interesting algorithm documents today and thought=20
others implementing low-level primitives in Java (Graphics and/or Java2D)=
=20
might find them useful. I emailed the author and we are welcome to use th=
e=20
documents at:

http://www.magic-software.com/Documentation/

Hope some other than I will find this useful!

Thanks,

Stephane

P.S. I'm including his email for information (both addresses are readily=20
available on our respective sites so no point masking them):

-------------------------------------------------------------------------=
-
From: Dave Eberly <eberly@magic-software.com>
To: "S. Meslin-Weber" <twiun@adorphuye.com>
Subject: Re: Information request
Date: Mon, 17 Nov 2003 12:44:28 -0500

> Hello Stephane.
>
>> I develop open source software and recently came across the files
>> contained on your website: http://www.magic-software.com/Documentation=
/
>> through a google search. I am implementing some low-level graphical
>> primitives in Java and searched for an integerised ellipse algorithm.
>>
>> Before using these documents as the basis for my implementation I woul=
d
>> like to request your permission to do so. I also believe that others i=
n
>> related open source projects could benefit from your documentation, ar=
e
>> there any plans on making them available from your main site?
>
> You may reach the documentation from the home page, select the
> "Source Code" tab, then select the "Documentation" tab.  Also from
> the "Source Code" tab, select the "Image Analysis" tab.  At the bottom
> of that page are files WmlRasterDrawing.{h,cpp}.  These files contain
> implementations of integerised ellipse algorithms.
>
> You are welcome to use the documentation and the source for your
> projects.
>
> --
> Dave Eberly
> eberly@magic-software.com
> http://www.magic-software.com
> http://www.wild-magic.com
>
>
>




From MAILER-DAEMON Mon Nov 17 21:30:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ALvdJ-0000aZ-4B
	for mharc-classpath@gnu.org; Mon, 17 Nov 2003 21:30:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ALvdD-0000SV-Bd
	for classpath@gnu.org; Mon, 17 Nov 2003 21:30:19 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ALvcd-0008JD-A9
	for classpath@gnu.org; Mon, 17 Nov 2003 21:30:14 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALvcc-0008Fl-8g
	for classpath@gnu.org; Mon, 17 Nov 2003 21:29:42 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id SAA09222
	for <classpath@gnu.org>; Mon, 17 Nov 2003 18:28:16 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 252074F8090; Mon, 17 Nov 2003 18:19:02 -0700 (MST)
To: Classpath Discussion Mailing List <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I LOVE juxtaposing th' splendor of an unpopulated ARROYO with
	th' SLEEK lines of ``NARCISSUS-X'', my new SPORTS UTILITY VEHICLE!
Date: 17 Nov 2003 18:19:02 -0700
Message-ID: <878ymexym1.fsf@fleche.redhat.com>
Lines: 29
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 02:30:22 -0000

Raif Naffah sent me a couple nice jalopy patches to implement things
from my last wish-list.  I wrote a new patch myself, to get jalopy to
use tabs for indentation in the way we expect.

I made a new release with these improvements.  Once again, it is here:

    ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz

You'll also want this file, which is the GNU.xml style:

    ftp://sources.redhat.com/pub/java/GNU.xml

This is somewhat different from the last one.


This version seems to be much better.  The strange Point.java change
has disappeared (I didn't try to find out why).

At this point I think we are ready to try this version of jalopy for
real.  I propose we pick a package to reformat and check in.
Preferably we'd pick something where active work is going on, so we
could more easily notice whatever jalopy doesn't handle well.


Long term, we need to find a cvs repository for this version.  We
should also put GNU.xml into the classpath repository; I'll do this if
we're all on board for the test drive.

Tom



From MAILER-DAEMON Tue Nov 18 15:33:37 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMCXT-0001Tm-7a
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 15:33:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMCX8-000103-D8
	for classpath@gnu.org; Tue, 18 Nov 2003 15:33:10 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMCWG-000815-1z
	for classpath@gnu.org; Tue, 18 Nov 2003 15:32:47 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMCWF-0007ys-FT
	for classpath@gnu.org; Tue, 18 Nov 2003 15:32:15 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMBYl-0007XE-00
	for <classpath@gnu.org>; Tue, 18 Nov 2003 20:30:47 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMBYj-0007Wp-00; Tue, 18 Nov 2003 20:30:45 +0100
Message-ID: <3FBA7364.9060206@kaffe.org>
Date: Tue, 18 Nov 2003 20:30:44 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
In-Reply-To: <1068933449.925.530.camel@elsschot.wildebeest.org>
Content-Type: multipart/mixed; boundary="------------080505040206020503090508"
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 20:33:29 -0000

This is a multi-part message in MIME format.
--------------080505040206020503090508
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi Mark,

Mark Wielaard wrote:
> Hi,
> 
> On Sat, 2003-11-15 at 19:43, Dalibor Topic wrote:
> 
>>2003-11-15 Guilhem Lavaux <guilhem@kaffe.org>
>>
>>	* java/text/FieldPosition.java (field_attribute): New field.
>>	(FieldPosition (Format.Field), FieldPosition(Format.Field, int),
>>	getFieldAttribute) New methods.
>>
> 
> 
> Shouldn't the hashCode(), equals() and possibly toString() methods be
> updated to take the new field into account?

Thanks for pointing that out. Please take a look at the updated, 
attached patch, and check it in.

2003-11-18 Guilhem Lavaux <guilhem@kaffe.org>

     * java/text/FieldPosition.java (field_attribute): New field.
     (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
     getFieldAttribute) New methods.

2003-11-18 Dalibor Topic <robilad@kaffe.org>

     * java/text/FieldPosition.java (equals) : Adapted to handle
     field_attribute. Added fast-circuit check for comparison to self.
     Replaced use of instanceof by getClass to fix symmetry for derived
     types.
     (toString) Adapted to handle field_attribute. Improved readability.
     (hashCode) New method.

--------------080505040206020503090508
Content-Type: text/plain;
 name="FieldPosition.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="FieldPosition.diff"

Index: java/text/FieldPosition.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/FieldPosition.java,v
retrieving revision 1.5
diff -u -r1.5 FieldPosition.java
--- java/text/FieldPosition.java	22 Jan 2002 22:27:01 -0000	1.5
+++ java/text/FieldPosition.java	18 Nov 2003 18:42:32 -0000
@@ -65,6 +65,38 @@
   private int end;
 
   /**
+   * This is the field attribute value.
+   */
+  private Format.Field field_attribute;
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id.
+   *
+   * @param field The field format attribute.
+   */
+  public FieldPosition (Format.Field field)
+  {
+    this.field_attribute = field;
+  }
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id is non null. The integer field id is only used if the Format.Field
+   * attribute is not used by the formatter.
+   *
+   * @param field The field format attribute.
+   * @param field_id The field identifier value.
+   */
+  public FieldPosition (Format.Field field, int field_id)
+  {
+    this.field_attribute = field;
+    this.field_id = field_id;
+  }
+
+  /**
    * This method initializes a new instance of <code>FieldPosition</code> to
    * have the specified field id.
    *
@@ -85,6 +117,11 @@
     return field_id;
   }
 
+  public Format.Field getFieldAttribute ()
+  {
+    return field_attribute;
+  }
+
   /**
    * This method returns the beginning index for this field.
    *
@@ -132,8 +169,8 @@
    * <ul>
    * <li>The specified object is not <code>null</code>.
    * <li>The specified object is an instance of <code>FieldPosition</code>.
-   * <li>The specified object has the same field identifier and beginning
-   * and ending index as this object.
+   * <li>The specified object has the same field identifier, field attribute 
+   * and beginning and ending index as this object.
    * </ul>
    *
    * @param obj The object to test for equality to this object.
@@ -143,15 +180,39 @@
    */
   public boolean equals (Object obj)
   {
-    if (! (obj instanceof FieldPosition))
+    if (this == obj)
+      return true;
+
+    if (obj != null && (obj.getClass() != this.getClass()))
       return false;
 
     FieldPosition fp = (FieldPosition) obj;
     return (field_id == fp.field_id
+	    && (field_attribute == fp.field_attribute 
+		|| (field_attribute != null 
+		    && field_attribute.equals(fp.field_attribute)))
 	    && begin == fp.begin
 	    && end == fp.end);
   }
 
+
+  /**
+   * This method returns a hash value for this object
+   * 
+   * @return A hash value for this object.
+   */
+  public int hashCode ()
+  {
+    int hash = 7;
+
+    hash = 31 * hash + field_id;
+    hash = 31 * hash + begin;
+    hash = 31 * hash + end;
+    hash = 31 * hash + (null == field_attribute ? 0 : field_attribute.hashCode());
+
+    return hash;
+  }
+
   /**
    * This method returns a <code>String</code> representation of this
    * object.
@@ -160,7 +221,11 @@
    */
   public String toString ()
   {
-    return (getClass ().getName () + "[field=" + getField () + ",beginIndex="
-	    + getBeginIndex () + ",endIndex=" + getEndIndex () + "]");
+    return (getClass ().getName ()
+	    + "[field=" + getField ()
+	    + ",attribute=" + getFieldAttribute ()
+	    + ",beginIndex=" + getBeginIndex () 
+	    + ",endIndex=" + getEndIndex () 
+	    + "]");
   }
 }

--------------080505040206020503090508--




From MAILER-DAEMON Tue Nov 18 16:06:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMD3f-0003rC-Ls
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 16:06:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMD3b-0003nT-Qp
	for classpath@gnu.org; Tue, 18 Nov 2003 16:06:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMD35-00032k-7T
	for classpath@gnu.org; Tue, 18 Nov 2003 16:06:42 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMD2s-0002lT-5z
	for classpath@gnu.org; Tue, 18 Nov 2003 16:05:58 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-75-220.ewetel.net
	[80.228.75.220])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id hAIK3rTR001855;
	Tue, 18 Nov 2003 21:03:56 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AMC5F-0005r4-00; Tue, 18 Nov 2003 21:04:21 +0100
Date: Tue, 18 Nov 2003 21:04:21 +0100
From: Michael Koch <konqueror@gmx.de>
To: Dalibor Topic <robilad@kaffe.org>
Message-ID: <20031118200421.GA21816@mail.konqueror.de>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FBA7364.9060206@kaffe.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 21:06:45 -0000

On Tue, Nov 18, 2003 at 08:30:44PM +0100, Dalibor Topic wrote:
> 2003-11-18 Guilhem Lavaux <guilhem@kaffe.org>
> 
>     * java/text/FieldPosition.java (field_attribute): New field.
>     (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
>     getFieldAttribute) New methods.
> 
> 2003-11-18 Dalibor Topic <robilad@kaffe.org>
> 
>     * java/text/FieldPosition.java (equals) : Adapted to handle
>     field_attribute. Added fast-circuit check for comparison to self.
>     Replaced use of instanceof by getClass to fix symmetry for derived
>     types.
>     (toString) Adapted to handle field_attribute. Improved readability.
>     (hashCode) New method.

There are some missing ':'. The rule is:

	(methodname): description of change.



Michael



From MAILER-DAEMON Tue Nov 18 16:52:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMDlm-0003bh-IS
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 16:52:22 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMDli-0003Xi-VO
	for classpath@gnu.org; Tue, 18 Nov 2003 16:52:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMDl0-0002ry-5l
	for classpath@gnu.org; Tue, 18 Nov 2003 16:52:05 -0500
Received: from [217.185.152.93] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMDku-0002fX-Ue
	for classpath@gnu.org; Tue, 18 Nov 2003 16:51:29 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hAIMEkH01405; Tue, 18 Nov 2003 23:14:47 +0100
Message-ID: <3FBA99D2.9010106@kaffe.org>
Date: Tue, 18 Nov 2003 23:14:42 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
	<20031118200421.GA21816@mail.konqueror.de>
In-Reply-To: <20031118200421.GA21816@mail.konqueror.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 21:52:20 -0000

Michael Koch wrote:
> On Tue, Nov 18, 2003 at 08:30:44PM +0100, Dalibor Topic wrote:
> 
>>2003-11-18 Guilhem Lavaux <guilhem@kaffe.org>
>>
>>    * java/text/FieldPosition.java (field_attribute): New field.
>>    (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
>>    getFieldAttribute) New methods.
>>
>>2003-11-18 Dalibor Topic <robilad@kaffe.org>
>>
>>    * java/text/FieldPosition.java (equals) : Adapted to handle
>>    field_attribute. Added fast-circuit check for comparison to self.
>>    Replaced use of instanceof by getClass to fix symmetry for derived
>>    types.
>>    (toString) Adapted to handle field_attribute. Improved readability.
>>    (hashCode) New method.
> 
> 
> There are some missing ':'. The rule is:
> 
> 	(methodname): description of change.

thnaks for catching that one. how about:

2003-11-18 Guilhem Lavaux <guilhem@kaffe.org>

     * java/text/FieldPosition.java (field_attribute): New field.
     (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
     getFieldAttribute): New methods.

2003-11-18 Dalibor Topic <robilad@kaffe.org>

     * java/text/FieldPosition.java (equals): Adapted to handle
     field_attribute. Added fast-circuit check for comparison to self.
     Replaced use of instanceof by getClass to fix symmetry for derived
     types.
     (toString): Adapted to handle field_attribute. Improved readability.
     (hashCode): New method.

cheers,
dalibor topic




From MAILER-DAEMON Tue Nov 18 17:30:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMEMl-0005tD-L6
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 17:30:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMEMi-0005ri-D4
	for classpath@gnu.org; Tue, 18 Nov 2003 17:30:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMEM1-0005e1-Hv
	for classpath@gnu.org; Tue, 18 Nov 2003 17:30:20 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMEM1-0005d4-05
	for classpath@gnu.org; Tue, 18 Nov 2003 17:29:49 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMDNx-0007VJ-00; Tue, 18 Nov 2003 22:27:45 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FBA7364.9060206@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-eAg7JcsHMWMPXR2DgzQU"
Message-Id: <1069190892.1745.23.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 18 Nov 2003 22:28:12 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 22:30:34 -0000


--=-eAg7JcsHMWMPXR2DgzQU
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 2003-11-18 at 20:30, Dalibor Topic wrote:
>     * <li>The specified object is an instance of <code>FieldPosition</cod=
e>.
> -   * <li>The specified object has the same field identifier and beginnin=
g
> -   * and ending index as this object.
> +   * <li>The specified object has the same field identifier, field attri=
bute=20
> +   * and beginning and ending index as this object.
>     * </ul>
>     *
>     * @param obj The object to test for equality to this object.
> @@ -143,15 +180,39 @@
>     */
>    public boolean equals (Object obj)
>    {
> -    if (! (obj instanceof FieldPosition))
> +    if (this =3D=3D obj)
> +      return true;
> +
> +    if (obj !=3D null && (obj.getClass() !=3D this.getClass()))
>        return false;

The documentation and code don't match up now.
My Class Library book seems to indicate that it actually is instanceof,
thought in most cases your code comparing the actual Class seems more
correct.

> +  /**
> +   * This method returns a hash value for this object
> +   *=20
> +   * @return A hash value for this object.
> +   */
> +  public int hashCode ()
> +  {
> +    int hash =3D 7;
> +
> +    hash =3D 31 * hash + field_id;
> +    hash =3D 31 * hash + begin;
> +    hash =3D 31 * hash + end;
> +    hash =3D 31 * hash + (null =3D=3D field_attribute ? 0 : field_attrib=
ute.hashCode());
> +
> +    return hash;
> +  }

Just curious, why this particular hash function?
I couldn't find one specified, so I guess any good one will do.
Don't know if you need to include the field_attribute.hashCode() since
it will probably depend on the field_id in almost all cases.

Cheers,

Mark

--=-eAg7JcsHMWMPXR2DgzQU
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/uo7sxVhZCJWr9QwRApF2AJ4hZ0JikRYMgQVAcLqJwkQwQ12I3gCfUYjW
U5wOAdQyzpWJ/5Q8tt5d+Aw=
=2ujb
-----END PGP SIGNATURE-----

--=-eAg7JcsHMWMPXR2DgzQU--




From MAILER-DAEMON Tue Nov 18 17:55:33 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMEku-0004qi-QI
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 17:55:32 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMEks-0004pQ-M4
	for classpath@gnu.org; Tue, 18 Nov 2003 17:55:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMEkM-0004ep-GR
	for classpath@gnu.org; Tue, 18 Nov 2003 17:55:29 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMEkM-0004ea-29
	for classpath@gnu.org; Tue, 18 Nov 2003 17:54:58 -0500
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AMDmu-0005Mg-00
	for <classpath@gnu.org>; Tue, 18 Nov 2003 22:53:32 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMDms-0005MY-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 22:53:30 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AMDms-0005B4-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 22:53:30 +0100
From: graydon hoare <graydon@redhat.com>
Date: 18 Nov 2003 16:51:55 -0500
Lines: 174
Message-ID: <87wu9xs5tw.fsf@dub.venge.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Sender: news <news@sea.gmane.org>
Cc: java-patches@gcc.gnu.org
Subject: [PATCH] attributed string fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 22:55:31 -0000

--=-=-=

hi,

this fixes some arithmetic and semantic errors with attributed
strings.

-graydon

2003-11-18  Graydon Hoare  <graydon@redhat.com>

	* java/text/AttributedString.java: Fix arithmetic.
	* java/text/AttributedStringIterator.java: Likewise.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
  filename=j2d-attributed-string-fix.patch

--- java/text/AttributedString.java	22 Jan 2002 22:27:01 -0000	1.4
+++ java/text/AttributedString.java	17 Nov 2003 17:38:59 -0000
@@ -319,7 +319,7 @@
 public void
 addAttribute(AttributedCharacterIterator.Attribute attrib, Object value)
 {
-  addAttribute(attrib, value, 0, sci.getEndIndex() - 1);
+  addAttribute(attrib, value, 0, sci.getEndIndex());
 }
 
 /*************************************************************************/
@@ -388,8 +388,7 @@
 public AttributedCharacterIterator
 getIterator()
 {
-  return(new AttributedStringIterator(sci, attribs, 0, sci.getEndIndex() - 1,
-                                      null));
+  return(new AttributedStringIterator(sci, attribs, 0, sci.getEndIndex(), null));
 }
 
 /*************************************************************************/
@@ -408,8 +407,8 @@
 public AttributedCharacterIterator
 getIterator(AttributedCharacterIterator.Attribute[] attributes)
 {
-  return(getIterator(attributes, 0, sci.getEndIndex() - 1));
+  return(getIterator(attributes, 0, sci.getEndIndex()));
 }
 
 /*************************************************************************/
--- java/text/AttributedStringIterator.java	22 Jan 2002 22:27:01 -0000	1.4
+++ java/text/AttributedStringIterator.java	17 Nov 2003 17:38:59 -0000
@@ -217,39 +217,28 @@
 public synchronized int
 getRunLimit(Set attribute_set)
 {
-  int orig_index = ci.getIndex();
-  int run_limit;
-
-  do  
-    {
-      run_limit = ci.getIndex();
-
-      Map attribute_map = getAttributes();
-
-      boolean found = false;
-      Iterator iter = attribute_set.iterator();
-      while(iter.hasNext()) 
-        if (!attribute_map.containsKey(iter.next()))
-          {
-            found = true;
-            break;
-          }
-
-      if (found)
-        break;
-    }
-  while (ci.next() != CharacterIterator.DONE);
-
-  boolean hit_end = (ci.previous() == CharacterIterator.DONE);
-
-  ci.setIndex(orig_index);
-
-  if (run_limit == orig_index)
-    return(-1); // No characters match the given attributes
-//  else if (!hit_end)
-//    --run_limit;
-
-  return(run_limit); 
+    boolean hit = false;
+    int runLimit = ci.getEndIndex ();
+    int pos = ci.getIndex ();
+
+    for (int i = 0; i < attribs.length; ++i)
+	{
+	    if (pos >= attribs[i].begin_index &&
+		pos <= attribs[i].end_index)
+		{
+		    Iterator iter = attribute_set.iterator();
+		    while(iter.hasNext()) 
+			if (attribs[i].attribs.containsKey(iter.next()))
+			    {
+				hit = true;
+				runLimit = Math.min(runLimit, attribs[i].end_index);
+			    }
+		}
+	}
+    if (hit)
+	return runLimit;
+    else
+	return -1;
 }
 
 /*************************************************************************/
@@ -277,35 +266,28 @@
 public int
 getRunStart(Set attribute_set)
 {
-  int orig_index = ci.getIndex();
-  int run_start;
-
-  do  
-    {
-      run_start = ci.getIndex();
-
-      Map attribute_map = getAttributes();
-
-      Iterator iter = attribute_set.iterator();
-      while(iter.hasNext())
-        if (!attribute_map.containsKey(iter.next()))
-          break;
-
-      if (iter.hasNext())
-        break;
-    }
-  while (ci.previous() != CharacterIterator.DONE);
-
-  boolean hit_beginning = (ci.previous() == CharacterIterator.DONE);
-
-  ci.setIndex(orig_index);
-
-  if (run_start == orig_index)
-    return(-1); // No characters match the given attributes
-  else if (!hit_beginning)
-    ++run_start;
-
-  return(run_start); 
+    boolean hit = false;
+    int runBegin = 0;
+    int pos = ci.getIndex ();
+
+    for (int i = 0; i < attribs.length; ++i)
+	{
+	    if (pos >= attribs[i].begin_index &&
+		pos <= attribs[i].end_index)
+		{
+		    Iterator iter = attribute_set.iterator();
+		    while(iter.hasNext()) 
+			if (attribs[i].attribs.containsKey(iter.next()))
+			    {
+				hit = true;
+				runBegin = Math.max(runBegin, attribs[i].begin_index);
+			    }
+		}
+	}
+    if (hit)
+	return runBegin;
+    else
+	return -1;
 }
 
 /*************************************************************************/

--=-=-=--




From MAILER-DAEMON Tue Nov 18 18:12:23 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMF1D-0006i7-Nl
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 18:12:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMF1B-0006i2-Kk
	for classpath@gnu.org; Tue, 18 Nov 2003 18:12:21 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMF0a-0006cB-Nq
	for classpath@gnu.org; Tue, 18 Nov 2003 18:12:15 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMF0a-0006c4-4W
	for classpath@gnu.org; Tue, 18 Nov 2003 18:11:44 -0500
Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AME38-0005WE-00
	for <classpath@gnu.org>; Tue, 18 Nov 2003 23:10:18 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMDqW-0005Nn-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 22:57:16 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AMDqW-0005Iy-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 22:57:16 +0100
From: graydon hoare <graydon@redhat.com>
Date: 18 Nov 2003 16:55:44 -0500
Lines: 114
Message-ID: <87smkls5nj.fsf@dub.venge.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Sender: news <news@sea.gmane.org>
Cc: java-patches@gcc.gnu.org
Subject: [PATCH] text layout implementation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:12:22 -0000

--=-=-=

hi,

this patch implements simple awt text layouts using attributed strings
and j2d glyph vectors. it will probably need further work, but it is
enough to get the swing text system limping along.

-graydon

2003-11-18  Graydon Hoare  <graydon@redhat.com>

	* java/awt/font/TextLayout.java: Implement simple layouts
	using attributed strings and glyph vectors.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=j2d-textlayout-fix.patch

--- java/awt/font/TextLayout.java       17 Feb 2003 08:05:50 -0000      1.1
+++ java/awt/font/TextLayout.java       18 Nov 2003 21:27:04 -0000
@@ -43,8 +43,12 @@
 import java.awt.Shape;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.Rectangle2D;
+import java.text.CharacterIterator;
 import java.text.AttributedCharacterIterator;
+import java.text.AttributedString;
 import java.util.Map;
+import java.awt.font.TextAttribute;
+
 
 /**
  * @author Michael Koch
@@ -67,24 +71,26 @@
     }
   }
 
+  private AttributedString attributedString;
   private FontRenderContext fontRenderContext;
   
   public TextLayout (AttributedCharacterIterator text, FontRenderContext frc)
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (text);
+    fontRenderContext = frc;
   }
 
   public TextLayout (String string, Font font, FontRenderContext frc) 
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (string);
+    attributedString.addAttribute (TextAttribute.FONT, font);
+    fontRenderContext = frc;
   }
 
   public TextLayout (String string, Map attributes, FontRenderContext frc) 
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (string, attributes);
+    fontRenderContext = frc;
   }
 
   protected Object clone ()
@@ -102,7 +108,42 @@
 
   public void draw (Graphics2D g2, float x, float y) 
   {
-    throw new Error ("not implemented");
+    AttributedCharacterIterator ci = attributedString.getIterator ();
+    Font defFont = g2.getFont ();
+
+    for (char c = ci.first ();
+         c != CharacterIterator.DONE;
+         c = ci.next ())
+      {                
+        Object fnt = ci.getAttribute(TextAttribute.FONT);
+
+        int limit = ci.getRunLimit(TextAttribute.FONT);
+        String run = new String();
+        while (ci.current () != CharacterIterator.DONE && 
+               ci.getIndex() < limit)
+          {
+            run += ci.current ();
+            ci.next ();
+          }
+
+        GlyphVector gv;
+        if (fnt != null && fnt instanceof Font)          
+          gv = ((Font)fnt).createGlyphVector (fontRenderContext, run);
+        else
+          gv = defFont.createGlyphVector (fontRenderContext, run);
+
+        g2.drawGlyphVector (gv, x, y);
+
+        int n = gv.getNumGlyphs ();
+        for (int i = 0; i < n; ++i)
+          {
+            GlyphMetrics gm = gv.getGlyphMetrics (i);
+            if (gm.getAdvanceX() == gm.getAdvance ())
+              x += gm.getAdvanceX ();
+            else
+              y += gm.getAdvanceY ();
+          }
+      }
   }
 
   public boolean equals (Object obj)

--=-=-=--




From MAILER-DAEMON Tue Nov 18 18:23:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFBv-0002DI-1e
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 18:23:27 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFBs-0002Cf-5G
	for classpath@gnu.org; Tue, 18 Nov 2003 18:23:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFBK-00024g-UZ
	for classpath@gnu.org; Tue, 18 Nov 2003 18:23:22 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFBK-00023s-5z
	for classpath@gnu.org; Tue, 18 Nov 2003 18:22:50 -0500
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AMEDs-0005kc-00
	for <classpath@gnu.org>; Tue, 18 Nov 2003 23:21:24 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMEDr-0005kU-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 23:21:23 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AMEDr-0003Ov-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 18 Nov 2003 23:21:23 +0100
From: graydon hoare <graydon@redhat.com>
Date: 18 Nov 2003 17:19:49 -0500
Lines: 407
Message-ID: <87ekw5s4je.fsf@dub.venge.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Sender: news <news@sea.gmane.org>
Cc: java-patches@gcc.gnu.org
Subject: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:23:24 -0000

--=-=-=

hi,

this patch implements JLayeredPane and makes some minor adjustments to
JFrame and JRootPane.

-graydon

2003-11-18  Graydon Hoare  <graydon@redhat.com>

	* javax/swing/JLayeredPane.java: Implement.
	* javax/swing/JFrame.java (getContentPane): Make public
	* javax/swing/javax/swing/JRootPane.java (setContentPane): 
	Use JLayeredPane.FRAME_CONTENT_LAYER.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=j2d-swing-frame-fixes.patch

--- javax/swing/JRootPane.java	8 Jun 2003 11:20:07 -0000	1.5
+++ javax/swing/JRootPane.java	17 Nov 2003 17:39:10 -0000
@@ -119,8 +120,8 @@
     public void setContentPane(Container p)
     {
 	contentPane = p;    
-	getLayeredPane().add(contentPane, 0);
+	getLayeredPane().add(contentPane, JLayeredPane.FRAME_CONTENT_LAYER);
     }
 
     protected void addImpl(Component comp,
--- javax/swing/JLayeredPane.java	8 Jun 2003 11:43:14 -0000	1.4
+++ javax/swing/JLayeredPane.java	17 Nov 2003 17:39:10 -0000
@@ -39,23 +39,354 @@
 package javax.swing;
 
 import java.awt.Component;
+import java.util.*;
+import java.awt.Component;
 import javax.accessibility.Accessible;
 
+
+/**
+ * The "Layered Pane" is a container which divides its children into 6 (or
+ * more) disjoint sets. the pre-defined sets are:
+ *
+ *  "Frame Content", "Default", "Palette", "Modal", "Popup", and "Drag".
+ *
+ * A child is in exactly one of these layers at any time, though there may
+ * be other layers if someone creates them.
+ *
+ * The purpose of this class is to translate this view of "layers" into a
+ * contiguous array of components: the one held in our ancestor,
+ * java.awt.Container.
+ *
+ * There is a precise set of words we will use to refer to numbers within
+ * this class:
+ * 
+ * Internal Component Index: an offset into the "component" array held in
+ * our ancestor, java.awt.Container, from [0 .. component.length). The
+ * drawing rule with internal indices is that 0 is drawn first.
+ *
+ * External Component Index: an offset into the "logical drawing order" of
+ * this container. If I is the internal index of a component, the external
+ * index E = component.length - I. The rule with external indices is that 0
+ * is drawn last.
+ *
+ * Layer Number: a general int specifying a layer within this component.
+ * Negative numbers are drawn first, then layer 0, then positive numbered
+ * layers, in ascending order.
+ *
+ * Position: an offset into a layer's "logical drawing order". Layer
+ * position 0 is drawn last. Layer position -1 is a synonym for the first
+ * layer position (the logical "bottom").
+ */
+
 public class JLayeredPane extends JComponent implements Accessible
 {
+
+    public static String LAYER_PROPERTY = "LAYER_PROPERTY";
+
+    public static Integer FRAME_CONTENT_LAYER = new Integer (-30000);
+
+    public static Integer DEFAULT_LAYER = new Integer (0);
+    public static Integer PALETTE_LAYER = new Integer (100);
+    public static Integer MODAL_LAYER   = new Integer (200);
+    public static Integer POPUP_LAYER   = new Integer (300);
+    public static Integer DRAG_LAYER    = new Integer (400);
+
+    TreeMap layers;               // Layer Number (Integer) -> Layer Size (Integer)
+    Hashtable componentToLayer;   // Component -> Layer Number (Integer)
+
+    protected Integer getLayer (Component c)
+    {
+	if (! componentToLayer.containsKey (c))
+	    throw new IllegalArgumentException ();
+	return (Integer) componentToLayer.get (c);
+    }
+
+    // this returns a half-open range [bottom, top), which is the range of
+    // internal component indices this layer number corresponds to.  note
+    // that top is *not* included in the range of component indices in this
+    // layer: a layer with 0 elements in it has ret[0] == ret[1].
+
+    protected int[] layerToRange (Integer layer)
+    {
+	int[] ret = new int[2];	
+	Iterator i = layers.entrySet ().iterator ();
+	while (i.hasNext())
+	    {
+		Map.Entry pair = (Map.Entry) i.next();
+		Integer layerNum = (Integer) pair.getKey ();
+		Integer layerSz = (Integer) pair.getValue ();
+		if (layerNum == layer)
+		    {
+			ret[1] = ret[0] + layerSz.intValue ();
+			return ret;
+		    }
+		else
+		    {
+			ret[0] += layerSz.intValue ();
+		    }
+	    }
+	// should have found the layer during iteration
+	throw new IllegalArgumentException ();
+    }
+
+    protected void incrLayer(Integer layer)
+    {
+	int sz = 1;
+	if (layers.containsKey (layer))
+	    sz += ((Integer)(layers.get (layer))).intValue ();
+	layers.put (layer, new Integer(sz));
+    }
+
+    protected void decrLayer(Integer layer)
+    {
+	int sz = 0;
+	if (layers.containsKey (layer))
+	    sz = ((Integer)(layers.get (layer))).intValue () - 1;
+	layers.put (layer, new Integer(sz));
+    }
+
     JLayeredPane()
     {
+	layers = new TreeMap ();
+	layers.put (FRAME_CONTENT_LAYER, new Integer (0));
+	layers.put (DEFAULT_LAYER, new Integer (0));
+	layers.put (PALETTE_LAYER, new Integer (0));
+	layers.put (MODAL_LAYER, new Integer (0));
+	layers.put (POPUP_LAYER, new Integer (0));
+	layers.put (DRAG_LAYER, new Integer (0));	
+
+	componentToLayer = new Hashtable ();
+    }
+
+    public int highestLayer()
+    {
+	if (layers.size() == 0)
+	    return 0;
+	return ((Integer)(layers.lastKey ())).intValue ();
+    }
+    
+    public int lowestLayer()
+    {
+	if (layers.size() == 0)
+	    return 0;
+	return ((Integer)(layers.firstKey ())).intValue ();
+    }
+
+    public void moveToFront(Component c)
+    {
+	setPosition (c, 0);
+    }
+
+    public void moveToBack(Component c)
+    {
+	setPosition (c, -1);
+    }
+    
+    public int getPosition(Component c)
+    {
+	Integer layer = getLayer (c);
+	int[] range = layerToRange (layer);
+	int top = (range[1] - 1);
+	Component[] comps = getComponents ();
+	for (int i = range[0]; i < range[1]; ++i)
+	    {
+		if (comps[i] == c)
+		    return top - i;
+	    }
+	// should have found it
+	throw new IllegalArgumentException ();
+    }
+
+    public void setPosition(Component c, int position)
+    {
+	Integer layer = getLayer (c);
+	int[] range = layerToRange (layer);
+	if (range[0] == range[1])
+	    throw new IllegalArgumentException ();
+
+	int top = (range[1] - 1);
+	if (position == -1)
+	    position = top - range[0];
+	int targ = top - position;
+	int curr = -1;
+
+	Component[] comps = getComponents();
+	for (int i = range[0]; i < range[1]; ++i)
+	    {
+		if (comps[i] == c)
+		    {
+			curr = i;
+			break;
+		    }
+	    }
+	if (curr == -1)
+	    // should have found it
+	    throw new IllegalArgumentException ();
+
+	// System.err.println("set component position to " + position + " in layer " + layer);
+
+	Component tmp = comps[curr];
+	super.remove (curr);
+	super.add (tmp, targ);
+	super.validate ();
+    }
+    
+
+
+    public Component[] getComponentsInLayer(int layer)
+    {
+	int[] range = layerToRange (getObjectForLayer (layer));
+	if (range[0] == range[1])
+	    return new Component[0];
+	else
+	    {
+		Component[] comps = getComponents ();
+		int sz = (range[1] - 1) - range[0];
+		Component[] nc = new Component[sz];
+		for (int i = 0; i < sz; ++i)
+		    nc[i] = comps[range[0] + i];
+		return nc;
+	    }
+    }
+
+    public int getComponentCountInLayer(int layer)
+    {
+	int[] range = layerToRange (getObjectForLayer (layer));
+	if (range[0] == range[1])
+	    return 0;
+	else
+	    return ((range[1] - 1) - range[0]);
+    }
+
+    protected Hashtable getComponentToLayer()
+    {
+	return componentToLayer;
+    }
+
+    protected int getInternalIndexOf(Component c) 
+    {
+	Integer layer = getLayer (c);
+	int[] range = layerToRange (layer);
+	Component[] comps = getComponents();
+	for (int i = range[0]; i < range[1]; ++i)
+	    {
+		if (comps[i] == c)
+		    return i;
+	    }
+	// should have found the component during iteration
+	throw new IllegalArgumentException ();
     }
 
+
+    public int getIndexOf(Component c) 
+    {
+	// returns the *external* index of the component.
+	int top = getComponentCount() - 1;
+	return top - getIndexOf (c);
+    }    
+
+
+    protected Integer getObjectForLayer(int layer)
+    {
+	switch (layer)
+	    {
+	    case -30000:
+		return FRAME_CONTENT_LAYER;
+
+	    case 0:
+		return DEFAULT_LAYER;
+
+	    case 100:
+		return PALETTE_LAYER;
+
+	    case 200:
+		return MODAL_LAYER;
+
+	    case 300:
+		return POPUP_LAYER;
+
+	    case 400:
+		return DRAG_LAYER;
+
+	    default:
+		break;
+	    }
+
+	return new Integer(layer);
+    }
     
-    protected void addImpl(Component comp, Object constraints, int index) 
-    {        
-        super.addImpl(comp, constraints, index);
+    protected int insertIndexForLayer(int layer, int position)
+    {
+	int[] range = layerToRange (getObjectForLayer (layer));
+	if (range[0] == range[1])
+	    return range[0];
 	
-        comp.validate();
-        comp.repaint();
+	int bottom = range[0];
+	int top = range[1] - 1;
+	
+	if (position == -1 || position > (top - bottom))
+	    return bottom;
+	else
+	    return top - position;
     }
     
-  
+    public void remove (int index)
+    {
+	Component c = getComponent (index);
+	Integer layer = getLayer (c);
+	decrLayer (layer);
+	componentToLayer.remove (c);
+	super.remove (index);
+    }
+	
+    public void remove (Component comp)
+    {
+	Integer layer = getLayer (comp);
+	decrLayer (layer);
+	componentToLayer.remove (comp);
+	super.remove (comp);
+    }
+
+    public void removeAll ()
+    {
+	componentToLayer.clear ();
+	layers.clear ();
+	super.removeAll ();
+    }
+
+    public void setLayer(Component c, int layer)
+    {
+	componentToLayer.put (c, getObjectForLayer (layer));
+    }
+
+    public void setLayer(Component c,
+			 int layer,
+			 int position)
+    {
+	componentToLayer.put (c, getObjectForLayer (layer));
+	setPosition(c, position);
+        repaint();
+    }
+
+    protected void addImpl(Component comp, Object layerConstraint, int index) 
+    {        	
+	Integer layer;
+	if (layerConstraint != null && layerConstraint instanceof Integer)
+		layer = (Integer) layerConstraint;
+	else if (componentToLayer.containsKey (comp))
+	    layer = (Integer) componentToLayer.remove (comp);
+	else
+	    layer = DEFAULT_LAYER;
+
+	int newIdx = insertIndexForLayer(layer.intValue (), -1);
+	componentToLayer.put (comp, layer);
+	incrLayer (layer);
+
+	// System.err.println("adding component to layer " + layer);
+	
+        super.addImpl(comp, null, newIdx);	
+        validate();
+        repaint();
+    }     
 }
--- javax/swing/JFrame.java	8 Jun 2003 11:20:07 -0000	1.6
+++ javax/swing/JFrame.java	17 Nov 2003 17:39:10 -0000
@@ -149,7 +151,7 @@
     JRootPane createRootPane()
     {   return new JRootPane();    }
 
-    Container getContentPane()
+    public Container getContentPane()
     {    return getRootPane().getContentPane();     }
 
     void setContentPane(Container contentPane)

--=-=-=--




From MAILER-DAEMON Tue Nov 18 18:45:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFXB-0006NH-A9
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 18:45:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFX8-0006LA-Bu
	for classpath@gnu.org; Tue, 18 Nov 2003 18:45:22 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFWW-0006Fb-Bv
	for classpath@gnu.org; Tue, 18 Nov 2003 18:45:16 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFVP-0005sP-KS
	for classpath@gnu.org; Tue, 18 Nov 2003 18:43:35 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA18807;
	Tue, 18 Nov 2003 15:42:00 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 2B1BD4F8288; Tue, 18 Nov 2003 15:32:45 -0700 (MST)
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Jesus is my POSTMASTER GENERAL..
Date: 18 Nov 2003 15:32:45 -0700
In-Reply-To: <3FBA7364.9060206@kaffe.org>
Message-ID: <87d6bpb94i.fsf@fleche.redhat.com>
Lines: 22
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:45:23 -0000

>>>>> "Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:

Dalibor> -    if (! (obj instanceof FieldPosition))
Dalibor> +    if (this == obj)
Dalibor> +      return true;
Dalibor> +
Dalibor> +    if (obj != null && (obj.getClass() != this.getClass()))
Dalibor>        return false;

I think this should read:

  if (obj == null || obj.getClass() != this.getClass())
    return false;

I don't think short-circuiting the this==obj case is really worth the
effort.  But I don't really care all that much.

Dalibor> +    hash = 31 * hash + (null == field_attribute ? 0 : field_attribute.hashCode());

Does this line need to be wrapped?  I think it goes past column 79.

Tom



From MAILER-DAEMON Tue Nov 18 18:47:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFZU-0006lD-CN
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 18:47:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFZR-0006kg-Mo
	for classpath@gnu.org; Tue, 18 Nov 2003 18:47:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFYu-0006dm-2F
	for classpath@gnu.org; Tue, 18 Nov 2003 18:47:43 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFYt-0006de-JS
	for classpath@gnu.org; Tue, 18 Nov 2003 18:47:11 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA20228;
	Tue, 18 Nov 2003 15:45:40 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id C0A964F8288; Tue, 18 Nov 2003 15:36:24 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <87wu9xs5tw.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I invented skydiving in 1989!
Date: 18 Nov 2003 15:36:24 -0700
In-Reply-To: <87wu9xs5tw.fsf@dub.venge.net>
Message-ID: <878ymdb8yf.fsf@fleche.redhat.com>
Lines: 12
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] attributed string fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:47:47 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> 2003-11-18  Graydon Hoare  <graydon@redhat.com>
graydon> 	* java/text/AttributedString.java: Fix arithmetic.
graydon> 	* java/text/AttributedStringIterator.java: Likewise.

Looks good, please commit.
Actually, could you update the javadoc for the addAttribute methods
to clarify that "end_index" is one more than the index of the final
character?

Tom



From MAILER-DAEMON Tue Nov 18 18:50:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFc7-0007gi-RS
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 18:50:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFc4-0007ei-L8
	for classpath@gnu.org; Tue, 18 Nov 2003 18:50:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFbV-0007SK-Km
	for classpath@gnu.org; Tue, 18 Nov 2003 18:50:24 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFbU-0007RZ-Vn
	for classpath@gnu.org; Tue, 18 Nov 2003 18:49:53 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA21170;
	Tue, 18 Nov 2003 15:48:26 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 7FED14F8288; Tue, 18 Nov 2003 15:39:10 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <87smkls5nj.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I was in EXCRUCIATING PAIN until I started reading JACK AND JILL
	Magazine!!
Date: 18 Nov 2003 15:39:10 -0700
In-Reply-To: <87smkls5nj.fsf@dub.venge.net>
Message-ID: <874qx1b8tt.fsf@fleche.redhat.com>
Lines: 16
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] text layout implementation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:50:29 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> this patch implements simple awt text layouts using attributed strings
graydon> and j2d glyph vectors. it will probably need further work, but it is
graydon> enough to get the swing text system limping along.

If you know of specific problems in the patch, go ahead and add
comments explaining what remains.

graydon> 2003-11-18  Graydon Hoare  <graydon@redhat.com>
graydon> 	* java/awt/font/TextLayout.java: Implement simple layouts
graydon> 	using attributed strings and glyph vectors.

Please check in, thanks.

Tom



From MAILER-DAEMON Tue Nov 18 19:00:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFlP-0001pF-82
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 19:00:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFl9-0001nP-Qx
	for classpath@gnu.org; Tue, 18 Nov 2003 18:59:51 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFka-0001Yz-UK
	for classpath@gnu.org; Tue, 18 Nov 2003 18:59:49 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFka-0001YI-8A
	for classpath@gnu.org; Tue, 18 Nov 2003 18:59:16 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA24619;
	Tue, 18 Nov 2003 15:57:36 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 7B2354F8288; Tue, 18 Nov 2003 15:48:20 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <878ymdv7v9.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: MMM-MM!!  So THIS is BIO-NEBULATION!
Date: 18 Nov 2003 15:48:20 -0700
In-Reply-To: <878ymdv7v9.fsf@dub.venge.net>
Message-ID: <87vfph9tu3.fsf@fleche.redhat.com>
Lines: 12
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java@gcc.gnu.org
Subject: Re: [PATCH] various graphics2d fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2003 23:59:53 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> these are just miscellaneous fixes which have accumulated to the
graydon> graphics2d implementation I did atop cairo. nothing revolutionary,
graydon> just a lot of minor fixups, so I bundled them up here in one
graydon> patch. changes to other areas (eg. swing) will follow in separate
graydon> patches.
graydon> comments? ok to commit?

Please check in, thanks.

Tom



From MAILER-DAEMON Tue Nov 18 19:16:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMFys-0007wC-RI
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 19:14:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMFyj-0007t9-8q
	for classpath@gnu.org; Tue, 18 Nov 2003 19:13:53 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMFy9-0007kF-RD
	for classpath@gnu.org; Tue, 18 Nov 2003 19:13:48 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMFsU-0006I8-Cq
	for classpath@gnu.org; Tue, 18 Nov 2003 19:07:26 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA22728;
	Tue, 18 Nov 2003 15:52:37 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 6DDD74F8288; Tue, 18 Nov 2003 15:43:21 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <87ekw5s4je.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I'm having an emotional outburst!!
Date: 18 Nov 2003 15:43:21 -0700
In-Reply-To: <87ekw5s4je.fsf@dub.venge.net>
Message-ID: <87znet9u2e.fsf@fleche.redhat.com>
Lines: 11
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 00:13:57 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> 2003-11-18  Graydon Hoare  <graydon@redhat.com>
graydon> 	* javax/swing/JLayeredPane.java: Implement.
graydon> 	* javax/swing/JFrame.java (getContentPane): Make public
graydon> 	* javax/swing/javax/swing/JRootPane.java (setContentPane): 
graydon> 	Use JLayeredPane.FRAME_CONTENT_LAYER.

Thanks, please check in.

Tom



From MAILER-DAEMON Tue Nov 18 20:08:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMGpY-0007Xv-GV
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 20:08:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMGpF-0007Bw-Gg
	for classpath@gnu.org; Tue, 18 Nov 2003 20:08:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMGnQ-0005YB-IE
	for classpath@gnu.org; Tue, 18 Nov 2003 20:06:47 -0500
Received: from [217.185.152.88] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMGmd-00054Y-0W
	for classpath@gnu.org; Tue, 18 Nov 2003 20:05:27 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hAJ1EOH03069; Wed, 19 Nov 2003 02:14:25 +0100
Message-ID: <3FBAC3ED.1010904@kaffe.org>
Date: Wed, 19 Nov 2003 02:14:21 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FB673C1.6010206@kaffe.org>	
	<1068933449.925.530.camel@elsschot.wildebeest.org>	
	<3FBA7364.9060206@kaffe.org>
	<1069190892.1745.23.camel@elsschot.wildebeest.org>
In-Reply-To: <1069190892.1745.23.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by clerks.local id
	hAJ1EOH03069
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 01:08:26 -0000

Hi Mark,

Mark Wielaard wrote:

> The documentation and code don't match up now.
> My Class Library book seems to indicate that it actually is instanceof,
> thought in most cases your code comparing the actual Class seems more
> correct.

It's the recommended way of doing equals() if you want to avoid symmetry
bugs. See PRAXIS 12 in Peter Haggar's Practical Java, or =A75.1, p 119 in
Java 2 performance and idion guide by craig lahrmann & rhett guthrie, or
Effective Java by Joshua Bloch. Using instanceof is a bad idea because
it allows for symmetry bugs:

B extends A. With instanceof in equals, we can have A.equals(B) but=20
!B.equlas(A) since A is not an instance of B. Ugly, and very broken.=20
There are a few places, where the API demands this (Maps), but they are=20
all well documented, AFAIK. If it's not documented, it's better to use=20
the symmetry safe form, in my opinion.

>>+  /**
>>+   * This method returns a hash value for this object
>>+   *=20
>>+   * @return A hash value for this object.
>>+   */
>>+  public int hashCode ()
>>+  {
>>+    int hash =3D 7;
>>+
>>+    hash =3D 31 * hash + field_id;
>>+    hash =3D 31 * hash + begin;
>>+    hash =3D 31 * hash + end;
>>+    hash =3D 31 * hash + (null =3D=3D field_attribute ? 0 : field_attr=
ibute.hashCode());
>>+
>>+    return hash;
>>+  }
>=20
>=20
> Just curious, why this particular hash function?

7 is the largest prime, that's still an iconst, iconst_7, afaik. That=20
makes it take less bytecode.

The rest follows recommendations from Joshua Bloch on writing good=20
hashCode methods.

> I couldn't find one specified, so I guess any good one will do.
> Don't know if you need to include the field_attribute.hashCode() since
> it will probably depend on the field_id in almost all cases.

If two objects are not equal, they should have different hashCodes.=20
field_attribute is checked in the equality test, so it should play a=20
role in hashCode calculation as well.

cheers,
dalibor topic




From MAILER-DAEMON Tue Nov 18 20:17:13 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMGxy-0002Xw-Ii
	for mharc-classpath@gnu.org; Tue, 18 Nov 2003 20:17:10 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMGxt-0002Rk-TC
	for classpath@gnu.org; Tue, 18 Nov 2003 20:17:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMGxG-000294-8v
	for classpath@gnu.org; Tue, 18 Nov 2003 20:16:57 -0500
Received: from [217.185.147.81] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMGwv-0001zv-Sc
	for classpath@gnu.org; Tue, 18 Nov 2003 20:16:06 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hAJ1cpH03334; Wed, 19 Nov 2003 02:38:51 +0100
Message-ID: <3FBAC9A8.6030002@kaffe.org>
Date: Wed, 19 Nov 2003 02:38:48 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <3FB673C1.6010206@kaffe.org>	<1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>
	<87d6bpb94i.fsf@fleche.redhat.com>
In-Reply-To: <87d6bpb94i.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 01:17:09 -0000

Hi Tom,

Tom Tromey wrote:
>>>>>>"Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:
> 
> 
> Dalibor> -    if (! (obj instanceof FieldPosition))
> Dalibor> +    if (this == obj)
> Dalibor> +      return true;
> Dalibor> +
> Dalibor> +    if (obj != null && (obj.getClass() != this.getClass()))
> Dalibor>        return false;
> 
> I think this should read:
> 
>   if (obj == null || obj.getClass() != this.getClass())
>     return false;

thanks for the comment. I agree that's more readable. I'll change that 
in another revision.

> I don't think short-circuiting the this==obj case is really worth the
> effort.  But I don't really care all that much.

A quick grep for equals in java.util.* collection classes shows that 
it's being used quite a bit there. for example, in order to find out 
whether an element is contained in a collection, on needs to find out 
whether there is an element that is equal to it in the collection. I 
believe that a short circuit here helps. I could run some tests and 
provide some numbers, if necessary.

> Dalibor> +    hash = 31 * hash + (null == field_attribute ? 0 : field_attribute.hashCode());
> 
> Does this line need to be wrapped?  I think it goes past column 79.

can't say, I need to teach emacs to count columns, I guess. But I'll 
wrap it anyway, to go for sure.

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 05:46:59 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMPrP-0000io-5S
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 05:46:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMPrG-0000iE-Gp
	for classpath@gnu.org; Wed, 19 Nov 2003 05:46:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMPqk-0000f6-BE
	for classpath@gnu.org; Wed, 19 Nov 2003 05:46:49 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMPqj-0000em-Vz
	for classpath@gnu.org; Wed, 19 Nov 2003 05:46:18 -0500
Content-class: urn:content-classes:message
Date: Wed, 19 Nov 2003 10:44:33 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C680@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] Field position attribute handling
Thread-Index: AcOuMjSWudwt+DgzTJmclqutbpU/ggATqm8w
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Dalibor Topic" <robilad@kaffe.org>,
	"Mark Wielaard" <mark@klomp.org>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 10:46:51 -0000

Dalibor Topic wrote:
> 7 is the largest prime, that's still an iconst, iconst_7, afaik. That=20
> makes it take less bytecode.

Actually, iconst_5 is the maximum, but this seems like a little too low
level view of the problem space ;-)

> If two objects are not equal, they should have different hashCodes.=20

No this isn't true, however, if two objects are equal, they must have
identical hashCodes. It would be nice if unequal objects had different
hashCodes, but this is not a requirement.

Regards,
Jeroen



From MAILER-DAEMON Wed Nov 19 06:41:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMQhl-0000l3-Dr
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 06:41:05 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMQhi-0000ju-4n
	for classpath@gnu.org; Wed, 19 Nov 2003 06:41:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMQh9-0000YO-J5
	for classpath@gnu.org; Wed, 19 Nov 2003 06:40:58 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMQh8-0000YB-R6
	for classpath@gnu.org; Wed, 19 Nov 2003 06:40:27 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMPjh-0000Kg-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 11:39:01 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMPjd-0000Jk-00; Wed, 19 Nov 2003 11:38:57 +0100
Message-ID: <3FBB4841.3010808@kaffe.org>
Date: Wed, 19 Nov 2003 11:38:57 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC04C680@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C680@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 11:41:03 -0000

Jeroen Frijters wrote:
> Dalibor Topic wrote:
> 
>>7 is the largest prime, that's still an iconst, iconst_7, afaik. That 
>>makes it take less bytecode.
> 
> 
> Actually, iconst_5 is the maximum, but this seems like a little too low
> level view of the problem space ;-)

Thanks, I'll make it 5, then ;)

>>If two objects are not equal, they should have different hashCodes. 
> 
> 
> No this isn't true, however, if two objects are equal, they must have
> identical hashCodes. It would be nice if unequal objects had different
> hashCodes, but this is not a requirement.

Note that I used *should* in my sentence instead of *must*, and reparse 
what I said ;)

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 06:52:24 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMQsg-0005QZ-Js
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 06:52:22 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMQsc-0005O4-Hu
	for classpath@gnu.org; Wed, 19 Nov 2003 06:52:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMQrz-0005F2-AD
	for classpath@gnu.org; Wed, 19 Nov 2003 06:52:10 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMQry-0005Ez-BT
	for classpath@gnu.org; Wed, 19 Nov 2003 06:51:38 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-80-226.ewetel.net
	[80.228.80.226])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id hAJAo46J007060;
	Wed, 19 Nov 2003 11:50:05 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AMPur-0007wX-00; Wed, 19 Nov 2003 11:50:33 +0100
Date: Wed, 19 Nov 2003 11:50:33 +0100
From: Michael Koch <konqueror@gmx.de>
To: Tom Tromey <tromey@redhat.com>
Message-ID: <20031119105033.GA29318@mail.konqueror.de>
References: <878ymexym1.fsf@fleche.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878ymexym1.fsf@fleche.redhat.com>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 11:52:20 -0000

On Mon, Nov 17, 2003 at 06:19:02PM -0700, Tom Tromey wrote:
> Raif Naffah sent me a couple nice jalopy patches to implement things
> from my last wish-list.  I wrote a new patch myself, to get jalopy to
> use tabs for indentation in the way we expect.
> 
> I made a new release with these improvements.  Once again, it is here:
> 
>     ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz
> 
> You'll also want this file, which is the GNU.xml style:
> 
>     ftp://sources.redhat.com/pub/java/GNU.xml
> 
> This is somewhat different from the last one.
> 
> 
> This version seems to be much better.  The strange Point.java change
> has disappeared (I didn't try to find out why).
> 
> At this point I think we are ready to try this version of jalopy for
> real.  I propose we pick a package to reformat and check in.
> Preferably we'd pick something where active work is going on, so we
> could more easily notice whatever jalopy doesn't handle well.
> 
> 
> Long term, we need to find a cvs repository for this version.  We
> should also put GNU.xml into the classpath repository; I'll do this if
> we're all on board for the test drive.

I used this Jalopy version and got a weird indentation in an if
construct:

if (way == X_AXIS
    || (way == LINE_AXIS
    && component.getComponentOrientation().isHorizontal())
    || (way == PAGE_AXIS
    && !component.getComponentOrientation().isHorizontal()))

With XEmacs I got the more correct indention:

if (way == X_AXIS
    || (way == LINE_AXIS
        && component.getComponentOrientation().isHorizontal())
    || (way == PAGE_AXIS
        && !component.getComponentOrientation().isHorizontal()))

I think this should be fixed before we use jalopy.


Michael



From MAILER-DAEMON Wed Nov 19 07:19:12 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMRId-0001H7-DD
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 07:19:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMRIZ-0001Cc-99
	for classpath@gnu.org; Wed, 19 Nov 2003 07:19:07 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMRI1-0000sP-09
	for classpath@gnu.org; Wed, 19 Nov 2003 07:19:04 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMRI0-0000rm-Dn
	for classpath@gnu.org; Wed, 19 Nov 2003 07:18:32 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMQKZ-0000gu-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 12:17:07 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMQKV-0000fa-00; Wed, 19 Nov 2003 12:17:03 +0100
Message-ID: <3FBB512F.3000606@kaffe.org>
Date: Wed, 19 Nov 2003 12:17:03 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <3FB673C1.6010206@kaffe.org>	<1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>	<87d6bpb94i.fsf@fleche.redhat.com>
	<3FBAC9A8.6030002@kaffe.org>
In-Reply-To: <3FBAC9A8.6030002@kaffe.org>
Content-Type: multipart/mixed; boundary="------------040908010606060208020308"
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 12:19:09 -0000

This is a multi-part message in MIME format.
--------------040908010606060208020308
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Dalibor Topic wrote:
> Hi Tom,

> 
> thanks for the comment. I agree that's more readable. I'll change that 
> in another revision.

Done. Please review the next revision, and check in if it's o.k.


2003-11-18 Guilhem Lavaux <guilhem@kaffe.org>

     * java/text/FieldPosition.java (field_attribute): New field.
     (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
     getFieldAttribute): New methods.

2003-11-18 Dalibor Topic <robilad@kaffe.org>

     * java/text/FieldPosition.java (equals): Adapted to handle
     field_attribute. Added fast-circuit check for comparison to self.
     Replaced use of instanceof by getClass to fix symmetry for derived
     types.
     (toString): Adapted to handle field_attribute. Improved readability.
     (hashCode): New method.

--------------040908010606060208020308
Content-Type: text/plain;
 name="FieldPosition.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="FieldPosition.diff"

Index: java/text/FieldPosition.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/FieldPosition.java,v
retrieving revision 1.5
diff -u -r1.5 FieldPosition.java
--- java/text/FieldPosition.java	22 Jan 2002 22:27:01 -0000	1.5
+++ java/text/FieldPosition.java	19 Nov 2003 11:04:54 -0000
@@ -65,6 +65,38 @@
   private int end;
 
   /**
+   * This is the field attribute value.
+   */
+  private Format.Field field_attribute;
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id.
+   *
+   * @param field The field format attribute.
+   */
+  public FieldPosition (Format.Field field)
+  {
+    this.field_attribute = field;
+  }
+
+  /**
+   * This method initializes a new instance of <code>FieldPosition</code>
+   * to have the specified field attribute. The attribute will be used as
+   * an id is non null. The integer field id is only used if the Format.Field
+   * attribute is not used by the formatter.
+   *
+   * @param field The field format attribute.
+   * @param field_id The field identifier value.
+   */
+  public FieldPosition (Format.Field field, int field_id)
+  {
+    this.field_attribute = field;
+    this.field_id = field_id;
+  }
+
+  /**
    * This method initializes a new instance of <code>FieldPosition</code> to
    * have the specified field id.
    *
@@ -85,6 +117,11 @@
     return field_id;
   }
 
+  public Format.Field getFieldAttribute ()
+  {
+    return field_attribute;
+  }
+
   /**
    * This method returns the beginning index for this field.
    *
@@ -132,8 +169,8 @@
    * <ul>
    * <li>The specified object is not <code>null</code>.
    * <li>The specified object is an instance of <code>FieldPosition</code>.
-   * <li>The specified object has the same field identifier and beginning
-   * and ending index as this object.
+   * <li>The specified object has the same field identifier, field attribute 
+   * and beginning and ending index as this object.
    * </ul>
    *
    * @param obj The object to test for equality to this object.
@@ -143,15 +180,40 @@
    */
   public boolean equals (Object obj)
   {
-    if (! (obj instanceof FieldPosition))
+    if (this == obj)
+      return true;
+
+    if (obj == null || obj.getClass() != this.getClass())
       return false;
 
     FieldPosition fp = (FieldPosition) obj;
     return (field_id == fp.field_id
+	    && (field_attribute == fp.field_attribute 
+		|| (field_attribute != null 
+		    && field_attribute.equals(fp.field_attribute)))
 	    && begin == fp.begin
 	    && end == fp.end);
   }
 
+
+  /**
+   * This method returns a hash value for this object
+   * 
+   * @return A hash value for this object.
+   */
+  public int hashCode ()
+  {
+    int hash = 5;
+
+    hash = 31 * hash + field_id;
+    hash = 31 * hash + begin;
+    hash = 31 * hash + end;
+    hash = 31 * hash + 
+      (null == field_attribute ? 0 : field_attribute.hashCode());
+
+    return hash;
+  }
+
   /**
    * This method returns a <code>String</code> representation of this
    * object.
@@ -160,7 +222,11 @@
    */
   public String toString ()
   {
-    return (getClass ().getName () + "[field=" + getField () + ",beginIndex="
-	    + getBeginIndex () + ",endIndex=" + getEndIndex () + "]");
+    return (getClass ().getName ()
+	    + "[field=" + getField ()
+	    + ",attribute=" + getFieldAttribute ()
+	    + ",beginIndex=" + getBeginIndex () 
+	    + ",endIndex=" + getEndIndex () 
+	    + "]");
   }
 }

--------------040908010606060208020308--




From MAILER-DAEMON Wed Nov 19 09:15:21 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMT73-0001JR-59
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 09:15:21 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMT70-0001IT-Ie
	for classpath@gnu.org; Wed, 19 Nov 2003 09:15:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMT6S-00017b-8o
	for classpath@gnu.org; Wed, 19 Nov 2003 09:15:15 -0500
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMT6R-000178-NU
	for classpath@gnu.org; Wed, 19 Nov 2003 09:14:43 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-80-226.ewetel.net
	[80.228.80.226])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id hAJDCeIw013496;
	Wed, 19 Nov 2003 14:12:40 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AMS8r-0001Oe-00; Wed, 19 Nov 2003 14:13:09 +0100
Date: Wed, 19 Nov 2003 14:13:09 +0100
From: Michael Koch <konqueror@gmx.de>
To: Dalibor Topic <robilad@kaffe.org>
Message-ID: <20031119131309.GA4896@mail.konqueror.de>
References: <3FB396C3.8060705@kaffe.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FB396C3.8060705@kaffe.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 14:15:19 -0000

On Thu, Nov 13, 2003 at 03:35:47PM +0100, Dalibor Topic wrote:
> Hi all,
> 
> attached is a small fix for ServerSocket's close method. It fixes a 
> NullPointerException when attempting to close a ServerSocket twice.
> 
> 2003-11-13  Guilhem Lavaux <guilhem@kaffe.org>
> 	* java/net/ServerSocket.java:
> 	(close) Check if server socket has already been released,
> 	before attepting to close it.
> 

> --- /var/tmp/PROJECTS/classpath//./java/net/ServerSocket.java	Fri Oct 17 19:05:29 2003
> +++ java/net/ServerSocket.java	Wed Oct 22 21:32:21 2003
> @@ -339,7 +339,8 @@
>     */
>    public void close () throws IOException
>    {
> -    impl.close ();
> +    if (impl != null)
> +      impl.close ();
>  
>      if (getChannel() != null)
>        getChannel().close ();

After thinking about this patch, its more and more bogus in my eyes as
impl never may be null. I provided a better fix to libgcj. When its
approved I will merge it into classpath too.

What would really interest me is the testcase from Guilhem that
triggered this.


Michael



From MAILER-DAEMON Wed Nov 19 10:16:58 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMU4g-0006nq-8P
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 10:16:58 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMU4d-0006nI-5K
	for classpath@gnu.org; Wed, 19 Nov 2003 10:16:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMU46-0006aH-2G
	for classpath@gnu.org; Wed, 19 Nov 2003 10:16:53 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMU45-0006a4-8l
	for classpath@gnu.org; Wed, 19 Nov 2003 10:16:21 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMT6d-0005wK-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 15:14:55 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMT6b-0005vm-00; Wed, 19 Nov 2003 15:14:53 +0100
Message-ID: <3FBB7ADD.2020809@kaffe.org>
Date: Wed, 19 Nov 2003 15:14:53 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <3FB396C3.8060705@kaffe.org>
	<20031119131309.GA4896@mail.konqueror.de>
In-Reply-To: <20031119131309.GA4896@mail.konqueror.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 15:16:55 -0000

Hi Michael,

Michael Koch wrote:

>>--- /var/tmp/PROJECTS/classpath//./java/net/ServerSocket.java	Fri Oct 17 19:05:29 2003
>>+++ java/net/ServerSocket.java	Wed Oct 22 21:32:21 2003
>>@@ -339,7 +339,8 @@
>>    */
>>   public void close () throws IOException
>>   {
>>-    impl.close ();
>>+    if (impl != null)
>>+      impl.close ();
>> 
>>     if (getChannel() != null)
>>       getChannel().close ();
> 
> 
> After thinking about this patch, its more and more bogus in my eyes as
> impl never may be null. I provided a better fix to libgcj. When its
> approved I will merge it into classpath too.

Not yet, but soon it will.

ServerSocket is still broken with respect to how it behaves when it's 
closed. When the socket is closed, access to methods like accept() 
should throw an IOException that it's closed. Currently, no such checks 
are done and you get weird exceptions.

bash-2.05a$ cat stest.java
import java.net.*;

public class stest {
         public static void main(String [] args) {

                 try {
                         ServerSocket ss = new ServerSocket();
                         ss.close();
                         ss.accept();
                 }
                 catch (Exception e) {
                         e.printStackTrace();
                 }
         }
}

bash-2.05a$ java stest
java.net.SocketException: Socket is closed
         at java.net.ServerSocket.accept(ServerSocket.java:415)
         at stest.main(stest.java:9)
bash-2.05a$ which java
/opt/misc/lib/java/jdk1.4.2//bin/java

vs.
bash-2.05a$ /tmp/topic/current-jit3/bin/kaffe stest
java.io.IOException: Bad file descriptor
    at gnu.java.net.PlainSocketImpl.socketAccept (PlainSocketImpl.java)
    at gnu.java.net.PlainSocketImpl.accept (PlainSocketImpl.java:51)
    at java.net.ServerSocket.implAccept (ServerSocket.java:332)
    at java.net.ServerSocket.accept (ServerSocket.java:307)
    at stest.main (stest.java:9)

I want to fix the server socket methods to behave properly after close. 
In order to do that, I want to set impl to null in close, and check for 
impl == null to determine if the socket has been closed already in all 
methods that should throw an IOException when the socket is closed.

But I first wanted to get the simple patches from Guilhem in before I 
start hacking on it myself. Seems to be hard enough ;)

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 10:51:39 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMUcA-0007Xr-1D
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 10:51:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMUc3-0007Iq-Ek
	for classpath@gnu.org; Wed, 19 Nov 2003 10:51:27 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMUbQ-0006P6-Km
	for classpath@gnu.org; Wed, 19 Nov 2003 10:51:19 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMUbP-0006MP-H4
	for classpath@gnu.org; Wed, 19 Nov 2003 10:50:47 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMTdy-00067m-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 15:49:22 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMTdv-000674-00; Wed, 19 Nov 2003 15:49:19 +0100
Message-ID: <3FBB82EE.90707@kaffe.org>
Date: Wed, 19 Nov 2003 15:49:18 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB396C3.8060705@kaffe.org>	<20031119131309.GA4896@mail.konqueror.de>
	<3FBB7ADD.2020809@kaffe.org>
In-Reply-To: <3FBB7ADD.2020809@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 15:51:32 -0000

Dalibor Topic wrote:
> Hi Michael,
> 
> Michael Koch wrote:
> 
>>> --- /var/tmp/PROJECTS/classpath//./java/net/ServerSocket.java    Fri 
>>> Oct 17 19:05:29 2003
>>> +++ java/net/ServerSocket.java    Wed Oct 22 21:32:21 2003
>>> @@ -339,7 +339,8 @@
>>>    */
>>>   public void close () throws IOException
>>>   {
>>> -    impl.close ();
>>> +    if (impl != null)
>>> +      impl.close ();
>>>
>>>     if (getChannel() != null)
>>>       getChannel().close ();
>>
>>
>>
>> After thinking about this patch, its more and more bogus in my eyes as
>> impl never may be null. I provided a better fix to libgcj. When its
>> approved I will merge it into classpath too.
> 
> 
> Not yet, but soon it will.
> 
> ServerSocket is still broken with respect to how it behaves when it's 
> closed. When the socket is closed, access to methods like accept() 
> should throw an IOException that it's closed. Currently, no such checks 

It should throw a SocketException, actually ;) I got carried away by my 
implementation details from java.io. fixes to kaffe. But you get the idea.

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 11:05:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMUpT-0006HO-7i
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 11:05:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMUpO-0006GJ-8M
	for classpath@gnu.org; Wed, 19 Nov 2003 11:05:14 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMUop-00069r-C3
	for classpath@gnu.org; Wed, 19 Nov 2003 11:05:10 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMUoo-00069Y-2D
	for classpath@gnu.org; Wed, 19 Nov 2003 11:04:38 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMTrM-0000iA-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 16:03:12 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMTrK-0000hk-00; Wed, 19 Nov 2003 16:03:10 +0100
Message-ID: <3FBB862E.2090602@kaffe.org>
Date: Wed, 19 Nov 2003 16:03:10 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: graydon hoare <graydon@redhat.com>
References: <87wu9xs5tw.fsf@dub.venge.net>
In-Reply-To: <87wu9xs5tw.fsf@dub.venge.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] attributed string fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 16:05:17 -0000

graydon hoare wrote:
> hi,
> 
> this fixes some arithmetic and semantic errors with attributed
> strings.
> 
> -graydon
> 
> 2003-11-18  Graydon Hoare  <graydon@redhat.com>
> 
> 	* java/text/AttributedString.java: Fix arithmetic.
> 	* java/text/AttributedStringIterator.java: Likewise.

PLease take a look at Guilhem's patches to java.text first. Your patch 
fails with kaffe's version of the file for 3 hunks:

patching file java/text/AttributedString.java
Hunk #3 FAILED at 407.
Hunk #4 FAILED at 217.
Hunk #5 FAILED at 266.
3 out of 5 hunks FAILED -- saving rejects to file 
java/text/AttributedString.java.rej

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 12:08:07 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMVoF-0002lE-Ct
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 12:08:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMVoC-0002ki-Sl
	for classpath@gnu.org; Wed, 19 Nov 2003 12:08:04 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMVnf-0002aC-WA
	for classpath@gnu.org; Wed, 19 Nov 2003 12:08:03 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMVnL-0002Ib-0J
	for classpath@gnu.org; Wed, 19 Nov 2003 12:07:11 -0500
Received: from [192.168.1.33] (196.56.dyn-adsl.customer.ch.easynet.net
	[217.8.196.56]) by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id 65902649DE; Wed, 19 Nov 2003 17:05:38 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Wed, 19 Nov 2003 17:04:32 +0100
Message-Id: <20031119160432.24598@smtp.mail.ch.easynet.net>
In-Reply-To: <87ekw5s4je.fsf@dub.venge.net>
References: <87ekw5s4je.fsf@dub.venge.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: java-patches@gcc.gnu.org, graydon hoare <graydon@redhat.com>
Subject: Re: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 17:08:05 -0000

Hi Graydon,

>this patch implements JLayeredPane and makes some minor adjustments to
>JFrame and JRootPane.

Thanks for having written some documentation for the class! Just a
suggestion: Please separate paragraphs by <p> tags. Also, it IMHO would
be better to describe attributes like "position" with the respective
methods (e.g., getPosition), but this may be a matter of personal taste.

Do you have any Mauve test code for your class? This question may sound
malicious, but I really think that we all should writing more test cases.
(This includes myself, I finally should clean up my test suite for
java.util.logging).

Of course it is boring and takes a lot of time to write stupid test
cases. But if anyone evaluated Classpath in its current state, they'd
probably get quite suspicious about the lack of test cases. Personally, I
wouldn't trust Classpath for anything critical -- not because it's
incomplete, but because so little code is tested by Mauve.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Nov 19 12:19:11 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMVyx-0001fa-FD
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 12:19:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMVys-0001aX-5S
	for classpath@gnu.org; Wed, 19 Nov 2003 12:19:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMVyL-0001DQ-Di
	for classpath@gnu.org; Wed, 19 Nov 2003 12:19:04 -0500
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMVy5-0000rC-81
	for classpath@gnu.org; Wed, 19 Nov 2003 12:18:17 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-65-212.ewetel.net
	[80.228.65.212])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id hAJGGeiR020053;
	Wed, 19 Nov 2003 17:16:42 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AMV0S-00020y-00; Wed, 19 Nov 2003 17:16:40 +0100
Date: Wed, 19 Nov 2003 17:16:40 +0100
From: Michael Koch <konqueror@gmx.de>
To: Sascha Brawer <brawer@dandelis.ch>
Message-ID: <20031119161640.GA6307@mail.konqueror.de>
References: <87ekw5s4je.fsf@dub.venge.net>
	<20031119160432.24598@smtp.mail.ch.easynet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031119160432.24598@smtp.mail.ch.easynet.net>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>, java-patches@gcc.gnu.org,
	graydon hoare <graydon@redhat.com>
Subject: Re: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 17:19:09 -0000

On Wed, Nov 19, 2003 at 05:04:32PM +0100, Sascha Brawer wrote:
> Hi Graydon,
> 
> >this patch implements JLayeredPane and makes some minor adjustments to
> >JFrame and JRootPane.
> 
> Thanks for having written some documentation for the class! Just a
> suggestion: Please separate paragraphs by <p> tags. Also, it IMHO would
> be better to describe attributes like "position" with the respective
> methods (e.g., getPosition), but this may be a matter of personal taste.

Why adding stupid <p> ? Doesnt javadoc/gcjdoc add them automatically ?
If javadoc does and gcjdoc doesnt we should fix the bug in gcjdoc and
not use workarounds.


Michael



From MAILER-DAEMON Wed Nov 19 12:45:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWO2-0000Fy-0t
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 12:45:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWNy-0000Eh-Gt
	for classpath@gnu.org; Wed, 19 Nov 2003 12:45:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWLj-0007lk-Hm
	for classpath@gnu.org; Wed, 19 Nov 2003 12:43:14 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWL1-00073Z-PS
	for classpath@gnu.org; Wed, 19 Nov 2003 12:42:00 -0500
Received: (qmail 8104 invoked by uid 504); 19 Nov 2003 17:40:31 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.777272 secs); 19 Nov 2003 16:40:31 -0000
Received: from unknown (HELO localhost) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 19 Nov 2003 17:40:30 +0100
Date: Wed, 19 Nov 2003 17:50:35 +0100 (CET)
Message-Id: <20031119.175035.45157383.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
In-Reply-To: <20031119160432.24598@smtp.mail.ch.easynet.net>
References: <87ekw5s4je.fsf@dub.venge.net>
	<20031119160432.24598@smtp.mail.ch.easynet.net>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Wed_Nov_19_17_50_35_2003_585)--"
Content-Transfer-Encoding: 7bit
Subject: Mauve tests [was: Re: [PATCH] swing frame fixes]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 17:45:03 -0000

----Security_Multipart(Wed_Nov_19_17_50_35_2003_585)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Wed, 19 Nov 2003 17:04:32 +0100
Sascha Brawer <brawer@dandelis.ch> wrote:

> Do you have any Mauve test code for your class? This question may sound
> malicious, but I really think that we all should writing more test cases.
> (This includes myself, I finally should clean up my test suite for
> java.util.logging).

I'd like to know where are the mauve tests? ./test? ./testsuite?

And maybe how can I write a mauve test for a awt or swing class?

Sorry if it's a dumb question ;)

Cheers,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Wed_Nov_19_17_50_35_2003_585)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u59b4vzFZu62tMIRAi+BAJ9APCFwGkCM6ZVu8GLccNxS4Az2rgCfXYaB
dSkXWt9XN9vGj625TOp8+Fg=
=NhiV
-----END PGP SIGNATURE-----

----Security_Multipart(Wed_Nov_19_17_50_35_2003_585)----



From MAILER-DAEMON Wed Nov 19 12:45:07 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWO2-0000GC-FZ
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 12:45:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWNz-0000Ex-1X
	for classpath@gnu.org; Wed, 19 Nov 2003 12:45:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWNR-0008TH-3m
	for classpath@gnu.org; Wed, 19 Nov 2003 12:45:01 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWNQ-0008Sl-Ia
	for classpath@gnu.org; Wed, 19 Nov 2003 12:44:28 -0500
Received: (qmail 8541 invoked by uid 504); 19 Nov 2003 17:43:02 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.455117 secs); 19 Nov 2003 16:43:02 -0000
Received: from unknown (HELO localhost) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 19 Nov 2003 17:43:01 +0100
Date: Wed, 19 Nov 2003 17:53:10 +0100 (CET)
Message-Id: <20031119.175310.35045407.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org, java-patches@gcc.gnu.org, graydon@redhat.com
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
In-Reply-To: <20031119161640.GA6307@mail.konqueror.de>
References: <87ekw5s4je.fsf@dub.venge.net>
	<20031119160432.24598@smtp.mail.ch.easynet.net>
	<20031119161640.GA6307@mail.konqueror.de>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Wed_Nov_19_17_53_10_2003_875)--"
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 17:45:04 -0000

----Security_Multipart(Wed_Nov_19_17_53_10_2003_875)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Wed, 19 Nov 2003 17:16:40 +0100
Michael Koch <konqueror@gmx.de> wrote:

> Why adding stupid <p> ? Doesnt javadoc/gcjdoc add them automatically ?
> If javadoc does and gcjdoc doesnt we should fix the bug in gcjdoc and
> not use workarounds.

I don't remember javadoc does that. But as javadoc is in html, it's not
really a workaround. Maybe we can write <p>text</p>.

Cheers,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Wed_Nov_19_17_53_10_2003_875)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u5/24vzFZu62tMIRAornAKC6UxTXR0P6/wBYZFa76HE34Hcd9wCeM/ay
gCjm0iw54hun61YF8TAaOiE=
=1mmK
-----END PGP SIGNATURE-----

----Security_Multipart(Wed_Nov_19_17_53_10_2003_875)----



From MAILER-DAEMON Wed Nov 19 13:04:57 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWh1-0006Vq-VD
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:04:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWgb-0005cF-I6
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWfg-0004Lr-VR
	for classpath@gnu.org; Wed, 19 Nov 2003 13:03:52 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWfe-0004Jf-5f
	for classpath@gnu.org; Wed, 19 Nov 2003 13:03:18 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id KAA23146;
	Wed, 19 Nov 2003 10:01:45 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id B31BC4F8286; Wed, 19 Nov 2003 09:52:23 -0700 (MST)
To: Michael Koch <konqueror@gmx.de>
References: <878ymexym1.fsf@fleche.redhat.com>
	<20031119105033.GA29318@mail.konqueror.de>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I'm EXCITED!!  I want a FLANK STEAK WEEK-END!!  I think I'm JULIA
	CHILD!!
Date: 19 Nov 2003 09:52:23 -0700
In-Reply-To: <20031119105033.GA29318@mail.konqueror.de>
Message-ID: <87wu9w712w.fsf@fleche.redhat.com>
Lines: 11
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:04:41 -0000

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> I used this Jalopy version and got a weird indentation in an if
Michael> construct:
Michael> [ ... ]

Michael> I think this should be fixed before we use jalopy.

I agree.  Thanks for finding this.

Tom



From MAILER-DAEMON Wed Nov 19 13:05:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWhO-0006mF-3a
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:05:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWhD-0006g3-IT
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWh0-0006Tr-6h
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:52 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWgv-0006Lk-Jf
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:37 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id KAA23691;
	Wed, 19 Nov 2003 10:03:10 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 746764F8286; Wed, 19 Nov 2003 09:53:50 -0700 (MST)
To: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
References: <87ekw5s4je.fsf@dub.venge.net>
	<20031119160432.24598@smtp.mail.ch.easynet.net>
	<20031119.175035.45157383.arnaud.vandyck@ulg.ac.be>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I'll clean your ROOM!!  I know some GOOD stories, too!!  All about
	ROAD Island's, HUSH Puppies, and how LUKE finds GOLD on his LAND!!
Date: 19 Nov 2003 09:53:50 -0700
In-Reply-To: <20031119.175035.45157383.arnaud.vandyck@ulg.ac.be>
Message-ID: <87smkk710h.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Mauve tests [was: Re: [PATCH] swing frame fixes]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:05:04 -0000

>>>>> "Arnaud" == Arnaud Vandyck <arnaud.vandyck@ulg.ac.be> writes:

Arnaud> I'd like to know where are the mauve tests? ./test? ./testsuite?

http://sources.redhat.com/mauve/

Arnaud> And maybe how can I write a mauve test for a awt or swing
Arnaud> class?

For AWT, I know Tom Fitzsimmons put the Acunia visual tester into a
mauve module.  We could write something similar for the visual parts
of Swing.

Tom



From MAILER-DAEMON Wed Nov 19 13:05:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWhT-0006t9-MX
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:05:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWhF-0006iC-M7
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:57 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWgc-0005hF-3z
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:49 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWgV-0005RC-5T
	for classpath@gnu.org; Wed, 19 Nov 2003 13:04:11 -0500
Received: from [192.168.1.33] (196.56.dyn-adsl.customer.ch.easynet.net
	[217.8.196.56]) by smtp1.mail.ch.easynet.net (Postfix) with ESMTP
	id 28B7B4A36F; Wed, 19 Nov 2003 18:02:43 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>,
	graydon hoare <graydon@redhat.com>
Date: Wed, 19 Nov 2003 18:01:38 +0100
Message-Id: <20031119170138.15317@smtp.mail.ch.easynet.net>
In-Reply-To: <87smkls5nj.fsf@dub.venge.net>
References: <87smkls5nj.fsf@dub.venge.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: java-patches@gcc.gnu.org
Subject: Re: [PATCH] text layout implementation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:05:07 -0000

Hi Graydon,

>this patch implements simple awt text layouts using attributed strings
>and j2d glyph vectors. it will probably need further work, but it is
>enough to get the swing text system limping along.

+        String run = new String();
+        while (ci.current () != CharacterIterator.DONE && 
+               ci.getIndex() < limit)
+          {
+            run += ci.current ();
+            ci.next ();
+          }

Actually, this seems a bit inefficient. Won't the "+=" statement allocate
a new StringBuffer and a new String, plus copy everything around, for
each single character?

  char c;
  StringBuffer buf;

  buf = new StringBuffer(); // can you somehow determine the size?
  while ((c = ci.current ()) != CharacterIterator.DONE && 
         ci.getIndex() < limit)
    {
      buf.append(c);
      ci.next();
    }

But why do you need to create the string at all? Could't you set up a
CharacterIterator so it points to a single font run, and use the method
java.awt.Font.createGlyphVector(FontRenderContext, CharacterIterator)?
This should be much more efficient, because you'd save all those object
allocations. A local class could implement CharacterIterator, but also
have setter methods (or accessible fields), so only a single instance
needs to be allocated.

Also, does the proposed implementation work if there are changes in any
attributes other than font, such as TextAttribute.UNDERLINE? It seems
that all these attributes are lost by passing Strings.

Please don't feel offended if I'm a bit picky here; I'm just trying to
ensure that we have efficient and good code.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Nov 19 13:15:55 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMWrq-0005ew-Ho
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:15:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMWro-0005e5-4A
	for classpath@gnu.org; Wed, 19 Nov 2003 13:15:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMWrF-0005YG-SH
	for classpath@gnu.org; Wed, 19 Nov 2003 13:15:49 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMWpF-0005FC-7a
	for classpath@gnu.org; Wed, 19 Nov 2003 13:13:13 -0500
Received: from [192.168.1.33] (196.56.dyn-adsl.customer.ch.easynet.net
	[217.8.196.56])
	by smtp1.mail.ch.easynet.net (Postfix) with ESMTP id BA1164A2A9
	for <classpath@gnu.org>; Wed, 19 Nov 2003 18:11:46 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Wed, 19 Nov 2003 18:10:42 +0100
Message-Id: <20031119171042.7724@smtp.mail.ch.easynet.net>
In-Reply-To: <20031119.175035.45157383.arnaud.vandyck@ulg.ac.be>
References: <20031119.175035.45157383.arnaud.vandyck@ulg.ac.be>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: Mauve tests
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:15:53 -0000

Arnaud Vandyck <arnaud.vandyck@ulg.ac.be> wrote on Wed, 19 Nov
2003 17:50:35 +0100:

>I'd like to know where are the mauve tests? ./test? ./testsuite?

http://sources.redhat.com/mauve/

>And maybe how can I write a mauve test for a awt or swing class?

For examples, see the tests for java.awt.geom.* or javax.swing.undo.

The truly interactive parts are certainly more difficult to test,
although there exists a class java.awt.Robot for this purpose. However,
Robot is currently not implemented in Classpath. :-(

>Sorry if it's a dumb question ;)

Not at all!

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Nov 19 13:45:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMXKP-0002z8-G0
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:45:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMXKK-0002wh-0K
	for classpath@gnu.org; Wed, 19 Nov 2003 13:45:20 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMXJl-0002rF-PV
	for classpath@gnu.org; Wed, 19 Nov 2003 13:45:16 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMXJj-0002qn-UU
	for classpath@gnu.org; Wed, 19 Nov 2003 13:44:44 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id KAA05609;
	Wed, 19 Nov 2003 10:43:15 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 908204F8286; Wed, 19 Nov 2003 10:33:56 -0700 (MST)
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org> <87d6bpb94i.fsf@fleche.redhat.com>
	<3FBAC9A8.6030002@kaffe.org> <3FBB512F.3000606@kaffe.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Look!!  Karl Malden!
Date: 19 Nov 2003 10:33:56 -0700
In-Reply-To: <3FBB512F.3000606@kaffe.org>
Message-ID: <87llqc6z5n.fsf@fleche.redhat.com>
Lines: 8
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:45:21 -0000

>>>>> "Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:

Dalibor> Done. Please review the next revision, and check in if it's o.k.

Looks ok to me, I checked it in.
Do you not have classpath write access?

Tom



From MAILER-DAEMON Wed Nov 19 13:52:51 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMXRS-0008SD-Am
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 13:52:42 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMXQm-0007ZJ-S8
	for classpath@gnu.org; Wed, 19 Nov 2003 13:52:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMXPx-0005kt-NQ
	for classpath@gnu.org; Wed, 19 Nov 2003 13:51:41 -0500
Received: from [212.227.126.185] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMXPp-0005S6-OA
	for classpath@gnu.org; Wed, 19 Nov 2003 13:51:01 -0500
Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de)
	by moutng7.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1AMWSL-0007Lj-00; Wed, 19 Nov 2003 18:49:33 +0100
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1AMWSM-00040A-00; Wed, 19 Nov 2003 18:49:34 +0100
Message-ID: <3FBBAD2D.8070000@aicas.com>
Date: Wed, 19 Nov 2003 18:49:33 +0100
From: =?ISO-8859-15?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <878ymexym1.fsf@fleche.redhat.com>
In-Reply-To: <878ymexym1.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 18:52:40 -0000

Hi,

have we decided to have tabs in the source code ?

It seems that my tabs are olny half the size of the tabs that jalopy 
assumes. In the snippet below I have replaced the the tabs with spaces 
to resemble the look that I get. Could we stick to a space only setting?

     switch (e.getID())
       {
       case PaintEvent.UPDATE:
       case PaintEvent.PAINT:
     Graphics g = getComponent().getGraphics();
     paint(g);
     g.dispose();
       default:  }

Also note the closing curly braces on the wrong line.

Thanks.
ingo

Tom Tromey wrote:
> Raif Naffah sent me a couple nice jalopy patches to implement things
> from my last wish-list.  I wrote a new patch myself, to get jalopy to
> use tabs for indentation in the way we expect.
> 
> I made a new release with these improvements.  Once again, it is here:
> 
>     ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz
> 
> You'll also want this file, which is the GNU.xml style:
> 
>     ftp://sources.redhat.com/pub/java/GNU.xml
> 
> This is somewhat different from the last one.
> 
> 
> This version seems to be much better.  The strange Point.java change
> has disappeared (I didn't try to find out why).
> 
> At this point I think we are ready to try this version of jalopy for
> real.  I propose we pick a package to reformat and check in.
> Preferably we'd pick something where active work is going on, so we
> could more easily notice whatever jalopy doesn't handle well.
> 
> 
> Long term, we need to find a cvs repository for this version.  We
> should also put GNU.xml into the classpath repository; I'll do this if
> we're all on board for the test drive.
> 
> Tom
> 
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath
> 




From MAILER-DAEMON Wed Nov 19 14:26:43 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMXy2-0001eE-CC
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 14:26:22 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMXwR-0001Kk-A6
	for classpath@gnu.org; Wed, 19 Nov 2003 14:24:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMXvj-0000ws-3z
	for classpath@gnu.org; Wed, 19 Nov 2003 14:24:30 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMXvS-0000t9-RO
	for classpath@gnu.org; Wed, 19 Nov 2003 14:23:43 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMWxZ-0001am-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 19:21:49 +0100
From: Mark Wielaard <mark@klomp.org>
To: GNU Classpath <classpath@gnu.org>
In-Reply-To: <3FBAC3ED.1010904@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
	<1069190892.1745.23.camel@elsschot.wildebeest.org>
	<3FBAC3ED.1010904@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-H98XPk57kF/wi9Y01ZvB"
Message-Id: <1069266136.2856.42.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 19 Nov 2003 19:22:17 +0100
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 19:26:20 -0000


--=-H98XPk57kF/wi9Y01ZvB
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2003-11-19 at 02:14, Dalibor Topic wrote:
> > The documentation and code don't match up now.
> > My Class Library book seems to indicate that it actually is instanceof,
> > thought in most cases your code comparing the actual Class seems more
> > correct.
>=20
> It's the recommended way of doing equals() if you want to avoid symmetry
> bugs. See PRAXIS 12 in Peter Haggar's Practical Java, or =A75.1, p 119 in
> Java 2 performance and idion guide by craig lahrmann & rhett guthrie, or
> Effective Java by Joshua Bloch. Using instanceof is a bad idea because
> it allows for symmetry bugs:

I know. But that wasn't the point. If you change to code then you must
also update the documentation.

> 7 is the largest prime, that's still an iconst, iconst_7, afaik. That=20
> makes it take less bytecode.
>=20
> The rest follows recommendations from Joshua Bloch on writing good=20
> hashCode methods.

It would be nice if we had something about the right way (tm) of writing
the standard clone(), toString(), hashCode() and equals() in the Hackers
Guide. (hint...)

> > I couldn't find one specified, so I guess any good one will do.
> > Don't know if you need to include the field_attribute.hashCode() since
> > it will probably depend on the field_id in almost all cases.
>=20
> If two objects are not equal, they should have different hashCodes.=20
> field_attribute is checked in the equality test, so it should play a=20
> role in hashCode calculation as well.

Should yes, but not must. I was just wondering whether or not the
field_attribute really matters since that field and field_id indicate
the same property. Having cheap hashCode() methods is a good thing and
IMHO field_attribute does not make the hashCode() more specific. But if
you think otherwise then please do it as you have it now.

Cheers,

Mark

--=-H98XPk57kF/wi9Y01ZvB
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u7TYxVhZCJWr9QwRAvWOAJ0bvyl97OS7/dQNqWIxrVCtZ5JsOACdGCd1
Qy1+wOnnEAhyU+jVpJcFOek=
=XF+n
-----END PGP SIGNATURE-----

--=-H98XPk57kF/wi9Y01ZvB--




From MAILER-DAEMON Wed Nov 19 14:47:26 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMYIQ-0007GJ-Jf
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 14:47:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMYIO-0007G2-0M
	for classpath@gnu.org; Wed, 19 Nov 2003 14:47:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMYHs-0007BL-9U
	for classpath@gnu.org; Wed, 19 Nov 2003 14:47:23 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMYHr-0007BD-VK
	for classpath@gnu.org; Wed, 19 Nov 2003 14:46:52 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMXJe-0001d2-00; Wed, 19 Nov 2003 19:44:38 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FBB862E.2090602@kaffe.org>
References: <87wu9xs5tw.fsf@dub.venge.net>  <3FBB862E.2090602@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-iKXoRUcbOBPmPF/tMZSL"
Message-Id: <1069267505.2856.63.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 19 Nov 2003 19:45:06 +0100
Cc: classpath@gnu.org, java-patches@gcc.gnu.org,
	graydon hoare <graydon@redhat.com>
Subject: Re: [PATCH] attributed string fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 19:47:24 -0000


--=-iKXoRUcbOBPmPF/tMZSL
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2003-11-19 at 16:03, Dalibor Topic wrote:
> graydon hoare wrote:
> >=20
> > 2003-11-18  Graydon Hoare  <graydon@redhat.com>
> >=20
> > 	* java/text/AttributedString.java: Fix arithmetic.
> > 	* java/text/AttributedStringIterator.java: Likewise.
>=20
> PLease take a look at Guilhem's patches to java.text first. Your patch=20
> fails with kaffe's version of the file for 3 hunks:
>=20
> patching file java/text/AttributedString.java
> Hunk #3 FAILED at 407.
> Hunk #4 FAILED at 217.
> Hunk #5 FAILED at 266.
> 3 out of 5 hunks FAILED -- saving rejects to file=20
> java/text/AttributedString.java.rej

Dalibor is referring to following Classpath bugs:
https://savannah.gnu.org/bugs/?func=3Ddetailbug&bug_id=3D4968&group_id=3D85
https://savannah.gnu.org/bugs/?func=3Ddetailbug&bug_id=3D4118&group_id=3D85

The first one has already been partly merged in and for the second bug
Stephen Crawley already created some Mauve tests for the second case.

I didn't have time to go through the complete patches yet and they don't
apply cleanly anymore so updated patches are very welcome.

Cheers,

Mark

--=-iKXoRUcbOBPmPF/tMZSL
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u7oxxVhZCJWr9QwRAreyAKCOex4HcKU1EFBFKSPfMnt4oyRtBwCfWPST
SNNeCPEPyXRpsesyzCtOvaY=
=G/H/
-----END PGP SIGNATURE-----

--=-iKXoRUcbOBPmPF/tMZSL--




From MAILER-DAEMON Wed Nov 19 14:48:53 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMYJp-0007j0-39
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 14:48:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMYJl-0007i3-In
	for classpath@gnu.org; Wed, 19 Nov 2003 14:48:49 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMYCP-0006KM-To
	for classpath@gnu.org; Wed, 19 Nov 2003 14:41:45 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMYAr-00069Q-5M
	for classpath@gnu.org; Wed, 19 Nov 2003 14:39:37 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMXCZ-0001c8-00; Wed, 19 Nov 2003 19:37:19 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <20031119131309.GA4896@mail.konqueror.de>
References: <3FB396C3.8060705@kaffe.org>
	<20031119131309.GA4896@mail.konqueror.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-rRhL+x+VZCFWPQEIZlMy"
Message-Id: <1069267066.2850.57.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 19 Nov 2003 19:37:46 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 19:48:50 -0000


--=-rRhL+x+VZCFWPQEIZlMy
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2003-11-19 at 14:13, Michael Koch wrote:
> > --- /var/tmp/PROJECTS/classpath//./java/net/ServerSocket.java	Fri Oct 1=
7 19:05:29 2003
> > +++ java/net/ServerSocket.java	Wed Oct 22 21:32:21 2003
> > @@ -339,7 +339,8 @@
> >     */
> >    public void close () throws IOException
> >    {
> > -    impl.close ();
> > +    if (impl !=3D null)
> > +      impl.close ();
> > =20
> >      if (getChannel() !=3D null)
> >        getChannel().close ();
>=20
> After thinking about this patch, its more and more bogus in my eyes as
> impl never may be null. I provided a better fix to libgcj. When its
> approved I will merge it into classpath too.

You are right. I saw your patch on the java-patches mailinglist to make
sure impl will never be null. Sorry for not investigation the root cause
before committing it. But it looked like having an extra sanity check
here wouldn't hurt.

I hope to propose a bit more formal patch/commit strategy in the next
couple of weeks (like libgcj already has). Now that we are attracting
more and more developers with different background it would be nice to
have more formal procedure so that a) patches are not lost, b) all
patches are actually reviewed.

> What would really interest me is the testcase from Guilhem that
> triggered this.

Yes, that would be nice.
I did test it against Mauve with Kissme before checking in (please never
check something in if you cannot test it against Mauve and some VM). But
since there were multiple tests broken already=20

I hope that I can cleanup Mauve enough before next week (when we will
create the 0.07 snapshot release) to activate a autobuilder which we can
use to track failures. But Currently Mauve is still to fragile for this.

Cheers,

Mark

--=-rRhL+x+VZCFWPQEIZlMy
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u7h6xVhZCJWr9QwRAkJdAKCpaXYlN0F8aMepmSxL11W0bidYNgCgjtLV
m/HjcQzDuGrwOZMgRn3EH4Q=
=MiAH
-----END PGP SIGNATURE-----

--=-rRhL+x+VZCFWPQEIZlMy--




From MAILER-DAEMON Wed Nov 19 15:22:31 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMYqN-0003Y4-5m
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 15:22:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMYqK-0003XQ-DW
	for classpath@gnu.org; Wed, 19 Nov 2003 15:22:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMYpn-0003SJ-Cv
	for classpath@gnu.org; Wed, 19 Nov 2003 15:22:26 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMYpl-0003Rg-LV
	for classpath@gnu.org; Wed, 19 Nov 2003 15:21:53 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMXsK-0002sP-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 20:20:28 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMXsG-0002r4-00; Wed, 19 Nov 2003 20:20:24 +0100
Message-ID: <3FBBC278.4070504@kaffe.org>
Date: Wed, 19 Nov 2003 20:20:24 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <3FB673C1.6010206@kaffe.org>	<1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>
	<87d6bpb94i.fsf@fleche.redhat.com>	<3FBAC9A8.6030002@kaffe.org>
	<3FBB512F.3000606@kaffe.org> <87llqc6z5n.fsf@fleche.redhat.com>
In-Reply-To: <87llqc6z5n.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 20:22:29 -0000

Tom Tromey wrote:
>>>>>>"Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:
> 
> 
> Dalibor> Done. Please review the next revision, and check in if it's o.k.
> 
> Looks ok to me, I checked it in.
> Do you not have classpath write access?

Nope, not yet ;) Bryce asked back when I sent in my paperwork if I 
wanted it, and I didn't, as I had no use for it back then. It wasn't 
clear whether kaffe would switch to GNU Classpath completely, so I 
didn't want to risk potentially polluting Classpath with GPLd code from 
kaffe as I wasn't sure how to do the merge properly.

Now that I know how to merge stuff properly (drop kaffe's implementation 
for a class, chuck in Classpath's, review, fix, submit a patch to 
Classpath) I have no such fear anymore, so that's changed a bit.

So if you want to offer me write access again, I'd take it ;)

cheers,
dalibor topic




From MAILER-DAEMON Wed Nov 19 15:26:57 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMYuf-0004V0-GN
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 15:26:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMYua-0004U8-Nn
	for classpath@gnu.org; Wed, 19 Nov 2003 15:26:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMYu2-0004Lg-1j
	for classpath@gnu.org; Wed, 19 Nov 2003 15:26:49 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMYu1-0004LJ-Ej
	for classpath@gnu.org; Wed, 19 Nov 2003 15:26:17 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA09263;
	Wed, 19 Nov 2003 12:24:51 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 93EFF4F8286; Wed, 19 Nov 2003 12:15:25 -0700 (MST)
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org> <87d6bpb94i.fsf@fleche.redhat.com>
	<3FBAC9A8.6030002@kaffe.org> <3FBB512F.3000606@kaffe.org>
	<87llqc6z5n.fsf@fleche.redhat.com> <3FBBC278.4070504@kaffe.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: SHHHH!!  I hear SIX TATTOOED TRUCK-DRIVERS tossing ENGINE BLOCKS
	into empty OIL DRUMS..
Date: 19 Nov 2003 12:15:25 -0700
In-Reply-To: <3FBBC278.4070504@kaffe.org>
Message-ID: <87n0as5fw2.fsf@fleche.redhat.com>
Lines: 9
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 20:26:56 -0000

>>>>> "Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:

Dalibor> So if you want to offer me write access again, I'd take it ;)

I think it would be a good idea.  You can make a savannah account
yourself, if you don't already have one.  Then Mark has to do some
admin thing to give you access.

Tom



From MAILER-DAEMON Wed Nov 19 15:37:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMZ4v-0006Ia-Os
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 15:37:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMZ4s-0006HA-9R
	for classpath@gnu.org; Wed, 19 Nov 2003 15:37:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMZ4B-00065o-Tm
	for classpath@gnu.org; Wed, 19 Nov 2003 15:37:19 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMZ4A-000646-66
	for classpath@gnu.org; Wed, 19 Nov 2003 15:36:46 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AMY6f-0005Iv-00
	for <classpath@gnu.org>; Wed, 19 Nov 2003 20:35:17 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AMY6b-0005IB-00; Wed, 19 Nov 2003 20:35:13 +0100
Message-ID: <3FBBC5F1.8040301@kaffe.org>
Date: Wed, 19 Nov 2003 20:35:13 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <3FB673C1.6010206@kaffe.org>	<1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>
	<87d6bpb94i.fsf@fleche.redhat.com>	<3FBAC9A8.6030002@kaffe.org>
	<3FBB512F.3000606@kaffe.org>	<87llqc6z5n.fsf@fleche.redhat.com>
	<3FBBC278.4070504@kaffe.org> <87n0as5fw2.fsf@fleche.redhat.com>
In-Reply-To: <87n0as5fw2.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 20:37:31 -0000

Tom Tromey wrote:
>>>>>>"Dalibor" == Dalibor Topic <robilad@kaffe.org> writes:
> 
> 
> Dalibor> So if you want to offer me write access again, I'd take it ;)
> 
> I think it would be a good idea.  You can make a savannah account
> yourself, if you don't already have one.  Then Mark has to do some
> admin thing to give you access.

I've got a savannah account already[1], mostly for filing bugs & patches 
on Classpath ;)

cheers,
dalibor topic

[1] under the unobvious name of robilad.




From MAILER-DAEMON Wed Nov 19 16:12:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMZcp-0005PG-Ba
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 16:12:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMZcm-0005Nf-A5
	for classpath@gnu.org; Wed, 19 Nov 2003 16:12:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMZTe-00033d-Cc
	for classpath@gnu.org; Wed, 19 Nov 2003 16:03:37 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMYea-0001Od-Ij
	for classpath@gnu.org; Wed, 19 Nov 2003 15:10:20 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA03763;
	Wed, 19 Nov 2003 12:08:49 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 373D94F8286; Wed, 19 Nov 2003 11:59:27 -0700 (MST)
To: Mark Wielaard <mark@klomp.org>
References: <3FB396C3.8060705@kaffe.org>
	<20031119131309.GA4896@mail.konqueror.de>
	<1069267066.2850.57.camel@elsschot.wildebeest.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: ..  I think I'd better go back to my DESK and toy with
	a few common MISAPPREHENSIONS...
Date: 19 Nov 2003 11:59:26 -0700
In-Reply-To: <1069267066.2850.57.camel@elsschot.wildebeest.org>
Message-ID: <87vfpg5gmp.fsf@fleche.redhat.com>
Lines: 32
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: [PATCH] small fix for ServerSocket close
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 21:12:33 -0000

>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> I hope that I can cleanup Mauve enough before next week (when we
Mark> will create the 0.07 snapshot release) to activate a autobuilder
Mark> which we can use to track failures. But Currently Mauve is still
Mark> to fragile for this.

FWIW, I run Mauve as part of my nightly builds.  I don't think Mauve
is all that fragile, it hardly ever seems to be the part of the
process that has trouble.

These days the nightly tester is doing quite a bit:

* Build gcc from scratch.  Run the test suite including Mauve and Jacks
* Build classpath from scratch with new gcj and jikes
* Build rhug with new gcj
* Build GNU Crypto and Kawa with gcj
* Run Classpath/libgcj comparison and JAPI comparison

Also I run the test suites for all of these things.
Some of it doesn't work that reliably... rhug hasn't built completely
in months, classpath fails with gcj.  Of course, I wouldn't know that
without the nightly tester :-)

I'm not publishing the info anywhere, I just have it send me email.
And the scripts to do all this are a little ugly.  Still, as long as
the builds are done when I start work in the morning, I'm happy to add
stuff... ideally I'd have a recipe (so I don't have to think :-).  I'd
be happy to send the reports somewhere, too, if there were agreement
on where.

Tom



From MAILER-DAEMON Wed Nov 19 16:27:52 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMZrb-0001rA-Ag
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 16:27:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMZrX-0001pB-99
	for classpath@gnu.org; Wed, 19 Nov 2003 16:27:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMZma-0000OB-Gu
	for classpath@gnu.org; Wed, 19 Nov 2003 16:23:11 -0500
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMZmR-0000Ls-RS
	for classpath@gnu.org; Wed, 19 Nov 2003 16:22:31 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix3-1.free.fr (Postfix) with ESMTP
	id 05188C42EF; Wed, 19 Nov 2003 21:21:05 +0100 (CET)
Message-ID: <3FBBD0AB.3000308@kaffe.org>
Date: Wed, 19 Nov 2003 21:20:59 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <87wu9xs5tw.fsf@dub.venge.net> <3FBB862E.2090602@kaffe.org>
	<1069267505.2856.63.camel@elsschot.wildebeest.org>
In-Reply-To: <1069267505.2856.63.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org, java-patches@gcc.gnu.org,
	graydon hoare <graydon@redhat.com>
Subject: Re: [PATCH] attributed string fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 21:27:48 -0000

Mark Wielaard wrote:

>Hi,
>
>On Wed, 2003-11-19 at 16:03, Dalibor Topic wrote:
>  
>
>>graydon hoare wrote:
>>    
>>
>>>2003-11-18  Graydon Hoare  <graydon@redhat.com>
>>>
>>>	* java/text/AttributedString.java: Fix arithmetic.
>>>	* java/text/AttributedStringIterator.java: Likewise.
>>>      
>>>
>>PLease take a look at Guilhem's patches to java.text first. Your patch 
>>fails with kaffe's version of the file for 3 hunks:
>>
>>patching file java/text/AttributedString.java
>>Hunk #3 FAILED at 407.
>>Hunk #4 FAILED at 217.
>>Hunk #5 FAILED at 266.
>>3 out of 5 hunks FAILED -- saving rejects to file 
>>java/text/AttributedString.java.rej
>>    
>>
>
>Dalibor is referring to following Classpath bugs:
>https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4968&group_id=85
>https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4118&group_id=85
>
>The first one has already been partly merged in and for the second bug
>Stephen Crawley already created some Mauve tests for the second case.
>
>I didn't have time to go through the complete patches yet and they don't
>apply cleanly anymore so updated patches are very welcome.
>
>  
>
I have quickly hacked a merge between current implementation and mine. 
The patch has been built using today's classpath CVS. If anybody can review it...
;-) I remind that this collator implements everything but one feature of Java's API 
('!' and some puzzling behaviour highlighted by 2 Mauve tests).

The new patch is available at:
https://savannah.gnu.org/bugs/?func=detailbug&bug_id=4118&group_id=85

The other one is following tomorrow or on friday... 

Regards,
Guilhem.





From MAILER-DAEMON Wed Nov 19 16:42:11 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMa5S-0007fq-Vh
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 16:42:10 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMa5O-0007ep-Fz
	for classpath@gnu.org; Wed, 19 Nov 2003 16:42:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMa4r-0007Vt-AI
	for classpath@gnu.org; Wed, 19 Nov 2003 16:42:04 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMa4p-0007Rb-Hp
	for classpath@gnu.org; Wed, 19 Nov 2003 16:41:31 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hAJKdrH11101;
	Wed, 19 Nov 2003 15:39:53 -0500
Received: from dub.venge.net (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hAJKdqw21472; 
	Wed, 19 Nov 2003 15:39:52 -0500
Sender: graydon@dub.venge.net
To: Sascha Brawer <brawer@dandelis.ch>
References: <87smkls5nj.fsf@dub.venge.net>
	<20031119170138.15317@smtp.mail.ch.easynet.net>
From: graydon hoare <graydon@redhat.com>
Date: 19 Nov 2003 15:38:19 -0500
In-Reply-To: <20031119170138.15317@smtp.mail.ch.easynet.net>
Message-ID: <873cckksas.fsf@dub.venge.net>
Lines: 33
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: GNU Classpath <classpath@gnu.org>, java-patches@gcc.gnu.org
Subject: Re: [PATCH] text layout implementation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 21:42:09 -0000

--=-=-=

Sascha Brawer <brawer@dandelis.ch> writes:

> But why do you need to create the string at all? Could't you set up a
> CharacterIterator so it points to a single font run, and use the method
> java.awt.Font.createGlyphVector(FontRenderContext, CharacterIterator)?
> This should be much more efficient, because you'd save all those object
> allocations. A local class could implement CharacterIterator, but also
> have setter methods (or accessible fields), so only a single instance
> needs to be allocated.

ok, changed to do this.

> Also, does the proposed implementation work if there are changes in any
> attributes other than font, such as TextAttribute.UNDERLINE? It seems
> that all these attributes are lost by passing Strings.

well, the CharacterIteratorProxy I've implemented (modified patch
below) doesn't do the whole AttributedCharacterIterator interface, but
there's no method on Font to create a glyph vector with an
AttributedCharacterIterator anyways. I think we'd have to interpret
extra attributes as calls to deriveFont or something, no?

> Please don't feel offended if I'm a bit picky here; I'm just trying to
> ensure that we have efficient and good code.

not at all, this is precisely the sort of polishing that code review
fosters, I'm glad to get the suggestions (as I was, belatedly, with
the graphics2d suggestions).

-graydon


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=j2d-textlayout-fix.patch

--- java/awt/font/TextLayout.java	17 Feb 2003 08:05:50 -0000	1.1
+++ java/awt/font/TextLayout.java	19 Nov 2003 20:34:57 -0000
@@ -43,8 +43,12 @@
 import java.awt.Shape;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.Rectangle2D;
+import java.text.CharacterIterator;
 import java.text.AttributedCharacterIterator;
+import java.text.AttributedString;
 import java.util.Map;
+import java.awt.font.TextAttribute;
+
 
 /**
  * @author Michael Koch
@@ -67,24 +71,26 @@
     }
   }
 
+  private AttributedString attributedString;
   private FontRenderContext fontRenderContext;
   
   public TextLayout (AttributedCharacterIterator text, FontRenderContext frc)
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (text);
+    fontRenderContext = frc;
   }
 
   public TextLayout (String string, Font font, FontRenderContext frc) 
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (string);
+    attributedString.addAttribute (TextAttribute.FONT, font);
+    fontRenderContext = frc;
   }
 
   public TextLayout (String string, Map attributes, FontRenderContext frc) 
   {
-    // FIXME
-    this.fontRenderContext = frc;
+    attributedString = new AttributedString (string, attributes);
+    fontRenderContext = frc;
   }
 
   protected Object clone ()
@@ -100,9 +106,139 @@
       }
   }
 
+
+  protected class CharacterIteratorProxy 
+    implements CharacterIterator
+  {
+    public CharacterIterator target;
+    public int begin;
+    public int limit;
+    public int index;
+
+    public CharacterIteratorProxy (CharacterIterator ci)
+    {
+      target = ci;
+    }
+
+    public int getBeginIndex ()
+    {
+      return begin;
+    }
+
+    public int getEndIndex ()
+    {
+      return limit;
+    }
+
+    public int getIndex ()
+    {
+      return index;
+    }
+
+    public char setIndex (int idx) 
+      throws IllegalArgumentException
+    {
+      if (idx < begin || idx >= limit)
+        throw new IllegalArgumentException ();
+      char ch = target.setIndex (idx);
+      index = idx;
+      return ch;
+    }
+
+    public char first ()
+    {
+      int save = target.getIndex ();
+      char ch = target.setIndex (begin);
+      target.setIndex (save);
+      return ch;
+    }
+
+    public char last ()
+    {
+      if (begin == limit)
+        return this.first ();
+
+      int save = target.getIndex ();
+      char ch = target.setIndex (limit - 1);
+      target.setIndex (save);
+      return ch;
+    }
+
+    public char current ()
+    {
+      return target.current();
+    }
+
+    public char next ()
+    {
+      if (index >= limit - 1)
+        return CharacterIterator.DONE;
+      else
+        {
+          index++;
+          return target.next();
+        }
+    }
+
+    public char previous ()
+    {
+      if (index <= begin)
+        return CharacterIterator.DONE;
+      else
+        {
+          index--;
+          return target.previous ();
+        }
+    }
+
+    public Object clone ()
+    {
+      CharacterIteratorProxy cip = new CharacterIteratorProxy (this.target);
+      cip.begin = this.begin;
+      cip.limit = this.limit;
+      cip.index = this.index;
+      return cip;
+    }
+    
+  }
+
+
   public void draw (Graphics2D g2, float x, float y) 
   {
-    throw new Error ("not implemented");
+    AttributedCharacterIterator ci = attributedString.getIterator ();
+    CharacterIteratorProxy proxy = new CharacterIteratorProxy (ci);
+    Font defFont = g2.getFont ();
+
+    for (char c = ci.first ();
+         c != CharacterIterator.DONE;
+         c = ci.next ())
+      {                
+        proxy.begin = ci.getIndex ();
+        proxy.limit = ci.getRunLimit(TextAttribute.FONT);
+        if (proxy.limit <= proxy.begin)
+          continue;
+
+        proxy.index = proxy.begin;
+
+        Object fnt = ci.getAttribute(TextAttribute.FONT);
+        GlyphVector gv;
+        if (fnt != null && fnt instanceof Font)          
+          gv = ((Font)fnt).createGlyphVector (fontRenderContext, proxy);
+        else
+          gv = defFont.createGlyphVector (fontRenderContext, proxy);
+
+        g2.drawGlyphVector (gv, x, y);
+
+        int n = gv.getNumGlyphs ();
+        for (int i = 0; i < n; ++i)
+          {
+            GlyphMetrics gm = gv.getGlyphMetrics (i);
+            if (gm.getAdvanceX() == gm.getAdvance ())
+              x += gm.getAdvanceX ();
+            else
+              y += gm.getAdvanceY ();
+          }
+      }
   }
 
   public boolean equals (Object obj)

--=-=-=--




From MAILER-DAEMON Wed Nov 19 17:14:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMaaF-0007HW-Fv
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 17:13:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMaaB-0007AJ-4b
	for classpath@gnu.org; Wed, 19 Nov 2003 17:13:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMaZa-0006Sh-Aq
	for classpath@gnu.org; Wed, 19 Nov 2003 17:13:49 -0500
Received: from [193.74.71.22] (helo=guri.is.kpn.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMaZZ-0006PY-3Y
	for classpath@gnu.org; Wed, 19 Nov 2003 17:13:17 -0500
Received: from (eudslpro-213-49-17-120.antwerp.kpn.be [213.49.17.120]) 
	by guri.is.kpn.be  with SMTP id hAJLBcZ07979; 
	Wed, 19 Nov 2003 22:11:39 +0100
Message-Id: <200311192111.hAJLBcZ07979@guri.is.kpn.be>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Dalibor Topic <robilad@kaffe.org>, Jeroen Frijters <jeroen@sumatra.nl>
Date: Wed, 19 Nov 2003 22:12:17 +0100
X-Mailer: KMail [version 1.3]
References: <788B535AB1F9CB49BB9C229372B50ACC04C680@LEMBU.sumatrasoftware.com>
	<3FBB4841.3010808@kaffe.org>
In-Reply-To: <3FBB4841.3010808@kaffe.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 22:13:57 -0000

On Wednesday 19 November 2003 11:38, Dalibor Topic wrote:
> Jeroen Frijters wrote:
> > Dalibor Topic wrote:
[...]
> >>If two objects are not equal, they should have different hashCodes.
> >
> > No this isn't true, however, if two objects are equal, they must have
> > identical hashCodes. It would be nice if unequal objects had different
> > hashCodes, but this is not a requirement.
>
> Note that I used *should* in my sentence instead of *must*, and reparse
> what I said ;)

In general it's impossible to ensure that non-equal objects have different 
hashcodes - just think for a moment about java.lang.Long. So IMHO even 
"should" is going too far ...

-- 
Chris Gray                                /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                      +32 477 599 703



From MAILER-DAEMON Wed Nov 19 18:52:55 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMc7x-0003ff-LV
	for mharc-classpath@gnu.org; Wed, 19 Nov 2003 18:52:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMc5b-00022O-Cd
	for classpath@gnu.org; Wed, 19 Nov 2003 18:50:27 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMc1c-0000Io-00
	for classpath@gnu.org; Wed, 19 Nov 2003 18:46:51 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMc0f-0008R8-G5
	for classpath@gnu.org; Wed, 19 Nov 2003 18:45:21 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMb2g-0002CP-00; Wed, 19 Nov 2003 23:43:22 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <oprysqhmiwreuyrv@tangency.co.uk>
References: <oprysks71yreuyrv@tangency.co.uk>
	<00ae01c3ad32$74373110$0300a8c0@allanon>
	<oprysqhmiwreuyrv@tangency.co.uk>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-i0kjVYeWpd5WfB/U9JZq"
Message-Id: <1069281830.2851.219.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 19 Nov 2003 23:43:50 +0100
Cc: Kaffe Mailing List <kaffe@kaffe.org>
Subject: Re: Graphical Algorithm documents
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 23:52:51 -0000


--=-i0kjVYeWpd5WfB/U9JZq
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2003-11-17 at 20:16, S. Meslin-Weber wrote:
> I stumbled on some interesting algorithm documents today and thought=20
> others implementing low-level primitives in Java (Graphics and/or Java2D)=
=20
> might find them useful. I emailed the author and we are welcome to use th=
e=20
> documents at:
>=20
> http://www.magic-software.com/Documentation/
>=20
> Hope some other than I will find this useful!

Thanks for that info. It looks very useful.
It is of course OK to read about those algorithms and create an
implementation of them for inclusion in GNU Classpath. But please
contact me before you use/copy any code snippets. The commercial-use
restrictions in their license look confusing to me and when we want to
use it in GNU Classpath (which may be used commercially) we certainly
have to contact the author about it (and check with fsf-licensing).

Thanks,

Mark "paranoia maintainer" Wielaard

--=-i0kjVYeWpd5WfB/U9JZq
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/u/ImxVhZCJWr9QwRAgBsAKCJ0cQAgeQURG57Nhn0Wio6p6ZfQwCfXNYo
Y2oQ5UOsmBpGlraOemfX2Dw=
=11P2
-----END PGP SIGNATURE-----

--=-i0kjVYeWpd5WfB/U9JZq--




From MAILER-DAEMON Thu Nov 20 07:20:14 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMnnA-00061q-VB
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 07:20:12 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMnn7-00061P-Cm
	for classpath@gnu.org; Thu, 20 Nov 2003 07:20:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMnma-0005yj-3q
	for classpath@gnu.org; Thu, 20 Nov 2003 07:20:07 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMnmZ-0005yS-GF
	for classpath@gnu.org; Thu, 20 Nov 2003 07:19:35 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C3AF57.F9E99B3D"
Date: Thu, 20 Nov 2003 12:17:55 +0100
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C688@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
Thread-Topic: Suggested Runtime change and small Thread fix
Thread-Index: AcOvV/IFIqAdaKF6SJiCS6cjISMmYg==
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "GNU Classpath" <classpath@gnu.org>
Subject: Suggested Runtime change and small Thread fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 12:20:10 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C3AF57.F9E99B3D
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable

Hi,

I would like to move the code to run the shutdown hooks from exit() to a
new method. This allows me to also run the shutdown hooks if the process
termination is triggered by code outside of Java (in my .NET JVM). I
can't see it hurting any other scenarios.

Any objections or comments?

Also fixed Thread.start() to throw IllegalThreadStateException instead
of IllegalStateException.

Regards,
Jeroen

------_=_NextPart_001_01C3AF57.F9E99B3D
Content-Type: application/octet-stream;
	name="thread.diff"
Content-Transfer-Encoding: base64
Content-Description: thread.diff
Content-Disposition: attachment;
	filename="thread.diff"

SW5kZXg6IGphdmEvbGFuZy9UaHJlYWQuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNy
b290L2NsYXNzcGF0aC9jbGFzc3BhdGgvamF2YS9sYW5nL1RocmVhZC5qYXZhLHYNCnJldHJpZXZp
bmcgcmV2aXNpb24gMS4xDQpkaWZmIC11IC1yMS4xIFRocmVhZC5qYXZhDQotLS0gamF2YS9sYW5n
L1RocmVhZC5qYXZhCTI5IEF1ZyAyMDAzIDEyOjQzOjA3IC0wMDAwCTEuMQ0KKysrIGphdmEvbGFu
Zy9UaHJlYWQuamF2YQkyMCBOb3YgMjAwMyAxMTowNzo0MiAtMDAwMA0KQEAgLTM4OCw3ICszODgs
NyBAQA0KICAgcHVibGljIHN5bmNocm9uaXplZCB2b2lkIHN0YXJ0KCkNCiAgIHsNCiAgICAgaWYg
KHZtVGhyZWFkICE9IG51bGwgfHwgZ3JvdXAgPT0gbnVsbCkNCi0JdGhyb3cgbmV3IElsbGVnYWxT
dGF0ZUV4Y2VwdGlvbigpOw0KKwl0aHJvdyBuZXcgSWxsZWdhbFRocmVhZFN0YXRlRXhjZXB0aW9u
KCk7DQogDQogICAgIFZNVGhyZWFkLmNyZWF0ZSh0aGlzLCBzdGFja3NpemUpOw0KICAgfQ0K

------_=_NextPart_001_01C3AF57.F9E99B3D
Content-Type: application/octet-stream;
	name="runtime.diff"
Content-Transfer-Encoding: base64
Content-Description: runtime.diff
Content-Disposition: attachment;
	filename="runtime.diff"

SW5kZXg6IHZtL3JlZmVyZW5jZS9qYXZhL2xhbmcvUnVudGltZS5qYXZhDQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC92bS9yZWZlcmVuY2UvamF2YS9s
YW5nL1J1bnRpbWUuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjMNCmRpZmYgLXUgLXIx
LjIzIFJ1bnRpbWUuamF2YQ0KLS0tIHZtL3JlZmVyZW5jZS9qYXZhL2xhbmcvUnVudGltZS5qYXZh
CTIxIEp1bCAyMDAzIDAxOjUyOjA4IC0wMDAwCTEuMjMNCisrKyB2bS9yZWZlcmVuY2UvamF2YS9s
YW5nL1J1bnRpbWUuamF2YQkyMCBOb3YgMjAwMyAxMTowODoxNCAtMDAwMA0KQEAgLTE5NCw2ICsx
OTQsMzkgQEANCiAgICAgU2VjdXJpdHlNYW5hZ2VyIHNtID0gc2VjdXJpdHlNYW5hZ2VyOyAvLyBC
ZSB0aHJlYWQtc2FmZSENCiAgICAgaWYgKHNtICE9IG51bGwpDQogICAgICAgc20uY2hlY2tFeGl0
KHN0YXR1cyk7DQorDQorICAgIGlmKHJ1blNodXRkb3duSG9va3MoKSkNCisgICAgICBoYWx0KHN0
YXR1cyk7DQorDQorICAgIHN5bmNocm9uaXplZCAobGlicGF0aCkNCisgICAgICB7DQorICAgICAg
ICBpZiAoc2h1dGRvd25Ib29rcyAhPSBudWxsKQ0KKyAgICAgICAgICB7DQorICAgICAgICAgICAg
c2h1dGRvd25Ib29rcy5yZW1vdmUoVGhyZWFkLmN1cnJlbnRUaHJlYWQoKSk7DQorICAgICAgICAg
IH0NCisgICAgICB9DQorICAgIA0KKyAgICB3aGlsZSAodHJ1ZSkNCisgICAgICB0cnkNCisgICAg
ICAgIHsNCisgICAgICAgICAgZXhpdFNlcXVlbmNlLmpvaW4oKTsNCisgICAgICAgIH0NCisgICAg
ICBjYXRjaCAoSW50ZXJydXB0ZWRFeGNlcHRpb24gZSkNCisgICAgICAgIHsNCisgICAgICAgICAg
Ly8gSWdub3JlLCB3ZSd2ZSBzdXNwZW5kZWQgaW5kZWZpbml0ZWx5IHRvIGxldCBhbGwgc2h1dGRv
d24NCisgICAgICAgICAgLy8gaG9va3MgY29tcGxldGUsIGFuZCB0byBsZXQgYW55IG5vbi16ZXJv
IGV4aXRzIHRocm91Z2gsIGJlY2F1c2UNCisgICAgICAgICAgLy8gdGhpcyBpcyBhIGR1cGxpY2F0
ZSBjYWxsIHRvIGV4aXQoMCkuDQorICAgICAgICB9DQorICB9DQorDQorICAvKioNCisgICAqIE9u
IGZpcnN0IGludm9jYXRpb24sIHJ1biBhbGwgdGhlIHNodXRkb3duIGhvb2tzIGFuZCByZXR1cm4g
dHJ1ZS4NCisgICAqIEFueSBzdWJzZXF1ZW50IGludm9jYXRpb25zIHdpbGwgc2ltcGx5IHJldHVy
biBmYWxzZS4NCisgICAqIA0KKyAgICogQHJldHVybiB3YXMgdGhlIGN1cnJlbnQgdGhyZWFkIHRo
ZSBmaXJzdCBvbmUgdG8gY2FsbCB0aGlzIG1ldGhvZD8NCisgICAqLw0KKyAgcHJpdmF0ZSBib29s
ZWFuIHJ1blNodXRkb3duSG9va3MoKQ0KKyAgew0KICAgICBib29sZWFuIGZpcnN0ID0gZmFsc2U7
DQogICAgIHN5bmNocm9uaXplZCAobGlicGF0aCkgLy8gU3luY2ggb24gbGlicGF0aCwgbm90IHRo
aXMsIHRvIGF2b2lkIGRlYWRsb2NrLg0KICAgICAgIHsNCkBAIC0yNTgsMjkgKzI5MSw3IEBADQog
ICAgICAgICAvLyB0aGlzIHNob3VsZCBiZSBydW4gb24gZXZlcnkgb2JqZWN0Lg0KICAgICAgICAg
cnVuRmluYWxpemF0aW9uKCk7DQogICAgICAgfQ0KLSAgICBlbHNlDQotICAgICAgc3luY2hyb25p
emVkIChsaWJwYXRoKQ0KLSAgICAgICAgew0KLSAgICAgICAgICBpZiAoc2h1dGRvd25Ib29rcyAh
PSBudWxsKQ0KLSAgICAgICAgICAgIHsNCi0gICAgICAgICAgICAgIHNodXRkb3duSG9va3MucmVt
b3ZlKFRocmVhZC5jdXJyZW50VGhyZWFkKCkpOw0KLSAgICAgICAgICAgICAgc3RhdHVzID0gMDsg
Ly8gQ2hhbmdlIHN0YXR1cyB0byBlbnRlciBpbmRlZmluaXRlIHdhaXQuDQotICAgICAgICAgICAg
fQ0KLSAgICAgICAgfQ0KLSAgICANCi0gICAgaWYgKGZpcnN0IHx8IHN0YXR1cyA+IDApDQotICAg
ICAgaGFsdChzdGF0dXMpOw0KLSAgICB3aGlsZSAodHJ1ZSkNCi0gICAgICB0cnkNCi0gICAgICAg
IHsNCi0gICAgICAgICAgZXhpdFNlcXVlbmNlLmpvaW4oKTsNCi0gICAgICAgIH0NCi0gICAgICBj
YXRjaCAoSW50ZXJydXB0ZWRFeGNlcHRpb24gZSkNCi0gICAgICAgIHsNCi0gICAgICAgICAgLy8g
SWdub3JlLCB3ZSd2ZSBzdXNwZW5kZWQgaW5kZWZpbml0ZWx5IHRvIGxldCBhbGwgc2h1dGRvd24N
Ci0gICAgICAgICAgLy8gaG9va3MgY29tcGxldGUsIGFuZCB0byBsZXQgYW55IG5vbi16ZXJvIGV4
aXRzIHRocm91Z2gsIGJlY2F1c2UNCi0gICAgICAgICAgLy8gdGhpcyBpcyBhIGR1cGxpY2F0ZSBj
YWxsIHRvIGV4aXQoMCkuDQotICAgICAgICB9DQorICAgIHJldHVybiBmaXJzdDsNCiAgIH0NCiAN
CiAgIC8qKg0K

------_=_NextPart_001_01C3AF57.F9E99B3D
Content-Type: application/octet-stream;
	name="changelog.diff"
Content-Transfer-Encoding: base64
Content-Description: changelog.diff
Content-Disposition: attachment;
	filename="changelog.diff"

SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNzcGF0
aC9jbGFzc3BhdGgvQ2hhbmdlTG9nLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNjE2DQpkaWZm
IC11IC1yMS4xNjE2IENoYW5nZUxvZw0KLS0tIENoYW5nZUxvZwkxOSBOb3YgMjAwMyAxNzo0MTox
OCAtMDAwMAkxLjE2MTYNCisrKyBDaGFuZ2VMb2cJMjAgTm92IDIwMDMgMTE6MTU6MDkgLTAwMDAN
CkBAIC0xLDMgKzEsMTAgQEANCisyMDAzLTExLTIwICBKZXJvZW4gRnJpanRlcnMgPGplcm9lbkBm
cmlqdGVycy5uZXQ+DQorCSogamF2YS9sYW5nL1RocmVhZC5qYXZhIChzdGFydCk6IFRocm93IEls
bGVnYWxUaHJlYWRTdGF0ZUV4Y2VwdGlvbg0KKwlpbnN0ZWFkIG9mIElsbGVnYWxTdGF0ZUV4Y2Vw
dGlvbi4NCisgICAgICAgICogdm0vcmVmZXJlbmNlL2phdmEvbGFuZy9SdW50aW1lLmphdmEgKGV4
aXQpOiBNb3ZlZCBzaHV0ZG93biBob29rDQorICAgICAgICBwcm9jZXNzaW5nIHRvIG5ldyBtZXRo
b2QuDQorICAgICAgICAocnVuU2h1dGRvd25Ib29rcyk6IE5ldyBtZXRob2QuDQorDQogMjAwMy0x
MS0xOSAgRGFsaWJvciBUb3BpYyA8cm9iaWxhZEBrYWZmZS5vcmc+DQogDQogCSogamF2YS90ZXh0
L0ZpZWxkUG9zaXRpb24uamF2YSAoZXF1YWxzKTogQWRhcHRlZCB0byBoYW5kbGUNCg==

------_=_NextPart_001_01C3AF57.F9E99B3D--



From MAILER-DAEMON Thu Nov 20 09:30:51 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMppa-0007ih-Mw
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 09:30:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMppY-0007hr-2f
	for classpath@gnu.org; Thu, 20 Nov 2003 09:30:48 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMpp0-0007be-BH
	for classpath@gnu.org; Thu, 20 Nov 2003 09:30:45 -0500
Received: from [32.97.182.104] (helo=e4.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AMpoz-0007am-En
	for classpath@gnu.org; Thu, 20 Nov 2003 09:30:13 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e4.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id hAKDShXA781156
	for <classpath@gnu.org>; Thu, 20 Nov 2003 08:28:43 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hAKDSfUh090592
	for <classpath@gnu.org>; Thu, 20 Nov 2003 08:28:41 -0500
To: classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OFFCFFE44A.D6EAEEF7-ON85256DE4.0049161F-85256DE4.0049EE42@us.ibm.com>
Date: Thu, 20 Nov 2003 08:28:40 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/20/2003 08:28:42,
	Serialize complete at 11/20/2003 08:28:42
Content-Type: multipart/alternative;
	boundary="=_alternative 0049AC1885256DE4_="
Subject: eclipse 3.0M4 and java.nio
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 14:30:49 -0000

This is a multipart message in MIME format.
--=_alternative 0049AC1885256DE4_=
Content-Type: text/plain; charset="US-ASCII"

Hi,

        I tried to run eclipse 3.0M4 on Jikes RVM + classpath CVS head 
earlier this week.  It died almost immediately because 
java.nio.channels.FileChannelImpl.tryLock isn't implemented.

        Mark had mentioned a couple weeks back that he had run eclipse 
3.0M4 on gij.  Is this a portion of the library where classpath is lagging 
behind gcj's libraries?

thanks,

--dave
--=_alternative 0049AC1885256DE4_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Hi,</font>
<br>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; I
tried to run eclipse 3.0M4 on Jikes RVM + classpath CVS head earlier this
week. &nbsp;It died almost immediately because java.nio.channels.FileChannelImpl.tryLock
isn't implemented.</font>
<br>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; Mark
had mentioned a couple weeks back that he had run eclipse 3.0M4 on gij.
&nbsp;Is this a portion of the library where classpath is lagging behind
gcj's libraries?</font>
<br>
<br><font size=2 face="sans-serif">thanks,</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 0049AC1885256DE4_=--



From MAILER-DAEMON Thu Nov 20 10:11:20 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMqSm-0008Iz-6T
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 10:11:20 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMqSh-0008HY-FN
	for classpath@gnu.org; Thu, 20 Nov 2003 10:11:15 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMqPO-0006ee-NZ
	for classpath@gnu.org; Thu, 20 Nov 2003 10:08:21 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMqAF-0000R6-Nv
	for classpath@gnu.org; Thu, 20 Nov 2003 09:52:11 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMpC5-0003tP-00; Thu, 20 Nov 2003 14:50:01 +0100
From: Mark Wielaard <mark@klomp.org>
To: David P Grove <groved@us.ibm.com>
In-Reply-To: <OFFCFFE44A.D6EAEEF7-ON85256DE4.0049161F-85256DE4.0049EE42@us.ibm.com>
References: <OFFCFFE44A.D6EAEEF7-ON85256DE4.0049161F-85256DE4.0049EE42@us.ibm.com>
Content-Type: text/plain
Message-Id: <1069336229.2860.261.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 20 Nov 2003 14:50:29 +0100
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: eclipse 3.0M4 and java.nio
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 15:11:16 -0000

Hi,

On Thu, 2003-11-20 at 14:28, David P Grove wrote:
>         I tried to run eclipse 3.0M4 on Jikes RVM + classpath CVS head
> earlier this week.  It died almost immediately because
> java.nio.channels.FileChannelImpl.tryLock isn't implemented.
> 
>         Mark had mentioned a couple weeks back that he had run eclipse
> 3.0M4 on gij.  Is this a portion of the library where classpath is
> lagging behind gcj's libraries?

No file locking is not implemented in either library yet.
(Patches welcome!)

I cheated. When you define the system property
org.eclipse.core.runtime.ignoreLockFile=true
The Eclipse 3.0 startup code doesn't try to get a real lock.

Besides that issue I only remember two things missing from our library
regexp compile on a String and a unsupported format symbol
in java.text. But both were not really fatal, just annoying.

Hope to hear a success story about JRVM and Eclipse 3.0 soon!
(Kaffe is also able to run it now with a couple of small patches.)

Cheers,

Mark




From MAILER-DAEMON Thu Nov 20 12:34:59 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMshm-0000a2-IZ
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 12:34:58 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMshe-0000Vf-Mw
	for classpath@gnu.org; Thu, 20 Nov 2003 12:34:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMsh0-0000Eb-F0
	for classpath@gnu.org; Thu, 20 Nov 2003 12:34:41 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMsh0-0000EF-2p
	for classpath@gnu.org; Thu, 20 Nov 2003 12:34:10 -0500
Received: from [192.168.1.33] (unknown [217.8.220.53])
	by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id 13F8F64702; Thu, 20 Nov 2003 17:32:42 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: graydon hoare <graydon@redhat.com>
Date: Thu, 20 Nov 2003 17:31:35 +0100
Message-Id: <20031120163135.23024@smtp.mail.ch.easynet.net>
In-Reply-To: <873cckksas.fsf@dub.venge.net>
References: <873cckksas.fsf@dub.venge.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, java-patches@gcc.gnu.org
Subject: Re: [PATCH] text layout implementation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 17:34:54 -0000

graydon hoare <graydon@redhat.com> wrote on Wed, 19 Nov 2003 15:38:19 -0500:

>Sascha Brawer <brawer@dandelis.ch> writes:
>
>> Also, does the proposed implementation work if there are changes in any
>> attributes other than font, such as TextAttribute.UNDERLINE? It seems
>> that all these attributes are lost by passing Strings.
>
>well, the CharacterIteratorProxy I've implemented (modified patch
>below) doesn't do the whole AttributedCharacterIterator interface, but
>there's no method on Font to create a glyph vector with an
>AttributedCharacterIterator anyways. I think we'd have to interpret
>extra attributes as calls to deriveFont or something, no?

Hm, it's really tricky... AttributedCharacterIterator is actually a
subinterface of CharacterIterator, so Font.createGlyphVector could handle
some of the attributes. But presumably only those which manifest in glyph
selection and placement -- probably BIDI_EMBEDDING, CHAR_REPLACEMENT,
JUSTIFICATION, NUMERIC_SHAPING, RUN_DIRECTION, SUPERSCRIPT. I guess one
would want to pass them to Font.createGlyphVector, but I'm not really sure.

FAMILY, FONT, POSTURE, SIZE, TRANSFORM, WEIGHT, WIDTH: Because all
elements of a GlyphVector belong to the same Font, these probably cannot
be handled by Font.creteGlyphVector. Handle them in TextLayout?

BACKGROUND, FOREGROUND, SWAP_COLORS; INPUT_METHOD_UNDERLINE,
STRIKETHROUGH, UNDERLINE: These are tricky. Should this information be
part of the GlyphVector?

INPUT_METHOD_HIGHLIGHT: There's a method
java.awt.Toolkit.mapInputMethodHighlight for mapping the value to a
visual TextAttribute.

Well, here's an observation that is easier to discuss: The first part of

  (fnt != null && fnt instanceof Font)

is redundant.

Best,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Thu Nov 20 13:48:20 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMtql-00039K-Rl
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 13:48:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMtqj-00038T-7G
	for classpath@gnu.org; Thu, 20 Nov 2003 13:48:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMtqD-000357-Gf
	for classpath@gnu.org; Thu, 20 Nov 2003 13:48:16 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMtqB-00034h-BW
	for classpath@gnu.org; Thu, 20 Nov 2003 13:47:43 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id KAA09194;
	Thu, 20 Nov 2003 10:46:10 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 8340F4F8243; Thu, 20 Nov 2003 10:36:47 -0700 (MST)
To: Mark Wielaard <mark@klomp.org>
References: <OFFCFFE44A.D6EAEEF7-ON85256DE4.0049161F-85256DE4.0049EE42@us.ibm.com>
	<1069336229.2860.261.camel@elsschot.wildebeest.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: PIZZA!!
Date: 20 Nov 2003 10:36:47 -0700
In-Reply-To: <1069336229.2860.261.camel@elsschot.wildebeest.org>
Message-ID: <87y8ub0wnk.fsf@fleche.redhat.com>
Lines: 9
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: eclipse 3.0M4 and java.nio
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 18:48:17 -0000

Mark> Besides that issue I only remember two things missing from our library
Mark> regexp compile on a String and a unsupported format symbol
Mark> in java.text. But both were not really fatal, just annoying.

I'm submitting bug reports for these to the gcc bugzilla, so that I
can keep track of what is needed to run eclipse 3.0.  Can you tell me
what format symbol is missing from java.text?

Tom



From MAILER-DAEMON Thu Nov 20 14:03:00 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMu4x-000786-MO
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 14:02:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMu4u-00075t-60
	for classpath@gnu.org; Thu, 20 Nov 2003 14:02:56 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMu4N-0006vD-OP
	for classpath@gnu.org; Thu, 20 Nov 2003 14:02:54 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMu4M-0006ug-W6
	for classpath@gnu.org; Thu, 20 Nov 2003 14:02:23 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id LAA14327;
	Thu, 20 Nov 2003 11:00:54 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 655764F8243; Thu, 20 Nov 2003 10:51:31 -0700 (MST)
To: =?iso-8859-15?q?Ingo_Pr=F6tel?= <proetel@aicas.com>
References: <878ymexym1.fsf@fleche.redhat.com> <3FBBAD2D.8070000@aicas.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I'm having a MID-WEEK CRISIS!
Date: 20 Nov 2003 10:51:31 -0700
In-Reply-To: <3FBBAD2D.8070000@aicas.com>
Message-ID: <87oev70vz0.fsf@fleche.redhat.com>
Lines: 23
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 19:02:57 -0000

>>>>> "Ingo" == Ingo Prötel <proetel@aicas.com> writes:

Ingo> have we decided to have tabs in the source code ?

I've been assuming yes, but only because Emacs defaults
indent-tabs-mode to t.

Ingo> It seems that my tabs are olny half the size of the tabs that jalopy
Ingo> assumes.

Not sure what you mean here... with GNU.xml, jalopy should assume that
one tab is equivalent to 8 spaces.  Is this how you have your editor
set up?  If not, you'll probably run into problems with already
existing Classpath code, which makes the same assumption.

If jalopy+GNU.xml gives different results from this in some case, tell
me what file and I'll investigate.

Ingo> Also note the closing curly braces on the wrong line.

Yeah :-(.  What file was that?

Tom



From MAILER-DAEMON Thu Nov 20 14:36:46 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMube-0007Re-Cx
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 14:36:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMuba-0007Q4-Rw
	for classpath@gnu.org; Thu, 20 Nov 2003 14:36:42 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMub0-00074H-QF
	for classpath@gnu.org; Thu, 20 Nov 2003 14:36:37 -0500
Received: from [32.97.182.104] (helo=e4.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AMub0-000748-9x
	for classpath@gnu.org; Thu, 20 Nov 2003 14:36:06 -0500
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e4.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id hAKIYeXA774570
	for <classpath@gnu.org>; Thu, 20 Nov 2003 13:34:40 -0500
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.9/NCO/VER6.6) with ESMTP id
	hAKIYdUh117326
	for <classpath@gnu.org>; Thu, 20 Nov 2003 13:34:39 -0500
In-Reply-To: <87oev70vz0.fsf@fleche.redhat.com>
To: Classpath Discussion Mailing List <classpath@gnu.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
Message-ID: <OFD552F087.1A7D268C-ON85256DE4.00642B79-85256DE4.0065F0EB@us.ibm.com>
Date: Thu, 20 Nov 2003 13:34:37 -0500
X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 6.5|September 18,
	2003) at 11/20/2003 13:34:39,
	Serialize complete at 11/20/2003 13:34:39
Content-Type: multipart/alternative;
	boundary="=_alternative 0065C0B685256DE4_="
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 19:36:44 -0000

This is a multipart message in MIME format.
--=_alternative 0065C0B685256DE4_=
Content-Type: text/plain; charset="US-ASCII"

For what it's worth, we (Jikes RVM) have been getting complaints from 
users who are trying to browse Jikes RVM source code using Eclipse that it 
is somewhat annoying to have tabs in the source code.  If a tab represents 
8 spaces, but your spaces per indentation level is something else (eg 2 or 
4) then the IDE gets unhappy and starts doing wierd stuff.  It also 
creates a minor annoyance when you get patches from users that created 
them in an ide where spaces per tab is often set equal to indent level.

We've decided to give up on tabs in all of Jikes RVM's source code as the 
slight increase in file size doesn't seem to be worth the annoyance.

Just a random comment; the minor space gains from using tabs may not be 
worth the trouble. YMMV.

--dave
--=_alternative 0065C0B685256DE4_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">For what it's worth, we (Jikes RVM)
have been getting complaints from users who are trying to browse Jikes
RVM source code using Eclipse that it is somewhat annoying to have tabs
in the source code. &nbsp;If a tab represents 8 spaces, but your spaces
per indentation level is something else (eg 2 or 4) then the IDE gets unhappy
and starts doing wierd stuff. &nbsp;It also creates a minor annoyance when
you get patches from users that created them in an ide where spaces per
tab is often set equal to indent level.</font>
<br>
<br><font size=2 face="sans-serif">We've decided to give up on tabs in
all of Jikes RVM's source code as the slight increase in file size doesn't
seem to be worth the annoyance.</font>
<br>
<br><font size=2 face="sans-serif">Just a random comment; the minor space
gains from using tabs may not be worth the trouble. YMMV.</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 0065C0B685256DE4_=--



From MAILER-DAEMON Thu Nov 20 14:43:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMuhx-0001vE-Kg
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 14:43:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMudk-0008WU-Na
	for classpath@gnu.org; Thu, 20 Nov 2003 14:38:56 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMudE-0008HC-6r
	for classpath@gnu.org; Thu, 20 Nov 2003 14:38:55 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMuZ8-0005kp-JI
	for classpath@gnu.org; Thu, 20 Nov 2003 14:34:10 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AMtbC-0004bF-00; Thu, 20 Nov 2003 19:32:14 +0100
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C688@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC04C688@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-os7ox9z6SBVviMfOSzyL"
Message-Id: <1069353162.2855.478.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 20 Nov 2003 19:32:42 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Suggested Runtime change and small Thread fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 19:43:15 -0000


--=-os7ox9z6SBVviMfOSzyL
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-20 at 12:17, Jeroen Frijters wrote:
> I would like to move the code to run the shutdown hooks from exit() to a
> new method. This allows me to also run the shutdown hooks if the process
> termination is triggered by code outside of Java (in my .NET JVM). I
> can't see it hurting any other scenarios.
>=20
> Any objections or comments?

If this helps you then I see no objections.
But we really should split Runtime into these kind of VM-independent
methods and a VMRuntime that does the VM-dependent (memory,
gc/finalizers, exec and halt) stuff.

> Also fixed Thread.start() to throw IllegalThreadStateException instead
> of IllegalStateException.

Funny the documentation was already correct.

BTW. Don't forget to update copyright years of files you change.

Cheers,

Mark

--=-os7ox9z6SBVviMfOSzyL
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vQjKxVhZCJWr9QwRAi6oAJ9dgsEOeh3pBjZ0Y7oAxgW0tDZGxQCfYEfq
7K4vp4OPnZiDBETVCj6kMPc=
=PPFn
-----END PGP SIGNATURE-----

--=-os7ox9z6SBVviMfOSzyL--




From MAILER-DAEMON Thu Nov 20 15:12:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMv9t-0005RR-93
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 15:12:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMv9q-0005QP-Hw
	for classpath@gnu.org; Thu, 20 Nov 2003 15:12:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMv9E-0005D9-1o
	for classpath@gnu.org; Thu, 20 Nov 2003 15:11:59 -0500
Received: from [17.254.13.23] (helo=mail-out4.apple.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMv9D-0005CW-Go
	for classpath@gnu.org; Thu, 20 Nov 2003 15:11:27 -0500
Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225])
	by mail-out4.apple.com (8.12.10/8.12.9) with ESMTP id hAKJA1nc023367
	for <classpath@gnu.org>; Thu, 20 Nov 2003 11:10:01 -0800 (PST)
Received: from scv1.apple.com (scv1.apple.com) by mailgate1.apple.com
	(Content Technologies SMTPRS 4.2.1) with ESMTP id
	<T66053d4798118064e1818@mailgate1.apple.com>; 
	Thu, 20 Nov 2003 11:09:26 -0800
Received: from bothner.com (vpn-scv-x2-168.apple.com [17.219.193.168])
	by scv1.apple.com (8.12.9/8.12.9) with ESMTP id hAKJ9Sww021001;
	Thu, 20 Nov 2003 11:09:28 -0800 (PST)
Message-ID: <3FBD1188.7020100@bothner.com>
Date: Thu, 20 Nov 2003 11:10:00 -0800
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.5b) Gecko/20030827
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: David P Grove <groved@us.ibm.com>
References: <OFD552F087.1A7D268C-ON85256DE4.00642B79-85256DE4.0065F0EB@us.ibm.com>
In-Reply-To: <OFD552F087.1A7D268C-ON85256DE4.00642B79-85256DE4.0065F0EB@us.ibm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 20:12:07 -0000

David P Grove wrote:

>  It also creates a minor annoyance when you get patches from users that 
> created them in an ide where spaces per tab is often set equal to indent 
> level.

This seems to be common in the Windows world.  It has the advantage
that you can adjust indentation width according to personal preference
by changing a display parameter (the tab width) without changing any
source files.

Unfortunately, it's incompatible with the Unix tab-is-8-column
"standard".
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/





From MAILER-DAEMON Thu Nov 20 15:57:00 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AMvrH-0001RW-KA
	for mharc-classpath@gnu.org; Thu, 20 Nov 2003 15:56:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AMvrD-0001P9-RS
	for classpath@gnu.org; Thu, 20 Nov 2003 15:56:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AMvqe-00015j-Ba
	for classpath@gnu.org; Thu, 20 Nov 2003 15:56:51 -0500
Received: from [209.100.227.1] (helo=e4500.ripco.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AMvo4-0008QQ-S2
	for classpath@gnu.org; Thu, 20 Nov 2003 15:53:40 -0500
Received: from shell2.ripco.com (root@shell2.ripco.com [209.100.225.144])
	by e4500.ripco.com (8.12.10/8.12.9) with ESMTP id hAKJpctx001644;
	Thu, 20 Nov 2003 13:51:38 -0600 (CST)
Received: from shell2.ripco.com (arenn@localhost [127.0.0.1])
	by shell2.ripco.com (8.12.9/8.12.9) with ESMTP id hAKJq9jE010717;
	Thu, 20 Nov 2003 13:52:09 -0600 (CST)
Received: (from arenn@localhost)
	by shell2.ripco.com (8.12.9/8.12.9/Submit) id hAKJq63A010716;
	Thu, 20 Nov 2003 13:52:06 -0600 (CST)
Date: Thu, 20 Nov 2003 13:52:06 -0600
From: "Aaron M. Renn" <arenn@urbanophile.com>
To: David P Grove <groved@us.ibm.com>
Message-ID: <20031120135206.A10670@urbanophile.com>
Mail-Followup-To: "Aaron M. Renn" <arenn@urbanophile.com>,
	David P Grove <groved@us.ibm.com>,
	Classpath Discussion Mailing List <classpath@gnu.org>
References: <87oev70vz0.fsf@fleche.redhat.com>
	<OFD552F087.1A7D268C-ON85256DE4.00642B79-85256DE4.0065F0EB@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <OFD552F087.1A7D268C-ON85256DE4.00642B79-85256DE4.0065F0EB@us.ibm.com>;
	from groved@us.ibm.com on Thu, Nov 20, 2003 at 01:34:37PM -0500
Organization: GNU's Not Unix!
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2003 20:56:58 -0000

David P Grove (groved@us.ibm.com) wrote:
> For what it's worth, we (Jikes RVM) have been getting complaints from 
> users who are trying to browse Jikes RVM source code using Eclipse that it 
> is somewhat annoying to have tabs in the source code.  If a tab represents 
> 8 spaces, but your spaces per indentation level is something else (eg 2 or 
> 4) then the IDE gets unhappy and starts doing wierd stuff.  It also 
> creates a minor annoyance when you get patches from users that created 
> them in an ide where spaces per tab is often set equal to indent level.
> 
> We've decided to give up on tabs in all of Jikes RVM's source code as the 
> slight increase in file size doesn't seem to be worth the annoyance.

I've always thought that using tabs for formatting in source code was
a Bad Thing.  In fact, replacing tabs with spaces seems to be conventional
wisdom most of the places I've worked.  So count me as a supporter
of nuking tabs.

-- 
Aaron M. Renn (arenn@urbanophile.com) http://www.urbanophile.com/arenn/




From MAILER-DAEMON Fri Nov 21 04:35:00 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AN7gq-00007A-NA
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 04:35:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AN7go-000065-BY
	for classpath@gnu.org; Fri, 21 Nov 2003 04:34:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AN7gH-0008J2-Ez
	for classpath@gnu.org; Fri, 21 Nov 2003 04:34:56 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AN7gG-0008I3-DR
	for classpath@gnu.org; Fri, 21 Nov 2003 04:34:24 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 21 Nov 2003 09:32:46 +0100
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C68B@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Suggested Runtime change and small Thread fix
Thread-Index: AcOvlLFe9T+7+wArQwy8qY4z4C2uUgAcuzyg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Mark Wielaard" <mark@klomp.org>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: Suggested Runtime change and small Thread fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 09:34:59 -0000

Mark Wielaard wrote:
> On Thu, 2003-11-20 at 12:17, Jeroen Frijters wrote:
> > I would like to move the code to run the shutdown hooks=20
> from exit() to a
> > new method. This allows me to also run the shutdown hooks=20
> if the process
> > termination is triggered by code outside of Java (in my .NET JVM). I
> > can't see it hurting any other scenarios.
> >=20
> > Any objections or comments?
>=20
> If this helps you then I see no objections.

OK. I checked them in.

> But we really should split Runtime into these kind of VM-independent
> methods and a VMRuntime that does the VM-dependent (memory,
> gc/finalizers, exec and halt) stuff.

Agreed, but that is (mostly) orthogonal to this patch. I'll try to do it
this weekend, it's been on my TODO list for a long time already ;-)

> > Also fixed Thread.start() to throw=20
> IllegalThreadStateException instead
> > of IllegalStateException.
>=20
> Funny the documentation was already correct.

It is easy to overlook the difference between the two class names. It
made me think that it would be nice to have a static analysis tool that
checks exceptions thrown vs caught. Such a tool would probably (as
usual) suffer from lots of false positives, but it might still be
helpful.

> BTW. Don't forget to update copyright years of files you change.

Thanks, I do tend to forget that.

BTW, I don't want to post a me too in the tab vs spaces thread, but
count me firmly in spaces camp. Tabs are a pain to manage.

Regards,
Jeroen



From MAILER-DAEMON Fri Nov 21 11:59:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANEdO-0008BK-8j
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 11:59:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANEbh-0007ur-O5
	for classpath@gnu.org; Fri, 21 Nov 2003 11:58:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANEaz-0007im-JI
	for classpath@gnu.org; Fri, 21 Nov 2003 11:57:56 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANE67-00071J-FT
	for classpath@gnu.org; Fri, 21 Nov 2003 11:25:31 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AND8f-00039C-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 16:24:05 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AND8e-000390-00; Fri, 21 Nov 2003 16:24:04 +0100
Message-ID: <3FBE2E13.5070201@kaffe.org>
Date: Fri, 21 Nov 2003 16:24:03 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>
Content-Type: multipart/mixed; boundary="------------030009090705010102030407"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: small bug report for java.io.FileInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 16:59:51 -0000

This is a multi-part message in MIME format.
--------------030009090705010102030407
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

the constructors in FileInputstream don't throw a FileNotFoundException 
when the File to open as an InputStream is actually a directory, as they 
should do. I've attached a test case that demonstrates the bug.

While there is a patch in kaffe for this bug, it existed in a previous 
form in the old version of FileInputStream.java before it was replaced 
by GNU Classpath's version[1], so I'd prefer to see a patch that can not 
be seen as derived from GPL'd code.

I've attached a simple test case.

cheers,
dalibor topic

[1] Guilhem imported the file from Classpath, and fixed the bug. The 
code is similar (there are not that many ways to check if a file is a 
directory and throw an exception based on that) to the code from the 
earlier, GPLd version, checked in by Jim Pick and written by Patrick 
Tullman.

--------------030009090705010102030407
Content-Type: text/x-java;
 name="fistest.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="fistest.java"

import java.io.*;

public class fistest {
	private static void construct(String name) {
		try {
			FileInputStream fis = new FileInputStream(name);
			System.out.println(fis);
		}
		catch (Exception e) {
			e.printStackTrace();
		}
	}

	public static void main(String [] args) {
		String [] test = { "/tmp" };

		for (int i = 0; i < test.length; i++) {
			construct(test[i]);
		}
	}
}


--------------030009090705010102030407--




From MAILER-DAEMON Fri Nov 21 12:18:43 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANEvb-0005Ob-2q
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 12:18:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANEvV-0005MU-Ru
	for classpath@gnu.org; Fri, 21 Nov 2003 12:18:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANEuy-0005Ax-IF
	for classpath@gnu.org; Fri, 21 Nov 2003 12:18:35 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANEt0-0004Ol-R7
	for classpath@gnu.org; Fri, 21 Nov 2003 12:16:02 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANDv5-0007UH-00; Fri, 21 Nov 2003 17:14:07 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org, kaffe@kaffe.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-RxVt1O405kLeLka00L/C"
Message-Id: <1069431275.2861.580.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 21 Nov 2003 17:14:35 +0100
Cc: java-patches@gcc.gnu.org
Subject: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 17:18:40 -0000


--=-RxVt1O405kLeLka00L/C
Content-Type: multipart/mixed; boundary="=-aHPNm/qwu5tf02V0N+4g"


--=-aHPNm/qwu5tf02V0N+4g
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

Since I am not a GregorianCalendar expert I was hoping that someone
could review the following patch which I have in my tree from Ito
Kazumitsu. He and I wrote a couple of mauve test cases which are fixed
by this and I see no new failures. But people didn't seem to be
completely comfortable with it back in Augustus/September. It would be
nice if we could create even more test cases to make sure that nothing
else breaks and to have a ChangeLog entry for this patch (Ito?). Don't
really have have time to learn about Calendars so I am just re-posting
this patch in the hope that someone can review it.

Thanks,

Mark

--=-aHPNm/qwu5tf02V0N+4g
Content-Disposition: inline; filename=GregorianCalendar.patch
Content-Type: text/x-patch; name=GregorianCalendar.patch; charset=ISO-8859-1
Content-Transfer-Encoding: base64

SW5kZXg6IGphdmEvdXRpbC9HcmVnb3JpYW5DYWxlbmRhci5qYXZhDQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
ZmlsZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC9qYXZhL3V0aWwvR3JlZ29yaWFuQ2Fs
ZW5kYXIuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjANCmRpZmYgLXUgLXIxLjIwIEdy
ZWdvcmlhbkNhbGVuZGFyLmphdmENCi0tLSBqYXZhL3V0aWwvR3JlZ29yaWFuQ2FsZW5kYXIuamF2
YQkxMiBBdWcgMjAwMyAxMzo0MToyNyAtMDAwMAkxLjIwDQorKysgamF2YS91dGlsL0dyZWdvcmlh
bkNhbGVuZGFyLmphdmEJMjEgTm92IDIwMDMgMTY6MTE6NTYgLTAwMDANCkBAIC0xLDUgKzEsNSBA
QA0KIC8qIGphdmEudXRpbC5HcmVnb3JpYW5DYWxlbmRhcg0KLSAgIENvcHlyaWdodCAoQykgMTk5
OCwgMTk5OSwgMjAwMSwgMjAwMiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4NCisgICBD
b3B5cmlnaHQgKEMpIDE5OTgsIDE5OTksIDIwMDEsIDIwMDIsIDIwMDMgRnJlZSBTb2Z0d2FyZSBG
b3VuZGF0aW9uLCBJbmMuDQogDQogVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIENsYXNzcGF0aC4N
CiANCkBAIC0yNjQsOCArMjY0LDEwIEBADQogCS8vDQogCS8vIFRoZSBhZGRpdGlvbmFsIGxlYXAg
eWVhciBmYWN0b3IgYWNjb3VudHMgZm9yIHRoZSBmYWN0IHRoYXQNCiAJLy8gYSBsZWFwIGRheSBp
cyBub3Qgc2VlbiBvbiBKYW4gMSBvZiB0aGUgbGVhcCB5ZWFyLg0KKwkvLyBBbmQgb24gYW5kIGFm
dGVyIHRoZSBsZWFwIGRheSwgdGhlIGxlYXAgZGF5IGhhcyBhbHJlYWR5IGJlZW4NCisJLy8gaW5j
bHVkZWQgaW4gZGF5T2ZZZWFyLiANCiAJaW50IGdyZWdPZmZzZXQgPSAoeWVhciAvIDQwMCkgLSAo
eWVhciAvIDEwMCkgKyAyOw0KLQlpZiAoaXNMZWFwWWVhciAoeWVhciwgdHJ1ZSkgJiYgZGF5T2ZZ
ZWFyIDwgMzEgKyAyOSkNCisJaWYgKGlzTGVhcFllYXIgKHllYXIsIHRydWUpKQ0KIAkgIC0tZ3Jl
Z09mZnNldDsNCiAJdGltZSArPSBncmVnT2Zmc2V0ICogKDI0ICogNjAgKiA2MCAqIDEwMDBMKTsN
CiAgICAgICB9DQpAQCAtNjA0LDEyICs2MDYsMTIgQEANCiAJY2FsY3VsYXRlRGF5KCsrZGF5LCBn
cmVnb3JpYW4pOw0KICAgICAgIH0NCiANCi0gICAgZmllbGRzW0RBWV9PRl9XRUVLX0lOX01PTlRI
XSA9IChmaWVsZHNbREFZX09GX01PTlRIXSArIDYpIC8gNzsNCisgICAgZmllbGRzW0RBWV9PRl9X
RUVLX0lOX01PTlRIXSA9IChmaWVsZHNbREFZX09GX01PTlRIXSArIDEyKSAvIDc7DQogDQogICAg
IC8vIHdoaWNoIGRheSBvZiB0aGUgd2VlayBhcmUgd2UgKDAuLjYpLCByZWxhdGl2ZSB0byBnZXRG
aXJzdERheU9mV2Vlaw0KICAgICBpbnQgcmVsYXRpdmVXZWVrZGF5ID0gKDcgKyBmaWVsZHNbREFZ
X09GX1dFRUtdIC0gZ2V0Rmlyc3REYXlPZldlZWsoKSkgJSA3Ow0KIA0KLSAgICBmaWVsZHNbV0VF
S19PRl9NT05USF0gPSAoZmllbGRzW0RBWV9PRl9NT05USF0gLSByZWxhdGl2ZVdlZWtkYXkgKyA2
KSAvIDc7DQorICAgIGZpZWxkc1tXRUVLX09GX01PTlRIXSA9IChmaWVsZHNbREFZX09GX01PTlRI
XSAtIHJlbGF0aXZlV2Vla2RheSArIDEyKSAvIDc7DQogDQogICAgIGludCB3ZWVrT2ZZZWFyID0g
KGZpZWxkc1tEQVlfT0ZfWUVBUl0gLSByZWxhdGl2ZVdlZWtkYXkgKyA2KSAvIDc7DQogDQo=

--=-aHPNm/qwu5tf02V0N+4g--

--=-RxVt1O405kLeLka00L/C
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vjnrxVhZCJWr9QwRAm4xAJsFKlDVCY2ll0+4RlZ6PxZpE4gwUwCghVI+
5ijwKfBR+FohtnvZMe4ldts=
=gX1R
-----END PGP SIGNATURE-----

--=-RxVt1O405kLeLka00L/C--




From MAILER-DAEMON Fri Nov 21 13:19:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANFs5-0004dT-9p
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 13:19:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANFs2-0004cH-Ao
	for classpath@gnu.org; Fri, 21 Nov 2003 13:19:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANFrR-0004TU-M1
	for classpath@gnu.org; Fri, 21 Nov 2003 13:19:00 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANFrR-0004TP-AA
	for classpath@gnu.org; Fri, 21 Nov 2003 13:18:29 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANEtz-00036A-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 18:17:03 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANEty-00035y-00; Fri, 21 Nov 2003 18:17:02 +0100
Message-ID: <3FBE488E.9010307@kaffe.org>
Date: Fri, 21 Nov 2003 18:17:02 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>
Content-Type: multipart/mixed; boundary="------------050906080105070003000305"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: [PATCH] DatagramSocket bind (null) fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 18:19:07 -0000

This is a multi-part message in MIME format.
--------------050906080105070003000305
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

attached is a small patch from Guilhem hat fixes the behaviour of 
DatagramSocket.bind(null) to match the API spec in 1.4.2, i.e. pick an 
ephemeral port and a local address to bind to.


2003-11-21  Guilhem Lavaux <guilhem@kaffe.org>

         * libraries/javalib/java/net/DatagramSocket.java:
         (bind) When address is null, it should bind to an available
         port.

--------------050906080105070003000305
Content-Type: text/plain;
 name="cpath-guilhem-datagram-socket.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-guilhem-datagram-socket.diff"

--- /var/tmp/PROJECTS/classpath//./java/net/DatagramSocket.java	Mon Sep 22 16:56:08 2003
+++ /tmp/topic/kaffe/libraries/javalib/java/net/DatagramSocket.java	Mon Nov  3 18:24:43 2003
@@ -573,7 +579,8 @@
   /**
    * Binds the socket to the given socket address.
    *
-   * @param address The socket address to bind to.
+   * @param address The socket address to bind to. If address is null, bind
+   * will take an ephemeral port and a valid local address to bind the socket.
    *
    * @exception SocketException If an error occurs.
    * @exception SecurityException If a security manager exists and
@@ -585,6 +592,9 @@
   public void bind (SocketAddress address)
     throws SocketException
   {
+    if (address == null)
+      address = new InetSocketAddress (InetAddress.ANY_IF, 0);
+    
     if (! (address instanceof InetSocketAddress))
       throw new IllegalArgumentException ();
 

--------------050906080105070003000305--




From MAILER-DAEMON Fri Nov 21 14:00:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANGVj-0008Ae-SI
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 14:00:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANGQN-0007Mm-Ns
	for classpath@gnu.org; Fri, 21 Nov 2003 13:54:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANGOR-0005tE-48
	for classpath@gnu.org; Fri, 21 Nov 2003 13:53:06 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANGLv-0002f6-3V
	for classpath@gnu.org; Fri, 21 Nov 2003 13:49:59 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANFOT-0007vK-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 18:48:33 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANFOS-0007vA-00; Fri, 21 Nov 2003 18:48:32 +0100
Message-ID: <3FBE4FF0.2040805@kaffe.org>
Date: Fri, 21 Nov 2003 18:48:32 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>
References: <3FBE488E.9010307@kaffe.org>
In-Reply-To: <3FBE488E.9010307@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: Re: [PATCH] DatagramSocket bind (null) fix
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 19:00:06 -0000

Dalibor Topic wrote:
> Hi all,
> 
> attached is a small patch from Guilhem hat fixes the behaviour of 
> DatagramSocket.bind(null) to match the API spec in 1.4.2, i.e. pick an 
> ephemeral port and a local address to bind to.
> 
> 
> 2003-11-21  Guilhem Lavaux <guilhem@kaffe.org>
> 
>         * libraries/javalib/java/net/DatagramSocket.java:
>         (bind) When address is null, it should bind to an available
>         port.

o.k., i spotted it first. the changeLog entry should be:


2003-11-21  Guilhem Lavaux <guilhem@kaffe.org>

         * libraries/javalib/java/net/DatagramSocket.java (bind):
         When address is null, it should bind to an available
         port.

cheers,
dalibor topic




From MAILER-DAEMON Fri Nov 21 14:10:59 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANGgE-0004Zu-Ok
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 14:10:58 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANGg7-0004Wj-Rx
	for classpath@gnu.org; Fri, 21 Nov 2003 14:10:51 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANGZn-0001lp-LI
	for classpath@gnu.org; Fri, 21 Nov 2003 14:04:50 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANGXA-0000NM-VV
	for classpath@gnu.org; Fri, 21 Nov 2003 14:01:37 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANFZj-00040l-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 19:00:11 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANFZi-00040N-00; Fri, 21 Nov 2003 19:00:10 +0100
Message-ID: <3FBE52AA.5020705@kaffe.org>
Date: Fri, 21 Nov 2003 19:00:10 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>, Guilhem Lavaux <guilhem@kaffe.org>
Content-Type: multipart/mixed; boundary="------------080009050509080502090607"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: [PATCH] DatagramSocket constrcutor fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 19:10:53 -0000

This is a multi-part message in MIME format.
--------------080009050509080502090607
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

attached is another patch from Guilhem that fixes DatagramSocket 
constructor behaviour & comments. It resulted as a fix to a bug report 
to the kaffe mailing list from Everton da Silva Marques [1]. Please also 
take a look at the discussion in the thread about other approaches to 
fix the issue, and why they weren't picked.


2003-11-21  Guilhem Lavaux <guilhem@kaffe.org>

         * libraries/javalib/java/net/DatagramSocket.java
	((DatagramSocket(SocketAddress)): Fixed comment to match
	method. If address is null leave socket unbound.
	(DatagramSocket(int, InetAddress)): Rewritten to delegate
	to ((DatagramSocket(SocketAddress)) in order to pick up
	the fix. Moved checking code into
	((DatagramSocket(SocketAddress)).


cheers,
dalibor topic

[1] http://www.mail-archive.com/kaffe@kaffe.org/msg03573.html

--------------080009050509080502090607
Content-Type: text/plain; name="cpath-guilhem-datagram-socket-constructor.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="cpath-guilhem-datagram-socket-constructor.diff"

--- /var/tmp/PROJECTS/classpath//./java/net/DatagramSocket.java	Mon Sep 22 16:56:08 2003
+++ /tmp/topic/kaffe/libraries/javalib/java/net/DatagramSocket.java	Mon Nov  3 18:24:43 2003
@@ -146,13 +146,24 @@
    */
   public DatagramSocket(int port, InetAddress laddr) throws SocketException
   {
-    if (port < 0 || port > 65535)
-      throw new IllegalArgumentException("Invalid port: " + port);
-
-    SecurityManager s = System.getSecurityManager();
-    if (s != null)
-      s.checkListen(port);
+    this(new InetSocketAddress (laddr, port));
+  }
 
+  /**
+   * Initializes a new instance of <code>DatagramSocket</code> that binds to 
+   * the specified local port and address.
+   *
+   * @param address address to bind the socket to. If address is null,
+   * the socket is left unbound.
+   *
+   * @exception SecurityException If a security manager exists and its
+   * <code>checkListen</code> method doesn't allow the operation.
+   * @exception SocketException If an error occurs.
+   *
+   * @since 1.4
+   */
+  public DatagramSocket (SocketAddress address) throws SocketException
+  {
     String propVal = System.getProperty("impl.prefix");
     if (propVal == null || propVal.equals(""))
       impl = new PlainDatagramSocketImpl();
@@ -170,12 +181,26 @@
 	}
     impl.create();
 
+    // If address is null just return immediately.
+    if (address == null)
+      return;
+
+    InetSocketAddress is_addr = (InetSocketAddress)address;
+    InetAddress laddr;
+
+    laddr = is_addr.getAddress();
     if (laddr == null)
       laddr = InetAddress.ANY_IF;
-    
+    if (is_addr.getPort() < 0 || is_addr.getPort() > 65535)
+      throw new IllegalArgumentException("Invalid port: " + is_addr.getPort());
+
+    SecurityManager s = System.getSecurityManager();
+    if (s != null)
+      s.checkListen (is_addr.getPort());
+ 
     try
       {
-        impl.bind (port, laddr);
+        impl.bind (is_addr.getPort(), laddr);
       }
     catch (SocketException exception)
       {
@@ -193,25 +218,6 @@
         throw error;
       }
   }
-
-  /**
-   * Initializes a new instance of <code>DatagramSocket</code> that binds to 
-   * the specified local port and address.
-   *
-   * @param port The local port number to bind to.
-   * @param laddr The local address to bind to.
-   *
-   * @exception SecurityException If a security manager exists and its
-   * <code>checkListen</code> method doesn't allow the operation.
-   * @exception SocketException If an error occurs.
-   *
-   * @since 1.4
-   */
-  public DatagramSocket (SocketAddress address) throws SocketException
-  {
-    this (((InetSocketAddress) address).getPort (),
-          ((InetSocketAddress) address).getAddress ());
-  }
   
   /**
    * Closes this datagram socket.

--------------080009050509080502090607--




From MAILER-DAEMON Fri Nov 21 14:30:31 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANGz6-0007Mr-U8
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 14:30:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANGyv-0007I6-TO
	for classpath@gnu.org; Fri, 21 Nov 2003 14:30:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANGvk-0006bf-Ek
	for classpath@gnu.org; Fri, 21 Nov 2003 14:27:31 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANGvc-0006Y4-10
	for classpath@gnu.org; Fri, 21 Nov 2003 14:26:52 -0500
Received: from [192.168.1.33] (199.3.dyn-adsl.customer.ch.easynet.net
	[217.8.199.3]) by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id 26B5A64732; Fri, 21 Nov 2003 19:25:24 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: Dalibor Topic <robilad@yahoo.com>
Date: Fri, 21 Nov 2003 19:24:12 +0100
Message-Id: <20031121182412.28824@smtp.mail.ch.easynet.net>
In-Reply-To: <3FBE2E13.5070201@kaffe.org>
References: <3FBE2E13.5070201@kaffe.org>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: small bug report for java.io.FileInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 19:30:26 -0000

Hi Dalibor,

>I've attached a test case that demonstrates the bug.

Would you mind re-formulating this as a Mauve test case? It's really not
much work, and it would mean that we have another thing that gets
automatically tested.

Thanks a lot,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Fri Nov 21 14:55:03 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANHMs-0001NV-Uq
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 14:55:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANHMq-0001Kg-Fp
	for classpath@gnu.org; Fri, 21 Nov 2003 14:55:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANHMK-0000gv-G3
	for classpath@gnu.org; Fri, 21 Nov 2003 14:54:59 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANHMK-0000gM-1w
	for classpath@gnu.org; Fri, 21 Nov 2003 14:54:28 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANGOs-00024x-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 19:53:02 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANGOo-000215-00; Fri, 21 Nov 2003 19:52:58 +0100
Message-ID: <3FBE5F0A.109@kaffe.org>
Date: Fri, 21 Nov 2003 19:52:58 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Sascha Brawer <brawer@dandelis.ch>
References: <3FBE2E13.5070201@kaffe.org>
	<20031121182412.28824@smtp.mail.ch.easynet.net>
In-Reply-To: <20031121182412.28824@smtp.mail.ch.easynet.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Dalibor Topic <robilad@yahoo.com>, GNU Classpath <classpath@gnu.org>
Subject: Re: small bug report for java.io.FileInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 19:55:01 -0000

Hallo Sascha,

Sascha Brawer wrote:
> Hi Dalibor,
> 
> 
>>I've attached a test case that demonstrates the bug.
> 
> 
> Would you mind re-formulating this as a Mauve test case? It's really not
> much work, and it would mean that we have another thing that gets
> automatically tested.

No, I wouldn't mind at all. ;)

I just find it easier to write small tests to expose bugs everyone can 
run quickly to evaluate the patch, before I write a real mauve test, 
which requires that you have a working mauve install first.

cheers,
dalibor topic




From MAILER-DAEMON Fri Nov 21 15:23:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANHon-0001Ek-QC
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 15:23:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANHok-0001DN-Ju
	for classpath@gnu.org; Fri, 21 Nov 2003 15:23:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANHoD-00012U-As
	for classpath@gnu.org; Fri, 21 Nov 2003 15:23:49 -0500
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANHoC-00011N-0h
	for classpath@gnu.org; Fri, 21 Nov 2003 15:23:16 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix3-1.free.fr (Postfix) with ESMTP id E3820C40E9
	for <classpath@gnu.org>; Fri, 21 Nov 2003 20:21:48 +0100 (CET)
Message-ID: <3FBE65C4.8040701@kaffe.org>
Date: Fri, 21 Nov 2003 20:21:40 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------060802060803060605090100"
Subject: [PATCH] Compliance of DecimalFormatSymbols
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 20:23:51 -0000

This is a multi-part message in MIME format.
--------------060802060803060605090100
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is an adaptation of the former patch concerning java/text.
This one is small and concerns only java/text/DecimalFormatSymbols.
According to the official specification, if the serial version is greater
than 2, you have to read the locale field. This is what is done here.

Regards,
Guilhem.

ChangeLog entry:

2003-11-21 Guilhem Lavaux <guilhem@kaffe.org>

   * java/text/DecimalFormatSymbols.java    (locale): New field.
   (serialVersionOnStream): Upgraded to number 2
   (readObject): updated to assign locale if it wasn't by the
   serializer.


--------------060802060803060605090100
Content-Type: text/plain;
 name="format_symbols_diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="format_symbols_diff"

Index: java/text/DecimalFormatSymbols.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/DecimalFormatSymbols.java,v
retrieving revision 1.7
diff -u -r1.7 DecimalFormatSymbols.java
--- java/text/DecimalFormatSymbols.java	15 Nov 2003 21:45:27 -0000	1.7
+++ java/text/DecimalFormatSymbols.java	21 Nov 2003 19:14:00 -0000
@@ -158,6 +158,7 @@
     percent = safeGetChar (res, "percent", '%');
     perMill = safeGetChar (res, "perMill", '\u2030');
     zeroDigit = safeGetChar (res, "zeroDigit", '0');
+    locale = loc;
   }
 
   /**
@@ -580,13 +581,20 @@
   /**
    * @serial This value represents the type of object being de-serialized.
    * 0 indicates a pre-Java 1.1.6 version, 1 indicates 1.1.6 or later.
-   */
-  private int serialVersionOnStream = 1;
+   * 0 indicates a pre-Java 1.1.6 version, 1 indicates 1.1.6 or later,
+   * 2 indicates 1.4 or later
+    */
+  private int serialVersionOnStream = 2;
   /**
    * @serial This is the character used to represent 0.
    */
   private char zeroDigit;
 
+  /**
+   * @serial the locale of these currency symbols.
+   */
+  private Locale locale;
+ 
   private static final long serialVersionUID = 5772796243397350300L;
 
   private void readObject(ObjectInputStream stream)
@@ -597,7 +605,11 @@
       {
         monetarySeparator = decimalSeparator;
 	exponential = 'E';
-	serialVersionOnStream = 1;
       }
+    if (serialVersionOnStream < 2)
+      {
+	locale = Locale.getDefault();
+      }
+    serialVersionOnStream = 2;
   }
 }

--------------060802060803060605090100--




From MAILER-DAEMON Fri Nov 21 15:43:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANI74-0000Iy-Mh
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 15:42:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANI6s-0008QO-50
	for classpath@gnu.org; Fri, 21 Nov 2003 15:42:34 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANI6C-0007ZR-4k
	for classpath@gnu.org; Fri, 21 Nov 2003 15:42:23 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANI6B-0007YW-IE
	for classpath@gnu.org; Fri, 21 Nov 2003 15:41:51 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANH8k-00075e-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 20:40:26 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANH8i-000742-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 20:40:24 +0100
Message-ID: <3FBE6A28.7050901@kaffe.org>
Date: Fri, 21 Nov 2003 20:40:24 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Subject: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 20:42:43 -0000

Hi all,

attached is my fix to make ant (I think) work again with Classpath, 
fixing the bug reported by Jim Pick here [1]

Citing myself [2]:
this is a typical java library bug, and I've both produced and fixed a 
couple of those myself ;) You get an infinite recursion through calling 
overridden methods. Class A in library implements public methods b and 
c, where b internally (and of course undocumentedly ;) calls c. Class B 
from some user of the library extends A and overrides c to call b. When 
the user calls the method b of class B it goes straight into an infinite 
loop.

The fix is to avoid calling overridable methods from overridable 
methods, and to delegate those calls to internal, non-overridable 
versions of the methods.

2003-11-21  Dalibor Topic <robilad@kaffe.org>

         * libraries/javalib/java/util/Hashtable.java:
         (internalcontainsValue) new method.
         (contains, containsValue) delegate to internalContainsValue.

         Reported by: Jim Pick <jim@kaffe.org>

cheers,
dalibor topic

[1] http://mail.gnu.org/archive/html/classpath/2003-09/msg00009.html
[2] http://mail.gnu.org/archive/html/classpath/2003-09/msg00016.html




From MAILER-DAEMON Fri Nov 21 15:50:22 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANIEQ-0002bK-07
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 15:50:22 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANIEM-0002aP-P4
	for classpath@gnu.org; Fri, 21 Nov 2003 15:50:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANIDq-0002Rx-Df
	for classpath@gnu.org; Fri, 21 Nov 2003 15:50:17 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANIDp-0002Rd-Qs
	for classpath@gnu.org; Fri, 21 Nov 2003 15:49:45 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANHGO-0008VY-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 20:48:20 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANHGL-0008Si-00; Fri, 21 Nov 2003 20:48:17 +0100
Message-ID: <3FBE6C01.3040909@kaffe.org>
Date: Fri, 21 Nov 2003 20:48:17 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <3FBE6A28.7050901@kaffe.org>
In-Reply-To: <3FBE6A28.7050901@kaffe.org>
Content-Type: multipart/mixed; boundary="------------050600000702070500090304"
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 20:50:19 -0000

This is a multi-part message in MIME format.
--------------050600000702070500090304
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Dalibor Topic wrote:
> Hi all,
> 
> attached is my fix to make ant (I think) work again with Classpath, 
> fixing the bug reported by Jim Pick here [1]
> 
> Citing myself [2]:
> this is a typical java library bug, and I've both produced and fixed a 
> couple of those myself ;) You get an infinite recursion through calling 
> overridden methods. Class A in library implements public methods b and 
> c, where b internally (and of course undocumentedly ;) calls c. Class B 
> from some user of the library extends A and overrides c to call b. When 
> the user calls the method b of class B it goes straight into an infinite 
> loop.
> 
> The fix is to avoid calling overridable methods from overridable 
> methods, and to delegate those calls to internal, non-overridable 
> versions of the methods.
> 
> 2003-11-21  Dalibor Topic <robilad@kaffe.org>
> 
>         * libraries/javalib/java/util/Hashtable.java:
>         (internalcontainsValue) new method.
>         (contains, containsValue) delegate to internalContainsValue.
> 
>         Reported by: Jim Pick <jim@kaffe.org>
> 
> cheers,
> dalibor topic
> 
> [1] http://mail.gnu.org/archive/html/classpath/2003-09/msg00009.html
> [2] http://mail.gnu.org/archive/html/classpath/2003-09/msg00016.html

And this time, I even attached the patch! ;)

cheers,
dalbor topic

--------------050600000702070500090304
Content-Type: text/plain;
 name="cpath-dalibor-hashtable.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-dalibor-hashtable.diff"

--- /var/tmp/PROJECTS/classpath//./java/util/Hashtable.java	Wed Nov 12 21:56:20 2003
+++ /tmp/topic/kaffe/libraries/javalib/java/util/Hashtable.java	Fri Oct 10 18:49:09 2003
@@ -333,7 +333,10 @@
    */
   public synchronized boolean contains(Object value)
   {
-    return containsValue(value);
+    /* delegate to non-overridable worker method 
+     * to avoid blowing up the stack.
+     */
+    return internalContainsValue(value);
   }
 
   /**
@@ -349,6 +352,25 @@
    * @since 1.2
    */
   public boolean containsValue(Object value)
+  {
+    /* delegate to non-overridable worker method 
+     * to avoid blowing up the stack.
+     */
+    return internalContainsValue(value);
+  }
+
+  /**
+   * Returns true if this Hashtable contains a value <code>o</code>, such that
+   * <code>o.equals(value)</code>. This is an internal worker method
+   * called by <code>contains()</code> and <code>containsValue()</code>.
+   *
+   * @param value the value to search for in this Hashtable
+   * @return true if at least one key maps to the value
+   * @see #contains(Object)
+   * @see #containsKey(Object)
+   * @throws NullPointerException if <code>value</code> is null
+   */
+  private boolean internalContainsValue(Object value)
   {
     for (int i = buckets.length - 1; i >= 0; i--)
       {

--------------050600000702070500090304--




From MAILER-DAEMON Fri Nov 21 15:59:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANIMr-0005z9-Ti
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 15:59:05 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANIMo-0005yL-Vy
	for classpath@gnu.org; Fri, 21 Nov 2003 15:59:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANIMI-0005tt-40
	for classpath@gnu.org; Fri, 21 Nov 2003 15:59:02 -0500
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANIMH-0005tg-JP
	for classpath@gnu.org; Fri, 21 Nov 2003 15:58:29 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix3-1.free.fr (Postfix) with ESMTP id 2359DC4074
	for <classpath@gnu.org>; Fri, 21 Nov 2003 20:57:04 +0100 (CET)
Message-ID: <3FBE6E08.6070208@kaffe.org>
Date: Fri, 21 Nov 2003 20:56:56 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------020907060901050204080100"
Subject: [PATCH] NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 20:59:03 -0000

This is a multi-part message in MIME format.
--------------020907060901050204080100
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is just a patch to review about NumberFormat.Field before I check 
it in. It implements java.text.NumberFormat.Field it is quite 
straightforward using the documentation.

Regards,

Guilhem.

ChangeLog entry:

2003-11-21 Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/NumberFormat.java 
	(NumberFormat.Field): New implemented class to match Java 1.4


--------------020907060901050204080100
Content-Type: text/plain;
 name="number_format_diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="number_format_diff"

Index: java/text/NumberFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/NumberFormat.java,v
retrieving revision 1.4
diff -u -r1.4 NumberFormat.java
--- java/text/NumberFormat.java	22 Jan 2002 22:27:01 -0000	1.4
+++ java/text/NumberFormat.java	21 Nov 2003 19:52:44 -0000
@@ -79,6 +79,98 @@
    */
   public static final int FRACTION_FIELD = 1;
 
+  public static class Field extends Format.Field
+  {
+    static final long serialVersionUID = 7494728892700160890L;
+
+    /**
+     * Attribute set to all characters containing digits of the integer
+     * part.
+     */
+    public static final NumberFormat.Field INTEGER = new Field("integer");
+
+    /**
+     * Attribute set to all characters containing digits of the fractional
+     * part.
+     */
+    public static final NumberFormat.Field FRACTION = new Field("fraction");
+
+    /**
+     * Attribute set to all characters containing digits of the exponential
+     * part.
+     */
+    public static final NumberFormat.Field EXPONENT = new Field("exponent");
+
+    /**
+     * Attribute set to all characters containing a decimal separator.
+     */
+    public static final NumberFormat.Field DECIMAL_SEPARATOR = new Field("decimal separator");
+
+    /**
+     * Attribute set to all characters containing a sign (plus or minus).
+     */
+    public static final NumberFormat.Field SIGN = new Field("sign");
+
+    /**
+     * Attribute set to all characters containing a grouping separator (e.g. a comma,
+     * a white space,...).
+     */
+    public static final NumberFormat.Field GROUPING_SEPARATOR = new Field("grouping separator");
+
+    /**
+     * Attribute set to all characters containing an exponential symbol (e.g. 'E')
+     */
+    public static final NumberFormat.Field EXPONENT_SYMBOL = new Field("exponent symbol");
+
+    /**
+     * Attribute set to all characters containing a percent symbol (e.g. '%')
+     */
+    public static final NumberFormat.Field PERCENT = new Field("percent");
+
+    /**
+     * Attribute set to all characters containing a permille symbol.
+     */
+    public static final NumberFormat.Field PERMILLE = new Field("permille");
+
+    /**
+     * Attribute set to all characters containing the currency unit.
+     */
+    public static final NumberFormat.Field CURRENCY = new Field("currency");
+
+    /**
+     * Attribute set to all characters containing the exponent sign.
+     */
+    public static final NumberFormat.Field EXPONENT_SIGN = new Field("exponent sign");
+
+    private static final NumberFormat.Field[] allFields =
+    {
+      INTEGER, FRACTION, EXPONENT, DECIMAL_SEPARATOR, SIGN,
+      GROUPING_SEPARATOR, EXPONENT_SYMBOL, PERCENT,
+      PERMILLE, CURRENCY, EXPONENT_SIGN
+    };
+
+    // For deserialization purpose
+    private Field()
+    {
+      super("");
+    }
+    
+    private Field(String s)
+    {
+      super(s);
+    }
+
+    protected Object readResolve() throws InvalidObjectException
+    {
+      String s = getName();
+      for (int i=0;i<allFields.length;i++)
+	if (s.equals(allFields[i].getName()))
+	  return allFields[i];
+
+      throw new InvalidObjectException("no such NumberFormat field called " + s);
+    }
+  }
+
   /**
    * This method is a specialization of the format method that performs
    * a simple formatting of the specified <code>long</code> number.

--------------020907060901050204080100--




From MAILER-DAEMON Fri Nov 21 16:10:26 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANIXq-0006uQ-9i
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 16:10:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANIXo-0006u8-0j
	for classpath@gnu.org; Fri, 21 Nov 2003 16:10:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANIXC-0006l0-T0
	for classpath@gnu.org; Fri, 21 Nov 2003 16:10:19 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANIXC-0006kp-F6
	for classpath@gnu.org; Fri, 21 Nov 2003 16:09:46 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANHZl-0003L1-00
	for <classpath@gnu.org>; Fri, 21 Nov 2003 21:08:21 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANHZi-0003KB-00; Fri, 21 Nov 2003 21:08:18 +0100
Message-ID: <3FBE70B2.7020301@kaffe.org>
Date: Fri, 21 Nov 2003 21:08:18 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <3FBE6A28.7050901@kaffe.org> <3FBE6C01.3040909@kaffe.org>
In-Reply-To: <3FBE6C01.3040909@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 21:10:24 -0000

Dalibor Topic wrote:
> Dalibor Topic wrote:
> 
>> Hi all,
>>
>> attached is my fix to make ant (I think) work again with Classpath, 
>> fixing the bug reported by Jim Pick here [1]
>>
>> Citing myself [2]:
>> this is a typical java library bug, and I've both produced and fixed a 
>> couple of those myself ;) You get an infinite recursion through 
>> calling overridden methods. Class A in library implements public 
>> methods b and c, where b internally (and of course undocumentedly ;) 
>> calls c. Class B from some user of the library extends A and overrides 
>> c to call b. When the user calls the method b of class B it goes 
>> straight into an infinite loop.
>>
>> The fix is to avoid calling overridable methods from overridable 
>> methods, and to delegate those calls to internal, non-overridable 
>> versions of the methods.
>>
>> 2003-11-21  Dalibor Topic <robilad@kaffe.org>
>>
>>         * libraries/javalib/java/util/Hashtable.java:
>>         (internalcontainsValue) new method.
>>         (contains, containsValue) delegate to internalContainsValue.
>>
>>         Reported by: Jim Pick <jim@kaffe.org>
>>
>> cheers,
>> dalibor topic
>>
>> [1] http://mail.gnu.org/archive/html/classpath/2003-09/msg00009.html
>> [2] http://mail.gnu.org/archive/html/classpath/2003-09/msg00016.html
> 
> 
> And this time, I even attached the patch! ;)

Yeah, the ChangeLog doesn;t look Classpath-ish enough.

2003-11-21  Dalibor Topic <robilad@kaffe.org>

          * libraries/javalib/java/util/Hashtable.java
          (internalcontainsValue): new method.
          (contains, containsValue) delegate to internalContainsValue.

          Reported by: Jim Pick <jim@kaffe.org>

cheers,
dalibor topic




From MAILER-DAEMON Fri Nov 21 16:37:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANIxd-0002L1-Ou
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 16:37:05 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANIxa-0002JP-2N
	for classpath@gnu.org; Fri, 21 Nov 2003 16:37:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANIwy-0001zB-0Y
	for classpath@gnu.org; Fri, 21 Nov 2003 16:36:55 -0500
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANIwp-0001vy-3i
	for classpath@gnu.org; Fri, 21 Nov 2003 16:36:15 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix3-2.free.fr (Postfix) with ESMTP id 9C67DC0FC
	for <classpath@gnu.org>; Fri, 21 Nov 2003 21:34:48 +0100 (CET)
Message-ID: <3FBE76E0.4020009@kaffe.org>
Date: Fri, 21 Nov 2003 21:34:40 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------040801090604080901070207"
Subject: [PATCH] Two methods for NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 21:37:03 -0000

This is a multi-part message in MIME format.
--------------040801090604080901070207
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I am continuing the series of patches with that one, it adds two methods 
to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). 
They have to be implemented according to Java 1.4.

Please review it before I check it in.

Regards,
Guilhem.


--------------040801090604080901070207
Content-Type: text/plain;
 name="number_format_diff2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="number_format_diff2"

Index: java/text/NumberFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/NumberFormat.java,v
retrieving revision 1.4
diff -u -r1.4 NumberFormat.java
--- java/text/NumberFormat.java	22 Jan 2002 22:27:01 -0000	1.4
+++ java/text/NumberFormat.java	21 Nov 2003 19:58:29 -0000
@@ -323,6 +415,34 @@
   public static NumberFormat getNumberInstance (Locale loc)
   {
     return computeInstance (loc, "numberFormat", "#,##0.###");
+  }
+
+  /**
+   * This method returns an integer formatting and parsing class for the
+   * default locale. This will be a concrete subclass of <code>NumberFormat</code>,
+   * but the actual class returned is dependent on the locale.
+   *
+   * @return An instance of an integer number formatter for the default locale.
+   */
+  public static final NumberFormat getIntegerInstance()
+  {
+    return getIntegerInstance (Locale.getDefault());
+  }
+
+  /**
+   * This method returns an integer formatting and parsing class for the
+   * default locale. This will be a concrete subclass of <code>NumberFormat</code>,
+   * but the actual class returned is dependent on the locale.
+   *
+   * @param locale the desired locale.
+   *
+   * @return An instance of an integer number formatter for the default locale.
+   */
+  public static NumberFormat getIntegerInstance(Locale locale)
+  {
+    NumberFormat format = computeInstance (locale, "numberFormat", "#,##0");
+    format.setParseIntegerOnly (true);
+    return format;
   }
 
   /**

--------------040801090604080901070207--




From MAILER-DAEMON Fri Nov 21 17:50:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANK6I-0002rr-5t
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 17:50:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANK6G-0002ok-0U
	for classpath@gnu.org; Fri, 21 Nov 2003 17:50:04 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANK5C-0002XO-VN
	for classpath@gnu.org; Fri, 21 Nov 2003 17:49:30 -0500
Received: from [217.185.152.118] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANK4s-0002RY-Gn
	for classpath@gnu.org; Fri, 21 Nov 2003 17:48:39 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hALNC1V02273; Sat, 22 Nov 2003 00:12:01 +0100
Message-ID: <3FBE9BB9.8010106@kaffe.org>
Date: Sat, 22 Nov 2003 00:11:53 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Guilhem Lavaux <guilhem@kaffe.org>
References: <3FBE6E08.6070208@kaffe.org>
In-Reply-To: <3FBE6E08.6070208@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 22:50:04 -0000

Hi Guilhem,

Guilhem Lavaux wrote:
> Hi,
> 
> Here is just a patch to review about NumberFormat.Field before I check 
> it in. It implements java.text.NumberFormat.Field it is quite 
> straightforward using the documentation.

Looks good to me in general, I have small remarks before you check it in:

> Index: java/text/NumberFormat.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/java/text/NumberFormat.java,v
> retrieving revision 1.4
> diff -u -r1.4 NumberFormat.java
> --- java/text/NumberFormat.java	22 Jan 2002 22:27:01 -0000	1.4
> +++ java/text/NumberFormat.java	21 Nov 2003 19:52:44 -0000
> @@ -79,6 +79,98 @@
[snip]
> +    private static final NumberFormat.Field[] allFields =
> +    {
> +      INTEGER, FRACTION, EXPONENT, DECIMAL_SEPARATOR, SIGN,
> +      GROUPING_SEPARATOR, EXPONENT_SYMBOL, PERCENT,
> +      PERMILLE, CURRENCY, EXPONENT_SIGN
> +    };

I don't know what GNU Classpath's policy on JavaDoc comments for private 
  members [1] is, but as Michael Koch is cheering for checkStyle on #gcj 
I assume it will become the patch submission standard, and it pretty 
much wants to see comments on everything, if I recall my last CheckStyle 
usage attempts.

So, could you add a javadoc comment describing the field, please?

> +    // For deserialization purpose
> +    private Field()
> +    {
> +      super("");
> +    }
Same as above.
Could you add a javadoc comment for the constructor, please?

> +    
> +    private Field(String s)
> +    {
> +      super(s);
> +    }

This constructor is protected in the API spec for 1.4.2.

Again, a small comment would be nice.

> +    protected Object readResolve() throws InvalidObjectException
> +    {
> +      String s = getName();
> +      for (int i=0;i<allFields.length;i++)
> +	if (s.equals(allFields[i].getName()))
> +	  return allFields[i];
> +
> +      throw new InvalidObjectException("no such NumberFormat field called " + s);
> +    }
> +  }

Looks good to me. could you add another comment here?

Finally, the mean question: do we have mauve tests for those? If not, 
would you write some, please, so that gcj devs don't go ahead again and 
re-implement everything from scratch as they tend to do ;)? [2]

cheers,
dalibor topic,

who is eager to write his own patch to the java/text/FieldPosition.java 
(equals) method's comment as soon as he's finished playing virtual mjw ;)

[1] I devote this pun to ricky clarckson. Mark, how are his 
documentation patches coming along?





From MAILER-DAEMON Fri Nov 21 18:09:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANKPL-0003jJ-2v
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 18:09:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANKOk-0002Yl-K9
	for classpath@gnu.org; Fri, 21 Nov 2003 18:09:10 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANKNh-0001ND-Vr
	for classpath@gnu.org; Fri, 21 Nov 2003 18:08:37 -0500
Received: from [202.181.0.28] (helo=delenn.fl.net.au)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANKNh-0001Ly-H5
	for classpath@gnu.org; Fri, 21 Nov 2003 18:08:05 -0500
Received: from a3-p26.syd.fl.net.au (a3-p26.syd.fl.net.au [202.181.1.90])
	by delenn.fl.net.au (Postfix) with ESMTP id 60D7F5B6249
	for <classpath@gnu.org>; Sat, 22 Nov 2003 09:07:40 +1100 (EST)
From: "Raif S. Naffah" <raif@fl.net.au>
To: Classpath Discussion Mailing List <classpath@gnu.org>
Date: Sat, 22 Nov 2003 09:06:25 +1100
User-Agent: KMail/1.5
References: <878ymexym1.fsf@fleche.redhat.com>
In-Reply-To: <878ymexym1.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200311220906.37004.raif@fl.net.au>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: raif@fl.net.au
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 23:09:45 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

On Tue, 18 Nov 2003 12:19 pm, Tom Tromey wrote:
> ...
> I made a new release with these improvements.  Once again, it is
> here:
>
>     ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz

jalopy is able to handle grouping, and sorting, of class elements=20
(e.g.static field and initialisers, instance fields, constructors,=20
etc...) and separating them with a 1-line separator (2 with a blank=20
line followup).

how (strongly) do people feel about enabling this?


cheers;
rsn
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Que du magnifique

iD8DBQE/voxp+e1AKnsTRiERA67YAKDzb8bjI37+H0Xyaw68A6EFo4dSNACfZIyO
WisJqO0YFNybaStWRqqDHnQ=3D
=3D2NPI
=2D----END PGP SIGNATURE-----




From MAILER-DAEMON Fri Nov 21 18:17:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANKWd-0003T6-A3
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 18:17:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANKWb-0003T0-V6
	for classpath@gnu.org; Fri, 21 Nov 2003 18:17:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANKW5-00037w-AK
	for classpath@gnu.org; Fri, 21 Nov 2003 18:17:16 -0500
Received: from [217.185.152.118] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANKW4-00036D-2r
	for classpath@gnu.org; Fri, 21 Nov 2003 18:16:44 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hALNdYV02848; Sat, 22 Nov 2003 00:39:34 +0100
Message-ID: <3FBEA22A.3030801@kaffe.org>
Date: Sat, 22 Nov 2003 00:39:22 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Guilhem Lavaux <guilhem@kaffe.org>
References: <3FBE65C4.8040701@kaffe.org>
In-Reply-To: <3FBE65C4.8040701@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Compliance of DecimalFormatSymbols
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 23:17:18 -0000

Salut Guilhem,

Guilhem Lavaux wrote:
> Hi,
> 
> Here is an adaptation of the former patch concerning java/text.
> This one is small and concerns only java/text/DecimalFormatSymbols.
> According to the official specification, if the serial version is greater
> than 2, you have to read the locale field. This is what is done here.

Looks good to me beside just a small point. Could you write some mauve 
tests to go with it, please?


> Regards,
> Guilhem.
> 
> ChangeLog entry:
> 
> 2003-11-21 Guilhem Lavaux <guilhem@kaffe.org>
> 
>   * java/text/DecimalFormatSymbols.java    (locale): New field.
>   (serialVersionOnStream): Upgraded to number 2
>   (readObject): updated to assign locale if it wasn't by the
>   serializer.

Lacks one entry:
(DecimalFormatSymbols (Locale)): Set locale.

Other than that, looks fine to me. I'm waiting for the ChangeLog police, 
though ;)

cheers,
dalibor topic




From MAILER-DAEMON Fri Nov 21 18:29:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANKii-00070C-5s
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 18:29:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANKif-000704-Ce
	for classpath@gnu.org; Fri, 21 Nov 2003 18:29:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANKi9-0006vr-QB
	for classpath@gnu.org; Fri, 21 Nov 2003 18:29:44 -0500
Received: from [217.185.152.118] (helo=clerks.local)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANKi8-0006vn-Oa
	for classpath@gnu.org; Fri, 21 Nov 2003 18:29:13 -0500
Received: from kaffe.org (localhost [127.0.0.1])
	by clerks.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id
	hALNpbV02894; Sat, 22 Nov 2003 00:51:38 +0100
Message-ID: <3FBEA505.50508@kaffe.org>
Date: Sat, 22 Nov 2003 00:51:33 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: raif@fl.net.au
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
In-Reply-To: <200311220906.37004.raif@fl.net.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 23:29:45 -0000

Hi Raif,

Raif S. Naffah wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
> 
> On Tue, 18 Nov 2003 12:19 pm, Tom Tromey wrote:
> 
>>...
>>I made a new release with these improvements.  Once again, it is
>>here:
>>
>>    ftp://sources.redhat.com/pub/java/jalopy-console-1.0.4.tar.gz
> 
> 
> jalopy is able to handle grouping, and sorting, of class elements 
> (e.g.static field and initialisers, instance fields, constructors, 
> etc...) and separating them with a 1-line separator (2 with a blank 
> line followup).
> 
> how (strongly) do people feel about enabling this?

I'd love that. It's strongly useful when you're searcjhing for 
methods/fields etc. in a file. ;)

cheers,
dalibor topic

p.s. is there some kind of gnu-crypto.m4 file for automake to add a 
--with-gnu-crypto option to it? I'd love having a simple way to chuck in 
GNU crypto into kaffe without having to bother with those weird U.S. 
crypto laws, as kaffe's CVS server is located in California.




From MAILER-DAEMON Fri Nov 21 18:50:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANL2O-0003JK-8h
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 18:50:08 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANL2M-0003JD-89
	for classpath@gnu.org; Fri, 21 Nov 2003 18:50:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANL1q-0003H9-GO
	for classpath@gnu.org; Fri, 21 Nov 2003 18:50:05 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANL1q-0003H6-3X
	for classpath@gnu.org; Fri, 21 Nov 2003 18:49:34 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-75-204.ewetel.net
	[80.228.75.204])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id hALMlK6J008367;
	Fri, 21 Nov 2003 23:47:21 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1ANK3o-0005Gz-00; Fri, 21 Nov 2003 23:47:32 +0100
Date: Fri, 21 Nov 2003 23:47:32 +0100
From: Michael Koch <konqueror@gmx.de>
To: Dalibor Topic <robilad@kaffe.org>
Message-ID: <20031121224732.GA19860@mail.konqueror.de>
References: <3FBE52AA.5020705@kaffe.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FBE52AA.5020705@kaffe.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] DatagramSocket constrcutor fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2003 23:50:06 -0000

On Fri, Nov 21, 2003 at 07:00:10PM +0100, Dalibor Topic wrote:
> Hi all,
> 
> attached is another patch from Guilhem that fixes DatagramSocket 
> constructor behaviour & comments. It resulted as a fix to a bug report 
> to the kaffe mailing list from Everton da Silva Marques [1]. Please also 
> take a look at the discussion in the thread about other approaches to 
> fix the issue, and why they weren't picked.
> 
> 
> 2003-11-21  Guilhem Lavaux <guilhem@kaffe.org>
> 
>         * libraries/javalib/java/net/DatagramSocket.java
> 	((DatagramSocket(SocketAddress)): Fixed comment to match
> 	method. If address is null leave socket unbound.
> 	(DatagramSocket(int, InetAddress)): Rewritten to delegate
> 	to ((DatagramSocket(SocketAddress)) in order to pick up
> 	the fix. Moved checking code into
> 	((DatagramSocket(SocketAddress)).

This patch is in Classpath BTS already (two times). I'm working on this.
A similar patch is already in my tree. I just cant commit/submit it because the
network adapter of the computer with this code is broken. Will try to
make it work this weekend again. 


Michael



From MAILER-DAEMON Fri Nov 21 19:40:18 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANLov-00020a-Hw
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 19:40:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANLor-000202-Ax
	for classpath@gnu.org; Fri, 21 Nov 2003 19:40:13 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANLoK-0001xT-TZ
	for classpath@gnu.org; Fri, 21 Nov 2003 19:40:11 -0500
Received: from [202.181.0.28] (helo=delenn.fl.net.au)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1ANLoI-0001wi-TZ; Fri, 21 Nov 2003 19:39:39 -0500
Received: from a3-p26.syd.fl.net.au (a3-p26.syd.fl.net.au [202.181.1.90])
	by delenn.fl.net.au (Postfix) with ESMTP
	id 176155B5D63; Sat, 22 Nov 2003 10:39:13 +1100 (EST)
From: "Raif S. Naffah" <raif@fl.net.au>
To: Dalibor Topic <robilad@kaffe.org>
Date: Sat, 22 Nov 2003 10:38:04 +1100
User-Agent: KMail/1.5
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au> <3FBEA505.50508@kaffe.org>
In-Reply-To: <3FBEA505.50508@kaffe.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200311221038.09530.raif@fl.net.au>
Cc: GNU Crypto <gnu-crypto-discuss@gnu.org>,
	Classpath Discussion Mailing List <classpath@gnu.org>
Subject: gnu-crypto.m4.  was: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: raif@fl.net.au
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 00:40:15 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

hello Dalibor,

(i'm cc-ing GNU Crypto)

On Sat, 22 Nov 2003 10:51 am, Dalibor Topic wrote:
> ...
> p.s. is there some kind of gnu-crypto.m4 file for automake to add a
> --with-gnu-crypto option to it? I'd love having a simple way to chuck
> in GNU crypto into kaffe without having to bother with those weird
> U.S. crypto laws, as kaffe's CVS server is located in California.

no there isnt but i'm happy to work with you on making one.

things to consider are:

* building gnu crypto is effectively building three jars/libraries: one=20
is the gnu-crypto per se (incl. the JCE Adapters), the other two are=20
javax-crypto and javax-security (callbacks and sasl).

* once installed in a location (default is /usr/local/gnu-crypto) it=20
should be straightforward to construct the different options/switches=20
needed by the kaffe build script from the contents of that location.

* it would be nice to be able to re-use most, if not all, of the=20
generated options/switches of such an m4 library with other VM=20
providers; e.g. kissme and jikes rvm.

if you think this is worth it, let's continue this thread on the GNU=20
Crypto list.


cheers;
rsn

p.s. if there is a Debian packager out there who is capable/willing to=20
help us deliver the library as a debian package, pls. let me know.

=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Que du magnifique

iD8DBQE/vqHc+e1AKnsTRiERA66xAJ0dB8LDkuiC1J3tAfdpaz8XZYGoBwCg6J4p
5Zn1P8BCgMQDhN47X0GDwdE=3D
=3D9O5u
=2D----END PGP SIGNATURE-----




From MAILER-DAEMON Fri Nov 21 19:40:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANLpP-00026j-F9
	for mharc-classpath@gnu.org; Fri, 21 Nov 2003 19:40:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANLpL-000263-Re
	for classpath@gnu.org; Fri, 21 Nov 2003 19:40:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANLop-0001zW-AJ
	for classpath@gnu.org; Fri, 21 Nov 2003 19:40:42 -0500
Received: from [213.86.99.234] (helo=phoenix.infradead.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1ANLoo-0001zK-Lu
	for classpath@gnu.org; Fri, 21 Nov 2003 19:40:10 -0500
Received: from localhost.localdomain ([127.0.0.1] helo=localhost)
	by phoenix.infradead.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.22) id 1ANKrL-0006ds-JE
	for classpath@gnu.org; Fri, 21 Nov 2003 23:38:43 +0000
Date: Fri, 21 Nov 2003 23:38:42 +0000 (GMT)
From: James Simmons <jsimmons@infradead.org>
To: classpath@gnu.org
Message-ID: <Pine.LNX.4.44.0311212335280.20105-100000@phoenix.infradead.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: GraphicsConfigTemplate
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 00:40:45 -0000


Hi!

    I'm writing a X window AWt for Classpath. At present I'm working on 
the Graphics*.java classes. I figured out how to write native code for all 
the classes except for GraphicsConfigTemplate. How do you use the enum 
fields? I can't figure it out.





From MAILER-DAEMON Sat Nov 22 02:26:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANS9f-0003wW-PF
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 02:26:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANS9d-0003wP-EO
	for classpath@gnu.org; Sat, 22 Nov 2003 02:26:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANS97-0003vp-Nb
	for classpath@gnu.org; Sat, 22 Nov 2003 02:26:04 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANS97-0003vm-7E
	for classpath@gnu.org; Sat, 22 Nov 2003 02:25:33 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANRBA-0000lK-00; Sat, 22 Nov 2003 07:23:36 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FBE6C01.3040909@kaffe.org>
References: <3FBE6A28.7050901@kaffe.org>  <3FBE6C01.3040909@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-HagV6TeK/8hWMADhJXF2"
Message-Id: <1069482244.2848.622.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 07:24:04 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 07:26:06 -0000


--=-HagV6TeK/8hWMADhJXF2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-21 at 20:48, Dalibor Topic wrote:
> > this is a typical java library bug, and I've both produced and fixed a=20
> > couple of those myself ;) You get an infinite recursion through calling=
=20
> > overridden methods. Class A in library implements public methods b and=20
> > c, where b internally (and of course undocumentedly ;) calls c. Class B=
=20
> > from some user of the library extends A and overrides c to call b. When=
=20
> > the user calls the method b of class B it goes straight into an infinit=
e=20
> > loop.

Ugh. That is nasty. Especially since when you override Hashtable it is a
natural thing to do since contains and containsValue are specced to do
the same thing.

I created a small Mauve test for this
gnu.testlet.java.util.Hashtable.HashContains.

> Yeah, the ChangeLog doesn;t look Classpath-ish enough.
>=20
> 2003-11-21  Dalibor Topic <robilad@kaffe.org>
>=20
>           * libraries/javalib/java/util/Hashtable.java
>           (internalcontainsValue): new method.
>           (contains, containsValue) delegate to internalContainsValue.
>=20
>           Reported by: Jim Pick <jim@kaffe.org>

Almost :)
Reported by goes on top.
Entires are full sentences starting with a capital.

2003-11-21  Dalibor Topic <robilad@kaffe.org>

          Reported by: Jim Pick <jim@kaffe.org>
          * libraries/javalib/java/util/Hashtable.java
          (internalcontainsValue): New method.
          (contains, containsValue): Delegate to internalContainsValue.

________________________________________________________________________
> --- /var/tmp/PROJECTS/classpath//./java/util/Hashtable.java	Wed Nov 12 21=
:56:20 2003
> +++ /tmp/topic/kaffe/libraries/javalib/java/util/Hashtable.java	Fri Oct 1=
0 18:49:09 2003
> @@ -333,7 +333,10 @@
>     */
>    public synchronized boolean contains(Object value)
>    {
> -    return containsValue(value);
> +    /* delegate to non-overridable worker method=20
> +     * to avoid blowing up the stack.
> +     */
> +    return internalContainsValue(value);
>    }

To be more clear, please add 'blowing up the stack, when called from
overridden contains[Value]() method'.

>    /**
> @@ -349,6 +352,25 @@
>     * @since 1.2
>     */
>    public boolean containsValue(Object value)
> +  {
> +    /* delegate to non-overridable worker method=20
> +     * to avoid blowing up the stack.
> +     */
> +    return internalContainsValue(value);
> +  }

Likewise.

Feel free to try out your new cvs commit powers to check this in
yourself.

Thanks,

Mark

--=-HagV6TeK/8hWMADhJXF2
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vwEExVhZCJWr9QwRAti1AJ9eh/jHUrrgoxs+j17EIu0IHlssLwCeLD2n
JVH5oIensZtcD2VHwIWtgC4=
=nVpx
-----END PGP SIGNATURE-----

--=-HagV6TeK/8hWMADhJXF2--




From MAILER-DAEMON Sat Nov 22 03:18:46 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANSyc-0001hN-7l
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 03:18:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANSya-0001h0-42
	for classpath@gnu.org; Sat, 22 Nov 2003 03:18:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANSy3-0001Uh-RS
	for classpath@gnu.org; Sat, 22 Nov 2003 03:18:42 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANSy3-0001UN-B2
	for classpath@gnu.org; Sat, 22 Nov 2003 03:18:11 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANS07-0000re-00; Sat, 22 Nov 2003 08:16:15 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FBEA22A.3030801@kaffe.org>
References: <3FBE65C4.8040701@kaffe.org>  <3FBEA22A.3030801@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-pDQcQ2lyo41zVq4wbXSi"
Message-Id: <1069485403.2854.671.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 08:16:43 +0100
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Compliance of DecimalFormatSymbols
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 08:18:44 -0000


--=-pDQcQ2lyo41zVq4wbXSi
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 00:39, Dalibor Topic wrote:
> > Here is an adaptation of the former patch concerning java/text.
> > This one is small and concerns only java/text/DecimalFormatSymbols.
> > According to the official specification, if the serial version is great=
er
> > than 2, you have to read the locale field. This is what is done here.

Thanks. Below are some little (syntactic) nitpicks.

> @@ -580,13 +581,20 @@
>    /**
>     * @serial This value represents the type of object being de-serialize=
d.
>     * 0 indicates a pre-Java 1.1.6 version, 1 indicates 1.1.6 or later.
> -   */
> -  private int serialVersionOnStream =3D 1;
> +   * 0 indicates a pre-Java 1.1.6 version, 1 indicates 1.1.6 or later,
> +   * 2 indicates 1.4 or later
> +    */
> +  private int serialVersionOnStream =3D 2;

Indentation looks strange (hopefully jalopy will catch that for us in the f=
uture).
And comments should end with a dot.
>=20
> +  /**
> +   * @serial the locale of these currency symbols.
> +   */
> +  private Locale locale;

Make that comment start with a capital (The local...) so it looks like a re=
al sentence.

>       {
>          monetarySeparator =3D decimalSeparator;
>         exponential =3D 'E';
> -       serialVersionOnStream =3D 1;
>        }
> +    if (serialVersionOnStream < 2)
> +      {
> +       locale =3D Locale.getDefault();
> +      }
> +    serialVersionOnStream =3D 2;
>    }
>  }

You don't need brackets when the block is just one line:

    if (serialVersionOnStream < 2)
      locale =3D Locale.getDefault();

    serialVersionOnStream =3D 2;

> Looks good to me beside just a small point. Could you write some mauve=20
> tests to go with it, please?

Already made a very simple one.
gnu/testlet/java/text/DecimalFormatSymbols/serial.java
It can certainly be extended to test for more things.

> > 2003-11-21 Guilhem Lavaux <guilhem@kaffe.org>
> >=20
> >   * java/text/DecimalFormatSymbols.java    (locale): New field.
> >   (serialVersionOnStream): Upgraded to number 2
> >   (readObject): updated to assign locale if it wasn't by the
> >   serializer.
>=20
> Lacks one entry:
> (DecimalFormatSymbols (Locale)): Set locale.
>=20
> Other than that, looks fine to me. I'm waiting for the ChangeLog police,=20
> though ;)

At your service!

- ChangeLog entries should start with:
  date <two spaces> Name <two spaces> email.
- Just <one space> between filename and (field/method)
- Entries are full sentences with starting capital and ending dot.

2003-11-21  Guilhem Lavaux  <guilhem@kaffe.org>

	* java/text/DecimalFormatSymbols.java (locale): New field.
	(DecimalFormatSymbols (Locale)): Set locale.
	(serialVersionOnStream): Upgraded to number 2.
	(readObject): Assign locale if it wasn't by the serializer.

Guilhem, please feel free to try out your new cvs commit powers with
these changes.

Cheers,

Mark

--=-pDQcQ2lyo41zVq4wbXSi
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vw1bxVhZCJWr9QwRApCjAKCOWKI3Zde22mUEdSGYWlQcoFCHZwCbB+3n
HiO0bhEtrM7yHJkeev5VjSE=
=SIfC
-----END PGP SIGNATURE-----

--=-pDQcQ2lyo41zVq4wbXSi--




From MAILER-DAEMON Sat Nov 22 03:31:27 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANTAt-0007sG-AG
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 03:31:27 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANTAq-0007qg-OH
	for classpath@gnu.org; Sat, 22 Nov 2003 03:31:24 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANTAJ-0007NP-Qx
	for classpath@gnu.org; Sat, 22 Nov 2003 03:31:22 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANTAJ-0007NG-Ep
	for classpath@gnu.org; Sat, 22 Nov 2003 03:30:51 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANSCN-0000sD-00; Sat, 22 Nov 2003 08:28:55 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FBE9BB9.8010106@kaffe.org>
References: <3FBE6E08.6070208@kaffe.org>  <3FBE9BB9.8010106@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-o8eCiI4xqCZnxyyptnCI"
Message-Id: <1069486163.2850.680.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 08:29:24 +0100
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 08:31:25 -0000


--=-o8eCiI4xqCZnxyyptnCI
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 00:11, Dalibor Topic wrote:
> Looks good to me in general, I have small remarks before you check it in:

Same here. Please check it in. Just one little nitpick.

> > +    protected Object readResolve() throws InvalidObjectException
> > +    {
> > +      String s =3D getName();
> > +      for (int i=3D0;i<allFields.length;i++)
> > +	if (s.equals(allFields[i].getName()))
> > +	  return allFields[i];

Indenting looks a bit off, but that could be the diff and the
commenting. Please add spaces between the elements of the for loop and
(assignment) operators.

	for (int i =3D 0; i < allFields.length; i++)

> Finally, the mean question: do we have mauve tests for those? If not,=20
> would you write some, please, so that gcj devs don't go ahead again and=20
> re-implement everything from scratch as they tend to do ;)? [2]

Your [2] note reference is missing. Don't you like us writing Mauve test
cases for you? (Although I doubt you could create a very good one here,
only the (de)serialization is a little interesting.)

> dalibor topic,
>=20
> who is eager to write his own patch to the java/text/FieldPosition.java=20
> (equals) method's comment as soon as he's finished playing virtual mjw ;)

You are getting quite good at it!

> [1] I devote this pun to ricky clarckson. Mark, how are his=20
> documentation patches coming along?

That was a terrible pun...
Ricky is working through the bureaucrazies, he will not give up, he will
not be defeated, and he will do it when he is ready :)

Cheers,

Mark

--=-o8eCiI4xqCZnxyyptnCI
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vxBTxVhZCJWr9QwRAiXsAJ9VjJ+uR9JlCrw6ImnGA7Zaz5qv0gCeIyJe
ZjBPADpi5+M9N+GuZB8jD74=
=3Pom
-----END PGP SIGNATURE-----

--=-o8eCiI4xqCZnxyyptnCI--




From MAILER-DAEMON Sat Nov 22 03:48:37 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANTRV-00057H-5E
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 03:48:37 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANTRS-00056S-23
	for classpath@gnu.org; Sat, 22 Nov 2003 03:48:34 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANTQv-00053U-9f
	for classpath@gnu.org; Sat, 22 Nov 2003 03:48:32 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANTQu-00053R-Ta
	for classpath@gnu.org; Sat, 22 Nov 2003 03:48:01 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANSSz-0000tM-00; Sat, 22 Nov 2003 08:46:05 +0100
From: Mark Wielaard <mark@klomp.org>
To: Guilhem Lavaux <guilhem@kaffe.org>
In-Reply-To: <3FBE76E0.4020009@kaffe.org>
References: <3FBE76E0.4020009@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-2hbadGbyY5H2+RAP1H7n"
Message-Id: <1069487193.2851.696.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 08:46:34 +0100
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Two methods for NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 08:48:35 -0000


--=-2hbadGbyY5H2+RAP1H7n
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Guilhem,

On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote:
> I am continuing the series of patches with that one, it adds two methods=20
> to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale).=20
> They have to be implemented according to Java 1.4.

Thanks for splitting this up in small chunks.
Three small comments:
- You forgot a ChangeLog entry.
- Don't forget to update the copyright year.
- The second comment says 'default locale', should be 'desired locale'.
But besides that it looks fine to me. Please check it in.

(I would like to see us not use a space between the method and the
bracket beginning the argument list. But this class already had that and
jalopy will hopefully catch all this in the future for us.)

Thanks,

Mark


--=-2hbadGbyY5H2+RAP1H7n
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vxRZxVhZCJWr9QwRAnXzAKCWIcKGKRmc9SDsjDXlQcJQm2ewuACdHUwJ
Ib8Ni/52Rco2kptoJpJ8M/E=
=iAgO
-----END PGP SIGNATURE-----

--=-2hbadGbyY5H2+RAP1H7n--




From MAILER-DAEMON Sat Nov 22 03:53:46 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANTWU-0008M4-F2
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 03:53:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANTWR-0008Lm-MH
	for classpath@gnu.org; Sat, 22 Nov 2003 03:53:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANTVu-0007oO-Ue
	for classpath@gnu.org; Sat, 22 Nov 2003 03:53:42 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANTVu-0007o2-Hi
	for classpath@gnu.org; Sat, 22 Nov 2003 03:53:10 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANSXv-0000tT-00; Sat, 22 Nov 2003 08:51:11 +0100
From: Mark Wielaard <mark@klomp.org>
To: raif@fl.net.au
In-Reply-To: <200311220906.37004.raif@fl.net.au>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1yY5YqyuLLHJ/yQFsJXH"
Message-Id: <1069487500.2856.702.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 08:51:40 +0100
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 08:53:44 -0000


--=-1yY5YqyuLLHJ/yQFsJXH
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-21 at 23:06, Raif S. Naffah wrote:
> jalopy is able to handle grouping, and sorting, of class elements=20
> (e.g.static field and initialisers, instance fields, constructors,=20
> etc...) and separating them with a 1-line separator (2 with a blank=20
> line followup).
>=20
> how (strongly) do people feel about enabling this?

I don't like that very much. I like it when methods are grouped
logically (same kind of methods) together. Although simply adding all
constructors, static fields and field members together is probably OK.

Cheers,

Mark

--=-1yY5YqyuLLHJ/yQFsJXH
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/vxWMxVhZCJWr9QwRAmm9AKCAR0HvmLLfAmORDUU96qREpwFJ3QCeLrIR
5NDeiC5/nWzh980o2coD0Vc=
=D9qy
-----END PGP SIGNATURE-----

--=-1yY5YqyuLLHJ/yQFsJXH--




From MAILER-DAEMON Sat Nov 22 08:10:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANXWN-0001zU-V3
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 08:09:55 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANXWC-0001no-9Q
	for classpath@gnu.org; Sat, 22 Nov 2003 08:09:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANXVN-0000jz-1n
	for classpath@gnu.org; Sat, 22 Nov 2003 08:09:25 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANXUJ-0008OL-IA
	for classpath@gnu.org; Sat, 22 Nov 2003 08:07:47 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 22 Nov 2003 13:06:07 +0100
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] Fix for Hashtable contains blowing up the stack
Thread-Index: AcOwwapp6a35z56FSpiYDQgwZTqq8wALptEw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Mark Wielaard" <mark@klomp.org>,
	"Dalibor Topic" <robilad@kaffe.org>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 13:09:53 -0000

Mark Wielaard wrote:
> On Fri, 2003-11-21 at 20:48, Dalibor Topic wrote:
> > > this is a typical java library bug, and I've both=20
> produced and fixed a=20
> > > couple of those myself ;) You get an infinite recursion=20
> through calling=20
> > > overridden methods. Class A in library implements public=20
> methods b and=20
> > > c, where b internally (and of course undocumentedly ;)=20
> calls c. Class B=20
> > > from some user of the library extends A and overrides c=20
> to call b. When=20
> > > the user calls the method b of class B it goes straight=20
> into an infinite=20
> > > loop.
>=20
> Ugh. That is nasty. Especially since when you override=20
> Hashtable it is a natural thing to do since contains and
> containsValue are specced to do the same thing.

The fix is actually incorrect. containsValue() should call contains()
because containsValue() is a new method (since 1.2) and contains()
exists since 1.0. Older code may have overridden contains() and this
should work with newer code that calls containsValue().

As I've argued before, in cases such as these (multiple virtual methods
that do the same thing), we must use the same delegation as the Sun
implementation to be compatible.

Regards,
Jeroen



From MAILER-DAEMON Sat Nov 22 08:54:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANYD8-0005To-Lj
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 08:54:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANYD5-0005Tb-Jy
	for classpath@gnu.org; Sat, 22 Nov 2003 08:54:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANYCY-0005Pg-3a
	for classpath@gnu.org; Sat, 22 Nov 2003 08:54:01 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANYCX-0005Pd-Nn
	for classpath@gnu.org; Sat, 22 Nov 2003 08:53:29 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANXEY-0001P2-00; Sat, 22 Nov 2003 13:51:30 +0100
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Gf9e583m4bQy8D2ttd8V"
Message-Id: <1069505518.2856.724.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 13:51:59 +0100
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 13:54:04 -0000


--=-Gf9e583m4bQy8D2ttd8V
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote:
> The fix is actually incorrect. containsValue() should call contains()
> because containsValue() is a new method (since 1.2) and contains()
> exists since 1.0. Older code may have overridden contains() and this
> should work with newer code that calls containsValue().

Urgh. Yes, you are right. Wrote an additional test case for this:
gnu.testlet.java.util.Hashtable.ContainsHash (it currently fails).

> As I've argued before, in cases such as these (multiple virtual methods
> that do the same thing), we must use the same delegation as the Sun
> implementation to be compatible.

Problem is that this is not always easy to know.
So we depend on bug reports and then have to write a Mauve test if we
think that following such behavior is beneficial. But the "newer calls
older" is a guideline that will mostly work (I hope).

BTW. People might want the read what Jeroen wrote earlier about it:
http://weblog.ikvm.net/commentview.aspx/8b14c003-e16a-4e99-a52e-ad776cbb8cb=
f
His blog entires (and the people who comment on it) are very nice BTW.
I am always a bit sad when there is a week without a new entry.

Cheers,

Mark

--=-Gf9e583m4bQy8D2ttd8V
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/v1vuxVhZCJWr9QwRAmPIAKCbw1BSvrNfoE+ljUU1KAqkO7fyYwCdGdg4
F+xK3q/+ZJI5AEv6R3DeSGQ=
=Jxg3
-----END PGP SIGNATURE-----

--=-Gf9e583m4bQy8D2ttd8V--




From MAILER-DAEMON Sat Nov 22 10:37:03 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANZok-00005b-Rt
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:37:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANZog-0008V0-F4
	for classpath@gnu.org; Sat, 22 Nov 2003 10:36:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANZoA-00082n-NJ
	for classpath@gnu.org; Sat, 22 Nov 2003 10:36:57 -0500
Received: from [204.127.198.35] (helo=rwcrmhc11.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANZoA-00082b-EQ
	for classpath@gnu.org; Sat, 22 Nov 2003 10:36:26 -0500
Received: from byu.net (c-24-10-254-137.client.comcast.net[24.10.254.137])
	by comcast.net (rwcrmhc11) with SMTP id <2003112214345501300il9che>
	(Authid: ericblake); Sat, 22 Nov 2003 14:34:55 +0000
Message-ID: <3FBF7444.7040306@byu.net>
Date: Sat, 22 Nov 2003 07:35:48 -0700
From: Eric Blake <ebb9@byu.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
	<1069487500.2856.702.camel@elsschot.wildebeest.org>
In-Reply-To: <1069487500.2856.702.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: raif@fl.net.au, Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:37:01 -0000

I've noticed two general styles of 'sorting' in Classpath sources.  Both 
styles separate the metadata types (all fields are listed, followed by member 
classes, constructors, methods).  Within those groupings, one style sorts all 
methods alphabetically, and the other sorts methods according to the order 
which they are listed in Sun's documentation (which tends to be, but isn't 
always, by common functionality).  There is also the question of whether 
implementation-only members (private or default access) should be mixed in 
with exposed members (protected or public), or whether they come later.

I don't have a general opinion - alphabetical sorting makes it easier to find 
a method when just reading a file, but following Sun's sorting makes it easier 
to compare a method to Sun's documentation of how it should behave.  Either 
choice is fine with me, especially since emacs has wrap-around searching.  But 
if Jalopy can make the decision easier, by enforcing a sorting style, it might 
be worth considering.

Mark Wielaard wrote:
> Hi,
> 
> On Fri, 2003-11-21 at 23:06, Raif S. Naffah wrote:
> 
>>jalopy is able to handle grouping, and sorting, of class elements 
>>(e.g.static field and initialisers, instance fields, constructors, 
>>etc...) and separating them with a 1-line separator (2 with a blank 
>>line followup).
>>
>>how (strongly) do people feel about enabling this?
> 
> 
> I don't like that very much. I like it when methods are grouped
> logically (same kind of methods) together. Although simply adding all
> constructors, static fields and field members together is probably OK.
> 
> Cheers,
> 
> Mark

-- 
Someday, I might put a cute statement here.

Eric Blake             ebb9@byu.net




From MAILER-DAEMON Sat Nov 22 10:40:38 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANZsE-0001so-GD
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:40:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANZsB-0001pV-RM
	for classpath@gnu.org; Sat, 22 Nov 2003 10:40:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANZrf-0001fg-RW
	for classpath@gnu.org; Sat, 22 Nov 2003 10:40:34 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANZrO-0001Tn-Ax
	for classpath@gnu.org; Sat, 22 Nov 2003 10:39:46 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix4-1.free.fr (Postfix) with ESMTP
	id 2115FFC029; Sat, 22 Nov 2003 15:38:19 +0100 (CET)
Message-ID: <3FBF74D4.30707@kaffe.org>
Date: Sat, 22 Nov 2003 15:38:12 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FBE76E0.4020009@kaffe.org>
	<1069487193.2851.696.camel@elsschot.wildebeest.org>
In-Reply-To: <1069487193.2851.696.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Two methods for NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:40:36 -0000

Mark Wielaard wrote:

>Hi Guilhem,
>
>On Fri, 2003-11-21 at 21:34, Guilhem Lavaux wrote:
>  
>
>>I am continuing the series of patches with that one, it adds two methods 
>>to NumberFormat: getIntegerInstance() and getIntegerInstance(Locale). 
>>They have to be implemented according to Java 1.4.
>>    
>>
>
>Thanks for splitting this up in small chunks.
>Three small comments:
>- You forgot a ChangeLog entry.
>
Well not completely forgotten but I was between two tasks... ;-)

>- Don't forget to update the copyright year.
>
Ok.

>- The second comment says 'default locale', should be 'desired locale'.
>But besides that it looks fine to me. Please check it in.
>  
>
Too many copy-paste... ;-)

>(I would like to see us not use a space between the method and the
>bracket beginning the argument list. But this class already had that and
>jalopy will hopefully catch all this in the future for us.)
>  
>
I've just made a probabilistic choice according to what I've seen in 
some other files. It seemed to me that gcc-java files tends to have that 
sort of practices. If you say it's wrong it doesn't matter I'll fix this.

Regards,
Guilhem.





From MAILER-DAEMON Sat Nov 22 10:47:16 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANZyd-0005HY-U3
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:47:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANZyb-0005HT-S6
	for classpath@gnu.org; Sat, 22 Nov 2003 10:47:13 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANZy4-0004wl-My
	for classpath@gnu.org; Sat, 22 Nov 2003 10:47:11 -0500
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANZy4-0004vm-4L
	for classpath@gnu.org; Sat, 22 Nov 2003 10:46:40 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-65-138.ewetel.net
	[80.228.65.138])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id hAMEixIw021395;
	Sat, 22 Nov 2003 15:45:00 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1ANZ0d-0007Dp-00; Sat, 22 Nov 2003 15:45:15 +0100
Date: Sat, 22 Nov 2003 15:45:15 +0100
From: Michael Koch <konqueror@gmx.de>
To: Eric Blake <ebb9@byu.net>
Message-ID: <20031122144515.GA27696@mail.konqueror.de>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
	<1069487500.2856.702.camel@elsschot.wildebeest.org>
	<3FBF7444.7040306@byu.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FBF7444.7040306@byu.net>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, raif@fl.net.au,
	Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:47:14 -0000

On Sat, Nov 22, 2003 at 07:35:48AM -0700, Eric Blake wrote:
> I've noticed two general styles of 'sorting' in Classpath sources.  Both 
> styles separate the metadata types (all fields are listed, followed by 
> member classes, constructors, methods).  Within those groupings, one style 
> sorts all methods alphabetically, and the other sorts methods according to 
> the order which they are listed in Sun's documentation (which tends to be, 
> but isn't always, by common functionality).  There is also the question of 
> whether implementation-only members (private or default access) should be 
> mixed in with exposed members (protected or public), or whether they come 
> later.
> 
> I don't have a general opinion - alphabetical sorting makes it easier to 
> find a method when just reading a file, but following Sun's sorting makes 
> it easier to compare a method to Sun's documentation of how it should 
> behave.  Either choice is fine with me, especially since emacs has 
> wrap-around searching.  But if Jalopy can make the decision easier, by 
> enforcing a sorting style, it might be worth considering.


Serializable classes have to have their fields in the same order as in
in SUNs classes because of serialization issues.


Michael



From MAILER-DAEMON Sat Nov 22 10:55:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANa6H-0008IC-7f
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:55:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANa6E-0008HU-RI
	for classpath@gnu.org; Sat, 22 Nov 2003 10:55:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANa5i-0008E2-3b
	for classpath@gnu.org; Sat, 22 Nov 2003 10:55:05 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANa5h-0008Dz-N7
	for classpath@gnu.org; Sat, 22 Nov 2003 10:54:33 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANZ7k-0001dr-00; Sat, 22 Nov 2003 15:52:37 +0100
From: Mark Wielaard <mark@klomp.org>
To: Guilhem Lavaux <guilhem@kaffe.org>
In-Reply-To: <3FBF74D4.30707@kaffe.org>
References: <3FBE76E0.4020009@kaffe.org>
	<1069487193.2851.696.camel@elsschot.wildebeest.org>
	<3FBF74D4.30707@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-qJ8YiH/kSJxRiGQkgaF0"
Message-Id: <1069512785.2855.733.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 15:53:05 +0100
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Two methods for NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:55:07 -0000


--=-qJ8YiH/kSJxRiGQkgaF0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 15:38, Guilhem Lavaux wrote:
> >(I would like to see us not use a space between the method and the
> >bracket beginning the argument list. But this class already had that and
> >jalopy will hopefully catch all this in the future for us.)
> > =20
> >
> I've just made a probabilistic choice according to what I've seen in=20
> some other files. It seemed to me that gcc-java files tends to have that=20
> sort of practices. If you say it's wrong it doesn't matter I'll fix this.

It is not wrong (for now). Just follow what the file already does.
Jalopy will fix this for us soon anyway :)

Cheers,

Mark

--=-qJ8YiH/kSJxRiGQkgaF0
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/v3hRxVhZCJWr9QwRAo92AJ0SjiU0JbthkQKvGfju20cLlpT0HACfWT4x
HbGSl0u/sCMs6PLDzlivYZA=
=tp8z
-----END PGP SIGNATURE-----

--=-qJ8YiH/kSJxRiGQkgaF0--




From MAILER-DAEMON Sat Nov 22 10:55:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANa6P-0008KN-K4
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:55:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANa6M-0008Jg-Mw
	for classpath@gnu.org; Sat, 22 Nov 2003 10:55:14 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANa5q-0008EU-QU
	for classpath@gnu.org; Sat, 22 Nov 2003 10:55:13 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANa5q-0008ER-DK
	for classpath@gnu.org; Sat, 22 Nov 2003 10:54:42 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix4-1.free.fr (Postfix) with ESMTP
	id DFB14FBFFD; Sat, 22 Nov 2003 15:53:15 +0100 (CET)
Message-ID: <3FBF7854.6060008@kaffe.org>
Date: Sat, 22 Nov 2003 15:53:08 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FBE65C4.8040701@kaffe.org> <3FBEA22A.3030801@kaffe.org>
	<1069485403.2854.671.camel@elsschot.wildebeest.org>
In-Reply-To: <1069485403.2854.671.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Compliance of DecimalFormatSymbols
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:55:15 -0000

Mark Wielaard wrote:

>At your service!
>
>- ChangeLog entries should start with:
>  date <two spaces> Name <two spaces> email.
>- Just <one space> between filename and (field/method)
>- Entries are full sentences with starting capital and ending dot.
>
>2003-11-21  Guilhem Lavaux  <guilhem@kaffe.org>
>
>	* java/text/DecimalFormatSymbols.java (locale): New field.
>	(DecimalFormatSymbols (Locale)): Set locale.
>	(serialVersionOnStream): Upgraded to number 2.
>	(readObject): Assign locale if it wasn't by the serializer.
>
>Guilhem, please feel free to try out your new cvs commit powers with
>these changes.
>  
>
Thanks, I was needing some sort of real policy for that. I'm now using 
my new powers to commit these changes.

Cheers,
Guilhem.




From MAILER-DAEMON Sat Nov 22 10:59:03 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANaA3-0000LD-Gk
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 10:59:03 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANaA1-0000KN-2Q
	for classpath@gnu.org; Sat, 22 Nov 2003 10:59:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANa9U-0000IS-KA
	for classpath@gnu.org; Sat, 22 Nov 2003 10:58:59 -0500
Received: from [204.127.198.39] (helo=rwcrmhc13.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANa9U-0000IP-AZ
	for classpath@gnu.org; Sat, 22 Nov 2003 10:58:28 -0500
Received: from byu.net (c-24-10-254-137.client.comcast.net[24.10.254.137])
	by comcast.net (rwcrmhc13) with SMTP id <2003112214570201500pni2ge>
	(Authid: ericblake); Sat, 22 Nov 2003 14:57:02 +0000
Message-ID: <3FBF7973.2030104@byu.net>
Date: Sat, 22 Nov 2003 07:57:55 -0700
From: Eric Blake <ebb9@byu.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
	<1069487500.2856.702.camel@elsschot.wildebeest.org>
	<3FBF7444.7040306@byu.net>
	<20031122144515.GA27696@mail.konqueror.de>
In-Reply-To: <20031122144515.GA27696@mail.konqueror.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, raif@fl.net.au,
	Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 15:59:01 -0000

Michael Koch wrote:
> 
> Serializable classes have to have their fields in the same order as in
> in SUNs classes because of serialization issues.

I thought we already had the style rule that all serialized classes provide an 
explicit serialVersionUID - because we cannot depend on the compiler to 
generate the same serial version as Sun.  Case in point: when a class literal 
appears in the class, Sun emits a one-argument class$ method, but jikes emits 
a two-argument version; this affects the serial version.  Also, as long as the 
serial version is correct, deserialization is name-based (not offset-based). 
Therefore, field ordering does not matter, so long as we provide the explicit UID.

-- 
Someday, I might put a cute statement here.

Eric Blake             ebb9@byu.net




From MAILER-DAEMON Sat Nov 22 11:03:32 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANaEN-0001XU-Om
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 11:03:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANaEL-0001WR-Bl
	for classpath@gnu.org; Sat, 22 Nov 2003 11:03:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANaDp-0001Kc-F6
	for classpath@gnu.org; Sat, 22 Nov 2003 11:03:28 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANaDp-0001KP-1S
	for classpath@gnu.org; Sat, 22 Nov 2003 11:02:57 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-65-138.ewetel.net
	[80.228.65.138])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id hAMF1ETR011630;
	Sat, 22 Nov 2003 16:01:14 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1ANZGM-0007EU-00; Sat, 22 Nov 2003 16:01:30 +0100
Date: Sat, 22 Nov 2003 16:01:30 +0100
From: Michael Koch <konqueror@gmx.de>
To: Eric Blake <ebb9@byu.net>
Message-ID: <20031122150130.GB27696@mail.konqueror.de>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
	<1069487500.2856.702.camel@elsschot.wildebeest.org>
	<3FBF7444.7040306@byu.net>
	<20031122144515.GA27696@mail.konqueror.de>
	<3FBF7973.2030104@byu.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FBF7973.2030104@byu.net>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, raif@fl.net.au,
	Classpath Discussion Mailing List <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 16:03:30 -0000

On Sat, Nov 22, 2003 at 07:57:55AM -0700, Eric Blake wrote:
> Michael Koch wrote:
> >
> >Serializable classes have to have their fields in the same order as in
> >in SUNs classes because of serialization issues.
> 
> I thought we already had the style rule that all serialized classes provide 
> an explicit serialVersionUID - because we cannot depend on the compiler to 
> generate the same serial version as Sun.  Case in point: when a class 
> literal appears in the class, Sun emits a one-argument class$ method, but 
> jikes emits a two-argument version; this affects the serial version.  Also, 
> as long as the serial version is correct, deserialization is name-based 
> (not offset-based). Therefore, field ordering does not matter, so long as 
> we provide the explicit UID.

Thx for clarifying this. It wasnt clear to me. I thought its always
offset based.


Michael



From MAILER-DAEMON Sat Nov 22 11:05:17 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANaG4-00025U-Bd
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 11:05:16 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANaFz-00024k-1D
	for classpath@gnu.org; Sat, 22 Nov 2003 11:05:11 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANaFS-0001xG-5P
	for classpath@gnu.org; Sat, 22 Nov 2003 11:05:09 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANaFR-0001x5-QB
	for classpath@gnu.org; Sat, 22 Nov 2003 11:04:37 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANZHM-0001jl-00; Sat, 22 Nov 2003 16:02:32 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <20031122144515.GA27696@mail.konqueror.de>
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au>
	<1069487500.2856.702.camel@elsschot.wildebeest.org>
	<3FBF7444.7040306@byu.net> <20031122144515.GA27696@mail.konqueror.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-l5GndLCWsvQHAUJPEW7y"
Message-Id: <1069513381.2851.740.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 22 Nov 2003 16:03:01 +0100
Cc: raif@fl.net.au, Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 16:05:11 -0000


--=-l5GndLCWsvQHAUJPEW7y
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 15:45, Michael Koch wrote:
> Serializable classes have to have their fields in the same order as in
> in SUNs classes because of serialization issues.

I didn't know that. What are the problems precisely?
For calculation of the stream unique identifiers (serialVersionUIDs)
each field of the class is used sorted by field name. And for an
ObjectIn/OutputStream order of the field array shouldn't matter.

Cheers,

Mark

--=-l5GndLCWsvQHAUJPEW7y
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/v3qlxVhZCJWr9QwRAoetAKClUzW7FaQHjrzbYRhoRzYKX642YwCfQsDx
U2LwUnWmc74JXgc55tLVLOI=
=P5xV
-----END PGP SIGNATURE-----

--=-l5GndLCWsvQHAUJPEW7y--




From MAILER-DAEMON Sat Nov 22 13:25:02 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANcRJ-0001WH-Hy
	for mharc-classpath@gnu.org; Sat, 22 Nov 2003 13:25:01 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANcRG-0001Vk-GW
	for classpath@gnu.org; Sat, 22 Nov 2003 13:24:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANcQk-0001Qb-D0
	for classpath@gnu.org; Sat, 22 Nov 2003 13:24:57 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANcQj-0001QV-Nd
	for classpath@gnu.org; Sat, 22 Nov 2003 13:24:25 -0500
Received: from [192.168.1.33] (220.20.dyn-adsl.customer.ch.easynet.net
	[217.8.220.20])
	by smtp1.mail.ch.easynet.net (Postfix) with ESMTP id 8839949FD0
	for <classpath@gnu.org>; Sat, 22 Nov 2003 18:22:58 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Sat, 22 Nov 2003 18:21:46 +0100
Message-Id: <20031122172146.1291@smtp.mail.ch.easynet.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 18:25:00 -0000

Dear co-hackers,

having read quite a bit of Classpath code, I'd like to express two wishes.

First, please write more test cases. I agree that it is boring, dumb, and
taxing; testing slows down development. But it's also the most reliable
way to make sure that code really works. If anyone needs to change our
code in five years, they'll want to know whether their change has any
serious impact. Without a large test suite, this is close to impossible.

Second, please write understandable documentation for every single
method. Developers should be able to create free programs without
referring to external documents. These could disappear at any time.

In other words, I think that we really need to improve the quality of our
code. Building a sound foundation for others is not the same as some fun
week-end hack.

Thank you all,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Sun Nov 23 08:44:16 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANuX9-0004ar-NF
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 08:44:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANuX7-0004ZE-3W
	for classpath@gnu.org; Sun, 23 Nov 2003 08:44:13 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANuWa-0004NY-1n
	for classpath@gnu.org; Sun, 23 Nov 2003 08:44:12 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANuWZ-0004NL-MH
	for classpath@gnu.org; Sun, 23 Nov 2003 08:43:39 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id C029B621EC; Sun, 23 Nov 2003 12:41:53 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 06524-09; Sun, 23 Nov 2003 12:41:53 +0000 (GMT)
Received: from reali.dnsalias.net (adsl-212-41-93-116.solnet.ch
	[212.41.93.116]) by mail01.solnet.ch (Postfix) with ESMTP
	id 03046621E6; Sun, 23 Nov 2003 12:41:52 +0000 (GMT)
Received: from pcprr
	(192-168-001-003-at-home-your-network.privateiprange.solnet.ch
	[192.168.1.3]) by reali.dnsalias.net (Postfix) with SMTP
	id 46C4320277; Sun, 23 Nov 2003 13:32:10 +0100 (CET)
Message-ID: <003701c3b1bf$49e8cf90$0301a8c0@pcprr>
From: "Patrik Reali" <reali@acm.org>
To: "Sascha Brawer" <brawer@dandelis.ch>, "GNU Classpath" <classpath@gnu.org>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
Date: Sun, 23 Nov 2003 13:42:42 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Virus-Scanned: by SolNet
Cc: 
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 13:44:14 -0000

Hi Sascha,

I completely agree and support your wishes! In fact, it would be nice if the
whole classpath and its documentation (javadoc) would be rebuilt on a
regular base and offered through the website.

I disagree on one point: testing doesn't slow down development. It may be
boring, but it is like a safety net that prevents developers from comitting
buggy code and allow to detect errors early (and thus much faster) when they
are inserted.

-Patrik
--------
Patrik Reali
http://www.reali.ch/~patrik/
http://www.oberon.ethz.ch/jaos


> Dear co-hackers,
>
> having read quite a bit of Classpath code, I'd like to express two wishes.
>
> First, please write more test cases. I agree that it is boring, dumb, and
> taxing; testing slows down development. But it's also the most reliable
> way to make sure that code really works. If anyone needs to change our
> code in five years, they'll want to know whether their change has any
> serious impact. Without a large test suite, this is close to impossible.
>
> Second, please write understandable documentation for every single
> method. Developers should be able to create free programs without
> referring to external documents. These could disappear at any time.
>
> In other words, I think that we really need to improve the quality of our
> code. Building a sound foundation for others is not the same as some fun
> week-end hack.
>
> Thank you all,
>
> -- Sascha
>
> Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/
>
>
>
>
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath
>
>




From MAILER-DAEMON Sun Nov 23 08:52:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANufP-00029p-Id
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 08:52:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANufM-00027d-Nd
	for classpath@gnu.org; Sun, 23 Nov 2003 08:52:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANuep-0001wV-Bj
	for classpath@gnu.org; Sun, 23 Nov 2003 08:52:42 -0500
Received: from [196.25.240.76] (helo=ctb-mesg4.saix.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANueo-0001rb-8y
	for classpath@gnu.org; Sun, 23 Nov 2003 08:52:10 -0500
Received: from [192.168.1.5] (rbmf-ip-nas-1-p01.telkom-ipnet.co.za
	[155.239.96.1]) by ctb-mesg4.saix.net (Postfix) with ESMTP
	id 23A62AA84; Sun, 23 Nov 2003 14:50:39 +0200 (SAST)
From: John Leuner <jewel@pixie.co.za>
To: =?UTF-8?Q?=E9=87=91_=E6=9D=B1?= =?UTF-8?Q?=E4=B9=85?= <kdon@prism.co.jp>
In-Reply-To: <C1D121A526FE6A45A6CEA40AD1D99BECF423F0@EXC001.prism.co.jp>
References: <C1D121A526FE6A45A6CEA40AD1D99BECF423F0@EXC001.prism.co.jp>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-LshRG+YbP445PbMzyBAc"
Organization: 
Message-Id: <1069591413.8527.13.camel@cmalu>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.4 
Date: 23 Nov 2003 14:48:37 +0200
Cc: jazzlib-developers@lists.sourceforge.net, classpath@gnu.org
Subject: Classpath licensing (Re: About the java.util.zip project)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 13:52:45 -0000


--=-LshRG+YbP445PbMzyBAc
Content-Type: text/plain; charset=iso-8859-13
Content-Transfer-Encoding: quoted-printable

I am copying this to the jazzlib and classpath MLs to get some other
peoples' opinions on the Classpath license and how it should apply in a
case like this.

> My name is Dongku, Kim. I am a Japanese developer.

Hi

> My company makes commercial software. And, I work to make a module
> which makes a zip file from files by Java.
>=20
> So, I want to use your library. But I read the license at the
> homepage(http://jazzlib.sourceforge.net/).
>=20
> I think the license on your homepage means that I can use the library
> freely and I don=FFt need to obey the GPL license=20

No, the license says you MUST obey the GPL with one special exception
...

> if I use the library only by means of called the library to make a
> executable.

If you combine jazzlib "with independent modules to produce an
executable" you can "copy and distribute the resulting executable under
terms of your choice".

So you can use jazzlib in your program without changing the license of
your commercial software.
=20
>=20
> For sure, if you can give me an answer for some questions, I am very
> happy for it.
>=20
> 1) If I use your library without change(source code) to make a
> commercial ziputility, should I open my ziputility source code?

The license says you must combine with "independent modules". If you
write a commercial zip utility I am not sure that this other code will
be "an independent module".

> 2) If I should open my source code, is there other method not to do
> this? For example, we can pay for the license.

No, I doubt this is possible.

> 3) If I use your library without change(source code) to make a
> commercial ziputility, what I should do not to violate your license?

I am not sure how to answer that, perhaps another developer can answer
this question?

--=20
John Leuner <jewel@pixie.co.za>


--=-LshRG+YbP445PbMzyBAc
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA/wKt1XrnnKiKKOuQRArhqAKCENiVAvd6HFFP7i0puW7FT3PVbIwCeNvMR
Hj6Wxqj6PHfYgROYcgQ2zT0=
=5jzf
-----END PGP SIGNATURE-----

--=-LshRG+YbP445PbMzyBAc--




From MAILER-DAEMON Sun Nov 23 09:34:31 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANvJn-0005BX-2O
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 09:34:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANvJi-0005AE-2s
	for classpath@gnu.org; Sun, 23 Nov 2003 09:34:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANvJB-00053A-0p
	for classpath@gnu.org; Sun, 23 Nov 2003 09:34:25 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1ANvJA-00052a-MT
	for classpath@gnu.org; Sun, 23 Nov 2003 09:33:52 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1ANuLc-0005tQ-OG
	for classpath@gnu.org; Sun, 23 Nov 2003 08:32:20 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANuL7-0004Ti-00
	for <classpath@gnu.org>; Sun, 23 Nov 2003 14:31:49 +0100
From: Mark Wielaard <mark@klomp.org>
To: GNU Classpath <classpath@gnu.org>
In-Reply-To: <20031122172146.1291@smtp.mail.ch.easynet.net>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-wjtgRzceT/Gq8mEDF9sY"
Message-Id: <1069594338.2864.1077.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 23 Nov 2003 14:32:18 +0100
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 14:34:26 -0000


--=-wjtgRzceT/Gq8mEDF9sY
Content-Type: multipart/mixed; boundary="=-/srdEnWTYLRCT3jFBiDS"


--=-/srdEnWTYLRCT3jFBiDS
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-22 at 18:21, Sascha Brawer wrote:
> having read quite a bit of Classpath code, I'd like to express two wishes=
.
>=20
> First, please write more test cases. [..]
> Second, please write understandable documentation [...]
>
> In other words, I think that we really need to improve the quality of our
> code. Building a sound foundation for others is not the same as some fun
> week-end hack.

Thanks for raising these issues. Between you and Dalibor policing the
code so thoroughly I feel less and less need to play the bad evil
maintainer :)

I agree with you completely. But I feel we are going in the right
direction. Although I admit that creating more tests and documentation
is a slow process. There are a couple of things we should do to make
this easier (and more fun!):

- More peer code-review. It is really good to see that people post their
  patches to the mailing list so others can comment on it. We probably
  need a new list for it (classpath-patches) and a good set of rules of
  who and what kind of changes can be approved/denied or asked for
  improvements. I personally find peer review discussions very valuable,
  even though people often point out my mistaken assumptions.

- Always adding mauve tests for new code or patches. Mauve tests are
  extremely simple to write and give you immediate feedback. The amount
  of tests is also big enough to catch things you might not have thought
  would be changed by your patch. But as you point out there are areas
  with not very much or even no tests at all.
  A few problems with mauve currently are:
  - It is a pain to setup. We need to get rid of the auto* magic.
  - It is a bit to fragile. A hanging test or no network can stop
    everything. I have a simple shell/bash based wrapper to work around
    that.
  - There are still to many false positives.
  - Mauve proper doesn't have a good XFAILs mechanism.
    gcj does have something like that (although it doesn't detect when a
    XFAIL turns into a XPASS).
  All the above makes spotting regressions not easy (some of the
  recent network/url/connection breakage should have been spotted much
  earlier).

  With a few local patches I currently get for Classpath+Kissme (x86):
  182 of 10352 tests failed
  This includes the patch for GregorianCalendar and merging in
  URLConnection and gnu/java/net/protocol from libgcj. Some outstanding
  java.awt.geom patches and the recent Hashtable fixes that are not yet
  checked in.
  I had to disabling some tests (see attached mauve-kissme file).
  Most of the remaining failures are some char-encoding issues,
  bugs related to relection,  java.text.RuleBasedCollator (for which
  I believe we still have a patch pending) and some
  RoundRectangle2D.intersects failures. Plus a couple of smaller test
  failures.

- Autobuild Classpath, VMs, Mauve and applications regularly.
  Tom Tromey recently posted a list of free software projects that he
  regularly compiles against gcj and for which he runs the tests-suites.
  It would be good to create a classpath-testresults mailinglist and
  post the from a couple of different architectures, compilers, VMs,
  etc. Any volunteers to adapt Tom his scripts and to run this
  regularly?

- Automatic documentation generation. When updates to documentation are
  immediately visible people get much more satisfaction from writing it.
  Current problems are that gjdoc has not had an official release so you
  have to build from CVS. We need a way to add the correct copyright
  notice and distribution terms to each page (note that since we also
  have non-Classpath classes in CVS now in the external directory this
  is a bit tricky to get correct. gjdoc (at least my setup) does not
  handle all HTML entities correctly. See
  https://savannah.gnu.org/bugs/?func=3Ddetailbug&bug_id=3D4823&group_id=3D=
85
  And as far as I know it doesn't handle embedded images yet.

  Arnaud is currently testing gjdoc and kaffe.
  Although I hope we can fix/use gjdoc it would be nice to have a
  volunteer to check out SinjDoc from the Flex project.
  http://cscott.net/Projects/GJ/#sinjdoc
  - Does it work with gcj/kaffe?
  - Does it produce correct documentation for all of Classpath?

One additional documentation task would be to write a good book/article
on working with GNU Classpath and/or gcj/kaffe for free software
writers. This should be an overview of what is available now, how to
install it, writing hello world and more cookbook like examples with a
overview of the current packages available (when to use what for which
kind of task). Most of the articles/books about writing programs in the
java programming language and/or libraries are about proprietary systems
which make all kind of assumptions that are not appropriate when working
on a free system.

I want to do it all, but I am terribly slow :{
So volunteers for all of the above tasks are welcome!
I am currently concentrating on cleaning up Mauve and preparing the 0.07
snapshot for next week.

Cheers,

Mark

--=-/srdEnWTYLRCT3jFBiDS
Content-Disposition: inline; filename=mauve-kissme
Content-Type: text/plain; name=mauve-kissme; charset=iso-8859-1
Content-Transfer-Encoding: base64

IyBDb25maWcgZmlsZSB0aGF0IHRlbGxzIG1hdXZlIGFib3V0IHRoZSBga2lzc21lJyB0YWcuDQpK
REsxLjANCkpESzEuMQ0KSkRLMS4yDQpKREsxLjMNCkpESzEuNA0KSkxTMS4wDQpKTFMxLjENCkpM
UzEuMg0KSkRCQzEuMA0KSkRCQzIuMA0KDQojIFRoaXMgdGVzdCBzZXRzIHRoZSBKVk0ncyBTb2Nr
ZXRJbXBsIGZhY3RvcnkgdG8gYSBkdW1teSBmYWN0b3J5IHRoYXQNCiMgYnJlYWtzIGFueSBmb2xs
b3dpbmcgdGVzdHMgdGhhdCB0ZXN0IG9yIHVzZSBzb2NrZXRzLg0KIWphdmEubmV0LlNvY2tldC5z
ZXRTb2NrZXRJbXBsRmFjdG9yeQ0KDQojIENoYXJhY3Rlci51bmljb2RlIHNlZW1zIHRvIGJlIHZl
cnkgYnJva2VuICh0aGUgdGVzdCkNCiMgRG9lcyBub3QgZ2l2ZSBtZWFuaW5nZnVsbCB0ZXN0IHJl
c3VsdHMgYXQgdGhlIG1vbWVudC4NCiFqYXZhLmxhbmcuQ2hhcmFjdGVyLnVuaWNvZGUNCg0KIyBU
aGVzZSBhcmUgYWxtb3N0IGNlcnRhaW5seSBidWdneSB0ZXN0IGNhc2VzLg0KIyBUaGUgYmVoYXZp
b3VyIG9mIHRoZSBnYXJiYWdlIGNvbGxlY3RvciBjYW5ub3QgYmUgcHJlZGljdGVkLg0KIyAoTm90
ZTogdHJhaWxpbmcgJy4nIGlzIHRvIGF2b2lkIGRpc2FibGluZyB0aGUgcmVmbGVjdCB0ZXN0Y2Fz
ZXMuKQ0KIWphdmEubGFuZy5yZWYuDQoNCiMgQ3Jhc2hlcyB3aGVuIHRoZSB0ZXN0Y2FzZSBpcyBj
b21waWxlZCB3aXRoIGdjaiAoYnV0IG5vdCBqaWtlcyAxLjE2IG9yIA0KIyBKREsgMS40LjAgamF2
YWMpDQojIWphdmEubGFuZy5NYXRoLm1pbg0KDQojIENyYXNoIQ0KIWphdmEubGFuZy5yZWZsZWN0
LkFycmF5Lm5ld0luc3RhbmNlDQoNCiMgU3R1cGlkIHNlY3VyaXR5IG1hbmFnZXIgZmFpbHVyZXMu
DQohamF2YS5pby5GaWxlLnNlY3VyaXR5DQoNCiMgSGFuZ3MNCiFqYXZhLmxhbmcuVGhyZWFkLmpv
aW4NCiFqYXZhLm5ldC5EYXRhZ3JhbVNvY2tldC5EYXRhZ3JhbVNvY2tldFRlc3QNCg==

--=-/srdEnWTYLRCT3jFBiDS--

--=-wjtgRzceT/Gq8mEDF9sY
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/wLbixVhZCJWr9QwRAjNvAKCtA0oegA7tIMKGaQ+fgSwAN5k8RACaA+6b
Y+sXUjXQu3gFn0CQl9p+TXE=
=2Wb0
-----END PGP SIGNATURE-----

--=-wjtgRzceT/Gq8mEDF9sY--




From MAILER-DAEMON Sun Nov 23 09:34:57 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANvKA-0005HQ-Lp
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 09:34:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANvK2-0005G8-JI
	for classpath@gnu.org; Sun, 23 Nov 2003 09:34:46 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANvJU-00058Q-Sm
	for classpath@gnu.org; Sun, 23 Nov 2003 09:34:44 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1ANvJU-00054w-8j
	for classpath@gnu.org; Sun, 23 Nov 2003 09:34:12 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1ANuLy-0005vZ-SU
	for classpath@gnu.org; Sun, 23 Nov 2003 08:32:43 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANuLQ-0004To-00; Sun, 23 Nov 2003 14:32:08 +0100
From: Mark Wielaard <mark@klomp.org>
To: Patrik Reali <reali@acm.org>
In-Reply-To: <003701c3b1bf$49e8cf90$0301a8c0@pcprr>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<003701c3b1bf$49e8cf90$0301a8c0@pcprr>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-C/9RJZUVgQ+X+NCByxwQ"
Message-Id: <1069594357.2851.1079.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 23 Nov 2003 14:32:37 +0100
Cc: GNU Classpath <classpath@gnu.org>, Sascha Brawer <brawer@dandelis.ch>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 14:34:47 -0000


--=-C/9RJZUVgQ+X+NCByxwQ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2003-11-23 at 13:42, Patrik Reali wrote:
> I completely agree and support your wishes! In fact, it would be nice if =
the
> whole classpath and its documentation (javadoc) would be rebuilt on a
> regular base and offered through the website.

It has to be hosted on something different then www.gnu.org website for
now. After the compromise a few months ago they are a bit more paranoid
about allowing automatic uploads/updates of files on the server. There
is a new system in place now to make releases of packages on ftp.gnu.org
easier so I can ask again if we can get some sort of automatic upload of
the generated HTML pages to www.gnu.org, but it would be nice if we
already have something in place that works somewhere else.

Would someone be willing to try to set that up?
Could someone host the auto-generated documentation for now?

Cheers,

Mark

--=-C/9RJZUVgQ+X+NCByxwQ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/wLb1xVhZCJWr9QwRAsnkAJ0WCA1183Nz1zTcY3gnoLAqg26dPACePZo0
fUyRJoYksk+ZE8DOv+71luE=
=Hjxf
-----END PGP SIGNATURE-----

--=-C/9RJZUVgQ+X+NCByxwQ--




From MAILER-DAEMON Sun Nov 23 09:55:16 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANvdr-0006K7-JF
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 09:55:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANvdl-0006FM-J1
	for classpath@gnu.org; Sun, 23 Nov 2003 09:55:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANvdD-0005sB-Re
	for classpath@gnu.org; Sun, 23 Nov 2003 09:55:07 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANvdC-0005ra-PW
	for classpath@gnu.org; Sun, 23 Nov 2003 09:54:34 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C3B1C9.2007AE55"
Date: Sun, 23 Nov 2003 14:52:53 +0100
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C69B@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
Thread-Topic: Runtime, VMRuntime split
Thread-Index: AcOxyRcUOGE7c2TGRDK6OP40oBrYrQ==
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "GNU Classpath" <classpath@gnu.org>
Subject: Runtime, VMRuntime split
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 14:55:12 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C3B1C9.2007AE55
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable

Hi,

Attached is a proposed split of java.lang.Runtime into a generic and VM
specific portion. It's not very exciting, just a bunch of native methods
that are moved (and one additional one).

If there are no comments I will commit (or should that wait until after
the 0.07 snapshot?)

BTW, Runtime.java will move from vm/reference/java/lang to java/lang and
VMRuntime.java is a new file in vm/reference/java/lang.

Regards,
Jeroen

------_=_NextPart_001_01C3B1C9.2007AE55
Content-Type: application/octet-stream;
	name="Runtime.java"
Content-Transfer-Encoding: base64
Content-Description: Runtime.java
Content-Disposition: attachment;
	filename="Runtime.java"

LyogUnVudGltZS5qYXZhIC0tIGFjY2VzcyB0byB0aGUgVk0gcHJvY2Vzcw0KICAgQ29weXJpZ2h0
IChDKSAxOTk4LCAyMDAyLCAyMDAzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbg0KDQpUaGlzIGZp
bGUgaXMgcGFydCBvZiBHTlUgQ2xhc3NwYXRoLg0KDQpHTlUgQ2xhc3NwYXRoIGlzIGZyZWUgc29m
dHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCml0IHVuZGVyIHRo
ZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5
DQp0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyLCBvciAoYXQg
eW91ciBvcHRpb24pDQphbnkgbGF0ZXIgdmVyc2lvbi4NCg0KR05VIENsYXNzcGF0aCBpcyBkaXN0
cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQNCldJVEhPVVQg
QU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCk1FUkNI
QU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUg
R05VDQpHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQoNCllvdSBzaG91
bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl
DQphbG9uZyB3aXRoIEdOVSBDbGFzc3BhdGg7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLiAgSWYgbm90
LCB3cml0ZSB0byB0aGUNCkZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTkgVGVtcGxl
IFBsYWNlLCBTdWl0ZSAzMzAsIEJvc3RvbiwgTUENCjAyMTExLTEzMDcgVVNBLg0KDQpMaW5raW5n
IHRoaXMgbGlicmFyeSBzdGF0aWNhbGx5IG9yIGR5bmFtaWNhbGx5IHdpdGggb3RoZXIgbW9kdWxl
cyBpcw0KbWFraW5nIGEgY29tYmluZWQgd29yayBiYXNlZCBvbiB0aGlzIGxpYnJhcnkuICBUaHVz
LCB0aGUgdGVybXMgYW5kDQpjb25kaXRpb25zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGlj
ZW5zZSBjb3ZlciB0aGUgd2hvbGUNCmNvbWJpbmF0aW9uLg0KDQpBcyBhIHNwZWNpYWwgZXhjZXB0
aW9uLCB0aGUgY29weXJpZ2h0IGhvbGRlcnMgb2YgdGhpcyBsaWJyYXJ5IGdpdmUgeW91DQpwZXJt
aXNzaW9uIHRvIGxpbmsgdGhpcyBsaWJyYXJ5IHdpdGggaW5kZXBlbmRlbnQgbW9kdWxlcyB0byBw
cm9kdWNlIGFuDQpleGVjdXRhYmxlLCByZWdhcmRsZXNzIG9mIHRoZSBsaWNlbnNlIHRlcm1zIG9m
IHRoZXNlIGluZGVwZW5kZW50DQptb2R1bGVzLCBhbmQgdG8gY29weSBhbmQgZGlzdHJpYnV0ZSB0
aGUgcmVzdWx0aW5nIGV4ZWN1dGFibGUgdW5kZXINCnRlcm1zIG9mIHlvdXIgY2hvaWNlLCBwcm92
aWRlZCB0aGF0IHlvdSBhbHNvIG1lZXQsIGZvciBlYWNoIGxpbmtlZA0KaW5kZXBlbmRlbnQgbW9k
dWxlLCB0aGUgdGVybXMgYW5kIGNvbmRpdGlvbnMgb2YgdGhlIGxpY2Vuc2Ugb2YgdGhhdA0KbW9k
dWxlLiAgQW4gaW5kZXBlbmRlbnQgbW9kdWxlIGlzIGEgbW9kdWxlIHdoaWNoIGlzIG5vdCBkZXJp
dmVkIGZyb20NCm9yIGJhc2VkIG9uIHRoaXMgbGlicmFyeS4gIElmIHlvdSBtb2RpZnkgdGhpcyBs
aWJyYXJ5LCB5b3UgbWF5IGV4dGVuZA0KdGhpcyBleGNlcHRpb24gdG8geW91ciB2ZXJzaW9uIG9m
IHRoZSBsaWJyYXJ5LCBidXQgeW91IGFyZSBub3QNCm9ibGlnYXRlZCB0byBkbyBzby4gIElmIHlv
dSBkbyBub3Qgd2lzaCB0byBkbyBzbywgZGVsZXRlIHRoaXMNCmV4Y2VwdGlvbiBzdGF0ZW1lbnQg
ZnJvbSB5b3VyIHZlcnNpb24uICovDQoNCnBhY2thZ2UgamF2YS5sYW5nOw0KDQppbXBvcnQgamF2
YS5pby5GaWxlOw0KaW1wb3J0IGphdmEuaW8uSW5wdXRTdHJlYW07DQppbXBvcnQgamF2YS5pby5J
T0V4Y2VwdGlvbjsNCmltcG9ydCBqYXZhLmlvLk91dHB1dFN0cmVhbTsNCmltcG9ydCBqYXZhLnV0
aWwuSGFzaFNldDsNCmltcG9ydCBqYXZhLnV0aWwuSXRlcmF0b3I7DQppbXBvcnQgamF2YS51dGls
LlByb3BlcnRpZXM7DQppbXBvcnQgamF2YS51dGlsLlNldDsNCmltcG9ydCBqYXZhLnV0aWwuU3Ry
aW5nVG9rZW5pemVyOw0KDQovKioNCiAqIFJ1bnRpbWUgcmVwcmVzZW50cyB0aGUgVmlydHVhbCBN
YWNoaW5lLg0KICoNCiAqIEBhdXRob3IgSm9obiBLZWlzZXINCiAqIEBhdXRob3IgRXJpYyBCbGFr
ZSA8ZWJiOUBlbWFpbC5ieXUuZWR1Pg0KICogQGF1dGhvciBKZXJvZW4gRnJpanRlcnMNCiAqLw0K
Ly8gTm8gaWRlYSB3aHkgdGhpcyBjbGFzcyBpc24ndCBmaW5hbCwgc2luY2UgeW91IGNhbid0IGJ1
aWxkIGEgc3ViY2xhc3MhDQpwdWJsaWMgY2xhc3MgUnVudGltZQ0Kew0KICAvKioNCiAgICogVGhl
IGxpYnJhcnkgcGF0aCwgdG8gc2VhcmNoIHdoZW4gbG9hZGluZyBsaWJyYXJpZXMuIFdlIGNhbiBh
bHNvIHNhZmVseSB1c2UNCiAgICogdGhpcyBhcyBhIGxvY2sgZm9yIHN5bmNocm9uaXphdGlvbi4N
CiAgICovDQogIHByaXZhdGUgZmluYWwgU3RyaW5nW10gbGlicGF0aDsNCg0KICAvKioNCiAgICog
VGhlIGN1cnJlbnQgc2VjdXJpdHkgbWFuYWdlci4gVGhpcyBpcyBsb2NhdGVkIGhlcmUgaW5zdGVh
ZCBvZiBpbg0KICAgKiBTeXN0ZW0sIHRvIGF2b2lkIHNlY3VyaXR5IHByb2JsZW1zLCBhcyB3ZWxs
IGFzIGJvb3RzdHJhcCBpc3N1ZXMuDQogICAqIE1ha2Ugc3VyZSB0byBhY2Nlc3MgaXQgaW4gYSB0
aHJlYWQtc2FmZSBtYW5uZXI7IGl0IGlzIHBhY2thZ2UgdmlzaWJsZQ0KICAgKiB0byBhdm9pZCBv
dmVyaGVhZCBpbiBqYXZhLmxhbmcuDQogICAqLw0KICBzdGF0aWMgU2VjdXJpdHlNYW5hZ2VyIHNl
Y3VyaXR5TWFuYWdlcjsNCg0KICAvKioNCiAgICogVGhlIGRlZmF1bHQgcHJvcGVydGllcyBkZWZp
bmVkIGJ5IHRoZSBzeXN0ZW0uIFRoaXMgaXMgbGlrZXdpc2UgbG9jYXRlZA0KICAgKiBoZXJlIGlu
c3RlYWQgb2YgaW4gUnVudGltZSwgdG8gYXZvaWQgYm9vdHN0cmFwIGlzc3VlczsgaXQgaXMgcGFj
a2FnZQ0KICAgKiB2aXNpYmxlIHRvIGF2b2lkIG92ZXJoZWFkIGluIGphdmEubGFuZy4gTm90ZSB0
aGF0IFN5c3RlbSB3aWxsIGFkZCBhDQogICAqIGZldyBtb3JlIHByb3BlcnRpZXMgdG8gdGhpcyBj
b2xsZWN0aW9uLCBidXQgdGhhdCBhZnRlciB0aGF0LCBpdCBpcw0KICAgKiB0cmVhdGVkIGFzIHJl
YWQtb25seS4NCiAgICoNCiAgICogTm8gbWF0dGVyIHdoYXQgY2xhc3MgeW91IHN0YXJ0IGluaXRp
YWxpemF0aW9uIHdpdGgsIGl0IGRlZmVycyB0byB0aGUNCiAgICogc3VwZXJjbGFzcywgdGhlcmVm
b3JlIE9iamVjdC48Y2xpbml0PiB3aWxsIGJlIHRoZSBmaXJzdCBKYXZhIGNvZGUNCiAgICogZXhl
Y3V0ZWQuIEZyb20gdGhlcmUsIHRoZSBib290c3RyYXAgc2VxdWVuY2UsIHVwIHRvIHRoZSBwb2lu
dCB0aGF0DQogICAqIG5hdGl2ZSBsaWJyYXJpZXMgYXJlIGxvYWRlZCAoYXMgb2YgTWFyY2ggMjQs
IHdoZW4gSSB0cmFjZWQgdGhpcw0KICAgKiBtYW51YWxseSkgaXMgYXMgZm9sbG93czoNCiAgICoN
CiAgICogT2JqZWN0LjxjbGluaXQ+IHVzZXMgYSBTdHJpbmcgbGl0ZXJhbCwgcG9zc2libHkgdHJp
Z2dlcmluZyBpbml0aWFsaXphdGlvbg0KICAgKiAgU3RyaW5nLjxjbGluaXQ+IGNhbGxzIFdlYWtI
YXNoTWFwLjxpbml0PiwgdHJpZ2dlcmluZyBpbml0aWFsaXphdGlvbg0KICAgKiAgIEFic3RyYWN0
TWFwLCBXZWFrSGFzaE1hcCwgV2Vha0hhc2hNYXAkMSBoYXZlIG5vIGRlcGVuZGVuY2llcw0KICAg
KiAgU3RyaW5nLjxjbGluaXQ+IGNhbGxzIENhc2VJbnNlbnNpdGl2ZUNvbXBhcmF0b3IuPGluaXQ+
LCB0cmlnZ2VyaW5nDQogICAqICAgICAgaW5pdGlhbGl6YXRpb24NCiAgICogICBDYXNlSW5zZW5z
aXRpdmVDb21wYXJhdG9yIGhhcyBubyBkZXBlbmRlbmNpZXMNCiAgICogT2JqZWN0LjxjbGluaXQ+
IGNhbGxzIFN5c3RlbS5sb2FkTGlicmFyeSwgdHJpZ2dlcmluZyBpbml0aWFsaXphdGlvbg0KICAg
KiAgU3lzdGVtLjxjbGluaXQ+IGNhbGxzIFN5c3RlbS5sb2FkTGlicmFyeQ0KICAgKiAgU3lzdGVt
LmxvYWRMaWJyYXJ5IGNhbGxzIFJ1bnRpbWUuZ2V0UnVudGltZSwgdHJpZ2dlcmluZyBpbml0aWFs
aXphdGlvbg0KICAgKiAgIFJ1bnRpbWUuPGNsaW5pdD4gY2FsbHMgUHJvcGVydGllcy48aW5pdD4s
IHRyaWdnZXJpbmcgaW5pdGlhbGl6YXRpb24NCiAgICogICAgRGljdGlvbmFyeSwgSGFzaHRhYmxl
LCBhbmQgUHJvcGVydGllcyBoYXZlIG5vIGRlcGVuZGVuY2llcw0KICAgKiAgIFJ1bnRpbWUuPGNs
aW5pdD4gY2FsbHMgaW5zZXJ0U3lzdGVtUHJvcGVydGllczsgdGhlIFZNIG11c3QgbWFrZSBzdXJl
DQogICAqICAgICAgdGhhdCB0aGVyZSBhcmUgbm90IGFueSBoYXJtZnVsIGRlcGVuZGVuY2llcw0K
ICAgKiAgIFJ1bnRpbWUuPGNsaW5pdD4gY2FsbHMgUnVudGltZS48aW5pdD4NCiAgICogICAgUnVu
dGltZS48aW5pdD4gY2FsbHMgU3RyaW5nVG9rZW5pemVyLjxpbml0PiwgdHJpZ2dlcmluZyBpbml0
aWFsaXphdGlvbg0KICAgKiAgICAgU3RyaW5nVG9rZW5pemVyIGhhcyBubyBkZXBlbmRlbmNpZXMN
CiAgICogIFN5c3RlbS5sb2FkTGlicmFyeSBjYWxscyBSdW50aW1lLmxvYWRMaWJyYXJ5DQogICAq
ICAgUnVudGltZS5sb2FkTGlicmFyeSBzaG91bGQgYmUgYWJsZSB0byBsb2FkIHRoZSBsaWJyYXJ5
LCBhbHRob3VnaCBpdA0KICAgKiAgICAgICB3aWxsIHByb2JhYmx5IHNldCBvZmYgYW5vdGhlciBz
dHJpbmcgb2YgaW5pdGlhbGl6YXRpb25zIGZyb20NCiAgICogICAgICAgQ2xhc3NMb2FkZXIgZmly
c3QNCiAgICovDQogIHN0YXRpYyBQcm9wZXJ0aWVzIGRlZmF1bHRQcm9wZXJ0aWVzID0gbmV3IFBy
b3BlcnRpZXMoKTsNCiAgc3RhdGljDQogIHsNCiAgICBWTVJ1bnRpbWUuaW5zZXJ0U3lzdGVtUHJv
cGVydGllcyhkZWZhdWx0UHJvcGVydGllcyk7DQogIH0NCg0KICAvKioNCiAgICogVGhlIHRocmVh
ZCB0aGF0IHN0YXJ0ZWQgdGhlIGV4aXQgc2VxdWVuY2UuIEFjY2VzcyB0byB0aGlzIGZpZWxkIG11
c3QNCiAgICogYmUgdGhyZWFkLXNhZmU7IGxvY2sgb24gbGlicGF0aCB0byBhdm9pZCBkZWFkbG9j
ayB3aXRoIHVzZXIgY29kZS4NCiAgICogPGNvZGU+cnVuRmluYWxpemF0aW9uKCk8L2NvZGU+IG1h
eSB3YW50IHRvIGxvb2sgYXQgdGhpcyB0byBzZWUgaWYgQUxMDQogICAqIGZpbmFsaXplcnMgc2hv
dWxkIGJlIHJ1biwgYmVjYXVzZSB0aGUgdmlydHVhbCBtYWNoaW5lIGlzIGFib3V0IHRvIGhhbHQu
DQogICAqLw0KICBwcml2YXRlIFRocmVhZCBleGl0U2VxdWVuY2U7DQoNCiAgLyoqDQogICAqIEFs
bCBzaHV0ZG93biBob29rcy4gVGhpcyBpcyBpbml0aWFsaXplZCBsYXppbHksIGFuZCBzZXQgdG8g
bnVsbCBvbmNlIGFsbA0KICAgKiBzaHV0ZG93biBob29rcyBoYXZlIHJ1bi4gQWNjZXNzIHRvIHRo
aXMgZmllbGQgbXVzdCBiZSB0aHJlYWQtc2FmZTsgbG9jaw0KICAgKiBvbiBsaWJwYXRoIHRvIGF2
b2lkIGRlYWRsb2NrIHdpdGggdXNlciBjb2RlLg0KICAgKi8NCiAgcHJpdmF0ZSBTZXQgc2h1dGRv
d25Ib29rczsNCg0KICAvKioNCiAgICogVGhlIG9uZSBhbmQgb25seSBydW50aW1lIGluc3RhbmNl
LiBUaGlzIG11c3QgYXBwZWFyIGFmdGVyIHRoZSBkZWZhdWx0DQogICAqIHByb3BlcnRpZXMgaGF2
ZSBiZWVuIGluaXRpYWxpemVkIGJ5IHRoZSBWTS4NCiAgICovDQogIHByaXZhdGUgc3RhdGljIGZp
bmFsIFJ1bnRpbWUgY3VycmVudCA9IG5ldyBSdW50aW1lKCk7DQoNCiAgLyoqDQogICAqIE5vdCBp
bnN0YW50aWFibGUgYnkgYSB1c2VyLCB0aGlzIHNob3VsZCBvbmx5IGNyZWF0ZSBvbmUgaW5zdGFu
Y2UuDQogICAqLw0KICBwcml2YXRlIFJ1bnRpbWUoKQ0KICB7DQogICAgaWYgKGN1cnJlbnQgIT0g
bnVsbCkNCiAgICAgIHRocm93IG5ldyBJbnRlcm5hbEVycm9yKCJBdHRlbXB0IHRvIHJlY3JlYXRl
IFJ1bnRpbWUiKTsNCiAgICAvLyBVc2luZyBkZWZhdWx0UHJvcGVydGllcyBkaXJlY3RseSBhdm9p
ZHMgYSBzZWN1cml0eSBjaGVjaywgYXMgd2VsbA0KICAgIC8vIGFzIGJvb3RzdHJhcCBpc3N1ZXMg
KHNpbmNlIFN5c3RlbSBpcyBub3QgaW5pdGlhbGl6ZWQgeWV0KS4NCiAgICBTdHJpbmcgcGF0aCA9
IGRlZmF1bHRQcm9wZXJ0aWVzLmdldFByb3BlcnR5KCJqYXZhLmxpYnJhcnkucGF0aCIsICIuIik7
DQogICAgU3RyaW5nIHBhdGhTZXAgPSBkZWZhdWx0UHJvcGVydGllcy5nZXRQcm9wZXJ0eSgicGF0
aC5zZXBhcmF0b3IiLCAiOiIpOw0KICAgIFN0cmluZyBmaWxlU2VwID0gZGVmYXVsdFByb3BlcnRp
ZXMuZ2V0UHJvcGVydHkoImZpbGUuc2VwYXJhdG9yIiwgIi8iKTsNCiAgICBTdHJpbmdUb2tlbml6
ZXIgdCA9IG5ldyBTdHJpbmdUb2tlbml6ZXIocGF0aCwgcGF0aFNlcCk7DQogICAgbGlicGF0aCA9
IG5ldyBTdHJpbmdbdC5jb3VudFRva2VucygpXTsNCiAgICBmb3IgKGludCBpID0gMDsgaSA8IGxp
YnBhdGgubGVuZ3RoOyBpKyspDQogICAgICB7DQogICAgICAgIFN0cmluZyBwcmVmaXggPSB0Lm5l
eHRUb2tlbigpOw0KICAgICAgICBpZiAoISBwcmVmaXguZW5kc1dpdGgoZmlsZVNlcCkpDQogICAg
ICAgICAgcHJlZml4ICs9IGZpbGVTZXA7DQogICAgICAgIGxpYnBhdGhbaV0gPSBwcmVmaXg7DQog
ICAgICB9DQogIH0NCg0KICAvKioNCiAgICogR2V0IHRoZSBjdXJyZW50IFJ1bnRpbWUgb2JqZWN0
IGZvciB0aGlzIEpWTS4gVGhpcyBpcyBuZWNlc3NhcnkgdG8gYWNjZXNzDQogICAqIHRoZSBtYW55
IGluc3RhbmNlIG1ldGhvZHMgb2YgdGhpcyBjbGFzcy4NCiAgICoNCiAgICogQHJldHVybiB0aGUg
Y3VycmVudCBSdW50aW1lIG9iamVjdA0KICAgKi8NCiAgcHVibGljIHN0YXRpYyBSdW50aW1lIGdl
dFJ1bnRpbWUoKQ0KICB7DQogICAgcmV0dXJuIGN1cnJlbnQ7DQogIH0NCg0KICAvKioNCiAgICog
RXhpdCB0aGUgSmF2YSBydW50aW1lLiBUaGlzIG1ldGhvZCB3aWxsIGVpdGhlciB0aHJvdyBhIFNl
Y3VyaXR5RXhjZXB0aW9uDQogICAqIG9yIGl0IHdpbGwgbmV2ZXIgcmV0dXJuLiBUaGUgc3RhdHVz
IGNvZGUgaXMgcmV0dXJuZWQgdG8gdGhlIHN5c3RlbTsgb2Z0ZW4NCiAgICogYSBub24temVybyBz
dGF0dXMgY29kZSBpbmRpY2F0ZXMgYW4gYWJub3JtYWwgZXhpdC4gT2YgY291cnNlLCB0aGVyZSBp
cyBhDQogICAqIHNlY3VyaXR5IGNoZWNrLCA8Y29kZT5jaGVja0V4aXQoc3RhdHVzKTwvY29kZT4u
DQogICAqDQogICAqIDxwPkZpcnN0LCBhbGwgc2h1dGRvd24gaG9va3MgYXJlIHJ1biwgaW4gdW5z
cGVjaWZpZWQgb3JkZXIsIGFuZA0KICAgKiBjb25jdXJyZW50bHkuIE5leHQsIGlmIGZpbmFsaXph
dGlvbiBvbiBleGl0IGhhcyBiZWVuIGVuYWJsZWQsIGFsbCBwZW5kaW5nDQogICAqIGZpbmFsaXpl
cnMgYXJlIHJ1bi4gRmluYWxseSwgdGhlIHN5c3RlbSBjYWxscyA8Y29kZT5oYWx0PC9jb2RlPi4N
CiAgICoNCiAgICogPHA+SWYgdGhpcyBpcyBydW4gYSBzZWNvbmQgdGltZSBhZnRlciBzaHV0ZG93
biBoYXMgYWxyZWFkeSBzdGFydGVkLCB0aGVyZQ0KICAgKiBhcmUgdHdvIGFjdGlvbnMuIElmIHNo
dXRkb3duIGhvb2tzIGFyZSBzdGlsbCBleGVjdXRpbmcsIGl0IGJsb2Nrcw0KICAgKiBpbmRlZmlu
aXRlbHkuIE90aGVyd2lzZSwgaWYgdGhlIHN0YXR1cyBpcyBub256ZXJvIGl0IGhhbHRzIGltbWVk
aWF0ZWx5Ow0KICAgKiBpZiBpdCBpcyB6ZXJvLCBpdCBibG9ja3MgaW5kZWZpbml0ZWx5LiBUaGlz
IGlzIHR5cGljYWxseSBjYWxsZWQgYnkNCiAgICogPGNvZGU+U3lzdGVtLmV4aXQ8L2NvZGU+Lg0K
ICAgKg0KICAgKiBAcGFyYW0gc3RhdHVzIHRoZSBzdGF0dXMgdG8gZXhpdCB3aXRoDQogICAqIEB0
aHJvd3MgU2VjdXJpdHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBpcyBkZW5pZWQNCiAgICogQHNl
ZSAjYWRkU2h1dGRvd25Ib29rKFRocmVhZCkNCiAgICogQHNlZSAjcnVuRmluYWxpemVyc09uRXhp
dChib29sZWFuKQ0KICAgKiBAc2VlICNydW5GaW5hbGl6YXRpb24oKQ0KICAgKiBAc2VlICNoYWx0
KGludCkNCiAgICovDQogIHB1YmxpYyB2b2lkIGV4aXQoaW50IHN0YXR1cykNCiAgew0KICAgIFNl
Y3VyaXR5TWFuYWdlciBzbSA9IHNlY3VyaXR5TWFuYWdlcjsgLy8gQmUgdGhyZWFkLXNhZmUhDQog
ICAgaWYgKHNtICE9IG51bGwpDQogICAgICBzbS5jaGVja0V4aXQoc3RhdHVzKTsNCg0KICAgIGlm
IChydW5TaHV0ZG93bkhvb2tzKCkpDQogICAgICBoYWx0KHN0YXR1cyk7DQoNCiAgICAvLyBTb21l
b25lIGVsc2UgYWxyZWFkeSBjYWxsZWQgcnVuU2h1dGRvd25Ib29rcygpLg0KICAgIC8vIE1ha2Ug
c3VyZSB3ZSBhcmUgbm90L25vIGxvbmdlciBpbiB0aGUgc2h1dGRvd25Ib29rcyBzZXQuDQogICAg
Ly8gQW5kIHdhaXQgdGlsbCB0aGUgdGhyZWFkIHRoYXQgaXMgY2FsbGluZyBydW5TaHV0ZG93bkhv
b2tzKCkgZmluaXNoZXMuDQogICAgc3luY2hyb25pemVkIChsaWJwYXRoKQ0KICAgICAgew0KICAg
ICAgICBpZiAoc2h1dGRvd25Ib29rcyAhPSBudWxsKQ0KICAgICAgICAgIHsNCiAgICAgICAgICAg
IHNodXRkb3duSG9va3MucmVtb3ZlKFRocmVhZC5jdXJyZW50VGhyZWFkKCkpOw0KCSAgICAvLyBT
aHV0ZG93biBob29rcyBhcmUgc3RpbGwgcnVubmluZywgc28gd2UgY2xlYXIgc3RhdHVzIHRvDQoJ
ICAgIC8vIG1ha2Ugc3VyZSB3ZSBkb24ndCBoYWx0Lg0KCSAgICBzdGF0dXMgPSAwOw0KICAgICAg
ICAgIH0NCiAgICAgIH0NCg0KICAgIC8vIElmIGV4aXQoKSBpcyBjYWxsZWQgYWdhaW4gYWZ0ZXIg
dGhlIHNodXRkb3duIGhvb2tzIGhhdmUgcnVuLCBidXQNCiAgICAvLyB3aGlsZSBmaW5hbGl6YXRp
b24gZm9yIGV4aXQgaXMgZ29pbmcgb24gYW5kIHRoZSBzdGF0dXMgaXMgbm9uLXplcm8NCiAgICAv
LyB3ZSBoYWx0IGltbWVkaWF0ZWx5Lg0KICAgIGlmIChzdGF0dXMgIT0gMCkNCiAgICAgIGhhbHQo
c3RhdHVzKTsNCg0KICAgIHdoaWxlICh0cnVlKQ0KICAgICAgdHJ5DQogICAgICAgIHsNCiAgICAg
ICAgICBleGl0U2VxdWVuY2Uuam9pbigpOw0KICAgICAgICB9DQogICAgICBjYXRjaCAoSW50ZXJy
dXB0ZWRFeGNlcHRpb24gZSkNCiAgICAgICAgew0KICAgICAgICAgIC8vIElnbm9yZSwgd2UndmUg
c3VzcGVuZGVkIGluZGVmaW5pdGVseSB0byBsZXQgYWxsIHNodXRkb3duDQogICAgICAgICAgLy8g
aG9va3MgY29tcGxldGUsIGFuZCB0byBsZXQgYW55IG5vbi16ZXJvIGV4aXRzIHRocm91Z2gsIGJl
Y2F1c2UNCiAgICAgICAgICAvLyB0aGlzIGlzIGEgZHVwbGljYXRlIGNhbGwgdG8gZXhpdCgwKS4N
CiAgICAgICAgfQ0KICB9DQoNCiAgLyoqDQogICAqIE9uIGZpcnN0IGludm9jYXRpb24sIHJ1biBh
bGwgdGhlIHNodXRkb3duIGhvb2tzIGFuZCByZXR1cm4gdHJ1ZS4NCiAgICogQW55IHN1YnNlcXVl
bnQgaW52b2NhdGlvbnMgd2lsbCBzaW1wbHkgcmV0dXJuIGZhbHNlLg0KICAgKiBOb3RlIHRoYXQg
aXQgaXMgcGFja2FnZSBhY2Nlc3NpYmxlIHNvIHRoYXQgVk1SdW50aW1lIGNhbiBjYWxsIGl0DQog
ICAqIHdoZW4gVk0gZXhpdCBpcyBub3QgdHJpZ2dlcmVkIGJ5IGEgY2FsbCB0byBSdW50aW1lLmV4
aXQoKS4NCiAgICogDQogICAqIEByZXR1cm4gd2FzIHRoZSBjdXJyZW50IHRocmVhZCB0aGUgZmly
c3Qgb25lIHRvIGNhbGwgdGhpcyBtZXRob2Q/DQogICAqLw0KICBib29sZWFuIHJ1blNodXRkb3du
SG9va3MoKQ0KICB7DQogICAgYm9vbGVhbiBmaXJzdCA9IGZhbHNlOw0KICAgIHN5bmNocm9uaXpl
ZCAobGlicGF0aCkgLy8gU3luY2ggb24gbGlicGF0aCwgbm90IHRoaXMsIHRvIGF2b2lkIGRlYWRs
b2NrLg0KICAgICAgew0KICAgICAgICBpZiAoZXhpdFNlcXVlbmNlID09IG51bGwpDQogICAgICAg
ICAgew0KICAgICAgICAgICAgZmlyc3QgPSB0cnVlOw0KICAgICAgICAgICAgZXhpdFNlcXVlbmNl
ID0gVGhyZWFkLmN1cnJlbnRUaHJlYWQoKTsNCiAgICAgICAgICAgIGlmIChzaHV0ZG93bkhvb2tz
ICE9IG51bGwpDQogICAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAgICBJdGVyYXRvciBpID0g
c2h1dGRvd25Ib29rcy5pdGVyYXRvcigpOw0KICAgICAgICAgICAgICAgIHdoaWxlIChpLmhhc05l
eHQoKSkgLy8gU3RhcnQgYWxsIHNodXRkb3duIGhvb2tzLg0KICAgICAgICAgICAgICAgICAgdHJ5
DQogICAgICAgICAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAgICAgICAgICAoKFRocmVhZCkg
aS5uZXh0KCkpLnN0YXJ0KCk7DQogICAgICAgICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICAg
ICAgIGNhdGNoIChJbGxlZ2FsVGhyZWFkU3RhdGVFeGNlcHRpb24gZSkNCiAgICAgICAgICAgICAg
ICAgICAgew0KICAgICAgICAgICAgICAgICAgICAgIGkucmVtb3ZlKCk7DQogICAgICAgICAgICAg
ICAgICAgIH0NCiAgICAgICAgICAgICAgfQ0KICAgICAgICAgIH0NCiAgICAgIH0NCiAgICBpZiAo
Zmlyc3QpDQogICAgICB7DQogICAgICAgIGlmIChzaHV0ZG93bkhvb2tzICE9IG51bGwpDQogICAg
ICAgICAgew0KICAgICAgICAgICAgLy8gQ2hlY2sgcHJvZ3Jlc3Mgb2YgYWxsIHNodXRkb3duIGhv
b2tzLiBBcyBhIGhvb2sgY29tcGxldGVzLA0KICAgICAgICAgICAgLy8gcmVtb3ZlIGl0IGZyb20g
dGhlIHNldC4gSWYgYSBob29rIGNhbGxzIGV4aXQsIGl0IHJlbW92ZXMNCiAgICAgICAgICAgIC8v
IGl0c2VsZiBmcm9tIHRoZSBzZXQsIHRoZW4gd2FpdHMgaW5kZWZpbml0ZWx5IG9uIHRoZQ0KICAg
ICAgICAgICAgLy8gZXhpdFNlcXVlbmNlIHRocmVhZC4gT25jZSB0aGUgc2V0IGlzIGVtcHR5LCBz
ZXQgaXQgdG8gbnVsbCB0bw0KICAgICAgICAgICAgLy8gc2lnbmFsIGFsbCBmaW5hbGl6ZXIgdGhy
ZWFkcyB0aGF0IGhhbHQgbWF5IGJlIGNhbGxlZC4NCiAgICAgICAgICAgIHdoaWxlICghIHNodXRk
b3duSG9va3MuaXNFbXB0eSgpKQ0KICAgICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgVGhy
ZWFkW10gaG9va3M7DQogICAgICAgICAgICAgICAgc3luY2hyb25pemVkIChsaWJwYXRoKQ0KICAg
ICAgICAgICAgICAgICAgew0KICAgICAgICAgICAgICAgICAgICBob29rcyA9IG5ldyBUaHJlYWRb
c2h1dGRvd25Ib29rcy5zaXplKCldOw0KICAgICAgICAgICAgICAgICAgICBzaHV0ZG93bkhvb2tz
LnRvQXJyYXkoaG9va3MpOw0KICAgICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAgIGZv
ciAoaW50IGkgPSBob29rcy5sZW5ndGg7IC0taSA+PSAwOyApDQogICAgICAgICAgICAgICAgICBp
ZiAoISBob29rc1tpXS5pc0FsaXZlKCkpDQogICAgICAgICAgICAgICAgICAgIHN5bmNocm9uaXpl
ZCAobGlicGF0aCkNCiAgICAgICAgICAgICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgICAg
ICAgICBzaHV0ZG93bkhvb2tzLnJlbW92ZShob29rc1tpXSk7DQogICAgICAgICAgICAgICAgICAg
ICAgfQ0KICAgICAgICAgICAgICAgIHRyeQ0KICAgICAgICAgICAgICAgICAgew0KICAgICAgICAg
ICAgICAgICAgICBleGl0U2VxdWVuY2Uuc2xlZXAoMSk7IC8vIEdpdmUgb3RoZXIgdGhyZWFkcyBh
IGNoYW5jZS4NCiAgICAgICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICAgICBjYXRjaCAoSW50
ZXJydXB0ZWRFeGNlcHRpb24gZSkNCiAgICAgICAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAg
ICAgICAgLy8gSWdub3JlLCB0aGUgbmV4dCBsb29wIGp1c3Qgc3RhcnRzIHNvb25lci4NCiAgICAg
ICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgc3luY2hyb25pemVk
IChsaWJwYXRoKQ0KICAgICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgc2h1dGRvd25Ib29r
cyA9IG51bGw7DQogICAgICAgICAgICAgIH0NCiAgICAgICAgICB9DQoJLy8gUnVuIGZpbmFsaXph
dGlvbiBvbiBhbGwgZmluYWxpemFibGUgb2JqZWN0cyAoZXZlbiBpZiB0aGV5IGFyZQ0KCS8vIHN0
aWxsIHJlYWNoYWJsZSkuDQogICAgICAgIFZNUnVudGltZS5ydW5GaW5hbGl6YXRpb25Gb3JFeGl0
KCk7DQogICAgICB9DQogICAgcmV0dXJuIGZpcnN0Ow0KICB9DQoNCiAgLyoqDQogICAqIFJlZ2lz
dGVyIGEgbmV3IHNodXRkb3duIGhvb2suIFRoaXMgaXMgaW52b2tlZCB3aGVuIHRoZSBwcm9ncmFt
IGV4aXRzDQogICAqIG5vcm1hbGx5IChiZWNhdXNlIGFsbCBub24tZGFlbW9uIHRocmVhZHMgZW5k
ZWQsIG9yIGJlY2F1c2UNCiAgICogPGNvZGU+U3lzdGVtLmV4aXQ8L2NvZGU+IHdhcyBpbnZva2Vk
KSwgb3Igd2hlbiB0aGUgdXNlciB0ZXJtaW5hdGVzDQogICAqIHRoZSB2aXJ0dWFsIG1hY2hpbmUg
KHN1Y2ggYXMgYnkgdHlwaW5nIF5DLCBvciBsb2dnaW5nIG9mZikuIFRoZXJlIGlzDQogICAqIGEg
c2VjdXJpdHkgY2hlY2sgdG8gYWRkIGhvb2tzLA0KICAgKiA8Y29kZT5SdW50aW1lUGVybWlzc2lv
bigic2h1dGRvd25Ib29rcyIpPGNvZGU+Lg0KICAgKg0KICAgKiA8cD5UaGUgaG9vayBtdXN0IGJl
IGFuIGluaXRpYWxpemVkLCBidXQgdW5zdGFydGVkIFRocmVhZC4gVGhlIHRocmVhZHMNCiAgICog
YXJlIHJ1biBjb25jdXJyZW50bHksIGFuZCBzdGFydGVkIGluIGFuIGFyYml0cmFyeSBvcmRlcjsg
YW5kIHVzZXINCiAgICogdGhyZWFkcyBvciBkYWVtb25zIG1heSBzdGlsbCBiZSBydW5uaW5nLiBP
bmNlIHNodXRkb3duIGhvb2tzIGhhdmUNCiAgICogc3RhcnRlZCwgdGhleSBtdXN0IGFsbCBjb21w
bGV0ZSwgb3IgZWxzZSB5b3UgbXVzdCB1c2UgPGNvZGU+aGFsdDwvY29kZT4sDQogICAqIHRvIGFj
dHVhbGx5IGZpbmlzaCB0aGUgc2h1dGRvd24gc2VxdWVuY2UuIEF0dGVtcHRzIHRvIG1vZGlmeSBo
b29rcw0KICAgKiBhZnRlciBzaHV0ZG93biBoYXMgc3RhcnRlZCByZXN1bHQgaW4gSWxsZWdhbFN0
YXRlRXhjZXB0aW9ucy4NCiAgICoNCiAgICogPHA+SXQgaXMgaW1wZXJhdGl2ZSB0aGF0IHlvdSBj
b2RlIHNodXRkb3duIGhvb2tzIGRlZmVuc2l2ZWx5LCBhcyB5b3UNCiAgICogZG8gbm90IHdhbnQg
dG8gZGVhZGxvY2ssIGFuZCBoYXZlIG5vIGlkZWEgd2hhdCBvdGhlciBob29rcyB3aWxsIGJlDQog
ICAqIHJ1bm5pbmcgY29uY3VycmVudGx5LiBJdCBpcyBhbHNvIGEgZ29vZCBpZGVhIHRvIGZpbmlz
aCBxdWlja2x5LCBhcyB0aGUNCiAgICogdmlydHVhbCBtYWNoaW5lIHJlYWxseSB3YW50cyB0byBz
aHV0IGRvd24hDQogICAqDQogICAqIDxwPlRoZXJlIGFyZSBubyBndWFyYW50ZWVzIHRoYXQgc3Vj
aCBob29rcyB3aWxsIHJ1biwgYXMgdGhlcmUgYXJlIHdheXMNCiAgICogdG8gZm9yY2libHkga2ls
bCBhIHByb2Nlc3MuIEJ1dCBpbiBzdWNoIGEgZHJhc3RpYyBjYXNlLCBzaHV0ZG93biBob29rcw0K
ICAgKiB3b3VsZCBkbyBsaXR0bGUgZm9yIHlvdSBpbiB0aGUgZmlyc3QgcGxhY2UuDQogICAqDQog
ICAqIEBwYXJhbSBob29rIGFuIGluaXRpYWxpemVkLCB1bnN0YXJ0ZWQgVGhyZWFkDQogICAqIEB0
aHJvd3MgSWxsZWdhbEFyZ3VtZW50RXhjZXB0aW9uIGlmIHRoZSBob29rIGlzIGFscmVhZHkgcmVn
aXN0ZXJlZCBvciBydW4NCiAgICogQHRocm93cyBJbGxlZ2FsU3RhdGVFeGNlcHRpb24gaWYgdGhl
IHZpcnR1YWwgbWFjaGluZSBpcyBhbHJlYWR5IGluDQogICAqICAgICAgICAgdGhlIHNodXRkb3du
IHNlcXVlbmNlDQogICAqIEB0aHJvd3MgU2VjdXJpdHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBp
cyBkZW5pZWQNCiAgICogQHNpbmNlIDEuMw0KICAgKiBAc2VlICNyZW1vdmVTaHV0ZG93bkhvb2so
VGhyZWFkKQ0KICAgKiBAc2VlICNleGl0KGludCkNCiAgICogQHNlZSAjaGFsdChpbnQpDQogICAq
Lw0KICBwdWJsaWMgdm9pZCBhZGRTaHV0ZG93bkhvb2soVGhyZWFkIGhvb2spDQogIHsNCiAgICBT
ZWN1cml0eU1hbmFnZXIgc20gPSBzZWN1cml0eU1hbmFnZXI7IC8vIEJlIHRocmVhZC1zYWZlIQ0K
ICAgIGlmIChzbSAhPSBudWxsKQ0KICAgICAgc20uY2hlY2tQZXJtaXNzaW9uKG5ldyBSdW50aW1l
UGVybWlzc2lvbigic2h1dGRvd25Ib29rcyIpKTsNCiAgICBpZiAoaG9vay5pc0FsaXZlKCkgfHwg
aG9vay5nZXRUaHJlYWRHcm91cCgpID09IG51bGwpDQogICAgICB0aHJvdyBuZXcgSWxsZWdhbEFy
Z3VtZW50RXhjZXB0aW9uKCk7DQogICAgc3luY2hyb25pemVkIChsaWJwYXRoKQ0KICAgICAgew0K
ICAgICAgICBpZiAoZXhpdFNlcXVlbmNlICE9IG51bGwpDQogICAgICAgICAgdGhyb3cgbmV3IEls
bGVnYWxTdGF0ZUV4Y2VwdGlvbigpOw0KICAgICAgICBpZiAoc2h1dGRvd25Ib29rcyA9PSBudWxs
KQ0KICAgICAgICAgIHNodXRkb3duSG9va3MgPSBuZXcgSGFzaFNldCgpOyAvLyBMYXp5IGluaXRp
YWxpemF0aW9uLg0KICAgICAgICBpZiAoISBzaHV0ZG93bkhvb2tzLmFkZChob29rKSkNCiAgICAg
ICAgICB0aHJvdyBuZXcgSWxsZWdhbEFyZ3VtZW50RXhjZXB0aW9uKCk7DQogICAgICB9DQogIH0N
Cg0KICAvKioNCiAgICogRGUtcmVnaXN0ZXIgYSBzaHV0ZG93biBob29rLiBBcyB3aGVuIHlvdSBy
ZWdpc3RlcmVkIGl0LCB0aGVyZSBpcyBhDQogICAqIHNlY3VyaXR5IGNoZWNrIHRvIHJlbW92ZSBo
b29rcywNCiAgICogPGNvZGU+UnVudGltZVBlcm1pc3Npb24oInNodXRkb3duSG9va3MiKTxjb2Rl
Pi4NCiAgICoNCiAgICogQHBhcmFtIGhvb2sgdGhlIGhvb2sgdG8gcmVtb3ZlDQogICAqIEByZXR1
cm4gdHJ1ZSBpZiB0aGUgaG9vayB3YXMgc3VjY2Vzc2Z1bGx5IHJlbW92ZWQsIGZhbHNlIGlmIGl0
IHdhcyBub3QNCiAgICogICAgICAgICByZWdpc3RlcmVkIGluIHRoZSBmaXJzdCBwbGFjZQ0KICAg
KiBAdGhyb3dzIElsbGVnYWxTdGF0ZUV4Y2VwdGlvbiBpZiB0aGUgdmlydHVhbCBtYWNoaW5lIGlz
IGFscmVhZHkgaW4NCiAgICogICAgICAgICB0aGUgc2h1dGRvd24gc2VxdWVuY2UNCiAgICogQHRo
cm93cyBTZWN1cml0eUV4Y2VwdGlvbiBpZiBwZXJtaXNzaW9uIGlzIGRlbmllZA0KICAgKiBAc2lu
Y2UgMS4zDQogICAqIEBzZWUgI2FkZFNodXRkb3duSG9vayhUaHJlYWQpDQogICAqIEBzZWUgI2V4
aXQoaW50KQ0KICAgKiBAc2VlICNoYWx0KGludCkNCiAgICovDQogIHB1YmxpYyBib29sZWFuIHJl
bW92ZVNodXRkb3duSG9vayhUaHJlYWQgaG9vaykNCiAgew0KICAgIFNlY3VyaXR5TWFuYWdlciBz
bSA9IHNlY3VyaXR5TWFuYWdlcjsgLy8gQmUgdGhyZWFkLXNhZmUhDQogICAgaWYgKHNtICE9IG51
bGwpDQogICAgICBzbS5jaGVja1Blcm1pc3Npb24obmV3IFJ1bnRpbWVQZXJtaXNzaW9uKCJzaHV0
ZG93bkhvb2tzIikpOw0KICAgIHN5bmNocm9uaXplZCAobGlicGF0aCkNCiAgICAgIHsNCiAgICAg
ICAgaWYgKGV4aXRTZXF1ZW5jZSAhPSBudWxsKQ0KICAgICAgICAgIHRocm93IG5ldyBJbGxlZ2Fs
U3RhdGVFeGNlcHRpb24oKTsNCiAgICAgICAgaWYgKHNodXRkb3duSG9va3MgIT0gbnVsbCkNCiAg
ICAgICAgICByZXR1cm4gc2h1dGRvd25Ib29rcy5yZW1vdmUoaG9vayk7DQogICAgICB9DQogICAg
cmV0dXJuIGZhbHNlOw0KICB9DQoNCiAgLyoqDQogICAqIEZvcmNpYmx5IHRlcm1pbmF0ZSB0aGUg
dmlydHVhbCBtYWNoaW5lLiBUaGlzIGNhbGwgbmV2ZXIgcmV0dXJucy4gSXQgaXMNCiAgICogbXVj
aCBtb3JlIHNldmVyZSB0aGFuIDxjb2RlPmV4aXQ8L2NvZGU+LCBhcyBpdCBieXBhc3NlcyBhbGwg
c2h1dGRvd24NCiAgICogaG9va3MgYW5kIGluaXRpYWxpemVycy4gVXNlIGNhdXRpb24gaW4gY2Fs
bGluZyB0aGlzISBPZiBjb3Vyc2UsIHRoZXJlIGlzDQogICAqIGEgc2VjdXJpdHkgY2hlY2ssIDxj
b2RlPmNoZWNrRXhpdChzdGF0dXMpPC9jb2RlPi4NCiAgICoNCiAgICogQHBhcmFtIHN0YXR1cyB0
aGUgc3RhdHVzIHRvIGV4aXQgd2l0aA0KICAgKiBAdGhyb3dzIFNlY3VyaXR5RXhjZXB0aW9uIGlm
IHBlcm1pc3Npb24gaXMgZGVuaWVkDQogICAqIEBzaW5jZSAxLjMNCiAgICogQHNlZSAjZXhpdChp
bnQpDQogICAqIEBzZWUgI2FkZFNodXRkb3duSG9vayhUaHJlYWQpDQogICAqLw0KICBwdWJsaWMg
dm9pZCBoYWx0KGludCBzdGF0dXMpDQogIHsNCiAgICBTZWN1cml0eU1hbmFnZXIgc20gPSBzZWN1
cml0eU1hbmFnZXI7IC8vIEJlIHRocmVhZC1zYWZlIQ0KICAgIGlmIChzbSAhPSBudWxsKQ0KICAg
ICAgc20uY2hlY2tFeGl0KHN0YXR1cyk7DQogICAgVk1SdW50aW1lLmV4aXQoc3RhdHVzKTsNCiAg
fQ0KDQogIC8qKg0KICAgKiBUZWxsIHRoZSBWTSB0byBydW4gdGhlIGZpbmFsaXplKCkgbWV0aG9k
IG9uIGV2ZXJ5IHNpbmdsZSBPYmplY3QgYmVmb3JlDQogICAqIGl0IGV4aXRzLiAgTm90ZSB0aGF0
IHRoZSBKVk0gbWF5IHN0aWxsIGV4aXQgYWJub3JtYWxseSBhbmQgbm90IHBlcmZvcm0NCiAgICog
dGhpcywgc28geW91IHN0aWxsIGRvbid0IGhhdmUgYSBndWFyYW50ZWUuIEFuZCBiZXNpZGVzIHRo
YXQsIHRoaXMgaXMNCiAgICogaW5oZXJlbnRseSB1bnNhZmUgaW4gbXVsdGktdGhyZWFkZWQgY29k
ZSwgYXMgaXQgbWF5IHJlc3VsdCBpbiBkZWFkbG9jaw0KICAgKiBhcyBtdWx0aXBsZSB0aHJlYWRz
IGNvbXBldGUgdG8gbWFuaXB1bGF0ZSBvYmplY3RzLiBUaGlzIHZhbHVlIGRlZmF1bHRzIHRvDQog
ICAqIDxjb2RlPmZhbHNlPC9jb2RlPi4gVGhlcmUgaXMgYSBzZWN1cml0eSBjaGVjaywgPGNvZGU+
Y2hlY2tFeGl0KDApPC9jb2RlPi4NCiAgICoNCiAgICogQHBhcmFtIGZpbmFsaXplT25FeGl0IHdo
ZXRoZXIgdG8gZmluYWxpemUgYWxsIE9iamVjdHMgb24gZXhpdA0KICAgKiBAdGhyb3dzIFNlY3Vy
aXR5RXhjZXB0aW9uIGlmIHBlcm1pc3Npb24gaXMgZGVuaWVkDQogICAqIEBzZWUgI2V4aXQoaW50
KQ0KICAgKiBAc2VlICNnYygpDQogICAqIEBzaW5jZSAxLjENCiAgICogQGRlcHJlY2F0ZWQgbmV2
ZXIgcmVseSBvbiBmaW5hbGl6ZXJzIHRvIGRvIGEgY2xlYW4sIHRocmVhZC1zYWZlLA0KICAgKiAg
ICAgICAgICAgICBtb3AtdXAgZnJvbSB5b3VyIGNvZGUNCiAgICovDQogIHB1YmxpYyBzdGF0aWMg
dm9pZCBydW5GaW5hbGl6ZXJzT25FeGl0KGJvb2xlYW4gZmluYWxpemVPbkV4aXQpDQogIHsNCiAg
ICBTZWN1cml0eU1hbmFnZXIgc20gPSBzZWN1cml0eU1hbmFnZXI7IC8vIEJlIHRocmVhZC1zYWZl
IQ0KICAgIGlmIChzbSAhPSBudWxsKQ0KICAgICAgc20uY2hlY2tFeGl0KDApOw0KICAgIFZNUnVu
dGltZS5ydW5GaW5hbGl6ZXJzT25FeGl0KGZpbmFsaXplT25FeGl0KTsNCiAgfQ0KDQogIC8qKg0K
ICAgKiBDcmVhdGUgYSBuZXcgc3VicHJvY2VzcyB3aXRoIHRoZSBzcGVjaWZpZWQgY29tbWFuZCBs
aW5lLiBDYWxscw0KICAgKiA8Y29kZT5leGVjKGNtZGxpbmUsIG51bGwsIG51bGwpPGNvZGU+LiBB
IHNlY3VyaXR5IGNoZWNrIGlzIHBlcmZvcm1lZCwNCiAgICogPGNvZGU+Y2hlY2tFeGVjPC9jb2Rl
Pi4NCiAgICoNCiAgICogQHBhcmFtIGNtZGxpbmUgdGhlIGNvbW1hbmQgdG8gY2FsbA0KICAgKiBA
cmV0dXJuIHRoZSBQcm9jZXNzIG9iamVjdA0KICAgKiBAdGhyb3dzIFNlY3VyaXR5RXhjZXB0aW9u
IGlmIHBlcm1pc3Npb24gaXMgZGVuaWVkDQogICAqIEB0aHJvd3MgSU9FeGNlcHRpb24gaWYgYW4g
SS9PIGVycm9yIG9jY3Vycw0KICAgKiBAdGhyb3dzIE51bGxQb2ludGVyRXhjZXB0aW9uIGlmIGNt
ZGxpbmUgaXMgbnVsbA0KICAgKiBAdGhyb3dzIEluZGV4T3V0T2ZCb3VuZHNFeGNlcHRpb24gaWYg
Y21kbGluZSBpcyAiIg0KICAgKi8NCiAgcHVibGljIFByb2Nlc3MgZXhlYyhTdHJpbmcgY21kbGlu
ZSkgdGhyb3dzIElPRXhjZXB0aW9uDQogIHsNCiAgICByZXR1cm4gZXhlYyhjbWRsaW5lLCBudWxs
LCBudWxsKTsNCiAgfQ0KDQogIC8qKg0KICAgKiBDcmVhdGUgYSBuZXcgc3VicHJvY2VzcyB3aXRo
IHRoZSBzcGVjaWZpZWQgY29tbWFuZCBsaW5lIGFuZCBlbnZpcm9ubWVudC4NCiAgICogSWYgdGhl
IGVudmlyb25tZW50IGlzIG51bGwsIHRoZSBwcm9jZXNzIGluaGVyaXRzIHRoZSBlbnZpcm9ubWVu
dCBvZg0KICAgKiB0aGlzIHByb2Nlc3MuIENhbGxzIDxjb2RlPmV4ZWMoY21kbGluZSwgZW52LCBu
dWxsKTwvY29kZT4uIEEgc2VjdXJpdHkNCiAgICogY2hlY2sgaXMgcGVyZm9ybWVkLCA8Y29kZT5j
aGVja0V4ZWM8L2NvZGU+Lg0KICAgKg0KICAgKiBAcGFyYW0gY21kbGluZSB0aGUgY29tbWFuZCB0
byBjYWxsDQogICAqIEBwYXJhbSBlbnYgdGhlIGVudmlyb25tZW50IHRvIHVzZSwgaW4gdGhlIGZv
cm1hdCBuYW1lPXZhbHVlDQogICAqIEByZXR1cm4gdGhlIFByb2Nlc3Mgb2JqZWN0DQogICAqIEB0
aHJvd3MgU2VjdXJpdHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBpcyBkZW5pZWQNCiAgICogQHRo
cm93cyBJT0V4Y2VwdGlvbiBpZiBhbiBJL08gZXJyb3Igb2NjdXJzDQogICAqIEB0aHJvd3MgTnVs
bFBvaW50ZXJFeGNlcHRpb24gaWYgY21kbGluZSBpcyBudWxsLCBvciBlbnYgaGFzIG51bGwgZW50
cmllcw0KICAgKiBAdGhyb3dzIEluZGV4T3V0T2ZCb3VuZHNFeGNlcHRpb24gaWYgY21kbGluZSBp
cyAiIg0KICAgKi8NCiAgcHVibGljIFByb2Nlc3MgZXhlYyhTdHJpbmcgY21kbGluZSwgU3RyaW5n
W10gZW52KSB0aHJvd3MgSU9FeGNlcHRpb24NCiAgew0KICAgIHJldHVybiBleGVjKGNtZGxpbmUs
IGVudiwgbnVsbCk7DQogIH0NCg0KICAvKioNCiAgICogQ3JlYXRlIGEgbmV3IHN1YnByb2Nlc3Mg
d2l0aCB0aGUgc3BlY2lmaWVkIGNvbW1hbmQgbGluZSwgZW52aXJvbm1lbnQsIGFuZA0KICAgKiB3
b3JraW5nIGRpcmVjdG9yeS4gSWYgdGhlIGVudmlyb25tZW50IGlzIG51bGwsIHRoZSBwcm9jZXNz
IGluaGVyaXRzIHRoZQ0KICAgKiBlbnZpcm9ubWVudCBvZiB0aGlzIHByb2Nlc3MuIElmIHRoZSBk
aXJlY3RvcnkgaXMgbnVsbCwgdGhlIHByb2Nlc3MgdXNlcw0KICAgKiB0aGUgY3VycmVudCB3b3Jr
aW5nIGRpcmVjdG9yeS4gVGhpcyBzcGxpdHMgY21kbGluZSBpbnRvIGFuIGFycmF5LCB1c2luZw0K
ICAgKiB0aGUgZGVmYXVsdCBTdHJpbmdUb2tlbml6ZXIsIHRoZW4gY2FsbHMNCiAgICogPGNvZGU+
ZXhlYyhjbWRBcnJheSwgZW52LCBkaXIpPC9jb2RlPi4gQSBzZWN1cml0eSBjaGVjayBpcyBwZXJm
b3JtZWQsDQogICAqIDxjb2RlPmNoZWNrRXhlYzwvY29kZT4uDQogICAqDQogICAqIEBwYXJhbSBj
bWRsaW5lIHRoZSBjb21tYW5kIHRvIGNhbGwNCiAgICogQHBhcmFtIGVudiB0aGUgZW52aXJvbm1l
bnQgdG8gdXNlLCBpbiB0aGUgZm9ybWF0IG5hbWU9dmFsdWUNCiAgICogQHBhcmFtIGRpciB0aGUg
d29ya2luZyBkaXJlY3RvcnkgdG8gdXNlDQogICAqIEByZXR1cm4gdGhlIFByb2Nlc3Mgb2JqZWN0
DQogICAqIEB0aHJvd3MgU2VjdXJpdHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBpcyBkZW5pZWQN
CiAgICogQHRocm93cyBJT0V4Y2VwdGlvbiBpZiBhbiBJL08gZXJyb3Igb2NjdXJzDQogICAqIEB0
aHJvd3MgTnVsbFBvaW50ZXJFeGNlcHRpb24gaWYgY21kbGluZSBpcyBudWxsLCBvciBlbnYgaGFz
IG51bGwgZW50cmllcw0KICAgKiBAdGhyb3dzIEluZGV4T3V0T2ZCb3VuZHNFeGNlcHRpb24gaWYg
Y21kbGluZSBpcyAiIg0KICAgKiBAc2luY2UgMS4zDQogICAqLw0KICBwdWJsaWMgUHJvY2VzcyBl
eGVjKFN0cmluZyBjbWRsaW5lLCBTdHJpbmdbXSBlbnYsIEZpbGUgZGlyKQ0KICAgIHRocm93cyBJ
T0V4Y2VwdGlvbg0KICB7DQogICAgU3RyaW5nVG9rZW5pemVyIHQgPSBuZXcgU3RyaW5nVG9rZW5p
emVyKGNtZGxpbmUpOw0KICAgIFN0cmluZ1tdIGNtZCA9IG5ldyBTdHJpbmdbdC5jb3VudFRva2Vu
cygpXTsNCiAgICBmb3IgKGludCBpID0gMDsgaSA8IGNtZC5sZW5ndGg7IGkrKykNCiAgICAgIGNt
ZFtpXSA9IHQubmV4dFRva2VuKCk7DQogICAgcmV0dXJuIGV4ZWMoY21kLCBlbnYsIGRpcik7DQog
IH0NCg0KICAvKioNCiAgICogQ3JlYXRlIGEgbmV3IHN1YnByb2Nlc3Mgd2l0aCB0aGUgc3BlY2lm
aWVkIGNvbW1hbmQgbGluZSwgYWxyZWFkeQ0KICAgKiB0b2tlbml6ZWQuIENhbGxzIDxjb2RlPmV4
ZWMoY21kLCBudWxsLCBudWxsKTwvY29kZT4uIEEgc2VjdXJpdHkgY2hlY2sNCiAgICogaXMgcGVy
Zm9ybWVkLCA8Y29kZT5jaGVja0V4ZWM8L2NvZGU+Lg0KICAgKg0KICAgKiBAcGFyYW0gY21kIHRo
ZSBjb21tYW5kIHRvIGNhbGwNCiAgICogQHJldHVybiB0aGUgUHJvY2VzcyBvYmplY3QNCiAgICog
QHRocm93cyBTZWN1cml0eUV4Y2VwdGlvbiBpZiBwZXJtaXNzaW9uIGlzIGRlbmllZA0KICAgKiBA
dGhyb3dzIElPRXhjZXB0aW9uIGlmIGFuIEkvTyBlcnJvciBvY2N1cnMNCiAgICogQHRocm93cyBO
dWxsUG9pbnRlckV4Y2VwdGlvbiBpZiBjbWQgaXMgbnVsbCwgb3IgaGFzIG51bGwgZW50cmllcw0K
ICAgKiBAdGhyb3dzIEluZGV4T3V0T2ZCb3VuZHNFeGNlcHRpb24gaWYgY21kIGlzIGxlbmd0aCAw
DQogICAqLw0KICBwdWJsaWMgUHJvY2VzcyBleGVjKFN0cmluZ1tdIGNtZCkgdGhyb3dzIElPRXhj
ZXB0aW9uDQogIHsNCiAgICByZXR1cm4gZXhlYyhjbWQsIG51bGwsIG51bGwpOw0KICB9DQoNCiAg
LyoqDQogICAqIENyZWF0ZSBhIG5ldyBzdWJwcm9jZXNzIHdpdGggdGhlIHNwZWNpZmllZCBjb21t
YW5kIGxpbmUsIGFscmVhZHkNCiAgICogdG9rZW5pemVkLCBhbmQgc3BlY2lmaWVkIGVudmlyb25t
ZW50LiBJZiB0aGUgZW52aXJvbm1lbnQgaXMgbnVsbCwgdGhlDQogICAqIHByb2Nlc3MgaW5oZXJp
dHMgdGhlIGVudmlyb25tZW50IG9mIHRoaXMgcHJvY2Vzcy4gQ2FsbHMNCiAgICogPGNvZGU+ZXhl
YyhjbWQsIGVudiwgbnVsbCk8L2NvZGU+LiBBIHNlY3VyaXR5IGNoZWNrIGlzIHBlcmZvcm1lZCwN
CiAgICogPGNvZGU+Y2hlY2tFeGVjPC9jb2RlPi4NCiAgICoNCiAgICogQHBhcmFtIGNtZCB0aGUg
Y29tbWFuZCB0byBjYWxsDQogICAqIEBwYXJhbSBlbnYgdGhlIGVudmlyb25tZW50IHRvIHVzZSwg
aW4gdGhlIGZvcm1hdCBuYW1lPXZhbHVlDQogICAqIEByZXR1cm4gdGhlIFByb2Nlc3Mgb2JqZWN0
DQogICAqIEB0aHJvd3MgU2VjdXJpdHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBpcyBkZW5pZWQN
CiAgICogQHRocm93cyBJT0V4Y2VwdGlvbiBpZiBhbiBJL08gZXJyb3Igb2NjdXJzDQogICAqIEB0
aHJvd3MgTnVsbFBvaW50ZXJFeGNlcHRpb24gaWYgY21kIGlzIG51bGwsIG9yIGNtZCBvciBlbnYg
aGFzIG51bGwNCiAgICogICAgICAgICBlbnRyaWVzDQogICAqIEB0aHJvd3MgSW5kZXhPdXRPZkJv
dW5kc0V4Y2VwdGlvbiBpZiBjbWQgaXMgbGVuZ3RoIDANCiAgICovDQogIHB1YmxpYyBQcm9jZXNz
IGV4ZWMoU3RyaW5nW10gY21kLCBTdHJpbmdbXSBlbnYpIHRocm93cyBJT0V4Y2VwdGlvbg0KICB7
DQogICAgcmV0dXJuIGV4ZWMoY21kLCBlbnYsIG51bGwpOw0KICB9DQoNCiAgLyoqDQogICAqIENy
ZWF0ZSBhIG5ldyBzdWJwcm9jZXNzIHdpdGggdGhlIHNwZWNpZmllZCBjb21tYW5kIGxpbmUsIGFs
cmVhZHkNCiAgICogdG9rZW5pemVkLCBhbmQgdGhlIHNwZWNpZmllZCBlbnZpcm9ubWVudCBhbmQg
d29ya2luZyBkaXJlY3RvcnkuIElmIHRoZQ0KICAgKiBlbnZpcm9ubWVudCBpcyBudWxsLCB0aGUg
cHJvY2VzcyBpbmhlcml0cyB0aGUgZW52aXJvbm1lbnQgb2YgdGhpcw0KICAgKiBwcm9jZXNzLiBJ
ZiB0aGUgZGlyZWN0b3J5IGlzIG51bGwsIHRoZSBwcm9jZXNzIHVzZXMgdGhlIGN1cnJlbnQgd29y
a2luZw0KICAgKiBkaXJlY3RvcnkuIEEgc2VjdXJpdHkgY2hlY2sgaXMgcGVyZm9ybWVkLCA8Y29k
ZT5jaGVja0V4ZWM8L2NvZGU+Lg0KICAgKg0KICAgKiBAcGFyYW0gY21kIHRoZSBjb21tYW5kIHRv
IGNhbGwNCiAgICogQHBhcmFtIGVudiB0aGUgZW52aXJvbm1lbnQgdG8gdXNlLCBpbiB0aGUgZm9y
bWF0IG5hbWU9dmFsdWUNCiAgICogQHBhcmFtIGRpciB0aGUgd29ya2luZyBkaXJlY3RvcnkgdG8g
dXNlDQogICAqIEByZXR1cm4gdGhlIFByb2Nlc3Mgb2JqZWN0DQogICAqIEB0aHJvd3MgU2VjdXJp
dHlFeGNlcHRpb24gaWYgcGVybWlzc2lvbiBpcyBkZW5pZWQNCiAgICogQHRocm93cyBJT0V4Y2Vw
dGlvbiBpZiBhbiBJL08gZXJyb3Igb2NjdXJzDQogICAqIEB0aHJvd3MgTnVsbFBvaW50ZXJFeGNl
cHRpb24gaWYgY21kIGlzIG51bGwsIG9yIGNtZCBvciBlbnYgaGFzIG51bGwNCiAgICogICAgICAg
ICBlbnRyaWVzDQogICAqIEB0aHJvd3MgSW5kZXhPdXRPZkJvdW5kc0V4Y2VwdGlvbiBpZiBjbWQg
aXMgbGVuZ3RoIDANCiAgICogQHNpbmNlIDEuMw0KICAgKi8NCiAgcHVibGljIFByb2Nlc3MgZXhl
YyhTdHJpbmdbXSBjbWQsIFN0cmluZ1tdIGVudiwgRmlsZSBkaXIpDQogICAgdGhyb3dzIElPRXhj
ZXB0aW9uDQogIHsNCiAgICBTZWN1cml0eU1hbmFnZXIgc20gPSBzZWN1cml0eU1hbmFnZXI7IC8v
IEJlIHRocmVhZC1zYWZlIQ0KICAgIGlmIChzbSAhPSBudWxsKQ0KICAgICAgc20uY2hlY2tFeGVj
KGNtZFswXSk7DQogICAgcmV0dXJuIFZNUnVudGltZS5leGVjKGNtZCwgZW52LCBkaXIpOw0KICB9
DQoNCiAgLyoqDQogICAqIFJldHVybnMgdGhlIG51bWJlciBvZiBhdmFpbGFibGUgcHJvY2Vzc29y
cyBjdXJyZW50bHkgYXZhaWxhYmxlIHRvIHRoZQ0KICAgKiB2aXJ0dWFsIG1hY2hpbmUuIFRoaXMg
bnVtYmVyIG1heSBjaGFuZ2Ugb3ZlciB0aW1lOyBzbyBhIG11bHRpLXByb2Nlc3Nvcg0KICAgKiBw
cm9ncmFtIHdhbnQgdG8gcG9sbCB0aGlzIHRvIGRldGVybWluZSBtYXhpbWFsIHJlc291cmNlIHVz
YWdlLg0KICAgKg0KICAgKiBAcmV0dXJuIHRoZSBudW1iZXIgb2YgcHJvY2Vzc29ycyBhdmFpbGFi
bGUsIGF0IGxlYXN0IDENCiAgICovDQogIHB1YmxpYyBpbnQgYXZhaWxhYmxlUHJvY2Vzc29ycygp
DQogIHsNCiAgICByZXR1cm4gVk1SdW50aW1lLmF2YWlsYWJsZVByb2Nlc3NvcnMoKTsNCiAgfQ0K
DQogIC8qKg0KICAgKiBGaW5kIG91dCBob3cgbXVjaCBtZW1vcnkgaXMgc3RpbGwgZnJlZSBmb3Ig
YWxsb2NhdGluZyBPYmplY3RzIG9uIHRoZSBoZWFwLg0KICAgKg0KICAgKiBAcmV0dXJuIHRoZSBu
dW1iZXIgb2YgYnl0ZXMgb2YgZnJlZSBtZW1vcnkgZm9yIG1vcmUgT2JqZWN0cw0KICAgKi8NCiAg
cHVibGljIGxvbmcgZnJlZU1lbW9yeSgpDQogIHsNCiAgICByZXR1cm4gVk1SdW50aW1lLmZyZWVN
ZW1vcnkoKTsNCiAgfQ0KDQogIC8qKg0KICAgKiBGaW5kIG91dCBob3cgbXVjaCBtZW1vcnkgdG90
YWwgaXMgYXZhaWxhYmxlIG9uIHRoZSBoZWFwIGZvciBhbGxvY2F0aW5nDQogICAqIE9iamVjdHMu
DQogICAqDQogICAqIEByZXR1cm4gdGhlIHRvdGFsIG51bWJlciBvZiBieXRlcyBvZiBtZW1vcnkg
Zm9yIE9iamVjdHMNCiAgICovDQogIHB1YmxpYyBsb25nIHRvdGFsTWVtb3J5KCkNCiAgew0KICAg
IHJldHVybiBWTVJ1bnRpbWUudG90YWxNZW1vcnkoKTsNCiAgfQ0KDQogIC8qKg0KICAgKiBSZXR1
cm5zIHRoZSBtYXhpbXVtIGFtb3VudCBvZiBtZW1vcnkgdGhlIHZpcnR1YWwgbWFjaGluZSBjYW4g
YXR0ZW1wdCB0bw0KICAgKiB1c2UuIFRoaXMgbWF5IGJlIDxjb2RlPkxvbmcuTUFYX1ZBTFVFPC9j
b2RlPiBpZiB0aGVyZSBpcyBubyBpbmhlcmVudA0KICAgKiBsaW1pdCAob3IgaWYgeW91IHJlYWxs
eSBkbyBoYXZlIGEgOCBleGFieXRlIG1lbW9yeSEpLg0KICAgKg0KICAgKiBAcmV0dXJuIHRoZSBt
YXhpbXVtIG51bWJlciBvZiBieXRlcyB0aGUgdmlydHVhbCBtYWNoaW5lIHdpbGwgYXR0ZW1wdA0K
ICAgKiAgICAgICAgIHRvIGFsbG9jYXRlDQogICAqLw0KICBwdWJsaWMgbG9uZyBtYXhNZW1vcnko
KQ0KICB7DQogICAgcmV0dXJuIFZNUnVudGltZS5tYXhNZW1vcnkoKTsNCiAgfQ0KDQogIC8qKg0K
ICAgKiBSdW4gdGhlIGdhcmJhZ2UgY29sbGVjdG9yLiBUaGlzIG1ldGhvZCBpcyBtb3JlIG9mIGEg
c3VnZ2VzdGlvbiB0aGFuDQogICAqIGFueXRoaW5nLiBBbGwgdGhpcyBtZXRob2QgZ3VhcmFudGVl
cyBpcyB0aGF0IHRoZSBnYXJiYWdlIGNvbGxlY3RvciB3aWxsDQogICAqIGhhdmUgImRvbmUgaXRz
IGJlc3QiIGJ5IHRoZSB0aW1lIGl0IHJldHVybnMuIE5vdGljZSB0aGF0IGdhcmJhZ2UNCiAgICog
Y29sbGVjdGlvbiB0YWtlcyBwbGFjZSBldmVuIHdpdGhvdXQgY2FsbGluZyB0aGlzIG1ldGhvZC4N
CiAgICovDQogIHB1YmxpYyB2b2lkIGdjKCkNCiAgew0KICAgIFZNUnVudGltZS5nYygpOw0KICB9
DQoNCiAgLyoqDQogICAqIFJ1biBmaW5hbGl6YXRpb24gb24gYWxsIE9iamVjdHMgdGhhdCBhcmUg
d2FpdGluZyB0byBiZSBmaW5hbGl6ZWQuIEFnYWluLA0KICAgKiBhIHN1Z2dlc3Rpb24sIHRob3Vn
aCBhIHN0cm9uZ2VyIG9uZSB0aGFuIHtAbGluayAjZ2MoKX0uIFRoaXMgY2FsbHMgdGhlDQogICAq
IDxjb2RlPmZpbmFsaXplPC9jb2RlPiBtZXRob2Qgb2YgYWxsIG9iamVjdHMgd2FpdGluZyB0byBi
ZSBjb2xsZWN0ZWQuDQogICAqDQogICAqIEBzZWUgI2ZpbmFsaXplKCkNCiAgICovDQogIHB1Ymxp
YyB2b2lkIHJ1bkZpbmFsaXphdGlvbigpDQogIHsNCiAgICBWTVJ1bnRpbWUucnVuRmluYWxpemF0
aW9uKCk7DQogIH0NCg0KICAvKioNCiAgICogVGVsbCB0aGUgVk0gdG8gdHJhY2UgZXZlcnkgYnl0
ZWNvZGUgaW5zdHJ1Y3Rpb24gdGhhdCBleGVjdXRlcyAocHJpbnQgb3V0DQogICAqIGEgdHJhY2Ug
b2YgaXQpLiAgTm8gZ3VhcmFudGVlcyBhcmUgbWFkZSBhcyB0byB3aGVyZSBpdCB3aWxsIGJlIHBy
aW50ZWQsDQogICAqIGFuZCB0aGUgVk0gaXMgYWxsb3dlZCB0byBpZ25vcmUgdGhpcyByZXF1ZXN0
Lg0KICAgKg0KICAgKiBAcGFyYW0gb24gd2hldGhlciB0byB0dXJuIGluc3RydWN0aW9uIHRyYWNp
bmcgb24NCiAgICovDQogIHB1YmxpYyB2b2lkIHRyYWNlSW5zdHJ1Y3Rpb25zKGJvb2xlYW4gb24p
DQogIHsNCiAgICBWTVJ1bnRpbWUudHJhY2VJbnN0cnVjdGlvbnMob24pOw0KICB9DQoNCiAgLyoq
DQogICAqIFRlbGwgdGhlIFZNIHRvIHRyYWNlIGV2ZXJ5IG1ldGhvZCBjYWxsIHRoYXQgZXhlY3V0
ZXMgKHByaW50IG91dCBhIHRyYWNlDQogICAqIG9mIGl0KS4gIE5vIGd1YXJhbnRlZXMgYXJlIG1h
ZGUgYXMgdG8gd2hlcmUgaXQgd2lsbCBiZSBwcmludGVkLCBhbmQgdGhlDQogICAqIFZNIGlzIGFs
bG93ZWQgdG8gaWdub3JlIHRoaXMgcmVxdWVzdC4NCiAgICoNCiAgICogQHBhcmFtIG9uIHdoZXRo
ZXIgdG8gdHVybiBtZXRob2QgdHJhY2luZyBvbg0KICAgKi8NCiAgcHVibGljIHZvaWQgdHJhY2VN
ZXRob2RDYWxscyhib29sZWFuIG9uKQ0KICB7DQogICAgVk1SdW50aW1lLnRyYWNlTWV0aG9kQ2Fs
bHMob24pOw0KICB9DQoNCiAgLyoqDQogICAqIExvYWQgYSBuYXRpdmUgbGlicmFyeSB1c2luZyB0
aGUgc3lzdGVtLWRlcGVuZGVudCBmaWxlbmFtZS4gVGhpcyBpcyBzaW1pbGFyDQogICAqIHRvIGxv
YWRMaWJyYXJ5LCBleGNlcHQgdGhlIG9ubHkgbmFtZSBtYW5nbGluZyBkb25lIGlzIGluc2VydGlu
ZyAiX2ciDQogICAqIGJlZm9yZSB0aGUgZmluYWwgIi5zbyIgaWYgdGhlIFZNIHdhcyBpbnZva2Vk
IGJ5IHRoZSBuYW1lICJqYXZhX2ciLiBUaGVyZQ0KICAgKiBtYXkgYmUgYSBzZWN1cml0eSBjaGVj
aywgb2YgPGNvZGU+Y2hlY2tMaW5rPC9jb2RlPi4NCiAgICoNCiAgICogQHBhcmFtIGZpbGVuYW1l
IHRoZSBmaWxlIHRvIGxvYWQNCiAgICogQHRocm93cyBTZWN1cml0eUV4Y2VwdGlvbiBpZiBwZXJt
aXNzaW9uIGlzIGRlbmllZA0KICAgKiBAdGhyb3dzIFVuc2F0aXNmaWVkTGlua0Vycm9yIGlmIHRo
ZSBsaWJyYXJ5IGlzIG5vdCBmb3VuZA0KICAgKi8NCiAgcHVibGljIHZvaWQgbG9hZChTdHJpbmcg
ZmlsZW5hbWUpDQogIHsNCiAgICBTZWN1cml0eU1hbmFnZXIgc20gPSBzZWN1cml0eU1hbmFnZXI7
IC8vIEJlIHRocmVhZC1zYWZlIQ0KICAgIGlmIChzbSAhPSBudWxsKQ0KICAgICAgc20uY2hlY2tM
aW5rKGZpbGVuYW1lKTsNCiAgICBpZiAoVk1SdW50aW1lLm5hdGl2ZUxvYWQoZmlsZW5hbWUpID09
IDApDQogICAgICB0aHJvdyBuZXcgVW5zYXRpc2ZpZWRMaW5rRXJyb3IoIkNvdWxkIG5vdCBsb2Fk
IGxpYnJhcnkgIiArIGZpbGVuYW1lKTsNCiAgfQ0KDQogIC8qKg0KICAgKiBMb2FkIGEgbmF0aXZl
IGxpYnJhcnkgdXNpbmcgYSBzeXN0ZW0taW5kZXBlbmRlbnQgInNob3J0IG5hbWUiIGZvciB0aGUN
CiAgICogbGlicmFyeS4gIEl0IHdpbGwgYmUgdHJhbnNmb3JtZWQgdG8gYSBjb3JyZWN0IGZpbGVu
YW1lIGluIGENCiAgICogc3lzdGVtLWRlcGVuZGVudCBtYW5uZXIgKGZvciBleGFtcGxlLCBpbiBX
aW5kb3dzLCAibXlsaWIiIHdpbGwgYmUgdHVybmVkDQogICAqIGludG8gIm15bGliLmRsbCIpLiAg
VGhpcyBpcyBkb25lIGFzIGZvbGxvd3M6IGlmIHRoZSBjb250ZXh0IHRoYXQgY2FsbGVkDQogICAq
IGxvYWQgaGFzIGEgQ2xhc3NMb2FkZXIgY2wsIHRoZW4gPGNvZGU+Y2wuZmluZExpYnJhcnkobGli
cGF0aCk8L2NvZGU+IGlzDQogICAqIHVzZWQgdG8gY29udmVydCB0aGUgbmFtZS4gSWYgdGhhdCBy
ZXN1bHQgd2FzIG51bGwsIG9yIHRoZXJlIHdhcyBubyBjbGFzcw0KICAgKiBsb2FkZXIsIHRoaXMg
c2VhcmNoZXMgZWFjaCBkaXJlY3Rvcnkgb2YgdGhlIHN5c3RlbSBwcm9wZXJ0eQ0KICAgKiA8Y29k
ZT5qYXZhLmxpYnJhcnkucGF0aDwvY29kZT4gZm9yIGEgZmlsZSBuYW1lZA0KICAgKiA8Y29kZT5T
eXN0ZW0ubWFwTGlicmFyeU5hbWUobGlibmFtZSk8L2NvZGU+LiBUaGVyZSBtYXkgYmUgYSBzZWN1
cml0eQ0KICAgKiBjaGVjaywgb2YgPGNvZGU+Y2hlY2tMaW5rPC9jb2RlPi4NCiAgICoNCiAgICog
QHBhcmFtIGZpbGVuYW1lIHRoZSBmaWxlIHRvIGxvYWQNCiAgICogQHRocm93cyBTZWN1cml0eUV4
Y2VwdGlvbiBpZiBwZXJtaXNzaW9uIGlzIGRlbmllZA0KICAgKiBAdGhyb3dzIFVuc2F0aXNmaWVk
TGlua0Vycm9yIGlmIHRoZSBsaWJyYXJ5IGlzIG5vdCBmb3VuZA0KICAgKiBAc2VlIFN5c3RlbSNt
YXBMaWJyYXJ5TmFtZShTdHJpbmcpDQogICAqIEBzZWUgQ2xhc3NMb2FkZXIjZmluZExpYnJhcnko
U3RyaW5nKQ0KICAgKi8NCiAgcHVibGljIHZvaWQgbG9hZExpYnJhcnkoU3RyaW5nIGxpYm5hbWUp
DQogIHsNCiAgICBTdHJpbmcgZmlsZW5hbWU7DQogICAgQ2xhc3NMb2FkZXIgY2wgPSBWTVNlY3Vy
aXR5TWFuYWdlci5jdXJyZW50Q2xhc3NMb2FkZXIoKTsNCiAgICBpZiAoY2wgIT0gbnVsbCkNCiAg
ICAgIHsNCiAgICAgICAgZmlsZW5hbWUgPSBjbC5maW5kTGlicmFyeShsaWJuYW1lKTsNCiAgICAg
ICAgaWYgKGZpbGVuYW1lICE9IG51bGwpDQogICAgICAgICAgew0KICAgICAgICAgICAgbG9hZChm
aWxlbmFtZSk7DQogICAgICAgICAgICByZXR1cm47DQogICAgICAgICAgfQ0KICAgICAgfQ0KICAg
IGZpbGVuYW1lID0gU3lzdGVtLm1hcExpYnJhcnlOYW1lKGxpYm5hbWUpOw0KICAgIGZvciAoaW50
IGkgPSAwOyBpIDwgbGlicGF0aC5sZW5ndGg7IGkrKykNCiAgICAgIHRyeQ0KICAgICAgICB7DQog
ICAgICAgICAgbG9hZChsaWJwYXRoW2ldICsgZmlsZW5hbWUpOw0KICAgICAgICAgIHJldHVybjsN
CiAgICAgICAgfQ0KICAgICAgY2F0Y2ggKFVuc2F0aXNmaWVkTGlua0Vycm9yIGUpDQogICAgICAg
IHsNCiAgICAgICAgICAvLyBUcnkgbmV4dCBwYXRoIGVsZW1lbnQuDQogICAgICAgIH0NCiAgICB0
aHJvdyBuZXcgVW5zYXRpc2ZpZWRMaW5rRXJyb3IoIkNvdWxkIG5vdCBmaW5kIGxpYnJhcnkgIiAr
IGxpYm5hbWUgKyAiLiIpOw0KICB9DQoNCiAgLyoqDQogICAqIFJldHVybiBhIGxvY2FsaXplZCB2
ZXJzaW9uIG9mIHRoaXMgSW5wdXRTdHJlYW0sIG1lYW5pbmcgYWxsIGNoYXJhY3RlcnMNCiAgICog
YXJlIGxvY2FsaXplZCBiZWZvcmUgdGhleSBjb21lIG91dCB0aGUgb3RoZXIgZW5kLg0KICAgKg0K
ICAgKiBAcGFyYW0gaW4gdGhlIHN0cmVhbSB0byBsb2NhbGl6ZQ0KICAgKiBAcmV0dXJuIHRoZSBs
b2NhbGl6ZWQgc3RyZWFtDQogICAqIEBkZXByZWNhdGVkIDxjb2RlPklucHV0U3RyZWFtUmVhZGVy
PC9jb2RlPiBpcyB0aGUgcHJlZmVycmVkIHdheSB0byByZWFkDQogICAqICAgICAgICAgICAgIGxv
Y2FsIGVuY29kaW5ncw0KICAgKiBAWFhYIFRoaXMgaW1wbGVtZW50YXRpb24gZG9lcyBub3QgbG9j
YWxpemUsIHlldC4NCiAgICovDQogIHB1YmxpYyBJbnB1dFN0cmVhbSBnZXRMb2NhbGl6ZWRJbnB1
dFN0cmVhbShJbnB1dFN0cmVhbSBpbikNCiAgew0KICAgIHJldHVybiBpbjsNCiAgfQ0KDQogIC8q
Kg0KICAgKiBSZXR1cm4gYSBsb2NhbGl6ZWQgdmVyc2lvbiBvZiB0aGlzIE91dHB1dFN0cmVhbSwg
bWVhbmluZyBhbGwgY2hhcmFjdGVycw0KICAgKiBhcmUgbG9jYWxpemVkIGJlZm9yZSB0aGV5IGFy
ZSBzZW50IHRvIHRoZSBvdGhlciBlbmQuDQogICAqDQogICAqIEBwYXJhbSBvdXQgdGhlIHN0cmVh
bSB0byBsb2NhbGl6ZQ0KICAgKiBAcmV0dXJuIHRoZSBsb2NhbGl6ZWQgc3RyZWFtDQogICAqIEBk
ZXByZWNhdGVkIDxjb2RlPk91dHB1dFN0cmVhbVdyaXRlcjwvY29kZT4gaXMgdGhlIHByZWZlcnJl
ZCB3YXkgdG8gd3JpdGUNCiAgICogICAgICAgICAgICAgbG9jYWwgZW5jb2RpbmdzDQogICAqIEBY
WFggVGhpcyBpbXBsZW1lbnRhdGlvbiBkb2VzIG5vdCBsb2NhbGl6ZSwgeWV0Lg0KICAgKi8NCiAg
cHVibGljIE91dHB1dFN0cmVhbSBnZXRMb2NhbGl6ZWRPdXRwdXRTdHJlYW0oT3V0cHV0U3RyZWFt
IG91dCkNCiAgew0KICAgIHJldHVybiBvdXQ7DQogIH0NCn0gLy8gY2xhc3MgUnVudGltZQ0K

------_=_NextPart_001_01C3B1C9.2007AE55
Content-Type: application/octet-stream;
	name="VMRuntime.java"
Content-Transfer-Encoding: base64
Content-Description: VMRuntime.java
Content-Disposition: attachment;
	filename="VMRuntime.java"

LyogVk1SdW50aW1lLmphdmEgLS0gVk0gaW50ZXJmYWNlIHRvIFJ1bnRpbWUNCiAgIENvcHlyaWdo
dCAoQykgMjAwMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24NCg0KVGhpcyBmaWxlIGlzIHBhcnQg
b2YgR05VIENsYXNzcGF0aC4NCg0KR05VIENsYXNzcGF0aCBpcyBmcmVlIHNvZnR3YXJlOyB5b3Ug
Y2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQppdCB1bmRlciB0aGUgdGVybXMgb2Yg
dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KdGhlIEZyZWUg
U29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiwgb3IgKGF0IHlvdXIgb3B0aW9u
KQ0KYW55IGxhdGVyIHZlcnNpb24uDQoNCkdOVSBDbGFzc3BhdGggaXMgZGlzdHJpYnV0ZWQgaW4g
dGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0DQpXSVRIT1VUIEFOWSBXQVJSQU5U
WTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQpNRVJDSEFOVEFCSUxJVFkg
b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQ0KR2VuZXJh
bCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLg0KDQpZb3Ugc2hvdWxkIGhhdmUgcmVj
ZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQ0KYWxvbmcgd2l0
aCBHTlUgQ2xhc3NwYXRoOyBzZWUgdGhlIGZpbGUgQ09QWUlORy4gIElmIG5vdCwgd3JpdGUgdG8g
dGhlDQpGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSwgU3Vp
dGUgMzMwLCBCb3N0b24sIE1BDQowMjExMS0xMzA3IFVTQS4NCg0KTGlua2luZyB0aGlzIGxpYnJh
cnkgc3RhdGljYWxseSBvciBkeW5hbWljYWxseSB3aXRoIG90aGVyIG1vZHVsZXMgaXMNCm1ha2lu
ZyBhIGNvbWJpbmVkIHdvcmsgYmFzZWQgb24gdGhpcyBsaWJyYXJ5LiAgVGh1cywgdGhlIHRlcm1z
IGFuZA0KY29uZGl0aW9ucyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgY292ZXIg
dGhlIHdob2xlDQpjb21iaW5hdGlvbi4NCg0KQXMgYSBzcGVjaWFsIGV4Y2VwdGlvbiwgdGhlIGNv
cHlyaWdodCBob2xkZXJzIG9mIHRoaXMgbGlicmFyeSBnaXZlIHlvdQ0KcGVybWlzc2lvbiB0byBs
aW5rIHRoaXMgbGlicmFyeSB3aXRoIGluZGVwZW5kZW50IG1vZHVsZXMgdG8gcHJvZHVjZSBhbg0K
ZXhlY3V0YWJsZSwgcmVnYXJkbGVzcyBvZiB0aGUgbGljZW5zZSB0ZXJtcyBvZiB0aGVzZSBpbmRl
cGVuZGVudA0KbW9kdWxlcywgYW5kIHRvIGNvcHkgYW5kIGRpc3RyaWJ1dGUgdGhlIHJlc3VsdGlu
ZyBleGVjdXRhYmxlIHVuZGVyDQp0ZXJtcyBvZiB5b3VyIGNob2ljZSwgcHJvdmlkZWQgdGhhdCB5
b3UgYWxzbyBtZWV0LCBmb3IgZWFjaCBsaW5rZWQNCmluZGVwZW5kZW50IG1vZHVsZSwgdGhlIHRl
cm1zIGFuZCBjb25kaXRpb25zIG9mIHRoZSBsaWNlbnNlIG9mIHRoYXQNCm1vZHVsZS4gIEFuIGlu
ZGVwZW5kZW50IG1vZHVsZSBpcyBhIG1vZHVsZSB3aGljaCBpcyBub3QgZGVyaXZlZCBmcm9tDQpv
ciBiYXNlZCBvbiB0aGlzIGxpYnJhcnkuICBJZiB5b3UgbW9kaWZ5IHRoaXMgbGlicmFyeSwgeW91
IG1heSBleHRlbmQNCnRoaXMgZXhjZXB0aW9uIHRvIHlvdXIgdmVyc2lvbiBvZiB0aGUgbGlicmFy
eSwgYnV0IHlvdSBhcmUgbm90DQpvYmxpZ2F0ZWQgdG8gZG8gc28uICBJZiB5b3UgZG8gbm90IHdp
c2ggdG8gZG8gc28sIGRlbGV0ZSB0aGlzDQpleGNlcHRpb24gc3RhdGVtZW50IGZyb20geW91ciB2
ZXJzaW9uLiAqLw0KDQpwYWNrYWdlIGphdmEubGFuZzsNCg0KaW1wb3J0IGphdmEuaW8uRmlsZTsN
CmltcG9ydCBqYXZhLnV0aWwuUHJvcGVydGllczsNCg0KLyoqDQogKiBWTVJ1bnRpbWUgcmVwcmVz
ZW50cyB0aGUgaW50ZXJmYWNlIHRvIHRoZSBWaXJ0dWFsIE1hY2hpbmUuDQogKg0KICogQGF1dGhv
ciBKZXJvZW4gRnJpanRlcnMNCiAqLw0KZmluYWwgY2xhc3MgVk1SdW50aW1lDQp7DQogICAgLyoq
DQogICAgICogTm8gaW5zdGFuY2UgaXMgZXZlciBjcmVhdGVkLg0KICAgICAqLw0KICAgIHByaXZh
dGUgVk1SdW50aW1lKCkgDQogICAgew0KICAgIH0NCg0KICAgIC8qKg0KICAgICAqIFJldHVybnMg
dGhlIG51bWJlciBvZiBhdmFpbGFibGUgcHJvY2Vzc29ycyBjdXJyZW50bHkgYXZhaWxhYmxlIHRv
IHRoZQ0KICAgICAqIHZpcnR1YWwgbWFjaGluZS4gVGhpcyBudW1iZXIgbWF5IGNoYW5nZSBvdmVy
IHRpbWU7IHNvIGEgbXVsdGktcHJvY2Vzc29yDQogICAgICogcHJvZ3JhbSB3YW50IHRvIHBvbGwg
dGhpcyB0byBkZXRlcm1pbmUgbWF4aW1hbCByZXNvdXJjZSB1c2FnZS4NCiAgICAgKg0KICAgICAq
IEByZXR1cm4gdGhlIG51bWJlciBvZiBwcm9jZXNzb3JzIGF2YWlsYWJsZSwgYXQgbGVhc3QgMQ0K
ICAgICAqLw0KICAgIHN0YXRpYyBuYXRpdmUgaW50IGF2YWlsYWJsZVByb2Nlc3NvcnMoKTsNCg0K
ICAgIC8qKg0KICAgICAqIEZpbmQgb3V0IGhvdyBtdWNoIG1lbW9yeSBpcyBzdGlsbCBmcmVlIGZv
ciBhbGxvY2F0aW5nIE9iamVjdHMgb24gdGhlIGhlYXAuDQogICAgICoNCiAgICAgKiBAcmV0dXJu
IHRoZSBudW1iZXIgb2YgYnl0ZXMgb2YgZnJlZSBtZW1vcnkgZm9yIG1vcmUgT2JqZWN0cw0KICAg
ICAqLw0KICAgIHN0YXRpYyBuYXRpdmUgbG9uZyBmcmVlTWVtb3J5KCk7DQoNCiAgICAvKioNCiAg
ICAgKiBGaW5kIG91dCBob3cgbXVjaCBtZW1vcnkgdG90YWwgaXMgYXZhaWxhYmxlIG9uIHRoZSBo
ZWFwIGZvciBhbGxvY2F0aW5nDQogICAgICogT2JqZWN0cy4NCiAgICAgKg0KICAgICAqIEByZXR1
cm4gdGhlIHRvdGFsIG51bWJlciBvZiBieXRlcyBvZiBtZW1vcnkgZm9yIE9iamVjdHMNCiAgICAg
Ki8NCiAgICBzdGF0aWMgbmF0aXZlIGxvbmcgdG90YWxNZW1vcnkoKTsNCg0KICAgIC8qKg0KICAg
ICAqIFJldHVybnMgdGhlIG1heGltdW0gYW1vdW50IG9mIG1lbW9yeSB0aGUgdmlydHVhbCBtYWNo
aW5lIGNhbiBhdHRlbXB0IHRvDQogICAgICogdXNlLiBUaGlzIG1heSBiZSA8Y29kZT5Mb25nLk1B
WF9WQUxVRTwvY29kZT4gaWYgdGhlcmUgaXMgbm8gaW5oZXJlbnQNCiAgICAgKiBsaW1pdCAob3Ig
aWYgeW91IHJlYWxseSBkbyBoYXZlIGEgOCBleGFieXRlIG1lbW9yeSEpLg0KICAgICAqDQogICAg
ICogQHJldHVybiB0aGUgbWF4aW11bSBudW1iZXIgb2YgYnl0ZXMgdGhlIHZpcnR1YWwgbWFjaGlu
ZSB3aWxsIGF0dGVtcHQNCiAgICAgKiAgICAgICAgIHRvIGFsbG9jYXRlDQogICAgICovDQogICAg
c3RhdGljIG5hdGl2ZSBsb25nIG1heE1lbW9yeSgpOw0KDQogICAgLyoqDQogICAgICogUnVuIHRo
ZSBnYXJiYWdlIGNvbGxlY3Rvci4gVGhpcyBtZXRob2QgaXMgbW9yZSBvZiBhIHN1Z2dlc3Rpb24g
dGhhbg0KICAgICAqIGFueXRoaW5nLiBBbGwgdGhpcyBtZXRob2QgZ3VhcmFudGVlcyBpcyB0aGF0
IHRoZSBnYXJiYWdlIGNvbGxlY3RvciB3aWxsDQogICAgICogaGF2ZSAiZG9uZSBpdHMgYmVzdCIg
YnkgdGhlIHRpbWUgaXQgcmV0dXJucy4gTm90aWNlIHRoYXQgZ2FyYmFnZQ0KICAgICAqIGNvbGxl
Y3Rpb24gdGFrZXMgcGxhY2UgZXZlbiB3aXRob3V0IGNhbGxpbmcgdGhpcyBtZXRob2QuDQogICAg
ICovDQogICAgc3RhdGljIG5hdGl2ZSB2b2lkIGdjKCk7DQoNCiAgICAvKioNCiAgICAgKiBSdW4g
ZmluYWxpemF0aW9uIG9uIGFsbCBPYmplY3RzIHRoYXQgYXJlIHdhaXRpbmcgdG8gYmUgZmluYWxp
emVkLiBBZ2FpbiwNCiAgICAgKiBhIHN1Z2dlc3Rpb24sIHRob3VnaCBhIHN0cm9uZ2VyIG9uZSB0
aGFuIHtAbGluayAjZ2MoKX0uIFRoaXMgY2FsbHMgdGhlDQogICAgICogPGNvZGU+ZmluYWxpemU8
L2NvZGU+IG1ldGhvZCBvZiBhbGwgb2JqZWN0cyB3YWl0aW5nIHRvIGJlIGNvbGxlY3RlZC4NCiAg
ICAgKg0KICAgICAqIEBzZWUgI2ZpbmFsaXplKCkNCiAgICAgKi8NCiAgICBzdGF0aWMgbmF0aXZl
IHZvaWQgcnVuRmluYWxpemF0aW9uKCk7DQoNCiAgICAvKioNCiAgICAgKiBSdW4gZmluYWxpemF0
aW9uIG9uIGFsbCBmaW5hbGl6YWJsZSBPYmplY3RzIChldmVuIGxpdmUgb25lcykuIFRoaXMNCiAg
ICAgKiBzaG91bGQgb25seSBiZSBjYWxsZWQgaW1tZWRpYXRlbHkgcHJpb3IgdG8gVk0gdGVybWlu
YXRpb24uDQogICAgICoNCiAgICAgKiBAc2VlICNmaW5hbGl6ZSgpDQogICAgICovDQogICAgc3Rh
dGljIG5hdGl2ZSB2b2lkIHJ1bkZpbmFsaXphdGlvbkZvckV4aXQoKTsNCg0KICAgIC8qKg0KICAg
ICAqIFRlbGwgdGhlIFZNIHRvIHRyYWNlIGV2ZXJ5IGJ5dGVjb2RlIGluc3RydWN0aW9uIHRoYXQg
ZXhlY3V0ZXMgKHByaW50IG91dA0KICAgICAqIGEgdHJhY2Ugb2YgaXQpLiAgTm8gZ3VhcmFudGVl
cyBhcmUgbWFkZSBhcyB0byB3aGVyZSBpdCB3aWxsIGJlIHByaW50ZWQsDQogICAgICogYW5kIHRo
ZSBWTSBpcyBhbGxvd2VkIHRvIGlnbm9yZSB0aGlzIHJlcXVlc3QuDQogICAgICoNCiAgICAgKiBA
cGFyYW0gb24gd2hldGhlciB0byB0dXJuIGluc3RydWN0aW9uIHRyYWNpbmcgb24NCiAgICAgKi8N
CiAgICBzdGF0aWMgbmF0aXZlIHZvaWQgdHJhY2VJbnN0cnVjdGlvbnMoYm9vbGVhbiBvbik7DQoN
CiAgICAvKioNCiAgICAgKiBUZWxsIHRoZSBWTSB0byB0cmFjZSBldmVyeSBtZXRob2QgY2FsbCB0
aGF0IGV4ZWN1dGVzIChwcmludCBvdXQgYSB0cmFjZQ0KICAgICAqIG9mIGl0KS4gIE5vIGd1YXJh
bnRlZXMgYXJlIG1hZGUgYXMgdG8gd2hlcmUgaXQgd2lsbCBiZSBwcmludGVkLCBhbmQgdGhlDQog
ICAgICogVk0gaXMgYWxsb3dlZCB0byBpZ25vcmUgdGhpcyByZXF1ZXN0Lg0KICAgICAqDQogICAg
ICogQHBhcmFtIG9uIHdoZXRoZXIgdG8gdHVybiBtZXRob2QgdHJhY2luZyBvbg0KICAgICAqLw0K
ICAgIHN0YXRpYyBuYXRpdmUgdm9pZCB0cmFjZU1ldGhvZENhbGxzKGJvb2xlYW4gb24pOw0KDQog
ICAgLyoqDQogICAgICogTmF0aXZlIG1ldGhvZCB0aGF0IGFjdHVhbGx5IHNldHMgdGhlIGZpbmFs
aXplciBzZXR0aW5nLg0KICAgICAqDQogICAgICogQHBhcmFtIHZhbHVlIHdoZXRoZXIgdG8gcnVu
IGZpbmFsaXplcnMgb24gZXhpdA0KICAgICAqLw0KICAgIHN0YXRpYyBuYXRpdmUgdm9pZCBydW5G
aW5hbGl6ZXJzT25FeGl0KGJvb2xlYW4gdmFsdWUpOw0KDQogICAgLyoqDQogICAgICogTmF0aXZl
IG1ldGhvZCB0aGF0IGFjdHVhbGx5IHNodXRzIGRvd24gdGhlIHZpcnR1YWwgbWFjaGluZS4NCiAg
ICAgKg0KICAgICAqIEBwYXJhbSBzdGF0dXMgdGhlIHN0YXR1cyB0byBlbmQgdGhlIHByb2Nlc3Mg
d2l0aA0KICAgICAqLw0KICAgIHN0YXRpYyBuYXRpdmUgdm9pZCBleGl0KGludCBzdGF0dXMpOw0K
DQogICAgLyoqDQogICAgICogTG9hZCBhIGZpbGUuIElmIGl0IGhhcyBhbHJlYWR5IGJlZW4gbG9h
ZGVkLCBkbyBub3RoaW5nLiBUaGUgbmFtZSBoYXMNCiAgICAgKiBhbHJlYWR5IGJlZW4gbWFwcGVk
IHRvIGEgdHJ1ZSBmaWxlbmFtZS4NCiAgICAgKg0KICAgICAqIEBwYXJhbSBmaWxlbmFtZSB0aGUg
ZmlsZSB0byBsb2FkDQogICAgICogQHJldHVybiAwIG9uIGZhaWx1cmUsIG5vbnplcm8gb24gc3Vj
Y2Vzcw0KICAgICAqLw0KICAgIHN0YXRpYyBuYXRpdmUgaW50IG5hdGl2ZUxvYWQoU3RyaW5nIGZp
bGVuYW1lKTsNCg0KICAgIC8qKg0KICAgICAqIE1hcCBhIHN5c3RlbS1pbmRlcGVuZGVudCAic2hv
cnQgbmFtZSIgdG8gdGhlIGZ1bGwgZmlsZSBuYW1lLCBhbmQgYXBwZW5kDQogICAgICogaXQgdG8g
dGhlIHBhdGguDQogICAgICogWFhYIFRoaXMgbWV0aG9kIGlzIGJlaW5nIHJlcGxhY2VkIGJ5IFN5
c3RlbS5tYXBMaWJyYXJ5TmFtZS4NCiAgICAgKg0KICAgICAqIEBwYXJhbSBwYXRobmFtZSB0aGUg
cGF0aA0KICAgICAqIEBwYXJhbSBsaWJuYW1lIHRoZSBzaG9ydCB2ZXJzaW9uIG9mIHRoZSBsaWJy
YXJ5IG5hbWUNCiAgICAgKiBAcmV0dXJuIHRoZSBmdWxsIGZpbGVuYW1lDQogICAgICovDQogICAg
c3RhdGljIG5hdGl2ZSBTdHJpbmcgbmF0aXZlR2V0TGlibmFtZShTdHJpbmcgcGF0aG5hbWUsIFN0
cmluZyBsaWJuYW1lKTsNCg0KICAgIC8qKg0KICAgICAqIEV4ZWN1dGUgYSBwcm9jZXNzLiBUaGUg
Y29tbWFuZCBsaW5lIGhhcyBhbHJlYWR5IGJlZW4gdG9rZW5pemVkLCBhbmQNCiAgICAgKiB0aGUg
ZW52aXJvbm1lbnQgc2hvdWxkIGNvbnRhaW4gbmFtZT12YWx1ZSBtYXBwaW5ncy4gSWYgZGlyZWN0
b3J5IGlzIG51bGwsDQogICAgICogdXNlIHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5OyBv
dGhlcndpc2Ugc3RhcnQgdGhlIHByb2Nlc3MgaW4gdGhhdA0KICAgICAqIGRpcmVjdG9yeS4gIElm
IGVudiBpcyBudWxsLCB0aGVuIHRoZSBuZXcgcHJvY2VzcyBzaG91bGQgaW5oZXJpdA0KICAgICAq
IHRoZSBlbnZpcm9ubWVudCBvZiB0aGlzIHByb2Nlc3MuDQogICAgICoNCiAgICAgKiBAcGFyYW0g
Y21kIHRoZSBub24tbnVsbCBjb21tYW5kIHRva2Vucw0KICAgICAqIEBwYXJhbSBlbnYgdGhlIGVu
dmlyb25tZW50IHNldHVwDQogICAgICogQHBhcmFtIGRpciB0aGUgZGlyZWN0b3J5IHRvIHVzZSwg
bWF5IGJlIG51bGwNCiAgICAgKiBAcmV0dXJuIHRoZSBuZXdseSBjcmVhdGVkIHByb2Nlc3MNCiAg
ICAgKiBAdGhyb3dzIE51bGxQb2ludGVyRXhjZXB0aW9uIGlmIGNtZCBvciBlbnYgaGF2ZSBudWxs
IGVsZW1lbnRzDQogICAgICovDQogICAgc3RhdGljIG5hdGl2ZSBQcm9jZXNzIGV4ZWMoU3RyaW5n
W10gY21kLCBTdHJpbmdbXSBlbnYsIEZpbGUgZGlyKTsNCg0KICAgIC8qKg0KICAgICAqIEdldCB0
aGUgc3lzdGVtIHByb3BlcnRpZXMuIFRoaXMgaXMgZG9uZSBoZXJlLCBpbnN0ZWFkIG9mIGluIFN5
c3RlbSwNCiAgICAgKiBiZWNhdXNlIG9mIHRoZSBib290c3RyYXAgc2VxdWVuY2UuIE5vdGUgdGhh
dCB0aGUgbmF0aXZlIGNvZGUgc2hvdWxkDQogICAgICogbm90IHRyeSB0byB1c2UgdGhlIEphdmEg
SS9PIGNsYXNzZXMgeWV0LCBhcyB0aGV5IHJlbHkgb24gdGhlIHByb3BlcnRpZXMNCiAgICAgKiBh
bHJlYWR5IGV4aXN0aW5nLiBUaGUgb25seSBzYWZlIG1ldGhvZCB0byB1c2UgdG8gaW5zZXJ0IHRo
ZXNlIGRlZmF1bHQNCiAgICAgKiBzeXN0ZW0gcHJvcGVydGllcyBpcyB7QGxpbmsgUHJvcGVydGll
cyNzZXRQcm9wZXJ0eShTdHJpbmcsIFN0cmluZyl9Lg0KICAgICAqDQogICAgICogPHA+VGhlc2Ug
cHJvcGVydGllcyBNVVNUIGluY2x1ZGU6DQogICAgICogPGRsPg0KICAgICAqIDxkdD5qYXZhLnZl
cnNpb24gICAgICAgICA8ZGQ+SmF2YSB2ZXJzaW9uIG51bWJlcg0KICAgICAqIDxkdD5qYXZhLnZl
bmRvciAgICAgICAgICA8ZGQ+SmF2YSB2ZW5kb3Igc3BlY2lmaWMgc3RyaW5nDQogICAgICogPGR0
PmphdmEudmVuZG9yLnVybCAgICAgIDxkZD5KYXZhIHZlbmRvciBVUkwNCiAgICAgKiA8ZHQ+amF2
YS5ob21lICAgICAgICAgICAgPGRkPkphdmEgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeQ0KICAgICAq
IDxkdD5qYXZhLnZtLnNwZWNpZmljYXRpb24udmVyc2lvbiA8ZGQ+Vk0gU3BlYyB2ZXJzaW9uDQog
ICAgICogPGR0PmphdmEudm0uc3BlY2lmaWNhdGlvbi52ZW5kb3IgIDxkZD5WTSBTcGVjIHZlbmRv
cg0KICAgICAqIDxkdD5qYXZhLnZtLnNwZWNpZmljYXRpb24ubmFtZSAgICA8ZGQ+Vk0gU3BlYyBu
YW1lDQogICAgICogPGR0PmphdmEudm0udmVyc2lvbiAgICAgIDxkZD5WTSBpbXBsZW1lbnRhdGlv
biB2ZXJzaW9uDQogICAgICogPGR0PmphdmEudm0udmVuZG9yICAgICAgIDxkZD5WTSBpbXBsZW1l
bnRhdGlvbiB2ZW5kb3INCiAgICAgKiA8ZHQ+amF2YS52bS5uYW1lICAgICAgICAgPGRkPlZNIGlt
cGxlbWVudGF0aW9uIG5hbWUNCiAgICAgKiA8ZHQ+amF2YS5zcGVjaWZpY2F0aW9uLnZlcnNpb24g
ICAgPGRkPkphdmEgUnVudGltZSBFbnZpcm9ubWVudCB2ZXJzaW9uDQogICAgICogPGR0PmphdmEu
c3BlY2lmaWNhdGlvbi52ZW5kb3IgICAgIDxkZD5KYXZhIFJ1bnRpbWUgRW52aXJvbm1lbnQgdmVu
ZG9yDQogICAgICogPGR0PmphdmEuc3BlY2lmaWNhdGlvbi5uYW1lICAgICAgIDxkZD5KYXZhIFJ1
bnRpbWUgRW52aXJvbm1lbnQgbmFtZQ0KICAgICAqIDxkdD5qYXZhLmNsYXNzLnZlcnNpb24gICA8
ZGQ+SmF2YSBjbGFzcyB2ZXJzaW9uIG51bWJlcg0KICAgICAqIDxkdD5qYXZhLmNsYXNzLnBhdGgg
ICAgICA8ZGQ+SmF2YSBjbGFzc3BhdGgNCiAgICAgKiA8ZHQ+amF2YS5saWJyYXJ5LnBhdGggICAg
PGRkPlBhdGggZm9yIGZpbmRpbmcgSmF2YSBsaWJyYXJpZXMNCiAgICAgKiA8ZHQ+amF2YS5pby50
bXBkaXIgICAgICAgPGRkPkRlZmF1bHQgdGVtcCBmaWxlIHBhdGgNCiAgICAgKiA8ZHQ+amF2YS5j
b21waWxlciAgICAgICAgPGRkPk5hbWUgb2YgSklUIHRvIHVzZQ0KICAgICAqIDxkdD5qYXZhLmV4
dC5kaXJzICAgICAgICA8ZGQ+SmF2YSBleHRlbnNpb24gcGF0aA0KICAgICAqIDxkdD5vcy5uYW1l
ICAgICAgICAgICAgICA8ZGQ+T3BlcmF0aW5nIFN5c3RlbSBOYW1lDQogICAgICogPGR0Pm9zLmFy
Y2ggICAgICAgICAgICAgIDxkZD5PcGVyYXRpbmcgU3lzdGVtIEFyY2hpdGVjdHVyZQ0KICAgICAq
IDxkdD5vcy52ZXJzaW9uICAgICAgICAgICA8ZGQ+T3BlcmF0aW5nIFN5c3RlbSBWZXJzaW9uDQog
ICAgICogPGR0PmZpbGUuc2VwYXJhdG9yICAgICAgIDxkZD5GaWxlIHNlcGFyYXRvciAoIi8iIG9u
IFVuaXgpDQogICAgICogPGR0PnBhdGguc2VwYXJhdG9yICAgICAgIDxkZD5QYXRoIHNlcGFyYXRv
ciAoIjoiIG9uIFVuaXgpDQogICAgICogPGR0PmxpbmUuc2VwYXJhdG9yICAgICAgIDxkZD5MaW5l
IHNlcGFyYXRvciAoIlxuIiBvbiBVbml4KQ0KICAgICAqIDxkdD51c2VyLm5hbWUgICAgICAgICAg
ICA8ZGQ+VXNlciBhY2NvdW50IG5hbWUNCiAgICAgKiA8ZHQ+dXNlci5ob21lICAgICAgICAgICAg
PGRkPlVzZXIgaG9tZSBkaXJlY3RvcnkNCiAgICAgKiA8ZHQ+dXNlci5kaXIgICAgICAgICAgICAg
PGRkPlVzZXIncyBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5DQogICAgICogPC9kbD4NCiAgICAg
Kg0KICAgICAqIEBwYXJhbSBwIHRoZSBQcm9wZXJ0aWVzIG9iamVjdCB0byBpbnNlcnQgdGhlIHN5
c3RlbSBwcm9wZXJ0aWVzIGludG8NCiAgICAgKi8NCiAgICBzdGF0aWMgbmF0aXZlIHZvaWQgaW5z
ZXJ0U3lzdGVtUHJvcGVydGllcyhQcm9wZXJ0aWVzIHApOw0KfSAvLyBjbGFzcyBWTVJ1bnRpbWUN
Cg==

------_=_NextPart_001_01C3B1C9.2007AE55--



From MAILER-DAEMON Sun Nov 23 10:10:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANvt0-0003bI-Cy
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 10:10:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANvsx-0003aH-LI
	for classpath@gnu.org; Sun, 23 Nov 2003 10:10:51 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANvsR-0003UV-K8
	for classpath@gnu.org; Sun, 23 Nov 2003 10:10:50 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANvsR-0003UO-3X
	for classpath@gnu.org; Sun, 23 Nov 2003 10:10:19 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ANutZ-0004Zi-00; Sun, 23 Nov 2003 15:07:25 +0100
From: Mark Wielaard <mark@klomp.org>
To: John Leuner <jewel@pixie.co.za>
In-Reply-To: <1069591413.8527.13.camel@cmalu>
References: <C1D121A526FE6A45A6CEA40AD1D99BECF423F0@EXC001.prism.co.jp>
	<1069591413.8527.13.camel@cmalu>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-O/FQUZK8d73nisixBbUt"
Message-Id: <1069596475.2851.1102.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 23 Nov 2003 15:07:55 +0100
Cc: =?UTF-8?Q?=E9=87=91_=E6=9D=B1?= =?UTF-8?Q?=E4=B9=85?= <kdon@prism.co.jp>,
	jazzlib-developers@lists.sourceforge.net, classpath@gnu.org
Subject: Re: Classpath licensing (Re: About the java.util.zip project)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 15:10:52 -0000


--=-O/FQUZK8d73nisixBbUt
Content-Type: text/plain; charset=iso-8859-13
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2003-11-23 at 13:48, John Leuner wrote:
> I am copying this to the jazzlib and classpath MLs to get some other
> peoples' opinions on the Classpath license and how it should apply in a
> case like this.

Best is to direct such questions to licensing@gnu.org. The FSF is the
official copyright holder of Classpath and sets the distribution terms.

> > My company makes commercial software. And, I work to make a module
> > which makes a zip file from files by Java.
> >=20
> > So, I want to use your library. But I read the license at the
> > homepage(http://jazzlib.sourceforge.net/).
> >=20
> > I think the license on your homepage means that I can use the library
> > freely and I don=FFt need to obey the GPL license=20
>=20
> No, the license says you MUST obey the GPL with one special exception
> ...
>=20
> > if I use the library only by means of called the library to make a
> > executable.
>=20
> If you combine jazzlib "with independent modules to produce an
> executable" you can "copy and distribute the resulting executable under
> terms of your choice".
>=20
> So you can use jazzlib in your program without changing the license of
> your commercial software.

I believe John his interpretation is correct, but see below.

> > For sure, if you can give me an answer for some questions, I am very
> > happy for it.
> >=20
> > 1) If I use your library without change(source code) to make a
> > commercial ziputility, should I open my ziputility source code?
>=20
> The license says you must combine with "independent modules". If you
> write a commercial zip utility I am not sure that this other code will
> be "an independent module".

Best is to write with a clear example of how you plan do this and what
the distribution terms of the larger work are to licensing@gnu.org so
they can give advise on what is and isn't considered an independent
module.

> > 2) If I should open my source code, is there other method not to do
> > this? For example, we can pay for the license.
>=20
> No, I doubt this is possible.

The FSF does sometimes make exceptions as long as the two goals of
preserving the free status of all derivatives of our free software and
of promoting the sharing and reuse of software generally can be
guaranteed. You should contact licensing@gnu.org if you think you can
satisfy those goals, but compliance with the current GNU Classpath
(jazzlib) distribution terms is problematic.

> > 3) If I use your library without change(source code) to make a
> > commercial ziputility, what I should do not to violate your license?
>=20
> I am not sure how to answer that, perhaps another developer can answer
> this question?

The FSF has a GPL-compliance lab which offers consulting services for
companies who are working to develop products that incorporate Free
Software so that they can do so in ways that comply with the terms of
the GPL and other Free Software licenses. If you are interested in this
service, please write a separate message to <compliance-lab@fsf.org>.

Cheers,

Mark

--=-O/FQUZK8d73nisixBbUt
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/wL86xVhZCJWr9QwRApnpAJ9cCAwm9hRvyc8ZH/PLPnOdS97UjgCbB0eL
D+QQDx+R/kNyAP67AdGAVI8=
=VEhX
-----END PGP SIGNATURE-----

--=-O/FQUZK8d73nisixBbUt--




From MAILER-DAEMON Sun Nov 23 12:39:23 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANyCh-00030s-Mn
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 12:39:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANyCf-0002xu-Ep
	for classpath@gnu.org; Sun, 23 Nov 2003 12:39:21 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANyC5-0002ld-FR
	for classpath@gnu.org; Sun, 23 Nov 2003 12:39:16 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANyC5-0002lT-31
	for classpath@gnu.org; Sun, 23 Nov 2003 12:38:45 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id 95564621D5; Sun, 23 Nov 2003 16:37:19 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 40991-05; Sun, 23 Nov 2003 16:37:18 +0000 (GMT)
Received: from reali.dnsalias.net (adsl-212-41-93-116.solnet.ch
	[212.41.93.116]) by mail01.solnet.ch (Postfix) with ESMTP
	id 0232A6218D; Sun, 23 Nov 2003 16:37:18 +0000 (GMT)
Received: from pcprr
	(192-168-001-003-at-home-your-network.privateiprange.solnet.ch
	[192.168.1.3]) by reali.dnsalias.net (Postfix) with SMTP
	id F2F7520270; Sun, 23 Nov 2003 17:27:35 +0100 (CET)
Message-ID: <002801c3b1e0$2cdce2d0$0301a8c0@pcprr>
From: "Patrik Reali" <reali@acm.org>
To: "Mark Wielaard" <mark@klomp.org>
References: <20031122172146.1291@smtp.mail.ch.easynet.net><003701c3b1bf$49e8cf90$0301a8c0@pcprr>
	<1069594357.2851.1079.camel@elsschot.wildebeest.org>
Date: Sun, 23 Nov 2003 17:38:07 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Virus-Scanned: by SolNet
Cc: GNU Classpath <classpath@gnu.org>, Sascha Brawer <brawer@dandelis.ch>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 17:39:22 -0000

I could host the Classpath documentation on the Jaos site, but only as a
temporary solution.


-Patrik

--------
Patrik Reali
http://www.reali.ch/~patrik/
http://www.oberon.ethz.ch/jaos




From MAILER-DAEMON Sun Nov 23 14:18:47 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ANzkt-0007hA-I6
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 14:18:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ANzkr-0007gu-1g
	for classpath@gnu.org; Sun, 23 Nov 2003 14:18:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ANzkL-0007SE-5q
	for classpath@gnu.org; Sun, 23 Nov 2003 14:18:44 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ANzkK-0007SA-Ig
	for classpath@gnu.org; Sun, 23 Nov 2003 14:18:12 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1ANyms-0006pp-00
	for <classpath@gnu.org>; Sun, 23 Nov 2003 19:16:46 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1ANymq-0006pG-00; Sun, 23 Nov 2003 19:16:44 +0100
Message-ID: <3FC0F98B.6010802@kaffe.org>
Date: Sun, 23 Nov 2003 19:16:43 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: raif@fl.net.au
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311220906.37004.raif@fl.net.au> <3FBEA505.50508@kaffe.org>
	<200311221038.09530.raif@fl.net.au>
In-Reply-To: <200311221038.09530.raif@fl.net.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Crypto <gnu-crypto-discuss@gnu.org>,
	Classpath Discussion Mailing List <classpath@gnu.org>, kaffe@kaffe.org
Subject: Re: gnu-crypto.m4.  was: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 19:18:45 -0000

Hi Raif,

Raif S. Naffah wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
> 
> hello Dalibor,
> 
> (i'm cc-ing GNU Crypto)
> 
> On Sat, 22 Nov 2003 10:51 am, Dalibor Topic wrote:
> 
>>...
>>p.s. is there some kind of gnu-crypto.m4 file for automake to add a
>>--with-gnu-crypto option to it? I'd love having a simple way to chuck
>>in GNU crypto into kaffe without having to bother with those weird
>>U.S. crypto laws, as kaffe's CVS server is located in California.
> 
> 
> no there isnt but i'm happy to work with you on making one.

Great!

> things to consider are:
> 
> * building gnu crypto is effectively building three jars/libraries: one 
> is the gnu-crypto per se (incl. the JCE Adapters), the other two are 
> javax-crypto and javax-security (callbacks and sasl).

So we have three seperate jar files, right? Then we need a way to put 
those in the bootclasspath of the calling VM. The VM will need to figure 
out the location of the jar files to add to it's bootclasspath.

Let's say we have

--with-gnu-crypto[=PATH-TO-JAR-LOCATION]

as an API.

Maybe even a
--with-gnu-crypto-cvs=PATH-TO-GNU-CRYPTO-CVS-CHECKOUT

API later for those among us who like building from CVS checkouts ;)

So basically, I'm thinking about two APIs (macros), one for JARs, and 
another for rebuilding GNU Crpyto from CVS. I'll concentrate in the 
first, as that one seems to be easier to do as a prototype, and with 
lessons from that one, it should be easier to build the other.

> * once installed in a location (default is /usr/local/gnu-crypto) it 
> should be straightforward to construct the different options/switches 
> needed by the kaffe build script from the contents of that location.

I have the following in mind:

--with-gnu-crypto should set USE_GNU_CRYPTO as an autoconf variable, and 
PATH_TO_GNU_CRYPTO_JARS. Then, we can use one to check if kaffe should 
use GNU crypto, and the other to adapth the bootclasspath in the kaffe 
driver script, kaffe.in.

> * it would be nice to be able to re-use most, if not all, of the 
> generated options/switches of such an m4 library with other VM 
> providers; e.g. kissme and jikes rvm.

The options/switches depend on the options/switches from the GNU crypto 
configure.in you want the projects utilising GNU Crypto to be able to 
change. If there are any of them that make sense once you've uild the 
JAR files, we should list a set of --enable-gnu-crypto-something 
switches to allow the VM to enable those features.

> if you think this is worth it, let's continue this thread on the GNU 
> Crypto list.

I've cc:ed the kaffe mailing list, as I assume kaffe will provide the 
testbed for this type of integration.

> p.s. if there is a Debian packager out there who is capable/willing to 
> help us deliver the library as a debian package, pls. let me know.

Wasn't Morgon Kanter working on that? [1] What happened to that effort?

cheers,
dalibor topic

[1] 
http://mail.gnu.org/archive/html/gnu-crypto-discuss/2003-06/msg00035.html




From MAILER-DAEMON Sun Nov 23 15:27:18 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AO0pC-00070b-AG
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 15:27:18 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AO0p9-00070D-Ak
	for classpath@gnu.org; Sun, 23 Nov 2003 15:27:15 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AO0oc-0006my-Al
	for classpath@gnu.org; Sun, 23 Nov 2003 15:27:14 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AO0ob-0006mP-Q4
	for classpath@gnu.org; Sun, 23 Nov 2003 15:26:42 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA03742;
	Sun, 23 Nov 2003 12:25:06 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id C14184F8286; Sun, 23 Nov 2003 12:15:30 -0700 (MST)
To: Mark Wielaard <mark@klomp.org>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<003701c3b1bf$49e8cf90$0301a8c0@pcprr>
	<1069594357.2851.1079.camel@elsschot.wildebeest.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Laundry is the fifth dimension!! ...um...um... th' washing machine
	is a black hole and the pink socks are bus drivers who just fell in!!
Date: 23 Nov 2003 12:15:30 -0700
In-Reply-To: <1069594357.2851.1079.camel@elsschot.wildebeest.org>
Message-ID: <87ptfivqul.fsf@fleche.redhat.com>
Lines: 13
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Sascha Brawer <brawer@dandelis.ch>, GNU Classpath <classpath@gnu.org>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 20:27:16 -0000

Mark> Would someone be willing to try to set that up?
Mark> Could someone host the auto-generated documentation for now?

Last time I ran javadoc on classpath, I got tons and tons of errors.
Do we still get that?

I could set things up to post the pages to gcc.gnu.org nightly, just
like we do for the classpath comparison.  This could be expedited if
somebody sent a simple script to generate the pages.

Is gjdoc ready for this sort of work?

Tom



From MAILER-DAEMON Sun Nov 23 16:04:55 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AO1Pb-000151-Fi
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 16:04:55 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AO1PZ-00014l-5s
	for classpath@gnu.org; Sun, 23 Nov 2003 16:04:53 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AO1P3-00010V-CT
	for classpath@gnu.org; Sun, 23 Nov 2003 16:04:52 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AO1P3-00010P-5D
	for classpath@gnu.org; Sun, 23 Nov 2003 16:04:21 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AO0RI-0001t6-Lt
	for classpath@gnu.org; Sun, 23 Nov 2003 15:02:36 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id NAA12188;
	Sun, 23 Nov 2003 13:02:29 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 39B8E4F8286; Sun, 23 Nov 2003 12:52:53 -0700 (MST)
To: Guilhem Lavaux <guilhem@kaffe.org>
References: <3FBE76E0.4020009@kaffe.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: LIFE is a never-ending INFORMERCIAL!
Date: 23 Nov 2003 12:52:53 -0700
In-Reply-To: <3FBE76E0.4020009@kaffe.org>
Message-ID: <87d6biuaju.fsf@fleche.redhat.com>
Lines: 19
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Two methods for NumberFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 21:04:53 -0000

>>>>> "Guilhem" == Guilhem Lavaux <guilhem@kaffe.org> writes:

Guilhem> I am continuing the series of patches with that one, it adds two
Guilhem> methods to NumberFormat: getIntegerInstance() and
Guilhem> getIntegerInstance(Locale). They have to be implemented according to
Guilhem> Java 1.4.

Guilhem> +  /**
Guilhem> +   * This method returns an integer formatting and parsing class for the
Guilhem> +   * default locale. This will be a concrete subclass of <code>NumberFormat</code>,
Guilhem> +   * but the actual class returned is dependent on the locale.
Guilhem> +   *
Guilhem> +   * @return An instance of an integer number formatter for the default locale.
Guilhem> +   */

I think the javadoc for the new methods should include "@since 1.4".
We do this in other places.

Tom



From MAILER-DAEMON Sun Nov 23 16:42:15 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AO1zi-0004C7-8n
	for mharc-classpath@gnu.org; Sun, 23 Nov 2003 16:42:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AO1zd-00042x-4c
	for classpath@gnu.org; Sun, 23 Nov 2003 16:42:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AO1z6-0003UV-0J
	for classpath@gnu.org; Sun, 23 Nov 2003 16:42:08 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AO1z5-0003Rw-7n
	for classpath@gnu.org; Sun, 23 Nov 2003 16:41:35 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AO11d-00067e-00
	for <classpath@gnu.org>; Sun, 23 Nov 2003 21:40:09 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AO11a-00066p-00; Sun, 23 Nov 2003 21:40:06 +0100
Message-ID: <3FC11B25.50205@kaffe.org>
Date: Sun, 23 Nov 2003 21:40:05 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FB673C1.6010206@kaffe.org>	<1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>	<1069190892.1745.23.camel@elsschot.wildebeest.org>	<3FBAC3ED.1010904@kaffe.org>
	<1069266136.2856.42.camel@elsschot.wildebeest.org>
In-Reply-To: <1069266136.2856.42.camel@elsschot.wildebeest.org>
Content-Type: multipart/mixed; boundary="------------050908070909060803050202"
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2003 21:42:12 -0000

This is a multi-part message in MIME format.
--------------050908070909060803050202
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Mark Wielaard wrote:
> Hi,
> 
> On Wed, 2003-11-19 at 02:14, Dalibor Topic wrote:
> 
>>>The documentation and code don't match up now.
>>>My Class Library book seems to indicate that it actually is instanceof,
>>>thought in most cases your code comparing the actual Class seems more
>>>correct.
>>
>>It's the recommended way of doing equals() if you want to avoid symmetry
>>bugs. See PRAXIS 12 in Peter Haggar's Practical Java, or §5.1, p 119 in
>>Java 2 performance and idion guide by craig lahrmann & rhett guthrie, or
>>Effective Java by Joshua Bloch. Using instanceof is a bad idea because
>>it allows for symmetry bugs:
> 
> 
> I know. But that wasn't the point. If you change to code then you must
> also update the documentation.

O.K., I just wans;t very sure about a non-ambigous wording. How about 
the attached patch?

2003-11-23  Dalibor Topic <robilad@kaffe.org>

	* java/text/FieldPosition.java (equals): Fixed comment.

>>The rest follows recommendations from Joshua Bloch on writing good 
>>hashCode methods.
> 
> 
> It would be nice if we had something about the right way (tm) of writing
> the standard clone(), toString(), hashCode() and equals() in the Hackers
> Guide. (hint...)

I see. I'll try to come up with something based on what I've seen on the 
web and Bloch's book.

>>If two objects are not equal, they should have different hashCodes. 
>>field_attribute is checked in the equality test, so it should play a 
>>role in hashCode calculation as well.
> 
> 
> Should yes, but not must. I was just wondering whether or not the
> field_attribute really matters since that field and field_id indicate
> the same property. Having cheap hashCode() methods is a good thing and
> IMHO field_attribute does not make the hashCode() more specific. But if
> you think otherwise then please do it as you have it now.

True. I'll write some test code, and may post another patch that removes 
it based on what I find.

cheers,
dalibor topic

--------------050908070909060803050202
Content-Type: text/plain;
 name="cpath-field-position-equals-comment.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="cpath-field-position-equals-comment.diff"

Index: java/text/FieldPosition.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/FieldPosition.java,v
retrieving revision 1.6
diff -u -r1.6 FieldPosition.java
--- java/text/FieldPosition.java	19 Nov 2003 17:41:21 -0000	1.6
+++ java/text/FieldPosition.java	23 Nov 2003 20:34:53 -0000
@@ -168,7 +168,7 @@
    * <p>
    * <ul>
    * <li>The specified object is not <code>null</code>.
-   * <li>The specified object is an instance of <code>FieldPosition</code>.
+   * <li>The specified object has the same class as this object.
    * <li>The specified object has the same field identifier, field attribute 
    * and beginning and ending index as this object.
    * </ul>

--------------050908070909060803050202--




From MAILER-DAEMON Mon Nov 24 02:16:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOAxV-0002k0-Qa
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 02:16:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOALt-0003fP-KT
	for classpath@gnu.org; Mon, 24 Nov 2003 01:37:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOALM-0003aU-VH
	for classpath@gnu.org; Mon, 24 Nov 2003 01:37:40 -0500
Received: from [81.221.250.51] (helo=mail02.agrinet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOALM-0003a9-KS
	for classpath@gnu.org; Mon, 24 Nov 2003 01:37:08 -0500
Received: from pop.agri.ch (217.162.232.206) by mail02.agrinet.ch (7.0.024)
	(authenticated as toa@pop.agri.ch)
	id 3FBA9F6D000579AB; Mon, 24 Nov 2003 06:35:40 +0100
Message-ID: <3FC198AB.30209@pop.agri.ch>
Date: Mon, 24 Nov 2003 06:35:39 +0100
From: Andreas Tobler <toa@pop.agri.ch>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <1069431275.2861.580.camel@elsschot.wildebeest.org>
In-Reply-To: <1069431275.2861.580.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 24 Nov 2003 02:16:32 -0500
Cc: classpath@gnu.org, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2003 06:37:42 -0000

Mark Wielaard wrote:

> Hi,
> 
> Since I am not a GregorianCalendar expert I was hoping that someone
> could review the following patch which I have in my tree from Ito
> Kazumitsu. He and I wrote a couple of mauve test cases which are fixed
> by this and I see no new failures. But people didn't seem to be
> completely comfortable with it back in Augustus/September. It would be
> nice if we could create even more test cases to make sure that nothing
> else breaks and to have a ChangeLog entry for this patch (Ito?). Don't
> really have have time to learn about Calendars so I am just re-posting
> this patch in the hope that someone can review it.

I am not expert enough for a review ;)

But here the results:
http://gcc.gnu.org/ml/gcc-testresults/2003-11/msg00990.html

CHeers,
Andreas





From MAILER-DAEMON Mon Nov 24 04:17:52 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOCqo-0006om-S9
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 04:17:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOCqW-0006H3-Ic
	for classpath@gnu.org; Mon, 24 Nov 2003 04:17:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOCpx-0005sn-Qb
	for classpath@gnu.org; Mon, 24 Nov 2003 04:17:25 -0500
Received: from [202.181.0.28] (helo=delenn.fl.net.au)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AOCp9-0005bj-Eo; Mon, 24 Nov 2003 04:16:03 -0500
Received: from a3-p40.syd.fl.net.au (a3-p40.syd.fl.net.au [202.181.1.104])
	by delenn.fl.net.au (Postfix) with ESMTP
	id 5103E5B5A2E; Mon, 24 Nov 2003 19:14:40 +1100 (EST)
From: "Raif S. Naffah" <raif@fl.net.au>
To: Dalibor Topic <robilad@kaffe.org>
Date: Mon, 24 Nov 2003 19:13:08 +1100
User-Agent: KMail/1.5
References: <878ymexym1.fsf@fleche.redhat.com>
	<200311221038.09530.raif@fl.net.au> <3FC0F98B.6010802@kaffe.org>
In-Reply-To: <3FC0F98B.6010802@kaffe.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200311241913.32207.raif@fl.net.au>
Cc: GNU Crypto <gnu-crypto-discuss@gnu.org>,
	Classpath Discussion Mailing List <classpath@gnu.org>, kaffe@kaffe.org
Subject: Re: [GNU Crypto] Re: gnu-crypto.m4.  was: new jalopy available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: raif@fl.net.au
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2003 09:17:38 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

hello Dalibor,

On Mon, 24 Nov 2003 05:16 am, Dalibor Topic wrote:
> Raif S. Naffah wrote:
> > On Sat, 22 Nov 2003 10:51 am, Dalibor Topic wrote:
> >>...
> >>p.s. is there some kind of gnu-crypto.m4 file for automake to add a
> >>--with-gnu-crypto option to it? I'd love having a simple way to
> >> chuck in GNU crypto into kaffe without having to bother with those
> >> weird U.S. crypto laws, as kaffe's CVS server is located in
> >> California.
> > ...
> > things to consider are:
> >
> > * building gnu crypto is effectively building three jars/libraries:
> > one is the gnu-crypto per se (incl. the JCE Adapters), the other
> > two are javax-crypto and javax-security (callbacks and sasl).
>
> So we have three seperate jar files, right?

correct.


>... Then we need a way to put
> those in the bootclasspath of the calling VM.

i need to double check this but from memory you only need the=20
javax-crypto.jar only on the bootclasspath iff kaffe exhibits the same=20
behaviour as the jdk1.4; otherwise it only need to be accessible from=20
the classpath (similar to any other jar).


>... The VM will need to
> figure out the location of the jar files to add to it's
> bootclasspath.
>
> Let's say we have
>
> --with-gnu-crypto[=3DPATH-TO-JAR-LOCATION]
>
> as an API.

yes.  if the optional PATH-TO-JAR-LOCATION is omitted, then [the | a]=20
default list of destinations would be searched, incl.=20
/usr/local/gnu-crypto.  (see the _GNU_CRYPTO_WITH_CLASSPATH macro=20
(lines 119+ in =20
<http://savannah.gnu.org/cgi-bin/viewcvs/gnu-crypto/gnu-crypto/acinclude.m4=
?rev=3D1.11&content-type=3Dtext/vnd.viewcvs-markup>). =20
otherwise the designated path, and only that path, is considered.

if/when the expected jars are found in the location, the macro:

a. prints a message that it found, or not, the expected jars;
b. sets, as you suggest later the two ac variables:

   USE_GNU_CRYPTO, and
   GNU_CRYPTO_HOME (or similar).


> Maybe even a
> --with-gnu-crypto-cvs=3DPATH-TO-GNU-CRYPTO-CVS-CHECKOUT

i'm doubtful of the value of this since we (GNU Crypto) always build=20
outside the CVS directory.  but you may have some ideas that would work=20
around this situation.  if not i'd leave this "feature" to a followup=20
release :-)


> API later for those among us who like building from CVS checkouts ;)
>
> So basically, I'm thinking about two APIs (macros), one for JARs, and
> another for rebuilding GNU Crpyto from CVS. I'll concentrate in the
> first, as that one seems to be easier to do as a prototype, and with
> lessons from that one, it should be easier to build the other.

agree.


> > * once installed in a location (default is /usr/local/gnu-crypto)
> > it should be straightforward to construct the different
> > options/switches needed by the kaffe build script from the contents
> > of that location.
>
> I have the following in mind:
>
> --with-gnu-crypto should set USE_GNU_CRYPTO as an autoconf variable,
> and PATH_TO_GNU_CRYPTO_JARS. Then, we can use one to check if kaffe
> should use GNU crypto, and the other to adapth the bootclasspath in
> the kaffe driver script, kaffe.in.

agree.


> > * it would be nice to be able to re-use most, if not all, of the
> > generated options/switches of such an m4 library with other VM
> > providers; e.g. kissme and jikes rvm.
>
> The options/switches depend on the options/switches from the GNU
> crypto configure.in you want the projects utilising GNU Crypto to be
> able to change. If there are any of them that make sense once you've
> uild the JAR files, we should list a set of
> --enable-gnu-crypto-something switches to allow the VM to enable
> those features.

again, the fact that we build outside the CVS directory, IMO makes it=20
hard to chain build GNU Crypto with other projects.

on the other hand, i think what we have discussed so far would allow=20
easy integration of GNU Crypto jars with every VM provider; i.e. once=20
GNU_CRYPTO_HOME is set, and depending on the requirements of the=20
specific VM, the appropriate jars can be constructed as part of the=20
bootclasspath (or equivalent) and/or the plain classpath.


> > if you think this is worth it, let's continue this thread on the
> > GNU Crypto list.
>
> I've cc:ed the kaffe mailing list, as I assume kaffe will provide the
> testbed for this type of integration.

much appreciated :-)  i'll delay the release until we have this working.


> > p.s. if there is a Debian packager out there who is capable/willing
> > to help us deliver the library as a debian package, pls. let me
> > know.
>
> Wasn't Morgon Kanter working on that? [1] What happened to that
> effort?

a recent email sent almost two weeks ago is still unanswered, so i=20
presume per is busy with something else.


cheers;
rsn
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Que du magnifique

iD4DBQE/wb2c+e1AKnsTRiERAy3qAJiIIFGUhIS3u/U3BzRd3cJ5tp47AJ9lKNLW
HdUVr6UMe3zB1WMkMCeBow=3D=3D
=3DNqiN
=2D----END PGP SIGNATURE-----




From MAILER-DAEMON Mon Nov 24 06:34:39 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOEzG-0008FG-O9
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 06:34:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOEzD-0008EE-CG
	for classpath@gnu.org; Mon, 24 Nov 2003 06:34:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOEyg-00084x-C5
	for classpath@gnu.org; Mon, 24 Nov 2003 06:34:33 -0500
Received: from [217.8.192.20] (helo=smtp1.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AOEwU-0007mG-Ep; Mon, 24 Nov 2003 06:31:46 -0500
Received: from [192.168.1.33] (199.134.dyn-adsl.customer.ch.easynet.net
	[217.8.199.134]) by smtp1.mail.ch.easynet.net (Postfix) with ESMTP
	id 519D04A179; Mon, 24 Nov 2003 11:30:18 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: <raif@fl.net.au>, Dalibor Topic <robilad@kaffe.org>
Date: Mon, 24 Nov 2003 11:29:04 +0100
Message-Id: <20031124102904.18072@smtp.mail.ch.easynet.net>
In-Reply-To: <200311241913.32207.raif@fl.net.au>
References: <200311241913.32207.raif@fl.net.au>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Crypto <gnu-crypto-discuss@gnu.org>, GNU Classpath <classpath@gnu.org>,
	kaffe@kaffe.org
Subject: Re: [GNU Crypto] gnu-crypto.m4
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2003 11:34:37 -0000

On Sat, 22 Nov 2003 10:51 am, Dalibor Topic wrote:

> I'd love having a simple way to
> chuck in GNU crypto into kaffe without having to bother with those
> weird U.S. crypto laws, as kaffe's CVS server is located in
> California.

Actually, these "weird crypto laws" are not specific to the U.S. The
follwing states are currently participating in the Wassenaar Arrangement:

Argentina,  Australia,  Austria,  Belgium,  Bulgaria,  Canada,  Czech
Republic,  Denmark,  Finland,  France,  Germany,  Greece,  Hungary, 
Ireland,  Italy,  Japan,  Luxembourg,  Netherlands,  New Zealand, 
Norway,  Poland,  Portugal,  Republic of Korea,  Romania,  Russian
Federation,  Slovakia,  Spain,  Sweden,  Switzerland,  Turkey,  Ukraine,
 United Kingdom  and  United States.

The participating states implement the Wassenaar Arrangement in national
laws and regulations.  These may or may not be identical with the text of
the arrangement.

General info; contact lists of national bodies
http://www.wassenaar.org/

"List of Dual Use Goods and Technologies And Munitions List"
Category 5, Part 2: Information Security
[Specifies the technical criteria, such as key lengths, for crypto
software to be considered dual-use technology]
http://www.wassenaar.org/list/wa-list_02_1cat5p2.pdf

"General Software Note"
[excludes software "in the public domain" from the control regime]
http://www.wassenaar.org/list/wa-list_02_1gtnandgsn.pdf

Text on the FSF website about the Wassenaar Arrangement
[They call it "Wassenaar Agreement"]
http://www.gnu.org/philosophy/wassenaar.html

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Mon Nov 24 08:39:54 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOGwT-0003Pe-Np
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 08:39:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOGwN-0003N3-8J
	for classpath@gnu.org; Mon, 24 Nov 2003 08:39:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOGvm-0003Ck-Vq
	for classpath@gnu.org; Mon, 24 Nov 2003 08:39:42 -0500
Received: from [24.25.9.100] (helo=ms-smtp-01-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOGtf-0002rd-Ij
	for classpath@gnu.org; Mon, 24 Nov 2003 08:36:59 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-01-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hAOCZMse022026; Mon, 24 Nov 2003 07:35:22 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id 6F107BE641; Mon, 24 Nov 2003 07:35:13 -0500 (EST)
Sender: cbj@haphazard.org
To: tromey@redhat.com
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<003701c3b1bf$49e8cf90$0301a8c0@pcprr>
	<1069594357.2851.1079.camel@elsschot.wildebeest.org>
	<87ptfivqul.fsf@fleche.redhat.com>
From: Brian Jones <cbj@gnu.org>
Date: 24 Nov 2003 07:35:13 -0500
In-Reply-To: <87ptfivqul.fsf@fleche.redhat.com>
Message-ID: <m3n0amq70e.fsf@lyta.haphazard.org>
Lines: 22
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Sascha Brawer <brawer@dandelis.ch>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2003 13:39:50 -0000

--=-=-=

Tom Tromey <tromey@redhat.com> writes:

> Mark> Would someone be willing to try to set that up?
> Mark> Could someone host the auto-generated documentation for now?
> 
> Last time I ran javadoc on classpath, I got tons and tons of errors.
> Do we still get that?
> 
> I could set things up to post the pages to gcc.gnu.org nightly, just
> like we do for the classpath comparison.  This could be expedited if
> somebody sent a simple script to generate the pages.
> 
> Is gjdoc ready for this sort of work?

Here's and old script, I think it needs some work.

Brian
-- 
Brian Jones <cbj@gnu.org>


--=-=-=
Content-Type: application/octet-stream
Content-Disposition: attachment; filename=classpath-gjdoc

#!/bin/sh

CLASSPATH_CVS=~/gjdoc/classpath
CLASSPATH_PREFIX=~/gjdoc/root/classpath
LOG=~/gjdoc.log
OUTPUT_HTML=~/gjdoc/html
OUTPUT_API=~/gjdoc/api

rm -f ${LOG} > /dev/null 2>&1
today=`date`
echo "${today}" > ${LOG}
rm -rf "${OUTPUT_HTML}" > /dev/null 2>&1
mkdir --parents "${OUTPUT_HTML}"
rm -rf "${OUTPUT_API}" > /dev/null 2>&1

_aclocal ()
{
  aclocal "$@" >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error running aclocal"
    exit 1
  fi
}

_autoheader ()
{
  autoheader "$@" >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error running autoheader"
    exit 1
  fi
}

_automake ()
{
  automake "$@" >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error running automake"
    exit 1
  fi
}

_autoconf ()
{
  autoconf "$@" >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error running autoconf"
    exit 1
  fi
}

classpath_checkout ()
{
  if [ ! -d "${CLASSPATH_CVS}" ]; then
    mkdir --parents ${CLASSPATH_CVS}
    local dir=`dirname "${CLASSPATH_CVS}"`
    cd "${dir}"
    cvs -z3 -d :pserver:anoncvs@subversions.gnu.org:/cvsroot/classpath co classpath >> ${LOG} 2>/dev/null
    if [ $? -ne 0 ]; then
      echo "Error checking out classpath"
      exit 1
    fi
  fi
}

classpath_update ()
{
  cd "${CLASSPATH_CVS}" && cvs update -d -P . >> ${LOG} 2>/dev/null
  if [ $? -ne 0 ]; then
    echo "Error checking out classpath"
    exit 1
  fi
}

classpath_clean ()
{
  if [ -d "${CLASSPATH_CVS}/build" ]; then
    rm -rf "${CLASSPATH_CVS}/build"
  fi
  if [ -d "${CLASSPATH_PREFIX}" ]; then
    rm -rf "${CLASSPATH_PREFIX}"
  fi
  mkdir --parents "${CLASSPATH_CVS}/build"
  mkdir --parents "${CLASSPATH_PREFIX}"
}

classpath_configure ()
{
  cd "${CLASSPATH_CVS}"

  _aclocal
  _autoheader
  _automake
  _autoconf

  cd "${CLASSPATH_CVS}/build" && ../configure --prefix=${CLASSPATH_PREFIX} --with-jikes >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error configuring"
    exit 1
  fi
}

classpath_build ()
{
  cd "${CLASSPATH_CVS}/build" && make >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error during make"
    exit 1
  fi
}

classpath_install ()
{
  cd "${CLASSPATH_CVS}/build" && make install >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error during make"
    exit 1
  fi
}

classpath_gjdoc ()
{
  cd "${CLASSPATH_CVS}"
  if [ $? -ne 0 ]; then
    echo "Error changing directory to ${CLASSPATH_CVS}"
    exit 1
  fi
  local core_packages=`find java javax -type d ! -regex .*CVS | tr '/' '.' | grep -v "^java$" | grep -v "^javax$" | grep -v "java.awt.dnd.peer" | grep -v "java.awt.peer" | xargs`
  if [ $? -ne 0 ]; then
    echo "Error during find1"
    exit 1
  fi
  cd "${CLASSPATH_CVS}/external/jaxp/source"
  if [ $? -ne 0 ]; then
    echo "Error changing directory to ${CLASSPATH_CVS}/external/jaxp/source"
    exit 1
  fi
  local jaxp_packages=`find javax org -type d ! -regex .*CVS | tr '/' '.' | grep -v "^javax$" | grep -v "^org$" | grep -v "org.w3c.dom." | xargs`
  if [ $? -ne 0 ]; then
    echo "Error during find2"
    exit 1
  fi
  local packages="$core_packages $jaxp_packages"
  ~/bin/gjdoc -sourcepath \
    "${CLASSPATH_CVS}:${CLASSPATH_CVS}/vm/reference:${CLASSPATH_CVS}/external/jaxp/source" \
    -d "${OUTPUT_HTML}" ${packages} >> ${LOG} 2>&1
  if [ $? -ne 0 ]; then
    echo "Error during gjdoc"
    exit 1
  fi
}

classpath_postdoc ()
{
  dir=`dirname "${OUTPUT_HTML}"`
  cd "${dir}"
  mv html api
  tar -czf /tmp/api.tar.gz api
  if [ $? -ne 0 ]; then
    echo "Error during tar"
    exit 1
  fi
}

#--------------------------------------------------------------------
# Update Classpath CVS
#--------------------------------------------------------------------
classpath_checkout
classpath_update

#--------------------------------------------------------------------
# Build Classpath with Jikes
#--------------------------------------------------------------------
#classpath_clean
#classpath_configure
#classpath_build
#classpath_install

#--------------------------------------------------------------------
# Execute Mauve
#--------------------------------------------------------------------
classpath_gjdoc
classpath_postdoc

--=-=-=--



From MAILER-DAEMON Mon Nov 24 19:00:40 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOQd9-0005X6-5m
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 19:00:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOQd3-0005Vo-Fg
	for classpath@gnu.org; Mon, 24 Nov 2003 19:00:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOQcS-0005Nz-H0
	for classpath@gnu.org; Mon, 24 Nov 2003 19:00:23 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AOQcS-0005NK-9M
	for classpath@gnu.org; Mon, 24 Nov 2003 18:59:52 -0500
Received: from [210.230.164.2] (helo=mail.jsdi.or.jp)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AOPeR-0005nh-Dc
	for classpath@gnu.org; Mon, 24 Nov 2003 17:57:51 -0500
Received: from dl.maczuka.gcd.org (d084.hi.jsdi.or.jp [210.230.165.84])
	by mail.jsdi.or.jp (8.11.6p2/8.11.6) with SMTP id hAOMvAp36831
	for <classpath@gnu.org>; Tue, 25 Nov 2003 07:57:11 +0900 (JST)
Received: (qmail 2167 invoked by uid 0); 24 Nov 2003 22:57:08 -0000
Received: from ph.maczuka.gcd.org (HELO maczuka.gcd.org) (192.168.0.1)
	by dl.maczuka.gcd.org with SMTP; 24 Nov 2003 22:57:08 -0000
Received: (qmail 43636 invoked by uid 1000); 24 Nov 2003 22:57:26 -0000
Message-ID: <20031124225726.43635.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: Mark Wielaard <mark@klomp.org>
In-reply-to: Your message of "Fri, 21 Nov 2003 17:14:35 +0100"
References: <1069431275.2861.580.camel@elsschot.wildebeest.org>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Tue, 25 Nov 2003 07:57:26 +0900
Sender: kaz@maczuka.gcd.org
Cc: classpath@gnu.org, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 00:00:33 -0000

>>>>> ":" == Mark Wielaard <mark@klomp.org> writes:

:> and to have a ChangeLog entry for this patch (Ito?).

How about this?

2003-11-25  Ito Kazumitsu  <kaz@maczuka.gcd.org>

	* java/util/GregorianCalendar.java (getLinearTime): avoid counting
          the leap day of the leap year twice.
	  (computeFields): corrected so that the first week of month is
          not 0 but 1.



From MAILER-DAEMON Mon Nov 24 21:08:02 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOScJ-0004Cy-FP
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 21:07:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOSbr-0003EL-EP
	for classpath@gnu.org; Mon, 24 Nov 2003 21:07:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOSat-0001Qo-2D
	for classpath@gnu.org; Mon, 24 Nov 2003 21:06:54 -0500
Received: from [132.206.3.88] (helo=relay10.cs.mcgill.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOSal-0001Dk-P8
	for classpath@gnu.org; Mon, 24 Nov 2003 21:06:15 -0500
Received: from pinto.cs.mcgill.ca (pinto.CS.McGill.CA [132.206.3.79])
	by relay10.cs.mcgill.ca (Postfix) with ESMTP id 794F0536F29
	for <classpath@gnu.org>; Mon, 24 Nov 2003 20:04:50 -0500 (EST)
Received: from pinto.cs.mcgill.ca (dbelan2@localhost [127.0.0.1])
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) with ESMTP id
	hAP14oXd028198
	for <classpath@gnu.org>; Mon, 24 Nov 2003 20:04:50 -0500
Received: (from dbelan2@localhost)
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) id hAP14oQG028196
	for classpath@gnu.org; Mon, 24 Nov 2003 20:04:50 -0500
Date: Mon, 24 Nov 2003 20:04:50 -0500
From: David =?iso-8859-1?Q?B=E9langer?= <dbelan2@cs.mcgill.ca>
To: classpath@gnu.org
Message-ID: <20031125010450.GA28109@pinto.cs.mcgill.ca>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="0OAP2g/MAC+5xKAE"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Content-Transfer-Encoding: 7bit
Subject: patch ZipFile
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 02:07:48 -0000


--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Classpath developers,

The SableVM developers are moving to Classpath 0.06.  I will start
sending bug fixes found in Classpath.

The first one is in ZipFile.  See patch included.
The current Classpath implementation removes the path component
from the name when the JarFile is created with new ZipFile(new
File(name)).

Sun's JDK does not remove the path, getName() always return the name
specified in the constructor of ZipFile or File.

(Without this fix, it is impossible to load jar files with the
SystemClassLoader that are not located in the current directory).



David


---

David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226

Web page:   http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt


--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ZipFile.java.diff"

Index: java/util/zip/ZipFile.java
===================================================================
--- java/util/zip/ZipFile.java	(revision 1011)
+++ java/util/zip/ZipFile.java	(revision 1075)
@@ -105,7 +105,7 @@
   public ZipFile(File file) throws ZipException, IOException
   {
     this.raf = new RandomAccessFile(file, "r");
-    this.name = file.getName();
+    this.name = file.getPath();
   }
 
   /**
@@ -134,7 +134,7 @@
 	  ("OPEN_DELETE mode not supported yet in java.util.zip.ZipFile");
       }
     this.raf = new RandomAccessFile(file, "r");
-    this.name = file.getName();
+    this.name = file.getPath();
   }
 
   /**

--0OAP2g/MAC+5xKAE--



From MAILER-DAEMON Mon Nov 24 21:47:16 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOTEQ-0005Qq-8G
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 21:47:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOTE8-0005OF-EB
	for classpath@gnu.org; Mon, 24 Nov 2003 21:46:56 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOTDa-0005D5-2z
	for classpath@gnu.org; Mon, 24 Nov 2003 21:46:53 -0500
Received: from [132.206.3.88] (helo=relay10.cs.mcgill.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOTDZ-0005D1-SJ
	for classpath@gnu.org; Mon, 24 Nov 2003 21:46:21 -0500
Received: from pinto.cs.mcgill.ca (pinto.CS.McGill.CA [132.206.3.79])
	by relay10.cs.mcgill.ca (Postfix) with ESMTP id DD0CE536F16
	for <classpath@gnu.org>; Mon, 24 Nov 2003 20:44:56 -0500 (EST)
Received: from pinto.cs.mcgill.ca (dbelan2@localhost [127.0.0.1])
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) with ESMTP id
	hAP1iuXd028328
	for <classpath@gnu.org>; Mon, 24 Nov 2003 20:44:56 -0500
Received: (from dbelan2@localhost)
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) id hAP1iufo028326
	for classpath@gnu.org; Mon, 24 Nov 2003 20:44:56 -0500
Date: Mon, 24 Nov 2003 20:44:56 -0500
From: David =?iso-8859-1?Q?B=E9langer?= <dbelan2@cs.mcgill.ca>
To: classpath@gnu.org
Message-ID: <20031125014456.GA28272@pinto.cs.mcgill.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Content-Transfer-Encoding: quoted-printable
Subject: File.list()
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 02:47:11 -0000


Hi,

This may be some trace left from a old bug.

File: java/io/File.java.


A long time ago, there was a bug with listInternals as it was
not returning an empty array for "no files".  This has been
fixed since then and listInternals returns only NULL on error.
If there are no files, it correctly returns a String array
of length 0.

The current implementation of Filelists is as follows:

---------
  public String[] list (FilenameFilter filter)
  {
    checkRead ();

    // Get the list of files
    String list_path =3D PlatformHelper.removeTailSeparator(path);
    File dir =3D new File(list_path);

    if (! dir.exists() || ! dir.isDirectory() ) return null;
   =20
    String files[] =3D listInternal(list_path);
   =20
--> if (files =3D=3D null)
-->   return new String[0];
    if (filter =3D=3D null)
      return files;
------------

Note: From the current implementation of listInternal, it will return NUL=
L
      only on error, and it will correctly return "new String[0]" if
      the directory is empty.  (I checked with gdb to make sure).

So, I suggest something like:
    if (files =3D=3D null) {
      throw new IOException("Unknown IO Exception");
    }
I am assuming some JCL_* functions set exceptions on errors (did not stud=
y
them) but this may get other exceptional cases.


Let me know if it makes sense.


David


---

David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226

Web page:   http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt




From MAILER-DAEMON Mon Nov 24 22:16:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOTgP-0005Mw-3B
	for mharc-classpath@gnu.org; Mon, 24 Nov 2003 22:16:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOTgF-00057d-Sy
	for classpath@gnu.org; Mon, 24 Nov 2003 22:15:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOTfR-0004PR-AT
	for classpath@gnu.org; Mon, 24 Nov 2003 22:15:40 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AOTfO-0004Or-PE
	for classpath@gnu.org; Mon, 24 Nov 2003 22:15:06 -0500
Received: from [132.206.3.88] (helo=relay10.cs.mcgill.ca)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AOSg3-0005F2-5N
	for classpath@gnu.org; Mon, 24 Nov 2003 21:11:43 -0500
Received: from pinto.cs.mcgill.ca (pinto.CS.McGill.CA [132.206.3.79])
	by relay10.cs.mcgill.ca (Postfix) with ESMTP id 5D9A3536F04;
	Mon, 24 Nov 2003 21:11:12 -0500 (EST)
Received: from pinto.cs.mcgill.ca (dbelan2@localhost [127.0.0.1])
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) with ESMTP id
	hAP2BCXd028446; Mon, 24 Nov 2003 21:11:12 -0500
Received: (from dbelan2@localhost)
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) id hAP2BCtt028444;
	Mon, 24 Nov 2003 21:11:12 -0500
Date: Mon, 24 Nov 2003 21:11:12 -0500
From: David =?iso-8859-1?Q?B=E9langer?= <dbelan2@cs.mcgill.ca>
To: classpath@gnu.org
Message-ID: <20031125021112.GB28272@pinto.cs.mcgill.ca>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="CE+1k2dSO48ffgeK"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Content-Transfer-Encoding: 7bit
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Subject: java_io_File.c deletelocalref and cl in ObjectInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 03:16:07 -0000


--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Hi,

These are 2 more changes that were done on the old Classpath used in Sabl=
eVM
but are not currently found in the most recent Classpath.

I think Etienne did these two changes, I'm not sure.  Maybe Etienne
could answer your questions on these.

java_io_File.c: Basically, it frees a local ref, I guess otherwise it may
run out of local refs for a long directory listing.

ObjectInputStream.java: I don't understand ClassLoader enough to explain =
this
one.



David



---

David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226

Web page:   http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt


--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="java_io_File.c.diff"

Index: native/jni/java-io/java_io_File.c
===================================================================
--- native/jni/java-io/java_io_File.c	(revision 1011)
+++ native/jni/java-io/java_io_File.c	(revision 1076)
@@ -682,6 +682,7 @@
 
       /* save into array */
       (*env)->SetObjectArrayElement(env, filearray, i, str);
+      (*env)->DeleteLocalRef (env, str);
     }
 
   /* free resources */

--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ObjectInputStream.java.diff"

Index: java/io/ObjectInputStream.java
===================================================================
--- java/io/ObjectInputStream.java	(revision 1011)
+++ java/io/ObjectInputStream.java	(revision 1076)
@@ -559,7 +559,7 @@
     if (cl == null)
       return Class.forName (osc.getName ());
     else
-      return cl.loadClass (osc.getName ());
+      return Class.forName (osc.getName (), false, cl);
   }
 
   /**

--CE+1k2dSO48ffgeK--



From MAILER-DAEMON Tue Nov 25 00:06:52 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOVPY-0000Pv-3g
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 00:06:52 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOVPT-0000Kq-2M
	for classpath@gnu.org; Tue, 25 Nov 2003 00:06:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOVOw-0000DW-0t
	for classpath@gnu.org; Tue, 25 Nov 2003 00:06:45 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOVOv-0000Cr-B7
	for classpath@gnu.org; Tue, 25 Nov 2003 00:06:13 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hAP44gH28022;
	Mon, 24 Nov 2003 23:04:42 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hAP44gw24963; 
	Mon, 24 Nov 2003 23:04:42 -0500
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	hAP44fQ1002218; Mon, 24 Nov 2003 23:04:41 -0500
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Classpath Patches <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="=-UTL4Lf6cJ87SWdq5Et4w"
Message-Id: <1069733080.4125.479.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Mon, 24 Nov 2003 23:04:41 -0500
Cc: GCJ Patches <java-patches@gcc.gnu.org>
Subject: PixelGrabber fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 05:06:48 -0000


--=-UTL4Lf6cJ87SWdq5Et4w
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hello,

This patch completes the PixelGrabber implementation, updates its
javadocs and includes a mauve test case.

OK to commit?

Tom

2003-11-24  Thomas Fitzsimmons  <fitzsim@redhat.com>

	* gnu/java/awt/peer/gtk/GtkImage.java (setDimensions,
	setProperties): Check that io is not null before calling
	io.imageUpdate.
	* java/awt/image/ImageConsumer.java (setPixels, imageComplete):
	Update javadocs.
	* java/awt/image/PixelGrabber.java: Fix implementation and
	update javadocs.


--=-UTL4Lf6cJ87SWdq5Et4w
Content-Disposition: attachment; filename=pixelgrabber.patch
Content-Type: text/x-patch; name=pixelgrabber.patch; charset=
Content-Transfer-Encoding: 7bit

Index: gnu/java/awt/peer/gtk/GtkImage.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkImage.java,v
retrieving revision 1.3
diff -u -r1.3 GtkImage.java
--- gnu/java/awt/peer/gtk/GtkImage.java	12 Nov 2003 00:37:33 -0000	1.3
+++ gnu/java/awt/peer/gtk/GtkImage.java	25 Nov 2003 03:59:01 -0000
@@ -1,5 +1,5 @@
 /* GtkImage.java
-   Copyright (C) 1999, 2002 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2002, 2003 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -168,13 +168,15 @@
     for (int i = 0; i < widthObservers.size (); i++)
       {
 	ImageObserver io = (ImageObserver) widthObservers.elementAt (i);
-	io.imageUpdate (this, ImageObserver.WIDTH, -1, -1, width, height);
+	if (io != null)
+	  io.imageUpdate (this, ImageObserver.WIDTH, -1, -1, width, height);
       }
 
     for (int i = 0; i < heightObservers.size (); i++)
       {
 	ImageObserver io = (ImageObserver) heightObservers.elementAt (i);
-	io.imageUpdate (this, ImageObserver.HEIGHT, -1, -1, width, height);
+	if (io != null)
+	  io.imageUpdate (this, ImageObserver.HEIGHT, -1, -1, width, height);
       }
 
     if (observer != null)
@@ -192,7 +194,8 @@
     for (int i = 0; i < propertyObservers.size (); i++)
       {
 	ImageObserver io = (ImageObserver) propertyObservers.elementAt (i);
-	io.imageUpdate (this, ImageObserver.PROPERTIES, -1, -1, width, height);
+	if (io != null)
+	  io.imageUpdate (this, ImageObserver.PROPERTIES, -1, -1, width, height);
       }
   }
 
Index: java/awt/image/ImageConsumer.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/image/ImageConsumer.java,v
retrieving revision 1.6
diff -u -r1.6 ImageConsumer.java
--- java/awt/image/ImageConsumer.java	11 Oct 2003 17:19:46 -0000	1.6
+++ java/awt/image/ImageConsumer.java	25 Nov 2003 03:59:01 -0000
@@ -1,5 +1,5 @@
 /* ImageConsumer.java -- Java interface for image consumption
-   Copyright (C) 1999 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2003 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -160,17 +160,45 @@
     void setHints(int flags);
 
     /**
-     * This function delivers a rectangle of pixels where any
-     * pixel(m,n) is stored in the array as a <code>byte</code> at
-     * index (n * scansize + m + offset).  
+     * Deliver a subset of an ImageProducer's pixels to this ImageConsumer.
+     *
+     * Each element of the pixels array represents one pixel.  The
+     * pixel data is formatted according to the color model model.
+     * The x and y parameters are the coordinates of the block of
+     * pixels being delivered to this ImageConsumer.  They are
+     * specified relative to the top left corner of the image being
+     * produced.  Likewise, w and h are the pixel block's dimensions.
+     *
+     * @param x x coordinate of pixel block
+     * @param y y coordinate of pixel block
+     * @param w width of pixel block
+     * @param h height of pixel block
+     * @param model color model used to interpret pixel data
+     * @param pixels pixel block data
+     * @param offset offset into pixels array
+     * @param scansize width of one row in the pixel block
      */
     void setPixels(int x, int y, int w, int h, 
 	   ColorModel model, byte[] pixels, int offset, int scansize);
 
     /**
-     * This function delivers a rectangle of pixels where any
-     * pixel(m,n) is stored in the array as an <code>int</code> at
-     * index (n * scansize + m + offset).  
+     * Deliver a subset of an ImageProducer's pixels to this ImageConsumer.
+     *
+     * Each element of the pixels array represents one pixel.  The
+     * pixel data is formatted according to the color model model.
+     * The x and y parameters are the coordinates of the rectangular
+     * region of pixels being delivered to this ImageConsumer,
+     * specified relative to the top left corner of the image being
+     * produced.  Likewise, w and h are the pixel region's dimensions.
+     *
+     * @param x x coordinate of pixel block
+     * @param y y coordinate of pixel block
+     * @param w width of pixel block
+     * @param h height of pixel block
+     * @param model color model used to interpret pixel data
+     * @param pixels pixel block data
+     * @param offset offset into pixels array
+     * @param scansize width of one row in the pixel block
      */
     void setPixels(int x, int y, int w, int h, 
            ColorModel model, int[] pixels, int offset, int scansize);
@@ -180,7 +208,9 @@
      * single frame or the entire image is complete.  The method is
      * also used to indicate an error in loading or producing the
      * image.  
+     *
+     * @param status the status of image production, represented by a
+     * bitwise OR of ImageConsumer flags
      */
     void imageComplete(int status);
 }
-
Index: java/awt/image/PixelGrabber.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/image/PixelGrabber.java,v
retrieving revision 1.4
diff -u -r1.4 PixelGrabber.java
--- java/awt/image/PixelGrabber.java	27 Jun 2003 20:53:01 -0000	1.4
+++ java/awt/image/PixelGrabber.java	25 Nov 2003 03:59:01 -0000
@@ -1,39 +1,39 @@
-/* PixelGrabber.java -- Java class for providing image data 
-   Copyright (C) 1999 Free Software Foundation, Inc.
+/* PixelGrabber.java -- retrieve a subset of an image's data
+   Copyright (C) 1999, 2003 Free Software Foundation, Inc.
 
-This file is part of GNU Classpath.
+   This file is part of GNU Classpath.
 
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
-
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-02111-1307 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
+   GNU Classpath is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2, or (at your option)
+   any later version.
+
+   GNU Classpath is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with GNU Classpath; see the file COPYING.  If not, write to the
+   Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+   02111-1307 USA.
+
+   Linking this library statically or dynamically with other modules is
+   making a combined work based on this library.  Thus, the terms and
+   conditions of the GNU General Public License cover the whole
+   combination.
+
+   As a special exception, the copyright holders of this library give you
+   permission to link this library with independent modules to produce an
+   executable, regardless of the license terms of these independent
+   modules, and to copy and distribute the resulting executable under
+   terms of your choice, provided that you also meet, for each linked
+   independent module, the terms and conditions of the license of that
+   module.  An independent module is a module which is not derived from
+   or based on this library.  If you modify this library, you may extend
+   this exception to your version of the library, but you are not
+   obligated to do so.  If you do not wish to do so, delete this
+   exception statement from your version. */
 
 
 package java.awt.image;
@@ -42,309 +42,583 @@
 import java.util.Hashtable;
 
 /**
-   PixelGrabber is an ImageConsumer designed to extract a rectangular region of pixels
-   from an Image
+ * PixelGrabber is an ImageConsumer that extracts a rectangular region
+ * of pixels from an Image.
  */
-public class PixelGrabber implements ImageConsumer 
+public class PixelGrabber implements ImageConsumer
 {
-    int x, y, width, height, status, scansize, offset;
-    ColorModel model = ColorModel.getRGBdefault();
-    //int hints;
-    //Hashtable props;
-    int pixel_bufferi[];
-    byte pixel_bufferb[];
-    boolean grabbing;
-    ImageProducer ip;
-
-    /**
-     * Create a PixelGrabber used to grab pixels from the specified Image 
-     * in the specified rectangle
-     *
-     * @param img the Image to grab pixels from
-     * @param x the x coordinate of the rectangle
-     * @param y the y coordinate of the rectangle
-     * @param w the width of the rectangle
-     * @param h the height of the rectangle
-     * @param pixels the array of pixel values
-     * @param offset the index of the first pixels in the <code>pixels</code> array
-     * @param scansize the width to use in extracting pixels from the <code>pixels</code> array
-     */
-    public PixelGrabber(Image img, int x, int y, int w, int h,
-			int pix[], int off, int scansize)
-    {
-	this( img.getSource(), x, y, w, h, pix, off, scansize );
-    }
-
-    /**
-     * Create a PixelGrabber used to grab pixels from the specified ImageProducer
-     * in the specified rectangle
-     *
-     * @param ip the ImageProducer to grab pixels from
-     * @param x the x coordinate of the rectangle
-     * @param y the y coordinate of the rectangle
-     * @param w the width of the rectangle
-     * @param h the height of the rectangle
-     * @param pixels the array of pixel values
-     * @param offset the index of the first pixels in the <code>pixels</code> array
-     * @param scansize the width to use in extracting pixels from the <code>pixels</code> array
-     */
-    public PixelGrabber(ImageProducer ip, int x, int y, int w, int h,
-			int pix[], int off, int scansize)
-    {
-	this.ip = ip;
-	this.x = x;
-	this.y = y;
-	this.width = w;
-	this.height = h;
-	this.pixel_bufferi = pix;
-	this.offset = off;
-	this.scansize = scansize;
-	pixel_bufferb = new byte[pix.length * 4];
-    }
-
-
-    /**
-     * Create a PixelGrabber used to grab pixels from the specified Image 
-     * in the specified rectangle
-     *
-     * @param img the Image to grab pixels from
-     * @param x the x coordinate of the rectangle
-     * @param y the y coordinate of the rectangle
-     * @param w the width of the rectangle
-     * @param h the height of the rectangle
-     * @param forceRGB true to force conversion to RGB
-     */
-    public PixelGrabber(Image img,
-			int x, int y,
-			int w, int h,
-			boolean forceRGB)
-    {
-	//FIXME
-    }
-
-    /**
-       Start Grabbing Pixels
-     */
-    public synchronized void startGrabbing()
-    {
-	if ( grabbing == false )
+  int x, y, offset;
+  int width = -1;
+  int height = -1;
+  int scansize = -1;
+  boolean forceRGB = true;
+
+  ColorModel model = ColorModel.getRGBdefault();
+  int hints;
+  Hashtable props;
+
+  int int_pixel_buffer[];
+  boolean ints_delivered = false;
+  byte byte_pixel_buffer[];
+  boolean bytes_delivered = false;
+
+  ImageProducer ip;
+  int observerStatus;
+  int consumerStatus;
+
+  private Thread grabberThread;
+  boolean grabbing = false;
+
+  /**
+   * Construct a PixelGrabber that will retrieve RGB data from a given
+   * Image.
+   *
+   * The RGB data will be retrieved from a rectangular region
+   * <code>(x, y, w, h)</code> within the image.  The data will be
+   * stored in the provided <code>pix</code> array, which must have
+   * been initialized to a size of at least <code>w * h</code>.  The
+   * data for a pixel (m, n) in the grab rectangle will be stored at
+   * <code>pix[(n - y) * scansize + (m - x) + off]</code>.
+   *
+   * @param img the Image from which to grab pixels
+   * @param x the x coordinate, relative to <code>img</code>'s
+   * top-left corner, of the grab rectangle's top-left pixel
+   * @param y the y coordinate, relative to <code>img</code>'s
+   * top-left corner, of the grab rectangle's top-left pixel
+   * @param w the width of the grab rectangle, in pixels
+   * @param h the height of the grab rectangle, in pixels
+   * @param pix the array in which to store grabbed RGB pixel data
+   * @param off the offset into the <code>pix</code> array at which to
+   * start storing RGB data
+   * @param scansize a set of <code>scansize</code> consecutive
+   * elements in the <code>pix</code> array represents one row of
+   * pixels in the grab rectangle
+   */
+  public PixelGrabber(Image img, int x, int y, int w, int h,
+		      int pix[], int off, int scansize)
+  {
+    this (img.getSource(), x, y, w, h, pix, off, scansize);
+  }
+
+  /**
+   * Construct a PixelGrabber that will retrieve RGB data from a given
+   * ImageProducer.
+   *
+   * The RGB data will be retrieved from a rectangular region
+   * <code>(x, y, w, h)</code> within the image produced by
+   * <code>ip</code>.  The data will be stored in the provided
+   * <code>pix</code> array, which must have been initialized to a
+   * size of at least <code>w * h</code>.  The data for a pixel (m, n)
+   * in the grab rectangle will be stored at
+   * <code>pix[(n - y) * scansize + (m - x) + off]</code>.
+   *
+   * @param ip the ImageProducer from which to grab pixels
+   * @param x the x coordinate of the grab rectangle's top-left pixel,
+   * specified relative to the top-left corner of the image produced
+   * by <code>ip</code>
+   * @param y the y coordinate of the grab rectangle's top-left pixel,
+   * specified relative to the top-left corner of the image produced
+   * by <code>ip</code>
+   * @param w the width of the grab rectangle, in pixels
+   * @param h the height of the grab rectangle, in pixels
+   * @param pix the array in which to store grabbed RGB pixel data
+   * @param off the offset into the <code>pix</code> array at which to
+   * start storing RGB data
+   * @param scansize a set of <code>scansize</code> consecutive
+   * elements in the <code>pix</code> array represents one row of
+   * pixels in the grab rectangle
+   */
+  public PixelGrabber(ImageProducer ip, int x, int y, int w, int h,
+		      int pix[], int off, int scansize)
+  {
+    this.ip = ip;
+    this.x = x;
+    this.y = y;
+    this.width = w;
+    this.height = h;
+    this.offset = off;
+    this.scansize = scansize;
+
+    int_pixel_buffer = pix;
+    // Initialize the byte array in case ip sends us byte-formatted
+    // pixel data.
+    byte_pixel_buffer = new byte[pix.length * 4];
+  }
+
+  /**
+   * Construct a PixelGrabber that will retrieve data from a given
+   * Image.
+   *
+   * The RGB data will be retrieved from a rectangular region
+   * <code>(x, y, w, h)</code> within the image.  The data will be
+   * stored in an internal array which can be accessed by calling
+   * <code>getPixels</code>.  The data for a pixel (m, n) in the grab
+   * rectangle will be stored in the returned array at index
+   * <code>(n - y) * scansize + (m - x) + off</code>.
+   * If forceRGB is false, then the returned data will be not be
+   * converted to RGB from its format in <code>img</code>.
+   *
+   * If <code>w</code> is negative, the width of the grab region will
+   * be from x to the right edge of the image.  Likewise, if
+   * <code>h</code> is negative, the height of the grab region will be
+   * from y to the bottom edge of the image.
+   *
+   * @param img the Image from which to grab pixels
+   * @param x the x coordinate, relative to <code>img</code>'s
+   * top-left corner, of the grab rectangle's top-left pixel
+   * @param y the y coordinate, relative to <code>img</code>'s
+   * top-left corner, of the grab rectangle's top-left pixel
+   * @param w the width of the grab rectangle, in pixels
+   * @param h the height of the grab rectangle, in pixels
+   * @param forceRGB true to force conversion of the rectangular
+   * region's pixel data to RGB
+   */
+  public PixelGrabber(Image img,
+		      int x, int y,
+		      int w, int h,
+		      boolean forceRGB)
+  {
+    this.ip = img.getSource();
+    this.x = x;
+    this.y = y;
+    width = w;
+    height = h;
+    // If width or height is negative, postpone pixel buffer
+    // initialization until setDimensions is called back by ip.
+    if (width >= 0 && height >= 0)
+      {
+	int_pixel_buffer = new int[width * height];
+	byte_pixel_buffer = new byte[width * height];
+      }
+    this.forceRGB = forceRGB;
+  }
+
+  /**
+   * Start grabbing pixels.
+   *
+   * Spawns an image production thread that calls back to this
+   * PixelGrabber's ImageConsumer methods.
+   */
+  public synchronized void startGrabbing()
+  {
+    // Make sure we're not already grabbing.
+    if (grabbing == false)
+      {
+	grabbing = true;
+	grabberThread = new Thread ()
+	  {
+	    public void run ()
 	    {
-		grabbing = true;
-		ip.startProduction( this );
+	      ip.startProduction (PixelGrabber.this);
 	    }
-    }
-
-    /**
-       Abort the grabbing of pixels
-     */
-    public synchronized void abortGrabbing()
-    {
-	if ( grabbing == true )
-	    {
-		grabbing = false;
-		ip.removeConsumer( this );
-	    }
-    }
-
-    /**
-       Grab the Pixels.
-
-       @return true if successful
-
-       @throws InterruptedException if interrupted by another thread.
-     */
-    public boolean grabPixels() throws InterruptedException
-    {
-      return grabPixels(0);
-    }
-
-    /**
-       Grab the Pixels and abort if it takes too long
-
-       @return true if successful
-
-       @throws InterruptedException if interrupted by another thread.
-               or time runs out
-     */
-    public synchronized boolean grabPixels(long ms) throws InterruptedException
-    {
-	startGrabbing();
-	
-	if (ms < 0)
-	  return (status == ImageObserver.ALLBITS);
-	
-	wait(ms);
-	
-	if (status == ImageObserver.ALLBITS)
-	    return true;
-	else
-	    return false;
-    }
-
-    /**
-       Get the status of the pixel grabbing representing by ImageObserver flags
-
-       @return the status
-    */
-    public synchronized int getStatus()
-    {
-	return status;
-    }
-
-    /**
-       Return width of pixel region
-
-       @return width of region
-    */
-    public synchronized int getWidth()
-    {
-	return width;
-    }
-
-    /**
-       Return height of pixel region
-       
-       @return height of region
-    */
-    public synchronized int getHeight()
-    {
-	return height;
-    }
-
-    /**
-       Returns the grabbed pixel buffer 
-
-       @return a byte or int array
-    */
-    public synchronized Object getPixels()
-    {
-	if( pixel_bufferi != null )
-	    return pixel_bufferi;
-	return pixel_bufferb;
-    }
-
-    /**
-       Get the ColorModel of the image
-       
-       @return the ColorModel
-    */
-    public synchronized ColorModel getColorModel()
-    {
-	return model;
-    }
-
-    /**
-     * An <code>ImageProducer</code> indicates the size of the image
-     * being produced using this method.
-     * 
-     * @param width the width of the image
-     * @param height the height of the image 
-     */
-    public  void setDimensions(int width, int height)
-    {
-    }
-
-    /**
-     * An <code>ImageProducer</code> can set a list of properties
-     * associated with this image by using this method.
-     *
-     * @param props the list of properties associated with this image 
-     */
-    public  void setProperties(Hashtable props)
-    {
-	//this.props = props; //FIXME - DO WE NEED THIS
-    }
-
-    /**
-     * This <code>ColorModel</code> should indicate the model used by
-     * the majority of calls to <code>setPixels</code>.  Each call to
-     * <code>setPixels</code> could however indicate a different
-     * <code>ColorModel</code>.
-     *
-     * @param model the color model to be used most often by setPixels
-     * @see ColorModel 
-     */
-    public  void setColorModel(ColorModel model)
-    {
-	this.model = model;
-    }
-
-    /**
-     * The <code>ImageProducer</code> should call this method with a
-     * bit mask of hints from any of <code>RANDOMPIXELORDER</code>,
-     * <code>TOPDOWNLEFTRIGHT</code>, <code>COMPLETESCANLINES</code>,
-     * <code>SINGLEPASS</code>, <code>SINGLEFRAME</code>.
-     * 
-     * @param flags a bit mask of hints
-     */
-    public  void setHints(int flags)
-    {
-	//hints = flags; // FIXME - DO NOT KNOW WHAT TO DO WITH THE HINTS
-    }
-
-    /**
-     * This function delivers a rectangle of pixels where any
-     * pixel(m,n) is stored in the array as a <code>byte</code> at
-     * index (n * scansize + m + offset).  
-     */
-    public  void setPixels(int x, int y, int w, int h, 
-			   ColorModel model, byte[] pixels, int offset, int scansize)
-    {
-	//FIXME - I hate bytes
-	int xp, yp;
-	for( xp = x; xp < ( x + w); xp++ )
-	    for( yp = y; yp < (y + h); yp++ )
-		if( xp >= this.x && 
-		    yp >= this.y && 
-		    xp <= ( this.x + this.width ) && 
-		    yp <= ( this.y + this.height ) ) {
-		    pixel_bufferb[(yp - this.y) * this.scansize + (xp - this.x) + this.offset] =
-			pixels[ offset + yp * scansize + xp ];
-		}
-
-    }
-
-    /**
-     * This function delivers a rectangle of pixels where any
-     * pixel(m,n) is stored in the array as an <code>int</code> at
-     * index (n * scansize + m + offset).  
-     */
-    public  void setPixels(int x, int y, int w, int h, 
-			   ColorModel model, int[] pixels, int offset, int scansize)
-    {
-	int xp, yp;
-	for( xp = x; xp < ( x + w); xp++ )
-	    for( yp = y; yp < (y + h); yp++ )
-		if( xp >= this.x && 
-		    yp >= this.y && 
-		    xp <= ( this.x + this.width ) && 
-		    yp <= ( this.y + this.height ) ) {
-		    pixel_bufferi[(yp - this.y) * this.scansize + (xp - this.x) + this.offset] =
-			pixels[ offset + yp * scansize + xp ];
-		}
-    }
-
-    /**
-     * The <code>ImageProducer</code> calls this method to indicate a
-     * single frame or the entire image is complete.  The method is
-     * also used to indicate an error in loading or producing the
-     * image.  
-     */
-    public synchronized void imageComplete(int status)
-    {
-	this.status = status;
-    }
-
-    /**
-       Get the status of the pixel grabbing representing by ImageObserver flags
-
-       @return the status
-       
-       @specnote This method is not deprecated but getStatus is preferred to use
-     */
-    public synchronized int status()
-    {
-	return getStatus();
-    }
-
+	  };
+	grabberThread.start ();
+      }
+  }
+
+  /**
+   * Abort pixel grabbing.
+   */
+  public synchronized void abortGrabbing()
+  {
+    if (grabbing)
+      {
+	// Interrupt the grabbing thread.
+        Thread moribund = grabberThread;
+        grabberThread = null;
+        moribund.interrupt();
+
+	imageComplete (ImageConsumer.IMAGEABORTED);
+      }
+  }
+
+  /**
+   * Have our Image or ImageProducer start sending us pixels via our
+   * ImageConsumer methods and wait for all pixels in the grab
+   * rectangle to be delivered.
+   *
+   * @return true if successful, false on abort or error
+   *
+   * @throws InterruptedException if interrupted by another thread.
+   */
+  public synchronized boolean grabPixels() throws InterruptedException
+  {
+    return grabPixels(0);
+  }
+
+  /**
+   * grabPixels's behavior depends on the value of <code>ms</code>.
+   *
+   * If ms < 0, return true if all pixels from the source image have
+   * been delivered, false otherwise.  Do not wait.
+   *
+   * If ms >= 0 then we request that our Image or ImageProducer start
+   * delivering pixels to us via our ImageConsumer methods.
+   *
+   * If ms > 0, wait at most <code>ms</code> milliseconds for
+   * delivery of all pixels within the grab rectangle.
+   *
+   * If ms == 0, wait until all pixels have been delivered.
+   *
+   * @return true if all pixels from the source image have been
+   * delivered, false otherwise
+   *
+   * @throws InterruptedException if this thread is interrupted while
+   * we are waiting for pixels to be delivered
+   */
+  public synchronized boolean grabPixels(long ms) throws InterruptedException
+  {
+    if (ms < 0)
+      return ((observerStatus & (ImageObserver.FRAMEBITS
+				 | ImageObserver.ALLBITS)) != 0);
+
+    // Spawn a new ImageProducer thread to send us the image data via
+    // our ImageConsumer methods.
+    startGrabbing();
+
+    if (ms > 0)
+      {
+	long stop_time = System.currentTimeMillis() + ms;
+	long time_remaining;
+	while (grabbing)
+	  {
+	    time_remaining = stop_time - System.currentTimeMillis();
+	    if (time_remaining <= 0)
+	      break;
+	    wait (time_remaining);
+	  }
+	abortGrabbing ();
+      }
+    else
+      wait ();
+
+    // If consumerStatus is non-zero then the image is done loading or
+    // an error has occurred.
+    if (consumerStatus != 0)
+      return setObserverStatus ();
+
+    return ((observerStatus & (ImageObserver.FRAMEBITS
+			       | ImageObserver.ALLBITS)) != 0);
+  }
+
+  // Set observer status flags based on the current consumer status
+  // flags.  Return true if the consumer flags indicate that the
+  // image was loaded successfully, or false otherwise.
+  private synchronized boolean setObserverStatus ()
+  {
+    boolean retval = false;
+
+    if ((consumerStatus & IMAGEERROR) != 0)
+      observerStatus |= ImageObserver.ERROR;
+
+    if ((consumerStatus & IMAGEABORTED) != 0)
+      observerStatus |= ImageObserver.ABORT;
+
+    if ((consumerStatus & STATICIMAGEDONE) != 0)
+      {
+	observerStatus |= ImageObserver.ALLBITS;
+	retval = true;
+      }
+
+    if ((consumerStatus & SINGLEFRAMEDONE) != 0)
+      {
+	observerStatus |= ImageObserver.FRAMEBITS;
+	retval = true;
+      }
+
+    return retval;
+  }
+
+  /**
+   * @return the status of the pixel grabbing thread, represented by a
+   * bitwise OR of ImageObserver flags
+   */
+  public synchronized int getStatus()
+  {
+    return observerStatus;
+  }
+
+  /**
+   * @return the width of the grab rectangle in pixels, or a negative
+   * number if the ImageProducer has not yet called our setDimensions
+   * method
+   */
+  public synchronized int getWidth()
+  {
+    return width;
+  }
+
+  /**
+   * @return the height of the grab rectangle in pixels, or a negative
+   * number if the ImageProducer has not yet called our setDimensions
+   * method
+   */
+  public synchronized int getHeight()
+  {
+    return height;
+  }
+
+  /**
+   * @return a byte array of pixel data if ImageProducer delivered
+   * pixel data using the byte[] variant of setPixels, or an int array
+   * otherwise
+   */
+  public synchronized Object getPixels()
+  {
+    if (ints_delivered)
+      return int_pixel_buffer;
+    else if (bytes_delivered)
+      return byte_pixel_buffer;
+    else
+      return null;
+  }
+
+  /**
+   * @return the ColorModel currently being used for the majority of
+   * pixel data conversions
+   */
+  public synchronized ColorModel getColorModel()
+  {
+    return model;
+  }
+
+  /**
+   * Our <code>ImageProducer</code> calls this method to indicate the
+   * size of the image being produced.
+   *
+   * setDimensions is an ImageConsumer method.  None of PixelGrabber's
+   * ImageConsumer methods should be called by code that instantiates
+   * a PixelGrabber.  They are only made public so they can be called
+   * by the PixelGrabber's ImageProducer.
+   * 
+   * @param width the width of the image
+   * @param height the height of the image
+   */
+  public synchronized void setDimensions(int width, int height)
+  {
+    // Our width wasn't set when we were constructed.  Set our width
+    // so that the grab region includes all pixels from x to the right
+    // edge of the source image.
+    if (this.width < 0)
+      this.width = width - x;
+
+    // Our height wasn't set when we were constructed.  Set our height
+    // so that the grab region includes all pixels from y to the
+    // bottom edge of the source image.
+    if (this.height < 0)
+      this.height = height - y;
+
+    if (scansize < 0)
+      scansize = this.width;
+
+    if (int_pixel_buffer == null)
+      int_pixel_buffer = new int[this.width * this.height];
+
+    if (byte_pixel_buffer == null)
+      byte_pixel_buffer = new byte[this.width * this.height];
+  }
+
+  /**
+   * Our <code>ImageProducer</code> may call this method to send us a
+   * list of its image's properties.
+   *
+   * setProperties is an ImageConsumer method.  None of PixelGrabber's
+   * ImageConsumer methods should be called by code that instantiates
+   * a PixelGrabber.  They are only made public so they can be called
+   * by the PixelGrabber's ImageProducer.
+   *
+   * @param props a list of properties associated with the image being
+   * produced
+   */
+  public synchronized void setProperties(Hashtable props)
+  {
+    this.props = props;
+  }
+
+  /**
+   * Our ImageProducer will call <code>setColorModel</code> to
+   * indicate the model used by the majority of calls to
+   * <code>setPixels</code>.  Each call to <code>setPixels</code>
+   * could however indicate a different <code>ColorModel</code>.
+   *
+   * setColorModel is an ImageConsumer method.  None of PixelGrabber's
+   * ImageConsumer methods should be called by code that instantiates
+   * a PixelGrabber.  They are only made public so they can be called
+   * by the PixelGrabber's ImageProducer.
+   *
+   * @param model the color model to be used most often by setPixels
+   *
+   * @see ColorModel
+   */
+  public synchronized void setColorModel(ColorModel model)
+  {
+    this.model = model;
+  }
+
+  /**
+   * Our <code>ImageProducer</code> may call this method with a
+   * bit mask of hints from any of <code>RANDOMPIXELORDER</code>,
+   * <code>TOPDOWNLEFTRIGHT</code>, <code>COMPLETESCANLINES</code>,
+   * <code>SINGLEPASS</code>, <code>SINGLEFRAME</code>.
+   * 
+   * setHints is an ImageConsumer method.  None of PixelGrabber's
+   * ImageConsumer methods should be called by code that instantiates
+   * a PixelGrabber.  They are only made public so they can be called
+   * by the PixelGrabber's ImageProducer.
+   *
+   * @param flags a bit mask of hints
+   */
+  public synchronized void setHints(int flags)
+  {
+    hints = flags;
+  }
+
+  /**
+   * Our ImageProducer calls setPixels to deliver a subset of its
+   * pixels.
+   *
+   * Each element of the pixels array represents one pixel.  The
+   * pixel data is formatted according to the color model model.
+   * The x and y parameters are the coordinates of the rectangular
+   * region of pixels being delivered to this ImageConsumer,
+   * specified relative to the top left corner of the image being
+   * produced.  Likewise, w and h are the pixel region's dimensions.
+   *
+   * @param x x coordinate of pixel block
+   * @param y y coordinate of pixel block
+   * @param w width of pixel block
+   * @param h height of pixel block
+   * @param model color model used to interpret pixel data
+   * @param pixels pixel block data
+   * @param offset offset into pixels array
+   * @param scansize width of one row in the pixel block
+   */
+  public synchronized void setPixels(int x, int y, int w, int h, 
+				     ColorModel model, byte[] pixels,
+				     int offset, int scansize)
+  {
+    ColorModel currentModel;
+    if (model != null)
+      currentModel = model;
+    else
+      currentModel = this.model;
+
+    for(int yp = y; yp < (y + h); yp++)
+      {
+	for(int xp = x; xp < (x + w); xp++)
+	  {
+	    // Check if the coordinates (xp, yp) are within the
+	    // pixel block that we are grabbing.
+	    if(xp >= this.x
+	       && yp >= this.y
+	       && xp < (this.x + this.width)
+	       && yp < (this.y + this.height))
+	      {
+		int i = (yp - this.y) * this.scansize + (xp - this.x) + this.offset;
+		int p = (yp - y) * scansize + (xp - x) + offset;
+		if (forceRGB)
+		  {
+		    ints_delivered = true;
+
+		    assert (i >= 0 && i < int_pixel_buffer.length);
+		    assert (p >= 0 && p < pixels.length);
+		    int_pixel_buffer[i] = currentModel.getRGB (pixels[p]);
+		  }
+		else
+		  {
+		    bytes_delivered = true;
+
+		    assert (i >= 0 && i < byte_pixel_buffer.length);
+		    assert (p >= 0 && p < pixels.length);
+		    byte_pixel_buffer[i] = pixels[p];
+		  }
+	      }
+	  }
+      }
+  }
+
+  /**
+   * Our ImageProducer calls setPixels to deliver a subset of its
+   * pixels.
+   *
+   * Each element of the pixels array represents one pixel.  The
+   * pixel data is formatted according to the color model model.
+   * The x and y parameters are the coordinates of the rectangular
+   * region of pixels being delivered to this ImageConsumer,
+   * specified relative to the top left corner of the image being
+   * produced.  Likewise, w and h are the pixel region's dimensions.
+   *
+   * @param x x coordinate of pixel block
+   * @param y y coordinate of pixel block
+   * @param w width of pixel block
+   * @param h height of pixel block
+   * @param model color model used to interpret pixel data
+   * @param pixels pixel block data
+   * @param offset offset into pixels array
+   * @param scansize width of one row in the pixel block
+   */
+  public synchronized void setPixels(int x, int y, int w, int h, 
+				     ColorModel model, int[] pixels,
+				     int offset, int scansize)
+  {
+    ColorModel currentModel;
+    if (model != null)
+      currentModel = model;
+    else
+      currentModel = this.model;
+
+    ints_delivered = true;
+
+    for(int yp = y; yp < (y + h); yp++)
+      {
+	for(int xp = x; xp < (x + w); xp++)
+	  {
+	    // Check if the coordinates (xp, yp) are within the
+	    // pixel block that we are grabbing.
+	    if(xp >= this.x
+	       && yp >= this.y
+	       && xp < (this.x + this.width)
+	       && yp < (this.y + this.height))
+	      {
+		int i = (yp - this.y) * this.scansize + (xp - this.x) + this.offset;
+		int p = (yp - y) * scansize + (xp - x) + offset;
+		assert (i >= 0 && i < int_pixel_buffer.length);
+		assert (p >= 0 && p < pixels.length);
+		if (forceRGB)
+		  int_pixel_buffer[i] = currentModel.getRGB (pixels[p]);
+		else
+		  int_pixel_buffer[i] = pixels[p];
+	      }
+	  }
+      }
+  }
+
+  /**
+   * Our <code>ImageProducer</code> calls this method to inform us
+   * that a single frame or the entire image is complete.  The method
+   * is also used to inform us of an error in loading or producing the
+   * image.
+   *
+   * @param status the status of image production, represented by a
+   * bitwise OR of ImageConsumer flags
+   */
+  public synchronized void imageComplete(int status)
+  {
+    consumerStatus = status;
+    setObserverStatus ();
+    grabbing = false;
+    ip.removeConsumer (this);
+
+    notifyAll ();
+  }
+
+  /**
+   * @return the return value of getStatus
+   *
+   * @specnote The newer getStatus should be used in place of status.
+   */
+  public synchronized int status()
+  {
+    return getStatus();
+  }
 }

--=-UTL4Lf6cJ87SWdq5Et4w
Content-Disposition: attachment; filename=SimpleGrabber.java
Content-Type: text/x-java; name=SimpleGrabber.java; charset=
Content-Transfer-Encoding: 7bit

// Tags: JDK1.0

/* SimpleGrabber.java
   Copyright (C) 2003 Red Hat, Inc.

   This file is part of Mauve.

   Mauve is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 2, or (at your option)
   any later version.
 
   Mauve is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.
 
   You should have received a copy of the GNU General Public License
   along with Mauve; see the file COPYING.  If not, write to the Free
   Software Foundation, 59 Temple Place - Suite 330, Boston, MA
   02111-1307, USA. */

package gnu.testlet.java.awt.image.PixelGrabber;

import gnu.testlet.Testlet;
import gnu.testlet.TestHarness;

import java.awt.*;
import java.awt.image.*;

public class SimpleGrabber implements Testlet
{
  TestHarness harness;

  public void test (TestHarness harness)
  {
    this.harness = harness;

    Image i = null;

    try
      {
	String f = "gnu#testlet#java#awt#image#PixelGrabber#lena1.jpg";
	i = Toolkit.getDefaultToolkit().getImage (harness.getResourceFile (f).getAbsolutePath ());
      }
    catch (Exception e)
      {
	harness.fail ("lena1.jpg not found.");
      }

    String str = getPixels (i, 0, 0, 6, 12);

    harness.check (str,
		  "Pixel (0, 0)\n"
		  + "   R: 98 G: 31 B: 82\n"
		  + "Pixel (1, 0)\n"
		  + "   R: 79 G: 12 B: 63\n"
		  + "Pixel (2, 0)\n"
		  + "   R: 76 G: 9 B: 60\n"
		  + "Pixel (3, 0)\n"
		  + "   R: 152 G: 85 B: 136\n"
		  + "Pixel (4, 0)\n"
		  + "   R: 132 G: 66 B: 114\n"
		  + "Pixel (5, 0)\n"
		  + "   R: 95 G: 29 B: 77\n"
		  + "Pixel (0, 1)\n"
		  + "   R: 86 G: 19 B: 70\n"
		  + "Pixel (1, 1)\n"
		  + "   R: 75 G: 8 B: 59\n"
		  + "Pixel (2, 1)\n"
		  + "   R: 81 G: 14 B: 65\n"
		  + "Pixel (3, 1)\n"
		  + "   R: 150 G: 83 B: 134\n"
		  + "Pixel (4, 1)\n"
		  + "   R: 121 G: 55 B: 103\n"
		  + "Pixel (5, 1)\n"
		  + "   R: 85 G: 19 B: 67\n"
		  + "Pixel (0, 2)\n"
		  + "   R: 75 G: 11 B: 61\n"
		  + "Pixel (1, 2)\n"
		  + "   R: 79 G: 15 B: 65\n"
		  + "Pixel (2, 2)\n"
		  + "   R: 100 G: 36 B: 86\n"
		  + "Pixel (3, 2)\n"
		  + "   R: 155 G: 91 B: 141\n"
		  + "Pixel (4, 2)\n"
		  + "   R: 115 G: 52 B: 99\n"
		  + "Pixel (5, 2)\n"
		  + "   R: 76 G: 13 B: 60\n"
		  + "Pixel (0, 3)\n"
		  + "   R: 70 G: 8 B: 57\n"
		  + "Pixel (1, 3)\n"
		  + "   R: 91 G: 29 B: 78\n"
		  + "Pixel (2, 3)\n"
		  + "   R: 122 G: 60 B: 109\n"
		  + "Pixel (3, 3)\n"
		  + "   R: 162 G: 100 B: 149\n"
		  + "Pixel (4, 3)\n"
		  + "   R: 116 G: 53 B: 100\n"
		  + "Pixel (5, 3)\n"
		  + "   R: 69 G: 6 B: 53\n"
		  + "Pixel (0, 4)\n"
		  + "   R: 72 G: 13 B: 61\n"
		  + "Pixel (1, 4)\n"
		  + "   R: 102 G: 43 B: 91\n"
		  + "Pixel (2, 4)\n"
		  + "   R: 128 G: 69 B: 117\n"
		  + "Pixel (3, 4)\n"
		  + "   R: 154 G: 95 B: 143\n"
		  + "Pixel (4, 4)\n"
		  + "   R: 120 G: 58 B: 105\n"
		  + "Pixel (5, 4)\n"
		  + "   R: 64 G: 2 B: 49\n"
		  + "Pixel (0, 5)\n"
		  + "   R: 95 G: 36 B: 84\n"
		  + "Pixel (1, 5)\n"
		  + "   R: 117 G: 58 B: 106\n"
		  + "Pixel (2, 5)\n"
		  + "   R: 119 G: 60 B: 108\n"
		  + "Pixel (3, 5)\n"
		  + "   R: 136 G: 77 B: 125\n"
		  + "Pixel (4, 5)\n"
		  + "   R: 133 G: 74 B: 120\n"
		  + "Pixel (5, 5)\n"
		  + "   R: 73 G: 14 B: 60\n"
		  + "Pixel (0, 6)\n"
		  + "   R: 123 G: 65 B: 113\n"
		  + "Pixel (1, 6)\n"
		  + "   R: 125 G: 67 B: 115\n"
		  + "Pixel (2, 6)\n"
		  + "   R: 93 G: 35 B: 83\n"
		  + "Pixel (3, 6)\n"
		  + "   R: 106 G: 48 B: 96\n"
		  + "Pixel (4, 6)\n"
		  + "   R: 146 G: 89 B: 134\n"
		  + "Pixel (5, 6)\n"
		  + "   R: 88 G: 31 B: 76\n"
		  + "Pixel (0, 7)\n"
		  + "   R: 137 G: 79 B: 127\n"
		  + "Pixel (1, 7)\n"
		  + "   R: 123 G: 65 B: 113\n"
		  + "Pixel (2, 7)\n"
		  + "   R: 65 G: 7 B: 55\n"
		  + "Pixel (3, 7)\n"
		  + "   R: 78 G: 20 B: 68\n"
		  + "Pixel (4, 7)\n"
		  + "   R: 149 G: 92 B: 137\n"
		  + "Pixel (5, 7)\n"
		  + "   R: 95 G: 38 B: 83\n"
		  + "Pixel (0, 8)\n"
		  + "   R: 138 G: 80 B: 128\n"
		  + "Pixel (1, 8)\n"
		  + "   R: 96 G: 38 B: 86\n"
		  + "Pixel (2, 8)\n"
		  + "   R: 78 G: 20 B: 68\n"
		  + "Pixel (3, 8)\n"
		  + "   R: 76 G: 18 B: 66\n"
		  + "Pixel (4, 8)\n"
		  + "   R: 106 G: 49 B: 94\n"
		  + "Pixel (5, 8)\n"
		  + "   R: 122 G: 65 B: 110\n"
		  + "Pixel (0, 9)\n"
		  + "   R: 155 G: 97 B: 145\n"
		  + "Pixel (1, 9)\n"
		  + "   R: 99 G: 41 B: 89\n"
		  + "Pixel (2, 9)\n"
		  + "   R: 73 G: 15 B: 63\n"
		  + "Pixel (3, 9)\n"
		  + "   R: 80 G: 22 B: 70\n"
		  + "Pixel (4, 9)\n"
		  + "   R: 115 G: 58 B: 103\n"
		  + "Pixel (5, 9)\n"
		  + "   R: 107 G: 50 B: 95\n"
		  + "Pixel (0, 10)\n"
		  + "   R: 165 G: 106 B: 154\n"
		  + "Pixel (1, 10)\n"
		  + "   R: 99 G: 40 B: 88\n"
		  + "Pixel (2, 10)\n"
		  + "   R: 68 G: 9 B: 57\n"
		  + "Pixel (3, 10)\n"
		  + "   R: 83 G: 24 B: 72\n"
		  + "Pixel (4, 10)\n"
		  + "   R: 123 G: 64 B: 110\n"
		  + "Pixel (5, 10)\n"
		  + "   R: 88 G: 29 B: 75\n"
		  + "Pixel (0, 11)\n"
		  + "   R: 151 G: 92 B: 140\n"
		  + "Pixel (1, 11)\n"
		  + "   R: 93 G: 34 B: 82\n"
		  + "Pixel (2, 11)\n"
		  + "   R: 68 G: 9 B: 57\n"
		  + "Pixel (3, 11)\n"
		  + "   R: 81 G: 22 B: 70\n"
		  + "Pixel (4, 11)\n"
		  + "   R: 120 G: 58 B: 105\n"
		  + "Pixel (5, 11)\n"
		  + "   R: 74 G: 12 B: 59\n");
  }

  // Test eight-parameter constructor.
  public String getPixels(Image img, int x, int y, int w, int h)
  {
    int[] pix = new int[w * h];

    PixelGrabber pg = new PixelGrabber(img, x, y, w, h, pix, 0, w);
    try
      {
	pg.grabPixels(5000);
      }
    catch (InterruptedException e)
      {
	harness.fail ("image production interrupted.");
	return "";
      }

    if ((pg.getStatus() & ImageObserver.ABORT) != 0)
      {
	harness.fail ("image production aborted.");
	return "";
      }

    String result = "";
    for (int j = 0; j < h; j++)
      {
	for (int i = 0; i < w; i++)
	  {
	    int p = j * w + i;
	    result = result + getPixel (x + i, y + j, pix[p]);
	  }
      }
    return result;
  }

  public String getPixel (int x, int y, int pixel)
  {
    ColorModel model = ColorModel.getRGBdefault();

    return "Pixel (" + x + ", " + y + ")\n  "
      + " R: " + model.getRed (pixel)
      + " G: " + model.getGreen (pixel)
      + " B: " + model.getBlue (pixel) + "\n";
  }
}

--=-UTL4Lf6cJ87SWdq5Et4w--




From MAILER-DAEMON Tue Nov 25 13:31:14 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOhxR-0004rE-R2
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 13:30:41 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOhwm-0004Oh-Qg
	for classpath@gnu.org; Tue, 25 Nov 2003 13:30:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOhwA-00046U-7d
	for classpath@gnu.org; Tue, 25 Nov 2003 13:29:53 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOhvf-0003vK-Eb
	for classpath@gnu.org; Tue, 25 Nov 2003 13:28:51 -0500
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AOgyD-0004RC-00
	for <classpath@gnu.org>; Tue, 25 Nov 2003 18:27:25 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOgyC-0004R4-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 25 Nov 2003 18:27:24 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AOgyC-0003SX-00
	for <gmane-comp-java-classpath-devel@m.gmane.org>;
	Tue, 25 Nov 2003 18:27:24 +0100
From: graydon hoare <graydon@redhat.com>
Date: 25 Nov 2003 12:25:40 -0500
Lines: 79
Message-ID: <87vfp8z7fv.fsf@dub.venge.net>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Sender: news <news@sea.gmane.org>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 18:30:39 -0000

Sascha Brawer <brawer@dandelis.ch> writes:

> First, please write more test cases. I agree that it is boring, dumb, and
> taxing; testing slows down development. But it's also the most reliable
> way to make sure that code really works. If anyone needs to change our
> code in five years, they'll want to know whether their change has any
> serious impact. Without a large test suite, this is close to impossible.

I agree that we should be writing more test cases. but I think of it
in terms of a technical rather than moral failure: our testing system
requires mental energy beyond what we are willing to exert, and
rewards you with a sense of grinding tedium rather than excitement and
success. I think this is a result of mostly technical issues:

  - mauve should be arranged such that:
    - it's fetched, configured and built as part of classpath
    - it builds and runs with the JVM / compiler combination you
      configured classpath with
    - tests can be added inline with a source file, or "right next
      door" in a similarly-named class or package.
    - tests are run with "make check" from classpath, using $CWD as
      the package restriction when in a subdirectory
    - it uses simple introspection conventions rather than scanning
      text in a source tree and writing makefiles for itself

  - it should provide sub-frameworks for easily testing:
    - serializability
    - comparability, equality, hashing, toString, etc.
    - container protocols
    - threading protocols
    - property (bean) protocols
    - event listening / observer protocols
    - null-pointer sensitivity

  - it should provide (or at least provide a place to hook up)
    loopback, in-memory versions of:
    - "remote" web server
    - filesystem
    - window system
    - database server

  - it should provide generic facilities for doing:
    - pseudorandom / antirandom test vectors
    - all pairs / all n-tuples test reduction
    - noise-tolerant boundary / range checking
    - coverage and profiling analysis
    - establishing and releasing invariants across methods
    - establishing and releasing test prerequisites ("fixtures")

these are not too much to ask; existing JUnit-based suites often
provide some or all these as extensions to the basic TestCase class,
and they make testing feel much more productive. 

without enhancing the framework -- judging from the tests we've
accumulated so far -- I don't think the mauve suite is ever going to
offer you much assurance about whether a change has "serious impact".

> Second, please write understandable documentation for every single
> method. Developers should be able to create free programs without
> referring to external documents. These could disappear at any time.

I think javadoc is a very poor documentation system. it makes the same
mistake as the rest of the java libraries: that verbosity and
factoring into ever-smaller parts is a prima facie duty.

imo it should not be. it only works in your favour up to a point, then
it works against you. to understand a package or logical concept in
javadoc requires you to have dozens of browser tabs open, flipping
back and forth and assembling knowledge in pieces, like a jigsaw
puzzle. it's a very unpleasant way of reading.

I would much rather each class -- or each *package* -- had 1 javadoc
comment, maybe with some diagrams or the like, explaining its
operation in broad detail and pointing out salient features and how
they relate to one another. method-by-method operation is not
particularly useful to document, especially since it's free code and
you can always just read what the method does.

-graydon




From MAILER-DAEMON Tue Nov 25 14:15:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOies-0008PF-QM
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 14:15:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOiep-0008OY-JR
	for classpath@gnu.org; Tue, 25 Nov 2003 14:15:31 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOie8-0008F8-Js
	for classpath@gnu.org; Tue, 25 Nov 2003 14:15:20 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOie7-0008Eh-VF
	for classpath@gnu.org; Tue, 25 Nov 2003 14:14:48 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AOhgg-00023W-00
	for <classpath@gnu.org>; Tue, 25 Nov 2003 19:13:22 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AOhgc-00021h-00; Tue, 25 Nov 2003 19:13:18 +0100
Message-ID: <3FC39BBE.90209@kaffe.org>
Date: Tue, 25 Nov 2003 19:13:18 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: graydon hoare <graydon@redhat.com>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<87vfp8z7fv.fsf@dub.venge.net>
In-Reply-To: <87vfp8z7fv.fsf@dub.venge.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 19:15:33 -0000

Hi Graydon,

graydon hoare wrote:
> Sascha Brawer <brawer@dandelis.ch> writes:
> 
> 
>>First, please write more test cases. I agree that it is boring, dumb, and
>>taxing; testing slows down development. But it's also the most reliable
>>way to make sure that code really works. If anyone needs to change our
>>code in five years, they'll want to know whether their change has any
>>serious impact. Without a large test suite, this is close to impossible.
> 
> 
> I agree that we should be writing more test cases. but I think of it
> in terms of a technical rather than moral failure: our testing system
> requires mental energy beyond what we are willing to exert, and
> rewards you with a sense of grinding tedium rather than excitement and
> success. I think this is a result of mostly technical issues:
> 
>   - mauve should be arranged such that:
>     - it's fetched, configured and built as part of classpath

yes!

>     - it builds and runs with the JVM / compiler combination you
>       configured classpath with

oh yes!

>     - tests can be added inline with a source file, or "right next
>       door" in a similarly-named class or package.

only if you want mauve to have GNU Classpath specific features.

>     - tests are run with "make check" from classpath, using $CWD as
>       the package restriction when in a subdirectory

yes!

>     - it uses simple introspection conventions rather than scanning
>       text in a source tree and writing makefiles for itself

java.lang.reflect? I think that one's out of question for tests for java 
1.0. But I agree that reflection could make writing some tests easier. I 
was thinking about using reflection for generating tests for 
getter/setter pairs, for example.

>   - it should provide sub-frameworks for easily testing:
>     - serializability

yes!

>     - comparability, equality, hashing, toString, etc.

I'm dealing with equality, hashing & toString atm, and hope to have 
something to discuss on mauve-discuss based on some tests I'm writing 
for FieldPosition.

>     - container protocols
>     - threading protocols
>     - property (bean) protocols
>     - event listening / observer protocols
>     - null-pointer sensitivity

Add 'input sensitivity' to that. Many methods should check their input 
for correctness. I believe some of classpath's IO classes 
(BufferedReader ?) have problems with kaffe's regression tests for that.

>   - it should provide (or at least provide a place to hook up)
>     loopback, in-memory versions of:
>     - "remote" web server
>     - filesystem
>     - window system
>     - database server

yes!

>   - it should provide generic facilities for doing:
>     - pseudorandom / antirandom test vectors

definitely.

>     - all pairs / all n-tuples test reduction

test reduction? could you elaborate?

>     - noise-tolerant boundary / range checking

again, culd you elaborate some more on that?

>     - coverage and profiling analysis

yes! when I write a mauve test, I'd like to know what code paths I've 
missed. That should be possible to automatize.

>     - establishing and releasing invariants across methods
>     - establishing and releasing test prerequisites ("fixtures")
> 
> these are not too much to ask; existing JUnit-based suites often
> provide some or all these as extensions to the basic TestCase class,
> and they make testing feel much more productive. 
> 
> without enhancing the framework -- judging from the tests we've
> accumulated so far -- I don't think the mauve suite is ever going to
> offer you much assurance about whether a change has "serious impact".

Yep. And it is not so much fun to write tests in, if you have to do much 
of the above by hand for every other test you write.

>>Second, please write understandable documentation for every single
>>method. Developers should be able to create free programs without
>>referring to external documents. These could disappear at any time.
> 
> 
> I think javadoc is a very poor documentation system. it makes the same
> mistake as the rest of the java libraries: that verbosity and
> factoring into ever-smaller parts is a prima facie duty.

It's better than a lot of the rest, i.e. no docs at all. You can process 
documentation in various formats, etc. Of course something CWEB-ish 
would be a great thing, but I think JavaDoc goes a long way into that 
direction without requiring that you learn TeX ;)

> imo it should not be. it only works in your favour up to a point, then
> it works against you. to understand a package or logical concept in
> javadoc requires you to have dozens of browser tabs open, flipping
> back and forth and assembling knowledge in pieces, like a jigsaw
> puzzle. it's a very unpleasant way of reading.

That's only the case if a class is badly designed and has a ton of 
methods, fields & constructors. Of course, the JDK API is full of such 
things. ;) But that doesn't mean that our implementations need to be 
equally messy.

> I would much rather each class -- or each *package* -- had 1 javadoc
> comment, maybe with some diagrams or the like, explaining its
> operation in broad detail and pointing out salient features and how
> they relate to one another. method-by-method operation is not
> particularly useful to document, especially since it's free code and
> you can always just read what the method does.

That's what the top level comment of the class is for. To explain the 
general usage of the class. But you also need to document the methods, 
as the behaviour may be different depending on different states an 
instance can be in.

Example: A closed stream can not be read from. That's easy to see from 
the code, usually. But try to see what some methods in GregorianCalender 
are supposed to do just by reading the code. ;) I assume that 
understanding the Java2D code, if you're not proficient in 2D graphics, 
would not be trivial either.

You shouldn't have to understand how it works in order to use it. That's 
why you have JavaDocs on methods. To describe the user what she needs to 
know in order to use it ;)

cheers,
dalibor topic




From MAILER-DAEMON Tue Nov 25 15:21:21 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOjgW-0007xI-Ej
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 15:21:20 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOjgT-0007vr-2m
	for classpath@gnu.org; Tue, 25 Nov 2003 15:21:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOjfw-0007kb-3n
	for classpath@gnu.org; Tue, 25 Nov 2003 15:21:15 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOjfv-0007jZ-36
	for classpath@gnu.org; Tue, 25 Nov 2003 15:20:43 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOihm-0002Hw-00; Tue, 25 Nov 2003 20:18:34 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOiiF-0000L7-00; Tue, 25 Nov 2003 20:19:03 +0100
From: Mark Wielaard <mark@klomp.org>
To: Patrik Reali <reali@acm.org>
In-Reply-To: <002801c3b1e0$2cdce2d0$0301a8c0@pcprr>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<003701c3b1bf$49e8cf90$0301a8c0@pcprr>
	<1069594357.2851.1079.camel@elsschot.wildebeest.org>
	<002801c3b1e0$2cdce2d0$0301a8c0@pcprr>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1069787943.1305.1.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 20:19:03 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: GNU Classpath <classpath@gnu.org>, Sascha Brawer <brawer@dandelis.ch>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 20:21:18 -0000

Hi,

On Sun, 2003-11-23 at 17:38, Patrik Reali wrote:
> I could host the Classpath documentation on the Jaos site, but only as a
> temporary solution.

That would be very nice. It would (hopefully) be temporary.
But I want to have something up and running before bothering the GNU
system admins for a way to do the automatic update.
If we can show what kind of information we generate from where then it
will be easier for them to come up with a safe solution.

Cheers,

Mark



From MAILER-DAEMON Tue Nov 25 15:35:15 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOjtz-0006RE-62
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 15:35:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOjtw-0006Qb-Kw
	for classpath@gnu.org; Tue, 25 Nov 2003 15:35:12 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOjpa-0005AH-JB
	for classpath@gnu.org; Tue, 25 Nov 2003 15:31:13 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOjpa-0005A1-0O
	for classpath@gnu.org; Tue, 25 Nov 2003 15:30:42 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id MAA29476
	for <classpath@gnu.org>; Tue, 25 Nov 2003 12:29:15 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 394AB4F8090; Tue, 25 Nov 2003 12:19:31 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<87vfp8z7fv.fsf@dub.venge.net>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: ..  Like I always say -- nothing can beat the BRATWURST
	here in DUSSELDORF!!
Date: 25 Nov 2003 12:19:31 -0700
In-Reply-To: <87vfp8z7fv.fsf@dub.venge.net>
Message-ID: <87oev0w918.fsf@fleche.redhat.com>
Lines: 29
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 20:35:13 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

This discussion should probably take place on mauve-discuss...

graydon>   - mauve should be arranged such that:
graydon> [ ... great stuff ... ]

I think any improvements to Mauve are to be welcomed, and anybody
willing to put effort into improving the harness should go for it.

graydon>     - it uses simple introspection conventions rather than scanning
graydon>       text in a source tree and writing makefiles for itself

When I wrote the original mauve code, I set it up this way because
different free java implementations had different class coverage.  So
if someone added a new test, there was no guarantee it could be
compiled against a given class library.  Hence, source-level scanning
to eliminate tests you know you aren't interested in.

This need may be alleviated these days, now that everybody is moving
to Classpath.  Things were a lot different 5 years ago.

graydon> these are not too much to ask; existing JUnit-based suites often
graydon> provide some or all these as extensions to the basic TestCase class,
graydon> and they make testing feel much more productive. 

In the past people have also suggested converting Mauve to JUnit.

Tom



From MAILER-DAEMON Tue Nov 25 15:35:35 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOjuI-0006a6-M5
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 15:35:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOjuE-0006XD-Uz
	for classpath@gnu.org; Tue, 25 Nov 2003 15:35:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOjtc-0006KJ-VH
	for classpath@gnu.org; Tue, 25 Nov 2003 15:35:24 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOjtc-0006KC-KB
	for classpath@gnu.org; Tue, 25 Nov 2003 15:34:52 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOivX-0002Jc-00; Tue, 25 Nov 2003 20:32:47 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOiw1-0000Le-00; Tue, 25 Nov 2003 20:33:17 +0100
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <87ptfivqul.fsf@fleche.redhat.com>
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<003701c3b1bf$49e8cf90$0301a8c0@pcprr>
	<1069594357.2851.1079.camel@elsschot.wildebeest.org>
	<87ptfivqul.fsf@fleche.redhat.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1069788796.1298.16.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 20:33:17 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: Sascha Brawer <brawer@dandelis.ch>, GNU Classpath <classpath@gnu.org>
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 20:35:32 -0000

Hi,

On Sun, 2003-11-23 at 20:15, Tom Tromey wrote:
>
> I could set things up to post the pages to gcc.gnu.org nightly, just
> like we do for the classpath comparison.  This could be expedited if
> somebody sent a simple script to generate the pages.
> 
> Is gjdoc ready for this sort of work?

Yes, certainly! One example is what was created during the 0.06 release:
http://klomp.org/mark/classpath/doc/api/html/

The problem is setting gcjdoc up correctly since there has not been an
official gjdoc release. You have to combine gjdoc-proper with either
xsltproc (from libxml2) or with libxmlj (from classpathx) for xslt
transforms. This is really step one. Get a released gjdoc that works out
of the box. Debian used to come with one (natively compiled with gcj
even) but it is now unmaintained... Arnaud is trying again (but now
using kaffe). So hopefully we will have a easy to install gjdoc soon.

There was one issue with HTML entities not being processed correctly.
And some minor glitches with the HTML encoding being used.

The main reason that it is currently not enabled by the Classpath build
system is that we need to generate a real copyright/license on every
page from the actual source file it was generated from (the external
directory contains non-FSF copyrighted source code which might/might not
use the Classpath license-text) and that after the compromise of the
gnu-server earlier this year semi-automatic updating of files on that
machine have been disabled.

Cheers,

Mark



From MAILER-DAEMON Tue Nov 25 15:40:58 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOjzV-0000IP-0m
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 15:40:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOjzN-0000AY-I0
	for classpath@gnu.org; Tue, 25 Nov 2003 15:40:49 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOjyd-00089p-D0
	for classpath@gnu.org; Tue, 25 Nov 2003 15:40:40 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOjyc-00089B-Dn
	for classpath@gnu.org; Tue, 25 Nov 2003 15:40:02 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOj0c-0002KG-00; Tue, 25 Nov 2003 20:38:02 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOj16-0000Lx-00; Tue, 25 Nov 2003 20:38:32 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FC11B25.50205@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>
	<1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
	<1069190892.1745.23.camel@elsschot.wildebeest.org>
	<3FBAC3ED.1010904@kaffe.org>
	<1069266136.2856.42.camel@elsschot.wildebeest.org>
	<3FC11B25.50205@kaffe.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1069789112.1298.22.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 20:38:32 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] Field position attribute handling
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 20:40:55 -0000

Hi,

On Sun, 2003-11-23 at 21:40, Dalibor Topic wrote:

> 2003-11-23  Dalibor Topic <robilad@kaffe.org>
> 
>	* java/text/FieldPosition.java (equals): Fixed comment.

Looks fine. Please check it in.

> > It would be nice if we had something about the right way (tm) of writing
> > the standard clone(), toString(), hashCode() and equals() in the Hackers
> > Guide. (hint...)
> 
> I see. I'll try to come up with something based on what I've seen on the 
> web and Bloch's book.

Thanks. The current Classpath Hacking Guide is really out of date.
http://www.gnu.org/software/classpath/docs/hacking.html
People wishing to hack on it can find the (texi) source in the 'doc'
directory in cvs.

> True. I'll write some test code, and may post another patch that removes 
> it based on what I find.

Thanks for trying out Mauve. Hope we can use it much more consistently
in the future.

Cheers,

Mark



From MAILER-DAEMON Tue Nov 25 16:17:31 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOkYs-0008Rk-TP
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 16:17:30 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOkYq-0008Qa-JI
	for classpath@gnu.org; Tue, 25 Nov 2003 16:17:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOkYK-0008KA-Oj
	for classpath@gnu.org; Tue, 25 Nov 2003 16:17:27 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOkYK-0008K5-CY
	for classpath@gnu.org; Tue, 25 Nov 2003 16:16:56 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOjaH-0002Rb-00; Tue, 25 Nov 2003 21:14:53 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOjal-0000ND-00; Tue, 25 Nov 2003 21:15:23 +0100
From: Mark Wielaard <mark@klomp.org>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>
In-Reply-To: <20031124225726.43635.qmail@maczuka.gcd.org>
References: <1069431275.2861.580.camel@elsschot.wildebeest.org>
	<20031124225726.43635.qmail@maczuka.gcd.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1069791322.1303.41.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 21:15:22 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: classpath@gnu.org, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 21:17:29 -0000

Hi,

On Mon, 2003-11-24 at 23:57, Ito Kazumitsu wrote:
>
> 2003-11-25  Ito Kazumitsu  <kaz@maczuka.gcd.org>
> 
> 	* java/util/GregorianCalendar.java (getLinearTime): Avoid counting
>           the leap day of the leap year twice.
> 	  (computeFields): First week of month is 1 not 0.

Thanks (I made it real sentences - starting with a capital).
Looked some more at the code and I see now that the the first change was
inside a if (time >= gregorianCutover) so it now makes more sense to me.
And the second change seems correct given the above remark.
I'll commit it in Classpath.

Thanks for your work (and patience before it was accepted),

Mark




From MAILER-DAEMON Tue Nov 25 17:41:16 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOlrt-0005pT-75
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 17:41:13 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOlrj-0005mn-5l
	for classpath@gnu.org; Tue, 25 Nov 2003 17:41:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOlrB-0005Zi-Pu
	for classpath@gnu.org; Tue, 25 Nov 2003 17:41:01 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOlrB-0005ZK-FN
	for classpath@gnu.org; Tue, 25 Nov 2003 17:40:29 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOktC-0002cs-00
	for <classpath@gnu.org>; Tue, 25 Nov 2003 22:38:30 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOktg-0000PF-00
	for <classpath@gnu.org>; Tue, 25 Nov 2003 22:39:00 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1069796339.1303.125.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 22:39:00 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Subject: GNU Classpath 0.07 NEWS
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 22:41:04 -0000

Hi,

It has been three months since the last snapshot release so we are going
to do another one this week. I would like to get 0.07 out the door on
Friday. There are some URLConnection and gnu.java.net.protocol fixes
from libgcj that must go in since networking is very broken otherwise.
But we will do another snapshot release in three months anyway so it
doesn't have to be perfect. It really is just a development snapshot for
people who don't like to work from CVS. And it is a clear point to sync
with for some of the projects that depend on GNU Classpath, but don't
want to release with a CVS version.

Please add anything you want to get in for 0.07 before Friday, but try
to not destabilize the tree to much. Mauve results look reasonable now,
although they are not perfect yet. Adding the URLConnection and protocol
versions from libgcj I get the following results with Kissme:
182 of 10352 tests failed

Sascha send some nice updates to put into the NEWS file.
The current items look as follows:

New in release 0.07 (not-yet-released)
 
* java.awt gtk+ peers now depend on gtk+ 2.2.x.
* java.awt.geom.CubicCurve2D, java.awt.geom.QuadCurve2D:
  Subdivision and flatness calculation implemented.
* java.awt.geom.FlatteningPathIterator: Working implementation.
* gnu.java.awt.BitwiseXORComposite helper class.
* Improved documentation.
* Fixed various bugs in java.awt, java.awt.font, java.awt.geom, java.awt.image,
  javax.swing.undo, (possibly many others).
* Fixed Classpath bugs:
  #2944 Incorrect synchronization in java.util.logging.ErrorManager
  #6075 java.awt.geom.GeneralPath.getCurrentPoint returns wrong results
  #6076 java.awt.geom.GeneralPath constructor sometimes hangs
  #6089 java.awt.geom.GeneralPath.getPathIterator does not work
 
VM Interface changes:
 
* Thread has been split in a VM-independent Thread class and a VM-dependent
  VMThread class.

Please add anything that you think should be mentioned for people who
look for GNU Classpath progress by looking at NEWS items.

Thanks,

Mark



From MAILER-DAEMON Tue Nov 25 18:31:06 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AOmeA-00068V-E5
	for mharc-classpath@gnu.org; Tue, 25 Nov 2003 18:31:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AOmdw-00066f-27
	for classpath@gnu.org; Tue, 25 Nov 2003 18:30:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AOmdP-0005ww-7J
	for classpath@gnu.org; Tue, 25 Nov 2003 18:30:50 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AOmdM-0005wQ-Vb
	for classpath@gnu.org; Tue, 25 Nov 2003 18:30:17 -0500
Received: from slauerhoff.wildebeest.org
	([192.168.1.27] helo=localhost ident=mail)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AOlfM-0002jr-00; Tue, 25 Nov 2003 23:28:16 +0100
Received: from mark by localhost with local (Exim 3.36 #1 (Debian))
	id 1AOlfq-0000Qk-00; Tue, 25 Nov 2003 23:28:46 +0100
From: Mark Wielaard <mark@klomp.org>
To: David =?ISO-8859-1?Q?B=E9langer?= <dbelan2@cs.mcgill.ca>
In-Reply-To: <20031125010450.GA28109@pinto.cs.mcgill.ca>
References: <20031125010450.GA28109@pinto.cs.mcgill.ca>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Message-Id: <1069799326.1304.207.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 25 Nov 2003 23:28:46 +0100
Sender: Mark Wielaard <mark@slauerhoff>
Cc: classpath@gnu.org
Subject: Re: patch ZipFile
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2003 23:31:04 -0000

Hi,

On Tue, 2003-11-25 at 02:04, David B=E9langer wrote:
> The SableVM developers are moving to Classpath 0.06.  I will start
> sending bug fixes found in Classpath.

Very good news!
Please let us know when you have something releasable/testable.

> The first one is in ZipFile.  See patch included.
> The current Classpath implementation removes the path component
> from the name when the JarFile is created with new ZipFile(new
> File(name)).

Thanks. I created a Mauve test for this and checked that your patch
fixes the issue.

Applied as:

2003-11-25  David belanger  <dbelan2@cs.mcgill.ca>

        * java/util/zip/ZipFile (Zipfile(File)): Set file path as name.
        (ZipFile(File,int)): Likewise.=20

Very sorry to lose your \x{00E9}, I just couldn't get it in correctly
(being logged into my development machine remotely).

Cheers,

Mark



From MAILER-DAEMON Wed Nov 26 12:53:48 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP3rI-0007dI-Jv
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 12:53:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP3rE-0007c4-H2
	for classpath@gnu.org; Wed, 26 Nov 2003 12:53:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP3qh-0007SX-CX
	for classpath@gnu.org; Wed, 26 Nov 2003 12:53:42 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AP3qg-0007R5-P7
	for classpath@gnu.org; Wed, 26 Nov 2003 12:53:10 -0500
Received: from fleche.redhat.com (lt658_076.peakpeak.com [199.165.157.76] (may
	be forged))
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id JAA20728;
	Wed, 26 Nov 2003 09:51:37 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 40D3B4F8288; Wed, 26 Nov 2003 09:41:47 -0700 (MST)
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <1069733080.4125.479.camel@tortoise.toronto.redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: CALIFORNIA is where people from IOWA or NEW YORK go to subscribe to
	CABLE TELEVISION!!
Date: 26 Nov 2003 09:41:47 -0700
In-Reply-To: <1069733080.4125.479.camel@tortoise.toronto.redhat.com>
Message-ID: <87r7zvrsj8.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Classpath Patches <classpath@gnu.org>,
	GCJ Patches <java-patches@gcc.gnu.org>
Subject: Re: PixelGrabber fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 17:53:46 -0000

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch completes the PixelGrabber implementation, updates its
Tom> javadocs and includes a mauve test case.

Excellent.

Tom> OK to commit?

Definitely, thanks.

FYI, Mauve tests don't require approval.  It's a free-for-all.

Tom



From MAILER-DAEMON Wed Nov 26 16:09:45 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP6u3-0007uJ-HM
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 16:08:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP62L-0004zk-8E
	for classpath@gnu.org; Wed, 26 Nov 2003 15:13:21 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP61Q-0003Px-QZ
	for classpath@gnu.org; Wed, 26 Nov 2003 15:12:55 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AP61Q-0003JM-BO
	for classpath@gnu.org; Wed, 26 Nov 2003 15:12:24 -0500
Received: from free.fr (cachan-3-82-66-125-112.fbx.proxad.net [82.66.125.112])
	by postfix4-1.free.fr (Postfix) with ESMTP id E845D109FBA
	for <classpath@gnu.org>; Wed, 26 Nov 2003 20:10:54 +0100 (CET)
Message-ID: <3FC4FAA8.4040301@free.fr>
Date: Wed, 26 Nov 2003 20:10:32 +0100
From: Guilhem Lavaux <guilhem.lavaux@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------070602050507030608090004"
X-Mailman-Approved-At: Wed, 26 Nov 2003 16:08:49 -0500
Subject: [PATCH] Pre-submit for serialization
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 20:13:38 -0000

This is a multi-part message in MIME format.
--------------070602050507030608090004
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I think I will have to begin the split of the serialization patch at a 
time or another. I'm beginning with this really simple patch for 
TypeSignature.
It is needed so class can resolved by name using a specific class loader 
and not using a default class loader as it was the case with the 
previous API.

This change was originally submitted/suggested by Helmer Kraemer to fix 
something in the modified serializer.

Cheers,
Guilhem.

ChangeLog:

2003-11-26  Guilhem Lavaux <guilhem@kaffe.org>, Helmer Kraemer <hkraemer@freenet.de>

	* gnu/java/lang/reflect/TypeSignature.java
	(getClassForEncoding) Splitted the method so we can specify an 
	explicit boot loader.


--------------070602050507030608090004
Content-Type: text/plain;
 name="typesig_diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="typesig_diff"

Index: gnu/java/lang/reflect/TypeSignature.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/lang/reflect/TypeSignature.java,v
retrieving revision 1.10
diff -u -r1.10 TypeSignature.java
--- gnu/java/lang/reflect/TypeSignature.java	22 Mar 2002 21:25:20 -0000	1.10
+++ gnu/java/lang/reflect/TypeSignature.java	16 Nov 2003 16:27:05 -0000
@@ -150,6 +150,12 @@
   public static Class getClassForEncoding(String type_code, boolean descriptor)
     throws ClassNotFoundException
   {
+    return getClassForEncoding(type_code, descriptor, null);
+  }
+
+  public static Class getClassForEncoding(String type_code, boolean descriptor, ClassLoader loader)
+    throws ClassNotFoundException
+  {
     if (descriptor)
       {
         switch (type_code.charAt(0))
@@ -181,7 +187,7 @@
           case '[':
           }
       }
-    return Class.forName(type_code.replace('/', '.'));
+    return Class.forName(type_code.replace('/', '.'), true, loader);
   }
 
   /**

--------------070602050507030608090004--




From MAILER-DAEMON Wed Nov 26 16:35:04 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP7JP-0002Rk-VM
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 16:35:03 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP7JN-0002QH-3l
	for classpath@gnu.org; Wed, 26 Nov 2003 16:35:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP7Ij-0002EC-KG
	for classpath@gnu.org; Wed, 26 Nov 2003 16:34:52 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AP7Ij-0002Dk-9J
	for classpath@gnu.org; Wed, 26 Nov 2003 16:34:21 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-1.free.fr (Postfix) with ESMTP id 5DE0B1094CC
	for <classpath@gnu.org>; Wed, 26 Nov 2003 21:07:30 +0100 (CET)
Message-ID: <3FC507FC.7030402@kaffe.org>
Date: Wed, 26 Nov 2003 21:07:24 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [PATCH] Serialization #2 (set field methods)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 21:35:02 -0000

Hi,

This patch adds extra checking required by JDK's behaviour. If someone 
tries to assign a field which has not the required type then an 
InvalidClassException should be thrown.

Please review it.

Cheers,
Guilhem.

P.S.: Should I really write a documentation for each of the methods in 
this patch ? I would think they are straightforward to understand... In 
the other case I'll try to write something.

ChangeLog:

2003-26-11  Guilhem Lavaux <guilhem@kaffe.org>

	* java/io/ObjectInputStream.java:
	(setBooleanField) Throw an InvalidClassException if the field hasn't the required
	type.
	(setByteField) Likewise.
	(setCharField) Likewise.
	(setDoubleField) Likewise.
	(setFloatField) Likewise.
	(setIntField) Likewise.
	(setShortField) Likewise.
	(setLongField) Likewise.
	(setObjectField) Likewise.





From MAILER-DAEMON Wed Nov 26 17:05:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP7nB-000437-1J
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 17:05:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP7mB-0003AC-M0
	for classpath@gnu.org; Wed, 26 Nov 2003 17:04:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP7lR-00020L-MF
	for classpath@gnu.org; Wed, 26 Nov 2003 17:04:32 -0500
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AP7lQ-0001uP-1W
	for classpath@gnu.org; Wed, 26 Nov 2003 17:04:00 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-82-085.ewetel.net
	[80.228.82.85])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id hAQL20Iw013958;
	Wed, 26 Nov 2003 22:02:01 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AP6o2-0005l5-00; Wed, 26 Nov 2003 22:02:38 +0100
Date: Wed, 26 Nov 2003 22:02:38 +0100
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>
Message-ID: <20031126210238.GA21513@mail.konqueror.de>
References: <3FC507FC.7030402@kaffe.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3FC507FC.7030402@kaffe.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Serialization #2 (set field methods)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 22:05:47 -0000

On Wed, Nov 26, 2003 at 09:07:24PM +0100, Guilhem Lavaux wrote:
> P.S.: Should I really write a documentation for each of the methods in 
> this patch ? I would think they are straightforward to understand... In 
> the other case I'll try to write something.

The way you do it here seems okay, but I cant look at the patch. Its not
attached.

> 	the required
> 	type.

This can go on one line.


Michael



From MAILER-DAEMON Wed Nov 26 17:37:45 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP8I5-0002h4-KQ
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 17:37:45 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP8HL-00021a-HF
	for classpath@gnu.org; Wed, 26 Nov 2003 17:36:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP8GN-0001Is-UD
	for classpath@gnu.org; Wed, 26 Nov 2003 17:36:31 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AP8GJ-0001EL-M8
	for classpath@gnu.org; Wed, 26 Nov 2003 17:35:55 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-1.free.fr (Postfix) with ESMTP id 1F56310D850
	for <classpath@gnu.org>; Wed, 26 Nov 2003 22:07:32 +0100 (CET)
Message-ID: <3FC5160F.5090103@kaffe.org>
Date: Wed, 26 Nov 2003 22:07:27 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------080005060604000008050706"
Subject: [PATCH] Serialization #3
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 22:37:44 -0000

This is a multi-part message in MIME format.
--------------080005060604000008050706
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

This the patch number 3. It adds a few methods to 
java.io.ObjectStreamField: they will become necessary for the next 
patches that will follow tomorrow. BTW, it fixes the behaviour of a 
constructor which should throw a NullPointerException according to JDK's 
behaviour but was not in classpath's.

I will add the documentation on time. But you may understand that it's a 
nightmare to separate all portions of code as they've been written in 
one pass. BTW, I will also build some additionnal Mauve tests to import 
kaffe's tests.

Cheers,
Guilhem.

ChangeLog:

2003-26-11  Guilhem Lavaux <guilhem@kaffe.org>

	* java/io/ObjectStreamField.java: A few methods were added in prevision of the
	upcoming upgrade of the serialization code. 
	(ObjectStreamField): We should throw a NullPointerException when 'name' is null. 


--------------080005060604000008050706
Content-Type: text/plain;
 name="field_diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="field_diff"

Index: ObjectStreamField.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamField.java,v
retrieving revision 1.10
diff -u -r1.10 ObjectStreamField.java
--- ObjectStreamField.java	21 Jun 2003 11:43:41 -0000	1.10
+++ ObjectStreamField.java	26 Nov 2003 20:49:34 -0000
@@ -48,7 +48,9 @@
   private String typename;
   private int offset = -1; // XXX make sure this is correct
   private boolean unshared;
-  
+  private boolean persistent = false;
+  private boolean toset = true;
+
   public ObjectStreamField (String name, Class type)
   {
     this (name, type, false);
@@ -56,6 +58,9 @@
 
   public ObjectStreamField (String name, Class type, boolean unshared)
   {
+    if (name == null)
+      throw new NullPointerException();
+
     this.name = name;
     this.type = type;
     this.typename = TypeSignature.getEncodingOfClass(type);
@@ -79,6 +84,19 @@
         type = Object.class; //FIXME: ???
       }
   }
+
+  ObjectStreamField (String name, String typename, ClassLoader loader){
+    this.name = name;
+    this.typename = typename;
+    try
+      {
+        type = TypeSignature.getClassForEncoding(typename, true, loader);
+      }
+    catch(ClassNotFoundException e)
+      {
+        type = Object.class; // ALSO FIXME 
+      }
+  }
   
   public String getName ()
   {
@@ -98,6 +116,8 @@
   public String getTypeString ()
   {
     // use intern()
+    if (this.type.isPrimitive())
+      return null;
     return typename.intern();
   }
 
@@ -134,6 +154,26 @@
       return 1;
 
     return getName ().compareTo (f.getName ());
+  }
+
+  protected void setPersistent(boolean persistent)
+  {
+    this.persistent = persistent;
+  }
+
+  protected boolean isPersistent()
+  {
+    return persistent;
+  }
+
+  protected void setToSet(boolean toset)
+  {
+    this.toset = toset;
+  }
+
+  protected boolean isToSet()
+  {
+    return toset;
   }
 
   public String toString ()

--------------080005060604000008050706--




From MAILER-DAEMON Wed Nov 26 17:44:44 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AP8Oq-0005As-CO
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 17:44:44 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AP8Om-000596-Na
	for classpath@gnu.org; Wed, 26 Nov 2003 17:44:40 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AP8OG-0004pH-0r
	for classpath@gnu.org; Wed, 26 Nov 2003 17:44:39 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AP8OF-0004Yk-Hh
	for classpath@gnu.org; Wed, 26 Nov 2003 17:44:07 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AP7QH-0008Pk-M2
	for classpath@gnu.org; Wed, 26 Nov 2003 16:42:10 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-1.free.fr (Postfix) with ESMTP id 48B6B10D405
	for <classpath@gnu.org>; Wed, 26 Nov 2003 22:00:38 +0100 (CET)
Message-ID: <3FC51471.3020705@kaffe.org>
Date: Wed, 26 Nov 2003 22:00:33 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
References: <3FC507FC.7030402@kaffe.org>
In-Reply-To: <3FC507FC.7030402@kaffe.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------090403050401000705070500"
Subject: Re: [PATCH] Serialization #2 (set field methods)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 22:44:41 -0000

This is a multi-part message in MIME format.
--------------090403050401000705070500
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Sorry. Here is the patch.

Guilhem.

--------------090403050401000705070500
Content-Type: text/plain;
 name="patch_no_2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch_no_2"

Index: java/io/ObjectInputStream.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v
retrieving revision 1.32
diff -u -r1.32 ObjectInputStream.java
--- java/io/ObjectInputStream.java	1 Aug 2003 03:33:59 -0000	1.32
+++ java/io/ObjectInputStream.java	26 Nov 2003 20:58:42 -0000
@@ -1566,78 +1566,102 @@
   private native void callConstructor (Class clazz, Object obj);
 
   private void setBooleanField (Object obj, Class klass, String field_name,
-				boolean val)
+				boolean val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setBoolean (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
   }
 
   private void setByteField (Object obj, Class klass, String field_name,
-			     byte val)
+			     byte val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setByte (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
   }
 
   private void setCharField (Object obj, Class klass, String field_name,
-			     char val)
+			     char val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setChar (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
   }
 
   private void setDoubleField (Object obj, Class klass, String field_name,
-			       double val)
+			       double val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setDouble (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
   }
 
   private void setFloatField (Object obj, Class klass, String field_name,
-			      float val)
+			      float val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setFloat (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
   }
 
   private void setIntField (Object obj, Class klass, String field_name,
-			    int val)
+			    int val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setInt (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
@@ -1645,13 +1669,17 @@
 
 
   private void setLongField (Object obj, Class klass, String field_name,
-			     long val)
+			     long val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setLong (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
@@ -1659,13 +1687,17 @@
 
 
   private void setShortField (Object obj, Class klass, String field_name,
-			      short val)
+			      short val) throws IOException
   {
     try
       {
 	Field f = getField (klass, field_name);
 	f.setShort (obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+      }
     catch (Exception _)
       {
       }    
@@ -1673,17 +1705,24 @@
 
 
   private void setObjectField (Object obj, Class klass, String field_name,
-			       String type_code, Object val)
+			       String type_code, Object val) throws IOException
   {
     try
       {
-	Field f = getField (klass, field_name);
-	// FIXME: We should check the type_code here
-	f.set (obj, val);
+ 	Field f = getField (klass, field_name);
+	ObjectStreamField of = new ObjectStreamField(field_name, f.getType());
+	
+	if (of.getTypeString() == null ||
+	    !of.getTypeString().equals(type_code))
+          throw new InvalidClassException("incompatible field type for " + klass.getName() + "." + field_name);
+ 	f.set (obj, val);
       }
-    catch (Exception _)
+    catch (InvalidClassException e)
       {
-      }    
+	throw e;
+      }
+    catch (Exception _)
+      {}
   }
 
   private static final int BUFFER_SIZE = 1024;

--------------090403050401000705070500--




From MAILER-DAEMON Wed Nov 26 23:44:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APE0d-0000Kk-PC
	for mharc-classpath@gnu.org; Wed, 26 Nov 2003 23:44:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APE0Y-0000Fb-2V
	for classpath@gnu.org; Wed, 26 Nov 2003 23:44:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APDzz-00005Y-SW
	for classpath@gnu.org; Wed, 26 Nov 2003 23:43:58 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APDzz-00005V-KM
	for classpath@gnu.org; Wed, 26 Nov 2003 23:43:27 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hAR3g2H12938
	for <classpath@gnu.org>; Wed, 26 Nov 2003 22:42:02 -0500
Received: from dub.venge.net (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hAR3g1w26008
	for <classpath@gnu.org>; Wed, 26 Nov 2003 22:42:02 -0500
Sender: graydon@dub.venge.net
To: classpath@gnu.org
References: <20031122172146.1291@smtp.mail.ch.easynet.net>
	<87vfp8z7fv.fsf@dub.venge.net> <3FC39BBE.90209@kaffe.org>
From: graydon hoare <graydon@redhat.com>
Date: 26 Nov 2003 22:40:18 -0500
In-Reply-To: <3FC39BBE.90209@kaffe.org>
Message-ID: <87zneiiin1.fsf@dub.venge.net>
Lines: 104
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 04:44:03 -0000

Dalibor Topic <robilad@kaffe.org> writes:

> >     - tests can be added inline with a source file, or "right next
> >       door" in a similarly-named class or package.
> 
> only if you want mauve to have GNU Classpath specific features.

I guess my point is I'd like to lower, as far as possible, the cost of
writing such a class, and putting it inline with the classpath code
lowers the cost further (no need to do a separate "cvs add", open a
new file, copy the legal boilerplate, etc.)

my gut feeling (I don't mean to be insulting or dismissive, just
observing) is that few people -- and progressively fewer as time
passes -- will have a use for mauve outside testing classpath. if
they're a proprietary vendor, they'll buy a sun compatibility kit;
everyone else seems, from my limited perspective, to be slowly coming
around to the benefits of just throwing their weight behind classpath.

> >     - it uses simple introspection conventions rather than scanning
> >       text in a source tree and writing makefiles for itself
> 
> java.lang.reflect? I think that one's out of question for tests for
> java 1.0. But I agree that reflection could make writing some tests
> easier. I was thinking about using reflection for generating tests for
> getter/setter pairs, for example.

is 1.0 testing -- or rather, running on a non-reflect-able JVM --
really an issue? I appreciate the air of openness and compatibility
suggested here, but some aspects of introspection are pretty handy,
and can help automate a lot.

> >     - comparability, equality, hashing, toString, etc.
> 
> I'm dealing with equality, hashing & toString atm, and hope to have
> something to discuss on mauve-discuss based on some tests I'm writing
> for FieldPosition.

cool!

> >     - all pairs / all n-tuples test reduction
> 
> test reduction? could you elaborate?

http://fit.c2.com/wiki.cgi?AllPairs
http://burtleburtle.net/bob/math/jenny.html

> >     - noise-tolerant boundary / range checking
> 
> again, culd you elaborate some more on that?

oh, this is actually a mental fudge; I'm really describing two things
here, neither of which is terribly high-tech:

  - utility functions which know how to explore boundary conditions
    for various data (maximum and minimum integral sizes, successive
    powers of two, edges of floating point representations, etc.) and
    iterate tests "near" boundary conditions (+1 and -1, >>1 and <<1,
    +epsilon, -epsilon, etc.)

  - utility functions for checking results "near" ideal values, within
    tolerance ranges, which you need for many things using floating
    point, anything which tests speed or memory use, or anything 
    with nondeterministic results (say, related to threading).

> >     - coverage and profiling analysis
> 
> yes! when I write a mauve test, I'd like to know what code paths I've
> missed. That should be possible to automatize.

indeed it is, there's a JUnit extension which does decision coverage
(not quite as powerful as complete path coverage, but tractable) using
BCEL, seems quite friendly: http://hansel.sourceforge.net/

> Yep. And it is not so much fun to write tests in, if you have to do
> much of the above by hand for every other test you write.

that's the thing. test-writing has to be made to feel at least as
engaging as code-writing, if it's to be successful.

> That's only the case if a class is badly designed and has a ton of
> methods, fields & constructors. Of course, the JDK API is full of such
> things. ;) But that doesn't mean that our implementations need to be
> equally messy.

well, they do if they conform to the public API. I guess I was just
responding to sascha's demand for each and every method to get a
javadoc comment; personally I feel this is a waste of our limited
time, and am anyways much happier as a user when I open a class to see
a multi-paragraph block at the beginning, than one with lots of little
fiddly document fragments that are uninformative, or repetitive.

> Example: A closed stream can not be read from. That's easy to see from
> the code, usually. But try to see what some methods in
> GregorianCalender are supposed to do just by reading the code. ;) I
> assume that understanding the Java2D code, if you're not proficient in
> 2D graphics, would not be trivial either.

exactly my point: I think the user should get a short education in 2d
graphics programming when they look up Graphics2D, not a list of
method-by-method details. I'm happy to write the former, less so the
latter.

-graydon




From MAILER-DAEMON Thu Nov 27 05:25:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APJKd-0003UP-Pq
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 05:25:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APJKU-0003RF-De
	for classpath@gnu.org; Thu, 27 Nov 2003 05:24:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APJJw-0002vB-Sc
	for classpath@gnu.org; Thu, 27 Nov 2003 05:24:56 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APJJw-0002t1-0w
	for classpath@gnu.org; Thu, 27 Nov 2003 05:24:24 -0500
Received: from [192.168.1.33] (unknown [217.8.220.21])
	by smtp2.mail.ch.easynet.net (Postfix) with ESMTP id BF1096463C
	for <classpath@gnu.org>; Thu, 27 Nov 2003 10:22:56 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Thu, 27 Nov 2003 10:21:42 +0100
Message-Id: <20031127092142.28354@smtp.mail.ch.easynet.net>
In-Reply-To: <87zneiiin1.fsf@dub.venge.net>
References: <87zneiiin1.fsf@dub.venge.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: Tests, Documentation
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 10:25:04 -0000

graydon hoare <graydon@redhat.com> wrote on Wed, 26 Nov 2003 22:40:18 -0500:

> [many proposals for testing]

IMHO, most proposals sound very convincing.


>>>     - tests can be added inline with a source file, or "right next
>>>       door" in a similarly-named class or package.
>
>I guess my point is I'd like to lower, as far as possible, the cost of
>writing such a class, and putting it inline with the classpath code
>lowers the cost further (no need to do a separate "cvs add", open a
>new file, copy the legal boilerplate, etc.)

I would't find inlined test code too desirable, for several reasons:

1. The source files would get more difficult to read.

2. It would make it difficult to check the tests against the Sun JDK (see
below).

3. If tests were part of the sources, the size of the compiled code would
grow. This may be a problem for those users of Classpath who care about
memory consumption.

4. An inlined test suite might make some compiler optimizations more
difficult, because all code paths are executed.

One could avoid some of these problems by conditional compilation (#if/
#endif), or trickeries with some other macro engine. Personally, I would
be strongly opposed to introducing macros into Classpath code (because I
find macros evil, maybe with the exception of Lisp). But I'm aware that
any Real Programmer will have a different opinion. It's probably a matter
of taste.

Isn't "similarly-named class or package" exactly what we have in Mauve?

The tests for the method javax.swing.
undo.AbstractUndoableEdit.getPresentationName are located in
gnu.testlet.javax.swing.undo.AbstractUndoableEdit.getPresentationName.
Verbosity rules :-)

>my gut feeling (I don't mean to be insulting or dismissive, just
>observing) is that few people -- and progressively fewer as time
>passes -- will have a use for mauve outside testing classpath.

While I'd agree, I wonder whether it isn't in our own interest to run our
tests on proprietary Java environments. Runnning our tests against non-
Classpath implementations may help validating the test suite. Especially
in the case of the Sun JDK, which could be considered the reference
implementation for the Java environment. 


>is 1.0 testing -- or rather, running on a non-reflect-able JVM --
>really an issue? I appreciate the air of openness and compatibility
>suggested here, but some aspects of introspection are pretty handy,
>and can help automate a lot.

Hm, I'm not sure: Is introspection really part of every Java environment
that is being used nowadays? How about the mobile/connected device/...
profiles? (I don't know whether we want to care about these at all).

In general, I'd agree that using JUnit seems like a good idea. The bridge
class that you've sent to mauve-discuss is probably exactly what is needed.

About integrating Mauve into the Classpath cvs repository, I wouldn't
care a lot. I assume that the copyright issues that Mark mentioned would
possibly be solvable by letting people assign copyright to the FSF. But
would we gain much from Mauve and Classpath being part of the same source
tree?

>test-writing has to be made to feel at least as
>engaging as code-writing, if it's to be successful.

I imagine that this will be hard: For most people (including myself),
it's so much more fun to write code that actually does something.

Maybe we should take turns in baking chocolate cakes? Once a month, a
fresh cake would be sent to the person who has contributed the largest
number of test cases. Please don't laugh, I mean it seriously.


> [Documentation style]
>exactly my point: I think the user should get a short education in 2d
>graphics programming when they look up Graphics2D, not a list of
>method-by-method details. I'm happy to write the former, less so the
>latter.

Hm, this may well be a question of personal preference.

Personally, I'd like to have both good per-package introductions and
decent detail documentation. I think they serve a different purpose, but
both are equally important.

But we obviously have only limited resources. With my complaint, I mostly
wanted to whine about the piles of Classpath code that have no
documentation whatsoever.

In any case, I really don't think that "read the source, gal/dude" is an
appropriate answer to people who want to just use our code. It takes so
much less time to read a well-written description than to browse through
thousands of lines of code. (Again, others might well have different
experiences).

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Thu Nov 27 07:56:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APLh3-00067M-Fi
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 07:56:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APLh0-00066B-UI
	for classpath@gnu.org; Thu, 27 Nov 2003 07:56:22 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APLdz-0004uS-L0
	for classpath@gnu.org; Thu, 27 Nov 2003 07:53:47 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APLdt-0004kP-Ot
	for classpath@gnu.org; Thu, 27 Nov 2003 07:53:09 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APKfu-000782-00
	for <classpath@gnu.org>; Thu, 27 Nov 2003 12:51:10 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-w/WbHU13D5QYRofGaIU2"
Message-Id: <1069933901.27173.14.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 27 Nov 2003 12:51:41 +0100
Subject: Compiling on Windows like systems
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 12:56:23 -0000


--=-w/WbHU13D5QYRofGaIU2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

configure.in had the following macro definitions:
 AC_CYGWIN
 AC_MINGW32

The Autoconf manual says they are deprecated and all autotools complain
loudly about their usage. Since I couldn't find a real reason for using
them I just removed them for now. Do we actually have people compiling
Classpath (native libraries) on those systems? Could they check what
breaks for them?

Thanks,

Mark

--=-w/WbHU13D5QYRofGaIU2
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/xeVNxVhZCJWr9QwRAlDqAJ9IasX2huvQ6c1ryr5RT8R++kZTrwCfd5fh
NLn/qZF6fU5BpWQCQN+Fr/Q=
=zPOW
-----END PGP SIGNATURE-----

--=-w/WbHU13D5QYRofGaIU2--




From MAILER-DAEMON Thu Nov 27 12:00:12 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APPUx-0000cW-8i
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 12:00:11 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APPUm-0000aH-2t
	for classpath@gnu.org; Thu, 27 Nov 2003 12:00:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APPUF-0000Nk-At
	for classpath@gnu.org; Thu, 27 Nov 2003 11:59:58 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APPUE-0000NU-JT
	for classpath@gnu.org; Thu, 27 Nov 2003 11:59:26 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APOWE-0007ak-00
	for <classpath@gnu.org>; Thu, 27 Nov 2003 16:57:26 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-cchXhAigEXKjv5m2LdDr"
Message-Id: <1069948677.27164.85.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 27 Nov 2003 16:57:57 +0100
Subject: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 17:00:03 -0000


--=-cchXhAigEXKjv5m2LdDr
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

[UPDATE: It appears I broke it :( I am trying to figure out what I did
wrong. Help wanted...]

Patrik Reali (of Joas fame) was so kind to update our webpages. He is
playing in the mountains at the moment (he will be back in two weeks).
So I committed them. All praise should go to Patrik, any screwups are my
fault. There are some nice macros to easily create new pages, the
attached README file explains how to do this (all files can be found in
doc/www.gnu.org in CVS). There is a new sidebar and a beginning of a
FAQ, but it is not linked yet and it is very empty at the moment. Please
take a look.

Since I didn't know how Patrik made the relative/absolute paths work in
the sidebar I added an explicit base statement to the layout.wml file:=20
<base href=3D"http://www.gnu.org/software/classpath/">
(This makes it hard to try out changes in a local directory, but I
didn't know a better way to make it work.)

I did also try to make sure the old names are linked to the new names by
updating the .symlinks file on the website. If you find anything not
working correctly anymore at http://www.gnu.org/software/classpath/
please let the list know.

Cheers,

Mark

--=-cchXhAigEXKjv5m2LdDr
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/xh8FxVhZCJWr9QwRAvTIAKCNIECeVgUd090joAsLYbtPMct/1wCfU+Gy
SWaHBR5v/hLx6KNSQC3oosM=
=LHWP
-----END PGP SIGNATURE-----

--=-cchXhAigEXKjv5m2LdDr--




From MAILER-DAEMON Thu Nov 27 12:03:45 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APPYO-0001hO-RB
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 12:03:44 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APPYL-0001fj-4s
	for classpath@gnu.org; Thu, 27 Nov 2003 12:03:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APPXm-0001Uo-7u
	for classpath@gnu.org; Thu, 27 Nov 2003 12:03:37 -0500
Received: from [210.230.164.2] (helo=mail.jsdi.or.jp)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APPXl-0001Sp-1k
	for classpath@gnu.org; Thu, 27 Nov 2003 12:03:05 -0500
Received: from dl.maczuka.gcd.org (d080.hi.jsdi.or.jp [210.230.165.80])
	by mail.jsdi.or.jp (8.11.6p2/8.11.6) with SMTP id hARG1Sp28083
	for <classpath@gnu.org>; Fri, 28 Nov 2003 01:01:29 +0900 (JST)
Received: (qmail 266 invoked by uid 0); 27 Nov 2003 16:01:27 -0000
Received: from ph.maczuka.gcd.org (HELO maczuka.gcd.org) (192.168.0.1)
	by dl.maczuka.gcd.org with SMTP; 27 Nov 2003 16:01:27 -0000
Received: (qmail 486 invoked by uid 1000); 27 Nov 2003 16:01:47 -0000
Message-ID: <20031127160147.485.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: classpath@gnu.org
In-reply-to: Your message of "Tue, 25 Nov 2003 21:15:22 +0100"
References: <1069431275.2861.580.camel@elsschot.wildebeest.org>
	<20031124225726.43635.qmail@maczuka.gcd.org>
	<1069791322.1303.41.camel@localhost>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Fri, 28 Nov 2003 01:01:46 +0900
Sender: kaz@maczuka.gcd.org
Cc: Mark Wielaard <mark@klomp.org>, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 17:03:42 -0000

Hi,

>>>>> ":" == Mark Wielaard <mark@klomp.org> writes:

:> Looked some more at the code and I see now that the the first change was
:> inside a if (time >= gregorianCutover) so it now makes more sense to me.
:> And the second change seems correct given the above remark.
:> I'll commit it in Classpath.

There is another difference between GNU Classpath's
java/util/GregorianCalendar.java and that of kaffe.

Kaffe's was imported from GNU Classpath and modified
in the kaffe world, as described by the following
ChangeLog entry.

2003-08-16  Guilhem Lavaux <guilhem@kaffe.org>

	* java/util/GregorianCalendar.java (computeTime):
	12:00 midnight is AM and 12:00 noon is PM.

Here is the patch that can be applied to Revision 1.21:

--- java/util/GregorianCalendar.java.orig	Thu Nov 27 15:35:08 2003
+++ java/util/GregorianCalendar.java	Thu Nov 27 15:48:25 2003
@@ -402,7 +402,11 @@
       {
 	hour = fields[HOUR];
         if (isSet[AM_PM] && fields[AM_PM] == PM)
-	  hour += 12;
+	  if (hour != 12) /* not Noon */
+            hour += 12;
+	/* Fix the problem of the status of 12:00 AM (midnight). */
+	if (isSet[AM_PM] && fields[AM_PM] == AM && hour == 12)
+	  hour = 0;
       }
 
     int minute = isSet[MINUTE] ? fields[MINUTE] : 0;

A mauve test attached. Since I have got a write access to the
mauve CVS registry,  I will add it to the registry.  The test
results shows that Sun's implementation also seems to have
something wrong.

Here is the output of the tests.

Kaffe + kaffe's GregorianCalendar
gnu.testlet.java.util.Calendar.ampm
----
PASS: gnu.testlet.java.util.Calendar.ampm (number 1)
PASS: gnu.testlet.java.util.Calendar.ampm (number 2)
PASS: gnu.testlet.java.util.Calendar.ampm (number 3)
PASS: gnu.testlet.java.util.Calendar.ampm (number 4)
PASS: gnu.testlet.java.util.Calendar.ampm (number 5)
PASS: gnu.testlet.java.util.Calendar.ampm (number 6)
PASS: gnu.testlet.java.util.Calendar.ampm (number 7)
PASS: gnu.testlet.java.util.Calendar.ampm (number 8)
PASS: gnu.testlet.java.util.Calendar.ampm (number 9)
PASS: gnu.testlet.java.util.Calendar.ampm (number 10)
PASS: gnu.testlet.java.util.Calendar.ampm (number 11)
PASS: gnu.testlet.java.util.Calendar.ampm (number 12)
PASS: gnu.testlet.java.util.Calendar.ampm (number 13)
PASS: gnu.testlet.java.util.Calendar.ampm (number 14)
PASS: gnu.testlet.java.util.Calendar.ampm (number 15)
PASS: gnu.testlet.java.util.Calendar.ampm (number 16)
0 of 16 tests failed

Kaffe + GNU Classpath's GregorianCalendar
gnu.testlet.java.util.Calendar.ampm
----
FAIL: gnu.testlet.java.util.Calendar.ampm (number 1)
got 12:00 PM but expected 12:00 AM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 2)
got 12:00 PM but expected 12:00 AM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 3)
got 12:10 PM but expected 12:10 AM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 4)
got 12:10 PM but expected 12:10 AM
PASS: gnu.testlet.java.util.Calendar.ampm (number 5)
PASS: gnu.testlet.java.util.Calendar.ampm (number 6)
PASS: gnu.testlet.java.util.Calendar.ampm (number 7)
PASS: gnu.testlet.java.util.Calendar.ampm (number 8)
FAIL: gnu.testlet.java.util.Calendar.ampm (number 9)
got 12:00 AM but expected 12:00 PM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 10)
got 12:00 AM but expected 12:00 PM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 11)
got 12:10 AM but expected 12:10 PM
FAIL: gnu.testlet.java.util.Calendar.ampm (number 12)
got 12:10 AM but expected 12:10 PM
PASS: gnu.testlet.java.util.Calendar.ampm (number 13)
PASS: gnu.testlet.java.util.Calendar.ampm (number 14)
PASS: gnu.testlet.java.util.Calendar.ampm (number 15)
PASS: gnu.testlet.java.util.Calendar.ampm (number 16)
8 of 16 tests failed

Sun's java version "1.4.2_02"
gnu.testlet.java.util.Calendar.ampm
----
FAIL: gnu.testlet.java.util.Calendar.ampm (number 1)
got 12:00 PM but expected 12:00 AM
PASS: gnu.testlet.java.util.Calendar.ampm (number 2)
FAIL: gnu.testlet.java.util.Calendar.ampm (number 3)
got 12:10 PM but expected 12:10 AM
PASS: gnu.testlet.java.util.Calendar.ampm (number 4)
PASS: gnu.testlet.java.util.Calendar.ampm (number 5)
PASS: gnu.testlet.java.util.Calendar.ampm (number 6)
PASS: gnu.testlet.java.util.Calendar.ampm (number 7)
PASS: gnu.testlet.java.util.Calendar.ampm (number 8)
FAIL: gnu.testlet.java.util.Calendar.ampm (number 9)
got 12:00 AM but expected 12:00 PM
PASS: gnu.testlet.java.util.Calendar.ampm (number 10)
FAIL: gnu.testlet.java.util.Calendar.ampm (number 11)
got 12:10 AM but expected 12:10 PM
PASS: gnu.testlet.java.util.Calendar.ampm (number 12)
PASS: gnu.testlet.java.util.Calendar.ampm (number 13)
PASS: gnu.testlet.java.util.Calendar.ampm (number 14)
PASS: gnu.testlet.java.util.Calendar.ampm (number 15)
PASS: gnu.testlet.java.util.Calendar.ampm (number 16)
4 of 16 tests failed

The Mauve test program:
// Tags: JDK1.1

// Copyright (c) 2003 Ito Kazumitsu

// This file is part of Mauve.

package gnu.testlet.java.util.Calendar;

import gnu.testlet.Testlet;
import gnu.testlet.TestHarness;
import java.text.*;
import java.util.*;

public class ampm implements Testlet
{
  private DateFormat format;
  private TestHarness harness;

  public void test (TestHarness harness)
  {
    // AM/PM mark is locale-dependent.  We use Locale.US.
    format = new SimpleDateFormat("hh:mm a", Locale.US);
    this.harness = harness;

    // According to the API document of java.util.Calendar,
    // midnight belongs to "am", and noon belongs to "pm".

    checkTime(12, 0, Calendar.AM, "12:00 AM");
    checkTime("12:00 AM", "12:00 AM");
    checkTime(12, 10, Calendar.AM, "12:10 AM");
    checkTime("12:10 AM", "12:10 AM");
    checkTime(0, 0, Calendar.AM, "12:00 AM");
    checkTime("0:00 AM", "12:00 AM");
    checkTime(0, 10, Calendar.AM, "12:10 AM");
    checkTime("0:10 AM", "12:10 AM");

    checkTime(12, 0, Calendar.PM, "12:00 PM");
    checkTime("12:00 PM", "12:00 PM");
    checkTime(12, 10, Calendar.PM, "12:10 PM");
    checkTime("12:10 PM", "12:10 PM");
    checkTime(0, 0, Calendar.PM, "12:00 PM");
    checkTime("0:00 PM", "12:00 PM");
    checkTime(0, 10, Calendar.PM, "12:10 PM");
    checkTime("0:10 PM", "12:10 PM");
  }

  private void checkTime(int hh, int mm, int ampm, String expect)
  {

    Calendar calendar = Calendar.getInstance();
    calendar = Calendar.getInstance();
    calendar.set(Calendar.HOUR, hh);
    calendar.set(Calendar.MINUTE, mm);
    calendar.set(Calendar.AM_PM, ampm);
    harness.check (format.format (calendar.getTime()), expect);
  }

  private void checkTime(String input, String expect)
  {

    Calendar calendar = Calendar.getInstance();
    try
      {
        calendar.setTime (format.parse(input));
        harness.check (format.format(calendar.getTime()), expect);
      }
    catch (ParseException _)
      {
        harness.debug (_);
        harness.fail (input + " couldn't be parsed");
      }

  }

}



From MAILER-DAEMON Thu Nov 27 12:08:33 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APPd1-0003SO-VC
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 12:08:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APPcv-0003Oc-P0
	for classpath@gnu.org; Thu, 27 Nov 2003 12:08:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APPcN-0003Gn-Vr
	for classpath@gnu.org; Thu, 27 Nov 2003 12:08:23 -0500
Received: from [210.230.164.2] (helo=mail.jsdi.or.jp)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APPcM-0003GG-R2
	for classpath@gnu.org; Thu, 27 Nov 2003 12:07:51 -0500
Received: from dl.maczuka.gcd.org (d080.hi.jsdi.or.jp [210.230.165.80])
	by mail.jsdi.or.jp (8.11.6p2/8.11.6) with SMTP id hARG6Np33223
	for <classpath@gnu.org>; Fri, 28 Nov 2003 01:06:23 +0900 (JST)
Received: (qmail 285 invoked by uid 0); 27 Nov 2003 16:06:22 -0000
Received: from ph.maczuka.gcd.org (HELO maczuka.gcd.org) (192.168.0.1)
	by dl.maczuka.gcd.org with SMTP; 27 Nov 2003 16:06:22 -0000
Received: (qmail 497 invoked by uid 1000); 27 Nov 2003 16:06:43 -0000
Message-ID: <20031127160643.496.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: classpath@gnu.org, kaffe@kaffe.org
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Fri, 28 Nov 2003 01:06:43 +0900
Sender: kaz@maczuka.gcd.org
Cc: 
Subject: java/text/SimpleDateFormat.java (compileFormat)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 17:08:30 -0000

Hi,

Browsing GNU Classpath's CVS log, I found:

2003-10-02  Michael Koch  <konqueror@gmx.de>

        * java/text/SimpleDateFormat.java
        (compileFormat): Character.isLetter(char) allows too much characters.
        Replace it with Character.isLowerCase(char) ||
        Character.isUpperCase(char).

I think this change has something to do with the bug report:
http://www.kaffe.org/pipermail/kaffe/2003-August/043742.html
http://www.kaffe.org/pipermail/kaffe/2003-August/043743.html,

where I suggested to use

   (thisChar >= 'A' && thisChar <= 'Z') || (thisChar >= 'a' && thisChar <= 'z')

instead of

   Character.isLetter(thisChar)

Why do we use "Character.isLowerCase(char) || Character.isUpperCase(char)"
when the API doc clearly says, "Within date and time pattern strings,
unquoted letters from 'A' to 'Z' and from 'a' to 'z' are interpreted
as pattern letters representing the components of a date or time string"?

I am afraid "Character.isLowerCase(char) || Character.isUpperCase(char)"
also allows too many characters,  including Greek or Slavic alphabet
or even Japanese Zenkaku alphabet.



From MAILER-DAEMON Thu Nov 27 12:14:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APPic-0000aM-QA
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 12:14:18 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APPiZ-0000X6-Gg
	for classpath@gnu.org; Thu, 27 Nov 2003 12:14:15 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APPi3-0000Fx-NO
	for classpath@gnu.org; Thu, 27 Nov 2003 12:14:14 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APPi3-0000Fu-Aw
	for classpath@gnu.org; Thu, 27 Nov 2003 12:13:43 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APOk6-0007hU-00
	for <classpath@gnu.org>; Thu, 27 Nov 2003 17:11:46 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <1069948677.27164.85.camel@elsschot.wildebeest.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-EuLUOxxs/tocZNpnADis"
Message-Id: <1069949537.27158.94.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 27 Nov 2003 17:12:17 +0100
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 17:14:17 -0000


--=-EuLUOxxs/tocZNpnADis
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-27 at 16:57, Mark Wielaard wrote:
> [UPDATE: It appears I broke it :( I am trying to figure out what I did
> wrong. Help wanted...]

Somehow this fixed itself. Strange. I have been banging my head against
a wall for an hour and apparently some cron job then kicked in and
auto-fixed the symlinks or something...

Anyway. Please check out Patrik his work:
http://www.gnu.org/software/classpath/

Cheers,

Mark

--=-EuLUOxxs/tocZNpnADis
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/xiJgxVhZCJWr9QwRAsDJAJ0U0pHAnpuvXkzIxBjU2ybC0lEW9QCghpEK
Trw9+Uqvbqyicn+TjbFvmsU=
=e4WU
-----END PGP SIGNATURE-----

--=-EuLUOxxs/tocZNpnADis--




From MAILER-DAEMON Thu Nov 27 12:17:20 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APPlX-0003EO-J2
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 12:17:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APPlN-00039F-Al
	for classpath@gnu.org; Thu, 27 Nov 2003 12:17:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APPkm-0002MQ-A2
	for classpath@gnu.org; Thu, 27 Nov 2003 12:17:03 -0500
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APPkk-0002It-KB
	for classpath@gnu.org; Thu, 27 Nov 2003 12:16:30 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-73-096.ewetel.net
	[80.228.73.96])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id hARGDvIw009463;
	Thu, 27 Nov 2003 17:14:01 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1APOmu-0001jg-00; Thu, 27 Nov 2003 17:14:40 +0100
Date: Thu, 27 Nov 2003 17:14:40 +0100
From: Michael Koch <konqueror@gmx.de>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>
Message-ID: <20031127161440.GA1604@mail.konqueror.de>
References: <20031127160643.496.qmail@maczuka.gcd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031127160643.496.qmail@maczuka.gcd.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: classpath@gnu.org, kaffe@kaffe.org
Subject: Re: java/text/SimpleDateFormat.java (compileFormat)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 17:17:12 -0000

On Fri, Nov 28, 2003 at 01:06:43AM +0900, Ito Kazumitsu wrote:
> Hi,
> 
> Browsing GNU Classpath's CVS log, I found:
> 
> 2003-10-02  Michael Koch  <konqueror@gmx.de>
> 
>         * java/text/SimpleDateFormat.java
>         (compileFormat): Character.isLetter(char) allows too much characters.
>         Replace it with Character.isLowerCase(char) ||
>         Character.isUpperCase(char).
> 
> I think this change has something to do with the bug report:
> http://www.kaffe.org/pipermail/kaffe/2003-August/043742.html
> http://www.kaffe.org/pipermail/kaffe/2003-August/043743.html,
> 
> where I suggested to use
> 
>    (thisChar >= 'A' && thisChar <= 'Z') || (thisChar >= 'a' && thisChar <= 'z')
> 
> instead of
> 
>    Character.isLetter(thisChar)
> 
> Why do we use "Character.isLowerCase(char) || Character.isUpperCase(char)"
> when the API doc clearly says, "Within date and time pattern strings,
> unquoted letters from 'A' to 'Z' and from 'a' to 'z' are interpreted
> as pattern letters representing the components of a date or time string"?
> 
> I am afraid "Character.isLowerCase(char) || Character.isUpperCase(char)"
> also allows too many characters,  including Greek or Slavic alphabet
> or even Japanese Zenkaku alphabet.


Grrr! I thought its the same. All I found int the docs indicated this.
Can you please commit/provide a patch that fixes this ?


Michael



From MAILER-DAEMON Thu Nov 27 16:54:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APU5I-0002PX-Pp
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 16:54:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APU58-0002Hc-4C
	for classpath@gnu.org; Thu, 27 Nov 2003 16:53:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APU4S-00020t-Lw
	for classpath@gnu.org; Thu, 27 Nov 2003 16:53:39 -0500
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APU4S-00020j-2Y
	for classpath@gnu.org; Thu, 27 Nov 2003 16:53:08 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-2.free.fr (Postfix) with ESMTP id 70D2ED794
	for <classpath@gnu.org>; Thu, 27 Nov 2003 21:51:37 +0100 (CET)
Message-ID: <3FC663CF.50600@kaffe.org>
Date: Thu, 27 Nov 2003 21:51:27 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------070104040402020406080808"
Subject: [PATCH] Serialization #4
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 21:53:53 -0000

This is a multi-part message in MIME format.
--------------070104040402020406080808
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is a new part of the patch for serialization. It is mainly about 
restructuring the class lookup logic. It appeared that you need to build 
a class lookup table and a class hierarchy for a given input stream. 
Without that, if you write something with ObjectOutputStream and then 
read something else the previous code was using the already built class 
hierarchy to decode this new stream. The solution was obviously to build 
a full lookup table for each instance of ObjectInputStream. At the same 
time, ObjectStreamClass continue to manage the "real" class hierarchy 
(i.e. the one that exists in the VM at the running time).

This patch also contains an internal API change for 
ObjectStreamClass.setClass and some (extensive) addings to this method. 
setClass now also builds a consistent array of the accepted fields for 
the input stream:
* first we take all non transient, non static fields.

* then if there are the explicitly exported fields (using 
"serialPersistentFields" or by detecting the available fields)
* if the previous case was executed then the other "exportable" fields 
are implicitly imported but not exported .
These states will be used in a next patch.

getSerialPersistentFields has been simplified because exceptions should 
be caught in the calling method so they can be handled correctly by 
setClass.
getSerialPersistentFields will be updated to its true version in a next 
patch.

I'm sorry if this patch is too big but changing but this is mainly due 
to the change in the class lookup logic.

Cheers,
Guilhem.

P.S.: Modifications concerning ObjectOutputStream will follow after all 
modifications about ObjectInputStream.

ChangeLog entry:

2003-11-27  Guilhem Lavaux <guilhem@kaffe.org>

	* java/io/ObjectInputStream.java:
	(lookupClass): New method.
	(currentLoader): New method.
	(inputGetObjectStreamClasses): New method.
	(assignNewHandle): Documented.
	(currentClassLoader): Documented.

	* java/io/ObjectStreamClass.java:
	(setClass) Changed API. Better handling of the imported/exported fields.
	(getSerialPersistentFields) Make it throw previously caught exceptions so
	they can handled in setClass.


--------------070104040402020406080808
Content-Type: text/plain;
 name="patch_no_4"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch_no_4"

--- /home/guilhem/ext2/PROJECTS/classpath-public/java/io/ObjectInputStream.java	2003-11-26 21:59:05.000000000 +0100
+++ java/io/ObjectInputStream.java	2003-11-27 21:25:06.000000000 +0100
@@ -99,10 +99,11 @@
     this.blockDataInput = new DataInputStream (this);
     this.realInputStream = new DataInputStream (in);
     this.nextOID = baseWireHandle;
-    this.objectLookupTable = new Hashtable ();
-    this.validators = new Vector ();
+    this.objectLookupTable = new Hashtable();
+    this.validators = new Vector();
+    this.classLookupTable = new Hashtable();
     setBlockDataMode (true);
-    readStreamHeader ();
+    readStreamHeader();
   }
 
 
@@ -203,7 +204,7 @@
 	      Class cl = resolveProxyClass(intfs);
 	      setBlockDataMode(oldmode);
 	      
-	      ObjectStreamClass osc = ObjectStreamClass.lookup(cl);
+	      ObjectStreamClass osc = lookupClass (cl);
 	      assignNewHandle (osc);
 	      
 	      if (!is_consumed)
@@ -332,7 +333,7 @@
 	      int handle = assignNewHandle (obj);
 	      this.currentObject = obj;
 	      ObjectStreamClass[] hierarchy =
-		ObjectStreamClass.getObjectStreamClasses (clazz);
+		inputGetObjectStreamClasses (clazz);
 	      
 	      for (int i=0; i < hierarchy.length; i++)
 		{
@@ -455,8 +456,10 @@
 	  new ObjectStreamField (field_name, class_name);
       }
 	      
+    Class clazz = resolveClass (osc);
     boolean oldmode = setBlockDataMode (true);
-    osc.setClass (resolveClass (osc));
+    osc.setClass (clazz, lookupClass (clazz.getSuperclass()));
+    classLookupTable.put (clazz, osc);
     setBlockDataMode (oldmode);
 	      
     return osc;
@@ -550,16 +553,78 @@
   protected Class resolveClass (ObjectStreamClass osc)
     throws ClassNotFoundException, IOException
   {
+    return Class.forName (osc.getName(), true, currentLoader()); 
+  }
+  
+  private ClassLoader currentLoader ()
+  {
     SecurityManager sm = System.getSecurityManager ();
     if (sm == null)
       sm = new SecurityManager () {};
+ 
+    return currentClassLoader (sm);
+  }
 
-    ClassLoader cl = currentClassLoader (sm);
+  /**
+   * Lookup a class stored in the local hashtable. If it is not
+   * use the global lookup function in ObjectStreamClass to build
+   * the ObjectStreamClass. This method is requested according to
+   * the behaviour detected in the JDK by Kaffe's team.
+   *
+   * @param clazz Class to lookup in the hash table or for which
+   * we must build a descriptor. 
+   * @return A valid instance of ObjectStreamClass corresponding
+   * to the specified class.
+   */
+  private ObjectStreamClass lookupClass (Class clazz)
+  {
+    ObjectStreamClass oclazz;
+    
+    oclazz = (ObjectStreamClass) classLookupTable.get(clazz);
+    if (oclazz == null)
+      return ObjectStreamClass.lookup (clazz);
+    else
+      return oclazz;
+  }
+
+  /**
+   * Reconstruct class hierarchy the same way
+   * {@link java.io.ObjectStreamClass.getObjectStreamClasses(java.lang.Class)} does
+   * but using lookupClass instead of ObjectStreamClass.lookup. This
+   * dup is necessary localize the lookup table. Hopefully some future rewritings will
+   * be able to prevent this.
+   *
+   * @param clazz This is the class for which we want the hierarchy.
+   *
+   * @return An array of valid {@link java.io.ObjectStreamClass} instances which
+   * represent the class hierarchy for clazz.
+   */
+  private ObjectStreamClass[] inputGetObjectStreamClasses (Class clazz)
+  {
+    ObjectStreamClass osc = lookupClass (clazz);
+
+    ObjectStreamClass[] ret_val;
 
-    if (cl == null)
-      return Class.forName (osc.getName ());
+    if (osc == null)
+      return new ObjectStreamClass[0];
     else
-      return cl.loadClass (osc.getName ());
+    {
+      Vector oscs = new Vector ();
+
+      while (osc != null)
+      {
+	oscs.addElement (osc);
+	osc = osc.getSuper ();
+      }
+
+      int count = oscs.size ();
+      ObjectStreamClass[] sorted_oscs = new ObjectStreamClass[ count ];
+
+      for (int i = count - 1; i >= 0; i--)
+	sorted_oscs[ count - i - 1 ] = (ObjectStreamClass)oscs.elementAt (i);
+
+      return sorted_oscs;
+    }
   }
 
   /**
@@ -1148,7 +1213,12 @@
     throw new IOException ("Subclass of ObjectInputStream must implement readObjectOverride");
   }
 
-  // assigns the next availible handle to OBJ
+  /**
+   * Assigns the next available handle to <code>obj</code>.
+   *
+   * @param obj The object for which we want a new handle.
+   * @return A valid handle for the specified object.
+   */
   private int assignNewHandle (Object obj)
   {
     this.objectLookupTable.put (new Integer (this.nextOID),
@@ -1300,7 +1370,7 @@
   {
     ObjectStreamField[] stream_fields = stream_osc.fields;
     ObjectStreamField[] real_fields =
-      ObjectStreamClass.lookup (stream_osc.forClass ()).fields;
+      lookupClass (stream_osc.forClass ()).fields;
 
     boolean default_initialize, set_value;
     String field_name = null;
@@ -1493,14 +1563,20 @@
       }
   }
 
-  // this native method is used to get access to the protected method
-  // of the same name in SecurityManger
+  /**
+   * This native method is used to get access to the protected method
+   * of the same name in SecurityManger.
+   *
+   * @param sm SecurityManager instance which should be called.
+   * @return The current class loader in the calling stack.
+   */
   private static native ClassLoader currentClassLoader (SecurityManager sm);
 
   private static Field getField (Class klass, String name)
     throws java.lang.NoSuchFieldException
   {
     final Field f = klass.getDeclaredField(name);
+    
     AccessController.doPrivileged(new PrivilegedAction()
       {
 	public Object run()
@@ -1744,6 +1820,7 @@
   private boolean isDeserializing;
   private boolean fieldsAlreadyRead;
   private Vector validators;
+  private Hashtable classLookupTable;
 
   private static boolean dump;
 
--- /home/guilhem/ext2/PROJECTS/classpath-public/java/io/ObjectStreamClass.java	2003-11-26 21:58:23.000000000 +0100
+++ java/io/ObjectStreamClass.java	2003-11-26 21:46:43.000000000 +0100
@@ -291,7 +291,18 @@
     this.fields = fields;
   }
 
-  void setClass (Class cl) throws InvalidClassException
+  /**
+   * This method builds the internal description corresponding to a Java Class.
+   * As the constructor only assign a name to the current ObjectStreamClass instance,
+   * that method sets the serial UID, chose the fields which will be serialized,
+   * and compute the position of the fields in the serialized stream.
+   *
+   * @param cl The Java class which is used as a reference for building the descriptor.
+   * @param superClass The descriptor of the super class for this class descriptor.
+   * @throws InvalidClassException if an incompatibility between computed UID and
+   * already set UID is found.
+   */
+  void setClass (Class cl, ObjectStreamClass superClass) throws InvalidClassException
   {
     this.clazz = cl;
 
@@ -312,11 +323,89 @@
       }
 
     isProxyClass = clazz != null && Proxy.isProxyClass (clazz);
-    ObjectStreamClass osc = (ObjectStreamClass)classLookupTable.get (clazz);
-    if (osc == null)
-      classLookupTable.put (clazz, this);
-    superClass = lookupForClassObject (clazz.getSuperclass ());
+    this.superClass = superClass;
     calculateOffsets ();
+    
+    try
+      {
+	ObjectStreamField[] exportedFields = getSerialPersistentFields (clazz);  
+
+	if (exportedFields == null)
+	  return;
+
+	ObjectStreamField[] newFieldList = new ObjectStreamField[exportedFields.length + fields.length];
+	int i, j, k;
+
+	/* We now check the import fields against the exported fields.
+	 * There should not be contradiction (e.g. int x and String x)
+	 * but extra virtual fields can be added to the class.
+	 */
+
+	Arrays.sort(exportedFields);
+
+	i = 0; j = 0; k = 0;
+	while (i < fields.length && j < exportedFields.length)
+	{
+	  int comp = fields[i].getName().compareTo (exportedFields[j].getName());
+
+	  if (comp < 0)
+	    {
+	      newFieldList[k] = fields[i];
+	      fields[i].setPersistent(false);
+	      fields[i].setToSet(false);
+	      i++;
+	    }
+	  else if (comp > 0)
+	    {
+	      /* field not found in imported fields. We add it
+	       * in the list of supported fields.
+	       */
+	      newFieldList[k] = exportedFields[j];
+	      newFieldList[k].setPersistent(true);
+	      newFieldList[k].setToSet(false);
+	      j++;
+	    }
+	  else
+	    {
+	      if (!fields[i].getType().equals (exportedFields[j].getType()))
+		throw new InvalidClassException (
+			    "serialPersistentFields must be compatible with" +
+			    " imported fields (about " + fields[i].getName() + ")");
+	      newFieldList[k] = fields[i];
+	      fields[i].setPersistent(true);
+	      i++;
+	      j++;
+	    }
+	  k++;
+	}
+
+	if (i < fields.length)
+	  for (;i<fields.length;i++,k++)
+	  {
+	    fields[i].setPersistent(false);
+	    fields[i].setToSet(false);
+	    newFieldList[k] = fields[i];
+	  }
+	else
+	  if (j < exportedFields.length)
+	    for (;j<exportedFields.length;j++,k++)
+	      {
+		exportedFields[j].setPersistent(true);
+		exportedFields[j].setToSet(false);
+		newFieldList[k] = exportedFields[j];
+	      }
+	
+	fields = new ObjectStreamField[k];
+	System.arraycopy (newFieldList, 0, fields, 0, k);
+      }
+    catch (NoSuchFieldException ignore)
+      {
+	return;
+      }
+    catch (IllegalAccessException ignore)
+      {
+	return;
+      }
   }
 
   void setSuperclass (ObjectStreamClass osc)
@@ -435,7 +524,9 @@
       }
     }
     catch (NoSuchFieldException ignore)
-    {}
+      {}
+    catch (IllegalAccessException ignore)
+      {}
 
     int num_good_fields = 0;
     Field[] all_fields = cl.getDeclaredFields ();
@@ -612,25 +703,16 @@
 
   // Returns the value of CLAZZ's private static final field named
   // `serialPersistentFields'.
-  private ObjectStreamField[] getSerialPersistentFields (Class clazz)
+  private ObjectStreamField[] getSerialPersistentFields (Class clazz) 
+    throws NoSuchFieldException, IllegalAccessException
   {
     ObjectStreamField[] o = null;
-    try
-      {
-	// Use getDeclaredField rather than getField for the same reason
-	// as above in getDefinedSUID.
-	Field f = clazz.getDeclaredField ("serialPersistentFields");
-	f.setAccessible(true);
-	o = (ObjectStreamField[])f.get (null);
-      }
-    catch (java.lang.NoSuchFieldException e)
-      {
-      }
-    catch (java.lang.IllegalAccessException e)
-      {
-      }
 
-    return o;
+    // Use getDeclaredField rather than getField for the same reason
+    // as above in getDefinedSUID.
+    Field f = clazz.getDeclaredField ("serialPersistentFields");
+    f.setAccessible(true);
+    return (ObjectStreamField[])f.get (null);
   }
 
   public static final ObjectStreamField[] NO_FIELDS = {};

--------------070104040402020406080808--




From MAILER-DAEMON Thu Nov 27 17:10:39 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APULO-0001z3-Vx
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 17:10:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APULN-0001ys-33
	for classpath@gnu.org; Thu, 27 Nov 2003 17:10:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APUKq-0001Pb-5v
	for classpath@gnu.org; Thu, 27 Nov 2003 17:10:36 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APUKp-0001No-HE
	for classpath@gnu.org; Thu, 27 Nov 2003 17:10:03 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APTMs-0008FQ-00
	for <classpath@gnu.org>; Thu, 27 Nov 2003 22:08:06 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <1069949537.27158.94.camel@elsschot.wildebeest.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<1069949537.27158.94.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-j4XS287pvX7aGlLwtB6Q"
Message-Id: <1069967317.27170.163.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 27 Nov 2003 22:08:37 +0100
Subject: Re: New homepage (and new savannah)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 22:10:37 -0000


--=-j4XS287pvX7aGlLwtB6Q
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-27 at 17:12, Mark Wielaard wrote:
> Anyway. Please check out Patrik his work:
> http://www.gnu.org/software/classpath/

BTW. Savannah was also recently upgraded.
You might want to take a look at
http://savannah.gnu.org/

An overview of the user interface changes can be found in this news
item: http://savannah.gnu.org/forum/forum.php?forum_id=3D2715

Cheers,

Mark

--=-j4XS287pvX7aGlLwtB6Q
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/xmfVxVhZCJWr9QwRAitZAKCC6LJXalaUNBETehnByT4BpdxfpgCdGX/3
VVacuG+DYP9uYAThIrJJ65I=
=Bg9U
-----END PGP SIGNATURE-----

--=-j4XS287pvX7aGlLwtB6Q--




From MAILER-DAEMON Thu Nov 27 18:26:51 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APVX8-0001IU-VO
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 18:26:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APVX6-0001GA-P2
	for classpath@gnu.org; Thu, 27 Nov 2003 18:26:48 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APVWZ-0000su-EI
	for classpath@gnu.org; Thu, 27 Nov 2003 18:26:47 -0500
Received: from [210.230.164.2] (helo=mail.jsdi.or.jp)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APVWY-0000rC-6H
	for classpath@gnu.org; Thu, 27 Nov 2003 18:26:14 -0500
Received: from dl.maczuka.gcd.org (d067.hi.jsdi.or.jp [210.230.165.67])
	by mail.jsdi.or.jp (8.11.6p2/8.11.6) with SMTP id hARMOip24920
	for <classpath@gnu.org>; Fri, 28 Nov 2003 07:24:44 +0900 (JST)
Received: (qmail 2049 invoked by uid 0); 27 Nov 2003 22:24:42 -0000
Received: from ph.maczuka.gcd.org (HELO maczuka.gcd.org) (192.168.0.1)
	by dl.maczuka.gcd.org with SMTP; 27 Nov 2003 22:24:42 -0000
Received: (qmail 1837 invoked by uid 1000); 27 Nov 2003 22:25:02 -0000
Message-ID: <20031127222502.1836.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: Michael Koch <konqueror@gmx.de>
In-reply-to: Your message of "Thu, 27 Nov 2003 17:14:40 +0100"
References: <20031127160643.496.qmail@maczuka.gcd.org>
	<20031127161440.GA1604@mail.konqueror.de>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Fri, 28 Nov 2003 07:25:02 +0900
Sender: kaz@maczuka.gcd.org
Cc: classpath@gnu.org, kaffe@kaffe.org
Subject: Re: java/text/SimpleDateFormat.java (compileFormat)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2003 23:26:49 -0000

Hi,

>>>>> ":" == Michael Koch <konqueror@gmx.de> writes:

>> I am afraid "Character.isLowerCase(char) || Character.isUpperCase(char)"
>> also allows too many characters,  including Greek or Slavic alphabet
>> or even Japanese Zenkaku alphabet.

:> Grrr! I thought its the same. All I found int the docs indicated this.
:> Can you please commit/provide a patch that fixes this ?

The API document of java.lang.Character says:

    The following are examples of lowercase characters:
   
         a b c d e f g h i j k l m n o p q r s t u v w x y z
         '\u00DF' '\u00E0' '\u00E1' '\u00E2' '\u00E3' '\u00E4' '\u00E5' '\u00E6'
         '\u00E7' '\u00E8' '\u00E9' '\u00EA' '\u00EB' '\u00EC' '\u00ED' '\u00EE'
         '\u00EF' '\u00F0' '\u00F1' '\u00F2' '\u00F3' '\u00F4' '\u00F5' '\u00F6'
         '\u00F8' '\u00F9' '\u00FA' '\u00FB' '\u00FC' '\u00FD' '\u00FE' '\u00FF'
         
    Many other Unicode characters are lowercase too.

I do not know of a smart way of describing characters between 'A' and 'Z'
and 'a' and 'z',  so my patch is:

--- java/text/SimpleDateFormat.java.orig	Mon Nov 24 23:59:09 2003
+++ java/text/SimpleDateFormat.java	Fri Nov 28 07:05:10 2003
@@ -117,8 +117,8 @@
       field = formatData.getLocalPatternChars().indexOf(thisChar);
       if (field == -1) {
 	current = null;
-	if (Character.isLowerCase (thisChar)
-	    || Character.isUpperCase (thisChar)) {
+	if ((thisChar >= 'A' && thisChar <= 'Z')
+	    || (thisChar >= 'a' && thisChar <= 'z')) {
 	  // Not a valid letter
 	  tokens.add(new FieldSizePair(-1,0));
 	} else if (thisChar == '\'') {

ChangeLog entry:

2003-11-28  Ito Kazumitsu  <kaz@maczuka.gcd.org>

	* java/text/SimpleDateFormat.java (compileFormat): 
	isLowerCase and isUpperCase allow too many characters.
	Just use >= 'A' && <= 'Z' || >= 'a' && <= 'z'.




From MAILER-DAEMON Thu Nov 27 21:05:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APY0b-00085t-H0
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 21:05:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APY0Z-00085n-H8
	for classpath@gnu.org; Thu, 27 Nov 2003 21:05:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APY03-0007oT-Ox
	for classpath@gnu.org; Thu, 27 Nov 2003 21:05:22 -0500
Received: from [130.102.176.1] (helo=piglet.dstc.edu.au)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APY02-0007gv-TE
	for classpath@gnu.org; Thu, 27 Nov 2003 21:04:51 -0500
Received: from dstc.edu.au (credence.dstc.edu.au [130.102.177.137])
	by piglet.dstc.edu.au (8.12.10/8.12.10) with ESMTP id hAS12oYd014201;
	Fri, 28 Nov 2003 11:02:51 +1000 (EST)
Message-Id: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
X-Mailer: exmh version 2.6.1 02/18/2003 with nmh-1.0.4
To: Ito Kazumitsu <kaz@maczuka.gcd.org>
In-Reply-To: Message from Ito Kazumitsu <kaz@maczuka.gcd.org> of "Fri,
	28 Nov 2003 01:01:46 +0900." <20031127160147.485.qmail@maczuka.gcd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 28 Nov 2003 11:03:16 +1000
From: Stephen Crawley <crawley@dstc.edu.au>
X-Scanned-By: MIMEDefang 2.38
Cc: crawley@piglet.dstc.edu.au, Mark Wielaard <mark@klomp.org>,
	classpath@gnu.org, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes 
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 02:05:24 -0000


kaz@maczuka.gcd.org said:
> A mauve test attached. Since I have got a write access to the mauve
> CVS registry,  I will add it to the registry.  The test results shows
> that Sun's implementation also seems to have something wrong. 

If Sun's implementation (you don't say which JDK version!) is failing
a test, then that casts serious doubt on the correctness of the mauve
testcase itself!

The over-arching principle for Mauve testcases is that the behavior of
Sun's Java implementations is the "gold standard" for conformance
testing.  Even if the Sun Java behavior contradicts the javadocs, or
is "just plain wrong", it is still technically "correct behavior" from
the POV of conformance.

[Sun sometimes acknowledges JDK bugs, but then says they won't fix them. 
because of the risk of breaking existing customer code.  In such cases,
other Java implementations need to be bug-for-bug compatible in order
to minimize cross-platform portability problems for developers and
end-users.]

-- Steve




From MAILER-DAEMON Thu Nov 27 21:58:49 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APYqH-00082m-7D
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 21:58:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APYqE-000829-Ja
	for classpath@gnu.org; Thu, 27 Nov 2003 21:58:46 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APYph-000800-39
	for classpath@gnu.org; Thu, 27 Nov 2003 21:58:44 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APYpg-0007zv-O8
	for classpath@gnu.org; Thu, 27 Nov 2003 21:58:12 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APXrO-0000II-00; Fri, 28 Nov 2003 02:55:54 +0100
From: Mark Wielaard <mark@klomp.org>
To: Stephen Crawley <crawley@dstc.edu.au>
In-Reply-To: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
References: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-sFCQ3k/HxRUGNrD7wO3x"
Message-Id: <1069984585.27161.200.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 28 Nov 2003 02:56:26 +0100
Cc: crawley@piglet.dstc.edu.au, classpath@gnu.org, java-patches@gcc.gnu.org,
	kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 02:58:47 -0000


--=-sFCQ3k/HxRUGNrD7wO3x
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-28 at 02:03, Stephen Crawley wrote:
> The over-arching principle for Mauve testcases is that the behavior of
> Sun's Java implementations is the "gold standard" for conformance
> testing.

I don't agree. We should not create Mauve tests to validate some
proprietary library implementation.

Mark

--=-sFCQ3k/HxRUGNrD7wO3x
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/xqtJxVhZCJWr9QwRAgYTAJoCzm6L0ULh776wikNeCvFB8Nb69QCeNvse
fZDoID/PoiCRpTSIhpZuRhA=
=3w3X
-----END PGP SIGNATURE-----

--=-sFCQ3k/HxRUGNrD7wO3x--




From MAILER-DAEMON Thu Nov 27 23:41:52 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APaRz-0000Md-IV
	for mharc-classpath@gnu.org; Thu, 27 Nov 2003 23:41:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APaRs-0000H4-5h
	for classpath@gnu.org; Thu, 27 Nov 2003 23:41:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APaR0-0007D8-Qn
	for classpath@gnu.org; Thu, 27 Nov 2003 23:41:21 -0500
Received: from [130.102.176.1] (helo=piglet.dstc.edu.au)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APaQz-0007AL-Uz
	for classpath@gnu.org; Thu, 27 Nov 2003 23:40:50 -0500
Received: from dstc.edu.au (credence.dstc.edu.au [130.102.177.137])
	by piglet.dstc.edu.au (8.12.10/8.12.10) with ESMTP id hAS3cqYd024381;
	Fri, 28 Nov 2003 13:38:53 +1000 (EST)
Message-Id: <200311280338.hAS3cqYd024381@piglet.dstc.edu.au>
X-Mailer: exmh version 2.6.1 02/18/2003 with nmh-1.0.4
To: Mark Wielaard <mark@klomp.org>
In-Reply-To: Message from Mark Wielaard <mark@klomp.org> of "Fri,
	28 Nov 2003 02:56:26 +0100."
	<1069984585.27161.200.camel@elsschot.wildebeest.org> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 28 Nov 2003 13:39:18 +1000
From: Stephen Crawley <crawley@dstc.edu.au>
X-Scanned-By: MIMEDefang 2.38
Cc: Stephen Crawley <crawley@dstc.edu.au>, crawley@piglet.dstc.edu.au,
	classpath@gnu.org, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes 
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 04:41:46 -0000


Mark Wielaard <mark@klomp.org> wrote:
> On Fri, 2003-11-28 at 02:03, Stephen Crawley wrote:
> > The over-arching principle for Mauve testcases is that the behavior of
> > Sun's Java implementations is the "gold standard" for conformance
> > testing.
> 
> I don't agree. We should not create Mauve tests to validate some
> proprietary library implementation.
> 
> Mark

I don't understand what you are saying here.  We are not building Mauve
tests in order to validate Sun's implementation.  Rather, we are
building it to check that other implementations (including Classpath)
conform to the accepted specification for Java.  The ultimate
specification for Java is (according to Sun) the behaviour of Sun's
reference implementations.

Are you suggesting that there is a more appropriate or more definitive
specification of Java?  If so, what is it, and why is it more
appropriate or definitive?  

-- Steve











From MAILER-DAEMON Fri Nov 28 01:55:23 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APcXC-00016g-UL
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 01:55:22 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APcX7-0000v6-Lt
	for classpath@gnu.org; Fri, 28 Nov 2003 01:55:17 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APcWb-00007b-DO
	for classpath@gnu.org; Fri, 28 Nov 2003 01:55:16 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APcWa-00006D-DS
	for classpath@gnu.org; Fri, 28 Nov 2003 01:54:44 -0500
Received: from anis.telecom.uqam.ca (anis.telecom.uqam.ca [132.208.250.6])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id hAS5mPhx010728
	for <classpath@gnu.org>; Fri, 28 Nov 2003 00:49:16 -0500 (EST)
Received: from antivirus.uqam.ca ([127.0.0.1])
	by anis.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2003112800491625439
	for <classpath@gnu.org>; Fri, 28 Nov 2003 00:49:16 -0500
Received: from localhost (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	hAS5lfAO008506; Fri, 28 Nov 2003 00:47:41 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by localhost with esmtp (Exim 3.36 #1 (Debian))
	id 1APbTi-0000Qb-00; Fri, 28 Nov 2003 00:47:42 -0500
Message-ID: <3FC6E17D.9040900@uqam.ca>
Date: Fri, 28 Nov 2003 00:47:41 -0500
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.5) Gecko/20031110 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: classpath@gnu.org
References: <20031125021112.GB28272@pinto.cs.mcgill.ca>
In-Reply-To: <20031125021112.GB28272@pinto.cs.mcgill.ca>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Cc: 
Subject: Re: java_io_File.c deletelocalref and cl in ObjectInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 06:55:20 -0000

David B=E9langer wrote:
> I think Etienne did these two changes, I'm not sure.  Maybe Etienne
> could answer your questions on these.
>=20
> java_io_File.c: Basically, it frees a local ref, I guess otherwise it m=
ay
> run out of local refs for a long directory listing.

        (*env)->SetObjectArrayElement(env, filearray, i, str);
+      (*env)->DeleteLocalRef (env, str);

Yes.  This was a bug in Classpath.  One needs to free native locals, as t=
hey
consume memory.  A virtual machine only garantees the availability of 16 =
local
refs, by default (JNI Spec).  To get more, one must do the appropriate JN=
I
calls.

> ObjectInputStream.java: I don't understand ClassLoader enough to explai=
n this
> one.

-      return cl.loadClass (osc.getName ());
+      return Class.forName (osc.getName (), false, cl);

The idea is that "initialization" should NOT be triggered.  cl.loadClass =
will
initialize the class; this is why we should use Class.forName.

Etienne
--=20
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/




From MAILER-DAEMON Fri Nov 28 04:13:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APegw-0006Ww-IY
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 04:13:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APegt-0006UX-As
	for classpath@gnu.org; Fri, 28 Nov 2003 04:13:31 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APegC-0006IK-BO
	for classpath@gnu.org; Fri, 28 Nov 2003 04:13:19 -0500
Received: from [217.8.192.20] (helo=smtp2.mail.ch.easynet.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APegB-0006G3-8i
	for classpath@gnu.org; Fri, 28 Nov 2003 04:12:47 -0500
Received: from [192.168.1.33] (199.248.dyn-adsl.customer.ch.easynet.net
	[217.8.199.248]) by smtp2.mail.ch.easynet.net (Postfix) with ESMTP
	id D22F8645FC; Fri, 28 Nov 2003 09:11:19 +0100 (CET)
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Fri, 28 Nov 2003 09:10:04 +0100
Message-Id: <20031128081004.5511@smtp.mail.ch.easynet.net>
In-Reply-To: <87u14pcgr6.fsf@dub.venge.net>
References: <87u14pcgr6.fsf@dub.venge.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: graydon hoare <graydon@redhat.com>
Subject: Re: [PATCH] swing frame fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 09:13:32 -0000

Hi Graydon,

>ok, I've attached a testcase for mauve which gives JLayeredPane class
>(also attached) a good workout; I tested this on sun's jdk and my own
>code, and picked a bunch of bugs out of both the test and my own code
>as a result.

Yeah, this happens to me, too: First I think that the code is good, but
then, a nasty problem comes up for each test snippet. Which certainly
doesn't make it more fun to write tests...

Thanks a lot for having written the test case, and also for the nice
documentation. (Do javadoc-like tools really automatically insert <p>
tags into the HTML?)

Best regards,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Fri Nov 28 08:40:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APir5-0007gD-EB
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 08:40:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APir2-0007fr-GR
	for classpath@gnu.org; Fri, 28 Nov 2003 08:40:16 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APiqW-0007VZ-8J
	for classpath@gnu.org; Fri, 28 Nov 2003 08:40:15 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APiqV-0007UI-50
	for classpath@gnu.org; Fri, 28 Nov 2003 08:39:43 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APhsJ-0001W2-00; Fri, 28 Nov 2003 13:37:31 +0100
From: Mark Wielaard <mark@klomp.org>
To: Stephen Crawley <crawley@dstc.edu.au>
In-Reply-To: <200311280338.hAS3cqYd024381@piglet.dstc.edu.au>
References: <200311280338.hAS3cqYd024381@piglet.dstc.edu.au>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-QJsy/xMWLaOCaaoKR0PE"
Message-Id: <1070023082.27171.244.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 28 Nov 2003 13:38:02 +0100
Cc: crawley@piglet.dstc.edu.au, classpath@gnu.org, java-patches@gcc.gnu.org,
	kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 13:40:17 -0000


--=-QJsy/xMWLaOCaaoKR0PE
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-28 at 04:39, Stephen Crawley wrote:
> Mark Wielaard <mark@klomp.org> wrote:
> > On Fri, 2003-11-28 at 02:03, Stephen Crawley wrote:
> > > The over-arching principle for Mauve testcases is that the behavior o=
f
> > > Sun's Java implementations is the "gold standard" for conformance
> > > testing.
> >=20
> > I don't agree. We should not create Mauve tests to validate some
> > proprietary library implementation.
>
> I don't understand what you are saying here.

Sorry, was way past my bedtime. Maybe I should have taken more time
explain. I was mainly disturbed by the suggestion that some proprietary
implementation should be pointed out as the "gold standard" and that if
that same implementation decides not to fix bugs then it isn't a bug.

There are lots of examples of bugs in some widely used implementations.
Mauve points those out. For example floating point string
representation, or solving the solutions for some quadratic equation and
very possible representations of date and time. I haven't checked Ito
his test yet, but I hope you agree that even though some implementation
might claim say that a certain month has 35 days then it is obviously a
bug and not according to spec. What you seem to want is a list of bugs
in certain implementations according to Mauve and an explanation why
that bug is or isn't solved in that implementation. We don't provide
that. Even though it might be useful for some of our users.

>   We are not building Mauve
> tests in order to validate Sun's implementation.  Rather, we are
> building it to check that other implementations (including Classpath)
> conform to the accepted specification for Java.  The ultimate
> specification for Java is (according to Sun) the behaviour of Sun's
> reference implementations.
>=20
> Are you suggesting that there is a more appropriate or more definitive
> specification of Java?  If so, what is it, and why is it more
> appropriate or definitive? =20

No. Since Sun says what Java is and claims trademark on products which
carry that name. It is their definitive specification: "The thing that
according to Sun is Java". So by definition Mauve isn't The Java
Testsuite.

But there are publicly published documents and books about the libraries
and what Mauve can claim is that it is a testsuite that follows these
publicly published specification as closely as possible without favoring
any actual implementation.

Mauve is a reference test suite that everybody can use and study and
might even adapt (to better reflect their understanding of the spec) and
publish its own version, which validates differences between core
library implementations. In that sense Mauve is its own specification.

And for our users it is certainly very useful to use Mauve to compare
implementations against the currently dominant proprietary
implementation to see if another implementation can be used to easily
migrate away from the that implementation.

Cheers,

Mark

--=-QJsy/xMWLaOCaaoKR0PE
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x0GqxVhZCJWr9QwRApLHAJ47rhWjplrtR5O0MIiPgJu9CuGAgwCfYC8U
DfzJDHwBWYDfOcxwcFymSVM=
=vM2/
-----END PGP SIGNATURE-----

--=-QJsy/xMWLaOCaaoKR0PE--




From MAILER-DAEMON Fri Nov 28 10:13:59 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APkJj-0001AD-Bw
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 10:13:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APkJg-000170-Md
	for classpath@gnu.org; Fri, 28 Nov 2003 10:13:56 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APkJA-0000kl-Is
	for classpath@gnu.org; Fri, 28 Nov 2003 10:13:55 -0500
Received: from [24.25.9.102] (helo=ms-smtp-03-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APkJA-0000jw-8D
	for classpath@gnu.org; Fri, 28 Nov 2003 10:13:24 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-03-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hASEBuFm023333; Fri, 28 Nov 2003 09:11:56 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id F3E43BE641; Fri, 28 Nov 2003 09:11:55 -0500 (EST)
Sender: cbj@haphazard.org
To: Mark Wielaard <mark@klomp.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<1069949537.27158.94.camel@elsschot.wildebeest.org>
From: Brian Jones <cbj@gnu.org>
Date: 28 Nov 2003 09:11:55 -0500
In-Reply-To: <1069949537.27158.94.camel@elsschot.wildebeest.org>
Message-ID: <m3vfp460r8.fsf@lyta.haphazard.org>
Lines: 20
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 15:13:57 -0000

Mark Wielaard <mark@klomp.org> writes:

> Hi,
> 
> On Thu, 2003-11-27 at 16:57, Mark Wielaard wrote:
> > [UPDATE: It appears I broke it :( I am trying to figure out what I did
> > wrong. Help wanted...]
> 
> Somehow this fixed itself. Strange. I have been banging my head against
> a wall for an hour and apparently some cron job then kicked in and
> auto-fixed the symlinks or something...
> 
> Anyway. Please check out Patrik his work:
> http://www.gnu.org/software/classpath/

Some of the links are broken that shouldn't be.

Brian
-- 
Brian Jones <cbj@gnu.org>



From MAILER-DAEMON Fri Nov 28 10:23:41 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APkT6-0004km-De
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 10:23:40 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APkT3-0004jx-8b
	for classpath@gnu.org; Fri, 28 Nov 2003 10:23:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APkSX-0004cs-Jm
	for classpath@gnu.org; Fri, 28 Nov 2003 10:23:36 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1APkS2-0004TD-07; Fri, 28 Nov 2003 10:22:34 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APjU4-0001in-00; Fri, 28 Nov 2003 15:20:36 +0100
From: Mark Wielaard <mark@klomp.org>
To: Brian Jones <cbj@gnu.org>
In-Reply-To: <m3vfp460r8.fsf@lyta.haphazard.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<1069949537.27158.94.camel@elsschot.wildebeest.org>
	<m3vfp460r8.fsf@lyta.haphazard.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-jBKUsSINZxZhRBOXoRvx"
Message-Id: <1070029267.27171.282.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 28 Nov 2003 15:21:07 +0100
Cc: classpath@gnu.org
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 15:23:37 -0000


--=-jBKUsSINZxZhRBOXoRvx
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-28 at 15:11, Brian Jones wrote:
> > Anyway. Please check out Patrik his work:
> > http://www.gnu.org/software/classpath/
>=20
> Some of the links are broken that shouldn't be.

Thanks. Which one in particular?

Cheers,

Mark

--=-jBKUsSINZxZhRBOXoRvx
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x1nTxVhZCJWr9QwRAtYUAJ9zbPu7d+EQSNpp6a2srr1egszXSwCffaVX
Fw1ki2fvZ93WNI8VQlfahyU=
=bJSP
-----END PGP SIGNATURE-----

--=-jBKUsSINZxZhRBOXoRvx--




From MAILER-DAEMON Fri Nov 28 10:50:15 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APksp-0004yr-NR
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 10:50:15 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APksm-0004xr-RA
	for classpath@gnu.org; Fri, 28 Nov 2003 10:50:12 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APkni-0003pR-Eq
	for classpath@gnu.org; Fri, 28 Nov 2003 10:45:41 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APknh-0003oX-D3
	for classpath@gnu.org; Fri, 28 Nov 2003 10:44:57 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1APjqE-0003uU-00
	for <classpath@gnu.org>; Fri, 28 Nov 2003 15:43:30 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1APjqB-0003tO-00; Fri, 28 Nov 2003 15:43:27 +0100
Message-ID: <3FC75F0E.6040802@kaffe.org>
Date: Fri, 28 Nov 2003 15:43:26 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stephen Crawley <crawley@dstc.edu.au>
References: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
In-Reply-To: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: crawley@piglet.dstc.edu.au, classpath@gnu.org,
	Mark Wielaard <mark@klomp.org>, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 15:50:13 -0000

Hi Stephen,

Stephen Crawley wrote:
> kaz@maczuka.gcd.org said:
> 
>>A mauve test attached. Since I have got a write access to the mauve
>>CVS registry,  I will add it to the registry.  The test results shows
>>that Sun's implementation also seems to have something wrong. 
> 
> 
> If Sun's implementation (you don't say which JDK version!) is failing
> a test, then that casts serious doubt on the correctness of the mauve
> testcase itself!

Sure. On the other hand, it also casts doubts on the quality of Sun's 
implementation. The JDK is quite buggy, see the JDK Bug Parade for a 
reference. The implementations are often less buggy that what we have in 
GNU Classpath or kaffe at the moment, but they are far from perfect, in 
my experience. I don't usually have much trouble crashing Sun's 1.4.2 VM 
with my java code. ;)

After looking at the test case, I'd say that it excercises a bit of a 
very badly specified area of the JDK. java.util.Calendar has a very, 
very ugly API. You can set the fields separately, but setting them can 
trigger recalculations & clearing of other, related fields.

Unfortunately, how the changes propagate is not very well documented, 
unless you shelve out the cash for the Java Class Libraries Vol. 1, 2nd 
Edition & and the Vol. 1, 2nd Edition Supplement books. Even then, it's 
not very clear that if setting HOUR first (which triggers an update of 
AM_PM) and then set AM_PM (which triggers an update of HOUR) has the 
same effect as setting AM_PM first and then setting HOUR.

I've tried Ito's test case with the setting of AM_PM and HOUR in 
reverse. The results for the JDK 1.4.2 are the same, it still breaks on 
the same four test cases as before. Clearing the calender to avoid side 
effects in field computation because of current time's fields being set 
doesn't help, either.

Bascially, there seems to be no way to tell Sun's JDK that you want to 
have 12:[00-59] [AM|PM] by using the set(field, value) API. [1] Which 
looks like a bug in Sun's implemenation to me, and this test exposes it.

> The over-arching principle for Mauve testcases is that the behavior of
> Sun's Java implementations is the "gold standard" for conformance
> testing.  Even if the Sun Java behavior contradicts the javadocs, or
> is "just plain wrong", it is still technically "correct behavior" from
> the POV of conformance.

That depends on the situation. If the behaviour is clearly a bug, like 
in the above case, I'd say report it to Sun, make sure Classpath does it 
better, and have a mauve test to expose the bug in the JDK.

After all, the goal shouldn't be to just have the classes, it should be 
to have the superior implementation. Having a test suite of our own 
helps in showing that everyone's implementations are buggy, but at least 
you can fix the free ones and share the fixes ;)

> [Sun sometimes acknowledges JDK bugs, but then says they won't fix them. 
> because of the risk of breaking existing customer code.  In such cases,
> other Java implementations need to be bug-for-bug compatible in order
> to minimize cross-platform portability problems for developers and
> end-users.]

Yes, but they also fix a lot of bugs between releases, judging by their 
release notes. If the software depends on the bug, I'd say fix the 
software ;) If the software depends on some badly specified part of the 
spec, I'd say write tests & make sure we understand that part well, so 
that we can make Classpath's code even better than the JDK. Which is the 
case here, I believe.

In the long run, the JDK is as irrelevant as an industry standard as SCO 
Unix is now. Ten years ago, there were many (closed source) 
implementations of Unix-ish OSes. GNU/Linux is gradually replacing them.

I boldly predict that the same will happen with Java. True WORA for Java 
will arrive, but it will arrive through free software efforts like mauve 
& GNU Classpath [2] that will provide the next reference platform.

cheers,
dalibor topic

[1] Unless you can somehow guess that setting AM_PM seems to wrap the 
clock time around in a rather weird way, so that when it's 12 and you 
set it to PM, you get AM, but when it's 12 and you set it to PM, you get 
AM.
[2] And kaffe, gcj, sablevm, kissme, etc. of course ;)




From MAILER-DAEMON Fri Nov 28 12:14:04 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APmBw-0004AH-CH
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 12:14:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APmBt-00049s-Os
	for classpath@gnu.org; Fri, 28 Nov 2003 12:14:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APmBN-00044D-Tn
	for classpath@gnu.org; Fri, 28 Nov 2003 12:14:00 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APmBM-000440-LS
	for classpath@gnu.org; Fri, 28 Nov 2003 12:13:29 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APlDN-0001x5-00
	for <classpath@gnu.org>; Fri, 28 Nov 2003 17:11:29 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-unev2ALYYARua+D3BeS3"
Message-Id: <1070035920.27161.315.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 28 Nov 2003 17:12:01 +0100
Subject: Proposed NEWS entry for 0.07 (and test release)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 17:14:02 -0000


--=-unev2ALYYARua+D3BeS3
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

Here is the proposed NEWS entry for the 0.07 release.
Since we had almost 250 ChangeLog entries since 0.06 (only three months
ago) I have only quickly scanned over the list. My apologies if I missed
something. Please suggest additions.

New in release 0.07 (not-yet-released)

* Works with libtool 1.5 (and 1.4.3).
* java.awt gtk+ peers now depend on gtk+ 2.2.x and uses pango.
  Lots and lots improvements on the peers.
* java.awt.geom.CubicCurve2D, java.awt.geom.QuadCurve2D:
  Subdivision and flatness calculation implemented.
* java.awt.geom.FlatteningPathIterator: Working implementation.
* gnu.java.awt.BitwiseXORComposite helper class.
* New rmic compilers (jikes, kjc) support.
* java.text bug fixing and 1.4 updates (Currency).
* Hashtable and HashMap function more similar to other implementations.
* javax.naming and java.beans classloader fixes.
* URL parsing, URLConnection, protocol and (needed) permission fixes.
* More java.nio implementation
  (API complete, but implementation not finished yet).
* Lots of java.net code cleanup.
* Improved documentation.
* Numerous bug fixes in almost every package, and lots of updates for =20
  1.4 functionality.
* Fixed Classpath bugs:
  #2944 Incorrect synchronization in java.util.logging.ErrorManager
  #6075 java.awt.geom.GeneralPath.getCurrentPoint returns wrong results
  #6076 java.awt.geom.GeneralPath constructor sometimes hangs
  #6089 java.awt.geom.GeneralPath.getPathIterator does not work
  [...]

I tried to come up with a complete bug list but I don't understand how
to convince the Savannah bug tracker to give me one. It should be all
bugs fixed/closed after 2003/22/08 when we released 0.06, but the
returned list looks random to me.

A test release can be found (in a couple of minutes) at:
http://www.klomp.org/mark/classpath/

MD5sum:
115946c39e2795e8d4de32dfaf047790  classpath-0.07+rc1.tar.gz

I will wait for Dalibor his Hastable fix to make it in, but I want to
make the real release in a couple of hours. But if someone has a
showstopper that cannot wait please yell!
(And there is no real hurry since I don't have access yet to upload the
final version to ftp.gnu.org again. Sigh...)

Cheers,

Mark

--=-unev2ALYYARua+D3BeS3
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x3PQxVhZCJWr9QwRApfDAJ4nFueK7ISeSHWziXj7NHpUlk3dygCfZI42
tWcq+rI65EVA5t4s5gKEecg=
=INrA
-----END PGP SIGNATURE-----

--=-unev2ALYYARua+D3BeS3--




From MAILER-DAEMON Fri Nov 28 12:41:43 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APmch-0007rc-Ca
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 12:41:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APmcf-0007rV-LO
	for classpath@gnu.org; Fri, 28 Nov 2003 12:41:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APmc9-0007Rj-Dk
	for classpath@gnu.org; Fri, 28 Nov 2003 12:41:40 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APmc8-0007Qi-Qt
	for classpath@gnu.org; Fri, 28 Nov 2003 12:41:08 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1APleh-0004OV-00
	for <classpath@gnu.org>; Fri, 28 Nov 2003 17:39:43 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1APlee-0004Ns-00; Fri, 28 Nov 2003 17:39:40 +0100
Message-ID: <3FC77A4B.7070302@kaffe.org>
Date: Fri, 28 Nov 2003 17:39:39 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
	<1069505518.2856.724.camel@elsschot.wildebeest.org>
In-Reply-To: <1069505518.2856.724.camel@elsschot.wildebeest.org>
Content-Type: multipart/mixed; boundary="------------010002090700060303040000"
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 17:41:42 -0000

This is a multi-part message in MIME format.
--------------010002090700060303040000
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi Mark, hallo Jeroen,

Mark Wielaard wrote:
> Hi
> 
> On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote:
> 
>>The fix is actually incorrect. containsValue() should call contains()
>>because containsValue() is a new method (since 1.2) and contains()
>>exists since 1.0. Older code may have overridden contains() and this
>>should work with newer code that calls containsValue().
> 
> 
> Urgh. Yes, you are right. Wrote an additional test case for this:
> gnu.testlet.java.util.Hashtable.ContainsHash (it currently fails).

Thanks for pointing that mistake out. I've attached an updated version 
of the patch.

2003-11-28  Dalibor Topic <robilad@kaffe.org>

         Reported by: Jim Pick <jim@kaffe.org>

         * libraries/javalib/java/util/Hashtable.java
         (internalcontainsValue): New method.
         (contains) Delegate to internalContainsValue.

         Reported by: Mark Wielaard  <mark@klomp.org>

         * libraries/javalib/java/util/Hashtable.java
         (contains): Improved comment.

         Reported by: Jeroen Frijters  <jeroen@frijters.net>

         * libraries/javalib/java/util/Hashtable.java
         (containsValue): Delegate to contains(Object) to make sure older
         code overwriting it continues to work.

I'm not sure how to deal with mutliple people's bug reports being fixed 
in this patch in the ChangeLog entry, so I'd appreciate a hint from the 
ChangeLog police.

> 
>>As I've argued before, in cases such as these (multiple virtual methods
>>that do the same thing), we must use the same delegation as the Sun
>>implementation to be compatible.
> 
> 
> Problem is that this is not always easy to know.
> So we depend on bug reports and then have to write a Mauve test if we
> think that following such behavior is beneficial. But the "newer calls
> older" is a guideline that will mostly work (I hope).

Yes, that makes the most sense to me, too. Stuart Ballard started 
working on a 'override compatibility' test suite for collection classes. 
  See [1] for details.

cheers,
dalibor topic

[1] http://www.kaffe.org/pipermail/kaffe/2003-May/042181.html

--------------010002090700060303040000
Content-Type: text/plain;
 name="cpath-02-hashtable-contains.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-02-hashtable-contains.diff"

--- /var/tmp/PROJECTS/classpath/java/util/Hashtable.java	Wed Nov 12 21:56:20 2003
+++ kaffe/libraries/javalib/java/util/Hashtable.java	Fri Nov 28 17:11:51 2003
@@ -333,7 +333,11 @@
    */
   public synchronized boolean contains(Object value)
   {
-    return containsValue(value);
+    /* delegate to non-overridable worker method 
+     * to avoid blowing up the stack, when called 
+     * from overridden contains[Value]() method.
+     */
+    return internalContainsValue(value);
   }
 
   /**
@@ -349,6 +353,25 @@
    * @since 1.2
    */
   public boolean containsValue(Object value)
+  {
+    /* delegate to older method to make sure code overwriting it 
+     * continues to work.
+     */
+    return contains(value);
+  }
+
+  /**
+   * Returns true if this Hashtable contains a value <code>o</code>, such that
+   * <code>o.equals(value)</code>. This is an internal worker method
+   * called by <code>contains()</code> and <code>containsValue()</code>.
+   *
+   * @param value the value to search for in this Hashtable
+   * @return true if at least one key maps to the value
+   * @see #contains(Object)
+   * @see #containsKey(Object)
+   * @throws NullPointerException if <code>value</code> is null
+   */
+  private boolean internalContainsValue(Object value)
   {
     for (int i = buckets.length - 1; i >= 0; i--)
       {

--------------010002090700060303040000--




From MAILER-DAEMON Fri Nov 28 13:07:55 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APn22-0005ym-Qd
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 13:07:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APn20-0005yJ-3Y
	for classpath@gnu.org; Fri, 28 Nov 2003 13:07:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APn1R-0005qR-V5
	for classpath@gnu.org; Fri, 28 Nov 2003 13:07:49 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APn1R-0005qE-Fm
	for classpath@gnu.org; Fri, 28 Nov 2003 13:07:17 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APm3M-00024V-00; Fri, 28 Nov 2003 18:05:12 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FC77A4B.7070302@kaffe.org>
References: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
	<1069505518.2856.724.camel@elsschot.wildebeest.org>
	<3FC77A4B.7070302@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-jYwcSo5vTquKFkoYOsNc"
Message-Id: <1070039144.27164.322.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 28 Nov 2003 18:05:44 +0100
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 18:07:52 -0000


--=-jYwcSo5vTquKFkoYOsNc
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2003-11-28 at 17:39, Dalibor Topic wrote:
> Thanks for pointing that mistake out. I've attached an updated version=20
> of the patch.
>=20
> 2003-11-28  Dalibor Topic <robilad@kaffe.org>
>=20
>          Reported by: Jim Pick <jim@kaffe.org>
>=20
>          * libraries/javalib/java/util/Hashtable.java
>          (internalcontainsValue): New method.
>          (contains) Delegate to internalContainsValue.
>=20
>          Reported by: Mark Wielaard  <mark@klomp.org>
>=20
>          * libraries/javalib/java/util/Hashtable.java
>          (contains): Improved comment.
>=20
>          Reported by: Jeroen Frijters  <jeroen@frijters.net>
>=20
>          * libraries/javalib/java/util/Hashtable.java
>          (containsValue): Delegate to contains(Object) to make sure older
>          code overwriting it continues to work.
>=20
> I'm not sure how to deal with mutliple people's bug reports being fixed=20
> in this patch in the ChangeLog entry, so I'd appreciate a hint from the=20
> ChangeLog police.

Looks fine to me. (I would loose the extra empty line between Reported
by: and the actual change, but feel free to ignore me).

Also you could now pull the complete internalContainsValue() into the
containsValue() method, but that would make the patch bigger, so don't
bother (compiler/VM will inline the private method anyway).

If this solves both Mauve Hashtable tests, please check it in.

> Yes, that makes the most sense to me, too. Stuart Ballard started=20
> working on a 'override compatibility' test suite for collection classes.=20
>   See [1] for details.
>
> [1] http://www.kaffe.org/pipermail/kaffe/2003-May/042181.html

Interesting. Might be a candidate for our extended Mauve tests.

Cheers,

Mark

--=-jYwcSo5vTquKFkoYOsNc
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x4BnxVhZCJWr9QwRAvrrAJ9AWanytCRzFBTPxaaTRy25ogByZACfYdmx
nLUfc9w9TLgM6Y9cvfwR3GQ=
=Atp1
-----END PGP SIGNATURE-----

--=-jYwcSo5vTquKFkoYOsNc--




From MAILER-DAEMON Fri Nov 28 13:44:52 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APnbo-0007T3-5M
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 13:44:52 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APnbk-0007RN-Hr
	for classpath@gnu.org; Fri, 28 Nov 2003 13:44:48 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APnbE-0007Q9-On
	for classpath@gnu.org; Fri, 28 Nov 2003 13:44:47 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APnbE-0007Q6-FH
	for classpath@gnu.org; Fri, 28 Nov 2003 13:44:16 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1APmdm-0004FG-00
	for <classpath@gnu.org>; Fri, 28 Nov 2003 18:42:50 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1APmdi-0004DX-00; Fri, 28 Nov 2003 18:42:46 +0100
Message-ID: <3FC78916.4070703@kaffe.org>
Date: Fri, 28 Nov 2003 18:42:46 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>	
	<1069505518.2856.724.camel@elsschot.wildebeest.org>	
	<3FC77A4B.7070302@kaffe.org>
	<1070039144.27164.322.camel@elsschot.wildebeest.org>
In-Reply-To: <1070039144.27164.322.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 18:44:49 -0000

Hi Mark,

Mark Wielaard wrote:
> Hi,
> 
> On Fri, 2003-11-28 at 17:39, Dalibor Topic wrote:
> 
>>Thanks for pointing that mistake out. I've attached an updated version 
>>of the patch.
>>
>>2003-11-28  Dalibor Topic <robilad@kaffe.org>
>>
>>         Reported by: Jim Pick <jim@kaffe.org>
>>
>>         * libraries/javalib/java/util/Hashtable.java
>>         (internalcontainsValue): New method.
>>         (contains) Delegate to internalContainsValue.
>>
>>         Reported by: Mark Wielaard  <mark@klomp.org>
>>
>>         * libraries/javalib/java/util/Hashtable.java
>>         (contains): Improved comment.
>>
>>         Reported by: Jeroen Frijters  <jeroen@frijters.net>
>>
>>         * libraries/javalib/java/util/Hashtable.java
>>         (containsValue): Delegate to contains(Object) to make sure older
>>         code overwriting it continues to work.
>>
>>I'm not sure how to deal with mutliple people's bug reports being fixed 
>>in this patch in the ChangeLog entry, so I'd appreciate a hint from the 
>>ChangeLog police.
> 
> 
> Looks fine to me. (I would loose the extra empty line between Reported
> by: and the actual change, but feel free to ignore me).
> 
> Also you could now pull the complete internalContainsValue() into the
> containsValue() method, but that would make the patch bigger, so don't
> bother (compiler/VM will inline the private method anyway).

O.K.

> If this solves both Mauve Hashtable tests, please check it in.

done.

cheers,
dalibor topic




From MAILER-DAEMON Fri Nov 28 14:30:55 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APoKM-0008O8-Gc
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 14:30:54 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APoKI-0008M2-HY
	for classpath@gnu.org; Fri, 28 Nov 2003 14:30:50 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APoJk-0008Ci-VH
	for classpath@gnu.org; Fri, 28 Nov 2003 14:30:48 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1APoJi-00088u-DG; Fri, 28 Nov 2003 14:30:14 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hASITfSX037462;
	Fri, 28 Nov 2003 19:29:42 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311281829.hASITfSX037462@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Mark Wielaard <mark@klomp.org>, Brian Jones <cbj@gnu.org>
Date: Fri, 28 Nov 2003 19:29:41 +0100
X-Mailer: KMail [version 1.3]
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<m3vfp460r8.fsf@lyta.haphazard.org>
	<1070029267.27171.282.camel@elsschot.wildebeest.org>
In-Reply-To: <1070029267.27171.282.camel@elsschot.wildebeest.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: classpath@gnu.org
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 19:30:52 -0000

On Friday 28 November 2003 15:21, Mark Wielaard wrote:
> Hi,
>
> On Fri, 2003-11-28 at 15:11, Brian Jones wrote:
> > > Anyway. Please check out Patrik his work:
> > > http://www.gnu.org/software/classpath/
> >
> > Some of the links are broken that shouldn't be.
>
> Thanks. Which one in particular?

Brian, you must know that's the most frustrating comment a webmaster can ever 
hear. Next to "it's nice, but there are a few spelling mistakes".

WHICH? WHERE?

-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Fri Nov 28 14:32:40 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APoM3-0000iL-5b
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 14:32:39 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APoLz-0000gG-KB
	for classpath@gnu.org; Fri, 28 Nov 2003 14:32:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APoLM-0000MX-J2
	for classpath@gnu.org; Fri, 28 Nov 2003 14:32:27 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1APoLL-0000LQ-MY
	for classpath@gnu.org; Fri, 28 Nov 2003 14:31:56 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hASIVISX037468;
	Fri, 28 Nov 2003 19:31:19 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311281831.hASIVISX037468@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Dalibor Topic <robilad@kaffe.org>, Stephen Crawley <crawley@dstc.edu.au>
Date: Fri, 28 Nov 2003 19:31:18 +0100
X-Mailer: KMail [version 1.3]
References: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
	<3FC75F0E.6040802@kaffe.org>
In-Reply-To: <3FC75F0E.6040802@kaffe.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: classpath@gnu.org, Mark Wielaard <mark@klomp.org>,
	crawley@piglet.dstc.edu.au, java-patches@gcc.gnu.org, kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 19:32:37 -0000

On Friday 28 November 2003 15:43, Dalibor Topic wrote:

> In the long run, the JDK is as irrelevant as an industry standard as SCO
> Unix is now. Ten years ago, there were many (closed source)
> implementations of Unix-ish OSes. GNU/Linux is gradually replacing them.
>
> I boldly predict that the same will happen with Java. True WORA for Java
> will arrive, but it will arrive through free software efforts like mauve
> & GNU Classpath [2] that will provide the next reference platform.

me2

-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Fri Nov 28 14:42:45 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APoVp-0000Nx-4C
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 14:42:45 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APoVk-0000Jg-AH
	for classpath@gnu.org; Fri, 28 Nov 2003 14:42:40 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APoVA-0008EW-I9
	for classpath@gnu.org; Fri, 28 Nov 2003 14:42:35 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1APoV9-0008CR-TM
	for classpath@gnu.org; Fri, 28 Nov 2003 14:42:04 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hASIfbSX037478;
	Fri, 28 Nov 2003 19:41:37 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311281841.hASIfbSX037478@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Dalibor Topic <robilad@kaffe.org>, Mark Wielaard <mark@klomp.org>
Date: Fri, 28 Nov 2003 19:41:37 +0100
X-Mailer: KMail [version 1.3]
References: <788B535AB1F9CB49BB9C229372B50ACC04C69A@LEMBU.sumatrasoftware.com>
	<1069505518.2856.724.camel@elsschot.wildebeest.org>
	<3FC77A4B.7070302@kaffe.org>
In-Reply-To: <3FC77A4B.7070302@kaffe.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: [PATCH] Fix for Hashtable contains blowing up the stack
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2003 19:42:41 -0000

On Friday 28 November 2003 17:39, Dalibor Topic wrote:
> Hi Mark, hallo Jeroen,
>
> Mark Wielaard wrote:
> > Hi
> >
> > On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote:
> >>The fix is actually incorrect. containsValue() should call contains()
> >>because containsValue() is a new method (since 1.2) and contains()
> >>exists since 1.0. Older code may have overridden contains() and this
> >>should work with newer code that calls containsValue().
> >
> > Urgh. Yes, you are right. Wrote an additional test case for this:
> > gnu.testlet.java.util.Hashtable.ContainsHash (it currently fails).

The online API docs for 1.4.2 just say
    Note that this method is identical in functionality to contains (which 
predates the Map interface).
which would certainly lead one to believe that both-call-a-private-worker 
would be the right thing to do. Nonetheless Jeroen's argument is compelling.

In that case the rule seems to be
  - one API-visible method should not call another API-visible method, they 
should both call some non-visible "worker" method,
  - UNLESS it's actually documented thet this should happen,
  - OR the methods are synonyms and one was added later just to retcon the 
class into implementing some interface.

Hm, messy ...


-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Fri Nov 28 19:36:21 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APt5s-0005LY-P7
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 19:36:16 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APt5i-0005EX-Es
	for classpath@gnu.org; Fri, 28 Nov 2003 19:36:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APt59-00052Z-Bo
	for classpath@gnu.org; Fri, 28 Nov 2003 19:36:02 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APt58-00052B-Rf
	for classpath@gnu.org; Fri, 28 Nov 2003 19:35:30 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APs74-0002s6-00; Sat, 29 Nov 2003 00:33:26 +0100
From: Mark Wielaard <mark@klomp.org>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>
In-Reply-To: <20031127222502.1836.qmail@maczuka.gcd.org>
References: <20031127160643.496.qmail@maczuka.gcd.org>
	<20031127161440.GA1604@mail.konqueror.de>
	<20031127222502.1836.qmail@maczuka.gcd.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-vLBDGHO4HFtJf0VWk0K1"
Message-Id: <1070062438.27173.400.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 29 Nov 2003 00:33:58 +0100
Cc: classpath@gnu.org, kaffe@kaffe.org
Subject: Re: java/text/SimpleDateFormat.java (compileFormat)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 00:36:15 -0000


--=-vLBDGHO4HFtJf0VWk0K1
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2003-11-27 at 23:25, Ito Kazumitsu wrote:

> 2003-11-28  Ito Kazumitsu  <kaz@maczuka.gcd.org>
>=20
> 	* java/text/SimpleDateFormat.java (compileFormat):=20
> 	isLowerCase and isUpperCase allow too many characters.
> 	Just use >=3D 'A' && <=3D 'Z' || >=3D 'a' && <=3D 'z'.

Thanks a lot for looking after this.
I have committed it so that it can make the 0.07 release.

BTW about releasing 0.07. I am to tired to roll it now and do all the
checks to make sure it is perfect. So I will take a long sleep first.
Then make the final test release in the morning. Take a walk on the
beach and if nobody complained release it for real in the afternoon.

Michael Koch also had some Socket cleanups that he tested with gcj that
should go in 0.07 if possible.

Cheers,

Mark

--=-vLBDGHO4HFtJf0VWk0K1
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x9tmxVhZCJWr9QwRAqAjAJ9dwIUYr5yRZfGn3Ck5wyzpYMpZdgCdGctX
DGR9Gz+yS/p2mzk3QclV0uQ=
=Nglv
-----END PGP SIGNATURE-----

--=-vLBDGHO4HFtJf0VWk0K1--




From MAILER-DAEMON Fri Nov 28 19:41:15 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APtAg-0001Dr-Hp
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 19:41:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APtAb-0001Av-LI
	for classpath@gnu.org; Fri, 28 Nov 2003 19:41:09 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APtA0-0000rH-O2
	for classpath@gnu.org; Fri, 28 Nov 2003 19:41:03 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APtA0-0000qz-7E
	for classpath@gnu.org; Fri, 28 Nov 2003 19:40:32 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1APsC2-0002tP-00
	for <classpath@gnu.org>; Sat, 29 Nov 2003 00:38:34 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-+r7q5hr9ZtaDUZAT5mSS"
Message-Id: <1070062745.27171.405.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 29 Nov 2003 00:39:06 +0100
Subject: Strange cvs server messages and no commit emails
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 00:41:12 -0000


--=-+r7q5hr9ZtaDUZAT5mSS
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

There is something strange going on with the cvs server.
After committing you sometimes get a message like:

        Cannot open file </var/run/log_accum/#classpath.lastdir.15048 No
        such file or directory.

The commit does make it into CVS but then no commit message seems to be
send. I have reported it to the savannah hackers:
https://savannah.gnu.org/support/index.php?func=3Ddetailitem&item_id=3D1026=
38

Please double check every cvs update you do since some commit messages
might not have made it to the commit-classpath list.

Cheers,

Mark

--=-+r7q5hr9ZtaDUZAT5mSS
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/x9yZxVhZCJWr9QwRAigUAKCkx/ow6n5wfJO0XmiA+b29RjSOkwCeM0EI
EIIMvudrsEBAt5Y9HbZCUv0=
=hIIl
-----END PGP SIGNATURE-----

--=-+r7q5hr9ZtaDUZAT5mSS--




From MAILER-DAEMON Fri Nov 28 21:39:51 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1APv1T-00087E-FC
	for mharc-classpath@gnu.org; Fri, 28 Nov 2003 21:39:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1APv1Q-000863-Af
	for classpath@gnu.org; Fri, 28 Nov 2003 21:39:48 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1APv0t-0007y5-L6
	for classpath@gnu.org; Fri, 28 Nov 2003 21:39:46 -0500
Received: from [210.230.164.2] (helo=mail.jsdi.or.jp)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1APv0s-0007xX-Pr
	for classpath@gnu.org; Fri, 28 Nov 2003 21:39:15 -0500
Received: from dl.maczuka.gcd.org (d082.hi.jsdi.or.jp [210.230.165.82])
	by mail.jsdi.or.jp (8.11.6p2/8.11.6) with SMTP id hAT1bgp43149
	for <classpath@gnu.org>; Sat, 29 Nov 2003 10:37:43 +0900 (JST)
Received: (qmail 2568 invoked by uid 0); 29 Nov 2003 01:37:43 -0000
Received: from ph.maczuka.gcd.org (HELO maczuka.gcd.org) (192.168.0.1)
	by dl.maczuka.gcd.org with SMTP; 29 Nov 2003 01:37:43 -0000
Received: (qmail 24588 invoked by uid 1000); 29 Nov 2003 01:38:01 -0000
Message-ID: <20031129013801.24587.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: classpath@gnu.org
In-reply-to: Your message of "Fri, 28 Nov 2003 11:03:16 +1000"
References: <200311280102.hAS12oYd014201@piglet.dstc.edu.au>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Sat, 29 Nov 2003 10:38:00 +0900
Sender: kaz@maczuka.gcd.org
Cc: kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes 
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 02:39:49 -0000

Hi,

>>>>> ":" == Stephen Crawley <crawley@dstc.edu.au> writes:

:> If Sun's implementation (you don't say which JDK version!) is failing
:> a test, then that casts serious doubt on the correctness of the mauve
:> testcase itself!

I mentioned the JDK version as Sun's java version "1.4.2_02"
before showing the test results.

As for the correctness of the mauve testcase I made, I am
confident of it.

And my opinions on the discussed issue are:

1. Should the mauve test conform to Sun's implementation
   even if it seems incorrect?

   No.

2. Should GNU Classpath (or other implementations) simulate
   Sun's implementation even if it seems incorrect?

   Yes, if it is necesary.

These derives from Dalibor's saying in an article of Kaffe mailing list:
Date:        Tue, 01 Jul 2003 03:09:43 MST
Subject:     Re: [kaffe] Bug report (java.io.StreamTokenizer)

   Respect latest JDK API specs where you can,
   and do as Sun does where you must ;)

And in the case of 12 AM/PM issue,  I do not think we should
simulate Sun's bug.



From MAILER-DAEMON Sat Nov 29 03:18:25 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQ0J7-0004Jg-03
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 03:18:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQ0J4-0004JE-W2
	for classpath@gnu.org; Sat, 29 Nov 2003 03:18:22 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQ0IY-00043R-3a
	for classpath@gnu.org; Sat, 29 Nov 2003 03:18:21 -0500
Received: from [24.25.9.100] (helo=ms-smtp-01-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQ0IX-00043M-N5
	for classpath@gnu.org; Sat, 29 Nov 2003 03:17:49 -0500
Received: from lyta.haphazard.org (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-01-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	hAT7GMSq010693; Sat, 29 Nov 2003 02:16:22 -0500 (EST)
Received: by lyta.haphazard.org (Postfix, from userid 500)
	id 017F5BE641; Sat, 29 Nov 2003 02:16:21 -0500 (EST)
Sender: cbj@haphazard.org
To: Mark Wielaard <mark@klomp.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<1069949537.27158.94.camel@elsschot.wildebeest.org>
	<m3vfp460r8.fsf@lyta.haphazard.org>
	<1070029267.27171.282.camel@elsschot.wildebeest.org>
From: Brian Jones <cbj@gnu.org>
Date: 29 Nov 2003 02:16:21 -0500
In-Reply-To: <1070029267.27171.282.camel@elsschot.wildebeest.org>
Message-ID: <m3oeuv63wa.fsf@lyta.haphazard.org>
Lines: 18
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 08:18:23 -0000

Mark Wielaard <mark@klomp.org> writes:

> Hi,
> 
> On Fri, 2003-11-28 at 15:11, Brian Jones wrote:
> > > Anyway. Please check out Patrik his work:
> > > http://www.gnu.org/software/classpath/
> > 
> > Some of the links are broken that shouldn't be.
> 
> Thanks. Which one in particular?

Uh, "All Open Tasks" for one.  Just run one of those link checkers
over it.

Brian
-- 
Brian Jones <cbj@gnu.org>



From MAILER-DAEMON Sat Nov 29 05:43:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQ2Zb-0007yo-Rm
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 05:43:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQ2ZY-0007uc-HL
	for classpath@gnu.org; Sat, 29 Nov 2003 05:43:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQ2Z2-0007Vn-DZ
	for classpath@gnu.org; Sat, 29 Nov 2003 05:43:31 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AQ2YV-0007EJ-Lo; Sat, 29 Nov 2003 05:42:27 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AQ1aX-0004Ii-00; Sat, 29 Nov 2003 10:40:29 +0100
From: Mark Wielaard <mark@klomp.org>
To: Brian Jones <cbj@gnu.org>
In-Reply-To: <m3oeuv63wa.fsf@lyta.haphazard.org>
References: <1069948677.27164.85.camel@elsschot.wildebeest.org>
	<1069949537.27158.94.camel@elsschot.wildebeest.org>
	<m3vfp460r8.fsf@lyta.haphazard.org>
	<1070029267.27171.282.camel@elsschot.wildebeest.org>
	<m3oeuv63wa.fsf@lyta.haphazard.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-fJoB7rbvAF/3w8rwoOLA"
Message-Id: <1070098860.29476.46.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 29 Nov 2003 10:41:01 +0100
Cc: classpath@gnu.org
Subject: Re: New homepage
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 10:43:33 -0000


--=-fJoB7rbvAF/3w8rwoOLA
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2003-11-29 at 08:16, Brian Jones wrote:
> > On Fri, 2003-11-28 at 15:11, Brian Jones wrote:
> > > > Anyway. Please check out Patrik his work:
> > > > http://www.gnu.org/software/classpath/
> > >=20
> > > Some of the links are broken that shouldn't be.
> >=20
> > Thanks. Which one in particular?
>=20
> Uh, "All Open Tasks" for one.  Just run one of those link checkers
> over it.

Aha. Good. I did:
$ aptitude install webcheck
$ webcheck -b http://www.gnu.org/software/classpath/

That indeed gives a nice overview of some of the broken links.
The Open Tasks link was wrong after savannah interface change. Fixed
that.=20

The link checker doesn't like the jikesrvm link for some reason. Don't
know why since it works for me, but I changed it anyway to point to www,
not www-124.

Not fixed: We seem to need the (auto)mauve page back. But this is marked
as down at the moment. One of the old announcements points to a
status.html page which does not exist anymore, might be nice in the
future to get status and/or roadmap its own page. And some of the
releases are no more on alpha.gnu.org :{ Hopefully we will get them back
one day.

Cheers,

Mark

--=-fJoB7rbvAF/3w8rwoOLA
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yGmsxVhZCJWr9QwRAilaAJwORfZ0Iv9jdweUL+ZdiYFFseWcfACgmfmU
jLkFoHsmHw5wa6RTBIsIfUc=
=xWDK
-----END PGP SIGNATURE-----

--=-fJoB7rbvAF/3w8rwoOLA--




From MAILER-DAEMON Sat Nov 29 09:41:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQ6Hf-0006uR-2t
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 09:41:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQ6Hc-0006t6-Op
	for classpath@gnu.org; Sat, 29 Nov 2003 09:41:16 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQ6H6-0006br-Jw
	for classpath@gnu.org; Sat, 29 Nov 2003 09:41:15 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQ6H6-0006aW-62
	for classpath@gnu.org; Sat, 29 Nov 2003 09:40:44 -0500
Received: (qmail 13216 invoked by uid 504); 29 Nov 2003 14:39:17 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.549242 secs); 29 Nov 2003 13:39:17 -0000
Received: from unknown (HELO localhost) ([139.165.201.107])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 29 Nov 2003 14:39:16 +0100
Date: Sat, 29 Nov 2003 13:48:13 +0100 (CET)
Message-Id: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Sat_Nov_29_13_48_13_2003_561)--"
Content-Transfer-Encoding: 7bit
Subject: [Little Off Topic] Revolution is on ;)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 14:41:17 -0000

----Security_Multipart(Sat_Nov_29_13_48_13_2003_561)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Why don't you try to make a keynote at the JavaPolis (maybe next year)
in the Open Source hall.

http://www.bejug.org/bejugPortal/appmanager/BeJUG/JP03?_nfpb=true&16005_actionOverride=showPage&16005speaker=day1

If the link is bad, try http://www.bejug.org/ and follow 'Agenda'.

Cheers,

PS: I don't think I'll be there but I'll go at the FOSDEM, Bruxelles,
    Belgium: http://www.fosdem.org/

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Sat_Nov_29_13_48_13_2003_561)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yJWN4vzFZu62tMIRAvIyAKCowK+B4YInmaKrMJOBDUfy62y+xQCfXmoL
DjEV0MpfUqxiX3oezzDEvbs=
=sfgr
-----END PGP SIGNATURE-----

----Security_Multipart(Sat_Nov_29_13_48_13_2003_561)----



From MAILER-DAEMON Sat Nov 29 15:06:34 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQBMP-0007lg-IM
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 15:06:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQBMM-0007hh-Pv
	for classpath@gnu.org; Sat, 29 Nov 2003 15:06:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQBLq-0007Dn-G7
	for classpath@gnu.org; Sat, 29 Nov 2003 15:06:29 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQBLq-0007D7-87
	for classpath@gnu.org; Sat, 29 Nov 2003 15:05:58 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AQANa-0004Pf-Tu
	for classpath@gnu.org; Sat, 29 Nov 2003 14:03:43 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQAN4-0005kq-00
	for <classpath@gnu.org>; Sat, 29 Nov 2003 20:03:10 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQAN2-0005kT-00; Sat, 29 Nov 2003 20:03:08 +0100
Message-ID: <3FC8ED6C.1060107@kaffe.org>
Date: Sat, 29 Nov 2003 20:03:08 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <3FB673C1.6010206@kaffe.org>	
	<1068933449.925.530.camel@elsschot.wildebeest.org>	
	<3FBA7364.9060206@kaffe.org>	
	<1069190892.1745.23.camel@elsschot.wildebeest.org>	
	<3FBAC3ED.1010904@kaffe.org>	
	<1069266136.2856.42.camel@elsschot.wildebeest.org>	
	<3FC11B25.50205@kaffe.org> <1069789112.1298.22.camel@localhost>
In-Reply-To: <1069789112.1298.22.camel@localhost>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: The right way(tm) of writing toString() (Was: Re: [PATCH] Field
 position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 20:06:31 -0000

Hi Mark,

Mark Wielaard wrote:
> Hi,
> 
> On Sun, 2003-11-23 at 21:40, Dalibor Topic wrote:
> 
> 
>>2003-11-23  Dalibor Topic <robilad@kaffe.org>
>>
>>	* java/text/FieldPosition.java (equals): Fixed comment.
> 
> 
> Looks fine. Please check it in.
> 
> 
>>>It would be nice if we had something about the right way (tm) of writing
>>>the standard clone(), toString(), hashCode() and equals() in the Hackers
>>>Guide. (hint...)
>>
>>I see. I'll try to come up with something based on what I've seen on the 
>>web and Bloch's book.

here's my attempt at writing a short passage on the Art of Writing 
toString methods. As everyone has written bazillions of them, it's a 
perfect subject for bikeshed type of discussions. Feel free to chip in 
with your own bits of wisdom ;)

a) toString output should begin with the name of the class

   Rationale: When a field is declared as having an interface type, or a 
non-final class, it is useful to know the exact type of the instance.

b) the rest of the string should be braced in '[' and ']'

   Rationale: Visual separation makes it easier to separate the output 
string into its type information and information about the state of the 
particular instance.

c) different instances should have different string representations

   Rationale: If two instances are not equal, then their string 
represenation should reflect that. The contents of all fields used in 
equals() should be part of the string representation of an instance.

d) fields that are used in the string representation must be named

   Rationale: Explicitely naming fields removes ambiguities when a class 
contains several fields of the same type.

e) use '+' to concatenate strings and objects

   Rationale: Most Java compilers can optimize string concatenation by 
using string buffers. There is no need to do that task by hand. Using 
'+' allows you to write simpler code.

f) don't use toString() on non-primitive fields. Use "field_name=" + 
field instead.

   Rationale: Calling toString() can fail if a field's instance in null, 
resulting in a NullPointerException being thrown inside toString(). 
Since toString() is usually used to provide debugging information, it 
must not fail. Using '+' as explained above lets the compiler do the job 
of calling StringBuffer.append(Object) or String.valueOf(Object), that 
both can handle null automativally.

g) don't write special code to handle fields being null

   Rationale: follows from f).

Example code:

public class Test{
   private String field_1;
   private int field_2;

   public String toString() {
     return ("Test
             + "[field_1=" + field_1
             + ", field_2=" + field_2
             + ']');
   }
}

comments are welcome, as usual.

cheers,
dalibor topic

p.s. if performace of toString() doesn't matter that much, and we can 
use reflection, it would be quite simple to write a 
gnu/classpath/ToString class with a stringize method that could 
automatically create string representations conforming to above rules, 
given the interesting fields of a class.

it basically comes down to:
stringize(Field [] fields)
getClass().getName()
+ '['
+ ( for all f in fields : f.getName().toLower() + '=' + f.get()  + 
separator(", "), if necessary)

Is there some interest in that?




From MAILER-DAEMON Sat Nov 29 15:17:30 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQBX0-0005mx-AM
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 15:17:30 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQBWy-0005mg-1M
	for classpath@gnu.org; Sat, 29 Nov 2003 15:17:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQBWS-0005C4-7C
	for classpath@gnu.org; Sat, 29 Nov 2003 15:17:27 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQBWR-0005C0-WE
	for classpath@gnu.org; Sat, 29 Nov 2003 15:16:56 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AQAYh-0004yh-N9
	for classpath@gnu.org; Sat, 29 Nov 2003 14:15:11 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQAYh-0007NJ-00
	for <classpath@gnu.org>; Sat, 29 Nov 2003 20:15:11 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQAYe-0007Mb-00; Sat, 29 Nov 2003 20:15:08 +0100
Message-ID: <3FC8F03C.7080506@kaffe.org>
Date: Sat, 29 Nov 2003 20:15:08 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ito Kazumitsu <kaz@maczuka.gcd.org>
References: <1069431275.2861.580.camel@elsschot.wildebeest.org>
	<20031124225726.43635.qmail@maczuka.gcd.org>
	<1069791322.1303.41.camel@localhost>
	<20031127160147.485.qmail@maczuka.gcd.org>
In-Reply-To: <20031127160147.485.qmail@maczuka.gcd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, classpath@gnu.org, java-patches@gcc.gnu.org,
	kaffe@kaffe.org
Subject: Re: GregorianCalendar fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 20:17:28 -0000

Hi Ito,

after the discussion on the Classpath mailing list, I'd say it looks good ;)

Mark, can I check it into Classpath's CVS with an updated ChangeLog entry?

2003-11-29  Guilhem Lavaux <guilhem@kaffe.org>

  	* java/util/GregorianCalendar.java (computeTime):
  	12:00 midnight is AM and 12:00 noon is PM.

cheers,
dalibor topic

Ito Kazumitsu wrote:
> Hi,
> 
> 
>>>>>>":" == Mark Wielaard <mark@klomp.org> writes:
> 
> 
> :> Looked some more at the code and I see now that the the first change was
> :> inside a if (time >= gregorianCutover) so it now makes more sense to me.
> :> And the second change seems correct given the above remark.
> :> I'll commit it in Classpath.
> 
> There is another difference between GNU Classpath's
> java/util/GregorianCalendar.java and that of kaffe.
> 
> Kaffe's was imported from GNU Classpath and modified
> in the kaffe world, as described by the following
> ChangeLog entry.
> 
> 2003-08-16  Guilhem Lavaux <guilhem@kaffe.org>
> 
> 	* java/util/GregorianCalendar.java (computeTime):
> 	12:00 midnight is AM and 12:00 noon is PM.
> 
> Here is the patch that can be applied to Revision 1.21:
> 
> --- java/util/GregorianCalendar.java.orig	Thu Nov 27 15:35:08 2003
> +++ java/util/GregorianCalendar.java	Thu Nov 27 15:48:25 2003
> @@ -402,7 +402,11 @@
>        {
>  	hour = fields[HOUR];
>          if (isSet[AM_PM] && fields[AM_PM] == PM)
> -	  hour += 12;
> +	  if (hour != 12) /* not Noon */
> +            hour += 12;
> +	/* Fix the problem of the status of 12:00 AM (midnight). */
> +	if (isSet[AM_PM] && fields[AM_PM] == AM && hour == 12)
> +	  hour = 0;
>        }
>  
>      int minute = isSet[MINUTE] ? fields[MINUTE] : 0;




From MAILER-DAEMON Sat Nov 29 15:40:05 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQBsq-00019M-Ne
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 15:40:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQBsn-000172-8j
	for classpath@gnu.org; Sat, 29 Nov 2003 15:40:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQBsF-0000qq-W3
	for classpath@gnu.org; Sat, 29 Nov 2003 15:40:00 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQBsF-0000qg-En
	for classpath@gnu.org; Sat, 29 Nov 2003 15:39:27 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQAun-0004Go-00
	for <classpath@gnu.org>; Sat, 29 Nov 2003 20:38:01 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQAul-0004GC-00; Sat, 29 Nov 2003 20:37:59 +0100
Message-ID: <3FC8F597.5070006@kaffe.org>
Date: Sat, 29 Nov 2003 20:37:59 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Guilhem Lavaux <guilhem.lavaux@free.fr>
References: <3FC4FAA8.4040301@free.fr>
In-Reply-To: <3FC4FAA8.4040301@free.fr>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Pre-submit for serialization
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 20:40:02 -0000

Salut Guilhem,

Guilhem Lavaux wrote:
> Hi,
> 
> I think I will have to begin the split of the serialization patch at a 
> time or another. I'm beginning with this really simple patch for 
> TypeSignature.
> It is needed so class can resolved by name using a specific class loader 
> and not using a default class loader as it was the case with the 
> previous API.

Looks fine to me. Could you add some docs for 
getClassForEncoding(String, boolean, ClassLoader):

/**
  * This function is the inverse of <code>getEncodingOfClass</code>. This
  * accepts both object and descriptor formats, but must know which style
  * of string is being passed in (usually, descriptor should be true).In
  * descriptor format, "I" is treated as int.class, in object format, it
  * is treated as a class named I in the unnamed package. It also
  * accepts a <code>ClassLoader</code>, which is used to load the class.
  *
  * @param type_code the class name to decode
  * @param descriptor if the string is in descriptor format
  * @param loader the class loader used to load the class
  * @return the corresponding Class object
  * @throws ClassNotFoundException if the class cannot be located
  * @see #getEncodingOfClass(Class, boolean)
  * @see #getClassForEncoding(String, boolean)
  */

cheers,
dalibor topic

> 2003-11-26  Guilhem Lavaux <guilhem@kaffe.org>, Helmer Kraemer 
> <hkraemer@freenet.de>
> 
>     * gnu/java/lang/reflect/TypeSignature.java
>     (getClassForEncoding) Splitted the method so we can specify an 
>     explicit boot loader.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: gnu/java/lang/reflect/TypeSignature.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/gnu/java/lang/reflect/TypeSignature.java,v
> retrieving revision 1.10
> diff -u -r1.10 TypeSignature.java
> --- gnu/java/lang/reflect/TypeSignature.java	22 Mar 2002 21:25:20 -0000	1.10
> +++ gnu/java/lang/reflect/TypeSignature.java	16 Nov 2003 16:27:05 -0000
> @@ -150,6 +150,12 @@
>    public static Class getClassForEncoding(String type_code, boolean descriptor)
>      throws ClassNotFoundException
>    {
> +    return getClassForEncoding(type_code, descriptor, null);
> +  }
> +
> +  public static Class getClassForEncoding(String type_code, boolean descriptor, ClassLoader loader)
> +    throws ClassNotFoundException
> +  {
>      if (descriptor)
>        {
>          switch (type_code.charAt(0))
> @@ -181,7 +187,7 @@
>            case '[':
>            }
>        }
> -    return Class.forName(type_code.replace('/', '.'));
> +    return Class.forName(type_code.replace('/', '.'), true, loader);
>    }
>  
>    /**
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath





From MAILER-DAEMON Sat Nov 29 15:45:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQBxl-0002lZ-7b
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 15:45:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQBxh-0002i3-IY
	for classpath@gnu.org; Sat, 29 Nov 2003 15:45:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQBxB-0002LQ-HQ
	for classpath@gnu.org; Sat, 29 Nov 2003 15:45:04 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQBxB-0002KC-5X
	for classpath@gnu.org; Sat, 29 Nov 2003 15:44:33 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQAzf-0005Lp-00
	for <classpath@gnu.org>; Sat, 29 Nov 2003 20:43:03 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQAzd-0005LG-00; Sat, 29 Nov 2003 20:43:01 +0100
Message-ID: <3FC8F6C5.8080503@kaffe.org>
Date: Sat, 29 Nov 2003 20:43:01 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Guilhem Lavaux <guilhem@kaffe.org>
References: <3FC507FC.7030402@kaffe.org>
In-Reply-To: <3FC507FC.7030402@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Classpath List <classpath@gnu.org>
Subject: Re: [PATCH] Serialization #2 (set field methods)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 20:45:07 -0000

Hi Guilhem,

Guilhem Lavaux wrote:
> Hi,
> 
> This patch adds extra checking required by JDK's behaviour. If someone 
> tries to assign a field which has not the required type then an 
> InvalidClassException should be thrown.
> 
> Please review it.

The patch looks good to me. If we don't have mauve tests for the 
exceptions, it would be nice to have them.

> Cheers,
> Guilhem.
> 
> P.S.: Should I really write a documentation for each of the methods in 
> this patch ? I would think they are straightforward to understand... In 
> the other case I'll try to write something.

They are straighforward, but as the methods throw exceptions I'd prefer 
to see the boring java docs bits, too.

cheers,
dalibor topic




From MAILER-DAEMON Sat Nov 29 15:56:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQC8P-0000hk-OO
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 15:56:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQC8L-0000eI-HK
	for classpath@gnu.org; Sat, 29 Nov 2003 15:56:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQC7p-0000OJ-Ex
	for classpath@gnu.org; Sat, 29 Nov 2003 15:56:04 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQC7o-0000O0-PQ
	for classpath@gnu.org; Sat, 29 Nov 2003 15:55:33 -0500
Received: from anis.telecom.uqam.ca (anis.telecom.uqam.ca [132.208.250.6])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id hATJmFhZ013358
	for <classpath@gnu.org>; Sat, 29 Nov 2003 14:48:50 -0500 (EST)
Received: from antivirus.uqam.ca ([127.0.0.1])
	by anis.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2003112914484922111
	for <classpath@gnu.org>; Sat, 29 Nov 2003 14:48:50 -0500
Received: from localhost (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	hATJgwKB011197; Sat, 29 Nov 2003 14:42:59 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by localhost with esmtp (Exim 3.36 #1 (Debian))
	id 1AQAza-0005L8-00; Sat, 29 Nov 2003 14:42:59 -0500
Message-ID: <3FC8F6C1.5060703@uqam.ca>
Date: Sat, 29 Nov 2003 14:42:57 -0500
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.5) Gecko/20031110 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>		<1068933449.925.530.camel@elsschot.wildebeest.org>		<3FBA7364.9060206@kaffe.org>		<1069190892.1745.23.camel@elsschot.wildebeest.org>		<3FBAC3ED.1010904@kaffe.org>		<1069266136.2856.42.camel@elsschot.wildebeest.org>		<3FC11B25.50205@kaffe.org>
	<1069789112.1298.22.camel@localhost> <3FC8ED6C.1060107@kaffe.org>
In-Reply-To: <3FC8ED6C.1060107@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: The right way(tm) of writing toString() (Was: Re: [PATCH] Field
 position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2003 20:56:07 -0000

Dalibor Topic wrote:
> e) use '+' to concatenate strings and objects
> 
>   Rationale: Most Java compilers can optimize string concatenation by 
> using string buffers. There is no need to do that task by hand. Using 
> '+' allows you to write simpler code.


I partly disagree.  When you iterate through a collection, using "+" will
create one stringbuffer per iteration => bad.

So, I would in fact recommend using stringbuffers everywhere, unless the
toString() body holds on a single source line.

> f) don't use toString() on non-primitive fields. Use "field_name=" + 
> field instead.

or
  sb.append("field_name=");
  sb.append(field);

> g) don't write special code to handle fields being null

I think it also works for sb.append().


> Example code:
> 
> public class Test{
>   private String field_1;
>   private int field_2;
> 
>   public String toString() {
>     return ("Test
>             + "[field_1=" + field_1
>             + ", field_2=" + field_2
>             + ']');

This is a "logical" single line, so it fits the non-StringBuffer thing.  But,
this does not work for LinkedList.toString(), for example.

Etienne

> p.s. if performace of toString() doesn't matter that much, and we can 
> use reflection

No, please!  We want toString to be fast.  It is part of the base functionality
of Object(), so there is no reason to assume programmers will only use it for
debugging.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/




From MAILER-DAEMON Sat Nov 29 19:34:10 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQFXM-0003xY-FG
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 19:34:08 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQFXI-0003ub-Vo
	for classpath@gnu.org; Sat, 29 Nov 2003 19:34:04 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQFWm-0003nH-2G
	for classpath@gnu.org; Sat, 29 Nov 2003 19:34:03 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQFWl-0003my-EA
	for classpath@gnu.org; Sat, 29 Nov 2003 19:33:31 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hATNX8SX041287;
	Sun, 30 Nov 2003 00:33:09 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311292333.hATNX8SX041287@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>, classpath@gnu.org
Date: Sun, 30 Nov 2003 00:33:08 +0100
X-Mailer: KMail [version 1.3]
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
In-Reply-To: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: 
Subject: Re: [Little Off Topic] Revolution is on ;)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 00:34:06 -0000

On Saturday 29 November 2003 13:48, Arnaud Vandyck wrote:

> Why don't you try to make a keynote at the JavaPolis (maybe next year)
in the Open Source hall.

I'd love to. And the topic would be something like
  Java is not a proprietary language: and here's the proof:
  Classpath, IKVM, Jaos, Kaffe, Wonka, ...

However, frankly I suspect that the JavaPolis agenda is set by their 
sponsors, and that some of these would not want to hear such a talk. So let's 
by all means propose a paper or two for next year (like I already did this 
year) _and then_ if it is refused, just convene our own alternative 
conference at a nearby location.

In the meantime, is there anything planned for FOSDEM?  E.g., an open-source 
Java track? This could be an opportunity the thesis that the future of Java 
lies with us, not with S*n.

Up the workers,
 
-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Sat Nov 29 22:45:04 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQIW8-0008RE-EZ
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 22:45:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQIW6-0008Qw-81
	for classpath@gnu.org; Sat, 29 Nov 2003 22:45:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQIVa-0008Ls-Dl
	for classpath@gnu.org; Sat, 29 Nov 2003 22:45:01 -0500
Received: from [132.208.28.196] (helo=gadek.homelinux.org)
	by monty-python.gnu.org with esmtp (TLSv1:RC4-SHA:128) (Exim 4.24)
	id 1AQIVa-0008Lp-3E
	for classpath@gnu.org; Sat, 29 Nov 2003 22:44:30 -0500
Received: from localhost ([127.0.0.1])
	by gadek.homelinux.org with esmtp (Exim 4.24)
	id 1AQHY2-0007qy-8X; Sat, 29 Nov 2003 21:42:58 -0500
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: Mark Wielaard <mark@klomp.org>
In-Reply-To: <1069933901.27173.14.camel@elsschot.wildebeest.org>
References: <1069933901.27173.14.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=iso-8859-2
Organization: Debian GNU/Linux http://www.debian.org
Message-Id: <1070160175.13760.347.camel@gadek.homelinux.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 29 Nov 2003 21:42:57 -0500
Content-Transfer-Encoding: quoted-printable
Cc: classpath@gnu.org
Subject: Re: Compiling on Windows like systems
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 03:45:02 -0000

W li=B6cie z czw, 27-11-2003, godz. 06:51, Mark Wielaard pisze:=20
> Hi,
>=20
> configure.in had the following macro definitions:
>  AC_CYGWIN
>  AC_MINGW32
>=20
> The Autoconf manual says they are deprecated and all autotools complain
> loudly about their usage. Since I couldn't find a real reason for using
> them I just removed them for now. Do we actually have people compiling
> Classpath (native libraries) on those systems? Could they check what
> breaks for them?

I'll be fighting with Classpath on Cygwin this monday. So far the
problem I saw was that cygwin by default compiles static versions while
I need shared libs to be able to use them with SableVM.

These macros look outdated though. I think you can safely remove them.

I didn't need them to compile SableVM under cygwin. I only added
AC_LIBTOOL_WIN32_DLL (which - according to the discussions I found
- shouldn't be needed either) and "-no-undefined" for libtool.

Once we have SableVM (and Classpath) Cygwin port finished - it should be
easy to find out (=3Ddiff) what's actually needed to make it work
smoothly...

Feel free to remind me around january if I forgot.

Cheers,

				Grzegorz B. Prokopski

--=20
Grzegorz B. Prokopski <gadek@debian.org>
Debian GNU/Linux      http://www.debian.org
SableVM - LGPLed JVM  http://www.sablevm.org




From MAILER-DAEMON Sat Nov 29 22:51:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQIc0-0001Kd-Df
	for mharc-classpath@gnu.org; Sat, 29 Nov 2003 22:51:08 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQIby-0001KW-FU
	for classpath@gnu.org; Sat, 29 Nov 2003 22:51:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQIbS-0001ER-Ly
	for classpath@gnu.org; Sat, 29 Nov 2003 22:51:05 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQIbS-0001EO-8K
	for classpath@gnu.org; Sat, 29 Nov 2003 22:50:34 -0500
Received: (qmail 2088 invoked by uid 504); 30 Nov 2003 03:49:07 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.644405 secs); 30 Nov 2003 02:49:07 -0000
Received: from unknown (HELO localhost) ([139.165.201.107])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 30 Nov 2003 03:49:06 +0100
Date: Sun, 30 Nov 2003 03:48:47 +0100 (CET)
Message-Id: <20031130.034847.06497256.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
In-Reply-To: <200311292333.hATNX8SX041287@pigsty.cats.cradle>
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Sun_Nov_30_03_48_47_2003_159)--"
Content-Transfer-Encoding: 7bit
Subject: Re: [Little Off Topic] Revolution is on ;)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 03:51:07 -0000

----Security_Multipart(Sun_Nov_30_03_48_47_2003_159)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Sun, 30 Nov 2003 00:33:08 +0100
Chris Gray <chris@kiffer.eunet.be> wrote:

> However, frankly I suspect that the JavaPolis agenda is set by their 
> sponsors, and that some of these would not want to hear such a talk.

See the subject :-D

> So let's  by all means propose a paper or two for next year (like I
> already did this  year) _and then_ if it is refused, just convene our
> own alternative  conference at a nearby location.

Not a bad idea but I don't think it could be interresting. I prefer the
idea we meet all together at some freesoftware meetings

> In the meantime, is there anything planned for FOSDEM?  E.g., an
> open-source  Java track? This could be an opportunity the thesis that
> the future of Java  lies with us, not with S*n.

Of course! ;) And I suppose everyone will try to be there! ;)

http://www.fosdem.org/2004/index/speakers/speakers_tromey

GCJ

Tom Tromey has worked on many free software projects over the years. He
wrote GNU Automake, and these days is the libgcj maintainer.  He is an
engineer for Red Hat and lives in Boulder, Colorado.

GCJ is a free Java front end for EGCS. It can natively compile both Java
source and bytecode files. This new front end is integrated into the
EGCS project. The goal of the gcj project is to provide a complete free
software Java system, centered around an ahead-of-time compiler.

This talk will explain gcj's "radically traditional" view of the Java
programming language, and will cover the difficulties inherent in Java
precompilation.

	Website 	http://gcc.gnu.org/java/
	Contact 	tromey (at) redhat com

Also, maybe we can set a little JB party for the 0.07 release :-D

Cheers,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Sun_Nov_30_03_48_47_2003_159)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yVqS4vzFZu62tMIRAsgoAKCf3wh9rM/wGuJ9VjU6E7U2XgMZmgCdHpdn
yeCv4Y597NsYSgfnSwNpnWs=
=qRJr
-----END PGP SIGNATURE-----

----Security_Multipart(Sun_Nov_30_03_48_47_2003_159)----



From MAILER-DAEMON Sun Nov 30 01:56:08 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQLV1-0006YY-NL
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 01:56:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQLUz-0006Wr-Lz
	for classpath@gnu.org; Sun, 30 Nov 2003 01:56:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQLUT-0006I3-W8
	for classpath@gnu.org; Sun, 30 Nov 2003 01:56:04 -0500
Received: from [151.164.30.28] (helo=mta4.rcsntx.swbell.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQLUS-0006Hr-DH
	for classpath@gnu.org; Sun, 30 Nov 2003 01:55:32 -0500
Received: from bothner.com (adsl-216-102-199-253.dsl.snfc21.pacbell.net
	[216.102.199.253])
	by mta4.rcsntx.swbell.net (8.12.10/8.12.10) with ESMTP id
	hAU5s5m6011467; Sat, 29 Nov 2003 23:54:06 -0600 (CST)
Message-ID: <3FC98607.9040705@bothner.com>
Date: Sat, 29 Nov 2003 21:54:15 -0800
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
	<20031130.034847.06497256.arnaud.vandyck@ulg.ac.be>
In-Reply-To: <20031130.034847.06497256.arnaud.vandyck@ulg.ac.be>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: [Little Off Topic] Revolution is on ;)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 06:56:06 -0000

Arnaud Vandyck wrote:

> Tom Tromey ....
> GCJ is a free Java front end for EGCS.
 > This new front end is integrated into the EGCS project.

EGCS?  New front end?
Tom, you're living in the past ...
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/





From MAILER-DAEMON Sun Nov 30 11:52:04 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQUnk-0005WE-7D
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 11:52:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQUni-0005W8-4U
	for classpath@gnu.org; Sun, 30 Nov 2003 11:52:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQUnB-0005K4-7Z
	for classpath@gnu.org; Sun, 30 Nov 2003 11:52:01 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQUnA-0005K1-OA
	for classpath@gnu.org; Sun, 30 Nov 2003 11:51:28 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AQTpA-00083I-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 16:49:28 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1NC7Yl4L05EtvLAv0+10"
Message-Id: <1070207401.1309.126.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 30 Nov 2003 16:50:01 +0100
Subject: Generating API doc with gjdoc/libxmlj and gcj
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 16:52:02 -0000


--=-1NC7Yl4L05EtvLAv0+10
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

Before creating the actual 0.07 release I wanted to make sure that we
could generate API documentation. This is disabled by default since
creating a working gjdoc is non-trivial and the generation of a full
tree takes more then one and half hour (at least on my 1.4 Ghz Athlon)
and takes 150+ MB of memory. At least 25MB of tmp storage and at least
twice so much in your obj build dir.

Since this took (again) much more time then it should have I want to
make sure that I write down the steps that I had to do to make it work
again.

You need gcj 3.3.2 (or higher).
gjdoc CVS :pserver:anoncvs@subversions.gnu.org:/cvsroot/cp-tools
module gjdoc.
libxmlj CVS :pserver:anoncvs@subversions.gnu.org:/cvsroot/classpathx
module libxmlj.

libxmlj should compile and install out of the box by typing:
make && make install

For gjdoc add at the start of gnu/classpath/tools/gjdoc/Main.java
(main):

  System.setProperty("javax.xml.transform.TransformerFactory",
            "gnu.xml.libxmlj.transform.TransformerFactoryImpl");

There is a ant build.xml file, but I compiled it all by hand together
with the external/jaxp/source files from Classpath which I just copied
in the src direcrory as follows:

  find * -name \*.java | xargs gcj -O2 -g -o gjdoc \
  --main=3Dgnu.classpath.tools.gjdoc.Main

Then I created a simple gjdoc script and put it on my PATH:

  #!/bin/sh
  CLASSPATH=3D/home/mark/src/libxmlj:/home/mark/src/gjdoc/src/resources \
  LD_LIBRARY_PATH=3D/usr/local/libxmlj/lib \
  /home/mark/src/gjdoc/src/gjdoc $*

Now you can configure classpah with --enable-gjdoc.
Then typing make and go get yourself some coffe, take a shower and do
some work in the garden.

There is one catch. The above setup is completely broken for some HTML
entities (see [bugs #4823] HTML entities such as auml and nbsp should be
put back in the API doc). So if you have  spectacular and mysterious
crashes then make sure that your java source files don't contain such
entities (for 0.07 I have taken them out).

Cheers,

Mark

--=-1NC7Yl4L05EtvLAv0+10
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yhGoxVhZCJWr9QwRAg71AJsGgux2YkZMcivvqQhcZx236a90kwCfZNfb
MNKqo1ajrl+lwUAyXxxPUnQ=
=M5RD
-----END PGP SIGNATURE-----

--=-1NC7Yl4L05EtvLAv0+10--




From MAILER-DAEMON Sun Nov 30 12:27:53 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQVMO-0006Rg-VC
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 12:27:52 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQVMK-0006PT-Ev
	for classpath@gnu.org; Sun, 30 Nov 2003 12:27:48 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQVLn-0006EV-OM
	for classpath@gnu.org; Sun, 30 Nov 2003 12:27:46 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQVLn-0006E8-4h
	for classpath@gnu.org; Sun, 30 Nov 2003 12:27:15 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQUOI-0003V2-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 17:25:46 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQUOE-0003S3-00; Sun, 30 Nov 2003 17:25:42 +0100
Message-ID: <3FCA1A05.6070808@kaffe.org>
Date: Sun, 30 Nov 2003 17:25:41 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <3FB673C1.6010206@kaffe.org>		<1068933449.925.530.camel@elsschot.wildebeest.org>		<3FBA7364.9060206@kaffe.org>		<1069190892.1745.23.camel@elsschot.wildebeest.org>		<3FBAC3ED.1010904@kaffe.org>		<1069266136.2856.42.camel@elsschot.wildebeest.org>		<3FC11B25.50205@kaffe.org>
	<1069789112.1298.22.camel@localhost>
	<3FC8ED6C.1060107@kaffe.org> <3FC8F6C1.5060703@uqam.ca>
In-Reply-To: <3FC8F6C1.5060703@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: 2nd attempt at Re: The right way(tm) of writing toString() (Was:
 Re: [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 17:27:49 -0000

Salut Etienne,

Etienne Gagnon wrote:
> Dalibor Topic wrote:
> 
>> e) use '+' to concatenate strings and objects
>>
>>   Rationale: Most Java compilers can optimize string concatenation by 
>> using string buffers. There is no need to do that task by hand. Using 
>> '+' allows you to write simpler code.
> 
> 
> 
> I partly disagree.  When you iterate through a collection, using "+" will
> create one stringbuffer per iteration => bad.
> 
> So, I would in fact recommend using stringbuffers everywhere, unless the
> toString() body holds on a single source line.

Thanks for pointing that out, I had forgot that.

>> f) don't use toString() on non-primitive fields. Use "field_name=" + 
>> field instead.
> 
> 
> or
>  sb.append("field_name=");
>  sb.append(field);

yep.

>> g) don't write special code to handle fields being null
> 
> 
> I think it also works for sb.append().

yes, it does.

>> Example code:
>>
>> public class Test{
>>   private String field_1;
>>   private int field_2;
>>
>>   public String toString() {
>>     return ("Test
>>             + "[field_1=" + field_1
>>             + ", field_2=" + field_2
>>             + ']');
> 
> 
> This is a "logical" single line, so it fits the non-StringBuffer thing.  
> But,
> this does not work for LinkedList.toString(), for example.
> 
> Etienne
> 
>> p.s. if performace of toString() doesn't matter that much, and we can 
>> use reflection
> 
> 
> No, please!  We want toString to be fast.  It is part of the base 
> functionality
> of Object(), so there is no reason to assume programmers will only use 
> it for
> debugging.

O.K., then I'll attempt to write down how to make toString() fast with 
StringBuffers.

so here's the updated version:

a) toString output should begin with the name of the class

   Rationale: When a field is declared as having an interface type, or a 
non-final class, it is useful to know the exact type of the instance.

b) the rest of the string should be braced in '[' and ']'

   Rationale: Visual separation makes it easier to separate the output 
string into its type information and information about the state of the 
particular instance.

c) different instances should have different string representations

   Rationale: If two instances are not equal, then their string 
represenation should reflect that. The contents of all fields used in 
equals() should be part of the string representation of an instance.

d) fields that are used in the string representation must be named

   Rationale: Explicitely naming fields removes ambiguities when a class 
contains several fields of the same type.

e) always use a StringBuffer

   Rationale: While most Java compilers can optimize string 
concatenation by using string buffers automatically, that only works 
efficiently as long as the string representation can be generated within 
a single expression. If that's not the case, for example when iterating 
over a collection, most Java compilers create unnecessary temporary 
objects. Using a StringBuffer ensures that toString() works efficiently.

f) don't use toString() on non-primitive fields

   Rationale: Calling toString() can fail if a field's instance in null, 
resulting in a NullPointerException being thrown inside toString(). 
Since toString() is usually used to provide debugging information, it 
must not fail. Using StringBuffer.append(Object) handles null 
automatically. So simply use StringBuffer's append method for 
"field_name=" and the field instance.

g) don't write special code to handle fields being null

   Rationale: follows from f).

h) re-use the StringBuffer on the stack

   Rationale: In order to write as efficient code using StringBuffer as 
the good Java compilers, we need to reuse the StringBuffer instance on 
the stack. So instead of writing multiple append statements, try to use 
a single statement to perform all the work on the StringBuffer instance, 
including creation, calling append, and calling toString() on it.

Example code:

public class Test{
   private String field_1;
   private int field_2;

   public String toString() {
     return
	(new StringBuffer("Test[field_1=")).append(field_1)
	.append(",field_2=").append(field_2)
	.append(']')
	.toString();
   }
}

comments are welcome, as usual.

cheers,
dalibor topic




From MAILER-DAEMON Sun Nov 30 12:45:19 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQVd5-00011k-Hr
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 12:45:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQVWI-0006AA-5L
	for classpath@gnu.org; Sun, 30 Nov 2003 12:38:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQVVh-0005No-NX
	for classpath@gnu.org; Sun, 30 Nov 2003 12:38:01 -0500
Received: from [141.45.32.5] (helo=threejane.lichteblau.com)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AQVVe-0005JX-LJ
	for classpath@gnu.org; Sun, 30 Nov 2003 12:37:26 -0500
Received: (qmail 28438 invoked by uid 1000); 30 Nov 2003 16:35:51 -0000
Date: Sun, 30 Nov 2003 17:35:51 +0100
From: David Lichteblau <david@lichteblau.com>
To: GNU Classpath <classpath@gnu.org>
Message-ID: <20031130163550.GA25372@lichteblau.com>
References: <1068933449.925.530.camel@elsschot.wildebeest.org>
	<3FBA7364.9060206@kaffe.org>
	<1069190892.1745.23.camel@elsschot.wildebeest.org>
	<3FBAC3ED.1010904@kaffe.org>
	<1069266136.2856.42.camel@elsschot.wildebeest.org>
	<3FC11B25.50205@kaffe.org> <1069789112.1298.22.camel@localhost>
	<3FC8ED6C.1060107@kaffe.org> <3FC8F6C1.5060703@uqam.ca>
	<3FCA1A05.6070808@kaffe.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb"
Content-Disposition: inline
In-Reply-To: <3FCA1A05.6070808@kaffe.org>
User-Agent: Mutt/1.3.28i
X-Mailman-Approved-At: Sun, 30 Nov 2003 12:45:06 -0500
Subject: Re: 2nd attempt at Re: The right way(tm) of writing toString()
	(Was: Re: [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 17:38:08 -0000


--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Quoting Dalibor Topic (robilad@kaffe.org):
> h) re-use the StringBuffer on the stack
>=20
>   Rationale: In order to write as efficient code using StringBuffer as=20
> the good Java compilers, we need to reuse the StringBuffer instance on=20
> the stack. So instead of writing multiple append statements, try to use=
=20
> a single statement to perform all the work on the StringBuffer instance,=
=20
> including creation, calling append, and calling toString() on it.

That would only help with interpreters, right?  Nothing a good JIT does
not handle for you.

--VS++wcV0S1rZb1Fb
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/yhxliGoiD4YyHUgRAnptAJ9WFd0jujV26ZvDikTYTQ6KOQt10ACfY2U4
p1/j7nBM303QqoUi8/WOyYE=
=3hBj
-----END PGP SIGNATURE-----

--VS++wcV0S1rZb1Fb--



From MAILER-DAEMON Sun Nov 30 13:15:41 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQW6e-0001eN-Ij
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 13:15:40 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQW6c-0001cn-2q
	for classpath@gnu.org; Sun, 30 Nov 2003 13:15:38 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQW60-0001WM-40
	for classpath@gnu.org; Sun, 30 Nov 2003 13:15:32 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQW5z-0001UY-Fz
	for classpath@gnu.org; Sun, 30 Nov 2003 13:14:59 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQV8X-00081L-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 18:13:33 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQV8V-00080T-00; Sun, 30 Nov 2003 18:13:31 +0100
Message-ID: <3FCA253A.1010502@kaffe.org>
Date: Sun, 30 Nov 2003 18:13:30 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: David Lichteblau <david@lichteblau.com>
References: <1068933449.925.530.camel@elsschot.wildebeest.org>	<3FBA7364.9060206@kaffe.org>	<1069190892.1745.23.camel@elsschot.wildebeest.org>	<3FBAC3ED.1010904@kaffe.org>	<1069266136.2856.42.camel@elsschot.wildebeest.org>	<3FC11B25.50205@kaffe.org>
	<1069789112.1298.22.camel@localhost>	<3FC8ED6C.1060107@kaffe.org>
	<3FC8F6C1.5060703@uqam.ca>	<3FCA1A05.6070808@kaffe.org>
	<20031130163550.GA25372@lichteblau.com>
In-Reply-To: <20031130163550.GA25372@lichteblau.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: 2nd attempt at Re: The right way(tm) of writing toString()	(Was:
 Re: [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 18:15:39 -0000

Hi David,

David Lichteblau wrote:
> Quoting Dalibor Topic (robilad@kaffe.org):
> 
>>h) re-use the StringBuffer on the stack
>>
>>  Rationale: In order to write as efficient code using StringBuffer as 
>>the good Java compilers, we need to reuse the StringBuffer instance on 
>>the stack. So instead of writing multiple append statements, try to use 
>>a single statement to perform all the work on the StringBuffer instance, 
>>including creation, calling append, and calling toString() on it.
> 
> 
> That would only help with interpreters, right?  Nothing a good JIT does
> not handle for you.

I doubt that it only helps with interpreters. I'd assume that it also 
helps with kaffe's JIT, for example. But every little bit helps ;)

Basically, you want to have a JIT that rewrites

   sb.append("something");
   sb.append("else");

into

   sb.append("something").append("else");

In order to do that, the JIT would have to infer that 
StringBuffer.append(*) *always* returns a reference to the same string 
buffer instance it was invoked upon in that code path.

as in :

[sb on stack]
[call append]
[hey, that's sb on stack again, cool!]

Which means you either hardcode the optimisation into the JIT (which is 
possible since StringBuffer is a final class), or do some bytecode 
analysis on side-effects of StringBuffer.append() (i.e. does it return 
'this' on all code paths). I don't know how hard the second approach is.

In any case, the question is: can we assume that VMs using GNU Classpath 
have good JITs? I think the answer is 'No', despite the great 
performance of some VMs using GNU Classpath. Some VMs using GNU 
Classpath have no JITs, some have JITs that aren't state-of-the-art.

On a side note, I would have loved to assume that VMs using GNU 
Classpath have fast reflection implementations, which would have allowed 
me to use the generic, reflection based method outlined in the first 
proposal. But being a project that's used by multiple VMs, I think GNU 
Classpath has to care about the lowest common denominator. Which means I 
can't assume that some bytecode optimizer will take care of performance 
of my code ;)

cheers,
dalibor topic




From MAILER-DAEMON Sun Nov 30 13:56:30 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQWk9-0006wx-P4
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 13:56:29 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQWk6-0006vy-Or
	for classpath@gnu.org; Sun, 30 Nov 2003 13:56:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQWja-0006oz-Bt
	for classpath@gnu.org; Sun, 30 Nov 2003 13:56:25 -0500
Received: from [141.45.32.5] (helo=threejane.lichteblau.com)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AQWjZ-0006ok-R8
	for classpath@gnu.org; Sun, 30 Nov 2003 13:55:53 -0500
Received: (qmail 28587 invoked by uid 1000); 30 Nov 2003 17:54:27 -0000
Date: Sun, 30 Nov 2003 18:54:26 +0100
From: David Lichteblau <dave-cp@lichteblau.com>
To: Dalibor Topic <robilad@kaffe.org>
Message-ID: <20031130175426.GB25372@lichteblau.com>
References: <1069190892.1745.23.camel@elsschot.wildebeest.org>
	<3FBAC3ED.1010904@kaffe.org>
	<1069266136.2856.42.camel@elsschot.wildebeest.org>
	<3FC11B25.50205@kaffe.org> <1069789112.1298.22.camel@localhost>
	<3FC8ED6C.1060107@kaffe.org> <3FC8F6C1.5060703@uqam.ca>
	<3FCA1A05.6070808@kaffe.org>
	<20031130163550.GA25372@lichteblau.com>
	<3FCA253A.1010502@kaffe.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0"
Content-Disposition: inline
In-Reply-To: <3FCA253A.1010502@kaffe.org>
User-Agent: Mutt/1.3.28i
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: 2nd attempt at Re: The right way(tm) of writing
	toString()	(Was: Re: [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 18:56:27 -0000


--LyciRD1jyfeSSjG0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Quoting Dalibor Topic (robilad@kaffe.org):
> I doubt that it only helps with interpreters. I'd assume that it also=20
> helps with kaffe's JIT, for example. But every little bit helps ;)

Fair enough.  I will have to learn about kaffe's JIT then.

> Basically, you want to have a JIT that rewrites
>=20
>   sb.append("something");
>   sb.append("else");
>=20
> into
>=20
>   sb.append("something").append("else");

More precisely, a JIT that compiles both forms into machine code of
similar performance, where the difference is probably a load of `sb'
from memory for each method invocation.

(A sufficiently smart compiler might do what you are describing, but
that sounds a little unrealistic to me, too.)

> In any case, the question is: can we assume that VMs using GNU Classpath=
=20
> have good JITs? I think the answer is 'No', despite the great=20

Well, I guess that was my question.


Thanks,
David

--LyciRD1jyfeSSjG0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/yi7RiGoiD4YyHUgRAiecAJ9M+B24pydiCTgsXVcGP4Hb6mPgRgCeOHe6
rUXrV3ocRU9oBWvUhP7jeDE=
=JzqW
-----END PGP SIGNATURE-----

--LyciRD1jyfeSSjG0--



From MAILER-DAEMON Sun Nov 30 14:05:28 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQWsq-0001Bw-Nz
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 14:05:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQWsn-0001AK-TJ
	for classpath@gnu.org; Sun, 30 Nov 2003 14:05:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQWsH-0000xE-PH
	for classpath@gnu.org; Sun, 30 Nov 2003 14:05:24 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQWp9-0008HG-6J
	for classpath@gnu.org; Sun, 30 Nov 2003 14:01:39 -0500
Received: from anis.telecom.uqam.ca (anis.telecom.uqam.ca [132.208.250.6])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id hAUHtJh3014993
	for <classpath@gnu.org>; Sun, 30 Nov 2003 12:55:54 -0500 (EST)
Received: from antivirus.uqam.ca ([127.0.0.1])
	by anis.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2003113012555400127
	for <classpath@gnu.org>; Sun, 30 Nov 2003 12:55:54 -0500
Received: from localhost (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	hAUHnWKB028145; Sun, 30 Nov 2003 12:49:32 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by localhost with esmtp (Exim 3.36 #1 (Debian))
	id 1AQVhN-0003H5-00; Sun, 30 Nov 2003 12:49:33 -0500
Message-ID: <3FCA2DAA.2@uqam.ca>
Date: Sun, 30 Nov 2003 12:49:30 -0500
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.5) Gecko/20031110 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <3FB673C1.6010206@kaffe.org>		<1068933449.925.530.camel@elsschot.wildebeest.org>		<3FBA7364.9060206@kaffe.org>		<1069190892.1745.23.camel@elsschot.wildebeest.org>		<3FBAC3ED.1010904@kaffe.org>		<1069266136.2856.42.camel@elsschot.wildebeest.org>		<3FC11B25.50205@kaffe.org>
	<1069789112.1298.22.camel@localhost>
	<3FC8ED6C.1060107@kaffe.org> <3FC8F6C1.5060703@uqam.ca>
	<3FCA1A05.6070808@kaffe.org>
In-Reply-To: <3FCA1A05.6070808@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: 2nd attempt at Re: The right way(tm) of writing toString() (Was:
 Re: [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 19:05:26 -0000

Hi Dalibor,

I would drop h) altogether.

Rationale: while a "naive" Java compiler would produce a series of iload
instructions, for reusing a local variable, an optimizing compiler or a jit
would completely remove this.  So, yes, the code that reuse a local could be
a little slower on a interpreter (I am sure that on sablevm this would be
negligible as iload is a very cheap operation), but good software engineering
is the goal here.

Not only do I personally find the following more readable, but it is also
easier to debug, as a debugger would trace through the instructions one by one:

public String toString()
{
   StringBuffer sb = StringBuffer();

   sb.append("Test[field_1=");
   sb.append(field_1);
   sb.append(",field_2=");
   sb.append(field_2);
   sb.append("]");

   return sb.toString();
}

The performance difference (except on "naive" interpreters) is negligible.

Note about performance:  The reason iload is expensive on naive interpreters,
is the cost of dispatching an additional instruction in the interpreter.
SableVM's inline-threaded engine does eliminate dispatch between successive
instructions of a basic block, so the cost of an additional iload is simply
that of the "iload" functionality, not that of (iload + dispatch) as found
in normal switch-based interpreters and direct-threaded interpreters.

So, in summary: it is best to leave such low-level optimizations in the hand
of the compiler, not of the developer.  The developer should instead care about
code readability and debuggability (i.e. software engineering issues).

Etienne

Dalibor Topic wrote:
> h) re-use the StringBuffer on the stack
> 
>   Rationale: In order to write as efficient code using StringBuffer as 
> the good Java compilers, we need to reuse the StringBuffer instance on 
> the stack. So instead of writing multiple append statements, try to use 
> a single statement to perform all the work on the StringBuffer instance, 
> including creation, calling append, and calling toString() on it.
> 
> Example code:
> 
> public class Test{
>   private String field_1;
>   private int field_2;
> 
>   public String toString() {
>     return
>     (new StringBuffer("Test[field_1=")).append(field_1)
>     .append(",field_2=").append(field_2)
>     .append(']')
>     .toString();
>   }
> }
> 
> comments are welcome, as usual.
> 
> cheers,
> dalibor topic
> 
> 
> 


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/




From MAILER-DAEMON Sun Nov 30 14:25:56 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQXCd-0003nA-HF
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 14:25:55 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQXCZ-0003lA-TH
	for classpath@gnu.org; Sun, 30 Nov 2003 14:25:51 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQXC2-0003bC-9Y
	for classpath@gnu.org; Sun, 30 Nov 2003 14:25:50 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQXC1-0003ax-Pi
	for classpath@gnu.org; Sun, 30 Nov 2003 14:25:17 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AQVMp-0008IM-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 18:28:19 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-LhrxmJsQj18v+WdQD43J"
Message-Id: <1070213332.1310.148.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 30 Nov 2003 18:28:52 +0100
Subject: GNU Classpath 0.07 created
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 19:25:53 -0000


--=-LhrxmJsQj18v+WdQD43J
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

It is done. 0.07 has been tagged and created. Find it at:
http://www.klomp.org/mark/classpath/

As soon as we can get this up at ftp.gnu.org or alpha.gnu.org I will
make a real announcement.

gjdoc generated API documentation for this release can be found at:
http://www.klomp.org/mark/classpath/doc/api/html/

Thanks everybody. The progress since 0.06 (just three months ago!) has
been enormous again (see the NEWS file and the 250+ ChangeLog entries).
And apologies to everyone that had outstanding patches that didn't make
it for this release. Rest assured that those patches will be used for
making the next 0.08 release (again in three months) even more perfect
then 0.07 already is!

Cheers,

Mark

--=-LhrxmJsQj18v+WdQD43J
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yijTxVhZCJWr9QwRAgcaAJ9/hu8tOobJlq5RzXyUNTSIp3c6dACfVBpv
f1mWWSNSDa5xrAfKNMdngwk=
=c9x4
-----END PGP SIGNATURE-----

--=-LhrxmJsQj18v+WdQD43J--




From MAILER-DAEMON Sun Nov 30 14:29:13 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQXA5-0003NA-2e
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 14:23:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQX9m-0003LI-FZ
	for classpath@gnu.org; Sun, 30 Nov 2003 14:22:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQX9B-0003A8-IP
	for classpath@gnu.org; Sun, 30 Nov 2003 14:22:53 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQX9A-00039e-FQ
	for classpath@gnu.org; Sun, 30 Nov 2003 14:22:20 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQWBi-0008Th-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 19:20:54 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQWBe-0008Sj-00; Sun, 30 Nov 2003 19:20:50 +0100
Message-ID: <3FCA3502.9080104@kaffe.org>
Date: Sun, 30 Nov 2003 19:20:50 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <3FB673C1.6010206@kaffe.org>		<1068933449.925.530.camel@elsschot.wildebeest.org>		<3FBA7364.9060206@kaffe.org>		<1069190892.1745.23.camel@elsschot.wildebeest.org>		<3FBAC3ED.1010904@kaffe.org>		<1069266136.2856.42.camel@elsschot.wildebeest.org>		<3FC11B25.50205@kaffe.org>
	<1069789112.1298.22.camel@localhost>
	<3FC8ED6C.1060107@kaffe.org> <3FC8F6C1.5060703@uqam.ca>
	<3FCA1A05.6070808@kaffe.org> <3FCA2DAA.2@uqam.ca>
In-Reply-To: <3FCA2DAA.2@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: 3d attempt at Re: The right way(tm) of writing toString() (Was: Re:
 [PATCH] Field position attribute handling)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 19:23:02 -0000

Salut Etienne,

Etienne Gagnon wrote:
> Hi Dalibor,
> 
> I would drop h) altogether.

O.K.,o.k., so be it. ;)

> Rationale: while a "naive" Java compiler would produce a series of iload
> instructions, for reusing a local variable, an optimizing compiler or a jit
> would completely remove this.  So, yes, the code that reuse a local 
> could be
> a little slower on a interpreter (I am sure that on sablevm this would be
> negligible as iload is a very cheap operation), but good software 
> engineering
> is the goal here.

Here's the latest version:

a) toString output should begin with the name of the class

   Rationale: When a field is declared as having an interface type, or a 
non-final class, it is useful to know the exact type of the instance.

b) the rest of the string should be braced in '[' and ']'

   Rationale: Visual separation makes it easier to separate the output 
string into its type information and information about the state of the 
particular instance.

c) different instances should have different string representations

   Rationale: If two instances are not equal, then their string 
represenation should reflect that. The contents of all fields used in 
equals() should be part of the string representation of an instance.

d) fields that are used in the string representation must be named

   Rationale: Explicitely naming fields removes ambiguities when a class 
contains several fields of the same type.

e) always use a StringBuffer

   Rationale: While most Java compilers can optimize string 
concatenation by using string buffers automatically, that only works 
efficiently as long as the string representation can be generated within 
a single expression. If that's not the case, for example when iterating 
over a collection, most Java compilers create unnecessary temporary 
objects. Using a StringBuffer ensures that toString() works efficiently.

f) don't use toString() on non-primitive fields

   Rationale: Calling toString() can fail if a field's instance in null, 
resulting in a NullPointerException being thrown inside toString(). 
Since toString() is usually used to provide debugging information, it 
must not fail. Using StringBuffer.append(Object) handles null 
automatically. So simply use StringBuffer's append method for 
"field_name=" and the field instance.

g) don't write special code to handle fields being null

   Rationale: follows from f).

Example code:

public class Test{
   private String field_1;
   private int field_2;

   public String toString() {
     StringBuffer sb = new StringBuffer("Test[field_1="));

     sb.append(field_1);
     sb.append(",field_2=");
     sb.append(field_2);
     sb.append(']');

     return sb.toString();
   }
}

comments are welcome, as usual.

cheers,
dalibor topic




From MAILER-DAEMON Sun Nov 30 14:44:57 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQXV3-0003lE-JL
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 14:44:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQXV1-0003jA-8Q
	for classpath@gnu.org; Sun, 30 Nov 2003 14:44:55 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQXUS-0003HB-SH
	for classpath@gnu.org; Sun, 30 Nov 2003 14:44:52 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQXUS-0003DV-FV
	for classpath@gnu.org; Sun, 30 Nov 2003 14:44:20 -0500
Received: (qmail 7497 invoked by uid 504); 30 Nov 2003 19:42:49 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.610861 secs); 30 Nov 2003 18:42:49 -0000
Received: from unknown (HELO localhost) ([139.165.201.107])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 30 Nov 2003 19:42:48 +0100
Date: Sun, 30 Nov 2003 19:42:22 +0100 (CET)
Message-Id: <20031130.194222.115499342.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
In-Reply-To: <1070213332.1310.148.camel@elsschot.wildebeest.org>
References: <1070213332.1310.148.camel@elsschot.wildebeest.org>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Sun_Nov_30_19_42_23_2003_114)--"
Content-Transfer-Encoding: 7bit
Subject: Re: GNU Classpath 0.07 created
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 19:44:56 -0000

----Security_Multipart(Sun_Nov_30_19_42_23_2003_114)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Sun, 30 Nov 2003 18:28:52 +0100
Mark Wielaard <mark@klomp.org> wrote:

> It is done. 0.07 has been tagged and created. Find it at:
> http://www.klomp.org/mark/classpath/

Congratulation to the team and thanks to Mark.

[...]

> And apologies to everyone that had outstanding patches that didn't
> make it for this release. Rest assured that those patches will be used
> for making the next 0.08 release (again in three months) even more
> perfect then 0.07 already is!

So the JB party at FOSDEM will be to kill 0.07... and 0.08 will be
GoldFingers! ;)

Cheers,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Sun_Nov_30_19_42_23_2003_114)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yjoR4vzFZu62tMIRAnJwAJ4wTGCvd0PgAiLMfNR8woqt96vigACdFaLe
4PoEWQu8bcW/6hDOWxnc/rU=
=k9P9
-----END PGP SIGNATURE-----

----Security_Multipart(Sun_Nov_30_19_42_23_2003_114)----



From MAILER-DAEMON Sun Nov 30 15:20:50 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQY3k-00078S-Kq
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 15:20:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQY3b-00074Q-4n
	for classpath@gnu.org; Sun, 30 Nov 2003 15:20:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQY30-0006tO-Ie
	for classpath@gnu.org; Sun, 30 Nov 2003 15:20:33 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQY29-0006gR-QN
	for classpath@gnu.org; Sun, 30 Nov 2003 15:19:09 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AQWsx-0006xK-PL
	for classpath@gnu.org; Sun, 30 Nov 2003 14:05:35 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AQWsS-0006Q0-00
	for <classpath@gnu.org>; Sun, 30 Nov 2003 20:05:04 +0100
Received: from mpiat2304.ag2.mpi-sb.mpg.de
	([139.19.20.93] helo=kaffe.org ident=topic)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AQWsO-0006PB-00; Sun, 30 Nov 2003 20:05:00 +0100
Message-ID: <3FCA3F5C.6080806@kaffe.org>
Date: Sun, 30 Nov 2003 20:05:00 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Chris Gray <chris@kiffer.eunet.be>
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
In-Reply-To: <200311292333.hATNX8SX041287@pigsty.cats.cradle>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org, Mark Wielaard <mark@klomp.org>
Subject: Revolution Action (was: Re: [Little Off Topic] Revolution is on ; ))
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 20:20:44 -0000

Hi Chris,

Chris Gray wrote:
> On Saturday 29 November 2003 13:48, Arnaud Vandyck wrote:
> 
> 
>>Why don't you try to make a keynote at the JavaPolis (maybe next year)
> 
> in the Open Source hall.
> 
> I'd love to. And the topic would be something like
>   Java is not a proprietary language: and here's the proof:
>   Classpath, IKVM, Jaos, Kaffe, Wonka, ...
> 
> However, frankly I suspect that the JavaPolis agenda is set by their 
> sponsors, and that some of these would not want to hear such a talk. So let's 
> by all means propose a paper or two for next year (like I already did this 
> year) _and then_ if it is refused, just convene our own alternative 
> conference at a nearby location.

Speaking of our own tracks, do we have an update on the idea of someone 
from GUUG's of doing a free software java conference, that popped up 
after there were several free java related abstract proposals at Linux 
Kongress?

> In the meantime, is there anything planned for FOSDEM?  E.g., an open-source 
> Java track? This could be an opportunity the thesis that the future of Java 
> lies with us, not with S*n.

Tromey is doing a talk on gcj. There is an embedded development track 
[1], that might be a good traget to place accompanying talks about Wonka 
& other free VMs targetting embedded systems. I haven't been able to 
figure out how to get a BOF session registered.

cheers,
dalibor topic

[1] http://www.fosdem.org/2004/index/dev_room_embedded




From MAILER-DAEMON Sun Nov 30 16:06:30 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQYlw-0004qu-Ud
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 16:06:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQYlu-0004qB-0Q
	for classpath@gnu.org; Sun, 30 Nov 2003 16:06:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQYlO-0004V4-7T
	for classpath@gnu.org; Sun, 30 Nov 2003 16:06:25 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQYlN-0004Uu-Ky
	for classpath@gnu.org; Sun, 30 Nov 2003 16:05:53 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hAUK5YSX042399;
	Sun, 30 Nov 2003 21:05:35 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311302005.hAUK5YSX042399@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Dalibor Topic <robilad@kaffe.org>
Date: Sun, 30 Nov 2003 21:05:34 +0100
X-Mailer: KMail [version 1.3]
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
	<3FCA3F5C.6080806@kaffe.org>
In-Reply-To: <3FCA3F5C.6080806@kaffe.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: classpath@gnu.org, Mark Wielaard <mark@klomp.org>
Subject: Re: Revolution Action (was: Re: [Little Off Topic] Revolution is on
	; ))
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 21:06:26 -0000

On Sunday 30 November 2003 20:05, Dalibor Topic wrote:
> Hi Chris,
>
> Chris Gray wrote:
> > On Saturday 29 November 2003 13:48, Arnaud Vandyck wrote:
> >>Why don't you try to make a keynote at the JavaPolis (maybe next year)
> >
> > in the Open Source hall.
> >
> > I'd love to. And the topic would be something like
> >   Java is not a proprietary language: and here's the proof:
> >   Classpath, IKVM, Jaos, Kaffe, Wonka, ...
> >
> > However, frankly I suspect that the JavaPolis agenda is set by their
> > sponsors, and that some of these would not want to hear such a talk. So
> > let's by all means propose a paper or two for next year (like I already
> > did this year) _and then_ if it is refused, just convene our own
> > alternative conference at a nearby location.
>
> Speaking of our own tracks, do we have an update on the idea of someone
> from GUUG's of doing a free software java conference, that popped up
> after there were several free java related abstract proposals at Linux
> Kongress?
>
> > In the meantime, is there anything planned for FOSDEM?  E.g., an
> > open-source Java track? This could be an opportunity the thesis that the
> > future of Java lies with us, not with S*n.
>
> Tromey is doing a talk on gcj. There is an embedded development track
> [1], that might be a good traget to place accompanying talks about Wonka
> & other free VMs targetting embedded systems. I haven't been able to
> figure out how to get a BOF session registered.
>
> cheers,
> dalibor topic
>
> [1] http://www.fosdem.org/2004/index/dev_room_embedded

-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Sun Nov 30 16:10:01 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQYpN-0005pE-65
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 16:10:01 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQYpK-0005nq-L8
	for classpath@gnu.org; Sun, 30 Nov 2003 16:09:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQYoj-0005ZE-DG
	for classpath@gnu.org; Sun, 30 Nov 2003 16:09:52 -0500
Received: from [213.49.17.120] (helo=pigsty.cats.cradle)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AQYoi-0005Y9-Dk
	for classpath@gnu.org; Sun, 30 Nov 2003 16:09:20 -0500
Received: from there (localhost.cats.cradle [127.0.0.1])
	by pigsty.cats.cradle (8.12.6/8.11.6) with SMTP id hAUK93SX042402;
	Sun, 30 Nov 2003 21:09:03 +0100 (CET)
	(envelope-from chris@kiffer.eunet.be)
Message-Id: <200311302009.hAUK93SX042402@pigsty.cats.cradle>
Content-Type: text/plain;
  charset="iso-8859-1"
From: Chris Gray <chris@kiffer.eunet.be>
To: Dalibor Topic <robilad@kaffe.org>
Date: Sun, 30 Nov 2003 21:09:03 +0100
X-Mailer: KMail [version 1.3]
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
	<3FCA3F5C.6080806@kaffe.org>
In-Reply-To: <3FCA3F5C.6080806@kaffe.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: classpath@gnu.org, Mark Wielaard <mark@klomp.org>
Subject: Re: Revolution Action (was: Re: [Little Off Topic] Revolution is on
	; ))
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 21:09:59 -0000

Ahem. Maybe first type and then send?

I'll talk to the organiser, Peter Vandenabeele, about this.  We should be 
able to get more than just a BOF.

Chris

On Sunday 30 November 2003 20:05, Dalibor Topic wrote:
> Hi Chris,
>
> Chris Gray wrote:
> > On Saturday 29 November 2003 13:48, Arnaud Vandyck wrote:
> >>Why don't you try to make a keynote at the JavaPolis (maybe next year)
> >
> > in the Open Source hall.
> >
> > I'd love to. And the topic would be something like
> >   Java is not a proprietary language: and here's the proof:
> >   Classpath, IKVM, Jaos, Kaffe, Wonka, ...
> >
> > However, frankly I suspect that the JavaPolis agenda is set by their
> > sponsors, and that some of these would not want to hear such a talk. So
> > let's by all means propose a paper or two for next year (like I already
> > did this year) _and then_ if it is refused, just convene our own
> > alternative conference at a nearby location.
>
> Speaking of our own tracks, do we have an update on the idea of someone
> from GUUG's of doing a free software java conference, that popped up
> after there were several free java related abstract proposals at Linux
> Kongress?
>
> > In the meantime, is there anything planned for FOSDEM?  E.g., an
> > open-source Java track? This could be an opportunity the thesis that the
> > future of Java lies with us, not with S*n.
>
> Tromey is doing a talk on gcj. There is an embedded development track
> [1], that might be a good traget to place accompanying talks about Wonka
> & other free VMs targetting embedded systems. I haven't been able to
> figure out how to get a BOF session registered.
>
> cheers,
> dalibor topic
>
> [1] http://www.fosdem.org/2004/index/dev_room_embedded

-- 
Chris Gray                                  /k/ Embedded Java Solutions
Embedded & Mobile Java, OSGi              http://www.kiffer.be/k/
chris.gray@kiffer.be                                      +32 477 599 703



From MAILER-DAEMON Sun Nov 30 16:43:21 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQZLd-0001Av-1k
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 16:43:21 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQZLa-0001Ag-Ef
	for classpath@gnu.org; Sun, 30 Nov 2003 16:43:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQZL4-00014m-HW
	for classpath@gnu.org; Sun, 30 Nov 2003 16:43:17 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQZL4-00014R-0x
	for classpath@gnu.org; Sun, 30 Nov 2003 16:42:46 -0500
Received: (qmail 15180 invoked by uid 504); 30 Nov 2003 21:41:18 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.575365 secs); 30 Nov 2003 20:41:18 -0000
Received: from unknown (HELO localhost) ([139.165.201.107])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 30 Nov 2003 21:41:18 +0100
Date: Sun, 30 Nov 2003 21:15:57 +0100 (CET)
Message-Id: <20031130.211557.85399884.arnaud.vandyck@ulg.ac.be>
To: classpath@gnu.org
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
In-Reply-To: <200311302009.hAUK93SX042402@pigsty.cats.cradle>
References: <200311292333.hATNX8SX041287@pigsty.cats.cradle>
	<3FCA3F5C.6080806@kaffe.org>
	<200311302009.hAUK93SX042402@pigsty.cats.cradle>
Organization: STE-Formations Informatiques, ULg
X-Fingerprint: 82F3 45D0 F1B2 D79E D0BE  5188 E2FC C566 EEB6 B4C2
X-URL: http://vbstefi60.fapse.ulg.ac.be/~arnaud/
X-Face: ".{A?<Dzy|V1IPZL0O-B-~G{n+`j%t7K$Y`:u[w54'>P>_0mS1E$Wn4RK&CR)_yvw`),0&;
	?-]upzJvA]->#pP:$si]X039T'Qrd}9t=!EstonSVE1F$dtgGsRC"lyQnP+H6/g:f^d:,0@)P#xCy9?MmW[8n{8B75hA_=]O7TRZ~r9SE6CL*xpR8k4'~!5B8"|u
X-Mailer: Mew version 4.0.60 on Emacs 21.3.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Multipart/Signed; protocol="application/pgp-signature";
	micalg=pgp-sha1;
	boundary="--Security_Multipart(Sun_Nov_30_21_15_57_2003_455)--"
Content-Transfer-Encoding: 7bit
Subject: Re: Revolution Action
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 21:43:19 -0000

----Security_Multipart(Sun_Nov_30_21_15_57_2003_455)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Sun, 30 Nov 2003 21:09:03 +0100
Chris Gray <chris@kiffer.eunet.be> wrote:

> I'll talk to the organiser, Peter Vandenabeele, about this.  We should
> be able to get more than just a BOF.

Great!

It also could be great to announce new releases from SableVM, gcj, kaffe
and classpath... all together ;)

(saturday 21 and sunday 22, february, 2003)

Cheers,

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

----Security_Multipart(Sun_Nov_30_21_15_57_2003_455)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/yk//4vzFZu62tMIRApDDAJ9UB1yjmS5KeygZtTm7bV5S7fFGWACdHgCV
Oy8hwT7b3BpjbAnpdBTbQjM=
=kpl9
-----END PGP SIGNATURE-----

----Security_Multipart(Sun_Nov_30_21_15_57_2003_455)----



From MAILER-DAEMON Sun Nov 30 17:09:36 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQZl1-0007yr-UY
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 17:09:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQZky-0007wn-Sv
	for classpath@gnu.org; Sun, 30 Nov 2003 17:09:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQZkS-0007Rr-GQ
	for classpath@gnu.org; Sun, 30 Nov 2003 17:09:31 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQZkR-0007QQ-Rj
	for classpath@gnu.org; Sun, 30 Nov 2003 17:09:00 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AQYmH-0000MT-00; Sun, 30 Nov 2003 22:06:49 +0100
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <3FCA3F5C.6080806@kaffe.org>
References: <20031129.134813.123657481.arnaud.vandyck@ulg.ac.be>
	<200311292333.hATNX8SX041287@pigsty.cats.cradle>
	<3FCA3F5C.6080806@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-k51+OJGHBaf5D8MVVMoL"
Message-Id: <1070226441.2377.200.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 30 Nov 2003 22:07:21 +0100
Cc: classpath@gnu.org
Subject: Re: Revolution Action (was: Re: [Little Off Topic] Revolution is
	on ; ))
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 22:09:33 -0000


--=-k51+OJGHBaf5D8MVVMoL
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2003-11-30 at 20:05, Dalibor Topic wrote:
> Speaking of our own tracks, do we have an update on the idea of someone=20
> from GUUG's of doing a free software java conference, that popped up=20
> after there were several free java related abstract proposals at Linux=20
> Kongress?

Not that I know. Patrik, Sascha and I did discuss the idea with one of
the Linux-Kongress organizers. We promised to email a couple of ideas
for this around (for example, put all the ideas from the abstracts that
we rejected for Linux-Kongress proper together) but we did not really
follow up on that. Sorry.

> > In the meantime, is there anything planned for FOSDEM?  E.g., an open-s=
ource=20
> > Java track? This could be an opportunity the thesis that the future of =
Java=20
> > lies with us, not with S*n.
>=20
> Tromey is doing a talk on gcj. There is an embedded development track=20
> [1], that might be a good traget to place accompanying talks about Wonka=20
> & other free VMs targetting embedded systems. I haven't been able to=20
> figure out how to get a BOF session registered.
> [...]
> [1] http://www.fosdem.org/2004/index/dev_room_embedded

The page itself says that it is for 27-10-2003 so I don't know if that
is current.

last week I did email info@fosdem.org as the contact page says, to see
if we could get a developer room, but I didn't hear back from them yet.
But if Chris knows one of the organizers that might be a better way to
contact them.

How many people want to attend (Brussels, Belgium, the weekend of 21-22
February 2004)? If I followed the messages and irc discussions correctly
then Arnaud, Chris, Tom, Dalibor, Stephane, Michael and myself will be
there at least.

Cheers,

Mark

--=-k51+OJGHBaf5D8MVVMoL
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/ylwJxVhZCJWr9QwRAokeAJ9gusIoACOA9l/kdYOTgM/K8R02FACfe4c0
6E/jw8h+MRkZz2nBGbS9nes=
=+1wi
-----END PGP SIGNATURE-----

--=-k51+OJGHBaf5D8MVVMoL--




From MAILER-DAEMON Sun Nov 30 17:14:09 2003
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AQZpR-0003We-96
	for mharc-classpath@gnu.org; Sun, 30 Nov 2003 17:14:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AQZpM-0003Px-RG
	for classpath@gnu.org; Sun, 30 Nov 2003 17:14:04 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AQZoa-0001id-RE
	for classpath@gnu.org; Sun, 30 Nov 2003 17:13:49 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AQZoX-0001Zc-9X
	for classpath@gnu.org; Sun, 30 Nov 2003 17:13:13 -0500
Received: from anis.telecom.uqam.ca (anis.telecom.uqam.ca [132.208.250.6])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id hAUL8RgP016412
	for <classpath@gnu.org>; Sun, 30 Nov 2003 16:08:30 -0500 (EST)
Received: from antivirus.uqam.ca ([127.0.0.1])
	by anis.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2003113016083009669
	for <classpath@gnu.org>; Sun, 30 Nov 2003 16:08:30 -0500
Received: from localhost (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	hAUL0UKB029908; Sun, 30 Nov 2003 16:00:30 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by localhost with esmtp (Exim 3.36 #1 (Debian))
	id 1AQYgB-0003U9-00; Sun, 30 Nov 2003 16:00:31 -0500
Message-ID: <3FCA5A6D.1050908@uqam.ca>
Date: Sun, 30 Nov 2003 16:00:29 -0500
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.5) Gecko/20031110 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
References: <200311292333.hATNX8SX041287@pigsty.cats.cradle>	<3FCA3F5C.6080806@kaffe.org>	<200311302009.hAUK93SX042402@pigsty.cats.cradle>
	<20031130.211557.85399884.arnaud.vandyck@ulg.ac.be>
In-Reply-To: <20031130.211557.85399884.arnaud.vandyck@ulg.ac.be>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Revolution Action
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 22:14:07 -0000

Arnaud Vandyck wrote:
> It also could be great to announce new releases from SableVM, gcj, kaffe
> and classpath... all together ;)

That would be great!  Is there any corporate sponsor, on this list, that would
like to finance the travel of one SableVM developer (gadek, belanger, or
myself) to attend FOSDEM?  We would put a big entry in the THANKS file of sablevm
in return. ;-)

Etienne


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/




